{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/43","repository_url":"https://api.github.com/repos/PowerShell/xComputerManagement","labels_url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/43/comments","events_url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/43/events","html_url":"https://github.com/PowerShell/xComputerManagement/pull/43","id":171554776,"number":43,"title":"Add Startup & OnLogon for Schedule Type","user":{"login":"DamianBis","id":1705580,"avatar_url":"https://avatars.githubusercontent.com/u/1705580?v=3","gravatar_id":"","url":"https://api.github.com/users/DamianBis","html_url":"https://github.com/DamianBis","followers_url":"https://api.github.com/users/DamianBis/followers","following_url":"https://api.github.com/users/DamianBis/following{/other_user}","gists_url":"https://api.github.com/users/DamianBis/gists{/gist_id}","starred_url":"https://api.github.com/users/DamianBis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamianBis/subscriptions","organizations_url":"https://api.github.com/users/DamianBis/orgs","repos_url":"https://api.github.com/users/DamianBis/repos","events_url":"https://api.github.com/users/DamianBis/events{/privacy}","received_events_url":"https://api.github.com/users/DamianBis/received_events","type":"User","site_admin":false},"labels":[{"id":203317497,"url":"https://api.github.com/repos/PowerShell/xComputerManagement/labels/cla-signed","name":"cla-signed","color":"207de5","default":false},{"id":427119349,"url":"https://api.github.com/repos/PowerShell/xComputerManagement/labels/needs%20review","name":"needs review","color":"99ff33","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-17T01:30:31Z","updated_at":"2016-11-18T02:11:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xComputerManagement/pulls/43","html_url":"https://github.com/PowerShell/xComputerManagement/pull/43","diff_url":"https://github.com/PowerShell/xComputerManagement/pull/43.diff","patch_url":"https://github.com/PowerShell/xComputerManagement/pull/43.patch"},"body":"#34\n\nI made this for my own use. can probably be incorporated without any issues. Had to parse the XML to deal with triggers as it's not possible using Get-ScheduledTask or Get-ScheduledTaskTrigger to get the information regarding the onstartup and onlogon\n\n<!-- Reviewable:start -->\n\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xcomputermanagement/43)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/comments/261429734","html_url":"https://github.com/PowerShell/xComputerManagement/pull/43#issuecomment-261429734","issue_url":"https://api.github.com/repos/PowerShell/xComputerManagement/issues/43","id":261429734,"user":{"login":"kwirkykat","id":6372220,"avatar_url":"https://avatars.githubusercontent.com/u/6372220?v=3","gravatar_id":"","url":"https://api.github.com/users/kwirkykat","html_url":"https://github.com/kwirkykat","followers_url":"https://api.github.com/users/kwirkykat/followers","following_url":"https://api.github.com/users/kwirkykat/following{/other_user}","gists_url":"https://api.github.com/users/kwirkykat/gists{/gist_id}","starred_url":"https://api.github.com/users/kwirkykat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwirkykat/subscriptions","organizations_url":"https://api.github.com/users/kwirkykat/orgs","repos_url":"https://api.github.com/users/kwirkykat/repos","events_url":"https://api.github.com/users/kwirkykat/events{/privacy}","received_events_url":"https://api.github.com/users/kwirkykat/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T02:11:34Z","updated_at":"2016-11-18T02:11:34Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[DSCResources/MSFT_xScheduledTask/MSFT_xScheduledTask.psm1, line 240 at r4](https://reviewable.io:443/reviews/powershell/xcomputermanagement/43#-KWp9i8j5GlEsRljXAgl:-KWp9i8j5GlEsRljXAgm:bgaljle) ([raw file](https://github.com/powershell/xcomputermanagement/blob/89a726806ddc33d861164df9e7b6c109ed883c88/DSCResources/MSFT_xScheduledTask/MSFT_xScheduledTask.psm1#L240)):*\n> ```PowerShell\n>             \"Minutes\" \n>             { \n>                 $repeatAt = New-TimeSpan -Minutes $RepeatInterval\n> ```\n\nWhat happens if $RepeatInterval is not provided?\n\n---\n\n*[DSCResources/MSFT_xScheduledTask/MSFT_xScheduledTask.psm1, line 413 at r4](https://reviewable.io:443/reviews/powershell/xcomputermanagement/43#-KWobHrRHQ58yGgvw8jU:-KWobHrRHQ58yGgvw8jV:b-do2m56) ([raw file](https://github.com/powershell/xcomputermanagement/blob/89a726806ddc33d861164df9e7b6c109ed883c88/DSCResources/MSFT_xScheduledTask/MSFT_xScheduledTask.psm1#L413)):*\n> ```PowerShell\n>             return $false \n>         }\n>         if ($RepeatInterval -ne $currentValues.RepeatInterval) \n> ```\n\nThis parameter should now only get checked when it is provided.\n\n```powershell\nif ($PSBoundParameters.ContainsKey('RepeatInterval') -and $RepeatInterval -ne $currentValues.RepeatInterval)\n```\n\n---\n\n*[Tests/Unit/MSFT_xScheduledTask.Tests.ps1, line 251 at r4](https://reviewable.io:443/reviews/powershell/xcomputermanagement/43#-KWpBwAeLGDdJhCOoW5h:-KWpBwAeLGDdJhCOoW5i:b-jpbjz0) ([raw file](https://github.com/powershell/xcomputermanagement/blob/89a726806ddc33d861164df9e7b6c109ed883c88/Tests/Unit/MSFT_xScheduledTask.Tests.ps1#L251)):*\n> ```PowerShell\n>                     Test-TargetResource @testParams | Should Be $false\n>                 }\n>             }\n> ```\n\nCan you also add some tests for the OnLogon case?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/xcomputermanagement/43)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kwirkykat"}}