{"action":"created","issue":{"url":"https://api.github.com/repos/deis/controller/issues/704","repository_url":"https://api.github.com/repos/deis/controller","labels_url":"https://api.github.com/repos/deis/controller/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/deis/controller/issues/704/comments","events_url":"https://api.github.com/repos/deis/controller/issues/704/events","html_url":"https://github.com/deis/controller/pull/704","id":152913620,"number":704,"title":"feat(scheduler): add 10 mins to deploy timeout if image pull is slow","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deis/controller/labels/awaiting%20review","name":"awaiting review","color":"e11d21"},{"url":"https://api.github.com/repos/deis/controller/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/deis/controller/labels/k8s","name":"k8s","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller/milestones/5","html_url":"https://github.com/deis/controller/milestones/v2.0-beta4","labels_url":"https://api.github.com/repos/deis/controller/milestones/5/labels","id":1682306,"number":5,"title":"v2.0-beta4","description":null,"creator":{"login":"slack","id":28873,"avatar_url":"https://avatars.githubusercontent.com/u/28873?v=3","gravatar_id":"","url":"https://api.github.com/users/slack","html_url":"https://github.com/slack","followers_url":"https://api.github.com/users/slack/followers","following_url":"https://api.github.com/users/slack/following{/other_user}","gists_url":"https://api.github.com/users/slack/gists{/gist_id}","starred_url":"https://api.github.com/users/slack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack/subscriptions","organizations_url":"https://api.github.com/users/slack/orgs","repos_url":"https://api.github.com/users/slack/repos","events_url":"https://api.github.com/users/slack/events{/privacy}","received_events_url":"https://api.github.com/users/slack/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":31,"state":"open","created_at":"2016-04-04T15:55:20Z","updated_at":"2016-05-04T16:55:53Z","due_on":"2016-05-11T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-05-04T02:00:22Z","updated_at":"2016-05-04T17:21:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/controller/pulls/704","html_url":"https://github.com/deis/controller/pull/704","diff_url":"https://github.com/deis/controller/pull/704.diff","patch_url":"https://github.com/deis/controller/pull/704.patch"},"body":"## Summary of Changes\r\n\r\nAfter a minute of pulling the image (considered pretty high) then additionl 10 minutes are added on top.\r\nThis will help when the cache is cold. Slugrunner and generally big images are being used (1GB or higher generally)\r\n\r\n## Issue(s) that this PR Closes\r\n\r\nFixes #459\r\n\r\n## Associated [End To End Test](https://github.com/deis/workflow-e2e) PR(s)\r\n\r\nNo e2e for this as it would slow down e2e a lot. From time to time e2e will hit this tho if GKE is being slow\r\n\r\n## Testing Instructions\r\n\r\nThis is a hard one to test due to the need for a big image\r\n\r\n1. Create a Deis Cluster\r\n2. Register an app\r\n3. Run `docker rmi $(docker images -q quay.io/deisci/slugrunner)` against the k8s master\r\n4. Run `make deploy` with this branch\r\n5. `git push` an app\r\n\r\nAlternative is to modify the code (locally) and doing a local git commit to Controller itself (for `make deploy`) and changing `seconds = 60` to `seconds = 2` in `scheduler/__init__.py` \r\n\r\nAlso, please provide a description of the desired result after the tester completes the above steps.\r\n\r\n1. The app called \"abcd\" should be deployed\r\n2. Monitor the controller logs for `Kubernetes has been pulling the image for 60 seconds`"},"comment":{"url":"https://api.github.com/repos/deis/controller/issues/comments/216938248","html_url":"https://github.com/deis/controller/pull/704#issuecomment-216938248","issue_url":"https://api.github.com/repos/deis/controller/issues/704","id":216938248,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T17:21:23Z","updated_at":"2016-05-04T17:21:23Z","body":"## [Current coverage][cc-pull] is **85.04%**\n> Merging [#704][cc-pull] into [master][cc-base-branch] will decrease coverage by **-1.18%**\n\n```diff\n@@             master       #704   diff @@\n==========================================\n  Files            29         29          \n  Lines          2510       2546    +36   \n  Methods           0          0          \n  Messages          0          0          \n  Branches        391        399     +8   \n==========================================\n+ Hits           2164       2165     +1   \n- Misses          237        266    +29   \n- Partials        109        115     +6   \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [65b736f...d585286][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/deis/controller/compare/65b736fd3db61e0301e5f82e39fd71e80ea22239...d585286c8ceb6e569cecaf4fe681b5174f40db3d\n[cc-pull]: https://codecov.io/gh/deis/controller/pull/704?src=pr"}}