{"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/82988089","pull_request_review_id":3856485,"id":82988089,"diff_hunk":"@@ -66,6 +77,59 @@ public void start_server() throws IOException {\n         verify(server).start();\n     }\n \n+    @SuppressWarnings(\"MagicNumber\")\n+    @Test\n+    public void add_and_remove_parameters_form_builder() {\n+        final GrpcContainer.Builder builder = GrpcContainer.newBuilder()\n+                                                           .setPort(8080)\n+                                                           .setPort(60);\n+        assertEquals(60, builder.getPort());\n+\n+        int count = 3;\n+        final List<ServerServiceDefinition> definitions = new ArrayList<>(count);\n+\n+        for (int i = 0; i < count; i++) {\n+            final BindableService mockService = mock(BindableService.class);\n+            final ServerServiceDefinition mockDefinition = ServerServiceDefinition\n+                    .builder(String.format(\"service-%s\", i))\n+                    .build();\n+            when(mockService.bindService()).thenReturn(mockDefinition);\n+            definitions.add(mockDefinition);\n+\n+            builder.addService(mockService);\n+        }\n+\n+        count--;\n+        builder.removeService(definitions.get(count));\n+\n+        final Set<ServerServiceDefinition> serviceSet = builder.getServices();\n+        assertSize(count, serviceSet);\n+\n+        final GrpcContainer container = builder.build();\n+        assertNotNull(container);\n+    }\n+\n+    @Test\n+    public void add_shutdown_hook_to_runtime() throws NoSuchFieldException, IllegalAccessException, IOException {\n+        final Class<Runtime> runtimeClass = Runtime.class;\n+        // private static Runtime currentRuntime","path":"server/src/test/java/org/spine3/server/transport/GrpcContainerShould.java","position":88,"original_position":88,"commit_id":"3d02a988ad12e45e6441352d4621500ef081f6d2","original_commit_id":"3d02a988ad12e45e6441352d4621500ef081f6d2","user":{"login":"dmdashenkov","id":18305364,"avatar_url":"https://avatars.githubusercontent.com/u/18305364?v=3","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false},"body":"This is to show the field signature. Taken from `java.lang.Runtime`.","created_at":"2016-10-12T11:44:39Z","updated_at":"2016-10-12T11:44:39Z","html_url":"https://github.com/SpineEventEngine/core-java/pull/197#discussion_r82988089","pull_request_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/82988089"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/197#discussion_r82988089"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197","id":88992807,"html_url":"https://github.com/SpineEventEngine/core-java/pull/197","diff_url":"https://github.com/SpineEventEngine/core-java/pull/197.diff","patch_url":"https://github.com/SpineEventEngine/core-java/pull/197.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/197","number":197,"state":"open","locked":false,"title":"gRPC container coverage improvement","user":{"login":"dmdashenkov","id":18305364,"avatar_url":"https://avatars.githubusercontent.com/u/18305364?v=3","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false},"body":" - `Builder` methods test\r\n - `#addShutdownHook` test","created_at":"2016-10-12T10:42:51Z","updated_at":"2016-10-12T11:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"armiol","id":82468,"avatar_url":"https://avatars.githubusercontent.com/u/82468?v=3","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false},"assignees":[{"login":"armiol","id":82468,"avatar_url":"https://avatars.githubusercontent.com/u/82468?v=3","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/197/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/3d02a988ad12e45e6441352d4621500ef081f6d2","head":{"label":"SpineEventEngine:grpc-container-cov","ref":"grpc-container-cov","sha":"3d02a988ad12e45e6441352d4621500ef081f6d2","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"name":"core-java","full_name":"SpineEventEngine/core-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2016-09-09T16:53:47Z","pushed_at":"2016-10-12T10:42:51Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":6003,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"SpineEventEngine:stand-in-memory","ref":"stand-in-memory","sha":"032e28e468161b60bf88174137d3c104534cbc4f","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"name":"core-java","full_name":"SpineEventEngine/core-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2016-09-09T16:53:47Z","pushed_at":"2016-10-12T10:42:51Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":6003,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/197"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/197"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/3d02a988ad12e45e6441352d4621500ef081f6d2"}}}}
{"actor":{"display_login":"dmdashenkov"}}