{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/comments/56028540","id":56028540,"diff_hunk":"@@ -0,0 +1,34 @@\n+package com.alliander.osgp.domain.core.valueobjects.smartmetering;\n+\n+import java.math.BigDecimal;\n+\n+/**\n+ * A metervalue with its standardized osgp unit\n+ *\n+ *\n+ */\n+public class OsgpMeterValue {\n+\n+    public OsgpMeterValue(final BigDecimal value, final OsgpUnit osgpUnit) {\n+        super();\n+        this.value = value;\n+        this.osgpUnit = osgpUnit;\n+    }\n+\n+    private final BigDecimal value;\n+    private final OsgpUnit osgpUnit;","path":"osgp-domain-core/src/main/java/com/alliander/osgp/domain/core/valueobjects/smartmetering/OsgpMeterValue.java","position":19,"original_position":19,"commit_id":"30b4aad54f2f45ee10acd29f7ec35141836c6979","original_commit_id":"30b4aad54f2f45ee10acd29f7ec35141836c6979","user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars.githubusercontent.com/u/12208121?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Move this variable to comply with Java Code Conventions. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1213)\n","created_at":"2016-03-14T16:23:50Z","updated_at":"2016-03-14T16:23:50Z","html_url":"https://github.com/OSGP/Platform/pull/364#discussion_r56028540","pull_request_url":"https://api.github.com/repos/OSGP/Platform/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments/56028540"},"html":{"href":"https://github.com/OSGP/Platform/pull/364#discussion_r56028540"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/364","id":62219801,"html_url":"https://github.com/OSGP/Platform/pull/364","diff_url":"https://github.com/OSGP/Platform/pull/364.diff","patch_url":"https://github.com/OSGP/Platform/pull/364.patch","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/364","number":364,"state":"open","locked":false,"title":"SLIM-247 less strict xsd regarding fraction and unit, plus necessary adaptations","user":{"login":"eduarddrenth","id":10200360,"avatar_url":"https://avatars.githubusercontent.com/u/10200360?v=3","gravatar_id":"","url":"https://api.github.com/users/eduarddrenth","html_url":"https://github.com/eduarddrenth","followers_url":"https://api.github.com/users/eduarddrenth/followers","following_url":"https://api.github.com/users/eduarddrenth/following{/other_user}","gists_url":"https://api.github.com/users/eduarddrenth/gists{/gist_id}","starred_url":"https://api.github.com/users/eduarddrenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduarddrenth/subscriptions","organizations_url":"https://api.github.com/users/eduarddrenth/orgs","repos_url":"https://api.github.com/users/eduarddrenth/repos","events_url":"https://api.github.com/users/eduarddrenth/events{/privacy}","received_events_url":"https://api.github.com/users/eduarddrenth/received_events","type":"User","site_admin":false},"body":"xsd adapted, only MeterValue, no more EMeterValue / GMeterValue\r\nno more fraction_digits\r\nno more fixed value for unit attribute\r\nno more validations on translated unit","created_at":"2016-03-09T12:13:46Z","updated_at":"2016-03-14T16:23:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"410147ceda0918f19f3a33499947ce4a6469b398","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Platform/pulls/364/commits","review_comments_url":"https://api.github.com/repos/OSGP/Platform/pulls/364/comments","review_comment_url":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/364/comments","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/30b4aad54f2f45ee10acd29f7ec35141836c6979","head":{"label":"OSGP:feat_convert_reads_to_uniform_unit","ref":"feat_convert_reads_to_uniform_unit","sha":"30b4aad54f2f45ee10acd29f7ec35141836c6979","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2016-03-08T10:38:36Z","pushed_at":"2016-03-14T16:12:58Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":null,"size":25662,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":28,"forks":2,"open_issues":28,"watchers":7,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"ab26b7d94bdd98f5cb8b786921010d13553fdb3b","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2016-03-08T10:38:36Z","pushed_at":"2016-03-14T16:12:58Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":null,"size":25662,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":28,"forks":2,"open_issues":28,"watchers":7,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/364"},"html":{"href":"https://github.com/OSGP/Platform/pull/364"},"issue":{"href":"https://api.github.com/repos/OSGP/Platform/issues/364"},"comments":{"href":"https://api.github.com/repos/OSGP/Platform/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Platform/statuses/30b4aad54f2f45ee10acd29f7ec35141836c6979"}}}}