{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/trackler/pulls/comments/89686748","pull_request_review_id":10227985,"id":89686748,"diff_hunk":"@@ -4,41 +4,109 @@\n class ProblemTest < Minitest::Test\n   def test_existing_problem\n     problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n-\n     assert problem.exists?, \"hello world files not found in the metadata dir\"\n+  end\n+\n+  def test_slug\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n     assert_equal 'hello-world', problem.slug\n+  end\n+\n+  def test_name\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n     assert_equal 'Hello World', problem.name\n+  end\n+\n+  def test_blurb\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n     assert_equal 'Oh, hello.', problem.blurb\n+  end\n+\n+  def test_description\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n     assert_equal \"* hello\\n* hello again\\n\", problem.description\n+  end\n+\n+  def test_metadata_url\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n+    assert_equal 'https://github.com/exercism/x-common/blob/master/exercises/hello-world/metadata.yml', problem.metadata_url\n+  end\n+\n+  def test_yaml_url_deprecated\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n     assert_equal 'https://github.com/exercism/x-common/blob/master/exercises/hello-world/metadata.yml', problem.yaml_url\n+  end\n+\n+  def test_description_url\n+    problem = Trackler::Problem.new('hello-world', FIXTURE_PATH)\n+    assert_equal 'https://github.com/exercism/x-common/blob/master/exercises/hello-world/description.md', problem.description_url\n+  end\n+\n+  def test_md_url_deprecated","path":"test/trackler/problem_test.rb","position":43,"original_position":43,"commit_id":"e980de42131f4189f3526e1f1be051ab4ed3fe52","original_commit_id":"e980de42131f4189f3526e1f1be051ab4ed3fe52","user":{"login":"Insti","id":5096681,"avatar_url":"https://avatars.githubusercontent.com/u/5096681?v=3","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"body":"It's the method, I'll clarify the test names, thanks for pointing out the ambiguity.\r\n","created_at":"2016-11-27T10:10:31Z","updated_at":"2016-11-27T10:10:31Z","html_url":"https://github.com/exercism/trackler/pull/6#discussion_r89686748","pull_request_url":"https://api.github.com/repos/exercism/trackler/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/exercism/trackler/pulls/comments/89686748"},"html":{"href":"https://github.com/exercism/trackler/pull/6#discussion_r89686748"},"pull_request":{"href":"https://api.github.com/repos/exercism/trackler/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/trackler/pulls/6","id":94603163,"html_url":"https://github.com/exercism/trackler/pull/6","diff_url":"https://github.com/exercism/trackler/pull/6.diff","patch_url":"https://github.com/exercism/trackler/pull/6.patch","issue_url":"https://api.github.com/repos/exercism/trackler/issues/6","number":6,"state":"open","locked":false,"title":"Refactor Problem class","user":{"login":"Insti","id":5096681,"avatar_url":"https://avatars.githubusercontent.com/u/5096681?v=3","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"body":"- Removed deprecated file locations from problem data file search locations.\r\n- 100% test coverage. (up from 97.56%)\r\n- Improved naming.\r\n- Extracted some intention-revealing methods.\r\n\r\nFor example:\r\n```ruby\r\n     def exists?\r\n       !!md && !!yaml\r\n    end\r\n```\r\nBecomes:\r\n```ruby\r\n     def exists?\r\n       description_exists? && yaml_exists?\r\n     end\r\n```\r\n\r\n- Removed unneeded complexity by simplifying methods. (particularly: `source_markdown`)\r\n\r\n**Flog scores:**\r\nBefore (this was pretty good already.):\r\n```\r\n$ flog lib/trackler/problem.rb \r\n   111.2: flog total\r\n     7.0: flog/method average\r\n```\r\nAfter:\r\n```\r\n$ flog lib/trackler/problem.rb \r\n    99.6: flog total\r\n     4.0: flog/method average\r\n```\r\n","created_at":"2016-11-21T12:08:49Z","updated_at":"2016-11-27T10:10:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49747b5662f07476ec760437e062dcdf95ed472d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/trackler/pulls/6/commits","review_comments_url":"https://api.github.com/repos/exercism/trackler/pulls/6/comments","review_comment_url":"https://api.github.com/repos/exercism/trackler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/trackler/issues/6/comments","statuses_url":"https://api.github.com/repos/exercism/trackler/statuses/e980de42131f4189f3526e1f1be051ab4ed3fe52","head":{"label":"Insti:problem_refactoring","ref":"problem_refactoring","sha":"e980de42131f4189f3526e1f1be051ab4ed3fe52","user":{"login":"Insti","id":5096681,"avatar_url":"https://avatars.githubusercontent.com/u/5096681?v=3","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"repo":{"id":73544328,"name":"trackler","full_name":"Insti/trackler","owner":{"login":"Insti","id":5096681,"avatar_url":"https://avatars.githubusercontent.com/u/5096681?v=3","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Insti/trackler","description":"Bundle the exercism tracks into one library.","fork":true,"url":"https://api.github.com/repos/Insti/trackler","forks_url":"https://api.github.com/repos/Insti/trackler/forks","keys_url":"https://api.github.com/repos/Insti/trackler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Insti/trackler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Insti/trackler/teams","hooks_url":"https://api.github.com/repos/Insti/trackler/hooks","issue_events_url":"https://api.github.com/repos/Insti/trackler/issues/events{/number}","events_url":"https://api.github.com/repos/Insti/trackler/events","assignees_url":"https://api.github.com/repos/Insti/trackler/assignees{/user}","branches_url":"https://api.github.com/repos/Insti/trackler/branches{/branch}","tags_url":"https://api.github.com/repos/Insti/trackler/tags","blobs_url":"https://api.github.com/repos/Insti/trackler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Insti/trackler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Insti/trackler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Insti/trackler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Insti/trackler/statuses/{sha}","languages_url":"https://api.github.com/repos/Insti/trackler/languages","stargazers_url":"https://api.github.com/repos/Insti/trackler/stargazers","contributors_url":"https://api.github.com/repos/Insti/trackler/contributors","subscribers_url":"https://api.github.com/repos/Insti/trackler/subscribers","subscription_url":"https://api.github.com/repos/Insti/trackler/subscription","commits_url":"https://api.github.com/repos/Insti/trackler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Insti/trackler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Insti/trackler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Insti/trackler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Insti/trackler/contents/{+path}","compare_url":"https://api.github.com/repos/Insti/trackler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Insti/trackler/merges","archive_url":"https://api.github.com/repos/Insti/trackler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Insti/trackler/downloads","issues_url":"https://api.github.com/repos/Insti/trackler/issues{/number}","pulls_url":"https://api.github.com/repos/Insti/trackler/pulls{/number}","milestones_url":"https://api.github.com/repos/Insti/trackler/milestones{/number}","notifications_url":"https://api.github.com/repos/Insti/trackler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Insti/trackler/labels{/name}","releases_url":"https://api.github.com/repos/Insti/trackler/releases{/id}","deployments_url":"https://api.github.com/repos/Insti/trackler/deployments","created_at":"2016-11-12T09:48:15Z","updated_at":"2016-11-12T09:48:16Z","pushed_at":"2016-11-26T20:38:26Z","git_url":"git://github.com/Insti/trackler.git","ssh_url":"git@github.com:Insti/trackler.git","clone_url":"https://github.com/Insti/trackler.git","svn_url":"https://github.com/Insti/trackler","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"f9c9ee730f4007094b3c1c01e3123f0d3237e7cc","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":67301711,"name":"trackler","full_name":"exercism/trackler","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/trackler","description":"Bundle the exercism tracks into one library.","fork":false,"url":"https://api.github.com/repos/exercism/trackler","forks_url":"https://api.github.com/repos/exercism/trackler/forks","keys_url":"https://api.github.com/repos/exercism/trackler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/trackler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/trackler/teams","hooks_url":"https://api.github.com/repos/exercism/trackler/hooks","issue_events_url":"https://api.github.com/repos/exercism/trackler/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/trackler/events","assignees_url":"https://api.github.com/repos/exercism/trackler/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/trackler/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/trackler/tags","blobs_url":"https://api.github.com/repos/exercism/trackler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/trackler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/trackler/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/trackler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/trackler/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/trackler/languages","stargazers_url":"https://api.github.com/repos/exercism/trackler/stargazers","contributors_url":"https://api.github.com/repos/exercism/trackler/contributors","subscribers_url":"https://api.github.com/repos/exercism/trackler/subscribers","subscription_url":"https://api.github.com/repos/exercism/trackler/subscription","commits_url":"https://api.github.com/repos/exercism/trackler/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/trackler/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/trackler/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/trackler/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/trackler/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/trackler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/trackler/merges","archive_url":"https://api.github.com/repos/exercism/trackler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/trackler/downloads","issues_url":"https://api.github.com/repos/exercism/trackler/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/trackler/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/trackler/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/trackler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/trackler/labels{/name}","releases_url":"https://api.github.com/repos/exercism/trackler/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/trackler/deployments","created_at":"2016-09-03T17:03:13Z","updated_at":"2016-11-26T20:41:00Z","pushed_at":"2016-11-26T20:38:27Z","git_url":"git://github.com/exercism/trackler.git","ssh_url":"git@github.com:exercism/trackler.git","clone_url":"https://github.com/exercism/trackler.git","svn_url":"https://github.com/exercism/trackler","homepage":null,"size":144,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/trackler/pulls/6"},"html":{"href":"https://github.com/exercism/trackler/pull/6"},"issue":{"href":"https://api.github.com/repos/exercism/trackler/issues/6"},"comments":{"href":"https://api.github.com/repos/exercism/trackler/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/trackler/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/trackler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/trackler/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/trackler/statuses/e980de42131f4189f3526e1f1be051ab4ed3fe52"}}}}
{"actor":{"display_login":"Insti"}}