{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/comments/75407398","id":75407398,"diff_hunk":"@@ -58,14 +57,17 @@ public void setupMocksAndView() {\n         // inject the mocks in the test the initMocks method needs to be called.\n         MockitoAnnotations.initMocks(this);\n \n+        mSchedulerProvider = new ImmediateSchedulerProvider();","path":"todoapp/app/src/test/java/com/example/android/architecture/blueprints/todoapp/addedittask/AddEditTaskPresenterTest.java","position":44,"original_position":44,"commit_id":"9d2ce54766337c19cba8a741f63ca9d12b594d7b","original_commit_id":"9d2ce54766337c19cba8a741f63ca9d12b594d7b","user":{"login":"startthread","id":2934965,"avatar_url":"https://avatars.githubusercontent.com/u/2934965?v=3","gravatar_id":"","url":"https://api.github.com/users/startthread","html_url":"https://github.com/startthread","followers_url":"https://api.github.com/users/startthread/followers","following_url":"https://api.github.com/users/startthread/following{/other_user}","gists_url":"https://api.github.com/users/startthread/gists{/gist_id}","starred_url":"https://api.github.com/users/startthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startthread/subscriptions","organizations_url":"https://api.github.com/users/startthread/orgs","repos_url":"https://api.github.com/users/startthread/repos","events_url":"https://api.github.com/users/startthread/events{/privacy}","received_events_url":"https://api.github.com/users/startthread/received_events","type":"User","site_admin":false},"body":"For testing, I think it would be better if schedulers are provided through `@Rule` and RxJava hooks.\r\nShould create TestRule and use rule in AddEditTaskPresenterTest.\r\n\r\n```\r\npublic class RxJavaResetRule implements TestRule {\r\n\r\n    @Override\r\n    public Statement apply(final Statement base, Description description) {\r\n\r\n        return new Statement() {\r\n            @Override\r\n            public void evaluate() throws Throwable {\r\n\r\n                RxJavaHooks.setOnComputationScheduler(new Func1<Scheduler, Scheduler>() {\r\n                    @Override\r\n                    public Scheduler call(Scheduler scheduler) {\r\n                        return Schedulers.immediate();\r\n                    }\r\n                });\r\n                \r\n\r\n                base.evaluate();\r\n\r\n                RxJavaHooks.setOnComputationScheduler(null);\r\n            }\r\n        };\r\n    }\r\n}```","created_at":"2016-08-18T23:28:58Z","updated_at":"2016-08-18T23:28:58Z","html_url":"https://github.com/googlesamples/android-architecture/pull/148#discussion_r75407398","pull_request_url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/comments/75407398"},"html":{"href":"https://github.com/googlesamples/android-architecture/pull/148#discussion_r75407398"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148","id":81843054,"html_url":"https://github.com/googlesamples/android-architecture/pull/148","diff_url":"https://github.com/googlesamples/android-architecture/pull/148.diff","patch_url":"https://github.com/googlesamples/android-architecture/pull/148.patch","issue_url":"https://api.github.com/repos/googlesamples/android-architecture/issues/148","number":148,"state":"closed","locked":false,"title":"AddEditTaskPresenter - implementation and tests finished","user":{"login":"florina-muntenescu","id":2998890,"avatar_url":"https://avatars.githubusercontent.com/u/2998890?v=3","gravatar_id":"","url":"https://api.github.com/users/florina-muntenescu","html_url":"https://github.com/florina-muntenescu","followers_url":"https://api.github.com/users/florina-muntenescu/followers","following_url":"https://api.github.com/users/florina-muntenescu/following{/other_user}","gists_url":"https://api.github.com/users/florina-muntenescu/gists{/gist_id}","starred_url":"https://api.github.com/users/florina-muntenescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florina-muntenescu/subscriptions","organizations_url":"https://api.github.com/users/florina-muntenescu/orgs","repos_url":"https://api.github.com/users/florina-muntenescu/repos","events_url":"https://api.github.com/users/florina-muntenescu/events{/privacy}","received_events_url":"https://api.github.com/users/florina-muntenescu/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-18T16:05:57Z","updated_at":"2016-08-18T23:28:58Z","closed_at":"2016-08-18T16:09:41Z","merged_at":"2016-08-18T16:09:41Z","merge_commit_sha":"2dff93633e37bd1cdbc834b164b33d84cc8a0a79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148/commits","review_comments_url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148/comments","review_comment_url":"https://api.github.com/repos/googlesamples/android-architecture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/android-architecture/issues/148/comments","statuses_url":"https://api.github.com/repos/googlesamples/android-architecture/statuses/9d2ce54766337c19cba8a741f63ca9d12b594d7b","head":{"label":"florina-muntenescu:dev-todo-mvp-rxjava-fix-added-task","ref":"dev-todo-mvp-rxjava-fix-added-task","sha":"9d2ce54766337c19cba8a741f63ca9d12b594d7b","user":{"login":"florina-muntenescu","id":2998890,"avatar_url":"https://avatars.githubusercontent.com/u/2998890?v=3","gravatar_id":"","url":"https://api.github.com/users/florina-muntenescu","html_url":"https://github.com/florina-muntenescu","followers_url":"https://api.github.com/users/florina-muntenescu/followers","following_url":"https://api.github.com/users/florina-muntenescu/following{/other_user}","gists_url":"https://api.github.com/users/florina-muntenescu/gists{/gist_id}","starred_url":"https://api.github.com/users/florina-muntenescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florina-muntenescu/subscriptions","organizations_url":"https://api.github.com/users/florina-muntenescu/orgs","repos_url":"https://api.github.com/users/florina-muntenescu/repos","events_url":"https://api.github.com/users/florina-muntenescu/events{/privacy}","received_events_url":"https://api.github.com/users/florina-muntenescu/received_events","type":"User","site_admin":false},"repo":{"id":65200498,"name":"android-architecture","full_name":"florina-muntenescu/android-architecture","owner":{"login":"florina-muntenescu","id":2998890,"avatar_url":"https://avatars.githubusercontent.com/u/2998890?v=3","gravatar_id":"","url":"https://api.github.com/users/florina-muntenescu","html_url":"https://github.com/florina-muntenescu","followers_url":"https://api.github.com/users/florina-muntenescu/followers","following_url":"https://api.github.com/users/florina-muntenescu/following{/other_user}","gists_url":"https://api.github.com/users/florina-muntenescu/gists{/gist_id}","starred_url":"https://api.github.com/users/florina-muntenescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florina-muntenescu/subscriptions","organizations_url":"https://api.github.com/users/florina-muntenescu/orgs","repos_url":"https://api.github.com/users/florina-muntenescu/repos","events_url":"https://api.github.com/users/florina-muntenescu/events{/privacy}","received_events_url":"https://api.github.com/users/florina-muntenescu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/florina-muntenescu/android-architecture","description":"A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.","fork":true,"url":"https://api.github.com/repos/florina-muntenescu/android-architecture","forks_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/forks","keys_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/teams","hooks_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/hooks","issue_events_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/issues/events{/number}","events_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/events","assignees_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/assignees{/user}","branches_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/branches{/branch}","tags_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/tags","blobs_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/git/refs{/sha}","trees_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/statuses/{sha}","languages_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/languages","stargazers_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/stargazers","contributors_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/contributors","subscribers_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/subscribers","subscription_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/subscription","commits_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/commits{/sha}","git_commits_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/git/commits{/sha}","comments_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/comments{/number}","issue_comment_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/issues/comments{/number}","contents_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/contents/{+path}","compare_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/merges","archive_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/downloads","issues_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/issues{/number}","pulls_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/pulls{/number}","milestones_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/milestones{/number}","notifications_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/labels{/name}","releases_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/releases{/id}","deployments_url":"https://api.github.com/repos/florina-muntenescu/android-architecture/deployments","created_at":"2016-08-08T11:56:09Z","updated_at":"2016-08-08T11:22:29Z","pushed_at":"2016-08-18T16:15:07Z","git_url":"git://github.com/florina-muntenescu/android-architecture.git","ssh_url":"git@github.com:florina-muntenescu/android-architecture.git","clone_url":"https://github.com/florina-muntenescu/android-architecture.git","svn_url":"https://github.com/florina-muntenescu/android-architecture","homepage":"","size":7140,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlesamples:dev-todo-mvp-rxjava","ref":"dev-todo-mvp-rxjava","sha":"7ebb535dfc0ae33a7df721c073ebe37f1efc75f8","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":51148780,"name":"android-architecture","full_name":"googlesamples/android-architecture","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-architecture","description":"A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.","fork":false,"url":"https://api.github.com/repos/googlesamples/android-architecture","forks_url":"https://api.github.com/repos/googlesamples/android-architecture/forks","keys_url":"https://api.github.com/repos/googlesamples/android-architecture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-architecture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-architecture/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-architecture/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-architecture/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-architecture/events","assignees_url":"https://api.github.com/repos/googlesamples/android-architecture/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-architecture/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-architecture/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-architecture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-architecture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-architecture/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-architecture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-architecture/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-architecture/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-architecture/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-architecture/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-architecture/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-architecture/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-architecture/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-architecture/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-architecture/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-architecture/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-architecture/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-architecture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-architecture/merges","archive_url":"https://api.github.com/repos/googlesamples/android-architecture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-architecture/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-architecture/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-architecture/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-architecture/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-architecture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-architecture/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-architecture/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-architecture/deployments","created_at":"2016-02-05T13:42:07Z","updated_at":"2016-08-18T22:31:31Z","pushed_at":"2016-08-18T18:39:39Z","git_url":"git://github.com/googlesamples/android-architecture.git","ssh_url":"git@github.com:googlesamples/android-architecture.git","clone_url":"https://github.com/googlesamples/android-architecture.git","svn_url":"https://github.com/googlesamples/android-architecture","homepage":"","size":7597,"stargazers_count":9304,"watchers_count":9304,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2245,"mirror_url":null,"open_issues_count":48,"forks":2245,"open_issues":48,"watchers":9304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148"},"html":{"href":"https://github.com/googlesamples/android-architecture/pull/148"},"issue":{"href":"https://api.github.com/repos/googlesamples/android-architecture/issues/148"},"comments":{"href":"https://api.github.com/repos/googlesamples/android-architecture/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/android-architecture/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/android-architecture/statuses/9d2ce54766337c19cba8a741f63ca9d12b594d7b"}}}}
{"actor":{"display_login":"startthread"}}