{"action":"created","issue":{"url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/50","repository_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver","labels_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/50/comments","events_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/50/events","html_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/50","id":145352670,"number":50,"title":"Disposable fix for statement result","user":{"login":"IngvarKofoed","id":1925988,"avatar_url":"https://avatars.githubusercontent.com/u/1925988?v=3","gravatar_id":"","url":"https://api.github.com/users/IngvarKofoed","html_url":"https://github.com/IngvarKofoed","followers_url":"https://api.github.com/users/IngvarKofoed/followers","following_url":"https://api.github.com/users/IngvarKofoed/following{/other_user}","gists_url":"https://api.github.com/users/IngvarKofoed/gists{/gist_id}","starred_url":"https://api.github.com/users/IngvarKofoed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngvarKofoed/subscriptions","organizations_url":"https://api.github.com/users/IngvarKofoed/orgs","repos_url":"https://api.github.com/users/IngvarKofoed/repos","events_url":"https://api.github.com/users/IngvarKofoed/events{/privacy}","received_events_url":"https://api.github.com/users/IngvarKofoed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-02T08:55:12Z","updated_at":"2016-04-05T14:11:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/50","html_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/50","diff_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/50.diff","patch_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/50.patch"},"body":"This PR fixes the warning that was in the StatementResult. It keeps true to the API of both the Neo4j server and the driver API by consuming all records regardless if the user needs them and that only forward (and no restart) iteration is possible - eg consumes records when enumerated.\r\n\r\nThe only \"breaking\" thing is that IStatementResult has to be IDisposable to have the consume regardless feature. This is the correct way to do it in C#/.NET. I do not see this as a problem, because there might be other reasons in the future that ÌStatementResult`needs to be disposed and same behaviour is seen in other APIs for DBs."},"comment":{"url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/comments/205827580","html_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/50#issuecomment-205827580","issue_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/50","id":205827580,"user":{"login":"zhenlineo","id":4190164,"avatar_url":"https://avatars.githubusercontent.com/u/4190164?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T14:11:33Z","updated_at":"2016-04-05T14:11:33Z","body":"If you agree to remove Dispose, I get this PR\r\nhttps://github.com/IngvarKofoed/neo4j-dotnet-driver/pull/3"}}