{"action":"opened","number":309,"pull_request":{"url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309","id":79565789,"html_url":"https://github.com/EDDiscovery/EDDiscovery/pull/309","diff_url":"https://github.com/EDDiscovery/EDDiscovery/pull/309.diff","patch_url":"https://github.com/EDDiscovery/EDDiscovery/pull/309.patch","issue_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/309","number":309,"state":"open","locked":false,"title":"Add a couple of checks for null \"VisitedSystems\" member when synchron…","user":{"login":"mwerle","id":615724,"avatar_url":"https://avatars.githubusercontent.com/u/615724?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerle","html_url":"https://github.com/mwerle","followers_url":"https://api.github.com/users/mwerle/followers","following_url":"https://api.github.com/users/mwerle/following{/other_user}","gists_url":"https://api.github.com/users/mwerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerle/subscriptions","organizations_url":"https://api.github.com/users/mwerle/orgs","repos_url":"https://api.github.com/users/mwerle/repos","events_url":"https://api.github.com/users/mwerle/events{/privacy}","received_events_url":"https://api.github.com/users/mwerle/received_events","type":"User","site_admin":false},"body":"…ising -from- EDSM.\r\n\r\nUSE CASE: New install, no netlog, sync with EDSM.\r\n\r\n\r\nWithout these checks the sync fails.\r\n\r\nFurthermore, IF the \"netlog\" directory is not specified, ParseFiles() returns null (might be better to return an empty VisistedSystems list?), and the history is never refreshed properly, which means the next EDSM sync duplicates the entire list of visisted systems.\r\n\r\nRecommend we look at refactoring the code so that \"VisistedSystems\" can never be null, only empty, and \"ParseFiles\" doesn't abort if we don't have a valid netlog location.","created_at":"2016-08-01T13:12:14Z","updated_at":"2016-08-01T13:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309/commits","review_comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309/comments","review_comment_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/309/comments","statuses_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/995af23d541c4ac712fa3a6d50752339d08cce12","head":{"label":"mwerle:master","ref":"master","sha":"995af23d541c4ac712fa3a6d50752339d08cce12","user":{"login":"mwerle","id":615724,"avatar_url":"https://avatars.githubusercontent.com/u/615724?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerle","html_url":"https://github.com/mwerle","followers_url":"https://api.github.com/users/mwerle/followers","following_url":"https://api.github.com/users/mwerle/following{/other_user}","gists_url":"https://api.github.com/users/mwerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerle/subscriptions","organizations_url":"https://api.github.com/users/mwerle/orgs","repos_url":"https://api.github.com/users/mwerle/repos","events_url":"https://api.github.com/users/mwerle/events{/privacy}","received_events_url":"https://api.github.com/users/mwerle/received_events","type":"User","site_admin":false},"repo":{"id":46792085,"name":"EDDiscovery","full_name":"mwerle/EDDiscovery","owner":{"login":"mwerle","id":615724,"avatar_url":"https://avatars.githubusercontent.com/u/615724?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerle","html_url":"https://github.com/mwerle","followers_url":"https://api.github.com/users/mwerle/followers","following_url":"https://api.github.com/users/mwerle/following{/other_user}","gists_url":"https://api.github.com/users/mwerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerle/subscriptions","organizations_url":"https://api.github.com/users/mwerle/orgs","repos_url":"https://api.github.com/users/mwerle/repos","events_url":"https://api.github.com/users/mwerle/events{/privacy}","received_events_url":"https://api.github.com/users/mwerle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwerle/EDDiscovery","description":"Captains log and 3d star map for Elite Dangerous","fork":true,"url":"https://api.github.com/repos/mwerle/EDDiscovery","forks_url":"https://api.github.com/repos/mwerle/EDDiscovery/forks","keys_url":"https://api.github.com/repos/mwerle/EDDiscovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwerle/EDDiscovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwerle/EDDiscovery/teams","hooks_url":"https://api.github.com/repos/mwerle/EDDiscovery/hooks","issue_events_url":"https://api.github.com/repos/mwerle/EDDiscovery/issues/events{/number}","events_url":"https://api.github.com/repos/mwerle/EDDiscovery/events","assignees_url":"https://api.github.com/repos/mwerle/EDDiscovery/assignees{/user}","branches_url":"https://api.github.com/repos/mwerle/EDDiscovery/branches{/branch}","tags_url":"https://api.github.com/repos/mwerle/EDDiscovery/tags","blobs_url":"https://api.github.com/repos/mwerle/EDDiscovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwerle/EDDiscovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwerle/EDDiscovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwerle/EDDiscovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwerle/EDDiscovery/statuses/{sha}","languages_url":"https://api.github.com/repos/mwerle/EDDiscovery/languages","stargazers_url":"https://api.github.com/repos/mwerle/EDDiscovery/stargazers","contributors_url":"https://api.github.com/repos/mwerle/EDDiscovery/contributors","subscribers_url":"https://api.github.com/repos/mwerle/EDDiscovery/subscribers","subscription_url":"https://api.github.com/repos/mwerle/EDDiscovery/subscription","commits_url":"https://api.github.com/repos/mwerle/EDDiscovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwerle/EDDiscovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwerle/EDDiscovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwerle/EDDiscovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwerle/EDDiscovery/contents/{+path}","compare_url":"https://api.github.com/repos/mwerle/EDDiscovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwerle/EDDiscovery/merges","archive_url":"https://api.github.com/repos/mwerle/EDDiscovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwerle/EDDiscovery/downloads","issues_url":"https://api.github.com/repos/mwerle/EDDiscovery/issues{/number}","pulls_url":"https://api.github.com/repos/mwerle/EDDiscovery/pulls{/number}","milestones_url":"https://api.github.com/repos/mwerle/EDDiscovery/milestones{/number}","notifications_url":"https://api.github.com/repos/mwerle/EDDiscovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwerle/EDDiscovery/labels{/name}","releases_url":"https://api.github.com/repos/mwerle/EDDiscovery/releases{/id}","deployments_url":"https://api.github.com/repos/mwerle/EDDiscovery/deployments","created_at":"2015-11-24T13:04:32Z","updated_at":"2016-01-27T15:09:42Z","pushed_at":"2016-08-01T13:08:58Z","git_url":"git://github.com/mwerle/EDDiscovery.git","ssh_url":"git@github.com:mwerle/EDDiscovery.git","clone_url":"https://github.com/mwerle/EDDiscovery.git","svn_url":"https://github.com/mwerle/EDDiscovery","homepage":null,"size":498076,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EDDiscovery:master","ref":"master","sha":"5299410844b10f046e3d96cf8cf08ea28c5978a7","user":{"login":"EDDiscovery","id":12028419,"avatar_url":"https://avatars.githubusercontent.com/u/12028419?v=3","gravatar_id":"","url":"https://api.github.com/users/EDDiscovery","html_url":"https://github.com/EDDiscovery","followers_url":"https://api.github.com/users/EDDiscovery/followers","following_url":"https://api.github.com/users/EDDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/EDDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/EDDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDDiscovery/subscriptions","organizations_url":"https://api.github.com/users/EDDiscovery/orgs","repos_url":"https://api.github.com/users/EDDiscovery/repos","events_url":"https://api.github.com/users/EDDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/EDDiscovery/received_events","type":"Organization","site_admin":false},"repo":{"id":34243409,"name":"EDDiscovery","full_name":"EDDiscovery/EDDiscovery","owner":{"login":"EDDiscovery","id":12028419,"avatar_url":"https://avatars.githubusercontent.com/u/12028419?v=3","gravatar_id":"","url":"https://api.github.com/users/EDDiscovery","html_url":"https://github.com/EDDiscovery","followers_url":"https://api.github.com/users/EDDiscovery/followers","following_url":"https://api.github.com/users/EDDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/EDDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/EDDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDDiscovery/subscriptions","organizations_url":"https://api.github.com/users/EDDiscovery/orgs","repos_url":"https://api.github.com/users/EDDiscovery/repos","events_url":"https://api.github.com/users/EDDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/EDDiscovery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EDDiscovery/EDDiscovery","description":"Captains log and 3d star map for Elite Dangerous","fork":false,"url":"https://api.github.com/repos/EDDiscovery/EDDiscovery","forks_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/forks","keys_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/teams","hooks_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/hooks","issue_events_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/events{/number}","events_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/events","assignees_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/assignees{/user}","branches_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/branches{/branch}","tags_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/tags","blobs_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/{sha}","languages_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/languages","stargazers_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/stargazers","contributors_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/contributors","subscribers_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/subscribers","subscription_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/subscription","commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/contents/{+path}","compare_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/merges","archive_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/downloads","issues_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues{/number}","pulls_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls{/number}","milestones_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/milestones{/number}","notifications_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/labels{/name}","releases_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/releases{/id}","deployments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/deployments","created_at":"2015-04-20T06:55:44Z","updated_at":"2016-07-29T21:57:32Z","pushed_at":"2016-08-01T12:44:19Z","git_url":"git://github.com/EDDiscovery/EDDiscovery.git","ssh_url":"git@github.com:EDDiscovery/EDDiscovery.git","clone_url":"https://github.com/EDDiscovery/EDDiscovery.git","svn_url":"https://github.com/EDDiscovery/EDDiscovery","homepage":null,"size":498281,"stargazers_count":53,"watchers_count":53,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":20,"forks":29,"open_issues":20,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309"},"html":{"href":"https://github.com/EDDiscovery/EDDiscovery/pull/309"},"issue":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/309"},"comments":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/995af23d541c4ac712fa3a6d50752339d08cce12"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"mwerle"}}