{"action":"created","comment":{"url":"https://api.github.com/repos/su2code/SU2/pulls/comments/84723086","pull_request_review_id":5478749,"id":84723086,"diff_hunk":"@@ -10882,15 +10892,31 @@ void CEulerSolver::BC_Fluid_Interface(CGeometry *geometry, CSolver **solver_cont\n \n           /*--- Set primitive variables ---*/\n \n-          numerics->SetPrimitive(PrimVar_i, PrimVar_j);\n+          numerics->SetPrimitive( PrimVar_i, PrimVar_j );\n+          \n+          if( !( config->GetKind_FluidModel() == STANDARD_AIR || config->GetKind_FluidModel() == IDEAL_GAS ) ){\n+\t\t    P_static   = PrimVar_j[nDim+1];\n+\t\t    rho_static = PrimVar_j[nDim+2];\t\t\t  \n+\t\t\tFluidModel->SetTDState_Prho(P_static, rho_static);\n+\t\t\t  \t\t\t  \n+\t\t    P_static   = PrimVar_i[nDim+1];\n+\t\t    rho_static = PrimVar_i[nDim+2];\n+\t\t\tFluidModel->SetTDState_Prho(P_static, rho_static);\n+            node[iPoint]->SetSecondaryVar_Compressible(FluidModel);\n+\n+            Secondary_i[0] = FluidModel->GetdPdrho_e();\n+            Secondary_i[1] = FluidModel->GetdPde_rho();              \n+\n+            numerics->SetSecondary(Secondary_i, Secondary_j);\n+          }\n ","path":"SU2_CFD/src/solver_direct_mean.cpp","position":null,"original_position":113,"commit_id":"4ee2951fa5cc583497b0df2050d43accede60d1a","original_commit_id":"ed655fe5e35d5f90973d6adc1d5ba132e456218b","user":{"login":"arubino","id":10130821,"avatar_url":"https://avatars.githubusercontent.com/u/10130821?v=3","gravatar_id":"","url":"https://api.github.com/users/arubino","html_url":"https://github.com/arubino","followers_url":"https://api.github.com/users/arubino/followers","following_url":"https://api.github.com/users/arubino/following{/other_user}","gists_url":"https://api.github.com/users/arubino/gists{/gist_id}","starred_url":"https://api.github.com/users/arubino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arubino/subscriptions","organizations_url":"https://api.github.com/users/arubino/orgs","repos_url":"https://api.github.com/users/arubino/repos","events_url":"https://api.github.com/users/arubino/events{/privacy}","received_events_url":"https://api.github.com/users/arubino/received_events","type":"User","site_admin":false},"body":"Giulio, I am not sure about this maybe I am missing something. I see here that the fluid model is instantiated twice but used once. How are the Secondary_j calculated?  Why not using for the iNode simply the GetSecondary method and then calculating for j the secondary variables using the FluidModel ? Also, but I am not sure, I guess the if statement can be omitted.\r\n\r\nWhat about something like this:\r\n\r\n         \t```\r\n           Secondary_i = node[iPoint]->GetSecondary();\r\n\r\n          \tP_static   = PrimVar_j[nDim+1];\r\n          \trho_static = PrimVar_j[nDim+2];\r\n          \tFluidModel->SetTDState_Prho(P_static, rho_static);\r\n\r\n          \tSecondary_j[0] = FluidModel->GetdPdrho_e();\r\n          \tSecondary_j[1] = FluidModel->GetdPde_rho();\r\n\r\n\r\n          /*--- Set primitive variables ---*/\r\n          numerics->SetPrimitive(PrimVar_i, PrimVar_j);\r\n\r\n          /*--- Set secondary variables ---*/\r\n          numerics->SetSecondary(Secondary_i, Secondary_j);\r\n\r\n\r\n```\r\n","created_at":"2016-10-24T16:09:20Z","updated_at":"2016-10-24T16:09:55Z","html_url":"https://github.com/su2code/SU2/pull/322#discussion_r84723086","pull_request_url":"https://api.github.com/repos/su2code/SU2/pulls/322","_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments/84723086"},"html":{"href":"https://github.com/su2code/SU2/pull/322#discussion_r84723086"},"pull_request":{"href":"https://api.github.com/repos/su2code/SU2/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/su2code/SU2/pulls/322","id":89811729,"html_url":"https://github.com/su2code/SU2/pull/322","diff_url":"https://github.com/su2code/SU2/pull/322.diff","patch_url":"https://github.com/su2code/SU2/pull/322.patch","issue_url":"https://api.github.com/repos/su2code/SU2/issues/322","number":322,"state":"open","locked":false,"title":"Feature driver prototype","user":{"login":"LaSerpe","id":7878712,"avatar_url":"https://avatars.githubusercontent.com/u/7878712?v=3","gravatar_id":"","url":"https://api.github.com/users/LaSerpe","html_url":"https://github.com/LaSerpe","followers_url":"https://api.github.com/users/LaSerpe/followers","following_url":"https://api.github.com/users/LaSerpe/following{/other_user}","gists_url":"https://api.github.com/users/LaSerpe/gists{/gist_id}","starred_url":"https://api.github.com/users/LaSerpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaSerpe/subscriptions","organizations_url":"https://api.github.com/users/LaSerpe/orgs","repos_url":"https://api.github.com/users/LaSerpe/repos","events_url":"https://api.github.com/users/LaSerpe/events{/privacy}","received_events_url":"https://api.github.com/users/LaSerpe/received_events","type":"User","site_admin":false},"body":"This pull request contains a first step towards sliding mesh implementation.\r\n\r\nFluid-Fluid simulations are now possible using the NEAREST_NEIGHBOUR approach between an arbitrary number of zones.\r\n\r\n\r\nThe driver structure has changed: a CFluidDriver and a CGeneralDriver were created in place  of the singlezone and multizone drivers.\r\nFluidDriver is capable of managing an arbitrary number of fluid zones exploiting the Cinterpolator and the CTransfer classes.\r\nCGeneralDriver is left to run single-zone FEM, heat, poisson or wave problems. For the time being they are still limited to single zone problems only (as in the current develop branch).\r\nIf you any idea or suggestion about what the new drivers' names should be or about some reference multizone problem we may use in the future to extend the General driver we could start a discussion.\r\n\r\n\r\nThe CTransfer and CInterpolator classes were modified to deal with an arbitrary number of fluid zone, (they were limited to 2 zones only). \r\n\r\n\r\nA new BC MARKER_FLUID_INTERFACE was introduced.\r\nThis interface must be specified like, for instance, the MARKER_CLAMPED or MARKER_NORMAL_LOAD in FSI problems.\r\nRegarding this BC, now it still requires the MARKER_FSI_INTERFACE  to be specified in order to create the interfaces.\r\nFor this pull request I left the old name but I think it should change, maybe into something more general like MARKER_ZONE_INTERFACE. Any suggestion?\r\n\r\n","created_at":"2016-10-18T13:10:25Z","updated_at":"2016-10-24T16:12:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"923b8fe00a4ea7c75542a09ea44a63596998eede","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/su2code/SU2/pulls/322/commits","review_comments_url":"https://api.github.com/repos/su2code/SU2/pulls/322/comments","review_comment_url":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/su2code/SU2/issues/322/comments","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/4ee2951fa5cc583497b0df2050d43accede60d1a","head":{"label":"su2code:feature_driver_prototype","ref":"feature_driver_prototype","sha":"4ee2951fa5cc583497b0df2050d43accede60d1a","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars.githubusercontent.com/u/4796189?v=3","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars.githubusercontent.com/u/4796189?v=3","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2 Suite","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2016-10-24T04:25:47Z","pushed_at":"2016-10-24T14:16:32Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"http://su2.stanford.edu","size":484127,"stargazers_count":215,"watchers_count":215,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":220,"mirror_url":null,"open_issues_count":93,"forks":220,"open_issues":93,"watchers":215,"default_branch":"master"}},"base":{"label":"su2code:develop","ref":"develop","sha":"df8ebc6f23b09e979aa27124a41127ae81bacc4a","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars.githubusercontent.com/u/4796189?v=3","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars.githubusercontent.com/u/4796189?v=3","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2 Suite","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2016-10-24T04:25:47Z","pushed_at":"2016-10-24T14:16:32Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"http://su2.stanford.edu","size":484127,"stargazers_count":215,"watchers_count":215,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":220,"mirror_url":null,"open_issues_count":93,"forks":220,"open_issues":93,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/322"},"html":{"href":"https://github.com/su2code/SU2/pull/322"},"issue":{"href":"https://api.github.com/repos/su2code/SU2/issues/322"},"comments":{"href":"https://api.github.com/repos/su2code/SU2/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/su2code/SU2/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/su2code/SU2/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/su2code/SU2/statuses/4ee2951fa5cc583497b0df2050d43accede60d1a"}}}}
{"actor":{"display_login":"arubino"}}