{"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/farsightsec/nmsg/pulls/49","id":68271806,"html_url":"https://github.com/farsightsec/nmsg/pull/49","diff_url":"https://github.com/farsightsec/nmsg/pull/49.diff","patch_url":"https://github.com/farsightsec/nmsg/pull/49.patch","issue_url":"https://api.github.com/repos/farsightsec/nmsg/issues/49","number":49,"state":"open","locked":false,"title":"Fix when building without YAJL support","user":{"login":"edmonds","id":202839,"avatar_url":"https://avatars.githubusercontent.com/u/202839?v=3","gravatar_id":"","url":"https://api.github.com/users/edmonds","html_url":"https://github.com/edmonds","followers_url":"https://api.github.com/users/edmonds/followers","following_url":"https://api.github.com/users/edmonds/following{/other_user}","gists_url":"https://api.github.com/users/edmonds/gists{/gist_id}","starred_url":"https://api.github.com/users/edmonds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmonds/subscriptions","organizations_url":"https://api.github.com/users/edmonds/orgs","repos_url":"https://api.github.com/users/edmonds/repos","events_url":"https://api.github.com/users/edmonds/events{/privacy}","received_events_url":"https://api.github.com/users/edmonds/received_events","type":"User","site_admin":false},"body":"This commit fixes the build (#47) when configured with --without-yajl.\r\n\r\nWithout HAVE_YAJL, we build stub functions that return a failure, but\r\nthose stub functions aren't correct: nmsg_input_open_json() had the\r\nwrong signature:\r\n\r\n```\r\n    nmsg/input.c:168:1: error: conflicting types for ‘nmsg_input_open_json’\r\n     nmsg_input_open_json(int fd, nmsg_msgmod_t msgmod) {\r\n     ^\r\n    In file included from nmsg/nmsg.h:104:0,\r\n                     from nmsg/private.h:67,\r\n                     from nmsg/input.c:19:\r\n    ./nmsg/input.h:173:1: note: previous declaration of ‘nmsg_input_open_json’ was here\r\n     nmsg_input_open_json(int fd);\r\n     ^\r\n```\r\n\r\nThe YAJL-less alternative for nmsg_message_from_json() had the wrong\r\nfunction name, wrong signature, and included a syntax error:\r\n\r\n```\r\n    nmsg/msgmod/message.c:376:1: warning: no previous prototype for ‘nmsg_json_to_payload’ [-Wmissing-prototypes]\r\n     nmsg_json_to_payload(const char *json, struct nmsg_msgmod **mod, uint8_t **pbuf, size_t *sz)\r\n     ^\r\n    nmsg/msgmod/message.c: In function ‘nmsg_json_to_payload’:\r\n    nmsg/msgmod/message.c:377:2: error: expected declaration specifiers before ‘return’\r\n      return (nmsg_res_notimpl);\r\n      ^\r\n    nmsg/msgmod/message.c:378:1: error: expected declaration specifiers before ‘}’ token\r\n     }\r\n     ^\r\n    [...a bunch more...]\r\n```","created_at":"2016-04-28T18:54:55Z","updated_at":"2016-04-28T18:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/farsightsec/nmsg/milestones/3","html_url":"https://github.com/farsightsec/nmsg/milestones/0.12.0","labels_url":"https://api.github.com/repos/farsightsec/nmsg/milestones/3/labels","id":1737196,"number":3,"title":"0.12.0","description":"","creator":{"login":"edmonds","id":202839,"avatar_url":"https://avatars.githubusercontent.com/u/202839?v=3","gravatar_id":"","url":"https://api.github.com/users/edmonds","html_url":"https://github.com/edmonds","followers_url":"https://api.github.com/users/edmonds/followers","following_url":"https://api.github.com/users/edmonds/following{/other_user}","gists_url":"https://api.github.com/users/edmonds/gists{/gist_id}","starred_url":"https://api.github.com/users/edmonds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmonds/subscriptions","organizations_url":"https://api.github.com/users/edmonds/orgs","repos_url":"https://api.github.com/users/edmonds/repos","events_url":"https://api.github.com/users/edmonds/events{/privacy}","received_events_url":"https://api.github.com/users/edmonds/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2016-04-28T18:41:13Z","updated_at":"2016-04-28T18:54:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/farsightsec/nmsg/pulls/49/commits","review_comments_url":"https://api.github.com/repos/farsightsec/nmsg/pulls/49/comments","review_comment_url":"https://api.github.com/repos/farsightsec/nmsg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/farsightsec/nmsg/issues/49/comments","statuses_url":"https://api.github.com/repos/farsightsec/nmsg/statuses/7f903485cbf5d3c2e7da36ba9e6302f91be627fd","head":{"label":"farsightsec:branches/fix-without-yajl","ref":"branches/fix-without-yajl","sha":"7f903485cbf5d3c2e7da36ba9e6302f91be627fd","user":{"login":"farsightsec","id":5004096,"avatar_url":"https://avatars.githubusercontent.com/u/5004096?v=3","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"repo":{"id":14828870,"name":"nmsg","full_name":"farsightsec/nmsg","owner":{"login":"farsightsec","id":5004096,"avatar_url":"https://avatars.githubusercontent.com/u/5004096?v=3","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/farsightsec/nmsg","description":"network message encapsulation library","fork":false,"url":"https://api.github.com/repos/farsightsec/nmsg","forks_url":"https://api.github.com/repos/farsightsec/nmsg/forks","keys_url":"https://api.github.com/repos/farsightsec/nmsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farsightsec/nmsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farsightsec/nmsg/teams","hooks_url":"https://api.github.com/repos/farsightsec/nmsg/hooks","issue_events_url":"https://api.github.com/repos/farsightsec/nmsg/issues/events{/number}","events_url":"https://api.github.com/repos/farsightsec/nmsg/events","assignees_url":"https://api.github.com/repos/farsightsec/nmsg/assignees{/user}","branches_url":"https://api.github.com/repos/farsightsec/nmsg/branches{/branch}","tags_url":"https://api.github.com/repos/farsightsec/nmsg/tags","blobs_url":"https://api.github.com/repos/farsightsec/nmsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farsightsec/nmsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farsightsec/nmsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/farsightsec/nmsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farsightsec/nmsg/statuses/{sha}","languages_url":"https://api.github.com/repos/farsightsec/nmsg/languages","stargazers_url":"https://api.github.com/repos/farsightsec/nmsg/stargazers","contributors_url":"https://api.github.com/repos/farsightsec/nmsg/contributors","subscribers_url":"https://api.github.com/repos/farsightsec/nmsg/subscribers","subscription_url":"https://api.github.com/repos/farsightsec/nmsg/subscription","commits_url":"https://api.github.com/repos/farsightsec/nmsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/farsightsec/nmsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/farsightsec/nmsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/farsightsec/nmsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/farsightsec/nmsg/contents/{+path}","compare_url":"https://api.github.com/repos/farsightsec/nmsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farsightsec/nmsg/merges","archive_url":"https://api.github.com/repos/farsightsec/nmsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farsightsec/nmsg/downloads","issues_url":"https://api.github.com/repos/farsightsec/nmsg/issues{/number}","pulls_url":"https://api.github.com/repos/farsightsec/nmsg/pulls{/number}","milestones_url":"https://api.github.com/repos/farsightsec/nmsg/milestones{/number}","notifications_url":"https://api.github.com/repos/farsightsec/nmsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farsightsec/nmsg/labels{/name}","releases_url":"https://api.github.com/repos/farsightsec/nmsg/releases{/id}","deployments_url":"https://api.github.com/repos/farsightsec/nmsg/deployments","created_at":"2013-11-30T21:43:00Z","updated_at":"2016-03-24T18:58:24Z","pushed_at":"2016-04-28T18:53:55Z","git_url":"git://github.com/farsightsec/nmsg.git","ssh_url":"git@github.com:farsightsec/nmsg.git","clone_url":"https://github.com/farsightsec/nmsg.git","svn_url":"https://github.com/farsightsec/nmsg","homepage":null,"size":4605,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":10,"default_branch":"master"}},"base":{"label":"farsightsec:next","ref":"next","sha":"69cc09b95c4933c72546ed3307674e07283eec32","user":{"login":"farsightsec","id":5004096,"avatar_url":"https://avatars.githubusercontent.com/u/5004096?v=3","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"repo":{"id":14828870,"name":"nmsg","full_name":"farsightsec/nmsg","owner":{"login":"farsightsec","id":5004096,"avatar_url":"https://avatars.githubusercontent.com/u/5004096?v=3","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/farsightsec/nmsg","description":"network message encapsulation library","fork":false,"url":"https://api.github.com/repos/farsightsec/nmsg","forks_url":"https://api.github.com/repos/farsightsec/nmsg/forks","keys_url":"https://api.github.com/repos/farsightsec/nmsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farsightsec/nmsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farsightsec/nmsg/teams","hooks_url":"https://api.github.com/repos/farsightsec/nmsg/hooks","issue_events_url":"https://api.github.com/repos/farsightsec/nmsg/issues/events{/number}","events_url":"https://api.github.com/repos/farsightsec/nmsg/events","assignees_url":"https://api.github.com/repos/farsightsec/nmsg/assignees{/user}","branches_url":"https://api.github.com/repos/farsightsec/nmsg/branches{/branch}","tags_url":"https://api.github.com/repos/farsightsec/nmsg/tags","blobs_url":"https://api.github.com/repos/farsightsec/nmsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farsightsec/nmsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farsightsec/nmsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/farsightsec/nmsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farsightsec/nmsg/statuses/{sha}","languages_url":"https://api.github.com/repos/farsightsec/nmsg/languages","stargazers_url":"https://api.github.com/repos/farsightsec/nmsg/stargazers","contributors_url":"https://api.github.com/repos/farsightsec/nmsg/contributors","subscribers_url":"https://api.github.com/repos/farsightsec/nmsg/subscribers","subscription_url":"https://api.github.com/repos/farsightsec/nmsg/subscription","commits_url":"https://api.github.com/repos/farsightsec/nmsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/farsightsec/nmsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/farsightsec/nmsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/farsightsec/nmsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/farsightsec/nmsg/contents/{+path}","compare_url":"https://api.github.com/repos/farsightsec/nmsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farsightsec/nmsg/merges","archive_url":"https://api.github.com/repos/farsightsec/nmsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farsightsec/nmsg/downloads","issues_url":"https://api.github.com/repos/farsightsec/nmsg/issues{/number}","pulls_url":"https://api.github.com/repos/farsightsec/nmsg/pulls{/number}","milestones_url":"https://api.github.com/repos/farsightsec/nmsg/milestones{/number}","notifications_url":"https://api.github.com/repos/farsightsec/nmsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farsightsec/nmsg/labels{/name}","releases_url":"https://api.github.com/repos/farsightsec/nmsg/releases{/id}","deployments_url":"https://api.github.com/repos/farsightsec/nmsg/deployments","created_at":"2013-11-30T21:43:00Z","updated_at":"2016-03-24T18:58:24Z","pushed_at":"2016-04-28T18:53:55Z","git_url":"git://github.com/farsightsec/nmsg.git","ssh_url":"git@github.com:farsightsec/nmsg.git","clone_url":"https://github.com/farsightsec/nmsg.git","svn_url":"https://github.com/farsightsec/nmsg","homepage":null,"size":4605,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/farsightsec/nmsg/pulls/49"},"html":{"href":"https://github.com/farsightsec/nmsg/pull/49"},"issue":{"href":"https://api.github.com/repos/farsightsec/nmsg/issues/49"},"comments":{"href":"https://api.github.com/repos/farsightsec/nmsg/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/farsightsec/nmsg/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/farsightsec/nmsg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/farsightsec/nmsg/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/farsightsec/nmsg/statuses/7f903485cbf5d3c2e7da36ba9e6302f91be627fd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}