{"action":"created","comment":{"url":"https://api.github.com/repos/kubespray/kargo/pulls/comments/83893964","pull_request_review_id":4706963,"id":83893964,"diff_hunk":"@@ -4,7 +4,7 @@\n     dest: /etc/hosts\n     block: |-\n       {% for item in groups['all'] -%}\n-      {{ hostvars[item]['access_ip'] | default(hostvars[item]['ip'] | default(hostvars[item].ansible_default_ipv4.address)) }} {{ item }}\n+      {{ hostvars[item]['access_ip'] | default(hostvars[item]['ip'] | default(hostvars[item].ansible_default_ipv4.address)) }}{% if (item != hostvars[item]['inventory_hostname_short']) %} {{ hostvars[item]['inventory_hostname_short'] }}{% endif %} {{ item }}","path":"roles/kubernetes/preinstall/tasks/etchosts.yml","position":5,"original_position":5,"commit_id":"beb25c549c3a341acd6c99888495f9fb716aa0d4","original_commit_id":"beb25c549c3a341acd6c99888495f9fb716aa0d4","user":{"login":"mattymo","id":1229061,"avatar_url":"https://avatars.githubusercontent.com/u/1229061?v=3","gravatar_id":"","url":"https://api.github.com/users/mattymo","html_url":"https://github.com/mattymo","followers_url":"https://api.github.com/users/mattymo/followers","following_url":"https://api.github.com/users/mattymo/following{/other_user}","gists_url":"https://api.github.com/users/mattymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mattymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattymo/subscriptions","organizations_url":"https://api.github.com/users/mattymo/orgs","repos_url":"https://api.github.com/users/mattymo/repos","events_url":"https://api.github.com/users/mattymo/events{/privacy}","received_events_url":"https://api.github.com/users/mattymo/received_events","type":"User","site_admin":false},"body":"You're right! Good catch. +1","created_at":"2016-10-18T16:22:55Z","updated_at":"2016-10-18T16:22:55Z","html_url":"https://github.com/kubespray/kargo/pull/550#discussion_r83893964","pull_request_url":"https://api.github.com/repos/kubespray/kargo/pulls/550","_links":{"self":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/comments/83893964"},"html":{"href":"https://github.com/kubespray/kargo/pull/550#discussion_r83893964"},"pull_request":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/550"}}},"pull_request":{"url":"https://api.github.com/repos/kubespray/kargo/pulls/550","id":89657362,"html_url":"https://github.com/kubespray/kargo/pull/550","diff_url":"https://github.com/kubespray/kargo/pull/550.diff","patch_url":"https://github.com/kubespray/kargo/pull/550.patch","issue_url":"https://api.github.com/repos/kubespray/kargo/issues/550","number":550,"state":"open","locked":false,"title":"Hostname alias fixes","user":{"login":"chadswen","id":727874,"avatar_url":"https://avatars.githubusercontent.com/u/727874?v=3","gravatar_id":"","url":"https://api.github.com/users/chadswen","html_url":"https://github.com/chadswen","followers_url":"https://api.github.com/users/chadswen/followers","following_url":"https://api.github.com/users/chadswen/following{/other_user}","gists_url":"https://api.github.com/users/chadswen/gists{/gist_id}","starred_url":"https://api.github.com/users/chadswen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadswen/subscriptions","organizations_url":"https://api.github.com/users/chadswen/orgs","repos_url":"https://api.github.com/users/chadswen/repos","events_url":"https://api.github.com/users/chadswen/events{/privacy}","received_events_url":"https://api.github.com/users/chadswen/received_events","type":"User","site_admin":false},"body":"Change the kubelet `--hostname-override` flag to use the `ansible_hostname` variable by default instead of the `inventory_hostname` specified in the inventory file. This should ensure more consistency with the value required by cloud providers like OpenStack where the hostname has to match the system hostname.\r\n\r\nAdd an `inventory_hostname_short` alias to `/etc/hosts` when its value is different from `inventory_hostname` to overcome node name limitations, see: [k8s issue #22770](https://github.com/kubernetes/kubernetes/issues/22770)","created_at":"2016-10-17T16:27:10Z","updated_at":"2016-10-18T16:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4c85d15e92be22eff09c12c179607c6d2bb44eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubespray/kargo/pulls/550/commits","review_comments_url":"https://api.github.com/repos/kubespray/kargo/pulls/550/comments","review_comment_url":"https://api.github.com/repos/kubespray/kargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubespray/kargo/issues/550/comments","statuses_url":"https://api.github.com/repos/kubespray/kargo/statuses/beb25c549c3a341acd6c99888495f9fb716aa0d4","head":{"label":"chadswen:hostname-alias","ref":"hostname-alias","sha":"beb25c549c3a341acd6c99888495f9fb716aa0d4","user":{"login":"chadswen","id":727874,"avatar_url":"https://avatars.githubusercontent.com/u/727874?v=3","gravatar_id":"","url":"https://api.github.com/users/chadswen","html_url":"https://github.com/chadswen","followers_url":"https://api.github.com/users/chadswen/followers","following_url":"https://api.github.com/users/chadswen/following{/other_user}","gists_url":"https://api.github.com/users/chadswen/gists{/gist_id}","starred_url":"https://api.github.com/users/chadswen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadswen/subscriptions","organizations_url":"https://api.github.com/users/chadswen/orgs","repos_url":"https://api.github.com/users/chadswen/repos","events_url":"https://api.github.com/users/chadswen/events{/privacy}","received_events_url":"https://api.github.com/users/chadswen/received_events","type":"User","site_admin":false},"repo":{"id":60715349,"name":"kargo","full_name":"chadswen/kargo","owner":{"login":"chadswen","id":727874,"avatar_url":"https://avatars.githubusercontent.com/u/727874?v=3","gravatar_id":"","url":"https://api.github.com/users/chadswen","html_url":"https://github.com/chadswen","followers_url":"https://api.github.com/users/chadswen/followers","following_url":"https://api.github.com/users/chadswen/following{/other_user}","gists_url":"https://api.github.com/users/chadswen/gists{/gist_id}","starred_url":"https://api.github.com/users/chadswen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadswen/subscriptions","organizations_url":"https://api.github.com/users/chadswen/orgs","repos_url":"https://api.github.com/users/chadswen/repos","events_url":"https://api.github.com/users/chadswen/events{/privacy}","received_events_url":"https://api.github.com/users/chadswen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadswen/kargo","description":"Setup a kubernetes cluster with Ansible","fork":true,"url":"https://api.github.com/repos/chadswen/kargo","forks_url":"https://api.github.com/repos/chadswen/kargo/forks","keys_url":"https://api.github.com/repos/chadswen/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadswen/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadswen/kargo/teams","hooks_url":"https://api.github.com/repos/chadswen/kargo/hooks","issue_events_url":"https://api.github.com/repos/chadswen/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/chadswen/kargo/events","assignees_url":"https://api.github.com/repos/chadswen/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/chadswen/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/chadswen/kargo/tags","blobs_url":"https://api.github.com/repos/chadswen/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadswen/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadswen/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadswen/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadswen/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/chadswen/kargo/languages","stargazers_url":"https://api.github.com/repos/chadswen/kargo/stargazers","contributors_url":"https://api.github.com/repos/chadswen/kargo/contributors","subscribers_url":"https://api.github.com/repos/chadswen/kargo/subscribers","subscription_url":"https://api.github.com/repos/chadswen/kargo/subscription","commits_url":"https://api.github.com/repos/chadswen/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadswen/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadswen/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadswen/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadswen/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/chadswen/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadswen/kargo/merges","archive_url":"https://api.github.com/repos/chadswen/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadswen/kargo/downloads","issues_url":"https://api.github.com/repos/chadswen/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/chadswen/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/chadswen/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/chadswen/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadswen/kargo/labels{/name}","releases_url":"https://api.github.com/repos/chadswen/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/chadswen/kargo/deployments","created_at":"2016-06-08T17:07:24Z","updated_at":"2016-06-08T17:07:25Z","pushed_at":"2016-10-17T16:19:40Z","git_url":"git://github.com/chadswen/kargo.git","ssh_url":"git@github.com:chadswen/kargo.git","clone_url":"https://github.com/chadswen/kargo.git","svn_url":"https://github.com/chadswen/kargo","homepage":"","size":4325,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubespray:master","ref":"master","sha":"1de127470f51f7c5cd10e71621f525f1f4a337f0","user":{"login":"kubespray","id":14975689,"avatar_url":"https://avatars.githubusercontent.com/u/14975689?v=3","gravatar_id":"","url":"https://api.github.com/users/kubespray","html_url":"https://github.com/kubespray","followers_url":"https://api.github.com/users/kubespray/followers","following_url":"https://api.github.com/users/kubespray/following{/other_user}","gists_url":"https://api.github.com/users/kubespray/gists{/gist_id}","starred_url":"https://api.github.com/users/kubespray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubespray/subscriptions","organizations_url":"https://api.github.com/users/kubespray/orgs","repos_url":"https://api.github.com/users/kubespray/repos","events_url":"https://api.github.com/users/kubespray/events{/privacy}","received_events_url":"https://api.github.com/users/kubespray/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"name":"kargo","full_name":"kubespray/kargo","owner":{"login":"kubespray","id":14975689,"avatar_url":"https://avatars.githubusercontent.com/u/14975689?v=3","gravatar_id":"","url":"https://api.github.com/users/kubespray","html_url":"https://github.com/kubespray","followers_url":"https://api.github.com/users/kubespray/followers","following_url":"https://api.github.com/users/kubespray/following{/other_user}","gists_url":"https://api.github.com/users/kubespray/gists{/gist_id}","starred_url":"https://api.github.com/users/kubespray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubespray/subscriptions","organizations_url":"https://api.github.com/users/kubespray/orgs","repos_url":"https://api.github.com/users/kubespray/repos","events_url":"https://api.github.com/users/kubespray/events{/privacy}","received_events_url":"https://api.github.com/users/kubespray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubespray/kargo","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubespray/kargo","forks_url":"https://api.github.com/repos/kubespray/kargo/forks","keys_url":"https://api.github.com/repos/kubespray/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubespray/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubespray/kargo/teams","hooks_url":"https://api.github.com/repos/kubespray/kargo/hooks","issue_events_url":"https://api.github.com/repos/kubespray/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/kubespray/kargo/events","assignees_url":"https://api.github.com/repos/kubespray/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/kubespray/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/kubespray/kargo/tags","blobs_url":"https://api.github.com/repos/kubespray/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubespray/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubespray/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubespray/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubespray/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/kubespray/kargo/languages","stargazers_url":"https://api.github.com/repos/kubespray/kargo/stargazers","contributors_url":"https://api.github.com/repos/kubespray/kargo/contributors","subscribers_url":"https://api.github.com/repos/kubespray/kargo/subscribers","subscription_url":"https://api.github.com/repos/kubespray/kargo/subscription","commits_url":"https://api.github.com/repos/kubespray/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubespray/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubespray/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubespray/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubespray/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/kubespray/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubespray/kargo/merges","archive_url":"https://api.github.com/repos/kubespray/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubespray/kargo/downloads","issues_url":"https://api.github.com/repos/kubespray/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/kubespray/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/kubespray/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/kubespray/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubespray/kargo/labels{/name}","releases_url":"https://api.github.com/repos/kubespray/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/kubespray/kargo/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2016-10-18T15:50:57Z","pushed_at":"2016-10-18T16:19:08Z","git_url":"git://github.com/kubespray/kargo.git","ssh_url":"git@github.com:kubespray/kargo.git","clone_url":"https://github.com/kubespray/kargo.git","svn_url":"https://github.com/kubespray/kargo","homepage":"","size":4823,"stargazers_count":345,"watchers_count":345,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":75,"forks":111,"open_issues":75,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/550"},"html":{"href":"https://github.com/kubespray/kargo/pull/550"},"issue":{"href":"https://api.github.com/repos/kubespray/kargo/issues/550"},"comments":{"href":"https://api.github.com/repos/kubespray/kargo/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubespray/kargo/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/kubespray/kargo/statuses/beb25c549c3a341acd6c99888495f9fb716aa0d4"}}}}
{"actor":{"display_login":"mattymo"}}