{"action":"created","comment":{"url":"https://api.github.com/repos/kaazing/gateway/pulls/comments/52507832","id":52507832,"diff_hunk":"@@ -132,13 +183,12 @@ public void shouldLogOpenWriteReceivedAndAbruptClose() throws Exception {\n             \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] OPENED\",\n             \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] WRITE\",\n             \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] RECEIVED\",\n-            \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] CLOSED\",\n-            \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] EXCEPTION.*IOException\",\n+            // TODO: See why the following is not logged (on upstream and downstream)\n+            // \"http#[^wseb#]*wseb#[^ ]* [^/]*:\\\\d*] CLOSED\",","path":"transport/wseb/src/test/java/org/kaazing/gateway/transport/wseb/logging/WsebConnectorLoggingIT.java","position":98,"original_position":98,"commit_id":"fe5526d0188cc3936892af4677377766d95929ea","original_commit_id":"fe5526d0188cc3936892af4677377766d95929ea","user":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"body":"Is `CLOSED` being logged now?","created_at":"2016-02-10T19:10:16Z","updated_at":"2016-02-10T19:10:16Z","html_url":"https://github.com/kaazing/gateway/pull/418#discussion_r52507832","pull_request_url":"https://api.github.com/repos/kaazing/gateway/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/comments/52507832"},"html":{"href":"https://github.com/kaazing/gateway/pull/418#discussion_r52507832"},"pull_request":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/kaazing/gateway/pulls/418","id":58698431,"html_url":"https://github.com/kaazing/gateway/pull/418","diff_url":"https://github.com/kaazing/gateway/pull/418.diff","patch_url":"https://github.com/kaazing/gateway/pull/418.patch","issue_url":"https://api.github.com/repos/kaazing/gateway/issues/418","number":418,"state":"open","locked":false,"title":"Wse spec tests","user":{"login":"cmebarrow","id":3606936,"avatar_url":"https://avatars.githubusercontent.com/u/3606936?v=3","gravatar_id":"","url":"https://api.github.com/users/cmebarrow","html_url":"https://github.com/cmebarrow","followers_url":"https://api.github.com/users/cmebarrow/followers","following_url":"https://api.github.com/users/cmebarrow/following{/other_user}","gists_url":"https://api.github.com/users/cmebarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/cmebarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmebarrow/subscriptions","organizations_url":"https://api.github.com/users/cmebarrow/orgs","repos_url":"https://api.github.com/users/cmebarrow/repos","events_url":"https://api.github.com/users/cmebarrow/events{/privacy}","received_events_url":"https://api.github.com/users/cmebarrow/received_events","type":"User","site_admin":false},"body":"This pull request adds wse specification tests to the wseb transport, for both WsebAcceptor and WsebConnector. It also includes many fixes needed to make the tests pass, mostly to the wseb transport but also http. Changes include:\r\n\r\n- Implemented wseb close handshake (acceptor and connector)\r\n- Enhanced WsebConnector to do upstreaming using chunking\r\n- Enhanced WsebConnector to use create path suffix /cbm instead of /cb so it can send ws text frames\r\n- Added concept of ResponseFuture to http transport so consumers can be alerted when the HTTP response is received by HttpConnector, even if there is no data yet received.\r\n\r\nWsebConnector does not currently have support for buffering proxies.This PR does not attempt to address this.\r\n\r\nNOTE: k3po PR [Wse spec test fixes #305](https://github.com/k3po/k3po/pull/305) must be merged and k3po released before this PR can be merged.","created_at":"2016-02-09T02:38:15Z","updated_at":"2016-02-10T19:10:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"363f8d856530744ab37488b3110185b2fd833957","assignee":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kaazing/gateway/pulls/418/commits","review_comments_url":"https://api.github.com/repos/kaazing/gateway/pulls/418/comments","review_comment_url":"https://api.github.com/repos/kaazing/gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaazing/gateway/issues/418/comments","statuses_url":"https://api.github.com/repos/kaazing/gateway/statuses/fe5526d0188cc3936892af4677377766d95929ea","head":{"label":"cmebarrow:wse_spec_tests","ref":"wse_spec_tests","sha":"fe5526d0188cc3936892af4677377766d95929ea","user":{"login":"cmebarrow","id":3606936,"avatar_url":"https://avatars.githubusercontent.com/u/3606936?v=3","gravatar_id":"","url":"https://api.github.com/users/cmebarrow","html_url":"https://github.com/cmebarrow","followers_url":"https://api.github.com/users/cmebarrow/followers","following_url":"https://api.github.com/users/cmebarrow/following{/other_user}","gists_url":"https://api.github.com/users/cmebarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/cmebarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmebarrow/subscriptions","organizations_url":"https://api.github.com/users/cmebarrow/orgs","repos_url":"https://api.github.com/users/cmebarrow/repos","events_url":"https://api.github.com/users/cmebarrow/events{/privacy}","received_events_url":"https://api.github.com/users/cmebarrow/received_events","type":"User","site_admin":false},"repo":{"id":31911574,"name":"gateway","full_name":"cmebarrow/gateway","owner":{"login":"cmebarrow","id":3606936,"avatar_url":"https://avatars.githubusercontent.com/u/3606936?v=3","gravatar_id":"","url":"https://api.github.com/users/cmebarrow","html_url":"https://github.com/cmebarrow","followers_url":"https://api.github.com/users/cmebarrow/followers","following_url":"https://api.github.com/users/cmebarrow/following{/other_user}","gists_url":"https://api.github.com/users/cmebarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/cmebarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmebarrow/subscriptions","organizations_url":"https://api.github.com/users/cmebarrow/orgs","repos_url":"https://api.github.com/users/cmebarrow/repos","events_url":"https://api.github.com/users/cmebarrow/events{/privacy}","received_events_url":"https://api.github.com/users/cmebarrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmebarrow/gateway","description":"Gateway distribution","fork":true,"url":"https://api.github.com/repos/cmebarrow/gateway","forks_url":"https://api.github.com/repos/cmebarrow/gateway/forks","keys_url":"https://api.github.com/repos/cmebarrow/gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmebarrow/gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmebarrow/gateway/teams","hooks_url":"https://api.github.com/repos/cmebarrow/gateway/hooks","issue_events_url":"https://api.github.com/repos/cmebarrow/gateway/issues/events{/number}","events_url":"https://api.github.com/repos/cmebarrow/gateway/events","assignees_url":"https://api.github.com/repos/cmebarrow/gateway/assignees{/user}","branches_url":"https://api.github.com/repos/cmebarrow/gateway/branches{/branch}","tags_url":"https://api.github.com/repos/cmebarrow/gateway/tags","blobs_url":"https://api.github.com/repos/cmebarrow/gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmebarrow/gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmebarrow/gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmebarrow/gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmebarrow/gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/cmebarrow/gateway/languages","stargazers_url":"https://api.github.com/repos/cmebarrow/gateway/stargazers","contributors_url":"https://api.github.com/repos/cmebarrow/gateway/contributors","subscribers_url":"https://api.github.com/repos/cmebarrow/gateway/subscribers","subscription_url":"https://api.github.com/repos/cmebarrow/gateway/subscription","commits_url":"https://api.github.com/repos/cmebarrow/gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmebarrow/gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmebarrow/gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmebarrow/gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmebarrow/gateway/contents/{+path}","compare_url":"https://api.github.com/repos/cmebarrow/gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmebarrow/gateway/merges","archive_url":"https://api.github.com/repos/cmebarrow/gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmebarrow/gateway/downloads","issues_url":"https://api.github.com/repos/cmebarrow/gateway/issues{/number}","pulls_url":"https://api.github.com/repos/cmebarrow/gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/cmebarrow/gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/cmebarrow/gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmebarrow/gateway/labels{/name}","releases_url":"https://api.github.com/repos/cmebarrow/gateway/releases{/id}","deployments_url":"https://api.github.com/repos/cmebarrow/gateway/deployments","created_at":"2015-03-09T17:07:03Z","updated_at":"2016-01-11T22:42:55Z","pushed_at":"2016-02-10T02:36:40Z","git_url":"git://github.com/cmebarrow/gateway.git","ssh_url":"git@github.com:cmebarrow/gateway.git","clone_url":"https://github.com/cmebarrow/gateway.git","svn_url":"https://github.com/cmebarrow/gateway","homepage":null,"size":12999,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"kaazing:develop","ref":"develop","sha":"a4dcdd8281def8fb7cf85623fa5af631a5a06c2c","user":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"repo":{"id":26745548,"name":"gateway","full_name":"kaazing/gateway","owner":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaazing/gateway","description":"Kaazing Gateway","fork":false,"url":"https://api.github.com/repos/kaazing/gateway","forks_url":"https://api.github.com/repos/kaazing/gateway/forks","keys_url":"https://api.github.com/repos/kaazing/gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaazing/gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaazing/gateway/teams","hooks_url":"https://api.github.com/repos/kaazing/gateway/hooks","issue_events_url":"https://api.github.com/repos/kaazing/gateway/issues/events{/number}","events_url":"https://api.github.com/repos/kaazing/gateway/events","assignees_url":"https://api.github.com/repos/kaazing/gateway/assignees{/user}","branches_url":"https://api.github.com/repos/kaazing/gateway/branches{/branch}","tags_url":"https://api.github.com/repos/kaazing/gateway/tags","blobs_url":"https://api.github.com/repos/kaazing/gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaazing/gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaazing/gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaazing/gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaazing/gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/kaazing/gateway/languages","stargazers_url":"https://api.github.com/repos/kaazing/gateway/stargazers","contributors_url":"https://api.github.com/repos/kaazing/gateway/contributors","subscribers_url":"https://api.github.com/repos/kaazing/gateway/subscribers","subscription_url":"https://api.github.com/repos/kaazing/gateway/subscription","commits_url":"https://api.github.com/repos/kaazing/gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaazing/gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaazing/gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaazing/gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaazing/gateway/contents/{+path}","compare_url":"https://api.github.com/repos/kaazing/gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaazing/gateway/merges","archive_url":"https://api.github.com/repos/kaazing/gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaazing/gateway/downloads","issues_url":"https://api.github.com/repos/kaazing/gateway/issues{/number}","pulls_url":"https://api.github.com/repos/kaazing/gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/kaazing/gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/kaazing/gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaazing/gateway/labels{/name}","releases_url":"https://api.github.com/repos/kaazing/gateway/releases{/id}","deployments_url":"https://api.github.com/repos/kaazing/gateway/deployments","created_at":"2014-11-17T07:40:57Z","updated_at":"2016-01-18T18:32:32Z","pushed_at":"2016-02-10T15:43:06Z","git_url":"git://github.com/kaazing/gateway.git","ssh_url":"git@github.com:kaazing/gateway.git","clone_url":"https://github.com/kaazing/gateway.git","svn_url":"https://github.com/kaazing/gateway","homepage":"","size":14152,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":85,"forks":40,"open_issues":85,"watchers":41,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/418"},"html":{"href":"https://github.com/kaazing/gateway/pull/418"},"issue":{"href":"https://api.github.com/repos/kaazing/gateway/issues/418"},"comments":{"href":"https://api.github.com/repos/kaazing/gateway/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/kaazing/gateway/statuses/fe5526d0188cc3936892af4677377766d95929ea"}}}}