{"action":"created","issue":{"url":"https://api.github.com/repos/ucb-bar/rocket/issues/33","repository_url":"https://api.github.com/repos/ucb-bar/rocket","labels_url":"https://api.github.com/repos/ucb-bar/rocket/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/ucb-bar/rocket/issues/33/comments","events_url":"https://api.github.com/repos/ucb-bar/rocket/issues/33/events","html_url":"https://github.com/ucb-bar/rocket/pull/33","id":144869066,"number":33,"title":"fix leaky assert in nbdcache","user":{"login":"ccelio","id":788854,"avatar_url":"https://avatars.githubusercontent.com/u/788854?v=3","gravatar_id":"","url":"https://api.github.com/users/ccelio","html_url":"https://github.com/ccelio","followers_url":"https://api.github.com/users/ccelio/followers","following_url":"https://api.github.com/users/ccelio/following{/other_user}","gists_url":"https://api.github.com/users/ccelio/gists{/gist_id}","starred_url":"https://api.github.com/users/ccelio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccelio/subscriptions","organizations_url":"https://api.github.com/users/ccelio/orgs","repos_url":"https://api.github.com/users/ccelio/repos","events_url":"https://api.github.com/users/ccelio/events{/privacy}","received_events_url":"https://api.github.com/users/ccelio/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-31T11:35:58Z","updated_at":"2016-03-31T22:56:55Z","closed_at":"2016-03-31T22:56:55Z","pull_request":{"url":"https://api.github.com/repos/ucb-bar/rocket/pulls/33","html_url":"https://github.com/ucb-bar/rocket/pull/33","diff_url":"https://github.com/ucb-bar/rocket/pull/33.diff","patch_url":"https://github.com/ucb-bar/rocket/pull/33.patch"},"body":"The assert in nbdcache checks that a valid response from the cache does not have\r\nany exceptions, as it is the job of the pipeline to detect asserts and supply\r\nthe kill signal to the cache. However, the assert can be erroneously triggered\r\nby a load that misses in the cache returning and being compared against spurious\r\nexception signals.\r\n\r\nThis commit checks that the tag of the response matches the tag corresponding to\r\nthe exceptions and also checks that the excepting instruction was valid."},"comment":{"url":"https://api.github.com/repos/ucb-bar/rocket/issues/comments/204163707","html_url":"https://github.com/ucb-bar/rocket/pull/33#issuecomment-204163707","issue_url":"https://api.github.com/repos/ucb-bar/rocket/issues/33","id":204163707,"user":{"login":"aswaterman","id":1031106,"avatar_url":"https://avatars.githubusercontent.com/u/1031106?v=3","gravatar_id":"","url":"https://api.github.com/users/aswaterman","html_url":"https://github.com/aswaterman","followers_url":"https://api.github.com/users/aswaterman/followers","following_url":"https://api.github.com/users/aswaterman/following{/other_user}","gists_url":"https://api.github.com/users/aswaterman/gists{/gist_id}","starred_url":"https://api.github.com/users/aswaterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aswaterman/subscriptions","organizations_url":"https://api.github.com/users/aswaterman/orgs","repos_url":"https://api.github.com/users/aswaterman/repos","events_url":"https://api.github.com/users/aswaterman/events{/privacy}","received_events_url":"https://api.github.com/users/aswaterman/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T22:56:55Z","updated_at":"2016-03-31T22:56:55Z","body":"I squashed the commits and pushed."}}