{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/92902874","pull_request_review_id":13428518,"id":92902874,"diff_hunk":"@@ -850,6 +850,10 @@ void Model::setTextures(const QVariantMap& textures) {\n         _needsUpdateTextures = true;\n         _needsFixupInScene = true;\n         _renderGeometry->setTextures(textures);\n+    } else {\n+        connect(&_renderWatcher, &GeometryResourceWatcher::finished, this, [this, textures]() {\n+            _renderGeometry->setTextures(textures);\n+        });","path":"libraries/render-utils/src/Model.cpp","position":7,"original_position":7,"commit_id":"009c982cdfe87106d7d9a446ec492cb41023ce85","original_commit_id":"009c982cdfe87106d7d9a446ec492cb41023ce85","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"what is this for?","created_at":"2016-12-16T23:22:28Z","updated_at":"2016-12-16T23:22:28Z","html_url":"https://github.com/highfidelity/hifi/pull/9180#discussion_r92902874","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/9180","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/92902874"},"html":{"href":"https://github.com/highfidelity/hifi/pull/9180#discussion_r92902874"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/9180"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/9180","id":97398352,"html_url":"https://github.com/highfidelity/hifi/pull/9180","diff_url":"https://github.com/highfidelity/hifi/pull/9180.diff","patch_url":"https://github.com/highfidelity/hifi/pull/9180.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/9180","number":9180,"state":"open","locked":false,"title":"DNM - Add touch support to tutorial","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-09T23:27:52Z","updated_at":"2016-12-16T23:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67b0eb385f7e74354b3f427273643ab74d19c894","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/9180/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/9180/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/9180/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/009c982cdfe87106d7d9a446ec492cb41023ce85","head":{"label":"huffman:feat/tutorial-touch","ref":"feat/tutorial-touch","sha":"009c982cdfe87106d7d9a446ec492cb41023ce85","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"repo":{"id":16237479,"name":"hifi","full_name":"huffman/hifi","owner":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huffman/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  You can also contribute by doing jobs listed at http://worklist.net/worklist.php","fork":true,"url":"https://api.github.com/repos/huffman/hifi","forks_url":"https://api.github.com/repos/huffman/hifi/forks","keys_url":"https://api.github.com/repos/huffman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huffman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huffman/hifi/teams","hooks_url":"https://api.github.com/repos/huffman/hifi/hooks","issue_events_url":"https://api.github.com/repos/huffman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/huffman/hifi/events","assignees_url":"https://api.github.com/repos/huffman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/huffman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/huffman/hifi/tags","blobs_url":"https://api.github.com/repos/huffman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huffman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huffman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/huffman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huffman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/huffman/hifi/languages","stargazers_url":"https://api.github.com/repos/huffman/hifi/stargazers","contributors_url":"https://api.github.com/repos/huffman/hifi/contributors","subscribers_url":"https://api.github.com/repos/huffman/hifi/subscribers","subscription_url":"https://api.github.com/repos/huffman/hifi/subscription","commits_url":"https://api.github.com/repos/huffman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/huffman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/huffman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/huffman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/huffman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/huffman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huffman/hifi/merges","archive_url":"https://api.github.com/repos/huffman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huffman/hifi/downloads","issues_url":"https://api.github.com/repos/huffman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/huffman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/huffman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/huffman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huffman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/huffman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/huffman/hifi/deployments","created_at":"2014-01-25T18:54:32Z","updated_at":"2015-03-25T17:45:58Z","pushed_at":"2016-12-16T23:05:32Z","git_url":"git://github.com/huffman/hifi.git","ssh_url":"git@github.com:huffman/hifi.git","clone_url":"https://github.com/huffman/hifi.git","svn_url":"https://github.com/huffman/hifi","homepage":"http://highfidelity.io","size":273291,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"1ded581895492e06e801bf911807f2906539f7b4","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-12-14T10:28:51Z","pushed_at":"2016-12-16T23:31:54Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":260629,"stargazers_count":462,"watchers_count":462,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":45,"forks":265,"open_issues":45,"watchers":462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/9180"},"html":{"href":"https://github.com/highfidelity/hifi/pull/9180"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/9180"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/9180/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/9180/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/9180/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/009c982cdfe87106d7d9a446ec492cb41023ce85"}}}}
{"actor":{"display_login":"birarda"}}