{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/6835","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/6835/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/6835/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/6835/events","html_url":"https://github.com/scipy/scipy/issues/6835","id":193972007,"number":6835,"title":"signal.bsplines test","user":{"login":"cynthia-rempel","id":24236064,"avatar_url":"https://avatars.githubusercontent.com/u/24236064?v=3","gravatar_id":"","url":"https://api.github.com/users/cynthia-rempel","html_url":"https://github.com/cynthia-rempel","followers_url":"https://api.github.com/users/cynthia-rempel/followers","following_url":"https://api.github.com/users/cynthia-rempel/following{/other_user}","gists_url":"https://api.github.com/users/cynthia-rempel/gists{/gist_id}","starred_url":"https://api.github.com/users/cynthia-rempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynthia-rempel/subscriptions","organizations_url":"https://api.github.com/users/cynthia-rempel/orgs","repos_url":"https://api.github.com/users/cynthia-rempel/repos","events_url":"https://api.github.com/users/cynthia-rempel/events{/privacy}","received_events_url":"https://api.github.com/users/cynthia-rempel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-07T06:53:42Z","updated_at":"2016-12-07T09:44:15Z","closed_at":null,"body":"Happy Holidays!\r\n\r\nWrote a test-suite for scipy.signal.bsplines\r\n\r\nRan it from the scipy/scipy/signal/tests directory...\r\n\r\nIt yields a 99% coverage rating and a 94% mutation coverage rating (using cosmic-rays)...\r\nUsed pylint to correct the formatting...\r\n\r\nThe test oracle right now are the results I got when running the functions in an interpreter... so they'll only catch changes in the code...\r\n\r\nReally appreciate all you do!\r\n\r\n[test_bsplines.zip](https://github.com/scipy/scipy/files/635850/test_bsplines.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/265401729","html_url":"https://github.com/scipy/scipy/issues/6835#issuecomment-265401729","issue_url":"https://api.github.com/repos/scipy/scipy/issues/6835","id":265401729,"user":{"login":"rgommers","id":98330,"avatar_url":"https://avatars.githubusercontent.com/u/98330?v=3","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T09:44:15Z","updated_at":"2016-12-07T09:44:15Z","body":"Hi @cynthia-rempel, thank you that looks promising! Could you please submit your changes as a pull request rather than a zipped file? If you've never done that before, here's a walkthrough: https://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#basic-workflow\r\n\r\nI had a look at your code - the main thing to change would be to use numpy functions to generate the test arrays rather than hardcode them (which is verbose and hard to change). For example, this:\r\n\r\n        # data for testing complex branch generated by\r\n        # (numpy.random.rand(7,7)*10000).astype(int)/1000.0 +\r\n        # (numpy.random.rand(7,7)*10000).astype(int)*1j/1000.0\r\n        cplx = array([[5.665+4.273j, 5.101+0.498j, 9.287+9.575j, 7.464+6.337j,\r\n                       3.747+5.486j, 4.143+9.162j, 4.786+6.852j],\r\n                      [4.388+7.543j, 3.901+7.127j, 4.401+3.034j, \r\n        ....\r\n\r\nshould be:\r\n\r\n    np.random.seed(12457)\r\n    cplx = (np.random.rand(7,7)*10000).astype(int)/1000.0 +\r\n           (np.random.rand(7,7)*10000).astype(int)*1j/1000.0"}}
{"actor":{"display_login":"rgommers"}}