{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/89454944","pull_request_review_id":9999454,"id":89454944,"diff_hunk":"@@ -32,9 +32,9 @@\n  * that it can decode any message with a length field, which is often seen in","path":"codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java","position":1,"original_position":1,"commit_id":"c44f41f21587d0d989cc26bb9f089ff955f54578","original_commit_id":"c44f41f21587d0d989cc26bb9f089ff955f54578","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"revert changes to this file as its only reformatting ?","created_at":"2016-11-24T08:52:46Z","updated_at":"2016-11-24T08:52:46Z","html_url":"https://github.com/netty/netty/pull/6052#discussion_r89454944","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6052","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/89454944"},"html":{"href":"https://github.com/netty/netty/pull/6052#discussion_r89454944"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6052"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6052","id":94608027,"html_url":"https://github.com/netty/netty/pull/6052","diff_url":"https://github.com/netty/netty/pull/6052.diff","patch_url":"https://github.com/netty/netty/pull/6052.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6052","number":6052,"state":"open","locked":false,"title":" Implemented batch versions of LengthFieldBasedFrameDecoder and Fixed…","user":{"login":"maseev","id":3434800,"avatar_url":"https://avatars.githubusercontent.com/u/3434800?v=3","gravatar_id":"","url":"https://api.github.com/users/maseev","html_url":"https://github.com/maseev","followers_url":"https://api.github.com/users/maseev/followers","following_url":"https://api.github.com/users/maseev/following{/other_user}","gists_url":"https://api.github.com/users/maseev/gists{/gist_id}","starred_url":"https://api.github.com/users/maseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maseev/subscriptions","organizations_url":"https://api.github.com/users/maseev/orgs","repos_url":"https://api.github.com/users/maseev/repos","events_url":"https://api.github.com/users/maseev/events{/privacy}","received_events_url":"https://api.github.com/users/maseev/received_events","type":"User","site_admin":false},"body":"…LengthFrameDecoder\r\n\r\nMotivation:\r\n\r\nAccording to performance tests, LengthFieldBasedFrameDecoder and FixedLengthFrameDecoder generate a lot of garbage as well as perform quite poorly in cases where clients send data at a very high-speed rate.\r\n\r\nModifications:\r\n\r\n- Introduce a base class which implements batching of all incoming ByteBuf messages as well as provides a convenient API for decoding the resulting chunk of data\r\n- Introduce an optimised version of LengthFieldBasedFrameDecoder - BatchLengthFieldBasedFrameDecoder\r\n- Introduce an optimised version of FixedLengthFrameDecoder - BatchFixedLengthFrameDecoder\r\n\r\nResult:\r\n\r\nBatchLengthFieldBasedFrameDecoder and BatchFixedLengthFrameDecoder will provide much better throughput as compared to LengthFieldBasedFrameDecoder and FixedLengthFrameDecoder\r\n\r\nP.S I [created](https://github.com/maseev/echo) a simple echo application which tests three batching strategies. Here are some throughput as well as GC diagrams:\r\n\r\n[Dummy Handler](https://github.com/maseev/echo/blob/master/server/src/main/java/io/github/maseev/echo/handler/DummyEchoServerHandler.java)\r\n![Dummy Handler Throughput](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/DUMMY_THROUGHPUT.png)\r\n![Dummy Handler GC](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/DUMMY_GC.png)\r\n\r\n[Batching Handler](https://github.com/maseev/echo/blob/master/server/src/main/java/io/github/maseev/echo/handler/BatchingEchoServerHandler.java)\r\n![Batching Handler Throughput](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/BATCHING_THROUGHPUT.png)\r\n![Batching Handler GC](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/BATCHING_GC.png)\r\n\r\n[Optimised Handler](https://github.com/maseev/echo/blob/master/server/src/main/java/io/github/maseev/echo/handler/HighPerformanceEchoServerHandler.java)\r\n![Optimised Throughput](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/OPTIMISED_THROUGHPUT.png)\r\n![Optimised GC](https://maseev.github.io/2016/09/16/gotta-go-fast-with-netty/OPTIMISED_GC.png)\r\n\r\nThis particular handler mimics the semantic of the one in the [PR](https://github.com/maseev/netty/commit/e67ac28504952f989f7a926359a24fdeac03ad0d#diff-424f83af20faabeda9dd287cb533fbc8). As you can see, throughput in the last case is much higher.\r\n\r\nThis PR is probably related to the following issues: #1759, #5152","created_at":"2016-11-21T12:42:45Z","updated_at":"2016-11-24T08:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec29da019a9286698b54c7cd17a0e560f5185c37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6052/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6052/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6052/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/c44f41f21587d0d989cc26bb9f089ff955f54578","head":{"label":"maseev:feature/batch-decoders","ref":"feature/batch-decoders","sha":"c44f41f21587d0d989cc26bb9f089ff955f54578","user":{"login":"maseev","id":3434800,"avatar_url":"https://avatars.githubusercontent.com/u/3434800?v=3","gravatar_id":"","url":"https://api.github.com/users/maseev","html_url":"https://github.com/maseev","followers_url":"https://api.github.com/users/maseev/followers","following_url":"https://api.github.com/users/maseev/following{/other_user}","gists_url":"https://api.github.com/users/maseev/gists{/gist_id}","starred_url":"https://api.github.com/users/maseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maseev/subscriptions","organizations_url":"https://api.github.com/users/maseev/orgs","repos_url":"https://api.github.com/users/maseev/repos","events_url":"https://api.github.com/users/maseev/events{/privacy}","received_events_url":"https://api.github.com/users/maseev/received_events","type":"User","site_admin":false},"repo":{"id":72031811,"name":"netty","full_name":"maseev/netty","owner":{"login":"maseev","id":3434800,"avatar_url":"https://avatars.githubusercontent.com/u/3434800?v=3","gravatar_id":"","url":"https://api.github.com/users/maseev","html_url":"https://github.com/maseev","followers_url":"https://api.github.com/users/maseev/followers","following_url":"https://api.github.com/users/maseev/following{/other_user}","gists_url":"https://api.github.com/users/maseev/gists{/gist_id}","starred_url":"https://api.github.com/users/maseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maseev/subscriptions","organizations_url":"https://api.github.com/users/maseev/orgs","repos_url":"https://api.github.com/users/maseev/repos","events_url":"https://api.github.com/users/maseev/events{/privacy}","received_events_url":"https://api.github.com/users/maseev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maseev/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/maseev/netty","forks_url":"https://api.github.com/repos/maseev/netty/forks","keys_url":"https://api.github.com/repos/maseev/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maseev/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maseev/netty/teams","hooks_url":"https://api.github.com/repos/maseev/netty/hooks","issue_events_url":"https://api.github.com/repos/maseev/netty/issues/events{/number}","events_url":"https://api.github.com/repos/maseev/netty/events","assignees_url":"https://api.github.com/repos/maseev/netty/assignees{/user}","branches_url":"https://api.github.com/repos/maseev/netty/branches{/branch}","tags_url":"https://api.github.com/repos/maseev/netty/tags","blobs_url":"https://api.github.com/repos/maseev/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maseev/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maseev/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/maseev/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maseev/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/maseev/netty/languages","stargazers_url":"https://api.github.com/repos/maseev/netty/stargazers","contributors_url":"https://api.github.com/repos/maseev/netty/contributors","subscribers_url":"https://api.github.com/repos/maseev/netty/subscribers","subscription_url":"https://api.github.com/repos/maseev/netty/subscription","commits_url":"https://api.github.com/repos/maseev/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/maseev/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/maseev/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/maseev/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/maseev/netty/contents/{+path}","compare_url":"https://api.github.com/repos/maseev/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maseev/netty/merges","archive_url":"https://api.github.com/repos/maseev/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maseev/netty/downloads","issues_url":"https://api.github.com/repos/maseev/netty/issues{/number}","pulls_url":"https://api.github.com/repos/maseev/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/maseev/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/maseev/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maseev/netty/labels{/name}","releases_url":"https://api.github.com/repos/maseev/netty/releases{/id}","deployments_url":"https://api.github.com/repos/maseev/netty/deployments","created_at":"2016-10-26T18:21:05Z","updated_at":"2016-10-26T18:21:21Z","pushed_at":"2016-11-24T07:26:15Z","git_url":"git://github.com/maseev/netty.git","ssh_url":"git@github.com:maseev/netty.git","clone_url":"https://github.com/maseev/netty.git","svn_url":"https://github.com/maseev/netty","homepage":"http://netty.io/","size":42990,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"f6b37a38bac6dbea5dd2282c68a0f41c456f67a2","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2016-11-24T08:41:50Z","pushed_at":"2016-11-24T07:26:18Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":73751,"stargazers_count":8315,"watchers_count":8315,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4214,"mirror_url":null,"open_issues_count":333,"forks":4214,"open_issues":333,"watchers":8315,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6052"},"html":{"href":"https://github.com/netty/netty/pull/6052"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6052"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6052/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6052/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6052/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/c44f41f21587d0d989cc26bb9f089ff955f54578"}}}}
{"actor":{"display_login":"normanmaurer"}}