{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/KDE/cirkuit/pulls/1","id":87876583,"html_url":"https://github.com/KDE/cirkuit/pull/1","diff_url":"https://github.com/KDE/cirkuit/pull/1.diff","patch_url":"https://github.com/KDE/cirkuit/pull/1.patch","issue_url":"https://api.github.com/repos/KDE/cirkuit/issues/1","number":1,"state":"open","locked":false,"title":"Use modern KF5 plugin system","user":{"login":"bruecke","id":1809710,"avatar_url":"https://avatars.githubusercontent.com/u/1809710?v=3","gravatar_id":"","url":"https://api.github.com/users/bruecke","html_url":"https://github.com/bruecke","followers_url":"https://api.github.com/users/bruecke/followers","following_url":"https://api.github.com/users/bruecke/following{/other_user}","gists_url":"https://api.github.com/users/bruecke/gists{/gist_id}","starred_url":"https://api.github.com/users/bruecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruecke/subscriptions","organizations_url":"https://api.github.com/users/bruecke/orgs","repos_url":"https://api.github.com/users/bruecke/repos","events_url":"https://api.github.com/users/bruecke/events{/privacy}","received_events_url":"https://api.github.com/users/bruecke/received_events","type":"User","site_admin":false},"body":"This is a basic approach to use KF5's or Qt5's new plugin system to get rid of some deprecated KDE4 members.\r\n\r\nChanges so far\r\n---\r\n * embed desktop files as json metadata inside plugin\r\n * use `KPluginLoader::findPlugins()` instead of the _old_ `KService` & `KSycoca` mechanism\r\n * removed use of deprecated class `KPluginInfo`\r\n * removed use of deprecated macro `K_EXPORT_PLUGIN`\r\n\r\nTodo\r\n---\r\nThe following things could be done to further improve the code:\r\n\r\n 1. convert desktop files permanently to the new json format\r\n   * cirkuit_backend.desktop could be dropped\r\n 1. use `kcoreaddons_add_plugin()` instead of separate `add_library()` and `install()` commands in the CMakeLists.txt files\r\n  * build system will then also depend on json-file and trigger a build update if the metadata is changed\r\n  * simplify CMakeLists.txt\r\n 1. move plugins to subdir inside of Qt5's plugin dir\r\n  * `KPluginLoader::findPlugins()` will not have to scan _all_ plugins\r\n","created_at":"2016-10-04T11:31:21Z","updated_at":"2016-10-04T11:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KDE/cirkuit/pulls/1/commits","review_comments_url":"https://api.github.com/repos/KDE/cirkuit/pulls/1/comments","review_comment_url":"https://api.github.com/repos/KDE/cirkuit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KDE/cirkuit/issues/1/comments","statuses_url":"https://api.github.com/repos/KDE/cirkuit/statuses/f3804678e4b9d6798b1ab5b5c1d1d11542c690a0","head":{"label":"bruecke:frameworks-plugins","ref":"frameworks-plugins","sha":"f3804678e4b9d6798b1ab5b5c1d1d11542c690a0","user":{"login":"bruecke","id":1809710,"avatar_url":"https://avatars.githubusercontent.com/u/1809710?v=3","gravatar_id":"","url":"https://api.github.com/users/bruecke","html_url":"https://github.com/bruecke","followers_url":"https://api.github.com/users/bruecke/followers","following_url":"https://api.github.com/users/bruecke/following{/other_user}","gists_url":"https://api.github.com/users/bruecke/gists{/gist_id}","starred_url":"https://api.github.com/users/bruecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruecke/subscriptions","organizations_url":"https://api.github.com/users/bruecke/orgs","repos_url":"https://api.github.com/users/bruecke/repos","events_url":"https://api.github.com/users/bruecke/events{/privacy}","received_events_url":"https://api.github.com/users/bruecke/received_events","type":"User","site_admin":false},"repo":{"id":69880264,"name":"cirkuit","full_name":"bruecke/cirkuit","owner":{"login":"bruecke","id":1809710,"avatar_url":"https://avatars.githubusercontent.com/u/1809710?v=3","gravatar_id":"","url":"https://api.github.com/users/bruecke","html_url":"https://github.com/bruecke","followers_url":"https://api.github.com/users/bruecke/followers","following_url":"https://api.github.com/users/bruecke/following{/other_user}","gists_url":"https://api.github.com/users/bruecke/gists{/gist_id}","starred_url":"https://api.github.com/users/bruecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruecke/subscriptions","organizations_url":"https://api.github.com/users/bruecke/orgs","repos_url":"https://api.github.com/users/bruecke/repos","events_url":"https://api.github.com/users/bruecke/events{/privacy}","received_events_url":"https://api.github.com/users/bruecke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bruecke/cirkuit","description":"KDE interface for LaTeX graphic tools (such as TikZ, Gnuplot, Circuit Macros) to produce publication-ready pictures.","fork":true,"url":"https://api.github.com/repos/bruecke/cirkuit","forks_url":"https://api.github.com/repos/bruecke/cirkuit/forks","keys_url":"https://api.github.com/repos/bruecke/cirkuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bruecke/cirkuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bruecke/cirkuit/teams","hooks_url":"https://api.github.com/repos/bruecke/cirkuit/hooks","issue_events_url":"https://api.github.com/repos/bruecke/cirkuit/issues/events{/number}","events_url":"https://api.github.com/repos/bruecke/cirkuit/events","assignees_url":"https://api.github.com/repos/bruecke/cirkuit/assignees{/user}","branches_url":"https://api.github.com/repos/bruecke/cirkuit/branches{/branch}","tags_url":"https://api.github.com/repos/bruecke/cirkuit/tags","blobs_url":"https://api.github.com/repos/bruecke/cirkuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bruecke/cirkuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bruecke/cirkuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bruecke/cirkuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bruecke/cirkuit/statuses/{sha}","languages_url":"https://api.github.com/repos/bruecke/cirkuit/languages","stargazers_url":"https://api.github.com/repos/bruecke/cirkuit/stargazers","contributors_url":"https://api.github.com/repos/bruecke/cirkuit/contributors","subscribers_url":"https://api.github.com/repos/bruecke/cirkuit/subscribers","subscription_url":"https://api.github.com/repos/bruecke/cirkuit/subscription","commits_url":"https://api.github.com/repos/bruecke/cirkuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bruecke/cirkuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bruecke/cirkuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bruecke/cirkuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bruecke/cirkuit/contents/{+path}","compare_url":"https://api.github.com/repos/bruecke/cirkuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bruecke/cirkuit/merges","archive_url":"https://api.github.com/repos/bruecke/cirkuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bruecke/cirkuit/downloads","issues_url":"https://api.github.com/repos/bruecke/cirkuit/issues{/number}","pulls_url":"https://api.github.com/repos/bruecke/cirkuit/pulls{/number}","milestones_url":"https://api.github.com/repos/bruecke/cirkuit/milestones{/number}","notifications_url":"https://api.github.com/repos/bruecke/cirkuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bruecke/cirkuit/labels{/name}","releases_url":"https://api.github.com/repos/bruecke/cirkuit/releases{/id}","deployments_url":"https://api.github.com/repos/bruecke/cirkuit/deployments","created_at":"2016-10-03T14:45:14Z","updated_at":"2016-10-03T14:45:15Z","pushed_at":"2016-10-04T10:54:46Z","git_url":"git://github.com/bruecke/cirkuit.git","ssh_url":"git@github.com:bruecke/cirkuit.git","clone_url":"https://github.com/bruecke/cirkuit.git","svn_url":"https://github.com/bruecke/cirkuit","homepage":null,"size":1224,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"frameworks-plugins"}},"base":{"label":"KDE:frameworks","ref":"frameworks","sha":"68ed5603f52cda02d0d7b1bdbb9d019e9af96375","user":{"login":"KDE","id":14312869,"avatar_url":"https://avatars.githubusercontent.com/u/14312869?v=3","gravatar_id":"","url":"https://api.github.com/users/KDE","html_url":"https://github.com/KDE","followers_url":"https://api.github.com/users/KDE/followers","following_url":"https://api.github.com/users/KDE/following{/other_user}","gists_url":"https://api.github.com/users/KDE/gists{/gist_id}","starred_url":"https://api.github.com/users/KDE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDE/subscriptions","organizations_url":"https://api.github.com/users/KDE/orgs","repos_url":"https://api.github.com/users/KDE/repos","events_url":"https://api.github.com/users/KDE/events{/privacy}","received_events_url":"https://api.github.com/users/KDE/received_events","type":"Organization","site_admin":false},"repo":{"id":42727936,"name":"cirkuit","full_name":"KDE/cirkuit","owner":{"login":"KDE","id":14312869,"avatar_url":"https://avatars.githubusercontent.com/u/14312869?v=3","gravatar_id":"","url":"https://api.github.com/users/KDE","html_url":"https://github.com/KDE","followers_url":"https://api.github.com/users/KDE/followers","following_url":"https://api.github.com/users/KDE/following{/other_user}","gists_url":"https://api.github.com/users/KDE/gists{/gist_id}","starred_url":"https://api.github.com/users/KDE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDE/subscriptions","organizations_url":"https://api.github.com/users/KDE/orgs","repos_url":"https://api.github.com/users/KDE/repos","events_url":"https://api.github.com/users/KDE/events{/privacy}","received_events_url":"https://api.github.com/users/KDE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KDE/cirkuit","description":"KDE interface for LaTeX graphic tools (such as TikZ, Gnuplot, Circuit Macros) to produce publication-ready pictures.","fork":false,"url":"https://api.github.com/repos/KDE/cirkuit","forks_url":"https://api.github.com/repos/KDE/cirkuit/forks","keys_url":"https://api.github.com/repos/KDE/cirkuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KDE/cirkuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KDE/cirkuit/teams","hooks_url":"https://api.github.com/repos/KDE/cirkuit/hooks","issue_events_url":"https://api.github.com/repos/KDE/cirkuit/issues/events{/number}","events_url":"https://api.github.com/repos/KDE/cirkuit/events","assignees_url":"https://api.github.com/repos/KDE/cirkuit/assignees{/user}","branches_url":"https://api.github.com/repos/KDE/cirkuit/branches{/branch}","tags_url":"https://api.github.com/repos/KDE/cirkuit/tags","blobs_url":"https://api.github.com/repos/KDE/cirkuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KDE/cirkuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KDE/cirkuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/KDE/cirkuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KDE/cirkuit/statuses/{sha}","languages_url":"https://api.github.com/repos/KDE/cirkuit/languages","stargazers_url":"https://api.github.com/repos/KDE/cirkuit/stargazers","contributors_url":"https://api.github.com/repos/KDE/cirkuit/contributors","subscribers_url":"https://api.github.com/repos/KDE/cirkuit/subscribers","subscription_url":"https://api.github.com/repos/KDE/cirkuit/subscription","commits_url":"https://api.github.com/repos/KDE/cirkuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/KDE/cirkuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/KDE/cirkuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/KDE/cirkuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/KDE/cirkuit/contents/{+path}","compare_url":"https://api.github.com/repos/KDE/cirkuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KDE/cirkuit/merges","archive_url":"https://api.github.com/repos/KDE/cirkuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KDE/cirkuit/downloads","issues_url":"https://api.github.com/repos/KDE/cirkuit/issues{/number}","pulls_url":"https://api.github.com/repos/KDE/cirkuit/pulls{/number}","milestones_url":"https://api.github.com/repos/KDE/cirkuit/milestones{/number}","notifications_url":"https://api.github.com/repos/KDE/cirkuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KDE/cirkuit/labels{/name}","releases_url":"https://api.github.com/repos/KDE/cirkuit/releases{/id}","deployments_url":"https://api.github.com/repos/KDE/cirkuit/deployments","created_at":"2015-09-18T14:41:05Z","updated_at":"2016-09-10T18:41:26Z","pushed_at":"2016-10-04T11:31:21Z","git_url":"git://github.com/KDE/cirkuit.git","ssh_url":"git@github.com:KDE/cirkuit.git","clone_url":"https://github.com/KDE/cirkuit.git","svn_url":"https://github.com/KDE/cirkuit","homepage":null,"size":1243,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KDE/cirkuit/pulls/1"},"html":{"href":"https://github.com/KDE/cirkuit/pull/1"},"issue":{"href":"https://api.github.com/repos/KDE/cirkuit/issues/1"},"comments":{"href":"https://api.github.com/repos/KDE/cirkuit/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/KDE/cirkuit/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/KDE/cirkuit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KDE/cirkuit/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/KDE/cirkuit/statuses/f3804678e4b9d6798b1ab5b5c1d1d11542c690a0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":39,"deletions":28,"changed_files":8}}
{"actor":{"display_login":"bruecke"}}