{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/20793","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/20793/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/20793/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/20793/events","html_url":"https://github.com/tgstation/tgstation/pull/20793","id":180512307,"number":20793,"title":"Obj damaging system, acid damage, and fire damage refactor (WIP)","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800"},{"url":"https://api.github.com/repos/tgstation/tgstation/labels/Map%20Edit","name":"Map Edit","color":"eb6420"},{"url":"https://api.github.com/repos/tgstation/tgstation/labels/Ready%20for%20Review","name":"Ready for Review","color":"ffdfa2"},{"url":"https://api.github.com/repos/tgstation/tgstation/labels/Refactor","name":"Refactor","color":"FF9933"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-10-02T13:28:02Z","updated_at":"2016-10-09T16:02:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/20793","html_url":"https://github.com/tgstation/tgstation/pull/20793","diff_url":"https://github.com/tgstation/tgstation/pull/20793.diff","patch_url":"https://github.com/tgstation/tgstation/pull/20793.patch"},"body":"Please refer to #20867 and #20870 for a easier view of the changes. Those two PRs show all meaningful changes (hopefully) and doesn't show the files changed with just 3 lines changed.\r\n\r\nThis PR does three things:\r\n\r\n* It makes all children of /obj/ use the same damage system.\r\nPreviously to make your new machine/structure be destroyable you needed to give it a var/health, and its own version of many damage related proc such as bullet_act(), take_damage(), attacked_by(), attack_animal(), attack_hulk(), ex_act(), etc... But now, all /obj/ use the same version of those procs at the /obj/ level in code/game/obj_defense.dm. All these obj share the same necessary vars: obj_integrity (health), max_integrity, integrity_failure (optional, below that health level failure happens), and the armor list var which was previously only for items, as well as the resistance_flags bitfield. When you want your new object to be destroyable, you only have to give it a value for those vars and maybe override one proc if you want a special behavior but that's it. This reorganization removes a lot of copypasta (most bullet_act() version for each obj were nearly identical). Two new elements are added to the armor list var: fire and acid armor values.\r\nHow much damage an obj take depends on the armor value for each damage category. But some objects are INDESTRUCTIBLE and simply never take any damage no matter the type.\r\nThe armor categories are: \r\n-melee(punches, item attacks, xeno/animal/hulk attacks, blob attacks); \r\n-bullet\r\n-laser\r\n-energy (used by projectiles like ionrifle, taser, and also by EMPs)\r\n-bio (unused for this, only here because clothes use them when worn)\r\n-rad (same)\r\n-bomb (self-explanatory)\r\n-fire (for fire damage, not for heat damage though)\r\n-acid\r\nFor machines and structures, when their health reaches zero the object is not just deleted but gets somewhat forcedeconstructed (the proc used is shared with the actual deconstruction system) which can drops things. To not frustrates players most of these objects drop most of the elements necessary to rebuild them (think window dropping shards). Machines drop a machine frame and all components for example (but the frame can then be itself smashed to pieces).\r\nFor clothes, when they are damaged, they get a \"damaged\" overlay, which can also be seen when worn, similar to the \"bloody\" overlay.\r\n\r\n* It refactors acid. See #20537.\r\nSome objects are ACID_PROOF and take no damage from acid, while others take varying amounts\r\nof damage depending on their acid armor value. Some objects are even UNACIDABLE, no acid effect can even land on them. Acid on objects can be washed off using water.\r\n\r\n* It changes some aspect of damage from fires.\r\nAll /obj/ can now take fire damage and be flammable, instead of just items. And instead of having just FLAMMABLE objs that become ON_FIRE as soon as some fire touch them (paper), we now have objects that are non flammable but do take damage from fire and become ashes if their health reaches zero (only for items). The damage taken varies depending on the obj's fire armor value and total health. There's also still obj and items that are FIRE_PROOF (although some might still be melted by lava if they're not LAVA_PROOF).\r\nWhen a mob is on fire, its clothes now take fire damage and can turn to ashes. Similarly, when a mob takes melee damages, its clothes gets damaged a bit and can turn to shreds. You can repair clothes with cloth that is produceable by botany's biogenerator.\r\n\r\n\r\n* It also does many minor things:\r\n * Clicking a structure/machine with an item on help intent never results in an attack (so you don't destroy a structure while trying to figure out which tool to use).\r\n * I moved a lot of objects away from /obj/effect, it should only be used for visual effects, decals and stuff, not for things you can hit and destroy.\r\n * I tweaked a bit how clothes shredding from bombs work.\r\n * I made a machine or structure un/anchorable with the wrench, I don't remember which object...\r\n * Since I changed the meaning of the FIRE_PROOF bitflag to actually mean fire immune, I'm buffing the slime extract that you apply on items to make them fire proof. well now they're really 100% fire proof!\r\n * animals with environment_smash = 1 no longer one-hit destroy tables and stuff, we give them a decent obj_damage value so they can destroy most obj relatively fast depending on the animal.\r\n * Probably a million things I forgot.\r\n\r\nIf you want to know how the damage system works all you need is the three obj vars \"obj_integrity\", \"max_integrity\", \"integrity_failure\", as well as the armor list var and the resistance_flags bitfield, and read the file obj_defense.dm\r\n\r\nStill need to do the changelog below\r\n:cl: phil235\r\nadd: stuff\r\ntweak: stuff\r\n/:cl:\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/252494899","html_url":"https://github.com/tgstation/tgstation/pull/20793#issuecomment-252494899","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/20793","id":252494899,"user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T16:02:28Z","updated_at":"2016-10-09T16:02:28Z","body":"@Militaires Nope."}}
{"actor":{"display_login":"phil235"}}