{"action":"created","issue":{"url":"https://api.github.com/repos/mcollina/pino/issues/113","repository_url":"https://api.github.com/repos/mcollina/pino","labels_url":"https://api.github.com/repos/mcollina/pino/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/mcollina/pino/issues/113/comments","events_url":"https://api.github.com/repos/mcollina/pino/issues/113/events","html_url":"https://github.com/mcollina/pino/pull/113","id":184487928,"number":113,"title":"Correctly escape all the values according to RFC","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T13:42:19Z","updated_at":"2016-10-21T13:45:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcollina/pino/pulls/113","html_url":"https://github.com/mcollina/pino/pull/113","diff_url":"https://github.com/mcollina/pino/pull/113.diff","patch_url":"https://github.com/mcollina/pino/pull/113.patch"},"body":"https://tools.ietf.org/html/rfc7159#section-7\r\n\r\ncc @mstade @jsumners @davidmarkclements please check.\r\n\r\nFixes #112."},"comment":{"url":"https://api.github.com/repos/mcollina/pino/issues/comments/255380800","html_url":"https://github.com/mcollina/pino/pull/113#issuecomment-255380800","issue_url":"https://api.github.com/repos/mcollina/pino/issues/113","id":255380800,"user":{"login":"mstade","id":605731,"avatar_url":"https://avatars.githubusercontent.com/u/605731?v=3","gravatar_id":"","url":"https://api.github.com/users/mstade","html_url":"https://github.com/mstade","followers_url":"https://api.github.com/users/mstade/followers","following_url":"https://api.github.com/users/mstade/following{/other_user}","gists_url":"https://api.github.com/users/mstade/gists{/gist_id}","starred_url":"https://api.github.com/users/mstade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstade/subscriptions","organizations_url":"https://api.github.com/users/mstade/orgs","repos_url":"https://api.github.com/users/mstade/repos","events_url":"https://api.github.com/users/mstade/events{/privacy}","received_events_url":"https://api.github.com/users/mstade/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T13:44:59Z","updated_at":"2016-10-21T13:44:59Z","body":"I don't think this tests all characters that must be escaped (or I'm misreading the spec):\r\n\r\n> All Unicode characters may be placed within the quotation marks, except for the characters that must be escaped: quotation mark, reverse solidus, and the control characters (U+0000 through U+001F).\r\n\r\nI updated my PR with a new test to reflect the above quote: https://github.com/mcollina/pino/pull/112/commits/924ef6ffff3e34c8c81c063acef2e2e7aa612fd6\r\n\r\nLike I said though, maybe I'm misunderstanding the thing!"}}
{"actor":{"display_login":"mstade"}}