{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/131","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/131/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/131/events","html_url":"https://github.com/trilinos/Trilinos/issues/131","id":131547640,"number":131,"title":"Ifpack2: More modular software architecture (esp. triangular solves & ILU)","user":{"login":"mhoemmen","id":926747,"avatar_url":"https://avatars.githubusercontent.com/u/926747?v=3","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Ifpack2","name":"Ifpack2","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-02-05T03:54:20Z","updated_at":"2016-08-24T22:40:54Z","closed_at":"2016-08-24T22:40:54Z","body":"@trilinos/ifpack2 @trilinos/amesos2 \r\n\r\nThis relates to the recent addition of Basker's thread-parallel incomplete LU factorization (ILU) to `Ifpack2::RILUK`.  I really appreciate all the work that people are doing in Ifpack2 to improve support for thread parallelism.  \r\n\r\nWhat I see happening is that a lot of us are patching what amount to entirely new preconditioners, into existing classes.  I've been doing that with BlockCrsMatrix, and others have been doing that with other classes.  I think that's OK for prototyping, but I worry that eventually it will make the classes super complicated.  It may also add complication time.\r\n\r\nIt would be good to remember LinearSolver and LinearSolverFactory at this point.  We already have plenty of different ways to achieve abstraction.  For example, maybe it's appropriate to treat thread-parallel sparse triangular solves as an \"inner solver.\"  If we don't want to expose a new solver in Ifpack2's public interface, we can put it in the `Ifpack2::Details` namespace.  I'm not sure if we have to worry about it for Basker, but I want people to keep this in mind going forward.\r\n\r\nThanks all!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/242230880","html_url":"https://github.com/trilinos/Trilinos/issues/131#issuecomment-242230880","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/131","id":242230880,"user":{"login":"mhoemmen","id":926747,"avatar_url":"https://avatars.githubusercontent.com/u/926747?v=3","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T22:40:54Z","updated_at":"2016-08-24T22:40:54Z","body":"Discussion has been good.  I think we can close this overarching issue and focus on the individual cases.  Thanks all!"}}
{"actor":{"display_login":"mhoemmen"}}