{"action":"created","issue":{"url":"https://api.github.com/repos/metabase/metabase/issues/3738","repository_url":"https://api.github.com/repos/metabase/metabase","labels_url":"https://api.github.com/repos/metabase/metabase/issues/3738/labels{/name}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/3738/comments","events_url":"https://api.github.com/repos/metabase/metabase/issues/3738/events","html_url":"https://github.com/metabase/metabase/pull/3738","id":187801237,"number":3738,"title":"Query builder bug fixes [WIP]","user":{"login":"tlrobinson","id":18193,"avatar_url":"https://avatars.githubusercontent.com/u/18193?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrobinson","html_url":"https://github.com/tlrobinson","followers_url":"https://api.github.com/users/tlrobinson/followers","following_url":"https://api.github.com/users/tlrobinson/following{/other_user}","gists_url":"https://api.github.com/users/tlrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrobinson/subscriptions","organizations_url":"https://api.github.com/users/tlrobinson/orgs","repos_url":"https://api.github.com/users/tlrobinson/repos","events_url":"https://api.github.com/users/tlrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/tlrobinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-07T19:15:09Z","updated_at":"2016-11-14T23:05:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/3738","html_url":"https://github.com/metabase/metabase/pull/3738","diff_url":"https://github.com/metabase/metabase/pull/3738.diff","patch_url":"https://github.com/metabase/metabase/pull/3738.patch"},"body":"- [x] Clear old state, including `queryResult`, immediately upon returning to qb\r\n  - [x] Prevent previous query from appearing briefly while metadata loads\r\n  - [x] Table list doesn't close when moving off a new question and returning. Resolves #3645\r\n  - [x] I shouldn't be able to select filters, view options, or groupings until I've chosen a table. Resolves #3171\r\n- [x] If the card is saved but dirty use `MetabaseApi.dataset` instead of `CardApi.query`.\r\n- [x] Saving a card causes the query to be re-run. Resolves #3467\r\n- [x] UI pulled back to query answer after navigating away from query while \"doing science\". Resolves #3416\r\n- [x] Cards / queries break and can't be modified if underlying column is removed. Resolves #1986\r\n- ~~Number displayed as a boolean #3506~~ (not qb issue)\r\n- [x] Mongo nested fields being displayed in the QB filter dropdown without the top level Resolves #3173"},"comment":{"url":"https://api.github.com/repos/metabase/metabase/issues/comments/260493126","html_url":"https://github.com/metabase/metabase/pull/3738#issuecomment-260493126","issue_url":"https://api.github.com/repos/metabase/metabase/issues/3738","id":260493126,"user":{"login":"tlrobinson","id":18193,"avatar_url":"https://avatars.githubusercontent.com/u/18193?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrobinson","html_url":"https://github.com/tlrobinson","followers_url":"https://api.github.com/users/tlrobinson/followers","following_url":"https://api.github.com/users/tlrobinson/following{/other_user}","gists_url":"https://api.github.com/users/tlrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrobinson/subscriptions","organizations_url":"https://api.github.com/users/tlrobinson/orgs","repos_url":"https://api.github.com/users/tlrobinson/repos","events_url":"https://api.github.com/users/tlrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/tlrobinson/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T23:05:47Z","updated_at":"2016-11-14T23:05:47Z","body":"@metabase/core-developers These should all be fixed. I might try to add some tests, but they're going to be tricky. In the meantime here are some things to try:\r\n\r\n1. Run a query, navigate away from the query builder (e.x. \"Pulses\"), then click \"New Question\". You should *not* briefly see the previous query result\r\n2. Click \"New Question\", click \"Questions\", click a previously saved (GUI) question. The db/table widget should *not* be open.\r\n3. Run a query, click \"New Question\", you should *not* be able to add a filter/aggregation/breakout until you select a db/table.\r\n4. Open a saved query, click the edit/pencil icon, change the query and run it. It should run the new query, not the old one.\r\n5. Save a query, it should *not* re-run it\r\n6. Run query that takes a long time (e.x. Postgres SQL query `select pg_sleep(10)`), click \"New Question\", the result of the old query should *not* appear. \r\n7. Run query that takes a long time (e.x. Postgres SQL query `select pg_sleep(10)`), navigate away from the query builder (e.x. \"Pulses\") then back to the query builder (e.x. \"New Question\") before the query should finish, the result of the old query should *not* appear.\r\n"}}
{"actor":{"display_login":"tlrobinson"}}