{"action":"created","issue":{"url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/32","repository_url":"https://api.github.com/repos/SRombauts/UE4GitPlugin","labels_url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/32/comments","events_url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/32/events","html_url":"https://github.com/SRombauts/UE4GitPlugin/pull/32","id":177753625,"number":32,"title":"LFS Diff Support","user":{"login":"thk123","id":638608,"avatar_url":"https://avatars.githubusercontent.com/u/638608?v=3","gravatar_id":"","url":"https://api.github.com/users/thk123","html_url":"https://github.com/thk123","followers_url":"https://api.github.com/users/thk123/followers","following_url":"https://api.github.com/users/thk123/following{/other_user}","gists_url":"https://api.github.com/users/thk123/gists{/gist_id}","starred_url":"https://api.github.com/users/thk123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thk123/subscriptions","organizations_url":"https://api.github.com/users/thk123/orgs","repos_url":"https://api.github.com/users/thk123/repos","events_url":"https://api.github.com/users/thk123/events{/privacy}","received_events_url":"https://api.github.com/users/thk123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-19T10:46:35Z","updated_at":"2016-09-19T16:29:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/pulls/32","html_url":"https://github.com/SRombauts/UE4GitPlugin/pull/32","diff_url":"https://github.com/SRombauts/UE4GitPlugin/pull/32.diff","patch_url":"https://github.com/SRombauts/UE4GitPlugin/pull/32.patch"},"body":"This extends the `RunDumpToFile` to handle LFS pointer files. It first checks if LFS is installed and the file is a pointer file. If it is, then it pipes the output from `git show` in to `git lfs smude` which is the command to retrieve the actual file contents. This is then saved to the same temp file that was previously being used.\r\n\r\nIf either the file isn't a pointer file or LFS isn't installed then it just outputs the file to the temp file as it did before. \r\n\r\nTo get this working - I needed to use `FInteractiveProcess` to both send data in and read data out of `git lfs smudge`. However, this didn't allow the setting of a Working Directory (which seemed to be equired for the LFS command to work). So I duplicated this class and added support for this. Ideally this change would be merged back into UE4. "},"comment":{"url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/comments/248043880","html_url":"https://github.com/SRombauts/UE4GitPlugin/pull/32#issuecomment-248043880","issue_url":"https://api.github.com/repos/SRombauts/UE4GitPlugin/issues/32","id":248043880,"user":{"login":"SRombauts","id":868490,"avatar_url":"https://avatars.githubusercontent.com/u/868490?v=3","gravatar_id":"","url":"https://api.github.com/users/SRombauts","html_url":"https://github.com/SRombauts","followers_url":"https://api.github.com/users/SRombauts/followers","following_url":"https://api.github.com/users/SRombauts/following{/other_user}","gists_url":"https://api.github.com/users/SRombauts/gists{/gist_id}","starred_url":"https://api.github.com/users/SRombauts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SRombauts/subscriptions","organizations_url":"https://api.github.com/users/SRombauts/orgs","repos_url":"https://api.github.com/users/SRombauts/repos","events_url":"https://api.github.com/users/SRombauts/events{/privacy}","received_events_url":"https://api.github.com/users/SRombauts/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T16:29:19Z","updated_at":"2016-09-19T16:29:19Z","body":"Thank you for sibmitting this!\r\n\r\nAre you by any chance using UE4 under OSX ? Because I was able to work with lfs under Windows without all this : lfs under Windows does not use symlinks but actual copy of files, or at least that was what I understood at that time... "}}
{"actor":{"display_login":"SRombauts"}}