{"comment":{"url":"https://api.github.com/repos/christinaa/rpi-open-firmware/comments/18940758","html_url":"https://github.com/christinaa/rpi-open-firmware/commit/9eed9d06e01a7f2c6dc2bd1e0138ce877ac10f5b#commitcomment-18940758","id":18940758,"user":{"login":"christinaa","id":2118877,"avatar_url":"https://avatars.githubusercontent.com/u/2118877?v=3","gravatar_id":"","url":"https://api.github.com/users/christinaa","html_url":"https://github.com/christinaa","followers_url":"https://api.github.com/users/christinaa/followers","following_url":"https://api.github.com/users/christinaa/following{/other_user}","gists_url":"https://api.github.com/users/christinaa/gists{/gist_id}","starred_url":"https://api.github.com/users/christinaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christinaa/subscriptions","organizations_url":"https://api.github.com/users/christinaa/orgs","repos_url":"https://api.github.com/users/christinaa/repos","events_url":"https://api.github.com/users/christinaa/events{/privacy}","received_events_url":"https://api.github.com/users/christinaa/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"9eed9d06e01a7f2c6dc2bd1e0138ce877ac10f5b","created_at":"2016-09-08T07:34:30Z","updated_at":"2016-09-08T07:34:30Z","body":"This is incorrect, in a DT:\r\n\r\n- The correct DT node is `/chosen/bootargs`, not `cmdline`.\r\n- Paths usually start with `/`, so you would go with `/chosen/bootargs`.\r\n- I believe you first would have to create the chosen node, get its nodeoffset and then use `fdt_appendprop` instead which appens a property to a node (you could check if the property already exists with `fdt_get_property`). To add a new node to a FDT you may need to use `fdt_add_subnode`."}}
{"actor":{"display_login":"christinaa"}}