{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/93010596","pull_request_review_id":13530392,"id":93010596,"diff_hunk":"@@ -478,6 +478,11 @@ cl::opt<LTOKind> ltoMode(\n                    \"Parallel importing and codegen (faster than 'full')\")));\n #endif\n \n+cl::list<std::string>\n+    dcomputeTargets(\"mdcompute-targets\", cl::CommaSeparated,\n+                     cl::desc(\"DCompute targets to generate for:OpenCl \"\n+                              \"(ocl-xy0 for x.y) CUDA (cuda-xy0 for cc x.y)\"),\n+                     cl::value_desc(\"ocl-210,cuda-350\"));","path":"driver/cl_options.cpp","position":8,"original_position":8,"commit_id":"c310f163dfce674cf36101c70381d976fc9f4262","original_commit_id":"c310f163dfce674cf36101c70381d976fc9f4262","user":{"login":"JohanEngelen","id":10983051,"avatar_url":"https://avatars.githubusercontent.com/u/10983051?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanEngelen","html_url":"https://github.com/JohanEngelen","followers_url":"https://api.github.com/users/JohanEngelen/followers","following_url":"https://api.github.com/users/JohanEngelen/following{/other_user}","gists_url":"https://api.github.com/users/JohanEngelen/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanEngelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanEngelen/subscriptions","organizations_url":"https://api.github.com/users/JohanEngelen/orgs","repos_url":"https://api.github.com/users/JohanEngelen/repos","events_url":"https://api.github.com/users/JohanEngelen/events{/privacy}","received_events_url":"https://api.github.com/users/JohanEngelen/received_events","type":"User","site_admin":false},"body":"With this `value_desc`, the -help output will be: `-mdcompute-targets=<ocl-210,cuda-350>`.\r\nSuggestion: `value_desc(\"targets\")`\r\n\r\nAlso needs a space between : and OpenCL (capital L).","created_at":"2016-12-19T11:05:18Z","updated_at":"2016-12-19T11:05:18Z","html_url":"https://github.com/ldc-developers/ldc/pull/1922#discussion_r93010596","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/93010596"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1922#discussion_r93010596"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922","id":98464774,"html_url":"https://github.com/ldc-developers/ldc/pull/1922","diff_url":"https://github.com/ldc-developers/ldc/pull/1922.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1922.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1922","number":1922,"state":"open","locked":false,"title":"[dcompute] target and codegen part 1","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"body":"Adds the command line option `-mdcompute-targets=` a comma separated\r\nlist of targets to generate for dcompute (cl_options.\\*), and hides\r\noptions added by the spirv backend.\r\n\r\nAdds an analogue to `CodeGenerator` (driver/dcomputecodegenerator.\\*)\r\nthat deputises to the targets (gen/dcomputetarget\\*) to do the code\r\ngeneration and add required metadata.\r\n\r\nAdds code to detect types from `ldc.dcomputetypes`, a module for magic\r\ntypes required for targeting SPIRV and NVPTX. Currently only `Pointer`\r\na struct containing a pointer to a specified address space mapped to\r\nthe correct addrspace for the given backend (gen/dcomputetypes.*\\).","created_at":"2016-12-18T04:58:59Z","updated_at":"2016-12-19T11:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5713a5817db0f611bc210d70b00eec659c5212f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1922/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/c310f163dfce674cf36101c70381d976fc9f4262","head":{"label":"thewilsonator:dcompute-target+codegen","ref":"dcompute-target+codegen","sha":"c310f163dfce674cf36101c70381d976fc9f4262","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"repo":{"id":62774759,"name":"ldc","full_name":"thewilsonator/ldc","owner":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thewilsonator/ldc","description":"The LLVM-based D compiler.","fork":true,"url":"https://api.github.com/repos/thewilsonator/ldc","forks_url":"https://api.github.com/repos/thewilsonator/ldc/forks","keys_url":"https://api.github.com/repos/thewilsonator/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewilsonator/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewilsonator/ldc/teams","hooks_url":"https://api.github.com/repos/thewilsonator/ldc/hooks","issue_events_url":"https://api.github.com/repos/thewilsonator/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/thewilsonator/ldc/events","assignees_url":"https://api.github.com/repos/thewilsonator/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/thewilsonator/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/thewilsonator/ldc/tags","blobs_url":"https://api.github.com/repos/thewilsonator/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewilsonator/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewilsonator/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewilsonator/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewilsonator/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/thewilsonator/ldc/languages","stargazers_url":"https://api.github.com/repos/thewilsonator/ldc/stargazers","contributors_url":"https://api.github.com/repos/thewilsonator/ldc/contributors","subscribers_url":"https://api.github.com/repos/thewilsonator/ldc/subscribers","subscription_url":"https://api.github.com/repos/thewilsonator/ldc/subscription","commits_url":"https://api.github.com/repos/thewilsonator/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewilsonator/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewilsonator/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewilsonator/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewilsonator/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/thewilsonator/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewilsonator/ldc/merges","archive_url":"https://api.github.com/repos/thewilsonator/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewilsonator/ldc/downloads","issues_url":"https://api.github.com/repos/thewilsonator/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/thewilsonator/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/thewilsonator/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/thewilsonator/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewilsonator/ldc/labels{/name}","releases_url":"https://api.github.com/repos/thewilsonator/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/thewilsonator/ldc/deployments","created_at":"2016-07-07T04:19:58Z","updated_at":"2016-09-20T05:33:40Z","pushed_at":"2016-12-18T09:24:22Z","git_url":"git://github.com/thewilsonator/ldc.git","ssh_url":"git@github.com:thewilsonator/ldc.git","clone_url":"https://github.com/thewilsonator/ldc.git","svn_url":"https://github.com/thewilsonator/ldc","homepage":"http://wiki.dlang.org/LDC","size":25445,"stargazers_count":3,"watchers_count":3,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ldc-developers:dcompute","ref":"dcompute","sha":"869f9d9207f123931b68e726c4ba8c9293b967e4","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-12-16T10:59:32Z","pushed_at":"2016-12-19T10:38:17Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":25198,"stargazers_count":517,"watchers_count":517,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":194,"forks":109,"open_issues":194,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1922"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1922"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1922/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1922/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/c310f163dfce674cf36101c70381d976fc9f4262"}}}}
{"actor":{"display_login":"JohanEngelen"}}