{"action":"created","issue":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/492","labels_url":"https://api.github.com/repos/cloudflare/cfssl/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/492/comments","events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/492/events","html_url":"https://github.com/cloudflare/cfssl/pull/492","id":128102752,"number":492,"title":"Zi/certdb abstraction","user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-22T07:50:41Z","updated_at":"2016-01-29T08:56:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/492","html_url":"https://github.com/cloudflare/cfssl/pull/492","diff_url":"https://github.com/cloudflare/cfssl/pull/492.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/492.patch"},"body":"Needs some comments on this approach. It is definitely making signer more entangled with certdb. But the benefits is now signer depends on the sql and certdb's DBAccessor interface, which doesn't bring in db drivers and sql formatters."},"comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments/176649508","html_url":"https://github.com/cloudflare/cfssl/pull/492#issuecomment-176649508","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/492","id":176649508,"user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T08:56:18Z","updated_at":"2016-01-29T08:56:18Z","body":"I still need to work on the db abstraction a little bit more because I want to get rid of setting both db and db accessor in a signer to have a certificate store in a db when issued."}}