{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/92847462","pull_request_review_id":13371201,"id":92847462,"diff_hunk":"@@ -110,29 +104,13 @@\n \t\t\t</button>\n \t\t</div>\n \n-\t\t<d2l-simple-overlay","path":"d2l-my-courses.html","position":20,"original_position":20,"commit_id":"e70de3b98049a92c33f4fc4ea55bcd94d24cec8b","original_commit_id":"e70de3b98049a92c33f4fc4ea55bcd94d24cec8b","user":{"login":"ctwomey1","id":1779270,"avatar_url":"https://avatars.githubusercontent.com/u/1779270?v=3","gravatar_id":"","url":"https://api.github.com/users/ctwomey1","html_url":"https://github.com/ctwomey1","followers_url":"https://api.github.com/users/ctwomey1/followers","following_url":"https://api.github.com/users/ctwomey1/following{/other_user}","gists_url":"https://api.github.com/users/ctwomey1/gists{/gist_id}","starred_url":"https://api.github.com/users/ctwomey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctwomey1/subscriptions","organizations_url":"https://api.github.com/users/ctwomey1/orgs","repos_url":"https://api.github.com/users/ctwomey1/repos","events_url":"https://api.github.com/users/ctwomey1/events{/privacy}","received_events_url":"https://api.github.com/users/ctwomey1/received_events","type":"User","site_admin":false},"body":"So my take on this whole thing was, my courses shouldn't know implementation details of all-courses.  Moving the overlay inside gives that responsibility to the view itself instead of my-courses managing it.  \r\n\r\nOverall i wanted all-courses to just be an element we drop on the page that opens an overlay.  If this was a generic component i would create a new polymer element so it could be used outside of an overlay though...","created_at":"2016-12-16T17:00:59Z","updated_at":"2016-12-16T17:00:59Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241#discussion_r92847462","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/92847462"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241#discussion_r92847462"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241","id":98189626,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/241","number":241,"state":"open","locked":false,"title":"Course live search","user":{"login":"ctwomey1","id":1779270,"avatar_url":"https://avatars.githubusercontent.com/u/1779270?v=3","gravatar_id":"","url":"https://api.github.com/users/ctwomey1","html_url":"https://github.com/ctwomey1","followers_url":"https://api.github.com/users/ctwomey1/followers","following_url":"https://api.github.com/users/ctwomey1/following{/other_user}","gists_url":"https://api.github.com/users/ctwomey1/gists{/gist_id}","starred_url":"https://api.github.com/users/ctwomey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctwomey1/subscriptions","organizations_url":"https://api.github.com/users/ctwomey1/orgs","repos_url":"https://api.github.com/users/ctwomey1/repos","events_url":"https://api.github.com/users/ctwomey1/events{/privacy}","received_events_url":"https://api.github.com/users/ctwomey1/received_events","type":"User","site_admin":false},"body":"Take 2 of my last pr.\r\n\r\nSome things of note:\r\n\r\n- Course image management behavior was causing too much coupling between the two views.  I'd consider partially coupling them together through the behavior, but i feel like the two views are fundamentally different.  Very open to suggestions, this was a \"make it work\" type of release\r\n- debounce functions weren't setup correctly before, i've made a change that should reduce request spam, as well as introduced more debounce \r\n- Polymer is really really bad at notifying for arrays with as much change as i'm doing.  As per the documentation i'm doing https://www.polymer-project.org/1.0/docs/devguide/model-data#override-dirty-check to make the courses correctly work.","created_at":"2016-12-15T16:57:43Z","updated_at":"2016-12-16T17:00:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"209e024c5c4c3b12edd5ec9372767fb152fe3bd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/241/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/e70de3b98049a92c33f4fc4ea55bcd94d24cec8b","head":{"label":"Brightspace:course-live-search","ref":"course-live-search","sha":"e70de3b98049a92c33f4fc4ea55bcd94d24cec8b","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2016-12-16T02:51:21Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":865,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"b4d7f94d2645529587b43aba8496f80654d1fbe8","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2016-12-16T02:51:21Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":865,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/241"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/241"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/e70de3b98049a92c33f4fc4ea55bcd94d24cec8b"}}}}
{"actor":{"display_login":"ctwomey1"}}