{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/842","repository_url":"https://api.github.com/repos/googleapis/toolkit","labels_url":"https://api.github.com/repos/googleapis/toolkit/issues/842/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/842/comments","events_url":"https://api.github.com/repos/googleapis/toolkit/issues/842/events","html_url":"https://github.com/googleapis/toolkit/issues/842","id":194666723,"number":842,"title":"[NodeJS][LRO] can't find the metadata or response when it's not imported","user":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"labels":[{"id":365192221,"url":"https://api.github.com/repos/googleapis/toolkit/labels/NodeJS","name":"NodeJS","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"landrito","id":8572251,"avatar_url":"https://avatars.githubusercontent.com/u/8572251?v=3","gravatar_id":"","url":"https://api.github.com/users/landrito","html_url":"https://github.com/landrito","followers_url":"https://api.github.com/users/landrito/followers","following_url":"https://api.github.com/users/landrito/following{/other_user}","gists_url":"https://api.github.com/users/landrito/gists{/gist_id}","starred_url":"https://api.github.com/users/landrito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landrito/subscriptions","organizations_url":"https://api.github.com/users/landrito/orgs","repos_url":"https://api.github.com/users/landrito/repos","events_url":"https://api.github.com/users/landrito/events{/privacy}","received_events_url":"https://api.github.com/users/landrito/received_events","type":"User","site_admin":false},"assignees":[{"login":"landrito","id":8572251,"avatar_url":"https://avatars.githubusercontent.com/u/8572251?v=3","gravatar_id":"","url":"https://api.github.com/users/landrito","html_url":"https://github.com/landrito","followers_url":"https://api.github.com/users/landrito/followers","following_url":"https://api.github.com/users/landrito/following{/other_user}","gists_url":"https://api.github.com/users/landrito/gists{/gist_id}","starred_url":"https://api.github.com/users/landrito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landrito/subscriptions","organizations_url":"https://api.github.com/users/landrito/orgs","repos_url":"https://api.github.com/users/landrito/repos","events_url":"https://api.github.com/users/landrito/events{/privacy}","received_events_url":"https://api.github.com/users/landrito/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-09T18:38:33Z","updated_at":"2016-12-09T22:48:18Z","closed_at":null,"body":"This might affect other languages, but found this on NodeJS.\r\n\r\nFor cloud functions API, the LRO metadata is defined at https://github.com/googleapis/googleapis/blob/master/google/cloud/functions/v1beta2/operations.proto, but this proto file is not imported. When generating the GAPIC client with LRO configuring with this, this proto file won't be loaded and therefore it fails with\r\n```\r\n/path/to/google-cloud-node/packages/functions/src/v1beta2/cloud_functions_service_client.js:102\r\n      grpcClients.google.cloud.functions.v1beta2.OperationMetadataV1Beta2.decode),\r\n                                                                         ^\r\n\r\nTypeError: Cannot read property 'decode' of undefined\r\n    at new CloudFunctionsServiceClient (/path/to/google-cloud-node/packages/functions/src/v1beta2/cloud_functions_service_client.js:102:74)\r\n    at CloudFunctionsServiceClientBuilder.cloudFunctionsServiceClient (/path/to/google-cloud-node/packages/functions/src/v1beta2/cloud_functions_service_client.js:751:12)\r\n    at Object.<anonymous> (/path/to/google-cloud-node/packages/functions/foo.js:2:16)\r\n    at Module._compile (module.js:570:32)\r\n    at Object.Module._extensions..js (module.js:579:10)\r\n    at Module.load (module.js:487:32)\r\n    at tryModuleLoad (module.js:446:12)\r\n    at Function.Module._load (module.js:438:3)\r\n    at Module.runMain (module.js:604:10)\r\n    at run (bootstrap_node.js:394:7)\r\n```\r\n\r\nWe could fix this by adding the following line to functions.proto\r\n```protobuf\r\nimport \"google/cloud/functions/v1beta2/operations.proto\";\r\n```\r\n\r\nI'm not sure this is the right solution.\r\n\r\nTheoretically the same thing could happen for the final result type.\r\nThis might happen on other languages, although I'm not familiar with them."},"comment":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/comments/266144460","html_url":"https://github.com/googleapis/toolkit/issues/842#issuecomment-266144460","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/842","id":266144460,"user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T22:48:18Z","updated_at":"2016-12-09T22:48:18Z","body":"I don't think that missing this import line will cause problems in the Java GAPIC client - it might have to be tried to be sure, though. "}}
{"actor":{"display_login":"garrettjonesgoogle"}}