{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/21339","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21339/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21339/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21339/events","html_url":"https://github.com/elastic/elasticsearch/pull/21339","id":187352628,"number":21339,"title":"Assert status logger does not warn on Log4j usage","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"labels":[{"id":151561891,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Logging","name":":Logging","color":"009800","default":false},{"id":23173,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/bug","name":"bug","color":"9e2c2c","default":true},{"id":94283388,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc","default":false},{"id":463755193,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.0.1","name":"v5.0.1","color":"dddddd","default":false},{"id":408109539,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.1.0","name":"v5.1.0","color":"dddddd","default":false},{"id":334286612,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.0.0","name":"v6.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-04T14:49:24Z","updated_at":"2016-11-04T16:14:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21339","html_url":"https://github.com/elastic/elasticsearch/pull/21339","diff_url":"https://github.com/elastic/elasticsearch/pull/21339.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/21339.patch"},"body":"Today if you start Elasticsearch with the status logger configured to\r\nthe warn level, or use a transport client with the default status logger\r\nlevel, you will see warn messages about deprecation loggers being\r\ncreated with different message factories and that formatting might be\r\nbroken. This happens because the deprecation logger is constructed using\r\nthe message factory from its parent, an artifact leftover from the first\r\nLog4j 2 implementation that used a custom message factory. When that\r\ncustom message factory was removed, this constructor invocation should\r\nhave been changed to not explicitly use the message factory from the\r\nparent. This commit fixes this invocation. However, we also had some\r\nstatus checking to all tests to ensure that there are no warn status log\r\nmessages that might indicate a configuration problem with Log4j 2. These\r\nassertions blow up badly without the fix for the deprecation logger\r\nconstruction, and also caught a misconfiguration in one of the logging\r\ntests."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/258475968","html_url":"https://github.com/elastic/elasticsearch/pull/21339#issuecomment-258475968","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21339","id":258475968,"user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T16:14:34Z","updated_at":"2016-11-04T16:14:34Z","body":"> Semi unrelated question: why do we have all those log4j property files under evil tests? Why isn't the property file packaged with the test framework good enough?\r\n\r\nThese configuration files are used in different tests to ensure that certain properties we desire work (for example, that we pick up configs in sub-directories of the config directory (these might be installed by plugins), that we give a nice error message if the config file is missing (we didn't previously), etc.))."}}
{"actor":{"display_login":"jasontedor"}}