{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/71073655","id":71073655,"diff_hunk":"@@ -155,6 +155,10 @@ sparkR.sparkContext <- function(\n \n   existingPort <- Sys.getenv(\"EXISTING_SPARKR_BACKEND_PORT\", \"\")\n   if (existingPort != \"\") {\n+    if (length(sparkPackages) != 0) {","path":"R/pkg/R/sparkR.R","position":4,"original_position":4,"commit_id":"b425540018881be644697c3a1468a3f5bebb9d9d","original_commit_id":"b425540018881be644697c3a1468a3f5bebb9d9d","user":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"body":"I looked into this and we get the unit test error because the check here isn't correct. So we get `sparkPackages`  as `\"\"` and in R the length of empty string is not 0 but 1. \r\n```\r\n> length(\"\")\r\n[1] 1\r\n```\r\nI think we should instead check the length of `packages` to be zero  ? (`packages` is a list created by splitting the input in `processSparkPackages`)","created_at":"2016-07-17T00:02:04Z","updated_at":"2016-07-17T00:02:04Z","html_url":"https://github.com/apache/spark/pull/14179#discussion_r71073655","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/14179","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/71073655"},"html":{"href":"https://github.com/apache/spark/pull/14179#discussion_r71073655"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/14179"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14179","id":77253079,"html_url":"https://github.com/apache/spark/pull/14179","diff_url":"https://github.com/apache/spark/pull/14179.diff","patch_url":"https://github.com/apache/spark/pull/14179.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/14179","number":14179,"state":"open","locked":false,"title":"[SPARK-16055][SPARKR] warning added while using sparkPackages with spark-submit","user":{"login":"krishnakalyan3","id":4648995,"avatar_url":"https://avatars.githubusercontent.com/u/4648995?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnakalyan3","html_url":"https://github.com/krishnakalyan3","followers_url":"https://api.github.com/users/krishnakalyan3/followers","following_url":"https://api.github.com/users/krishnakalyan3/following{/other_user}","gists_url":"https://api.github.com/users/krishnakalyan3/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnakalyan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnakalyan3/subscriptions","organizations_url":"https://api.github.com/users/krishnakalyan3/orgs","repos_url":"https://api.github.com/users/krishnakalyan3/repos","events_url":"https://api.github.com/users/krishnakalyan3/events{/privacy}","received_events_url":"https://api.github.com/users/krishnakalyan3/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nhttps://issues.apache.org/jira/browse/SPARK-16055\r\nsparkPackages - argument is passed and we detect that we are in the R script mode, we should print some warning like --packages flag should be used with with spark-submit\r\n\r\n## How was this patch tested?\r\nIn my system locally\r\n\r\n\r\n","created_at":"2016-07-13T09:01:10Z","updated_at":"2016-07-17T00:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10f6ffd7449ea0fc16674cc967c2334142a31259","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/14179/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/14179/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/14179/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/b425540018881be644697c3a1468a3f5bebb9d9d","head":{"label":"krishnakalyan3:spark-pkg","ref":"spark-pkg","sha":"b425540018881be644697c3a1468a3f5bebb9d9d","user":{"login":"krishnakalyan3","id":4648995,"avatar_url":"https://avatars.githubusercontent.com/u/4648995?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnakalyan3","html_url":"https://github.com/krishnakalyan3","followers_url":"https://api.github.com/users/krishnakalyan3/followers","following_url":"https://api.github.com/users/krishnakalyan3/following{/other_user}","gists_url":"https://api.github.com/users/krishnakalyan3/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnakalyan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnakalyan3/subscriptions","organizations_url":"https://api.github.com/users/krishnakalyan3/orgs","repos_url":"https://api.github.com/users/krishnakalyan3/repos","events_url":"https://api.github.com/users/krishnakalyan3/events{/privacy}","received_events_url":"https://api.github.com/users/krishnakalyan3/received_events","type":"User","site_admin":false},"repo":{"id":59521403,"name":"spark","full_name":"krishnakalyan3/spark","owner":{"login":"krishnakalyan3","id":4648995,"avatar_url":"https://avatars.githubusercontent.com/u/4648995?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnakalyan3","html_url":"https://github.com/krishnakalyan3","followers_url":"https://api.github.com/users/krishnakalyan3/followers","following_url":"https://api.github.com/users/krishnakalyan3/following{/other_user}","gists_url":"https://api.github.com/users/krishnakalyan3/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnakalyan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnakalyan3/subscriptions","organizations_url":"https://api.github.com/users/krishnakalyan3/orgs","repos_url":"https://api.github.com/users/krishnakalyan3/repos","events_url":"https://api.github.com/users/krishnakalyan3/events{/privacy}","received_events_url":"https://api.github.com/users/krishnakalyan3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnakalyan3/spark","description":"My Spark Mirror","fork":true,"url":"https://api.github.com/repos/krishnakalyan3/spark","forks_url":"https://api.github.com/repos/krishnakalyan3/spark/forks","keys_url":"https://api.github.com/repos/krishnakalyan3/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnakalyan3/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnakalyan3/spark/teams","hooks_url":"https://api.github.com/repos/krishnakalyan3/spark/hooks","issue_events_url":"https://api.github.com/repos/krishnakalyan3/spark/issues/events{/number}","events_url":"https://api.github.com/repos/krishnakalyan3/spark/events","assignees_url":"https://api.github.com/repos/krishnakalyan3/spark/assignees{/user}","branches_url":"https://api.github.com/repos/krishnakalyan3/spark/branches{/branch}","tags_url":"https://api.github.com/repos/krishnakalyan3/spark/tags","blobs_url":"https://api.github.com/repos/krishnakalyan3/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnakalyan3/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnakalyan3/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnakalyan3/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnakalyan3/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnakalyan3/spark/languages","stargazers_url":"https://api.github.com/repos/krishnakalyan3/spark/stargazers","contributors_url":"https://api.github.com/repos/krishnakalyan3/spark/contributors","subscribers_url":"https://api.github.com/repos/krishnakalyan3/spark/subscribers","subscription_url":"https://api.github.com/repos/krishnakalyan3/spark/subscription","commits_url":"https://api.github.com/repos/krishnakalyan3/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnakalyan3/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnakalyan3/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnakalyan3/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/krishnakalyan3/spark/contents/{+path}","compare_url":"https://api.github.com/repos/krishnakalyan3/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnakalyan3/spark/merges","archive_url":"https://api.github.com/repos/krishnakalyan3/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnakalyan3/spark/downloads","issues_url":"https://api.github.com/repos/krishnakalyan3/spark/issues{/number}","pulls_url":"https://api.github.com/repos/krishnakalyan3/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnakalyan3/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnakalyan3/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnakalyan3/spark/labels{/name}","releases_url":"https://api.github.com/repos/krishnakalyan3/spark/releases{/id}","deployments_url":"https://api.github.com/repos/krishnakalyan3/spark/deployments","created_at":"2016-05-23T22:02:53Z","updated_at":"2016-06-13T13:18:38Z","pushed_at":"2016-07-16T21:25:50Z","git_url":"git://github.com/krishnakalyan3/spark.git","ssh_url":"git@github.com:krishnakalyan3/spark.git","clone_url":"https://github.com/krishnakalyan3/spark.git","svn_url":"https://github.com/krishnakalyan3/spark","homepage":"","size":174539,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"772c213ec702c80d0f25aa6f30b2dffebfbe2d0d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-07-16T21:50:32Z","pushed_at":"2016-07-16T23:57:48Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":501322,"stargazers_count":9317,"watchers_count":9317,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8645,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":436,"forks":8645,"open_issues":436,"watchers":9317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/14179"},"html":{"href":"https://github.com/apache/spark/pull/14179"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/14179"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/14179/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/14179/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/14179/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/b425540018881be644697c3a1468a3f5bebb9d9d"}}}}
{"actor":{"display_login":"shivaram"}}