{"action":"created","issue":{"url":"https://api.github.com/repos/traject/traject/issues/122","labels_url":"https://api.github.com/repos/traject/traject/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/traject/traject/issues/122/comments","events_url":"https://api.github.com/repos/traject/traject/issues/122/events","html_url":"https://github.com/traject/traject/pull/122","id":126267227,"number":122,"title":"Be more forgiving about the record ID field","user":{"login":"billdueber","id":114006,"avatar_url":"https://avatars.githubusercontent.com/u/114006?v=3","gravatar_id":"","url":"https://api.github.com/users/billdueber","html_url":"https://github.com/billdueber","followers_url":"https://api.github.com/users/billdueber/followers","following_url":"https://api.github.com/users/billdueber/following{/other_user}","gists_url":"https://api.github.com/users/billdueber/gists{/gist_id}","starred_url":"https://api.github.com/users/billdueber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billdueber/subscriptions","organizations_url":"https://api.github.com/users/billdueber/orgs","repos_url":"https://api.github.com/users/billdueber/repos","events_url":"https://api.github.com/users/billdueber/events{/privacy}","received_events_url":"https://api.github.com/users/billdueber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-12T20:21:27Z","updated_at":"2016-01-12T20:30:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/traject/traject/pulls/122","html_url":"https://github.com/traject/traject/pull/122","diff_url":"https://github.com/traject/traject/pull/122.diff","patch_url":"https://github.com/traject/traject/pull/122.patch"},"body":"attn: @jcoyne. This seem like a reasonable way to handle it?\r\n\r\nDebugWriter errors out when encountering a record without\r\nan 'id' field (or, more generally, whatever is set in\r\n`debug_writer.idfield`).\r\n\r\nNew behavior is to emit a warning on first encounter, and use as the record id \r\n`record_no_N` (where N is the record position).\r\n\r\nThe warning reads:\r\n\r\n```ruby\r\n\"At least one record (##{context.position}) doesn't define field '#{@idfield}'.\r\nAll records are assumed to have a unique id. You can set which field to look in via the setting 'debug_writer.idfield'\"\r\n\r\n```\r\n\r\nTests added.\r\n"},"comment":{"url":"https://api.github.com/repos/traject/traject/issues/comments/171045142","html_url":"https://github.com/traject/traject/pull/122#issuecomment-171045142","issue_url":"https://api.github.com/repos/traject/traject/issues/122","id":171045142,"user":{"login":"billdueber","id":114006,"avatar_url":"https://avatars.githubusercontent.com/u/114006?v=3","gravatar_id":"","url":"https://api.github.com/users/billdueber","html_url":"https://github.com/billdueber","followers_url":"https://api.github.com/users/billdueber/followers","following_url":"https://api.github.com/users/billdueber/following{/other_user}","gists_url":"https://api.github.com/users/billdueber/gists{/gist_id}","starred_url":"https://api.github.com/users/billdueber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billdueber/subscriptions","organizations_url":"https://api.github.com/users/billdueber/orgs","repos_url":"https://api.github.com/users/billdueber/repos","events_url":"https://api.github.com/users/billdueber/events{/privacy}","received_events_url":"https://api.github.com/users/billdueber/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T20:30:22Z","updated_at":"2016-01-12T20:30:22Z","body":"Great. Once I get the problems with travis ironed out, I'll pull in these\nchanges and do a minor upgrade.\n\nOn Tue, Jan 12, 2016 at 3:25 PM, Justin Coyne <notifications@github.com>\nwrote:\n\n> Yes, this is great. Good job @billdueber <https://github.com/billdueber> !\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/traject/traject/pull/122#issuecomment-171043649>.\n>\n\n\n\n-- \nBill Dueber\nLibrary Systems Programmer\nUniversity of Michigan Library\n"}}