{"push_id":1395882511,"size":2,"distinct_size":1,"ref":"refs/heads/feature/apvs-672/upload-file-functionality","head":"4901d17887a7b831487201bfcfa40141a9a0b104","before":"25cf83e20f0779ca4d546ed8a20062b6e051655a","commits":[{"sha":"e5ca0542924ac573ac7428a729a77c1cd9d9eb16","author":{"name":"Thomas Rowe","email":"5392af4c06f75888a654e4076b61cb591abdf191@gmail.com"},"message":"Feature/apvs 349/add about child page to capture child details (#151)\n\nThe journey-information page now branches based on the value of child-relationship.\r\n\r\nRedirects to the about-child page if value is 'yes'.\r\nRedirects to the expenses page if value is 'no'.\r\nUpdated unit test for the route to cover this new branch.\r\nCleaned up the unit test to match our standard approach for testing routes.\r\nAdded validation on child-relationship to the domain object.\r\nUpdated unit test for the domain object.\r\nAdded the about-child page to capture details of children being brought along on a visit.\r\n\r\nAdded and cleaned up the HTML from the UX prototype.\r\nAdded GET and POST route. Redirects to expenses on submission.\r\nThe user can add additional children in the same fashion as the expense pages.\r\nAdded a domain object for capturing child details + validation.\r\nAdded validation field names for the about-child page.\r\nAdded unit tests for each of the new files.\r\nAdded insert-claim-child module.\r\nAdded integration test for insert module.\r\nRefactored the logic for checking age based on DOB into the common validator.\r\n\r\ndate-of-birth now uses this logic to check claimant is over 16 years of age.\r\nabout-child uses this logic to ensure children are 18 or younger.\r\nAdded unit tests for the new functions.\r\nAdded an error message for the person's age being incorrect.\r\nUpdated the end-to-end test to include the about-child page.\r\n\r\nWe now visit the page. Add child details, and then add a second child.\r\nUpdated the routeHelper to use the bodyParser in the same way the real application does.\r\n\r\nResolved an issue that meant setting the response body of POST requests was not working as expected in unit tests.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/apvs-external-web/commits/e5ca0542924ac573ac7428a729a77c1cd9d9eb16"},{"sha":"4901d17887a7b831487201bfcfa40141a9a0b104","author":{"name":"Michael Hall","email":"b191faaf53d62a84f6d88cc3b0224c1d811ddc10@kainos.com"},"message":"Merge branch 'develop' of github.com:ministryofjustice/apvs-external-web into feature/apvs-672/upload-file-functionality","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/apvs-external-web/commits/4901d17887a7b831487201bfcfa40141a9a0b104"}]}
{"actor":{"display_login":"msjhall138"}}