{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/completable-futures/pulls/comments/56761628","id":56761628,"diff_hunk":"@@ -0,0 +1,69 @@\n+/*\n+ * Copyright (c) 2016 Spotify AB\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package com.spotify.futures;\n+\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.rules.ExpectedException;\n+\n+import static org.hamcrest.CoreMatchers.is;\n+import static org.hamcrest.MatcherAssert.assertThat;\n+\n+public class FunctionsTest {","path":"src/test/java/com/spotify/futures/FunctionsTest.java","position":25,"original_position":25,"commit_id":"ab6422da5fa2e0c1b6e19671076c13cc9710b9c7","original_commit_id":"ab6422da5fa2e0c1b6e19671076c13cc9710b9c7","user":{"login":"mbruggmann","id":24575,"avatar_url":"https://avatars.githubusercontent.com/u/24575?v=3","gravatar_id":"","url":"https://api.github.com/users/mbruggmann","html_url":"https://github.com/mbruggmann","followers_url":"https://api.github.com/users/mbruggmann/followers","following_url":"https://api.github.com/users/mbruggmann/following{/other_user}","gists_url":"https://api.github.com/users/mbruggmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruggmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruggmann/subscriptions","organizations_url":"https://api.github.com/users/mbruggmann/orgs","repos_url":"https://api.github.com/users/mbruggmann/repos","events_url":"https://api.github.com/users/mbruggmann/events{/privacy}","received_events_url":"https://api.github.com/users/mbruggmann/received_events","type":"User","site_admin":false},"body":"Kind of. It's two commits at least, but I can split the PR as well if you prefer that.","created_at":"2016-03-20T09:44:10Z","updated_at":"2016-03-20T09:44:10Z","html_url":"https://github.com/spotify/completable-futures/pull/33#discussion_r56761628","pull_request_url":"https://api.github.com/repos/spotify/completable-futures/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/comments/56761628"},"html":{"href":"https://github.com/spotify/completable-futures/pull/33#discussion_r56761628"},"pull_request":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/completable-futures/pulls/33","id":63466089,"html_url":"https://github.com/spotify/completable-futures/pull/33","diff_url":"https://github.com/spotify/completable-futures/pull/33.diff","patch_url":"https://github.com/spotify/completable-futures/pull/33.patch","issue_url":"https://api.github.com/repos/spotify/completable-futures/issues/33","number":33,"state":"open","locked":false,"title":"Use a custom matcher to assert against CompletionStages.","user":{"login":"mbruggmann","id":24575,"avatar_url":"https://avatars.githubusercontent.com/u/24575?v=3","gravatar_id":"","url":"https://api.github.com/users/mbruggmann","html_url":"https://github.com/mbruggmann","followers_url":"https://api.github.com/users/mbruggmann/followers","following_url":"https://api.github.com/users/mbruggmann/following{/other_user}","gists_url":"https://api.github.com/users/mbruggmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruggmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruggmann/subscriptions","organizations_url":"https://api.github.com/users/mbruggmann/orgs","repos_url":"https://api.github.com/users/mbruggmann/repos","events_url":"https://api.github.com/users/mbruggmann/events{/privacy}","received_events_url":"https://api.github.com/users/mbruggmann/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-19T11:52:28Z","updated_at":"2016-03-20T09:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c131db303c8dd326967cb3c1246f2cef5944593e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/completable-futures/pulls/33/commits","review_comments_url":"https://api.github.com/repos/spotify/completable-futures/pulls/33/comments","review_comment_url":"https://api.github.com/repos/spotify/completable-futures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/completable-futures/issues/33/comments","statuses_url":"https://api.github.com/repos/spotify/completable-futures/statuses/ab6422da5fa2e0c1b6e19671076c13cc9710b9c7","head":{"label":"spotify:tests-cleanup","ref":"tests-cleanup","sha":"ab6422da5fa2e0c1b6e19671076c13cc9710b9c7","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":52595362,"name":"completable-futures","full_name":"spotify/completable-futures","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/completable-futures","description":"Convenience utilities for working with asynchronous Java 8","fork":false,"url":"https://api.github.com/repos/spotify/completable-futures","forks_url":"https://api.github.com/repos/spotify/completable-futures/forks","keys_url":"https://api.github.com/repos/spotify/completable-futures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/completable-futures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/completable-futures/teams","hooks_url":"https://api.github.com/repos/spotify/completable-futures/hooks","issue_events_url":"https://api.github.com/repos/spotify/completable-futures/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/completable-futures/events","assignees_url":"https://api.github.com/repos/spotify/completable-futures/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/completable-futures/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/completable-futures/tags","blobs_url":"https://api.github.com/repos/spotify/completable-futures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/completable-futures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/completable-futures/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/completable-futures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/completable-futures/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/completable-futures/languages","stargazers_url":"https://api.github.com/repos/spotify/completable-futures/stargazers","contributors_url":"https://api.github.com/repos/spotify/completable-futures/contributors","subscribers_url":"https://api.github.com/repos/spotify/completable-futures/subscribers","subscription_url":"https://api.github.com/repos/spotify/completable-futures/subscription","commits_url":"https://api.github.com/repos/spotify/completable-futures/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/completable-futures/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/completable-futures/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/completable-futures/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/completable-futures/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/completable-futures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/completable-futures/merges","archive_url":"https://api.github.com/repos/spotify/completable-futures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/completable-futures/downloads","issues_url":"https://api.github.com/repos/spotify/completable-futures/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/completable-futures/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/completable-futures/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/completable-futures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/completable-futures/labels{/name}","releases_url":"https://api.github.com/repos/spotify/completable-futures/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/completable-futures/deployments","created_at":"2016-02-26T09:56:53Z","updated_at":"2016-03-18T10:45:53Z","pushed_at":"2016-03-20T09:43:18Z","git_url":"git://github.com/spotify/completable-futures.git","ssh_url":"git@github.com:spotify/completable-futures.git","clone_url":"https://github.com/spotify/completable-futures.git","svn_url":"https://github.com/spotify/completable-futures","homepage":"","size":80,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"b42333ab7c680e047fc8393e01068e732849898b","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":52595362,"name":"completable-futures","full_name":"spotify/completable-futures","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/completable-futures","description":"Convenience utilities for working with asynchronous Java 8","fork":false,"url":"https://api.github.com/repos/spotify/completable-futures","forks_url":"https://api.github.com/repos/spotify/completable-futures/forks","keys_url":"https://api.github.com/repos/spotify/completable-futures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/completable-futures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/completable-futures/teams","hooks_url":"https://api.github.com/repos/spotify/completable-futures/hooks","issue_events_url":"https://api.github.com/repos/spotify/completable-futures/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/completable-futures/events","assignees_url":"https://api.github.com/repos/spotify/completable-futures/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/completable-futures/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/completable-futures/tags","blobs_url":"https://api.github.com/repos/spotify/completable-futures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/completable-futures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/completable-futures/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/completable-futures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/completable-futures/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/completable-futures/languages","stargazers_url":"https://api.github.com/repos/spotify/completable-futures/stargazers","contributors_url":"https://api.github.com/repos/spotify/completable-futures/contributors","subscribers_url":"https://api.github.com/repos/spotify/completable-futures/subscribers","subscription_url":"https://api.github.com/repos/spotify/completable-futures/subscription","commits_url":"https://api.github.com/repos/spotify/completable-futures/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/completable-futures/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/completable-futures/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/completable-futures/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/completable-futures/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/completable-futures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/completable-futures/merges","archive_url":"https://api.github.com/repos/spotify/completable-futures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/completable-futures/downloads","issues_url":"https://api.github.com/repos/spotify/completable-futures/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/completable-futures/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/completable-futures/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/completable-futures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/completable-futures/labels{/name}","releases_url":"https://api.github.com/repos/spotify/completable-futures/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/completable-futures/deployments","created_at":"2016-02-26T09:56:53Z","updated_at":"2016-03-18T10:45:53Z","pushed_at":"2016-03-20T09:43:18Z","git_url":"git://github.com/spotify/completable-futures.git","ssh_url":"git@github.com:spotify/completable-futures.git","clone_url":"https://github.com/spotify/completable-futures.git","svn_url":"https://github.com/spotify/completable-futures","homepage":"","size":80,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/33"},"html":{"href":"https://github.com/spotify/completable-futures/pull/33"},"issue":{"href":"https://api.github.com/repos/spotify/completable-futures/issues/33"},"comments":{"href":"https://api.github.com/repos/spotify/completable-futures/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/completable-futures/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/completable-futures/statuses/ab6422da5fa2e0c1b6e19671076c13cc9710b9c7"}}}}