{"action":"opened","issue":{"url":"https://api.github.com/repos/Victoire/victoire/issues/681","repository_url":"https://api.github.com/repos/Victoire/victoire","labels_url":"https://api.github.com/repos/Victoire/victoire/issues/681/labels{/name}","comments_url":"https://api.github.com/repos/Victoire/victoire/issues/681/comments","events_url":"https://api.github.com/repos/Victoire/victoire/issues/681/events","html_url":"https://github.com/Victoire/victoire/issues/681","id":188259657,"number":681,"title":"Refactor page modal display","user":{"login":"lenybernard","id":618536,"avatar_url":"https://avatars.githubusercontent.com/u/618536?v=3","gravatar_id":"","url":"https://api.github.com/users/lenybernard","html_url":"https://github.com/lenybernard","followers_url":"https://api.github.com/users/lenybernard/followers","following_url":"https://api.github.com/users/lenybernard/following{/other_user}","gists_url":"https://api.github.com/users/lenybernard/gists{/gist_id}","starred_url":"https://api.github.com/users/lenybernard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenybernard/subscriptions","organizations_url":"https://api.github.com/users/lenybernard/orgs","repos_url":"https://api.github.com/users/lenybernard/repos","events_url":"https://api.github.com/users/lenybernard/events{/privacy}","received_events_url":"https://api.github.com/users/lenybernard/received_events","type":"User","site_admin":false},"labels":[{"id":373288947,"url":"https://api.github.com/repos/Victoire/victoire/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":335196165,"url":"https://api.github.com/repos/Victoire/victoire/labels/Priority%20:%20Medium","name":"Priority : Medium","color":"fbca04","default":false},{"id":335196624,"url":"https://api.github.com/repos/Victoire/victoire/labels/Type%20:%20Technical%20debt","name":"Type : Technical debt","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-09T14:25:45Z","updated_at":"2016-11-09T14:25:45Z","closed_at":null,"body":"## Description\r\nIt is usefull to render the page's content in ajax.\r\n\r\n@MadeWilson made a workaround in the https://github.com/Victoire/victoire/blob/2.1/Bundle/PageBundle/Helper/PageHelper.php#L426 to load an alternative layout following a logical pattern. For example, for a page using a template using the `defaultLayout` layout, if we try to render it in ajax, then it will load at haphazard `modal_defaultLayout.html.twig`. But this template doesn't exists and it'll return an exception.\r\n\r\nThis is problematic.\r\n\r\n## Resolution Ideas\r\n\r\n- adding a `layout` GET parameter to the PageController@showAction to force the layout use\r\n- adding a way to define custom modal layouts\r\n- do LinkType listing this `modal` layout when choosing \"modal\" value for `target`\r\n- passing the `layout` parameter to the link generated by the `vic_link` extension\r\n- validating the default `modal.html.twig` use with any page\r\n\r\n## Related to\r\n\r\n| Bundle         |    --    | --             | --       |\r\n| -------------- |:--------:| --             | --       |\r\n| Analytics      |  | Page           | &#10004; |\r\n| Blog           |  | Query          |          |\r\n| BusinessEntity |          |Seo             |          |\r\n| BusinessPage   |          | Sitemap        |          |\r\n| Core           | &#10004; | Template       |  &#10004;  |\r\n| Criteria       |          | Twig           |          |\r\n| Filter         |          | User           |          |\r\n| Form           |          | ViewReference  |          |\r\n| I18n           |          | Widget         |          |\r\n| Media          |          | WidgetMap      |          |\r\n"}}
{"actor":{"display_login":"lenybernard"}}