{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2345","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2345/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2345/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2345/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2345","id":173403638,"number":2345,"title":"FIX: Properly convert hyperlink data to new table rows","user":{"login":"richaagarwal","id":354591,"avatar_url":"https://avatars.githubusercontent.com/u/354591?v=3","gravatar_id":"","url":"https://api.github.com/users/richaagarwal","html_url":"https://github.com/richaagarwal","followers_url":"https://api.github.com/users/richaagarwal/followers","following_url":"https://api.github.com/users/richaagarwal/following{/other_user}","gists_url":"https://api.github.com/users/richaagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/richaagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richaagarwal/subscriptions","organizations_url":"https://api.github.com/users/richaagarwal/orgs","repos_url":"https://api.github.com/users/richaagarwal/repos","events_url":"https://api.github.com/users/richaagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/richaagarwal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"richaagarwal","id":354591,"avatar_url":"https://avatars.githubusercontent.com/u/354591?v=3","gravatar_id":"","url":"https://api.github.com/users/richaagarwal","html_url":"https://github.com/richaagarwal","followers_url":"https://api.github.com/users/richaagarwal/followers","following_url":"https://api.github.com/users/richaagarwal/following{/other_user}","gists_url":"https://api.github.com/users/richaagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/richaagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richaagarwal/subscriptions","organizations_url":"https://api.github.com/users/richaagarwal/orgs","repos_url":"https://api.github.com/users/richaagarwal/repos","events_url":"https://api.github.com/users/richaagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/richaagarwal/received_events","type":"User","site_admin":false},"assignees":[{"login":"richaagarwal","id":354591,"avatar_url":"https://avatars.githubusercontent.com/u/354591?v=3","gravatar_id":"","url":"https://api.github.com/users/richaagarwal","html_url":"https://github.com/richaagarwal","followers_url":"https://api.github.com/users/richaagarwal/followers","following_url":"https://api.github.com/users/richaagarwal/following{/other_user}","gists_url":"https://api.github.com/users/richaagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/richaagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richaagarwal/subscriptions","organizations_url":"https://api.github.com/users/richaagarwal/orgs","repos_url":"https://api.github.com/users/richaagarwal/repos","events_url":"https://api.github.com/users/richaagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/richaagarwal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-26T08:57:56Z","updated_at":"2016-08-30T18:05:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2345","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2345","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2345.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2345.patch"},"body":"This should've been a part of the TableBlocks PR https://github.com/cfpb/cfgov-refresh/pull/2295 - an oversight on my part.  \r\n\r\n## Test\r\n\r\n- To see the problem, visit http://build.consumerfinance.gov/data-research/credit-card-data/college-credit-card-agreement/ and notice the rows are missing data.  \r\n- To see the fix, re-import prod data (`./refresh-data.sh production.sql`) & run migrations (`python cfgov/manage.py migrate --fake-initial`) & navigate to [http://localhost:8000/data-research/credit-card-data/college-credit-card-agreement/](http://localhost:8000/data-research/credit-card-data/college-credit-card-agreement/ ) to verify the correct data is there.\r\n\r\n\r\n## Note\r\n- I'm updating the migration itself as opposed to adding a new one since this hasn't been run on prod yet, and we don't really want to run the previous migration on prod data if we can help it. If you have strong objections to that, discuss! \r\n\r\n## Assignee\r\n- @cfpb/cfgov-backends \r\n- @sebworks "},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/243527293","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2345#issuecomment-243527293","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2345","id":243527293,"user":{"login":"richaagarwal","id":354591,"avatar_url":"https://avatars.githubusercontent.com/u/354591?v=3","gravatar_id":"","url":"https://api.github.com/users/richaagarwal","html_url":"https://github.com/richaagarwal","followers_url":"https://api.github.com/users/richaagarwal/followers","following_url":"https://api.github.com/users/richaagarwal/following{/other_user}","gists_url":"https://api.github.com/users/richaagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/richaagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richaagarwal/subscriptions","organizations_url":"https://api.github.com/users/richaagarwal/orgs","repos_url":"https://api.github.com/users/richaagarwal/repos","events_url":"https://api.github.com/users/richaagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/richaagarwal/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T18:05:35Z","updated_at":"2016-08-30T18:05:35Z","body":"@chosak Thanks for your detailed comments!\r\n\r\n- To test locally, it's easiest to use a prod dump. Recent dumps are a lot faster than before. The migration in question, `0006_update_tables.py` that is already in master is not going to be in prod until this PR gets merged in and also gets deployed, so we do not need to worry about that. \r\nYou might run something like\r\n`./refresh-data.sh production.sql` and then `python cfgov/manage.py migrate --fake-initial`. \r\n\r\n- I think that there could be a lot of variations to the data in the old Table type, but for purposes of migrating, we should just focus on the ones that exist and make sure those work. To that end, I'm not actually sure how useful unit tests would be.  I've done a visual gut-check of the pages that get updated. Here is the output from the migration:\r\n\r\n```\r\nUpdating tables in content field\r\nUpdating Table to a TableBlock on page College Credit Card Agreements of page type BrowsePage\r\nUpdating Table to a TableBlock on page Small Business Review Panels of page type BrowsePage\r\nUpdating Table to a TableBlock on page test to delete of page type BrowsePage\r\nUpdating Table to a TableBlock on page Adjudication Proceeding Rules of page type BrowsePage\r\nUpdating Table to a TableBlock on page Warning Letters of page type BrowsePage\r\nUpdating Table to a TableBlock on page Serving Your Country of page type SublandingPage\r\nUpdating Table to a TableBlock on page Civil Penalty Fund allocation schedule of page type LearnPage\r\nUpdating Table to a TableBlock on page Integrity Advance, LLC and James R. Carnes of page type DocumentDetailPage\r\nUpdating tables in full width text organisms\r\nUpdating Table to a TableBlock on page Testing options for Prepaid - LJ+KD of page type BlogPage\r\nUpdating Table to a TableBlock on page Title XIV Rules: Mortgage Origination of page type BrowsePage\r\nUpdating Table to a TableBlock on page Title XIV Rules: Mortgage Servicing of page type BrowsePage\r\nUpdating Table to a TableBlock on page Payments by Case of page type BrowsePage\r\nUpdating Table to a TableBlock on page System of Records Notices of page type BrowsePage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2012 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the fourth quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the fourth quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the fourth quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the fourth quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the third quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the second quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2011 of page type LearnPage\r\nUpdating Table to a TableBlock on page CFO update for the first quarter of fiscal year 2011 of page type LearnPage\r\n```\r\n\r\nOnce this is merged in, perhaps either @schaferjh or @sarahsimpson09 could do a review of the pages above. There are only about 13 unique ones.\r\n\r\n"}}
{"actor":{"display_login":"richaagarwal"}}