{"action":"created","comment":{"url":"https://api.github.com/repos/threadly/litesockets/pulls/comments/54682511","id":54682511,"diff_hunk":"@@ -319,4 +322,81 @@ public boolean isEncrypted() {\n     }\n     throw new IllegalStateException(\"Must Set the SSLEngine before starting Encryption!\");\n   }\n+  \n+  /**\n+   * \n+   * @author lwahlmeier\n+   *\n+   */\n+  private class TCPSocketOptions extends BaseClientOptions {\n+    \n+    @Override\n+    public boolean setTcpNoDelay(boolean enabled) {\n+        try {\n+          channel.socket().setTcpNoDelay(enabled);\n+          return true;","path":"src/main/java/org/threadly/litesockets/TCPClient.java","position":97,"original_position":97,"commit_id":"bd6b6848c845a754b026b3eaa42d31e0a7fb6d1b","original_commit_id":"bd6b6848c845a754b026b3eaa42d31e0a7fb6d1b","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"body":"So I am definitely open to other ideas.  I did the enum thing before, but depreciated it because it seemed to messy.  The true/false just indicates if it was able to set, it gets kind of awkward w/o it because certain socket level option can only be set at certain levels by certain OSes.  mainly the sent/recv buffers.  So true means you set it, false means you didnt and you cant set it at least to the value you you tried to set it at.  Certain things like setting udp options on a tcp connection will just always return false.","created_at":"2016-03-02T05:50:49Z","updated_at":"2016-03-02T05:50:49Z","html_url":"https://github.com/threadly/litesockets/pull/32#discussion_r54682511","pull_request_url":"https://api.github.com/repos/threadly/litesockets/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/comments/54682511"},"html":{"href":"https://github.com/threadly/litesockets/pull/32#discussion_r54682511"},"pull_request":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/threadly/litesockets/pulls/32","id":61325827,"html_url":"https://github.com/threadly/litesockets/pull/32","diff_url":"https://github.com/threadly/litesockets/pull/32.diff","patch_url":"https://github.com/threadly/litesockets/pull/32.patch","issue_url":"https://api.github.com/repos/threadly/litesockets/issues/32","number":32,"state":"open","locked":false,"title":"3.1.x updates","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"body":"minor interface additions/depreciation.  Some minor bug fixes.","created_at":"2016-03-01T23:18:29Z","updated_at":"2016-03-02T05:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f708a15ae173043ae94ead36243508e4aa241f18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/threadly/litesockets/pulls/32/commits","review_comments_url":"https://api.github.com/repos/threadly/litesockets/pulls/32/comments","review_comment_url":"https://api.github.com/repos/threadly/litesockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/threadly/litesockets/issues/32/comments","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/bd6b6848c845a754b026b3eaa42d31e0a7fb6d1b","head":{"label":"threadly:3.1.x-updates","ref":"3.1.x-updates","sha":"bd6b6848c845a754b026b3eaa42d31e0a7fb6d1b","user":{"login":"threadly","id":4627301,"avatar_url":"https://avatars.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"repo":{"id":29884068,"name":"litesockets","full_name":"threadly/litesockets","owner":{"login":"threadly","id":4627301,"avatar_url":"https://avatars.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/threadly/litesockets","description":"Light weight socket library which relies heavily on threadly concurrency tools.","fork":false,"url":"https://api.github.com/repos/threadly/litesockets","forks_url":"https://api.github.com/repos/threadly/litesockets/forks","keys_url":"https://api.github.com/repos/threadly/litesockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threadly/litesockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threadly/litesockets/teams","hooks_url":"https://api.github.com/repos/threadly/litesockets/hooks","issue_events_url":"https://api.github.com/repos/threadly/litesockets/issues/events{/number}","events_url":"https://api.github.com/repos/threadly/litesockets/events","assignees_url":"https://api.github.com/repos/threadly/litesockets/assignees{/user}","branches_url":"https://api.github.com/repos/threadly/litesockets/branches{/branch}","tags_url":"https://api.github.com/repos/threadly/litesockets/tags","blobs_url":"https://api.github.com/repos/threadly/litesockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threadly/litesockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threadly/litesockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/threadly/litesockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/{sha}","languages_url":"https://api.github.com/repos/threadly/litesockets/languages","stargazers_url":"https://api.github.com/repos/threadly/litesockets/stargazers","contributors_url":"https://api.github.com/repos/threadly/litesockets/contributors","subscribers_url":"https://api.github.com/repos/threadly/litesockets/subscribers","subscription_url":"https://api.github.com/repos/threadly/litesockets/subscription","commits_url":"https://api.github.com/repos/threadly/litesockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/threadly/litesockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/threadly/litesockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/threadly/litesockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/threadly/litesockets/contents/{+path}","compare_url":"https://api.github.com/repos/threadly/litesockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threadly/litesockets/merges","archive_url":"https://api.github.com/repos/threadly/litesockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threadly/litesockets/downloads","issues_url":"https://api.github.com/repos/threadly/litesockets/issues{/number}","pulls_url":"https://api.github.com/repos/threadly/litesockets/pulls{/number}","milestones_url":"https://api.github.com/repos/threadly/litesockets/milestones{/number}","notifications_url":"https://api.github.com/repos/threadly/litesockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threadly/litesockets/labels{/name}","releases_url":"https://api.github.com/repos/threadly/litesockets/releases{/id}","deployments_url":"https://api.github.com/repos/threadly/litesockets/deployments","created_at":"2015-01-26T22:05:45Z","updated_at":"2015-10-10T22:13:38Z","pushed_at":"2016-03-01T23:34:53Z","git_url":"git://github.com/threadly/litesockets.git","ssh_url":"git@github.com:threadly/litesockets.git","clone_url":"https://github.com/threadly/litesockets.git","svn_url":"https://github.com/threadly/litesockets","homepage":null,"size":631,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"threadly:master","ref":"master","sha":"1d4af2406fdf8354631fd39841f8bfbf529dfb45","user":{"login":"threadly","id":4627301,"avatar_url":"https://avatars.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"repo":{"id":29884068,"name":"litesockets","full_name":"threadly/litesockets","owner":{"login":"threadly","id":4627301,"avatar_url":"https://avatars.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/threadly/litesockets","description":"Light weight socket library which relies heavily on threadly concurrency tools.","fork":false,"url":"https://api.github.com/repos/threadly/litesockets","forks_url":"https://api.github.com/repos/threadly/litesockets/forks","keys_url":"https://api.github.com/repos/threadly/litesockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threadly/litesockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threadly/litesockets/teams","hooks_url":"https://api.github.com/repos/threadly/litesockets/hooks","issue_events_url":"https://api.github.com/repos/threadly/litesockets/issues/events{/number}","events_url":"https://api.github.com/repos/threadly/litesockets/events","assignees_url":"https://api.github.com/repos/threadly/litesockets/assignees{/user}","branches_url":"https://api.github.com/repos/threadly/litesockets/branches{/branch}","tags_url":"https://api.github.com/repos/threadly/litesockets/tags","blobs_url":"https://api.github.com/repos/threadly/litesockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threadly/litesockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threadly/litesockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/threadly/litesockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/{sha}","languages_url":"https://api.github.com/repos/threadly/litesockets/languages","stargazers_url":"https://api.github.com/repos/threadly/litesockets/stargazers","contributors_url":"https://api.github.com/repos/threadly/litesockets/contributors","subscribers_url":"https://api.github.com/repos/threadly/litesockets/subscribers","subscription_url":"https://api.github.com/repos/threadly/litesockets/subscription","commits_url":"https://api.github.com/repos/threadly/litesockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/threadly/litesockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/threadly/litesockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/threadly/litesockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/threadly/litesockets/contents/{+path}","compare_url":"https://api.github.com/repos/threadly/litesockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threadly/litesockets/merges","archive_url":"https://api.github.com/repos/threadly/litesockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threadly/litesockets/downloads","issues_url":"https://api.github.com/repos/threadly/litesockets/issues{/number}","pulls_url":"https://api.github.com/repos/threadly/litesockets/pulls{/number}","milestones_url":"https://api.github.com/repos/threadly/litesockets/milestones{/number}","notifications_url":"https://api.github.com/repos/threadly/litesockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threadly/litesockets/labels{/name}","releases_url":"https://api.github.com/repos/threadly/litesockets/releases{/id}","deployments_url":"https://api.github.com/repos/threadly/litesockets/deployments","created_at":"2015-01-26T22:05:45Z","updated_at":"2015-10-10T22:13:38Z","pushed_at":"2016-03-01T23:34:53Z","git_url":"git://github.com/threadly/litesockets.git","ssh_url":"git@github.com:threadly/litesockets.git","clone_url":"https://github.com/threadly/litesockets.git","svn_url":"https://github.com/threadly/litesockets","homepage":null,"size":631,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/32"},"html":{"href":"https://github.com/threadly/litesockets/pull/32"},"issue":{"href":"https://api.github.com/repos/threadly/litesockets/issues/32"},"comments":{"href":"https://api.github.com/repos/threadly/litesockets/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/threadly/litesockets/statuses/bd6b6848c845a754b026b3eaa42d31e0a7fb6d1b"}}}}