{"action":"created","comment":{"url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/comments/71995476","id":71995476,"diff_hunk":"@@ -48,29 +49,20 @@ class US_Core_EXPORT FrameworkFactory\n     FrameworkFactory(void);\n     virtual ~FrameworkFactory(void);\n \n+    FrameworkFactory(const FrameworkFactory&) = delete;\n+    FrameworkFactory& operator=(const FrameworkFactory&) = delete;\n+","path":"core/include/usFrameworkFactory.h","position":18,"original_position":18,"commit_id":"4a351c96b003299991ca585f0b452d3d1b489e68","original_commit_id":"4a351c96b003299991ca585f0b452d3d1b489e68","user":{"login":"saschazelzer","id":219045,"avatar_url":"https://avatars.githubusercontent.com/u/219045?v=3","gravatar_id":"","url":"https://api.github.com/users/saschazelzer","html_url":"https://github.com/saschazelzer","followers_url":"https://api.github.com/users/saschazelzer/followers","following_url":"https://api.github.com/users/saschazelzer/following{/other_user}","gists_url":"https://api.github.com/users/saschazelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/saschazelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschazelzer/subscriptions","organizations_url":"https://api.github.com/users/saschazelzer/orgs","repos_url":"https://api.github.com/users/saschazelzer/repos","events_url":"https://api.github.com/users/saschazelzer/events{/privacy}","received_events_url":"https://api.github.com/users/saschazelzer/received_events","type":"User","site_admin":false},"body":"I think we should make this class much simpler and remove all the constructors and assignment operators. This class has no state and it would be perfectly okay to copy it around.","created_at":"2016-07-24T21:02:43Z","updated_at":"2016-07-24T21:02:43Z","html_url":"https://github.com/CppMicroServices/CppMicroServices/pull/96#discussion_r71995476","pull_request_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/comments/71995476"},"html":{"href":"https://github.com/CppMicroServices/CppMicroServices/pull/96#discussion_r71995476"},"pull_request":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96","id":69713133,"html_url":"https://github.com/CppMicroServices/CppMicroServices/pull/96","diff_url":"https://github.com/CppMicroServices/CppMicroServices/pull/96.diff","patch_url":"https://github.com/CppMicroServices/CppMicroServices/pull/96.patch","issue_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/96","number":96,"state":"open","locked":false,"title":"Framework Listener and logging support","user":{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false},"body":"Implements FrameworkEvent, Framework Listeners and an internal Framework logger.\r\n\r\nCloses #40 \r\n\r\nSigned-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com","created_at":"2016-05-11T17:44:16Z","updated_at":"2016-07-24T21:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d6ad93abfa2055177c74ead74bd7ec666f813cc","assignee":{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/milestones/2","html_url":"https://github.com/CppMicroServices/CppMicroServices/milestones/Release%203.0","labels_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/milestones/2/labels","id":591281,"number":2,"title":"Release 3.0","description":"Support multiple sub-projects by re-organizing the overall project structure. The sub-projects are supposed to implement various OSGi related specifications.\r\n\r\nThe release will also contain a couple of feature additions.","creator":{"login":"saschazelzer","id":219045,"avatar_url":"https://avatars.githubusercontent.com/u/219045?v=3","gravatar_id":"","url":"https://api.github.com/users/saschazelzer","html_url":"https://github.com/saschazelzer","followers_url":"https://api.github.com/users/saschazelzer/followers","following_url":"https://api.github.com/users/saschazelzer/following{/other_user}","gists_url":"https://api.github.com/users/saschazelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/saschazelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschazelzer/subscriptions","organizations_url":"https://api.github.com/users/saschazelzer/orgs","repos_url":"https://api.github.com/users/saschazelzer/repos","events_url":"https://api.github.com/users/saschazelzer/events{/privacy}","received_events_url":"https://api.github.com/users/saschazelzer/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":32,"state":"open","created_at":"2014-03-08T12:44:14Z","updated_at":"2016-07-18T17:57:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96/commits","review_comments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96/comments","review_comment_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/96/comments","statuses_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/statuses/4a351c96b003299991ca585f0b452d3d1b489e68","head":{"label":"CppMicroServices:40-framework-logger-fixes","ref":"40-framework-logger-fixes","sha":"4a351c96b003299991ca585f0b452d3d1b489e68","user":{"login":"CppMicroServices","id":14895880,"avatar_url":"https://avatars.githubusercontent.com/u/14895880?v=3","gravatar_id":"","url":"https://api.github.com/users/CppMicroServices","html_url":"https://github.com/CppMicroServices","followers_url":"https://api.github.com/users/CppMicroServices/followers","following_url":"https://api.github.com/users/CppMicroServices/following{/other_user}","gists_url":"https://api.github.com/users/CppMicroServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CppMicroServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CppMicroServices/subscriptions","organizations_url":"https://api.github.com/users/CppMicroServices/orgs","repos_url":"https://api.github.com/users/CppMicroServices/repos","events_url":"https://api.github.com/users/CppMicroServices/events{/privacy}","received_events_url":"https://api.github.com/users/CppMicroServices/received_events","type":"Organization","site_admin":false},"repo":{"id":3569726,"name":"CppMicroServices","full_name":"CppMicroServices/CppMicroServices","owner":{"login":"CppMicroServices","id":14895880,"avatar_url":"https://avatars.githubusercontent.com/u/14895880?v=3","gravatar_id":"","url":"https://api.github.com/users/CppMicroServices","html_url":"https://github.com/CppMicroServices","followers_url":"https://api.github.com/users/CppMicroServices/followers","following_url":"https://api.github.com/users/CppMicroServices/following{/other_user}","gists_url":"https://api.github.com/users/CppMicroServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CppMicroServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CppMicroServices/subscriptions","organizations_url":"https://api.github.com/users/CppMicroServices/orgs","repos_url":"https://api.github.com/users/CppMicroServices/repos","events_url":"https://api.github.com/users/CppMicroServices/events{/privacy}","received_events_url":"https://api.github.com/users/CppMicroServices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CppMicroServices/CppMicroServices","description":"An OSGi-like C++ dynamic module system and service registry","fork":false,"url":"https://api.github.com/repos/CppMicroServices/CppMicroServices","forks_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/forks","keys_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/teams","hooks_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/hooks","issue_events_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/events{/number}","events_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/events","assignees_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/assignees{/user}","branches_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/branches{/branch}","tags_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/tags","blobs_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/statuses/{sha}","languages_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/languages","stargazers_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/stargazers","contributors_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/contributors","subscribers_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/subscribers","subscription_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/subscription","commits_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/contents/{+path}","compare_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/merges","archive_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/downloads","issues_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues{/number}","pulls_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls{/number}","milestones_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/milestones{/number}","notifications_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/labels{/name}","releases_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/releases{/id}","deployments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/deployments","created_at":"2012-02-28T09:32:28Z","updated_at":"2016-06-30T03:50:27Z","pushed_at":"2016-07-24T08:32:52Z","git_url":"git://github.com/CppMicroServices/CppMicroServices.git","ssh_url":"git@github.com:CppMicroServices/CppMicroServices.git","clone_url":"https://github.com/CppMicroServices/CppMicroServices.git","svn_url":"https://github.com/CppMicroServices/CppMicroServices","homepage":"http://cppmicroservices.org","size":7248,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":30,"forks":32,"open_issues":30,"watchers":80,"default_branch":"master"}},"base":{"label":"CppMicroServices:development","ref":"development","sha":"484ded4662563cfd3b09a6423578af0ca21608b3","user":{"login":"CppMicroServices","id":14895880,"avatar_url":"https://avatars.githubusercontent.com/u/14895880?v=3","gravatar_id":"","url":"https://api.github.com/users/CppMicroServices","html_url":"https://github.com/CppMicroServices","followers_url":"https://api.github.com/users/CppMicroServices/followers","following_url":"https://api.github.com/users/CppMicroServices/following{/other_user}","gists_url":"https://api.github.com/users/CppMicroServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CppMicroServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CppMicroServices/subscriptions","organizations_url":"https://api.github.com/users/CppMicroServices/orgs","repos_url":"https://api.github.com/users/CppMicroServices/repos","events_url":"https://api.github.com/users/CppMicroServices/events{/privacy}","received_events_url":"https://api.github.com/users/CppMicroServices/received_events","type":"Organization","site_admin":false},"repo":{"id":3569726,"name":"CppMicroServices","full_name":"CppMicroServices/CppMicroServices","owner":{"login":"CppMicroServices","id":14895880,"avatar_url":"https://avatars.githubusercontent.com/u/14895880?v=3","gravatar_id":"","url":"https://api.github.com/users/CppMicroServices","html_url":"https://github.com/CppMicroServices","followers_url":"https://api.github.com/users/CppMicroServices/followers","following_url":"https://api.github.com/users/CppMicroServices/following{/other_user}","gists_url":"https://api.github.com/users/CppMicroServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CppMicroServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CppMicroServices/subscriptions","organizations_url":"https://api.github.com/users/CppMicroServices/orgs","repos_url":"https://api.github.com/users/CppMicroServices/repos","events_url":"https://api.github.com/users/CppMicroServices/events{/privacy}","received_events_url":"https://api.github.com/users/CppMicroServices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CppMicroServices/CppMicroServices","description":"An OSGi-like C++ dynamic module system and service registry","fork":false,"url":"https://api.github.com/repos/CppMicroServices/CppMicroServices","forks_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/forks","keys_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/teams","hooks_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/hooks","issue_events_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/events{/number}","events_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/events","assignees_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/assignees{/user}","branches_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/branches{/branch}","tags_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/tags","blobs_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/statuses/{sha}","languages_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/languages","stargazers_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/stargazers","contributors_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/contributors","subscribers_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/subscribers","subscription_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/subscription","commits_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/contents/{+path}","compare_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/merges","archive_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/downloads","issues_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues{/number}","pulls_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls{/number}","milestones_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/milestones{/number}","notifications_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/labels{/name}","releases_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/releases{/id}","deployments_url":"https://api.github.com/repos/CppMicroServices/CppMicroServices/deployments","created_at":"2012-02-28T09:32:28Z","updated_at":"2016-06-30T03:50:27Z","pushed_at":"2016-07-24T08:32:52Z","git_url":"git://github.com/CppMicroServices/CppMicroServices.git","ssh_url":"git@github.com:CppMicroServices/CppMicroServices.git","clone_url":"https://github.com/CppMicroServices/CppMicroServices.git","svn_url":"https://github.com/CppMicroServices/CppMicroServices","homepage":"http://cppmicroservices.org","size":7248,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":30,"forks":32,"open_issues":30,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96"},"html":{"href":"https://github.com/CppMicroServices/CppMicroServices/pull/96"},"issue":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/96"},"comments":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/CppMicroServices/CppMicroServices/statuses/4a351c96b003299991ca585f0b452d3d1b489e68"}}}}
{"actor":{"display_login":"saschazelzer"}}