{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/77574538","id":77574538,"diff_hunk":"@@ -166,9 +166,10 @@ func (kl *Kubelet) initialNode() (*api.Node, error) {\n \t\tObjectMeta: api.ObjectMeta{\n \t\t\tName: kl.nodeName,\n \t\t\tLabels: map[string]string{\n-\t\t\t\tunversioned.LabelHostname: kl.hostname,\n-\t\t\t\tunversioned.LabelOS:       goRuntime.GOOS,\n-\t\t\t\tunversioned.LabelArch:     goRuntime.GOARCH,\n+\t\t\t\tunversioned.LabelHostname:       kl.hostname,\n+\t\t\t\tunversioned.LabelOS:             goRuntime.GOOS,\n+\t\t\t\tunversioned.LabelArch:           goRuntime.GOARCH,\n+\t\t\t\tunversioned.LabelFluentdDsReady: \"true\",","path":"pkg/kubelet/kubelet_node_status.go","position":10,"original_position":10,"commit_id":"8b1b532c9de089751cea4c9704e2b51203de1afe","original_commit_id":"8b1b532c9de089751cea4c9704e2b51203de1afe","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"body":"The question is how many past version of Kubelet do we want to support. @dchen1107 any ideas?","created_at":"2016-09-06T05:16:40Z","updated_at":"2016-09-06T05:16:40Z","html_url":"https://github.com/kubernetes/kubernetes/pull/32088#discussion_r77574538","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/77574538"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32088#discussion_r77574538"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088","id":84035471,"html_url":"https://github.com/kubernetes/kubernetes/pull/32088","diff_url":"https://github.com/kubernetes/kubernetes/pull/32088.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32088.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32088","number":32088,"state":"open","locked":false,"title":"Migrated fluentd addon to daemon set","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"body":"fix #23224\r\nsupersedes #23306 \r\n\r\n```release-note\r\nMigrated fluentd addon to daemon set\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32088)\n<!-- Reviewable:end -->\n","created_at":"2016-09-05T19:44:31Z","updated_at":"2016-09-06T05:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f80bc011b5405be1a957b7916766f093a1219993","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"https://github.com/kubernetes/features/blob/master/release-1.4/Release-1.4.md","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":213,"closed_issues":696,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-09-06T05:09:07Z","due_on":"2016-09-20T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32088/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8b1b532c9de089751cea4c9704e2b51203de1afe","head":{"label":"piosz:fluentd-daemon-set","ref":"fluentd-daemon-set","sha":"8b1b532c9de089751cea4c9704e2b51203de1afe","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"repo":{"id":30922782,"name":"kubernetes","full_name":"piosz/kubernetes","owner":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piosz/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/piosz/kubernetes","forks_url":"https://api.github.com/repos/piosz/kubernetes/forks","keys_url":"https://api.github.com/repos/piosz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piosz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piosz/kubernetes/teams","hooks_url":"https://api.github.com/repos/piosz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/piosz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/piosz/kubernetes/events","assignees_url":"https://api.github.com/repos/piosz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/piosz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/piosz/kubernetes/tags","blobs_url":"https://api.github.com/repos/piosz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piosz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piosz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/piosz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piosz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/piosz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/piosz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/piosz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/piosz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/piosz/kubernetes/subscription","commits_url":"https://api.github.com/repos/piosz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/piosz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/piosz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/piosz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/piosz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/piosz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piosz/kubernetes/merges","archive_url":"https://api.github.com/repos/piosz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piosz/kubernetes/downloads","issues_url":"https://api.github.com/repos/piosz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/piosz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/piosz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/piosz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piosz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/piosz/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/piosz/kubernetes/deployments","created_at":"2015-02-17T15:23:02Z","updated_at":"2016-01-12T14:51:54Z","pushed_at":"2016-09-05T19:40:57Z","git_url":"git://github.com/piosz/kubernetes.git","ssh_url":"git@github.com:piosz/kubernetes.git","clone_url":"https://github.com/piosz/kubernetes.git","svn_url":"https://github.com/piosz/kubernetes","homepage":"http://kubernetes.io","size":313679,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"02dd17803988c6bfa619a8951177a5d125f6188d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-06T04:54:25Z","pushed_at":"2016-09-06T05:09:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":557901,"stargazers_count":16539,"watchers_count":16539,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5333,"mirror_url":null,"open_issues_count":4404,"forks":5333,"open_issues":4404,"watchers":16539,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32088"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32088"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32088/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32088/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8b1b532c9de089751cea4c9704e2b51203de1afe"}}}}
{"actor":{"display_login":"piosz"}}