{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/487","repository_url":"https://api.github.com/repos/saltstack/salt-winrepo-ng","labels_url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/487/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/487/comments","events_url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/487/events","html_url":"https://github.com/saltstack/salt-winrepo-ng/issues/487","id":160045792,"number":487,"title":"travis-ci new sls file setting \"skip_urltest\" is leading to yaml compilation error","user":{"login":"TheBigBear","id":471105,"avatar_url":"https://avatars.githubusercontent.com/u/471105?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBigBear","html_url":"https://github.com/TheBigBear","followers_url":"https://api.github.com/users/TheBigBear/followers","following_url":"https://api.github.com/users/TheBigBear/following{/other_user}","gists_url":"https://api.github.com/users/TheBigBear/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBigBear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBigBear/subscriptions","organizations_url":"https://api.github.com/users/TheBigBear/orgs","repos_url":"https://api.github.com/users/TheBigBear/repos","events_url":"https://api.github.com/users/TheBigBear/events{/privacy}","received_events_url":"https://api.github.com/users/TheBigBear/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-13T21:10:40Z","updated_at":"2016-06-18T14:47:30Z","closed_at":null,"body":"the new (and unofficial) setting 'skip_urltest' in sls file (e.g. duplicati.sls) leads to yaml compilation problem report. :-(\r\n\r\nwhen running ```salt-run winrepo.genrepo``` on a 2016.3.0 master you get \r\n\r\n```\r\nevent:\r\n    ----------\r\n    error:\r\n        Failed to compile /srv/salt/win/repo/salt-winrepo/duplicati.sls.\r\nsuffix:\r\n    progress\r\nevent:\r\n    ----------\r\n    error:\r\n        Failed to compile /srv/salt/win/repo/salt-winrepo/duplicati_x86.sls.\r\nsuffix:\r\n    progress\r\n```\r\n\r\n@moebiuseye was kind enough to help me, a non-programmer, to get the travis-ci tests running again and in the process he 'invented' a new switch in the sls file that allows travis-ci to know when the 404 urltest should not be run against a particular sls file.\r\n\r\nThis new setting 'skip_urltest' works just fine, but unfortunately it results in the above yaml compilation error.\r\n\r\nQuestion mainly to @moebiuseye could you please think about re-working the 'skip_urltest' workaround and maybe add a 'skip_urltest' section to the ```.travis/travis.yml``` or maybe a new ```.travis/skip_urltest``` or ```.travis/urltest_skip``` file that would contain  a simple one per line list of sls file names where the 404 url test should not be run against? \r\n\r\nAlso at same time it might be good to get the travis tests to start to be modular, so there can be other tests (and some of them might need 'skip' files or sections as well?) There are of course many other tests that could be added over time, and some of them I could possibly handle myself, even as a non-programmer. One of the first would be a simple flagging of any trailing whitespace at end of lines. Another a test for any use of TAB instead of <SPACE> characters to indent sls files. \r\nAlso generally those tests should be run only against the changed sls file that is being committed and not against every single file in the repo. That applies also to the URL test, it should be run only against the currently changed sls file in the submission. BUT there should be a cron or otherwise scheduled job that checks for URLs that have gone bad. A committer merging a PR should not be 'forced' to deal with a bad URL or 404 error in another unrelated sls file.  \r\n \r\nBasically the travis-ci files and setup should be 100% external to the actual winrepo sls files. They should not require new settings or even commented out lines to tell travis-ci how to work on them.\r\n\r\nBTW saltstack might also look at moving the travis-ci files into their automated jenkins test-suite, so this travis-ci test suite might be superceeded at some point. Any ideas, or feedback or thoughts on this?\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/comments/226946221","html_url":"https://github.com/saltstack/salt-winrepo-ng/issues/487#issuecomment-226946221","issue_url":"https://api.github.com/repos/saltstack/salt-winrepo-ng/issues/487","id":226946221,"user":{"login":"moebiuseye","id":746812,"avatar_url":"https://avatars.githubusercontent.com/u/746812?v=3","gravatar_id":"","url":"https://api.github.com/users/moebiuseye","html_url":"https://github.com/moebiuseye","followers_url":"https://api.github.com/users/moebiuseye/followers","following_url":"https://api.github.com/users/moebiuseye/following{/other_user}","gists_url":"https://api.github.com/users/moebiuseye/gists{/gist_id}","starred_url":"https://api.github.com/users/moebiuseye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moebiuseye/subscriptions","organizations_url":"https://api.github.com/users/moebiuseye/orgs","repos_url":"https://api.github.com/users/moebiuseye/repos","events_url":"https://api.github.com/users/moebiuseye/events{/privacy}","received_events_url":"https://api.github.com/users/moebiuseye/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T14:47:30Z","updated_at":"2016-06-18T14:47:30Z","body":"I pushed the new working version (same link above) "}}
{"actor":{"display_login":"moebiuseye"}}