{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/86872965","pull_request_review_id":7509011,"id":86872965,"diff_hunk":"@@ -335,10 +337,10 @@ func MakeCA(certFile, keyFile, serialFile, name string) (*CA, error) {\n \t}, nil\n }\n \n-func (ca *CA) EnsureServerCert(certFile, keyFile string, hostnames sets.String) (*TLSCertificateConfig, bool, error) {\n+func (ca *CA) EnsureServerCert(certFile, keyFile string, hostnames sets.String, expirationDate time.Time) (*TLSCertificateConfig, bool, error) {","path":"pkg/cmd/server/crypto/crypto.go","position":14,"original_position":14,"commit_id":"3a82829f9f6cfaf5a09d852ccb4a7f9dab4e4da6","original_commit_id":"3a82829f9f6cfaf5a09d852ccb4a7f9dab4e4da6","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"i would rather make it part of CA struct","created_at":"2016-11-07T21:27:55Z","updated_at":"2016-11-07T21:27:55Z","html_url":"https://github.com/openshift/origin/pull/11814#discussion_r86872965","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11814","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/86872965"},"html":{"href":"https://github.com/openshift/origin/pull/11814#discussion_r86872965"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11814"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11814","id":92635156,"html_url":"https://github.com/openshift/origin/pull/11814","diff_url":"https://github.com/openshift/origin/pull/11814.diff","patch_url":"https://github.com/openshift/origin/pull/11814.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11814","number":11814,"state":"open","locked":false,"title":"[WIP] osadm ca: add --expires option.","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"body":"This PR adds `--expires` option to `osadm ca` sub commands. By default, generated certificates expire in 2 years, but with this option user is able to specify exact date:\r\n\r\n```console\r\n$ sudo `which oadm` ca create-server-cert \\\r\n    --hostnames=one.example.org,two.example.org \\\r\n    --cert example.org.crt \\\r\n    --key example.org.key \\\r\n    --signer-cert=$CA/ca.crt \\\r\n    --signer-key=$CA/ca.key \\\r\n    --signer-serial=$CA/ca.serial.txt \\\r\n    --expires=2017-01-01T00:00:00Z\r\n$ openssl x509 -in example.org.crt -text | head -9 | tail -3\r\nValidity\r\n    Not Before: Nov  7 17:52:22 2016 GMT\r\n    Not After : Jan  1 00:00:00 2017 GMT\r\n```\r\n\r\nTrello card: https://trello.com/c/de9h5mA4/829-3-allow-configuration-of-expiration-date-for-generated-certs\r\nPTAL @mfojtik @deads2k \r\n\r\nTODO:\r\n- [ ] get feedback\r\n- [ ] warn if expiration date >= 10yrs\r\n- [ ] add tests\r\n- [ ] add option to `osadm ca create-master-certs` \r\n- [ ] add option to `osadm ca create-signer-cert` \r\n- [ ] document","created_at":"2016-11-07T18:12:37Z","updated_at":"2016-11-07T21:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f047eec7e477e447f165137d9b088b7bd1626612","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11814/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11814/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11814/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3a82829f9f6cfaf5a09d852ccb4a7f9dab4e4da6","head":{"label":"php-coder:osadm_ca_add_expiration_date_option","ref":"osadm_ca_add_expiration_date_option","sha":"3a82829f9f6cfaf5a09d852ccb4a7f9dab4e4da6","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"repo":{"id":43544739,"name":"origin","full_name":"php-coder/origin","owner":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/php-coder/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/php-coder/origin","forks_url":"https://api.github.com/repos/php-coder/origin/forks","keys_url":"https://api.github.com/repos/php-coder/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-coder/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-coder/origin/teams","hooks_url":"https://api.github.com/repos/php-coder/origin/hooks","issue_events_url":"https://api.github.com/repos/php-coder/origin/issues/events{/number}","events_url":"https://api.github.com/repos/php-coder/origin/events","assignees_url":"https://api.github.com/repos/php-coder/origin/assignees{/user}","branches_url":"https://api.github.com/repos/php-coder/origin/branches{/branch}","tags_url":"https://api.github.com/repos/php-coder/origin/tags","blobs_url":"https://api.github.com/repos/php-coder/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-coder/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-coder/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-coder/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-coder/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/php-coder/origin/languages","stargazers_url":"https://api.github.com/repos/php-coder/origin/stargazers","contributors_url":"https://api.github.com/repos/php-coder/origin/contributors","subscribers_url":"https://api.github.com/repos/php-coder/origin/subscribers","subscription_url":"https://api.github.com/repos/php-coder/origin/subscription","commits_url":"https://api.github.com/repos/php-coder/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-coder/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-coder/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-coder/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-coder/origin/contents/{+path}","compare_url":"https://api.github.com/repos/php-coder/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-coder/origin/merges","archive_url":"https://api.github.com/repos/php-coder/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-coder/origin/downloads","issues_url":"https://api.github.com/repos/php-coder/origin/issues{/number}","pulls_url":"https://api.github.com/repos/php-coder/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/php-coder/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/php-coder/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-coder/origin/labels{/name}","releases_url":"https://api.github.com/repos/php-coder/origin/releases{/id}","deployments_url":"https://api.github.com/repos/php-coder/origin/deployments","created_at":"2015-10-02T09:21:06Z","updated_at":"2016-01-12T15:08:10Z","pushed_at":"2016-11-07T18:04:12Z","git_url":"git://github.com/php-coder/origin.git","ssh_url":"git@github.com:php-coder/origin.git","clone_url":"https://github.com/php-coder/origin.git","svn_url":"https://github.com/php-coder/origin","homepage":"http://www.openshift.org","size":366138,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"32708e768d77db08b118d084955a7ccf2aebbf1c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-11-07T19:51:36Z","pushed_at":"2016-11-07T21:14:02Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":622571,"stargazers_count":1978,"watchers_count":1978,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1318,"mirror_url":null,"open_issues_count":1179,"forks":1318,"open_issues":1179,"watchers":1978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11814"},"html":{"href":"https://github.com/openshift/origin/pull/11814"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11814"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11814/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11814/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11814/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3a82829f9f6cfaf5a09d852ccb4a7f9dab4e4da6"}}}}
{"actor":{"display_login":"mfojtik"}}