{"action":"closed","issue":{"url":"https://api.github.com/repos/chancejs/chancejs/issues/255","repository_url":"https://api.github.com/repos/chancejs/chancejs","labels_url":"https://api.github.com/repos/chancejs/chancejs/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/chancejs/chancejs/issues/255/comments","events_url":"https://api.github.com/repos/chancejs/chancejs/issues/255/events","html_url":"https://github.com/chancejs/chancejs/issues/255","id":154798216,"number":255,"title":"birthday() with type option can generate birthdays outside of the age range, plus a few minor issues","user":{"login":"mdsakalu","id":1858057,"avatar_url":"https://avatars.githubusercontent.com/u/1858057?v=3","gravatar_id":"","url":"https://api.github.com/users/mdsakalu","html_url":"https://github.com/mdsakalu","followers_url":"https://api.github.com/users/mdsakalu/followers","following_url":"https://api.github.com/users/mdsakalu/following{/other_user}","gists_url":"https://api.github.com/users/mdsakalu/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsakalu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsakalu/subscriptions","organizations_url":"https://api.github.com/users/mdsakalu/orgs","repos_url":"https://api.github.com/users/mdsakalu/repos","events_url":"https://api.github.com/users/mdsakalu/events{/privacy}","received_events_url":"https://api.github.com/users/mdsakalu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-05-13T20:54:23Z","updated_at":"2016-06-24T15:38:17Z","closed_at":"2016-06-24T15:38:17Z","body":"### Main issue\r\nSince `birthday()` just uses a random year, it can generate birthdays outside of the age range. For instance, `birthday({type: 'adult'})` could result in a birthday of 12/12/1998, which means that a person with that birthday is still 17, not 18.\r\n\r\n### Other issues\r\nI noticed that the age ranges were inconsistent through the code and tests. For instance, in some places the max age was 100, in others it was 120.\r\n\r\nI think that the minimum age for child should be 0, not 1."}}
{"actor":{"display_login":"mdsakalu"}}