{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/comments/60634837","id":60634837,"diff_hunk":"@@ -31,6 +33,9 @@\n @SpringApplicationConfiguration(classes = {KubernetesAutoConfiguration.class})\n public class KubernetesAppDeployerIntegrationTests extends AbstractAppDeployerIntegrationTests {\n \n+\t@ClassRule\n+\tpublic static KubernetesTestSupport marathonAvailable = new KubernetesTestSupport();","path":"src/test/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppDeployerIntegrationTests.java","position":null,"original_position":14,"commit_id":"b1f7aca69e838fd20ba4641c9aaebf424b87c9c5","original_commit_id":"e6971da68f0614ee6f7a7eb549631594ee36d9ea","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-04-21T18:47:06Z","updated_at":"2016-04-21T18:47:06Z","html_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8#discussion_r60634837","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/comments/60634837"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8#discussion_r60634837"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8","id":65847123,"html_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8","diff_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/8","number":8,"state":"open","locked":false,"title":"Make deployer work for SCDF","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"body":"Fix SCDF deployment issues\r\n    \r\n- Add service env vars for RABBITMQ,KAFKA,ZK\r\n    \r\n- Fix deployment properties lookup for memory and cpu\r\n\r\nAdd \"LoadBalancer\" so app will be reachable from outside\r\n    \r\n- only create load balancer if property `spring.cloud.deployer.kubernetes.createLoadBalancer` is true\r\n    \r\n- we must wait for load balancer creation to be complete when deleting service\r\n    \r\n- updated fabric8 kubernetes-client version\r\n","created_at":"2016-04-08T21:03:36Z","updated_at":"2016-04-21T18:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1548582db52721d1212a80902b85e7b2403cb2e9","assignee":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/8/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/statuses/b1f7aca69e838fd20ba4641c9aaebf424b87c9c5","head":{"label":"trisberg:add-service-env-vars","ref":"add-service-env-vars","sha":"b1f7aca69e838fd20ba4641c9aaebf424b87c9c5","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"repo":{"id":53960681,"name":"spring-cloud-kubernetes-deployer","full_name":"trisberg/spring-cloud-kubernetes-deployer","owner":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trisberg/spring-cloud-kubernetes-deployer","description":"","fork":true,"url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer","forks_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/forks","keys_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/teams","hooks_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/hooks","issue_events_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/events","assignees_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/tags","blobs_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/languages","stargazers_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/stargazers","contributors_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/contributors","subscribers_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/subscribers","subscription_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/subscription","commits_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/merges","archive_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/downloads","issues_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/labels{/name}","releases_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/trisberg/spring-cloud-kubernetes-deployer/deployments","created_at":"2016-03-15T16:28:23Z","updated_at":"2016-03-30T18:43:44Z","pushed_at":"2016-04-21T18:42:41Z","git_url":"git://github.com/trisberg/spring-cloud-kubernetes-deployer.git","ssh_url":"git@github.com:trisberg/spring-cloud-kubernetes-deployer.git","clone_url":"https://github.com/trisberg/spring-cloud-kubernetes-deployer.git","svn_url":"https://github.com/trisberg/spring-cloud-kubernetes-deployer","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"5bd44290029bf3818500406228a8c67a3ade7980","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52819699,"name":"spring-cloud-kubernetes-deployer","full_name":"spring-cloud/spring-cloud-kubernetes-deployer","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/deployments","created_at":"2016-02-29T19:53:03Z","updated_at":"2016-03-28T21:19:57Z","pushed_at":"2016-04-21T18:42:41Z","git_url":"git://github.com/spring-cloud/spring-cloud-kubernetes-deployer.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-kubernetes-deployer.git","clone_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer.git","svn_url":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer","homepage":null,"size":88,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-kubernetes-deployer/pull/8"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/8"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-kubernetes-deployer/statuses/b1f7aca69e838fd20ba4641c9aaebf424b87c9c5"}}}}