{"action":"created","issue":{"url":"https://api.github.com/repos/briansmith/ring/issues/78","repository_url":"https://api.github.com/repos/briansmith/ring","labels_url":"https://api.github.com/repos/briansmith/ring/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/briansmith/ring/issues/78/comments","events_url":"https://api.github.com/repos/briansmith/ring/issues/78/events","html_url":"https://github.com/briansmith/ring/issues/78","id":125546021,"number":78,"title":"Finish up `use_heap` feature.","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"labels":[{"id":274467329,"url":"https://api.github.com/repos/briansmith/ring/labels/static-analysis-and-type-safety","name":"static-analysis-and-type-safety","color":"c7def8","default":false},{"id":274468306,"url":"https://api.github.com/repos/briansmith/ring/labels/usability","name":"usability","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-01-08T05:28:00Z","updated_at":"2016-12-12T23:16:34Z","closed_at":null,"body":"- [x] Replace the non-default `no_heap` feature with a default `use_heap` feature.\n- [ ] Convert tests from using `std::string::String` and `std::vec::Vec` to use arrayvec's `ArrayString` and `ArrayVec`, respectively.\n- [ ] [On Hold] Add `use_heap` configurations to CI configurations.\n"},"comment":{"url":"https://api.github.com/repos/briansmith/ring/issues/comments/266584656","html_url":"https://github.com/briansmith/ring/issues/78#issuecomment-266584656","issue_url":"https://api.github.com/repos/briansmith/ring/issues/78","id":266584656,"user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T23:16:34Z","updated_at":"2016-12-12T23:16:34Z","body":"We now do this:\r\n\r\n```rust\r\n#[cfg(feature = \"use_heap\")]\r\nimpl std::error::Error for Unspecified {\r\n```\r\n\r\nInstead of keying that on `use_heap` we should key it on `std` or `use_std` depending on whatever convention is more common in Rust libraries.\r\n\r\nOnce #102 is done, we can `#[cfg(not(all(feature = \"rsa_signing\", feature = \"use_heap\")))]` with `#[cfg(feature = \"rsa_signing\")]` and make rsa_signing depend on `use_heap."}}
{"actor":{"display_login":"briansmith"}}