{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/81200810","pull_request_review_id":2198439,"id":81200810,"diff_hunk":"@@ -0,0 +1,53 @@\n+test_case \"--ignore-cache command-line option causes the fact cache to be ignored\" do\n+  require 'facter/acceptance/user_fact_utils'\n+  extend Facter::Acceptance::UserFactUtils\n+\n+  # the kernel fact should be resolvable on ALL systems\n+  cached_fact_name = \"kernel\"\n+\n+  config = <<-FILE\n+  cli : { debug : true }\n+  facts : { ttls : [ \"kernel\" : 30 minutes ] }\n+  FILE\n+\n+  agents.each do |agent|\n+    config_dir = get_default_fact_dir(agent['platform'], on(agent, facter('kernelmajversion')).stdout.chomp.to_f)\n+    config_file = File.join(config_dir, \"facter.conf\")\n+\n+    cached_facts_dir = get_cached_facts_dir(agent['platform'], on(agent, facter('kernelmajversion')).stdout.chomp.to_f)","path":"acceptance/tests/options/ignore_cache.rb","position":null,"original_position":17,"commit_id":"e2b288943979735aea04a4822412659153a09a8f","original_commit_id":"62969b3d59da001e760384ef727d5b17eef9c2ed","user":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"body":"udpated","created_at":"2016-09-29T18:15:11Z","updated_at":"2016-09-29T18:15:12Z","html_url":"https://github.com/puppetlabs/facter/pull/1425#discussion_r81200810","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1425","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/81200810"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1425#discussion_r81200810"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1425"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1425","id":85322027,"html_url":"https://github.com/puppetlabs/facter/pull/1425","diff_url":"https://github.com/puppetlabs/facter/pull/1425.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1425.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1425","number":1425,"state":"open","locked":false,"title":"(FACT-348) Allow fact caching","user":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"body":"This allows a `ttls` element to be specified in the config file with the following structure:\r\n`facts : { ttls : [ { \"block group\" : 30 days } ] }`. Facts in the specified block groups will be cached as json files and loaded from those files until the files expire, i.e. the file is older than the specified duration.\r\n\r\nThis can be used with any fact that has a blockgroup specified in the schema.","created_at":"2016-09-14T23:13:31Z","updated_at":"2016-09-29T18:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a73792809e078b61d6f269480f55aa376c46d7d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1425/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/e2b288943979735aea04a4822412659153a09a8f","head":{"label":"Magisus:ttls/FACT-348","ref":"ttls/FACT-348","sha":"e2b288943979735aea04a4822412659153a09a8f","user":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"repo":{"id":37144669,"name":"facter","full_name":"Magisus/facter","owner":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Magisus/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/Magisus/facter","forks_url":"https://api.github.com/repos/Magisus/facter/forks","keys_url":"https://api.github.com/repos/Magisus/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magisus/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magisus/facter/teams","hooks_url":"https://api.github.com/repos/Magisus/facter/hooks","issue_events_url":"https://api.github.com/repos/Magisus/facter/issues/events{/number}","events_url":"https://api.github.com/repos/Magisus/facter/events","assignees_url":"https://api.github.com/repos/Magisus/facter/assignees{/user}","branches_url":"https://api.github.com/repos/Magisus/facter/branches{/branch}","tags_url":"https://api.github.com/repos/Magisus/facter/tags","blobs_url":"https://api.github.com/repos/Magisus/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magisus/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magisus/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magisus/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magisus/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/Magisus/facter/languages","stargazers_url":"https://api.github.com/repos/Magisus/facter/stargazers","contributors_url":"https://api.github.com/repos/Magisus/facter/contributors","subscribers_url":"https://api.github.com/repos/Magisus/facter/subscribers","subscription_url":"https://api.github.com/repos/Magisus/facter/subscription","commits_url":"https://api.github.com/repos/Magisus/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magisus/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magisus/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magisus/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magisus/facter/contents/{+path}","compare_url":"https://api.github.com/repos/Magisus/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magisus/facter/merges","archive_url":"https://api.github.com/repos/Magisus/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magisus/facter/downloads","issues_url":"https://api.github.com/repos/Magisus/facter/issues{/number}","pulls_url":"https://api.github.com/repos/Magisus/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/Magisus/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/Magisus/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magisus/facter/labels{/name}","releases_url":"https://api.github.com/repos/Magisus/facter/releases{/id}","deployments_url":"https://api.github.com/repos/Magisus/facter/deployments","created_at":"2015-06-09T16:39:09Z","updated_at":"2016-06-07T21:30:07Z","pushed_at":"2016-09-29T18:14:57Z","git_url":"git://github.com/Magisus/facter.git","ssh_url":"git@github.com:Magisus/facter.git","clone_url":"https://github.com/Magisus/facter.git","svn_url":"https://github.com/Magisus/facter","homepage":"https://tickets.puppetlabs.com/browse/FACT","size":11902,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"d53ef63aab6d73f11e9f647aca59dee36ad479af","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2016-09-18T03:22:42Z","pushed_at":"2016-09-29T18:14:59Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":19369,"stargazers_count":455,"watchers_count":455,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":397,"mirror_url":null,"open_issues_count":11,"forks":397,"open_issues":11,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1425"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1425"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1425"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/e2b288943979735aea04a4822412659153a09a8f"}}}}
{"actor":{"display_login":"Magisus"}}