{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/atomic/pulls/comments/74236590","id":74236590,"diff_hunk":"@@ -149,6 +162,16 @@ def install_system_container(self, image, name):\n         if not repo:\n             raise ValueError(\"Cannot find a configured OSTree repo\")\n \n+        if not self.user:\n+            runc_found = True\n+        try:\n+            util.check_call([RUNC_PATH, \"--version\"], stdout=DEVNULL)\n+        except util.FileNotFound:\n+            runc_found = False\n+\n+        if not runc_found:\n+            raise ValueError(\"Cannot install the container: runc is needed to run system containers\")\n+","path":"Atomic/syscontainers.py","position":42,"original_position":42,"commit_id":"869438b68373b1b8109158049273e4f24d425230","original_commit_id":"869438b68373b1b8109158049273e4f24d425230","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Why not raise this in the exception.  Don't see the need for runc_found.","created_at":"2016-08-10T12:47:37Z","updated_at":"2016-08-10T12:47:38Z","html_url":"https://github.com/projectatomic/atomic/pull/529#discussion_r74236590","pull_request_url":"https://api.github.com/repos/projectatomic/atomic/pulls/529","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/comments/74236590"},"html":{"href":"https://github.com/projectatomic/atomic/pull/529#discussion_r74236590"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/529"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/atomic/pulls/529","id":80783364,"html_url":"https://github.com/projectatomic/atomic/pull/529","diff_url":"https://github.com/projectatomic/atomic/pull/529.diff","patch_url":"https://github.com/projectatomic/atomic/pull/529.patch","issue_url":"https://api.github.com/repos/projectatomic/atomic/issues/529","number":529,"state":"open","locked":false,"title":"Improve error messages system containers","user":{"login":"giuseppe","id":67430,"avatar_url":"https://avatars.githubusercontent.com/u/67430?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"body":"Fail early if runc is not installed when installing a system container, or either if bwrap-oci is not installed or systemctl doesn't support --user when installing an user container.","created_at":"2016-08-10T12:15:27Z","updated_at":"2016-08-10T12:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21f61936c7148cc69dfda59e4d9dc04a03edfdc5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/atomic/pulls/529/commits","review_comments_url":"https://api.github.com/repos/projectatomic/atomic/pulls/529/comments","review_comment_url":"https://api.github.com/repos/projectatomic/atomic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/atomic/issues/529/comments","statuses_url":"https://api.github.com/repos/projectatomic/atomic/statuses/869438b68373b1b8109158049273e4f24d425230","head":{"label":"giuseppe:improve-error-messages-system-containers","ref":"improve-error-messages-system-containers","sha":"869438b68373b1b8109158049273e4f24d425230","user":{"login":"giuseppe","id":67430,"avatar_url":"https://avatars.githubusercontent.com/u/67430?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"repo":{"id":51300220,"name":"atomic","full_name":"giuseppe/atomic","owner":{"login":"giuseppe","id":67430,"avatar_url":"https://avatars.githubusercontent.com/u/67430?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giuseppe/atomic","description":"Atomic Run Tool for installing/running/managing container images.","fork":true,"url":"https://api.github.com/repos/giuseppe/atomic","forks_url":"https://api.github.com/repos/giuseppe/atomic/forks","keys_url":"https://api.github.com/repos/giuseppe/atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giuseppe/atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giuseppe/atomic/teams","hooks_url":"https://api.github.com/repos/giuseppe/atomic/hooks","issue_events_url":"https://api.github.com/repos/giuseppe/atomic/issues/events{/number}","events_url":"https://api.github.com/repos/giuseppe/atomic/events","assignees_url":"https://api.github.com/repos/giuseppe/atomic/assignees{/user}","branches_url":"https://api.github.com/repos/giuseppe/atomic/branches{/branch}","tags_url":"https://api.github.com/repos/giuseppe/atomic/tags","blobs_url":"https://api.github.com/repos/giuseppe/atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giuseppe/atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giuseppe/atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/giuseppe/atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giuseppe/atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/giuseppe/atomic/languages","stargazers_url":"https://api.github.com/repos/giuseppe/atomic/stargazers","contributors_url":"https://api.github.com/repos/giuseppe/atomic/contributors","subscribers_url":"https://api.github.com/repos/giuseppe/atomic/subscribers","subscription_url":"https://api.github.com/repos/giuseppe/atomic/subscription","commits_url":"https://api.github.com/repos/giuseppe/atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/giuseppe/atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/giuseppe/atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/giuseppe/atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/giuseppe/atomic/contents/{+path}","compare_url":"https://api.github.com/repos/giuseppe/atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giuseppe/atomic/merges","archive_url":"https://api.github.com/repos/giuseppe/atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giuseppe/atomic/downloads","issues_url":"https://api.github.com/repos/giuseppe/atomic/issues{/number}","pulls_url":"https://api.github.com/repos/giuseppe/atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/giuseppe/atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/giuseppe/atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giuseppe/atomic/labels{/name}","releases_url":"https://api.github.com/repos/giuseppe/atomic/releases{/id}","deployments_url":"https://api.github.com/repos/giuseppe/atomic/deployments","created_at":"2016-02-08T13:45:27Z","updated_at":"2016-02-08T13:45:28Z","pushed_at":"2016-08-10T12:42:15Z","git_url":"git://github.com/giuseppe/atomic.git","ssh_url":"git@github.com:giuseppe/atomic.git","clone_url":"https://github.com/giuseppe/atomic.git","svn_url":"https://github.com/giuseppe/atomic","homepage":null,"size":2153,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"f3d6080b0c9a037b8cea754a3444e4a3ddccee61","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":29267754,"name":"atomic","full_name":"projectatomic/atomic","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/atomic","description":"Atomic Run Tool for installing/running/managing container images.","fork":false,"url":"https://api.github.com/repos/projectatomic/atomic","forks_url":"https://api.github.com/repos/projectatomic/atomic/forks","keys_url":"https://api.github.com/repos/projectatomic/atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/atomic/teams","hooks_url":"https://api.github.com/repos/projectatomic/atomic/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/atomic/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/atomic/events","assignees_url":"https://api.github.com/repos/projectatomic/atomic/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/atomic/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/atomic/tags","blobs_url":"https://api.github.com/repos/projectatomic/atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/atomic/languages","stargazers_url":"https://api.github.com/repos/projectatomic/atomic/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/atomic/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/atomic/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/atomic/subscription","commits_url":"https://api.github.com/repos/projectatomic/atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/atomic/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/atomic/merges","archive_url":"https://api.github.com/repos/projectatomic/atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/atomic/downloads","issues_url":"https://api.github.com/repos/projectatomic/atomic/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/atomic/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/atomic/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/atomic/deployments","created_at":"2015-01-14T21:54:06Z","updated_at":"2016-08-09T14:25:58Z","pushed_at":"2016-08-10T12:42:16Z","git_url":"git://github.com/projectatomic/atomic.git","ssh_url":"git@github.com:projectatomic/atomic.git","clone_url":"https://github.com/projectatomic/atomic.git","svn_url":"https://github.com/projectatomic/atomic","homepage":null,"size":2383,"stargazers_count":190,"watchers_count":190,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":33,"forks":94,"open_issues":33,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/529"},"html":{"href":"https://github.com/projectatomic/atomic/pull/529"},"issue":{"href":"https://api.github.com/repos/projectatomic/atomic/issues/529"},"comments":{"href":"https://api.github.com/repos/projectatomic/atomic/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/atomic/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/atomic/statuses/869438b68373b1b8109158049273e4f24d425230"}}}}
{"actor":{"display_login":"rhatdan"}}