{"action":"created","comment":{"url":"https://api.github.com/repos/andela/banasko-cfh/pulls/comments/90844258","pull_request_review_id":11357966,"id":90844258,"diff_hunk":"@@ -1,166 +1,220 @@\n 'use strict';\n \n-var should = require('should');\n-var io = require('socket.io-client');\n+const should = require('should');\n+const io = require('socket.io-client');\n \n-var socketURL = 'http://localhost:3000';\n+const socketURL = 'http://localhost:3000';\n \n-var options = {\n+const options = {\n   transports: ['websocket'],\n   'force new connection': true\n };\n+const cfhPlayer1 = { 'name': 'Tom' };\n+const cfhPlayer2 = { 'name': 'Sally' };\n+const cfhPlayer3 = { 'name': 'Dana' };\n \n-var cfhPlayer1 = {'name':'Tom'};\n-var cfhPlayer2 = {'name':'Sally'};\n-var cfhPlayer3 = {'name':'Dana'};\n-\n-describe(\"Game Server\",function() {\n-\n-  it('Should accept requests to joinGame', function(done) {\n-    var client1 = io.connect(socketURL, options);\n-    var disconnect = function() {\n+describe(\"Game Server\", function () {\n+  it('Should accept requests to joinGame', function (done) {\n+    const client1 = io.connect(socketURL, options);\n+    const disconnect = function () {\n       client1.disconnect();\n       done();\n     };\n-    client1.on('connect', function(data) {\n-      client1.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n-      setTimeout(disconnect,200);\n+    client1.on('connect', function (data) {\n+      client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+      setTimeout(disconnect, 200);\n     });\n     done();\n   });\n \n-  it('Should send a game update upon receiving request to joinGame', function(done) {\n-    var client1 = io.connect(socketURL, options);\n-    var disconnect = function() {\n+  it('Should send a game update upon receiving request to joinGame', function (done) {\n+    const client1 = io.connect(socketURL, options);\n+    const disconnect = function () {\n       client1.disconnect();\n       done();\n     };\n-    client1.on('connect', function() {\n-      client1.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n-      client1.on('gameUpdate', function(data) {\n+\n+    client1.on('connect', function (data) {\n+      client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+      client1.on('gameUpdate', function (data) {\n         data.gameID.should.match(/\\d+/);\n       });\n-      setTimeout(disconnect,200);\n+      setTimeout(disconnect, 200);\n     });\n     done();\n   });\n \n-  it('Should announce new user to all users', function(done) {\n-    var client1 = io.connect(socketURL, options);\n-    var client2;\n-    var disconnect = function() {\n+  it('Should announce new user to all users', function (done) {\n+    const client1 = io.connect(socketURL, options);\n+    let client2;\n+    let disconnect = function () {\n       client1.disconnect();\n       client2.disconnect();\n       done();\n     };\n-    client1.on('connect', function(data) {\n-      client1.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n+    client1.on('connect', function (data) {\n+      client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n       client2 = io.connect(socketURL, options);\n-      client2.on('connect', function(data) {\n-        client2.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n-        client1.on('notification', function(data) {\n+      client2.on('connect', function (data) {\n+        client2.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+        client1.on('notification', function (data) {\n           data.notification.should.match(/ has joined the game\\!/);\n         });\n       });\n-      setTimeout(disconnect,200);\n+      setTimeout(disconnect, 200);\n     });\n     done();\n   });\n \n-  it('Should start game when startGame event is sent with 3 players', function(done) {\n-    var client1, client2, client3;\n+  it('Should start game when startGame event is sent with 3 players', function (done) {\n+    let client1, client2, client3;\n     client1 = io.connect(socketURL, options);\n-    var disconnect = function() {\n+    let disconnect = function () {\n       client1.disconnect();\n       client2.disconnect();\n       client3.disconnect();\n       done();\n     };\n-    var expectStartGame = function() {\n+    let expectStartGame = function () {\n       client1.emit('startGame');\n-      client1.on('gameUpdate', function(data) {\n+      client1.on('gameUpdate', function (data) {\n         data.state.should.equal(\"waiting for players to pick\");\n       });\n-      client2.on('gameUpdate', function(data) {\n+      client2.on('gameUpdate', function (data) {\n         data.state.should.equal(\"waiting for players to pick\");\n       });\n-      client3.on('gameUpdate', function(data) {\n+      client3.on('gameUpdate', function (data) {\n         data.state.should.equal(\"waiting for players to pick\");\n       });\n-      setTimeout(disconnect,200);\n+      setTimeout(disconnect, 200);\n     };\n-    client1.on('connect', function() {\n-      client1.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n+    client1.on('connect', function () {\n+      client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n       client2 = io.connect(socketURL, options);\n-      client2.on('connect', function() {\n-        client2.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n+      client2.on('connect', function () {\n+        client2.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n         client3 = io.connect(socketURL, options);\n-        client3.on('connect', function() {\n-          client3.emit('joinGame',{userID:'unauthenticated',room: '', createPrivate: false});\n-          setTimeout(expectStartGame,100);\n+        client3.on('connect', function () {\n+          client3.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+          setTimeout(expectStartGame, 100);\n         });\n       });\n     });\n     done();\n   });\n \n-  it('Should automatically start game when 6 players are in a game', function(done) {\n-    var client1, client2, client3, client4, client5, client6;\n+<<<<<<< HEAD\n+  it('Should automatically start game when 12 players are in a game', function (done) {\n+    let client1, client2, client3, client4, client5, client6, client7, client8, client9, client10, client11, client12;\n     client1 = io.connect(socketURL, options);\n-    var disconnect = function() {\n+    let disconnect = function () {\n+=======\n+  it('Should automatically start game when 12 players are in a game', function(done) {","path":"test/server/game/game.js","position":163,"original_position":163,"commit_id":"58dfa911fe86100e7bce432fa014570037535f1a","original_commit_id":"58dfa911fe86100e7bce432fa014570037535f1a","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2016-12-05T11:11:08Z","updated_at":"2016-12-05T11:11:08Z","html_url":"https://github.com/andela/banasko-cfh/pull/11#discussion_r90844258","pull_request_url":"https://api.github.com/repos/andela/banasko-cfh/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/comments/90844258"},"html":{"href":"https://github.com/andela/banasko-cfh/pull/11#discussion_r90844258"},"pull_request":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/andela/banasko-cfh/pulls/11","id":95998523,"html_url":"https://github.com/andela/banasko-cfh/pull/11","diff_url":"https://github.com/andela/banasko-cfh/pull/11.diff","patch_url":"https://github.com/andela/banasko-cfh/pull/11.patch","issue_url":"https://api.github.com/repos/andela/banasko-cfh/issues/11","number":11,"state":"open","locked":false,"title":"#134249133 Users should be able to send invites to at most 11 people","user":{"login":"olawalequest","id":6044962,"avatar_url":"https://avatars.githubusercontent.com/u/6044962?v=3","gravatar_id":"","url":"https://api.github.com/users/olawalequest","html_url":"https://github.com/olawalequest","followers_url":"https://api.github.com/users/olawalequest/followers","following_url":"https://api.github.com/users/olawalequest/following{/other_user}","gists_url":"https://api.github.com/users/olawalequest/gists{/gist_id}","starred_url":"https://api.github.com/users/olawalequest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olawalequest/subscriptions","organizations_url":"https://api.github.com/users/olawalequest/orgs","repos_url":"https://api.github.com/users/olawalequest/repos","events_url":"https://api.github.com/users/olawalequest/events{/privacy}","received_events_url":"https://api.github.com/users/olawalequest/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nIt ensure that user can send invites to at most 11 other people other than themselves\r\n\r\n#### Description of Task to be completed?  \r\nUsers should be able to invite people to their game up to a maximum of 11 other people, so no game can exceed 12 people in total and must have at least 3 players.\r\n\r\n#### How should this be manually tested?  \r\nRun npm test","created_at":"2016-11-30T23:49:41Z","updated_at":"2016-12-05T11:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b0fea3549d20384ce1155dfd71662b96385da8f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/banasko-cfh/pulls/11/commits","review_comments_url":"https://api.github.com/repos/andela/banasko-cfh/pulls/11/comments","review_comment_url":"https://api.github.com/repos/andela/banasko-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/banasko-cfh/issues/11/comments","statuses_url":"https://api.github.com/repos/andela/banasko-cfh/statuses/58dfa911fe86100e7bce432fa014570037535f1a","head":{"label":"andela:feature/134249133/invite-11-people","ref":"feature/134249133/invite-11-people","sha":"58dfa911fe86100e7bce432fa014570037535f1a","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":73644823,"name":"banasko-cfh","full_name":"andela/banasko-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/banasko-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/banasko-cfh","forks_url":"https://api.github.com/repos/andela/banasko-cfh/forks","keys_url":"https://api.github.com/repos/andela/banasko-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/banasko-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/banasko-cfh/teams","hooks_url":"https://api.github.com/repos/andela/banasko-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/banasko-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/banasko-cfh/events","assignees_url":"https://api.github.com/repos/andela/banasko-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/banasko-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/banasko-cfh/tags","blobs_url":"https://api.github.com/repos/andela/banasko-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/banasko-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/banasko-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/banasko-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/banasko-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/banasko-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/banasko-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/banasko-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/banasko-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/banasko-cfh/subscription","commits_url":"https://api.github.com/repos/andela/banasko-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/banasko-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/banasko-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/banasko-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/banasko-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/banasko-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/banasko-cfh/merges","archive_url":"https://api.github.com/repos/andela/banasko-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/banasko-cfh/downloads","issues_url":"https://api.github.com/repos/andela/banasko-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/banasko-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/banasko-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/banasko-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/banasko-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/banasko-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/banasko-cfh/deployments","created_at":"2016-11-13T21:42:09Z","updated_at":"2016-12-02T13:39:19Z","pushed_at":"2016-12-05T11:10:59Z","git_url":"git://github.com/andela/banasko-cfh.git","ssh_url":"git@github.com:andela/banasko-cfh.git","clone_url":"https://github.com/andela/banasko-cfh.git","svn_url":"https://github.com/andela/banasko-cfh","homepage":"https://banaskotest.herokuapp.com/#!/","size":10857,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"development"}},"base":{"label":"andela:development","ref":"development","sha":"f4099028da7ef25ae0737c08456462f5438397b1","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":73644823,"name":"banasko-cfh","full_name":"andela/banasko-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/banasko-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/banasko-cfh","forks_url":"https://api.github.com/repos/andela/banasko-cfh/forks","keys_url":"https://api.github.com/repos/andela/banasko-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/banasko-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/banasko-cfh/teams","hooks_url":"https://api.github.com/repos/andela/banasko-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/banasko-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/banasko-cfh/events","assignees_url":"https://api.github.com/repos/andela/banasko-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/banasko-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/banasko-cfh/tags","blobs_url":"https://api.github.com/repos/andela/banasko-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/banasko-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/banasko-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/banasko-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/banasko-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/banasko-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/banasko-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/banasko-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/banasko-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/banasko-cfh/subscription","commits_url":"https://api.github.com/repos/andela/banasko-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/banasko-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/banasko-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/banasko-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/banasko-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/banasko-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/banasko-cfh/merges","archive_url":"https://api.github.com/repos/andela/banasko-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/banasko-cfh/downloads","issues_url":"https://api.github.com/repos/andela/banasko-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/banasko-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/banasko-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/banasko-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/banasko-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/banasko-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/banasko-cfh/deployments","created_at":"2016-11-13T21:42:09Z","updated_at":"2016-12-02T13:39:19Z","pushed_at":"2016-12-05T11:10:59Z","git_url":"git://github.com/andela/banasko-cfh.git","ssh_url":"git@github.com:andela/banasko-cfh.git","clone_url":"https://github.com/andela/banasko-cfh.git","svn_url":"https://github.com/andela/banasko-cfh","homepage":"https://banaskotest.herokuapp.com/#!/","size":10857,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/11"},"html":{"href":"https://github.com/andela/banasko-cfh/pull/11"},"issue":{"href":"https://api.github.com/repos/andela/banasko-cfh/issues/11"},"comments":{"href":"https://api.github.com/repos/andela/banasko-cfh/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/banasko-cfh/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/andela/banasko-cfh/statuses/58dfa911fe86100e7bce432fa014570037535f1a"}}}}
{"actor":{"display_login":"houndci-bot"}}