{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/77496662","id":77496662,"diff_hunk":"@@ -277,11 +277,11 @@ open class UnitAngle : Dimension {\n     \n     private struct Coefficient {\n         static let degrees      = 1.0\n-        static let arcMinutes   = 0.016667\n-        static let arcSeconds   = 0.00027778\n-        static let radians      = 57.2958\n+        static let arcMinutes   = 1.0 / 60.0\n+        static let arcSeconds   = 1.0 / 3600.0\n+        static let radians      = 180.0 / .pi\n         static let gradians     = 0.9\n-        static let revolutions  = 6.28319\n+        static let revolutions  = 360.0","path":"Foundation/Unit.swift","position":12,"original_position":12,"commit_id":"0ddaaf732e8c6092c6cca93af06ae0f2bb10cdde","original_commit_id":"0ddaaf732e8c6092c6cca93af06ae0f2bb10cdde","user":{"login":"Qbyte248","id":15814572,"avatar_url":"https://avatars.githubusercontent.com/u/15814572?v=3","gravatar_id":"","url":"https://api.github.com/users/Qbyte248","html_url":"https://github.com/Qbyte248","followers_url":"https://api.github.com/users/Qbyte248/followers","following_url":"https://api.github.com/users/Qbyte248/following{/other_user}","gists_url":"https://api.github.com/users/Qbyte248/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbyte248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbyte248/subscriptions","organizations_url":"https://api.github.com/users/Qbyte248/orgs","repos_url":"https://api.github.com/users/Qbyte248/repos","events_url":"https://api.github.com/users/Qbyte248/events{/privacy}","received_events_url":"https://api.github.com/users/Qbyte248/received_events","type":"User","site_admin":false},"body":"That's true but the base unit is degrees so the conversion factor has to be 360.","created_at":"2016-09-05T09:48:55Z","updated_at":"2016-09-05T09:48:55Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/618#discussion_r77496662","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/77496662"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/618#discussion_r77496662"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618","id":83873444,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/618","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/618.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/618.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/618","number":618,"state":"open","locked":false,"title":"Changed coefficients of UnitAngle to more exact values","user":{"login":"Qbyte248","id":15814572,"avatar_url":"https://avatars.githubusercontent.com/u/15814572?v=3","gravatar_id":"","url":"https://api.github.com/users/Qbyte248","html_url":"https://github.com/Qbyte248","followers_url":"https://api.github.com/users/Qbyte248/followers","following_url":"https://api.github.com/users/Qbyte248/following{/other_user}","gists_url":"https://api.github.com/users/Qbyte248/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbyte248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbyte248/subscriptions","organizations_url":"https://api.github.com/users/Qbyte248/orgs","repos_url":"https://api.github.com/users/Qbyte248/repos","events_url":"https://api.github.com/users/Qbyte248/events{/privacy}","received_events_url":"https://api.github.com/users/Qbyte248/received_events","type":"User","site_admin":false},"body":"The provided values were not as exact as they could be. In fact the value for \"revolutions\" was completely wrong (2π instead of 360°).","created_at":"2016-09-02T22:35:51Z","updated_at":"2016-09-05T09:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f237ae681eb5114f77d3e552a5c6378878d5a837","assignee":{"login":"lifeissweetgood","id":2141023,"avatar_url":"https://avatars.githubusercontent.com/u/2141023?v=3","gravatar_id":"","url":"https://api.github.com/users/lifeissweetgood","html_url":"https://github.com/lifeissweetgood","followers_url":"https://api.github.com/users/lifeissweetgood/followers","following_url":"https://api.github.com/users/lifeissweetgood/following{/other_user}","gists_url":"https://api.github.com/users/lifeissweetgood/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeissweetgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeissweetgood/subscriptions","organizations_url":"https://api.github.com/users/lifeissweetgood/orgs","repos_url":"https://api.github.com/users/lifeissweetgood/repos","events_url":"https://api.github.com/users/lifeissweetgood/events{/privacy}","received_events_url":"https://api.github.com/users/lifeissweetgood/received_events","type":"User","site_admin":false},"assignees":[{"login":"lifeissweetgood","id":2141023,"avatar_url":"https://avatars.githubusercontent.com/u/2141023?v=3","gravatar_id":"","url":"https://api.github.com/users/lifeissweetgood","html_url":"https://github.com/lifeissweetgood","followers_url":"https://api.github.com/users/lifeissweetgood/followers","following_url":"https://api.github.com/users/lifeissweetgood/following{/other_user}","gists_url":"https://api.github.com/users/lifeissweetgood/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeissweetgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeissweetgood/subscriptions","organizations_url":"https://api.github.com/users/lifeissweetgood/orgs","repos_url":"https://api.github.com/users/lifeissweetgood/repos","events_url":"https://api.github.com/users/lifeissweetgood/events{/privacy}","received_events_url":"https://api.github.com/users/lifeissweetgood/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/618/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/0ddaaf732e8c6092c6cca93af06ae0f2bb10cdde","head":{"label":"Qbyte248:patch-1","ref":"patch-1","sha":"0ddaaf732e8c6092c6cca93af06ae0f2bb10cdde","user":{"login":"Qbyte248","id":15814572,"avatar_url":"https://avatars.githubusercontent.com/u/15814572?v=3","gravatar_id":"","url":"https://api.github.com/users/Qbyte248","html_url":"https://github.com/Qbyte248","followers_url":"https://api.github.com/users/Qbyte248/followers","following_url":"https://api.github.com/users/Qbyte248/following{/other_user}","gists_url":"https://api.github.com/users/Qbyte248/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbyte248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbyte248/subscriptions","organizations_url":"https://api.github.com/users/Qbyte248/orgs","repos_url":"https://api.github.com/users/Qbyte248/repos","events_url":"https://api.github.com/users/Qbyte248/events{/privacy}","received_events_url":"https://api.github.com/users/Qbyte248/received_events","type":"User","site_admin":false},"repo":{"id":67258699,"name":"swift-corelibs-foundation","full_name":"Qbyte248/swift-corelibs-foundation","owner":{"login":"Qbyte248","id":15814572,"avatar_url":"https://avatars.githubusercontent.com/u/15814572?v=3","gravatar_id":"","url":"https://api.github.com/users/Qbyte248","html_url":"https://github.com/Qbyte248","followers_url":"https://api.github.com/users/Qbyte248/followers","following_url":"https://api.github.com/users/Qbyte248/following{/other_user}","gists_url":"https://api.github.com/users/Qbyte248/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbyte248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbyte248/subscriptions","organizations_url":"https://api.github.com/users/Qbyte248/orgs","repos_url":"https://api.github.com/users/Qbyte248/repos","events_url":"https://api.github.com/users/Qbyte248/events{/privacy}","received_events_url":"https://api.github.com/users/Qbyte248/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qbyte248/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/Qbyte248/swift-corelibs-foundation/deployments","created_at":"2016-09-02T22:25:55Z","updated_at":"2016-09-02T22:26:00Z","pushed_at":"2016-09-02T22:32:26Z","git_url":"git://github.com/Qbyte248/swift-corelibs-foundation.git","ssh_url":"git@github.com:Qbyte248/swift-corelibs-foundation.git","clone_url":"https://github.com/Qbyte248/swift-corelibs-foundation.git","svn_url":"https://github.com/Qbyte248/swift-corelibs-foundation","homepage":"swift.org","size":7675,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0dc0dacd75fbfc94a84193649f8a92bf6c135fdf","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2016-09-05T08:55:59Z","pushed_at":"2016-09-05T01:10:44Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":9010,"stargazers_count":2092,"watchers_count":2092,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":453,"mirror_url":null,"open_issues_count":30,"forks":453,"open_issues":30,"watchers":2092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/618"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/618"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/0ddaaf732e8c6092c6cca93af06ae0f2bb10cdde"}}}}
{"actor":{"display_login":"Qbyte248"}}