{"action":"closed","number":3318,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318","id":64061980,"html_url":"https://github.com/ansible/ansible-modules-core/pull/3318","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3318.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3318.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3318","number":3318,"state":"closed","locked":false,"title":"Preserve order during Yaml to JSON parsing","user":{"login":"bgeesaman","id":3769609,"avatar_url":"https://avatars.githubusercontent.com/u/3769609?v=3","gravatar_id":"","url":"https://api.github.com/users/bgeesaman","html_url":"https://github.com/bgeesaman","followers_url":"https://api.github.com/users/bgeesaman/followers","following_url":"https://api.github.com/users/bgeesaman/following{/other_user}","gists_url":"https://api.github.com/users/bgeesaman/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeesaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeesaman/subscriptions","organizations_url":"https://api.github.com/users/bgeesaman/orgs","repos_url":"https://api.github.com/users/bgeesaman/repos","events_url":"https://api.github.com/users/bgeesaman/events{/privacy}","received_events_url":"https://api.github.com/users/bgeesaman/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\ncloudformation module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.0.1.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nWhen using template_format: yaml in the cloudformation module, the order of the yaml components are not preserved during the parsing to JSON (which is fine per JSON's spec). This results in a syntactically valid JSON document that cloudformation happily accepts. However, when viewing the running template in the AWS Cloudformation GUI of the stack that was just created, the order really helps readability. Preserving order just helps us humans looking at the parsedJSON to have a better chance at reading/troubleshooting issues when comparing the source Yaml to the actual JSON result.\r\n\r\n```\r\nN/A as visual output remains unchanged.\r\n```\r\n\r\nAdapted the bits from here: https://gist.github.com/yuvipanda/10481205","created_at":"2016-03-24T16:37:42Z","updated_at":"2016-10-19T23:51:56Z","closed_at":"2016-10-19T23:51:56Z","merged_at":null,"merge_commit_sha":"6dc1d233029024b9a0fe266124dde2c66af056e4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3318/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/1bc9cf0db5db4874b6685d5060e0f30c869f33ee","head":{"label":"bgeesaman:bgeesaman-patch-1","ref":"bgeesaman-patch-1","sha":"1bc9cf0db5db4874b6685d5060e0f30c869f33ee","user":{"login":"bgeesaman","id":3769609,"avatar_url":"https://avatars.githubusercontent.com/u/3769609?v=3","gravatar_id":"","url":"https://api.github.com/users/bgeesaman","html_url":"https://github.com/bgeesaman","followers_url":"https://api.github.com/users/bgeesaman/followers","following_url":"https://api.github.com/users/bgeesaman/following{/other_user}","gists_url":"https://api.github.com/users/bgeesaman/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeesaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeesaman/subscriptions","organizations_url":"https://api.github.com/users/bgeesaman/orgs","repos_url":"https://api.github.com/users/bgeesaman/repos","events_url":"https://api.github.com/users/bgeesaman/events{/privacy}","received_events_url":"https://api.github.com/users/bgeesaman/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"ansible:devel","ref":"devel","sha":"a2f41dfb043df33a068520634838a32fc695a124","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474126,"name":"ansible-modules-core","full_name":"ansible/ansible-modules-core","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-core","description":"Ansible modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-core","forks_url":"https://api.github.com/repos/ansible/ansible-modules-core/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-core/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-core/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-core/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-core/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-core/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-core/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible-modules-core/deployments","created_at":"2014-09-25T20:28:25Z","updated_at":"2016-10-19T19:21:11Z","pushed_at":"2016-10-19T23:50:22Z","git_url":"git://github.com/ansible/ansible-modules-core.git","ssh_url":"git@github.com:ansible/ansible-modules-core.git","clone_url":"https://github.com/ansible/ansible-modules-core.git","svn_url":"https://github.com/ansible/ansible-modules-core","homepage":"","size":20468,"stargazers_count":868,"watchers_count":868,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1927,"mirror_url":null,"open_issues_count":1178,"forks":1927,"open_issues":1178,"watchers":868,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318"},"html":{"href":"https://github.com/ansible/ansible-modules-core/pull/3318"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3318"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3318/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3318/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/1bc9cf0db5db4874b6685d5060e0f30c869f33ee"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":14,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ryansb"}}