{"action":"opened","number":4061,"pull_request":{"url":"https://api.github.com/repos/jruby/jruby/pulls/4061","id":80754642,"html_url":"https://github.com/jruby/jruby/pull/4061","diff_url":"https://github.com/jruby/jruby/pull/4061.diff","patch_url":"https://github.com/jruby/jruby/pull/4061.patch","issue_url":"https://api.github.com/repos/jruby/jruby/issues/4061","number":4061,"state":"open","locked":false,"title":"Fix Socket.tcp connect_timeout option","user":{"login":"etehtsea","id":100999,"avatar_url":"https://avatars.githubusercontent.com/u/100999?v=3","gravatar_id":"","url":"https://api.github.com/users/etehtsea","html_url":"https://github.com/etehtsea","followers_url":"https://api.github.com/users/etehtsea/followers","following_url":"https://api.github.com/users/etehtsea/following{/other_user}","gists_url":"https://api.github.com/users/etehtsea/gists{/gist_id}","starred_url":"https://api.github.com/users/etehtsea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etehtsea/subscriptions","organizations_url":"https://api.github.com/users/etehtsea/orgs","repos_url":"https://api.github.com/users/etehtsea/repos","events_url":"https://api.github.com/users/etehtsea/events{/privacy}","received_events_url":"https://api.github.com/users/etehtsea/received_events","type":"User","site_admin":false},"body":"Before commit `Socket.tcp(host, port, connect_timeout: 0.1)`\r\nignored timeout option. This happened because `connect_internal`\r\nmistakenly responded ith `:wait_readable` instead `:wait_writable`.\r\nAfter fixing it this code started to constantly fail with timeout error.\r\nChecking for OP_CONNECT in RubyThread.select fixed this issue.\r\n\r\nAdded adopted spec from MRI, because it's excluded by other reasons. Also added RubySpec (cross PR https://github.com/ruby/spec/pull/278)","created_at":"2016-08-10T08:35:49Z","updated_at":"2016-08-10T08:35:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jruby/jruby/pulls/4061/commits","review_comments_url":"https://api.github.com/repos/jruby/jruby/pulls/4061/comments","review_comment_url":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/4061/comments","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/59e58bee8ac3a44ce030352c42c74338845bd6ce","head":{"label":"etehtsea:fix-connect-timeout","ref":"fix-connect-timeout","sha":"59e58bee8ac3a44ce030352c42c74338845bd6ce","user":{"login":"etehtsea","id":100999,"avatar_url":"https://avatars.githubusercontent.com/u/100999?v=3","gravatar_id":"","url":"https://api.github.com/users/etehtsea","html_url":"https://github.com/etehtsea","followers_url":"https://api.github.com/users/etehtsea/followers","following_url":"https://api.github.com/users/etehtsea/following{/other_user}","gists_url":"https://api.github.com/users/etehtsea/gists{/gist_id}","starred_url":"https://api.github.com/users/etehtsea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etehtsea/subscriptions","organizations_url":"https://api.github.com/users/etehtsea/orgs","repos_url":"https://api.github.com/users/etehtsea/repos","events_url":"https://api.github.com/users/etehtsea/events{/privacy}","received_events_url":"https://api.github.com/users/etehtsea/received_events","type":"User","site_admin":false},"repo":{"id":49498041,"name":"jruby","full_name":"etehtsea/jruby","owner":{"login":"etehtsea","id":100999,"avatar_url":"https://avatars.githubusercontent.com/u/100999?v=3","gravatar_id":"","url":"https://api.github.com/users/etehtsea","html_url":"https://github.com/etehtsea","followers_url":"https://api.github.com/users/etehtsea/followers","following_url":"https://api.github.com/users/etehtsea/following{/other_user}","gists_url":"https://api.github.com/users/etehtsea/gists{/gist_id}","starred_url":"https://api.github.com/users/etehtsea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etehtsea/subscriptions","organizations_url":"https://api.github.com/users/etehtsea/orgs","repos_url":"https://api.github.com/users/etehtsea/repos","events_url":"https://api.github.com/users/etehtsea/events{/privacy}","received_events_url":"https://api.github.com/users/etehtsea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etehtsea/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":true,"url":"https://api.github.com/repos/etehtsea/jruby","forks_url":"https://api.github.com/repos/etehtsea/jruby/forks","keys_url":"https://api.github.com/repos/etehtsea/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etehtsea/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etehtsea/jruby/teams","hooks_url":"https://api.github.com/repos/etehtsea/jruby/hooks","issue_events_url":"https://api.github.com/repos/etehtsea/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/etehtsea/jruby/events","assignees_url":"https://api.github.com/repos/etehtsea/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/etehtsea/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/etehtsea/jruby/tags","blobs_url":"https://api.github.com/repos/etehtsea/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etehtsea/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etehtsea/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/etehtsea/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etehtsea/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/etehtsea/jruby/languages","stargazers_url":"https://api.github.com/repos/etehtsea/jruby/stargazers","contributors_url":"https://api.github.com/repos/etehtsea/jruby/contributors","subscribers_url":"https://api.github.com/repos/etehtsea/jruby/subscribers","subscription_url":"https://api.github.com/repos/etehtsea/jruby/subscription","commits_url":"https://api.github.com/repos/etehtsea/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/etehtsea/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/etehtsea/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/etehtsea/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/etehtsea/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/etehtsea/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etehtsea/jruby/merges","archive_url":"https://api.github.com/repos/etehtsea/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etehtsea/jruby/downloads","issues_url":"https://api.github.com/repos/etehtsea/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/etehtsea/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/etehtsea/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/etehtsea/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etehtsea/jruby/labels{/name}","releases_url":"https://api.github.com/repos/etehtsea/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/etehtsea/jruby/deployments","created_at":"2016-01-12T12:13:24Z","updated_at":"2016-01-12T12:13:44Z","pushed_at":"2016-08-10T08:22:18Z","git_url":"git://github.com/etehtsea/jruby.git","ssh_url":"git@github.com:etehtsea/jruby.git","clone_url":"https://github.com/etehtsea/jruby.git","svn_url":"https://github.com/etehtsea/jruby","homepage":"http://www.jruby.org","size":202777,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jruby:master","ref":"master","sha":"175cdf6e8ba708c7558d6fdf6e0ecfed3450af11","user":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"name":"jruby","full_name":"jruby/jruby","owner":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/jruby/jruby/deployments","created_at":"2009-04-05T03:54:35Z","updated_at":"2016-08-09T03:59:14Z","pushed_at":"2016-08-10T08:35:49Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":300397,"stargazers_count":2597,"watchers_count":2597,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":683,"mirror_url":null,"open_issues_count":819,"forks":683,"open_issues":819,"watchers":2597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/4061"},"html":{"href":"https://github.com/jruby/jruby/pull/4061"},"issue":{"href":"https://api.github.com/repos/jruby/jruby/issues/4061"},"comments":{"href":"https://api.github.com/repos/jruby/jruby/issues/4061/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby/jruby/pulls/4061/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jruby/jruby/pulls/4061/commits"},"statuses":{"href":"https://api.github.com/repos/jruby/jruby/statuses/59e58bee8ac3a44ce030352c42c74338845bd6ce"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"etehtsea"}}