{"action":"created","issue":{"url":"https://api.github.com/repos/enthought/traits/issues/326","repository_url":"https://api.github.com/repos/enthought/traits","labels_url":"https://api.github.com/repos/enthought/traits/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/enthought/traits/issues/326/comments","events_url":"https://api.github.com/repos/enthought/traits/issues/326/events","html_url":"https://github.com/enthought/traits/pull/326","id":173974813,"number":326,"title":"Remove command-line option for setting toolkit","user":{"login":"corranwebster","id":600761,"avatar_url":"https://avatars.githubusercontent.com/u/600761?v=3","gravatar_id":"","url":"https://api.github.com/users/corranwebster","html_url":"https://github.com/corranwebster","followers_url":"https://api.github.com/users/corranwebster/followers","following_url":"https://api.github.com/users/corranwebster/following{/other_user}","gists_url":"https://api.github.com/users/corranwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/corranwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corranwebster/subscriptions","organizations_url":"https://api.github.com/users/corranwebster/orgs","repos_url":"https://api.github.com/users/corranwebster/repos","events_url":"https://api.github.com/users/corranwebster/events{/privacy}","received_events_url":"https://api.github.com/users/corranwebster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-30T09:44:54Z","updated_at":"2016-08-30T12:26:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/enthought/traits/pulls/326","html_url":"https://github.com/enthought/traits/pull/326","diff_url":"https://github.com/enthought/traits/pull/326.diff","patch_url":"https://github.com/enthought/traits/pull/326.patch"},"body":"At present the ETSConfig option looks to see if there is are items `-toolkit` and a toolkit name adjacent in `sys.argv`; if so it removes them and uses the supplied toolkit.  This is completely independent of any other command-line argument processing done by other code, and the processing is done when the toolkit is first requested (which could occur in any number of places, possibly as a side-effect of imports), which may or may not be before any other argument parsing is done.  This is a potential source of subtle bugs.\r\n\r\nAdditionally, the use of `-toolkit` vs. `--toolkit` may be surprising to some, as it goes against some conventions for command-line argument use.\r\n\r\nThis PR removes this code and corresponding tests.\r\n\r\nThis is obviously a backward-incompatible change, although I have never seen the `-toolkit` option used.\r\n\r\nFurthermore, this PR shouldn't be merged without the blessing of either @rkern or @mdickinson."},"comment":{"url":"https://api.github.com/repos/enthought/traits/issues/comments/243422253","html_url":"https://github.com/enthought/traits/pull/326#issuecomment-243422253","issue_url":"https://api.github.com/repos/enthought/traits/issues/326","id":243422253,"user":{"login":"rkern","id":46135,"avatar_url":"https://avatars.githubusercontent.com/u/46135?v=3","gravatar_id":"","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T12:26:54Z","updated_at":"2016-08-30T12:26:54Z","body":"Agreed.\r\n\r\nThere are a few remaining references to the option in docstrings. `grin -- '-toolkit'` will help find them. It also is documented in the TraitsUI documentation: https://github.com/enthought/traitsui/blob/master/docs/source/traitsui_user_manual/intro.rst#toolkit-selection"}}
{"actor":{"display_login":"rkern"}}