{"action":"created","comment":{"url":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments/84111524","pull_request_review_id":4909797,"id":84111524,"diff_hunk":"@@ -5,7 +5,8 @@ import {\n \n class MatchProvider extends React.Component {\n   static childContextTypes = {\n-    match: matchContextType.isRequired\n+    match: matchContextType.isRequired,","path":"modules/MatchProvider.js","position":5,"original_position":5,"commit_id":"a2c9143844aaaf6d02a8b954f69e5d36435d2542","original_commit_id":"139ac05e772e39958adc040df6e8347ac0579782","user":{"login":"pshrmn","id":1127037,"avatar_url":"https://avatars.githubusercontent.com/u/1127037?v=3","gravatar_id":"","url":"https://api.github.com/users/pshrmn","html_url":"https://github.com/pshrmn","followers_url":"https://api.github.com/users/pshrmn/followers","following_url":"https://api.github.com/users/pshrmn/following{/other_user}","gists_url":"https://api.github.com/users/pshrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/pshrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshrmn/subscriptions","organizations_url":"https://api.github.com/users/pshrmn/orgs","repos_url":"https://api.github.com/users/pshrmn/repos","events_url":"https://api.github.com/users/pshrmn/events{/privacy}","received_events_url":"https://api.github.com/users/pshrmn/received_events","type":"User","site_admin":false},"body":"I'll hold off on changing this, but I agree that `match` is ambiguous and a different name might be preferable.","created_at":"2016-10-19T16:31:21Z","updated_at":"2016-10-19T16:31:21Z","html_url":"https://github.com/ReactTraining/react-router/pull/4067#discussion_r84111524","pull_request_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067","_links":{"self":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments/84111524"},"html":{"href":"https://github.com/ReactTraining/react-router/pull/4067#discussion_r84111524"},"pull_request":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067"}}},"pull_request":{"url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067","id":90034573,"html_url":"https://github.com/ReactTraining/react-router/pull/4067","diff_url":"https://github.com/ReactTraining/react-router/pull/4067.diff","patch_url":"https://github.com/ReactTraining/react-router/pull/4067.patch","issue_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4067","number":4067,"state":"open","locked":false,"title":"[WIP] manage location through MatchProvider","user":{"login":"pshrmn","id":1127037,"avatar_url":"https://avatars.githubusercontent.com/u/1127037?v=3","gravatar_id":"","url":"https://api.github.com/users/pshrmn","html_url":"https://github.com/pshrmn","followers_url":"https://api.github.com/users/pshrmn/followers","following_url":"https://api.github.com/users/pshrmn/following{/other_user}","gists_url":"https://api.github.com/users/pshrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/pshrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshrmn/subscriptions","organizations_url":"https://api.github.com/users/pshrmn/orgs","repos_url":"https://api.github.com/users/pshrmn/repos","events_url":"https://api.github.com/users/pshrmn/events{/privacy}","received_events_url":"https://api.github.com/users/pshrmn/received_events","type":"User","site_admin":false},"body":"This is a way to manage location changes that is resistant to `shouldComponentUpdate`.\r\n\r\nThe main change is that `<MatchProvider>` components are kept updated about the current location. All `<Match>` and `<Miss>` children of a `<MatchProvider>` provide it with update functions. The `<Match>` update functions return a boolean indicating whether they match against the current location. The `<Miss>` update function is the same as the current one.\r\n\r\n`<Match>` maintains a `match` state, which is the result of `matchPattern` and is set whenever the component updates naturally (through `componentWillReceiveProps`) or when its `update` function is called.\r\n\r\nThis passes the failing miss test that @alisd23 wrote in #4047, but may need additional tests to verify its correctness.\r\n\r\nRelated issue: #4035","created_at":"2016-10-19T15:34:07Z","updated_at":"2016-10-19T16:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc26156433be8049e901a129a1b89dea5f0f1f7a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ReactTraining/react-router/milestones/18","html_url":"https://github.com/ReactTraining/react-router/milestones/v4.0.0","labels_url":"https://api.github.com/repos/ReactTraining/react-router/milestones/18/labels","id":1961834,"number":18,"title":"v4.0.0","description":"","creator":{"login":"timdorr","id":17882,"avatar_url":"https://avatars.githubusercontent.com/u/17882?v=3","gravatar_id":"","url":"https://api.github.com/users/timdorr","html_url":"https://github.com/timdorr","followers_url":"https://api.github.com/users/timdorr/followers","following_url":"https://api.github.com/users/timdorr/following{/other_user}","gists_url":"https://api.github.com/users/timdorr/gists{/gist_id}","starred_url":"https://api.github.com/users/timdorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdorr/subscriptions","organizations_url":"https://api.github.com/users/timdorr/orgs","repos_url":"https://api.github.com/users/timdorr/repos","events_url":"https://api.github.com/users/timdorr/events{/privacy}","received_events_url":"https://api.github.com/users/timdorr/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":34,"state":"open","created_at":"2016-08-24T22:46:03Z","updated_at":"2016-10-19T15:42:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067/commits","review_comments_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067/comments","review_comment_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4067/comments","statuses_url":"https://api.github.com/repos/ReactTraining/react-router/statuses/a2c9143844aaaf6d02a8b954f69e5d36435d2542","head":{"label":"pshrmn:matchprovider-location","ref":"matchprovider-location","sha":"a2c9143844aaaf6d02a8b954f69e5d36435d2542","user":{"login":"pshrmn","id":1127037,"avatar_url":"https://avatars.githubusercontent.com/u/1127037?v=3","gravatar_id":"","url":"https://api.github.com/users/pshrmn","html_url":"https://github.com/pshrmn","followers_url":"https://api.github.com/users/pshrmn/followers","following_url":"https://api.github.com/users/pshrmn/following{/other_user}","gists_url":"https://api.github.com/users/pshrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/pshrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshrmn/subscriptions","organizations_url":"https://api.github.com/users/pshrmn/orgs","repos_url":"https://api.github.com/users/pshrmn/repos","events_url":"https://api.github.com/users/pshrmn/events{/privacy}","received_events_url":"https://api.github.com/users/pshrmn/received_events","type":"User","site_admin":false},"repo":{"id":71083822,"name":"react-router","full_name":"pshrmn/react-router","owner":{"login":"pshrmn","id":1127037,"avatar_url":"https://avatars.githubusercontent.com/u/1127037?v=3","gravatar_id":"","url":"https://api.github.com/users/pshrmn","html_url":"https://github.com/pshrmn","followers_url":"https://api.github.com/users/pshrmn/followers","following_url":"https://api.github.com/users/pshrmn/following{/other_user}","gists_url":"https://api.github.com/users/pshrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/pshrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshrmn/subscriptions","organizations_url":"https://api.github.com/users/pshrmn/orgs","repos_url":"https://api.github.com/users/pshrmn/repos","events_url":"https://api.github.com/users/pshrmn/events{/privacy}","received_events_url":"https://api.github.com/users/pshrmn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pshrmn/react-router","description":"Declarative routing for React","fork":true,"url":"https://api.github.com/repos/pshrmn/react-router","forks_url":"https://api.github.com/repos/pshrmn/react-router/forks","keys_url":"https://api.github.com/repos/pshrmn/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pshrmn/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pshrmn/react-router/teams","hooks_url":"https://api.github.com/repos/pshrmn/react-router/hooks","issue_events_url":"https://api.github.com/repos/pshrmn/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/pshrmn/react-router/events","assignees_url":"https://api.github.com/repos/pshrmn/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/pshrmn/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/pshrmn/react-router/tags","blobs_url":"https://api.github.com/repos/pshrmn/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pshrmn/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pshrmn/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/pshrmn/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pshrmn/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/pshrmn/react-router/languages","stargazers_url":"https://api.github.com/repos/pshrmn/react-router/stargazers","contributors_url":"https://api.github.com/repos/pshrmn/react-router/contributors","subscribers_url":"https://api.github.com/repos/pshrmn/react-router/subscribers","subscription_url":"https://api.github.com/repos/pshrmn/react-router/subscription","commits_url":"https://api.github.com/repos/pshrmn/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/pshrmn/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/pshrmn/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/pshrmn/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/pshrmn/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/pshrmn/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pshrmn/react-router/merges","archive_url":"https://api.github.com/repos/pshrmn/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pshrmn/react-router/downloads","issues_url":"https://api.github.com/repos/pshrmn/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/pshrmn/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/pshrmn/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/pshrmn/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pshrmn/react-router/labels{/name}","releases_url":"https://api.github.com/repos/pshrmn/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/pshrmn/react-router/deployments","created_at":"2016-10-16T23:33:34Z","updated_at":"2016-10-16T23:33:37Z","pushed_at":"2016-10-19T16:24:00Z","git_url":"git://github.com/pshrmn/react-router.git","ssh_url":"git@github.com:pshrmn/react-router.git","clone_url":"https://github.com/pshrmn/react-router.git","svn_url":"https://github.com/pshrmn/react-router","homepage":"","size":5832,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactTraining:v4","ref":"v4","sha":"fcd8e3ef754ccab18a004351756c18c954bfb7f9","user":{"login":"ReactTraining","id":11823761,"avatar_url":"https://avatars.githubusercontent.com/u/11823761?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactTraining","html_url":"https://github.com/ReactTraining","followers_url":"https://api.github.com/users/ReactTraining/followers","following_url":"https://api.github.com/users/ReactTraining/following{/other_user}","gists_url":"https://api.github.com/users/ReactTraining/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactTraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactTraining/subscriptions","organizations_url":"https://api.github.com/users/ReactTraining/orgs","repos_url":"https://api.github.com/users/ReactTraining/repos","events_url":"https://api.github.com/users/ReactTraining/events{/privacy}","received_events_url":"https://api.github.com/users/ReactTraining/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"ReactTraining/react-router","owner":{"login":"ReactTraining","id":11823761,"avatar_url":"https://avatars.githubusercontent.com/u/11823761?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactTraining","html_url":"https://github.com/ReactTraining","followers_url":"https://api.github.com/users/ReactTraining/followers","following_url":"https://api.github.com/users/ReactTraining/following{/other_user}","gists_url":"https://api.github.com/users/ReactTraining/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactTraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactTraining/subscriptions","organizations_url":"https://api.github.com/users/ReactTraining/orgs","repos_url":"https://api.github.com/users/ReactTraining/repos","events_url":"https://api.github.com/users/ReactTraining/events{/privacy}","received_events_url":"https://api.github.com/users/ReactTraining/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactTraining/react-router","description":"Declarative routing for React","fork":false,"url":"https://api.github.com/repos/ReactTraining/react-router","forks_url":"https://api.github.com/repos/ReactTraining/react-router/forks","keys_url":"https://api.github.com/repos/ReactTraining/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactTraining/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactTraining/react-router/teams","hooks_url":"https://api.github.com/repos/ReactTraining/react-router/hooks","issue_events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/ReactTraining/react-router/events","assignees_url":"https://api.github.com/repos/ReactTraining/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/ReactTraining/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/ReactTraining/react-router/tags","blobs_url":"https://api.github.com/repos/ReactTraining/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactTraining/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactTraining/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactTraining/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactTraining/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactTraining/react-router/languages","stargazers_url":"https://api.github.com/repos/ReactTraining/react-router/stargazers","contributors_url":"https://api.github.com/repos/ReactTraining/react-router/contributors","subscribers_url":"https://api.github.com/repos/ReactTraining/react-router/subscribers","subscription_url":"https://api.github.com/repos/ReactTraining/react-router/subscription","commits_url":"https://api.github.com/repos/ReactTraining/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactTraining/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactTraining/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactTraining/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/ReactTraining/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactTraining/react-router/merges","archive_url":"https://api.github.com/repos/ReactTraining/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactTraining/react-router/downloads","issues_url":"https://api.github.com/repos/ReactTraining/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/ReactTraining/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactTraining/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactTraining/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactTraining/react-router/labels{/name}","releases_url":"https://api.github.com/repos/ReactTraining/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/ReactTraining/react-router/deployments","created_at":"2014-05-16T22:22:51Z","updated_at":"2016-10-19T16:02:50Z","pushed_at":"2016-10-19T16:24:01Z","git_url":"git://github.com/ReactTraining/react-router.git","ssh_url":"git@github.com:ReactTraining/react-router.git","clone_url":"https://github.com/ReactTraining/react-router.git","svn_url":"https://github.com/ReactTraining/react-router","homepage":"","size":9546,"stargazers_count":16899,"watchers_count":16899,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3856,"mirror_url":null,"open_issues_count":34,"forks":3856,"open_issues":34,"watchers":16899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067"},"html":{"href":"https://github.com/ReactTraining/react-router/pull/4067"},"issue":{"href":"https://api.github.com/repos/ReactTraining/react-router/issues/4067"},"comments":{"href":"https://api.github.com/repos/ReactTraining/react-router/issues/4067/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4067/commits"},"statuses":{"href":"https://api.github.com/repos/ReactTraining/react-router/statuses/a2c9143844aaaf6d02a8b954f69e5d36435d2542"}}}}
{"actor":{"display_login":"pshrmn"}}