{"action":"created","issue":{"url":"https://api.github.com/repos/haskell/ghc-events/issues/13","repository_url":"https://api.github.com/repos/haskell/ghc-events","labels_url":"https://api.github.com/repos/haskell/ghc-events/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/haskell/ghc-events/issues/13/comments","events_url":"https://api.github.com/repos/haskell/ghc-events/issues/13/events","html_url":"https://github.com/haskell/ghc-events/pull/13","id":160690485,"number":13,"title":"Incremental parser, cleaned up branch","user":{"login":"kvelicka","id":1649201,"avatar_url":"https://avatars.githubusercontent.com/u/1649201?v=3","gravatar_id":"","url":"https://api.github.com/users/kvelicka","html_url":"https://github.com/kvelicka","followers_url":"https://api.github.com/users/kvelicka/followers","following_url":"https://api.github.com/users/kvelicka/following{/other_user}","gists_url":"https://api.github.com/users/kvelicka/gists{/gist_id}","starred_url":"https://api.github.com/users/kvelicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvelicka/subscriptions","organizations_url":"https://api.github.com/users/kvelicka/orgs","repos_url":"https://api.github.com/users/kvelicka/repos","events_url":"https://api.github.com/users/kvelicka/events{/privacy}","received_events_url":"https://api.github.com/users/kvelicka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2016-06-16T15:28:13Z","updated_at":"2016-06-21T14:32:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haskell/ghc-events/pulls/13","html_url":"https://github.com/haskell/ghc-events/pull/13","diff_url":"https://github.com/haskell/ghc-events/pull/13.diff","patch_url":"https://github.com/haskell/ghc-events/pull/13.patch"},"body":"The long-overdue cleanup of my incremental parser for ghc-events. All the history is now linear, and some unnecessary commits were omitted.\r\n\r\n@Mikolaj, should be ready for a review! However, the commit timeline still reflects the progress of the work as it was originally implemented, so there will be some bits that get implemented, and then re-implemented/removed. I hope that this will not be too inconvenient.  \r\nNote that in the final version the test cases are failing since the log re-writing has been broken for God knows how long (pre-0.4.4.0 at least) and the pretty printer output was (I suspect) altered by the PRs to master that were made after my original branch split off. If this is all looking good, I'm willing to look into these further, as well as other issues/PRs to ghc-events and Threadscope."},"comment":{"url":"https://api.github.com/repos/haskell/ghc-events/issues/comments/227458450","html_url":"https://github.com/haskell/ghc-events/pull/13#issuecomment-227458450","issue_url":"https://api.github.com/repos/haskell/ghc-events/issues/13","id":227458450,"user":{"login":"Mikolaj","id":281893,"avatar_url":"https://avatars.githubusercontent.com/u/281893?v=3","gravatar_id":"","url":"https://api.github.com/users/Mikolaj","html_url":"https://github.com/Mikolaj","followers_url":"https://api.github.com/users/Mikolaj/followers","following_url":"https://api.github.com/users/Mikolaj/following{/other_user}","gists_url":"https://api.github.com/users/Mikolaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikolaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikolaj/subscriptions","organizations_url":"https://api.github.com/users/Mikolaj/orgs","repos_url":"https://api.github.com/users/Mikolaj/repos","events_url":"https://api.github.com/users/Mikolaj/events{/privacy}","received_events_url":"https://api.github.com/users/Mikolaj/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T14:32:22Z","updated_at":"2016-06-21T14:32:22Z","body":"Yes, I think it would make sense to get some numbers. O(log n) is rather small, so we should not be seeing a huge difference, unless there is some other slowdown or the constants are much larger in some situations. With some luck, the huge eventlogs would let us see past any fluke small scale slowdowns, such as the one with loading the mandelbrot log.\r\n\r\nAs for my plans, I'd like to finish reading the actual PR and finish testing TS by Friday. Then, unless @simonmar or anybody else objects, I'd like to merge the PR and merge the TS changes to master. I guess we may wait with the actual new Hackage releases until we polish things a bit more."}}
{"actor":{"display_login":"Mikolaj"}}