{"action":"closed","number":19438,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438","id":88735974,"html_url":"https://github.com/NixOS/nixpkgs/pull/19438","diff_url":"https://github.com/NixOS/nixpkgs/pull/19438.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19438.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19438","number":19438,"state":"closed","locked":false,"title":"vim module: init","user":{"login":"primeos","id":7537109,"avatar_url":"https://avatars.githubusercontent.com/u/7537109?v=3","gravatar_id":"","url":"https://api.github.com/users/primeos","html_url":"https://github.com/primeos","followers_url":"https://api.github.com/users/primeos/followers","following_url":"https://api.github.com/users/primeos/following{/other_user}","gists_url":"https://api.github.com/users/primeos/gists{/gist_id}","starred_url":"https://api.github.com/users/primeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primeos/subscriptions","organizations_url":"https://api.github.com/users/primeos/orgs","repos_url":"https://api.github.com/users/primeos/repos","events_url":"https://api.github.com/users/primeos/events{/privacy}","received_events_url":"https://api.github.com/users/primeos/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nMy main motivation is to provide the `services.vim.defaultEditor` wich a user could set in order to make vim (instead of nano) the system wide default text editor via the `EDITOR` environment variable (and it'll install vim if that isn't already the case). I don't know if the `services.vim.install` option makes sense since the same effect can be achieved by simply adding vim to the systemPackages.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nNote: If both `services.vim.defaultEditor` and `services.emacs.defaultEditor` are set vim will be the default editor (not tested...) since the priority is lower (`mkForce` / `mkOverride 10` vs `mkOverride 900`). Is that ok or should I also use 900? I just thought mkForce (which apparently uses 10) would fit better. I must also admit that this probably isn't the best solution due to the emacs collision, however the user should avoid that anyway. An alternative would be to introduce a generic `defaultEditor` option.","created_at":"2016-10-10T21:40:59Z","updated_at":"2016-10-12T13:30:44Z","closed_at":"2016-10-12T13:30:44Z","merged_at":"2016-10-12T13:30:44Z","merge_commit_sha":"ce3624f6b41f7d90efca662b781a72ba513ae3e0","assignee":{"login":"jagajaga","id":2179419,"avatar_url":"https://avatars.githubusercontent.com/u/2179419?v=3","gravatar_id":"","url":"https://api.github.com/users/jagajaga","html_url":"https://github.com/jagajaga","followers_url":"https://api.github.com/users/jagajaga/followers","following_url":"https://api.github.com/users/jagajaga/following{/other_user}","gists_url":"https://api.github.com/users/jagajaga/gists{/gist_id}","starred_url":"https://api.github.com/users/jagajaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagajaga/subscriptions","organizations_url":"https://api.github.com/users/jagajaga/orgs","repos_url":"https://api.github.com/users/jagajaga/repos","events_url":"https://api.github.com/users/jagajaga/events{/privacy}","received_events_url":"https://api.github.com/users/jagajaga/received_events","type":"User","site_admin":false},"assignees":[{"login":"jagajaga","id":2179419,"avatar_url":"https://avatars.githubusercontent.com/u/2179419?v=3","gravatar_id":"","url":"https://api.github.com/users/jagajaga","html_url":"https://github.com/jagajaga","followers_url":"https://api.github.com/users/jagajaga/followers","following_url":"https://api.github.com/users/jagajaga/following{/other_user}","gists_url":"https://api.github.com/users/jagajaga/gists{/gist_id}","starred_url":"https://api.github.com/users/jagajaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagajaga/subscriptions","organizations_url":"https://api.github.com/users/jagajaga/orgs","repos_url":"https://api.github.com/users/jagajaga/repos","events_url":"https://api.github.com/users/jagajaga/events{/privacy}","received_events_url":"https://api.github.com/users/jagajaga/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19438/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8c21021f0f6132ba88205afb8357610f2bc6eb3b","head":{"label":"primeos:vim-service","ref":"vim-service","sha":"8c21021f0f6132ba88205afb8357610f2bc6eb3b","user":{"login":"primeos","id":7537109,"avatar_url":"https://avatars.githubusercontent.com/u/7537109?v=3","gravatar_id":"","url":"https://api.github.com/users/primeos","html_url":"https://github.com/primeos","followers_url":"https://api.github.com/users/primeos/followers","following_url":"https://api.github.com/users/primeos/following{/other_user}","gists_url":"https://api.github.com/users/primeos/gists{/gist_id}","starred_url":"https://api.github.com/users/primeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primeos/subscriptions","organizations_url":"https://api.github.com/users/primeos/orgs","repos_url":"https://api.github.com/users/primeos/repos","events_url":"https://api.github.com/users/primeos/events{/privacy}","received_events_url":"https://api.github.com/users/primeos/received_events","type":"User","site_admin":false},"repo":{"id":70061637,"name":"nixpkgs","full_name":"primeos/nixpkgs","owner":{"login":"primeos","id":7537109,"avatar_url":"https://avatars.githubusercontent.com/u/7537109?v=3","gravatar_id":"","url":"https://api.github.com/users/primeos","html_url":"https://github.com/primeos","followers_url":"https://api.github.com/users/primeos/followers","following_url":"https://api.github.com/users/primeos/following{/other_user}","gists_url":"https://api.github.com/users/primeos/gists{/gist_id}","starred_url":"https://api.github.com/users/primeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primeos/subscriptions","organizations_url":"https://api.github.com/users/primeos/orgs","repos_url":"https://api.github.com/users/primeos/repos","events_url":"https://api.github.com/users/primeos/events{/privacy}","received_events_url":"https://api.github.com/users/primeos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/primeos/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/primeos/nixpkgs","forks_url":"https://api.github.com/repos/primeos/nixpkgs/forks","keys_url":"https://api.github.com/repos/primeos/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/primeos/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/primeos/nixpkgs/teams","hooks_url":"https://api.github.com/repos/primeos/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/primeos/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/primeos/nixpkgs/events","assignees_url":"https://api.github.com/repos/primeos/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/primeos/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/primeos/nixpkgs/tags","blobs_url":"https://api.github.com/repos/primeos/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/primeos/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/primeos/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/primeos/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/primeos/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/primeos/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/primeos/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/primeos/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/primeos/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/primeos/nixpkgs/subscription","commits_url":"https://api.github.com/repos/primeos/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/primeos/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/primeos/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/primeos/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/primeos/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/primeos/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/primeos/nixpkgs/merges","archive_url":"https://api.github.com/repos/primeos/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/primeos/nixpkgs/downloads","issues_url":"https://api.github.com/repos/primeos/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/primeos/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/primeos/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/primeos/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/primeos/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/primeos/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/primeos/nixpkgs/deployments","created_at":"2016-10-05T13:10:51Z","updated_at":"2016-10-05T13:11:15Z","pushed_at":"2016-10-10T22:14:39Z","git_url":"git://github.com/primeos/nixpkgs.git","ssh_url":"git@github.com:primeos/nixpkgs.git","clone_url":"https://github.com/primeos/nixpkgs.git","svn_url":"https://github.com/primeos/nixpkgs","homepage":null,"size":363270,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b44e79e2406c4da151b9eb6a35756dc2c51c94b1","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-10-12T04:39:13Z","pushed_at":"2016-10-12T13:30:44Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":611625,"stargazers_count":1337,"watchers_count":1337,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1660,"mirror_url":null,"open_issues_count":1523,"forks":1660,"open_issues":1523,"watchers":1337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19438"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19438"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19438/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19438/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8c21021f0f6132ba88205afb8357610f2bc6eb3b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jagajaga","id":2179419,"avatar_url":"https://avatars.githubusercontent.com/u/2179419?v=3","gravatar_id":"","url":"https://api.github.com/users/jagajaga","html_url":"https://github.com/jagajaga","followers_url":"https://api.github.com/users/jagajaga/followers","following_url":"https://api.github.com/users/jagajaga/following{/other_user}","gists_url":"https://api.github.com/users/jagajaga/gists{/gist_id}","starred_url":"https://api.github.com/users/jagajaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagajaga/subscriptions","organizations_url":"https://api.github.com/users/jagajaga/orgs","repos_url":"https://api.github.com/users/jagajaga/repos","events_url":"https://api.github.com/users/jagajaga/events{/privacy}","received_events_url":"https://api.github.com/users/jagajaga/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":25,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"jagajaga"}}