{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1","id":74270670,"html_url":"https://github.com/jpmml/jpmml-sparkml/pull/1","diff_url":"https://github.com/jpmml/jpmml-sparkml/pull/1.diff","patch_url":"https://github.com/jpmml/jpmml-sparkml/pull/1.patch","issue_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/1","number":1,"state":"closed","locked":false,"title":"TreeModel PMML Export - add Node IDs","user":{"login":"dataRava","id":19995923,"avatar_url":"https://avatars.githubusercontent.com/u/19995923?v=3","gravatar_id":"","url":"https://api.github.com/users/dataRava","html_url":"https://github.com/dataRava","followers_url":"https://api.github.com/users/dataRava/followers","following_url":"https://api.github.com/users/dataRava/following{/other_user}","gists_url":"https://api.github.com/users/dataRava/gists{/gist_id}","starred_url":"https://api.github.com/users/dataRava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataRava/subscriptions","organizations_url":"https://api.github.com/users/dataRava/orgs","repos_url":"https://api.github.com/users/dataRava/repos","events_url":"https://api.github.com/users/dataRava/events{/privacy}","received_events_url":"https://api.github.com/users/dataRava/received_events","type":"User","site_admin":false},"body":"When we tried importing a .pmml file for a DecisionTree into KNIME, we noticed that KNIME needs Node ID tags for each Node in the DecisionTree which were missing in the exported file.\r\n\r\nThis is an attempt to fix this problem: \r\nIn TreeModelUtil.java we provide a function which uses a visitor object to visit every Node of a TreeModel and set their IDs to the value of a running index.\r\nIn DecisionTreeClassificationModelConverter.java we call this function after the creation of the treeModel object.\r\n\r\nPlease advise.","created_at":"2016-06-17T16:35:41Z","updated_at":"2016-10-08T05:29:35Z","closed_at":"2016-10-08T05:29:35Z","merged_at":null,"merge_commit_sha":"0795069d3214bab8f4958c6f33aa604e0cf29103","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/1/comments","statuses_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/statuses/30d0cebd337df7159b81d6be095797833b7de007","head":{"label":"dataRava:master","ref":"master","sha":"30d0cebd337df7159b81d6be095797833b7de007","user":{"login":"dataRava","id":19995923,"avatar_url":"https://avatars.githubusercontent.com/u/19995923?v=3","gravatar_id":"","url":"https://api.github.com/users/dataRava","html_url":"https://github.com/dataRava","followers_url":"https://api.github.com/users/dataRava/followers","following_url":"https://api.github.com/users/dataRava/following{/other_user}","gists_url":"https://api.github.com/users/dataRava/gists{/gist_id}","starred_url":"https://api.github.com/users/dataRava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataRava/subscriptions","organizations_url":"https://api.github.com/users/dataRava/orgs","repos_url":"https://api.github.com/users/dataRava/repos","events_url":"https://api.github.com/users/dataRava/events{/privacy}","received_events_url":"https://api.github.com/users/dataRava/received_events","type":"User","site_admin":false},"repo":{"id":61376141,"name":"jpmml-sparkml","full_name":"dataRava/jpmml-sparkml","owner":{"login":"dataRava","id":19995923,"avatar_url":"https://avatars.githubusercontent.com/u/19995923?v=3","gravatar_id":"","url":"https://api.github.com/users/dataRava","html_url":"https://github.com/dataRava","followers_url":"https://api.github.com/users/dataRava/followers","following_url":"https://api.github.com/users/dataRava/following{/other_user}","gists_url":"https://api.github.com/users/dataRava/gists{/gist_id}","starred_url":"https://api.github.com/users/dataRava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataRava/subscriptions","organizations_url":"https://api.github.com/users/dataRava/orgs","repos_url":"https://api.github.com/users/dataRava/repos","events_url":"https://api.github.com/users/dataRava/events{/privacy}","received_events_url":"https://api.github.com/users/dataRava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dataRava/jpmml-sparkml","description":"Java library and command-line application for converting Spark ML pipelines to PMML","fork":true,"url":"https://api.github.com/repos/dataRava/jpmml-sparkml","forks_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/forks","keys_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/teams","hooks_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/hooks","issue_events_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/issues/events{/number}","events_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/events","assignees_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/assignees{/user}","branches_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/branches{/branch}","tags_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/tags","blobs_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/git/refs{/sha}","trees_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/statuses/{sha}","languages_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/languages","stargazers_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/stargazers","contributors_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/contributors","subscribers_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/subscribers","subscription_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/subscription","commits_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/commits{/sha}","git_commits_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/git/commits{/sha}","comments_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/comments{/number}","issue_comment_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/issues/comments{/number}","contents_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/contents/{+path}","compare_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/merges","archive_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/downloads","issues_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/issues{/number}","pulls_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/pulls{/number}","milestones_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/milestones{/number}","notifications_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/labels{/name}","releases_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/releases{/id}","deployments_url":"https://api.github.com/repos/dataRava/jpmml-sparkml/deployments","created_at":"2016-06-17T13:37:41Z","updated_at":"2016-06-17T13:37:42Z","pushed_at":"2016-06-17T15:53:47Z","git_url":"git://github.com/dataRava/jpmml-sparkml.git","ssh_url":"git@github.com:dataRava/jpmml-sparkml.git","clone_url":"https://github.com/dataRava/jpmml-sparkml.git","svn_url":"https://github.com/dataRava/jpmml-sparkml","homepage":null,"size":755,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jpmml:master","ref":"master","sha":"3f28d6dcad7bbf66a826f3608245dbbc2c9626c0","user":{"login":"jpmml","id":3713638,"avatar_url":"https://avatars.githubusercontent.com/u/3713638?v=3","gravatar_id":"","url":"https://api.github.com/users/jpmml","html_url":"https://github.com/jpmml","followers_url":"https://api.github.com/users/jpmml/followers","following_url":"https://api.github.com/users/jpmml/following{/other_user}","gists_url":"https://api.github.com/users/jpmml/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmml/subscriptions","organizations_url":"https://api.github.com/users/jpmml/orgs","repos_url":"https://api.github.com/users/jpmml/repos","events_url":"https://api.github.com/users/jpmml/events{/privacy}","received_events_url":"https://api.github.com/users/jpmml/received_events","type":"Organization","site_admin":false},"repo":{"id":58119316,"name":"jpmml-sparkml","full_name":"jpmml/jpmml-sparkml","owner":{"login":"jpmml","id":3713638,"avatar_url":"https://avatars.githubusercontent.com/u/3713638?v=3","gravatar_id":"","url":"https://api.github.com/users/jpmml","html_url":"https://github.com/jpmml","followers_url":"https://api.github.com/users/jpmml/followers","following_url":"https://api.github.com/users/jpmml/following{/other_user}","gists_url":"https://api.github.com/users/jpmml/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmml/subscriptions","organizations_url":"https://api.github.com/users/jpmml/orgs","repos_url":"https://api.github.com/users/jpmml/repos","events_url":"https://api.github.com/users/jpmml/events{/privacy}","received_events_url":"https://api.github.com/users/jpmml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jpmml/jpmml-sparkml","description":"Java library and command-line application for converting Apache Spark ML pipelines to PMML","fork":false,"url":"https://api.github.com/repos/jpmml/jpmml-sparkml","forks_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/forks","keys_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/teams","hooks_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/hooks","issue_events_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/events{/number}","events_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/events","assignees_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/assignees{/user}","branches_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/branches{/branch}","tags_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/tags","blobs_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/statuses/{sha}","languages_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/languages","stargazers_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/stargazers","contributors_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/contributors","subscribers_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/subscribers","subscription_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/subscription","commits_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/contents/{+path}","compare_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/merges","archive_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/downloads","issues_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues{/number}","pulls_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls{/number}","milestones_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/milestones{/number}","notifications_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/labels{/name}","releases_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/releases{/id}","deployments_url":"https://api.github.com/repos/jpmml/jpmml-sparkml/deployments","created_at":"2016-05-05T09:16:59Z","updated_at":"2016-10-07T20:31:40Z","pushed_at":"2016-10-07T20:31:14Z","git_url":"git://github.com/jpmml/jpmml-sparkml.git","ssh_url":"git@github.com:jpmml/jpmml-sparkml.git","clone_url":"https://github.com/jpmml/jpmml-sparkml.git","svn_url":"https://github.com/jpmml/jpmml-sparkml","homepage":"","size":1439,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1"},"html":{"href":"https://github.com/jpmml/jpmml-sparkml/pull/1"},"issue":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/1"},"comments":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jpmml/jpmml-sparkml/statuses/30d0cebd337df7159b81d6be095797833b7de007"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":86,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"vruusmann"}}