{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/55575411","id":55575411,"diff_hunk":"@@ -0,0 +1,42 @@\n+/*\n+* Copyright (C) 2014-2016 LinkedIn Corp. All rights reserved.\n+*\n+* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+* this file except in compliance with the License. You may obtain a copy of the\n+* License at  http://www.apache.org/licenses/LICENSE-2.0\n+*\n+* Unless required by applicable law or agreed to in writing, software distributed\n+* under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+* CONDITIONS OF ANY KIND, either express or implied.\n+*/\n+\n+package gobblin.data.management.version.finder;\n+\n+import java.io.IOException;\n+import java.util.Collection;\n+\n+import gobblin.dataset.FileSystemDataset;\n+import gobblin.data.management.version.FileSystemDatasetVersion;\n+\n+\n+/**\n+ * Finds dataset versions.\n+ *\n+ * @param <T> Type of {@link DatasetVersion} expected from this class.\n+ */\n+public interface VersionFinder<T extends FileSystemDatasetVersion> {","path":"gobblin-data-management/src/main/java/gobblin/data/management/version/finder/VersionFinder.java","position":27,"original_position":27,"commit_id":"525db2772258f7b521fd18464d3bbafa6b32052d","original_commit_id":"525db2772258f7b521fd18464d3bbafa6b32052d","user":{"login":"ibuenros","id":1364112,"avatar_url":"https://avatars.githubusercontent.com/u/1364112?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuenros","html_url":"https://github.com/ibuenros","followers_url":"https://api.github.com/users/ibuenros/followers","following_url":"https://api.github.com/users/ibuenros/following{/other_user}","gists_url":"https://api.github.com/users/ibuenros/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuenros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuenros/subscriptions","organizations_url":"https://api.github.com/users/ibuenros/orgs","repos_url":"https://api.github.com/users/ibuenros/repos","events_url":"https://api.github.com/users/ibuenros/events{/privacy}","received_events_url":"https://api.github.com/users/ibuenros/received_events","type":"User","site_admin":false},"body":"Does this need to be restricted to `FileSystemDatasetVersion`?","created_at":"2016-03-09T19:36:15Z","updated_at":"2016-03-09T19:36:15Z","html_url":"https://github.com/linkedin/gobblin/pull/812#discussion_r55575411","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/812","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/55575411"},"html":{"href":"https://github.com/linkedin/gobblin/pull/812#discussion_r55575411"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/812"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/812","id":62156442,"html_url":"https://github.com/linkedin/gobblin/pull/812","diff_url":"https://github.com/linkedin/gobblin/pull/812.diff","patch_url":"https://github.com/linkedin/gobblin/pull/812.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/812","number":812,"state":"open","locked":false,"title":"Make generic version, version finder, version selection policy","user":{"login":"ydai1124","id":10764942,"avatar_url":"https://avatars.githubusercontent.com/u/10764942?v=3","gravatar_id":"","url":"https://api.github.com/users/ydai1124","html_url":"https://github.com/ydai1124","followers_url":"https://api.github.com/users/ydai1124/followers","following_url":"https://api.github.com/users/ydai1124/following{/other_user}","gists_url":"https://api.github.com/users/ydai1124/gists{/gist_id}","starred_url":"https://api.github.com/users/ydai1124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydai1124/subscriptions","organizations_url":"https://api.github.com/users/ydai1124/orgs","repos_url":"https://api.github.com/users/ydai1124/repos","events_url":"https://api.github.com/users/ydai1124/events{/privacy}","received_events_url":"https://api.github.com/users/ydai1124/received_events","type":"User","site_admin":false},"body":"@ibuenros  Can you review? Thanks","created_at":"2016-03-08T23:39:53Z","updated_at":"2016-03-09T19:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e03c06df6c60fb20fa3823d80d4c52bf255239d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/812/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/812/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/812/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/525db2772258f7b521fd18464d3bbafa6b32052d","head":{"label":"ydai1124:master","ref":"master","sha":"525db2772258f7b521fd18464d3bbafa6b32052d","user":{"login":"ydai1124","id":10764942,"avatar_url":"https://avatars.githubusercontent.com/u/10764942?v=3","gravatar_id":"","url":"https://api.github.com/users/ydai1124","html_url":"https://github.com/ydai1124","followers_url":"https://api.github.com/users/ydai1124/followers","following_url":"https://api.github.com/users/ydai1124/following{/other_user}","gists_url":"https://api.github.com/users/ydai1124/gists{/gist_id}","starred_url":"https://api.github.com/users/ydai1124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydai1124/subscriptions","organizations_url":"https://api.github.com/users/ydai1124/orgs","repos_url":"https://api.github.com/users/ydai1124/repos","events_url":"https://api.github.com/users/ydai1124/events{/privacy}","received_events_url":"https://api.github.com/users/ydai1124/received_events","type":"User","site_admin":false},"repo":{"id":31681854,"name":"gobblin-1","full_name":"ydai1124/gobblin-1","owner":{"login":"ydai1124","id":10764942,"avatar_url":"https://avatars.githubusercontent.com/u/10764942?v=3","gravatar_id":"","url":"https://api.github.com/users/ydai1124","html_url":"https://github.com/ydai1124","followers_url":"https://api.github.com/users/ydai1124/followers","following_url":"https://api.github.com/users/ydai1124/following{/other_user}","gists_url":"https://api.github.com/users/ydai1124/gists{/gist_id}","starred_url":"https://api.github.com/users/ydai1124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydai1124/subscriptions","organizations_url":"https://api.github.com/users/ydai1124/orgs","repos_url":"https://api.github.com/users/ydai1124/repos","events_url":"https://api.github.com/users/ydai1124/events{/privacy}","received_events_url":"https://api.github.com/users/ydai1124/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ydai1124/gobblin-1","description":"","fork":true,"url":"https://api.github.com/repos/ydai1124/gobblin-1","forks_url":"https://api.github.com/repos/ydai1124/gobblin-1/forks","keys_url":"https://api.github.com/repos/ydai1124/gobblin-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ydai1124/gobblin-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ydai1124/gobblin-1/teams","hooks_url":"https://api.github.com/repos/ydai1124/gobblin-1/hooks","issue_events_url":"https://api.github.com/repos/ydai1124/gobblin-1/issues/events{/number}","events_url":"https://api.github.com/repos/ydai1124/gobblin-1/events","assignees_url":"https://api.github.com/repos/ydai1124/gobblin-1/assignees{/user}","branches_url":"https://api.github.com/repos/ydai1124/gobblin-1/branches{/branch}","tags_url":"https://api.github.com/repos/ydai1124/gobblin-1/tags","blobs_url":"https://api.github.com/repos/ydai1124/gobblin-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ydai1124/gobblin-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ydai1124/gobblin-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ydai1124/gobblin-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ydai1124/gobblin-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ydai1124/gobblin-1/languages","stargazers_url":"https://api.github.com/repos/ydai1124/gobblin-1/stargazers","contributors_url":"https://api.github.com/repos/ydai1124/gobblin-1/contributors","subscribers_url":"https://api.github.com/repos/ydai1124/gobblin-1/subscribers","subscription_url":"https://api.github.com/repos/ydai1124/gobblin-1/subscription","commits_url":"https://api.github.com/repos/ydai1124/gobblin-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ydai1124/gobblin-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ydai1124/gobblin-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ydai1124/gobblin-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ydai1124/gobblin-1/contents/{+path}","compare_url":"https://api.github.com/repos/ydai1124/gobblin-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ydai1124/gobblin-1/merges","archive_url":"https://api.github.com/repos/ydai1124/gobblin-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ydai1124/gobblin-1/downloads","issues_url":"https://api.github.com/repos/ydai1124/gobblin-1/issues{/number}","pulls_url":"https://api.github.com/repos/ydai1124/gobblin-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ydai1124/gobblin-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ydai1124/gobblin-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ydai1124/gobblin-1/labels{/name}","releases_url":"https://api.github.com/repos/ydai1124/gobblin-1/releases{/id}","deployments_url":"https://api.github.com/repos/ydai1124/gobblin-1/deployments","created_at":"2015-03-04T21:53:04Z","updated_at":"2016-01-28T00:09:48Z","pushed_at":"2016-03-09T01:12:19Z","git_url":"git://github.com/ydai1124/gobblin-1.git","ssh_url":"git@github.com:ydai1124/gobblin-1.git","clone_url":"https://github.com/ydai1124/gobblin-1.git","svn_url":"https://github.com/ydai1124/gobblin-1","homepage":null,"size":83408,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"d4e952849f40fdc4fd9e846183ccc35a1cab4c26","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-03-09T14:55:34Z","pushed_at":"2016-03-09T18:21:40Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":164561,"stargazers_count":469,"watchers_count":469,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":179,"mirror_url":null,"open_issues_count":68,"forks":179,"open_issues":68,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/812"},"html":{"href":"https://github.com/linkedin/gobblin/pull/812"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/812"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/812/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/812/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/812/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/525db2772258f7b521fd18464d3bbafa6b32052d"}}}}