{"action":"created","comment":{"url":"https://api.github.com/repos/athanatos/ceph/pulls/comments/70843227","id":70843227,"diff_hunk":"@@ -1944,6 +1944,32 @@ void PG::queue_op(OpRequestRef& op)\n   }\n }\n \n+void PG::queue_op_without_pg_lock(OpRequestRef& op)","path":"src/osd/PG.cc","position":4,"original_position":4,"commit_id":"840239b5a32a802d3588e1757eb5d62312642aa6","original_commit_id":"840239b5a32a802d3588e1757eb5d62312642aa6","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"As I've said, you need *some* lock in order to maintain reply ordering.  Once you identify and name that lock, update these names.","created_at":"2016-07-14T17:03:48Z","updated_at":"2016-07-14T17:03:48Z","html_url":"https://github.com/athanatos/ceph/pull/4#discussion_r70843227","pull_request_url":"https://api.github.com/repos/athanatos/ceph/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/comments/70843227"},"html":{"href":"https://github.com/athanatos/ceph/pull/4#discussion_r70843227"},"pull_request":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/athanatos/ceph/pulls/4","id":77231379,"html_url":"https://github.com/athanatos/ceph/pull/4","diff_url":"https://github.com/athanatos/ceph/pull/4.diff","patch_url":"https://github.com/athanatos/ceph/pull/4.patch","issue_url":"https://api.github.com/repos/athanatos/ceph/issues/4","number":4,"state":"open","locked":false,"title":"OSD: op lock completion patch","user":{"login":"myoungwon","id":6869809,"avatar_url":"https://avatars.githubusercontent.com/u/6869809?v=3","gravatar_id":"","url":"https://api.github.com/users/myoungwon","html_url":"https://github.com/myoungwon","followers_url":"https://api.github.com/users/myoungwon/followers","following_url":"https://api.github.com/users/myoungwon/following{/other_user}","gists_url":"https://api.github.com/users/myoungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/myoungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myoungwon/subscriptions","organizations_url":"https://api.github.com/users/myoungwon/orgs","repos_url":"https://api.github.com/users/myoungwon/repos","events_url":"https://api.github.com/users/myoungwon/events{/privacy}","received_events_url":"https://api.github.com/users/myoungwon/received_events","type":"User","site_admin":false},"body":"op lock completion patch for discussion\r\n\r\nSigned-off-by: Myoungwon Oh <omwmw@sk.com>","created_at":"2016-07-13T05:16:23Z","updated_at":"2016-07-14T17:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a4d7068524807580137099c21e3357949f96ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/athanatos/ceph/pulls/4/commits","review_comments_url":"https://api.github.com/repos/athanatos/ceph/pulls/4/comments","review_comment_url":"https://api.github.com/repos/athanatos/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/athanatos/ceph/issues/4/comments","statuses_url":"https://api.github.com/repos/athanatos/ceph/statuses/840239b5a32a802d3588e1757eb5d62312642aa6","head":{"label":"myoungwon:wip-osd-reply","ref":"wip-osd-reply","sha":"840239b5a32a802d3588e1757eb5d62312642aa6","user":{"login":"myoungwon","id":6869809,"avatar_url":"https://avatars.githubusercontent.com/u/6869809?v=3","gravatar_id":"","url":"https://api.github.com/users/myoungwon","html_url":"https://github.com/myoungwon","followers_url":"https://api.github.com/users/myoungwon/followers","following_url":"https://api.github.com/users/myoungwon/following{/other_user}","gists_url":"https://api.github.com/users/myoungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/myoungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myoungwon/subscriptions","organizations_url":"https://api.github.com/users/myoungwon/orgs","repos_url":"https://api.github.com/users/myoungwon/repos","events_url":"https://api.github.com/users/myoungwon/events{/privacy}","received_events_url":"https://api.github.com/users/myoungwon/received_events","type":"User","site_admin":false},"repo":{"id":59538992,"name":"ceph","full_name":"myoungwon/ceph","owner":{"login":"myoungwon","id":6869809,"avatar_url":"https://avatars.githubusercontent.com/u/6869809?v=3","gravatar_id":"","url":"https://api.github.com/users/myoungwon","html_url":"https://github.com/myoungwon","followers_url":"https://api.github.com/users/myoungwon/followers","following_url":"https://api.github.com/users/myoungwon/following{/other_user}","gists_url":"https://api.github.com/users/myoungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/myoungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myoungwon/subscriptions","organizations_url":"https://api.github.com/users/myoungwon/orgs","repos_url":"https://api.github.com/users/myoungwon/repos","events_url":"https://api.github.com/users/myoungwon/events{/privacy}","received_events_url":"https://api.github.com/users/myoungwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myoungwon/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/myoungwon/ceph","forks_url":"https://api.github.com/repos/myoungwon/ceph/forks","keys_url":"https://api.github.com/repos/myoungwon/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myoungwon/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myoungwon/ceph/teams","hooks_url":"https://api.github.com/repos/myoungwon/ceph/hooks","issue_events_url":"https://api.github.com/repos/myoungwon/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/myoungwon/ceph/events","assignees_url":"https://api.github.com/repos/myoungwon/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/myoungwon/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/myoungwon/ceph/tags","blobs_url":"https://api.github.com/repos/myoungwon/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myoungwon/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myoungwon/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/myoungwon/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myoungwon/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/myoungwon/ceph/languages","stargazers_url":"https://api.github.com/repos/myoungwon/ceph/stargazers","contributors_url":"https://api.github.com/repos/myoungwon/ceph/contributors","subscribers_url":"https://api.github.com/repos/myoungwon/ceph/subscribers","subscription_url":"https://api.github.com/repos/myoungwon/ceph/subscription","commits_url":"https://api.github.com/repos/myoungwon/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/myoungwon/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/myoungwon/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/myoungwon/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/myoungwon/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/myoungwon/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myoungwon/ceph/merges","archive_url":"https://api.github.com/repos/myoungwon/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myoungwon/ceph/downloads","issues_url":"https://api.github.com/repos/myoungwon/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/myoungwon/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/myoungwon/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/myoungwon/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myoungwon/ceph/labels{/name}","releases_url":"https://api.github.com/repos/myoungwon/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/myoungwon/ceph/deployments","created_at":"2016-05-24T03:57:43Z","updated_at":"2016-05-24T03:58:03Z","pushed_at":"2016-07-14T12:25:49Z","git_url":"git://github.com/myoungwon/ceph.git","ssh_url":"git@github.com:myoungwon/ceph.git","clone_url":"https://github.com/myoungwon/ceph.git","svn_url":"https://github.com/myoungwon/ceph","homepage":"http://ceph.com","size":167943,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"athanatos:wip-osd-reply","ref":"wip-osd-reply","sha":"9e06517c96e5072c7a90000f045906794a3c018a","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"repo":{"id":2424229,"name":"ceph","full_name":"athanatos/ceph","owner":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/athanatos/ceph","description":"Ceph distributed file system","fork":true,"url":"https://api.github.com/repos/athanatos/ceph","forks_url":"https://api.github.com/repos/athanatos/ceph/forks","keys_url":"https://api.github.com/repos/athanatos/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/athanatos/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/athanatos/ceph/teams","hooks_url":"https://api.github.com/repos/athanatos/ceph/hooks","issue_events_url":"https://api.github.com/repos/athanatos/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/athanatos/ceph/events","assignees_url":"https://api.github.com/repos/athanatos/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/athanatos/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/athanatos/ceph/tags","blobs_url":"https://api.github.com/repos/athanatos/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/athanatos/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/athanatos/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/athanatos/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/athanatos/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/athanatos/ceph/languages","stargazers_url":"https://api.github.com/repos/athanatos/ceph/stargazers","contributors_url":"https://api.github.com/repos/athanatos/ceph/contributors","subscribers_url":"https://api.github.com/repos/athanatos/ceph/subscribers","subscription_url":"https://api.github.com/repos/athanatos/ceph/subscription","commits_url":"https://api.github.com/repos/athanatos/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/athanatos/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/athanatos/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/athanatos/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/athanatos/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/athanatos/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/athanatos/ceph/merges","archive_url":"https://api.github.com/repos/athanatos/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/athanatos/ceph/downloads","issues_url":"https://api.github.com/repos/athanatos/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/athanatos/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/athanatos/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/athanatos/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/athanatos/ceph/labels{/name}","releases_url":"https://api.github.com/repos/athanatos/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/athanatos/ceph/deployments","created_at":"2011-09-20T17:52:49Z","updated_at":"2015-08-22T02:15:30Z","pushed_at":"2016-07-14T14:49:15Z","git_url":"git://github.com/athanatos/ceph.git","ssh_url":"git@github.com:athanatos/ceph.git","clone_url":"https://github.com/athanatos/ceph.git","svn_url":"https://github.com/athanatos/ceph","homepage":"http://ceph.newdream.net/","size":163227,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/4"},"html":{"href":"https://github.com/athanatos/ceph/pull/4"},"issue":{"href":"https://api.github.com/repos/athanatos/ceph/issues/4"},"comments":{"href":"https://api.github.com/repos/athanatos/ceph/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/athanatos/ceph/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/athanatos/ceph/statuses/840239b5a32a802d3588e1757eb5d62312642aa6"}}}}
{"actor":{"display_login":"athanatos"}}