{"action":"created","issue":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/353","repository_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk","labels_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/353/comments","events_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/353/events","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/353","id":155183826,"number":353,"title":"[Android] Support third part media player on Crosswalk","user":{"login":"fujunwei","id":7856909,"avatar_url":"https://avatars.githubusercontent.com/u/7856909?v=3","gravatar_id":"","url":"https://api.github.com/users/fujunwei","html_url":"https://github.com/fujunwei","followers_url":"https://api.github.com/users/fujunwei/followers","following_url":"https://api.github.com/users/fujunwei/following{/other_user}","gists_url":"https://api.github.com/users/fujunwei/gists{/gist_id}","starred_url":"https://api.github.com/users/fujunwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fujunwei/subscriptions","organizations_url":"https://api.github.com/users/fujunwei/orgs","repos_url":"https://api.github.com/users/fujunwei/repos","events_url":"https://api.github.com/users/fujunwei/events{/privacy}","received_events_url":"https://api.github.com/users/fujunwei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2016-05-17T06:10:06Z","updated_at":"2016-08-25T11:48:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/pulls/353","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/353","diff_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/353.diff","patch_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/353.patch"},"body":"A requirement from an important customer who want to forward web resources with proxy\r\non Crosswalk, but android system MediaPlayer can't set a proxy with a standard API.\r\nThe ExoMediaPlayer is playing videos and music is a popular activity on Android devices,\r\nand it can be configured with proxy.\r\nhttps://developer.android.com/guide/topics/media/exoplayer.html\r\n\r\nBUG=XWALK-6770"},"comment":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/comments/242358719","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/353#issuecomment-242358719","issue_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/353","id":242358719,"user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T11:48:04Z","updated_at":"2016-08-25T11:48:04Z","body":"Not yet, IMO.\r\n\r\n* The questions that must always be asked on every single chromium-crosswalk pull request and which have not been addressed here: have you tried to upstream this in any form? If not, why not? What's the maintenance plan here, are we expected to carry this patch forever?\r\n* \"I want to integrate this patch because my unnamed, important customer wants it\" is not a valid reason to have a patch merged into a public, open-source project. You need to come up with a better explanation of why we want this.\r\n\r\nCode-wise: isn't it possible to add a delegate that returns a subclass of `MediaPlayer` so you don't need to define `ExternalMediaPlayer` at all? Something like making `getLocalPlayer()` return either a new `MediaPlayer` or a subclass if one is registered in Crosswalk. This way the change to chromium-crosswalk is much smaller (and easier to get accepted upstream) and you make `XWalkMediaPlayer` inherit from `MediaPlayer` and let your users change its behavior as they see fit.\r\n"}}
{"actor":{"display_login":"rakuco"}}