{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4723","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4723/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4723/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4723/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4723","id":193887088,"number":4723,"title":"Improve geocoder","user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-06T21:16:23Z","updated_at":"2016-12-13T12:02:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4723","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4723","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4723.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4723.patch"},"body":"Adresses parts of #1262.\r\n\r\n- Support for custom geocoders\r\n- Support for automatic suggestions\r\n\r\nSomething I haven't quite decided on is whether there should be different methods for getting geocoder search suggestions and the actual geocoding. This would be necessary if a certain service has different API endpoints for this, or if they otherwise need to be handled differently. It would probably be better to keep this separate.\r\n\r\nA custom geocoder is expected to look like:\r\n```js\r\n{\r\n    geocode: function(query) {...},\r\n    getSuggestions: function(query) {...} // Currently not used -- should we have this?\r\n}\r\n```\r\n\r\nThe default geocoder in Cesium remains largely unchanged in this PR.\r\n\r\nI've marked the `GeocoderViewModel` properties `key` and `url` for deprecation. I think these don't make sense to expose as public properties since they are implementation details (and may not exist) of the custom geocoder provided."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/266721369","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4723#issuecomment-266721369","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4723","id":266721369,"user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T12:02:22Z","updated_at":"2016-12-13T12:02:22Z","body":"@pjcozzi @hpinkos This is ready.\r\n\r\nI removed the Nominatim geocoder from `Core` and put it into a Sandcastle example. It would be easy to move this to core but it would likely violate the usage policy of Nominatim which is fairly restrictive."}}
{"actor":{"display_login":"erikmaarten"}}