{"action":"created","issue":{"url":"https://api.github.com/repos/brettc/partitionfinder/issues/97","repository_url":"https://api.github.com/repos/brettc/partitionfinder","labels_url":"https://api.github.com/repos/brettc/partitionfinder/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/brettc/partitionfinder/issues/97/comments","events_url":"https://api.github.com/repos/brettc/partitionfinder/issues/97/events","html_url":"https://github.com/brettc/partitionfinder/issues/97","id":154421318,"number":97,"title":"add tests for morphology","user":{"login":"roblanf","id":895251,"avatar_url":"https://avatars.githubusercontent.com/u/895251?v=3","gravatar_id":"","url":"https://api.github.com/users/roblanf","html_url":"https://github.com/roblanf","followers_url":"https://api.github.com/users/roblanf/followers","following_url":"https://api.github.com/users/roblanf/following{/other_user}","gists_url":"https://api.github.com/users/roblanf/gists{/gist_id}","starred_url":"https://api.github.com/users/roblanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblanf/subscriptions","organizations_url":"https://api.github.com/users/roblanf/orgs","repos_url":"https://api.github.com/users/roblanf/repos","events_url":"https://api.github.com/users/roblanf/events{/privacy}","received_events_url":"https://api.github.com/users/roblanf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-12T08:07:11Z","updated_at":"2016-05-13T02:29:33Z","closed_at":null,"body":"@wrightaprilm, can you take a look at what tests we should implement for the morphological stuff? I know you wrote a lot of extra tests, and in general we want all of them. However, the morph stuff in PF2 is a little different from what you had, mostly because we use entropies, and there are some default settings for kmeans that are now different from the ones in your version.\r\n\r\nThe best thing to do is fork the feature/morph2 branch, add the tests you want from your own branch, make sure they all work fine, and then submit a pull request back to feature/morph2. Once we have a good collection of tests, I can go ahead an merge back to master. \r\n\r\nFor ease of merging, please don't change any code just now - there are a few active branches and it would be easy to get conflicts. If you have tests that fail, just leave them failing and put a note here with any clues you have about what the problem might be. I'll work on the code at this end."},"comment":{"url":"https://api.github.com/repos/brettc/partitionfinder/issues/comments/218937473","html_url":"https://github.com/brettc/partitionfinder/issues/97#issuecomment-218937473","issue_url":"https://api.github.com/repos/brettc/partitionfinder/issues/97","id":218937473,"user":{"login":"wrightaprilm","id":1715446,"avatar_url":"https://avatars.githubusercontent.com/u/1715446?v=3","gravatar_id":"","url":"https://api.github.com/users/wrightaprilm","html_url":"https://github.com/wrightaprilm","followers_url":"https://api.github.com/users/wrightaprilm/followers","following_url":"https://api.github.com/users/wrightaprilm/following{/other_user}","gists_url":"https://api.github.com/users/wrightaprilm/gists{/gist_id}","starred_url":"https://api.github.com/users/wrightaprilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrightaprilm/subscriptions","organizations_url":"https://api.github.com/users/wrightaprilm/orgs","repos_url":"https://api.github.com/users/wrightaprilm/repos","events_url":"https://api.github.com/users/wrightaprilm/events{/privacy}","received_events_url":"https://api.github.com/users/wrightaprilm/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T02:29:33Z","updated_at":"2016-05-13T02:29:33Z","body":"OK, so that all seems to be working. will see how it goes!"}}