{"action":"opened","number":399,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-demo/pulls/399","id":92818417,"html_url":"https://github.com/symfony/symfony-demo/pull/399","diff_url":"https://github.com/symfony/symfony-demo/pull/399.diff","patch_url":"https://github.com/symfony/symfony-demo/pull/399.patch","issue_url":"https://api.github.com/repos/symfony/symfony-demo/issues/399","number":399,"state":"open","locked":false,"title":"Use dynamic env params for critical settings and restore Heroku deploys","user":{"login":"dzuelke","id":27900,"avatar_url":"https://avatars.githubusercontent.com/u/27900?v=3","gravatar_id":"","url":"https://api.github.com/users/dzuelke","html_url":"https://github.com/dzuelke","followers_url":"https://api.github.com/users/dzuelke/followers","following_url":"https://api.github.com/users/dzuelke/following{/other_user}","gists_url":"https://api.github.com/users/dzuelke/gists{/gist_id}","starred_url":"https://api.github.com/users/dzuelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzuelke/subscriptions","organizations_url":"https://api.github.com/users/dzuelke/orgs","repos_url":"https://api.github.com/users/dzuelke/repos","events_url":"https://api.github.com/users/dzuelke/events{/privacy}","received_events_url":"https://api.github.com/users/dzuelke/received_events","type":"User","site_admin":false},"body":"Database, log destination, and secrets are now configurable via environment variables (via the quasi standard `DATABASE_URL`, and `SYMFONY_LOG`, and `SYMFONY_SECRET`). All three fall back to defaults from `parameters.yml(.dist)`.\r\n\r\nFor simplicity (one param versus many), a URL is now used again for SQLite, because that works fine since Doctrine DBAL 2.5.5.\r\n\r\nDeploys to Heroku are now fixed again; @bocharsky-bw's PR #377 was not a fix for #371, because SQLite does not scale horizontally :p The original problem was @javiereguiluz's 56cfa66 change to Symfony 3.1, which used individual parameters for config. Again, no longer a problem since DBAL 2.5.5. It also uses `php://stderr` for env `prod` on Heroku only, which @javiereguiluz had also removed in 56cfa665cf1235c436c70afa5fc85c2668c14605 (for the future, I'd encourage separate commits for stuff like this, as it makes it much easier to untangle individual parts and reasons for changes).\r\n\r\nThis demo app ships with sample data in SQLite, but for other databases, the data needs to be seeded, and that can even happen in a prod env. @javiereguiluz' commit e2264b0 removed the fixtures bundle needed for that from the kernel init; it's now back.\r\n\r\nThis app now works just fine with the usual defaults both in `dev` and `prod` envs, but users who want to try running it on Docker or on a PaaS like Heroku can now trivially adjust relevant settings via environment variables.\r\n\r\n/CC @stof @fabpot ","created_at":"2016-11-08T17:03:03Z","updated_at":"2016-11-08T17:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/399/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/399/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/issues/399/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/7f22cc7c5697c270f806f9c8d0664da72cd1147f","head":{"label":"dzuelke:envparams","ref":"envparams","sha":"7f22cc7c5697c270f806f9c8d0664da72cd1147f","user":{"login":"dzuelke","id":27900,"avatar_url":"https://avatars.githubusercontent.com/u/27900?v=3","gravatar_id":"","url":"https://api.github.com/users/dzuelke","html_url":"https://github.com/dzuelke","followers_url":"https://api.github.com/users/dzuelke/followers","following_url":"https://api.github.com/users/dzuelke/following{/other_user}","gists_url":"https://api.github.com/users/dzuelke/gists{/gist_id}","starred_url":"https://api.github.com/users/dzuelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzuelke/subscriptions","organizations_url":"https://api.github.com/users/dzuelke/orgs","repos_url":"https://api.github.com/users/dzuelke/repos","events_url":"https://api.github.com/users/dzuelke/events{/privacy}","received_events_url":"https://api.github.com/users/dzuelke/received_events","type":"User","site_admin":false},"repo":{"id":47336604,"name":"symfony-demo","full_name":"dzuelke/symfony-demo","owner":{"login":"dzuelke","id":27900,"avatar_url":"https://avatars.githubusercontent.com/u/27900?v=3","gravatar_id":"","url":"https://api.github.com/users/dzuelke","html_url":"https://github.com/dzuelke","followers_url":"https://api.github.com/users/dzuelke/followers","following_url":"https://api.github.com/users/dzuelke/following{/other_user}","gists_url":"https://api.github.com/users/dzuelke/gists{/gist_id}","starred_url":"https://api.github.com/users/dzuelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzuelke/subscriptions","organizations_url":"https://api.github.com/users/dzuelke/orgs","repos_url":"https://api.github.com/users/dzuelke/repos","events_url":"https://api.github.com/users/dzuelke/events{/privacy}","received_events_url":"https://api.github.com/users/dzuelke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzuelke/symfony-demo","description":null,"fork":true,"url":"https://api.github.com/repos/dzuelke/symfony-demo","forks_url":"https://api.github.com/repos/dzuelke/symfony-demo/forks","keys_url":"https://api.github.com/repos/dzuelke/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzuelke/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzuelke/symfony-demo/teams","hooks_url":"https://api.github.com/repos/dzuelke/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/dzuelke/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/dzuelke/symfony-demo/events","assignees_url":"https://api.github.com/repos/dzuelke/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/dzuelke/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/dzuelke/symfony-demo/tags","blobs_url":"https://api.github.com/repos/dzuelke/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzuelke/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzuelke/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzuelke/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzuelke/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/dzuelke/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/dzuelke/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/dzuelke/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/dzuelke/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/dzuelke/symfony-demo/subscription","commits_url":"https://api.github.com/repos/dzuelke/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzuelke/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzuelke/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzuelke/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzuelke/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/dzuelke/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzuelke/symfony-demo/merges","archive_url":"https://api.github.com/repos/dzuelke/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzuelke/symfony-demo/downloads","issues_url":"https://api.github.com/repos/dzuelke/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/dzuelke/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/dzuelke/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/dzuelke/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzuelke/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/dzuelke/symfony-demo/releases{/id}","deployments_url":"https://api.github.com/repos/dzuelke/symfony-demo/deployments","created_at":"2015-12-03T14:18:51Z","updated_at":"2016-11-08T15:34:39Z","pushed_at":"2016-11-08T16:48:46Z","git_url":"git://github.com/dzuelke/symfony-demo.git","ssh_url":"git@github.com:dzuelke/symfony-demo.git","clone_url":"https://github.com/dzuelke/symfony-demo.git","svn_url":"https://github.com/dzuelke/symfony-demo","homepage":null,"size":2471,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"0313e7a521a607e119b0b22715b34b7bf9f286ac","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":32792088,"name":"symfony-demo","full_name":"symfony/symfony-demo","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-demo","description":"Symfony Demo Application","fork":false,"url":"https://api.github.com/repos/symfony/symfony-demo","forks_url":"https://api.github.com/repos/symfony/symfony-demo/forks","keys_url":"https://api.github.com/repos/symfony/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-demo/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-demo/events","assignees_url":"https://api.github.com/repos/symfony/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-demo/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-demo/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-demo/merges","archive_url":"https://api.github.com/repos/symfony/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-demo/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-demo/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony-demo/deployments","created_at":"2015-03-24T10:37:08Z","updated_at":"2016-11-07T12:41:45Z","pushed_at":"2016-11-08T17:03:03Z","git_url":"git://github.com/symfony/symfony-demo.git","ssh_url":"git@github.com:symfony/symfony-demo.git","clone_url":"https://github.com/symfony/symfony-demo.git","svn_url":"https://github.com/symfony/symfony-demo","homepage":"https://symfony.com/","size":3713,"stargazers_count":417,"watchers_count":417,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":13,"forks":324,"open_issues":13,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/399"},"html":{"href":"https://github.com/symfony/symfony-demo/pull/399"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/399"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-demo/statuses/7f22cc7c5697c270f806f9c8d0664da72cd1147f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":24,"deletions":18,"changed_files":8}}
{"actor":{"display_login":"dzuelke"}}