{"action":"created","issue":{"url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/95","repository_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped","labels_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/95/comments","events_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/95/events","html_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/pull/95","id":171560920,"number":95,"title":"d3-geo Suggestions","user":{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/labels/d3-geo","name":"d3-geo","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false},"assignees":[{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/milestones/1","html_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/milestones/Standard%20Bundle%20Modules%20(TypeScript%202)","labels_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/milestones/1/labels","id":1847956,"number":1,"title":"Standard Bundle Modules (TypeScript 2)","description":"A complete set of definitions for the d3 modules contained in the **standard bundle of D3** as defined by Mike Bostock. Initial shape tests for internal consistency of the definitions.\r\n\r\nCovered is also a definitions file for the standard d3 bundle itself (re-export from included D3 modules).\r\n\r\nThis milestone has a primary focus on testing out UMD-style definitions and the ability to type the 'this' context of key callback functions, i.p. related to selections/transitions and the D3 approach to passing in DOM element references.","creator":{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":58,"state":"open","created_at":"2016-06-25T00:56:49Z","updated_at":"2016-08-18T02:40:07Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-08-17T02:32:33Z","updated_at":"2016-08-18T17:03:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/pulls/95","html_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/pull/95","diff_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/pull/95.diff","patch_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/pull/95.patch"},"body":"@Ledragon I took a longer look at d3-geo (including the source code, some of the old 3.x API documentation, and played around with d3-geo in the browser console a bit.)\r\n\r\nBased on that I put together this PR for your review. Let me know what you think. As I said before, this one really was not as easy as some of the others purely off the API doc. I tried to comment out all my change suggestions in the individual commit messages."},"comment":{"url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/comments/240788908","html_url":"https://github.com/tomwanzek/d3-v4-definitelytyped/pull/95#issuecomment-240788908","issue_url":"https://api.github.com/repos/tomwanzek/d3-v4-definitelytyped/issues/95","id":240788908,"user":{"login":"Ledragon","id":9558809,"avatar_url":"https://avatars.githubusercontent.com/u/9558809?v=3","gravatar_id":"","url":"https://api.github.com/users/Ledragon","html_url":"https://github.com/Ledragon","followers_url":"https://api.github.com/users/Ledragon/followers","following_url":"https://api.github.com/users/Ledragon/following{/other_user}","gists_url":"https://api.github.com/users/Ledragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Ledragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ledragon/subscriptions","organizations_url":"https://api.github.com/users/Ledragon/orgs","repos_url":"https://api.github.com/users/Ledragon/repos","events_url":"https://api.github.com/users/Ledragon/events{/privacy}","received_events_url":"https://api.github.com/users/Ledragon/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T17:03:05Z","updated_at":"2016-08-18T17:03:05Z","body":"I don't even know what to say *_*\r\nThis is brilliant work, it is so complete. So green lights to merge the PR of course.\r\n\r\nFor what I see, maybe some contributing rules could be added, such as creating one line per method overload rather than optional/multiple types in a single method.\r\n\r\nAlso, based on what you found and completed, might it be worth augmenting the actual d3-geo documentation?"}}
{"actor":{"display_login":"Ledragon"}}