{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/56784131","id":56784131,"diff_hunk":"@@ -83,8 +83,18 @@\n     <build>\n         <resources>\n             <resource>\n-                <directory>${project.basedir}/src/main/resources</directory>\n+                <directory>src/main/resources</directory>","path":"presto-product-tests/pom.xml","position":5,"original_position":5,"commit_id":"d0d19406d4486523d7872aa88e64eab6c7a4f128","original_commit_id":"d0d19406d4486523d7872aa88e64eab6c7a4f128","user":{"login":"kokosing","id":7569403,"avatar_url":"https://avatars.githubusercontent.com/u/7569403?v=3","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"body":"why did you remove `${project.basedir}`?","created_at":"2016-03-21T05:46:13Z","updated_at":"2016-03-21T05:46:13Z","html_url":"https://github.com/prestodb/presto/pull/4824#discussion_r56784131","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/4824","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/56784131"},"html":{"href":"https://github.com/prestodb/presto/pull/4824#discussion_r56784131"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4824"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/4824","id":63410413,"html_url":"https://github.com/prestodb/presto/pull/4824","diff_url":"https://github.com/prestodb/presto/pull/4824.diff","patch_url":"https://github.com/prestodb/presto/pull/4824.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/4824","number":4824,"state":"open","locked":false,"title":"Fix product tests resource processing","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"Apply maven resource pluging filtering only to `presto.env` file\r\ninstead of to all the presto-product-tests resources.\r\n\r\nMaven resource filtering is used to replace properties\r\nplaceholders e.g. `${project.version}` in the module resource files.\r\nIn our case we use this feature to substitute the actual presto version\r\nin `presto.env` file which is used for running product tests on travis.\r\nThe problem is that the `presto-product-tests` module contains\r\nmany binary files with the test tables data. Resource plugin with filtering\r\nenabled always tries to parse resources as text files and writes\r\nthe parsed result to the target even if no placeholders has been replaced.\r\nThis operation breaks the binary files.","created_at":"2016-03-18T17:37:01Z","updated_at":"2016-03-21T05:46:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29cf040e93f124c2fc516d60f6e259e1c10707e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/4824/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/4824/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/4824/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/d0d19406d4486523d7872aa88e64eab6c7a4f128","head":{"label":"arhimondr:fix-product-tests-resource-processing","ref":"fix-product-tests-resource-processing","sha":"d0d19406d4486523d7872aa88e64eab6c7a4f128","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"repo":{"id":37681604,"name":"presto","full_name":"arhimondr/presto","owner":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arhimondr/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/arhimondr/presto","forks_url":"https://api.github.com/repos/arhimondr/presto/forks","keys_url":"https://api.github.com/repos/arhimondr/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhimondr/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhimondr/presto/teams","hooks_url":"https://api.github.com/repos/arhimondr/presto/hooks","issue_events_url":"https://api.github.com/repos/arhimondr/presto/issues/events{/number}","events_url":"https://api.github.com/repos/arhimondr/presto/events","assignees_url":"https://api.github.com/repos/arhimondr/presto/assignees{/user}","branches_url":"https://api.github.com/repos/arhimondr/presto/branches{/branch}","tags_url":"https://api.github.com/repos/arhimondr/presto/tags","blobs_url":"https://api.github.com/repos/arhimondr/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhimondr/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhimondr/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhimondr/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhimondr/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/arhimondr/presto/languages","stargazers_url":"https://api.github.com/repos/arhimondr/presto/stargazers","contributors_url":"https://api.github.com/repos/arhimondr/presto/contributors","subscribers_url":"https://api.github.com/repos/arhimondr/presto/subscribers","subscription_url":"https://api.github.com/repos/arhimondr/presto/subscription","commits_url":"https://api.github.com/repos/arhimondr/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhimondr/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhimondr/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhimondr/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhimondr/presto/contents/{+path}","compare_url":"https://api.github.com/repos/arhimondr/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhimondr/presto/merges","archive_url":"https://api.github.com/repos/arhimondr/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhimondr/presto/downloads","issues_url":"https://api.github.com/repos/arhimondr/presto/issues{/number}","pulls_url":"https://api.github.com/repos/arhimondr/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/arhimondr/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/arhimondr/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhimondr/presto/labels{/name}","releases_url":"https://api.github.com/repos/arhimondr/presto/releases{/id}","deployments_url":"https://api.github.com/repos/arhimondr/presto/deployments","created_at":"2015-06-18T19:57:44Z","updated_at":"2016-03-18T00:24:50Z","pushed_at":"2016-03-18T17:35:29Z","git_url":"git://github.com/arhimondr/presto.git","ssh_url":"git@github.com:arhimondr/presto.git","clone_url":"https://github.com/arhimondr/presto.git","svn_url":"https://github.com/arhimondr/presto","homepage":"https://prestodb.io","size":52561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"0499ee304d3f61a622ede9829d08e9f07a3d75e2","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-03-20T02:34:50Z","pushed_at":"2016-03-20T10:49:21Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":112348,"stargazers_count":4576,"watchers_count":4576,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1309,"mirror_url":null,"open_issues_count":548,"forks":1309,"open_issues":548,"watchers":4576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4824"},"html":{"href":"https://github.com/prestodb/presto/pull/4824"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/4824"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/4824/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4824/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4824/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/d0d19406d4486523d7872aa88e64eab6c7a4f128"}}}}