{"action":"closed","number":4164,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/4164","id":65738023,"html_url":"https://github.com/dotnet/coreclr/pull/4164","diff_url":"https://github.com/dotnet/coreclr/pull/4164.diff","patch_url":"https://github.com/dotnet/coreclr/pull/4164.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/4164","number":4164,"state":"closed","locked":false,"title":"Fix LPSTR test failure due to incorrect implementation of strncpy_s.","user":{"login":"yizhang82","id":6903744,"avatar_url":"https://avatars.githubusercontent.com/u/6903744?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhang82","html_url":"https://github.com/yizhang82","followers_url":"https://api.github.com/users/yizhang82/followers","following_url":"https://api.github.com/users/yizhang82/following{/other_user}","gists_url":"https://api.github.com/users/yizhang82/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhang82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhang82/subscriptions","organizations_url":"https://api.github.com/users/yizhang82/orgs","repos_url":"https://api.github.com/users/yizhang82/repos","events_url":"https://api.github.com/users/yizhang82/events{/privacy}","received_events_url":"https://api.github.com/users/yizhang82/received_events","type":"User","site_admin":false},"body":"It was implemented using snprintf and didn't account for the null terminator behavioral difference. Test is now passing after the fix. We should see if we can always use xplat helpers in all platforms for easier debugging.\r\n\r\nFix #3572","created_at":"2016-04-08T05:19:39Z","updated_at":"2016-04-08T17:43:56Z","closed_at":"2016-04-08T17:43:56Z","merged_at":"2016-04-08T17:43:56Z","merge_commit_sha":"7770c88ff4f672071d6365498a8c942d0417253c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4164/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4164/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/4164/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/78595418e12b1059e94b3b5d031da007b1be6794","head":{"label":"yizhang82:lpstr_test_fix","ref":"lpstr_test_fix","sha":"78595418e12b1059e94b3b5d031da007b1be6794","user":{"login":"yizhang82","id":6903744,"avatar_url":"https://avatars.githubusercontent.com/u/6903744?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhang82","html_url":"https://github.com/yizhang82","followers_url":"https://api.github.com/users/yizhang82/followers","following_url":"https://api.github.com/users/yizhang82/following{/other_user}","gists_url":"https://api.github.com/users/yizhang82/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhang82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhang82/subscriptions","organizations_url":"https://api.github.com/users/yizhang82/orgs","repos_url":"https://api.github.com/users/yizhang82/repos","events_url":"https://api.github.com/users/yizhang82/events{/privacy}","received_events_url":"https://api.github.com/users/yizhang82/received_events","type":"User","site_admin":false},"repo":{"id":55650021,"name":"coreclr","full_name":"yizhang82/coreclr","owner":{"login":"yizhang82","id":6903744,"avatar_url":"https://avatars.githubusercontent.com/u/6903744?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhang82","html_url":"https://github.com/yizhang82","followers_url":"https://api.github.com/users/yizhang82/followers","following_url":"https://api.github.com/users/yizhang82/following{/other_user}","gists_url":"https://api.github.com/users/yizhang82/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhang82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhang82/subscriptions","organizations_url":"https://api.github.com/users/yizhang82/orgs","repos_url":"https://api.github.com/users/yizhang82/repos","events_url":"https://api.github.com/users/yizhang82/events{/privacy}","received_events_url":"https://api.github.com/users/yizhang82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yizhang82/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/yizhang82/coreclr","forks_url":"https://api.github.com/repos/yizhang82/coreclr/forks","keys_url":"https://api.github.com/repos/yizhang82/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yizhang82/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yizhang82/coreclr/teams","hooks_url":"https://api.github.com/repos/yizhang82/coreclr/hooks","issue_events_url":"https://api.github.com/repos/yizhang82/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/yizhang82/coreclr/events","assignees_url":"https://api.github.com/repos/yizhang82/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/yizhang82/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/yizhang82/coreclr/tags","blobs_url":"https://api.github.com/repos/yizhang82/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yizhang82/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yizhang82/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/yizhang82/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yizhang82/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/yizhang82/coreclr/languages","stargazers_url":"https://api.github.com/repos/yizhang82/coreclr/stargazers","contributors_url":"https://api.github.com/repos/yizhang82/coreclr/contributors","subscribers_url":"https://api.github.com/repos/yizhang82/coreclr/subscribers","subscription_url":"https://api.github.com/repos/yizhang82/coreclr/subscription","commits_url":"https://api.github.com/repos/yizhang82/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/yizhang82/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/yizhang82/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/yizhang82/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/yizhang82/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/yizhang82/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yizhang82/coreclr/merges","archive_url":"https://api.github.com/repos/yizhang82/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yizhang82/coreclr/downloads","issues_url":"https://api.github.com/repos/yizhang82/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/yizhang82/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/yizhang82/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/yizhang82/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yizhang82/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/yizhang82/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/yizhang82/coreclr/deployments","created_at":"2016-04-07T00:09:10Z","updated_at":"2016-04-07T00:10:31Z","pushed_at":"2016-04-08T05:14:42Z","git_url":"git://github.com/yizhang82/coreclr.git","ssh_url":"git@github.com:yizhang82/coreclr.git","clone_url":"https://github.com/yizhang82/coreclr.git","svn_url":"https://github.com/yizhang82/coreclr","homepage":"http://dotnet.github.io/","size":72013,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"775933742b8cb9bd6f576c244a7b44f788e462e8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-04-08T16:48:18Z","pushed_at":"2016-04-08T17:43:56Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":77772,"stargazers_count":6123,"watchers_count":6123,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1381,"mirror_url":null,"open_issues_count":719,"forks":1381,"open_issues":719,"watchers":6123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4164"},"html":{"href":"https://github.com/dotnet/coreclr/pull/4164"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4164"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4164/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4164/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4164/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/78595418e12b1059e94b3b5d031da007b1be6794"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tijoytom","id":937748,"avatar_url":"https://avatars.githubusercontent.com/u/937748?v=3","gravatar_id":"","url":"https://api.github.com/users/tijoytom","html_url":"https://github.com/tijoytom","followers_url":"https://api.github.com/users/tijoytom/followers","following_url":"https://api.github.com/users/tijoytom/following{/other_user}","gists_url":"https://api.github.com/users/tijoytom/gists{/gist_id}","starred_url":"https://api.github.com/users/tijoytom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijoytom/subscriptions","organizations_url":"https://api.github.com/users/tijoytom/orgs","repos_url":"https://api.github.com/users/tijoytom/repos","events_url":"https://api.github.com/users/tijoytom/events{/privacy}","received_events_url":"https://api.github.com/users/tijoytom/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":2}}