{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37065","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37065/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37065/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37065/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37065","id":190257043,"number":37065,"title":"K8s branch add advanced help flag to kubeadm init","user":{"login":"bruceauyeung","id":1210201,"avatar_url":"https://avatars.githubusercontent.com/u/1210201?v=3","gravatar_id":"","url":"https://api.github.com/users/bruceauyeung","html_url":"https://github.com/bruceauyeung","followers_url":"https://api.github.com/users/bruceauyeung/followers","following_url":"https://api.github.com/users/bruceauyeung/following{/other_user}","gists_url":"https://api.github.com/users/bruceauyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/bruceauyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruceauyeung/subscriptions","organizations_url":"https://api.github.com/users/bruceauyeung/orgs","repos_url":"https://api.github.com/users/bruceauyeung/repos","events_url":"https://api.github.com/users/bruceauyeung/events{/privacy}","received_events_url":"https://api.github.com/users/bruceauyeung/received_events","type":"User","site_admin":false},"labels":[{"id":176978828,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-18T07:53:52Z","updated_at":"2016-11-18T07:53:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37065","html_url":"https://github.com/kubernetes/kubernetes/pull/37065","diff_url":"https://github.com/kubernetes/kubernetes/pull/37065.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37065.patch"},"body":"\r\n**What this PR does / why we need it**:\r\n\r\n1. add `--advanced-help` flag to `kubeadm init`.\r\n2. there are extra 4 flags (`external-etcd-endpoints`, `external-etcd-cafile`, `external-etcd-certfile`, `external-etcd-keyfile`) will be displayed in `kubeadm init --advanced-help`, but they will NOT be displayed in `kubeadm init --help`\r\n3. these 4 flags' original deprecated messages will be appended to normal usage message.\r\n\r\n\r\n**Special notes for your reviewer**:\r\n1. the original deprecated message says that those 4 flags will be removed when componentconfig exists. i think normal users may not know what componentconfig is, so these messages maybe a little confusing. should i just adjust these deprecated messages a little ?\r\nfor example :\r\n> --external-etcd-cafile string           etcd certificate authority certificate file. Note: The path must be in /etc/ssl/certs, deprecated and will be removed in the future.\r\n2. currently pflag recognize those flags that have nonempty Deprecated message as deprecated flags. deprecated flags will not be displayed. so there is no chance to display deprecated flags without setting their deprecated messages empty. that's why i mark those flags hidden instead of deprecated.\r\n\r\nSigned-off-by: bruceauyeung <ouyang.qinhua@zte.com.cn>"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/261470025","html_url":"https://github.com/kubernetes/kubernetes/pull/37065#issuecomment-261470025","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37065","id":261470025,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T07:53:53Z","updated_at":"2016-11-18T07:53:53Z","body":"\nCan a [kubernetes](https://github.com/orgs/kubernetes/people) member verify that this patch is reasonable to test? If so, please reply with \"@k8s-bot ok to test\" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.\n\n<details>\nIf you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}