{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/8422","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/8422/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/8422/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/8422/events","html_url":"https://github.com/hashicorp/terraform/pull/8422","id":172775696,"number":8422,"title":"provider/aws: Support Tags for `aws_alb` and `aws_alb_target_group` resources","user":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/provider/aws","name":"provider/aws","color":"bfdadc"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-23T18:43:53Z","updated_at":"2016-09-20T16:33:43Z","closed_at":"2016-08-24T09:54:43Z","pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/8422","html_url":"https://github.com/hashicorp/terraform/pull/8422","diff_url":"https://github.com/hashicorp/terraform/pull/8422.diff","patch_url":"https://github.com/hashicorp/terraform/pull/8422.patch"},"body":"Fixes #8420\n\nAdds the ability to update tags on the ALB resource as well as\nsupporting tags on `aws_alb_target_group`\n\n```\nALB Tests:\n\n% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALB_'                                                                                                                         2 ↵ ✹\n==> Checking that code complies with gofmt requirements...\n/Users/stacko/Code/go/bin/stringer\ngo generate $(go list ./... | grep -v /terraform/vendor/)\n2016/08/23 19:30:16 Generated command/internal_plugin_list.go\nTF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALB_ -timeout 120m\n=== RUN   TestAccAWSALB_basic\n--- PASS: TestAccAWSALB_basic (67.18s)\n=== RUN   TestAccAWSALB_tags\n--- PASS: TestAccAWSALB_tags (99.88s)\n=== RUN   TestAccAWSALB_noSecurityGroup\n--- PASS: TestAccAWSALB_noSecurityGroup (62.49s)\n=== RUN   TestAccAWSALB_accesslogs\n--- PASS: TestAccAWSALB_accesslogs (126.25s)\nPASS\nok  \tgithub.com/hashicorp/terraform/builtin/providers/aws\t355.835s\n```\n\n```\nALB Target Group Tests:\n\n% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALBTargetGroup_'\n==> Checking that code complies with gofmt requirements...\n/Users/stacko/Code/go/bin/stringer\ngo generate $(go list ./... | grep -v /terraform/vendor/)\n2016/08/23 19:37:37 Generated command/internal_plugin_list.go\nTF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALBTargetGroup_ -timeout 120m\n=== RUN   TestAccAWSALBTargetGroup_basic\n--- PASS: TestAccAWSALBTargetGroup_basic (47.26s)\n=== RUN   TestAccAWSALBTargetGroup_tags\n--- PASS: TestAccAWSALBTargetGroup_tags (81.01s)\n=== RUN   TestAccAWSALBTargetGroup_updateHealthCheck\n--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (78.74s)\nPASS\nok  \tgithub.com/hashicorp/terraform/builtin/providers/aws\t207.025s\n```"},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/248356936","html_url":"https://github.com/hashicorp/terraform/pull/8422#issuecomment-248356936","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/8422","id":248356936,"user":{"login":"tomgoren","id":806975,"avatar_url":"https://avatars.githubusercontent.com/u/806975?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgoren","html_url":"https://github.com/tomgoren","followers_url":"https://api.github.com/users/tomgoren/followers","following_url":"https://api.github.com/users/tomgoren/following{/other_user}","gists_url":"https://api.github.com/users/tomgoren/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgoren/subscriptions","organizations_url":"https://api.github.com/users/tomgoren/orgs","repos_url":"https://api.github.com/users/tomgoren/repos","events_url":"https://api.github.com/users/tomgoren/events{/privacy}","received_events_url":"https://api.github.com/users/tomgoren/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T16:33:43Z","updated_at":"2016-09-20T16:33:43Z","body":"This works for `aws_alb` but doesn't apply correctly for whatever reason for `aws_alb_target_group` (at least for me: https://github.com/hashicorp/terraform/issues/8847)..."}}
{"actor":{"display_login":"tomgoren"}}