{"action":"created","issue":{"url":"https://api.github.com/repos/osresearch/heads/issues/60","repository_url":"https://api.github.com/repos/osresearch/heads","labels_url":"https://api.github.com/repos/osresearch/heads/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/osresearch/heads/issues/60/comments","events_url":"https://api.github.com/repos/osresearch/heads/issues/60/events","html_url":"https://github.com/osresearch/heads/issues/60","id":194746747,"number":60,"title":"Xen kernel not automatically built?","user":{"login":"tlaurion","id":827570,"avatar_url":"https://avatars.githubusercontent.com/u/827570?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaurion","html_url":"https://github.com/tlaurion","followers_url":"https://api.github.com/users/tlaurion/followers","following_url":"https://api.github.com/users/tlaurion/following{/other_user}","gists_url":"https://api.github.com/users/tlaurion/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaurion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaurion/subscriptions","organizations_url":"https://api.github.com/users/tlaurion/orgs","repos_url":"https://api.github.com/users/tlaurion/repos","events_url":"https://api.github.com/users/tlaurion/events{/privacy}","received_events_url":"https://api.github.com/users/tlaurion/received_events","type":"User","site_admin":false},"labels":[{"id":490665135,"url":"https://api.github.com/repos/osresearch/heads/labels/buildsystem","name":"buildsystem","color":"bfd4f2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-10T05:45:20Z","updated_at":"2016-12-16T21:38:46Z","closed_at":"2016-12-16T21:38:46Z","body":"Even though the xen references in Makefile are uncommented, the module is not compiled, patched and packaged.\r\n\r\ngit diff Makefile:\r\n```diff --git a/Makefile b/Makefile\r\nindex ea0007c..4234165 100644\r\n--- a/Makefile\r\n+++ b/Makefile\r\n@@ -148,7 +148,7 @@ $(foreach _, $(call libs,tpmtotp), $(eval $(call initrd_lib_add,$_)))\r\n $(foreach _, $(call libs,mbedtls), $(eval $(call initrd_lib_add,$_)))\r\n $(foreach _, $(call libs,qrencode), $(eval $(call initrd_lib_add,$_)))\r\n \r\n-#$(foreach _, $(call outputs,xen), $(eval $(call initrd_bin,$_)))\r\n+$(foreach _, $(call outputs,xen), $(eval $(call initrd_bin,$_)))\r\n \r\n # hack to install busybox into the initrd\r\n initrd_bins += initrd/bin/busybox\r\n@@ -174,7 +174,7 @@ $(build)/$(coreboot_dir)/util/cbmem/cbmem: $(build)/$(coreboot_dir)/.canary\r\n #initrd_bins += initrd/bin/cryptsetup\r\n initrd/bin/cryptsetup: /sbin/cryptsetup\r\n        cp \"$<\" \"$@\"\r\n-initrd_bins += initrd/bin/dmsetup\r\n+#initrd_bins += initrd/bin/dmsetup\r\n initrd/bin/dmsetup: /sbin/dmsetup\r\n        cp \"$<\" \"$@\"\r\n initrd_bins += initrd/bin/gpgv\r\n@@ -191,8 +191,6 @@ initrd_lib_install: $(initrd_bins) $(initrd_libs)\r\n                initrd/bin/* \\\r\n                initrd/sbin/* \\\r\n \r\n-\r\n-\r\n #\r\n # initrd image creation\r\n #\r\n```"},"comment":{"url":"https://api.github.com/repos/osresearch/heads/issues/comments/267702133","html_url":"https://github.com/osresearch/heads/issues/60#issuecomment-267702133","issue_url":"https://api.github.com/repos/osresearch/heads/issues/60","id":267702133,"user":{"login":"tlaurion","id":827570,"avatar_url":"https://avatars.githubusercontent.com/u/827570?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaurion","html_url":"https://github.com/tlaurion","followers_url":"https://api.github.com/users/tlaurion/followers","following_url":"https://api.github.com/users/tlaurion/following{/other_user}","gists_url":"https://api.github.com/users/tlaurion/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaurion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaurion/subscriptions","organizations_url":"https://api.github.com/users/tlaurion/orgs","repos_url":"https://api.github.com/users/tlaurion/repos","events_url":"https://api.github.com/users/tlaurion/events{/privacy}","received_events_url":"https://api.github.com/users/tlaurion/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T21:38:46Z","updated_at":"2016-12-16T21:38:46Z","body":"Simple enough:\r\n```\r\ndiff --git a/Makefile b/Makefile\r\nindex ba51138..2fb3982 100644\r\n--- a/Makefile\r\n+++ b/Makefile\r\n@@ -20,7 +20,7 @@ include modules/*\r\n \r\n # These will be built via their intermediate targets\r\n # This increases the build time, so it is commented out for now\r\n-#all: $(foreach m,$(modules),$m.intermediate)\r\n+all: $(foreach m,$(modules),$m.intermediate)\r\n \r\n define prefix =\r\n $(foreach _, $2, $1$_)\r\n\r\n```"}}
{"actor":{"display_login":"tlaurion"}}