{"push_id":1106381830,"size":20,"distinct_size":1,"ref":"refs/heads/prod-puma-config","head":"bbb91b9158cfb560c539cbcad00b55a86d2c29d7","before":"30d2c73b32be48b4650ac2f6135ceffd6659ba88","commits":[{"sha":"9894ef3e5c7f68093d96eb72d57bbd001dc3fae1","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Remove .json postfix from API routes\n\nIt’s unnecessary & Accept header is preferable.\n\nMoreover the constraint does not appear to be correctly enforced by Rails anyway.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/9894ef3e5c7f68093d96eb72d57bbd001dc3fae1"},{"sha":"aa8855fc019644a97f5165e3c57afa372a9ea4d7","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Reject non-JSON API calls (rather than failing)","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/aa8855fc019644a97f5165e3c57afa372a9ea4d7"},{"sha":"de46e0db25a1cef983611cde03ab71c1c2331ecc","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Remove unused and incomplete API index","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/de46e0db25a1cef983611cde03ab71c1c2331ecc"},{"sha":"ceeb8608bc55e68215e7080181108d4173640e1b","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Remove / simplify unused & untested API linking","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/ceeb8608bc55e68215e7080181108d4173640e1b"},{"sha":"798ab54f577cfad2906b8c2e31b853b027fe2052","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Merge pull request #312 from ministryofjustice/tweak_api_format_before_launch\n\nTweak api before launch","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/798ab54f577cfad2906b8c2e31b853b027fe2052"},{"sha":"0909b7cbda54244de4f382e1eca321d808f798a7","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Link to prison-visits-public from README","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/0909b7cbda54244de4f382e1eca321d808f798a7"},{"sha":"72890961f1945006ff3dfc014023cc7777fe64af","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Set NOMIS API timeouts to 1s\n\nThis will need tweaking when we get real data on the expected latency of the production system.\n\nThis allows us to leave the development NOMIS connection configured when developing locally even when not on the internal network, and to exercise the failure path.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/72890961f1945006ff3dfc014023cc7777fe64af"},{"sha":"487fd55b48565e43a9b81aa49cbc744660c181aa","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Add more rescueable errors as per Rails 5","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/487fd55b48565e43a9b81aa49cbc744660c181aa"},{"sha":"0c5b4f666b345d8c4dfeeb4f220e4d09d44a1cda","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Handle invalid query strings while error handling\n\nOur exception app is an ActionController action (they are Rack apps), the\nproblem is that if an error happens inside that application it will be bubble\nout of the error app resulting in a non-styled error page showed to the user and\nthe error not being reported to Sentry.\n\nWe've seen this happen with invaid query strings that involve invalid nested\nattributes. To fix this we need to detect if the query string is invalid before\nis processed by the exception app, otherwise the controller will try to parse\nthe query string before processing the main body of the action and raise an\nerror.\n\nAn alternative of doing this would be of decoupling our error pages from Rails\ncontrollers / views, and have a Rack app that has the same behaviour while not\nhaving to use the query string.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/0c5b4f666b345d8c4dfeeb4f220e4d09d44a1cda"},{"sha":"8d59fb5bf61cb208bfee0e440c103bdf66a58cf9","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Merge pull request #314 from ministryofjustice/updated-readme\n\nLink to prison-visits-public from README","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/8d59fb5bf61cb208bfee0e440c103bdf66a58cf9"},{"sha":"b13b53e1b3799dd672ce07005bdff7a0af577c0d","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@mloughran.com","name":"Martyn Loughran"},"message":"Merge pull request #316 from ministryofjustice/rails-errors\n\nImprove Rails error handling","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/b13b53e1b3799dd672ce07005bdff7a0af577c0d"},{"sha":"32abe30d7f3a823db79d80fe6bc06863f36982e2","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Merge pull request #315 from ministryofjustice/set-nomis-api-timeouts\n\nSet NOMIS API timeouts to 1s","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/32abe30d7f3a823db79d80fe6bc06863f36982e2"},{"sha":"8f744078b6ea55846ee3400f4fc63261abeb39e1","author":{"email":"a126122568d3d80af83a781d1857008dd123e4b7@digital.justice.gov.uk","name":"Kylie Mulholland"},"message":"Grendon update Weds slot","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/8f744078b6ea55846ee3400f4fc63261abeb39e1"},{"sha":"b5071aad7a57b3efc74f0ad9595258e515a031fb","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Merge pull request #317 from ministryofjustice/Grendon-update-Weds-slot\n\nGrendon update Weds slot","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/b5071aad7a57b3efc74f0ad9595258e515a031fb"},{"sha":"0fd3817c24d8669ab0177776b336714ac3132836","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Show an error page for authenticity errors\n\nRails treats authenticity errors as a 422, we have no template for a 422, if\nthis happen it most likely mean an error on this side, so I've chosen to render\na 503 page.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/0fd3817c24d8669ab0177776b336714ac3132836"},{"sha":"c46866085e9ed66dd3e3eb7e18969fe53bc02cd7","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@mloughran.com","name":"Martyn Loughran"},"message":"Merge pull request #318 from ministryofjustice/render-422\n\nShow an error page for authenticity errors","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/c46866085e9ed66dd3e3eb7e18969fe53bc02cd7"},{"sha":"05e05d5d108f13595bdee9a8672957c98e9fe1d4","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Remove special email check (used for smoke tests)","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/05e05d5d108f13595bdee9a8672957c98e9fe1d4"},{"sha":"a041f455bb4d8ffa4bace360c50d7f40e4b54e92","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@mloughran.com","name":"Martyn Loughran"},"message":"Remove smoke tests\n\nThese have been replaced by https://github.com/ministryofjustice/prison-visits-integration-tests","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/a041f455bb4d8ffa4bace360c50d7f40e4b54e92"},{"sha":"c197434710b41adb268e1d2b15e4a0f15c946b1b","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Merge pull request #319 from ministryofjustice/remove-smoke-tests\n\nRemove smoke tests","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/c197434710b41adb268e1d2b15e4a0f15c946b1b"},{"sha":"bbb91b9158cfb560c539cbcad00b55a86d2c29d7","author":{"email":"e0c05dfebd8b15e8170d016dd33337e010494a1a@gmail.com","name":"Alan Kennedy"},"message":"Set the puma threads max to be the db pool size\n\nFixes an issue where Puma can accept a request but error out because the DB pool\ntimes out. This happened a couple of months ago when the Sendgrid API started\nbecoming unresponsive and we didn't have a pool of Sendgrid clients.\n\nThis is similar to how Rails 5 will be configured by default with Puma [1].\nAlthough with Rails 5 Puma can be configured via the command line with `rails s`\nso we can revisit this when we upgrade.\n\n[1] https://blog.heroku.com/archives/2016/5/2/container_ready_rails_5","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits/bbb91b9158cfb560c539cbcad00b55a86d2c29d7"}]}