{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/force/issues/476","repository_url":"https://api.github.com/repos/artsy/force","labels_url":"https://api.github.com/repos/artsy/force/issues/476/labels{/name}","comments_url":"https://api.github.com/repos/artsy/force/issues/476/comments","events_url":"https://api.github.com/repos/artsy/force/issues/476/events","html_url":"https://github.com/artsy/force/pull/476","id":194101273,"number":476,"title":"ASCII folding for partner location filters, take 2","user":{"login":"anandaroop","id":140521,"avatar_url":"https://avatars.githubusercontent.com/u/140521?v=3","gravatar_id":"","url":"https://api.github.com/users/anandaroop","html_url":"https://github.com/anandaroop","followers_url":"https://api.github.com/users/anandaroop/followers","following_url":"https://api.github.com/users/anandaroop/following{/other_user}","gists_url":"https://api.github.com/users/anandaroop/gists{/gist_id}","starred_url":"https://api.github.com/users/anandaroop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandaroop/subscriptions","organizations_url":"https://api.github.com/users/anandaroop/orgs","repos_url":"https://api.github.com/users/anandaroop/repos","events_url":"https://api.github.com/users/anandaroop/events{/privacy}","received_events_url":"https://api.github.com/users/anandaroop/received_events","type":"User","site_admin":false},"labels":[{"id":443827326,"url":"https://api.github.com/repos/artsy/force/labels/PS&R","name":"PS&R","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"gnilekaw","id":7292475,"avatar_url":"https://avatars.githubusercontent.com/u/7292475?v=3","gravatar_id":"","url":"https://api.github.com/users/gnilekaw","html_url":"https://github.com/gnilekaw","followers_url":"https://api.github.com/users/gnilekaw/followers","following_url":"https://api.github.com/users/gnilekaw/following{/other_user}","gists_url":"https://api.github.com/users/gnilekaw/gists{/gist_id}","starred_url":"https://api.github.com/users/gnilekaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnilekaw/subscriptions","organizations_url":"https://api.github.com/users/gnilekaw/orgs","repos_url":"https://api.github.com/users/gnilekaw/repos","events_url":"https://api.github.com/users/gnilekaw/events{/privacy}","received_events_url":"https://api.github.com/users/gnilekaw/received_events","type":"User","site_admin":false},"assignees":[{"login":"gnilekaw","id":7292475,"avatar_url":"https://avatars.githubusercontent.com/u/7292475?v=3","gravatar_id":"","url":"https://api.github.com/users/gnilekaw","html_url":"https://github.com/gnilekaw","followers_url":"https://api.github.com/users/gnilekaw/followers","following_url":"https://api.github.com/users/gnilekaw/following{/other_user}","gists_url":"https://api.github.com/users/gnilekaw/gists{/gist_id}","starred_url":"https://api.github.com/users/gnilekaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnilekaw/subscriptions","organizations_url":"https://api.github.com/users/gnilekaw/orgs","repos_url":"https://api.github.com/users/gnilekaw/repos","events_url":"https://api.github.com/users/gnilekaw/events{/privacy}","received_events_url":"https://api.github.com/users/gnilekaw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-07T16:42:19Z","updated_at":"2016-12-07T19:04:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/476","html_url":"https://github.com/artsy/force/pull/476","diff_url":"https://github.com/artsy/force/pull/476.diff","patch_url":"https://github.com/artsy/force/pull/476.patch"},"body":"Well [that was fun](https://github.com/artsy/force/pull/460), but this does the same thing for /galleries as well as  /collect, and furthermore does so by deleting net ~20 lines from the project, instead of by adding ~70 — ¯\\\\\\_(ツ)_/¯\r\n\r\nIn attempting to refactor the /collect case I learned — well, I stumbled across it by accident, while inspecting the js bundle created by Browserify — that there already was ascii-folding functionality [available to us via a third-party lib](https://github.com/artsy/force/blob/d01f65bf0b5cc58d5d3906494981be3c0c52f33b/package.json#L90), even though [that function](https://github.com/epeli/underscore.string/blob/master/cleanDiacritics.js) was not being used anywhere in Force.\r\n\r\nNow it is, and should be for similar cases where we need to do this on the client side (rather than via, say,  ES).\r\n\r\n#### /galleries works the same as in the other PR… \r\n\r\n![fold](https://cloud.githubusercontent.com/assets/140521/20906679/55cf3c20-bb17-11e6-8f36-49576a6cb9c2.gif)\r\n\r\n#### and now /collect has parity — same set of accented chars will get folded here too\r\n\r\n\r\n![collect](https://cloud.githubusercontent.com/assets/140521/20976694/4f4ed01c-bc71-11e6-84a6-cbb556d78266.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/artsy/force/issues/comments/265540471","html_url":"https://github.com/artsy/force/pull/476#issuecomment-265540471","issue_url":"https://api.github.com/repos/artsy/force/issues/476","id":265540471,"user":{"login":"anandaroop","id":140521,"avatar_url":"https://avatars.githubusercontent.com/u/140521?v=3","gravatar_id":"","url":"https://api.github.com/users/anandaroop","html_url":"https://github.com/anandaroop","followers_url":"https://api.github.com/users/anandaroop/followers","following_url":"https://api.github.com/users/anandaroop/following{/other_user}","gists_url":"https://api.github.com/users/anandaroop/gists{/gist_id}","starred_url":"https://api.github.com/users/anandaroop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandaroop/subscriptions","organizations_url":"https://api.github.com/users/anandaroop/orgs","repos_url":"https://api.github.com/users/anandaroop/repos","events_url":"https://api.github.com/users/anandaroop/events{/privacy}","received_events_url":"https://api.github.com/users/anandaroop/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T19:04:51Z","updated_at":"2016-12-07T19:04:51Z","body":"Thanks for the review @gnilekaw !"}}
{"actor":{"display_login":"anandaroop"}}