{"action":"closed","issue":{"url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/issues/140","repository_url":"https://api.github.com/repos/phetsims/capacitor-lab-basics","labels_url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/issues/140/comments","events_url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/issues/140/events","html_url":"https://github.com/phetsims/capacitor-lab-basics/issues/140","id":181015258,"number":140,"title":"Closed vs Open circuit representations","user":{"login":"phet-steele","id":5863899,"avatar_url":"https://avatars.githubusercontent.com/u/5863899?v=3","gravatar_id":"","url":"https://api.github.com/users/phet-steele","html_url":"https://github.com/phet-steele","followers_url":"https://api.github.com/users/phet-steele/followers","following_url":"https://api.github.com/users/phet-steele/following{/other_user}","gists_url":"https://api.github.com/users/phet-steele/gists{/gist_id}","starred_url":"https://api.github.com/users/phet-steele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phet-steele/subscriptions","organizations_url":"https://api.github.com/users/phet-steele/orgs","repos_url":"https://api.github.com/users/phet-steele/repos","events_url":"https://api.github.com/users/phet-steele/events{/privacy}","received_events_url":"https://api.github.com/users/phet-steele/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/labels/design:general","name":"design:general","color":"F6CCDA"},{"url":"https://api.github.com/repos/phetsims/capacitor-lab-basics/labels/status:ready-to-test","name":"status:ready-to-test","color":"006400"}],"state":"closed","locked":false,"assignee":{"login":"andrewadare","id":154163,"avatar_url":"https://avatars.githubusercontent.com/u/154163?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewadare","html_url":"https://github.com/andrewadare","followers_url":"https://api.github.com/users/andrewadare/followers","following_url":"https://api.github.com/users/andrewadare/following{/other_user}","gists_url":"https://api.github.com/users/andrewadare/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewadare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewadare/subscriptions","organizations_url":"https://api.github.com/users/andrewadare/orgs","repos_url":"https://api.github.com/users/andrewadare/repos","events_url":"https://api.github.com/users/andrewadare/events{/privacy}","received_events_url":"https://api.github.com/users/andrewadare/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewadare","id":154163,"avatar_url":"https://avatars.githubusercontent.com/u/154163?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewadare","html_url":"https://github.com/andrewadare","followers_url":"https://api.github.com/users/andrewadare/followers","following_url":"https://api.github.com/users/andrewadare/following{/other_user}","gists_url":"https://api.github.com/users/andrewadare/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewadare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewadare/subscriptions","organizations_url":"https://api.github.com/users/andrewadare/orgs","repos_url":"https://api.github.com/users/andrewadare/repos","events_url":"https://api.github.com/users/andrewadare/events{/privacy}","received_events_url":"https://api.github.com/users/andrewadare/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-10-04T21:55:53Z","updated_at":"2016-10-19T22:46:32Z","closed_at":"2016-10-19T22:46:32Z","body":"There was a discussion between myself and others about the behaviour of dragging the switch and when the circuit is open vs. closed. The sim doesn't consider a circuit closed if the switch is still being dragged, and only makes the circuit closed once the switch is released from the user's control. However, there is absolutely no visual difference between an open or closed circuit. For example, here is a screen shot of me dragging the switch into place. It looks like the circuit *should* be closed, but it is not and causes this very unphysical looking situation (the plate should be discharged/discharging):\r\n![img_0066 1](https://cloud.githubusercontent.com/assets/5863899/19093775/cf6a2ac6-8a49-11e6-93fa-3bca844f0132.PNG)\r\n\r\nTo avoid any confusion with this, I suggested to @arouinfar that we adopt the way CCKBBS handles circuits (she generally agreed). Any disconnected, open wire vertices have a red outline. Once the circuit is closed, the connected vertices become black and soldered together with a gray dot. \r\n\r\n<img width=\"478\" alt=\"screen shot 2016-10-04 at 3 32 19 pm\" src=\"https://cloud.githubusercontent.com/assets/5863899/19093300/ce1b1e5c-8a47-11e6-963d-ac39a68a29c2.png\">\r\n\r\n\r\nThis would work nicely in CLB, too. See below for the beautiful Google Drawing mockup (I'm sure @arouinfar could make a more accurate one, nudge nudge). The \"pin\" or round ball at the end of the switch will behave like the solder, where it would **only** appear once the switch is released and the circuit becomes closed. I'd think the behaviour of the middle position would ideally always show as open (no black circle or \"pin\" when releasing the switch in the middle). EDIT: @arouinfar had a better suggestion for the middle position below.\r\n![untitled drawing 1](https://cloud.githubusercontent.com/assets/5863899/19092376/976472c2-8a43-11e6-8f26-49750622ffd4.png)\r\n\r\n@arouinfar anything you would like to change or add? I'm sure I missed something!\r\n\r\nFor phetsims/tasks/issues/706.\r\n"}}
{"actor":{"display_login":"phet-steele"}}