{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/71742074","id":71742074,"diff_hunk":"@@ -263,6 +269,9 @@ def load_iris():\n         'target_names', the meaning of the labels, 'feature_names', the\n         meaning of the features, and 'DESCR', the\n         full description of the dataset.\n+    \n+    (data,target) : tuple if return_X_y == true","path":"sklearn/datasets/base.py","position":null,"original_position":27,"commit_id":"4613cdf142a44a539d54c1dbec159d66933b7270","original_commit_id":"3f9494c3c9f2befd548380a922f8021c058a6410","user":{"login":"manu-chroma","id":12952080,"avatar_url":"https://avatars.githubusercontent.com/u/12952080?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-chroma","html_url":"https://github.com/manu-chroma","followers_url":"https://api.github.com/users/manu-chroma/followers","following_url":"https://api.github.com/users/manu-chroma/following{/other_user}","gists_url":"https://api.github.com/users/manu-chroma/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-chroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-chroma/subscriptions","organizations_url":"https://api.github.com/users/manu-chroma/orgs","repos_url":"https://api.github.com/users/manu-chroma/repos","events_url":"https://api.github.com/users/manu-chroma/events{/privacy}","received_events_url":"https://api.github.com/users/manu-chroma/received_events","type":"User","site_admin":false},"body":"Updated and added an extra line.","created_at":"2016-07-21T16:45:17Z","updated_at":"2016-07-21T16:45:17Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7049#discussion_r71742074","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/71742074"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7049#discussion_r71742074"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049","id":77950114,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7049","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7049.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7049.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7049","number":7049,"state":"open","locked":false,"title":"[MRG] load_iris dataset: added return_X_y option","user":{"login":"manu-chroma","id":12952080,"avatar_url":"https://avatars.githubusercontent.com/u/12952080?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-chroma","html_url":"https://github.com/manu-chroma","followers_url":"https://api.github.com/users/manu-chroma/followers","following_url":"https://api.github.com/users/manu-chroma/following{/other_user}","gists_url":"https://api.github.com/users/manu-chroma/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-chroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-chroma/subscriptions","organizations_url":"https://api.github.com/users/manu-chroma/orgs","repos_url":"https://api.github.com/users/manu-chroma/repos","events_url":"https://api.github.com/users/manu-chroma/events{/privacy}","received_events_url":"https://api.github.com/users/manu-chroma/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\nAdd return_tuple option to data loaders that return a Bunch https://github.com/scikit-learn/scikit-learn/issues/6670\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n1. added return_X_y option in load_iris\r\n2. Wrote tests for the same \r\n\r\n#### Any other comments?\r\n1. Majority of the code is taken from https://github.com/scikit-learn/scikit-learn/pull/6704\r\n2. Some improvements based on the discussion on the same PR \r\n3. First contribution to scikit-learn \r\n\r\n<!--Please be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n\r\n","created_at":"2016-07-19T10:11:08Z","updated_at":"2016-07-21T16:45:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b69c255c1be9df2e567751a74043baa3b3b1d83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7049/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4613cdf142a44a539d54c1dbec159d66933b7270","head":{"label":"manu-chroma:load_iris","ref":"load_iris","sha":"4613cdf142a44a539d54c1dbec159d66933b7270","user":{"login":"manu-chroma","id":12952080,"avatar_url":"https://avatars.githubusercontent.com/u/12952080?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-chroma","html_url":"https://github.com/manu-chroma","followers_url":"https://api.github.com/users/manu-chroma/followers","following_url":"https://api.github.com/users/manu-chroma/following{/other_user}","gists_url":"https://api.github.com/users/manu-chroma/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-chroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-chroma/subscriptions","organizations_url":"https://api.github.com/users/manu-chroma/orgs","repos_url":"https://api.github.com/users/manu-chroma/repos","events_url":"https://api.github.com/users/manu-chroma/events{/privacy}","received_events_url":"https://api.github.com/users/manu-chroma/received_events","type":"User","site_admin":false},"repo":{"id":63677574,"name":"scikit-learn","full_name":"manu-chroma/scikit-learn","owner":{"login":"manu-chroma","id":12952080,"avatar_url":"https://avatars.githubusercontent.com/u/12952080?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-chroma","html_url":"https://github.com/manu-chroma","followers_url":"https://api.github.com/users/manu-chroma/followers","following_url":"https://api.github.com/users/manu-chroma/following{/other_user}","gists_url":"https://api.github.com/users/manu-chroma/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-chroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-chroma/subscriptions","organizations_url":"https://api.github.com/users/manu-chroma/orgs","repos_url":"https://api.github.com/users/manu-chroma/repos","events_url":"https://api.github.com/users/manu-chroma/events{/privacy}","received_events_url":"https://api.github.com/users/manu-chroma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manu-chroma/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/manu-chroma/scikit-learn","forks_url":"https://api.github.com/repos/manu-chroma/scikit-learn/forks","keys_url":"https://api.github.com/repos/manu-chroma/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manu-chroma/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manu-chroma/scikit-learn/teams","hooks_url":"https://api.github.com/repos/manu-chroma/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/manu-chroma/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/manu-chroma/scikit-learn/events","assignees_url":"https://api.github.com/repos/manu-chroma/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/manu-chroma/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/manu-chroma/scikit-learn/tags","blobs_url":"https://api.github.com/repos/manu-chroma/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manu-chroma/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manu-chroma/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/manu-chroma/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manu-chroma/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/manu-chroma/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/manu-chroma/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/manu-chroma/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/manu-chroma/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/manu-chroma/scikit-learn/subscription","commits_url":"https://api.github.com/repos/manu-chroma/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/manu-chroma/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/manu-chroma/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/manu-chroma/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/manu-chroma/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/manu-chroma/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manu-chroma/scikit-learn/merges","archive_url":"https://api.github.com/repos/manu-chroma/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manu-chroma/scikit-learn/downloads","issues_url":"https://api.github.com/repos/manu-chroma/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/manu-chroma/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/manu-chroma/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/manu-chroma/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manu-chroma/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/manu-chroma/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/manu-chroma/scikit-learn/deployments","created_at":"2016-07-19T08:50:51Z","updated_at":"2016-07-19T08:50:59Z","pushed_at":"2016-07-21T16:36:59Z","git_url":"git://github.com/manu-chroma/scikit-learn.git","ssh_url":"git@github.com:manu-chroma/scikit-learn.git","clone_url":"https://github.com/manu-chroma/scikit-learn.git","svn_url":"https://github.com/manu-chroma/scikit-learn","homepage":"http://scikit-learn.org","size":77111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"6b863e59e14987dcb50aa95add923ba32dbcc80d","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-07-21T16:14:30Z","pushed_at":"2016-07-21T16:37:00Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":125564,"stargazers_count":12455,"watchers_count":12455,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7214,"mirror_url":null,"open_issues_count":1248,"forks":7214,"open_issues":1248,"watchers":12455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7049"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7049"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7049/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7049/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4613cdf142a44a539d54c1dbec159d66933b7270"}}}}
{"actor":{"display_login":"manu-chroma"}}