{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments/59629102","id":59629102,"diff_hunk":"@@ -0,0 +1,107 @@\n+/*\n+ * Copyright 2016 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *       http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.google.cloud;\n+\n+import static com.google.common.base.Preconditions.checkNotNull;\n+import static com.google.common.base.Preconditions.checkState;\n+\n+import java.util.LinkedList;\n+import java.util.List;\n+\n+/**\n+ * This class holds a single result of a batch call. {@code T} is the type of the result and {@code\n+ * E} is the type of the service-dependent exception thrown when a processing error occurs.\n+ */\n+public abstract class BatchResult<T, E extends BaseServiceException> {\n+\n+  private T result;\n+  private boolean completed = false;\n+  private E error;\n+  private List<Callback<T, E>> toBeNotified = new LinkedList<>();\n+\n+  /**\n+   * Returns {@code true} if the batch has been completed and the result is available; {@code false}\n+   * otherwise.\n+   */\n+  public boolean completed() {\n+    return completed;\n+  }\n+\n+  /**\n+   * Returns the result of this call.\n+   *\n+   * @throws IllegalStateException if the batch has not been completed yet\n+   * @throws E if an error occurred when processing this request\n+   */\n+  public T get() throws E {\n+    checkState(completed(), \"Batch has not been completed yet\");\n+    if (error != null) {\n+      throw error;\n+    }\n+    return result;\n+  }\n+\n+  /**\n+   * Adds a callback for the batch operation.\n+   *\n+   * @throws IllegalStateException if the batch has been completed already\n+   */\n+  public void notify(Callback<T, E> callback) {\n+    if (completed) {","path":"gcloud-java-core/src/main/java/com/google/cloud/BatchResult.java","position":64,"original_position":64,"commit_id":"1c60ba0f1d16e18433af8dbaf86f1bb90498eeff","original_commit_id":"1c60ba0f1d16e18433af8dbaf86f1bb90498eeff","user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"body":"Like above you should use `checkState(...)`","created_at":"2016-04-13T21:28:15Z","updated_at":"2016-04-13T21:28:15Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787#discussion_r59629102","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments/59629102"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787#discussion_r59629102"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787","id":64115329,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/787","number":787,"state":"closed","locked":false,"title":"Third concept of DNS batch.","user":{"login":"mderka","id":1192586,"avatar_url":"https://avatars.githubusercontent.com/u/1192586?v=3","gravatar_id":"","url":"https://api.github.com/users/mderka","html_url":"https://github.com/mderka","followers_url":"https://api.github.com/users/mderka/followers","following_url":"https://api.github.com/users/mderka/following{/other_user}","gists_url":"https://api.github.com/users/mderka/gists{/gist_id}","starred_url":"https://api.github.com/users/mderka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mderka/subscriptions","organizations_url":"https://api.github.com/users/mderka/orgs","repos_url":"https://api.github.com/users/mderka/repos","events_url":"https://api.github.com/users/mderka/events{/privacy}","received_events_url":"https://api.github.com/users/mderka/received_events","type":"User","site_admin":false},"body":"The internals differ a bit, however, the interface is the same as in the second concept #777.","created_at":"2016-03-24T23:47:46Z","updated_at":"2016-04-13T21:28:15Z","closed_at":"2016-04-13T20:45:47Z","merged_at":"2016-04-13T20:45:47Z","merge_commit_sha":"beea588369267e59f7d2c3f10cf20088195f9d66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/787/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/1c60ba0f1d16e18433af8dbaf86f1bb90498eeff","head":{"label":"mderka:batch3","ref":"batch3","sha":"1c60ba0f1d16e18433af8dbaf86f1bb90498eeff","user":{"login":"mderka","id":1192586,"avatar_url":"https://avatars.githubusercontent.com/u/1192586?v=3","gravatar_id":"","url":"https://api.github.com/users/mderka","html_url":"https://github.com/mderka","followers_url":"https://api.github.com/users/mderka/followers","following_url":"https://api.github.com/users/mderka/following{/other_user}","gists_url":"https://api.github.com/users/mderka/gists{/gist_id}","starred_url":"https://api.github.com/users/mderka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mderka/subscriptions","organizations_url":"https://api.github.com/users/mderka/orgs","repos_url":"https://api.github.com/users/mderka/repos","events_url":"https://api.github.com/users/mderka/events{/privacy}","received_events_url":"https://api.github.com/users/mderka/received_events","type":"User","site_admin":false},"repo":{"id":49172330,"name":"gcloud-java","full_name":"mderka/gcloud-java","owner":{"login":"mderka","id":1192586,"avatar_url":"https://avatars.githubusercontent.com/u/1192586?v=3","gravatar_id":"","url":"https://api.github.com/users/mderka","html_url":"https://github.com/mderka","followers_url":"https://api.github.com/users/mderka/followers","following_url":"https://api.github.com/users/mderka/following{/other_user}","gists_url":"https://api.github.com/users/mderka/gists{/gist_id}","starred_url":"https://api.github.com/users/mderka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mderka/subscriptions","organizations_url":"https://api.github.com/users/mderka/orgs","repos_url":"https://api.github.com/users/mderka/repos","events_url":"https://api.github.com/users/mderka/events{/privacy}","received_events_url":"https://api.github.com/users/mderka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mderka/gcloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/mderka/gcloud-java","forks_url":"https://api.github.com/repos/mderka/gcloud-java/forks","keys_url":"https://api.github.com/repos/mderka/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mderka/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mderka/gcloud-java/teams","hooks_url":"https://api.github.com/repos/mderka/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/mderka/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/mderka/gcloud-java/events","assignees_url":"https://api.github.com/repos/mderka/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/mderka/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/mderka/gcloud-java/tags","blobs_url":"https://api.github.com/repos/mderka/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mderka/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mderka/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mderka/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mderka/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/mderka/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/mderka/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/mderka/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/mderka/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/mderka/gcloud-java/subscription","commits_url":"https://api.github.com/repos/mderka/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mderka/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mderka/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mderka/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mderka/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/mderka/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mderka/gcloud-java/merges","archive_url":"https://api.github.com/repos/mderka/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mderka/gcloud-java/downloads","issues_url":"https://api.github.com/repos/mderka/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/mderka/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/mderka/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/mderka/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mderka/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/mderka/gcloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/mderka/gcloud-java/deployments","created_at":"2016-01-07T01:16:58Z","updated_at":"2016-01-11T19:05:33Z","pushed_at":"2016-04-13T20:58:54Z","git_url":"git://github.com/mderka/gcloud-java.git","ssh_url":"git@github.com:mderka/gcloud-java.git","clone_url":"https://github.com/mderka/gcloud-java.git","svn_url":"https://github.com/mderka/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":15160,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:dns-alpha-batch","ref":"dns-alpha-batch","sha":"10afe8614b8ce9d04e9a4ac915f9a5f07aa86b87","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"gcloud-java","full_name":"GoogleCloudPlatform/gcloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2016-04-13T11:49:50Z","pushed_at":"2016-04-13T21:25:48Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":224035,"stargazers_count":86,"watchers_count":86,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":155,"forks":46,"open_issues":155,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/787"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/787"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/1c60ba0f1d16e18433af8dbaf86f1bb90498eeff"}}}}