{"action":"created","issue":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1536","repository_url":"https://api.github.com/repos/Project-OSRM/osrm-backend","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1536/labels{/name}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1536/comments","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1536/events","html_url":"https://github.com/Project-OSRM/osrm-backend/issues/1536","id":89411674,"number":1536,"title":"Make EdgeBasedFactory testable","user":{"login":"TheMarex","id":606968,"avatar_url":"https://avatars.githubusercontent.com/u/606968?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMarex","html_url":"https://github.com/TheMarex","followers_url":"https://api.github.com/users/TheMarex/followers","following_url":"https://api.github.com/users/TheMarex/following{/other_user}","gists_url":"https://api.github.com/users/TheMarex/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMarex/subscriptions","organizations_url":"https://api.github.com/users/TheMarex/orgs","repos_url":"https://api.github.com/users/TheMarex/repos","events_url":"https://api.github.com/users/TheMarex/events{/privacy}","received_events_url":"https://api.github.com/users/TheMarex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/11","html_url":"https://github.com/Project-OSRM/osrm-backend/milestones/5.1.0","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/11/labels","id":1516996,"number":11,"title":"5.1.0","description":null,"creator":{"login":"TheMarex","id":606968,"avatar_url":"https://avatars.githubusercontent.com/u/606968?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMarex","html_url":"https://github.com/TheMarex","followers_url":"https://api.github.com/users/TheMarex/followers","following_url":"https://api.github.com/users/TheMarex/following{/other_user}","gists_url":"https://api.github.com/users/TheMarex/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMarex/subscriptions","organizations_url":"https://api.github.com/users/TheMarex/orgs","repos_url":"https://api.github.com/users/TheMarex/repos","events_url":"https://api.github.com/users/TheMarex/events{/privacy}","received_events_url":"https://api.github.com/users/TheMarex/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":0,"state":"open","created_at":"2016-01-19T16:55:27Z","updated_at":"2016-03-09T14:47:58Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-06-18T22:23:41Z","updated_at":"2016-03-09T14:48:20Z","closed_at":null,"body":"After spending far far too many hours tracking down bugs in this part of the code we really need to break this apart [again](https://github.com/Project-OSRM/osrm-backend/pull/1010).\r\n\r\nCourse of action:\r\n- [x] Move CompressGeometry outside of EdgeBasedGraphFactory because this is a separate step\r\n- [ ] Move serialization outside of EdgeBasedGraphFactory (that is the generation of `OriginalEdgeData` the contents of the `.edges` file which is needed for turn instructions)\r\n- [ ] Move lua dependency outside of EdgeBasedGraphFactory (abstract this to TurnCostCalculator or maybe bundle with the turn restrictions?)\r\n- [x] Add unit tests for geometry compression\r\n- [ ] Add unit test for expanded graph generation"},"comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments/194327197","html_url":"https://github.com/Project-OSRM/osrm-backend/issues/1536#issuecomment-194327197","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1536","id":194327197,"user":{"login":"TheMarex","id":606968,"avatar_url":"https://avatars.githubusercontent.com/u/606968?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMarex","html_url":"https://github.com/TheMarex","followers_url":"https://api.github.com/users/TheMarex/followers","following_url":"https://api.github.com/users/TheMarex/following{/other_user}","gists_url":"https://api.github.com/users/TheMarex/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMarex/subscriptions","organizations_url":"https://api.github.com/users/TheMarex/orgs","repos_url":"https://api.github.com/users/TheMarex/repos","events_url":"https://api.github.com/users/TheMarex/events{/privacy}","received_events_url":"https://api.github.com/users/TheMarex/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T14:48:20Z","updated_at":"2016-03-09T14:48:20Z","body":"What is missing here is mostly the profile abstraction and writing the damn tests."}}