{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6782","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6782/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6782/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6782/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6782","id":154864524,"number":6782,"title":"Imputer fix for indicator_matrix in add_indicator_features option","user":{"login":"maniteja123","id":6291963,"avatar_url":"https://avatars.githubusercontent.com/u/6291963?v=3","gravatar_id":"","url":"https://api.github.com/users/maniteja123","html_url":"https://github.com/maniteja123","followers_url":"https://api.github.com/users/maniteja123/followers","following_url":"https://api.github.com/users/maniteja123/following{/other_user}","gists_url":"https://api.github.com/users/maniteja123/gists{/gist_id}","starred_url":"https://api.github.com/users/maniteja123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniteja123/subscriptions","organizations_url":"https://api.github.com/users/maniteja123/orgs","repos_url":"https://api.github.com/users/maniteja123/repos","events_url":"https://api.github.com/users/maniteja123/events{/privacy}","received_events_url":"https://api.github.com/users/maniteja123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-14T17:01:00Z","updated_at":"2016-05-15T12:53:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6782","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6782","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6782.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6782.patch"},"body":"#### Reference Issue\r\nFixes #6767 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nImputer ``add_indicator_features`` depends on the ``fit`` input for the indicator matrix and should be irrespective of the transform input.\r\n\r\n#### Any other comments?\r\nI have done many changes in the code, but the tests are passing. So please let me know if I changed something incorrectly.\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/219284183","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6782#issuecomment-219284183","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6782","id":219284183,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T12:53:29Z","updated_at":"2016-05-15T12:53:29Z","body":"The golden rule of **every call to transform must output the same number of features** says you must be wrong. No, we add indicator features according to missing values at `fit` time, not `transform` time."}}