{"action":"created","comment":{"url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/comments/58896421","id":58896421,"diff_hunk":"@@ -0,0 +1,37 @@\n+from pyshelf.resource_identity import ResourceIdentity\n+\n+\n+class ResourceIdentityFactory(object):\n+    def __init__(self, artifact_path_builder):\n+        self.artifact_path_builder = artifact_path_builder\n+\n+    def from_resource_url(self, resource_url):\n+        \"\"\"\n+            Creates a ResourceIdentity from the full\n+            resource url.  For example:\n+            /<bucket-name>/artifacts/<path>\n+\n+            Args:\n+                resource_url(basestring)\n+\n+            Returns:\n+                pyshelf.resource_identity.ResourceIdentity\n+        \"\"\"\n+        identity = ResourceIdentity(resource_url)\n+        return identity\n+\n+    def from_cloud_identifier(self, cloud_identifier):","path":"pyshelf/resource_identity_factory.py","position":23,"original_position":23,"commit_id":"4f937a0e63db75b7c38c5a44dd01328329ee5662","original_commit_id":"9740123381bd2cbb8f5e0c5fd80de1b437066eee","user":{"login":"quantumew","id":14934291,"avatar_url":"https://avatars.githubusercontent.com/u/14934291?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumew","html_url":"https://github.com/quantumew","followers_url":"https://api.github.com/users/quantumew/followers","following_url":"https://api.github.com/users/quantumew/following{/other_user}","gists_url":"https://api.github.com/users/quantumew/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumew/subscriptions","organizations_url":"https://api.github.com/users/quantumew/orgs","repos_url":"https://api.github.com/users/quantumew/repos","events_url":"https://api.github.com/users/quantumew/events{/privacy}","received_events_url":"https://api.github.com/users/quantumew/received_events","type":"User","site_admin":false},"body":"Should we test `from_cloud_identifier` since we have unit tests for the rest of resource_identity stuff?","created_at":"2016-04-07T15:53:45Z","updated_at":"2016-04-07T15:53:45Z","html_url":"https://github.com/kyle-long/pyshelf/pull/26#discussion_r58896421","pull_request_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/comments/58896421"},"html":{"href":"https://github.com/kyle-long/pyshelf/pull/26#discussion_r58896421"},"pull_request":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26","id":65653189,"html_url":"https://github.com/kyle-long/pyshelf/pull/26","diff_url":"https://github.com/kyle-long/pyshelf/pull/26.diff","patch_url":"https://github.com/kyle-long/pyshelf/pull/26.patch","issue_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/26","number":26,"state":"open","locked":false,"title":"needed a way to create a ResourceIdentity from the cloud identifier","user":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-07T15:47:27Z","updated_at":"2016-04-07T15:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9927bae3525c45f00540aae455039a260b9b8067","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26/commits","review_comments_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26/comments","review_comment_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/26/comments","statuses_url":"https://api.github.com/repos/kyle-long/pyshelf/statuses/4f937a0e63db75b7c38c5a44dd01328329ee5662","head":{"label":"kyle-long:resource-identity","ref":"resource-identity","sha":"4f937a0e63db75b7c38c5a44dd01328329ee5662","user":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"repo":{"id":48077575,"name":"pyshelf","full_name":"kyle-long/pyshelf","owner":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyle-long/pyshelf","description":"REST API for AWS S3 meant to be an interface to immutable artifact storage.","fork":false,"url":"https://api.github.com/repos/kyle-long/pyshelf","forks_url":"https://api.github.com/repos/kyle-long/pyshelf/forks","keys_url":"https://api.github.com/repos/kyle-long/pyshelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyle-long/pyshelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyle-long/pyshelf/teams","hooks_url":"https://api.github.com/repos/kyle-long/pyshelf/hooks","issue_events_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/events{/number}","events_url":"https://api.github.com/repos/kyle-long/pyshelf/events","assignees_url":"https://api.github.com/repos/kyle-long/pyshelf/assignees{/user}","branches_url":"https://api.github.com/repos/kyle-long/pyshelf/branches{/branch}","tags_url":"https://api.github.com/repos/kyle-long/pyshelf/tags","blobs_url":"https://api.github.com/repos/kyle-long/pyshelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyle-long/pyshelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyle-long/pyshelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyle-long/pyshelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyle-long/pyshelf/statuses/{sha}","languages_url":"https://api.github.com/repos/kyle-long/pyshelf/languages","stargazers_url":"https://api.github.com/repos/kyle-long/pyshelf/stargazers","contributors_url":"https://api.github.com/repos/kyle-long/pyshelf/contributors","subscribers_url":"https://api.github.com/repos/kyle-long/pyshelf/subscribers","subscription_url":"https://api.github.com/repos/kyle-long/pyshelf/subscription","commits_url":"https://api.github.com/repos/kyle-long/pyshelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyle-long/pyshelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyle-long/pyshelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyle-long/pyshelf/contents/{+path}","compare_url":"https://api.github.com/repos/kyle-long/pyshelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyle-long/pyshelf/merges","archive_url":"https://api.github.com/repos/kyle-long/pyshelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyle-long/pyshelf/downloads","issues_url":"https://api.github.com/repos/kyle-long/pyshelf/issues{/number}","pulls_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls{/number}","milestones_url":"https://api.github.com/repos/kyle-long/pyshelf/milestones{/number}","notifications_url":"https://api.github.com/repos/kyle-long/pyshelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyle-long/pyshelf/labels{/name}","releases_url":"https://api.github.com/repos/kyle-long/pyshelf/releases{/id}","deployments_url":"https://api.github.com/repos/kyle-long/pyshelf/deployments","created_at":"2015-12-16T00:43:49Z","updated_at":"2016-02-06T03:27:35Z","pushed_at":"2016-04-07T15:53:39Z","git_url":"git://github.com/kyle-long/pyshelf.git","ssh_url":"git@github.com:kyle-long/pyshelf.git","clone_url":"https://github.com/kyle-long/pyshelf.git","svn_url":"https://github.com/kyle-long/pyshelf","homepage":null,"size":360,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"kyle-long:develop","ref":"develop","sha":"0d64f625d3f6d69b1849e657ded2f9419dc1152b","user":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"repo":{"id":48077575,"name":"pyshelf","full_name":"kyle-long/pyshelf","owner":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyle-long/pyshelf","description":"REST API for AWS S3 meant to be an interface to immutable artifact storage.","fork":false,"url":"https://api.github.com/repos/kyle-long/pyshelf","forks_url":"https://api.github.com/repos/kyle-long/pyshelf/forks","keys_url":"https://api.github.com/repos/kyle-long/pyshelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyle-long/pyshelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyle-long/pyshelf/teams","hooks_url":"https://api.github.com/repos/kyle-long/pyshelf/hooks","issue_events_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/events{/number}","events_url":"https://api.github.com/repos/kyle-long/pyshelf/events","assignees_url":"https://api.github.com/repos/kyle-long/pyshelf/assignees{/user}","branches_url":"https://api.github.com/repos/kyle-long/pyshelf/branches{/branch}","tags_url":"https://api.github.com/repos/kyle-long/pyshelf/tags","blobs_url":"https://api.github.com/repos/kyle-long/pyshelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyle-long/pyshelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyle-long/pyshelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyle-long/pyshelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyle-long/pyshelf/statuses/{sha}","languages_url":"https://api.github.com/repos/kyle-long/pyshelf/languages","stargazers_url":"https://api.github.com/repos/kyle-long/pyshelf/stargazers","contributors_url":"https://api.github.com/repos/kyle-long/pyshelf/contributors","subscribers_url":"https://api.github.com/repos/kyle-long/pyshelf/subscribers","subscription_url":"https://api.github.com/repos/kyle-long/pyshelf/subscription","commits_url":"https://api.github.com/repos/kyle-long/pyshelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyle-long/pyshelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyle-long/pyshelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyle-long/pyshelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyle-long/pyshelf/contents/{+path}","compare_url":"https://api.github.com/repos/kyle-long/pyshelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyle-long/pyshelf/merges","archive_url":"https://api.github.com/repos/kyle-long/pyshelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyle-long/pyshelf/downloads","issues_url":"https://api.github.com/repos/kyle-long/pyshelf/issues{/number}","pulls_url":"https://api.github.com/repos/kyle-long/pyshelf/pulls{/number}","milestones_url":"https://api.github.com/repos/kyle-long/pyshelf/milestones{/number}","notifications_url":"https://api.github.com/repos/kyle-long/pyshelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyle-long/pyshelf/labels{/name}","releases_url":"https://api.github.com/repos/kyle-long/pyshelf/releases{/id}","deployments_url":"https://api.github.com/repos/kyle-long/pyshelf/deployments","created_at":"2015-12-16T00:43:49Z","updated_at":"2016-02-06T03:27:35Z","pushed_at":"2016-04-07T15:53:39Z","git_url":"git://github.com/kyle-long/pyshelf.git","ssh_url":"git@github.com:kyle-long/pyshelf.git","clone_url":"https://github.com/kyle-long/pyshelf.git","svn_url":"https://github.com/kyle-long/pyshelf","homepage":null,"size":360,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26"},"html":{"href":"https://github.com/kyle-long/pyshelf/pull/26"},"issue":{"href":"https://api.github.com/repos/kyle-long/pyshelf/issues/26"},"comments":{"href":"https://api.github.com/repos/kyle-long/pyshelf/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kyle-long/pyshelf/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/kyle-long/pyshelf/statuses/4f937a0e63db75b7c38c5a44dd01328329ee5662"}}}}