{"action":"closed","number":2257,"pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/2257","id":98147739,"html_url":"https://github.com/zeromq/libzmq/pull/2257","diff_url":"https://github.com/zeromq/libzmq/pull/2257.diff","patch_url":"https://github.com/zeromq/libzmq/pull/2257.patch","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/2257","number":2257,"state":"closed","locked":false,"title":"zmq_poll: only compare FD when neither item is a zmq socket","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"The bug fixed by #2250 was that `j` is an index into `events`, not `items_`. Removing the comparison altogether in #2250 ought to be safe because unlike `items_`, `events` comes internally from libzmq. Still, I'm more comfortable with only comparing FD if neither side is a zmq socket event.\n\nStill passes the test case in #2255","created_at":"2016-12-15T13:11:05Z","updated_at":"2016-12-15T13:20:46Z","closed_at":"2016-12-15T13:20:46Z","merged_at":"2016-12-15T13:20:46Z","merge_commit_sha":"2b565088d0058a03936200939e7fd772c8677d72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/libzmq/pulls/2257/commits","review_comments_url":"https://api.github.com/repos/zeromq/libzmq/pulls/2257/comments","review_comment_url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/2257/comments","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/0abdc28c8457e5bc4462a942ee8569fb2d81dfae","head":{"label":"minrk:check-event","ref":"check-event","sha":"0abdc28c8457e5bc4462a942ee8569fb2d81dfae","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":1141636,"name":"libzmq","full_name":"minrk/libzmq","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/libzmq","description":"lightweight messaging kernel","fork":true,"url":"https://api.github.com/repos/minrk/libzmq","forks_url":"https://api.github.com/repos/minrk/libzmq/forks","keys_url":"https://api.github.com/repos/minrk/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/libzmq/teams","hooks_url":"https://api.github.com/repos/minrk/libzmq/hooks","issue_events_url":"https://api.github.com/repos/minrk/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/libzmq/events","assignees_url":"https://api.github.com/repos/minrk/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/libzmq/tags","blobs_url":"https://api.github.com/repos/minrk/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/libzmq/languages","stargazers_url":"https://api.github.com/repos/minrk/libzmq/stargazers","contributors_url":"https://api.github.com/repos/minrk/libzmq/contributors","subscribers_url":"https://api.github.com/repos/minrk/libzmq/subscribers","subscription_url":"https://api.github.com/repos/minrk/libzmq/subscription","commits_url":"https://api.github.com/repos/minrk/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/libzmq/merges","archive_url":"https://api.github.com/repos/minrk/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/libzmq/downloads","issues_url":"https://api.github.com/repos/minrk/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/minrk/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/minrk/libzmq/deployments","created_at":"2010-12-06T00:27:43Z","updated_at":"2014-12-03T18:39:43Z","pushed_at":"2016-12-15T13:05:57Z","git_url":"git://github.com/minrk/libzmq.git","ssh_url":"git@github.com:minrk/libzmq.git","clone_url":"https://github.com/minrk/libzmq.git","svn_url":"https://github.com/minrk/libzmq","homepage":"www.zeromq.org","size":17388,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"1910ef8d3e2553d296962445002e538ef797348a","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":263379,"name":"libzmq","full_name":"zeromq/libzmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.0","fork":false,"url":"https://api.github.com/repos/zeromq/libzmq","forks_url":"https://api.github.com/repos/zeromq/libzmq/forks","keys_url":"https://api.github.com/repos/zeromq/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/libzmq/teams","hooks_url":"https://api.github.com/repos/zeromq/libzmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/libzmq/events","assignees_url":"https://api.github.com/repos/zeromq/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/libzmq/tags","blobs_url":"https://api.github.com/repos/zeromq/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/libzmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/libzmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/libzmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/libzmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/libzmq/subscription","commits_url":"https://api.github.com/repos/zeromq/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/libzmq/merges","archive_url":"https://api.github.com/repos/zeromq/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/libzmq/downloads","issues_url":"https://api.github.com/repos/zeromq/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/zeromq/libzmq/deployments","created_at":"2009-07-29T09:56:41Z","updated_at":"2016-12-15T07:41:38Z","pushed_at":"2016-12-15T13:20:46Z","git_url":"git://github.com/zeromq/libzmq.git","ssh_url":"git@github.com:zeromq/libzmq.git","clone_url":"https://github.com/zeromq/libzmq.git","svn_url":"https://github.com/zeromq/libzmq","homepage":"http://www.zeromq.org","size":15846,"stargazers_count":3124,"watchers_count":3124,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":942,"mirror_url":null,"open_issues_count":214,"forks":942,"open_issues":214,"watchers":3124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2257"},"html":{"href":"https://github.com/zeromq/libzmq/pull/2257"},"issue":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/2257"},"comments":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/2257/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2257/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2257/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/libzmq/statuses/0abdc28c8457e5bc4462a942ee8569fb2d81dfae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bluca","id":782193,"avatar_url":"https://avatars.githubusercontent.com/u/782193?v=3","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bluca"}}