{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/1404","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/1404/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1404/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/1404/events","html_url":"https://github.com/openssl/openssl/pull/1404","id":169587739,"number":1404,"title":"satsub64be() fixes","user":{"login":"dwmw2","id":911239,"avatar_url":"https://avatars.githubusercontent.com/u/911239?v=3","gravatar_id":"","url":"https://api.github.com/users/dwmw2","html_url":"https://github.com/dwmw2","followers_url":"https://api.github.com/users/dwmw2/followers","following_url":"https://api.github.com/users/dwmw2/following{/other_user}","gists_url":"https://api.github.com/users/dwmw2/gists{/gist_id}","starred_url":"https://api.github.com/users/dwmw2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwmw2/subscriptions","organizations_url":"https://api.github.com/users/dwmw2/orgs","repos_url":"https://api.github.com/users/dwmw2/repos","events_url":"https://api.github.com/users/dwmw2/events{/privacy}","received_events_url":"https://api.github.com/users/dwmw2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/1","html_url":"https://github.com/openssl/openssl/milestones/1.1.0","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/1/labels","id":1748232,"number":1,"title":"1.1.0","description":"","creator":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":263,"state":"open","created_at":"2016-05-04T17:53:39Z","updated_at":"2016-08-16T09:02:24Z","due_on":"2016-08-24T22:00:00Z","closed_at":null},"comments":3,"created_at":"2016-08-05T11:30:41Z","updated_at":"2016-08-16T09:24:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1404","html_url":"https://github.com/openssl/openssl/pull/1404","diff_url":"https://github.com/openssl/openssl/pull/1404.diff","patch_url":"https://github.com/openssl/openssl/pull/1404.patch"},"body":"In PR #1296 I added a minimal fix for `satsub64be()` since it was already fairly much outside the scope of what I was trying to do — it was broken even for standard DTLS.\r\n\r\nIt warrants closer attention though. Here's a cleanup for both the special-case 64-bit version, and the fallback. The former can work for little-endian too and the latter doesn't need to be bytewise; we can do it as two 32-bit values instead.\r\n\r\nI checked with GCC 6.1.1 on Fedora, and at least for x86_64 the compiler is clever enough to spot the pattern of bytewise loads-and-shifts in `n2l8()` and emit a single `movbe` instruction.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/240051001","html_url":"https://github.com/openssl/openssl/pull/1404#issuecomment-240051001","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1404","id":240051001,"user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T09:24:28Z","updated_at":"2016-08-16T09:24:28Z","body":"+1. Buried in the discussion above I think @dot-asm already gave this a +1 too, so I will merge."}}
{"actor":{"display_login":"mattcaswell"}}