{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/64724450","id":64724450,"diff_hunk":"@@ -134,7 +139,15 @@ static public function convertPositionalToNamedPlaceholders($statement)\n      */\n     public function bindValue($param, $value, $type = null)\n     {\n-        return $this->bindParam($param, $value, $type, null);\n+        if ($type === \\PDO::PARAM_LOB || -99 === $type) {\n+            $descriptor = oci_new_descriptor($this->_dbh, OCI_D_LOB);\n+            $descriptor->writeTemporary($value, $type === -99 ? OCI_TEMP_CLOB : OCI_TEMP_BLOB);","path":"lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php","position":19,"original_position":19,"commit_id":"27d26b776f214cee0f2cc9a544b466714256a930","original_commit_id":"27d26b776f214cee0f2cc9a544b466714256a930","user":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"body":"The [PHP docs](http://php.net/manual/en/oci-lob.writetemporary.php) are encouraging us to close the descriptor when finished. Maybe we should do that?","created_at":"2016-05-26T10:33:34Z","updated_at":"2016-05-26T10:33:34Z","html_url":"https://github.com/doctrine/dbal/pull/2386#discussion_r64724450","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/2386","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/64724450"},"html":{"href":"https://github.com/doctrine/dbal/pull/2386#discussion_r64724450"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2386"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/2386","id":69638024,"html_url":"https://github.com/doctrine/dbal/pull/2386","diff_url":"https://github.com/doctrine/dbal/pull/2386.diff","patch_url":"https://github.com/doctrine/dbal/pull/2386.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/2386","number":2386,"state":"open","locked":false,"title":"Fix oci driver bindValue overwrite with php7","user":{"login":"soyuka","id":1321971,"avatar_url":"https://avatars.githubusercontent.com/u/1321971?v=3","gravatar_id":"","url":"https://api.github.com/users/soyuka","html_url":"https://github.com/soyuka","followers_url":"https://api.github.com/users/soyuka/followers","following_url":"https://api.github.com/users/soyuka/following{/other_user}","gists_url":"https://api.github.com/users/soyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/soyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soyuka/subscriptions","organizations_url":"https://api.github.com/users/soyuka/orgs","repos_url":"https://api.github.com/users/soyuka/repos","events_url":"https://api.github.com/users/soyuka/events{/privacy}","received_events_url":"https://api.github.com/users/soyuka/received_events","type":"User","site_admin":false},"body":"Follow up on #2262 ","created_at":"2016-05-11T09:09:45Z","updated_at":"2016-05-26T10:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c54b9b7f0c7d1f6b1d71678c8875eec46c45910","assignee":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/2386/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/2386/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/2386/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/27d26b776f214cee0f2cc9a544b466714256a930","head":{"label":"soyuka:fixoci","ref":"fixoci","sha":"27d26b776f214cee0f2cc9a544b466714256a930","user":{"login":"soyuka","id":1321971,"avatar_url":"https://avatars.githubusercontent.com/u/1321971?v=3","gravatar_id":"","url":"https://api.github.com/users/soyuka","html_url":"https://github.com/soyuka","followers_url":"https://api.github.com/users/soyuka/followers","following_url":"https://api.github.com/users/soyuka/following{/other_user}","gists_url":"https://api.github.com/users/soyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/soyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soyuka/subscriptions","organizations_url":"https://api.github.com/users/soyuka/orgs","repos_url":"https://api.github.com/users/soyuka/repos","events_url":"https://api.github.com/users/soyuka/events{/privacy}","received_events_url":"https://api.github.com/users/soyuka/received_events","type":"User","site_admin":false},"repo":{"id":53577980,"name":"dbal","full_name":"soyuka/dbal","owner":{"login":"soyuka","id":1321971,"avatar_url":"https://avatars.githubusercontent.com/u/1321971?v=3","gravatar_id":"","url":"https://api.github.com/users/soyuka","html_url":"https://github.com/soyuka","followers_url":"https://api.github.com/users/soyuka/followers","following_url":"https://api.github.com/users/soyuka/following{/other_user}","gists_url":"https://api.github.com/users/soyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/soyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soyuka/subscriptions","organizations_url":"https://api.github.com/users/soyuka/orgs","repos_url":"https://api.github.com/users/soyuka/repos","events_url":"https://api.github.com/users/soyuka/events{/privacy}","received_events_url":"https://api.github.com/users/soyuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soyuka/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/soyuka/dbal","forks_url":"https://api.github.com/repos/soyuka/dbal/forks","keys_url":"https://api.github.com/repos/soyuka/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soyuka/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soyuka/dbal/teams","hooks_url":"https://api.github.com/repos/soyuka/dbal/hooks","issue_events_url":"https://api.github.com/repos/soyuka/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/soyuka/dbal/events","assignees_url":"https://api.github.com/repos/soyuka/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/soyuka/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/soyuka/dbal/tags","blobs_url":"https://api.github.com/repos/soyuka/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soyuka/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soyuka/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/soyuka/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soyuka/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/soyuka/dbal/languages","stargazers_url":"https://api.github.com/repos/soyuka/dbal/stargazers","contributors_url":"https://api.github.com/repos/soyuka/dbal/contributors","subscribers_url":"https://api.github.com/repos/soyuka/dbal/subscribers","subscription_url":"https://api.github.com/repos/soyuka/dbal/subscription","commits_url":"https://api.github.com/repos/soyuka/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/soyuka/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/soyuka/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/soyuka/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/soyuka/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/soyuka/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soyuka/dbal/merges","archive_url":"https://api.github.com/repos/soyuka/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soyuka/dbal/downloads","issues_url":"https://api.github.com/repos/soyuka/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/soyuka/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/soyuka/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/soyuka/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soyuka/dbal/labels{/name}","releases_url":"https://api.github.com/repos/soyuka/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/soyuka/dbal/deployments","created_at":"2016-03-10T11:05:14Z","updated_at":"2016-03-10T11:05:16Z","pushed_at":"2016-05-13T08:58:44Z","git_url":"git://github.com/soyuka/dbal.git","ssh_url":"git@github.com:soyuka/dbal.git","clone_url":"https://github.com/soyuka/dbal.git","svn_url":"https://github.com/soyuka/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":21168,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"1c6f63dff60f1f8c073087833edae2da96d37287","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2016-05-25T19:16:31Z","pushed_at":"2016-05-26T01:46:18Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":27181,"stargazers_count":738,"watchers_count":738,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":627,"mirror_url":null,"open_issues_count":279,"forks":627,"open_issues":279,"watchers":738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2386"},"html":{"href":"https://github.com/doctrine/dbal/pull/2386"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2386"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2386/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2386/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2386/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/27d26b776f214cee0f2cc9a544b466714256a930"}}}}
{"actor":{"display_login":"deeky666"}}