{"action":"closed","number":224,"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224","id":63133381,"html_url":"https://github.com/matrix-org/matrix-react-sdk/pull/224","diff_url":"https://github.com/matrix-org/matrix-react-sdk/pull/224.diff","patch_url":"https://github.com/matrix-org/matrix-react-sdk/pull/224.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/224","number":224,"state":"closed","locked":false,"title":"Pass correct arguments to onFinished in Modal","user":{"login":"aviraldg","id":238916,"avatar_url":"https://avatars.githubusercontent.com/u/238916?v=3","gravatar_id":"","url":"https://api.github.com/users/aviraldg","html_url":"https://github.com/aviraldg","followers_url":"https://api.github.com/users/aviraldg/followers","following_url":"https://api.github.com/users/aviraldg/following{/other_user}","gists_url":"https://api.github.com/users/aviraldg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviraldg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviraldg/subscriptions","organizations_url":"https://api.github.com/users/aviraldg/orgs","repos_url":"https://api.github.com/users/aviraldg/repos","events_url":"https://api.github.com/users/aviraldg/events{/privacy}","received_events_url":"https://api.github.com/users/aviraldg/received_events","type":"User","site_admin":false},"body":"Fixes vector-im/vector-web#1169\r\n\r\nWorks, and I couldn't find a case where this breaks existing behaviour, but since there are no tests to verify I can't be sure.","created_at":"2016-03-16T20:49:11Z","updated_at":"2016-03-18T11:32:18Z","closed_at":"2016-03-18T11:32:18Z","merged_at":null,"merge_commit_sha":"4b0a4fb5c9e7bc5b2cf808d7074a981eb32379f0","assignee":{"login":"ara4n","id":1294269,"avatar_url":"https://avatars.githubusercontent.com/u/1294269?v=3","gravatar_id":"","url":"https://api.github.com/users/ara4n","html_url":"https://github.com/ara4n","followers_url":"https://api.github.com/users/ara4n/followers","following_url":"https://api.github.com/users/ara4n/following{/other_user}","gists_url":"https://api.github.com/users/ara4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ara4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara4n/subscriptions","organizations_url":"https://api.github.com/users/ara4n/orgs","repos_url":"https://api.github.com/users/ara4n/repos","events_url":"https://api.github.com/users/ara4n/events{/privacy}","received_events_url":"https://api.github.com/users/ara4n/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/224/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/statuses/f20d02e6059cc78f884d5aa73368887d321f4bcd","head":{"label":"aviraldg:fix-1169","ref":"fix-1169","sha":"f20d02e6059cc78f884d5aa73368887d321f4bcd","user":{"login":"aviraldg","id":238916,"avatar_url":"https://avatars.githubusercontent.com/u/238916?v=3","gravatar_id":"","url":"https://api.github.com/users/aviraldg","html_url":"https://github.com/aviraldg","followers_url":"https://api.github.com/users/aviraldg/followers","following_url":"https://api.github.com/users/aviraldg/following{/other_user}","gists_url":"https://api.github.com/users/aviraldg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviraldg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviraldg/subscriptions","organizations_url":"https://api.github.com/users/aviraldg/orgs","repos_url":"https://api.github.com/users/aviraldg/repos","events_url":"https://api.github.com/users/aviraldg/events{/privacy}","received_events_url":"https://api.github.com/users/aviraldg/received_events","type":"User","site_admin":false},"repo":{"id":53987155,"name":"matrix-react-sdk","full_name":"aviraldg/matrix-react-sdk","owner":{"login":"aviraldg","id":238916,"avatar_url":"https://avatars.githubusercontent.com/u/238916?v=3","gravatar_id":"","url":"https://api.github.com/users/aviraldg","html_url":"https://github.com/aviraldg","followers_url":"https://api.github.com/users/aviraldg/followers","following_url":"https://api.github.com/users/aviraldg/following{/other_user}","gists_url":"https://api.github.com/users/aviraldg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviraldg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviraldg/subscriptions","organizations_url":"https://api.github.com/users/aviraldg/orgs","repos_url":"https://api.github.com/users/aviraldg/repos","events_url":"https://api.github.com/users/aviraldg/events{/privacy}","received_events_url":"https://api.github.com/users/aviraldg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aviraldg/matrix-react-sdk","description":"Matrix SDK for React Javascript","fork":true,"url":"https://api.github.com/repos/aviraldg/matrix-react-sdk","forks_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/forks","keys_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/teams","hooks_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/hooks","issue_events_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/events","assignees_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/tags","blobs_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/languages","stargazers_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/stargazers","contributors_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/contributors","subscribers_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/subscribers","subscription_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/subscription","commits_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/merges","archive_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/downloads","issues_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aviraldg/matrix-react-sdk/deployments","created_at":"2016-03-16T00:00:09Z","updated_at":"2016-03-16T00:00:11Z","pushed_at":"2016-03-17T15:00:10Z","git_url":"git://github.com/aviraldg/matrix-react-sdk.git","ssh_url":"git@github.com:aviraldg/matrix-react-sdk.git","clone_url":"https://github.com/aviraldg/matrix-react-sdk.git","svn_url":"https://github.com/aviraldg/matrix-react-sdk","homepage":null,"size":2020,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"9dcdf0ae51d0bc508b93700caced83e214f06898","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":37144575,"name":"matrix-react-sdk","full_name":"matrix-org/matrix-react-sdk","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-react-sdk","description":"Matrix SDK for React Javascript","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-react-sdk","forks_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/deployments","created_at":"2015-06-09T16:37:07Z","updated_at":"2016-03-05T17:53:32Z","pushed_at":"2016-03-18T11:26:28Z","git_url":"git://github.com/matrix-org/matrix-react-sdk.git","ssh_url":"git@github.com:matrix-org/matrix-react-sdk.git","clone_url":"https://github.com/matrix-org/matrix-react-sdk.git","svn_url":"https://github.com/matrix-org/matrix-react-sdk","homepage":null,"size":2203,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224"},"html":{"href":"https://github.com/matrix-org/matrix-react-sdk/pull/224"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/224"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-react-sdk/statuses/f20d02e6059cc78f884d5aa73368887d321f4bcd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":7,"commits":2,"additions":5,"deletions":5,"changed_files":1}}