{"action":"opened","number":2642,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642","id":94838293,"html_url":"https://github.com/jenkinsci/jenkins/pull/2642","diff_url":"https://github.com/jenkinsci/jenkins/pull/2642.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2642.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2642","number":2642,"state":"open","locked":false,"title":"Make sure Security218BlackBoxTest cleans up threads it starts","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"While looking at the thread dump for a flaked test (`AbstractProjectTest.testConfiguringBlockBuildWhenUpstreamBuildingRoundtrip`, not that it really matters), I noticed that there were a lot of threads started by `Security218BlackBoxTest` in another test run blocked in `SocketInputStream.read`.\r\n\r\nCurrently we reuse JVMs between test suites, forking only as many as concurrency requires, so it is important to clean up static state between runs. `jenkins.util.Timer` does this correctly, though `FilePath.localPool` and `Computer.threadPoolForRemoting` still do not—a topic for a future fix.\r\n\r\nRetrofitting `CLI` to be `AutoCloseable` as well, and naming some more thread factories to make it easier to diagnose thread leaks.\r\n\r\n@reviewbybees","created_at":"2016-11-22T15:39:18Z","updated_at":"2016-11-22T15:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2642/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/e050540d8ca9ffce623daa46b45b96d0d7e5fbf1","head":{"label":"jglick:Security218BlackBoxTest-shutdown","ref":"Security218BlackBoxTest-shutdown","sha":"e050540d8ca9ffce623daa46b45b96d0d7e5fbf1","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":4914128,"name":"jenkins","full_name":"jglick/jenkins","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jglick/jenkins","forks_url":"https://api.github.com/repos/jglick/jenkins/forks","keys_url":"https://api.github.com/repos/jglick/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/jenkins/teams","hooks_url":"https://api.github.com/repos/jglick/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jglick/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/jenkins/events","assignees_url":"https://api.github.com/repos/jglick/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/jenkins/tags","blobs_url":"https://api.github.com/repos/jglick/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/jenkins/languages","stargazers_url":"https://api.github.com/repos/jglick/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jglick/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jglick/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jglick/jenkins/subscription","commits_url":"https://api.github.com/repos/jglick/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/jenkins/merges","archive_url":"https://api.github.com/repos/jglick/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/jenkins/downloads","issues_url":"https://api.github.com/repos/jglick/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jglick/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/jenkins/deployments","created_at":"2012-07-05T19:53:26Z","updated_at":"2015-02-22T21:27:52Z","pushed_at":"2016-11-22T15:38:57Z","git_url":"git://github.com/jglick/jenkins.git","ssh_url":"git@github.com:jglick/jenkins.git","clone_url":"https://github.com/jglick/jenkins.git","svn_url":"https://github.com/jglick/jenkins","homepage":"http://jenkins-ci.org/","size":96191,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"fada46e7387476b9b36f5780d5a75902a72edf2d","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-11-22T09:18:08Z","pushed_at":"2016-11-22T15:39:18Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":142658,"stargazers_count":7121,"watchers_count":7121,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2984,"mirror_url":null,"open_issues_count":114,"forks":2984,"open_issues":114,"watchers":7121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2642"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2642"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2642/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2642/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/e050540d8ca9ffce623daa46b45b96d0d7e5fbf1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":49,"deletions":30,"changed_files":7}}
{"actor":{"display_login":"jglick"}}