{"action":"closed","issue":{"url":"https://api.github.com/repos/MathewSachin/DuplicateFileDetector/issues/1","repository_url":"https://api.github.com/repos/MathewSachin/DuplicateFileDetector","labels_url":"https://api.github.com/repos/MathewSachin/DuplicateFileDetector/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/MathewSachin/DuplicateFileDetector/issues/1/comments","events_url":"https://api.github.com/repos/MathewSachin/DuplicateFileDetector/issues/1/events","html_url":"https://github.com/MathewSachin/DuplicateFileDetector/issues/1","id":160330736,"number":1,"title":"Creating error window in Non UI thread.","user":{"login":"kaviteshsingh","id":1415006,"avatar_url":"https://avatars.githubusercontent.com/u/1415006?v=3","gravatar_id":"","url":"https://api.github.com/users/kaviteshsingh","html_url":"https://github.com/kaviteshsingh","followers_url":"https://api.github.com/users/kaviteshsingh/followers","following_url":"https://api.github.com/users/kaviteshsingh/following{/other_user}","gists_url":"https://api.github.com/users/kaviteshsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/kaviteshsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaviteshsingh/subscriptions","organizations_url":"https://api.github.com/users/kaviteshsingh/orgs","repos_url":"https://api.github.com/users/kaviteshsingh/repos","events_url":"https://api.github.com/users/kaviteshsingh/events{/privacy}","received_events_url":"https://api.github.com/users/kaviteshsingh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-15T03:23:57Z","updated_at":"2016-06-15T04:04:28Z","closed_at":"2016-06-15T04:04:28Z","body":"Hi,\r\n\r\nYou are creating error window in the non-UI thread and it crashes the app when you try to delete the file which is in use.\r\n\r\n// code snippet at crash\r\n                // Intentionally not using a MessageBox so that user could see what was not deleted side by side.\r\n                new Window\r\n                {\r\n                    Title = $\"{errors.Count} error(s) occured:\",\r\n                    Content = sb.ToString(),\r\n                    ResizeMode = ResizeMode.NoResize,\r\n                    WindowStyle = WindowStyle.ToolWindow,\r\n                    Padding = new Thickness(10)\r\n                }.ShowDialog();\r\n\r\nYou can test this simply by copying any exe and creating a copy of it and launching it and then perform scan. After the duplicates are found, try deleting the exe and it will hit the issue.\r\n\r\nAlso, since the code is following MVVM pattern you should not directly create an UI component in the View-Model. If it is really needed, you can create an interface and call the UI element. "}}
{"actor":{"display_login":"MathewSachin"}}