{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/routing/issues/1115","repository_url":"https://api.github.com/repos/maidsafe/routing","labels_url":"https://api.github.com/repos/maidsafe/routing/issues/1115/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1115/comments","events_url":"https://api.github.com/repos/maidsafe/routing/issues/1115/events","html_url":"https://github.com/maidsafe/routing/pull/1115","id":168113126,"number":1115,"title":"WIP feat/routing: use node key as name","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-07-28T14:42:07Z","updated_at":"2016-08-02T06:50:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1115","html_url":"https://github.com/maidsafe/routing/pull/1115","diff_url":"https://github.com/maidsafe/routing/pull/1115.diff","patch_url":"https://github.com/maidsafe/routing/pull/1115.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/maidsafe/routing/1115)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/routing/issues/comments/236816391","html_url":"https://github.com/maidsafe/routing/pull/1115#issuecomment-236816391","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1115","id":236816391,"user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T06:50:55Z","updated_at":"2016-08-02T06:50:55Z","body":"\n\n\n\nReview status: 0 of 7 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/states/node.rs, line 979 \\[r2\\]](https://reviewable.io:443/reviews/maidsafe/routing/1115#-KNpCP_nrGU16vLOMb8K:-KO9-lMctBduu2HDHh2F:192488956) ([raw file](https://github.com/maidsafe/routing/blob/ac1402619ccd42445e4144879b38041e14ff0805/src/states/node.rs#L979)):*\n<details><summary><i>Previously, maqi wrote…</i></summary>\n> we can call nodes.sort(), but it doesn't change the order (or it sorted in the decreasing order?)\n</details>\nAh, sorry, it is `PublicId` that needs to implement `Ord` - and that should definitely go by _name_. Maybe it will, if we just make `name` the first field in `PublicId`? If not, `Ord` needs to be implemented by hand.\n\nIn either case, please add a test to `id.rs` to make sure that public IDs are ordered by name.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/maidsafe/routing/1115)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"afck"}}