{"action":"created","comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/84706930","pull_request_review_id":5467287,"id":84706930,"diff_hunk":"@@ -1,18 +1,22 @@\n package org.corfudb.runtime.view;\n \n-import lombok.Getter;\n+import lombok.extern.slf4j.Slf4j;\n import org.corfudb.infrastructure.TestLayoutBuilder;\n+import org.corfudb.protocols.wireprotocol.LogData;\n import org.corfudb.runtime.CorfuRuntime;\n import org.corfudb.runtime.clients.TestRule;\n import org.junit.Test;\n \n+import java.util.concurrent.CountDownLatch;\n+\n import static org.assertj.core.api.Assertions.assertThat;\n \n /**\n  * Created by mwei on 1/6/16.\n  */\n+@Slf4j\n public class LayoutViewTest extends AbstractViewTest {\n-    @Test\n+    //@Test","path":"src/test/java/org/corfudb/runtime/view/LayoutViewTest.java","position":21,"original_position":21,"commit_id":"fba0861d0dcc57017bbe33b1ef4d1cc4b2c60633","original_commit_id":"fba0861d0dcc57017bbe33b1ef4d1cc4b2c60633","user":{"login":"medhavidhawan","id":11648683,"avatar_url":"https://avatars.githubusercontent.com/u/11648683?v=3","gravatar_id":"","url":"https://api.github.com/users/medhavidhawan","html_url":"https://github.com/medhavidhawan","followers_url":"https://api.github.com/users/medhavidhawan/followers","following_url":"https://api.github.com/users/medhavidhawan/following{/other_user}","gists_url":"https://api.github.com/users/medhavidhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/medhavidhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medhavidhawan/subscriptions","organizations_url":"https://api.github.com/users/medhavidhawan/orgs","repos_url":"https://api.github.com/users/medhavidhawan/repos","events_url":"https://api.github.com/users/medhavidhawan/events{/privacy}","received_events_url":"https://api.github.com/users/medhavidhawan/received_events","type":"User","site_admin":false},"body":"I will fix this to run.","created_at":"2016-10-24T14:59:57Z","updated_at":"2016-10-24T14:59:57Z","html_url":"https://github.com/CorfuDB/CorfuDB/pull/249#discussion_r84706930","pull_request_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/84706930"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/249#discussion_r84706930"},"pull_request":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249","id":90240326,"html_url":"https://github.com/CorfuDB/CorfuDB/pull/249","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/249.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/249.patch","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/249","number":249,"state":"open","locked":false,"title":"Bug Fixes: CorfuRuntime and Corfu Layout","user":{"login":"medhavidhawan","id":11648683,"avatar_url":"https://avatars.githubusercontent.com/u/11648683?v=3","gravatar_id":"","url":"https://api.github.com/users/medhavidhawan","html_url":"https://github.com/medhavidhawan","followers_url":"https://api.github.com/users/medhavidhawan/followers","following_url":"https://api.github.com/users/medhavidhawan/following{/other_user}","gists_url":"https://api.github.com/users/medhavidhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/medhavidhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medhavidhawan/subscriptions","organizations_url":"https://api.github.com/users/medhavidhawan/orgs","repos_url":"https://api.github.com/users/medhavidhawan/repos","events_url":"https://api.github.com/users/medhavidhawan/events{/privacy}","received_events_url":"https://api.github.com/users/medhavidhawan/received_events","type":"User","site_admin":false},"body":"1. Improved CorfuRuntim#fetchLayout to shuffle through all layoutservers to\r\nfetch the new layout.\r\n2. Fixed synchronization problem when layout is fetched. It needs more\r\nwork.\r\n3. Changed LayoutView to not use the standard LayoutHelper in prepare,\r\npropose and committed calls to LayoutServers. The LayoutHelper was\r\nholding on to the old layout while trying to move the system to new layout.\r\n4. Changed LayoutServer Epoch checks to work with the epoch in the\r\nmessage payload (new Layout) and not the message metadata.\r\n5. Added LogUnit and LayoutServer failover test during data operations.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/corfudb/corfudb/249)\n<!-- Reviewable:end -->\n","created_at":"2016-10-20T16:56:34Z","updated_at":"2016-10-24T14:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce1b78b8f4fe7af79951aff0e613718d215c84ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249/commits","review_comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249/comments","review_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/249/comments","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/fba0861d0dcc57017bbe33b1ef4d1cc4b2c60633","head":{"label":"medhavidhawan:master","ref":"master","sha":"fba0861d0dcc57017bbe33b1ef4d1cc4b2c60633","user":{"login":"medhavidhawan","id":11648683,"avatar_url":"https://avatars.githubusercontent.com/u/11648683?v=3","gravatar_id":"","url":"https://api.github.com/users/medhavidhawan","html_url":"https://github.com/medhavidhawan","followers_url":"https://api.github.com/users/medhavidhawan/followers","following_url":"https://api.github.com/users/medhavidhawan/following{/other_user}","gists_url":"https://api.github.com/users/medhavidhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/medhavidhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medhavidhawan/subscriptions","organizations_url":"https://api.github.com/users/medhavidhawan/orgs","repos_url":"https://api.github.com/users/medhavidhawan/repos","events_url":"https://api.github.com/users/medhavidhawan/events{/privacy}","received_events_url":"https://api.github.com/users/medhavidhawan/received_events","type":"User","site_admin":false},"repo":{"id":45650730,"name":"CorfuDB","full_name":"medhavidhawan/CorfuDB","owner":{"login":"medhavidhawan","id":11648683,"avatar_url":"https://avatars.githubusercontent.com/u/11648683?v=3","gravatar_id":"","url":"https://api.github.com/users/medhavidhawan","html_url":"https://github.com/medhavidhawan","followers_url":"https://api.github.com/users/medhavidhawan/followers","following_url":"https://api.github.com/users/medhavidhawan/following{/other_user}","gists_url":"https://api.github.com/users/medhavidhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/medhavidhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medhavidhawan/subscriptions","organizations_url":"https://api.github.com/users/medhavidhawan/orgs","repos_url":"https://api.github.com/users/medhavidhawan/repos","events_url":"https://api.github.com/users/medhavidhawan/events{/privacy}","received_events_url":"https://api.github.com/users/medhavidhawan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/medhavidhawan/CorfuDB","description":"A cluster consistency platform","fork":true,"url":"https://api.github.com/repos/medhavidhawan/CorfuDB","forks_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/forks","keys_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/teams","hooks_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/events","assignees_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/tags","blobs_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/subscription","commits_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/merges","archive_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/downloads","issues_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/medhavidhawan/CorfuDB/deployments","created_at":"2015-11-06T01:14:49Z","updated_at":"2016-06-30T23:06:56Z","pushed_at":"2016-10-20T16:55:06Z","git_url":"git://github.com/medhavidhawan/CorfuDB.git","ssh_url":"git@github.com:medhavidhawan/CorfuDB.git","clone_url":"https://github.com/medhavidhawan/CorfuDB.git","svn_url":"https://github.com/medhavidhawan/CorfuDB","homepage":"","size":298348,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CorfuDB:master","ref":"master","sha":"c01079d24ae255514dbe478a7a7b30e1e1677f54","user":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars.githubusercontent.com/u/10199273?v=3","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"repo":{"id":12960439,"name":"CorfuDB","full_name":"CorfuDB/CorfuDB","owner":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars.githubusercontent.com/u/10199273?v=3","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CorfuDB/CorfuDB","description":"A cluster consistency platform","fork":false,"url":"https://api.github.com/repos/CorfuDB/CorfuDB","forks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/forks","keys_url":"https://api.github.com/repos/CorfuDB/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CorfuDB/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CorfuDB/CorfuDB/teams","hooks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/events","assignees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/CorfuDB/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/tags","blobs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/CorfuDB/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscription","commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/CorfuDB/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CorfuDB/CorfuDB/merges","archive_url":"https://api.github.com/repos/CorfuDB/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CorfuDB/CorfuDB/downloads","issues_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/CorfuDB/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/CorfuDB/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/CorfuDB/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/deployments","created_at":"2013-09-19T22:02:36Z","updated_at":"2016-10-12T04:55:31Z","pushed_at":"2016-10-22T16:08:03Z","git_url":"git://github.com/CorfuDB/CorfuDB.git","ssh_url":"git@github.com:CorfuDB/CorfuDB.git","clone_url":"https://github.com/CorfuDB/CorfuDB.git","svn_url":"https://github.com/CorfuDB/CorfuDB","homepage":"","size":1925820,"stargazers_count":95,"watchers_count":95,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":50,"forks":24,"open_issues":50,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/249"},"issue":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/249"},"comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/fba0861d0dcc57017bbe33b1ef4d1cc4b2c60633"}}}}
{"actor":{"display_login":"medhavidhawan"}}