{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/comments/80556160","id":80556160,"diff_hunk":"@@ -0,0 +1,19 @@\n+module.exports = {\n+    entry: ['babel-polyfill', './parser.js'],\n+    output: {\n+        path: './bin',","path":"webpack.config.js","position":4,"original_position":4,"commit_id":"e4905e3d721d9b8c690820ef3a860c54f21ef38f","original_commit_id":"e4905e3d721d9b8c690820ef3a860c54f21ef38f","user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"body":"Not sure that \"./bin/\" feels right.\r\nI thought that was typically used for CLI scripts in Node.\r\nWhat about \"./client\"?","created_at":"2016-09-26T19:44:33Z","updated_at":"2016-09-26T19:44:33Z","html_url":"https://github.com/mozilla/page-metadata-parser/pull/68#discussion_r80556160","pull_request_url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/comments/80556160"},"html":{"href":"https://github.com/mozilla/page-metadata-parser/pull/68#discussion_r80556160"},"pull_request":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68","id":85818273,"html_url":"https://github.com/mozilla/page-metadata-parser/pull/68","diff_url":"https://github.com/mozilla/page-metadata-parser/pull/68.diff","patch_url":"https://github.com/mozilla/page-metadata-parser/pull/68.patch","issue_url":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/68","number":68,"state":"open","locked":false,"title":"Adds webpack script for bundling page-metadata-parser + fathom.js for mobile clients","user":{"login":"sleroux","id":434322,"avatar_url":"https://avatars.githubusercontent.com/u/434322?v=3","gravatar_id":"","url":"https://api.github.com/users/sleroux","html_url":"https://github.com/sleroux","followers_url":"https://api.github.com/users/sleroux/followers","following_url":"https://api.github.com/users/sleroux/following{/other_user}","gists_url":"https://api.github.com/users/sleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/sleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleroux/subscriptions","organizations_url":"https://api.github.com/users/sleroux/orgs","repos_url":"https://api.github.com/users/sleroux/repos","events_url":"https://api.github.com/users/sleroux/events{/privacy}","received_events_url":"https://api.github.com/users/sleroux/received_events","type":"User","site_admin":false},"body":"Similar to the patch I submitted for fathom [1], this patch adds a webpack script to bundle up the rules set, fathom, and other dependencies into a single, vanilla JS file that can be loaded into a mobile Safari webview. This allows us to execute fathom and the rule set client-side on page loads when users navigate to pages.\r\n\r\n[1] https://github.com/mozilla/fathom/pull/24\r\n","created_at":"2016-09-19T15:44:26Z","updated_at":"2016-09-26T19:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032f714ccf388e4e9021703d6060c3ff1f8334b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68/commits","review_comments_url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68/comments","review_comment_url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/68/comments","statuses_url":"https://api.github.com/repos/mozilla/page-metadata-parser/statuses/e4905e3d721d9b8c690820ef3a860c54f21ef38f","head":{"label":"sleroux:sleroux/WebPackForIOS","ref":"sleroux/WebPackForIOS","sha":"e4905e3d721d9b8c690820ef3a860c54f21ef38f","user":{"login":"sleroux","id":434322,"avatar_url":"https://avatars.githubusercontent.com/u/434322?v=3","gravatar_id":"","url":"https://api.github.com/users/sleroux","html_url":"https://github.com/sleroux","followers_url":"https://api.github.com/users/sleroux/followers","following_url":"https://api.github.com/users/sleroux/following{/other_user}","gists_url":"https://api.github.com/users/sleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/sleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleroux/subscriptions","organizations_url":"https://api.github.com/users/sleroux/orgs","repos_url":"https://api.github.com/users/sleroux/repos","events_url":"https://api.github.com/users/sleroux/events{/privacy}","received_events_url":"https://api.github.com/users/sleroux/received_events","type":"User","site_admin":false},"repo":{"id":68032934,"name":"page-metadata-parser","full_name":"sleroux/page-metadata-parser","owner":{"login":"sleroux","id":434322,"avatar_url":"https://avatars.githubusercontent.com/u/434322?v=3","gravatar_id":"","url":"https://api.github.com/users/sleroux","html_url":"https://github.com/sleroux","followers_url":"https://api.github.com/users/sleroux/followers","following_url":"https://api.github.com/users/sleroux/following{/other_user}","gists_url":"https://api.github.com/users/sleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/sleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleroux/subscriptions","organizations_url":"https://api.github.com/users/sleroux/orgs","repos_url":"https://api.github.com/users/sleroux/repos","events_url":"https://api.github.com/users/sleroux/events{/privacy}","received_events_url":"https://api.github.com/users/sleroux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sleroux/page-metadata-parser","description":"A Javascript library for parsing metadata on a web page.","fork":true,"url":"https://api.github.com/repos/sleroux/page-metadata-parser","forks_url":"https://api.github.com/repos/sleroux/page-metadata-parser/forks","keys_url":"https://api.github.com/repos/sleroux/page-metadata-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sleroux/page-metadata-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sleroux/page-metadata-parser/teams","hooks_url":"https://api.github.com/repos/sleroux/page-metadata-parser/hooks","issue_events_url":"https://api.github.com/repos/sleroux/page-metadata-parser/issues/events{/number}","events_url":"https://api.github.com/repos/sleroux/page-metadata-parser/events","assignees_url":"https://api.github.com/repos/sleroux/page-metadata-parser/assignees{/user}","branches_url":"https://api.github.com/repos/sleroux/page-metadata-parser/branches{/branch}","tags_url":"https://api.github.com/repos/sleroux/page-metadata-parser/tags","blobs_url":"https://api.github.com/repos/sleroux/page-metadata-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sleroux/page-metadata-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sleroux/page-metadata-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/sleroux/page-metadata-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sleroux/page-metadata-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/sleroux/page-metadata-parser/languages","stargazers_url":"https://api.github.com/repos/sleroux/page-metadata-parser/stargazers","contributors_url":"https://api.github.com/repos/sleroux/page-metadata-parser/contributors","subscribers_url":"https://api.github.com/repos/sleroux/page-metadata-parser/subscribers","subscription_url":"https://api.github.com/repos/sleroux/page-metadata-parser/subscription","commits_url":"https://api.github.com/repos/sleroux/page-metadata-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/sleroux/page-metadata-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/sleroux/page-metadata-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/sleroux/page-metadata-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/sleroux/page-metadata-parser/contents/{+path}","compare_url":"https://api.github.com/repos/sleroux/page-metadata-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sleroux/page-metadata-parser/merges","archive_url":"https://api.github.com/repos/sleroux/page-metadata-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sleroux/page-metadata-parser/downloads","issues_url":"https://api.github.com/repos/sleroux/page-metadata-parser/issues{/number}","pulls_url":"https://api.github.com/repos/sleroux/page-metadata-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/sleroux/page-metadata-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/sleroux/page-metadata-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sleroux/page-metadata-parser/labels{/name}","releases_url":"https://api.github.com/repos/sleroux/page-metadata-parser/releases{/id}","deployments_url":"https://api.github.com/repos/sleroux/page-metadata-parser/deployments","created_at":"2016-09-12T17:46:52Z","updated_at":"2016-09-12T17:46:53Z","pushed_at":"2016-09-15T18:23:45Z","git_url":"git://github.com/sleroux/page-metadata-parser.git","ssh_url":"git@github.com:sleroux/page-metadata-parser.git","clone_url":"https://github.com/sleroux/page-metadata-parser.git","svn_url":"https://github.com/sleroux/page-metadata-parser","homepage":"https://www.npmjs.com/package/page-metadata-parser","size":153,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"18c334a9b7cc613e52f5e7ef3138e7294747b7ea","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":61582733,"name":"page-metadata-parser","full_name":"mozilla/page-metadata-parser","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/page-metadata-parser","description":"A Javascript library for parsing metadata on a web page.","fork":false,"url":"https://api.github.com/repos/mozilla/page-metadata-parser","forks_url":"https://api.github.com/repos/mozilla/page-metadata-parser/forks","keys_url":"https://api.github.com/repos/mozilla/page-metadata-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/page-metadata-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/page-metadata-parser/teams","hooks_url":"https://api.github.com/repos/mozilla/page-metadata-parser/hooks","issue_events_url":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/page-metadata-parser/events","assignees_url":"https://api.github.com/repos/mozilla/page-metadata-parser/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/page-metadata-parser/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/page-metadata-parser/tags","blobs_url":"https://api.github.com/repos/mozilla/page-metadata-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/page-metadata-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/page-metadata-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/page-metadata-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/page-metadata-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/page-metadata-parser/languages","stargazers_url":"https://api.github.com/repos/mozilla/page-metadata-parser/stargazers","contributors_url":"https://api.github.com/repos/mozilla/page-metadata-parser/contributors","subscribers_url":"https://api.github.com/repos/mozilla/page-metadata-parser/subscribers","subscription_url":"https://api.github.com/repos/mozilla/page-metadata-parser/subscription","commits_url":"https://api.github.com/repos/mozilla/page-metadata-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/page-metadata-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/page-metadata-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/page-metadata-parser/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/page-metadata-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/page-metadata-parser/merges","archive_url":"https://api.github.com/repos/mozilla/page-metadata-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/page-metadata-parser/downloads","issues_url":"https://api.github.com/repos/mozilla/page-metadata-parser/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/page-metadata-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/page-metadata-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/page-metadata-parser/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/page-metadata-parser/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/page-metadata-parser/deployments","created_at":"2016-06-20T21:50:32Z","updated_at":"2016-09-09T18:51:46Z","pushed_at":"2016-09-26T19:37:05Z","git_url":"git://github.com/mozilla/page-metadata-parser.git","ssh_url":"git@github.com:mozilla/page-metadata-parser.git","clone_url":"https://github.com/mozilla/page-metadata-parser.git","svn_url":"https://github.com/mozilla/page-metadata-parser","homepage":"https://www.npmjs.com/package/page-metadata-parser","size":51,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":22,"forks":6,"open_issues":22,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68"},"html":{"href":"https://github.com/mozilla/page-metadata-parser/pull/68"},"issue":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/68"},"comments":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/page-metadata-parser/statuses/e4905e3d721d9b8c690820ef3a860c54f21ef38f"}}}}
{"actor":{"display_login":"pdehaan"}}