{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/78491313","id":78491313,"diff_hunk":"@@ -118,7 +119,13 @@ void ColumnWriter::AddDataPage() {\n   DataPage page(\n       uncompressed_data, num_buffered_values_, encoding_, Encoding::RLE, Encoding::RLE);\n \n-  data_pages_.push_back(std::move(page));\n+  // Write the page to OutputStream eagerly if there is no dictionary or\n+  // if dictionary encoding has fallen back to PLAIN","path":"src/parquet/column/writer.cc","position":16,"original_position":16,"commit_id":"312bad896815d91f5d3b3a98d21de434f65f3e8e","original_commit_id":"312bad896815d91f5d3b3a98d21de434f65f3e8e","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"Sorry, my mistake, `data_pages_` is cleared after the fallback code path. Gerrit draft comments would be useful here","created_at":"2016-09-13T03:23:52Z","updated_at":"2016-09-13T03:23:52Z","html_url":"https://github.com/apache/parquet-cpp/pull/157#discussion_r78491313","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/78491313"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/157#discussion_r78491313"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/157","id":84906107,"html_url":"https://github.com/apache/parquet-cpp/pull/157","diff_url":"https://github.com/apache/parquet-cpp/pull/157.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/157.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/157","number":157,"state":"open","locked":false,"title":"PARQUET-687: C++: Switch to PLAIN encoding if dictionary grows too large","user":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"body":"Implemented dictionary fallback encoding\r\nAdded tests\r\nAdded a fast path to serialize data pages","created_at":"2016-09-12T16:53:25Z","updated_at":"2016-09-13T03:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96565f37837614d36dd6177369b6da1a8e5d7901","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/157/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/157/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/157/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/312bad896815d91f5d3b3a98d21de434f65f3e8e","head":{"label":"majetideepak:PARQUET-717","ref":"PARQUET-717","sha":"312bad896815d91f5d3b3a98d21de434f65f3e8e","user":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"repo":{"id":49598967,"name":"parquet-cpp","full_name":"majetideepak/parquet-cpp","owner":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majetideepak/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/majetideepak/parquet-cpp","forks_url":"https://api.github.com/repos/majetideepak/parquet-cpp/forks","keys_url":"https://api.github.com/repos/majetideepak/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majetideepak/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majetideepak/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/majetideepak/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/majetideepak/parquet-cpp/events","assignees_url":"https://api.github.com/repos/majetideepak/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/majetideepak/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/majetideepak/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majetideepak/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/majetideepak/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/majetideepak/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/majetideepak/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/majetideepak/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/majetideepak/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/majetideepak/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/majetideepak/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/majetideepak/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/majetideepak/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majetideepak/parquet-cpp/merges","archive_url":"https://api.github.com/repos/majetideepak/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majetideepak/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/majetideepak/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/majetideepak/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/majetideepak/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majetideepak/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/majetideepak/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/majetideepak/parquet-cpp/deployments","created_at":"2016-01-13T20:12:53Z","updated_at":"2016-03-17T14:07:22Z","pushed_at":"2016-09-12T16:48:58Z","git_url":"git://github.com/majetideepak/parquet-cpp.git","ssh_url":"git@github.com:majetideepak/parquet-cpp.git","clone_url":"https://github.com/majetideepak/parquet-cpp.git","svn_url":"https://github.com/majetideepak/parquet-cpp","homepage":null,"size":1054,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"55604b297f444e95e132658b2ef384870ae1f701","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-09-07T14:42:14Z","pushed_at":"2016-09-12T21:40:14Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":1554,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":2,"forks":38,"open_issues":2,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/157"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/157"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/157"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/312bad896815d91f5d3b3a98d21de434f65f3e8e"}}}}
{"actor":{"display_login":"wesm"}}