{"action":"created","comment":{"url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/comments/91975892","pull_request_review_id":12484975,"id":91975892,"diff_hunk":"@@ -62,33 +64,29 @@\n     (set-invalid-trigger trigger)))\n \n (defn process-value [v notify]\n-  (map (fn [k]\n-         (let [trigger (k @invalid-triggers)]\n-           (doall (map\n-                   (fn [rule]\n-                     (let [rhs (:rhs rule)\n-                     ;lhs (:lhs rule)\n-                           cmp (:comparator rule)]\n-                       (case cmp\n-                         \"$geowithin\" (if-let [features (.features rhs)]\n-                                        (if (.hasNext features)\n-                                          (if (relation/within? v (-> features .next .getDefaultGeometry))\n-                                            (handle-success trigger notify)\n-                                            (handle-failure trigger))\n-                                          (handle-failure trigger)))\n-                         nil)))\n-                   (:rules trigger)))))\n-       (keys @invalid-triggers)))\n+  (doall (map (fn [k]\n+                (let [trigger (k @invalid-triggers)]\n+                  (loop [rules (:rules trigger)]","path":"server/src/spacon/components/trigger.clj","position":75,"original_position":75,"commit_id":"988f923a83ddb6a5b118844933fbc2635f7c5af3","original_commit_id":"30547fdb9bfa16f1090e84bf49aadfcfb10b020f","user":{"login":"tetriscode","id":242747,"avatar_url":"https://avatars.githubusercontent.com/u/242747?v=3","gravatar_id":"","url":"https://api.github.com/users/tetriscode","html_url":"https://github.com/tetriscode","followers_url":"https://api.github.com/users/tetriscode/followers","following_url":"https://api.github.com/users/tetriscode/following{/other_user}","gists_url":"https://api.github.com/users/tetriscode/gists{/gist_id}","starred_url":"https://api.github.com/users/tetriscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetriscode/subscriptions","organizations_url":"https://api.github.com/users/tetriscode/orgs","repos_url":"https://api.github.com/users/tetriscode/repos","events_url":"https://api.github.com/users/tetriscode/events{/privacy}","received_events_url":"https://api.github.com/users/tetriscode/received_events","type":"User","site_admin":false},"body":"check for empty set of rules","created_at":"2016-12-12T15:59:54Z","updated_at":"2016-12-12T15:59:54Z","html_url":"https://github.com/boundlessgeo/spatialconnect-server/pull/187#discussion_r91975892","pull_request_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/comments/91975892"},"html":{"href":"https://github.com/boundlessgeo/spatialconnect-server/pull/187#discussion_r91975892"},"pull_request":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187","id":97489373,"html_url":"https://github.com/boundlessgeo/spatialconnect-server/pull/187","diff_url":"https://github.com/boundlessgeo/spatialconnect-server/pull/187.diff","patch_url":"https://github.com/boundlessgeo/spatialconnect-server/pull/187.patch","issue_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/187","number":187,"state":"open","locked":false,"title":"Compound Triggers. Switched FeatureCollection checks to logical OR","user":{"login":"tetriscode","id":242747,"avatar_url":"https://avatars.githubusercontent.com/u/242747?v=3","gravatar_id":"","url":"https://api.github.com/users/tetriscode","html_url":"https://github.com/tetriscode","followers_url":"https://api.github.com/users/tetriscode/followers","following_url":"https://api.github.com/users/tetriscode/following{/other_user}","gists_url":"https://api.github.com/users/tetriscode/gists{/gist_id}","starred_url":"https://api.github.com/users/tetriscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetriscode/subscriptions","organizations_url":"https://api.github.com/users/tetriscode/orgs","repos_url":"https://api.github.com/users/tetriscode/repos","events_url":"https://api.github.com/users/tetriscode/events{/privacy}","received_events_url":"https://api.github.com/users/tetriscode/received_events","type":"User","site_admin":false},"body":"## Status\r\n**READY**\r\n\r\n## JIRA Ticket\r\nSPACON-373\r\n\r\n## Description\r\nTriggers use `recur` instead of map and stop processing when any part of the compound predicate \r\n\r\n## Todos\r\n- [x] Tests\r\n- [x] Documentation\r\n- [x] License\r\n\r\n```sh\r\ngit fetch --all\r\ngit checkout <feature_branch> \r\nnpm test\r\n```\r\n\r\n@boundlessgeo/spatial-connect\r\n","created_at":"2016-12-12T03:21:09Z","updated_at":"2016-12-12T15:59:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"373be54eecf7f76438770eb1df2701f0a1304bc7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187/commits","review_comments_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187/comments","review_comment_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/187/comments","statuses_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/statuses/988f923a83ddb6a5b118844933fbc2635f7c5af3","head":{"label":"tetriscode:trigger-perf","ref":"trigger-perf","sha":"988f923a83ddb6a5b118844933fbc2635f7c5af3","user":{"login":"tetriscode","id":242747,"avatar_url":"https://avatars.githubusercontent.com/u/242747?v=3","gravatar_id":"","url":"https://api.github.com/users/tetriscode","html_url":"https://github.com/tetriscode","followers_url":"https://api.github.com/users/tetriscode/followers","following_url":"https://api.github.com/users/tetriscode/following{/other_user}","gists_url":"https://api.github.com/users/tetriscode/gists{/gist_id}","starred_url":"https://api.github.com/users/tetriscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetriscode/subscriptions","organizations_url":"https://api.github.com/users/tetriscode/orgs","repos_url":"https://api.github.com/users/tetriscode/repos","events_url":"https://api.github.com/users/tetriscode/events{/privacy}","received_events_url":"https://api.github.com/users/tetriscode/received_events","type":"User","site_admin":false},"repo":{"id":71825436,"name":"spatialconnect-server","full_name":"tetriscode/spatialconnect-server","owner":{"login":"tetriscode","id":242747,"avatar_url":"https://avatars.githubusercontent.com/u/242747?v=3","gravatar_id":"","url":"https://api.github.com/users/tetriscode","html_url":"https://github.com/tetriscode","followers_url":"https://api.github.com/users/tetriscode/followers","following_url":"https://api.github.com/users/tetriscode/following{/other_user}","gists_url":"https://api.github.com/users/tetriscode/gists{/gist_id}","starred_url":"https://api.github.com/users/tetriscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetriscode/subscriptions","organizations_url":"https://api.github.com/users/tetriscode/orgs","repos_url":"https://api.github.com/users/tetriscode/repos","events_url":"https://api.github.com/users/tetriscode/events{/privacy}","received_events_url":"https://api.github.com/users/tetriscode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tetriscode/spatialconnect-server","description":null,"fork":true,"url":"https://api.github.com/repos/tetriscode/spatialconnect-server","forks_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/forks","keys_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/teams","hooks_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/hooks","issue_events_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/issues/events{/number}","events_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/events","assignees_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/assignees{/user}","branches_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/branches{/branch}","tags_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/tags","blobs_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/statuses/{sha}","languages_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/languages","stargazers_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/stargazers","contributors_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/contributors","subscribers_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/subscribers","subscription_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/subscription","commits_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/contents/{+path}","compare_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/merges","archive_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/downloads","issues_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/issues{/number}","pulls_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/pulls{/number}","milestones_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/milestones{/number}","notifications_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/labels{/name}","releases_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/releases{/id}","deployments_url":"https://api.github.com/repos/tetriscode/spatialconnect-server/deployments","created_at":"2016-10-24T19:39:56Z","updated_at":"2016-10-24T19:39:57Z","pushed_at":"2016-12-12T03:23:50Z","git_url":"git://github.com/tetriscode/spatialconnect-server.git","ssh_url":"git@github.com:tetriscode/spatialconnect-server.git","clone_url":"https://github.com/tetriscode/spatialconnect-server.git","svn_url":"https://github.com/tetriscode/spatialconnect-server","homepage":null,"size":1144,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boundlessgeo:develop","ref":"develop","sha":"1e9a8929827749738799ef6b2eed7536df91e9e9","user":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars.githubusercontent.com/u/306022?v=3","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":51032237,"name":"spatialconnect-server","full_name":"boundlessgeo/spatialconnect-server","owner":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars.githubusercontent.com/u/306022?v=3","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boundlessgeo/spatialconnect-server","description":null,"fork":false,"url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server","forks_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/forks","keys_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/teams","hooks_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/hooks","issue_events_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/events{/number}","events_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/events","assignees_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/assignees{/user}","branches_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/branches{/branch}","tags_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/tags","blobs_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/statuses/{sha}","languages_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/languages","stargazers_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/stargazers","contributors_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/contributors","subscribers_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/subscribers","subscription_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/subscription","commits_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/contents/{+path}","compare_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/merges","archive_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/downloads","issues_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues{/number}","pulls_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls{/number}","milestones_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/milestones{/number}","notifications_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/labels{/name}","releases_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/releases{/id}","deployments_url":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/deployments","created_at":"2016-02-03T21:35:30Z","updated_at":"2016-12-09T22:32:08Z","pushed_at":"2016-12-12T15:41:04Z","git_url":"git://github.com/boundlessgeo/spatialconnect-server.git","ssh_url":"git@github.com:boundlessgeo/spatialconnect-server.git","clone_url":"https://github.com/boundlessgeo/spatialconnect-server.git","svn_url":"https://github.com/boundlessgeo/spatialconnect-server","homepage":null,"size":1301,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187"},"html":{"href":"https://github.com/boundlessgeo/spatialconnect-server/pull/187"},"issue":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/187"},"comments":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/boundlessgeo/spatialconnect-server/statuses/988f923a83ddb6a5b118844933fbc2635f7c5af3"}}}}
{"actor":{"display_login":"tetriscode"}}