{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/86779852","pull_request_review_id":7418970,"id":86779852,"diff_hunk":"@@ -132,9 +133,12 @@ protected function execute(InputInterface $input, OutputInterface $output)\n         // load any messages from templates\n         $extractedCatalogue = new MessageCatalogue($input->getArgument('locale'));\n         $io->comment('Parsing templates...');\n-        $prefix = $input->getOption('prefix');\n         $extractor = $this->getContainer()->get('translation.extractor');\n-        $extractor->setPrefix(null === $prefix ? '' : $prefix);\n+\n+        if (false === $input->getOption('no-prefix')) {\n+            $extractor->setPrefix(false === $input->getOption('no-prefix') ? $input->getOption('prefix') : '');","path":"src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php","position":17,"original_position":17,"commit_id":"0db7da137125b036f4459e4b4198f3994cb4d2c8","original_commit_id":"0db7da137125b036f4459e4b4198f3994cb4d2c8","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"The `false === $input->getOption('no-prefix')` condition is redundant here?","created_at":"2016-11-07T14:00:28Z","updated_at":"2016-11-07T14:03:13Z","html_url":"https://github.com/symfony/symfony/pull/20432#discussion_r86779852","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20432","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/86779852"},"html":{"href":"https://github.com/symfony/symfony/pull/20432#discussion_r86779852"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20432"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20432","id":92578045,"html_url":"https://github.com/symfony/symfony/pull/20432","diff_url":"https://github.com/symfony/symfony/pull/20432.diff","patch_url":"https://github.com/symfony/symfony/pull/20432.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20432","number":20432,"state":"open","locked":false,"title":"[FrameworkBundle] Add --no-prefix option to translation:update","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | yes\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/issues/20044\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nThis adds an option `--no-prefix` to the `translation:update` command, allowing to use an empty string as prefix. I guess it should be treated as a feature as it adds a new option to the command, but it indeed fixes the bug reported in #20044 (yeah, really this time).","created_at":"2016-11-07T12:54:23Z","updated_at":"2016-11-07T14:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c40b586ee72a274555f3b04b1bd8d33c4a465b96","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20432/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20432/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20432/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/0db7da137125b036f4459e4b4198f3994cb4d2c8","head":{"label":"chalasr:framework/translation-upd-no-prefix-opt","ref":"framework/translation-upd-no-prefix-opt","sha":"0db7da137125b036f4459e4b4198f3994cb4d2c8","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"repo":{"id":56510160,"name":"symfony","full_name":"chalasr/symfony","owner":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalasr/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/chalasr/symfony","forks_url":"https://api.github.com/repos/chalasr/symfony/forks","keys_url":"https://api.github.com/repos/chalasr/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalasr/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalasr/symfony/teams","hooks_url":"https://api.github.com/repos/chalasr/symfony/hooks","issue_events_url":"https://api.github.com/repos/chalasr/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/chalasr/symfony/events","assignees_url":"https://api.github.com/repos/chalasr/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/chalasr/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/chalasr/symfony/tags","blobs_url":"https://api.github.com/repos/chalasr/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalasr/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalasr/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalasr/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalasr/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/chalasr/symfony/languages","stargazers_url":"https://api.github.com/repos/chalasr/symfony/stargazers","contributors_url":"https://api.github.com/repos/chalasr/symfony/contributors","subscribers_url":"https://api.github.com/repos/chalasr/symfony/subscribers","subscription_url":"https://api.github.com/repos/chalasr/symfony/subscription","commits_url":"https://api.github.com/repos/chalasr/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalasr/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalasr/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalasr/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalasr/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/chalasr/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalasr/symfony/merges","archive_url":"https://api.github.com/repos/chalasr/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalasr/symfony/downloads","issues_url":"https://api.github.com/repos/chalasr/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/chalasr/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/chalasr/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/chalasr/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalasr/symfony/labels{/name}","releases_url":"https://api.github.com/repos/chalasr/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/chalasr/symfony/deployments","created_at":"2016-04-18T13:30:14Z","updated_at":"2016-04-18T13:30:30Z","pushed_at":"2016-11-07T12:38:41Z","git_url":"git://github.com/chalasr/symfony.git","ssh_url":"git@github.com:chalasr/symfony.git","clone_url":"https://github.com/chalasr/symfony.git","svn_url":"https://github.com/chalasr/symfony","homepage":"symfony.com","size":74601,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"53b55fca364815b1051fbce897591d708c52d546","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-11-07T10:55:19Z","pushed_at":"2016-11-07T12:54:59Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":139560,"stargazers_count":13234,"watchers_count":13234,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5102,"mirror_url":null,"open_issues_count":797,"forks":5102,"open_issues":797,"watchers":13234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20432"},"html":{"href":"https://github.com/symfony/symfony/pull/20432"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20432"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20432/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20432/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20432/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/0db7da137125b036f4459e4b4198f3994cb4d2c8"}}}}
{"actor":{"display_login":"javiereguiluz"}}