{"action":"created","comment":{"url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/comments/80171727","id":80171727,"diff_hunk":"@@ -42,6 +42,20 @@ declare module \"tsdDef\" {\n     }\n \n     /**\n+     * Interface for classes which create <code>Metrics</code> instances. Clients","path":"src/defs/metrics.d.ts","position":4,"original_position":4,"commit_id":"473cddbc73acf0fee0a4df8715951a4205a342bb","original_commit_id":"473cddbc73acf0fee0a4df8715951a4205a342bb","user":{"login":"vjkoskela","id":1775197,"avatar_url":"https://avatars.githubusercontent.com/u/1775197?v=3","gravatar_id":"","url":"https://api.github.com/users/vjkoskela","html_url":"https://github.com/vjkoskela","followers_url":"https://api.github.com/users/vjkoskela/followers","following_url":"https://api.github.com/users/vjkoskela/following{/other_user}","gists_url":"https://api.github.com/users/vjkoskela/gists{/gist_id}","starred_url":"https://api.github.com/users/vjkoskela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjkoskela/subscriptions","organizations_url":"https://api.github.com/users/vjkoskela/orgs","repos_url":"https://api.github.com/users/vjkoskela/repos","events_url":"https://api.github.com/users/vjkoskela/events{/privacy}","received_events_url":"https://api.github.com/users/vjkoskela/received_events","type":"User","site_admin":false},"body":"Does nodejs support similar html doc generation as java? Or is this just copy-paste? I'm fine continuing the annotations Mohammed has adopted, however, we should remove the html mark-up unless it actually gets used.","created_at":"2016-09-23T02:12:34Z","updated_at":"2016-09-23T02:54:02Z","html_url":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7#discussion_r80171727","pull_request_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/comments/80171727"},"html":{"href":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7#discussion_r80171727"},"pull_request":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7","id":86247445,"html_url":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7","diff_url":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7.diff","patch_url":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7.patch","issue_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/7","number":7,"state":"open","locked":false,"title":"2f","user":{"login":"matthayter","id":2703760,"avatar_url":"https://avatars.githubusercontent.com/u/2703760?v=3","gravatar_id":"","url":"https://api.github.com/users/matthayter","html_url":"https://github.com/matthayter","followers_url":"https://api.github.com/users/matthayter/followers","following_url":"https://api.github.com/users/matthayter/following{/other_user}","gists_url":"https://api.github.com/users/matthayter/gists{/gist_id}","starred_url":"https://api.github.com/users/matthayter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthayter/subscriptions","organizations_url":"https://api.github.com/users/matthayter/orgs","repos_url":"https://api.github.com/users/matthayter/repos","events_url":"https://api.github.com/users/matthayter/events{/privacy}","received_events_url":"https://api.github.com/users/matthayter/received_events","type":"User","site_admin":false},"body":"I'll be building the dimensions work and 2G on top of this.\r\n\r\nTest coverage:\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 99.18% ( 483/487 ), 10 ignored\r\nBranches     : 96.49% ( 110/114 ), 8 ignored\r\nFunctions    : 99.12% ( 113/114 ), 7 ignored\r\nLines        : 99.78% ( 464/465 )\r\n================================================================================\r\n>> Done. Minimum coverage threshold succeeded.\r\n```","created_at":"2016-09-21T21:46:55Z","updated_at":"2016-09-23T02:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b872241ce0a6466fdf8f0871fd0b30a3d676b319","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/7/comments","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/statuses/473cddbc73acf0fee0a4df8715951a4205a342bb","head":{"label":"ArpNetworking:mhayter-2f","ref":"mhayter-2f","sha":"473cddbc73acf0fee0a4df8715951a4205a342bb","user":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":48870403,"name":"metrics-client-nodejs","full_name":"ArpNetworking/metrics-client-nodejs","owner":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArpNetworking/metrics-client-nodejs","description":"","fork":false,"url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs","forks_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/forks","keys_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/teams","hooks_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/hooks","issue_events_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/events","assignees_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/tags","blobs_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/languages","stargazers_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/stargazers","contributors_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/contributors","subscribers_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/subscribers","subscription_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/subscription","commits_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/merges","archive_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/downloads","issues_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/deployments","created_at":"2016-01-01T05:32:56Z","updated_at":"2016-02-10T23:52:01Z","pushed_at":"2016-09-22T20:28:30Z","git_url":"git://github.com/ArpNetworking/metrics-client-nodejs.git","ssh_url":"git@github.com:ArpNetworking/metrics-client-nodejs.git","clone_url":"https://github.com/ArpNetworking/metrics-client-nodejs.git","svn_url":"https://github.com/ArpNetworking/metrics-client-nodejs","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ArpNetworking:master","ref":"master","sha":"89151e5c30ae54d08bb0210417dcefd69c390bfe","user":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":48870403,"name":"metrics-client-nodejs","full_name":"ArpNetworking/metrics-client-nodejs","owner":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArpNetworking/metrics-client-nodejs","description":"","fork":false,"url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs","forks_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/forks","keys_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/teams","hooks_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/hooks","issue_events_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/events","assignees_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/tags","blobs_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/languages","stargazers_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/stargazers","contributors_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/contributors","subscribers_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/subscribers","subscription_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/subscription","commits_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/merges","archive_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/downloads","issues_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/deployments","created_at":"2016-01-01T05:32:56Z","updated_at":"2016-02-10T23:52:01Z","pushed_at":"2016-09-22T20:28:30Z","git_url":"git://github.com/ArpNetworking/metrics-client-nodejs.git","ssh_url":"git@github.com:ArpNetworking/metrics-client-nodejs.git","clone_url":"https://github.com/ArpNetworking/metrics-client-nodejs.git","svn_url":"https://github.com/ArpNetworking/metrics-client-nodejs","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7"},"html":{"href":"https://github.com/ArpNetworking/metrics-client-nodejs/pull/7"},"issue":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/7"},"comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ArpNetworking/metrics-client-nodejs/statuses/473cddbc73acf0fee0a4df8715951a4205a342bb"}}}}
{"actor":{"display_login":"vjkoskela"}}