{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/crossdock/pulls/comments/68150519","id":68150519,"diff_hunk":"@@ -0,0 +1,99 @@\n+// Copyright (c) 2016 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package execute\n+\n+import (\n+\t\"net/http\"\n+\t\"net/http/httptest\"\n+\t\"testing\"\n+\t\"time\"\n+\n+\t\"github.com/stretchr/testify/require\"\n+)\n+\n+type testHandler struct {\n+\tt             *testing.T\n+\tdelay         time.Duration // delay before replying\n+\tnotReadyCount int32         // 500 that many time before returning success.\n+}\n+\n+func (h *testHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {\n+\tt := h.t\n+\tif h.delay != 0 {\n+\t\tt.Logf(\"serverHTTP: Delaying for %v\", h.delay)","path":"execute/wait_test.go","position":41,"original_position":41,"commit_id":"aa43e500cc31a7c66e89e5f8a1bdbd541ce67f3e","original_commit_id":"aa43e500cc31a7c66e89e5f8a1bdbd541ce67f3e","user":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"body":"serveHTTP, not serverHTTP. Although I would name the type here instead (\"testHandler\")","created_at":"2016-06-22T22:59:27Z","updated_at":"2016-06-22T22:59:27Z","html_url":"https://github.com/yarpc/crossdock/pull/65#discussion_r68150519","pull_request_url":"https://api.github.com/repos/yarpc/crossdock/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/comments/68150519"},"html":{"href":"https://github.com/yarpc/crossdock/pull/65#discussion_r68150519"},"pull_request":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/crossdock/pulls/65","id":74505439,"html_url":"https://github.com/yarpc/crossdock/pull/65","diff_url":"https://github.com/yarpc/crossdock/pull/65.diff","patch_url":"https://github.com/yarpc/crossdock/pull/65.patch","issue_url":"https://api.github.com/repos/yarpc/crossdock/issues/65","number":65,"state":"open","locked":false,"title":"Better timeout logic & messages.","user":{"login":"bombela","id":216204,"avatar_url":"https://avatars.githubusercontent.com/u/216204?v=3","gravatar_id":"","url":"https://api.github.com/users/bombela","html_url":"https://github.com/bombela","followers_url":"https://api.github.com/users/bombela/followers","following_url":"https://api.github.com/users/bombela/following{/other_user}","gists_url":"https://api.github.com/users/bombela/gists{/gist_id}","starred_url":"https://api.github.com/users/bombela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bombela/subscriptions","organizations_url":"https://api.github.com/users/bombela/orgs","repos_url":"https://api.github.com/users/bombela/repos","events_url":"https://api.github.com/users/bombela/events{/privacy}","received_events_url":"https://api.github.com/users/bombela/received_events","type":"User","site_admin":false},"body":"The crossdock driver \"HTTP PING\" every other containers before running\nthe tests.\n\nThis adds a smaller sub-timeout of 500ms, making sure that we cancel and\nretry the HTTP HEAD request from scratch during the global wait timeout.\n\nAdditional this fixes few log messages.","created_at":"2016-06-20T20:15:00Z","updated_at":"2016-06-22T22:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d613f543c274ccc3196e1fe22006690078ac4ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/crossdock/pulls/65/commits","review_comments_url":"https://api.github.com/repos/yarpc/crossdock/pulls/65/comments","review_comment_url":"https://api.github.com/repos/yarpc/crossdock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/crossdock/issues/65/comments","statuses_url":"https://api.github.com/repos/yarpc/crossdock/statuses/aa43e500cc31a7c66e89e5f8a1bdbd541ce67f3e","head":{"label":"yarpc:datimeout","ref":"datimeout","sha":"aa43e500cc31a7c66e89e5f8a1bdbd541ce67f3e","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50474051,"name":"crossdock","full_name":"yarpc/crossdock","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/crossdock","description":"A tiny Docker appliance for running cross-repo integration tests","fork":false,"url":"https://api.github.com/repos/yarpc/crossdock","forks_url":"https://api.github.com/repos/yarpc/crossdock/forks","keys_url":"https://api.github.com/repos/yarpc/crossdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/crossdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/crossdock/teams","hooks_url":"https://api.github.com/repos/yarpc/crossdock/hooks","issue_events_url":"https://api.github.com/repos/yarpc/crossdock/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/crossdock/events","assignees_url":"https://api.github.com/repos/yarpc/crossdock/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/crossdock/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/crossdock/tags","blobs_url":"https://api.github.com/repos/yarpc/crossdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/crossdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/crossdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/crossdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/crossdock/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/crossdock/languages","stargazers_url":"https://api.github.com/repos/yarpc/crossdock/stargazers","contributors_url":"https://api.github.com/repos/yarpc/crossdock/contributors","subscribers_url":"https://api.github.com/repos/yarpc/crossdock/subscribers","subscription_url":"https://api.github.com/repos/yarpc/crossdock/subscription","commits_url":"https://api.github.com/repos/yarpc/crossdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/crossdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/crossdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/crossdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/crossdock/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/crossdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/crossdock/merges","archive_url":"https://api.github.com/repos/yarpc/crossdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/crossdock/downloads","issues_url":"https://api.github.com/repos/yarpc/crossdock/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/crossdock/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/crossdock/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/crossdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/crossdock/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/crossdock/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/crossdock/deployments","created_at":"2016-01-27T02:02:28Z","updated_at":"2016-02-20T21:06:04Z","pushed_at":"2016-06-22T22:33:29Z","git_url":"git://github.com/yarpc/crossdock.git","ssh_url":"git@github.com:yarpc/crossdock.git","clone_url":"https://github.com/yarpc/crossdock.git","svn_url":"https://github.com/yarpc/crossdock","homepage":"","size":155,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"yarpc:master","ref":"master","sha":"0fb4aafa2ca54b530b544a415ccdb5bdd8ec7812","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50474051,"name":"crossdock","full_name":"yarpc/crossdock","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/crossdock","description":"A tiny Docker appliance for running cross-repo integration tests","fork":false,"url":"https://api.github.com/repos/yarpc/crossdock","forks_url":"https://api.github.com/repos/yarpc/crossdock/forks","keys_url":"https://api.github.com/repos/yarpc/crossdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/crossdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/crossdock/teams","hooks_url":"https://api.github.com/repos/yarpc/crossdock/hooks","issue_events_url":"https://api.github.com/repos/yarpc/crossdock/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/crossdock/events","assignees_url":"https://api.github.com/repos/yarpc/crossdock/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/crossdock/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/crossdock/tags","blobs_url":"https://api.github.com/repos/yarpc/crossdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/crossdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/crossdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/crossdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/crossdock/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/crossdock/languages","stargazers_url":"https://api.github.com/repos/yarpc/crossdock/stargazers","contributors_url":"https://api.github.com/repos/yarpc/crossdock/contributors","subscribers_url":"https://api.github.com/repos/yarpc/crossdock/subscribers","subscription_url":"https://api.github.com/repos/yarpc/crossdock/subscription","commits_url":"https://api.github.com/repos/yarpc/crossdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/crossdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/crossdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/crossdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/crossdock/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/crossdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/crossdock/merges","archive_url":"https://api.github.com/repos/yarpc/crossdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/crossdock/downloads","issues_url":"https://api.github.com/repos/yarpc/crossdock/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/crossdock/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/crossdock/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/crossdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/crossdock/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/crossdock/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/crossdock/deployments","created_at":"2016-01-27T02:02:28Z","updated_at":"2016-02-20T21:06:04Z","pushed_at":"2016-06-22T22:33:29Z","git_url":"git://github.com/yarpc/crossdock.git","ssh_url":"git@github.com:yarpc/crossdock.git","clone_url":"https://github.com/yarpc/crossdock.git","svn_url":"https://github.com/yarpc/crossdock","homepage":"","size":155,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/65"},"html":{"href":"https://github.com/yarpc/crossdock/pull/65"},"issue":{"href":"https://api.github.com/repos/yarpc/crossdock/issues/65"},"comments":{"href":"https://api.github.com/repos/yarpc/crossdock/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/crossdock/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/crossdock/statuses/aa43e500cc31a7c66e89e5f8a1bdbd541ce67f3e"}}}}
{"actor":{"display_login":"abhinav"}}