{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/sartaj/riot-animate/pulls/3","id":95151521,"html_url":"https://github.com/sartaj/riot-animate/pull/3","diff_url":"https://github.com/sartaj/riot-animate/pull/3.diff","patch_url":"https://github.com/sartaj/riot-animate/pull/3.patch","issue_url":"https://api.github.com/repos/sartaj/riot-animate/issues/3","number":3,"state":"open","locked":false,"title":"added removeEventListener after the tag is unmounted ","user":{"login":"no-wa-ke","id":6639567,"avatar_url":"https://avatars.githubusercontent.com/u/6639567?v=3","gravatar_id":"","url":"https://api.github.com/users/no-wa-ke","html_url":"https://github.com/no-wa-ke","followers_url":"https://api.github.com/users/no-wa-ke/followers","following_url":"https://api.github.com/users/no-wa-ke/following{/other_user}","gists_url":"https://api.github.com/users/no-wa-ke/gists{/gist_id}","starred_url":"https://api.github.com/users/no-wa-ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-wa-ke/subscriptions","organizations_url":"https://api.github.com/users/no-wa-ke/orgs","repos_url":"https://api.github.com/users/no-wa-ke/repos","events_url":"https://api.github.com/users/no-wa-ke/events{/privacy}","received_events_url":"https://api.github.com/users/no-wa-ke/received_events","type":"User","site_admin":false},"body":"When the root tag is re-mounted (like using router and stuff), the unmounted function in animatedUnmount was still called by eventlistener. \r\n\r\nThis is just a temporal fix: I added  removeEventListeners  right after animation tag is unmounted","created_at":"2016-11-24T10:24:01Z","updated_at":"2016-11-24T10:24:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sartaj/riot-animate/pulls/3/commits","review_comments_url":"https://api.github.com/repos/sartaj/riot-animate/pulls/3/comments","review_comment_url":"https://api.github.com/repos/sartaj/riot-animate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sartaj/riot-animate/issues/3/comments","statuses_url":"https://api.github.com/repos/sartaj/riot-animate/statuses/3af6a283e16cfdcada46d4fc31703b86ad8f343b","head":{"label":"no-wa-ke:fixing-event-problem","ref":"fixing-event-problem","sha":"3af6a283e16cfdcada46d4fc31703b86ad8f343b","user":{"login":"no-wa-ke","id":6639567,"avatar_url":"https://avatars.githubusercontent.com/u/6639567?v=3","gravatar_id":"","url":"https://api.github.com/users/no-wa-ke","html_url":"https://github.com/no-wa-ke","followers_url":"https://api.github.com/users/no-wa-ke/followers","following_url":"https://api.github.com/users/no-wa-ke/following{/other_user}","gists_url":"https://api.github.com/users/no-wa-ke/gists{/gist_id}","starred_url":"https://api.github.com/users/no-wa-ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-wa-ke/subscriptions","organizations_url":"https://api.github.com/users/no-wa-ke/orgs","repos_url":"https://api.github.com/users/no-wa-ke/repos","events_url":"https://api.github.com/users/no-wa-ke/events{/privacy}","received_events_url":"https://api.github.com/users/no-wa-ke/received_events","type":"User","site_admin":false},"repo":{"id":74658599,"name":"riot-animate","full_name":"no-wa-ke/riot-animate","owner":{"login":"no-wa-ke","id":6639567,"avatar_url":"https://avatars.githubusercontent.com/u/6639567?v=3","gravatar_id":"","url":"https://api.github.com/users/no-wa-ke","html_url":"https://github.com/no-wa-ke","followers_url":"https://api.github.com/users/no-wa-ke/followers","following_url":"https://api.github.com/users/no-wa-ke/following{/other_user}","gists_url":"https://api.github.com/users/no-wa-ke/gists{/gist_id}","starred_url":"https://api.github.com/users/no-wa-ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-wa-ke/subscriptions","organizations_url":"https://api.github.com/users/no-wa-ke/orgs","repos_url":"https://api.github.com/users/no-wa-ke/repos","events_url":"https://api.github.com/users/no-wa-ke/events{/privacy}","received_events_url":"https://api.github.com/users/no-wa-ke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/no-wa-ke/riot-animate","description":"Animate Riot 2","fork":true,"url":"https://api.github.com/repos/no-wa-ke/riot-animate","forks_url":"https://api.github.com/repos/no-wa-ke/riot-animate/forks","keys_url":"https://api.github.com/repos/no-wa-ke/riot-animate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/no-wa-ke/riot-animate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/no-wa-ke/riot-animate/teams","hooks_url":"https://api.github.com/repos/no-wa-ke/riot-animate/hooks","issue_events_url":"https://api.github.com/repos/no-wa-ke/riot-animate/issues/events{/number}","events_url":"https://api.github.com/repos/no-wa-ke/riot-animate/events","assignees_url":"https://api.github.com/repos/no-wa-ke/riot-animate/assignees{/user}","branches_url":"https://api.github.com/repos/no-wa-ke/riot-animate/branches{/branch}","tags_url":"https://api.github.com/repos/no-wa-ke/riot-animate/tags","blobs_url":"https://api.github.com/repos/no-wa-ke/riot-animate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/no-wa-ke/riot-animate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/no-wa-ke/riot-animate/git/refs{/sha}","trees_url":"https://api.github.com/repos/no-wa-ke/riot-animate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/no-wa-ke/riot-animate/statuses/{sha}","languages_url":"https://api.github.com/repos/no-wa-ke/riot-animate/languages","stargazers_url":"https://api.github.com/repos/no-wa-ke/riot-animate/stargazers","contributors_url":"https://api.github.com/repos/no-wa-ke/riot-animate/contributors","subscribers_url":"https://api.github.com/repos/no-wa-ke/riot-animate/subscribers","subscription_url":"https://api.github.com/repos/no-wa-ke/riot-animate/subscription","commits_url":"https://api.github.com/repos/no-wa-ke/riot-animate/commits{/sha}","git_commits_url":"https://api.github.com/repos/no-wa-ke/riot-animate/git/commits{/sha}","comments_url":"https://api.github.com/repos/no-wa-ke/riot-animate/comments{/number}","issue_comment_url":"https://api.github.com/repos/no-wa-ke/riot-animate/issues/comments{/number}","contents_url":"https://api.github.com/repos/no-wa-ke/riot-animate/contents/{+path}","compare_url":"https://api.github.com/repos/no-wa-ke/riot-animate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/no-wa-ke/riot-animate/merges","archive_url":"https://api.github.com/repos/no-wa-ke/riot-animate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/no-wa-ke/riot-animate/downloads","issues_url":"https://api.github.com/repos/no-wa-ke/riot-animate/issues{/number}","pulls_url":"https://api.github.com/repos/no-wa-ke/riot-animate/pulls{/number}","milestones_url":"https://api.github.com/repos/no-wa-ke/riot-animate/milestones{/number}","notifications_url":"https://api.github.com/repos/no-wa-ke/riot-animate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/no-wa-ke/riot-animate/labels{/name}","releases_url":"https://api.github.com/repos/no-wa-ke/riot-animate/releases{/id}","deployments_url":"https://api.github.com/repos/no-wa-ke/riot-animate/deployments","created_at":"2016-11-24T09:35:55Z","updated_at":"2016-11-24T09:35:56Z","pushed_at":"2016-11-24T10:04:25Z","git_url":"git://github.com/no-wa-ke/riot-animate.git","ssh_url":"git@github.com:no-wa-ke/riot-animate.git","clone_url":"https://github.com/no-wa-ke/riot-animate.git","svn_url":"https://github.com/no-wa-ke/riot-animate","homepage":"http://sartaj.github.io/riot-animate","size":672,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sartaj:master","ref":"master","sha":"4335043c039146be216e78fb7d73f824d933db04","user":{"login":"sartaj","id":1682557,"avatar_url":"https://avatars.githubusercontent.com/u/1682557?v=3","gravatar_id":"","url":"https://api.github.com/users/sartaj","html_url":"https://github.com/sartaj","followers_url":"https://api.github.com/users/sartaj/followers","following_url":"https://api.github.com/users/sartaj/following{/other_user}","gists_url":"https://api.github.com/users/sartaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sartaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sartaj/subscriptions","organizations_url":"https://api.github.com/users/sartaj/orgs","repos_url":"https://api.github.com/users/sartaj/repos","events_url":"https://api.github.com/users/sartaj/events{/privacy}","received_events_url":"https://api.github.com/users/sartaj/received_events","type":"User","site_admin":false},"repo":{"id":40219202,"name":"riot-animate","full_name":"sartaj/riot-animate","owner":{"login":"sartaj","id":1682557,"avatar_url":"https://avatars.githubusercontent.com/u/1682557?v=3","gravatar_id":"","url":"https://api.github.com/users/sartaj","html_url":"https://github.com/sartaj","followers_url":"https://api.github.com/users/sartaj/followers","following_url":"https://api.github.com/users/sartaj/following{/other_user}","gists_url":"https://api.github.com/users/sartaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sartaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sartaj/subscriptions","organizations_url":"https://api.github.com/users/sartaj/orgs","repos_url":"https://api.github.com/users/sartaj/repos","events_url":"https://api.github.com/users/sartaj/events{/privacy}","received_events_url":"https://api.github.com/users/sartaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sartaj/riot-animate","description":"Animate Riot 2","fork":false,"url":"https://api.github.com/repos/sartaj/riot-animate","forks_url":"https://api.github.com/repos/sartaj/riot-animate/forks","keys_url":"https://api.github.com/repos/sartaj/riot-animate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sartaj/riot-animate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sartaj/riot-animate/teams","hooks_url":"https://api.github.com/repos/sartaj/riot-animate/hooks","issue_events_url":"https://api.github.com/repos/sartaj/riot-animate/issues/events{/number}","events_url":"https://api.github.com/repos/sartaj/riot-animate/events","assignees_url":"https://api.github.com/repos/sartaj/riot-animate/assignees{/user}","branches_url":"https://api.github.com/repos/sartaj/riot-animate/branches{/branch}","tags_url":"https://api.github.com/repos/sartaj/riot-animate/tags","blobs_url":"https://api.github.com/repos/sartaj/riot-animate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sartaj/riot-animate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sartaj/riot-animate/git/refs{/sha}","trees_url":"https://api.github.com/repos/sartaj/riot-animate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sartaj/riot-animate/statuses/{sha}","languages_url":"https://api.github.com/repos/sartaj/riot-animate/languages","stargazers_url":"https://api.github.com/repos/sartaj/riot-animate/stargazers","contributors_url":"https://api.github.com/repos/sartaj/riot-animate/contributors","subscribers_url":"https://api.github.com/repos/sartaj/riot-animate/subscribers","subscription_url":"https://api.github.com/repos/sartaj/riot-animate/subscription","commits_url":"https://api.github.com/repos/sartaj/riot-animate/commits{/sha}","git_commits_url":"https://api.github.com/repos/sartaj/riot-animate/git/commits{/sha}","comments_url":"https://api.github.com/repos/sartaj/riot-animate/comments{/number}","issue_comment_url":"https://api.github.com/repos/sartaj/riot-animate/issues/comments{/number}","contents_url":"https://api.github.com/repos/sartaj/riot-animate/contents/{+path}","compare_url":"https://api.github.com/repos/sartaj/riot-animate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sartaj/riot-animate/merges","archive_url":"https://api.github.com/repos/sartaj/riot-animate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sartaj/riot-animate/downloads","issues_url":"https://api.github.com/repos/sartaj/riot-animate/issues{/number}","pulls_url":"https://api.github.com/repos/sartaj/riot-animate/pulls{/number}","milestones_url":"https://api.github.com/repos/sartaj/riot-animate/milestones{/number}","notifications_url":"https://api.github.com/repos/sartaj/riot-animate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sartaj/riot-animate/labels{/name}","releases_url":"https://api.github.com/repos/sartaj/riot-animate/releases{/id}","deployments_url":"https://api.github.com/repos/sartaj/riot-animate/deployments","created_at":"2015-08-05T02:05:47Z","updated_at":"2016-11-17T13:46:35Z","pushed_at":"2016-11-24T10:24:01Z","git_url":"git://github.com/sartaj/riot-animate.git","ssh_url":"git@github.com:sartaj/riot-animate.git","clone_url":"https://github.com/sartaj/riot-animate.git","svn_url":"https://github.com/sartaj/riot-animate","homepage":"http://sartaj.github.io/riot-animate","size":672,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sartaj/riot-animate/pulls/3"},"html":{"href":"https://github.com/sartaj/riot-animate/pull/3"},"issue":{"href":"https://api.github.com/repos/sartaj/riot-animate/issues/3"},"comments":{"href":"https://api.github.com/repos/sartaj/riot-animate/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/sartaj/riot-animate/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/sartaj/riot-animate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sartaj/riot-animate/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/sartaj/riot-animate/statuses/3af6a283e16cfdcada46d4fc31703b86ad8f343b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":276330,"deletions":1,"changed_files":1959}}
{"actor":{"display_login":"no-wa-ke"}}