{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/recog/issues/107","repository_url":"https://api.github.com/repos/rapid7/recog","labels_url":"https://api.github.com/repos/rapid7/recog/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/recog/issues/107/comments","events_url":"https://api.github.com/repos/rapid7/recog/issues/107/events","html_url":"https://github.com/rapid7/recog/pull/107","id":144525012,"number":107,"title":"SMB banners for VisionFS and OS/400","user":{"login":"jkennedy-r7","id":12800364,"avatar_url":"https://avatars.githubusercontent.com/u/12800364?v=3","gravatar_id":"","url":"https://api.github.com/users/jkennedy-r7","html_url":"https://github.com/jkennedy-r7","followers_url":"https://api.github.com/users/jkennedy-r7/followers","following_url":"https://api.github.com/users/jkennedy-r7/following{/other_user}","gists_url":"https://api.github.com/users/jkennedy-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jkennedy-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkennedy-r7/subscriptions","organizations_url":"https://api.github.com/users/jkennedy-r7/orgs","repos_url":"https://api.github.com/users/jkennedy-r7/repos","events_url":"https://api.github.com/users/jkennedy-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jkennedy-r7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-30T09:58:18Z","updated_at":"2016-04-20T13:48:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/recog/pulls/107","html_url":"https://github.com/rapid7/recog/pull/107","diff_url":"https://github.com/rapid7/recog/pull/107.diff","patch_url":"https://github.com/rapid7/recog/pull/107.patch"},"body":"Banners for VisionFS and OS/400\r\n\r\nAccording to our code comments VisionFS returns [AR][OS][VFVR] which is arch, os and VisionFS version. The remainder of the visionFS banner contains the \"uname -a\" output, such as: `[abbrev] [uname -a output...`:\r\n```\r\ni3un0210 UnixWare unixware7 5 7 i386\r\n```\r\n\r\nAfter discussion within the team, we decided to error on the safe side and only match on the [abbrev].\r\n\r\nRSpec output:\r\n```rspec\r\nFinished in 53.32 seconds (files took 1.9 seconds to load)\r\n17868 examples, 0 failures\r\n\r\nRandomized with seed 64103\r\n\r\n/opt/ruby2.2/lib/ruby/gems/2.2.0/gems/simplecov-0.10.0/lib/simplecov/defaults.rb:50: warning: global variable `$ERROR_INFO' not initialized\r\nCoverage report generated for RSpec to /home/jkennedy/rapid7/recog/coverage. 690 / 722 LOC (95.57%) covered.\r\n```"},"comment":{"url":"https://api.github.com/repos/rapid7/recog/issues/comments/212432520","html_url":"https://github.com/rapid7/recog/pull/107#issuecomment-212432520","issue_url":"https://api.github.com/repos/rapid7/recog/issues/107","id":212432520,"user":{"login":"jhart-r7","id":3869433,"avatar_url":"https://avatars.githubusercontent.com/u/3869433?v=3","gravatar_id":"","url":"https://api.github.com/users/jhart-r7","html_url":"https://github.com/jhart-r7","followers_url":"https://api.github.com/users/jhart-r7/followers","following_url":"https://api.github.com/users/jhart-r7/following{/other_user}","gists_url":"https://api.github.com/users/jhart-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jhart-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhart-r7/subscriptions","organizations_url":"https://api.github.com/users/jhart-r7/orgs","repos_url":"https://api.github.com/users/jhart-r7/repos","events_url":"https://api.github.com/users/jhart-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jhart-r7/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T13:48:45Z","updated_at":"2016-04-20T13:48:45Z","body":"Looks good to me.  \r\n\r\nRegarding the `uname` stuff, to be clear, I'm saying that _something else_, **not recog**, should probably parse this `uname` output when it detects a VisionFS-based SMB instance.  To allow this to happen, you could capture it now, store it as, say, `smb.visionfs.uname_stuff` and then recog's data/interface's will return the `uname` output to you if you add it as a capture in your regex."}}