{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/comments/71000056","id":71000056,"diff_hunk":"@@ -85,7 +85,12 @@ void IWcfTelemetryModule.OnEndRequest(IOperationContext operation, Message reply\n                 responseCode = HttpStatusCode.InternalServerError;\n             }\n \n-            telemetry.Success = !isFault;\n+            // if the operation code has already marked the request as failed\n+            // don't overwrite the value if we think it was successful\n+            if ( isFault || !telemetry.Success.HasValue )\n+            {\n+                telemetry.Success = !isFault;\n+            }\n             telemetry.ResponseCode = responseCode.ToString(\"d\");","path":"WCF/Shared/RequestTrackingTelemetryModule.cs","position":11,"original_position":11,"commit_id":"ed58772b5b13514eb16e017b3870443416fb827c","original_commit_id":"ed58772b5b13514eb16e017b3870443416fb827c","user":{"login":"SergeyKanzhelev","id":9950081,"avatar_url":"https://avatars.githubusercontent.com/u/9950081?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyKanzhelev","html_url":"https://github.com/SergeyKanzhelev","followers_url":"https://api.github.com/users/SergeyKanzhelev/followers","following_url":"https://api.github.com/users/SergeyKanzhelev/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKanzhelev/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKanzhelev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKanzhelev/subscriptions","organizations_url":"https://api.github.com/users/SergeyKanzhelev/orgs","repos_url":"https://api.github.com/users/SergeyKanzhelev/repos","events_url":"https://api.github.com/users/SergeyKanzhelev/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKanzhelev/received_events","type":"User","site_admin":false},"body":"Do you want to allow similar logic here - not override if already set by user?","created_at":"2016-07-15T16:20:35Z","updated_at":"2016-07-15T16:20:35Z","html_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26#discussion_r71000056","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/comments/71000056"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26#discussion_r71000056"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26","id":77614706,"html_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26","diff_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/26","number":26,"state":"open","locked":false,"title":"Add option to mark WCF request as failed","user":{"login":"tomasr","id":16179,"avatar_url":"https://avatars.githubusercontent.com/u/16179?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasr","html_url":"https://github.com/tomasr","followers_url":"https://api.github.com/users/tomasr/followers","following_url":"https://api.github.com/users/tomasr/following{/other_user}","gists_url":"https://api.github.com/users/tomasr/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasr/subscriptions","organizations_url":"https://api.github.com/users/tomasr/orgs","repos_url":"https://api.github.com/users/tomasr/repos","events_url":"https://api.github.com/users/tomasr/events{/privacy}","received_events_url":"https://api.github.com/users/tomasr/received_events","type":"User","site_admin":false},"body":"This change updates documentation, and also checks that the customer code has not set `RequestTelemetry.Success` before overwriting the value. Related to issue https://github.com/Microsoft/ApplicationInsights-SDK-Labs/issues/25","created_at":"2016-07-15T13:22:38Z","updated_at":"2016-07-15T16:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4572bacd963c14b757401ec9903e00b8ce94996","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/26/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/statuses/ed58772b5b13514eb16e017b3870443416fb827c","head":{"label":"tomasr:WcfRequestFailed","ref":"WcfRequestFailed","sha":"ed58772b5b13514eb16e017b3870443416fb827c","user":{"login":"tomasr","id":16179,"avatar_url":"https://avatars.githubusercontent.com/u/16179?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasr","html_url":"https://github.com/tomasr","followers_url":"https://api.github.com/users/tomasr/followers","following_url":"https://api.github.com/users/tomasr/following{/other_user}","gists_url":"https://api.github.com/users/tomasr/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasr/subscriptions","organizations_url":"https://api.github.com/users/tomasr/orgs","repos_url":"https://api.github.com/users/tomasr/repos","events_url":"https://api.github.com/users/tomasr/events{/privacy}","received_events_url":"https://api.github.com/users/tomasr/received_events","type":"User","site_admin":false},"repo":{"id":52403009,"name":"ApplicationInsights-SDK-Labs","full_name":"tomasr/ApplicationInsights-SDK-Labs","owner":{"login":"tomasr","id":16179,"avatar_url":"https://avatars.githubusercontent.com/u/16179?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasr","html_url":"https://github.com/tomasr","followers_url":"https://api.github.com/users/tomasr/followers","following_url":"https://api.github.com/users/tomasr/following{/other_user}","gists_url":"https://api.github.com/users/tomasr/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasr/subscriptions","organizations_url":"https://api.github.com/users/tomasr/orgs","repos_url":"https://api.github.com/users/tomasr/repos","events_url":"https://api.github.com/users/tomasr/events{/privacy}","received_events_url":"https://api.github.com/users/tomasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomasr/ApplicationInsights-SDK-Labs","description":"Application Insights experimental projects repository","fork":true,"url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs","forks_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/forks","keys_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/teams","hooks_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/hooks","issue_events_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/issues/events{/number}","events_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/events","assignees_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/assignees{/user}","branches_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/branches{/branch}","tags_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/tags","blobs_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/statuses/{sha}","languages_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/languages","stargazers_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/stargazers","contributors_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/contributors","subscribers_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/subscribers","subscription_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/subscription","commits_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/contents/{+path}","compare_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/merges","archive_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/downloads","issues_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/issues{/number}","pulls_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/pulls{/number}","milestones_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/milestones{/number}","notifications_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/labels{/name}","releases_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/releases{/id}","deployments_url":"https://api.github.com/repos/tomasr/ApplicationInsights-SDK-Labs/deployments","created_at":"2016-02-24T00:53:10Z","updated_at":"2016-02-24T00:53:11Z","pushed_at":"2016-07-15T13:21:09Z","git_url":"git://github.com/tomasr/ApplicationInsights-SDK-Labs.git","ssh_url":"git@github.com:tomasr/ApplicationInsights-SDK-Labs.git","clone_url":"https://github.com/tomasr/ApplicationInsights-SDK-Labs.git","svn_url":"https://github.com/tomasr/ApplicationInsights-SDK-Labs","homepage":null,"size":1807,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"c81a53f163095e0f3a392e4a5b37c71f59739ceb","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":34921357,"name":"ApplicationInsights-SDK-Labs","full_name":"Microsoft/ApplicationInsights-SDK-Labs","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs","description":"Application Insights experimental projects repository","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/deployments","created_at":"2015-05-01T19:59:20Z","updated_at":"2016-06-18T23:33:26Z","pushed_at":"2016-07-15T13:22:38Z","git_url":"git://github.com/Microsoft/ApplicationInsights-SDK-Labs.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-SDK-Labs.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs","homepage":null,"size":1828,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-SDK-Labs/pull/26"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/26"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-SDK-Labs/statuses/ed58772b5b13514eb16e017b3870443416fb827c"}}}}
{"actor":{"display_login":"SergeyKanzhelev"}}