{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1415","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1415/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1415/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1415/events","html_url":"https://github.com/Microsoft/visualfsharp/pull/1415","id":170526286,"number":1415,"title":"[WIP] Added PEVerifyBuiltAssembly target to build","user":{"login":"otawfik-ms","id":15987992,"avatar_url":"https://avatars.githubusercontent.com/u/15987992?v=3","gravatar_id":"","url":"https://api.github.com/users/otawfik-ms","html_url":"https://github.com/otawfik-ms","followers_url":"https://api.github.com/users/otawfik-ms/followers","following_url":"https://api.github.com/users/otawfik-ms/following{/other_user}","gists_url":"https://api.github.com/users/otawfik-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/otawfik-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otawfik-ms/subscriptions","organizations_url":"https://api.github.com/users/otawfik-ms/orgs","repos_url":"https://api.github.com/users/otawfik-ms/repos","events_url":"https://api.github.com/users/otawfik-ms/events{/privacy}","received_events_url":"https://api.github.com/users/otawfik-ms/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/cla-not-required","name":"cla-not-required","color":"90EE90"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-10T21:44:33Z","updated_at":"2016-08-11T23:31:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1415","html_url":"https://github.com/Microsoft/visualfsharp/pull/1415","diff_url":"https://github.com/Microsoft/visualfsharp/pull/1415.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/1415.patch"},"body":"Fixing PEVerify errors in master branch in order."},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/239324212","html_url":"https://github.com/Microsoft/visualfsharp/pull/1415#issuecomment-239324212","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1415","id":239324212,"user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T23:31:04Z","updated_at":"2016-08-11T23:31:04Z","body":"I think I can take care of it.\n\nFrom: Don Syme\nSent: Thursday, August 11, 2016 4:30 PM\nTo: Kevin Ransom <Kevin.Ransom@microsoft.com>; Microsoft/visualfsharp <reply@reply.github.com>; Microsoft/visualfsharp <visualfsharp@noreply.github.com>; Omar Tawfik <otawfik@microsoft.com>\nSubject: RE: [Microsoft/visualfsharp] [WIP] Added PEVerifyBuiltAssembly target to build (#1415)\n\nThese are just using the win32 API for memory mapped files I think. We could likely switch to the standard .net wrappers for these\n\nSent from my Windows 10 phone\n\nFrom: Kevin Ransom<mailto:Kevin.Ransom@microsoft.com>\nSent: 12 August 2016 00:19\nTo: Microsoft/visualfsharp<mailto:reply@reply.github.com>; Microsoft/visualfsharp<mailto:visualfsharp@noreply.github.com>; Omar Tawfik<mailto:otawfik@microsoft.com>; Don Syme<mailto:Don.Syme@microsoft.com>\nSubject: RE: [Microsoft/visualfsharp] [WIP] Added PEVerifyBuiltAssembly target to build (#1415)\n\n@Omar Tawfik<mailto:otawfik@microsoft.com> @Don Syme<mailto:Don.Syme@microsoft.com>\n\nI know what is going on ... I don't have a fix yet, but I do know what it looks like.  PR to follow.\n\n\nKevin\n\nFrom: Omar Tawfik [mailto:notifications@github.com]\nSent: Thursday, August 11, 2016 2:28 PM\nTo: Microsoft/visualfsharp <visualfsharp@noreply.github.com<mailto:visualfsharp@noreply.github.com>>\nSubject: Re: [Microsoft/visualfsharp] [WIP] Added PEVerifyBuiltAssembly target to build (#1415)\n\n\n@dsyme<https://github.com/dsyme> I recently added this target because I found a few peverify errors in our assemblies. The current plan is to identify/fix the errors one by one in this branch, then finally turn on the check in master.\nI found a few errors related to byref returns. Can you please tell me if this is related to your recent changes?\nExample:\n[IL]: Error: [C:\\projects\\visualfsharp-3dtit\\Proto\\net40\\bin\\FSharp.Compiler-proto.dll : Microsoft.FSharp.Compiler.AbstractIL.ILBinaryReader+MemoryMappedFile::ReadByte][offset 0x0000000C][found Native Int] Expected ByRef on the stack.\n[IL]: Error: [C:\\projects\\visualfsharp-3dtit\\Proto\\net40\\bin\\FSharp.Compiler-proto.dll : Microsoft.FSharp.Compiler.AbstractIL.ILBinaryReader+MemoryMappedFile::ReadInt32][offset 0x0000000A][found Native Int] Expected ByRef on the stack.\n[IL]: Error: [C:\\projects\\visualfsharp-3dtit\\Proto\\net40\\bin\\FSharp.Compiler-proto.dll : Microsoft.FSharp.Compiler.AbstractIL.ILBinaryReader+MemoryMappedFile::ReadUInt16][offset 0x0000000A][found Native Int] Expected ByRef on the stack.\n\n-\nYou are receiving this because you are subscribed to this thread.\nReply to this email directly, view it on GitHub<https://github.com/Microsoft/visualfsharp/pull/1415#issuecomment-239298304>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE76Fts8-xj1xk1Gtd2EYuWKCM_it6gJks5qe5PVgaJpZM4Jhm_c>.\n"}}
{"actor":{"display_login":"KevinRansom"}}