{"action":"created","comment":{"url":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments/61154989","id":61154989,"diff_hunk":"@@ -158,17 +158,29 @@ public function findFeedDate(SimpleXMLElement $xml, Feed $feed)\n     }\n \n     /**\n-     * Find the item date.\n+     * Find the item published date.\n      *\n      * @param SimpleXMLElement      $entry Feed item\n      * @param Item                  $item  Item object\n      * @param \\PicoFeed\\Parser\\Feed $feed  Feed object\n      */\n-    public function findItemDate(SimpleXMLElement $entry, Item $item, Feed $feed)\n+    public function findItemPublishedDate(SimpleXMLElement $entry, Item $item, Feed $feed)\n     {\n         $date = XmlParser::getXPathResult($entry, 'dc:date', $this->namespaces);\n \n-        $item->setDate(empty($date) ? $feed->getDate() : $this->getDateParser()->getDateTime(XmlParser::getValue($date)));\n+        $item->setPublishedDate(!empty($date) ? $this->getDateParser()->getDateTime(XmlParser::getValue($date)) : null);\n+    }\n+\n+    /**\n+     * Find the item updated date.\n+     *\n+     * @param SimpleXMLElement      $entry Feed item\n+     * @param Item                  $item  Item object\n+     * @param \\PicoFeed\\Parser\\Feed $feed  Feed object\n+     */\n+    public function findItemUpdatedDate(SimpleXMLElement $entry, Item $item, Feed $feed)\n+    {\n+        $item->setUpdatedDate(null); // No updated date in RSS 1.0 specifications","path":"lib/PicoFeed/Parser/Rss10.php","position":null,"original_position":29,"commit_id":"3ddad9adfc0c08e4b9d447b897ce901c26ced464","original_commit_id":"3f4f61225b5a0e47532c2ee98738f44a284e5dad","user":{"login":"crazy-max","id":1951866,"avatar_url":"https://avatars.githubusercontent.com/u/1951866?v=3","gravatar_id":"","url":"https://api.github.com/users/crazy-max","html_url":"https://github.com/crazy-max","followers_url":"https://api.github.com/users/crazy-max/followers","following_url":"https://api.github.com/users/crazy-max/following{/other_user}","gists_url":"https://api.github.com/users/crazy-max/gists{/gist_id}","starred_url":"https://api.github.com/users/crazy-max/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazy-max/subscriptions","organizations_url":"https://api.github.com/users/crazy-max/orgs","repos_url":"https://api.github.com/users/crazy-max/repos","events_url":"https://api.github.com/users/crazy-max/events{/privacy}","received_events_url":"https://api.github.com/users/crazy-max/received_events","type":"User","site_admin":false},"body":"Ahahah yes why not but i prefer to wait the merge like you o:)","created_at":"2016-04-26T20:08:10Z","updated_at":"2016-04-26T20:08:10Z","html_url":"https://github.com/fguillot/picoFeed/pull/268#discussion_r61154989","pull_request_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments/61154989"},"html":{"href":"https://github.com/fguillot/picoFeed/pull/268#discussion_r61154989"},"pull_request":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/fguillot/picoFeed/pulls/268","id":67616623,"html_url":"https://github.com/fguillot/picoFeed/pull/268","diff_url":"https://github.com/fguillot/picoFeed/pull/268.diff","patch_url":"https://github.com/fguillot/picoFeed/pull/268.patch","issue_url":"https://api.github.com/repos/fguillot/picoFeed/issues/268","number":268,"state":"open","locked":false,"title":"Add item published and updated date","user":{"login":"crazy-max","id":1951866,"avatar_url":"https://avatars.githubusercontent.com/u/1951866?v=3","gravatar_id":"","url":"https://api.github.com/users/crazy-max","html_url":"https://github.com/crazy-max","followers_url":"https://api.github.com/users/crazy-max/followers","following_url":"https://api.github.com/users/crazy-max/following{/other_user}","gists_url":"https://api.github.com/users/crazy-max/gists{/gist_id}","starred_url":"https://api.github.com/users/crazy-max/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazy-max/subscriptions","organizations_url":"https://api.github.com/users/crazy-max/orgs","repos_url":"https://api.github.com/users/crazy-max/repos","events_url":"https://api.github.com/users/crazy-max/events{/privacy}","received_events_url":"https://api.github.com/users/crazy-max/received_events","type":"User","site_admin":false},"body":"Linked to Issue #267 ","created_at":"2016-04-23T19:49:07Z","updated_at":"2016-04-26T20:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb38cc6a91718a1332e0b961446ff83498ef4d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/268/commits","review_comments_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/268/comments","review_comment_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fguillot/picoFeed/issues/268/comments","statuses_url":"https://api.github.com/repos/fguillot/picoFeed/statuses/3ddad9adfc0c08e4b9d447b897ce901c26ced464","head":{"label":"crazy-max:master","ref":"master","sha":"3ddad9adfc0c08e4b9d447b897ce901c26ced464","user":{"login":"crazy-max","id":1951866,"avatar_url":"https://avatars.githubusercontent.com/u/1951866?v=3","gravatar_id":"","url":"https://api.github.com/users/crazy-max","html_url":"https://github.com/crazy-max","followers_url":"https://api.github.com/users/crazy-max/followers","following_url":"https://api.github.com/users/crazy-max/following{/other_user}","gists_url":"https://api.github.com/users/crazy-max/gists{/gist_id}","starred_url":"https://api.github.com/users/crazy-max/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazy-max/subscriptions","organizations_url":"https://api.github.com/users/crazy-max/orgs","repos_url":"https://api.github.com/users/crazy-max/repos","events_url":"https://api.github.com/users/crazy-max/events{/privacy}","received_events_url":"https://api.github.com/users/crazy-max/received_events","type":"User","site_admin":false},"repo":{"id":56930233,"name":"picoFeed","full_name":"crazy-max/picoFeed","owner":{"login":"crazy-max","id":1951866,"avatar_url":"https://avatars.githubusercontent.com/u/1951866?v=3","gravatar_id":"","url":"https://api.github.com/users/crazy-max","html_url":"https://github.com/crazy-max","followers_url":"https://api.github.com/users/crazy-max/followers","following_url":"https://api.github.com/users/crazy-max/following{/other_user}","gists_url":"https://api.github.com/users/crazy-max/gists{/gist_id}","starred_url":"https://api.github.com/users/crazy-max/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazy-max/subscriptions","organizations_url":"https://api.github.com/users/crazy-max/orgs","repos_url":"https://api.github.com/users/crazy-max/repos","events_url":"https://api.github.com/users/crazy-max/events{/privacy}","received_events_url":"https://api.github.com/users/crazy-max/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crazy-max/picoFeed","description":"PHP library to parse and write RSS/Atom feeds","fork":true,"url":"https://api.github.com/repos/crazy-max/picoFeed","forks_url":"https://api.github.com/repos/crazy-max/picoFeed/forks","keys_url":"https://api.github.com/repos/crazy-max/picoFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crazy-max/picoFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crazy-max/picoFeed/teams","hooks_url":"https://api.github.com/repos/crazy-max/picoFeed/hooks","issue_events_url":"https://api.github.com/repos/crazy-max/picoFeed/issues/events{/number}","events_url":"https://api.github.com/repos/crazy-max/picoFeed/events","assignees_url":"https://api.github.com/repos/crazy-max/picoFeed/assignees{/user}","branches_url":"https://api.github.com/repos/crazy-max/picoFeed/branches{/branch}","tags_url":"https://api.github.com/repos/crazy-max/picoFeed/tags","blobs_url":"https://api.github.com/repos/crazy-max/picoFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crazy-max/picoFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crazy-max/picoFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/crazy-max/picoFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crazy-max/picoFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/crazy-max/picoFeed/languages","stargazers_url":"https://api.github.com/repos/crazy-max/picoFeed/stargazers","contributors_url":"https://api.github.com/repos/crazy-max/picoFeed/contributors","subscribers_url":"https://api.github.com/repos/crazy-max/picoFeed/subscribers","subscription_url":"https://api.github.com/repos/crazy-max/picoFeed/subscription","commits_url":"https://api.github.com/repos/crazy-max/picoFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/crazy-max/picoFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/crazy-max/picoFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/crazy-max/picoFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/crazy-max/picoFeed/contents/{+path}","compare_url":"https://api.github.com/repos/crazy-max/picoFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crazy-max/picoFeed/merges","archive_url":"https://api.github.com/repos/crazy-max/picoFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crazy-max/picoFeed/downloads","issues_url":"https://api.github.com/repos/crazy-max/picoFeed/issues{/number}","pulls_url":"https://api.github.com/repos/crazy-max/picoFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/crazy-max/picoFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/crazy-max/picoFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crazy-max/picoFeed/labels{/name}","releases_url":"https://api.github.com/repos/crazy-max/picoFeed/releases{/id}","deployments_url":"https://api.github.com/repos/crazy-max/picoFeed/deployments","created_at":"2016-04-23T16:51:46Z","updated_at":"2016-04-23T16:51:47Z","pushed_at":"2016-04-26T20:04:15Z","git_url":"git://github.com/crazy-max/picoFeed.git","ssh_url":"git@github.com:crazy-max/picoFeed.git","clone_url":"https://github.com/crazy-max/picoFeed.git","svn_url":"https://github.com/crazy-max/picoFeed","homepage":"","size":2526,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fguillot:master","ref":"master","sha":"1d3e0c8aab576e140e064d88ca9b0f29fe0316b3","user":{"login":"fguillot","id":323546,"avatar_url":"https://avatars.githubusercontent.com/u/323546?v=3","gravatar_id":"","url":"https://api.github.com/users/fguillot","html_url":"https://github.com/fguillot","followers_url":"https://api.github.com/users/fguillot/followers","following_url":"https://api.github.com/users/fguillot/following{/other_user}","gists_url":"https://api.github.com/users/fguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/fguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fguillot/subscriptions","organizations_url":"https://api.github.com/users/fguillot/orgs","repos_url":"https://api.github.com/users/fguillot/repos","events_url":"https://api.github.com/users/fguillot/events{/privacy}","received_events_url":"https://api.github.com/users/fguillot/received_events","type":"User","site_admin":false},"repo":{"id":8106011,"name":"picoFeed","full_name":"fguillot/picoFeed","owner":{"login":"fguillot","id":323546,"avatar_url":"https://avatars.githubusercontent.com/u/323546?v=3","gravatar_id":"","url":"https://api.github.com/users/fguillot","html_url":"https://github.com/fguillot","followers_url":"https://api.github.com/users/fguillot/followers","following_url":"https://api.github.com/users/fguillot/following{/other_user}","gists_url":"https://api.github.com/users/fguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/fguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fguillot/subscriptions","organizations_url":"https://api.github.com/users/fguillot/orgs","repos_url":"https://api.github.com/users/fguillot/repos","events_url":"https://api.github.com/users/fguillot/events{/privacy}","received_events_url":"https://api.github.com/users/fguillot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fguillot/picoFeed","description":"PHP library to parse and write RSS/Atom feeds","fork":false,"url":"https://api.github.com/repos/fguillot/picoFeed","forks_url":"https://api.github.com/repos/fguillot/picoFeed/forks","keys_url":"https://api.github.com/repos/fguillot/picoFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fguillot/picoFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fguillot/picoFeed/teams","hooks_url":"https://api.github.com/repos/fguillot/picoFeed/hooks","issue_events_url":"https://api.github.com/repos/fguillot/picoFeed/issues/events{/number}","events_url":"https://api.github.com/repos/fguillot/picoFeed/events","assignees_url":"https://api.github.com/repos/fguillot/picoFeed/assignees{/user}","branches_url":"https://api.github.com/repos/fguillot/picoFeed/branches{/branch}","tags_url":"https://api.github.com/repos/fguillot/picoFeed/tags","blobs_url":"https://api.github.com/repos/fguillot/picoFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fguillot/picoFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fguillot/picoFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/fguillot/picoFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fguillot/picoFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/fguillot/picoFeed/languages","stargazers_url":"https://api.github.com/repos/fguillot/picoFeed/stargazers","contributors_url":"https://api.github.com/repos/fguillot/picoFeed/contributors","subscribers_url":"https://api.github.com/repos/fguillot/picoFeed/subscribers","subscription_url":"https://api.github.com/repos/fguillot/picoFeed/subscription","commits_url":"https://api.github.com/repos/fguillot/picoFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/fguillot/picoFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/fguillot/picoFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/fguillot/picoFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/fguillot/picoFeed/contents/{+path}","compare_url":"https://api.github.com/repos/fguillot/picoFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fguillot/picoFeed/merges","archive_url":"https://api.github.com/repos/fguillot/picoFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fguillot/picoFeed/downloads","issues_url":"https://api.github.com/repos/fguillot/picoFeed/issues{/number}","pulls_url":"https://api.github.com/repos/fguillot/picoFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/fguillot/picoFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/fguillot/picoFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fguillot/picoFeed/labels{/name}","releases_url":"https://api.github.com/repos/fguillot/picoFeed/releases{/id}","deployments_url":"https://api.github.com/repos/fguillot/picoFeed/deployments","created_at":"2013-02-09T04:16:49Z","updated_at":"2016-04-25T18:22:00Z","pushed_at":"2016-04-26T20:04:17Z","git_url":"git://github.com/fguillot/picoFeed.git","ssh_url":"git@github.com:fguillot/picoFeed.git","clone_url":"https://github.com/fguillot/picoFeed.git","svn_url":"https://github.com/fguillot/picoFeed","homepage":"","size":2958,"stargazers_count":282,"watchers_count":282,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":24,"forks":70,"open_issues":24,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/268"},"html":{"href":"https://github.com/fguillot/picoFeed/pull/268"},"issue":{"href":"https://api.github.com/repos/fguillot/picoFeed/issues/268"},"comments":{"href":"https://api.github.com/repos/fguillot/picoFeed/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/fguillot/picoFeed/statuses/3ddad9adfc0c08e4b9d447b897ce901c26ced464"}}}}