{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26016","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26016/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26016/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26016/events","html_url":"https://github.com/kubernetes/kubernetes/pull/26016","id":156110000,"number":26016,"title":"integration.go: remove scheduler phantom pod test","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-merge","name":"needs-ok-to-merge","color":"ededed"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2016-05-21T16:26:28Z","updated_at":"2016-05-22T19:13:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26016","html_url":"https://github.com/kubernetes/kubernetes/pull/26016","diff_url":"https://github.com/kubernetes/kubernetes/pull/26016.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26016.patch"},"body":"This is an effort for #24440.\r\n\r\nWhy this PR?\r\n- Integration test is hard to debug. We could model the test as a unit test similar to [TestSchedulerForgetAssumedPodAfterDelete()](https://github.com/kubernetes/kubernetes/blob/132ebb091af3b625df0ad19a5975119e800bebef/plugin/pkg/scheduler/scheduler_test.go#L173). Currently the test is testing expiring case, we can change that to delete.\r\n- Add a test similar to TestSchedulerForgetAssumedPodAfterDelete() to test phantom pod.\r\n- refactor scheduler tests to share the code between TestSchedulerNoPhantomPodAfterExpire() and TestSchedulerNoPhantomPodAfterDelete()\r\n- Decouple scheduler tests from scheduler events: not to use events"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/220850247","html_url":"https://github.com/kubernetes/kubernetes/pull/26016#issuecomment-220850247","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26016","id":220850247,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T19:13:29Z","updated_at":"2016-05-22T19:13:29Z","body":"GCE e2e build/test **passed** for commit 46d96c9e7f3af899dca25582332cf25d9f039db2.\n* [Build Log](http://pr-test.k8s.io/26016/kubernetes-pull-build-test-e2e-gce/41353/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/26016/kubernetes-pull-build-test-e2e-gce/41353/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//41353)\n"}}
{"actor":{"display_login":"k8s-bot"}}