{"action":"closed","number":2550,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/2550","id":55286393,"html_url":"https://github.com/dotnet/coreclr/pull/2550","diff_url":"https://github.com/dotnet/coreclr/pull/2550.diff","patch_url":"https://github.com/dotnet/coreclr/pull/2550.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/2550","number":2550,"state":"closed","locked":false,"title":"Initial version of the inline tree","user":{"login":"AndyAyersMS","id":10121823,"avatar_url":"https://avatars.githubusercontent.com/u/10121823?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"body":"Extend `inlExpLst` to to describe the full inlining tree in a method, with a\r\ncorresponding dump method.\r\n\r\nAdd a top-level tree node to serve as the root of the tree. Set this as the\r\ninline context for all top-level expressions. Update the code that links in new\r\nnodes when there is a successful inline to build the tree links. Since the\r\nchild list is extended by a prepend and candidates are currently visited in\r\nlexical (increasing \"local\" IL offset) order, the child list ends up reversed.\r\nThe dumper prints the list entries from back to front to compensate so the tree\r\ndisplay reflects lexical order.\r\n\r\nCapture IL offset to help in identifying call sites. Note this is incomplete and\r\noffets are often missing copies of the parent's offset. Will work on improving\r\nthis subsequently.\r\n\r\nUpdate the depth check to return the depth. This is currently only used in\r\ndiagnostic messages.\r\n\r\nRemove some unused inlining-related data members from the compiler class. Cache\r\nthe `JitPrintInlinedMethods` config value and use it to dump the tree when\r\ninlining is done, if there were any inlines.\r\n\r\nThe jit traditionally (and probably inadvertently) allowed one level of\r\nrecursive inlining. Added a test case showing how this can happen.\r\n\r\nBecause there is now a top-level inlining context, the recursion check can now\r\npotentially detect and block these recursive inlines. Support legacy behavior\r\nfor now by setting `ixlCode` to `nullptr` in the top-level record.\r\n\r\nThis change should be no diff.\r\n\r\nSample output:\r\n```\r\nInlines into Enumerable:Where(ref,ref):ref\r\n  [IL=3] Error:ArgumentNull(ref):ref\r\n  [IL=17] Error:ArgumentNull(ref):ref\r\n  [IL=?] WhereArrayIterator`1:.ctor(ref,ref):this\r\n    [IL=?] Iterator`1:.ctor():this\r\n      [IL=?] Object:.ctor():this\r\n      [IL=?] Environment:get_CurrentManagedThreadId():int\r\n        [IL=?] Thread:get_CurrentThread():ref\r\n  [IL=?] WhereListIterator`1:.ctor(ref,ref):this\r\n    [IL=?] Iterator`1:.ctor():this\r\n      [IL=?] Object:.ctor():this\r\n      [IL=?] Environment:get_CurrentManagedThreadId():int\r\n        [IL=?] Thread:get_CurrentThread():ref\r\n  [IL=?] WhereEnumerableIterator`1:.ctor(ref,ref):this\r\n    [IL=?] Iterator`1:.ctor():this\r\n      [IL=?] Object:.ctor():this\r\n      [IL=?] Environment:get_CurrentManagedThreadId():int\r\n        [IL=?] Thread:get_CurrentThread():ref\r\n```\r\nSample showing the recursive inline:\r\n```\r\nInlines into Fact:factRx(int,int,int,int):int\r\n  [IL=6] Fact:factRx(int,int,int,int):int\r\n```","created_at":"2016-01-07T00:46:58Z","updated_at":"2016-01-08T18:09:40Z","closed_at":"2016-01-08T18:09:40Z","merged_at":"2016-01-08T18:09:40Z","merge_commit_sha":"d0e8c2f467780aebfaac75adcc978cddc7a15a45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2550/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2550/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/2550/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/b6ed20b4c0ba3bf877a305c44864a32786e905ea","head":{"label":"AndyAyersMS:InlineTree","ref":"InlineTree","sha":"b6ed20b4c0ba3bf877a305c44864a32786e905ea","user":{"login":"AndyAyersMS","id":10121823,"avatar_url":"https://avatars.githubusercontent.com/u/10121823?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"repo":{"id":34692475,"name":"coreclr","full_name":"AndyAyersMS/coreclr","owner":{"login":"AndyAyersMS","id":10121823,"avatar_url":"https://avatars.githubusercontent.com/u/10121823?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndyAyersMS/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/AndyAyersMS/coreclr","forks_url":"https://api.github.com/repos/AndyAyersMS/coreclr/forks","keys_url":"https://api.github.com/repos/AndyAyersMS/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndyAyersMS/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndyAyersMS/coreclr/teams","hooks_url":"https://api.github.com/repos/AndyAyersMS/coreclr/hooks","issue_events_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/AndyAyersMS/coreclr/events","assignees_url":"https://api.github.com/repos/AndyAyersMS/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/AndyAyersMS/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/AndyAyersMS/coreclr/tags","blobs_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndyAyersMS/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/AndyAyersMS/coreclr/languages","stargazers_url":"https://api.github.com/repos/AndyAyersMS/coreclr/stargazers","contributors_url":"https://api.github.com/repos/AndyAyersMS/coreclr/contributors","subscribers_url":"https://api.github.com/repos/AndyAyersMS/coreclr/subscribers","subscription_url":"https://api.github.com/repos/AndyAyersMS/coreclr/subscription","commits_url":"https://api.github.com/repos/AndyAyersMS/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndyAyersMS/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndyAyersMS/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/AndyAyersMS/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndyAyersMS/coreclr/merges","archive_url":"https://api.github.com/repos/AndyAyersMS/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndyAyersMS/coreclr/downloads","issues_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/AndyAyersMS/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/AndyAyersMS/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/AndyAyersMS/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndyAyersMS/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/AndyAyersMS/coreclr/releases{/id}","created_at":"2015-04-27T21:34:06Z","updated_at":"2015-04-29T23:48:15Z","pushed_at":"2016-01-08T18:07:56Z","git_url":"git://github.com/AndyAyersMS/coreclr.git","ssh_url":"git@github.com:AndyAyersMS/coreclr.git","clone_url":"https://github.com/AndyAyersMS/coreclr.git","svn_url":"https://github.com/AndyAyersMS/coreclr","homepage":"","size":48898,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a7a79de1e4491b9c3a2a69665183f62024752172","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-01-08T14:56:47Z","pushed_at":"2016-01-08T18:09:40Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":52372,"stargazers_count":5646,"watchers_count":5646,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1226,"mirror_url":null,"open_issues_count":482,"forks":1226,"open_issues":482,"watchers":5646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2550"},"html":{"href":"https://github.com/dotnet/coreclr/pull/2550"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2550"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2550/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2550/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2550/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/b6ed20b4c0ba3bf877a305c44864a32786e905ea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AndyAyersMS","id":10121823,"avatar_url":"https://avatars.githubusercontent.com/u/10121823?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"comments":9,"review_comments":6,"commits":1,"additions":229,"deletions":27,"changed_files":6}}