{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/coreos/go-systemd/pulls/166","id":72529727,"html_url":"https://github.com/coreos/go-systemd/pull/166","diff_url":"https://github.com/coreos/go-systemd/pull/166.diff","patch_url":"https://github.com/coreos/go-systemd/pull/166.patch","issue_url":"https://api.github.com/repos/coreos/go-systemd/issues/166","number":166,"state":"closed","locked":false,"title":"sdjournal: fix error mgmt in NewJournalFromDir","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"body":"Errors were previously hidden. With this patch, I can see the following\r\nerror:\r\n\r\n> $ ./client_example\r\n> rpc error: code = 2 desc = \"error resolving symbol \\\"sd_journal_next\\\": .2: undefined symbol: sd_journal_next\"\r\n\r\nReproducible steps on https://github.com/coreos/rkt/issues/2740. This is\r\nnot solving the symbol issue, but at least, the error is not hidden.","created_at":"2016-06-03T15:56:12Z","updated_at":"2016-06-05T18:23:13Z","closed_at":"2016-06-05T18:23:13Z","merged_at":null,"merge_commit_sha":"f531f0065853a04d3be561dc40bf30ef30ab34fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/go-systemd/pulls/166/commits","review_comments_url":"https://api.github.com/repos/coreos/go-systemd/pulls/166/comments","review_comment_url":"https://api.github.com/repos/coreos/go-systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/go-systemd/issues/166/comments","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/b425c8665e07f0212e675f4403d98b76b92a2af2","head":{"label":"kinvolk:alban/NewJournalFromDir-err-mgmt","ref":"alban/NewJournalFromDir-err-mgmt","sha":"b425c8665e07f0212e675f4403d98b76b92a2af2","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":48180290,"name":"go-systemd","full_name":"kinvolk/go-systemd","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/go-systemd","description":"Go bindings to systemd socket activation, journal, D-Bus, and unit files","fork":true,"url":"https://api.github.com/repos/kinvolk/go-systemd","forks_url":"https://api.github.com/repos/kinvolk/go-systemd/forks","keys_url":"https://api.github.com/repos/kinvolk/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/go-systemd/teams","hooks_url":"https://api.github.com/repos/kinvolk/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/go-systemd/events","assignees_url":"https://api.github.com/repos/kinvolk/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/go-systemd/tags","blobs_url":"https://api.github.com/repos/kinvolk/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/go-systemd/languages","stargazers_url":"https://api.github.com/repos/kinvolk/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/go-systemd/subscription","commits_url":"https://api.github.com/repos/kinvolk/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/go-systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/go-systemd/merges","archive_url":"https://api.github.com/repos/kinvolk/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/go-systemd/downloads","issues_url":"https://api.github.com/repos/kinvolk/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/go-systemd/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/go-systemd/deployments","created_at":"2015-12-17T14:53:48Z","updated_at":"2015-12-17T14:53:49Z","pushed_at":"2016-06-03T16:58:26Z","git_url":"git://github.com/kinvolk/go-systemd.git","ssh_url":"git@github.com:kinvolk/go-systemd.git","clone_url":"https://github.com/kinvolk/go-systemd.git","svn_url":"https://github.com/kinvolk/go-systemd","homepage":"","size":318,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"4484981625c1a6a2ecb40a390fcb6a9bcfee76e3","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":12821303,"name":"go-systemd","full_name":"coreos/go-systemd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/go-systemd","description":"Go bindings to systemd socket activation, journal, D-Bus, and unit files","fork":false,"url":"https://api.github.com/repos/coreos/go-systemd","forks_url":"https://api.github.com/repos/coreos/go-systemd/forks","keys_url":"https://api.github.com/repos/coreos/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/go-systemd/teams","hooks_url":"https://api.github.com/repos/coreos/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/coreos/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/go-systemd/events","assignees_url":"https://api.github.com/repos/coreos/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/go-systemd/tags","blobs_url":"https://api.github.com/repos/coreos/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/go-systemd/languages","stargazers_url":"https://api.github.com/repos/coreos/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/coreos/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/coreos/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/coreos/go-systemd/subscription","commits_url":"https://api.github.com/repos/coreos/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/go-systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/go-systemd/merges","archive_url":"https://api.github.com/repos/coreos/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/go-systemd/downloads","issues_url":"https://api.github.com/repos/coreos/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/go-systemd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/go-systemd/deployments","created_at":"2013-09-13T23:13:51Z","updated_at":"2016-06-01T11:35:08Z","pushed_at":"2016-06-05T08:46:11Z","git_url":"git://github.com/coreos/go-systemd.git","ssh_url":"git@github.com:coreos/go-systemd.git","clone_url":"https://github.com/coreos/go-systemd.git","svn_url":"https://github.com/coreos/go-systemd","homepage":"","size":520,"stargazers_count":270,"watchers_count":270,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":16,"forks":89,"open_issues":16,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/166"},"html":{"href":"https://github.com/coreos/go-systemd/pull/166"},"issue":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/166"},"comments":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/go-systemd/statuses/b425c8665e07f0212e675f4403d98b76b92a2af2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":4,"commits":1,"additions":10,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"alban"}}