{"action":"closed","number":2990,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990","id":92121956,"html_url":"https://github.com/DataDog/dd-agent/pull/2990","diff_url":"https://github.com/DataDog/dd-agent/pull/2990.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2990.patch","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2990","number":2990,"state":"closed","locked":false,"title":"[kubernetes] add image_name and image_tag to container metrics","user":{"login":"tarvip","id":1782293,"avatar_url":"https://avatars.githubusercontent.com/u/1782293?v=3","gravatar_id":"","url":"https://api.github.com/users/tarvip","html_url":"https://github.com/tarvip","followers_url":"https://api.github.com/users/tarvip/followers","following_url":"https://api.github.com/users/tarvip/following{/other_user}","gists_url":"https://api.github.com/users/tarvip/gists{/gist_id}","starred_url":"https://api.github.com/users/tarvip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarvip/subscriptions","organizations_url":"https://api.github.com/users/tarvip/orgs","repos_url":"https://api.github.com/users/tarvip/repos","events_url":"https://api.github.com/users/tarvip/events{/privacy}","received_events_url":"https://api.github.com/users/tarvip/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThis PR adds additional tags `image_name` and `image_tag` to container metrics collected by kubernetes check.\r\n\r\n### Motivation\r\n\r\nAt the moment you can have docker and kubernetes container metrics on same graph only if you have exact container_name, but container_names are auto generated and are changing frequently, `image_name` is more stable, but at the moment these tags are missing in kubernetes check.\r\n\r\nThese tags are collected in docker_daemon check, so this adds option to display kubernetes and docker container metrics on same graph if using `image_name` filter/tag.\r\n\r\nFor example one use case is to compare container level cpu requests/limit values (collected in kubernetes check) to current cpu usage (collected in docker_daemon, although cpu usage is also collected in kubernetes check, it is not very accurate).\r\n\r\n### Testing Guidelines\r\n\r\nRelevant tests have been updated.","created_at":"2016-11-03T09:59:37Z","updated_at":"2016-12-07T14:00:34Z","closed_at":"2016-12-07T14:00:34Z","merged_at":"2016-12-07T14:00:34Z","merge_commit_sha":"325c6cae241d10c373cd7843b46626818bfdc524","assignee":{"login":"hkaj","id":5287287,"avatar_url":"https://avatars.githubusercontent.com/u/5287287?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaj","html_url":"https://github.com/hkaj","followers_url":"https://api.github.com/users/hkaj/followers","following_url":"https://api.github.com/users/hkaj/following{/other_user}","gists_url":"https://api.github.com/users/hkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaj/subscriptions","organizations_url":"https://api.github.com/users/hkaj/orgs","repos_url":"https://api.github.com/users/hkaj/repos","events_url":"https://api.github.com/users/hkaj/events{/privacy}","received_events_url":"https://api.github.com/users/hkaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"hkaj","id":5287287,"avatar_url":"https://avatars.githubusercontent.com/u/5287287?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaj","html_url":"https://github.com/hkaj","followers_url":"https://api.github.com/users/hkaj/followers","following_url":"https://api.github.com/users/hkaj/following{/other_user}","gists_url":"https://api.github.com/users/hkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaj/subscriptions","organizations_url":"https://api.github.com/users/hkaj/orgs","repos_url":"https://api.github.com/users/hkaj/repos","events_url":"https://api.github.com/users/hkaj/events{/privacy}","received_events_url":"https://api.github.com/users/hkaj/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/76","html_url":"https://github.com/DataDog/dd-agent/milestones/5.11.0","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/76/labels","id":2085757,"number":76,"title":"5.11.0","description":"","creator":{"login":"olivielpeau","id":4912500,"avatar_url":"https://avatars.githubusercontent.com/u/4912500?v=3","gravatar_id":"","url":"https://api.github.com/users/olivielpeau","html_url":"https://github.com/olivielpeau","followers_url":"https://api.github.com/users/olivielpeau/followers","following_url":"https://api.github.com/users/olivielpeau/following{/other_user}","gists_url":"https://api.github.com/users/olivielpeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olivielpeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivielpeau/subscriptions","organizations_url":"https://api.github.com/users/olivielpeau/orgs","repos_url":"https://api.github.com/users/olivielpeau/repos","events_url":"https://api.github.com/users/olivielpeau/events{/privacy}","received_events_url":"https://api.github.com/users/olivielpeau/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":31,"state":"open","created_at":"2016-10-21T19:48:58Z","updated_at":"2016-12-07T14:00:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2990/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/3f489367b7f90674385047f2efbf3f0748c57980","head":{"label":"tarvip:kubernetes-tags","ref":"kubernetes-tags","sha":"3f489367b7f90674385047f2efbf3f0748c57980","user":{"login":"tarvip","id":1782293,"avatar_url":"https://avatars.githubusercontent.com/u/1782293?v=3","gravatar_id":"","url":"https://api.github.com/users/tarvip","html_url":"https://github.com/tarvip","followers_url":"https://api.github.com/users/tarvip/followers","following_url":"https://api.github.com/users/tarvip/following{/other_user}","gists_url":"https://api.github.com/users/tarvip/gists{/gist_id}","starred_url":"https://api.github.com/users/tarvip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarvip/subscriptions","organizations_url":"https://api.github.com/users/tarvip/orgs","repos_url":"https://api.github.com/users/tarvip/repos","events_url":"https://api.github.com/users/tarvip/events{/privacy}","received_events_url":"https://api.github.com/users/tarvip/received_events","type":"User","site_admin":false},"repo":{"id":72727649,"name":"dd-agent","full_name":"tarvip/dd-agent","owner":{"login":"tarvip","id":1782293,"avatar_url":"https://avatars.githubusercontent.com/u/1782293?v=3","gravatar_id":"","url":"https://api.github.com/users/tarvip","html_url":"https://github.com/tarvip","followers_url":"https://api.github.com/users/tarvip/followers","following_url":"https://api.github.com/users/tarvip/following{/other_user}","gists_url":"https://api.github.com/users/tarvip/gists{/gist_id}","starred_url":"https://api.github.com/users/tarvip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarvip/subscriptions","organizations_url":"https://api.github.com/users/tarvip/orgs","repos_url":"https://api.github.com/users/tarvip/repos","events_url":"https://api.github.com/users/tarvip/events{/privacy}","received_events_url":"https://api.github.com/users/tarvip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarvip/dd-agent","description":"Datadog Agent","fork":true,"url":"https://api.github.com/repos/tarvip/dd-agent","forks_url":"https://api.github.com/repos/tarvip/dd-agent/forks","keys_url":"https://api.github.com/repos/tarvip/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarvip/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarvip/dd-agent/teams","hooks_url":"https://api.github.com/repos/tarvip/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/tarvip/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/tarvip/dd-agent/events","assignees_url":"https://api.github.com/repos/tarvip/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/tarvip/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/tarvip/dd-agent/tags","blobs_url":"https://api.github.com/repos/tarvip/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarvip/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarvip/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarvip/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarvip/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/tarvip/dd-agent/languages","stargazers_url":"https://api.github.com/repos/tarvip/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/tarvip/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/tarvip/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/tarvip/dd-agent/subscription","commits_url":"https://api.github.com/repos/tarvip/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarvip/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarvip/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarvip/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarvip/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/tarvip/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarvip/dd-agent/merges","archive_url":"https://api.github.com/repos/tarvip/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarvip/dd-agent/downloads","issues_url":"https://api.github.com/repos/tarvip/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/tarvip/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/tarvip/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/tarvip/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarvip/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/tarvip/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/tarvip/dd-agent/deployments","created_at":"2016-11-03T09:09:24Z","updated_at":"2016-11-03T09:09:27Z","pushed_at":"2016-11-03T17:46:54Z","git_url":"git://github.com/tarvip/dd-agent.git","ssh_url":"git@github.com:tarvip/dd-agent.git","clone_url":"https://github.com/tarvip/dd-agent.git","svn_url":"https://github.com/tarvip/dd-agent","homepage":"https://docs.datadoghq.com/","size":39980,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"1d673687d3fbca13e42b6d77289e7ff7858fad54","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":1210071,"name":"dd-agent","full_name":"DataDog/dd-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-agent","description":"Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/dd-agent","forks_url":"https://api.github.com/repos/DataDog/dd-agent/forks","keys_url":"https://api.github.com/repos/DataDog/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-agent/events","assignees_url":"https://api.github.com/repos/DataDog/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-agent/merges","archive_url":"https://api.github.com/repos/DataDog/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-agent/deployments","created_at":"2010-12-31T03:02:47Z","updated_at":"2016-12-07T13:36:36Z","pushed_at":"2016-12-07T14:00:34Z","git_url":"git://github.com/DataDog/dd-agent.git","ssh_url":"git@github.com:DataDog/dd-agent.git","clone_url":"https://github.com/DataDog/dd-agent.git","svn_url":"https://github.com/DataDog/dd-agent","homepage":"https://docs.datadoghq.com/","size":52570,"stargazers_count":685,"watchers_count":685,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":629,"mirror_url":null,"open_issues_count":233,"forks":629,"open_issues":233,"watchers":685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/2990"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2990"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2990/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2990/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-agent/statuses/3f489367b7f90674385047f2efbf3f0748c57980"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hkaj","id":5287287,"avatar_url":"https://avatars.githubusercontent.com/u/5287287?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaj","html_url":"https://github.com/hkaj","followers_url":"https://api.github.com/users/hkaj/followers","following_url":"https://api.github.com/users/hkaj/following{/other_user}","gists_url":"https://api.github.com/users/hkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaj/subscriptions","organizations_url":"https://api.github.com/users/hkaj/orgs","repos_url":"https://api.github.com/users/hkaj/repos","events_url":"https://api.github.com/users/hkaj/events{/privacy}","received_events_url":"https://api.github.com/users/hkaj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"hkaj"}}