{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/76226123","id":76226123,"diff_hunk":"@@ -135,6 +141,21 @@ def expire_topbar_cache(sweeper)\n     role.usergroups.each { |g| g.expire_topbar_cache(sweeper) }\n   end\n \n+  def disable_overriding!\n+    self.override = false\n+    self.save!\n+  end\n+\n+  def inherit_taxonomies\n+    inherit_taxonomies! unless self.override?","path":"app/models/filter.rb","position":48,"original_position":48,"commit_id":"9d01f0a39dc5ea86ce36075d57c77ce6b92e6a58","original_commit_id":"9d01f0a39dc5ea86ce36075d57c77ce6b92e6a58","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"body":"The reasoning is the follow:\r\n\r\n* The method isn't used (YAGNI, dead code)\r\n* The rest of the code cares about 'override' inconsistently. Case in point: when I uncheck 'override', taxonomies are not disassociated from the filter object (and it's fine, they don't matter at that point)\r\n* If someone calls `inherit_taxonomies!`, they will add any checks that are needed. The `!` is there for something.\r\n* Single responsibility - this code does more than just `inherit_taxonomies`, it's checking a flag that ","created_at":"2016-08-25T11:31:16Z","updated_at":"2016-08-25T11:31:16Z","html_url":"https://github.com/theforeman/foreman/pull/3704#discussion_r76226123","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3704","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/76226123"},"html":{"href":"https://github.com/theforeman/foreman/pull/3704#discussion_r76226123"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3704"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3704","id":80056769,"html_url":"https://github.com/theforeman/foreman/pull/3704","diff_url":"https://github.com/theforeman/foreman/pull/3704.diff","patch_url":"https://github.com/theforeman/foreman/pull/3704.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3704","number":3704,"state":"open","locked":false,"title":"Fixes #7806 - allow taxonomy association on role level","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-04T10:42:08Z","updated_at":"2016-08-25T11:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb803bfdfb63ec858b0cb234d23ef3022cf93ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3704/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3704/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3704/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/9d01f0a39dc5ea86ce36075d57c77ce6b92e6a58","head":{"label":"ares:fix/7806","ref":"fix/7806","sha":"9d01f0a39dc5ea86ce36075d57c77ce6b92e6a58","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"repo":{"id":8576886,"name":"foreman","full_name":"ares/foreman","owner":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ares/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ares/foreman","forks_url":"https://api.github.com/repos/ares/foreman/forks","keys_url":"https://api.github.com/repos/ares/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ares/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ares/foreman/teams","hooks_url":"https://api.github.com/repos/ares/foreman/hooks","issue_events_url":"https://api.github.com/repos/ares/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ares/foreman/events","assignees_url":"https://api.github.com/repos/ares/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ares/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ares/foreman/tags","blobs_url":"https://api.github.com/repos/ares/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ares/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ares/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ares/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ares/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ares/foreman/languages","stargazers_url":"https://api.github.com/repos/ares/foreman/stargazers","contributors_url":"https://api.github.com/repos/ares/foreman/contributors","subscribers_url":"https://api.github.com/repos/ares/foreman/subscribers","subscription_url":"https://api.github.com/repos/ares/foreman/subscription","commits_url":"https://api.github.com/repos/ares/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ares/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ares/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ares/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ares/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ares/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ares/foreman/merges","archive_url":"https://api.github.com/repos/ares/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ares/foreman/downloads","issues_url":"https://api.github.com/repos/ares/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ares/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ares/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ares/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ares/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ares/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/ares/foreman/deployments","created_at":"2013-03-05T09:59:59Z","updated_at":"2014-08-19T11:27:01Z","pushed_at":"2016-08-25T06:29:42Z","git_url":"git://github.com/ares/foreman.git","ssh_url":"git@github.com:ares/foreman.git","clone_url":"https://github.com/ares/foreman.git","svn_url":"https://github.com/ares/foreman","homepage":"http://theforeman.org","size":41330,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"f233e57de4ce8b783c4ac87466a0fdc7ff55f9f9","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-08-25T04:54:58Z","pushed_at":"2016-08-25T11:20:51Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":69673,"stargazers_count":1073,"watchers_count":1073,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":544,"mirror_url":null,"open_issues_count":84,"forks":544,"open_issues":84,"watchers":1073,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3704"},"html":{"href":"https://github.com/theforeman/foreman/pull/3704"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3704"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3704/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3704/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3704/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/9d01f0a39dc5ea86ce36075d57c77ce6b92e6a58"}}}}
{"actor":{"display_login":"dLobatog"}}