{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/streams/pulls/comments/82742107","pull_request_review_id":3627366,"id":82742107,"diff_hunk":"@@ -0,0 +1,87 @@\n+'use strict';\n+\n+if (self.importScripts) {\n+  self.importScripts('/resources/testharness.js');\n+}\n+\n+promise_test(t => {\n+  const ws = new WritableStream({\n+    close() {\n+      return 'Hello';\n+    }\n+  });\n+\n+  const writer = ws.getWriter();\n+\n+  const closePromise = writer.close('a');\n+  return closePromise.then(value => assert_equals(value, undefined, 'fulfillment value must be undefined'));\n+}, 'fulfillment value of ws.close() call must be undefined even if the underlying sink returns a non-undefined ' +\n+    'value');\n+\n+async_test(t => {\n+  const thrownError = new Error('throw me');\n+  const ws = new WritableStream({\n+    close() {\n+      throw thrownError;\n+    }\n+  });\n+\n+  const writer = ws.getWriter();\n+\n+  promise_rejects(\n+      t, thrownError, writer.close(), 'close promise', 'close promise should be rejected with the thrown error');","path":"reference-implementation/to-upstream-wpts/writable-streams/close.js","position":null,"original_position":32,"commit_id":"f350687c74e834ad634d418caac1420ce6e9027d","original_commit_id":"b6020e0e7d9e68e750bcafd0ac91cf3912cfb409","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"body":"Sorry. I failed to spot that they take different arguments.\r\n\r\nThe semantics are also slightly different. I am wondering whether we need to add a method named promiseRejectsWithStrictEquality() or similar.","created_at":"2016-10-11T08:08:20Z","updated_at":"2016-10-11T08:08:20Z","html_url":"https://github.com/whatwg/streams/pull/529#discussion_r82742107","pull_request_url":"https://api.github.com/repos/whatwg/streams/pulls/529","_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments/82742107"},"html":{"href":"https://github.com/whatwg/streams/pull/529#discussion_r82742107"},"pull_request":{"href":"https://api.github.com/repos/whatwg/streams/pulls/529"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/streams/pulls/529","id":88776375,"html_url":"https://github.com/whatwg/streams/pull/529","diff_url":"https://github.com/whatwg/streams/pull/529.diff","patch_url":"https://github.com/whatwg/streams/pull/529.patch","issue_url":"https://api.github.com/repos/whatwg/streams/issues/529","number":529,"state":"open","locked":false,"title":"Port close() tests to web-platform-tests","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"body":"Move tests relating to the WritableStream sink's close() method to the\r\ntestharness.js framework.\r\n\r\nTo reduce the risk of functional changes, changes to the tests are\r\nintentionally minimal. The only kinds of changes are:\r\n\r\n* Use testharness.js syntax\r\n* Match web-platform-tests style\r\n\r\nasync_test was used where necessary to retain the existing\r\nsemantics. It will be changed to promise_test in a separate commit.","created_at":"2016-10-11T06:15:11Z","updated_at":"2016-10-11T08:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f8be8310fb0269cc6c6476b71311b3ebe7cec37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/streams/pulls/529/commits","review_comments_url":"https://api.github.com/repos/whatwg/streams/pulls/529/comments","review_comment_url":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/529/comments","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/f350687c74e834ad634d418caac1420ce6e9027d","head":{"label":"ricea:writable_streams_test_close","ref":"writable_streams_test_close","sha":"f350687c74e834ad634d418caac1420ce6e9027d","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"repo":{"id":64450373,"name":"streams","full_name":"ricea/streams","owner":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricea/streams","description":"Streams Standard","fork":true,"url":"https://api.github.com/repos/ricea/streams","forks_url":"https://api.github.com/repos/ricea/streams/forks","keys_url":"https://api.github.com/repos/ricea/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricea/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricea/streams/teams","hooks_url":"https://api.github.com/repos/ricea/streams/hooks","issue_events_url":"https://api.github.com/repos/ricea/streams/issues/events{/number}","events_url":"https://api.github.com/repos/ricea/streams/events","assignees_url":"https://api.github.com/repos/ricea/streams/assignees{/user}","branches_url":"https://api.github.com/repos/ricea/streams/branches{/branch}","tags_url":"https://api.github.com/repos/ricea/streams/tags","blobs_url":"https://api.github.com/repos/ricea/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricea/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricea/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricea/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricea/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/ricea/streams/languages","stargazers_url":"https://api.github.com/repos/ricea/streams/stargazers","contributors_url":"https://api.github.com/repos/ricea/streams/contributors","subscribers_url":"https://api.github.com/repos/ricea/streams/subscribers","subscription_url":"https://api.github.com/repos/ricea/streams/subscription","commits_url":"https://api.github.com/repos/ricea/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricea/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricea/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricea/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricea/streams/contents/{+path}","compare_url":"https://api.github.com/repos/ricea/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricea/streams/merges","archive_url":"https://api.github.com/repos/ricea/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricea/streams/downloads","issues_url":"https://api.github.com/repos/ricea/streams/issues{/number}","pulls_url":"https://api.github.com/repos/ricea/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/ricea/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/ricea/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricea/streams/labels{/name}","releases_url":"https://api.github.com/repos/ricea/streams/releases{/id}","deployments_url":"https://api.github.com/repos/ricea/streams/deployments","created_at":"2016-07-29T04:28:21Z","updated_at":"2016-07-29T04:28:21Z","pushed_at":"2016-10-11T08:04:31Z","git_url":"git://github.com/ricea/streams.git","ssh_url":"git@github.com:ricea/streams.git","clone_url":"https://github.com/ricea/streams.git","svn_url":"https://github.com/ricea/streams","homepage":"https://streams.spec.whatwg.org/","size":1880,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"b0c598e4bd013f551034856038dd661e1ae610a3","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":13962843,"name":"streams","full_name":"whatwg/streams","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/streams","description":"Streams Standard","fork":false,"url":"https://api.github.com/repos/whatwg/streams","forks_url":"https://api.github.com/repos/whatwg/streams/forks","keys_url":"https://api.github.com/repos/whatwg/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/streams/teams","hooks_url":"https://api.github.com/repos/whatwg/streams/hooks","issue_events_url":"https://api.github.com/repos/whatwg/streams/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/streams/events","assignees_url":"https://api.github.com/repos/whatwg/streams/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/streams/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/streams/tags","blobs_url":"https://api.github.com/repos/whatwg/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/streams/languages","stargazers_url":"https://api.github.com/repos/whatwg/streams/stargazers","contributors_url":"https://api.github.com/repos/whatwg/streams/contributors","subscribers_url":"https://api.github.com/repos/whatwg/streams/subscribers","subscription_url":"https://api.github.com/repos/whatwg/streams/subscription","commits_url":"https://api.github.com/repos/whatwg/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/streams/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/streams/merges","archive_url":"https://api.github.com/repos/whatwg/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/streams/downloads","issues_url":"https://api.github.com/repos/whatwg/streams/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/streams/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/streams/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/streams/deployments","created_at":"2013-10-29T17:16:58Z","updated_at":"2016-10-09T01:57:59Z","pushed_at":"2016-10-11T08:04:31Z","git_url":"git://github.com/whatwg/streams.git","ssh_url":"git@github.com:whatwg/streams.git","clone_url":"https://github.com/whatwg/streams.git","svn_url":"https://github.com/whatwg/streams","homepage":"https://streams.spec.whatwg.org/","size":2615,"stargazers_count":583,"watchers_count":583,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":56,"forks":54,"open_issues":56,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/529"},"html":{"href":"https://github.com/whatwg/streams/pull/529"},"issue":{"href":"https://api.github.com/repos/whatwg/streams/issues/529"},"comments":{"href":"https://api.github.com/repos/whatwg/streams/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/streams/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/streams/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/streams/statuses/f350687c74e834ad634d418caac1420ce6e9027d"}}}}
{"actor":{"display_login":"ricea"}}