{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14950","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14950/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14950/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14950/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/14950","id":128198148,"number":14950,"title":"Recipes passing flags from components to results","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"labels":[{"id":14965560,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":43875653,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Suggestion%20(Discuss)","name":"Suggestion (Discuss)","color":"FF3399","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-01-22T16:58:17Z","updated_at":"2016-12-09T18:29:39Z","closed_at":null,"body":"We have quite a bit of recipes that are either duplicates with 1 or 2 values changed or that don't track some variables.\nMost of those are food items: cannibal items and allergens.\n\nI propose a system that would combine the duplicates and allow easily adding new recipes using stuff with \"side effects\" without losing said side effects:\n- Effects like poison, human flesh and allergens would be moved to flags\n- Certain flags, such as the ones above, would be added to results of crafting recipe that uses components with those flags\n- List of flags that would be passed could be hardcoded at first, later jsonized and with the ability to insert them per-recipe. At first probably only food recipes would pass flags.\n- In order to skip this flag passing, a recipe would specify a recipe flag like \"DROP_COMPONENT_FLAGS\" to avoid mutagens having to be poisonous. Alternatively, for some selected recipes, there could be lists of flags they don't pass.\n- Components with \"passable\" flags wouldn't stack with ones that don't have them and would get extra notes for some of them. That is, unless they had HIDDEN_POISON or the like.\n- Later on we could have flag pairs: input flag->output flag. So that, for example, cooking zombie meat could downgrade the poison but not remove it.\n\nAs a result:\n- Cannibal food wouldn't require new entries for everything. Could still have them for fancy names\n- Allergens and poison would get passed down the line automatically, allowing dehydrated poisoned/hallucinogenic shrooms (and then hallucinogenic pemmican), wheat vs. corn tortillas, broth becoming non-vegan when eggs are used etc.\n- Possibility of cooking with zombie flesh for desperate (or mutated) survivors - at a steep morale penalty. Only if it makes sense, I guess - if they no longer taste like long pork, they may need own recipes. Or if we don't want easy grinding of cooking on zed flesh.\n\nSounds relatively simple to implement to me. Did I miss some important detail, like UI problems?\nOr is it too \"automatic\" and we should control all of that by hand?\n"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/266086113","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/14950#issuecomment-266086113","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14950","id":266086113,"user":{"login":"keyspace","id":18170434,"avatar_url":"https://avatars.githubusercontent.com/u/18170434?v=3","gravatar_id":"","url":"https://api.github.com/users/keyspace","html_url":"https://github.com/keyspace","followers_url":"https://api.github.com/users/keyspace/followers","following_url":"https://api.github.com/users/keyspace/following{/other_user}","gists_url":"https://api.github.com/users/keyspace/gists{/gist_id}","starred_url":"https://api.github.com/users/keyspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyspace/subscriptions","organizations_url":"https://api.github.com/users/keyspace/orgs","repos_url":"https://api.github.com/users/keyspace/repos","events_url":"https://api.github.com/users/keyspace/events{/privacy}","received_events_url":"https://api.github.com/users/keyspace/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T18:29:39Z","updated_at":"2016-12-09T18:29:39Z","body":"> Would the flags also have the potential to impact nutritional content?\r\n\r\nI'd like to hope so.\r\n\r\nCan the current data structures for crafted tools/clothes (\"Made from\" in the UI) be re-used for consumables?.."}}
{"actor":{"display_login":"keyspace"}}