{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/60998030","id":60998030,"diff_hunk":"@@ -0,0 +1,43 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<Project ToolsVersion=\"12.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+  <PropertyGroup>\n+    <Configuration Condition=\"'$(Configuration)'==''\">Windows_Debug</Configuration>\n+  </PropertyGroup>\n+  <Import Project=\"$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\\dir.props\" />\n+  <PropertyGroup>\n+    <ProjectGuid>{03D84CBD-896D-4B2F-9A22-07034F51E73D}</ProjectGuid>\n+    <AssemblyName>System.Security.Cryptography.Pkcs</AssemblyName>\n+    <AssemblyVersion>4.0.0.0</AssemblyVersion>\n+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>\n+    <CLSCompliant>false</CLSCompliant>\n+    <IsPartialFacadeAssembly Condition=\"'$(TargetGroup)' == 'net46'\">true</IsPartialFacadeAssembly>\n+    <ResourcesSourceOutputDirectory Condition=\"'$(IsPartialFacadeAssembly)' == 'true'\">None</ResourcesSourceOutputDirectory>\n+    <GeneratePlatformNotSupportedAssembly Condition=\"'$(TargetsUnix)' == 'true'\">true</GeneratePlatformNotSupportedAssembly>\n+    <UsePackageTargetRuntimeDefaults Condition=\"'$(IsPartialFacadeAssembly)' != 'true'\">true</UsePackageTargetRuntimeDefaults>\n+    <PackageTargetFramework Condition=\"'$(PackageTargetFramework)' == ''\">netstandard1.3</PackageTargetFramework>\n+    <NuGetTargetMoniker Condition=\"'$(TargetGroup)'==''\">.NETStandard,Version=v1.3</NuGetTargetMoniker>\n+  </PropertyGroup>\n+\n+  <!-- Don't delete these clauses even if they look useless. They tell the VS IDE that \"Windows_Debug\", etc., are\n+       valid configuration for this project and stop it from trying to \"fix up\" the .sln file -->\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_Debug|AnyCPU'\" />\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_Release|AnyCPU'\" />\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_netcore50_Debug|AnyCPU'\" />\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_netcore50_Release|AnyCPU'\" />\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Unix_Debug|AnyCPU'\" />\n+  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Unix_Release|AnyCPU'\" />\n+\n+  <PropertyGroup Condition=\" '$(TargetGroup)' == 'netcore50' and '$(ProjectJson)' == '' \">","path":"src/System.Security.Cryptography.Pkcs/src/System.Security.Cryptography.Pkcs.csproj","position":null,"original_position":30,"commit_id":"d6ebfe8423b0c7da222d860076f370817545d382","original_commit_id":"77321e85e17bb40cb75be81de667953927bf9956","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"body":"Packaging LGTM","created_at":"2016-04-25T22:05:19Z","updated_at":"2016-04-25T22:05:19Z","html_url":"https://github.com/dotnet/corefx/pull/8049#discussion_r60998030","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/8049","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/60998030"},"html":{"href":"https://github.com/dotnet/corefx/pull/8049#discussion_r60998030"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8049"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/8049","id":67728097,"html_url":"https://github.com/dotnet/corefx/pull/8049","diff_url":"https://github.com/dotnet/corefx/pull/8049.diff","patch_url":"https://github.com/dotnet/corefx/pull/8049.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/8049","number":8049,"state":"open","locked":false,"title":"Add Support for EnvelopedCms (Step 1: Empty Package.)","user":{"login":"AtsushiKan","id":13223578,"avatar_url":"https://avatars.githubusercontent.com/u/13223578?v=3","gravatar_id":"","url":"https://api.github.com/users/AtsushiKan","html_url":"https://github.com/AtsushiKan","followers_url":"https://api.github.com/users/AtsushiKan/followers","following_url":"https://api.github.com/users/AtsushiKan/following{/other_user}","gists_url":"https://api.github.com/users/AtsushiKan/gists{/gist_id}","starred_url":"https://api.github.com/users/AtsushiKan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtsushiKan/subscriptions","organizations_url":"https://api.github.com/users/AtsushiKan/orgs","repos_url":"https://api.github.com/users/AtsushiKan/repos","events_url":"https://api.github.com/users/AtsushiKan/events{/privacy}","received_events_url":"https://api.github.com/users/AtsushiKan/received_events","type":"User","site_admin":false},"body":"Add Support for EnvelopedCms (Step 1: Empty Package.)\r\n\r\nThis class has been API reviewed and approved\r\n   https://github.com/dotnet/corefx/issues/7830\r\n\r\n\r\nFor this first PR, the assembly has the actual code elided. As soon as this is merged, a followup PR will add the code. This is for pragmatic reasons, having learned the hard way that having a long PR open with a project.json in it turns a simple isolated PR into a daily merge and CI-break hassle due to the constantly changing package version numbers. I'd much rather have the project.json merged first so that gets taken care of for me. Also, the people likely to CR the packaging and dependency stuff aren't likely to be interested in the crypto code so they can sign off on this and don't need to deal with the monster PR that's coming up.\r\n\r\nAlso included in this PR (again, to avoid merging later) is addition of \r\n\r\n```\r\n   internal const string Heap_L1 = \"api-ms-win-core-heap-l1-1-0.dll\";\r\n   internal const string SecurityCryptoApi = \"api-ms-win-security-cryptoapi-l1-1-0.dll\";\r\n```\r\nto Interop.Libraries.cs\r\n\r\n\r\nFor time/cost reasons, only Windows is supported for now. Unix platforms get a PlatformNotSupported shim. OpenSSL support is planned for later and the code is structured with a Pal structure similar to what we used for X509.\r\n\r\n\r\nPlatform targets are netcore50, net46, net461\r\n\r\nThe parts I didn't understand (basically all of it,) I copy-pasted from the X509Certificate2 package\r\nuntil things worked and the built binaries looked the way I wanted.\r\n\r\n\r\n\r\n\r\n<b>Some preemptive PR answers:</b>\r\n\r\n<b>Why does the .csproj file condition on \"$(Configuration)=Unix_Debug\" when the *.sln\r\ndoesn't have a Unix_Debug configuration?</b>\r\n\r\nThe .sln file doesn't include a Unix_Debug config because the Unix build is an autogenerated PlatformNotSupported assembly, which doesn't play well in a VS IDE.\r\n\r\nThe .csproj file still includes the magic \"test for $(Configuration)=Unix_Debug\" line as an investment into the future. Some day, someone will need to add that configuration to the .sln file and it'd be nice if they didn't have to play the \"Why does VS keep removing my change\" game.\"","created_at":"2016-04-25T14:22:57Z","updated_at":"2016-04-25T22:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbebf0b734449396e134e328b849f531f5313f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/8049/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/8049/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/8049/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/d6ebfe8423b0c7da222d860076f370817545d382","head":{"label":"AtsushiKan:pkcsempty","ref":"pkcsempty","sha":"d6ebfe8423b0c7da222d860076f370817545d382","user":{"login":"AtsushiKan","id":13223578,"avatar_url":"https://avatars.githubusercontent.com/u/13223578?v=3","gravatar_id":"","url":"https://api.github.com/users/AtsushiKan","html_url":"https://github.com/AtsushiKan","followers_url":"https://api.github.com/users/AtsushiKan/followers","following_url":"https://api.github.com/users/AtsushiKan/following{/other_user}","gists_url":"https://api.github.com/users/AtsushiKan/gists{/gist_id}","starred_url":"https://api.github.com/users/AtsushiKan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtsushiKan/subscriptions","organizations_url":"https://api.github.com/users/AtsushiKan/orgs","repos_url":"https://api.github.com/users/AtsushiKan/repos","events_url":"https://api.github.com/users/AtsushiKan/events{/privacy}","received_events_url":"https://api.github.com/users/AtsushiKan/received_events","type":"User","site_admin":false},"repo":{"id":38702362,"name":"corefx","full_name":"AtsushiKan/corefx","owner":{"login":"AtsushiKan","id":13223578,"avatar_url":"https://avatars.githubusercontent.com/u/13223578?v=3","gravatar_id":"","url":"https://api.github.com/users/AtsushiKan","html_url":"https://github.com/AtsushiKan","followers_url":"https://api.github.com/users/AtsushiKan/followers","following_url":"https://api.github.com/users/AtsushiKan/following{/other_user}","gists_url":"https://api.github.com/users/AtsushiKan/gists{/gist_id}","starred_url":"https://api.github.com/users/AtsushiKan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtsushiKan/subscriptions","organizations_url":"https://api.github.com/users/AtsushiKan/orgs","repos_url":"https://api.github.com/users/AtsushiKan/repos","events_url":"https://api.github.com/users/AtsushiKan/events{/privacy}","received_events_url":"https://api.github.com/users/AtsushiKan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AtsushiKan/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/AtsushiKan/corefx","forks_url":"https://api.github.com/repos/AtsushiKan/corefx/forks","keys_url":"https://api.github.com/repos/AtsushiKan/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtsushiKan/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtsushiKan/corefx/teams","hooks_url":"https://api.github.com/repos/AtsushiKan/corefx/hooks","issue_events_url":"https://api.github.com/repos/AtsushiKan/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/AtsushiKan/corefx/events","assignees_url":"https://api.github.com/repos/AtsushiKan/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/AtsushiKan/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/AtsushiKan/corefx/tags","blobs_url":"https://api.github.com/repos/AtsushiKan/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtsushiKan/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtsushiKan/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtsushiKan/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtsushiKan/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/AtsushiKan/corefx/languages","stargazers_url":"https://api.github.com/repos/AtsushiKan/corefx/stargazers","contributors_url":"https://api.github.com/repos/AtsushiKan/corefx/contributors","subscribers_url":"https://api.github.com/repos/AtsushiKan/corefx/subscribers","subscription_url":"https://api.github.com/repos/AtsushiKan/corefx/subscription","commits_url":"https://api.github.com/repos/AtsushiKan/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtsushiKan/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtsushiKan/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtsushiKan/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtsushiKan/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/AtsushiKan/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtsushiKan/corefx/merges","archive_url":"https://api.github.com/repos/AtsushiKan/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtsushiKan/corefx/downloads","issues_url":"https://api.github.com/repos/AtsushiKan/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/AtsushiKan/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/AtsushiKan/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/AtsushiKan/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtsushiKan/corefx/labels{/name}","releases_url":"https://api.github.com/repos/AtsushiKan/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/AtsushiKan/corefx/deployments","created_at":"2015-07-07T17:03:52Z","updated_at":"2016-01-13T21:05:54Z","pushed_at":"2016-04-25T21:58:58Z","git_url":"git://github.com/AtsushiKan/corefx.git","ssh_url":"git@github.com:AtsushiKan/corefx.git","clone_url":"https://github.com/AtsushiKan/corefx.git","svn_url":"https://github.com/AtsushiKan/corefx","homepage":"http://dotnet.github.io/core/","size":65531,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"320576a306e600b3bf3d5837cec92a56ee893349","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-25T19:51:40Z","pushed_at":"2016-04-25T22:04:29Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":89361,"stargazers_count":9560,"watchers_count":9560,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2279,"mirror_url":null,"open_issues_count":977,"forks":2279,"open_issues":977,"watchers":9560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8049"},"html":{"href":"https://github.com/dotnet/corefx/pull/8049"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8049"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8049/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8049/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8049/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/d6ebfe8423b0c7da222d860076f370817545d382"}}}}