{"action":"created","comment":{"url":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/85232253","pull_request_review_id":5959779,"id":85232253,"diff_hunk":"@@ -203,9 +203,13 @@ def execute_curl(options, subprocess_options, &data_proc)\n           @logger.warn(\"Downloader exit code: #{result.exit_code}\")\n           parts    = result.stderr.split(/\\n*curl:\\s+\\(\\d+\\)\\s*/, 2)\n           parts[1] ||= \"\"\n-          raise Errors::DownloaderError,\n-            code: result.exit_code,\n-            message: parts[1].chomp\n+          if parts[1].include? \"416\"\n+            # All good actually. 416 means there is no mory bytes to download","path":"lib/vagrant/util/downloader.rb","position":8,"original_position":8,"commit_id":"8419f10e0a9615e73ff0630377019508061fb64e","original_commit_id":"8419f10e0a9615e73ff0630377019508061fb64e","user":{"login":"glennpratt","id":202230,"avatar_url":"https://avatars.githubusercontent.com/u/202230?v=3","gravatar_id":"","url":"https://api.github.com/users/glennpratt","html_url":"https://github.com/glennpratt","followers_url":"https://api.github.com/users/glennpratt/followers","following_url":"https://api.github.com/users/glennpratt/following{/other_user}","gists_url":"https://api.github.com/users/glennpratt/gists{/gist_id}","starred_url":"https://api.github.com/users/glennpratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennpratt/subscriptions","organizations_url":"https://api.github.com/users/glennpratt/orgs","repos_url":"https://api.github.com/users/glennpratt/repos","events_url":"https://api.github.com/users/glennpratt/events{/privacy}","received_events_url":"https://api.github.com/users/glennpratt/received_events","type":"User","site_admin":false},"body":"s/mory/more\r\n\r\nMore importantly, I'm not sure this is true. I received a 416 on an incomplete file when my machine crashed.\r\n\r\n```\r\n$ vagrant up\r\nBringing machine 'default' up with 'virtualbox' provider...\r\n==> default: Box 'puppetlabs-precise64' could not be found. Attempting to find and install...\r\n    default: Box Provider: virtualbox\r\n    default: Box Version: >= 0\r\n==> default: Box file was not detected as metadata. Adding it directly...\r\n==> default: Adding box 'puppetlabs-precise64' (v0) for provider: virtualbox\r\n    default: Downloading: http://puppet-vagrant-boxes.puppetlabs.com/ubuntu-server-12042-x64-vbox4210.box\r\n==> default: Box download is resuming from prior download progress\r\n    default: Progress: 47% (Rate: 1217k/s, Estimated time remaining: 0:00:41)\r\n\r\nSession Restored\r\n\r\nLast login: Wed Oct 26 15:06:58 on ttys002\r\ndefault is not running. Please start this with docker-machine start default\r\n\r\n$ vagrant up\r\nBringing machine 'default' up with 'virtualbox' provider...\r\n==> default: Box 'puppetlabs-precise64' could not be found. Attempting to find and install...\r\n    default: Box Provider: virtualbox\r\n    default: Box Version: >= 0\r\n==> default: Box file was not detected as metadata. Adding it directly...\r\n==> default: Adding box 'puppetlabs-precise64' (v0) for provider: virtualbox\r\n    default: Downloading: http://puppet-vagrant-boxes.puppetlabs.com/ubuntu-server-12042-x64-vbox4210.box\r\n==> default: Box download is resuming from prior download progress\r\nAn error occurred while downloading the remote file. The error\r\nmessage, if any, is reproduced below. Please fix this error and try\r\nagain.\r\n\r\nThe requested URL returned error: 416\r\n```","created_at":"2016-10-26T22:14:55Z","updated_at":"2016-10-26T22:14:55Z","html_url":"https://github.com/mitchellh/vagrant/pull/7886#discussion_r85232253","pull_request_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886","_links":{"self":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/85232253"},"html":{"href":"https://github.com/mitchellh/vagrant/pull/7886#discussion_r85232253"},"pull_request":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886"}}},"pull_request":{"url":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886","id":88808072,"html_url":"https://github.com/mitchellh/vagrant/pull/7886","diff_url":"https://github.com/mitchellh/vagrant/pull/7886.diff","patch_url":"https://github.com/mitchellh/vagrant/pull/7886.patch","issue_url":"https://api.github.com/repos/mitchellh/vagrant/issues/7886","number":7886,"state":"open","locked":false,"title":"Issue #7885 Don't raise error if response is 416","user":{"login":"akamensky","id":985805,"avatar_url":"https://avatars.githubusercontent.com/u/985805?v=3","gravatar_id":"","url":"https://api.github.com/users/akamensky","html_url":"https://github.com/akamensky","followers_url":"https://api.github.com/users/akamensky/followers","following_url":"https://api.github.com/users/akamensky/following{/other_user}","gists_url":"https://api.github.com/users/akamensky/gists{/gist_id}","starred_url":"https://api.github.com/users/akamensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamensky/subscriptions","organizations_url":"https://api.github.com/users/akamensky/orgs","repos_url":"https://api.github.com/users/akamensky/repos","events_url":"https://api.github.com/users/akamensky/events{/privacy}","received_events_url":"https://api.github.com/users/akamensky/received_events","type":"User","site_admin":false},"body":"Vagrant downloader should handle response codes appropriately. HTTP response code 416 means that the requested bytes are out of range, which in case of curl --continue-at or wget --continue means that the entire file has already been downloaded.\r\n\r\nThe chosen place for patch is justified by the fact that we should not raise ANY error if response code is 416.","created_at":"2016-10-11T10:29:50Z","updated_at":"2016-10-26T22:14:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69e83cd66e779bad0530e0a70db13195d740cd98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886/commits","review_comments_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886/comments","review_comment_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitchellh/vagrant/issues/7886/comments","statuses_url":"https://api.github.com/repos/mitchellh/vagrant/statuses/8419f10e0a9615e73ff0630377019508061fb64e","head":{"label":"akamensky:akamensky-patch-1","ref":"akamensky-patch-1","sha":"8419f10e0a9615e73ff0630377019508061fb64e","user":{"login":"akamensky","id":985805,"avatar_url":"https://avatars.githubusercontent.com/u/985805?v=3","gravatar_id":"","url":"https://api.github.com/users/akamensky","html_url":"https://github.com/akamensky","followers_url":"https://api.github.com/users/akamensky/followers","following_url":"https://api.github.com/users/akamensky/following{/other_user}","gists_url":"https://api.github.com/users/akamensky/gists{/gist_id}","starred_url":"https://api.github.com/users/akamensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamensky/subscriptions","organizations_url":"https://api.github.com/users/akamensky/orgs","repos_url":"https://api.github.com/users/akamensky/repos","events_url":"https://api.github.com/users/akamensky/events{/privacy}","received_events_url":"https://api.github.com/users/akamensky/received_events","type":"User","site_admin":false},"repo":{"id":70580140,"name":"vagrant","full_name":"akamensky/vagrant","owner":{"login":"akamensky","id":985805,"avatar_url":"https://avatars.githubusercontent.com/u/985805?v=3","gravatar_id":"","url":"https://api.github.com/users/akamensky","html_url":"https://github.com/akamensky","followers_url":"https://api.github.com/users/akamensky/followers","following_url":"https://api.github.com/users/akamensky/following{/other_user}","gists_url":"https://api.github.com/users/akamensky/gists{/gist_id}","starred_url":"https://api.github.com/users/akamensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamensky/subscriptions","organizations_url":"https://api.github.com/users/akamensky/orgs","repos_url":"https://api.github.com/users/akamensky/repos","events_url":"https://api.github.com/users/akamensky/events{/privacy}","received_events_url":"https://api.github.com/users/akamensky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akamensky/vagrant","description":"Vagrant is a tool for building and distributing development environments.","fork":true,"url":"https://api.github.com/repos/akamensky/vagrant","forks_url":"https://api.github.com/repos/akamensky/vagrant/forks","keys_url":"https://api.github.com/repos/akamensky/vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamensky/vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamensky/vagrant/teams","hooks_url":"https://api.github.com/repos/akamensky/vagrant/hooks","issue_events_url":"https://api.github.com/repos/akamensky/vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/akamensky/vagrant/events","assignees_url":"https://api.github.com/repos/akamensky/vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/akamensky/vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/akamensky/vagrant/tags","blobs_url":"https://api.github.com/repos/akamensky/vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamensky/vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamensky/vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamensky/vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamensky/vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/akamensky/vagrant/languages","stargazers_url":"https://api.github.com/repos/akamensky/vagrant/stargazers","contributors_url":"https://api.github.com/repos/akamensky/vagrant/contributors","subscribers_url":"https://api.github.com/repos/akamensky/vagrant/subscribers","subscription_url":"https://api.github.com/repos/akamensky/vagrant/subscription","commits_url":"https://api.github.com/repos/akamensky/vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamensky/vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamensky/vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamensky/vagrant/issues/comments{/number}","contents_url":"https://api.github.com/repos/akamensky/vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/akamensky/vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamensky/vagrant/merges","archive_url":"https://api.github.com/repos/akamensky/vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamensky/vagrant/downloads","issues_url":"https://api.github.com/repos/akamensky/vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/akamensky/vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/akamensky/vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/akamensky/vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamensky/vagrant/labels{/name}","releases_url":"https://api.github.com/repos/akamensky/vagrant/releases{/id}","deployments_url":"https://api.github.com/repos/akamensky/vagrant/deployments","created_at":"2016-10-11T09:59:09Z","updated_at":"2016-10-11T09:59:14Z","pushed_at":"2016-10-11T10:23:54Z","git_url":"git://github.com/akamensky/vagrant.git","ssh_url":"git@github.com:akamensky/vagrant.git","clone_url":"https://github.com/akamensky/vagrant.git","svn_url":"https://github.com/akamensky/vagrant","homepage":"https://www.vagrantup.com","size":17795,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitchellh:master","ref":"master","sha":"29b033390f4a10ec21cdd900e99a5925b605843b","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":481872,"name":"vagrant","full_name":"mitchellh/vagrant","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/vagrant","description":"Vagrant is a tool for building and distributing development environments.","fork":false,"url":"https://api.github.com/repos/mitchellh/vagrant","forks_url":"https://api.github.com/repos/mitchellh/vagrant/forks","keys_url":"https://api.github.com/repos/mitchellh/vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/vagrant/teams","hooks_url":"https://api.github.com/repos/mitchellh/vagrant/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/vagrant/events","assignees_url":"https://api.github.com/repos/mitchellh/vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/vagrant/tags","blobs_url":"https://api.github.com/repos/mitchellh/vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/vagrant/languages","stargazers_url":"https://api.github.com/repos/mitchellh/vagrant/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/vagrant/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/vagrant/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/vagrant/subscription","commits_url":"https://api.github.com/repos/mitchellh/vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/vagrant/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellh/vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/vagrant/merges","archive_url":"https://api.github.com/repos/mitchellh/vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/vagrant/downloads","issues_url":"https://api.github.com/repos/mitchellh/vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/vagrant/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/vagrant/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellh/vagrant/deployments","created_at":"2010-01-21T08:34:27Z","updated_at":"2016-10-26T18:23:55Z","pushed_at":"2016-10-26T20:07:52Z","git_url":"git://github.com/mitchellh/vagrant.git","ssh_url":"git@github.com:mitchellh/vagrant.git","clone_url":"https://github.com/mitchellh/vagrant.git","svn_url":"https://github.com/mitchellh/vagrant","homepage":"https://www.vagrantup.com","size":26909,"stargazers_count":13364,"watchers_count":13364,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2826,"mirror_url":null,"open_issues_count":407,"forks":2826,"open_issues":407,"watchers":13364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886"},"html":{"href":"https://github.com/mitchellh/vagrant/pull/7886"},"issue":{"href":"https://api.github.com/repos/mitchellh/vagrant/issues/7886"},"comments":{"href":"https://api.github.com/repos/mitchellh/vagrant/issues/7886/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/7886/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/vagrant/statuses/8419f10e0a9615e73ff0630377019508061fb64e"}}}}
{"actor":{"display_login":"glennpratt"}}