{"action":"created","comment":{"url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/comments/57517751","id":57517751,"diff_hunk":"@@ -2,23 +2,28 @@ import Ember from 'ember';\n \n export default Ember.Component.extend({\n   tagName: 'li',\n-  childLinkViews: [],\n   classNameBindings: ['active'],\n \n   active: Ember.computed('childLinkViews.@each.active', function() {\n-    return Ember.A(this.get('childLinkViews')).isAny('active');\n+    return this.get('childLinkViews').isAny('active');\n   }),\n \n-  didRender: function() {\n+  init() {\n+    this._super( ...arguments );\n+    this.set('childLinkViews', Ember.A());\n+  },\n+\n+  didRender() {\n+    this._super( ...arguments );","path":"addon/components/active-link.js","position":null,"original_position":19,"commit_id":"f2d864305556e2820b75ce92e0144020cd1c9b39","original_commit_id":"99268051ad42e5e78218933ccf049139330f4f1c","user":{"login":"alexspeller","id":1217,"avatar_url":"https://avatars.githubusercontent.com/u/1217?v=3","gravatar_id":"","url":"https://api.github.com/users/alexspeller","html_url":"https://github.com/alexspeller","followers_url":"https://api.github.com/users/alexspeller/followers","following_url":"https://api.github.com/users/alexspeller/following{/other_user}","gists_url":"https://api.github.com/users/alexspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexspeller/subscriptions","organizations_url":"https://api.github.com/users/alexspeller/orgs","repos_url":"https://api.github.com/users/alexspeller/repos","events_url":"https://api.github.com/users/alexspeller/events{/privacy}","received_events_url":"https://api.github.com/users/alexspeller/received_events","type":"User","site_admin":false},"body":"There is no need to call super here. There is no super `didRender` hook to call on Ember.Component","created_at":"2016-03-26T18:48:47Z","updated_at":"2016-03-26T18:48:47Z","html_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12#discussion_r57517751","pull_request_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/comments/57517751"},"html":{"href":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12#discussion_r57517751"},"pull_request":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12","id":61780826,"html_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12","diff_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12.diff","patch_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12.patch","issue_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/12","number":12,"state":"open","locked":false,"title":"Changing activeClass, added disabled state, moved to Mixin, ember-cli 2.4.1, and more!","user":{"login":"Panman8201","id":3475765,"avatar_url":"https://avatars.githubusercontent.com/u/3475765?v=3","gravatar_id":"","url":"https://api.github.com/users/Panman8201","html_url":"https://github.com/Panman8201","followers_url":"https://api.github.com/users/Panman8201/followers","following_url":"https://api.github.com/users/Panman8201/following{/other_user}","gists_url":"https://api.github.com/users/Panman8201/gists{/gist_id}","starred_url":"https://api.github.com/users/Panman8201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Panman8201/subscriptions","organizations_url":"https://api.github.com/users/Panman8201/orgs","repos_url":"https://api.github.com/users/Panman8201/repos","events_url":"https://api.github.com/users/Panman8201/events{/privacy}","received_events_url":"https://api.github.com/users/Panman8201/received_events","type":"User","site_admin":false},"body":"_Finally_ got around to creating the PR for issue #10. This encompasses everything mentioned there, with your concerns resolved (I'm hoping anyway). Here are the commit messages and details:\r\n\r\n__Update to ember-cli 2.4.1__\r\nUpdated the ember-cli dep to 2.4.1 and ran `ember init` to update other deps and file changes.\r\n\r\n__Remove ember-data__\r\nRemoved `ember-data` from the `devDependencies`, not needed for this addon..\r\n\r\n__Remove un-needed .gitkeep files__\r\nReally minor, just removing un-needed `.gitkeep` files since the addon and app folders contain stuff.\r\n\r\n__Make 'childLinkViews' an Ember Array__\r\nMake the `childLinkViews` property an Ember Array, instead of having the Computed Properties convert it (setup for future commits). This commit includes a few other related changes;\r\n\r\n* Create the initial array in the `init()` hook\r\n* Run `_super()` on the `didRender()` hook\r\n* Change `var` to `let` for variable declarations\r\n\r\n__Add ability to change the 'activeClass' name__\r\nPreviously, the active class name was hard coded to ‘active’. Now it will pull the child `{{link-to}}` `activeClass` name by default. Or, users can specify what it will be by defining the `activeClass` on the `{{active-link}}`. Also added tests for this and updated the README (which has been expanded to show more examples).\r\n\r\n__Add support for the disabled state__\r\nAs a negative to active, add a disabled state that adds a class when ALL child links are also disabled. Similarly, the class name draws from the child `{{link-to}}` but can be overridden. Users can always opt-out by defining `disabledClass=false`. Also added tests for this and updated the README.\r\n\r\n__Expose the child link selector__\r\nWhile probably a rare case, expose the selector used to find child links. That way if folks are using `<button>`s instead, they could update the `linkSelector`. Also added tests for this and updated the README.\r\n\r\n__Move functionality to mixin__\r\nBy moving the main functionality of this addon into a Mixin, Components from other addons can implement these features. For example, other UI libraries might provide a dropdown Component where this might be a helpful addition.\r\n\r\n__Minor README tweaks__\r\nJust a few tweaks to the README; broke-up long lines, extra spacing between headers, added the Development section (in new addons), adjusted the tests link, and removed the Building section (doesn’t make sense for this addon).\r\n\r\nImpacts on existing issues and PRs:\r\nResolves #3 \r\nResolves #10 \r\nCloses #8 ","created_at":"2016-03-04T22:25:58Z","updated_at":"2016-03-26T18:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6faa6845a86e306de2203471163c6067f3589c3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12/commits","review_comments_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12/comments","review_comment_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/12/comments","statuses_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/statuses/f2d864305556e2820b75ce92e0144020cd1c9b39","head":{"label":"Panman8201:mutation","ref":"mutation","sha":"f2d864305556e2820b75ce92e0144020cd1c9b39","user":{"login":"Panman8201","id":3475765,"avatar_url":"https://avatars.githubusercontent.com/u/3475765?v=3","gravatar_id":"","url":"https://api.github.com/users/Panman8201","html_url":"https://github.com/Panman8201","followers_url":"https://api.github.com/users/Panman8201/followers","following_url":"https://api.github.com/users/Panman8201/following{/other_user}","gists_url":"https://api.github.com/users/Panman8201/gists{/gist_id}","starred_url":"https://api.github.com/users/Panman8201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Panman8201/subscriptions","organizations_url":"https://api.github.com/users/Panman8201/orgs","repos_url":"https://api.github.com/users/Panman8201/repos","events_url":"https://api.github.com/users/Panman8201/events{/privacy}","received_events_url":"https://api.github.com/users/Panman8201/received_events","type":"User","site_admin":false},"repo":{"id":48378185,"name":"ember-cli-active-link-wrapper","full_name":"Panman8201/ember-cli-active-link-wrapper","owner":{"login":"Panman8201","id":3475765,"avatar_url":"https://avatars.githubusercontent.com/u/3475765?v=3","gravatar_id":"","url":"https://api.github.com/users/Panman8201","html_url":"https://github.com/Panman8201","followers_url":"https://api.github.com/users/Panman8201/followers","following_url":"https://api.github.com/users/Panman8201/following{/other_user}","gists_url":"https://api.github.com/users/Panman8201/gists{/gist_id}","starred_url":"https://api.github.com/users/Panman8201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Panman8201/subscriptions","organizations_url":"https://api.github.com/users/Panman8201/orgs","repos_url":"https://api.github.com/users/Panman8201/repos","events_url":"https://api.github.com/users/Panman8201/events{/privacy}","received_events_url":"https://api.github.com/users/Panman8201/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Panman8201/ember-cli-active-link-wrapper","description":"Simple ember-cli link wrapper to propagate active class to parent element","fork":true,"url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper","forks_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/forks","keys_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/teams","hooks_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/hooks","issue_events_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/events","assignees_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/tags","blobs_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/languages","stargazers_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/stargazers","contributors_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/contributors","subscribers_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/subscribers","subscription_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/subscription","commits_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/merges","archive_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/downloads","issues_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/Panman8201/ember-cli-active-link-wrapper/deployments","created_at":"2015-12-21T15:10:18Z","updated_at":"2016-03-04T14:45:45Z","pushed_at":"2016-03-04T22:11:19Z","git_url":"git://github.com/Panman8201/ember-cli-active-link-wrapper.git","ssh_url":"git@github.com:Panman8201/ember-cli-active-link-wrapper.git","clone_url":"https://github.com/Panman8201/ember-cli-active-link-wrapper.git","svn_url":"https://github.com/Panman8201/ember-cli-active-link-wrapper","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexspeller:master","ref":"master","sha":"18db37f30abdaa2e1c6f5b2c116f174a582e2eae","user":{"login":"alexspeller","id":1217,"avatar_url":"https://avatars.githubusercontent.com/u/1217?v=3","gravatar_id":"","url":"https://api.github.com/users/alexspeller","html_url":"https://github.com/alexspeller","followers_url":"https://api.github.com/users/alexspeller/followers","following_url":"https://api.github.com/users/alexspeller/following{/other_user}","gists_url":"https://api.github.com/users/alexspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexspeller/subscriptions","organizations_url":"https://api.github.com/users/alexspeller/orgs","repos_url":"https://api.github.com/users/alexspeller/repos","events_url":"https://api.github.com/users/alexspeller/events{/privacy}","received_events_url":"https://api.github.com/users/alexspeller/received_events","type":"User","site_admin":false},"repo":{"id":32482459,"name":"ember-cli-active-link-wrapper","full_name":"alexspeller/ember-cli-active-link-wrapper","owner":{"login":"alexspeller","id":1217,"avatar_url":"https://avatars.githubusercontent.com/u/1217?v=3","gravatar_id":"","url":"https://api.github.com/users/alexspeller","html_url":"https://github.com/alexspeller","followers_url":"https://api.github.com/users/alexspeller/followers","following_url":"https://api.github.com/users/alexspeller/following{/other_user}","gists_url":"https://api.github.com/users/alexspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexspeller/subscriptions","organizations_url":"https://api.github.com/users/alexspeller/orgs","repos_url":"https://api.github.com/users/alexspeller/repos","events_url":"https://api.github.com/users/alexspeller/events{/privacy}","received_events_url":"https://api.github.com/users/alexspeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper","description":"Simple ember-cli link wrapper to propagate active class to parent element","fork":false,"url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper","forks_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/forks","keys_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/teams","hooks_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/hooks","issue_events_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/events","assignees_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/tags","blobs_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/languages","stargazers_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/stargazers","contributors_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/contributors","subscribers_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/subscribers","subscription_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/subscription","commits_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/merges","archive_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/downloads","issues_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/deployments","created_at":"2015-03-18T20:28:46Z","updated_at":"2016-02-29T19:40:24Z","pushed_at":"2016-03-04T22:25:58Z","git_url":"git://github.com/alexspeller/ember-cli-active-link-wrapper.git","ssh_url":"git@github.com:alexspeller/ember-cli-active-link-wrapper.git","clone_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper.git","svn_url":"https://github.com/alexspeller/ember-cli-active-link-wrapper","homepage":null,"size":19,"stargazers_count":41,"watchers_count":41,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12"},"html":{"href":"https://github.com/alexspeller/ember-cli-active-link-wrapper/pull/12"},"issue":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/12"},"comments":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/alexspeller/ember-cli-active-link-wrapper/statuses/f2d864305556e2820b75ce92e0144020cd1c9b39"}}}}