{"action":"created","issue":{"url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/528","repository_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs","labels_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/528/labels{/name}","comments_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/528/comments","events_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/528/events","html_url":"https://github.com/SpiderLabs/owasp-modsecurity-crs/issues/528","id":171023004,"number":528,"title":"Add removed rules to IdNumbering.csv","user":{"login":"lifeforms","id":3464056,"avatar_url":"https://avatars.githubusercontent.com/u/3464056?v=3","gravatar_id":"","url":"https://api.github.com/users/lifeforms","html_url":"https://github.com/lifeforms","followers_url":"https://api.github.com/users/lifeforms/followers","following_url":"https://api.github.com/users/lifeforms/following{/other_user}","gists_url":"https://api.github.com/users/lifeforms/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeforms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeforms/subscriptions","organizations_url":"https://api.github.com/users/lifeforms/orgs","repos_url":"https://api.github.com/users/lifeforms/repos","events_url":"https://api.github.com/users/lifeforms/events{/privacy}","received_events_url":"https://api.github.com/users/lifeforms/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/milestones/5","html_url":"https://github.com/SpiderLabs/owasp-modsecurity-crs/milestones/CRS%20v3.0.0%20RC2","labels_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/milestones/5/labels","id":1919105,"number":5,"title":"CRS v3.0.0 RC2","description":"","creator":{"login":"csanders-git","id":4632287,"avatar_url":"https://avatars.githubusercontent.com/u/4632287?v=3","gravatar_id":"","url":"https://api.github.com/users/csanders-git","html_url":"https://github.com/csanders-git","followers_url":"https://api.github.com/users/csanders-git/followers","following_url":"https://api.github.com/users/csanders-git/following{/other_user}","gists_url":"https://api.github.com/users/csanders-git/gists{/gist_id}","starred_url":"https://api.github.com/users/csanders-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csanders-git/subscriptions","organizations_url":"https://api.github.com/users/csanders-git/orgs","repos_url":"https://api.github.com/users/csanders-git/repos","events_url":"https://api.github.com/users/csanders-git/events{/privacy}","received_events_url":"https://api.github.com/users/csanders-git/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":20,"state":"open","created_at":"2016-08-02T19:04:12Z","updated_at":"2016-09-19T20:01:17Z","due_on":"2016-09-22T00:00:00Z","closed_at":null},"comments":2,"created_at":"2016-08-13T19:13:05Z","updated_at":"2016-09-19T20:01:17Z","closed_at":"2016-09-19T20:01:17Z","body":"When upgrading a CRS2 deployment to CRS3, a user needs the idNumbering script to upgrade the rule ids in your own exclusions.\r\n\r\nBut many rules have been deleted in CRS3, so a user should also delete those exclusions.\r\n\r\nOtherwise, if an old rule id gets reused for a new rule id, users will still be referring the old rule id in your configs, producing unexpected results and possibly bypasses.\r\n\r\nI would propose that we add the removed rules to idNumbering.csv, for instance replacing them with a fake rule id '999999'. That's easy to grep in the resulting files, and so you can choose to remove any rules having to do with it.\r\n\r\nThe 999999 number should be documented in the script and its README of course. And we should never use it for a real rule.\r\n\r\nEdit: Bonus issue: Also maybe we should remove the `id_renumbering` directory below `util` too."},"comment":{"url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/comments/248106853","html_url":"https://github.com/SpiderLabs/owasp-modsecurity-crs/issues/528#issuecomment-248106853","issue_url":"https://api.github.com/repos/SpiderLabs/owasp-modsecurity-crs/issues/528","id":248106853,"user":{"login":"dune73","id":618722,"avatar_url":"https://avatars.githubusercontent.com/u/618722?v=3","gravatar_id":"","url":"https://api.github.com/users/dune73","html_url":"https://github.com/dune73","followers_url":"https://api.github.com/users/dune73/followers","following_url":"https://api.github.com/users/dune73/following{/other_user}","gists_url":"https://api.github.com/users/dune73/gists{/gist_id}","starred_url":"https://api.github.com/users/dune73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dune73/subscriptions","organizations_url":"https://api.github.com/users/dune73/orgs","repos_url":"https://api.github.com/users/dune73/repos","events_url":"https://api.github.com/users/dune73/events{/privacy}","received_events_url":"https://api.github.com/users/dune73/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T20:01:17Z","updated_at":"2016-09-19T20:01:17Z","body":"Closed in favor of PR in #581."}}
{"actor":{"display_login":"dune73"}}