{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/114","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/114/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/114/events","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/114","id":127137770,"number":114,"title":"Should we ever export a span missing a trace id or a span id?","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-18T01:09:14Z","updated_at":"2016-01-18T16:05:09Z","closed_at":"2016-01-18T16:05:09Z","body":"In issue #111, we carry-over a \"default id\" of 1125899906842597L\r\n\r\nIt doesn't make sense to me why we would report a constant id. ex, if this were actually used, any spans that are missing ids would become attached to trace 1125899906842597L. That data wouldn't be reclassifyable. If it could be displayed, it would appear in the trace list as an odd trace that has dead spans from N endpoints attached.\r\n\r\nI think this is an example of where we are allowing null in a place that should never be. Is there any valid reason for a span without an identifier to be reported?"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments/172571000","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/114#issuecomment-172571000","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/114","id":172571000,"user":{"login":"marcingrzejszczak","id":3297437,"avatar_url":"https://avatars.githubusercontent.com/u/3297437?v=3","gravatar_id":"","url":"https://api.github.com/users/marcingrzejszczak","html_url":"https://github.com/marcingrzejszczak","followers_url":"https://api.github.com/users/marcingrzejszczak/followers","following_url":"https://api.github.com/users/marcingrzejszczak/following{/other_user}","gists_url":"https://api.github.com/users/marcingrzejszczak/gists{/gist_id}","starred_url":"https://api.github.com/users/marcingrzejszczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcingrzejszczak/subscriptions","organizations_url":"https://api.github.com/users/marcingrzejszczak/orgs","repos_url":"https://api.github.com/users/marcingrzejszczak/repos","events_url":"https://api.github.com/users/marcingrzejszczak/events{/privacy}","received_events_url":"https://api.github.com/users/marcingrzejszczak/received_events","type":"User","site_admin":false},"created_at":"2016-01-18T16:05:09Z","updated_at":"2016-01-18T16:05:09Z","body":"ATM (https://github.com/spring-cloud/spring-cloud-sleuth/issues/111) it's no longer possible to have a span without trace and span id."}}