{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4709","labels_url":"https://api.github.com/repos/netty/netty/issues/4709/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4709/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4709/events","html_url":"https://github.com/netty/netty/pull/4709","id":126712183,"number":4709,"title":"Don't enforce JZlibDecoder on JDK7+, close #4707","user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars.githubusercontent.com/u/849197?v=3","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netty/netty/labels/improvement","name":"improvement","color":"0052cc"}],"state":"closed","locked":false,"assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/131","html_url":"https://github.com/netty/netty/milestones/4.0.34.Final","labels_url":"https://api.github.com/repos/netty/netty/milestones/131/labels","id":1391004,"number":131,"title":"4.0.34.Final","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":89,"state":"open","created_at":"2015-11-03T10:48:29Z","updated_at":"2016-01-14T20:14:19Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-01-14T18:01:53Z","updated_at":"2016-01-14T20:30:09Z","closed_at":"2016-01-14T20:14:02Z","pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4709","html_url":"https://github.com/netty/netty/pull/4709","diff_url":"https://github.com/netty/netty/pull/4709.diff","patch_url":"https://github.com/netty/netty/pull/4709.patch"},"body":"Motivation:\r\n\r\n`JdkZlibDecoder` is available since Netty 4.0.8 and works with JDK7+.\r\nHowever, `io.netty.noJdkZlibDecoder` System prop evaluation always defaults to\r\ntrue, causing Netty to always use JZLib when decompressing on the\r\nclient side when the property insn't explictly set to `false`.\r\n\r\nModifications:\r\n\r\nDefault to `false` instead of `true` when JDK7+.\r\n\r\nResult:\r\n\r\nJZLib optional as expected on JDK7+."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/171770766","html_url":"https://github.com/netty/netty/pull/4709#issuecomment-171770766","issue_url":"https://api.github.com/repos/netty/netty/issues/4709","id":171770766,"user":{"login":"johnou","id":323497,"avatar_url":"https://avatars.githubusercontent.com/u/323497?v=3","gravatar_id":"","url":"https://api.github.com/users/johnou","html_url":"https://github.com/johnou","followers_url":"https://api.github.com/users/johnou/followers","following_url":"https://api.github.com/users/johnou/following{/other_user}","gists_url":"https://api.github.com/users/johnou/gists{/gist_id}","starred_url":"https://api.github.com/users/johnou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnou/subscriptions","organizations_url":"https://api.github.com/users/johnou/orgs","repos_url":"https://api.github.com/users/johnou/repos","events_url":"https://api.github.com/users/johnou/events{/privacy}","received_events_url":"https://api.github.com/users/johnou/received_events","type":"User","site_admin":false},"created_at":"2016-01-14T20:30:09Z","updated_at":"2016-01-14T20:30:09Z","body":"@slandelle how's it going to work with the following check?\r\n\r\n```java\r\npublic static ZlibEncoder newZlibEncoder(int compressionLevel) {\r\n        if (PlatformDependent.javaVersion() < 7 || noJdkZlibEncoder) {\r\n            return new JZlibEncoder(compressionLevel);\r\n        } else {\r\n            return new JdkZlibEncoder(compressionLevel);\r\n        }\r\n    }\r\n```"}}