{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1927","repository_url":"https://api.github.com/repos/RPCS3/rpcs3","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1927/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1927/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1927/events","html_url":"https://github.com/RPCS3/rpcs3/pull/1927","id":165972136,"number":1927,"title":"[WIP/IGNORE] Enable separate back and front lighting","user":{"login":"kd-11","id":15904127,"avatar_url":"https://avatars.githubusercontent.com/u/15904127?v=3","gravatar_id":"","url":"https://api.github.com/users/kd-11","html_url":"https://github.com/kd-11","followers_url":"https://api.github.com/users/kd-11/followers","following_url":"https://api.github.com/users/kd-11/following{/other_user}","gists_url":"https://api.github.com/users/kd-11/gists{/gist_id}","starred_url":"https://api.github.com/users/kd-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd-11/subscriptions","organizations_url":"https://api.github.com/users/kd-11/orgs","repos_url":"https://api.github.com/users/kd-11/repos","events_url":"https://api.github.com/users/kd-11/events{/privacy}","received_events_url":"https://api.github.com/users/kd-11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-17T11:15:24Z","updated_at":"2016-07-17T16:13:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1927","html_url":"https://github.com/RPCS3/rpcs3/pull/1927","diff_url":"https://github.com/RPCS3/rpcs3/pull/1927.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1927.patch"},"body":"Implement separate front and back diffuse lighting.\r\n\r\nNOTE:\r\nWhile implementing 2 sided diffuse and specular for vulkan, I noticed that enabling this causes bugs similar to those seen in dx12 in outrun online arcade. For some scenes, 2 sided lighting is enabled and back_diffuse_color is output by the vertex shader. However using the front face test to select correct color gives incorrect results in some cases. Note however, that this is not constant and some other scenes seem to expect the whole flag to be ignored (ingame HUD and skybox).\r\nDisabling the diffuse lighting on dx12 fixes lighting there as well."},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/233189632","html_url":"https://github.com/RPCS3/rpcs3/pull/1927#issuecomment-233189632","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1927","id":233189632,"user":{"login":"raven02","id":3000282,"avatar_url":"https://avatars.githubusercontent.com/u/3000282?v=3","gravatar_id":"","url":"https://api.github.com/users/raven02","html_url":"https://github.com/raven02","followers_url":"https://api.github.com/users/raven02/followers","following_url":"https://api.github.com/users/raven02/following{/other_user}","gists_url":"https://api.github.com/users/raven02/gists{/gist_id}","starred_url":"https://api.github.com/users/raven02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raven02/subscriptions","organizations_url":"https://api.github.com/users/raven02/orgs","repos_url":"https://api.github.com/users/raven02/repos","events_url":"https://api.github.com/users/raven02/events{/privacy}","received_events_url":"https://api.github.com/users/raven02/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T16:13:15Z","updated_at":"2016-07-17T16:13:15Z","body":"DX12 looks good as well and inline with Vulkan .\r\n\r\n![untitled](https://cloud.githubusercontent.com/assets/3000282/16901649/61174686-4c7c-11e6-8f63-68bb3706c6ad.jpg)\r\n"}}
{"actor":{"display_login":"raven02"}}