{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1359","repository_url":"https://api.github.com/repos/BloomBooks/BloomDesktop","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1359/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1359/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1359/events","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1359","id":193887174,"number":1359,"title":"BL-4027/9 and 4036 TextBox Properties dialog","user":{"login":"gmartin7","id":2300551,"avatar_url":"https://avatars.githubusercontent.com/u/2300551?v=3","gravatar_id":"","url":"https://api.github.com/users/gmartin7","html_url":"https://github.com/gmartin7","followers_url":"https://api.github.com/users/gmartin7/followers","following_url":"https://api.github.com/users/gmartin7/following{/other_user}","gists_url":"https://api.github.com/users/gmartin7/gists{/gist_id}","starred_url":"https://api.github.com/users/gmartin7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmartin7/subscriptions","organizations_url":"https://api.github.com/users/gmartin7/orgs","repos_url":"https://api.github.com/users/gmartin7/repos","events_url":"https://api.github.com/users/gmartin7/events{/privacy}","received_events_url":"https://api.github.com/users/gmartin7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-06T21:16:45Z","updated_at":"2016-12-07T22:40:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1359","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1359","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/1359.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/1359.patch"},"body":"* hook up dialog\n* factor out common code to editableDivUtils from\n   StyleEditor, toolbox and TextBoxProperties\n* put basic Language tab UI in place\n* get dialog to install data-default-languages attribute\n   in appropriate translationGroup\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomdesktop/1359)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/265596758","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1359#issuecomment-265596758","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1359","id":265596758,"user":{"login":"gmartin7","id":2300551,"avatar_url":"https://avatars.githubusercontent.com/u/2300551?v=3","gravatar_id":"","url":"https://api.github.com/users/gmartin7","html_url":"https://github.com/gmartin7","followers_url":"https://api.github.com/users/gmartin7/followers","following_url":"https://api.github.com/users/gmartin7/following{/other_user}","gists_url":"https://api.github.com/users/gmartin7/gists{/gist_id}","starred_url":"https://api.github.com/users/gmartin7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmartin7/subscriptions","organizations_url":"https://api.github.com/users/gmartin7/orgs","repos_url":"https://api.github.com/users/gmartin7/repos","events_url":"https://api.github.com/users/gmartin7/events{/privacy}","received_events_url":"https://api.github.com/users/gmartin7/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T22:40:57Z","updated_at":"2016-12-07T22:40:57Z","body":"\n\n\n\nReview status: 1 of 5 files reviewed at latest revision, 10 unresolved discussions.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/js/origami.ts, line 119 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOjypvBisE1JAzKYkR:-KYPDL60BMyPqh64V-P5:b-896fix) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/js/origami.ts#L119)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nLet's avoid abbreviations like this.\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/StyleEditor/StyleEditor.ts, line 535 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOlrC9C-uq6_TfJlqg:-KYQ-R3M1CzV7KZqnLkr:b-xishue) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/StyleEditor/StyleEditor.ts#L535)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nSo CKEditor is attaching even in this \"Change Layout\" mode, where we don't use it?\n</blockquote></details>\n\nNo, CKEditor never attaches to origami panes. Removed.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts, line 46 at r1](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYL3PAq6HTe4fC_6_ja:-KYQ57DT54A1-AEMyphY:b-ucx2ls) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/5add0b792980cd18c33198afe6217b61ec2477ca/src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts#L46)):*\n<details><summary><i>Previously, andrew-polk wrote…</i></summary><blockquote>\n\nI would try a delay before calling the code in the 'then' to see if it is, indeed, a timing issue.\n\nI'm not really comfortable with the code as is, unless we can at least understand what is happening. If it is a timing issue, there is always the possibility that availableFontNames finishes too early to really solve the problem which would result in flaky behavior for users.\n\nI guess the call to availableFontNames got in there in the first place due to being copy/modified from StyleEditor?\n</blockquote></details>\n\nMuch better! It turns out that a 0 sec setTimout call is enough to push the contents to the end of the event queue, which is all that's needed to get it to work. Removes the dependency on axios too!\n\n---\n\n*[src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts, line 54 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOkeqw0xoVsk2Kpd45:-KYQRMtU2JvTIfxDUm7r:b9v1m32) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts#L54)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nWow, this has got to be the most painful way possible of building a UI.\n</blockquote></details>\n\nHopefully I improved it a bit, but yes, you're right.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts, line 83 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOkuWnDWiCKr-97BTQ:-KYQQeWjD9uBe9bOONp_:bx735c6) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts#L83)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nIn what sense is this dialog box a \"toolbar\"?\n</blockquote></details>\n\nRenamed 'format-toolbar' to 'text-properties-dialog'. Renamed local variable 'toolbar' to 'dialogElement'.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts, line 127 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOlMy208B6Dn6CHNX8:-KYQQmdv8gH9ooEvrUan:buaywsi) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts#L127)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nIs this copy/pasted from StyleEditor? Why isn't it factored out?\n</blockquote></details>\n\nI put it in editableDivUtils. I'm not sure that's the best place for it, but at least the file name ends in Utils.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts, line 150 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOl6C3ANZ45quj8zSx:-KYQ5dmg0-NnI0mkaCpb:b-896fix) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/TextBoxProperties/TextBoxProperties.ts#L150)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nI'm missing the point of this method. Why not just construct the string where it is needed?\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/BloomBrowserUI/bookEdit/js/bloomImages.ts, line 2 at r2](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359#-KYOjfxn77tRcegQLH-F:-KYPC51Y5qEeQOk33-6I:b-896fix) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/dd594e7565c8e4bebf5d1eb1e387a576bf062a27/src/BloomBrowserUI/bookEdit/js/bloomImages.ts#L2)):*\n<details><summary><i>Previously, hatton (John Hatton) wrote…</i></summary><blockquote>\n\nHow is this related to this PR? If it is not, please remove it.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1359)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"gmartin7"}}