{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/82660863","pull_request_review_id":3553186,"id":82660863,"diff_hunk":"@@ -523,6 +535,9 @@ class _Tokenizer {\n     this._attemptCharCodeUntilFn(isNotWhitespace);\n     this._requireCharCode(chars.$GT);\n     this._endToken(prefixAndName);\n+    if (this._inNonBindableBlock()) {","path":"modules/@angular/compiler/src/ml_parser/lexer.ts","position":70,"original_position":70,"commit_id":"9acdbbe4f033fee7df2e9435ae81a6306a87e179","original_commit_id":"9acdbbe4f033fee7df2e9435ae81a6306a87e179","user":{"login":"tiagoroldao","id":1634026,"avatar_url":"https://avatars.githubusercontent.com/u/1634026?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagoroldao","html_url":"https://github.com/tiagoroldao","followers_url":"https://api.github.com/users/tiagoroldao/followers","following_url":"https://api.github.com/users/tiagoroldao/following{/other_user}","gists_url":"https://api.github.com/users/tiagoroldao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoroldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoroldao/subscriptions","organizations_url":"https://api.github.com/users/tiagoroldao/orgs","repos_url":"https://api.github.com/users/tiagoroldao/repos","events_url":"https://api.github.com/users/tiagoroldao/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoroldao/received_events","type":"User","site_admin":false},"body":"A first draft for clarity. Let me know if you prefer to move the logic/approach this in another way.\r\n```javascript\r\nprivate _checkNonBindableElementDepth () {\r\n    let currentToken: Token = this.tokens[this.tokens.length - 1];\r\n\r\n    if (currentToken.type === TokenType.TAG_OPEN_END || \r\n        currentToken.type === TokenType.TAG_OPEN_END_VOID || \r\n        currentToken.type === TokenType.TAG_CLOSE) {\r\n      // check if this closes any previous, react\r\n    }\r\n\r\n    if (currentToken.type === TokenType.TAG_OPEN_END) {\r\n      if (this._inNonBindableElement()) {\r\n        this._nonBindableElementDepth++;\r\n      }\r\n      else if (/* tag contains ngNonBindable attr */){\r\n        \r\n      }\r\n    }\r\n    else if (currentToken.type === TokenType.TAG_CLOSE) {\r\n      if (this._inNonBindableElement()) {\r\n        this._nonBindableElementDepth--;\r\n      }\r\n    }\r\n  };\r\n```","created_at":"2016-10-10T18:44:04Z","updated_at":"2016-10-10T18:44:04Z","html_url":"https://github.com/angular/angular/pull/12178#discussion_r82660863","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/12178","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/82660863"},"html":{"href":"https://github.com/angular/angular/pull/12178#discussion_r82660863"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/12178"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/12178","id":88565410,"html_url":"https://github.com/angular/angular/pull/12178","diff_url":"https://github.com/angular/angular/pull/12178.diff","patch_url":"https://github.com/angular/angular/pull/12178.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/12178","number":12178,"state":"open","locked":false,"title":"fix(compiler): bypass expansion form tokenizing in ngNonBindable blocks","user":{"login":"tiagoroldao","id":1634026,"avatar_url":"https://avatars.githubusercontent.com/u/1634026?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagoroldao","html_url":"https://github.com/tiagoroldao","followers_url":"https://api.github.com/users/tiagoroldao/followers","following_url":"https://api.github.com/users/tiagoroldao/following{/other_user}","gists_url":"https://api.github.com/users/tiagoroldao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoroldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoroldao/subscriptions","organizations_url":"https://api.github.com/users/tiagoroldao/orgs","repos_url":"https://api.github.com/users/tiagoroldao/repos","events_url":"https://api.github.com/users/tiagoroldao/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoroldao/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [not required] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nSee #11859 \r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n\r\nfixes #11859","created_at":"2016-10-09T02:07:10Z","updated_at":"2016-10-10T18:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa7b51984b2885cf297e38265cde3aa06a26f14f","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"assignees":[{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/12178/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/12178/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/12178/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/9acdbbe4f033fee7df2e9435ae81a6306a87e179","head":{"label":"tiagoroldao:issue_11859","ref":"issue_11859","sha":"9acdbbe4f033fee7df2e9435ae81a6306a87e179","user":{"login":"tiagoroldao","id":1634026,"avatar_url":"https://avatars.githubusercontent.com/u/1634026?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagoroldao","html_url":"https://github.com/tiagoroldao","followers_url":"https://api.github.com/users/tiagoroldao/followers","following_url":"https://api.github.com/users/tiagoroldao/following{/other_user}","gists_url":"https://api.github.com/users/tiagoroldao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoroldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoroldao/subscriptions","organizations_url":"https://api.github.com/users/tiagoroldao/orgs","repos_url":"https://api.github.com/users/tiagoroldao/repos","events_url":"https://api.github.com/users/tiagoroldao/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoroldao/received_events","type":"User","site_admin":false},"repo":{"id":69032188,"name":"angular","full_name":"tiagoroldao/angular","owner":{"login":"tiagoroldao","id":1634026,"avatar_url":"https://avatars.githubusercontent.com/u/1634026?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagoroldao","html_url":"https://github.com/tiagoroldao","followers_url":"https://api.github.com/users/tiagoroldao/followers","following_url":"https://api.github.com/users/tiagoroldao/following{/other_user}","gists_url":"https://api.github.com/users/tiagoroldao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoroldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoroldao/subscriptions","organizations_url":"https://api.github.com/users/tiagoroldao/orgs","repos_url":"https://api.github.com/users/tiagoroldao/repos","events_url":"https://api.github.com/users/tiagoroldao/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoroldao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiagoroldao/angular","description":null,"fork":true,"url":"https://api.github.com/repos/tiagoroldao/angular","forks_url":"https://api.github.com/repos/tiagoroldao/angular/forks","keys_url":"https://api.github.com/repos/tiagoroldao/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiagoroldao/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiagoroldao/angular/teams","hooks_url":"https://api.github.com/repos/tiagoroldao/angular/hooks","issue_events_url":"https://api.github.com/repos/tiagoroldao/angular/issues/events{/number}","events_url":"https://api.github.com/repos/tiagoroldao/angular/events","assignees_url":"https://api.github.com/repos/tiagoroldao/angular/assignees{/user}","branches_url":"https://api.github.com/repos/tiagoroldao/angular/branches{/branch}","tags_url":"https://api.github.com/repos/tiagoroldao/angular/tags","blobs_url":"https://api.github.com/repos/tiagoroldao/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiagoroldao/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiagoroldao/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiagoroldao/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiagoroldao/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/tiagoroldao/angular/languages","stargazers_url":"https://api.github.com/repos/tiagoroldao/angular/stargazers","contributors_url":"https://api.github.com/repos/tiagoroldao/angular/contributors","subscribers_url":"https://api.github.com/repos/tiagoroldao/angular/subscribers","subscription_url":"https://api.github.com/repos/tiagoroldao/angular/subscription","commits_url":"https://api.github.com/repos/tiagoroldao/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiagoroldao/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiagoroldao/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiagoroldao/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiagoroldao/angular/contents/{+path}","compare_url":"https://api.github.com/repos/tiagoroldao/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiagoroldao/angular/merges","archive_url":"https://api.github.com/repos/tiagoroldao/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiagoroldao/angular/downloads","issues_url":"https://api.github.com/repos/tiagoroldao/angular/issues{/number}","pulls_url":"https://api.github.com/repos/tiagoroldao/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/tiagoroldao/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/tiagoroldao/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiagoroldao/angular/labels{/name}","releases_url":"https://api.github.com/repos/tiagoroldao/angular/releases{/id}","deployments_url":"https://api.github.com/repos/tiagoroldao/angular/deployments","created_at":"2016-09-23T14:26:00Z","updated_at":"2016-09-23T14:26:21Z","pushed_at":"2016-10-10T07:34:57Z","git_url":"git://github.com/tiagoroldao/angular.git","ssh_url":"git@github.com:tiagoroldao/angular.git","clone_url":"https://github.com/tiagoroldao/angular.git","svn_url":"https://github.com/tiagoroldao/angular","homepage":"https://angular.io","size":29302,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f5b0e22d352fd00cee1dc9016e85bdef94256e62","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-10-10T17:25:32Z","pushed_at":"2016-10-10T18:41:31Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":646734,"stargazers_count":17137,"watchers_count":17137,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4343,"mirror_url":null,"open_issues_count":881,"forks":4343,"open_issues":881,"watchers":17137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/12178"},"html":{"href":"https://github.com/angular/angular/pull/12178"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/12178"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/12178/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/12178/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/12178/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/9acdbbe4f033fee7df2e9435ae81a6306a87e179"}}}}
{"actor":{"display_login":"tiagoroldao"}}