{"action":"closed","number":5439,"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5439","id":72434120,"html_url":"https://github.com/elastic/logstash/pull/5439","diff_url":"https://github.com/elastic/logstash/pull/5439.diff","patch_url":"https://github.com/elastic/logstash/pull/5439.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5439","number":5439,"state":"closed","locked":false,"title":"Add URI config validator/type","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"Often times plugins (like the Elasticsearch output) can naturally use URIs for their configuration.\r\nUnfortunately using the :string type here means that the password portion of the URI can easily be leaked.\r\n\r\nThis wraps the URI class in a new LogStash::Util::SafeURI class that proxies all regular URI methods but masks\r\nthe password when `#to_s` and `#inspect` are invoked.","created_at":"2016-06-02T23:31:58Z","updated_at":"2016-06-09T12:33:14Z","closed_at":"2016-06-09T12:33:14Z","merged_at":null,"merge_commit_sha":"d76cb2e4a90c1039abac6aa7db730ef168db1bac","assignee":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5439/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5439/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5439/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/ff4814123652e062f7b92aaae6a2974dfaec8ae6","head":{"label":"andrewvc:url-validator","ref":"url-validator","sha":"ff4814123652e062f7b92aaae6a2974dfaec8ae6","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37559198,"name":"logstash","full_name":"andrewvc/logstash","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/andrewvc/logstash","forks_url":"https://api.github.com/repos/andrewvc/logstash/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/logstash/deployments","created_at":"2015-06-16T22:23:09Z","updated_at":"2015-06-16T22:23:11Z","pushed_at":"2016-06-06T23:07:25Z","git_url":"git://github.com/andrewvc/logstash.git","ssh_url":"git@github.com:andrewvc/logstash.git","clone_url":"https://github.com/andrewvc/logstash.git","svn_url":"https://github.com/andrewvc/logstash","homepage":"https://www.elastic.co/products/logstash","size":78247,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c5610505c793497fa3aeb38550dbea5510e02663","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-06-09T10:13:40Z","pushed_at":"2016-06-09T12:33:04Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":89001,"stargazers_count":5973,"watchers_count":5973,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1792,"mirror_url":null,"open_issues_count":746,"forks":1792,"open_issues":746,"watchers":5973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5439"},"html":{"href":"https://github.com/elastic/logstash/pull/5439"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5439"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5439/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5439/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5439/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/ff4814123652e062f7b92aaae6a2974dfaec8ae6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":5,"commits":1,"additions":140,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"elasticsearch-bot"}}