{"push_id":1107832385,"size":248,"distinct_size":18,"ref":"refs/heads/fix-20678","head":"e22146a58b93d4a5ea53ef481387738f58bb1fd5","before":"4ce5b90c6b61b2c3a79731e024697f77808883be","commits":[{"sha":"8ca8a2d773b942c4ea76baabe2df502a339d05b1","author":{"email":"67694853bf7ec18265cf9799549f3660b4e0121a@unboxedconsulting.com","name":"Andrew White"},"message":"Refactor handling of :action default in routing\n\nThe longstanding convention in Rails is that if the :action parameter\nis missing or nil then it defaults to 'index'. Up until Rails 5.0.0.beta1\nthis was handled slightly differently than other routing defaults by\ndeleting it from the route options and adding it to the recall parameters.\n\nWith the recent focus of removing unnecessary duplications this has\nexposed a problem in this strategy - we are now mutating the request's\npath parameters and causing problems for later url generation. This will\ntypically affect url_for rather a named url helper since the latter\nexplicitly pass :controller, :action, etc.\n\nThe fix is to add a default for :action in the route class if the path\ncontains an :action segment and no default is passed. This change also\nrevealed an issue with the parameterized part expiry in that it doesn't\nfollow a right to left order - as soon as a dynamic segment is required\nthen all other segments become required.\n\nFixes #23019.","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/8ca8a2d773b942c4ea76baabe2df502a339d05b1"},{"sha":"b43158afba7fb4de6a3530d4f4e940f0c89bd057","author":{"email":"39cf178cf6dad8b7e84ad1f63409d0753fd6d701@gmail.com","name":"Ryan T. Hosford"},"message":"Fixes #23964\n\n  - Adds #each_chunk to ActionDispatch::Response. it's a method which\n    will be called by ActionDispatch::Response#each.\n  - Make Response#each a proper method instead of delegating to @stream\n  - In Live, instead of overriding #each, override #each_chunk.\n  - `#each` should just spit out @str_body if it's already set\n  - Adds #test_set_header_after_read_body_during_action\n    to prove this fixes #23964\n  - Adds #test_each_isnt_called_if_str_body_is_written to\n    ensure #each_chunk is not called when @str_body is available\n  - Call `@response.sent!` in AC::TestCase's #perform so a test response\n    acts a bit more like a real response. Makes test that call  `#assert_stream_closed`\n    pass again.\n  - Additionally assert `#committed?` in `#assert_stream_closed`\n  - Make test that was calling @response.stream.each pass again by\n    calling @response.each instead.","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/b43158afba7fb4de6a3530d4f4e940f0c89bd057"},{"sha":"c89e6926a002c148af52d036f16c26f88a5f99d0","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"[ci skip] Update code used for filtering passwords in the configuring guide","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/c89e6926a002c148af52d036f16c26f88a5f99d0"},{"sha":"343e2647b39fa087444a94b6110e6d5809bc50eb","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"[ci skip] Fix formatting of code snippet in Action Cable guide","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/343e2647b39fa087444a94b6110e6d5809bc50eb"},{"sha":"7ab5682ebe1ead09a415eccfae56cdcfea440e6f","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"s/Thoughtbot/thoughtbot/\n\nSee https://github.com/thoughtbot/presskit/blob/master/README.md#name for name capitalization.\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/7ab5682ebe1ead09a415eccfae56cdcfea440e6f"},{"sha":"72360dd11ac5f59973b8255ba459fb5ad111e1af","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"- Fix typo in config guide, from config.logger section\n- Make bulleted lists, end properly\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/72360dd11ac5f59973b8255ba459fb5ad111e1af"},{"sha":"6ab0637da83429187b7191fac87cdce327e656cb","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"[ci skip] Typo fix. `loggs` -> `logs`","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/6ab0637da83429187b7191fac87cdce327e656cb"},{"sha":"ab4361698a7c632d368fa8259b7287e86345887a","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"[ci skip] Add some missing commas","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/ab4361698a7c632d368fa8259b7287e86345887a"},{"sha":"fe9bd013e2806066e0e43b8b0b4dabab0c8549d1","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"- Make sure we end sentences\n- Change from \"The Task\" to \"The Update Task\" as referred elsewhere\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/fe9bd013e2806066e0e43b8b0b4dabab0c8549d1"},{"sha":"68ece40a383863c4bc63a4bc13a207ac016ab8c5","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"- Be consistent in providing file locations of schema, model and initializer\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/68ece40a383863c4bc63a4bc13a207ac016ab8c5"},{"sha":"cbb25c4b1cb96cc6e857c3c05896056ec81931bf","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"Expand on Action Mailer Fragment caching tests","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/cbb25c4b1cb96cc6e857c3c05896056ec81931bf"},{"sha":"efb98e138fbbdca65501cc1770398adc6f621ba1","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"s/determins/determines/\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/efb98e138fbbdca65501cc1770398adc6f621ba1"},{"sha":"2ef7741305298ff13618eca82a3d9b9cc0c133b7","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Aline results of code examples in comments","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/2ef7741305298ff13618eca82a3d9b9cc0c133b7"},{"sha":"60c6b538170ce35cc8ff8382bef2f082868b4b09","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Discart the schema and host information when building the per-form token\n\nWhen the token is generated by the form we were using the schema and\nhost information while only using the path to compare if the action was\nthe same. This was causing the token to be invalid.\n\nTo fix this we use the same information to generate the token and check\nit.\n\nFix #24257","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/60c6b538170ce35cc8ff8382bef2f082868b4b09"},{"sha":"db3f68f4d733437ade5d0668b981542b2e0873b2","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"`debug_exception_format` is set to :api by default for API apps only, not for normal apps.\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/db3f68f4d733437ade5d0668b981542b2e0873b2"},{"sha":"4d770712595ae1d4937d602dce7ab1220ec6ef7f","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"Mention default values for `debug_exception_response_format` in configuring guide [ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/4d770712595ae1d4937d602dce7ab1220ec6ef7f"},{"sha":"7f9c9d6dcbe83f857639b7ac6dd2f79295fef875","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"be specific when the debug_exception_response_format to :api\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/7f9c9d6dcbe83f857639b7ac6dd2f79295fef875"},{"sha":"0f91e2bc2591340369c7644678eab6c1d93043c1","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"s/statment/statement/","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/0f91e2bc2591340369c7644678eab6c1d93043c1"},{"sha":"7463aa19b1a1492bcc6aeb61e3163a893856453c","author":{"email":"be11b38ca2a8492ea688531e4730d7fc0f6b7beb@hashref.com","name":"Xavier Noria"},"message":"rewords code comment [ci skip]\n\nThis alternative flows better.\n\n[Richard Schneeman & Xavier Noria]","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/7463aa19b1a1492bcc6aeb61e3163a893856453c"},{"sha":"6c6eeda54d0f2c8e689772b50cc5c4419fa82749","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"Follow up of #23461\n\n- Rename max to statement_limit\n- Remove magic number 1000 from everywhere\n- Defined StatementPool::DEFAULT_STATEMENT_LIMIT and started using it everywhere\n\nSigned-off-by: Jeremy Daer <jeremydaer@gmail.com>","distinct":false,"url":"https://api.github.com/repos/maclover7/rails/commits/6c6eeda54d0f2c8e689772b50cc5c4419fa82749"}]}