{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/54925138","id":54925138,"diff_hunk":"@@ -666,10 +666,13 @@ - (ASLayout *)transitionLayoutWithAnimation:(BOOL)animated\n \n - (ASLayout *)transitionLayoutWithSizeRange:(ASSizeRange)constrainedSize animated:(BOOL)animated\n {\n+  BOOL disableImplicitHierarchyManagement = self.usesImplicitHierarchyManagement == NO;","path":"AsyncDisplayKit/ASDisplayNode.mm","position":13,"original_position":13,"commit_id":"4601cd5d1ec7ca6dc0a27df0b6c25877354a3cb8","original_commit_id":"4601cd5d1ec7ca6dc0a27df0b6c25877354a3cb8","user":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"body":"Either way is fine. This flag is going to be removed before 2.0 once I fix some of the ordering issues with the implicit hierarchy operations and also include support for manually managed nodes.","created_at":"2016-03-03T18:37:12Z","updated_at":"2016-03-03T18:37:12Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1313#discussion_r54925138","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/54925138"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1313#discussion_r54925138"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313","id":61587395,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1313","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1313.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1313.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1313","number":1313,"state":"open","locked":false,"title":"Preserve usesImplicitHierarchyManagement when doing animations","user":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"body":"Currently the flag was being reset to NO in all cases. It should ignore turning off the hierarchy management when the user has already enabled it.","created_at":"2016-03-03T16:40:15Z","updated_at":"2016-03-03T18:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502077f947f6ab75667ed91bec635aa3510d4a23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1313/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/4601cd5d1ec7ca6dc0a27df0b6c25877354a3cb8","head":{"label":"levi:patch-6","ref":"patch-6","sha":"4601cd5d1ec7ca6dc0a27df0b6c25877354a3cb8","user":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"repo":{"id":35245356,"name":"AsyncDisplayKit","full_name":"levi/AsyncDisplayKit","owner":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/levi/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/levi/AsyncDisplayKit","forks_url":"https://api.github.com/repos/levi/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/levi/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levi/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levi/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/levi/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/levi/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/levi/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/levi/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/levi/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levi/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/levi/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/levi/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/levi/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/levi/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/levi/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/levi/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/levi/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/levi/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/levi/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levi/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/levi/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levi/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/levi/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/levi/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/levi/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levi/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/levi/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/levi/AsyncDisplayKit/deployments","created_at":"2015-05-07T21:50:39Z","updated_at":"2016-01-16T07:48:47Z","pushed_at":"2016-03-03T16:40:08Z","git_url":"git://github.com/levi/AsyncDisplayKit.git","ssh_url":"git@github.com:levi/AsyncDisplayKit.git","clone_url":"https://github.com/levi/AsyncDisplayKit.git","svn_url":"https://github.com/levi/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":17775,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f27ea719da8d89d67a58f02c41bdaa92a8bef4ed","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-03-03T13:52:29Z","pushed_at":"2016-03-03T17:24:44Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":18527,"stargazers_count":7412,"watchers_count":7412,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1158,"mirror_url":null,"open_issues_count":188,"forks":1158,"open_issues":188,"watchers":7412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1313"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1313"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/4601cd5d1ec7ca6dc0a27df0b6c25877354a3cb8"}}}}