{"action":"created","issue":{"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/325","repository_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks","labels_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/325/labels{/name}","comments_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/325/comments","events_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/325/events","html_url":"https://github.com/sosy-lab/sv-benchmarks/issues/325","id":195076298,"number":325,"title":"ntdriver benchmarks are not memory safe","user":{"login":"mchalupa","id":2385056,"avatar_url":"https://avatars.githubusercontent.com/u/2385056?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalupa","html_url":"https://github.com/mchalupa","followers_url":"https://api.github.com/users/mchalupa/followers","following_url":"https://api.github.com/users/mchalupa/following{/other_user}","gists_url":"https://api.github.com/users/mchalupa/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalupa/subscriptions","organizations_url":"https://api.github.com/users/mchalupa/orgs","repos_url":"https://api.github.com/users/mchalupa/repos","events_url":"https://api.github.com/users/mchalupa/events{/privacy}","received_events_url":"https://api.github.com/users/mchalupa/received_events","type":"User","site_admin":false},"labels":[{"id":472360268,"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/labels/issue%20with%20benchmark","name":"issue with benchmark","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/milestones/2","html_url":"https://github.com/sosy-lab/sv-benchmarks/milestone/2","labels_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/milestones/2/labels","id":2159340,"number":2,"title":"SV-COMP'18","description":"","creator":{"login":"PhilippWendler","id":2545335,"avatar_url":"https://avatars.githubusercontent.com/u/2545335?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippWendler","html_url":"https://github.com/PhilippWendler","followers_url":"https://api.github.com/users/PhilippWendler/followers","following_url":"https://api.github.com/users/PhilippWendler/following{/other_user}","gists_url":"https://api.github.com/users/PhilippWendler/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippWendler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippWendler/subscriptions","organizations_url":"https://api.github.com/users/PhilippWendler/orgs","repos_url":"https://api.github.com/users/PhilippWendler/repos","events_url":"https://api.github.com/users/PhilippWendler/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippWendler/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2016-11-27T16:30:34Z","updated_at":"2016-12-15T17:23:57Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-12-12T20:24:55Z","updated_at":"2016-12-15T17:24:40Z","closed_at":null,"body":"Hi,\r\n\r\nI was just going through this `ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c` benchmark again (#290) and found out that it is still not memory safe at all. There is a bunch of places where an invalid memory dereference can occur.\r\n\r\n1.  here is an out-of-bound access https://github.com/sosy-lab/sv-benchmarks/blob/master/c/ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c#L1681\r\n2. here the DriverExtension is not allocated https://github.com/sosy-lab/sv-benchmarks/blob/master/c/ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c#L1688 (actually, it is usage of uninitialized automatic value)\r\n3. here the DeviceExtension is not allocated https://github.com/sosy-lab/sv-benchmarks/blob/master/c/ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c#L1709\r\n4. here (and on many other places) a uninitialized pointer is loaded https://github.com/sosy-lab/sv-benchmarks/blob/master/c/ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c#L1744 and dereferenced later (e.g. https://github.com/sosy-lab/sv-benchmarks/blob/master/c/ntdrivers/kbfiltr_false-unreach-call_true-valid-memsafety.i.cil.c#L1746)\r\n\r\nThe question is what to do with it? Should I try fix all these errors or should we drop the benchmark (we already have the false-valid-deref version)?\r\n\r\nThanks,\r\nMarek"},"comment":{"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/comments/267387878","html_url":"https://github.com/sosy-lab/sv-benchmarks/issues/325#issuecomment-267387878","issue_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/325","id":267387878,"user":{"login":"dbeyer","id":2941008,"avatar_url":"https://avatars.githubusercontent.com/u/2941008?v=3","gravatar_id":"","url":"https://api.github.com/users/dbeyer","html_url":"https://github.com/dbeyer","followers_url":"https://api.github.com/users/dbeyer/followers","following_url":"https://api.github.com/users/dbeyer/following{/other_user}","gists_url":"https://api.github.com/users/dbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbeyer/subscriptions","organizations_url":"https://api.github.com/users/dbeyer/orgs","repos_url":"https://api.github.com/users/dbeyer/repos","events_url":"https://api.github.com/users/dbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dbeyer/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T17:24:40Z","updated_at":"2016-12-15T17:24:40Z","body":"Is the conclusion that these should be fixed later?  So I added milestone SV-COMP 2018."}}
{"actor":{"display_login":"dbeyer"}}