{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/58126750","id":58126750,"diff_hunk":"@@ -1210,10 +1235,33 @@ fi\n \n # Check for Greenplum Query Optimizer (orca) and supporting Greenplum OS header files.\n AS_IF([test \"$enable_orca\" = yes],\n-[ # then\n+[\n+  if test x\"$with_xerces\" = x; then\n+    AC_CHECK_HEADERS(xerces/util/XercesVersion.hpp, [], [AC_MSG_ERROR([Xerces-C includes required for Greenplum Query Optimizer (orca), not found in \"$with_xerces/include\"])])\n+  else\n+    save_cppflags=$CPPFLAGS\n+\tCPPFLAGS=\"-I$with_xerces/include\"","path":"configure.in","position":49,"original_position":49,"commit_id":"2df675b57b6a183deffba7d0dfa776503679c589","original_commit_id":"2df675b57b6a183deffba7d0dfa776503679c589","user":{"login":"d","id":440892,"avatar_url":"https://avatars.githubusercontent.com/u/440892?v=3","gravatar_id":"","url":"https://api.github.com/users/d","html_url":"https://github.com/d","followers_url":"https://api.github.com/users/d/followers","following_url":"https://api.github.com/users/d/following{/other_user}","gists_url":"https://api.github.com/users/d/gists{/gist_id}","starred_url":"https://api.github.com/users/d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d/subscriptions","organizations_url":"https://api.github.com/users/d/orgs","repos_url":"https://api.github.com/users/d/repos","events_url":"https://api.github.com/users/d/events{/privacy}","received_events_url":"https://api.github.com/users/d/received_events","type":"User","site_admin":false},"body":"ll. 1243-1249 are indented by a TAB where I guess we expect 4 spaces, fat finger, @danielgustafsson ?","created_at":"2016-03-31T20:59:26Z","updated_at":"2016-03-31T20:59:26Z","html_url":"https://github.com/greenplum-db/gpdb/pull/428#discussion_r58126750","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/58126750"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/428#discussion_r58126750"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428","id":60521600,"html_url":"https://github.com/greenplum-db/gpdb/pull/428","diff_url":"https://github.com/greenplum-db/gpdb/pull/428.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/428.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/428","number":428,"state":"open","locked":false,"title":"Support GPORCA building in autoconf [#116156561]","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"**Disclaimer:** I don't fully grok everything in `gpAux/releng/` et.al with regards to how (and if) it relates to the OSS build of GPDB/[GPORCA](https://github.com/greenplum-db/gporca) so I might be missing something but this patch makes GPORCA work for me out of the box with just `make install` which is exciting. I have only tested this on OS X so far since I'd rather get feedback early before investing time on it, reports from Linux are highly welcome.\r\n\r\nThe `--enable-orca` autoconf switch was setting up some of the required scaffolding for building GPDB with GPORCA but not all that is needed to get a working GPDB with GPORCA out of the box. The makefiles were assuming builds in `gpAux/ext` which isn't the case when building GPORCA from source out of the OSS repository. Also, since GPORCA requires a patched version of Xerces-C which generally won't be available as a system library this needs to be handled in autoconf. The main changes in this patch:\r\n\r\n* Adds a `--with-xerces=DIR` autoconf setting which is used to identify the location of the patched Xerces-C library needed by GPORCA. Once GPORCA no longer requires a patched version this can be removed.\r\n* Checks for all used header files of the required libraries. This does of course take extra time but I think it's worth it, configure isn't executed that often and it immediately caught an issue in preprocessing the header files.\r\n* Checks for all require libraries.\r\n* Extracts the actual version of Xerces-C linked against rather than depending on a hardcoded values.\r\n* Sets the linking of the GPORCA libraries properly in `src/backend/gpopt`.\r\n* Installs the libdxltranslators library on `make install`.\r\n\r\nAll of this still requires a GPORCA properly built and installed as per the build instructions in the GPORCA repository. Should the libs from GPORCA be installed with a `--prefix` then this needs to be added to GPDB autoconf invocation with the `--with-libraries=DIR` option.\r\n\r\nI have attempted to not alter the existing behaviour in `gpAux/releng` which should mostly work like before (but thats untested).","created_at":"2016-02-24T15:01:41Z","updated_at":"2016-03-31T20:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5958c9b98b024293f139bc5e797a8ecacc7d2c0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/428/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/2df675b57b6a183deffba7d0dfa776503679c589","head":{"label":"danielgustafsson:enable_orca","ref":"enable_orca","sha":"2df675b57b6a183deffba7d0dfa776503679c589","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"repo":{"id":45419965,"name":"gpdb","full_name":"danielgustafsson/gpdb","owner":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielgustafsson/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/danielgustafsson/gpdb","forks_url":"https://api.github.com/repos/danielgustafsson/gpdb/forks","keys_url":"https://api.github.com/repos/danielgustafsson/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielgustafsson/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielgustafsson/gpdb/teams","hooks_url":"https://api.github.com/repos/danielgustafsson/gpdb/hooks","issue_events_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/danielgustafsson/gpdb/events","assignees_url":"https://api.github.com/repos/danielgustafsson/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/danielgustafsson/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/danielgustafsson/gpdb/tags","blobs_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielgustafsson/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/danielgustafsson/gpdb/languages","stargazers_url":"https://api.github.com/repos/danielgustafsson/gpdb/stargazers","contributors_url":"https://api.github.com/repos/danielgustafsson/gpdb/contributors","subscribers_url":"https://api.github.com/repos/danielgustafsson/gpdb/subscribers","subscription_url":"https://api.github.com/repos/danielgustafsson/gpdb/subscription","commits_url":"https://api.github.com/repos/danielgustafsson/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielgustafsson/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielgustafsson/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/danielgustafsson/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielgustafsson/gpdb/merges","archive_url":"https://api.github.com/repos/danielgustafsson/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielgustafsson/gpdb/downloads","issues_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/danielgustafsson/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/danielgustafsson/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/danielgustafsson/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielgustafsson/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/danielgustafsson/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/danielgustafsson/gpdb/deployments","created_at":"2015-11-02T20:26:32Z","updated_at":"2015-11-02T20:27:17Z","pushed_at":"2016-03-31T20:58:06Z","git_url":"git://github.com/danielgustafsson/gpdb.git","ssh_url":"git@github.com:danielgustafsson/gpdb.git","clone_url":"https://github.com/danielgustafsson/gpdb.git","svn_url":"https://github.com/danielgustafsson/gpdb","homepage":"http://greenplum.org","size":148534,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"fd2e045f1a5b916125c645cbd352a4fcac7711fa","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-03-31T16:23:52Z","pushed_at":"2016-03-31T20:29:02Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":150144,"stargazers_count":1382,"watchers_count":1382,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":345,"mirror_url":null,"open_issues_count":85,"forks":345,"open_issues":85,"watchers":1382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/428"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/428"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/2df675b57b6a183deffba7d0dfa776503679c589"}}}}