{"action":"created","comment":{"url":"https://api.github.com/repos/blaze/blaze/pulls/comments/73153827","id":73153827,"diff_hunk":"@@ -367,20 +367,20 @@ def compute(expr, d, return_type=no_default, **kwargs):\n         The blaze expression to compute.\n     d : any\n         The data source to compute expression on.\n-    return_type : {'native', 'core', type}, optional\n-        Type to return data as. Defaults to 'native' but will be changed\n-        to 'core' in version 0.11.  'core' forces the computation into a core\n-        type. 'native' returns the result as is from the respective backend's\n-        ``post_compute``. If a type is passed, it will odo the result into the\n-        type before returning.\n+    return_type : {'core', 'native', type}, optional\n+        Type to return data as.  Defaults to 'core' since version 0.11.1.\n+        'core' forces the computation into a core type. 'native' returns\n+        the result as is from the respective backend's ``post_compute``.\n+        If a type is passed, it will odo the result into the type before\n+        returning.\n \n     Examples\n     --------\n     >>> t = symbol('t', 'var * {name: string, balance: int}')\n     >>> deadbeats = t[t['balance'] < 0]['name']\n \n     >>> data = [['Alice', 100], ['Bob', -50], ['Charlie', -20]]\n-    >>> list(compute(deadbeats, {t: data}))\n+    >>> list(compute(deadbeats, {t: data}, return_type='native'))","path":"blaze/compute/core.py","position":33,"original_position":33,"commit_id":"76f2a4dc09ad7498f783eb89e8b3c6f84871c50a","original_commit_id":"76f2a4dc09ad7498f783eb89e8b3c6f84871c50a","user":{"login":"skrah","id":16530421,"avatar_url":"https://avatars.githubusercontent.com/u/16530421?v=3","gravatar_id":"","url":"https://api.github.com/users/skrah","html_url":"https://github.com/skrah","followers_url":"https://api.github.com/users/skrah/followers","following_url":"https://api.github.com/users/skrah/following{/other_user}","gists_url":"https://api.github.com/users/skrah/gists{/gist_id}","starred_url":"https://api.github.com/users/skrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrah/subscriptions","organizations_url":"https://api.github.com/users/skrah/orgs","repos_url":"https://api.github.com/users/skrah/repos","events_url":"https://api.github.com/users/skrah/events{/privacy}","received_events_url":"https://api.github.com/users/skrah/received_events","type":"User","site_admin":false},"body":"@kwmsmith Currently the return type is necessary:\r\n\r\n```python\r\n>>> list(compute(deadbeats, {t: data}))\r\nTraceback (most recent call last):\r\n...\r\nAttributeError: 'NoneType' object has no attribute 'measure'\r\n```\r\n\r\nIn many places ```return_type='native'``` is hardcoded (for lack of a better word)\r\nwhen ```compute``` is used internally.  Example:\r\n\r\nhttps://github.com/blaze/blaze/blob/master/blaze/compute/sql.py#L125\r\n\r\nShould that always be the case?  If so, perhaps the argument is missing in \r\nsome places.\r\n\r\n","created_at":"2016-08-02T13:26:36Z","updated_at":"2016-08-02T13:26:36Z","html_url":"https://github.com/blaze/blaze/pull/1559#discussion_r73153827","pull_request_url":"https://api.github.com/repos/blaze/blaze/pulls/1559","_links":{"self":{"href":"https://api.github.com/repos/blaze/blaze/pulls/comments/73153827"},"html":{"href":"https://github.com/blaze/blaze/pull/1559#discussion_r73153827"},"pull_request":{"href":"https://api.github.com/repos/blaze/blaze/pulls/1559"}}},"pull_request":{"url":"https://api.github.com/repos/blaze/blaze/pulls/1559","id":79574625,"html_url":"https://github.com/blaze/blaze/pull/1559","diff_url":"https://github.com/blaze/blaze/pull/1559.diff","patch_url":"https://github.com/blaze/blaze/pull/1559.patch","issue_url":"https://api.github.com/repos/blaze/blaze/issues/1559","number":1559,"state":"open","locked":false,"title":"compute(): change default of 'return_type' parameter to 'core'.","user":{"login":"skrah","id":16530421,"avatar_url":"https://avatars.githubusercontent.com/u/16530421?v=3","gravatar_id":"","url":"https://api.github.com/users/skrah","html_url":"https://github.com/skrah","followers_url":"https://api.github.com/users/skrah/followers","following_url":"https://api.github.com/users/skrah/following{/other_user}","gists_url":"https://api.github.com/users/skrah/gists{/gist_id}","starred_url":"https://api.github.com/users/skrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrah/subscriptions","organizations_url":"https://api.github.com/users/skrah/orgs","repos_url":"https://api.github.com/users/skrah/repos","events_url":"https://api.github.com/users/skrah/events{/privacy}","received_events_url":"https://api.github.com/users/skrah/received_events","type":"User","site_admin":false},"body":"Implementation for #1551.","created_at":"2016-08-01T14:11:31Z","updated_at":"2016-08-02T13:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf58ebc38c7ec7a76322b8755cd106e4cf43951","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/blaze/blaze/milestones/20","html_url":"https://github.com/blaze/blaze/milestones/0.12","labels_url":"https://api.github.com/repos/blaze/blaze/milestones/20/labels","id":1892915,"number":20,"title":"0.12","description":"","creator":{"login":"kwmsmith","id":288771,"avatar_url":"https://avatars.githubusercontent.com/u/288771?v=3","gravatar_id":"","url":"https://api.github.com/users/kwmsmith","html_url":"https://github.com/kwmsmith","followers_url":"https://api.github.com/users/kwmsmith/followers","following_url":"https://api.github.com/users/kwmsmith/following{/other_user}","gists_url":"https://api.github.com/users/kwmsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/kwmsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwmsmith/subscriptions","organizations_url":"https://api.github.com/users/kwmsmith/orgs","repos_url":"https://api.github.com/users/kwmsmith/repos","events_url":"https://api.github.com/users/kwmsmith/events{/privacy}","received_events_url":"https://api.github.com/users/kwmsmith/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2016-07-19T20:40:45Z","updated_at":"2016-08-02T12:31:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/blaze/blaze/pulls/1559/commits","review_comments_url":"https://api.github.com/repos/blaze/blaze/pulls/1559/comments","review_comment_url":"https://api.github.com/repos/blaze/blaze/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blaze/blaze/issues/1559/comments","statuses_url":"https://api.github.com/repos/blaze/blaze/statuses/76f2a4dc09ad7498f783eb89e8b3c6f84871c50a","head":{"label":"skrah:return_type","ref":"return_type","sha":"76f2a4dc09ad7498f783eb89e8b3c6f84871c50a","user":{"login":"skrah","id":16530421,"avatar_url":"https://avatars.githubusercontent.com/u/16530421?v=3","gravatar_id":"","url":"https://api.github.com/users/skrah","html_url":"https://github.com/skrah","followers_url":"https://api.github.com/users/skrah/followers","following_url":"https://api.github.com/users/skrah/following{/other_user}","gists_url":"https://api.github.com/users/skrah/gists{/gist_id}","starred_url":"https://api.github.com/users/skrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrah/subscriptions","organizations_url":"https://api.github.com/users/skrah/orgs","repos_url":"https://api.github.com/users/skrah/repos","events_url":"https://api.github.com/users/skrah/events{/privacy}","received_events_url":"https://api.github.com/users/skrah/received_events","type":"User","site_admin":false},"repo":{"id":60599153,"name":"blaze","full_name":"skrah/blaze","owner":{"login":"skrah","id":16530421,"avatar_url":"https://avatars.githubusercontent.com/u/16530421?v=3","gravatar_id":"","url":"https://api.github.com/users/skrah","html_url":"https://github.com/skrah","followers_url":"https://api.github.com/users/skrah/followers","following_url":"https://api.github.com/users/skrah/following{/other_user}","gists_url":"https://api.github.com/users/skrah/gists{/gist_id}","starred_url":"https://api.github.com/users/skrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrah/subscriptions","organizations_url":"https://api.github.com/users/skrah/orgs","repos_url":"https://api.github.com/users/skrah/repos","events_url":"https://api.github.com/users/skrah/events{/privacy}","received_events_url":"https://api.github.com/users/skrah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skrah/blaze","description":"NumPy and Pandas interface to Big Data","fork":true,"url":"https://api.github.com/repos/skrah/blaze","forks_url":"https://api.github.com/repos/skrah/blaze/forks","keys_url":"https://api.github.com/repos/skrah/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skrah/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skrah/blaze/teams","hooks_url":"https://api.github.com/repos/skrah/blaze/hooks","issue_events_url":"https://api.github.com/repos/skrah/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/skrah/blaze/events","assignees_url":"https://api.github.com/repos/skrah/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/skrah/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/skrah/blaze/tags","blobs_url":"https://api.github.com/repos/skrah/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skrah/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skrah/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/skrah/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skrah/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/skrah/blaze/languages","stargazers_url":"https://api.github.com/repos/skrah/blaze/stargazers","contributors_url":"https://api.github.com/repos/skrah/blaze/contributors","subscribers_url":"https://api.github.com/repos/skrah/blaze/subscribers","subscription_url":"https://api.github.com/repos/skrah/blaze/subscription","commits_url":"https://api.github.com/repos/skrah/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/skrah/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/skrah/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/skrah/blaze/issues/comments{/number}","contents_url":"https://api.github.com/repos/skrah/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/skrah/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skrah/blaze/merges","archive_url":"https://api.github.com/repos/skrah/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skrah/blaze/downloads","issues_url":"https://api.github.com/repos/skrah/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/skrah/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/skrah/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/skrah/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skrah/blaze/labels{/name}","releases_url":"https://api.github.com/repos/skrah/blaze/releases{/id}","deployments_url":"https://api.github.com/repos/skrah/blaze/deployments","created_at":"2016-06-07T09:10:51Z","updated_at":"2016-06-07T09:10:53Z","pushed_at":"2016-08-02T12:50:56Z","git_url":"git://github.com/skrah/blaze.git","ssh_url":"git@github.com:skrah/blaze.git","clone_url":"https://github.com/skrah/blaze.git","svn_url":"https://github.com/skrah/blaze","homepage":"blaze.pydata.org","size":22800,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blaze:master","ref":"master","sha":"c744e9a9a6db2630788315e776633403269ee726","user":{"login":"blaze","id":12833921,"avatar_url":"https://avatars.githubusercontent.com/u/12833921?v=3","gravatar_id":"","url":"https://api.github.com/users/blaze","html_url":"https://github.com/blaze","followers_url":"https://api.github.com/users/blaze/followers","following_url":"https://api.github.com/users/blaze/following{/other_user}","gists_url":"https://api.github.com/users/blaze/gists{/gist_id}","starred_url":"https://api.github.com/users/blaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blaze/subscriptions","organizations_url":"https://api.github.com/users/blaze/orgs","repos_url":"https://api.github.com/users/blaze/repos","events_url":"https://api.github.com/users/blaze/events{/privacy}","received_events_url":"https://api.github.com/users/blaze/received_events","type":"Organization","site_admin":false},"repo":{"id":6404963,"name":"blaze","full_name":"blaze/blaze","owner":{"login":"blaze","id":12833921,"avatar_url":"https://avatars.githubusercontent.com/u/12833921?v=3","gravatar_id":"","url":"https://api.github.com/users/blaze","html_url":"https://github.com/blaze","followers_url":"https://api.github.com/users/blaze/followers","following_url":"https://api.github.com/users/blaze/following{/other_user}","gists_url":"https://api.github.com/users/blaze/gists{/gist_id}","starred_url":"https://api.github.com/users/blaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blaze/subscriptions","organizations_url":"https://api.github.com/users/blaze/orgs","repos_url":"https://api.github.com/users/blaze/repos","events_url":"https://api.github.com/users/blaze/events{/privacy}","received_events_url":"https://api.github.com/users/blaze/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blaze/blaze","description":"NumPy and Pandas interface to Big Data","fork":false,"url":"https://api.github.com/repos/blaze/blaze","forks_url":"https://api.github.com/repos/blaze/blaze/forks","keys_url":"https://api.github.com/repos/blaze/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blaze/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blaze/blaze/teams","hooks_url":"https://api.github.com/repos/blaze/blaze/hooks","issue_events_url":"https://api.github.com/repos/blaze/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/blaze/blaze/events","assignees_url":"https://api.github.com/repos/blaze/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/blaze/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/blaze/blaze/tags","blobs_url":"https://api.github.com/repos/blaze/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blaze/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blaze/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/blaze/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blaze/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/blaze/blaze/languages","stargazers_url":"https://api.github.com/repos/blaze/blaze/stargazers","contributors_url":"https://api.github.com/repos/blaze/blaze/contributors","subscribers_url":"https://api.github.com/repos/blaze/blaze/subscribers","subscription_url":"https://api.github.com/repos/blaze/blaze/subscription","commits_url":"https://api.github.com/repos/blaze/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/blaze/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/blaze/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/blaze/blaze/issues/comments{/number}","contents_url":"https://api.github.com/repos/blaze/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/blaze/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blaze/blaze/merges","archive_url":"https://api.github.com/repos/blaze/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blaze/blaze/downloads","issues_url":"https://api.github.com/repos/blaze/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/blaze/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/blaze/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/blaze/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blaze/blaze/labels{/name}","releases_url":"https://api.github.com/repos/blaze/blaze/releases{/id}","deployments_url":"https://api.github.com/repos/blaze/blaze/deployments","created_at":"2012-10-26T14:25:22Z","updated_at":"2016-08-02T05:34:31Z","pushed_at":"2016-08-02T12:52:40Z","git_url":"git://github.com/blaze/blaze.git","ssh_url":"git@github.com:blaze/blaze.git","clone_url":"https://github.com/blaze/blaze.git","svn_url":"https://github.com/blaze/blaze","homepage":"blaze.pydata.org","size":33358,"stargazers_count":1531,"watchers_count":1531,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":227,"mirror_url":null,"open_issues_count":217,"forks":227,"open_issues":217,"watchers":1531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blaze/blaze/pulls/1559"},"html":{"href":"https://github.com/blaze/blaze/pull/1559"},"issue":{"href":"https://api.github.com/repos/blaze/blaze/issues/1559"},"comments":{"href":"https://api.github.com/repos/blaze/blaze/issues/1559/comments"},"review_comments":{"href":"https://api.github.com/repos/blaze/blaze/pulls/1559/comments"},"review_comment":{"href":"https://api.github.com/repos/blaze/blaze/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blaze/blaze/pulls/1559/commits"},"statuses":{"href":"https://api.github.com/repos/blaze/blaze/statuses/76f2a4dc09ad7498f783eb89e8b3c6f84871c50a"}}}}
{"actor":{"display_login":"skrah"}}