{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/75753237","id":75753237,"diff_hunk":"@@ -34,6 +37,44 @@ you are responsible for updating it to reflect requirements of newer versions of\n the {product-title} master.\n ====\n \n+=== General Admission Rules\n+Starting in 1.3, OpenShift uses a single admission chain for Kubernetes and OpenShift\n+resources.  This changed from 1.2 and before where we had separate admission chains.","path":"architecture/additional_concepts/admission_controllers.adoc","position":16,"original_position":16,"commit_id":"2e060336b277aa9cfefb92cfc982560a3d71f0eb","original_commit_id":"2e060336b277aa9cfefb92cfc982560a3d71f0eb","user":{"login":"ahardin-rh","id":16197393,"avatar_url":"https://avatars.githubusercontent.com/u/16197393?v=3","gravatar_id":"","url":"https://api.github.com/users/ahardin-rh","html_url":"https://github.com/ahardin-rh","followers_url":"https://api.github.com/users/ahardin-rh/followers","following_url":"https://api.github.com/users/ahardin-rh/following{/other_user}","gists_url":"https://api.github.com/users/ahardin-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/ahardin-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahardin-rh/subscriptions","organizations_url":"https://api.github.com/users/ahardin-rh/orgs","repos_url":"https://api.github.com/users/ahardin-rh/repos","events_url":"https://api.github.com/users/ahardin-rh/events{/privacy}","received_events_url":"https://api.github.com/users/ahardin-rh/received_events","type":"User","site_admin":false},"body":"comma after before","created_at":"2016-08-22T20:34:55Z","updated_at":"2016-08-22T20:34:55Z","html_url":"https://github.com/openshift/openshift-docs/pull/2695#discussion_r75753237","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/75753237"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2695#discussion_r75753237"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695","id":82194501,"html_url":"https://github.com/openshift/openshift-docs/pull/2695","diff_url":"https://github.com/openshift/openshift-docs/pull/2695.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/2695.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2695","number":2695,"state":"open","locked":false,"title":"describe admission plugin chain","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/openshift/origin/issues/10539\r\n\r\nDescribes the changes to the admission chain we made in 1.3.\r\n\r\n@csrwng ptal for technical accuracy.\r\n@ahardin-rh I need some help with the version numbers I tried to use in this change.  I know there's some tags for me to use somewhere.","created_at":"2016-08-22T13:51:52Z","updated_at":"2016-08-22T20:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca7cda7226d22b8defc25ffd3b6b524a93b6d699","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2695/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/2e060336b277aa9cfefb92cfc982560a3d71f0eb","head":{"label":"deads2k:admission","ref":"admission","sha":"2e060336b277aa9cfefb92cfc982560a3d71f0eb","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"repo":{"id":30081469,"name":"openshift-docs","full_name":"deads2k/openshift-docs","owner":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deads2k/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/deads2k/openshift-docs","forks_url":"https://api.github.com/repos/deads2k/openshift-docs/forks","keys_url":"https://api.github.com/repos/deads2k/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deads2k/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deads2k/openshift-docs/teams","hooks_url":"https://api.github.com/repos/deads2k/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/deads2k/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/deads2k/openshift-docs/events","assignees_url":"https://api.github.com/repos/deads2k/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/deads2k/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/deads2k/openshift-docs/tags","blobs_url":"https://api.github.com/repos/deads2k/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deads2k/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deads2k/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/deads2k/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deads2k/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/deads2k/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/deads2k/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/deads2k/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/deads2k/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/deads2k/openshift-docs/subscription","commits_url":"https://api.github.com/repos/deads2k/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/deads2k/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/deads2k/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/deads2k/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/deads2k/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/deads2k/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deads2k/openshift-docs/merges","archive_url":"https://api.github.com/repos/deads2k/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deads2k/openshift-docs/downloads","issues_url":"https://api.github.com/repos/deads2k/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/deads2k/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/deads2k/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/deads2k/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deads2k/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/deads2k/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/deads2k/openshift-docs/deployments","created_at":"2015-01-30T16:54:38Z","updated_at":"2016-03-16T20:30:03Z","pushed_at":"2016-08-22T17:34:07Z","git_url":"git://github.com/deads2k/openshift-docs.git","ssh_url":"git@github.com:deads2k/openshift-docs.git","clone_url":"https://github.com/deads2k/openshift-docs.git","svn_url":"https://github.com/deads2k/openshift-docs","homepage":null,"size":13754,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"62d13007ba3e4d2c37c44fe986f263476e77fe08","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2016-08-03T17:10:01Z","pushed_at":"2016-08-22T20:18:31Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":22604,"stargazers_count":51,"watchers_count":51,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":241,"mirror_url":null,"open_issues_count":203,"forks":241,"open_issues":203,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2695"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2695"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2695/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2695/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/2e060336b277aa9cfefb92cfc982560a3d71f0eb"}}}}
{"actor":{"display_login":"ahardin-rh"}}