{"action":"opened","number":294,"pull_request":{"url":"https://api.github.com/repos/google/cloud-print-connector/pulls/294","id":80917465,"html_url":"https://github.com/google/cloud-print-connector/pull/294","diff_url":"https://github.com/google/cloud-print-connector/pull/294.diff","patch_url":"https://github.com/google/cloud-print-connector/pull/294.patch","issue_url":"https://api.github.com/repos/google/cloud-print-connector/issues/294","number":294,"state":"open","locked":false,"title":"Introduced NativePrintJob interface to clean up NativePrintSystem.","user":{"login":"kristofferknudsen","id":20860139,"avatar_url":"https://avatars.githubusercontent.com/u/20860139?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofferknudsen","html_url":"https://github.com/kristofferknudsen","followers_url":"https://api.github.com/users/kristofferknudsen/followers","following_url":"https://api.github.com/users/kristofferknudsen/following{/other_user}","gists_url":"https://api.github.com/users/kristofferknudsen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofferknudsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofferknudsen/subscriptions","organizations_url":"https://api.github.com/users/kristofferknudsen/orgs","repos_url":"https://api.github.com/users/kristofferknudsen/repos","events_url":"https://api.github.com/users/kristofferknudsen/events{/privacy}","received_events_url":"https://api.github.com/users/kristofferknudsen/received_events","type":"User","site_admin":false},"body":"The `NativePrintSystem` interface recently picked up a second method manipulating individual print jobs. Additionally, `NativePrintSystem` failed to hide the actual native implementation, by exposing jobIDs as unsigned integers when addressing print jobs. \r\n\r\nI've introduced a `NativePrintJob` interface returned by `Print(...)`, replacing the raw jobIDs, and moved the methods addressing individual print jobs to this new interface. \r\n\r\nTesting has be sparse, so my confidence is not absolute. I would welcome feedback though. ","created_at":"2016-08-11T08:04:03Z","updated_at":"2016-08-11T08:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/294/commits","review_comments_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/294/comments","review_comment_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cloud-print-connector/issues/294/comments","statuses_url":"https://api.github.com/repos/google/cloud-print-connector/statuses/cba20c87492ec19cb525ef15eb418f2f03e22b4b","head":{"label":"kristofferknudsen:refactor","ref":"refactor","sha":"cba20c87492ec19cb525ef15eb418f2f03e22b4b","user":{"login":"kristofferknudsen","id":20860139,"avatar_url":"https://avatars.githubusercontent.com/u/20860139?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofferknudsen","html_url":"https://github.com/kristofferknudsen","followers_url":"https://api.github.com/users/kristofferknudsen/followers","following_url":"https://api.github.com/users/kristofferknudsen/following{/other_user}","gists_url":"https://api.github.com/users/kristofferknudsen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofferknudsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofferknudsen/subscriptions","organizations_url":"https://api.github.com/users/kristofferknudsen/orgs","repos_url":"https://api.github.com/users/kristofferknudsen/repos","events_url":"https://api.github.com/users/kristofferknudsen/events{/privacy}","received_events_url":"https://api.github.com/users/kristofferknudsen/received_events","type":"User","site_admin":false},"repo":{"id":65385510,"name":"cloud-print-connector","full_name":"kristofferknudsen/cloud-print-connector","owner":{"login":"kristofferknudsen","id":20860139,"avatar_url":"https://avatars.githubusercontent.com/u/20860139?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofferknudsen","html_url":"https://github.com/kristofferknudsen","followers_url":"https://api.github.com/users/kristofferknudsen/followers","following_url":"https://api.github.com/users/kristofferknudsen/following{/other_user}","gists_url":"https://api.github.com/users/kristofferknudsen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofferknudsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofferknudsen/subscriptions","organizations_url":"https://api.github.com/users/kristofferknudsen/orgs","repos_url":"https://api.github.com/users/kristofferknudsen/repos","events_url":"https://api.github.com/users/kristofferknudsen/events{/privacy}","received_events_url":"https://api.github.com/users/kristofferknudsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kristofferknudsen/cloud-print-connector","description":"Google Cloud Print Connector","fork":true,"url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector","forks_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/forks","keys_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/teams","hooks_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/hooks","issue_events_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/issues/events{/number}","events_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/events","assignees_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/assignees{/user}","branches_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/branches{/branch}","tags_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/tags","blobs_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/languages","stargazers_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/stargazers","contributors_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/contributors","subscribers_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/subscribers","subscription_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/subscription","commits_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/contents/{+path}","compare_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/merges","archive_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/downloads","issues_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/issues{/number}","pulls_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/labels{/name}","releases_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/releases{/id}","deployments_url":"https://api.github.com/repos/kristofferknudsen/cloud-print-connector/deployments","created_at":"2016-08-10T13:39:45Z","updated_at":"2016-08-10T13:39:47Z","pushed_at":"2016-08-10T18:36:55Z","git_url":"git://github.com/kristofferknudsen/cloud-print-connector.git","ssh_url":"git@github.com:kristofferknudsen/cloud-print-connector.git","clone_url":"https://github.com/kristofferknudsen/cloud-print-connector.git","svn_url":"https://github.com/kristofferknudsen/cloud-print-connector","homepage":"","size":1126,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e1a47b7a81383b4aa92b431485dd95bd6c059199","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":31638315,"name":"cloud-print-connector","full_name":"google/cloud-print-connector","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cloud-print-connector","description":"Google Cloud Print Connector","fork":false,"url":"https://api.github.com/repos/google/cloud-print-connector","forks_url":"https://api.github.com/repos/google/cloud-print-connector/forks","keys_url":"https://api.github.com/repos/google/cloud-print-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cloud-print-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cloud-print-connector/teams","hooks_url":"https://api.github.com/repos/google/cloud-print-connector/hooks","issue_events_url":"https://api.github.com/repos/google/cloud-print-connector/issues/events{/number}","events_url":"https://api.github.com/repos/google/cloud-print-connector/events","assignees_url":"https://api.github.com/repos/google/cloud-print-connector/assignees{/user}","branches_url":"https://api.github.com/repos/google/cloud-print-connector/branches{/branch}","tags_url":"https://api.github.com/repos/google/cloud-print-connector/tags","blobs_url":"https://api.github.com/repos/google/cloud-print-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cloud-print-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cloud-print-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cloud-print-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cloud-print-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cloud-print-connector/languages","stargazers_url":"https://api.github.com/repos/google/cloud-print-connector/stargazers","contributors_url":"https://api.github.com/repos/google/cloud-print-connector/contributors","subscribers_url":"https://api.github.com/repos/google/cloud-print-connector/subscribers","subscription_url":"https://api.github.com/repos/google/cloud-print-connector/subscription","commits_url":"https://api.github.com/repos/google/cloud-print-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cloud-print-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cloud-print-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cloud-print-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cloud-print-connector/contents/{+path}","compare_url":"https://api.github.com/repos/google/cloud-print-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cloud-print-connector/merges","archive_url":"https://api.github.com/repos/google/cloud-print-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cloud-print-connector/downloads","issues_url":"https://api.github.com/repos/google/cloud-print-connector/issues{/number}","pulls_url":"https://api.github.com/repos/google/cloud-print-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cloud-print-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cloud-print-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cloud-print-connector/labels{/name}","releases_url":"https://api.github.com/repos/google/cloud-print-connector/releases{/id}","deployments_url":"https://api.github.com/repos/google/cloud-print-connector/deployments","created_at":"2015-03-04T04:41:38Z","updated_at":"2016-08-05T19:15:19Z","pushed_at":"2016-08-05T20:17:14Z","git_url":"git://github.com/google/cloud-print-connector.git","ssh_url":"git@github.com:google/cloud-print-connector.git","clone_url":"https://github.com/google/cloud-print-connector.git","svn_url":"https://github.com/google/cloud-print-connector","homepage":"","size":1354,"stargazers_count":251,"watchers_count":251,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":29,"forks":51,"open_issues":29,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/294"},"html":{"href":"https://github.com/google/cloud-print-connector/pull/294"},"issue":{"href":"https://api.github.com/repos/google/cloud-print-connector/issues/294"},"comments":{"href":"https://api.github.com/repos/google/cloud-print-connector/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/google/cloud-print-connector/statuses/cba20c87492ec19cb525ef15eb418f2f03e22b4b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":72,"deletions":58,"changed_files":3}}
{"actor":{"display_login":"kristofferknudsen"}}