{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments/60963559","id":60963559,"diff_hunk":"@@ -12,7 +12,7 @@\n (def min-config\n   {:product\n    {:name \"puppet-server\", :update-server-url \"http://localhost:11111\"},\n-   :jruby-puppet\n+   :jruby","path":"test/unit/puppetlabs/services/jruby/jruby_core_test.clj","position":17,"original_position":17,"commit_id":"0bee20864c3af8e499b82dfc877db2de1fb04518","original_commit_id":"0bee20864c3af8e499b82dfc877db2de1fb04518","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"Assuming we move forward with my suggestion above, about preferring a `:jruby` section but falling back to `:jruby-puppet` if it doesn't exist, then I think you should leave all of your test changes as they are in this PR (i.e., test the new setting by default).  And then maybe we just add one or two unit-ish tests that validate that we will fall back to `:jruby-puppet` if `:jruby` doesn't exist?","created_at":"2016-04-25T18:30:10Z","updated_at":"2016-04-25T18:30:10Z","html_url":"https://github.com/puppetlabs/jruby-utils/pull/5#discussion_r60963559","pull_request_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments/60963559"},"html":{"href":"https://github.com/puppetlabs/jruby-utils/pull/5#discussion_r60963559"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5","id":67586046,"html_url":"https://github.com/puppetlabs/jruby-utils/pull/5","diff_url":"https://github.com/puppetlabs/jruby-utils/pull/5.diff","patch_url":"https://github.com/puppetlabs/jruby-utils/pull/5.patch","issue_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/5","number":5,"state":"open","locked":false,"title":"(TK-365) Remove references to 'puppet'","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"body":"This commit renames all the things to remove\r\nreferences to 'puppet'.","created_at":"2016-04-22T23:26:58Z","updated_at":"2016-04-25T18:30:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83f54c6765a813b8857657d59104e10811834b89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/5/comments","statuses_url":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/0bee20864c3af8e499b82dfc877db2de1fb04518","head":{"label":"rlinehan:TK-365-remove-references-to-puppet","ref":"TK-365-remove-references-to-puppet","sha":"0bee20864c3af8e499b82dfc877db2de1fb04518","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"repo":{"id":54999540,"name":"jruby-utils","full_name":"rlinehan/jruby-utils","owner":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlinehan/jruby-utils","description":"Tools for working with JRuby from Clojure","fork":true,"url":"https://api.github.com/repos/rlinehan/jruby-utils","forks_url":"https://api.github.com/repos/rlinehan/jruby-utils/forks","keys_url":"https://api.github.com/repos/rlinehan/jruby-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlinehan/jruby-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlinehan/jruby-utils/teams","hooks_url":"https://api.github.com/repos/rlinehan/jruby-utils/hooks","issue_events_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues/events{/number}","events_url":"https://api.github.com/repos/rlinehan/jruby-utils/events","assignees_url":"https://api.github.com/repos/rlinehan/jruby-utils/assignees{/user}","branches_url":"https://api.github.com/repos/rlinehan/jruby-utils/branches{/branch}","tags_url":"https://api.github.com/repos/rlinehan/jruby-utils/tags","blobs_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlinehan/jruby-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/rlinehan/jruby-utils/languages","stargazers_url":"https://api.github.com/repos/rlinehan/jruby-utils/stargazers","contributors_url":"https://api.github.com/repos/rlinehan/jruby-utils/contributors","subscribers_url":"https://api.github.com/repos/rlinehan/jruby-utils/subscribers","subscription_url":"https://api.github.com/repos/rlinehan/jruby-utils/subscription","commits_url":"https://api.github.com/repos/rlinehan/jruby-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlinehan/jruby-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlinehan/jruby-utils/contents/{+path}","compare_url":"https://api.github.com/repos/rlinehan/jruby-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlinehan/jruby-utils/merges","archive_url":"https://api.github.com/repos/rlinehan/jruby-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlinehan/jruby-utils/downloads","issues_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues{/number}","pulls_url":"https://api.github.com/repos/rlinehan/jruby-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/rlinehan/jruby-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/rlinehan/jruby-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlinehan/jruby-utils/labels{/name}","releases_url":"https://api.github.com/repos/rlinehan/jruby-utils/releases{/id}","deployments_url":"https://api.github.com/repos/rlinehan/jruby-utils/deployments","created_at":"2016-03-29T18:16:10Z","updated_at":"2016-04-19T22:15:52Z","pushed_at":"2016-04-22T23:25:56Z","git_url":"git://github.com/rlinehan/jruby-utils.git","ssh_url":"git@github.com:rlinehan/jruby-utils.git","clone_url":"https://github.com/rlinehan/jruby-utils.git","svn_url":"https://github.com/rlinehan/jruby-utils","homepage":null,"size":3644,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"993f2eb535c3613b3b07c983c18089c7aa2b623e","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":54928848,"name":"jruby-utils","full_name":"puppetlabs/jruby-utils","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/jruby-utils","description":"Tools for working with JRuby from Clojure","fork":false,"url":"https://api.github.com/repos/puppetlabs/jruby-utils","forks_url":"https://api.github.com/repos/puppetlabs/jruby-utils/forks","keys_url":"https://api.github.com/repos/puppetlabs/jruby-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/jruby-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/jruby-utils/teams","hooks_url":"https://api.github.com/repos/puppetlabs/jruby-utils/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/jruby-utils/events","assignees_url":"https://api.github.com/repos/puppetlabs/jruby-utils/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/jruby-utils/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/jruby-utils/tags","blobs_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/jruby-utils/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/jruby-utils/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/jruby-utils/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/jruby-utils/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/jruby-utils/subscription","commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/jruby-utils/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/jruby-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/jruby-utils/merges","archive_url":"https://api.github.com/repos/puppetlabs/jruby-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/jruby-utils/downloads","issues_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/jruby-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/jruby-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/jruby-utils/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/jruby-utils/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/deployments","created_at":"2016-03-28T22:45:23Z","updated_at":"2016-03-31T01:03:48Z","pushed_at":"2016-04-22T23:26:58Z","git_url":"git://github.com/puppetlabs/jruby-utils.git","ssh_url":"git@github.com:puppetlabs/jruby-utils.git","clone_url":"https://github.com/puppetlabs/jruby-utils.git","svn_url":"https://github.com/puppetlabs/jruby-utils","homepage":null,"size":3617,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5"},"html":{"href":"https://github.com/puppetlabs/jruby-utils/pull/5"},"issue":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/5"},"comments":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/0bee20864c3af8e499b82dfc877db2de1fb04518"}}}}