{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1603","repository_url":"https://api.github.com/repos/Microsoft/WinObjC","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1603/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1603/comments","events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1603/events","html_url":"https://github.com/Microsoft/WinObjC/pull/1603","id":197009094,"number":1603,"title":"Improve perf for CTFramesetterSuggestFrameSizeWithConstraints","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"labels":[{"id":245005357,"url":"https://api.github.com/repos/Microsoft/WinObjC/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-21T19:05:25Z","updated_at":"2016-12-27T19:10:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1603","html_url":"https://github.com/Microsoft/WinObjC/pull/1603","diff_url":"https://github.com/Microsoft/WinObjC/pull/1603.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1603.patch"},"body":"CTFramesetterSuggestFrameSizeWithConstraints was going through the entire process of creating a frame to get the size, which was very wasteful.  Now only does the minimum amount of layout to determine the suggested size.  Cleans up NSString+UIKitAdditions for better perf analysis.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/winobjc/1603)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments/269369006","html_url":"https://github.com/Microsoft/WinObjC/pull/1603#issuecomment-269369006","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1603","id":269369006,"user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T19:10:23Z","updated_at":"2016-12-27T19:10:23Z","body":"> #endif\r\n\r\nunrelated, but can you see if we can ditch these? UIKIT_EXPORT already has 'extern \"C\"' when __cplusplus is defined\r\n\r\n---\r\nRefers to: include/UIKit/UIGraphics.h:40 in c3bbc8f. [](commit_id = c3bbc8f3f3f29e775f13f584a2c3ebcd558d7a4b, deletion_comment = False)"}}
{"actor":{"display_login":"ms-jihua"}}