{"action":"created","comment":{"url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/comments/79286740","id":79286740,"diff_hunk":"@@ -12,10 +12,23 @@\n \n     <artifactId>canonical</artifactId>\n     <version>1.0.0-SNAPSHOT</version>\n-    <packaging>war</packaging>\n+    <packaging>jar</packaging>\n     <name>Microprofile Samples :: Canonical</name>\n \n+    <properties>\n+        <maven.compiler.source>1.8</maven.compiler.source>\n+        <maven.compiler.target>1.8</maven.compiler.target>\n+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\n+        <hammock.version>0.2.0</hammock.version>\n+    </properties>\n+\n     <dependencies>\n+        <!-- JBoss Logging required due to older version from resteasy client -->","path":"microprofile-sample-canonical/pom.xml","position":16,"original_position":16,"commit_id":"a8fda906b642bf70ea59ea2cb84843d8e7b20c3b","original_commit_id":"a8fda906b642bf70ea59ea2cb84843d8e7b20c3b","user":{"login":"johnament","id":108167,"avatar_url":"https://avatars.githubusercontent.com/u/108167?v=3","gravatar_id":"","url":"https://api.github.com/users/johnament","html_url":"https://github.com/johnament","followers_url":"https://api.github.com/users/johnament/followers","following_url":"https://api.github.com/users/johnament/following{/other_user}","gists_url":"https://api.github.com/users/johnament/gists{/gist_id}","starred_url":"https://api.github.com/users/johnament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnament/subscriptions","organizations_url":"https://api.github.com/users/johnament/orgs","repos_url":"https://api.github.com/users/johnament/repos","events_url":"https://api.github.com/users/johnament/events{/privacy}","received_events_url":"https://api.github.com/users/johnament/received_events","type":"User","site_admin":false},"body":"The problem is that when both Undertow (using JBoss Logging 3.3.0) and RestEasy Client (JBoss Logging 3.0.x) are on the classpath with profiles, the dependency from client is winning over undertow.  This is the only way I saw to override this.","created_at":"2016-09-17T15:55:55Z","updated_at":"2016-09-17T15:55:55Z","html_url":"https://github.com/microprofile/microprofile-samples/pull/20#discussion_r79286740","pull_request_url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/comments/79286740"},"html":{"href":"https://github.com/microprofile/microprofile-samples/pull/20#discussion_r79286740"},"pull_request":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20","id":85211218,"html_url":"https://github.com/microprofile/microprofile-samples/pull/20","diff_url":"https://github.com/microprofile/microprofile-samples/pull/20.diff","patch_url":"https://github.com/microprofile/microprofile-samples/pull/20.patch","issue_url":"https://api.github.com/repos/microprofile/microprofile-samples/issues/20","number":20,"state":"open","locked":false,"title":"Added a Hammock based build for microprofile.","user":{"login":"johnament","id":108167,"avatar_url":"https://avatars.githubusercontent.com/u/108167?v=3","gravatar_id":"","url":"https://api.github.com/users/johnament","html_url":"https://github.com/johnament","followers_url":"https://api.github.com/users/johnament/followers","following_url":"https://api.github.com/users/johnament/following{/other_user}","gists_url":"https://api.github.com/users/johnament/gists{/gist_id}","starred_url":"https://api.github.com/users/johnament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnament/subscriptions","organizations_url":"https://api.github.com/users/johnament/orgs","repos_url":"https://api.github.com/users/johnament/repos","events_url":"https://api.github.com/users/johnament/events{/privacy}","received_events_url":"https://api.github.com/users/johnament/received_events","type":"User","site_admin":false},"body":"Don't merge yet - due to packaging changes.","created_at":"2016-09-14T11:32:53Z","updated_at":"2016-09-17T15:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7a1c65c15b1ec43bb70b4b22ef9475d0838e1cf","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/microprofile/microprofile-samples/milestones/1","html_url":"https://github.com/microprofile/microprofile-samples/milestones/1.0.0","labels_url":"https://api.github.com/repos/microprofile/microprofile-samples/milestones/1/labels","id":1943600,"number":1,"title":"1.0.0","description":"To coincide with JavaOne","creator":{"login":"karianna","id":180840,"avatar_url":"https://avatars.githubusercontent.com/u/180840?v=3","gravatar_id":"","url":"https://api.github.com/users/karianna","html_url":"https://github.com/karianna","followers_url":"https://api.github.com/users/karianna/followers","following_url":"https://api.github.com/users/karianna/following{/other_user}","gists_url":"https://api.github.com/users/karianna/gists{/gist_id}","starred_url":"https://api.github.com/users/karianna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karianna/subscriptions","organizations_url":"https://api.github.com/users/karianna/orgs","repos_url":"https://api.github.com/users/karianna/repos","events_url":"https://api.github.com/users/karianna/events{/privacy}","received_events_url":"https://api.github.com/users/karianna/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":11,"state":"open","created_at":"2016-08-15T21:15:24Z","updated_at":"2016-09-14T11:55:56Z","due_on":"2016-09-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20/commits","review_comments_url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20/comments","review_comment_url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microprofile/microprofile-samples/issues/20/comments","statuses_url":"https://api.github.com/repos/microprofile/microprofile-samples/statuses/a8fda906b642bf70ea59ea2cb84843d8e7b20c3b","head":{"label":"hammock-project:master-us","ref":"master-us","sha":"a8fda906b642bf70ea59ea2cb84843d8e7b20c3b","user":{"login":"hammock-project","id":20507614,"avatar_url":"https://avatars.githubusercontent.com/u/20507614?v=3","gravatar_id":"","url":"https://api.github.com/users/hammock-project","html_url":"https://github.com/hammock-project","followers_url":"https://api.github.com/users/hammock-project/followers","following_url":"https://api.github.com/users/hammock-project/following{/other_user}","gists_url":"https://api.github.com/users/hammock-project/gists{/gist_id}","starred_url":"https://api.github.com/users/hammock-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammock-project/subscriptions","organizations_url":"https://api.github.com/users/hammock-project/orgs","repos_url":"https://api.github.com/users/hammock-project/repos","events_url":"https://api.github.com/users/hammock-project/events{/privacy}","received_events_url":"https://api.github.com/users/hammock-project/received_events","type":"Organization","site_admin":false},"repo":{"id":64712046,"name":"microprofile-samples","full_name":"hammock-project/microprofile-samples","owner":{"login":"hammock-project","id":20507614,"avatar_url":"https://avatars.githubusercontent.com/u/20507614?v=3","gravatar_id":"","url":"https://api.github.com/users/hammock-project","html_url":"https://github.com/hammock-project","followers_url":"https://api.github.com/users/hammock-project/followers","following_url":"https://api.github.com/users/hammock-project/following{/other_user}","gists_url":"https://api.github.com/users/hammock-project/gists{/gist_id}","starred_url":"https://api.github.com/users/hammock-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammock-project/subscriptions","organizations_url":"https://api.github.com/users/hammock-project/orgs","repos_url":"https://api.github.com/users/hammock-project/repos","events_url":"https://api.github.com/users/hammock-project/events{/privacy}","received_events_url":"https://api.github.com/users/hammock-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammock-project/microprofile-samples","description":"Micro Profile Samples","fork":true,"url":"https://api.github.com/repos/hammock-project/microprofile-samples","forks_url":"https://api.github.com/repos/hammock-project/microprofile-samples/forks","keys_url":"https://api.github.com/repos/hammock-project/microprofile-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammock-project/microprofile-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammock-project/microprofile-samples/teams","hooks_url":"https://api.github.com/repos/hammock-project/microprofile-samples/hooks","issue_events_url":"https://api.github.com/repos/hammock-project/microprofile-samples/issues/events{/number}","events_url":"https://api.github.com/repos/hammock-project/microprofile-samples/events","assignees_url":"https://api.github.com/repos/hammock-project/microprofile-samples/assignees{/user}","branches_url":"https://api.github.com/repos/hammock-project/microprofile-samples/branches{/branch}","tags_url":"https://api.github.com/repos/hammock-project/microprofile-samples/tags","blobs_url":"https://api.github.com/repos/hammock-project/microprofile-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammock-project/microprofile-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammock-project/microprofile-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammock-project/microprofile-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammock-project/microprofile-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/hammock-project/microprofile-samples/languages","stargazers_url":"https://api.github.com/repos/hammock-project/microprofile-samples/stargazers","contributors_url":"https://api.github.com/repos/hammock-project/microprofile-samples/contributors","subscribers_url":"https://api.github.com/repos/hammock-project/microprofile-samples/subscribers","subscription_url":"https://api.github.com/repos/hammock-project/microprofile-samples/subscription","commits_url":"https://api.github.com/repos/hammock-project/microprofile-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammock-project/microprofile-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammock-project/microprofile-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammock-project/microprofile-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/hammock-project/microprofile-samples/contents/{+path}","compare_url":"https://api.github.com/repos/hammock-project/microprofile-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammock-project/microprofile-samples/merges","archive_url":"https://api.github.com/repos/hammock-project/microprofile-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammock-project/microprofile-samples/downloads","issues_url":"https://api.github.com/repos/hammock-project/microprofile-samples/issues{/number}","pulls_url":"https://api.github.com/repos/hammock-project/microprofile-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/hammock-project/microprofile-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/hammock-project/microprofile-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammock-project/microprofile-samples/labels{/name}","releases_url":"https://api.github.com/repos/hammock-project/microprofile-samples/releases{/id}","deployments_url":"https://api.github.com/repos/hammock-project/microprofile-samples/deployments","created_at":"2016-08-02T00:56:14Z","updated_at":"2016-08-02T00:56:15Z","pushed_at":"2016-09-14T11:36:35Z","git_url":"git://github.com/hammock-project/microprofile-samples.git","ssh_url":"git@github.com:hammock-project/microprofile-samples.git","clone_url":"https://github.com/hammock-project/microprofile-samples.git","svn_url":"https://github.com/hammock-project/microprofile-samples","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microprofile:master","ref":"master","sha":"8d18e4d4bec27fd42c608a06383fa759e9f050e6","user":{"login":"microprofile","id":19935375,"avatar_url":"https://avatars.githubusercontent.com/u/19935375?v=3","gravatar_id":"","url":"https://api.github.com/users/microprofile","html_url":"https://github.com/microprofile","followers_url":"https://api.github.com/users/microprofile/followers","following_url":"https://api.github.com/users/microprofile/following{/other_user}","gists_url":"https://api.github.com/users/microprofile/gists{/gist_id}","starred_url":"https://api.github.com/users/microprofile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microprofile/subscriptions","organizations_url":"https://api.github.com/users/microprofile/orgs","repos_url":"https://api.github.com/users/microprofile/repos","events_url":"https://api.github.com/users/microprofile/events{/privacy}","received_events_url":"https://api.github.com/users/microprofile/received_events","type":"Organization","site_admin":false},"repo":{"id":63673958,"name":"microprofile-samples","full_name":"microprofile/microprofile-samples","owner":{"login":"microprofile","id":19935375,"avatar_url":"https://avatars.githubusercontent.com/u/19935375?v=3","gravatar_id":"","url":"https://api.github.com/users/microprofile","html_url":"https://github.com/microprofile","followers_url":"https://api.github.com/users/microprofile/followers","following_url":"https://api.github.com/users/microprofile/following{/other_user}","gists_url":"https://api.github.com/users/microprofile/gists{/gist_id}","starred_url":"https://api.github.com/users/microprofile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microprofile/subscriptions","organizations_url":"https://api.github.com/users/microprofile/orgs","repos_url":"https://api.github.com/users/microprofile/repos","events_url":"https://api.github.com/users/microprofile/events{/privacy}","received_events_url":"https://api.github.com/users/microprofile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/microprofile/microprofile-samples","description":"Micro Profile Samples","fork":false,"url":"https://api.github.com/repos/microprofile/microprofile-samples","forks_url":"https://api.github.com/repos/microprofile/microprofile-samples/forks","keys_url":"https://api.github.com/repos/microprofile/microprofile-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microprofile/microprofile-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microprofile/microprofile-samples/teams","hooks_url":"https://api.github.com/repos/microprofile/microprofile-samples/hooks","issue_events_url":"https://api.github.com/repos/microprofile/microprofile-samples/issues/events{/number}","events_url":"https://api.github.com/repos/microprofile/microprofile-samples/events","assignees_url":"https://api.github.com/repos/microprofile/microprofile-samples/assignees{/user}","branches_url":"https://api.github.com/repos/microprofile/microprofile-samples/branches{/branch}","tags_url":"https://api.github.com/repos/microprofile/microprofile-samples/tags","blobs_url":"https://api.github.com/repos/microprofile/microprofile-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microprofile/microprofile-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microprofile/microprofile-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/microprofile/microprofile-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microprofile/microprofile-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/microprofile/microprofile-samples/languages","stargazers_url":"https://api.github.com/repos/microprofile/microprofile-samples/stargazers","contributors_url":"https://api.github.com/repos/microprofile/microprofile-samples/contributors","subscribers_url":"https://api.github.com/repos/microprofile/microprofile-samples/subscribers","subscription_url":"https://api.github.com/repos/microprofile/microprofile-samples/subscription","commits_url":"https://api.github.com/repos/microprofile/microprofile-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/microprofile/microprofile-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/microprofile/microprofile-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/microprofile/microprofile-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/microprofile/microprofile-samples/contents/{+path}","compare_url":"https://api.github.com/repos/microprofile/microprofile-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microprofile/microprofile-samples/merges","archive_url":"https://api.github.com/repos/microprofile/microprofile-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microprofile/microprofile-samples/downloads","issues_url":"https://api.github.com/repos/microprofile/microprofile-samples/issues{/number}","pulls_url":"https://api.github.com/repos/microprofile/microprofile-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/microprofile/microprofile-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/microprofile/microprofile-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microprofile/microprofile-samples/labels{/name}","releases_url":"https://api.github.com/repos/microprofile/microprofile-samples/releases{/id}","deployments_url":"https://api.github.com/repos/microprofile/microprofile-samples/deployments","created_at":"2016-07-19T08:03:22Z","updated_at":"2016-08-25T16:14:36Z","pushed_at":"2016-09-14T11:36:36Z","git_url":"git://github.com/microprofile/microprofile-samples.git","ssh_url":"git@github.com:microprofile/microprofile-samples.git","clone_url":"https://github.com/microprofile/microprofile-samples.git","svn_url":"https://github.com/microprofile/microprofile-samples","homepage":null,"size":52,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":6,"forks":10,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20"},"html":{"href":"https://github.com/microprofile/microprofile-samples/pull/20"},"issue":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/issues/20"},"comments":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/microprofile/microprofile-samples/statuses/a8fda906b642bf70ea59ea2cb84843d8e7b20c3b"}}}}
{"actor":{"display_login":"johnament"}}