{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/82630981","pull_request_review_id":3525050,"id":82630981,"diff_hunk":"@@ -2022,5 +2022,77 @@ void M()\n \n             await TestAsync(markup, new[] { new SignatureHelpTestItem(\"void List<int>.Add(int item)\") });\n         }\n+\n+        [Fact, Trait(Traits.Feature, Traits.Features.SignatureHelp)]\n+        public async Task TypingTupleDoesNotDismiss1()\n+        {\n+            var markup = @\"\n+class C\n+{\n+    int Foo(object x)\n+    {\n+        [|Foo(($$)|];\n+    }\n+}\";\n+\n+            var expectedOrderedItems = new List<SignatureHelpTestItem>();\n+            expectedOrderedItems.Add(new SignatureHelpTestItem(\"int C.Foo(object x)\", currentParameterIndex: 0));\n+\n+            await TestAsync(markup, expectedOrderedItems, usePreviousCharAsTrigger: true);","path":"src/EditorFeatures/CSharpTest/SignatureHelp/InvocationExpressionSignatureHelpProviderTests.cs","position":20,"original_position":20,"commit_id":"824aa2605421f6ababd8e27b5aba7835bfd79950","original_commit_id":"824aa2605421f6ababd8e27b5aba7835bfd79950","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"body":"In this case, dismissal happens because the user types a '(' or ',' and the system asks the provider to trigger on that typed char. We used to dismiss because we wouldn't trigger on the start of a tuple. I'll rename the tests to indicate this.","created_at":"2016-10-10T15:49:27Z","updated_at":"2016-10-10T15:49:27Z","html_url":"https://github.com/dotnet/roslyn/pull/14289#discussion_r82630981","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14289","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/82630981"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14289#discussion_r82630981"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14289"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/14289","id":88112877,"html_url":"https://github.com/dotnet/roslyn/pull/14289","diff_url":"https://github.com/dotnet/roslyn/pull/14289.diff","patch_url":"https://github.com/dotnet/roslyn/pull/14289.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/14289","number":14289,"state":"open","locked":false,"title":"Signature help improvements for C# tuples","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"body":"* The invocation/initializer/objectcreation sighelp providers no longer dismiss sighelp if the user starts typing a tuple\r\n* When the user starts typing a tuple, show signature help for the tuple member types/names if the type of the tuple can be inferred","created_at":"2016-10-05T16:32:43Z","updated_at":"2016-10-10T15:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eff43d74a22708a5252a2fcb708bee4490496173","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14289/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14289/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/14289/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/824aa2605421f6ababd8e27b5aba7835bfd79950","head":{"label":"rchande:tupleSigHelp","ref":"tupleSigHelp","sha":"824aa2605421f6ababd8e27b5aba7835bfd79950","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"repo":{"id":30547830,"name":"roslyn","full_name":"rchande/roslyn","owner":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rchande/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/rchande/roslyn","forks_url":"https://api.github.com/repos/rchande/roslyn/forks","keys_url":"https://api.github.com/repos/rchande/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchande/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchande/roslyn/teams","hooks_url":"https://api.github.com/repos/rchande/roslyn/hooks","issue_events_url":"https://api.github.com/repos/rchande/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/rchande/roslyn/events","assignees_url":"https://api.github.com/repos/rchande/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/rchande/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/rchande/roslyn/tags","blobs_url":"https://api.github.com/repos/rchande/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchande/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchande/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchande/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchande/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/rchande/roslyn/languages","stargazers_url":"https://api.github.com/repos/rchande/roslyn/stargazers","contributors_url":"https://api.github.com/repos/rchande/roslyn/contributors","subscribers_url":"https://api.github.com/repos/rchande/roslyn/subscribers","subscription_url":"https://api.github.com/repos/rchande/roslyn/subscription","commits_url":"https://api.github.com/repos/rchande/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchande/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchande/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchande/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchande/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/rchande/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchande/roslyn/merges","archive_url":"https://api.github.com/repos/rchande/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchande/roslyn/downloads","issues_url":"https://api.github.com/repos/rchande/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/rchande/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/rchande/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/rchande/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchande/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/rchande/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/rchande/roslyn/deployments","created_at":"2015-02-09T17:16:21Z","updated_at":"2015-02-09T17:16:48Z","pushed_at":"2016-10-10T15:45:56Z","git_url":"git://github.com/rchande/roslyn.git","ssh_url":"git@github.com:rchande/roslyn.git","clone_url":"https://github.com/rchande/roslyn.git","svn_url":"https://github.com/rchande/roslyn","homepage":"","size":176092,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6f017b726eb918e39de9ab01291ee5771c9f3f1d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-10-10T15:25:17Z","pushed_at":"2016-10-10T15:48:42Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":341519,"stargazers_count":6343,"watchers_count":6343,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1522,"mirror_url":null,"open_issues_count":3331,"forks":1522,"open_issues":3331,"watchers":6343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14289"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14289"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14289"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14289/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14289/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14289/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/824aa2605421f6ababd8e27b5aba7835bfd79950"}}}}
{"actor":{"display_login":"rchande"}}