{"action":"created","issue":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/3738","repository_url":"https://api.github.com/repos/kennethreitz/requests","labels_url":"https://api.github.com/repos/kennethreitz/requests/issues/3738/labels{/name}","comments_url":"https://api.github.com/repos/kennethreitz/requests/issues/3738/comments","events_url":"https://api.github.com/repos/kennethreitz/requests/issues/3738/events","html_url":"https://github.com/kennethreitz/requests/pull/3738","id":192682996,"number":3738,"title":"Revert \"Restrict URL preparation to HTTP/HTTPS\"","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-30T21:22:10Z","updated_at":"2016-12-01T06:00:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/3738","html_url":"https://github.com/kennethreitz/requests/pull/3738","diff_url":"https://github.com/kennethreitz/requests/pull/3738.diff","patch_url":"https://github.com/kennethreitz/requests/pull/3738.patch"},"body":"This reverts commit 34af72c87d79bd8852e8564c050dd7711c6a08d6.\r\n\r\nThis commit was added by @tiran to try to avoid the IDNA-encoding logic that we added in v2.12.0. I believe that the *other* workarounds we merged for that are sufficient, and this change broke docker-py and probably broke others.\r\n\r\n@tiran, can you confirm that your code continues to function with this change reverted? I'd like to be able to merge this and ship a v2.12.3 if at all possible.\r\n\r\nResolves #3735."},"comment":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/comments/264086207","html_url":"https://github.com/kennethreitz/requests/pull/3738#issuecomment-264086207","issue_url":"https://api.github.com/repos/kennethreitz/requests/issues/3738","id":264086207,"user":{"login":"mshahpalerra","id":19394554,"avatar_url":"https://avatars.githubusercontent.com/u/19394554?v=3","gravatar_id":"","url":"https://api.github.com/users/mshahpalerra","html_url":"https://github.com/mshahpalerra","followers_url":"https://api.github.com/users/mshahpalerra/followers","following_url":"https://api.github.com/users/mshahpalerra/following{/other_user}","gists_url":"https://api.github.com/users/mshahpalerra/gists{/gist_id}","starred_url":"https://api.github.com/users/mshahpalerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshahpalerra/subscriptions","organizations_url":"https://api.github.com/users/mshahpalerra/orgs","repos_url":"https://api.github.com/users/mshahpalerra/repos","events_url":"https://api.github.com/users/mshahpalerra/events{/privacy}","received_events_url":"https://api.github.com/users/mshahpalerra/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T06:00:01Z","updated_at":"2016-12-01T06:00:01Z","body":"@Lukasa sorry for being a hound but do you have an eta on this 2.12.3 release? We just lost a day of dev / test trying to figure out what broke docker-py until we found this. Thx \r\n\r\n- MS"}}
{"actor":{"display_login":"mshahpalerra"}}