{"action":"created","comment":{"url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/comments/92056285","pull_request_review_id":12566208,"id":92056285,"diff_hunk":"@@ -206,6 +208,7 @@ extractBoundNamesDPat (DVarPa n)      = S.singleton n\n extractBoundNamesDPat (DConPa _ pats) = S.unions (map extractBoundNamesDPat pats)\n extractBoundNamesDPat (DTildePa p)    = extractBoundNamesDPat p\n extractBoundNamesDPat (DBangPa p)     = extractBoundNamesDPat p\n+extractBoundNamesDPat (DSigPa p _)    = extractBoundNamesDPat p","path":"Language/Haskell/TH/Desugar/Match.hs","position":14,"original_position":14,"commit_id":"f43ceaef428cd9607b042653f4253199502ca7cd","original_commit_id":"f43ceaef428cd9607b042653f4253199502ca7cd","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"body":"GHC has a function just like this called [`collectPatBinders`](http://git.haskell.org/ghc.git/blob/8f6d241a74efa6f6280689a9b14c36c6a9f4c231:/compiler/deSugar/DsArrows.hs#l1119) which [also ignores](http://git.haskell.org/ghc.git/blob/8f6d241a74efa6f6280689a9b14c36c6a9f4c231:/compiler/deSugar/DsArrows.hs#l1152) the type in a type pattern, so my hunch is to answer \"no, it doesn't matter\".","created_at":"2016-12-12T22:32:10Z","updated_at":"2016-12-12T22:32:10Z","html_url":"https://github.com/goldfirere/th-desugar/pull/48#discussion_r92056285","pull_request_url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/comments/92056285"},"html":{"href":"https://github.com/goldfirere/th-desugar/pull/48#discussion_r92056285"},"pull_request":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48","id":97435398,"html_url":"https://github.com/goldfirere/th-desugar/pull/48","diff_url":"https://github.com/goldfirere/th-desugar/pull/48.diff","patch_url":"https://github.com/goldfirere/th-desugar/pull/48.patch","issue_url":"https://api.github.com/repos/goldfirere/th-desugar/issues/48","number":48,"state":"open","locked":false,"title":"Add support for type signatures in patterns","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"body":"In http://git.haskell.org/ghc.git/commit/b0121209f8fb47a7cb8fc32e10d8e2c06d4502c2, Template Haskell gained the ability to support type signatures in patterns. We should do the same in `th-desugar`.","created_at":"2016-12-10T19:39:09Z","updated_at":"2016-12-12T22:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cec68fa4a219a6d3f6ae1265b62b5af1c58ff60","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48/commits","review_comments_url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48/comments","review_comment_url":"https://api.github.com/repos/goldfirere/th-desugar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goldfirere/th-desugar/issues/48/comments","statuses_url":"https://api.github.com/repos/goldfirere/th-desugar/statuses/f43ceaef428cd9607b042653f4253199502ca7cd","head":{"label":"RyanGlScott:type-pats","ref":"type-pats","sha":"f43ceaef428cd9607b042653f4253199502ca7cd","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"repo":{"id":75579182,"name":"th-desugar","full_name":"RyanGlScott/th-desugar","owner":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyanGlScott/th-desugar","description":"Desugars Template Haskell abstract syntax to a simpler format without changing semantics","fork":true,"url":"https://api.github.com/repos/RyanGlScott/th-desugar","forks_url":"https://api.github.com/repos/RyanGlScott/th-desugar/forks","keys_url":"https://api.github.com/repos/RyanGlScott/th-desugar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyanGlScott/th-desugar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyanGlScott/th-desugar/teams","hooks_url":"https://api.github.com/repos/RyanGlScott/th-desugar/hooks","issue_events_url":"https://api.github.com/repos/RyanGlScott/th-desugar/issues/events{/number}","events_url":"https://api.github.com/repos/RyanGlScott/th-desugar/events","assignees_url":"https://api.github.com/repos/RyanGlScott/th-desugar/assignees{/user}","branches_url":"https://api.github.com/repos/RyanGlScott/th-desugar/branches{/branch}","tags_url":"https://api.github.com/repos/RyanGlScott/th-desugar/tags","blobs_url":"https://api.github.com/repos/RyanGlScott/th-desugar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyanGlScott/th-desugar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyanGlScott/th-desugar/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyanGlScott/th-desugar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyanGlScott/th-desugar/statuses/{sha}","languages_url":"https://api.github.com/repos/RyanGlScott/th-desugar/languages","stargazers_url":"https://api.github.com/repos/RyanGlScott/th-desugar/stargazers","contributors_url":"https://api.github.com/repos/RyanGlScott/th-desugar/contributors","subscribers_url":"https://api.github.com/repos/RyanGlScott/th-desugar/subscribers","subscription_url":"https://api.github.com/repos/RyanGlScott/th-desugar/subscription","commits_url":"https://api.github.com/repos/RyanGlScott/th-desugar/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyanGlScott/th-desugar/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyanGlScott/th-desugar/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyanGlScott/th-desugar/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyanGlScott/th-desugar/contents/{+path}","compare_url":"https://api.github.com/repos/RyanGlScott/th-desugar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyanGlScott/th-desugar/merges","archive_url":"https://api.github.com/repos/RyanGlScott/th-desugar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyanGlScott/th-desugar/downloads","issues_url":"https://api.github.com/repos/RyanGlScott/th-desugar/issues{/number}","pulls_url":"https://api.github.com/repos/RyanGlScott/th-desugar/pulls{/number}","milestones_url":"https://api.github.com/repos/RyanGlScott/th-desugar/milestones{/number}","notifications_url":"https://api.github.com/repos/RyanGlScott/th-desugar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyanGlScott/th-desugar/labels{/name}","releases_url":"https://api.github.com/repos/RyanGlScott/th-desugar/releases{/id}","deployments_url":"https://api.github.com/repos/RyanGlScott/th-desugar/deployments","created_at":"2016-12-05T02:00:34Z","updated_at":"2016-12-05T02:00:35Z","pushed_at":"2016-12-12T22:23:13Z","git_url":"git://github.com/RyanGlScott/th-desugar.git","ssh_url":"git@github.com:RyanGlScott/th-desugar.git","clone_url":"https://github.com/RyanGlScott/th-desugar.git","svn_url":"https://github.com/RyanGlScott/th-desugar","homepage":"","size":333,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goldfirere:master","ref":"master","sha":"2ced2834e3e313970b9d029f87995cf0fa86adcf","user":{"login":"goldfirere","id":1958003,"avatar_url":"https://avatars.githubusercontent.com/u/1958003?v=3","gravatar_id":"","url":"https://api.github.com/users/goldfirere","html_url":"https://github.com/goldfirere","followers_url":"https://api.github.com/users/goldfirere/followers","following_url":"https://api.github.com/users/goldfirere/following{/other_user}","gists_url":"https://api.github.com/users/goldfirere/gists{/gist_id}","starred_url":"https://api.github.com/users/goldfirere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldfirere/subscriptions","organizations_url":"https://api.github.com/users/goldfirere/orgs","repos_url":"https://api.github.com/users/goldfirere/repos","events_url":"https://api.github.com/users/goldfirere/events{/privacy}","received_events_url":"https://api.github.com/users/goldfirere/received_events","type":"User","site_admin":false},"repo":{"id":12388941,"name":"th-desugar","full_name":"goldfirere/th-desugar","owner":{"login":"goldfirere","id":1958003,"avatar_url":"https://avatars.githubusercontent.com/u/1958003?v=3","gravatar_id":"","url":"https://api.github.com/users/goldfirere","html_url":"https://github.com/goldfirere","followers_url":"https://api.github.com/users/goldfirere/followers","following_url":"https://api.github.com/users/goldfirere/following{/other_user}","gists_url":"https://api.github.com/users/goldfirere/gists{/gist_id}","starred_url":"https://api.github.com/users/goldfirere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldfirere/subscriptions","organizations_url":"https://api.github.com/users/goldfirere/orgs","repos_url":"https://api.github.com/users/goldfirere/repos","events_url":"https://api.github.com/users/goldfirere/events{/privacy}","received_events_url":"https://api.github.com/users/goldfirere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goldfirere/th-desugar","description":"Desugars Template Haskell abstract syntax to a simpler format without changing semantics","fork":false,"url":"https://api.github.com/repos/goldfirere/th-desugar","forks_url":"https://api.github.com/repos/goldfirere/th-desugar/forks","keys_url":"https://api.github.com/repos/goldfirere/th-desugar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goldfirere/th-desugar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goldfirere/th-desugar/teams","hooks_url":"https://api.github.com/repos/goldfirere/th-desugar/hooks","issue_events_url":"https://api.github.com/repos/goldfirere/th-desugar/issues/events{/number}","events_url":"https://api.github.com/repos/goldfirere/th-desugar/events","assignees_url":"https://api.github.com/repos/goldfirere/th-desugar/assignees{/user}","branches_url":"https://api.github.com/repos/goldfirere/th-desugar/branches{/branch}","tags_url":"https://api.github.com/repos/goldfirere/th-desugar/tags","blobs_url":"https://api.github.com/repos/goldfirere/th-desugar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goldfirere/th-desugar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goldfirere/th-desugar/git/refs{/sha}","trees_url":"https://api.github.com/repos/goldfirere/th-desugar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goldfirere/th-desugar/statuses/{sha}","languages_url":"https://api.github.com/repos/goldfirere/th-desugar/languages","stargazers_url":"https://api.github.com/repos/goldfirere/th-desugar/stargazers","contributors_url":"https://api.github.com/repos/goldfirere/th-desugar/contributors","subscribers_url":"https://api.github.com/repos/goldfirere/th-desugar/subscribers","subscription_url":"https://api.github.com/repos/goldfirere/th-desugar/subscription","commits_url":"https://api.github.com/repos/goldfirere/th-desugar/commits{/sha}","git_commits_url":"https://api.github.com/repos/goldfirere/th-desugar/git/commits{/sha}","comments_url":"https://api.github.com/repos/goldfirere/th-desugar/comments{/number}","issue_comment_url":"https://api.github.com/repos/goldfirere/th-desugar/issues/comments{/number}","contents_url":"https://api.github.com/repos/goldfirere/th-desugar/contents/{+path}","compare_url":"https://api.github.com/repos/goldfirere/th-desugar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goldfirere/th-desugar/merges","archive_url":"https://api.github.com/repos/goldfirere/th-desugar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goldfirere/th-desugar/downloads","issues_url":"https://api.github.com/repos/goldfirere/th-desugar/issues{/number}","pulls_url":"https://api.github.com/repos/goldfirere/th-desugar/pulls{/number}","milestones_url":"https://api.github.com/repos/goldfirere/th-desugar/milestones{/number}","notifications_url":"https://api.github.com/repos/goldfirere/th-desugar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goldfirere/th-desugar/labels{/name}","releases_url":"https://api.github.com/repos/goldfirere/th-desugar/releases{/id}","deployments_url":"https://api.github.com/repos/goldfirere/th-desugar/deployments","created_at":"2013-08-26T20:26:45Z","updated_at":"2016-12-05T01:54:39Z","pushed_at":"2016-12-12T22:23:14Z","git_url":"git://github.com/goldfirere/th-desugar.git","ssh_url":"git@github.com:goldfirere/th-desugar.git","clone_url":"https://github.com/goldfirere/th-desugar.git","svn_url":"https://github.com/goldfirere/th-desugar","homepage":"","size":368,"stargazers_count":8,"watchers_count":8,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48"},"html":{"href":"https://github.com/goldfirere/th-desugar/pull/48"},"issue":{"href":"https://api.github.com/repos/goldfirere/th-desugar/issues/48"},"comments":{"href":"https://api.github.com/repos/goldfirere/th-desugar/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goldfirere/th-desugar/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/goldfirere/th-desugar/statuses/f43ceaef428cd9607b042653f4253199502ca7cd"}}}}
{"actor":{"display_login":"RyanGlScott"}}