{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/77711096","id":77711096,"diff_hunk":"@@ -105,15 +115,24 @@ class ServerGroupParameters {\n    */\n   static List<String> unescapePythonUnicodeJsonList(String string) {\n     string?.split(\",\")?.collect { s ->\n-      s.replace(\"u'\", \"\")\n-        .replace(\"'\",\"\")\n-        .replace(\"[\",\"\")\n-        .replace(\"]\",\"\")\n-        .replaceAll(\"([ ][ ]*)\",\"\")\n+      s.replace(\"u'\", \"\").replace(\"'\",\"\").replace(\"[\",\"\").replace(\"]\",\"\").replaceAll(\"([ ][ ]*)\",\"\")\n     } ?: []\n   }\n \n   /**\n+   * Stack parameters of type 'comma_delimited_list' come back as a unicode json string. We need to split that up.\n+   *\n+   * To reiterate, I need a shower.","path":"clouddriver-openstack/src/main/groovy/com/netflix/spinnaker/clouddriver/openstack/deploy/description/servergroup/ServerGroupParameters.groovy","position":62,"original_position":62,"commit_id":"d56fa0f0a23e17ed00ab324695d2bbedc733ecad","original_commit_id":"d56fa0f0a23e17ed00ab324695d2bbedc733ecad","user":{"login":"derekolk","id":4722324,"avatar_url":"https://avatars.githubusercontent.com/u/4722324?v=3","gravatar_id":"","url":"https://api.github.com/users/derekolk","html_url":"https://github.com/derekolk","followers_url":"https://api.github.com/users/derekolk/followers","following_url":"https://api.github.com/users/derekolk/following{/other_user}","gists_url":"https://api.github.com/users/derekolk/gists{/gist_id}","starred_url":"https://api.github.com/users/derekolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekolk/subscriptions","organizations_url":"https://api.github.com/users/derekolk/orgs","repos_url":"https://api.github.com/users/derekolk/repos","events_url":"https://api.github.com/users/derekolk/events{/privacy}","received_events_url":"https://api.github.com/users/derekolk/received_events","type":"User","site_admin":false},"body":"Probably can remove the shower comments too.","created_at":"2016-09-06T20:22:56Z","updated_at":"2016-09-06T20:22:56Z","html_url":"https://github.com/spinnaker/clouddriver/pull/998#discussion_r77711096","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/77711096"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/998#discussion_r77711096"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998","id":84187198,"html_url":"https://github.com/spinnaker/clouddriver/pull/998","diff_url":"https://github.com/spinnaker/clouddriver/pull/998.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/998.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/998","number":998,"state":"open","locked":false,"title":"provider/openstack:adding metadata tags to server group create and clone","user":{"login":"drmaas","id":3291796,"avatar_url":"https://avatars.githubusercontent.com/u/3291796?v=3","gravatar_id":"","url":"https://api.github.com/users/drmaas","html_url":"https://github.com/drmaas","followers_url":"https://api.github.com/users/drmaas/followers","following_url":"https://api.github.com/users/drmaas/following{/other_user}","gists_url":"https://api.github.com/users/drmaas/gists{/gist_id}","starred_url":"https://api.github.com/users/drmaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmaas/subscriptions","organizations_url":"https://api.github.com/users/drmaas/orgs","repos_url":"https://api.github.com/users/drmaas/repos","events_url":"https://api.github.com/users/drmaas/events{/privacy}","received_events_url":"https://api.github.com/users/drmaas/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-06T20:06:17Z","updated_at":"2016-09-06T20:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"017bfb2b4e558edbb75743519b16f12ead2d706a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/998/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/d56fa0f0a23e17ed00ab324695d2bbedc733ecad","head":{"label":"target:feature_instance_tags","ref":"feature_instance_tags","sha":"d56fa0f0a23e17ed00ab324695d2bbedc733ecad","user":{"login":"target","id":932489,"avatar_url":"https://avatars.githubusercontent.com/u/932489?v=3","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"repo":{"id":58946721,"name":"clouddriver","full_name":"target/clouddriver","owner":{"login":"target","id":932489,"avatar_url":"https://avatars.githubusercontent.com/u/932489?v=3","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/target/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/target/clouddriver","forks_url":"https://api.github.com/repos/target/clouddriver/forks","keys_url":"https://api.github.com/repos/target/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/target/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/target/clouddriver/teams","hooks_url":"https://api.github.com/repos/target/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/target/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/target/clouddriver/events","assignees_url":"https://api.github.com/repos/target/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/target/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/target/clouddriver/tags","blobs_url":"https://api.github.com/repos/target/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/target/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/target/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/target/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/target/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/target/clouddriver/languages","stargazers_url":"https://api.github.com/repos/target/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/target/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/target/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/target/clouddriver/subscription","commits_url":"https://api.github.com/repos/target/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/target/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/target/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/target/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/target/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/target/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/target/clouddriver/merges","archive_url":"https://api.github.com/repos/target/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/target/clouddriver/downloads","issues_url":"https://api.github.com/repos/target/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/target/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/target/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/target/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/target/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/target/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/target/clouddriver/deployments","created_at":"2016-05-16T16:06:08Z","updated_at":"2016-05-16T16:06:14Z","pushed_at":"2016-09-06T20:06:35Z","git_url":"git://github.com/target/clouddriver.git","ssh_url":"git@github.com:target/clouddriver.git","clone_url":"https://github.com/target/clouddriver.git","svn_url":"https://github.com/target/clouddriver","homepage":null,"size":28719,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"2a01dd44948c0508ae29c1fcd4efb7e159da0041","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2016-09-01T04:39:20Z","pushed_at":"2016-09-06T20:06:35Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":30807,"stargazers_count":61,"watchers_count":61,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":6,"forks":99,"open_issues":6,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/998"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/998"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/998/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/998/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/d56fa0f0a23e17ed00ab324695d2bbedc733ecad"}}}}
{"actor":{"display_login":"derekolk"}}