{"action":"closed","number":1867,"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/1867","id":55857775,"html_url":"https://github.com/spinnaker/deck/pull/1867","diff_url":"https://github.com/spinnaker/deck/pull/1867.diff","patch_url":"https://github.com/spinnaker/deck/pull/1867.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/1867","number":1867,"state":"closed","locked":false,"title":"show date AWS server group was disabled","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"This started as a small pull request to change this:\r\n<img width=\"312\" alt=\"screen shot 2016-01-12 at 5 49 43 pm\" src=\"https://cloud.githubusercontent.com/assets/73450/12286271/9ce4c302-b977-11e5-82ef-06004bd93f20.png\">\r\n\r\nto this:\r\n<img width=\"310\" alt=\"screen shot 2016-01-12 at 5 49 56 pm\" src=\"https://cloud.githubusercontent.com/assets/73450/12286276/a29205c6-b977-11e5-90a5-2e1fa741f738.png\">\r\n\r\nI started down the path of breaking up the sections in the details panel into separate directives, but that would have made this a 1000+ line change, so I settled for converting it to ES6.\r\n\r\nThe core changes are moving the logic for extracting the scaling processes into the `autoScalingProcessService`, and adding that band along the bottom of the header when the server group is disabled - that's the first couple of files here, as well as the top part of the controller. After that, it's just converting to ES6.\r\n\r\n@zanthrash please review\r\n\r\n@duftler @gregturn @JargoonPard I did not touch anything but the AWS components - not sure what's involved in determining _when_ a server group was disabled for each provider. Ideally, we'd move this logic to Clouddriver, and we may someday.","created_at":"2016-01-13T06:03:05Z","updated_at":"2016-01-13T19:01:52Z","closed_at":"2016-01-13T19:01:52Z","merged_at":"2016-01-13T19:01:52Z","merge_commit_sha":"23d8c895811424f90d4feac63c82d8835ddcbcb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/1867/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/1867/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/1867/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/5c18a8be2c7977e3c95063bf50a24a3264fcb851","head":{"label":"anotherchrisberry:disable-date","ref":"disable-date","sha":"5c18a8be2c7977e3c95063bf50a24a3264fcb851","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"repo":{"id":46325253,"name":"deck","full_name":"anotherchrisberry/deck","owner":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anotherchrisberry/deck","description":"New and improved management UI","fork":true,"url":"https://api.github.com/repos/anotherchrisberry/deck","forks_url":"https://api.github.com/repos/anotherchrisberry/deck/forks","keys_url":"https://api.github.com/repos/anotherchrisberry/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anotherchrisberry/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anotherchrisberry/deck/teams","hooks_url":"https://api.github.com/repos/anotherchrisberry/deck/hooks","issue_events_url":"https://api.github.com/repos/anotherchrisberry/deck/issues/events{/number}","events_url":"https://api.github.com/repos/anotherchrisberry/deck/events","assignees_url":"https://api.github.com/repos/anotherchrisberry/deck/assignees{/user}","branches_url":"https://api.github.com/repos/anotherchrisberry/deck/branches{/branch}","tags_url":"https://api.github.com/repos/anotherchrisberry/deck/tags","blobs_url":"https://api.github.com/repos/anotherchrisberry/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anotherchrisberry/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anotherchrisberry/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/anotherchrisberry/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anotherchrisberry/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/anotherchrisberry/deck/languages","stargazers_url":"https://api.github.com/repos/anotherchrisberry/deck/stargazers","contributors_url":"https://api.github.com/repos/anotherchrisberry/deck/contributors","subscribers_url":"https://api.github.com/repos/anotherchrisberry/deck/subscribers","subscription_url":"https://api.github.com/repos/anotherchrisberry/deck/subscription","commits_url":"https://api.github.com/repos/anotherchrisberry/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/anotherchrisberry/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/anotherchrisberry/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/anotherchrisberry/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/anotherchrisberry/deck/contents/{+path}","compare_url":"https://api.github.com/repos/anotherchrisberry/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anotherchrisberry/deck/merges","archive_url":"https://api.github.com/repos/anotherchrisberry/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anotherchrisberry/deck/downloads","issues_url":"https://api.github.com/repos/anotherchrisberry/deck/issues{/number}","pulls_url":"https://api.github.com/repos/anotherchrisberry/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/anotherchrisberry/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/anotherchrisberry/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anotherchrisberry/deck/labels{/name}","releases_url":"https://api.github.com/repos/anotherchrisberry/deck/releases{/id}","created_at":"2015-11-17T05:27:30Z","updated_at":"2016-01-12T06:40:01Z","pushed_at":"2016-01-13T18:49:34Z","git_url":"git://github.com/anotherchrisberry/deck.git","ssh_url":"git@github.com:anotherchrisberry/deck.git","clone_url":"https://github.com/anotherchrisberry/deck.git","svn_url":"https://github.com/anotherchrisberry/deck","homepage":null,"size":21412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"d341560e6620489da09ac69dc9e42f19499df2da","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","created_at":"2014-07-17T18:51:00Z","updated_at":"2016-01-13T02:21:58Z","pushed_at":"2016-01-13T19:01:52Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":22533,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":2,"forks":34,"open_issues":2,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1867"},"html":{"href":"https://github.com/spinnaker/deck/pull/1867"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/1867"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/1867/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1867/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1867/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/5c18a8be2c7977e3c95063bf50a24a3264fcb851"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":462,"deletions":324,"changed_files":11}}