{"action":"created","comment":{"url":"https://api.github.com/repos/Gizra/og/pulls/comments/81590075","pull_request_review_id":2559041,"id":81590075,"diff_hunk":"@@ -46,6 +46,19 @@ public function getDefaultRoles();\n   public function getRequiredDefaultRoles();\n \n   /**\n+   * Returns all the roles of a provided group.\n+   *\n+   * @param string $entity_type_id\n+   *    The entity type id of the group.\n+   * @param string $bundle\n+   *    The bundle of the group.\n+   *\n+   * @return \\Drupal\\og\\OgRoleInterface[]\n+   *   An array of roles indexed by their ids.\n+   */\n+  public function loadRolesByGroup($entity_type_id, $bundle);","path":"src/OgRoleManagerInterface.php","position":14,"original_position":14,"commit_id":"453cf5f001745e8d92f6f6d1ab28bb4d3c7fb6a6","original_commit_id":"453cf5f001745e8d92f6f6d1ab28bb4d3c7fb6a6","user":{"login":"pfrenssen","id":442924,"avatar_url":"https://avatars.githubusercontent.com/u/442924?v=3","gravatar_id":"","url":"https://api.github.com/users/pfrenssen","html_url":"https://github.com/pfrenssen","followers_url":"https://api.github.com/users/pfrenssen/followers","following_url":"https://api.github.com/users/pfrenssen/following{/other_user}","gists_url":"https://api.github.com/users/pfrenssen/gists{/gist_id}","starred_url":"https://api.github.com/users/pfrenssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfrenssen/subscriptions","organizations_url":"https://api.github.com/users/pfrenssen/orgs","repos_url":"https://api.github.com/users/pfrenssen/repos","events_url":"https://api.github.com/users/pfrenssen/events{/privacy}","received_events_url":"https://api.github.com/users/pfrenssen/received_events","type":"User","site_admin":false},"body":"Yeah that makes sense, let's not force our users to have to call `OgRole::create()` if they have no group entity nearby :D ","created_at":"2016-10-03T16:46:13Z","updated_at":"2016-10-03T16:46:13Z","html_url":"https://github.com/Gizra/og/pull/197#discussion_r81590075","pull_request_url":"https://api.github.com/repos/Gizra/og/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/Gizra/og/pulls/comments/81590075"},"html":{"href":"https://github.com/Gizra/og/pull/197#discussion_r81590075"},"pull_request":{"href":"https://api.github.com/repos/Gizra/og/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/Gizra/og/pulls/197","id":87721307,"html_url":"https://github.com/Gizra/og/pull/197","diff_url":"https://github.com/Gizra/og/pull/197.diff","patch_url":"https://github.com/Gizra/og/pull/197.patch","issue_url":"https://api.github.com/repos/Gizra/og/issues/197","number":197,"state":"open","locked":false,"title":"Group roles load","user":{"login":"idimopoulos","id":12171851,"avatar_url":"https://avatars.githubusercontent.com/u/12171851?v=3","gravatar_id":"","url":"https://api.github.com/users/idimopoulos","html_url":"https://github.com/idimopoulos","followers_url":"https://api.github.com/users/idimopoulos/followers","following_url":"https://api.github.com/users/idimopoulos/following{/other_user}","gists_url":"https://api.github.com/users/idimopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/idimopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idimopoulos/subscriptions","organizations_url":"https://api.github.com/users/idimopoulos/orgs","repos_url":"https://api.github.com/users/idimopoulos/repos","events_url":"https://api.github.com/users/idimopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/idimopoulos/received_events","type":"User","site_admin":false},"body":"Given the work in progress of the UI and the use cases where we need to check roles per group, I was thinking that maybe we can have a method as part of the Role manager class that can load the roles of a group.\r\n\r\nCurrently, there is only a method to load a role given a group and a role name (in OgRole) but we do not have the sense of having all the roles of a group retrieved.\r\n\r\nThis was based on https://github.com/amitaibu/og/pull/196/files#diff-f5fb6aad0c225e8559cacebfcbf5d915R142 \r\n\r\nCan this be valid? Is this functionality useful to be separate (since it is just a few lines of code)?","created_at":"2016-10-03T13:59:12Z","updated_at":"2016-10-03T16:46:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4a54fef20f10942397e274b8547b956b329c850","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Gizra/og/pulls/197/commits","review_comments_url":"https://api.github.com/repos/Gizra/og/pulls/197/comments","review_comment_url":"https://api.github.com/repos/Gizra/og/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Gizra/og/issues/197/comments","statuses_url":"https://api.github.com/repos/Gizra/og/statuses/453cf5f001745e8d92f6f6d1ab28bb4d3c7fb6a6","head":{"label":"ec-europa:group_roles_load","ref":"group_roles_load","sha":"453cf5f001745e8d92f6f6d1ab28bb4d3c7fb6a6","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":46046967,"name":"og","full_name":"ec-europa/og","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/og","description":"https://www.drupal.org/project/og","fork":true,"url":"https://api.github.com/repos/ec-europa/og","forks_url":"https://api.github.com/repos/ec-europa/og/forks","keys_url":"https://api.github.com/repos/ec-europa/og/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/og/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/og/teams","hooks_url":"https://api.github.com/repos/ec-europa/og/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/og/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/og/events","assignees_url":"https://api.github.com/repos/ec-europa/og/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/og/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/og/tags","blobs_url":"https://api.github.com/repos/ec-europa/og/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/og/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/og/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/og/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/og/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/og/languages","stargazers_url":"https://api.github.com/repos/ec-europa/og/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/og/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/og/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/og/subscription","commits_url":"https://api.github.com/repos/ec-europa/og/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/og/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/og/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/og/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/og/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/og/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/og/merges","archive_url":"https://api.github.com/repos/ec-europa/og/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/og/downloads","issues_url":"https://api.github.com/repos/ec-europa/og/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/og/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/og/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/og/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/og/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/og/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/og/deployments","created_at":"2015-11-12T10:54:04Z","updated_at":"2016-03-11T15:02:28Z","pushed_at":"2016-10-03T15:48:10Z","git_url":"git://github.com/ec-europa/og.git","ssh_url":"git@github.com:ec-europa/og.git","clone_url":"https://github.com/ec-europa/og.git","svn_url":"https://github.com/ec-europa/og","homepage":"","size":6780,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"Gizra:8.x-1.x","ref":"8.x-1.x","sha":"4587fde254b86ad03c9044af5a69eaaa512f183f","user":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?v=3","gravatar_id":"","url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"repo":{"id":22711459,"name":"og","full_name":"Gizra/og","owner":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?v=3","gravatar_id":"","url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gizra/og","description":"https://www.drupal.org/project/og","fork":false,"url":"https://api.github.com/repos/Gizra/og","forks_url":"https://api.github.com/repos/Gizra/og/forks","keys_url":"https://api.github.com/repos/Gizra/og/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gizra/og/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gizra/og/teams","hooks_url":"https://api.github.com/repos/Gizra/og/hooks","issue_events_url":"https://api.github.com/repos/Gizra/og/issues/events{/number}","events_url":"https://api.github.com/repos/Gizra/og/events","assignees_url":"https://api.github.com/repos/Gizra/og/assignees{/user}","branches_url":"https://api.github.com/repos/Gizra/og/branches{/branch}","tags_url":"https://api.github.com/repos/Gizra/og/tags","blobs_url":"https://api.github.com/repos/Gizra/og/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gizra/og/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gizra/og/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gizra/og/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gizra/og/statuses/{sha}","languages_url":"https://api.github.com/repos/Gizra/og/languages","stargazers_url":"https://api.github.com/repos/Gizra/og/stargazers","contributors_url":"https://api.github.com/repos/Gizra/og/contributors","subscribers_url":"https://api.github.com/repos/Gizra/og/subscribers","subscription_url":"https://api.github.com/repos/Gizra/og/subscription","commits_url":"https://api.github.com/repos/Gizra/og/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gizra/og/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gizra/og/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gizra/og/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gizra/og/contents/{+path}","compare_url":"https://api.github.com/repos/Gizra/og/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gizra/og/merges","archive_url":"https://api.github.com/repos/Gizra/og/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gizra/og/downloads","issues_url":"https://api.github.com/repos/Gizra/og/issues{/number}","pulls_url":"https://api.github.com/repos/Gizra/og/pulls{/number}","milestones_url":"https://api.github.com/repos/Gizra/og/milestones{/number}","notifications_url":"https://api.github.com/repos/Gizra/og/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gizra/og/labels{/name}","releases_url":"https://api.github.com/repos/Gizra/og/releases{/id}","deployments_url":"https://api.github.com/repos/Gizra/og/deployments","created_at":"2014-08-07T06:48:42Z","updated_at":"2016-09-12T23:28:49Z","pushed_at":"2016-10-03T15:48:11Z","git_url":"git://github.com/Gizra/og.git","ssh_url":"git@github.com:Gizra/og.git","clone_url":"https://github.com/Gizra/og.git","svn_url":"https://github.com/Gizra/og","homepage":"","size":6967,"stargazers_count":40,"watchers_count":40,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":110,"forks":74,"open_issues":110,"watchers":40,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Gizra/og/pulls/197"},"html":{"href":"https://github.com/Gizra/og/pull/197"},"issue":{"href":"https://api.github.com/repos/Gizra/og/issues/197"},"comments":{"href":"https://api.github.com/repos/Gizra/og/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/Gizra/og/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/Gizra/og/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Gizra/og/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/Gizra/og/statuses/453cf5f001745e8d92f6f6d1ab28bb4d3c7fb6a6"}}}}
{"actor":{"display_login":"pfrenssen"}}