{"action":"created","comment":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79430058","id":79430058,"diff_hunk":"@@ -77,20 +78,14 @@ func init() {\n \t}\n }\n \n+// JoinFlags holds values for \"kubeadm join\" command flags.\n type JoinFlags struct {\n \tMasterAddrs []net.IP\n }\n \n-// TODO(phase1?) we haven't decided whether manual sub commands should get merged into  main commands...\n-type ManualFlags struct {","path":"cmd/kubeadm/app/api/types.go","position":47,"original_position":47,"commit_id":"ec3b5735877b457d7d39cca585cb9035cdd376ed","original_commit_id":"ec3b5735877b457d7d39cca585cb9035cdd376ed","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"body":"Thanks for removing it, I've been meaning to do it.","created_at":"2016-09-19T16:23:21Z","updated_at":"2016-09-19T16:33:54Z","html_url":"https://github.com/errordeveloper/kubernetes/pull/12#discussion_r79430058","pull_request_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79430058"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/12#discussion_r79430058"},"pull_request":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12","id":85814431,"html_url":"https://github.com/errordeveloper/kubernetes/pull/12","diff_url":"https://github.com/errordeveloper/kubernetes/pull/12.diff","patch_url":"https://github.com/errordeveloper/kubernetes/pull/12.patch","issue_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/12","number":12,"state":"open","locked":false,"title":"Reviewed typos, comments, instructions, etc.","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"body":"/cc @errordeveloper @lukemarsden ","created_at":"2016-09-19T15:23:32Z","updated_at":"2016-09-19T16:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f321748d05cad98ce42c49c61e81345438e4247e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12/commits","review_comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12/comments","review_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/12/comments","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/ec3b5735877b457d7d39cca585cb9035cdd376ed","head":{"label":"pires:kubeadm-help","ref":"kubeadm-help","sha":"ec3b5735877b457d7d39cca585cb9035cdd376ed","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"repo":{"id":28869198,"name":"kubernetes","full_name":"pires/kubernetes","owner":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pires/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/pires/kubernetes","forks_url":"https://api.github.com/repos/pires/kubernetes/forks","keys_url":"https://api.github.com/repos/pires/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pires/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pires/kubernetes/teams","hooks_url":"https://api.github.com/repos/pires/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pires/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pires/kubernetes/events","assignees_url":"https://api.github.com/repos/pires/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pires/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pires/kubernetes/tags","blobs_url":"https://api.github.com/repos/pires/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pires/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pires/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pires/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pires/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pires/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pires/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pires/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pires/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pires/kubernetes/subscription","commits_url":"https://api.github.com/repos/pires/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pires/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pires/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pires/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pires/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pires/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pires/kubernetes/merges","archive_url":"https://api.github.com/repos/pires/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pires/kubernetes/downloads","issues_url":"https://api.github.com/repos/pires/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pires/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pires/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pires/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pires/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pires/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pires/kubernetes/deployments","created_at":"2015-01-06T15:24:52Z","updated_at":"2016-03-22T14:21:11Z","pushed_at":"2016-09-19T15:19:34Z","git_url":"git://github.com/pires/kubernetes.git","ssh_url":"git@github.com:pires/kubernetes.git","clone_url":"https://github.com/pires/kubernetes.git","svn_url":"https://github.com/pires/kubernetes","homepage":null,"size":314318,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errordeveloper:kubeadm","ref":"kubeadm","sha":"c943473c979db1f03ca76f29280a82e8136b5604","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":25202727,"name":"kubernetes","full_name":"errordeveloper/kubernetes","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/errordeveloper/kubernetes","forks_url":"https://api.github.com/repos/errordeveloper/kubernetes/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubernetes/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubernetes/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubernetes/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubernetes/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubernetes/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubernetes/deployments","created_at":"2014-10-14T11:13:25Z","updated_at":"2016-03-23T12:29:37Z","pushed_at":"2016-09-19T15:23:32Z","git_url":"git://github.com/errordeveloper/kubernetes.git","ssh_url":"git@github.com:errordeveloper/kubernetes.git","clone_url":"https://github.com/errordeveloper/kubernetes.git","svn_url":"https://github.com/errordeveloper/kubernetes","homepage":null,"size":316624,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/12"},"issue":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/12"},"comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/ec3b5735877b457d7d39cca585cb9035cdd376ed"}}}}
{"actor":{"display_login":"errordeveloper"}}