{"action":"created","comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/81172752","pull_request_review_id":2172520,"id":81172752,"diff_hunk":"@@ -114,15 +114,37 @@ var ModelingController = {\n             project = App.currentProject;\n             project.set('model_package', modelPackage);\n             itsiResetProject(project);\n+            App.getMapView().addSidebarToggleControl();","path":"src/mmw/js/src/modeling/controllers.js","position":4,"original_position":4,"commit_id":"bd4f70409d984523d9ed98ffc2f3132105a34579","original_commit_id":"bd4f70409d984523d9ed98ffc2f3132105a34579","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"body":"Why is this needed here when it also exists on line 148?","created_at":"2016-09-29T16:04:26Z","updated_at":"2016-09-29T16:12:31Z","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1492#discussion_r81172752","pull_request_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492","_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/81172752"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1492#discussion_r81172752"},"pull_request":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492"}}},"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492","id":86980296,"html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1492","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1492.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1492.patch","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1492","number":1492,"state":"open","locked":false,"title":"Reduce geoprocessor calls","user":{"login":"jtarricone","id":18290666,"avatar_url":"https://avatars.githubusercontent.com/u/18290666?v=3","gravatar_id":"","url":"https://api.github.com/users/jtarricone","html_url":"https://github.com/jtarricone","followers_url":"https://api.github.com/users/jtarricone/followers","following_url":"https://api.github.com/users/jtarricone/following{/other_user}","gists_url":"https://api.github.com/users/jtarricone/gists{/gist_id}","starred_url":"https://api.github.com/users/jtarricone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtarricone/subscriptions","organizations_url":"https://api.github.com/users/jtarricone/orgs","repos_url":"https://api.github.com/users/jtarricone/repos","events_url":"https://api.github.com/users/jtarricone/events{/privacy}","received_events_url":"https://api.github.com/users/jtarricone/received_events","type":"User","site_admin":false},"body":"This is a minor refactor that reduces the number of calls to the geoprocessor by bundling the AoI census into the JSON blob returned by the `analyze` endpoint, and subsequently using it when instantiating projects and scenarios so that it can be POSTed to the API modeling endpoints. The durations of the blocking geoprocessor calls are not trivial, especially for large AoI's.\r\n\r\nTo test:\r\n* clone the branch and bring up the environment\r\n* navigate to `http://localhost:8000`\r\n* go through typical user actions, e.g. select an AoI for analysis, create a TR55 model, add some scenarios\r\n* keeping the test version of the app open, switch branches to `develop` or navigate the to the staging site and perform the same user actions, trying to keep all the parameters as close to identical as possible\r\n* compare the two to make sure the output is identical, or if the parameters of the model are slightly different, that the differences can reasonably be ignored\r\n* in general, the test version should be faster than the baseline, especially if the AoI is somewhat large (>10k sq-km)\r\n\r\nConnects #956 ","created_at":"2016-09-27T17:58:24Z","updated_at":"2016-09-29T16:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"098f451e5c70a610786c99e0d456d18576126a43","assignee":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492/commits","review_comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492/comments","review_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1492/comments","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/bd4f70409d984523d9ed98ffc2f3132105a34579","head":{"label":"jtarricone:feature/reduce-geop-calls","ref":"feature/reduce-geop-calls","sha":"bd4f70409d984523d9ed98ffc2f3132105a34579","user":{"login":"jtarricone","id":18290666,"avatar_url":"https://avatars.githubusercontent.com/u/18290666?v=3","gravatar_id":"","url":"https://api.github.com/users/jtarricone","html_url":"https://github.com/jtarricone","followers_url":"https://api.github.com/users/jtarricone/followers","following_url":"https://api.github.com/users/jtarricone/following{/other_user}","gists_url":"https://api.github.com/users/jtarricone/gists{/gist_id}","starred_url":"https://api.github.com/users/jtarricone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtarricone/subscriptions","organizations_url":"https://api.github.com/users/jtarricone/orgs","repos_url":"https://api.github.com/users/jtarricone/repos","events_url":"https://api.github.com/users/jtarricone/events{/privacy}","received_events_url":"https://api.github.com/users/jtarricone/received_events","type":"User","site_admin":false},"repo":{"id":55988813,"name":"model-my-watershed","full_name":"jtarricone/model-my-watershed","owner":{"login":"jtarricone","id":18290666,"avatar_url":"https://avatars.githubusercontent.com/u/18290666?v=3","gravatar_id":"","url":"https://api.github.com/users/jtarricone","html_url":"https://github.com/jtarricone","followers_url":"https://api.github.com/users/jtarricone/followers","following_url":"https://api.github.com/users/jtarricone/following{/other_user}","gists_url":"https://api.github.com/users/jtarricone/gists{/gist_id}","starred_url":"https://api.github.com/users/jtarricone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtarricone/subscriptions","organizations_url":"https://api.github.com/users/jtarricone/orgs","repos_url":"https://api.github.com/users/jtarricone/repos","events_url":"https://api.github.com/users/jtarricone/events{/privacy}","received_events_url":"https://api.github.com/users/jtarricone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtarricone/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":true,"url":"https://api.github.com/repos/jtarricone/model-my-watershed","forks_url":"https://api.github.com/repos/jtarricone/model-my-watershed/forks","keys_url":"https://api.github.com/repos/jtarricone/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtarricone/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtarricone/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/jtarricone/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/jtarricone/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/jtarricone/model-my-watershed/events","assignees_url":"https://api.github.com/repos/jtarricone/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/jtarricone/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/jtarricone/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/jtarricone/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtarricone/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtarricone/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtarricone/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtarricone/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/jtarricone/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/jtarricone/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/jtarricone/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/jtarricone/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/jtarricone/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/jtarricone/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtarricone/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtarricone/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtarricone/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtarricone/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/jtarricone/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtarricone/model-my-watershed/merges","archive_url":"https://api.github.com/repos/jtarricone/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtarricone/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/jtarricone/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/jtarricone/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/jtarricone/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/jtarricone/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtarricone/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/jtarricone/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/jtarricone/model-my-watershed/deployments","created_at":"2016-04-11T16:28:20Z","updated_at":"2016-04-11T16:28:21Z","pushed_at":"2016-09-29T15:13:00Z","git_url":"git://github.com/jtarricone/model-my-watershed.git","ssh_url":"git@github.com:jtarricone/model-my-watershed.git","clone_url":"https://github.com/jtarricone/model-my-watershed.git","svn_url":"https://github.com/jtarricone/model-my-watershed","homepage":null,"size":17646,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"WikiWatershed:develop","ref":"develop","sha":"0617c5f8ccc5eb2418b362e4102b1374c2d5d1c8","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/deployments","created_at":"2015-03-23T16:02:55Z","updated_at":"2016-08-30T18:26:42Z","pushed_at":"2016-09-29T15:13:00Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"git@github.com:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":null,"size":18248,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":167,"forks":14,"open_issues":167,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1492"},"issue":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1492"},"comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1492/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1492/commits"},"statuses":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/bd4f70409d984523d9ed98ffc2f3132105a34579"}}}}
{"actor":{"display_login":"rajadain"}}