{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/93066845","pull_request_review_id":13588374,"id":93066845,"diff_hunk":"@@ -1644,6 +1644,54 @@ def set_multiplicity_matrix_mgxs(self, nuscatter, scatter=None,\n         self._multiplicity_matrix[i] = \\\n             np.nan_to_num(self._multiplicity_matrix[i])\n \n+    def set_inverse_velocity_mgxs(self, inverse_velocity, temperature=294.,\n+                                  nuclide='total', xs_type='macro',\n+                                  subdomain=None):\n+        \"\"\"This method allows for an openmc.mgxs.InverseVelocity\n+        to be used to set the absorption cross section for this XSdata object.\n+\n+        Parameters\n+        ----------\n+        inverse_velocity : openmc.mgxs.InverseVelocity\n+            MGXS Object containing the inverse velocity for the domain of\n+            interest.\n+        temperature : float\n+            Temperature (in Kelvin) of the data. Defaults to room temperature\n+            (294K).\n+        nuclide : str\n+            Individual nuclide (or 'total' if obtaining material-wise data)\n+            to gather data for.  Defaults to 'total'.\n+        xs_type: {'macro', 'micro'}\n+            Provide the macro or micro cross section in units of cm^-1 or\n+            barns. Defaults to 'macro'.\n+        subdomain : iterable of int\n+            If the MGXS contains a mesh domain type, the subdomain parameter\n+            specifies which mesh cell (i.e., [i, j, k] index) to use.\n+\n+        See also\n+        --------\n+        openmc.mgxs.Library.create_mg_library()\n+        openmc.mgxs.Library.get_xsdata","path":"openmc/mgxs_library.py","position":108,"original_position":108,"commit_id":"1a7630083b609bfc7e09b3a866c6f7d5d97f1450","original_commit_id":"1a7630083b609bfc7e09b3a866c6f7d5d97f1450","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"It should have parentheses. This is used for all the setter methods, so I'll change it throughout.","created_at":"2016-12-19T16:29:08Z","updated_at":"2016-12-19T16:29:08Z","html_url":"https://github.com/mit-crpg/openmc/pull/771#discussion_r93066845","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/771","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/93066845"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/771#discussion_r93066845"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/771"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/771","id":98231342,"html_url":"https://github.com/mit-crpg/openmc/pull/771","diff_url":"https://github.com/mit-crpg/openmc/pull/771.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/771.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/771","number":771,"state":"open","locked":false,"title":"Track length estimator for decay rate tally and other fixes","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This PR adds the capability to use the track length estimator for the decay-rate tally. Since the decay-rate tally with an analog estimator is only tallied to when there is a delayed neutron created, there will be very few analog tallies to decay-rate. Additionally, a number of other items were addressed:\r\n\r\n* `Material.get_nuclide_atom_densities()` method was not properly outputting the nuclide atom densities.\r\n* `mgxs.Library` was not properly adding delayed groups to MDGXS objects.\r\n* Added a `mgxs.MGXS.get_homogenized_mgxs()` method to homogenize MGXS objects. This has been useful for computing the MGXS for the C5G7 benchmark using the given isotopic data. The benchmark homogenizes the fuel, inner gap, inner clad, outer gap, and outer clad, so it is nice to have the functionality to homogenize MGXS within the MGXS framework.\r\n* Fixed ordering of DG in `XSdata._xs_shapes`.\r\n* Added `XSdata.set_inverse_velocity_mgxs()` method.\r\n* Added option to set path of `tallies.xml` file, consistent with the other xml files.\r\n* Updated python example input files to avoid explicitly creating nuclide and element objects.","created_at":"2016-12-15T21:08:36Z","updated_at":"2016-12-19T16:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2032c69b60f7ae859eee58ea16522ca348edbd85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/771/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/771/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/771/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/1a7630083b609bfc7e09b3a866c6f7d5d97f1450","head":{"label":"samuelshaner:decay-rate-tracklength","ref":"decay-rate-tracklength","sha":"1a7630083b609bfc7e09b3a866c6f7d5d97f1450","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":30840720,"name":"openmc","full_name":"samuelshaner/openmc","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/samuelshaner/openmc","forks_url":"https://api.github.com/repos/samuelshaner/openmc/forks","keys_url":"https://api.github.com/repos/samuelshaner/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/openmc/teams","hooks_url":"https://api.github.com/repos/samuelshaner/openmc/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/openmc/events","assignees_url":"https://api.github.com/repos/samuelshaner/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/openmc/tags","blobs_url":"https://api.github.com/repos/samuelshaner/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/openmc/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/openmc/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/openmc/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/openmc/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/openmc/subscription","commits_url":"https://api.github.com/repos/samuelshaner/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/openmc/merges","archive_url":"https://api.github.com/repos/samuelshaner/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/openmc/downloads","issues_url":"https://api.github.com/repos/samuelshaner/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/openmc/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/samuelshaner/openmc/deployments","created_at":"2015-02-15T20:23:50Z","updated_at":"2016-10-11T12:42:32Z","pushed_at":"2016-12-15T22:27:06Z","git_url":"git://github.com/samuelshaner/openmc.git","ssh_url":"git@github.com:samuelshaner/openmc.git","clone_url":"https://github.com/samuelshaner/openmc.git","svn_url":"https://github.com/samuelshaner/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":35563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"9b94c4dbec1de082f5d44f36f60818796d3ed4b5","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/openmc/deployments","created_at":"2011-07-21T00:33:27Z","updated_at":"2016-12-11T20:01:03Z","pushed_at":"2016-12-17T20:31:50Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":34898,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":50,"forks":105,"open_issues":50,"watchers":93,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/771"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/771"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/771"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/1a7630083b609bfc7e09b3a866c6f7d5d97f1450"}}}}
{"actor":{"display_login":"samuelshaner"}}