{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82126255","pull_request_review_id":3054134,"id":82126255,"diff_hunk":"@@ -3090,6 +3090,7 @@ zfs_receive_one(libzfs_handle_t *hdl, int infd, const char *tosnap,\n \tuint64_t errflags = 0;\n \tuint64_t parent_snapguid = 0;\n \tprop_changelist_t *clp = NULL;\n+\tnvlist_t *lookup_nvlist = NULL;","path":"lib/libzfs/libzfs_sendrecv.c","position":null,"original_position":4,"commit_id":"1739eb98488889dd178c1b833e1c80cd61f285d0","original_commit_id":"d4e77bb8506950dd3b0556143676744be5d061f1","user":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"body":"Done, and rebased on current master","created_at":"2016-10-06T06:52:19Z","updated_at":"2016-10-06T06:52:20Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5189#discussion_r82126255","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82126255"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5189#discussion_r82126255"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189","id":87187916,"html_url":"https://github.com/zfsonlinux/zfs/pull/5189","diff_url":"https://github.com/zfsonlinux/zfs/pull/5189.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5189.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5189","number":5189,"state":"open","locked":false,"title":"Fix receiving custom snapshot properties","user":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"body":"We never initialize `snapprops_nvlist` in `zfs_receive_one`, so custom properties aren't applied to the received snapshot.\r\n\r\nShould fix https://github.com/zfsonlinux/zfs/issues/4338, more info in comments.","created_at":"2016-09-28T19:49:21Z","updated_at":"2016-10-06T06:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b93219030eb76fb727a2fd50f720c44b97403f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5189/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/1739eb98488889dd178c1b833e1c80cd61f285d0","head":{"label":"loli10K:master","ref":"master","sha":"1739eb98488889dd178c1b833e1c80cd61f285d0","user":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"repo":{"id":67621699,"name":"zfs","full_name":"loli10K/zfs","owner":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loli10K/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/loli10K/zfs","forks_url":"https://api.github.com/repos/loli10K/zfs/forks","keys_url":"https://api.github.com/repos/loli10K/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loli10K/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loli10K/zfs/teams","hooks_url":"https://api.github.com/repos/loli10K/zfs/hooks","issue_events_url":"https://api.github.com/repos/loli10K/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/loli10K/zfs/events","assignees_url":"https://api.github.com/repos/loli10K/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/loli10K/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/loli10K/zfs/tags","blobs_url":"https://api.github.com/repos/loli10K/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loli10K/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loli10K/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/loli10K/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loli10K/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/loli10K/zfs/languages","stargazers_url":"https://api.github.com/repos/loli10K/zfs/stargazers","contributors_url":"https://api.github.com/repos/loli10K/zfs/contributors","subscribers_url":"https://api.github.com/repos/loli10K/zfs/subscribers","subscription_url":"https://api.github.com/repos/loli10K/zfs/subscription","commits_url":"https://api.github.com/repos/loli10K/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/loli10K/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/loli10K/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/loli10K/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/loli10K/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/loli10K/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loli10K/zfs/merges","archive_url":"https://api.github.com/repos/loli10K/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loli10K/zfs/downloads","issues_url":"https://api.github.com/repos/loli10K/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/loli10K/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/loli10K/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/loli10K/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loli10K/zfs/labels{/name}","releases_url":"https://api.github.com/repos/loli10K/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/loli10K/zfs/deployments","created_at":"2016-09-07T15:51:11Z","updated_at":"2016-09-07T15:51:18Z","pushed_at":"2016-10-06T06:49:51Z","git_url":"git://github.com/loli10K/zfs.git","ssh_url":"git@github.com:loli10K/zfs.git","clone_url":"https://github.com/loli10K/zfs.git","svn_url":"https://github.com/loli10K/zfs","homepage":"http://zfsonlinux.org/","size":32507,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"64c688d7161daac0a799b11b40cb791f6fd264db","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-10-06T03:40:54Z","pushed_at":"2016-10-06T06:49:52Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":60276,"stargazers_count":2072,"watchers_count":2072,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":988,"forks":518,"open_issues":988,"watchers":2072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5189"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5189"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5189/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5189/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/1739eb98488889dd178c1b833e1c80cd61f285d0"}}}}
{"actor":{"display_login":"loli10K"}}