{"action":"created","comment":{"url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/comments/57446074","id":57446074,"diff_hunk":"@@ -0,0 +1,59 @@\n+package io.github.pancake.servlet;\n+\n+import static org.junit.Assert.assertEquals;\n+import static org.mockito.Mockito.when;\n+\n+import java.io.IOException;\n+import java.io.PrintWriter;\n+import java.io.StringWriter;\n+\n+import javax.servlet.http.HttpServletRequest;\n+import javax.servlet.http.HttpServletResponse;\n+\n+import org.junit.Before;\n+import org.junit.Test;\n+import org.mockito.Mock;\n+import org.mockito.MockitoAnnotations;\n+\n+/**\n+ * @author Adorjan Nagy\n+ *\n+ */\n+public class PancakeServletTest {\n+\n+    @Mock\n+    private HttpServletRequest request;\n+    @Mock\n+    private HttpServletResponse response;\n+\n+    private PancakeServlet underTest;\n+    private String PancakeServletResponseHtml;","path":"src/test/java/io/github/pancake/servlet/PancakeServletTest.java","position":30,"original_position":30,"commit_id":"7d65ab9837ef0e0f3053d08b350278dd5e389323","original_commit_id":"7d65ab9837ef0e0f3053d08b350278dd5e389323","user":{"login":"kicsikrumpli","id":5749514,"avatar_url":"https://avatars.githubusercontent.com/u/5749514?v=3","gravatar_id":"","url":"https://api.github.com/users/kicsikrumpli","html_url":"https://github.com/kicsikrumpli","followers_url":"https://api.github.com/users/kicsikrumpli/followers","following_url":"https://api.github.com/users/kicsikrumpli/following{/other_user}","gists_url":"https://api.github.com/users/kicsikrumpli/gists{/gist_id}","starred_url":"https://api.github.com/users/kicsikrumpli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kicsikrumpli/subscriptions","organizations_url":"https://api.github.com/users/kicsikrumpli/orgs","repos_url":"https://api.github.com/users/kicsikrumpli/repos","events_url":"https://api.github.com/users/kicsikrumpli/events{/privacy}","received_events_url":"https://api.github.com/users/kicsikrumpli/received_events","type":"User","site_admin":false},"body":"- this might as well be a private static final\r\n- String concatenation is compiled into string builder anyway, no harm in using `+`\r\n- I wouldn't test for output of servlet, rather its behavior","created_at":"2016-03-25T14:02:59Z","updated_at":"2016-03-25T14:02:59Z","html_url":"https://github.com/kicsikrumpli/pancake/pull/2#discussion_r57446074","pull_request_url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/comments/57446074"},"html":{"href":"https://github.com/kicsikrumpli/pancake/pull/2#discussion_r57446074"},"pull_request":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2","id":64163515,"html_url":"https://github.com/kicsikrumpli/pancake/pull/2","diff_url":"https://github.com/kicsikrumpli/pancake/pull/2.diff","patch_url":"https://github.com/kicsikrumpli/pancake/pull/2.patch","issue_url":"https://api.github.com/repos/kicsikrumpli/pancake/issues/2","number":2,"state":"open","locked":false,"title":"Phase #1","user":{"login":"adorjan","id":878167,"avatar_url":"https://avatars.githubusercontent.com/u/878167?v=3","gravatar_id":"","url":"https://api.github.com/users/adorjan","html_url":"https://github.com/adorjan","followers_url":"https://api.github.com/users/adorjan/followers","following_url":"https://api.github.com/users/adorjan/following{/other_user}","gists_url":"https://api.github.com/users/adorjan/gists{/gist_id}","starred_url":"https://api.github.com/users/adorjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorjan/subscriptions","organizations_url":"https://api.github.com/users/adorjan/orgs","repos_url":"https://api.github.com/users/adorjan/repos","events_url":"https://api.github.com/users/adorjan/events{/privacy}","received_events_url":"https://api.github.com/users/adorjan/received_events","type":"User","site_admin":false},"body":"- Maven app\r\n- Servlet API\r\n- Static content\r\n- Unit test","created_at":"2016-03-25T13:47:24Z","updated_at":"2016-03-25T14:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0578b0a6eaf9b57228c53301ab6aa707fcd5d00c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2/commits","review_comments_url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2/comments","review_comment_url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kicsikrumpli/pancake/issues/2/comments","statuses_url":"https://api.github.com/repos/kicsikrumpli/pancake/statuses/7d65ab9837ef0e0f3053d08b350278dd5e389323","head":{"label":"adorjan:Adorjan","ref":"Adorjan","sha":"7d65ab9837ef0e0f3053d08b350278dd5e389323","user":{"login":"adorjan","id":878167,"avatar_url":"https://avatars.githubusercontent.com/u/878167?v=3","gravatar_id":"","url":"https://api.github.com/users/adorjan","html_url":"https://github.com/adorjan","followers_url":"https://api.github.com/users/adorjan/followers","following_url":"https://api.github.com/users/adorjan/following{/other_user}","gists_url":"https://api.github.com/users/adorjan/gists{/gist_id}","starred_url":"https://api.github.com/users/adorjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorjan/subscriptions","organizations_url":"https://api.github.com/users/adorjan/orgs","repos_url":"https://api.github.com/users/adorjan/repos","events_url":"https://api.github.com/users/adorjan/events{/privacy}","received_events_url":"https://api.github.com/users/adorjan/received_events","type":"User","site_admin":false},"repo":{"id":54633563,"name":"pancake","full_name":"adorjan/pancake","owner":{"login":"adorjan","id":878167,"avatar_url":"https://avatars.githubusercontent.com/u/878167?v=3","gravatar_id":"","url":"https://api.github.com/users/adorjan","html_url":"https://github.com/adorjan","followers_url":"https://api.github.com/users/adorjan/followers","following_url":"https://api.github.com/users/adorjan/following{/other_user}","gists_url":"https://api.github.com/users/adorjan/gists{/gist_id}","starred_url":"https://api.github.com/users/adorjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorjan/subscriptions","organizations_url":"https://api.github.com/users/adorjan/orgs","repos_url":"https://api.github.com/users/adorjan/repos","events_url":"https://api.github.com/users/adorjan/events{/privacy}","received_events_url":"https://api.github.com/users/adorjan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adorjan/pancake","description":"pancake training project","fork":true,"url":"https://api.github.com/repos/adorjan/pancake","forks_url":"https://api.github.com/repos/adorjan/pancake/forks","keys_url":"https://api.github.com/repos/adorjan/pancake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adorjan/pancake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adorjan/pancake/teams","hooks_url":"https://api.github.com/repos/adorjan/pancake/hooks","issue_events_url":"https://api.github.com/repos/adorjan/pancake/issues/events{/number}","events_url":"https://api.github.com/repos/adorjan/pancake/events","assignees_url":"https://api.github.com/repos/adorjan/pancake/assignees{/user}","branches_url":"https://api.github.com/repos/adorjan/pancake/branches{/branch}","tags_url":"https://api.github.com/repos/adorjan/pancake/tags","blobs_url":"https://api.github.com/repos/adorjan/pancake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adorjan/pancake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adorjan/pancake/git/refs{/sha}","trees_url":"https://api.github.com/repos/adorjan/pancake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adorjan/pancake/statuses/{sha}","languages_url":"https://api.github.com/repos/adorjan/pancake/languages","stargazers_url":"https://api.github.com/repos/adorjan/pancake/stargazers","contributors_url":"https://api.github.com/repos/adorjan/pancake/contributors","subscribers_url":"https://api.github.com/repos/adorjan/pancake/subscribers","subscription_url":"https://api.github.com/repos/adorjan/pancake/subscription","commits_url":"https://api.github.com/repos/adorjan/pancake/commits{/sha}","git_commits_url":"https://api.github.com/repos/adorjan/pancake/git/commits{/sha}","comments_url":"https://api.github.com/repos/adorjan/pancake/comments{/number}","issue_comment_url":"https://api.github.com/repos/adorjan/pancake/issues/comments{/number}","contents_url":"https://api.github.com/repos/adorjan/pancake/contents/{+path}","compare_url":"https://api.github.com/repos/adorjan/pancake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adorjan/pancake/merges","archive_url":"https://api.github.com/repos/adorjan/pancake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adorjan/pancake/downloads","issues_url":"https://api.github.com/repos/adorjan/pancake/issues{/number}","pulls_url":"https://api.github.com/repos/adorjan/pancake/pulls{/number}","milestones_url":"https://api.github.com/repos/adorjan/pancake/milestones{/number}","notifications_url":"https://api.github.com/repos/adorjan/pancake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adorjan/pancake/labels{/name}","releases_url":"https://api.github.com/repos/adorjan/pancake/releases{/id}","deployments_url":"https://api.github.com/repos/adorjan/pancake/deployments","created_at":"2016-03-24T10:25:08Z","updated_at":"2016-03-24T10:03:27Z","pushed_at":"2016-03-25T13:46:19Z","git_url":"git://github.com/adorjan/pancake.git","ssh_url":"git@github.com:adorjan/pancake.git","clone_url":"https://github.com/adorjan/pancake.git","svn_url":"https://github.com/adorjan/pancake","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kicsikrumpli:Adorjan","ref":"Adorjan","sha":"311963834926784bfff337c7b86848e5e61388e8","user":{"login":"kicsikrumpli","id":5749514,"avatar_url":"https://avatars.githubusercontent.com/u/5749514?v=3","gravatar_id":"","url":"https://api.github.com/users/kicsikrumpli","html_url":"https://github.com/kicsikrumpli","followers_url":"https://api.github.com/users/kicsikrumpli/followers","following_url":"https://api.github.com/users/kicsikrumpli/following{/other_user}","gists_url":"https://api.github.com/users/kicsikrumpli/gists{/gist_id}","starred_url":"https://api.github.com/users/kicsikrumpli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kicsikrumpli/subscriptions","organizations_url":"https://api.github.com/users/kicsikrumpli/orgs","repos_url":"https://api.github.com/users/kicsikrumpli/repos","events_url":"https://api.github.com/users/kicsikrumpli/events{/privacy}","received_events_url":"https://api.github.com/users/kicsikrumpli/received_events","type":"User","site_admin":false},"repo":{"id":54632371,"name":"pancake","full_name":"kicsikrumpli/pancake","owner":{"login":"kicsikrumpli","id":5749514,"avatar_url":"https://avatars.githubusercontent.com/u/5749514?v=3","gravatar_id":"","url":"https://api.github.com/users/kicsikrumpli","html_url":"https://github.com/kicsikrumpli","followers_url":"https://api.github.com/users/kicsikrumpli/followers","following_url":"https://api.github.com/users/kicsikrumpli/following{/other_user}","gists_url":"https://api.github.com/users/kicsikrumpli/gists{/gist_id}","starred_url":"https://api.github.com/users/kicsikrumpli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kicsikrumpli/subscriptions","organizations_url":"https://api.github.com/users/kicsikrumpli/orgs","repos_url":"https://api.github.com/users/kicsikrumpli/repos","events_url":"https://api.github.com/users/kicsikrumpli/events{/privacy}","received_events_url":"https://api.github.com/users/kicsikrumpli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kicsikrumpli/pancake","description":"pancake training project","fork":false,"url":"https://api.github.com/repos/kicsikrumpli/pancake","forks_url":"https://api.github.com/repos/kicsikrumpli/pancake/forks","keys_url":"https://api.github.com/repos/kicsikrumpli/pancake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kicsikrumpli/pancake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kicsikrumpli/pancake/teams","hooks_url":"https://api.github.com/repos/kicsikrumpli/pancake/hooks","issue_events_url":"https://api.github.com/repos/kicsikrumpli/pancake/issues/events{/number}","events_url":"https://api.github.com/repos/kicsikrumpli/pancake/events","assignees_url":"https://api.github.com/repos/kicsikrumpli/pancake/assignees{/user}","branches_url":"https://api.github.com/repos/kicsikrumpli/pancake/branches{/branch}","tags_url":"https://api.github.com/repos/kicsikrumpli/pancake/tags","blobs_url":"https://api.github.com/repos/kicsikrumpli/pancake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kicsikrumpli/pancake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kicsikrumpli/pancake/git/refs{/sha}","trees_url":"https://api.github.com/repos/kicsikrumpli/pancake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kicsikrumpli/pancake/statuses/{sha}","languages_url":"https://api.github.com/repos/kicsikrumpli/pancake/languages","stargazers_url":"https://api.github.com/repos/kicsikrumpli/pancake/stargazers","contributors_url":"https://api.github.com/repos/kicsikrumpli/pancake/contributors","subscribers_url":"https://api.github.com/repos/kicsikrumpli/pancake/subscribers","subscription_url":"https://api.github.com/repos/kicsikrumpli/pancake/subscription","commits_url":"https://api.github.com/repos/kicsikrumpli/pancake/commits{/sha}","git_commits_url":"https://api.github.com/repos/kicsikrumpli/pancake/git/commits{/sha}","comments_url":"https://api.github.com/repos/kicsikrumpli/pancake/comments{/number}","issue_comment_url":"https://api.github.com/repos/kicsikrumpli/pancake/issues/comments{/number}","contents_url":"https://api.github.com/repos/kicsikrumpli/pancake/contents/{+path}","compare_url":"https://api.github.com/repos/kicsikrumpli/pancake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kicsikrumpli/pancake/merges","archive_url":"https://api.github.com/repos/kicsikrumpli/pancake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kicsikrumpli/pancake/downloads","issues_url":"https://api.github.com/repos/kicsikrumpli/pancake/issues{/number}","pulls_url":"https://api.github.com/repos/kicsikrumpli/pancake/pulls{/number}","milestones_url":"https://api.github.com/repos/kicsikrumpli/pancake/milestones{/number}","notifications_url":"https://api.github.com/repos/kicsikrumpli/pancake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kicsikrumpli/pancake/labels{/name}","releases_url":"https://api.github.com/repos/kicsikrumpli/pancake/releases{/id}","deployments_url":"https://api.github.com/repos/kicsikrumpli/pancake/deployments","created_at":"2016-03-24T10:03:27Z","updated_at":"2016-03-24T10:03:27Z","pushed_at":"2016-03-25T13:47:24Z","git_url":"git://github.com/kicsikrumpli/pancake.git","ssh_url":"git@github.com:kicsikrumpli/pancake.git","clone_url":"https://github.com/kicsikrumpli/pancake.git","svn_url":"https://github.com/kicsikrumpli/pancake","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2"},"html":{"href":"https://github.com/kicsikrumpli/pancake/pull/2"},"issue":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/issues/2"},"comments":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/kicsikrumpli/pancake/statuses/7d65ab9837ef0e0f3053d08b350278dd5e389323"}}}}