{"action":"created","issue":{"url":"https://api.github.com/repos/lxde/liblxqt/issues/77","labels_url":"https://api.github.com/repos/lxde/liblxqt/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/lxde/liblxqt/issues/77/comments","events_url":"https://api.github.com/repos/lxde/liblxqt/issues/77/events","html_url":"https://github.com/lxde/liblxqt/pull/77","id":125512791,"number":77,"title":"settings: Upgrade emitting of \"changed\" signals","user":{"login":"palinek","id":10990929,"avatar_url":"https://avatars.githubusercontent.com/u/10990929?v=3","gravatar_id":"","url":"https://api.github.com/users/palinek","html_url":"https://github.com/palinek","followers_url":"https://api.github.com/users/palinek/followers","following_url":"https://api.github.com/users/palinek/following{/other_user}","gists_url":"https://api.github.com/users/palinek/gists{/gist_id}","starred_url":"https://api.github.com/users/palinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palinek/subscriptions","organizations_url":"https://api.github.com/users/palinek/orgs","repos_url":"https://api.github.com/users/palinek/repos","events_url":"https://api.github.com/users/palinek/events{/privacy}","received_events_url":"https://api.github.com/users/palinek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"paulolieuthier","id":1238157,"avatar_url":"https://avatars.githubusercontent.com/u/1238157?v=3","gravatar_id":"","url":"https://api.github.com/users/paulolieuthier","html_url":"https://github.com/paulolieuthier","followers_url":"https://api.github.com/users/paulolieuthier/followers","following_url":"https://api.github.com/users/paulolieuthier/following{/other_user}","gists_url":"https://api.github.com/users/paulolieuthier/gists{/gist_id}","starred_url":"https://api.github.com/users/paulolieuthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulolieuthier/subscriptions","organizations_url":"https://api.github.com/users/paulolieuthier/orgs","repos_url":"https://api.github.com/users/paulolieuthier/repos","events_url":"https://api.github.com/users/paulolieuthier/events{/privacy}","received_events_url":"https://api.github.com/users/paulolieuthier/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-01-08T00:03:32Z","updated_at":"2016-01-27T13:26:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lxde/liblxqt/pulls/77","html_url":"https://github.com/lxde/liblxqt/pull/77","diff_url":"https://github.com/lxde/liblxqt/pull/77.diff","patch_url":"https://github.com/lxde/liblxqt/pull/77.patch"},"body":"- Same signal settingsChanged() was emitted upon object based change (setValue(), erase()...) and\r\nupon change made by external entity (watching the file changes) => we added other two signals\r\nsettingsChangedFromExternal() & settingsChangedByApp() to make these changes distinguishable. The signal settingsChanged() was left for backwards compatibility.\r\n\r\n- Emitting of settingsChanged*() signals was delayed to be able to distinguish if change made on file was based upon our write/sync or by external application.\r\n\r\nThis is needed by lxde/lxqt-panel#294"},"comment":{"url":"https://api.github.com/repos/lxde/liblxqt/issues/comments/175627247","html_url":"https://github.com/lxde/liblxqt/pull/77#issuecomment-175627247","issue_url":"https://api.github.com/repos/lxde/liblxqt/issues/77","id":175627247,"user":{"login":"paulolieuthier","id":1238157,"avatar_url":"https://avatars.githubusercontent.com/u/1238157?v=3","gravatar_id":"","url":"https://api.github.com/users/paulolieuthier","html_url":"https://github.com/paulolieuthier","followers_url":"https://api.github.com/users/paulolieuthier/followers","following_url":"https://api.github.com/users/paulolieuthier/following{/other_user}","gists_url":"https://api.github.com/users/paulolieuthier/gists{/gist_id}","starred_url":"https://api.github.com/users/paulolieuthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulolieuthier/subscriptions","organizations_url":"https://api.github.com/users/paulolieuthier/orgs","repos_url":"https://api.github.com/users/paulolieuthier/repos","events_url":"https://api.github.com/users/paulolieuthier/events{/privacy}","received_events_url":"https://api.github.com/users/paulolieuthier/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T13:26:41Z","updated_at":"2016-01-27T13:26:41Z","body":"It's been already 20 days, right? We've both tested it, so I think it's safe to merge it. Go ahead."}}