{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7390","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7390/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7390/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7390/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7390","id":176290981,"number":7390,"title":"[MRG+1] make export_graphviz return string if out_file is None","user":{"login":"themrmax","id":8220288,"avatar_url":"https://avatars.githubusercontent.com/u/8220288?v=3","gravatar_id":"","url":"https://api.github.com/users/themrmax","html_url":"https://github.com/themrmax","followers_url":"https://api.github.com/users/themrmax/followers","following_url":"https://api.github.com/users/themrmax/following{/other_user}","gists_url":"https://api.github.com/users/themrmax/gists{/gist_id}","starred_url":"https://api.github.com/users/themrmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themrmax/subscriptions","organizations_url":"https://api.github.com/users/themrmax/orgs","repos_url":"https://api.github.com/users/themrmax/repos","events_url":"https://api.github.com/users/themrmax/events{/privacy}","received_events_url":"https://api.github.com/users/themrmax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-12T04:08:57Z","updated_at":"2016-09-14T14:00:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7390","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7390","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7390.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7390.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\nFixes #6261.\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nClean up the API for `export_graphviz` to make it possible to create visualisations with `pydotplus` without needing to use `StringIO`.  Following the example of `DataFrame.to_csv`, if no file name is provided, now it will just return the output as as a string.\r\n\r\n#### Any other comments?\r\nTested this in Ipython Notebook for both Python 2 and 3.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/247022259","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7390#issuecomment-247022259","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7390","id":247022259,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T14:00:56Z","updated_at":"2016-09-14T14:00:56Z","body":"sorry, I didn't notice the previous default. Changing the default here would be more elegant, but isn't necessary and may be disruptive."}}
{"actor":{"display_login":"jnothman"}}