{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/531","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/531/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/531/events","html_url":"https://github.com/triplea-game/triplea/pull/531","id":141175376,"number":531,"title":"AI - add check on whether allied or enemy attacks when selecting max.","user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-03-16T05:15:40Z","updated_at":"2016-03-17T00:09:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/531","html_url":"https://github.com/triplea-game/triplea/pull/531","diff_url":"https://github.com/triplea-game/triplea/pull/531.diff","patch_url":"https://github.com/triplea-game/triplea/pull/531.patch"},"body":"This was causing issues with enemy attacks being skipped that shouldn't\r\nhave been.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/triplea-game/triplea/531)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/197618113","html_url":"https://github.com/triplea-game/triplea/pull/531#issuecomment-197618113","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/531","id":197618113,"user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T00:09:04Z","updated_at":"2016-03-17T00:09:04Z","body":"@DanVanAtta It is relevant since you are claiming that \"We've included test in most PRs\" which I don't agree with and I can probably go through the last 10-20 PRs and show that.\r\n\r\nThat save game doesn't cover them all. It covers only the case that was broken. The code only didn't work properly for finding the max 'enemy' 'attack' on an 'allied' territory. This method is also used for other combinations such as 'allied' 'attack' on 'enemy' territory. There are a number of cases but the others should remain unchanged with this fix since its only adding a 'check' for skipping only when 'allied'. "}}