{"action":"closed","number":9467,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467","id":63369003,"html_url":"https://github.com/joomla/joomla-cms/pull/9467","diff_url":"https://github.com/joomla/joomla-cms/pull/9467.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9467.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9467","number":9467,"state":"closed","locked":false,"title":"Fix index lengths errors on new installation with PDO driver in strict mode","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #9465 .\r\n\r\n#### Summary of Changes\r\n\r\nIt seems there were some index and column modifications forgotten for the utf8mb4 conversion, which fail on create table then when pdomysql (or mysql in general, any driver) is in strict mode but not failed without strict mode.\r\n\r\n#### Testing Instructions\r\n\r\n**Test 1:** Check if a new installation works without running into the errors described in issue #9465, chosing the PDO driver for mysql on installation and using the branch of this patch as installation source: [https://github.com/richard67/joomla-cms/archive/utf8mb4-forgotten-column-changes-1.zip](https://github.com/richard67/joomla-cms/archive/utf8mb4-forgotten-column-changes-1.zip).\r\n\r\nTo enforce strict mode, hack the pdomysql.php as described in PR #9461 before starting the installation.\r\n\r\n**Test 2:** Test also if the utf8(mb4) conversion still works on the Joomla! just installed with Test 1 before. To enforce the conversion to be performed again, enter following SQL statement in phpMyAdmin:\r\n\r\n> UPDATE `#__utf8_conversion` SET `converted` = 0;\r\n\r\n(replace `#__` by your db prefix).\r\n\r\nThen go to \"Extensions -> Manage -> Update\".\r\n\r\nYou should see the conversion to be done reported as open problem.\r\n\r\nClick the \"Fix\" button.\r\n\r\nResult: The conversion is performed without errors, after this database is up to date without problems.","created_at":"2016-03-18T12:45:37Z","updated_at":"2016-03-18T23:42:27Z","closed_at":"2016-03-18T23:42:27Z","merged_at":"2016-03-18T23:42:27Z","merge_commit_sha":"1cb0ffb0dbdca32ee46e0c71333ef7933f78a3a1","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.5.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7/labels","id":944889,"number":7,"title":"Joomla! 3.5.0","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":671,"state":"open","created_at":"2015-01-21T08:12:44Z","updated_at":"2016-03-18T23:42:27Z","due_on":"2016-03-16T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9467/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/c21a9812896db0cab253cec89540b1ec884c5e5b","head":{"label":"richard67:utf8mb4-forgotten-column-changes-1","ref":"utf8mb4-forgotten-column-changes-1","sha":"c21a9812896db0cab253cec89540b1ec884c5e5b","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"repo":{"id":27455477,"name":"joomla-cms","full_name":"richard67/joomla-cms","owner":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard67/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/richard67/joomla-cms","forks_url":"https://api.github.com/repos/richard67/joomla-cms/forks","keys_url":"https://api.github.com/repos/richard67/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard67/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard67/joomla-cms/teams","hooks_url":"https://api.github.com/repos/richard67/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/richard67/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/richard67/joomla-cms/events","assignees_url":"https://api.github.com/repos/richard67/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/richard67/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/richard67/joomla-cms/tags","blobs_url":"https://api.github.com/repos/richard67/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard67/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard67/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard67/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard67/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/richard67/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/richard67/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/richard67/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/richard67/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/richard67/joomla-cms/subscription","commits_url":"https://api.github.com/repos/richard67/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard67/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard67/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard67/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard67/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/richard67/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard67/joomla-cms/merges","archive_url":"https://api.github.com/repos/richard67/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard67/joomla-cms/downloads","issues_url":"https://api.github.com/repos/richard67/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/richard67/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/richard67/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/richard67/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard67/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/richard67/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/richard67/joomla-cms/deployments","created_at":"2014-12-02T21:54:34Z","updated_at":"2016-01-19T12:17:29Z","pushed_at":"2016-03-18T19:03:53Z","git_url":"git://github.com/richard67/joomla-cms.git","ssh_url":"git@github.com:richard67/joomla-cms.git","clone_url":"https://github.com/richard67/joomla-cms.git","svn_url":"https://github.com/richard67/joomla-cms","homepage":"http://joomla.org","size":141576,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"81ea485e756828cb11c92d61620359a2870e936c","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-03-18T15:31:43Z","pushed_at":"2016-03-18T23:42:27Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":267588,"stargazers_count":1855,"watchers_count":1855,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2090,"mirror_url":null,"open_issues_count":615,"forks":2090,"open_issues":615,"watchers":1855,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/9467"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9467"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9467/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9467/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/c21a9812896db0cab253cec89540b1ec884c5e5b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"comments":18,"review_comments":0,"commits":2,"additions":43,"deletions":20,"changed_files":3}}