{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/spiricom/sunspots/pulls/19","id":90541309,"html_url":"https://github.com/spiricom/sunspots/pull/19","diff_url":"https://github.com/spiricom/sunspots/pull/19.diff","patch_url":"https://github.com/spiricom/sunspots/pull/19.patch","issue_url":"https://api.github.com/repos/spiricom/sunspots/issues/19","number":19,"state":"closed","locked":false,"title":"Resolve gain issues","user":{"login":"JoshuaStorm","id":12414183,"avatar_url":"https://avatars.githubusercontent.com/u/12414183?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaStorm","html_url":"https://github.com/JoshuaStorm","followers_url":"https://api.github.com/users/JoshuaStorm/followers","following_url":"https://api.github.com/users/JoshuaStorm/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaStorm/subscriptions","organizations_url":"https://api.github.com/users/JoshuaStorm/orgs","repos_url":"https://api.github.com/users/JoshuaStorm/repos","events_url":"https://api.github.com/users/JoshuaStorm/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaStorm/received_events","type":"User","site_admin":false},"body":"Resolves #16 \r\n@spiricom \r\nSo I figured it out: Doing `gain.setValueAtTime` does not work on Chrome since it is not directly a part of the WebAudioApi. However, oddly enough, directly setting `gain.value = MAX_VOLUME` does not work on the p5 editor. \r\n\r\nOf course, this leads to using `gain.value = ...` to be the proper solution for us, but we should be aware that we won't be able to mix locally.","created_at":"2016-10-24T02:24:39Z","updated_at":"2016-10-24T02:27:55Z","closed_at":"2016-10-24T02:27:55Z","merged_at":"2016-10-24T02:27:54Z","merge_commit_sha":"47a3e0ce89a89d08583277a5463f53285f8ddb8d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spiricom/sunspots/pulls/19/commits","review_comments_url":"https://api.github.com/repos/spiricom/sunspots/pulls/19/comments","review_comment_url":"https://api.github.com/repos/spiricom/sunspots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spiricom/sunspots/issues/19/comments","statuses_url":"https://api.github.com/repos/spiricom/sunspots/statuses/f504c5d71adbf60976c46a02d6d48171ff5ef49a","head":{"label":"spiricom:chromeGainIssue","ref":"chromeGainIssue","sha":"f504c5d71adbf60976c46a02d6d48171ff5ef49a","user":{"login":"spiricom","id":789628,"avatar_url":"https://avatars.githubusercontent.com/u/789628?v=3","gravatar_id":"","url":"https://api.github.com/users/spiricom","html_url":"https://github.com/spiricom","followers_url":"https://api.github.com/users/spiricom/followers","following_url":"https://api.github.com/users/spiricom/following{/other_user}","gists_url":"https://api.github.com/users/spiricom/gists{/gist_id}","starred_url":"https://api.github.com/users/spiricom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiricom/subscriptions","organizations_url":"https://api.github.com/users/spiricom/orgs","repos_url":"https://api.github.com/users/spiricom/repos","events_url":"https://api.github.com/users/spiricom/events{/privacy}","received_events_url":"https://api.github.com/users/spiricom/received_events","type":"User","site_admin":false},"repo":{"id":69049021,"name":"sunspots","full_name":"spiricom/sunspots","owner":{"login":"spiricom","id":789628,"avatar_url":"https://avatars.githubusercontent.com/u/789628?v=3","gravatar_id":"","url":"https://api.github.com/users/spiricom","html_url":"https://github.com/spiricom","followers_url":"https://api.github.com/users/spiricom/followers","following_url":"https://api.github.com/users/spiricom/following{/other_user}","gists_url":"https://api.github.com/users/spiricom/gists{/gist_id}","starred_url":"https://api.github.com/users/spiricom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiricom/subscriptions","organizations_url":"https://api.github.com/users/spiricom/orgs","repos_url":"https://api.github.com/users/spiricom/repos","events_url":"https://api.github.com/users/spiricom/events{/privacy}","received_events_url":"https://api.github.com/users/spiricom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spiricom/sunspots","description":"web art for the sunspots audio/visual project","fork":false,"url":"https://api.github.com/repos/spiricom/sunspots","forks_url":"https://api.github.com/repos/spiricom/sunspots/forks","keys_url":"https://api.github.com/repos/spiricom/sunspots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiricom/sunspots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiricom/sunspots/teams","hooks_url":"https://api.github.com/repos/spiricom/sunspots/hooks","issue_events_url":"https://api.github.com/repos/spiricom/sunspots/issues/events{/number}","events_url":"https://api.github.com/repos/spiricom/sunspots/events","assignees_url":"https://api.github.com/repos/spiricom/sunspots/assignees{/user}","branches_url":"https://api.github.com/repos/spiricom/sunspots/branches{/branch}","tags_url":"https://api.github.com/repos/spiricom/sunspots/tags","blobs_url":"https://api.github.com/repos/spiricom/sunspots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiricom/sunspots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiricom/sunspots/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiricom/sunspots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiricom/sunspots/statuses/{sha}","languages_url":"https://api.github.com/repos/spiricom/sunspots/languages","stargazers_url":"https://api.github.com/repos/spiricom/sunspots/stargazers","contributors_url":"https://api.github.com/repos/spiricom/sunspots/contributors","subscribers_url":"https://api.github.com/repos/spiricom/sunspots/subscribers","subscription_url":"https://api.github.com/repos/spiricom/sunspots/subscription","commits_url":"https://api.github.com/repos/spiricom/sunspots/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiricom/sunspots/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiricom/sunspots/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiricom/sunspots/issues/comments{/number}","contents_url":"https://api.github.com/repos/spiricom/sunspots/contents/{+path}","compare_url":"https://api.github.com/repos/spiricom/sunspots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiricom/sunspots/merges","archive_url":"https://api.github.com/repos/spiricom/sunspots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiricom/sunspots/downloads","issues_url":"https://api.github.com/repos/spiricom/sunspots/issues{/number}","pulls_url":"https://api.github.com/repos/spiricom/sunspots/pulls{/number}","milestones_url":"https://api.github.com/repos/spiricom/sunspots/milestones{/number}","notifications_url":"https://api.github.com/repos/spiricom/sunspots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiricom/sunspots/labels{/name}","releases_url":"https://api.github.com/repos/spiricom/sunspots/releases{/id}","deployments_url":"https://api.github.com/repos/spiricom/sunspots/deployments","created_at":"2016-09-23T18:05:12Z","updated_at":"2016-09-23T19:27:00Z","pushed_at":"2016-10-24T02:27:55Z","git_url":"git://github.com/spiricom/sunspots.git","ssh_url":"git@github.com:spiricom/sunspots.git","clone_url":"https://github.com/spiricom/sunspots.git","svn_url":"https://github.com/spiricom/sunspots","homepage":null,"size":1299371,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"spiricom:master","ref":"master","sha":"fbc8e6afa78efce575a9a5185eb861307a16df7c","user":{"login":"spiricom","id":789628,"avatar_url":"https://avatars.githubusercontent.com/u/789628?v=3","gravatar_id":"","url":"https://api.github.com/users/spiricom","html_url":"https://github.com/spiricom","followers_url":"https://api.github.com/users/spiricom/followers","following_url":"https://api.github.com/users/spiricom/following{/other_user}","gists_url":"https://api.github.com/users/spiricom/gists{/gist_id}","starred_url":"https://api.github.com/users/spiricom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiricom/subscriptions","organizations_url":"https://api.github.com/users/spiricom/orgs","repos_url":"https://api.github.com/users/spiricom/repos","events_url":"https://api.github.com/users/spiricom/events{/privacy}","received_events_url":"https://api.github.com/users/spiricom/received_events","type":"User","site_admin":false},"repo":{"id":69049021,"name":"sunspots","full_name":"spiricom/sunspots","owner":{"login":"spiricom","id":789628,"avatar_url":"https://avatars.githubusercontent.com/u/789628?v=3","gravatar_id":"","url":"https://api.github.com/users/spiricom","html_url":"https://github.com/spiricom","followers_url":"https://api.github.com/users/spiricom/followers","following_url":"https://api.github.com/users/spiricom/following{/other_user}","gists_url":"https://api.github.com/users/spiricom/gists{/gist_id}","starred_url":"https://api.github.com/users/spiricom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiricom/subscriptions","organizations_url":"https://api.github.com/users/spiricom/orgs","repos_url":"https://api.github.com/users/spiricom/repos","events_url":"https://api.github.com/users/spiricom/events{/privacy}","received_events_url":"https://api.github.com/users/spiricom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spiricom/sunspots","description":"web art for the sunspots audio/visual project","fork":false,"url":"https://api.github.com/repos/spiricom/sunspots","forks_url":"https://api.github.com/repos/spiricom/sunspots/forks","keys_url":"https://api.github.com/repos/spiricom/sunspots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiricom/sunspots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiricom/sunspots/teams","hooks_url":"https://api.github.com/repos/spiricom/sunspots/hooks","issue_events_url":"https://api.github.com/repos/spiricom/sunspots/issues/events{/number}","events_url":"https://api.github.com/repos/spiricom/sunspots/events","assignees_url":"https://api.github.com/repos/spiricom/sunspots/assignees{/user}","branches_url":"https://api.github.com/repos/spiricom/sunspots/branches{/branch}","tags_url":"https://api.github.com/repos/spiricom/sunspots/tags","blobs_url":"https://api.github.com/repos/spiricom/sunspots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiricom/sunspots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiricom/sunspots/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiricom/sunspots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiricom/sunspots/statuses/{sha}","languages_url":"https://api.github.com/repos/spiricom/sunspots/languages","stargazers_url":"https://api.github.com/repos/spiricom/sunspots/stargazers","contributors_url":"https://api.github.com/repos/spiricom/sunspots/contributors","subscribers_url":"https://api.github.com/repos/spiricom/sunspots/subscribers","subscription_url":"https://api.github.com/repos/spiricom/sunspots/subscription","commits_url":"https://api.github.com/repos/spiricom/sunspots/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiricom/sunspots/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiricom/sunspots/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiricom/sunspots/issues/comments{/number}","contents_url":"https://api.github.com/repos/spiricom/sunspots/contents/{+path}","compare_url":"https://api.github.com/repos/spiricom/sunspots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiricom/sunspots/merges","archive_url":"https://api.github.com/repos/spiricom/sunspots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiricom/sunspots/downloads","issues_url":"https://api.github.com/repos/spiricom/sunspots/issues{/number}","pulls_url":"https://api.github.com/repos/spiricom/sunspots/pulls{/number}","milestones_url":"https://api.github.com/repos/spiricom/sunspots/milestones{/number}","notifications_url":"https://api.github.com/repos/spiricom/sunspots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiricom/sunspots/labels{/name}","releases_url":"https://api.github.com/repos/spiricom/sunspots/releases{/id}","deployments_url":"https://api.github.com/repos/spiricom/sunspots/deployments","created_at":"2016-09-23T18:05:12Z","updated_at":"2016-09-23T19:27:00Z","pushed_at":"2016-10-24T02:27:55Z","git_url":"git://github.com/spiricom/sunspots.git","ssh_url":"git@github.com:spiricom/sunspots.git","clone_url":"https://github.com/spiricom/sunspots.git","svn_url":"https://github.com/spiricom/sunspots","homepage":null,"size":1299371,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spiricom/sunspots/pulls/19"},"html":{"href":"https://github.com/spiricom/sunspots/pull/19"},"issue":{"href":"https://api.github.com/repos/spiricom/sunspots/issues/19"},"comments":{"href":"https://api.github.com/repos/spiricom/sunspots/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/spiricom/sunspots/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/spiricom/sunspots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spiricom/sunspots/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/spiricom/sunspots/statuses/f504c5d71adbf60976c46a02d6d48171ff5ef49a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JoshuaStorm","id":12414183,"avatar_url":"https://avatars.githubusercontent.com/u/12414183?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaStorm","html_url":"https://github.com/JoshuaStorm","followers_url":"https://api.github.com/users/JoshuaStorm/followers","following_url":"https://api.github.com/users/JoshuaStorm/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaStorm/subscriptions","organizations_url":"https://api.github.com/users/JoshuaStorm/orgs","repos_url":"https://api.github.com/users/JoshuaStorm/repos","events_url":"https://api.github.com/users/JoshuaStorm/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaStorm/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"JoshuaStorm"}}