{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/comments/56927744","id":56927744,"diff_hunk":"@@ -33,20 +33,28 @@ function wp_cldr_menu() {\n }\n \n /**\n+ * Loads the text domain for the plug-in. We call this only when the settings page is loaded since translations aren't needed any earlier.\n+ */\n+function wp_cldr_load_plugin_textdomain() {\n+\tload_plugin_textdomain( 'wp-cldr', false, basename( dirname( __FILE__ ) ) . '/languages/' );\n+}\n+\n+/**\n  * Gets the settings and examples page for the plugin.\n  */\n function wp_cldr_settings() {\n \n+\twp_cldr_load_plugin_textdomain();","path":"wp-cldr.php","position":32,"original_position":32,"commit_id":"2ecdf388815b423ea045963beaec82157fae129e","original_commit_id":"2ecdf388815b423ea045963beaec82157fae129e","user":{"login":"stuwest","id":3966960,"avatar_url":"https://avatars.githubusercontent.com/u/3966960?v=3","gravatar_id":"","url":"https://api.github.com/users/stuwest","html_url":"https://github.com/stuwest","followers_url":"https://api.github.com/users/stuwest/followers","following_url":"https://api.github.com/users/stuwest/following{/other_user}","gists_url":"https://api.github.com/users/stuwest/gists{/gist_id}","starred_url":"https://api.github.com/users/stuwest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuwest/subscriptions","organizations_url":"https://api.github.com/users/stuwest/orgs","repos_url":"https://api.github.com/users/stuwest/repos","events_url":"https://api.github.com/users/stuwest/events{/privacy}","received_events_url":"https://api.github.com/users/stuwest/received_events","type":"User","site_admin":false},"body":"No I don't think we'll use it elsewhere. Was just instinctively trying to break things up. Will change.","created_at":"2016-03-22T02:06:21Z","updated_at":"2016-03-22T02:06:21Z","html_url":"https://github.com/Automattic/wp-cldr/pull/87#discussion_r56927744","pull_request_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/comments/56927744"},"html":{"href":"https://github.com/Automattic/wp-cldr/pull/87#discussion_r56927744"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87","id":63641750,"html_url":"https://github.com/Automattic/wp-cldr/pull/87","diff_url":"https://github.com/Automattic/wp-cldr/pull/87.diff","patch_url":"https://github.com/Automattic/wp-cldr/pull/87.patch","issue_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/87","number":87,"state":"open","locked":false,"title":"1.0 version cleanup","user":{"login":"stuwest","id":3966960,"avatar_url":"https://avatars.githubusercontent.com/u/3966960?v=3","gravatar_id":"","url":"https://api.github.com/users/stuwest","html_url":"https://github.com/stuwest","followers_url":"https://api.github.com/users/stuwest/followers","following_url":"https://api.github.com/users/stuwest/following{/other_user}","gists_url":"https://api.github.com/users/stuwest/gists{/gist_id}","starred_url":"https://api.github.com/users/stuwest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuwest/subscriptions","organizations_url":"https://api.github.com/users/stuwest/orgs","repos_url":"https://api.github.com/users/stuwest/repos","events_url":"https://api.github.com/users/stuwest/events{/privacy}","received_events_url":"https://api.github.com/users/stuwest/received_events","type":"User","site_admin":false},"body":"This PR has a smattering of 1.0 version cleanup in documentation plus adding `load_plugin_textdomain()`.","created_at":"2016-03-21T22:18:48Z","updated_at":"2016-03-22T02:06:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf227094b5ed8f82f9ba475f757d9e994b65cfb5","assignee":{"login":"stuwest","id":3966960,"avatar_url":"https://avatars.githubusercontent.com/u/3966960?v=3","gravatar_id":"","url":"https://api.github.com/users/stuwest","html_url":"https://github.com/stuwest","followers_url":"https://api.github.com/users/stuwest/followers","following_url":"https://api.github.com/users/stuwest/following{/other_user}","gists_url":"https://api.github.com/users/stuwest/gists{/gist_id}","starred_url":"https://api.github.com/users/stuwest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuwest/subscriptions","organizations_url":"https://api.github.com/users/stuwest/orgs","repos_url":"https://api.github.com/users/stuwest/repos","events_url":"https://api.github.com/users/stuwest/events{/privacy}","received_events_url":"https://api.github.com/users/stuwest/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/87/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-cldr/statuses/2ecdf388815b423ea045963beaec82157fae129e","head":{"label":"Automattic:fix/release-cleanup","ref":"fix/release-cleanup","sha":"2ecdf388815b423ea045963beaec82157fae129e","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":22383975,"name":"wp-cldr","full_name":"Automattic/wp-cldr","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-cldr","description":"Use CLDR localization data in WordPress","fork":false,"url":"https://api.github.com/repos/Automattic/wp-cldr","forks_url":"https://api.github.com/repos/Automattic/wp-cldr/forks","keys_url":"https://api.github.com/repos/Automattic/wp-cldr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-cldr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-cldr/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-cldr/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-cldr/events","assignees_url":"https://api.github.com/repos/Automattic/wp-cldr/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-cldr/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-cldr/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-cldr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-cldr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-cldr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-cldr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-cldr/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-cldr/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-cldr/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-cldr/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-cldr/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-cldr/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-cldr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-cldr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-cldr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-cldr/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-cldr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-cldr/merges","archive_url":"https://api.github.com/repos/Automattic/wp-cldr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-cldr/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-cldr/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-cldr/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-cldr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-cldr/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-cldr/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-cldr/deployments","created_at":"2014-07-29T15:04:00Z","updated_at":"2016-03-21T22:27:05Z","pushed_at":"2016-03-22T01:24:35Z","git_url":"git://github.com/Automattic/wp-cldr.git","ssh_url":"git@github.com:Automattic/wp-cldr.git","clone_url":"https://github.com/Automattic/wp-cldr.git","svn_url":"https://github.com/Automattic/wp-cldr","homepage":"","size":9371,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":10,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"d454e6047299d83e226661b554cd8dbf314c7d58","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":22383975,"name":"wp-cldr","full_name":"Automattic/wp-cldr","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-cldr","description":"Use CLDR localization data in WordPress","fork":false,"url":"https://api.github.com/repos/Automattic/wp-cldr","forks_url":"https://api.github.com/repos/Automattic/wp-cldr/forks","keys_url":"https://api.github.com/repos/Automattic/wp-cldr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-cldr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-cldr/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-cldr/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-cldr/events","assignees_url":"https://api.github.com/repos/Automattic/wp-cldr/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-cldr/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-cldr/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-cldr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-cldr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-cldr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-cldr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-cldr/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-cldr/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-cldr/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-cldr/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-cldr/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-cldr/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-cldr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-cldr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-cldr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-cldr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-cldr/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-cldr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-cldr/merges","archive_url":"https://api.github.com/repos/Automattic/wp-cldr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-cldr/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-cldr/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-cldr/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-cldr/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-cldr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-cldr/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-cldr/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-cldr/deployments","created_at":"2014-07-29T15:04:00Z","updated_at":"2016-03-21T22:27:05Z","pushed_at":"2016-03-22T01:24:35Z","git_url":"git://github.com/Automattic/wp-cldr.git","ssh_url":"git@github.com:Automattic/wp-cldr.git","clone_url":"https://github.com/Automattic/wp-cldr.git","svn_url":"https://github.com/Automattic/wp-cldr","homepage":"","size":9371,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87"},"html":{"href":"https://github.com/Automattic/wp-cldr/pull/87"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-cldr/issues/87"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-cldr/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-cldr/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-cldr/statuses/2ecdf388815b423ea045963beaec82157fae129e"}}}}