{"action":"created","issue":{"url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/20","repository_url":"https://api.github.com/repos/Evizero/LearnBase.jl","labels_url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/20/comments","events_url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/20/events","html_url":"https://github.com/Evizero/LearnBase.jl/pull/20","id":154001872,"number":20,"title":"Dependency changes","user":{"login":"tbreloff","id":933338,"avatar_url":"https://avatars.githubusercontent.com/u/933338?v=3","gravatar_id":"","url":"https://api.github.com/users/tbreloff","html_url":"https://github.com/tbreloff","followers_url":"https://api.github.com/users/tbreloff/followers","following_url":"https://api.github.com/users/tbreloff/following{/other_user}","gists_url":"https://api.github.com/users/tbreloff/gists{/gist_id}","starred_url":"https://api.github.com/users/tbreloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbreloff/subscriptions","organizations_url":"https://api.github.com/users/tbreloff/orgs","repos_url":"https://api.github.com/users/tbreloff/repos","events_url":"https://api.github.com/users/tbreloff/events{/privacy}","received_events_url":"https://api.github.com/users/tbreloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-10T13:08:06Z","updated_at":"2016-05-10T13:23:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Evizero/LearnBase.jl/pulls/20","html_url":"https://github.com/Evizero/LearnBase.jl/pull/20","diff_url":"https://github.com/Evizero/LearnBase.jl/pull/20.diff","patch_url":"https://github.com/Evizero/LearnBase.jl/pull/20.patch"},"body":"In a nutshell... I found one instance of `view` and replaced it with `sub` to remove the dependency on ArrayViews.  I commented out the UnicodePlots sections (which seem to match functionality of the recipes... correct me if I'm wrong there), and copied the recipes from MLPlots.  This let me remove the dependency on Requires as well.\r\n\r\nThere are some tests which plot directly into UnicodePlots... I left those.  Eventually maybe change to show them through Plots with the unicodeplots backend?\r\n\r\n@Evizero  I think this is ok to merge, but please take a look.\r\n\r\nQuestion: Is it reasonable to try to remove the dependency on MLBase?  I don't remember which parts depend on that, and I seem to remember that it wasn't very actively supported."},"comment":{"url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/comments/218155577","html_url":"https://github.com/Evizero/LearnBase.jl/pull/20#issuecomment-218155577","issue_url":"https://api.github.com/repos/Evizero/LearnBase.jl/issues/20","id":218155577,"user":{"login":"tbreloff","id":933338,"avatar_url":"https://avatars.githubusercontent.com/u/933338?v=3","gravatar_id":"","url":"https://api.github.com/users/tbreloff","html_url":"https://github.com/tbreloff","followers_url":"https://api.github.com/users/tbreloff/followers","following_url":"https://api.github.com/users/tbreloff/following{/other_user}","gists_url":"https://api.github.com/users/tbreloff/gists{/gist_id}","starred_url":"https://api.github.com/users/tbreloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbreloff/subscriptions","organizations_url":"https://api.github.com/users/tbreloff/orgs","repos_url":"https://api.github.com/users/tbreloff/repos","events_url":"https://api.github.com/users/tbreloff/events{/privacy}","received_events_url":"https://api.github.com/users/tbreloff/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T13:23:52Z","updated_at":"2016-05-10T13:23:52Z","body":"Or... did you only want to keep the `show` methods?"}}