{"action":"created","issue":{"url":"https://api.github.com/repos/interledger/five-bells-connector/issues/195","repository_url":"https://api.github.com/repos/interledger/five-bells-connector","labels_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/195/comments","events_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/195/events","html_url":"https://github.com/interledger/five-bells-connector/pull/195","id":166693150,"number":195,"title":"feat: pass through ILP packet","user":{"login":"emschwartz","id":3262610,"avatar_url":"https://avatars.githubusercontent.com/u/3262610?v=3","gravatar_id":"","url":"https://api.github.com/users/emschwartz","html_url":"https://github.com/emschwartz","followers_url":"https://api.github.com/users/emschwartz/followers","following_url":"https://api.github.com/users/emschwartz/following{/other_user}","gists_url":"https://api.github.com/users/emschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/emschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emschwartz/subscriptions","organizations_url":"https://api.github.com/users/emschwartz/orgs","repos_url":"https://api.github.com/users/emschwartz/repos","events_url":"https://api.github.com/users/emschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/emschwartz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"justmoon","id":53233,"avatar_url":"https://avatars.githubusercontent.com/u/53233?v=3","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"justmoon","id":53233,"avatar_url":"https://avatars.githubusercontent.com/u/53233?v=3","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},{"login":"sentientwaffle","id":461112,"avatar_url":"https://avatars.githubusercontent.com/u/461112?v=3","gravatar_id":"","url":"https://api.github.com/users/sentientwaffle","html_url":"https://github.com/sentientwaffle","followers_url":"https://api.github.com/users/sentientwaffle/followers","following_url":"https://api.github.com/users/sentientwaffle/following{/other_user}","gists_url":"https://api.github.com/users/sentientwaffle/gists{/gist_id}","starred_url":"https://api.github.com/users/sentientwaffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sentientwaffle/subscriptions","organizations_url":"https://api.github.com/users/sentientwaffle/orgs","repos_url":"https://api.github.com/users/sentientwaffle/repos","events_url":"https://api.github.com/users/sentientwaffle/events{/privacy}","received_events_url":"https://api.github.com/users/sentientwaffle/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-20T22:03:53Z","updated_at":"2016-07-21T09:39:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/195","html_url":"https://github.com/interledger/five-bells-connector/pull/195","diff_url":"https://github.com/interledger/five-bells-connector/pull/195.diff","patch_url":"https://github.com/interledger/five-bells-connector/pull/195.patch"},"body":"the connector was stripping the ilp header before sending the last\r\ntransfer. the full ilp packet is useful for the recipient to check the\r\ndetails of the incoming transfer against what was supposed to happen\r\n(i.e. what was in the packet).\r\n\r\nthis changes the behavior to pass\r\nthrough the whole ILP packet. this is also useful for when we switch to\r\nbinary, as it is arguably simpler for the connector to just forward on\r\nthe packet rather than stripping particular fields before sending it to\r\nthe receiver. if we do want to strip fields before handing the packet\r\noff to the actual end user, the client libraries can do that.\r\n\r\nrequires https://github.com/interledger/five-bells-receiver/pull/4 for integration tests to pass."},"comment":{"url":"https://api.github.com/repos/interledger/five-bells-connector/issues/comments/234205741","html_url":"https://github.com/interledger/five-bells-connector/pull/195#issuecomment-234205741","issue_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/195","id":234205741,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T09:39:42Z","updated_at":"2016-07-21T09:39:42Z","body":"## [Current coverage][cc-pull] is **91.54%**\n> Merging [#195][cc-pull] into [master][cc-base-branch] will decrease coverage by **<.01%**\n\n```diff\n@@             master       #195   diff @@\n==========================================\n  Files            48         48          \n  Lines           995        994     -1   \n  Methods         127        127          \n  Messages          0          0          \n  Branches        154        153     -1   \n==========================================\n- Hits            911        910     -1   \n  Misses           84         84          \n  Partials          0          0          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ac4379f...c490304][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/interledger/five-bells-connector/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/interledger/five-bells-connector/compare/ac4379f5b6c269d6c1f6610aedc7143b166597d3...c490304dc85f726bb61350faa7d137f7338d8e38?src=pr\n[cc-pull]: https://codecov.io/gh/interledger/five-bells-connector/pull/195?src=pr"}}
{"actor":{"display_login":"codecov-io"}}