{"action":"created","issue":{"url":"https://api.github.com/repos/cozy/cozy-emails/issues/793","repository_url":"https://api.github.com/repos/cozy/cozy-emails","labels_url":"https://api.github.com/repos/cozy/cozy-emails/issues/793/labels{/name}","comments_url":"https://api.github.com/repos/cozy/cozy-emails/issues/793/comments","events_url":"https://api.github.com/repos/cozy/cozy-emails/issues/793/events","html_url":"https://github.com/cozy/cozy-emails/pull/793","id":140632276,"number":793,"title":"Make routing easier","user":{"login":"misstick","id":1177627,"avatar_url":"https://avatars.githubusercontent.com/u/1177627?v=3","gravatar_id":"","url":"https://api.github.com/users/misstick","html_url":"https://github.com/misstick","followers_url":"https://api.github.com/users/misstick/followers","following_url":"https://api.github.com/users/misstick/following{/other_user}","gists_url":"https://api.github.com/users/misstick/gists{/gist_id}","starred_url":"https://api.github.com/users/misstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misstick/subscriptions","organizations_url":"https://api.github.com/users/misstick/orgs","repos_url":"https://api.github.com/users/misstick/repos","events_url":"https://api.github.com/users/misstick/events{/privacy}","received_events_url":"https://api.github.com/users/misstick/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cozy/cozy-emails/labels/4%20-%20To%20merge","name":"4 - To merge","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-03-14T10:23:05Z","updated_at":"2016-04-05T11:40:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-emails/pulls/793","html_url":"https://github.com/cozy/cozy-emails/pull/793","diff_url":"https://github.com/cozy/cozy-emails/pull/793.diff","patch_url":"https://github.com/cozy/cozy-emails/pull/793.patch"},"body":"### Enhancement\r\n\r\n#### Remove `panels` layout\r\n - [x] Remove `panel_router`(useless abstraction),\r\n - [x] remove `firstPanel` and `secondPanel` ,\r\n - [x] remove `router_panel.coffee`\r\n - [x] remove `component/panel.coffee`\r\n - [x] clean Views : add getters for 1rst level views (application, Panel)\r\n - [x] less `views` are listening to `Stores` changes\r\n\r\n#### Easier `routes`\r\n - [x] make `Routes` easier,\r\n - [x] move `filters`handling into `getter/router`,\r\n - [x] redirection : do not redirect into `views`but with `routerActionCreator.navigate`,\r\n - [x] use real DOM links to change Route directly,\r\n - [x] clean `buildURL` parameters + change its calls,\r\n - [x] no `window.location.href` into `views`.\r\n\r\n#### Clean `actionCreators`\r\n - [x] remove `callback` into `actionsCreator`,\r\n - [x] `actionsCreator` can't call other `actionsCreator`,\r\n - [x] remove callback to be executed after dispatch (anti-pattern)\r\n\r\n#### More smaller `stores`\r\n - [x] move notifications from `layout_store` to `notification_store`\r\n - [x] create `selection` store\r\n\r\n### Features concerned\r\nCheck new `routes` for :\r\n - [x] new Account,\r\n - [x] edit account,\r\n - [x] Message List,\r\n - [x] Message display,\r\n - [x] Message edit,\r\n - [x] Message reply,\r\n - [x] Message reply all,\r\n - [x] Message forward,\r\n\r\n### Synthese\r\n- [x] Make schemas to explain : before, after and what next?\r\n- [x] Write guidelines to use `Router`, and `redirection` int the App\r\n\r\n### Fix features\r\n - [x] Selection or mailbox `item` into left Menu,\r\n - [x] `Menu` can't be minimized,\r\n - [x] remove `fullscreen` button/mode,\r\n - [ ] keyboard navigation\r\n - [x] each message of a conversation has got its own URL"},"comment":{"url":"https://api.github.com/repos/cozy/cozy-emails/issues/comments/205766100","html_url":"https://github.com/cozy/cozy-emails/pull/793#issuecomment-205766100","issue_url":"https://api.github.com/repos/cozy/cozy-emails/issues/793","id":205766100,"user":{"login":"aenario","id":1580287,"avatar_url":"https://avatars.githubusercontent.com/u/1580287?v=3","gravatar_id":"","url":"https://api.github.com/users/aenario","html_url":"https://github.com/aenario","followers_url":"https://api.github.com/users/aenario/followers","following_url":"https://api.github.com/users/aenario/following{/other_user}","gists_url":"https://api.github.com/users/aenario/gists{/gist_id}","starred_url":"https://api.github.com/users/aenario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aenario/subscriptions","organizations_url":"https://api.github.com/users/aenario/orgs","repos_url":"https://api.github.com/users/aenario/repos","events_url":"https://api.github.com/users/aenario/events{/privacy}","received_events_url":"https://api.github.com/users/aenario/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T11:40:53Z","updated_at":"2016-04-05T11:40:53Z","body":"#MAYBELATER\r\n\r\nrouter_action_creator.coffee#L46\r\nFrench comment makes @clochix happy but we try to be welcoming to people who dont have the chance to speak french :-p (will be gone with #FIXME anyway)"}}