{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/83814468","pull_request_review_id":4631601,"id":83814468,"diff_hunk":"@@ -856,22 +856,45 @@ private function relativize($xpath)\n     {\n         $expressions = array();\n \n-        $unionPattern = '/\\|(?![^\\[]*\\])/';\n         // An expression which will never match to replace expressions which cannot match in the crawler\n         // We cannot simply drop\n         $nonMatchingExpression = 'a[name() = \"b\"]';\n \n-        // Split any unions into individual expressions.\n-        foreach (preg_split($unionPattern, $xpath) as $expression) {\n-            $expression = trim($expression);\n-            $parenthesis = '';\n+        $xpathLen = strlen($xpath);\n+        $openedBrackets = 0;\n+        $lastUnion = strspn($xpath, \" \\t\\n\\r\\0\\x0B\");","path":"src/Symfony/Component/DomCrawler/Crawler.php","position":15,"original_position":15,"commit_id":"6af53a6714700502c54aa7f471f26c256241b3ff","original_commit_id":"6af53a6714700502c54aa7f471f26c256241b3ff","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"whitespaces, chars list comes from `trim()`","created_at":"2016-10-18T09:27:09Z","updated_at":"2016-10-18T09:27:09Z","html_url":"https://github.com/symfony/symfony/pull/20235#discussion_r83814468","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20235","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/83814468"},"html":{"href":"https://github.com/symfony/symfony/pull/20235#discussion_r83814468"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20235"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20235","id":89767729,"html_url":"https://github.com/symfony/symfony/pull/20235","diff_url":"https://github.com/symfony/symfony/pull/20235.diff","patch_url":"https://github.com/symfony/symfony/pull/20235.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20235","number":20235,"state":"open","locked":false,"title":"[DomCrawler] Allow pipe (|) character in link tags when using Xpath expressions","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #20229\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\n@klausi could you please validate this patch? Is it an improvement over yours? (sorry I don't have the proper use case to test.)","created_at":"2016-10-18T08:25:51Z","updated_at":"2016-10-18T09:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c45608a72560c52a899d5178f6f979424fbda1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20235/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20235/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20235/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/6af53a6714700502c54aa7f471f26c256241b3ff","head":{"label":"nicolas-grekas:domcrawler-pipe","ref":"domcrawler-pipe","sha":"6af53a6714700502c54aa7f471f26c256241b3ff","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"repo":{"id":15110606,"name":"symfony","full_name":"nicolas-grekas/symfony","owner":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolas-grekas/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony","forks_url":"https://api.github.com/repos/nicolas-grekas/symfony/forks","keys_url":"https://api.github.com/repos/nicolas-grekas/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolas-grekas/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolas-grekas/symfony/teams","hooks_url":"https://api.github.com/repos/nicolas-grekas/symfony/hooks","issue_events_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/nicolas-grekas/symfony/events","assignees_url":"https://api.github.com/repos/nicolas-grekas/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/nicolas-grekas/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/nicolas-grekas/symfony/tags","blobs_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolas-grekas/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolas-grekas/symfony/languages","stargazers_url":"https://api.github.com/repos/nicolas-grekas/symfony/stargazers","contributors_url":"https://api.github.com/repos/nicolas-grekas/symfony/contributors","subscribers_url":"https://api.github.com/repos/nicolas-grekas/symfony/subscribers","subscription_url":"https://api.github.com/repos/nicolas-grekas/symfony/subscription","commits_url":"https://api.github.com/repos/nicolas-grekas/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolas-grekas/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolas-grekas/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/nicolas-grekas/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolas-grekas/symfony/merges","archive_url":"https://api.github.com/repos/nicolas-grekas/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolas-grekas/symfony/downloads","issues_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/nicolas-grekas/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolas-grekas/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolas-grekas/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolas-grekas/symfony/labels{/name}","releases_url":"https://api.github.com/repos/nicolas-grekas/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/nicolas-grekas/symfony/deployments","created_at":"2013-12-11T15:13:36Z","updated_at":"2015-04-11T08:00:47Z","pushed_at":"2016-10-18T09:25:41Z","git_url":"git://github.com/nicolas-grekas/symfony.git","ssh_url":"git@github.com:nicolas-grekas/symfony.git","clone_url":"https://github.com/nicolas-grekas/symfony.git","svn_url":"https://github.com/nicolas-grekas/symfony","homepage":"symfony.com","size":73687,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"ef48f5924ad8a931c1ad025f5bccab466a796755","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-10-18T08:49:11Z","pushed_at":"2016-10-18T09:25:43Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":138143,"stargazers_count":13129,"watchers_count":13129,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5081,"mirror_url":null,"open_issues_count":739,"forks":5081,"open_issues":739,"watchers":13129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20235"},"html":{"href":"https://github.com/symfony/symfony/pull/20235"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20235"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20235/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20235/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20235/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/6af53a6714700502c54aa7f471f26c256241b3ff"}}}}
{"actor":{"display_login":"nicolas-grekas"}}