{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/genproductions/issues/1010","repository_url":"https://api.github.com/repos/cms-sw/genproductions","labels_url":"https://api.github.com/repos/cms-sw/genproductions/issues/1010/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/genproductions/issues/1010/comments","events_url":"https://api.github.com/repos/cms-sw/genproductions/issues/1010/events","html_url":"https://github.com/cms-sw/genproductions/pull/1010","id":188862533,"number":1010,"title":"Patch for 'change rwgt_dir' in 2.4.2","user":{"login":"kdlong","id":6694640,"avatar_url":"https://avatars.githubusercontent.com/u/6694640?v=3","gravatar_id":"","url":"https://api.github.com/users/kdlong","html_url":"https://github.com/kdlong","followers_url":"https://api.github.com/users/kdlong/followers","following_url":"https://api.github.com/users/kdlong/following{/other_user}","gists_url":"https://api.github.com/users/kdlong/gists{/gist_id}","starred_url":"https://api.github.com/users/kdlong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdlong/subscriptions","organizations_url":"https://api.github.com/users/kdlong/orgs","repos_url":"https://api.github.com/users/kdlong/repos","events_url":"https://api.github.com/users/kdlong/events{/privacy}","received_events_url":"https://api.github.com/users/kdlong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-11T22:12:38Z","updated_at":"2016-12-13T22:47:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/genproductions/pulls/1010","html_url":"https://github.com/cms-sw/genproductions/pull/1010","diff_url":"https://github.com/cms-sw/genproductions/pull/1010.diff","patch_url":"https://github.com/cms-sw/genproductions/pull/1010.patch"},"body":"Adding patch from Olivier Mattalear to fix bug affecting 'change rwgt_dir' in 2.4.2, which is critical for using precompiled MadSpin. Also moving MadSpin to run after reweight.\r\n\r\n@bendavid I wasn't sure how you managed to format the patch files in the way you did. Let me know if it should be done differently.\r\n\r\nCorrespondence with Olivier:\r\n\r\nI actually\r\nfixed many bug in 2.5.0 related to “change rwgt_dir rwgt”\r\nbut I guess mainly for the NLO re-weighting and not that many for the LO\r\nre-weighting.\r\n\r\nHere is the full difference in those file (in case they can be usefull)\r\n    http://bazaar.launchpad.net/~madteam/mg5amcnlo/series2.0/revision/267#madgraph/interface/reweight_interface.py\r\nhttp://bazaar.launchpad.net/~madteam/mg5amcnlo/series2.0/revision/268#madgraph/interface/reweight_interface.py\r\n\r\nJust for information here is a small timeline of the re-weighting package:\r\n2.0.0 (2013) first implementation (only same model/same process) based on MadSpin idea (fortran executable called on the flight)\r\n2.3.2 (2015) new implementation via fortran library linked to python (f2py). possibility to change model/process definition.\r\n                    possibility to perform a LO accurate re-weighting on NLO sample.\r\n2.4.0 (2016) proper NLO re-weighting of NLO sample.\r\n2.5.0 (2016) Possibility to run the re-weighting on multiple core\r\n2.x.y (2017) change of structure.\r\n                    - having only two (four at NLO) fortran library to be linked to python (faster compilation/better memory footprint)\r\n                    - the fortran code would be modified such that the python code will extract information from the fortran library directly.\r\n                      This allows more flexibility for modifying the re-weighitng code by hand."},"comment":{"url":"https://api.github.com/repos/cms-sw/genproductions/issues/comments/266886885","html_url":"https://github.com/cms-sw/genproductions/pull/1010#issuecomment-266886885","issue_url":"https://api.github.com/repos/cms-sw/genproductions/issues/1010","id":266886885,"user":{"login":"vciulli","id":4605646,"avatar_url":"https://avatars.githubusercontent.com/u/4605646?v=3","gravatar_id":"","url":"https://api.github.com/users/vciulli","html_url":"https://github.com/vciulli","followers_url":"https://api.github.com/users/vciulli/followers","following_url":"https://api.github.com/users/vciulli/following{/other_user}","gists_url":"https://api.github.com/users/vciulli/gists{/gist_id}","starred_url":"https://api.github.com/users/vciulli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vciulli/subscriptions","organizations_url":"https://api.github.com/users/vciulli/orgs","repos_url":"https://api.github.com/users/vciulli/repos","events_url":"https://api.github.com/users/vciulli/events{/privacy}","received_events_url":"https://api.github.com/users/vciulli/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T22:47:43Z","updated_at":"2016-12-13T22:47:43Z","body":"adding @qili \r\nI had a quick look and if @kdlong tested it I am ok to merge it\r\n@bendavid: do you want to have a closer look ?\r\n"}}
{"actor":{"display_login":"vciulli"}}