{"action":"created","issue":{"url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/35","repository_url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module","labels_url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/35/comments","events_url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/35/events","html_url":"https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/pull/35","id":196279147,"number":35,"title":"Multi telemetry","user":{"login":"schwabe","id":1038539,"avatar_url":"https://avatars.githubusercontent.com/u/1038539?v=3","gravatar_id":"","url":"https://api.github.com/users/schwabe","html_url":"https://github.com/schwabe","followers_url":"https://api.github.com/users/schwabe/followers","following_url":"https://api.github.com/users/schwabe/following{/other_user}","gists_url":"https://api.github.com/users/schwabe/gists{/gist_id}","starred_url":"https://api.github.com/users/schwabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwabe/subscriptions","organizations_url":"https://api.github.com/users/schwabe/orgs","repos_url":"https://api.github.com/users/schwabe/repos","events_url":"https://api.github.com/users/schwabe/events{/privacy}","received_events_url":"https://api.github.com/users/schwabe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-18T14:40:39Z","updated_at":"2016-12-18T21:27:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/pulls/35","html_url":"https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/pull/35","diff_url":"https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/pull/35.diff","patch_url":"https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/pull/35.patch"},"body":"New telemetry protocl for OpenTX (and possible ersky9x)\r\n- Telemetry protocol selected by module instead of TX\r\n- Status and version of the multiprotocol module sent to TX"},"comment":{"url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/comments/267848011","html_url":"https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/pull/35#issuecomment-267848011","issue_url":"https://api.github.com/repos/pascallanger/DIY-Multiprotocol-TX-Module/issues/35","id":267848011,"user":{"login":"pascallanger","id":6367598,"avatar_url":"https://avatars.githubusercontent.com/u/6367598?v=3","gravatar_id":"","url":"https://api.github.com/users/pascallanger","html_url":"https://github.com/pascallanger","followers_url":"https://api.github.com/users/pascallanger/followers","following_url":"https://api.github.com/users/pascallanger/following{/other_user}","gists_url":"https://api.github.com/users/pascallanger/gists{/gist_id}","starred_url":"https://api.github.com/users/pascallanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascallanger/subscriptions","organizations_url":"https://api.github.com/users/pascallanger/orgs","repos_url":"https://api.github.com/users/pascallanger/repos","events_url":"https://api.github.com/users/pascallanger/events{/privacy}","received_events_url":"https://api.github.com/users/pascallanger/received_events","type":"User","site_admin":false},"created_at":"2016-12-18T21:27:14Z","updated_at":"2016-12-18T21:27:14Z","body":"Hi,\r\nI still have a couple of comments before merging:\r\n - Can we put the version number in Multiprotocol.h in the form of #define instead of hardcoded it in telemetry.ino?\r\n - About this code:\r\n```\r\nif (millis()-last_signal<70)\r\n        flags |= 0x01;\r\n```\r\nI do have a flag available and a test already builtin, can you use it instead?\r\n```\r\nif(IS_INPUT_SIGNAL_on)\r\n        flags |= 0x01;\r\n```\r\n - I would change the comment in _Config.h to indicate this is only supported by OpenTX version xxx and above. What do you think?\r\n - I'm thinking we should add this test in validate.h:\r\n```\r\n#ifndef TELEMETRY\r\n...\r\n#undef MULTI_TELEMETRY\r\n#else\r\n```\r\n- In PPM mode the speed is based on the protocol in Multiplrotocol.ino I'm thinking we want to force 8E2 100K in PPM_Telemetry_serial_init()\r\n\r\nSince I can't test it, I prefer that you do the changes on your side and see if everything is still ok.\r\n\r\nThanks, Pascal"}}
{"actor":{"display_login":"pascallanger"}}