{"action":"created","comment":{"url":"https://api.github.com/repos/helena-project/tock/pulls/comments/83544847","pull_request_review_id":4383566,"id":83544847,"diff_hunk":"@@ -0,0 +1,14 @@\n+#include <firestorm.h>\n+#include <tock.h>\n+\n+#define DRIVER_NUM_ADC 7","path":"userland/libtock/adc.c","position":4,"original_position":4,"commit_id":"c74a2cae6bb7765ae696d5e7f09354f61da73b49","original_commit_id":"c74a2cae6bb7765ae696d5e7f09354f61da73b49","user":{"login":"alevy","id":4689,"avatar_url":"https://avatars.githubusercontent.com/u/4689?v=3","gravatar_id":"","url":"https://api.github.com/users/alevy","html_url":"https://github.com/alevy","followers_url":"https://api.github.com/users/alevy/followers","following_url":"https://api.github.com/users/alevy/following{/other_user}","gists_url":"https://api.github.com/users/alevy/gists{/gist_id}","starred_url":"https://api.github.com/users/alevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alevy/subscriptions","organizations_url":"https://api.github.com/users/alevy/orgs","repos_url":"https://api.github.com/users/alevy/repos","events_url":"https://api.github.com/users/alevy/events{/privacy}","received_events_url":"https://api.github.com/users/alevy/received_events","type":"User","site_admin":false},"body":"`#include \"adc.h\"` instead","created_at":"2016-10-16T03:46:10Z","updated_at":"2016-10-16T03:46:10Z","html_url":"https://github.com/helena-project/tock/pull/141#discussion_r83544847","pull_request_url":"https://api.github.com/repos/helena-project/tock/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments/83544847"},"html":{"href":"https://github.com/helena-project/tock/pull/141#discussion_r83544847"},"pull_request":{"href":"https://api.github.com/repos/helena-project/tock/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/helena-project/tock/pulls/141","id":89120113,"html_url":"https://github.com/helena-project/tock/pull/141","diff_url":"https://github.com/helena-project/tock/pull/141.diff","patch_url":"https://github.com/helena-project/tock/pull/141.patch","issue_url":"https://api.github.com/repos/helena-project/tock/issues/141","number":141,"state":"open","locked":false,"title":"Update SAM4L ADC and add ADC capsule","user":{"login":"bradjc","id":1467890,"avatar_url":"https://avatars.githubusercontent.com/u/1467890?v=3","gravatar_id":"","url":"https://api.github.com/users/bradjc","html_url":"https://github.com/bradjc","followers_url":"https://api.github.com/users/bradjc/followers","following_url":"https://api.github.com/users/bradjc/following{/other_user}","gists_url":"https://api.github.com/users/bradjc/gists{/gist_id}","starred_url":"https://api.github.com/users/bradjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradjc/subscriptions","organizations_url":"https://api.github.com/users/bradjc/orgs","repos_url":"https://api.github.com/users/bradjc/repos","events_url":"https://api.github.com/users/bradjc/events{/privacy}","received_events_url":"https://api.github.com/users/bradjc/received_events","type":"User","site_admin":false},"body":"All credit for this goes to @nealjack, I just cleaned up the branch for making a pull request.\r\n\r\nMarked blocked to allow for more testing.\r\n\r\nAlso, the register list uses `#[cfg_attr(rustfmt, rustfmt_skip)]`. Doesn't that defeat the point? Or do we want to align all structs like that? Can we get `rustfmt` to do that?\r\n\r\nAlso, @nealjack feel free to take ownership of these commits. Git was doing the right thing all the way until I split it into two commits.","created_at":"2016-10-13T00:51:58Z","updated_at":"2016-10-16T03:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bc63d7f80aab24c1bd02716992d6a9c357b515b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/helena-project/tock/pulls/141/commits","review_comments_url":"https://api.github.com/repos/helena-project/tock/pulls/141/comments","review_comment_url":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helena-project/tock/issues/141/comments","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/c74a2cae6bb7765ae696d5e7f09354f61da73b49","head":{"label":"helena-project:adc-pr2","ref":"adc-pr2","sha":"c74a2cae6bb7765ae696d5e7f09354f61da73b49","user":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"name":"tock","full_name":"helena-project/tock","owner":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helena-project/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/helena-project/tock","forks_url":"https://api.github.com/repos/helena-project/tock/forks","keys_url":"https://api.github.com/repos/helena-project/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena-project/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena-project/tock/teams","hooks_url":"https://api.github.com/repos/helena-project/tock/hooks","issue_events_url":"https://api.github.com/repos/helena-project/tock/issues/events{/number}","events_url":"https://api.github.com/repos/helena-project/tock/events","assignees_url":"https://api.github.com/repos/helena-project/tock/assignees{/user}","branches_url":"https://api.github.com/repos/helena-project/tock/branches{/branch}","tags_url":"https://api.github.com/repos/helena-project/tock/tags","blobs_url":"https://api.github.com/repos/helena-project/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena-project/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena-project/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena-project/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/helena-project/tock/languages","stargazers_url":"https://api.github.com/repos/helena-project/tock/stargazers","contributors_url":"https://api.github.com/repos/helena-project/tock/contributors","subscribers_url":"https://api.github.com/repos/helena-project/tock/subscribers","subscription_url":"https://api.github.com/repos/helena-project/tock/subscription","commits_url":"https://api.github.com/repos/helena-project/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena-project/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena-project/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena-project/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena-project/tock/contents/{+path}","compare_url":"https://api.github.com/repos/helena-project/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena-project/tock/merges","archive_url":"https://api.github.com/repos/helena-project/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena-project/tock/downloads","issues_url":"https://api.github.com/repos/helena-project/tock/issues{/number}","pulls_url":"https://api.github.com/repos/helena-project/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/helena-project/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/helena-project/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena-project/tock/labels{/name}","releases_url":"https://api.github.com/repos/helena-project/tock/releases{/id}","deployments_url":"https://api.github.com/repos/helena-project/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2016-10-15T03:06:02Z","pushed_at":"2016-10-16T03:43:03Z","git_url":"git://github.com/helena-project/tock.git","ssh_url":"git@github.com:helena-project/tock.git","clone_url":"https://github.com/helena-project/tock.git","svn_url":"https://github.com/helena-project/tock","homepage":"http://www.tockos.org","size":3708,"stargazers_count":267,"watchers_count":267,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":29,"forks":23,"open_issues":29,"watchers":267,"default_branch":"master"}},"base":{"label":"helena-project:master","ref":"master","sha":"4e7ea7d86e5ff4598148425edf9058d8c4d7f3de","user":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"name":"tock","full_name":"helena-project/tock","owner":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helena-project/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/helena-project/tock","forks_url":"https://api.github.com/repos/helena-project/tock/forks","keys_url":"https://api.github.com/repos/helena-project/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena-project/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena-project/tock/teams","hooks_url":"https://api.github.com/repos/helena-project/tock/hooks","issue_events_url":"https://api.github.com/repos/helena-project/tock/issues/events{/number}","events_url":"https://api.github.com/repos/helena-project/tock/events","assignees_url":"https://api.github.com/repos/helena-project/tock/assignees{/user}","branches_url":"https://api.github.com/repos/helena-project/tock/branches{/branch}","tags_url":"https://api.github.com/repos/helena-project/tock/tags","blobs_url":"https://api.github.com/repos/helena-project/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena-project/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena-project/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena-project/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/helena-project/tock/languages","stargazers_url":"https://api.github.com/repos/helena-project/tock/stargazers","contributors_url":"https://api.github.com/repos/helena-project/tock/contributors","subscribers_url":"https://api.github.com/repos/helena-project/tock/subscribers","subscription_url":"https://api.github.com/repos/helena-project/tock/subscription","commits_url":"https://api.github.com/repos/helena-project/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena-project/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena-project/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena-project/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena-project/tock/contents/{+path}","compare_url":"https://api.github.com/repos/helena-project/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena-project/tock/merges","archive_url":"https://api.github.com/repos/helena-project/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena-project/tock/downloads","issues_url":"https://api.github.com/repos/helena-project/tock/issues{/number}","pulls_url":"https://api.github.com/repos/helena-project/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/helena-project/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/helena-project/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena-project/tock/labels{/name}","releases_url":"https://api.github.com/repos/helena-project/tock/releases{/id}","deployments_url":"https://api.github.com/repos/helena-project/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2016-10-15T03:06:02Z","pushed_at":"2016-10-16T03:43:03Z","git_url":"git://github.com/helena-project/tock.git","ssh_url":"git@github.com:helena-project/tock.git","clone_url":"https://github.com/helena-project/tock.git","svn_url":"https://github.com/helena-project/tock","homepage":"http://www.tockos.org","size":3708,"stargazers_count":267,"watchers_count":267,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":29,"forks":23,"open_issues":29,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/141"},"html":{"href":"https://github.com/helena-project/tock/pull/141"},"issue":{"href":"https://api.github.com/repos/helena-project/tock/issues/141"},"comments":{"href":"https://api.github.com/repos/helena-project/tock/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/helena-project/tock/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helena-project/tock/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/helena-project/tock/statuses/c74a2cae6bb7765ae696d5e7f09354f61da73b49"}}}}
{"actor":{"display_login":"alevy"}}