{"push_id":987031755,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"b64deed8bbbfeb79795266439f6a17c116074815","before":"14147eda61bcd56fefb629faebe79d4bd8607a55","commits":[{"sha":"d73d33fedf5dd5ad2b6a34eef0afa24a8cebe84e","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"TransformUtils: Avoid getNodePtrUnchecked() in integer division, NFC\n\nStop relying on `getNodePtrUnchecked()` being useful on invalid\niterators.  This function is documented to be for internal use only, and\nthe pointer type will eventually have to change to remove UB from\nilist_iterator.  Instead, check the iterator before it has been\ninvalidated.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@261497 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/llvm/commits/d73d33fedf5dd5ad2b6a34eef0afa24a8cebe84e"},{"sha":"8de6150816ce1efec2b1180fd8fe70364b45270f","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"ADT: Remove == and != comparisons between ilist iterators and pointers\n\nI missed == and != when I removed implicit conversions between iterators\nand pointers in r252380 since they were defined outside ilist_iterator.\n\nSince they depend on getNodePtrUnchecked(), they indirectly rely on UB.\nThis commit removes all uses of these operators.  (I'll delete the\noperators themselves in a separate commit so that it can be easily\nreverted if necessary.)\n\nThere should be NFC here.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@261498 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/llvm/commits/8de6150816ce1efec2b1180fd8fe70364b45270f"},{"sha":"7b83cb68d4f87d66d5112a7da4c566eab8a526a0","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"ADT: Disallow == and != between pointers and ilist iterators\n\nI completely missed these non-class operators when I removed the\nimplicit conversions in r252380.  Remove them now.  r261498 should have\nalready removed all uses.\n\nNote (repeated from r252380): if you have out-of-tree code, it should be\nfairly easy to revert this patch downstream while you update your\nout-of-tree call sites.  Note that these conversions are occasionally\nlatent bugs (that may happen to \"work\" now, but only because of getting\nlucky with UB; follow-ups will change your luck).  When they are valid,\nI suggest using `->getIterator()` to go from pointer to iterator, and\n`&*` to go from iterator to pointer.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@261499 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/llvm/commits/7b83cb68d4f87d66d5112a7da4c566eab8a526a0"},{"sha":"151a6ae8d103c1907292f7fa0817e40378dbec73","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"CodeGen: Add constructor for MIBuilder from a bundle_iterator, NFC\n\nDon't require explicit conversions for creating a MachineInstrBuilder\nfrom a bundle_iterator.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@261500 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/llvm/commits/151a6ae8d103c1907292f7fa0817e40378dbec73"},{"sha":"b64deed8bbbfeb79795266439f6a17c116074815","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"CodeGen: Split bundle_iterator into a separate file, NFC\n\nSplit MachineBasicBlock::bundle_iterator into a separate file, and\nrename the class to MachineBundleIterator.\n\nThis is a precursor to adding a `MachineInstr::getBundleIterator()`\naccessor, which will eventually let us delete the final call to\ngetNodePtrUnchecked(), and then remove the UB from ilist_iterator.\n\nAs a drive-by, I removed an unnecessary second template parameter.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@261502 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/llvm/commits/b64deed8bbbfeb79795266439f6a17c116074815"}]}