{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/61691918","id":61691918,"diff_hunk":"@@ -404,7 +404,7 @@ _outScanInfo(StringInfo str, Scan *node)\n \t\t * subquery, but this is serialized elsewhere in outSubqueryScan, no\n \t\t * need to duplicate it here\n \t\t */","path":"src/backend/nodes/outfuncs.c","position":3,"original_position":3,"commit_id":"529fed7e1e634efc9485d9c08fc5dc9c847d7063","original_commit_id":"529fed7e1e634efc9485d9c08fc5dc9c847d7063","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"body":"This is dead code, let's remove it altogether.\r\n\r\nprint_variable_fields is initialized to true, and only set to false in outfuncs_workfile_mgr_init() function. But outfuncs_workfile_mgr_init() is never called. So we can remove all of: print_variable_fields, outfuncs_workfile_mgr_init(), outfuncs_workfile_mgr_end(), and all the if() tests depending on print_variable_fields, including this one.","created_at":"2016-05-01T19:53:13Z","updated_at":"2016-05-01T19:53:13Z","html_url":"https://github.com/greenplum-db/gpdb/pull/688#discussion_r61691918","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/61691918"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/688#discussion_r61691918"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688","id":68458283,"html_url":"https://github.com/greenplum-db/gpdb/pull/688","diff_url":"https://github.com/greenplum-db/gpdb/pull/688.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/688.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/688","number":688,"state":"open","locked":false,"title":"Remove warning of 'incompatible type' when compiling","user":{"login":"kuien","id":14087289,"avatar_url":"https://avatars.githubusercontent.com/u/14087289?v=3","gravatar_id":"","url":"https://api.github.com/users/kuien","html_url":"https://github.com/kuien","followers_url":"https://api.github.com/users/kuien/followers","following_url":"https://api.github.com/users/kuien/following{/other_user}","gists_url":"https://api.github.com/users/kuien/gists{/gist_id}","starred_url":"https://api.github.com/users/kuien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuien/subscriptions","organizations_url":"https://api.github.com/users/kuien/orgs","repos_url":"https://api.github.com/users/kuien/repos","events_url":"https://api.github.com/users/kuien/events{/privacy}","received_events_url":"https://api.github.com/users/kuien/received_events","type":"User","site_admin":false},"body":"Files changed:\r\n    modified:   src/backend/cdb/motion/ic_common.c\r\n    modified:   src/backend/executor/spi.c\r\n    modified:   src/backend/nodes/outfuncs.c\r\n    modified:   src/backend/optimizer/path/costsize.c\r\n    modified:   src/backend/storage/file/compress_zlib.c\r\n\r\nNote: The warning indicates a potential error in\r\n    function _outScanInfo() of outfuncs.c.","created_at":"2016-04-30T04:51:33Z","updated_at":"2016-05-01T19:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f17c6f8f02dc1839587fcc5bfa9c17df691fc09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/688/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/529fed7e1e634efc9485d9c08fc5dc9c847d7063","head":{"label":"kuien:no-warnings-incompatible-type","ref":"no-warnings-incompatible-type","sha":"529fed7e1e634efc9485d9c08fc5dc9c847d7063","user":{"login":"kuien","id":14087289,"avatar_url":"https://avatars.githubusercontent.com/u/14087289?v=3","gravatar_id":"","url":"https://api.github.com/users/kuien","html_url":"https://github.com/kuien","followers_url":"https://api.github.com/users/kuien/followers","following_url":"https://api.github.com/users/kuien/following{/other_user}","gists_url":"https://api.github.com/users/kuien/gists{/gist_id}","starred_url":"https://api.github.com/users/kuien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuien/subscriptions","organizations_url":"https://api.github.com/users/kuien/orgs","repos_url":"https://api.github.com/users/kuien/repos","events_url":"https://api.github.com/users/kuien/events{/privacy}","received_events_url":"https://api.github.com/users/kuien/received_events","type":"User","site_admin":false},"repo":{"id":45446447,"name":"gpdb","full_name":"kuien/gpdb","owner":{"login":"kuien","id":14087289,"avatar_url":"https://avatars.githubusercontent.com/u/14087289?v=3","gravatar_id":"","url":"https://api.github.com/users/kuien","html_url":"https://github.com/kuien","followers_url":"https://api.github.com/users/kuien/followers","following_url":"https://api.github.com/users/kuien/following{/other_user}","gists_url":"https://api.github.com/users/kuien/gists{/gist_id}","starred_url":"https://api.github.com/users/kuien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuien/subscriptions","organizations_url":"https://api.github.com/users/kuien/orgs","repos_url":"https://api.github.com/users/kuien/repos","events_url":"https://api.github.com/users/kuien/events{/privacy}","received_events_url":"https://api.github.com/users/kuien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kuien/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/kuien/gpdb","forks_url":"https://api.github.com/repos/kuien/gpdb/forks","keys_url":"https://api.github.com/repos/kuien/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuien/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuien/gpdb/teams","hooks_url":"https://api.github.com/repos/kuien/gpdb/hooks","issue_events_url":"https://api.github.com/repos/kuien/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/kuien/gpdb/events","assignees_url":"https://api.github.com/repos/kuien/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/kuien/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/kuien/gpdb/tags","blobs_url":"https://api.github.com/repos/kuien/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuien/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuien/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuien/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuien/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/kuien/gpdb/languages","stargazers_url":"https://api.github.com/repos/kuien/gpdb/stargazers","contributors_url":"https://api.github.com/repos/kuien/gpdb/contributors","subscribers_url":"https://api.github.com/repos/kuien/gpdb/subscribers","subscription_url":"https://api.github.com/repos/kuien/gpdb/subscription","commits_url":"https://api.github.com/repos/kuien/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuien/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuien/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuien/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuien/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/kuien/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuien/gpdb/merges","archive_url":"https://api.github.com/repos/kuien/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuien/gpdb/downloads","issues_url":"https://api.github.com/repos/kuien/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/kuien/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/kuien/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/kuien/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuien/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/kuien/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/kuien/gpdb/deployments","created_at":"2015-11-03T06:28:30Z","updated_at":"2015-11-03T06:29:15Z","pushed_at":"2016-04-30T04:47:39Z","git_url":"git://github.com/kuien/gpdb.git","ssh_url":"git@github.com:kuien/gpdb.git","clone_url":"https://github.com/kuien/gpdb.git","svn_url":"https://github.com/kuien/gpdb","homepage":"http://greenplum.org","size":139905,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"d5f3d6fa94b78115424b1e3703cf9913e54507dd","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-04-30T00:16:08Z","pushed_at":"2016-05-01T01:49:53Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":152058,"stargazers_count":1417,"watchers_count":1417,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":372,"mirror_url":null,"open_issues_count":89,"forks":372,"open_issues":89,"watchers":1417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/688"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/688"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/529fed7e1e634efc9485d9c08fc5dc9c847d7063"}}}}