{"push_id":1315872917,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"edee7cd06efa2dccb504e965cd1b031ea5ded4db","before":"0ee01214f1b1fd1340e949b45eeebaa2aceeb226","commits":[{"sha":"3568d53064817059ae11ea575e1524abc1ec1794","author":{"name":"Mark Dodwell","email":"5af4368b9293063e989a5c111060172e6cf7c42b@gmail.com"},"message":"ensure no open file handles","distinct":true,"url":"https://api.github.com/repos/High5Apps/ruby-bidi/commits/3568d53064817059ae11ea575e1524abc1ec1794"},{"sha":"e4b161996bd9ad6de8ca72fefb2bc80c2c828306","author":{"name":"Mark Dodwell","email":"5af4368b9293063e989a5c111060172e6cf7c42b@gmail.com"},"message":"help reduce noise in diff","distinct":true,"url":"https://api.github.com/repos/High5Apps/ruby-bidi/commits/e4b161996bd9ad6de8ca72fefb2bc80c2c828306"},{"sha":"edee7cd06efa2dccb504e965cd1b031ea5ded4db","author":{"name":"Julian Tigler","email":"068f8df6cfd71033511563d027ec6f2027ffa669@gmail.com"},"message":"Fix to_visual algorithm broken after first call\n\nThis change fixes an issue where to_visual was only returning the\ncorrectly formatted bidi result the first time it was called after a\nserver restart (or anything else that would re-initialize Bidi’s global\n$weakHashMap variable).\n\nThe root cause of this issue was an unless block with improper syntax.\nRuby doesn’t allow braces to be used to define multi-line unless\nblocks. Instead, the ‘end’ keyword must be used. This caused the ruby\ninterpreter to think that the end of the WeakHashMap’s [] method\ndefinition was the real end of the offending unless block. Due to this,\non any WeakHashMap ‘hit’ the code that actually assigns ret_value was\nalways skipped and the delete method definition was returned instead.\nThis caused every letter to have bidiType nil in bidi.rb’s\nto_paragraphs method which messed up the bidi algorithm.\n\nThis is also the reason why an extra end keyword was previously needed\nat the bottom of the file. Were it not there, a SyntaxError would have\nbeen raised.\n\nI manually tested this change by testing that to_visual returned the\ncorrectly formatted bidi string on its first, second, and subsequent\ncalls with the input string \"משפט עם עברית ו-English. מספרים: 12345\n(וגם כל מיני סימני פיסוק) וגם סימן קריאה!” taken from this thread\nhttps://github.com/prawnpdf/prawn/issues/514","distinct":true,"url":"https://api.github.com/repos/High5Apps/ruby-bidi/commits/edee7cd06efa2dccb504e965cd1b031ea5ded4db"}]}
{"actor":{"display_login":"High5Apps"}}