{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/93805343","pull_request_review_id":14342217,"id":93805343,"diff_hunk":"@@ -5,6 +5,8 @@ licenses([\"notice\"])  # custom notice-style license, see LICENSE.md\n \n exports_files([\"LICENSE.md\"])\n \n+load(\"@//third_party:common.bzl\", \"expand_header_template\")","path":"third_party/jpeg/jpeg.BUILD","position":4,"original_position":4,"commit_id":"72f1ba04dda9202ab44aaaf2cda2bbba44107d8b","original_commit_id":"1e9ed820139f489e17fee294d72a42522e6297bf","user":{"login":"gunan","id":7946809,"avatar_url":"https://avatars.githubusercontent.com/u/7946809?v=3","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"body":"Acknowledged.\r\nDo you want me to leave a comment here about that?","created_at":"2016-12-23T22:11:42Z","updated_at":"2016-12-23T22:11:42Z","html_url":"https://github.com/tensorflow/tensorflow/pull/6462#discussion_r93805343","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/93805343"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/6462#discussion_r93805343"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462","id":99171529,"html_url":"https://github.com/tensorflow/tensorflow/pull/6462","diff_url":"https://github.com/tensorflow/tensorflow/pull/6462.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/6462.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/6462","number":6462,"state":"open","locked":false,"title":"Write rules to construct headers for jpeg-turbo using existing templates.","user":{"login":"gunan","id":7946809,"avatar_url":"https://avatars.githubusercontent.com/u/7946809?v=3","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"body":"Fixes #6442 \r\nTest build:\r\nhttp://ci.tensorflow.org/view/Experimental/job/exp-win-bzl/8/console\r\n\r\nHad to use a few hacks to get this fully working.\r\nBazel did not allow me to add a `dict` type with a selector.\r\nIt even did not let me use a selector in `expand_template`'s substitutions field.\r\nSo I expanded the selector in genrule to accomodate simd/nosimd differences.\r\n\r\nI think I can also get rid of my `expand_template.bzl` , and use `expand_header_template` in `llvm.bzl`.\r\nBut I am not sure how nice cross 3p usage. Maybe I can create a folder `third_party/skylark` and pull the skylark rules we are defining to that folder. Or simply `third_party/common.bzl`\r\nPlease let me know which looks nicer.","created_at":"2016-12-22T21:20:02Z","updated_at":"2016-12-23T22:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab344349cfc0884d461b1ef0e5cc53de4478f0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/6462/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/72f1ba04dda9202ab44aaaf2cda2bbba44107d8b","head":{"label":"gunan:windows_fix","ref":"windows_fix","sha":"72f1ba04dda9202ab44aaaf2cda2bbba44107d8b","user":{"login":"gunan","id":7946809,"avatar_url":"https://avatars.githubusercontent.com/u/7946809?v=3","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"repo":{"id":69069043,"name":"tensorflow","full_name":"gunan/tensorflow","owner":{"login":"gunan","id":7946809,"avatar_url":"https://avatars.githubusercontent.com/u/7946809?v=3","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunan/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/gunan/tensorflow","forks_url":"https://api.github.com/repos/gunan/tensorflow/forks","keys_url":"https://api.github.com/repos/gunan/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunan/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunan/tensorflow/teams","hooks_url":"https://api.github.com/repos/gunan/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/gunan/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/gunan/tensorflow/events","assignees_url":"https://api.github.com/repos/gunan/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/gunan/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/gunan/tensorflow/tags","blobs_url":"https://api.github.com/repos/gunan/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunan/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunan/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunan/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunan/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/gunan/tensorflow/languages","stargazers_url":"https://api.github.com/repos/gunan/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/gunan/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/gunan/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/gunan/tensorflow/subscription","commits_url":"https://api.github.com/repos/gunan/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunan/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunan/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunan/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunan/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/gunan/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunan/tensorflow/merges","archive_url":"https://api.github.com/repos/gunan/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunan/tensorflow/downloads","issues_url":"https://api.github.com/repos/gunan/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/gunan/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/gunan/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/gunan/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunan/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/gunan/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/gunan/tensorflow/deployments","created_at":"2016-09-24T00:10:29Z","updated_at":"2016-10-23T05:23:48Z","pushed_at":"2016-12-23T22:11:07Z","git_url":"git://github.com/gunan/tensorflow.git","ssh_url":"git@github.com:gunan/tensorflow.git","clone_url":"https://github.com/gunan/tensorflow.git","svn_url":"https://github.com/gunan/tensorflow","homepage":"http://tensorflow.org","size":79889,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"64edd34ce69b4a8033af5d217cb8894105297d8a","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2016-12-23T22:06:37Z","pushed_at":"2016-12-23T22:11:09Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":79913,"stargazers_count":40875,"watchers_count":40875,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19016,"mirror_url":null,"open_issues_count":735,"forks":19016,"open_issues":735,"watchers":40875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/6462"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/6462"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/6462/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/6462/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/72f1ba04dda9202ab44aaaf2cda2bbba44107d8b"}}}}
{"actor":{"display_login":"gunan"}}