{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/76387954","id":76387954,"diff_hunk":"@@ -50,16 +50,20 @@ type remoteAscFetcher struct {\n func (f *remoteAscFetcher) Get(location string) (readSeekCloser, error) {\n \troc, err := getTmpROC(f.S, location)\n \tif err != nil {\n-\t\treturn nil, err\n+\t\treturn NopReadSeekCloser(nil), err\n \t}\n-\tdefer func() { maybeClose(roc) }()\n+\tdefer func() {\n+\t\tif roc != nil {\n+\t\t\troc.Close()\n+\t\t}\n+\t}()","path":"rkt/image/asc.go","position":12,"original_position":12,"commit_id":"163816cc644377648c269ff131c6dd4341fb6829","original_commit_id":"163816cc644377648c269ff131c6dd4341fb6829","user":{"login":"alepuccetti","id":6577391,"avatar_url":"https://avatars.githubusercontent.com/u/6577391?v=3","gravatar_id":"","url":"https://api.github.com/users/alepuccetti","html_url":"https://github.com/alepuccetti","followers_url":"https://api.github.com/users/alepuccetti/followers","following_url":"https://api.github.com/users/alepuccetti/following{/other_user}","gists_url":"https://api.github.com/users/alepuccetti/gists{/gist_id}","starred_url":"https://api.github.com/users/alepuccetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alepuccetti/subscriptions","organizations_url":"https://api.github.com/users/alepuccetti/orgs","repos_url":"https://api.github.com/users/alepuccetti/repos","events_url":"https://api.github.com/users/alepuccetti/events{/privacy}","received_events_url":"https://api.github.com/users/alepuccetti/received_events","type":"User","site_admin":false},"body":"`getTmpROC` returns `removeOnClose` not `readSeekCloser`","created_at":"2016-08-26T09:07:15Z","updated_at":"2016-08-26T09:07:15Z","html_url":"https://github.com/coreos/rkt/pull/3120#discussion_r76387954","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3120","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/76387954"},"html":{"href":"https://github.com/coreos/rkt/pull/3120#discussion_r76387954"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3120"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3120","id":82791860,"html_url":"https://github.com/coreos/rkt/pull/3120","diff_url":"https://github.com/coreos/rkt/pull/3120.diff","patch_url":"https://github.com/coreos/rkt/pull/3120.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3120","number":3120,"state":"open","locked":false,"title":"Remove isReallyNil()","user":{"login":"alepuccetti","id":6577391,"avatar_url":"https://avatars.githubusercontent.com/u/6577391?v=3","gravatar_id":"","url":"https://api.github.com/users/alepuccetti","html_url":"https://github.com/alepuccetti","followers_url":"https://api.github.com/users/alepuccetti/followers","following_url":"https://api.github.com/users/alepuccetti/following{/other_user}","gists_url":"https://api.github.com/users/alepuccetti/gists{/gist_id}","starred_url":"https://api.github.com/users/alepuccetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alepuccetti/subscriptions","organizations_url":"https://api.github.com/users/alepuccetti/orgs","repos_url":"https://api.github.com/users/alepuccetti/repos","events_url":"https://api.github.com/users/alepuccetti/events{/privacy}","received_events_url":"https://api.github.com/users/alepuccetti/received_events","type":"User","site_admin":false},"body":"This PR implements the NopCloser()-like function `NopReadSeekCloser()` and some other cleanups related to the removing of `isReallyNil()`.\r\n\r\nThis fixes #2922 ","created_at":"2016-08-25T20:56:55Z","updated_at":"2016-08-26T09:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0e602865c353c69ad71cc7126bc1ecb4a661e70","assignee":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"assignees":[{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/48","html_url":"https://github.com/coreos/rkt/milestones/v1.14.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/48/labels","id":1922996,"number":48,"title":"v1.14.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":13,"state":"open","created_at":"2016-08-04T07:34:12Z","updated_at":"2016-08-26T07:44:26Z","due_on":"2016-09-01T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3120/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3120/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3120/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/163816cc644377648c269ff131c6dd4341fb6829","head":{"label":"kinvolk:alessandro/remove-is-really-nil","ref":"alessandro/remove-is-really-nil","sha":"163816cc644377648c269ff131c6dd4341fb6829","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":45149715,"name":"rkt","full_name":"kinvolk/rkt","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/kinvolk/rkt","forks_url":"https://api.github.com/repos/kinvolk/rkt/forks","keys_url":"https://api.github.com/repos/kinvolk/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/rkt/teams","hooks_url":"https://api.github.com/repos/kinvolk/rkt/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/rkt/events","assignees_url":"https://api.github.com/repos/kinvolk/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/rkt/tags","blobs_url":"https://api.github.com/repos/kinvolk/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/rkt/languages","stargazers_url":"https://api.github.com/repos/kinvolk/rkt/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/rkt/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/rkt/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/rkt/subscription","commits_url":"https://api.github.com/repos/kinvolk/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/rkt/merges","archive_url":"https://api.github.com/repos/kinvolk/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/rkt/downloads","issues_url":"https://api.github.com/repos/kinvolk/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/rkt/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/rkt/deployments","created_at":"2015-10-29T00:17:06Z","updated_at":"2016-06-06T12:54:39Z","pushed_at":"2016-08-25T20:50:33Z","git_url":"git://github.com/kinvolk/rkt.git","ssh_url":"git@github.com:kinvolk/rkt.git","clone_url":"https://github.com/kinvolk/rkt.git","svn_url":"https://github.com/kinvolk/rkt","homepage":"","size":23215,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"8d75491d77ec357cab76af4f959998493038ef21","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a container engine for Linux designed to be composable, secure, and built on standards","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-08-26T06:18:43Z","pushed_at":"2016-08-26T08:18:03Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":32684,"stargazers_count":5837,"watchers_count":5837,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":571,"mirror_url":null,"open_issues_count":374,"forks":571,"open_issues":374,"watchers":5837,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3120"},"html":{"href":"https://github.com/coreos/rkt/pull/3120"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3120"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3120/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3120/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3120/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/163816cc644377648c269ff131c6dd4341fb6829"}}}}
{"actor":{"display_login":"alepuccetti"}}