{"action":"created","comment":{"url":"https://api.github.com/repos/rsl/stringex/pulls/comments/52447628","id":52447628,"diff_hunk":"@@ -36,7 +39,7 @@ def store_translations(locale, scope, data)\n       end\n \n       def translate(scope, key, options = {})\n-        return if key == \".\" # I18n doesn't support dots as translation keys so we don't either\n+        return if key == DOT # I18n doesn't support dots as translation keys so we don't either","path":"lib/stringex/localization.rb","position":15,"original_position":15,"commit_id":"f5dc669920ddd34276aa3c7c7000bdce9be26802","original_commit_id":"f5dc669920ddd34276aa3c7c7000bdce9be26802","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [95/80]","created_at":"2016-02-10T11:54:12Z","updated_at":"2016-02-10T11:54:12Z","html_url":"https://github.com/rsl/stringex/pull/181#discussion_r52447628","pull_request_url":"https://api.github.com/repos/rsl/stringex/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/rsl/stringex/pulls/comments/52447628"},"html":{"href":"https://github.com/rsl/stringex/pull/181#discussion_r52447628"},"pull_request":{"href":"https://api.github.com/repos/rsl/stringex/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/rsl/stringex/pulls/181","id":58880446,"html_url":"https://github.com/rsl/stringex/pull/181","diff_url":"https://github.com/rsl/stringex/pull/181.diff","patch_url":"https://github.com/rsl/stringex/pull/181.patch","issue_url":"https://api.github.com/repos/rsl/stringex/issues/181","number":181,"state":"open","locked":false,"title":"Freeze the \".\" character used in comparisons","user":{"login":"Darep","id":218910,"avatar_url":"https://avatars.githubusercontent.com/u/218910?v=3","gravatar_id":"","url":"https://api.github.com/users/Darep","html_url":"https://github.com/Darep","followers_url":"https://api.github.com/users/Darep/followers","following_url":"https://api.github.com/users/Darep/following{/other_user}","gists_url":"https://api.github.com/users/Darep/gists{/gist_id}","starred_url":"https://api.github.com/users/Darep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darep/subscriptions","organizations_url":"https://api.github.com/users/Darep/orgs","repos_url":"https://api.github.com/users/Darep/repos","events_url":"https://api.github.com/users/Darep/events{/privacy}","received_events_url":"https://api.github.com/users/Darep/received_events","type":"User","site_admin":false},"body":"(Disclaimer: this change is written by @Fred-JulieDesk, I take no credit or responsibility, I'm just the pull request creator :) )\r\n\r\nThis change freezes the `.` character that is used in comparison of the translation key. This way, we don't allocate a new string object every time the comparison is made and save a bit of memory.\r\n\r\nSee #180 for more.","created_at":"2016-02-10T11:54:08Z","updated_at":"2016-02-10T11:54:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce58615aa6cccafcf388873231690433f0e7bb82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rsl/stringex/pulls/181/commits","review_comments_url":"https://api.github.com/repos/rsl/stringex/pulls/181/comments","review_comment_url":"https://api.github.com/repos/rsl/stringex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsl/stringex/issues/181/comments","statuses_url":"https://api.github.com/repos/rsl/stringex/statuses/f5dc669920ddd34276aa3c7c7000bdce9be26802","head":{"label":"Fred-JulieDesk:master","ref":"master","sha":"f5dc669920ddd34276aa3c7c7000bdce9be26802","user":{"login":"Fred-JulieDesk","id":13829806,"avatar_url":"https://avatars.githubusercontent.com/u/13829806?v=3","gravatar_id":"","url":"https://api.github.com/users/Fred-JulieDesk","html_url":"https://github.com/Fred-JulieDesk","followers_url":"https://api.github.com/users/Fred-JulieDesk/followers","following_url":"https://api.github.com/users/Fred-JulieDesk/following{/other_user}","gists_url":"https://api.github.com/users/Fred-JulieDesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Fred-JulieDesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fred-JulieDesk/subscriptions","organizations_url":"https://api.github.com/users/Fred-JulieDesk/orgs","repos_url":"https://api.github.com/users/Fred-JulieDesk/repos","events_url":"https://api.github.com/users/Fred-JulieDesk/events{/privacy}","received_events_url":"https://api.github.com/users/Fred-JulieDesk/received_events","type":"User","site_admin":false},"repo":{"id":51298163,"name":"stringex","full_name":"Fred-JulieDesk/stringex","owner":{"login":"Fred-JulieDesk","id":13829806,"avatar_url":"https://avatars.githubusercontent.com/u/13829806?v=3","gravatar_id":"","url":"https://api.github.com/users/Fred-JulieDesk","html_url":"https://github.com/Fred-JulieDesk","followers_url":"https://api.github.com/users/Fred-JulieDesk/followers","following_url":"https://api.github.com/users/Fred-JulieDesk/following{/other_user}","gists_url":"https://api.github.com/users/Fred-JulieDesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Fred-JulieDesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fred-JulieDesk/subscriptions","organizations_url":"https://api.github.com/users/Fred-JulieDesk/orgs","repos_url":"https://api.github.com/users/Fred-JulieDesk/repos","events_url":"https://api.github.com/users/Fred-JulieDesk/events{/privacy}","received_events_url":"https://api.github.com/users/Fred-JulieDesk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fred-JulieDesk/stringex","description":"Some [hopefully] useful extensions to Ruby’s String class. It is made up of three libraries: ActsAsUrl [permalink solution with better character translation], Unidecoder [Unicode to Ascii transliteration], and StringExtensions [miscellaneous helper methods for the String class].","fork":true,"url":"https://api.github.com/repos/Fred-JulieDesk/stringex","forks_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/forks","keys_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/teams","hooks_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/hooks","issue_events_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/issues/events{/number}","events_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/events","assignees_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/assignees{/user}","branches_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/branches{/branch}","tags_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/tags","blobs_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/statuses/{sha}","languages_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/languages","stargazers_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/stargazers","contributors_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/contributors","subscribers_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/subscribers","subscription_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/subscription","commits_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/contents/{+path}","compare_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/merges","archive_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/downloads","issues_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/issues{/number}","pulls_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/pulls{/number}","milestones_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/milestones{/number}","notifications_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/labels{/name}","releases_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/releases{/id}","deployments_url":"https://api.github.com/repos/Fred-JulieDesk/stringex/deployments","created_at":"2016-02-08T13:02:22Z","updated_at":"2016-02-08T13:02:24Z","pushed_at":"2016-02-08T13:10:12Z","git_url":"git://github.com/Fred-JulieDesk/stringex.git","ssh_url":"git@github.com:Fred-JulieDesk/stringex.git","clone_url":"https://github.com/Fred-JulieDesk/stringex.git","svn_url":"https://github.com/Fred-JulieDesk/stringex","homepage":"","size":633,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rsl:master","ref":"master","sha":"5b2043adc2487caeff55f3f6acb69ae46a4bffb9","user":{"login":"rsl","id":92,"avatar_url":"https://avatars.githubusercontent.com/u/92?v=3","gravatar_id":"","url":"https://api.github.com/users/rsl","html_url":"https://github.com/rsl","followers_url":"https://api.github.com/users/rsl/followers","following_url":"https://api.github.com/users/rsl/following{/other_user}","gists_url":"https://api.github.com/users/rsl/gists{/gist_id}","starred_url":"https://api.github.com/users/rsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsl/subscriptions","organizations_url":"https://api.github.com/users/rsl/orgs","repos_url":"https://api.github.com/users/rsl/repos","events_url":"https://api.github.com/users/rsl/events{/privacy}","received_events_url":"https://api.github.com/users/rsl/received_events","type":"User","site_admin":false},"repo":{"id":765,"name":"stringex","full_name":"rsl/stringex","owner":{"login":"rsl","id":92,"avatar_url":"https://avatars.githubusercontent.com/u/92?v=3","gravatar_id":"","url":"https://api.github.com/users/rsl","html_url":"https://github.com/rsl","followers_url":"https://api.github.com/users/rsl/followers","following_url":"https://api.github.com/users/rsl/following{/other_user}","gists_url":"https://api.github.com/users/rsl/gists{/gist_id}","starred_url":"https://api.github.com/users/rsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsl/subscriptions","organizations_url":"https://api.github.com/users/rsl/orgs","repos_url":"https://api.github.com/users/rsl/repos","events_url":"https://api.github.com/users/rsl/events{/privacy}","received_events_url":"https://api.github.com/users/rsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsl/stringex","description":"Some [hopefully] useful extensions to Ruby’s String class. It is made up of three libraries: ActsAsUrl [permalink solution with better character translation], Unidecoder [Unicode to Ascii transliteration], and StringExtensions [miscellaneous helper methods for the String class].","fork":false,"url":"https://api.github.com/repos/rsl/stringex","forks_url":"https://api.github.com/repos/rsl/stringex/forks","keys_url":"https://api.github.com/repos/rsl/stringex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsl/stringex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsl/stringex/teams","hooks_url":"https://api.github.com/repos/rsl/stringex/hooks","issue_events_url":"https://api.github.com/repos/rsl/stringex/issues/events{/number}","events_url":"https://api.github.com/repos/rsl/stringex/events","assignees_url":"https://api.github.com/repos/rsl/stringex/assignees{/user}","branches_url":"https://api.github.com/repos/rsl/stringex/branches{/branch}","tags_url":"https://api.github.com/repos/rsl/stringex/tags","blobs_url":"https://api.github.com/repos/rsl/stringex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsl/stringex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsl/stringex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsl/stringex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsl/stringex/statuses/{sha}","languages_url":"https://api.github.com/repos/rsl/stringex/languages","stargazers_url":"https://api.github.com/repos/rsl/stringex/stargazers","contributors_url":"https://api.github.com/repos/rsl/stringex/contributors","subscribers_url":"https://api.github.com/repos/rsl/stringex/subscribers","subscription_url":"https://api.github.com/repos/rsl/stringex/subscription","commits_url":"https://api.github.com/repos/rsl/stringex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsl/stringex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsl/stringex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsl/stringex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsl/stringex/contents/{+path}","compare_url":"https://api.github.com/repos/rsl/stringex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsl/stringex/merges","archive_url":"https://api.github.com/repos/rsl/stringex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsl/stringex/downloads","issues_url":"https://api.github.com/repos/rsl/stringex/issues{/number}","pulls_url":"https://api.github.com/repos/rsl/stringex/pulls{/number}","milestones_url":"https://api.github.com/repos/rsl/stringex/milestones{/number}","notifications_url":"https://api.github.com/repos/rsl/stringex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsl/stringex/labels{/name}","releases_url":"https://api.github.com/repos/rsl/stringex/releases{/id}","deployments_url":"https://api.github.com/repos/rsl/stringex/deployments","created_at":"2008-02-19T15:31:07Z","updated_at":"2016-01-25T01:32:20Z","pushed_at":"2016-02-10T11:54:08Z","git_url":"git://github.com/rsl/stringex.git","ssh_url":"git@github.com:rsl/stringex.git","clone_url":"https://github.com/rsl/stringex.git","svn_url":"https://github.com/rsl/stringex","homepage":"","size":950,"stargazers_count":911,"watchers_count":911,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":6,"forks":137,"open_issues":6,"watchers":911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsl/stringex/pulls/181"},"html":{"href":"https://github.com/rsl/stringex/pull/181"},"issue":{"href":"https://api.github.com/repos/rsl/stringex/issues/181"},"comments":{"href":"https://api.github.com/repos/rsl/stringex/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/rsl/stringex/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/rsl/stringex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsl/stringex/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/rsl/stringex/statuses/f5dc669920ddd34276aa3c7c7000bdce9be26802"}}}}