{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/52361877","id":52361877,"diff_hunk":"@@ -64,7 +64,7 @@ object CommandLineUtils extends Logging {\n \n     val props = new Properties\n     for(a <- splits) {\n-      if (a.length == 1) props.put(a(0), \"\")\n+      if (a.length == 1) throw new IllegalArgumentException(s\"Missing value for key ${a(0)}\")","path":"core/src/main/scala/kafka/utils/CommandLineUtils.scala","position":5,"original_position":5,"commit_id":"a63794ca23a8b73b9108c7ca3502b5930056bcd8","original_commit_id":"a63794ca23a8b73b9108c7ca3502b5930056bcd8","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"@ijuma to not introduce any unwanted error or change in cli behavior in a minor release, I am a +1 on adding a boolean param, `acceptEmptyValue`, with a default value of `true` to `acceptEmptyValue`.","created_at":"2016-02-09T19:39:19Z","updated_at":"2016-02-09T19:39:19Z","html_url":"https://github.com/apache/kafka/pull/806#discussion_r52361877","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/806","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/52361877"},"html":{"href":"https://github.com/apache/kafka/pull/806#discussion_r52361877"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/806"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/806","id":56960036,"html_url":"https://github.com/apache/kafka/pull/806","diff_url":"https://github.com/apache/kafka/pull/806.diff","patch_url":"https://github.com/apache/kafka/pull/806.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/806","number":806,"state":"open","locked":false,"title":"KAFKA-3141: Add checks to catch invalid authorizer porperties","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"Skip misformed properties instead of throwing ArrayIndexOutOfBoundsException","created_at":"2016-01-23T00:26:08Z","updated_at":"2016-02-09T19:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07806a695cafadcbdf48b6b33d56c83c89196c92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/806/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/806/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/806/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/a63794ca23a8b73b9108c7ca3502b5930056bcd8","head":{"label":"SinghAsDev:KAFKA-3141","ref":"KAFKA-3141","sha":"a63794ca23a8b73b9108c7ca3502b5930056bcd8","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"repo":{"id":29443488,"name":"kafka","full_name":"SinghAsDev/kafka","owner":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SinghAsDev/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/SinghAsDev/kafka","forks_url":"https://api.github.com/repos/SinghAsDev/kafka/forks","keys_url":"https://api.github.com/repos/SinghAsDev/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SinghAsDev/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SinghAsDev/kafka/teams","hooks_url":"https://api.github.com/repos/SinghAsDev/kafka/hooks","issue_events_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/SinghAsDev/kafka/events","assignees_url":"https://api.github.com/repos/SinghAsDev/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/SinghAsDev/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/SinghAsDev/kafka/tags","blobs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SinghAsDev/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/SinghAsDev/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SinghAsDev/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/SinghAsDev/kafka/languages","stargazers_url":"https://api.github.com/repos/SinghAsDev/kafka/stargazers","contributors_url":"https://api.github.com/repos/SinghAsDev/kafka/contributors","subscribers_url":"https://api.github.com/repos/SinghAsDev/kafka/subscribers","subscription_url":"https://api.github.com/repos/SinghAsDev/kafka/subscription","commits_url":"https://api.github.com/repos/SinghAsDev/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/SinghAsDev/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/SinghAsDev/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/SinghAsDev/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/SinghAsDev/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SinghAsDev/kafka/merges","archive_url":"https://api.github.com/repos/SinghAsDev/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SinghAsDev/kafka/downloads","issues_url":"https://api.github.com/repos/SinghAsDev/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/SinghAsDev/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/SinghAsDev/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/SinghAsDev/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SinghAsDev/kafka/labels{/name}","releases_url":"https://api.github.com/repos/SinghAsDev/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/SinghAsDev/kafka/deployments","created_at":"2015-01-18T22:26:11Z","updated_at":"2015-01-18T22:26:13Z","pushed_at":"2016-02-04T23:23:22Z","git_url":"git://github.com/SinghAsDev/kafka.git","ssh_url":"git@github.com:SinghAsDev/kafka.git","clone_url":"https://github.com/SinghAsDev/kafka.git","svn_url":"https://github.com/SinghAsDev/kafka","homepage":null,"size":26929,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"79eacf6c95506d5d6819add5a1256681b13170b1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-02-09T14:55:15Z","pushed_at":"2016-02-09T19:34:36Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":34799,"stargazers_count":2613,"watchers_count":2613,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1561,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":121,"forks":1561,"open_issues":121,"watchers":2613,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/806"},"html":{"href":"https://github.com/apache/kafka/pull/806"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/806"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/806/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/806/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/806/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/a63794ca23a8b73b9108c7ca3502b5930056bcd8"}}}}