{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/comments/66710944","id":66710944,"diff_hunk":"@@ -0,0 +1,54 @@\n+<?php\n+/**\n+ * Zend Framework (http://framework.zend.com/)\n+ *\n+ * @link      https://github.com/zendframework/zendframework for the canonical source repository\n+ * @copyright Copyright (c) 2005-2016 Zend Technologies USA Inc. (http://www.zend.com)\n+ * @license   http://framework.zend.com/license/new-bsd New BSD License\n+ */\n+\n+namespace ZendTest\\Navigation;\n+\n+use Zend\\Navigation\\ConfigProvider;\n+use Zend\\Navigation\\Navigation;\n+use Zend\\Navigation\\Service;\n+use Zend\\Navigation\\View;\n+\n+/**\n+ * Tests the class Zend_Navigation_ConfigProvider\n+ *\n+ * @group Zend_Navigation\n+ */\n+class ConfigProviderTest extends \\PHPUnit_Framework_TestCase\n+{\n+    private $config = [\n+        'abstract_factories' => [\n+            Service\\NavigationAbstractServiceFactory::class,\n+        ],\n+        'aliases' => [\n+            'navigation' => Navigation::class,\n+        ],\n+        'delegators' => [\n+            'ViewHelperManager' => [\n+                View\\ViewHelperManagerDelegatorFactory::class,\n+            ],\n+        ],\n+        'factories' => [\n+            Navigation::class => Service\\DefaultNavigationFactory::class,\n+        ],\n+    ];\n+\n+    public function testGetDependencyConfig()\n+    {\n+        $provider = new ConfigProvider();\n+\n+        $this->assertEquals($this->config, $provider->getDependencyConfig());\n+    }\n+\n+    public function testInvoke()\n+    {\n+        $provider = new ConfigProvider();\n+\n+        $this->assertEquals(['dependencies' => $this->config], $provider());","path":"test/ConfigProviderTest.php","position":52,"original_position":52,"commit_id":"ef2e8f4298f614b07e960c95382b78277b030336","original_commit_id":"ef2e8f4298f614b07e960c95382b78277b030336","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"I'd argue this should be:\r\n\r\n```php\r\n$this->assertEquals(['dependencies' => $provider->getDependencyConfig()], $provider());\r\n```\r\n\r\nAdditionally, this test should depend on the `testGetDependencyConfig()` test as a result, as if that fails, there's no reason to run it.\r\n\r\nI can make these changes on merge.","created_at":"2016-06-11T19:59:26Z","updated_at":"2016-06-11T19:59:26Z","html_url":"https://github.com/zendframework/zend-navigation/pull/35#discussion_r66710944","pull_request_url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/comments/66710944"},"html":{"href":"https://github.com/zendframework/zend-navigation/pull/35#discussion_r66710944"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35","id":73462056,"html_url":"https://github.com/zendframework/zend-navigation/pull/35","diff_url":"https://github.com/zendframework/zend-navigation/pull/35.diff","patch_url":"https://github.com/zendframework/zend-navigation/pull/35.patch","issue_url":"https://api.github.com/repos/zendframework/zend-navigation/issues/35","number":35,"state":"open","locked":false,"title":"config provider Service\\DefaultNavigationFactory namespace fix","user":{"login":"vaclavvanik","id":3754860,"avatar_url":"https://avatars.githubusercontent.com/u/3754860?v=3","gravatar_id":"","url":"https://api.github.com/users/vaclavvanik","html_url":"https://github.com/vaclavvanik","followers_url":"https://api.github.com/users/vaclavvanik/followers","following_url":"https://api.github.com/users/vaclavvanik/following{/other_user}","gists_url":"https://api.github.com/users/vaclavvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/vaclavvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaclavvanik/subscriptions","organizations_url":"https://api.github.com/users/vaclavvanik/orgs","repos_url":"https://api.github.com/users/vaclavvanik/repos","events_url":"https://api.github.com/users/vaclavvanik/events{/privacy}","received_events_url":"https://api.github.com/users/vaclavvanik/received_events","type":"User","site_admin":false},"body":"Fix for [issue #31](https://github.com/zendframework/zend-navigation/issues/31).\r\nUnit test added.","created_at":"2016-06-11T08:02:06Z","updated_at":"2016-06-11T19:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab7b5288de03311a02c8f9ef246a91b2551b530c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-navigation/issues/35/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-navigation/statuses/ef2e8f4298f614b07e960c95382b78277b030336","head":{"label":"vaclavvanik:hotfix/31","ref":"hotfix/31","sha":"ef2e8f4298f614b07e960c95382b78277b030336","user":{"login":"vaclavvanik","id":3754860,"avatar_url":"https://avatars.githubusercontent.com/u/3754860?v=3","gravatar_id":"","url":"https://api.github.com/users/vaclavvanik","html_url":"https://github.com/vaclavvanik","followers_url":"https://api.github.com/users/vaclavvanik/followers","following_url":"https://api.github.com/users/vaclavvanik/following{/other_user}","gists_url":"https://api.github.com/users/vaclavvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/vaclavvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaclavvanik/subscriptions","organizations_url":"https://api.github.com/users/vaclavvanik/orgs","repos_url":"https://api.github.com/users/vaclavvanik/repos","events_url":"https://api.github.com/users/vaclavvanik/events{/privacy}","received_events_url":"https://api.github.com/users/vaclavvanik/received_events","type":"User","site_admin":false},"repo":{"id":60896392,"name":"zend-navigation","full_name":"vaclavvanik/zend-navigation","owner":{"login":"vaclavvanik","id":3754860,"avatar_url":"https://avatars.githubusercontent.com/u/3754860?v=3","gravatar_id":"","url":"https://api.github.com/users/vaclavvanik","html_url":"https://github.com/vaclavvanik","followers_url":"https://api.github.com/users/vaclavvanik/followers","following_url":"https://api.github.com/users/vaclavvanik/following{/other_user}","gists_url":"https://api.github.com/users/vaclavvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/vaclavvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaclavvanik/subscriptions","organizations_url":"https://api.github.com/users/vaclavvanik/orgs","repos_url":"https://api.github.com/users/vaclavvanik/repos","events_url":"https://api.github.com/users/vaclavvanik/events{/privacy}","received_events_url":"https://api.github.com/users/vaclavvanik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vaclavvanik/zend-navigation","description":"Navigation component from Zend Framework","fork":true,"url":"https://api.github.com/repos/vaclavvanik/zend-navigation","forks_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/forks","keys_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/teams","hooks_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/hooks","issue_events_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/events","assignees_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/tags","blobs_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/languages","stargazers_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/stargazers","contributors_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/contributors","subscribers_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/subscribers","subscription_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/subscription","commits_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/merges","archive_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/downloads","issues_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/labels{/name}","releases_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/vaclavvanik/zend-navigation/deployments","created_at":"2016-06-11T07:37:59Z","updated_at":"2016-06-11T07:38:00Z","pushed_at":"2016-06-11T17:20:54Z","git_url":"git://github.com/vaclavvanik/zend-navigation.git","ssh_url":"git@github.com:vaclavvanik/zend-navigation.git","clone_url":"https://github.com/vaclavvanik/zend-navigation.git","svn_url":"https://github.com/vaclavvanik/zend-navigation","homepage":"https://github.com/zendframework/zf2","size":2450,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"bcbdb3f177572cba39b883134a188f4b1862935a","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280820,"name":"zend-navigation","full_name":"zendframework/zend-navigation","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-navigation","description":"Navigation component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-navigation","forks_url":"https://api.github.com/repos/zendframework/zend-navigation/forks","keys_url":"https://api.github.com/repos/zendframework/zend-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-navigation/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-navigation/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-navigation/events","assignees_url":"https://api.github.com/repos/zendframework/zend-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-navigation/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-navigation/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-navigation/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-navigation/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-navigation/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-navigation/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-navigation/merges","archive_url":"https://api.github.com/repos/zendframework/zend-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-navigation/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-navigation/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-navigation/deployments","created_at":"2015-05-08T13:28:07Z","updated_at":"2016-05-26T20:47:59Z","pushed_at":"2016-06-11T17:20:56Z","git_url":"git://github.com/zendframework/zend-navigation.git","ssh_url":"git@github.com:zendframework/zend-navigation.git","clone_url":"https://github.com/zendframework/zend-navigation.git","svn_url":"https://github.com/zendframework/zend-navigation","homepage":"https://github.com/zendframework/zf2","size":2443,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35"},"html":{"href":"https://github.com/zendframework/zend-navigation/pull/35"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-navigation/issues/35"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-navigation/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-navigation/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-navigation/statuses/ef2e8f4298f614b07e960c95382b78277b030336"}}}}
{"actor":{"display_login":"weierophinney"}}