{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/54022178","id":54022178,"diff_hunk":"@@ -0,0 +1,122 @@\n+/*\n+ * Copyright (C) 2009-2016 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+package play.libs;\n+\n+import play.mvc.Results.*;\n+\n+import com.fasterxml.jackson.databind.JsonNode;\n+\n+import java.util.*;\n+import java.util.function.Consumer;\n+\n+/**\n+ * A Chunked stream sending Comet messages.\n+ *\n+ * @Deprecated Use the Comet streams class.\n+ */\n+@Deprecated\n+public abstract class LegacyComet extends Chunks<String> {","path":"framework/src/play-java/src/main/java/play/libs/LegacyComet.java","position":19,"original_position":19,"commit_id":"3cf7a6f44a14e57617abc710cda77e4b4c0d11df","original_commit_id":"a48f32aa51ea3e8bc474687e79e21db02438f774","user":{"login":"jroper","id":105833,"avatar_url":"https://avatars.githubusercontent.com/u/105833?v=3","gravatar_id":"","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"body":"It would be ugly in our code, but end users won't notice, since classes don't inherit deprecation.","created_at":"2016-02-24T22:57:37Z","updated_at":"2016-02-24T22:57:37Z","html_url":"https://github.com/playframework/playframework/pull/5707#discussion_r54022178","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/5707","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/54022178"},"html":{"href":"https://github.com/playframework/playframework/pull/5707#discussion_r54022178"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5707"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5707","id":60076233,"html_url":"https://github.com/playframework/playframework/pull/5707","diff_url":"https://github.com/playframework/playframework/pull/5707.diff","patch_url":"https://github.com/playframework/playframework/pull/5707.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5707","number":5707,"state":"open","locked":false,"title":"[WIP] Update Comet and EventSource APIs","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"## Fixes\r\n\r\nFixes https://github.com/playframework/playframework/issues/5602\r\n\r\nWIP -- ScalaComet.md / JavaComet.md docs need to be updated.\r\n\r\n## Purpose\r\n\r\nAdd `Comet.flow()` method for both Scala and Java APIs.  Renames old Comet class to `LegacyComet` class.  Cleans up EventSource Java API to reflect API.\r\n\r\n## Background Context\r\n\r\nComet needs updating to use Akka Streams.\r\n\r\n## References\r\n\r\nEventSource Streams API https://github.com/playframework/playframework/pull/5300\r\n","created_at":"2016-02-21T06:35:06Z","updated_at":"2016-02-24T22:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e6465c3d90ee8ec1a01f1aedfd409d0bb3ff64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/5707/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/5707/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5707/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/3cf7a6f44a14e57617abc710cda77e4b4c0d11df","head":{"label":"wsargent:add-comet-akkastreams","ref":"add-comet-akkastreams","sha":"3cf7a6f44a14e57617abc710cda77e4b4c0d11df","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"repo":{"id":11010009,"name":"playframework","full_name":"wsargent/playframework","owner":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsargent/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/wsargent/playframework","forks_url":"https://api.github.com/repos/wsargent/playframework/forks","keys_url":"https://api.github.com/repos/wsargent/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsargent/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsargent/playframework/teams","hooks_url":"https://api.github.com/repos/wsargent/playframework/hooks","issue_events_url":"https://api.github.com/repos/wsargent/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/wsargent/playframework/events","assignees_url":"https://api.github.com/repos/wsargent/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/wsargent/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/wsargent/playframework/tags","blobs_url":"https://api.github.com/repos/wsargent/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsargent/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsargent/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsargent/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsargent/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/wsargent/playframework/languages","stargazers_url":"https://api.github.com/repos/wsargent/playframework/stargazers","contributors_url":"https://api.github.com/repos/wsargent/playframework/contributors","subscribers_url":"https://api.github.com/repos/wsargent/playframework/subscribers","subscription_url":"https://api.github.com/repos/wsargent/playframework/subscription","commits_url":"https://api.github.com/repos/wsargent/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsargent/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsargent/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsargent/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wsargent/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/wsargent/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsargent/playframework/merges","archive_url":"https://api.github.com/repos/wsargent/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsargent/playframework/downloads","issues_url":"https://api.github.com/repos/wsargent/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/wsargent/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/wsargent/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/wsargent/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsargent/playframework/labels{/name}","releases_url":"https://api.github.com/repos/wsargent/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/wsargent/playframework/deployments","created_at":"2013-06-27T22:58:23Z","updated_at":"2015-04-15T18:06:45Z","pushed_at":"2016-02-24T05:39:25Z","git_url":"git://github.com/wsargent/playframework.git","ssh_url":"git@github.com:wsargent/playframework.git","clone_url":"https://github.com/wsargent/playframework.git","svn_url":"https://github.com/wsargent/playframework","homepage":"http://www.playframework.org/","size":81208,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"0f9e87862a9cd18ad2e867f65881657ba6f33822","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-02-24T21:59:56Z","pushed_at":"2016-02-24T22:40:48Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":92371,"stargazers_count":7485,"watchers_count":7485,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2633,"mirror_url":null,"open_issues_count":297,"forks":2633,"open_issues":297,"watchers":7485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5707"},"html":{"href":"https://github.com/playframework/playframework/pull/5707"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/5707"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/5707/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5707/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5707/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/3cf7a6f44a14e57617abc710cda77e4b4c0d11df"}}}}