{"action":"created","comment":{"url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/comments/94268009","pull_request_review_id":14799210,"id":94268009,"diff_hunk":"@@ -42,7 +42,7 @@ def call(env)\n             headers['Content-Type'] = Rack::Mime.mime_type(File.extname(path), 'text/plain')\n \n             # Update cache-control to add directive telling Rack::Deflate to leave it alone.\n-            cache_control = headers['Cache-Control'].try(:to_s).try(:downcase)\n+            cache_control = headers['Cache-Control']&.to_s&.downcase","path":"lib/heroku_rails_deflate/serve_zipped_assets.rb","position":14,"original_position":14,"commit_id":"8f5bd4181431e7bb82c5961dd0e2a1015b976634","original_commit_id":"8f5bd4181431e7bb82c5961dd0e2a1015b976634","user":{"login":"dcosson","id":708904,"avatar_url":"https://avatars.githubusercontent.com/u/708904?v=3","gravatar_id":"","url":"https://api.github.com/users/dcosson","html_url":"https://github.com/dcosson","followers_url":"https://api.github.com/users/dcosson/followers","following_url":"https://api.github.com/users/dcosson/following{/other_user}","gists_url":"https://api.github.com/users/dcosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dcosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcosson/subscriptions","organizations_url":"https://api.github.com/users/dcosson/orgs","repos_url":"https://api.github.com/users/dcosson/repos","events_url":"https://api.github.com/users/dcosson/events{/privacy}","received_events_url":"https://api.github.com/users/dcosson/received_events","type":"User","site_admin":false},"body":"I'm not a maintainer or anything but would love to see this merged as I'm working on migrating a codebase to rails 5 that uses it.\r\n\r\nI'm pretty sure this use of `try` still works fine in rails 5 though, so this change doesn't seem necessary and it would break support for ruby < 2.3 ","created_at":"2016-12-31T02:54:30Z","updated_at":"2016-12-31T02:54:30Z","html_url":"https://github.com/mattolson/heroku_rails_deflate/pull/24#discussion_r94268009","pull_request_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/comments/94268009"},"html":{"href":"https://github.com/mattolson/heroku_rails_deflate/pull/24#discussion_r94268009"},"pull_request":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24","id":99053813,"html_url":"https://github.com/mattolson/heroku_rails_deflate/pull/24","diff_url":"https://github.com/mattolson/heroku_rails_deflate/pull/24.diff","patch_url":"https://github.com/mattolson/heroku_rails_deflate/pull/24.patch","issue_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/24","number":24,"state":"open","locked":false,"title":"Support rails 5","user":{"login":"st0012","id":5079556,"avatar_url":"https://avatars.githubusercontent.com/u/5079556?v=3","gravatar_id":"","url":"https://api.github.com/users/st0012","html_url":"https://github.com/st0012","followers_url":"https://api.github.com/users/st0012/followers","following_url":"https://api.github.com/users/st0012/following{/other_user}","gists_url":"https://api.github.com/users/st0012/gists{/gist_id}","starred_url":"https://api.github.com/users/st0012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st0012/subscriptions","organizations_url":"https://api.github.com/users/st0012/orgs","repos_url":"https://api.github.com/users/st0012/repos","events_url":"https://api.github.com/users/st0012/events{/privacy}","received_events_url":"https://api.github.com/users/st0012/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-22T06:19:47Z","updated_at":"2016-12-31T02:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9b4b807e0cbc2a3f823bf4dedaa8e659262612f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24/commits","review_comments_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24/comments","review_comment_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/24/comments","statuses_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/statuses/8f5bd4181431e7bb82c5961dd0e2a1015b976634","head":{"label":"st0012:rails5","ref":"rails5","sha":"8f5bd4181431e7bb82c5961dd0e2a1015b976634","user":{"login":"st0012","id":5079556,"avatar_url":"https://avatars.githubusercontent.com/u/5079556?v=3","gravatar_id":"","url":"https://api.github.com/users/st0012","html_url":"https://github.com/st0012","followers_url":"https://api.github.com/users/st0012/followers","following_url":"https://api.github.com/users/st0012/following{/other_user}","gists_url":"https://api.github.com/users/st0012/gists{/gist_id}","starred_url":"https://api.github.com/users/st0012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st0012/subscriptions","organizations_url":"https://api.github.com/users/st0012/orgs","repos_url":"https://api.github.com/users/st0012/repos","events_url":"https://api.github.com/users/st0012/events{/privacy}","received_events_url":"https://api.github.com/users/st0012/received_events","type":"User","site_admin":false},"repo":{"id":77111561,"name":"heroku_rails_deflate","full_name":"st0012/heroku_rails_deflate","owner":{"login":"st0012","id":5079556,"avatar_url":"https://avatars.githubusercontent.com/u/5079556?v=3","gravatar_id":"","url":"https://api.github.com/users/st0012","html_url":"https://github.com/st0012","followers_url":"https://api.github.com/users/st0012/followers","following_url":"https://api.github.com/users/st0012/following{/other_user}","gists_url":"https://api.github.com/users/st0012/gists{/gist_id}","starred_url":"https://api.github.com/users/st0012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st0012/subscriptions","organizations_url":"https://api.github.com/users/st0012/orgs","repos_url":"https://api.github.com/users/st0012/repos","events_url":"https://api.github.com/users/st0012/events{/privacy}","received_events_url":"https://api.github.com/users/st0012/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/st0012/heroku_rails_deflate","description":"Activate Rack::Deflate and serve up precompiled, gzipped assets on Heroku","fork":true,"url":"https://api.github.com/repos/st0012/heroku_rails_deflate","forks_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/forks","keys_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/teams","hooks_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/hooks","issue_events_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/issues/events{/number}","events_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/events","assignees_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/assignees{/user}","branches_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/branches{/branch}","tags_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/tags","blobs_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/git/refs{/sha}","trees_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/statuses/{sha}","languages_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/languages","stargazers_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/stargazers","contributors_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/contributors","subscribers_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/subscribers","subscription_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/subscription","commits_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/commits{/sha}","git_commits_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/git/commits{/sha}","comments_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/comments{/number}","issue_comment_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/issues/comments{/number}","contents_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/contents/{+path}","compare_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/merges","archive_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/downloads","issues_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/issues{/number}","pulls_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/pulls{/number}","milestones_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/milestones{/number}","notifications_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/labels{/name}","releases_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/releases{/id}","deployments_url":"https://api.github.com/repos/st0012/heroku_rails_deflate/deployments","created_at":"2016-12-22T04:17:57Z","updated_at":"2016-12-22T04:17:59Z","pushed_at":"2016-12-22T06:19:24Z","git_url":"git://github.com/st0012/heroku_rails_deflate.git","ssh_url":"git@github.com:st0012/heroku_rails_deflate.git","clone_url":"https://github.com/st0012/heroku_rails_deflate.git","svn_url":"https://github.com/st0012/heroku_rails_deflate","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattolson:master","ref":"master","sha":"b15f60ae427272b3d5ea13daad2f77190098ba84","user":{"login":"mattolson","id":168657,"avatar_url":"https://avatars.githubusercontent.com/u/168657?v=3","gravatar_id":"","url":"https://api.github.com/users/mattolson","html_url":"https://github.com/mattolson","followers_url":"https://api.github.com/users/mattolson/followers","following_url":"https://api.github.com/users/mattolson/following{/other_user}","gists_url":"https://api.github.com/users/mattolson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattolson/subscriptions","organizations_url":"https://api.github.com/users/mattolson/orgs","repos_url":"https://api.github.com/users/mattolson/repos","events_url":"https://api.github.com/users/mattolson/events{/privacy}","received_events_url":"https://api.github.com/users/mattolson/received_events","type":"User","site_admin":false},"repo":{"id":9177655,"name":"heroku_rails_deflate","full_name":"mattolson/heroku_rails_deflate","owner":{"login":"mattolson","id":168657,"avatar_url":"https://avatars.githubusercontent.com/u/168657?v=3","gravatar_id":"","url":"https://api.github.com/users/mattolson","html_url":"https://github.com/mattolson","followers_url":"https://api.github.com/users/mattolson/followers","following_url":"https://api.github.com/users/mattolson/following{/other_user}","gists_url":"https://api.github.com/users/mattolson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattolson/subscriptions","organizations_url":"https://api.github.com/users/mattolson/orgs","repos_url":"https://api.github.com/users/mattolson/repos","events_url":"https://api.github.com/users/mattolson/events{/privacy}","received_events_url":"https://api.github.com/users/mattolson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattolson/heroku_rails_deflate","description":"Activate Rack::Deflate and serve up precompiled, gzipped assets on Heroku","fork":false,"url":"https://api.github.com/repos/mattolson/heroku_rails_deflate","forks_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/forks","keys_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/teams","hooks_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/hooks","issue_events_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/events{/number}","events_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/events","assignees_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/assignees{/user}","branches_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/branches{/branch}","tags_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/tags","blobs_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/statuses/{sha}","languages_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/languages","stargazers_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/stargazers","contributors_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/contributors","subscribers_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/subscribers","subscription_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/subscription","commits_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/contents/{+path}","compare_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/merges","archive_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/downloads","issues_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues{/number}","pulls_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls{/number}","milestones_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/milestones{/number}","notifications_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/labels{/name}","releases_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/releases{/id}","deployments_url":"https://api.github.com/repos/mattolson/heroku_rails_deflate/deployments","created_at":"2013-04-02T19:06:08Z","updated_at":"2016-12-29T23:17:52Z","pushed_at":"2016-12-22T06:19:48Z","git_url":"git://github.com/mattolson/heroku_rails_deflate.git","ssh_url":"git@github.com:mattolson/heroku_rails_deflate.git","clone_url":"https://github.com/mattolson/heroku_rails_deflate.git","svn_url":"https://github.com/mattolson/heroku_rails_deflate","homepage":null,"size":375,"stargazers_count":108,"watchers_count":108,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24"},"html":{"href":"https://github.com/mattolson/heroku_rails_deflate/pull/24"},"issue":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/24"},"comments":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/mattolson/heroku_rails_deflate/statuses/8f5bd4181431e7bb82c5961dd0e2a1015b976634"}}}}
{"actor":{"display_login":"dcosson"}}