{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/79304930","id":79304930,"diff_hunk":"@@ -503,12 +503,12 @@ function _dump_function(f::ANY, t::ANY, native::Bool, wrapper::Bool, strip_ir_me\n     meth = func_for_method_checked(meth, tt)\n     linfo = ccall(:jl_specializations_get_linfo, Ref{Core.MethodInstance}, (Any, Any, Any), meth, tt, env)\n     # get the code for it\n-    return _dump_function(linfo, native, wrapper, strip_ir_metadata, dump_module, asmvariant)\n+    return _dump_function(linfo, native, wrapper, strip_ir_metadata, dump_module, syntax)\n end\n \n-function _dump_function(linfo::Core.MethodInstance, native::Bool, wrapper::Bool, strip_ir_metadata::Bool, dump_module::Bool, asmvariant::Symbol=:att)\n-    if asmvariant != :att && asmvariant != :intel\n-       throw(ErrorException(\"asmvariant must be either :intel or :att\"))\n+function _dump_function(linfo::Core.MethodInstance, native::Bool, wrapper::Bool, strip_ir_metadata::Bool, dump_module::Bool, syntax::Symbol=:att)\n+    if syntax != :att && syntax != :intel\n+       throw(ErrorException(\"'syntax' must be either :intel or :att\"))","path":"base/reflection.jl","position":null,"original_position":22,"commit_id":"51568e57badc7ebcd80f5c51e857a143f84be73c","original_commit_id":"1d7b1bb12f3ea1af12222f9eed65bc919d5537f6","user":{"login":"citisolo","id":3611437,"avatar_url":"https://avatars.githubusercontent.com/u/3611437?v=3","gravatar_id":"","url":"https://api.github.com/users/citisolo","html_url":"https://github.com/citisolo","followers_url":"https://api.github.com/users/citisolo/followers","following_url":"https://api.github.com/users/citisolo/following{/other_user}","gists_url":"https://api.github.com/users/citisolo/gists{/gist_id}","starred_url":"https://api.github.com/users/citisolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citisolo/subscriptions","organizations_url":"https://api.github.com/users/citisolo/orgs","repos_url":"https://api.github.com/users/citisolo/repos","events_url":"https://api.github.com/users/citisolo/events{/privacy}","received_events_url":"https://api.github.com/users/citisolo/received_events","type":"User","site_admin":false},"body":"Sorry missed that one","created_at":"2016-09-18T12:46:09Z","updated_at":"2016-09-18T12:46:09Z","html_url":"https://github.com/JuliaLang/julia/pull/18565#discussion_r79304930","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18565","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/79304930"},"html":{"href":"https://github.com/JuliaLang/julia/pull/18565#discussion_r79304930"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18565"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/18565","id":85685494,"html_url":"https://github.com/JuliaLang/julia/pull/18565","diff_url":"https://github.com/JuliaLang/julia/pull/18565.diff","patch_url":"https://github.com/JuliaLang/julia/pull/18565.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/18565","number":18565,"state":"open","locked":false,"title":"Fix for 17139","user":{"login":"citisolo","id":3611437,"avatar_url":"https://avatars.githubusercontent.com/u/3611437?v=3","gravatar_id":"","url":"https://api.github.com/users/citisolo","html_url":"https://github.com/citisolo","followers_url":"https://api.github.com/users/citisolo/followers","following_url":"https://api.github.com/users/citisolo/following{/other_user}","gists_url":"https://api.github.com/users/citisolo/gists{/gist_id}","starred_url":"https://api.github.com/users/citisolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citisolo/subscriptions","organizations_url":"https://api.github.com/users/citisolo/orgs","repos_url":"https://api.github.com/users/citisolo/repos","events_url":"https://api.github.com/users/citisolo/events{/privacy}","received_events_url":"https://api.github.com/users/citisolo/received_events","type":"User","site_admin":false},"body":"Update from previously closed PR solving issue 17139 enabling support for specifying the flavour of syntax desired for native code dump (code_native)","created_at":"2016-09-17T20:04:17Z","updated_at":"2016-09-18T12:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"324542325275390d201181339c8d2ebd6cedd5f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18565/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18565/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/18565/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/51568e57badc7ebcd80f5c51e857a143f84be73c","head":{"label":"citisolo:fix_for_17139","ref":"fix_for_17139","sha":"51568e57badc7ebcd80f5c51e857a143f84be73c","user":{"login":"citisolo","id":3611437,"avatar_url":"https://avatars.githubusercontent.com/u/3611437?v=3","gravatar_id":"","url":"https://api.github.com/users/citisolo","html_url":"https://github.com/citisolo","followers_url":"https://api.github.com/users/citisolo/followers","following_url":"https://api.github.com/users/citisolo/following{/other_user}","gists_url":"https://api.github.com/users/citisolo/gists{/gist_id}","starred_url":"https://api.github.com/users/citisolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citisolo/subscriptions","organizations_url":"https://api.github.com/users/citisolo/orgs","repos_url":"https://api.github.com/users/citisolo/repos","events_url":"https://api.github.com/users/citisolo/events{/privacy}","received_events_url":"https://api.github.com/users/citisolo/received_events","type":"User","site_admin":false},"repo":{"id":68245162,"name":"julia","full_name":"citisolo/julia","owner":{"login":"citisolo","id":3611437,"avatar_url":"https://avatars.githubusercontent.com/u/3611437?v=3","gravatar_id":"","url":"https://api.github.com/users/citisolo","html_url":"https://github.com/citisolo","followers_url":"https://api.github.com/users/citisolo/followers","following_url":"https://api.github.com/users/citisolo/following{/other_user}","gists_url":"https://api.github.com/users/citisolo/gists{/gist_id}","starred_url":"https://api.github.com/users/citisolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citisolo/subscriptions","organizations_url":"https://api.github.com/users/citisolo/orgs","repos_url":"https://api.github.com/users/citisolo/repos","events_url":"https://api.github.com/users/citisolo/events{/privacy}","received_events_url":"https://api.github.com/users/citisolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/citisolo/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/citisolo/julia","forks_url":"https://api.github.com/repos/citisolo/julia/forks","keys_url":"https://api.github.com/repos/citisolo/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citisolo/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citisolo/julia/teams","hooks_url":"https://api.github.com/repos/citisolo/julia/hooks","issue_events_url":"https://api.github.com/repos/citisolo/julia/issues/events{/number}","events_url":"https://api.github.com/repos/citisolo/julia/events","assignees_url":"https://api.github.com/repos/citisolo/julia/assignees{/user}","branches_url":"https://api.github.com/repos/citisolo/julia/branches{/branch}","tags_url":"https://api.github.com/repos/citisolo/julia/tags","blobs_url":"https://api.github.com/repos/citisolo/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citisolo/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citisolo/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/citisolo/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citisolo/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/citisolo/julia/languages","stargazers_url":"https://api.github.com/repos/citisolo/julia/stargazers","contributors_url":"https://api.github.com/repos/citisolo/julia/contributors","subscribers_url":"https://api.github.com/repos/citisolo/julia/subscribers","subscription_url":"https://api.github.com/repos/citisolo/julia/subscription","commits_url":"https://api.github.com/repos/citisolo/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/citisolo/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/citisolo/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/citisolo/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/citisolo/julia/contents/{+path}","compare_url":"https://api.github.com/repos/citisolo/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citisolo/julia/merges","archive_url":"https://api.github.com/repos/citisolo/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citisolo/julia/downloads","issues_url":"https://api.github.com/repos/citisolo/julia/issues{/number}","pulls_url":"https://api.github.com/repos/citisolo/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/citisolo/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/citisolo/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citisolo/julia/labels{/name}","releases_url":"https://api.github.com/repos/citisolo/julia/releases{/id}","deployments_url":"https://api.github.com/repos/citisolo/julia/deployments","created_at":"2016-09-14T21:33:25Z","updated_at":"2016-09-14T21:33:34Z","pushed_at":"2016-09-18T12:27:50Z","git_url":"git://github.com/citisolo/julia.git","ssh_url":"git@github.com:citisolo/julia.git","clone_url":"https://github.com/citisolo/julia.git","svn_url":"https://github.com/citisolo/julia","homepage":"http://julialang.org/","size":98656,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"45bc17d41b40f271dd5ebb2357e7f3564f969007","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-09-18T02:50:40Z","pushed_at":"2016-09-18T12:27:51Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":422345,"stargazers_count":7512,"watchers_count":7512,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1757,"mirror_url":null,"open_issues_count":1984,"forks":1757,"open_issues":1984,"watchers":7512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18565"},"html":{"href":"https://github.com/JuliaLang/julia/pull/18565"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18565"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18565/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18565/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18565/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/51568e57badc7ebcd80f5c51e857a143f84be73c"}}}}
{"actor":{"display_login":"citisolo"}}