{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/59225214","id":59225214,"diff_hunk":"@@ -0,0 +1,18 @@\n+Manifest-Version: 1.0\n+Bundle-ManifestVersion: 2\n+Bundle-Name: Eclipse SmartHome Core Persistence Rest\n+Bundle-SymbolicName: org.eclipse.smarthome.io.rest.persistence\n+Bundle-Version: 0.8.0.qualifier\n+Bundle-Vendor: Eclipse.org/SmartHome\n+Bundle-RequiredExecutionEnvironment: JavaSE-1.7\n+Import-Package: org.eclipse.smarthome.core.items,","path":"bundles/io/org.eclipse.smarthome.io.rest.persistence/META-INF/MANIFEST.MF","position":8,"original_position":8,"commit_id":"e222554c508d451477f7dc476f49452a55e0e88a","original_commit_id":"e222554c508d451477f7dc476f49452a55e0e88a","user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?v=3","gravatar_id":"","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"body":"Can you use alphabetical order for all imports?\r\nThat is not a must, but could improve readability.","created_at":"2016-04-11T15:30:11Z","updated_at":"2016-04-11T15:30:11Z","html_url":"https://github.com/eclipse/smarthome/pull/1365#discussion_r59225214","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1365","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/59225214"},"html":{"href":"https://github.com/eclipse/smarthome/pull/1365#discussion_r59225214"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1365"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/1365","id":66009381,"html_url":"https://github.com/eclipse/smarthome/pull/1365","diff_url":"https://github.com/eclipse/smarthome/pull/1365.diff","patch_url":"https://github.com/eclipse/smarthome/pull/1365.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/1365","number":1365,"state":"open","locked":false,"title":"factored out persistence REST resources into own bundle","user":{"login":"sjka","id":2592443,"avatar_url":"https://avatars.githubusercontent.com/u/2592443?v=3","gravatar_id":"","url":"https://api.github.com/users/sjka","html_url":"https://github.com/sjka","followers_url":"https://api.github.com/users/sjka/followers","following_url":"https://api.github.com/users/sjka/following{/other_user}","gists_url":"https://api.github.com/users/sjka/gists{/gist_id}","starred_url":"https://api.github.com/users/sjka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjka/subscriptions","organizations_url":"https://api.github.com/users/sjka/orgs","repos_url":"https://api.github.com/users/sjka/repos","events_url":"https://api.github.com/users/sjka/events{/privacy}","received_events_url":"https://api.github.com/users/sjka/received_events","type":"User","site_admin":false},"body":"I've been running into weird problems with the REST resources inside the core.persistence bundle. Whenever io.rest gets installed _after_ persistence.core, then DS attempts to activate the persistence rest resource component, failing badly as the RestResource base class cannot be found. \r\n\r\nWhen the io.rest bundle gets installer later on, this issue does not fix itself, as the OSGi spec does not require any existing bundles to be re-resolved only to satisfy _optional_ dependencies.\r\n\r\nSo although I know it's perfectly legal as it is, I would still suggest to factor out the rest dependencies from the core for the above reasons.\r\n\r\nSigned-off-by: Simon Kaufmann <simon.kfm@googlemail.com>","created_at":"2016-04-11T15:05:15Z","updated_at":"2016-04-11T15:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c1faa5c073d401c8d9064b7511ce308b134bbf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1365/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1365/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/1365/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/e222554c508d451477f7dc476f49452a55e0e88a","head":{"label":"sjka:separatePersitenceRest","ref":"separatePersitenceRest","sha":"e222554c508d451477f7dc476f49452a55e0e88a","user":{"login":"sjka","id":2592443,"avatar_url":"https://avatars.githubusercontent.com/u/2592443?v=3","gravatar_id":"","url":"https://api.github.com/users/sjka","html_url":"https://github.com/sjka","followers_url":"https://api.github.com/users/sjka/followers","following_url":"https://api.github.com/users/sjka/following{/other_user}","gists_url":"https://api.github.com/users/sjka/gists{/gist_id}","starred_url":"https://api.github.com/users/sjka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjka/subscriptions","organizations_url":"https://api.github.com/users/sjka/orgs","repos_url":"https://api.github.com/users/sjka/repos","events_url":"https://api.github.com/users/sjka/events{/privacy}","received_events_url":"https://api.github.com/users/sjka/received_events","type":"User","site_admin":false},"repo":{"id":37527739,"name":"smarthome","full_name":"sjka/smarthome","owner":{"login":"sjka","id":2592443,"avatar_url":"https://avatars.githubusercontent.com/u/2592443?v=3","gravatar_id":"","url":"https://api.github.com/users/sjka","html_url":"https://github.com/sjka","followers_url":"https://api.github.com/users/sjka/followers","following_url":"https://api.github.com/users/sjka/following{/other_user}","gists_url":"https://api.github.com/users/sjka/gists{/gist_id}","starred_url":"https://api.github.com/users/sjka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjka/subscriptions","organizations_url":"https://api.github.com/users/sjka/orgs","repos_url":"https://api.github.com/users/sjka/repos","events_url":"https://api.github.com/users/sjka/events{/privacy}","received_events_url":"https://api.github.com/users/sjka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjka/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/sjka/smarthome","forks_url":"https://api.github.com/repos/sjka/smarthome/forks","keys_url":"https://api.github.com/repos/sjka/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjka/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjka/smarthome/teams","hooks_url":"https://api.github.com/repos/sjka/smarthome/hooks","issue_events_url":"https://api.github.com/repos/sjka/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/sjka/smarthome/events","assignees_url":"https://api.github.com/repos/sjka/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/sjka/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/sjka/smarthome/tags","blobs_url":"https://api.github.com/repos/sjka/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjka/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjka/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjka/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjka/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/sjka/smarthome/languages","stargazers_url":"https://api.github.com/repos/sjka/smarthome/stargazers","contributors_url":"https://api.github.com/repos/sjka/smarthome/contributors","subscribers_url":"https://api.github.com/repos/sjka/smarthome/subscribers","subscription_url":"https://api.github.com/repos/sjka/smarthome/subscription","commits_url":"https://api.github.com/repos/sjka/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjka/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjka/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjka/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjka/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/sjka/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjka/smarthome/merges","archive_url":"https://api.github.com/repos/sjka/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjka/smarthome/downloads","issues_url":"https://api.github.com/repos/sjka/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/sjka/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/sjka/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/sjka/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjka/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/sjka/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/sjka/smarthome/deployments","created_at":"2015-06-16T12:08:22Z","updated_at":"2015-06-16T12:08:26Z","pushed_at":"2016-04-11T15:28:52Z","git_url":"git://github.com/sjka/smarthome.git","ssh_url":"git@github.com:sjka/smarthome.git","clone_url":"https://github.com/sjka/smarthome.git","svn_url":"https://github.com/sjka/smarthome","homepage":null,"size":17611,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"1a7473c662fea539d2a4a0cb118379355f6f0a87","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2016-04-08T15:19:31Z","pushed_at":"2016-04-11T15:28:53Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":null,"size":29951,"stargazers_count":279,"watchers_count":279,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":182,"forks":275,"open_issues":182,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1365"},"html":{"href":"https://github.com/eclipse/smarthome/pull/1365"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1365"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1365/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1365/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1365/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/e222554c508d451477f7dc476f49452a55e0e88a"}}}}