{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3243","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3243/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3243/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3243/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/3243","id":188314905,"number":3243,"title":"Fix make exporters compilation","user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"labels":[{"id":426496706,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/ready%20for%20merge","name":"ready for merge","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-11-09T18:13:11Z","updated_at":"2016-11-14T16:40:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3243","html_url":"https://github.com/ARMmbed/mbed-os/pull/3243","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3243.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3243.patch"},"body":"## Description\r\nIAR requires all pre-built libraries that are linked in to be prefixed with lib. This is a problem when used with the make exporters for a few platforms since the libraries do not have this prefix. This standardizes the prefix of lib for all pre-built libraries in the codebase.\r\n\r\nThere was also an assembly file that was using mixed notation for comments, switching between `; <COMMENT>` and `/* <COMMENT> */`. This was causing issues for make with ARM compiler, so I've changed it to use only `;`.\r\n\r\n\r\n## Status\r\n**READY**\r\n\r\n\r\n## Migrations\r\nIf this PR changes any APIs or behaviors, give a short description of what *API users* should do when this PR is merged.\r\n\r\nNO\r\n\r\n## Todos\r\n- [x] PR tests\r\n- [x] Exporter tests (**MAINTAINERS**: please hold off on this. I will trigger this test myself)\r\n- [x] Review by @mmorenobarm (renaming cordio libraries)\r\n- [x] Review by @andreaslarssonublox (renaming ublox odin w2 driver)\r\n- [x] Review by @jeremybrodt (renaming Maxim BLE libraries and changing comment notation in Maxim target startup file)\r\n\r\n\r\n## Steps to test or reproduce\r\nCurrently if you try and export [mbed-os-example-blinky](https://github.com/ARMmbed/mbed-os-example-blinky) and use the `make_iar` exporter, you'll receive an error for the following platforms: MAX32620HSP, MAXWSNENV, UBLOX_EVK_ODIN_W2.\r\n\r\n```\r\n$ mbed export -m MAX32620HSP -i make_iar\r\n$ make\r\n\"C:\\Jenkins\\workspace\\bm_wrap\\983\\examples\\mbed-os-example-blinky\\mbed-os\\features\\netsocket\\SocketAddress.cpp\",70  Warning[Pe721]: nonstandard format string conversion\r\nFatal error[Ms007]: could not open file \"libexactLE.a\"\r\n            Directories searched:\r\n              C:\\Jenkins\\workspace\\bm_wrap\\983\\examples\\mbed-os-example-blinky\\\r\n                      .build\r\n              C:\\Jenkins\\workspace\\bm_wrap\\983\\examples\\mbed-os-example-blinky\\\r\n                      mbed-os\\targets\\TARGET_Maxim\\TARGET_MAX32620\\TOOLCHAIN_IA\r\n                      R\r\nFatal error detected, aborting.\r\n```\r\n\r\nAfter this PR, the example will compile correctly with Make."},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/260387957","html_url":"https://github.com/ARMmbed/mbed-os/pull/3243#issuecomment-260387957","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3243","id":260387957,"user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T16:40:02Z","updated_at":"2016-11-14T16:40:02Z","body":"It'd be something along the lines of `mbed compile --library`"}}
{"actor":{"display_login":"bridadan"}}