{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/82346761","pull_request_review_id":2282938,"id":82346761,"diff_hunk":"@@ -0,0 +1,140 @@\n+/*\n+Copyright 2015 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package e2e\n+\n+import (\n+\t\"fmt\"\n+\t\"os/exec\"\n+\t\"strconv\"\n+\t\"strings\"\n+\t\"time\"\n+\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/util/json\"\n+\t\"k8s.io/kubernetes/test/e2e/framework\"\n+\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+)\n+\n+var _ = framework.KubeDescribe(\"Cluster level logging using GCL\", func() {\n+\tf := framework.NewDefaultFramework(\"gcl-logging\")\n+\n+\tBeforeEach(func() {\n+\t\t// TODO (crassirostris): Expand to GKE once the test is stable\n+\t\tframework.SkipUnlessProviderIs(\"gce\")\n+\t})\n+\n+\tIt(\"should check that logs from containers are ingested in GCL\", func() {\n+\t\tsynthLoggerPodName := f.Namespace.Name + \"-synthlogger\"\n+\n+\t\tBy(\"Creating synthetic logger\")\n+\t\tcreateSynthLogger(f, synthLoggerPodName, expectedLinesCount)\n+\t\tdefer f.PodClient().Delete(synthLoggerPodName, &api.DeleteOptions{})","path":"test/e2e/cluster_logging_gcl.go","position":47,"original_position":47,"commit_id":"0e9f02d62352602910053ad066416ce26125a95c","original_commit_id":"0e9f02d62352602910053ad066416ce26125a95c","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"body":"How about waiting for pod to complete successfully?","created_at":"2016-10-07T08:20:47Z","updated_at":"2016-10-07T08:21:34Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33278#discussion_r82346761","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/82346761"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33278#discussion_r82346761"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278","id":86356552,"html_url":"https://github.com/kubernetes/kubernetes/pull/33278","diff_url":"https://github.com/kubernetes/kubernetes/pull/33278.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33278.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33278","number":33278,"state":"open","locked":false,"title":"Add gcl cluster logging test","user":{"login":"Crassirostris","id":1756505,"avatar_url":"https://avatars.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/Crassirostris","html_url":"https://github.com/Crassirostris","followers_url":"https://api.github.com/users/Crassirostris/followers","following_url":"https://api.github.com/users/Crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/Crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crassirostris/subscriptions","organizations_url":"https://api.github.com/users/Crassirostris/orgs","repos_url":"https://api.github.com/users/Crassirostris/repos","events_url":"https://api.github.com/users/Crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/Crassirostris/received_events","type":"User","site_admin":false},"body":"This PR changes default logging destination for tests to gcp and adds test for cluster logging using google cloud logging\r\n\r\nFix #20760\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33278)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-09-22T15:09:16Z","updated_at":"2016-10-07T08:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3de785beee05b27d2fc9c61f22424428b85d539a","assignee":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"assignees":[{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33278/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0e9f02d62352602910053ad066416ce26125a95c","head":{"label":"Crassirostris:gcl-e2e-test","ref":"gcl-e2e-test","sha":"0e9f02d62352602910053ad066416ce26125a95c","user":{"login":"Crassirostris","id":1756505,"avatar_url":"https://avatars.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/Crassirostris","html_url":"https://github.com/Crassirostris","followers_url":"https://api.github.com/users/Crassirostris/followers","following_url":"https://api.github.com/users/Crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/Crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crassirostris/subscriptions","organizations_url":"https://api.github.com/users/Crassirostris/orgs","repos_url":"https://api.github.com/users/Crassirostris/repos","events_url":"https://api.github.com/users/Crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/Crassirostris/received_events","type":"User","site_admin":false},"repo":{"id":68590036,"name":"kubernetes","full_name":"Crassirostris/kubernetes","owner":{"login":"Crassirostris","id":1756505,"avatar_url":"https://avatars.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/Crassirostris","html_url":"https://github.com/Crassirostris","followers_url":"https://api.github.com/users/Crassirostris/followers","following_url":"https://api.github.com/users/Crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/Crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crassirostris/subscriptions","organizations_url":"https://api.github.com/users/Crassirostris/orgs","repos_url":"https://api.github.com/users/Crassirostris/repos","events_url":"https://api.github.com/users/Crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/Crassirostris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crassirostris/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/Crassirostris/kubernetes","forks_url":"https://api.github.com/repos/Crassirostris/kubernetes/forks","keys_url":"https://api.github.com/repos/Crassirostris/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crassirostris/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crassirostris/kubernetes/teams","hooks_url":"https://api.github.com/repos/Crassirostris/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Crassirostris/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Crassirostris/kubernetes/events","assignees_url":"https://api.github.com/repos/Crassirostris/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Crassirostris/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Crassirostris/kubernetes/tags","blobs_url":"https://api.github.com/repos/Crassirostris/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crassirostris/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crassirostris/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crassirostris/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crassirostris/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Crassirostris/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Crassirostris/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Crassirostris/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Crassirostris/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Crassirostris/kubernetes/subscription","commits_url":"https://api.github.com/repos/Crassirostris/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crassirostris/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crassirostris/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crassirostris/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crassirostris/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Crassirostris/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crassirostris/kubernetes/merges","archive_url":"https://api.github.com/repos/Crassirostris/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crassirostris/kubernetes/downloads","issues_url":"https://api.github.com/repos/Crassirostris/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Crassirostris/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Crassirostris/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Crassirostris/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crassirostris/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Crassirostris/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Crassirostris/kubernetes/deployments","created_at":"2016-09-19T09:23:31Z","updated_at":"2016-09-19T09:24:05Z","pushed_at":"2016-10-05T17:47:54Z","git_url":"git://github.com/Crassirostris/kubernetes.git","ssh_url":"git@github.com:Crassirostris/kubernetes.git","clone_url":"https://github.com/Crassirostris/kubernetes.git","svn_url":"https://github.com/Crassirostris/kubernetes","homepage":"http://kubernetes.io","size":333016,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5a59f3bbccd0671b844f95bca7d5548ad4723151","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-07T07:51:54Z","pushed_at":"2016-10-07T07:50:30Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":578659,"stargazers_count":17359,"watchers_count":17359,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5632,"mirror_url":null,"open_issues_count":4862,"forks":5632,"open_issues":4862,"watchers":17359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33278"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33278"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33278/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33278/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0e9f02d62352602910053ad066416ce26125a95c"}}}}
{"actor":{"display_login":"piosz"}}