{"action":"created","issue":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/744","repository_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com","labels_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/744/labels{/name}","comments_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/744/comments","events_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/744/events","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/744","id":169615635,"number":744,"title":"Update git submodules when CMake runs","user":{"login":"asarium","id":1013983,"avatar_url":"https://avatars.githubusercontent.com/u/1013983?v=3","gravatar_id":"","url":"https://api.github.com/users/asarium","html_url":"https://github.com/asarium","followers_url":"https://api.github.com/users/asarium/followers","following_url":"https://api.github.com/users/asarium/following{/other_user}","gists_url":"https://api.github.com/users/asarium/gists{/gist_id}","starred_url":"https://api.github.com/users/asarium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asarium/subscriptions","organizations_url":"https://api.github.com/users/asarium/orgs","repos_url":"https://api.github.com/users/asarium/repos","events_url":"https://api.github.com/users/asarium/events{/privacy}","received_events_url":"https://api.github.com/users/asarium/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-05T14:09:06Z","updated_at":"2016-08-05T14:25:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/pulls/744","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/744","diff_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/744.diff","patch_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/744.patch"},"body":"For this to work CMake needs to find a git executable. If it isn't found\r\nthen it's not an error but the submodules won't be updated."},"comment":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/comments/237864563","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/744#issuecomment-237864563","issue_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/744","id":237864563,"user":{"login":"chief1983","id":145825,"avatar_url":"https://avatars.githubusercontent.com/u/145825?v=3","gravatar_id":"","url":"https://api.github.com/users/chief1983","html_url":"https://github.com/chief1983","followers_url":"https://api.github.com/users/chief1983/followers","following_url":"https://api.github.com/users/chief1983/following{/other_user}","gists_url":"https://api.github.com/users/chief1983/gists{/gist_id}","starred_url":"https://api.github.com/users/chief1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chief1983/subscriptions","organizations_url":"https://api.github.com/users/chief1983/orgs","repos_url":"https://api.github.com/users/chief1983/repos","events_url":"https://api.github.com/users/chief1983/events{/privacy}","received_events_url":"https://api.github.com/users/chief1983/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T14:25:44Z","updated_at":"2016-08-05T14:25:44Z","body":"Not sure I'm a big fan of this concept.  I understand it's to make things a little easier on people but I think getting familiarity with submodules is just a growing pain the team will get through quickly enough.  The reason I'm not such a big fan is I don't think building our code should ever involve any remote operations that the user may or may not even notice are happening.  What if a submodule actually causes breakage of our own code configuring correctly due to an update (unlikely I know but stuff happens), and the developer doesn't think to look into that, instead going insane trying to find what change he made or what update on our end cause it to break on his machine?\r\n\r\nAlso, wouldn't this affect source code exports?  Those should never even expect that git is installed, but I'm actually not sure those exports would even have the submodules or not.  I haven't tried a github source download since the merge yet."}}
{"actor":{"display_login":"chief1983"}}