{"action":"created","comment":{"url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/comments/59190368","id":59190368,"diff_hunk":"@@ -0,0 +1,184 @@\n+using System;\n+using System.IO;\n+using System.Runtime.InteropServices;\n+\n+namespace TarantoolDnx.MsgPack\n+{\n+    internal class FloatConverter : IMsgPackConverter<float>, IMsgPackConverter<double>\n+    {\n+        public void Write(float value, Stream stream, MsgPackSettings settings)\n+        {\n+            var binary = new FloatBinary(value);\n+            stream.WriteByte((byte) DataTypes.Single);\n+            if (BitConverter.IsLittleEndian)\n+            {\n+                stream.WriteByte(binary.byte3);\n+                stream.WriteByte(binary.byte2);\n+                stream.WriteByte(binary.byte1);\n+                stream.WriteByte(binary.byte0);\n+            }\n+            else\n+            {\n+                stream.WriteByte(binary.byte0);\n+                stream.WriteByte(binary.byte1);\n+                stream.WriteByte(binary.byte2);\n+                stream.WriteByte(binary.byte3);\n+            }\n+        }\n+\n+        float IMsgPackConverter<float>.Read(Stream stream, MsgPackSettings settings, Func<float> creator)\n+        {\n+            var type = (DataTypes)stream.ReadByte();\n+\n+            if (type != DataTypes.Single)\n+                throw ExceptionUtils.BadTypeException(type, DataTypes.Single);\n+\n+            return ReadFloat(stream);\n+        }\n+\n+        public void Write(double value, Stream stream, MsgPackSettings settings)\n+        {\n+            var binary = new DoubleBinary(value);\n+            stream.WriteByte((byte) DataTypes.Double);\n+            if (BitConverter.IsLittleEndian)\n+            {\n+                stream.WriteByte(binary.byte7);\n+                stream.WriteByte(binary.byte6);\n+                stream.WriteByte(binary.byte5);\n+                stream.WriteByte(binary.byte4);\n+                stream.WriteByte(binary.byte3);\n+                stream.WriteByte(binary.byte2);\n+                stream.WriteByte(binary.byte1);\n+                stream.WriteByte(binary.byte0);\n+            }\n+            else\n+            {\n+                stream.WriteByte(binary.byte0);\n+                stream.WriteByte(binary.byte1);\n+                stream.WriteByte(binary.byte2);\n+                stream.WriteByte(binary.byte3);\n+                stream.WriteByte(binary.byte4);\n+                stream.WriteByte(binary.byte5);\n+                stream.WriteByte(binary.byte6);\n+                stream.WriteByte(binary.byte7);\n+            }\n+        }\n+\n+        double IMsgPackConverter<double>.Read(Stream stream, MsgPackSettings settings, Func<double> creator)","path":"src/msgpack/FloatConverter.cs","position":67,"original_position":67,"commit_id":"858ae903435b9f635775c7ee6ffbbde35f7ff525","original_commit_id":"858ae903435b9f635775c7ee6ffbbde35f7ff525","user":{"login":"roman-kozachenko","id":6246662,"avatar_url":"https://avatars.githubusercontent.com/u/6246662?v=3","gravatar_id":"","url":"https://api.github.com/users/roman-kozachenko","html_url":"https://github.com/roman-kozachenko","followers_url":"https://api.github.com/users/roman-kozachenko/followers","following_url":"https://api.github.com/users/roman-kozachenko/following{/other_user}","gists_url":"https://api.github.com/users/roman-kozachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/roman-kozachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roman-kozachenko/subscriptions","organizations_url":"https://api.github.com/users/roman-kozachenko/orgs","repos_url":"https://api.github.com/users/roman-kozachenko/repos","events_url":"https://api.github.com/users/roman-kozachenko/events{/privacy}","received_events_url":"https://api.github.com/users/roman-kozachenko/received_events","type":"User","site_admin":false},"body":"Why not to use implicit implementation?","created_at":"2016-04-11T11:39:06Z","updated_at":"2016-04-11T11:39:06Z","html_url":"https://github.com/aensidhe/tarantool-dnx/pull/4#discussion_r59190368","pull_request_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/comments/59190368"},"html":{"href":"https://github.com/aensidhe/tarantool-dnx/pull/4#discussion_r59190368"},"pull_request":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4","id":65974985,"html_url":"https://github.com/aensidhe/tarantool-dnx/pull/4","diff_url":"https://github.com/aensidhe/tarantool-dnx/pull/4.diff","patch_url":"https://github.com/aensidhe/tarantool-dnx/pull/4.patch","issue_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/4","number":4,"state":"open","locked":false,"title":"Feature/msgpack/rewrite","user":{"login":"aensidhe","id":3948027,"avatar_url":"https://avatars.githubusercontent.com/u/3948027?v=3","gravatar_id":"","url":"https://api.github.com/users/aensidhe","html_url":"https://github.com/aensidhe","followers_url":"https://api.github.com/users/aensidhe/followers","following_url":"https://api.github.com/users/aensidhe/following{/other_user}","gists_url":"https://api.github.com/users/aensidhe/gists{/gist_id}","starred_url":"https://api.github.com/users/aensidhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aensidhe/subscriptions","organizations_url":"https://api.github.com/users/aensidhe/orgs","repos_url":"https://api.github.com/users/aensidhe/repos","events_url":"https://api.github.com/users/aensidhe/events{/privacy}","received_events_url":"https://api.github.com/users/aensidhe/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-11T11:00:27Z","updated_at":"2016-04-11T11:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b12965b5179aac4cef2350fa814f7db7ce96b17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4/commits","review_comments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4/comments","review_comment_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/4/comments","statuses_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/statuses/858ae903435b9f635775c7ee6ffbbde35f7ff525","head":{"label":"aensidhe:feature/msgpack/rewrite","ref":"feature/msgpack/rewrite","sha":"858ae903435b9f635775c7ee6ffbbde35f7ff525","user":{"login":"aensidhe","id":3948027,"avatar_url":"https://avatars.githubusercontent.com/u/3948027?v=3","gravatar_id":"","url":"https://api.github.com/users/aensidhe","html_url":"https://github.com/aensidhe","followers_url":"https://api.github.com/users/aensidhe/followers","following_url":"https://api.github.com/users/aensidhe/following{/other_user}","gists_url":"https://api.github.com/users/aensidhe/gists{/gist_id}","starred_url":"https://api.github.com/users/aensidhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aensidhe/subscriptions","organizations_url":"https://api.github.com/users/aensidhe/orgs","repos_url":"https://api.github.com/users/aensidhe/repos","events_url":"https://api.github.com/users/aensidhe/events{/privacy}","received_events_url":"https://api.github.com/users/aensidhe/received_events","type":"User","site_admin":false},"repo":{"id":55472773,"name":"tarantool-dnx","full_name":"aensidhe/tarantool-dnx","owner":{"login":"aensidhe","id":3948027,"avatar_url":"https://avatars.githubusercontent.com/u/3948027?v=3","gravatar_id":"","url":"https://api.github.com/users/aensidhe","html_url":"https://github.com/aensidhe","followers_url":"https://api.github.com/users/aensidhe/followers","following_url":"https://api.github.com/users/aensidhe/following{/other_user}","gists_url":"https://api.github.com/users/aensidhe/gists{/gist_id}","starred_url":"https://api.github.com/users/aensidhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aensidhe/subscriptions","organizations_url":"https://api.github.com/users/aensidhe/orgs","repos_url":"https://api.github.com/users/aensidhe/repos","events_url":"https://api.github.com/users/aensidhe/events{/privacy}","received_events_url":"https://api.github.com/users/aensidhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aensidhe/tarantool-dnx","description":".net cli client for Tarantool NoSql database.","fork":false,"url":"https://api.github.com/repos/aensidhe/tarantool-dnx","forks_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/forks","keys_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/teams","hooks_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/hooks","issue_events_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/events{/number}","events_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/events","assignees_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/assignees{/user}","branches_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/branches{/branch}","tags_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/tags","blobs_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/statuses/{sha}","languages_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/languages","stargazers_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/stargazers","contributors_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/contributors","subscribers_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/subscribers","subscription_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/subscription","commits_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/contents/{+path}","compare_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/merges","archive_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/downloads","issues_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues{/number}","pulls_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls{/number}","milestones_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/milestones{/number}","notifications_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/labels{/name}","releases_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/releases{/id}","deployments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/deployments","created_at":"2016-04-05T06:17:39Z","updated_at":"2016-04-07T12:20:36Z","pushed_at":"2016-04-11T11:23:39Z","git_url":"git://github.com/aensidhe/tarantool-dnx.git","ssh_url":"git@github.com:aensidhe/tarantool-dnx.git","clone_url":"https://github.com/aensidhe/tarantool-dnx.git","svn_url":"https://github.com/aensidhe/tarantool-dnx","homepage":"","size":133,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aensidhe:master","ref":"master","sha":"2098bab7d07ffa747bc9e99adda02e8a267a64ce","user":{"login":"aensidhe","id":3948027,"avatar_url":"https://avatars.githubusercontent.com/u/3948027?v=3","gravatar_id":"","url":"https://api.github.com/users/aensidhe","html_url":"https://github.com/aensidhe","followers_url":"https://api.github.com/users/aensidhe/followers","following_url":"https://api.github.com/users/aensidhe/following{/other_user}","gists_url":"https://api.github.com/users/aensidhe/gists{/gist_id}","starred_url":"https://api.github.com/users/aensidhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aensidhe/subscriptions","organizations_url":"https://api.github.com/users/aensidhe/orgs","repos_url":"https://api.github.com/users/aensidhe/repos","events_url":"https://api.github.com/users/aensidhe/events{/privacy}","received_events_url":"https://api.github.com/users/aensidhe/received_events","type":"User","site_admin":false},"repo":{"id":55472773,"name":"tarantool-dnx","full_name":"aensidhe/tarantool-dnx","owner":{"login":"aensidhe","id":3948027,"avatar_url":"https://avatars.githubusercontent.com/u/3948027?v=3","gravatar_id":"","url":"https://api.github.com/users/aensidhe","html_url":"https://github.com/aensidhe","followers_url":"https://api.github.com/users/aensidhe/followers","following_url":"https://api.github.com/users/aensidhe/following{/other_user}","gists_url":"https://api.github.com/users/aensidhe/gists{/gist_id}","starred_url":"https://api.github.com/users/aensidhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aensidhe/subscriptions","organizations_url":"https://api.github.com/users/aensidhe/orgs","repos_url":"https://api.github.com/users/aensidhe/repos","events_url":"https://api.github.com/users/aensidhe/events{/privacy}","received_events_url":"https://api.github.com/users/aensidhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aensidhe/tarantool-dnx","description":".net cli client for Tarantool NoSql database.","fork":false,"url":"https://api.github.com/repos/aensidhe/tarantool-dnx","forks_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/forks","keys_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/teams","hooks_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/hooks","issue_events_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/events{/number}","events_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/events","assignees_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/assignees{/user}","branches_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/branches{/branch}","tags_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/tags","blobs_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/statuses/{sha}","languages_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/languages","stargazers_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/stargazers","contributors_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/contributors","subscribers_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/subscribers","subscription_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/subscription","commits_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/contents/{+path}","compare_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/merges","archive_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/downloads","issues_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues{/number}","pulls_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls{/number}","milestones_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/milestones{/number}","notifications_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/labels{/name}","releases_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/releases{/id}","deployments_url":"https://api.github.com/repos/aensidhe/tarantool-dnx/deployments","created_at":"2016-04-05T06:17:39Z","updated_at":"2016-04-07T12:20:36Z","pushed_at":"2016-04-11T11:23:39Z","git_url":"git://github.com/aensidhe/tarantool-dnx.git","ssh_url":"git@github.com:aensidhe/tarantool-dnx.git","clone_url":"https://github.com/aensidhe/tarantool-dnx.git","svn_url":"https://github.com/aensidhe/tarantool-dnx","homepage":"","size":133,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4"},"html":{"href":"https://github.com/aensidhe/tarantool-dnx/pull/4"},"issue":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/4"},"comments":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/aensidhe/tarantool-dnx/statuses/858ae903435b9f635775c7ee6ffbbde35f7ff525"}}}}