{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/GSL/issues/317","repository_url":"https://api.github.com/repos/Microsoft/GSL","labels_url":"https://api.github.com/repos/Microsoft/GSL/issues/317/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/GSL/issues/317/comments","events_url":"https://api.github.com/repos/Microsoft/GSL/issues/317/events","html_url":"https://github.com/Microsoft/GSL/pull/317","id":170179619,"number":317,"title":"Renamed include/ folder to gsl/ to address issue #277","user":{"login":"galik","id":752983,"avatar_url":"https://avatars.githubusercontent.com/u/752983?v=3","gravatar_id":"","url":"https://api.github.com/users/galik","html_url":"https://github.com/galik","followers_url":"https://api.github.com/users/galik/followers","following_url":"https://api.github.com/users/galik/following{/other_user}","gists_url":"https://api.github.com/users/galik/gists{/gist_id}","starred_url":"https://api.github.com/users/galik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galik/subscriptions","organizations_url":"https://api.github.com/users/galik/orgs","repos_url":"https://api.github.com/users/galik/repos","events_url":"https://api.github.com/users/galik/events{/privacy}","received_events_url":"https://api.github.com/users/galik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/GSL/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-09T14:24:20Z","updated_at":"2016-08-17T17:57:17Z","closed_at":"2016-08-10T00:54:55Z","pull_request":{"url":"https://api.github.com/repos/Microsoft/GSL/pulls/317","html_url":"https://github.com/Microsoft/GSL/pull/317","diff_url":"https://github.com/Microsoft/GSL/pull/317.diff","patch_url":"https://github.com/Microsoft/GSL/pull/317.patch"},"body":"Renamed include/ folder to gsl/ to make including the library consistent whether using it from the development folder, from the installation folder or from being copied into a project. \r\n\r\n    #include <gsl/gsl.h>\r\n\r\nUpdated headers/tests/instructions/cmake build accordingly\r\n\r\nThis PR should address https://github.com/Microsoft/GSL/issues/277 (less the renaming of gsl itself)"},"comment":{"url":"https://api.github.com/repos/Microsoft/GSL/issues/comments/240493599","html_url":"https://github.com/Microsoft/GSL/pull/317#issuecomment-240493599","issue_url":"https://api.github.com/repos/Microsoft/GSL/issues/317","id":240493599,"user":{"login":"MikeGitb","id":13987901,"avatar_url":"https://avatars.githubusercontent.com/u/13987901?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeGitb","html_url":"https://github.com/MikeGitb","followers_url":"https://api.github.com/users/MikeGitb/followers","following_url":"https://api.github.com/users/MikeGitb/following{/other_user}","gists_url":"https://api.github.com/users/MikeGitb/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGitb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGitb/subscriptions","organizations_url":"https://api.github.com/users/MikeGitb/orgs","repos_url":"https://api.github.com/users/MikeGitb/repos","events_url":"https://api.github.com/users/MikeGitb/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGitb/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T17:57:17Z","updated_at":"2016-08-17T17:57:17Z","body":"It's probably too late to revert this decision now, but could you at least shed some light on the rational behind dropping the .h extensions?\r\n\r\nPersonally, I see no benefit, but two drawbacks:\r\n- First, the only extensionless header names one usually comes across are part of the standard library, so this breaks consistency and might confuse some people (admittedly rather unlikely) \r\n- Second, many editors (including visual studio) won't automatically recognize them as c++ header files which disables things like syntax highlighting and code completion."}}
{"actor":{"display_login":"MikeGitb"}}