{"action":"closed","number":285,"pull_request":{"url":"https://api.github.com/repos/ssbc/patchwork/pulls/285","id":57792912,"html_url":"https://github.com/ssbc/patchwork/pull/285","diff_url":"https://github.com/ssbc/patchwork/pull/285.diff","patch_url":"https://github.com/ssbc/patchwork/pull/285.patch","issue_url":"https://api.github.com/repos/ssbc/patchwork/issues/285","number":285,"state":"closed","locked":false,"title":"Electron fixes","user":{"login":"clehner","id":95347,"avatar_url":"https://avatars.githubusercontent.com/u/95347?v=3","gravatar_id":"","url":"https://api.github.com/users/clehner","html_url":"https://github.com/clehner","followers_url":"https://api.github.com/users/clehner/followers","following_url":"https://api.github.com/users/clehner/following{/other_user}","gists_url":"https://api.github.com/users/clehner/gists{/gist_id}","starred_url":"https://api.github.com/users/clehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clehner/subscriptions","organizations_url":"https://api.github.com/users/clehner/orgs","repos_url":"https://api.github.com/users/clehner/repos","events_url":"https://api.github.com/users/clehner/events{/privacy}","received_events_url":"https://api.github.com/users/clehner/received_events","type":"User","site_admin":false},"body":"- Show Window menu\r\n- Fix About window missing image\r\n- Add link to website in About window\r\n\r\n~~For some reason, when I build a package using the patchwork-electron release scripts, the image in the About window is not recognized and was giving me an error, unless I ran the executable in the directory of patchwork. However, by wrapping the image path with nativeImage(), the error is suppresed and a generic icon is used instead, which fixes that problem partially.~~ Edit: Fixed in 3758bc0; nativeImage() not needed.","created_at":"2016-02-01T03:24:45Z","updated_at":"2016-02-01T15:29:42Z","closed_at":"2016-02-01T15:29:42Z","merged_at":"2016-02-01T15:29:42Z","merge_commit_sha":"34e1fa939e6a8f577a6130ea358f50aed79fc8f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ssbc/patchwork/pulls/285/commits","review_comments_url":"https://api.github.com/repos/ssbc/patchwork/pulls/285/comments","review_comment_url":"https://api.github.com/repos/ssbc/patchwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ssbc/patchwork/issues/285/comments","statuses_url":"https://api.github.com/repos/ssbc/patchwork/statuses/3758bc04d9dd9b6ea8ef79375f55d07f53f7259f","head":{"label":"ssbc:electron-fixes","ref":"electron-fixes","sha":"3758bc04d9dd9b6ea8ef79375f55d07f53f7259f","user":{"login":"ssbc","id":10190339,"avatar_url":"https://avatars.githubusercontent.com/u/10190339?v=3","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"repo":{"id":37995048,"name":"patchwork","full_name":"ssbc/patchwork","owner":{"login":"ssbc","id":10190339,"avatar_url":"https://avatars.githubusercontent.com/u/10190339?v=3","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ssbc/patchwork","description":"p2p social sharing","fork":false,"url":"https://api.github.com/repos/ssbc/patchwork","forks_url":"https://api.github.com/repos/ssbc/patchwork/forks","keys_url":"https://api.github.com/repos/ssbc/patchwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssbc/patchwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssbc/patchwork/teams","hooks_url":"https://api.github.com/repos/ssbc/patchwork/hooks","issue_events_url":"https://api.github.com/repos/ssbc/patchwork/issues/events{/number}","events_url":"https://api.github.com/repos/ssbc/patchwork/events","assignees_url":"https://api.github.com/repos/ssbc/patchwork/assignees{/user}","branches_url":"https://api.github.com/repos/ssbc/patchwork/branches{/branch}","tags_url":"https://api.github.com/repos/ssbc/patchwork/tags","blobs_url":"https://api.github.com/repos/ssbc/patchwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssbc/patchwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssbc/patchwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssbc/patchwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssbc/patchwork/statuses/{sha}","languages_url":"https://api.github.com/repos/ssbc/patchwork/languages","stargazers_url":"https://api.github.com/repos/ssbc/patchwork/stargazers","contributors_url":"https://api.github.com/repos/ssbc/patchwork/contributors","subscribers_url":"https://api.github.com/repos/ssbc/patchwork/subscribers","subscription_url":"https://api.github.com/repos/ssbc/patchwork/subscription","commits_url":"https://api.github.com/repos/ssbc/patchwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssbc/patchwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssbc/patchwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssbc/patchwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssbc/patchwork/contents/{+path}","compare_url":"https://api.github.com/repos/ssbc/patchwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssbc/patchwork/merges","archive_url":"https://api.github.com/repos/ssbc/patchwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssbc/patchwork/downloads","issues_url":"https://api.github.com/repos/ssbc/patchwork/issues{/number}","pulls_url":"https://api.github.com/repos/ssbc/patchwork/pulls{/number}","milestones_url":"https://api.github.com/repos/ssbc/patchwork/milestones{/number}","notifications_url":"https://api.github.com/repos/ssbc/patchwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssbc/patchwork/labels{/name}","releases_url":"https://api.github.com/repos/ssbc/patchwork/releases{/id}","deployments_url":"https://api.github.com/repos/ssbc/patchwork/deployments","created_at":"2015-06-24T16:00:09Z","updated_at":"2016-01-28T12:10:19Z","pushed_at":"2016-02-01T15:29:42Z","git_url":"git://github.com/ssbc/patchwork.git","ssh_url":"git@github.com:ssbc/patchwork.git","clone_url":"https://github.com/ssbc/patchwork.git","svn_url":"https://github.com/ssbc/patchwork","homepage":"https://ssbc.github.io/patchwork","size":12769,"stargazers_count":151,"watchers_count":151,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":70,"forks":20,"open_issues":70,"watchers":151,"default_branch":"master"}},"base":{"label":"ssbc:master","ref":"master","sha":"6c15be8aa464206b3be2820212116024be31d413","user":{"login":"ssbc","id":10190339,"avatar_url":"https://avatars.githubusercontent.com/u/10190339?v=3","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"repo":{"id":37995048,"name":"patchwork","full_name":"ssbc/patchwork","owner":{"login":"ssbc","id":10190339,"avatar_url":"https://avatars.githubusercontent.com/u/10190339?v=3","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ssbc/patchwork","description":"p2p social sharing","fork":false,"url":"https://api.github.com/repos/ssbc/patchwork","forks_url":"https://api.github.com/repos/ssbc/patchwork/forks","keys_url":"https://api.github.com/repos/ssbc/patchwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssbc/patchwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssbc/patchwork/teams","hooks_url":"https://api.github.com/repos/ssbc/patchwork/hooks","issue_events_url":"https://api.github.com/repos/ssbc/patchwork/issues/events{/number}","events_url":"https://api.github.com/repos/ssbc/patchwork/events","assignees_url":"https://api.github.com/repos/ssbc/patchwork/assignees{/user}","branches_url":"https://api.github.com/repos/ssbc/patchwork/branches{/branch}","tags_url":"https://api.github.com/repos/ssbc/patchwork/tags","blobs_url":"https://api.github.com/repos/ssbc/patchwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssbc/patchwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssbc/patchwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssbc/patchwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssbc/patchwork/statuses/{sha}","languages_url":"https://api.github.com/repos/ssbc/patchwork/languages","stargazers_url":"https://api.github.com/repos/ssbc/patchwork/stargazers","contributors_url":"https://api.github.com/repos/ssbc/patchwork/contributors","subscribers_url":"https://api.github.com/repos/ssbc/patchwork/subscribers","subscription_url":"https://api.github.com/repos/ssbc/patchwork/subscription","commits_url":"https://api.github.com/repos/ssbc/patchwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssbc/patchwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssbc/patchwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssbc/patchwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssbc/patchwork/contents/{+path}","compare_url":"https://api.github.com/repos/ssbc/patchwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssbc/patchwork/merges","archive_url":"https://api.github.com/repos/ssbc/patchwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssbc/patchwork/downloads","issues_url":"https://api.github.com/repos/ssbc/patchwork/issues{/number}","pulls_url":"https://api.github.com/repos/ssbc/patchwork/pulls{/number}","milestones_url":"https://api.github.com/repos/ssbc/patchwork/milestones{/number}","notifications_url":"https://api.github.com/repos/ssbc/patchwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssbc/patchwork/labels{/name}","releases_url":"https://api.github.com/repos/ssbc/patchwork/releases{/id}","deployments_url":"https://api.github.com/repos/ssbc/patchwork/deployments","created_at":"2015-06-24T16:00:09Z","updated_at":"2016-01-28T12:10:19Z","pushed_at":"2016-02-01T15:29:42Z","git_url":"git://github.com/ssbc/patchwork.git","ssh_url":"git@github.com:ssbc/patchwork.git","clone_url":"https://github.com/ssbc/patchwork.git","svn_url":"https://github.com/ssbc/patchwork","homepage":"https://ssbc.github.io/patchwork","size":12769,"stargazers_count":151,"watchers_count":151,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":70,"forks":20,"open_issues":70,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ssbc/patchwork/pulls/285"},"html":{"href":"https://github.com/ssbc/patchwork/pull/285"},"issue":{"href":"https://api.github.com/repos/ssbc/patchwork/issues/285"},"comments":{"href":"https://api.github.com/repos/ssbc/patchwork/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/ssbc/patchwork/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/ssbc/patchwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ssbc/patchwork/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/ssbc/patchwork/statuses/3758bc04d9dd9b6ea8ef79375f55d07f53f7259f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pfraze","id":1270099,"avatar_url":"https://avatars.githubusercontent.com/u/1270099?v=3","gravatar_id":"","url":"https://api.github.com/users/pfraze","html_url":"https://github.com/pfraze","followers_url":"https://api.github.com/users/pfraze/followers","following_url":"https://api.github.com/users/pfraze/following{/other_user}","gists_url":"https://api.github.com/users/pfraze/gists{/gist_id}","starred_url":"https://api.github.com/users/pfraze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfraze/subscriptions","organizations_url":"https://api.github.com/users/pfraze/orgs","repos_url":"https://api.github.com/users/pfraze/repos","events_url":"https://api.github.com/users/pfraze/events{/privacy}","received_events_url":"https://api.github.com/users/pfraze/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":8,"deletions":5,"changed_files":1}}