{"action":"created","issue":{"url":"https://api.github.com/repos/OTRS/otrs/issues/1150","repository_url":"https://api.github.com/repos/OTRS/otrs","labels_url":"https://api.github.com/repos/OTRS/otrs/issues/1150/labels{/name}","comments_url":"https://api.github.com/repos/OTRS/otrs/issues/1150/comments","events_url":"https://api.github.com/repos/OTRS/otrs/issues/1150/events","html_url":"https://github.com/OTRS/otrs/pull/1150","id":153223966,"number":1150,"title":"Master - Translate strings directly in JavaScript part 4","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zottto","id":481410,"avatar_url":"https://avatars.githubusercontent.com/u/481410?v=3","gravatar_id":"","url":"https://api.github.com/users/zottto","html_url":"https://github.com/zottto","followers_url":"https://api.github.com/users/zottto/followers","following_url":"https://api.github.com/users/zottto/following{/other_user}","gists_url":"https://api.github.com/users/zottto/gists{/gist_id}","starred_url":"https://api.github.com/users/zottto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zottto/subscriptions","organizations_url":"https://api.github.com/users/zottto/orgs","repos_url":"https://api.github.com/users/zottto/repos","events_url":"https://api.github.com/users/zottto/events{/privacy}","received_events_url":"https://api.github.com/users/zottto/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-05T12:39:46Z","updated_at":"2016-05-17T07:16:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/1150","html_url":"https://github.com/OTRS/otrs/pull/1150","diff_url":"https://github.com/OTRS/otrs/pull/1150.diff","patch_url":"https://github.com/OTRS/otrs/pull/1150.patch"},"body":"Hi @zottto\r\n\r\nHereby are updated some tt modules where strings in JS are translated  directly.\r\nI am not sure should I use Core.Language.Translate in confirm in AdminNotificationEvent.tt \r\n```\r\n    if (window.confirm(Core.Language.Translate('Do you really want to delete this notification?'))) {\r\n         window.location = $(this).attr('href');\r\n         window.location = $(this).attr('href');\r\n     }\r\n     }\r\n\r\n```\r\n\r\nAlso I have dilemma about EditConfirm strings n some AdminProcessManagement modules. IF there is necessary quotation marks ( EditConfirm: \"[%  ...  | html %]\" )\r\n\r\n```\r\n-    EditConfirm: \"[% Translate(\"As soon as you use this button or link, you will leave this screen and its current state will be saved automatically. Do you want to continue?\") | html %]\"\r\n\r\n+    EditConfirm: Core.Language.Translate('As soon as you use this button or link, you will leave this screen and its current state will be saved automatically. Do you want to continue?')\r\n```\r\n\r\nYou can see how I have done, but I will be able to update if it is not good. Please let me know what do you think about that.\r\n\r\n\r\nRegards\r\nZoran\r\n"},"comment":{"url":"https://api.github.com/repos/OTRS/otrs/issues/comments/219637954","html_url":"https://github.com/OTRS/otrs/pull/1150#issuecomment-219637954","issue_url":"https://api.github.com/repos/OTRS/otrs/issues/1150","id":219637954,"user":{"login":"zottto","id":481410,"avatar_url":"https://avatars.githubusercontent.com/u/481410?v=3","gravatar_id":"","url":"https://api.github.com/users/zottto","html_url":"https://github.com/zottto","followers_url":"https://api.github.com/users/zottto/followers","following_url":"https://api.github.com/users/zottto/following{/other_user}","gists_url":"https://api.github.com/users/zottto/gists{/gist_id}","starred_url":"https://api.github.com/users/zottto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zottto/subscriptions","organizations_url":"https://api.github.com/users/zottto/orgs","repos_url":"https://api.github.com/users/zottto/repos","events_url":"https://api.github.com/users/zottto/events{/privacy}","received_events_url":"https://api.github.com/users/zottto/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T07:16:15Z","updated_at":"2016-05-17T07:16:15Z","body":"Hi Zoran,\r\n\r\nI also saw in this PR that you used Core.Language.Translate() within a tt file (e.g. here: https://github.com/s7design/otrs/blob/1fbe7ba6e658f6474c00f268a60c7c153c44f52e/Kernel/Output/HTML/Templates/Standard/AdminDynamicField.tt#L116). As mentioned already in the other PR, this will not work. Please use the template block instead.\r\n\r\nThanks,\r\nMarc\r\n"}}