{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8597","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8597/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8597/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8597/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8597","id":173380450,"number":8597,"title":"[WIP] Move code from VERACK to VERSION (since VERACK is not requied)","user":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=3","gravatar_id":"","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-26T06:39:52Z","updated_at":"2016-08-28T02:45:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8597","html_url":"https://github.com/bitcoin/bitcoin/pull/8597","diff_url":"https://github.com/bitcoin/bitcoin/pull/8597.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8597.patch"},"body":"Currently it's possible for a node to not send a VERACK and the only impact of this is that the code within VERACK will not be run, which is not desired behaviour.\r\n\r\nThe code behind VERACK ought to be just that - code that needs a verack to run. It may be that a variable be set which would avoid a disconnect after a certain time, for example, but so far this has never been implemented so effectively VERACKs have never been required for a connection to remain connected. The code should perhaps reflect this."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/242952772","html_url":"https://github.com/bitcoin/bitcoin/pull/8597#issuecomment-242952772","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8597","id":242952772,"user":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=3","gravatar_id":"","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T02:45:49Z","updated_at":"2016-08-28T02:45:49Z","body":"@sipa you say \"before continuing\" but this is not how the code currently works. There is no stopping or waiting for the verack currently, instead some code is simply not executed as a result of the verack not being received. That code (which is important that it runs) is what I have now moved to run upon receipt of a \"version\" message - which DOES cause the required continuation that you mention."}}
{"actor":{"display_login":"rebroad"}}