{"action":"created","comment":{"url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/comments/53352691","id":53352691,"diff_hunk":"@@ -21,9 +21,9 @@ struct OAuth2Token: JSONObjectConvertible {\n \n     // MARK: - Public properties\n     \n-    let accessToken: String\n-    let expiresAt: NSDate\n-    let refreshToken: String?\n+    var accessToken: String\n+    var expiresAt: NSDate\n+    var refreshToken: String?","path":"NetworkStack/OAuth2Token.swift","position":9,"original_position":9,"commit_id":"05efc6d1d4d07dc7e2cd4cc4fd87c5fdf6b64ea3","original_commit_id":"05efc6d1d4d07dc7e2cd4cc4fd87c5fdf6b64ea3","user":{"login":"benjaminsnorris","id":3652919,"avatar_url":"https://avatars.githubusercontent.com/u/3652919?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminsnorris","html_url":"https://github.com/benjaminsnorris","followers_url":"https://api.github.com/users/benjaminsnorris/followers","following_url":"https://api.github.com/users/benjaminsnorris/following{/other_user}","gists_url":"https://api.github.com/users/benjaminsnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminsnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminsnorris/subscriptions","organizations_url":"https://api.github.com/users/benjaminsnorris/orgs","repos_url":"https://api.github.com/users/benjaminsnorris/repos","events_url":"https://api.github.com/users/benjaminsnorris/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminsnorris/received_events","type":"User","site_admin":false},"body":"I really like the reasoning for making them `var` instead of `let`. I think I want to take advantage of that in other areas. But for the OAuth token, I agree with making them `let`s.","created_at":"2016-02-18T17:53:29Z","updated_at":"2016-02-18T17:53:29Z","html_url":"https://github.com/octanner/ios-network-stack/pull/2#discussion_r53352691","pull_request_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/comments/53352691"},"html":{"href":"https://github.com/octanner/ios-network-stack/pull/2#discussion_r53352691"},"pull_request":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2","id":59833151,"html_url":"https://github.com/octanner/ios-network-stack/pull/2","diff_url":"https://github.com/octanner/ios-network-stack/pull/2.diff","patch_url":"https://github.com/octanner/ios-network-stack/pull/2.patch","issue_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/2","number":2,"state":"open","locked":false,"title":"Jason updates","user":{"login":"jarsen","id":73101,"avatar_url":"https://avatars.githubusercontent.com/u/73101?v=3","gravatar_id":"","url":"https://api.github.com/users/jarsen","html_url":"https://github.com/jarsen","followers_url":"https://api.github.com/users/jarsen/followers","following_url":"https://api.github.com/users/jarsen/following{/other_user}","gists_url":"https://api.github.com/users/jarsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarsen/subscriptions","organizations_url":"https://api.github.com/users/jarsen/orgs","repos_url":"https://api.github.com/users/jarsen/repos","events_url":"https://api.github.com/users/jarsen/events{/privacy}","received_events_url":"https://api.github.com/users/jarsen/received_events","type":"User","site_admin":false},"body":"Here a bunch of proposed changes as I was familiarizing myself with the network stack. Let me know what you like, don't like, and I can put things back as we wish.","created_at":"2016-02-18T17:22:59Z","updated_at":"2016-02-18T17:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc930a1c8bbd375d6d0e78d7b9dab945b0bec92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2/commits","review_comments_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2/comments","review_comment_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/2/comments","statuses_url":"https://api.github.com/repos/octanner/ios-network-stack/statuses/05efc6d1d4d07dc7e2cd4cc4fd87c5fdf6b64ea3","head":{"label":"octanner:jason-updates","ref":"jason-updates","sha":"05efc6d1d4d07dc7e2cd4cc4fd87c5fdf6b64ea3","user":{"login":"octanner","id":2523170,"avatar_url":"https://avatars.githubusercontent.com/u/2523170?v=3","gravatar_id":"","url":"https://api.github.com/users/octanner","html_url":"https://github.com/octanner","followers_url":"https://api.github.com/users/octanner/followers","following_url":"https://api.github.com/users/octanner/following{/other_user}","gists_url":"https://api.github.com/users/octanner/gists{/gist_id}","starred_url":"https://api.github.com/users/octanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octanner/subscriptions","organizations_url":"https://api.github.com/users/octanner/orgs","repos_url":"https://api.github.com/users/octanner/repos","events_url":"https://api.github.com/users/octanner/events{/privacy}","received_events_url":"https://api.github.com/users/octanner/received_events","type":"Organization","site_admin":false},"repo":{"id":51537483,"name":"ios-network-stack","full_name":"octanner/ios-network-stack","owner":{"login":"octanner","id":2523170,"avatar_url":"https://avatars.githubusercontent.com/u/2523170?v=3","gravatar_id":"","url":"https://api.github.com/users/octanner","html_url":"https://github.com/octanner","followers_url":"https://api.github.com/users/octanner/followers","following_url":"https://api.github.com/users/octanner/following{/other_user}","gists_url":"https://api.github.com/users/octanner/gists{/gist_id}","starred_url":"https://api.github.com/users/octanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octanner/subscriptions","organizations_url":"https://api.github.com/users/octanner/orgs","repos_url":"https://api.github.com/users/octanner/repos","events_url":"https://api.github.com/users/octanner/events{/privacy}","received_events_url":"https://api.github.com/users/octanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octanner/ios-network-stack","description":"The base network stack for OC Tanner iOS apps","fork":false,"url":"https://api.github.com/repos/octanner/ios-network-stack","forks_url":"https://api.github.com/repos/octanner/ios-network-stack/forks","keys_url":"https://api.github.com/repos/octanner/ios-network-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octanner/ios-network-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octanner/ios-network-stack/teams","hooks_url":"https://api.github.com/repos/octanner/ios-network-stack/hooks","issue_events_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/events{/number}","events_url":"https://api.github.com/repos/octanner/ios-network-stack/events","assignees_url":"https://api.github.com/repos/octanner/ios-network-stack/assignees{/user}","branches_url":"https://api.github.com/repos/octanner/ios-network-stack/branches{/branch}","tags_url":"https://api.github.com/repos/octanner/ios-network-stack/tags","blobs_url":"https://api.github.com/repos/octanner/ios-network-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octanner/ios-network-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octanner/ios-network-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/octanner/ios-network-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octanner/ios-network-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/octanner/ios-network-stack/languages","stargazers_url":"https://api.github.com/repos/octanner/ios-network-stack/stargazers","contributors_url":"https://api.github.com/repos/octanner/ios-network-stack/contributors","subscribers_url":"https://api.github.com/repos/octanner/ios-network-stack/subscribers","subscription_url":"https://api.github.com/repos/octanner/ios-network-stack/subscription","commits_url":"https://api.github.com/repos/octanner/ios-network-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/octanner/ios-network-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/octanner/ios-network-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/octanner/ios-network-stack/contents/{+path}","compare_url":"https://api.github.com/repos/octanner/ios-network-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octanner/ios-network-stack/merges","archive_url":"https://api.github.com/repos/octanner/ios-network-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octanner/ios-network-stack/downloads","issues_url":"https://api.github.com/repos/octanner/ios-network-stack/issues{/number}","pulls_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/octanner/ios-network-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/octanner/ios-network-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octanner/ios-network-stack/labels{/name}","releases_url":"https://api.github.com/repos/octanner/ios-network-stack/releases{/id}","deployments_url":"https://api.github.com/repos/octanner/ios-network-stack/deployments","created_at":"2016-02-11T18:45:39Z","updated_at":"2016-02-17T17:10:24Z","pushed_at":"2016-02-18T17:22:59Z","git_url":"git://github.com/octanner/ios-network-stack.git","ssh_url":"git@github.com:octanner/ios-network-stack.git","clone_url":"https://github.com/octanner/ios-network-stack.git","svn_url":"https://github.com/octanner/ios-network-stack","homepage":null,"size":77,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"octanner:master","ref":"master","sha":"7e831b09b47966f958ab611d51b94ec0cfd2a7e2","user":{"login":"octanner","id":2523170,"avatar_url":"https://avatars.githubusercontent.com/u/2523170?v=3","gravatar_id":"","url":"https://api.github.com/users/octanner","html_url":"https://github.com/octanner","followers_url":"https://api.github.com/users/octanner/followers","following_url":"https://api.github.com/users/octanner/following{/other_user}","gists_url":"https://api.github.com/users/octanner/gists{/gist_id}","starred_url":"https://api.github.com/users/octanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octanner/subscriptions","organizations_url":"https://api.github.com/users/octanner/orgs","repos_url":"https://api.github.com/users/octanner/repos","events_url":"https://api.github.com/users/octanner/events{/privacy}","received_events_url":"https://api.github.com/users/octanner/received_events","type":"Organization","site_admin":false},"repo":{"id":51537483,"name":"ios-network-stack","full_name":"octanner/ios-network-stack","owner":{"login":"octanner","id":2523170,"avatar_url":"https://avatars.githubusercontent.com/u/2523170?v=3","gravatar_id":"","url":"https://api.github.com/users/octanner","html_url":"https://github.com/octanner","followers_url":"https://api.github.com/users/octanner/followers","following_url":"https://api.github.com/users/octanner/following{/other_user}","gists_url":"https://api.github.com/users/octanner/gists{/gist_id}","starred_url":"https://api.github.com/users/octanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octanner/subscriptions","organizations_url":"https://api.github.com/users/octanner/orgs","repos_url":"https://api.github.com/users/octanner/repos","events_url":"https://api.github.com/users/octanner/events{/privacy}","received_events_url":"https://api.github.com/users/octanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octanner/ios-network-stack","description":"The base network stack for OC Tanner iOS apps","fork":false,"url":"https://api.github.com/repos/octanner/ios-network-stack","forks_url":"https://api.github.com/repos/octanner/ios-network-stack/forks","keys_url":"https://api.github.com/repos/octanner/ios-network-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octanner/ios-network-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octanner/ios-network-stack/teams","hooks_url":"https://api.github.com/repos/octanner/ios-network-stack/hooks","issue_events_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/events{/number}","events_url":"https://api.github.com/repos/octanner/ios-network-stack/events","assignees_url":"https://api.github.com/repos/octanner/ios-network-stack/assignees{/user}","branches_url":"https://api.github.com/repos/octanner/ios-network-stack/branches{/branch}","tags_url":"https://api.github.com/repos/octanner/ios-network-stack/tags","blobs_url":"https://api.github.com/repos/octanner/ios-network-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octanner/ios-network-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octanner/ios-network-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/octanner/ios-network-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octanner/ios-network-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/octanner/ios-network-stack/languages","stargazers_url":"https://api.github.com/repos/octanner/ios-network-stack/stargazers","contributors_url":"https://api.github.com/repos/octanner/ios-network-stack/contributors","subscribers_url":"https://api.github.com/repos/octanner/ios-network-stack/subscribers","subscription_url":"https://api.github.com/repos/octanner/ios-network-stack/subscription","commits_url":"https://api.github.com/repos/octanner/ios-network-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/octanner/ios-network-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/octanner/ios-network-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/octanner/ios-network-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/octanner/ios-network-stack/contents/{+path}","compare_url":"https://api.github.com/repos/octanner/ios-network-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octanner/ios-network-stack/merges","archive_url":"https://api.github.com/repos/octanner/ios-network-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octanner/ios-network-stack/downloads","issues_url":"https://api.github.com/repos/octanner/ios-network-stack/issues{/number}","pulls_url":"https://api.github.com/repos/octanner/ios-network-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/octanner/ios-network-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/octanner/ios-network-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octanner/ios-network-stack/labels{/name}","releases_url":"https://api.github.com/repos/octanner/ios-network-stack/releases{/id}","deployments_url":"https://api.github.com/repos/octanner/ios-network-stack/deployments","created_at":"2016-02-11T18:45:39Z","updated_at":"2016-02-17T17:10:24Z","pushed_at":"2016-02-18T17:22:59Z","git_url":"git://github.com/octanner/ios-network-stack.git","ssh_url":"git@github.com:octanner/ios-network-stack.git","clone_url":"https://github.com/octanner/ios-network-stack.git","svn_url":"https://github.com/octanner/ios-network-stack","homepage":null,"size":77,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2"},"html":{"href":"https://github.com/octanner/ios-network-stack/pull/2"},"issue":{"href":"https://api.github.com/repos/octanner/ios-network-stack/issues/2"},"comments":{"href":"https://api.github.com/repos/octanner/ios-network-stack/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octanner/ios-network-stack/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/octanner/ios-network-stack/statuses/05efc6d1d4d07dc7e2cd4cc4fd87c5fdf6b64ea3"}}}}