{"action":"created","comment":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/comments/85644760","pull_request_review_id":6351302,"id":85644760,"diff_hunk":"@@ -31,6 +31,10 @@ def add_directory(directory):\n     \"\"\" Add a directory to search for Cantera data files. \"\"\"\n     CxxAddDirectory(stringify(directory))\n \n+def get_data_directories(sep=':'):","path":"interfaces/cython/cantera/utils.pyx","position":4,"original_position":4,"commit_id":"ffd9f4c5b498b948599073b8f220d7ff9de7dc0f","original_commit_id":"ffd9f4c5b498b948599073b8f220d7ff9de7dc0f","user":{"login":"speth","id":644977,"avatar_url":"https://avatars.githubusercontent.com/u/644977?v=3","gravatar_id":"","url":"https://api.github.com/users/speth","html_url":"https://github.com/speth","followers_url":"https://api.github.com/users/speth/followers","following_url":"https://api.github.com/users/speth/following{/other_user}","gists_url":"https://api.github.com/users/speth/gists{/gist_id}","starred_url":"https://api.github.com/users/speth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speth/subscriptions","organizations_url":"https://api.github.com/users/speth/orgs","repos_url":"https://api.github.com/users/speth/repos","events_url":"https://api.github.com/users/speth/events{/privacy}","received_events_url":"https://api.github.com/users/speth/received_events","type":"User","site_admin":false},"body":"I think you need to use `os.pathsep` instead of `':'` here, otherwise this will fail badly on Windows.","created_at":"2016-10-29T17:35:03Z","updated_at":"2016-10-29T17:35:03Z","html_url":"https://github.com/Cantera/cantera/pull/375#discussion_r85644760","pull_request_url":"https://api.github.com/repos/Cantera/cantera/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments/85644760"},"html":{"href":"https://github.com/Cantera/cantera/pull/375#discussion_r85644760"},"pull_request":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/375","id":90936368,"html_url":"https://github.com/Cantera/cantera/pull/375","diff_url":"https://github.com/Cantera/cantera/pull/375.diff","patch_url":"https://github.com/Cantera/cantera/pull/375.patch","issue_url":"https://api.github.com/repos/Cantera/cantera/issues/375","number":375,"state":"open","locked":false,"title":"Add get data directories function","user":{"login":"bryanwweber","id":4396228,"avatar_url":"https://avatars.githubusercontent.com/u/4396228?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"body":"Add a function to get the data directories that Cantera searches. Since we're using Boost in another spot now as a requirement, I thought it'd be OK to use that here as well. If not, we just need to implement our own string imploder to convert from `std::vector<string>` to a `std::string`.","created_at":"2016-10-26T04:53:24Z","updated_at":"2016-10-29T17:44:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bf8895e01645c22e2a07bdf900690f75a14a794","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cantera/cantera/pulls/375/commits","review_comments_url":"https://api.github.com/repos/Cantera/cantera/pulls/375/comments","review_comment_url":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cantera/cantera/issues/375/comments","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/ffd9f4c5b498b948599073b8f220d7ff9de7dc0f","head":{"label":"bryanwweber:add_get_data_dirs","ref":"add_get_data_dirs","sha":"ffd9f4c5b498b948599073b8f220d7ff9de7dc0f","user":{"login":"bryanwweber","id":4396228,"avatar_url":"https://avatars.githubusercontent.com/u/4396228?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"repo":{"id":33513928,"name":"cantera","full_name":"bryanwweber/cantera","owner":{"login":"bryanwweber","id":4396228,"avatar_url":"https://avatars.githubusercontent.com/u/4396228?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryanwweber/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":true,"url":"https://api.github.com/repos/bryanwweber/cantera","forks_url":"https://api.github.com/repos/bryanwweber/cantera/forks","keys_url":"https://api.github.com/repos/bryanwweber/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryanwweber/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryanwweber/cantera/teams","hooks_url":"https://api.github.com/repos/bryanwweber/cantera/hooks","issue_events_url":"https://api.github.com/repos/bryanwweber/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/bryanwweber/cantera/events","assignees_url":"https://api.github.com/repos/bryanwweber/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/bryanwweber/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/bryanwweber/cantera/tags","blobs_url":"https://api.github.com/repos/bryanwweber/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryanwweber/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryanwweber/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryanwweber/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryanwweber/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/bryanwweber/cantera/languages","stargazers_url":"https://api.github.com/repos/bryanwweber/cantera/stargazers","contributors_url":"https://api.github.com/repos/bryanwweber/cantera/contributors","subscribers_url":"https://api.github.com/repos/bryanwweber/cantera/subscribers","subscription_url":"https://api.github.com/repos/bryanwweber/cantera/subscription","commits_url":"https://api.github.com/repos/bryanwweber/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryanwweber/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryanwweber/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryanwweber/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryanwweber/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/bryanwweber/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryanwweber/cantera/merges","archive_url":"https://api.github.com/repos/bryanwweber/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryanwweber/cantera/downloads","issues_url":"https://api.github.com/repos/bryanwweber/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/bryanwweber/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/bryanwweber/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/bryanwweber/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryanwweber/cantera/labels{/name}","releases_url":"https://api.github.com/repos/bryanwweber/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/bryanwweber/cantera/deployments","created_at":"2015-04-07T00:53:59Z","updated_at":"2016-01-22T22:46:25Z","pushed_at":"2016-10-29T16:08:55Z","git_url":"git://github.com/bryanwweber/cantera.git","ssh_url":"git@github.com:bryanwweber/cantera.git","clone_url":"https://github.com/bryanwweber/cantera.git","svn_url":"https://github.com/bryanwweber/cantera","homepage":"","size":32916,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cantera:master","ref":"master","sha":"2a8ac433088fb12dff087fe6bf6a92369ecc7bb4","user":{"login":"Cantera","id":817698,"avatar_url":"https://avatars.githubusercontent.com/u/817698?v=3","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"repo":{"id":32940327,"name":"cantera","full_name":"Cantera/cantera","owner":{"login":"Cantera","id":817698,"avatar_url":"https://avatars.githubusercontent.com/u/817698?v=3","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cantera/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":false,"url":"https://api.github.com/repos/Cantera/cantera","forks_url":"https://api.github.com/repos/Cantera/cantera/forks","keys_url":"https://api.github.com/repos/Cantera/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cantera/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cantera/cantera/teams","hooks_url":"https://api.github.com/repos/Cantera/cantera/hooks","issue_events_url":"https://api.github.com/repos/Cantera/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/Cantera/cantera/events","assignees_url":"https://api.github.com/repos/Cantera/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/Cantera/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/Cantera/cantera/tags","blobs_url":"https://api.github.com/repos/Cantera/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cantera/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cantera/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cantera/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/Cantera/cantera/languages","stargazers_url":"https://api.github.com/repos/Cantera/cantera/stargazers","contributors_url":"https://api.github.com/repos/Cantera/cantera/contributors","subscribers_url":"https://api.github.com/repos/Cantera/cantera/subscribers","subscription_url":"https://api.github.com/repos/Cantera/cantera/subscription","commits_url":"https://api.github.com/repos/Cantera/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cantera/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cantera/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cantera/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cantera/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/Cantera/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cantera/cantera/merges","archive_url":"https://api.github.com/repos/Cantera/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cantera/cantera/downloads","issues_url":"https://api.github.com/repos/Cantera/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/Cantera/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/Cantera/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/Cantera/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cantera/cantera/labels{/name}","releases_url":"https://api.github.com/repos/Cantera/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/Cantera/cantera/deployments","created_at":"2015-03-26T16:54:16Z","updated_at":"2016-10-22T03:17:14Z","pushed_at":"2016-10-29T16:08:56Z","git_url":"git://github.com/Cantera/cantera.git","ssh_url":"git@github.com:Cantera/cantera.git","clone_url":"https://github.com/Cantera/cantera.git","svn_url":"https://github.com/Cantera/cantera","homepage":"","size":74221,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":30,"forks":41,"open_issues":30,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/375"},"html":{"href":"https://github.com/Cantera/cantera/pull/375"},"issue":{"href":"https://api.github.com/repos/Cantera/cantera/issues/375"},"comments":{"href":"https://api.github.com/repos/Cantera/cantera/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/Cantera/cantera/statuses/ffd9f4c5b498b948599073b8f220d7ff9de7dc0f"}}}}
{"actor":{"display_login":"speth"}}