{"action":"created","comment":{"url":"https://api.github.com/repos/appprova/action_tracker/pulls/comments/61762159","id":61762159,"diff_hunk":"@@ -0,0 +1,17 @@\n+require 'spec_helper'\n+\n+describe ActionTracker::Configuration do\n+  describe '#track_events flag' do\n+    it 'default value is true' do\n+      expect(ActionTracker::Configuration.new.track_events).to eq(true)","path":"spec/configuration_spec.rb","position":6,"original_position":6,"commit_id":"f2595725cdb86819b7137af4b61bc73ce389e04a","original_commit_id":"f2595725cdb86819b7137af4b61bc73ce389e04a","user":{"login":"LeandroLM","id":6375721,"avatar_url":"https://avatars.githubusercontent.com/u/6375721?v=3","gravatar_id":"","url":"https://api.github.com/users/LeandroLM","html_url":"https://github.com/LeandroLM","followers_url":"https://api.github.com/users/LeandroLM/followers","following_url":"https://api.github.com/users/LeandroLM/following{/other_user}","gists_url":"https://api.github.com/users/LeandroLM/gists{/gist_id}","starred_url":"https://api.github.com/users/LeandroLM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeandroLM/subscriptions","organizations_url":"https://api.github.com/users/LeandroLM/orgs","repos_url":"https://api.github.com/users/LeandroLM/repos","events_url":"https://api.github.com/users/LeandroLM/events{/privacy}","received_events_url":"https://api.github.com/users/LeandroLM/received_events","type":"User","site_admin":false},"body":"No, I was sugesting something like this:\r\n\r\n```ruby\r\n  ActionTracker.configure do |config|\r\n    config.track_events = false\r\n  end\r\n\r\n expect(ActionTraker.configuration.track_events).to be_falsy\r\n```\r\n\r\nThis way you would be testing that the `configure` class method from ActionTracker is working properly. What do you think?","created_at":"2016-05-02T16:24:46Z","updated_at":"2016-05-02T16:24:46Z","html_url":"https://github.com/appprova/action_tracker/pull/17#discussion_r61762159","pull_request_url":"https://api.github.com/repos/appprova/action_tracker/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/comments/61762159"},"html":{"href":"https://github.com/appprova/action_tracker/pull/17#discussion_r61762159"},"pull_request":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/appprova/action_tracker/pulls/17","id":68566055,"html_url":"https://github.com/appprova/action_tracker/pull/17","diff_url":"https://github.com/appprova/action_tracker/pull/17.diff","patch_url":"https://github.com/appprova/action_tracker/pull/17.patch","issue_url":"https://api.github.com/repos/appprova/action_tracker/issues/17","number":17,"state":"open","locked":false,"title":"creating conditional events tracking","user":{"login":"MartinsTiago","id":1048642,"avatar_url":"https://avatars.githubusercontent.com/u/1048642?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinsTiago","html_url":"https://github.com/MartinsTiago","followers_url":"https://api.github.com/users/MartinsTiago/followers","following_url":"https://api.github.com/users/MartinsTiago/following{/other_user}","gists_url":"https://api.github.com/users/MartinsTiago/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinsTiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinsTiago/subscriptions","organizations_url":"https://api.github.com/users/MartinsTiago/orgs","repos_url":"https://api.github.com/users/MartinsTiago/repos","events_url":"https://api.github.com/users/MartinsTiago/events{/privacy}","received_events_url":"https://api.github.com/users/MartinsTiago/received_events","type":"User","site_admin":false},"body":"On this PR, it's implemented a custom configuration to enable or disable the events tracking on a application initializer. It is defaulted to `true`, but, if necessary, the implementing application can set it to `false`, in order to stop the application of setting session variables for the user.","created_at":"2016-05-02T14:20:01Z","updated_at":"2016-05-02T16:24:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72385e85ac86be45f6a3cce114206226a272c50c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appprova/action_tracker/pulls/17/commits","review_comments_url":"https://api.github.com/repos/appprova/action_tracker/pulls/17/comments","review_comment_url":"https://api.github.com/repos/appprova/action_tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appprova/action_tracker/issues/17/comments","statuses_url":"https://api.github.com/repos/appprova/action_tracker/statuses/f2595725cdb86819b7137af4b61bc73ce389e04a","head":{"label":"appprova:feature/conditional-events-tracking","ref":"feature/conditional-events-tracking","sha":"f2595725cdb86819b7137af4b61bc73ce389e04a","user":{"login":"appprova","id":5629909,"avatar_url":"https://avatars.githubusercontent.com/u/5629909?v=3","gravatar_id":"","url":"https://api.github.com/users/appprova","html_url":"https://github.com/appprova","followers_url":"https://api.github.com/users/appprova/followers","following_url":"https://api.github.com/users/appprova/following{/other_user}","gists_url":"https://api.github.com/users/appprova/gists{/gist_id}","starred_url":"https://api.github.com/users/appprova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appprova/subscriptions","organizations_url":"https://api.github.com/users/appprova/orgs","repos_url":"https://api.github.com/users/appprova/repos","events_url":"https://api.github.com/users/appprova/events{/privacy}","received_events_url":"https://api.github.com/users/appprova/received_events","type":"Organization","site_admin":false},"repo":{"id":56261104,"name":"action_tracker","full_name":"appprova/action_tracker","owner":{"login":"appprova","id":5629909,"avatar_url":"https://avatars.githubusercontent.com/u/5629909?v=3","gravatar_id":"","url":"https://api.github.com/users/appprova","html_url":"https://github.com/appprova","followers_url":"https://api.github.com/users/appprova/followers","following_url":"https://api.github.com/users/appprova/following{/other_user}","gists_url":"https://api.github.com/users/appprova/gists{/gist_id}","starred_url":"https://api.github.com/users/appprova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appprova/subscriptions","organizations_url":"https://api.github.com/users/appprova/orgs","repos_url":"https://api.github.com/users/appprova/repos","events_url":"https://api.github.com/users/appprova/events{/privacy}","received_events_url":"https://api.github.com/users/appprova/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appprova/action_tracker","description":"Easy way to track actions in your application","fork":false,"url":"https://api.github.com/repos/appprova/action_tracker","forks_url":"https://api.github.com/repos/appprova/action_tracker/forks","keys_url":"https://api.github.com/repos/appprova/action_tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appprova/action_tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appprova/action_tracker/teams","hooks_url":"https://api.github.com/repos/appprova/action_tracker/hooks","issue_events_url":"https://api.github.com/repos/appprova/action_tracker/issues/events{/number}","events_url":"https://api.github.com/repos/appprova/action_tracker/events","assignees_url":"https://api.github.com/repos/appprova/action_tracker/assignees{/user}","branches_url":"https://api.github.com/repos/appprova/action_tracker/branches{/branch}","tags_url":"https://api.github.com/repos/appprova/action_tracker/tags","blobs_url":"https://api.github.com/repos/appprova/action_tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appprova/action_tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appprova/action_tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/appprova/action_tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appprova/action_tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/appprova/action_tracker/languages","stargazers_url":"https://api.github.com/repos/appprova/action_tracker/stargazers","contributors_url":"https://api.github.com/repos/appprova/action_tracker/contributors","subscribers_url":"https://api.github.com/repos/appprova/action_tracker/subscribers","subscription_url":"https://api.github.com/repos/appprova/action_tracker/subscription","commits_url":"https://api.github.com/repos/appprova/action_tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/appprova/action_tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/appprova/action_tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/appprova/action_tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/appprova/action_tracker/contents/{+path}","compare_url":"https://api.github.com/repos/appprova/action_tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appprova/action_tracker/merges","archive_url":"https://api.github.com/repos/appprova/action_tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appprova/action_tracker/downloads","issues_url":"https://api.github.com/repos/appprova/action_tracker/issues{/number}","pulls_url":"https://api.github.com/repos/appprova/action_tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/appprova/action_tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/appprova/action_tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appprova/action_tracker/labels{/name}","releases_url":"https://api.github.com/repos/appprova/action_tracker/releases{/id}","deployments_url":"https://api.github.com/repos/appprova/action_tracker/deployments","created_at":"2016-04-14T18:32:32Z","updated_at":"2016-04-28T18:37:09Z","pushed_at":"2016-05-02T16:10:00Z","git_url":"git://github.com/appprova/action_tracker.git","ssh_url":"git@github.com:appprova/action_tracker.git","clone_url":"https://github.com/appprova/action_tracker.git","svn_url":"https://github.com/appprova/action_tracker","homepage":null,"size":50,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"develop"}},"base":{"label":"appprova:develop","ref":"develop","sha":"f4e5034beb92ab90c2e82f520e51635ad90941e9","user":{"login":"appprova","id":5629909,"avatar_url":"https://avatars.githubusercontent.com/u/5629909?v=3","gravatar_id":"","url":"https://api.github.com/users/appprova","html_url":"https://github.com/appprova","followers_url":"https://api.github.com/users/appprova/followers","following_url":"https://api.github.com/users/appprova/following{/other_user}","gists_url":"https://api.github.com/users/appprova/gists{/gist_id}","starred_url":"https://api.github.com/users/appprova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appprova/subscriptions","organizations_url":"https://api.github.com/users/appprova/orgs","repos_url":"https://api.github.com/users/appprova/repos","events_url":"https://api.github.com/users/appprova/events{/privacy}","received_events_url":"https://api.github.com/users/appprova/received_events","type":"Organization","site_admin":false},"repo":{"id":56261104,"name":"action_tracker","full_name":"appprova/action_tracker","owner":{"login":"appprova","id":5629909,"avatar_url":"https://avatars.githubusercontent.com/u/5629909?v=3","gravatar_id":"","url":"https://api.github.com/users/appprova","html_url":"https://github.com/appprova","followers_url":"https://api.github.com/users/appprova/followers","following_url":"https://api.github.com/users/appprova/following{/other_user}","gists_url":"https://api.github.com/users/appprova/gists{/gist_id}","starred_url":"https://api.github.com/users/appprova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appprova/subscriptions","organizations_url":"https://api.github.com/users/appprova/orgs","repos_url":"https://api.github.com/users/appprova/repos","events_url":"https://api.github.com/users/appprova/events{/privacy}","received_events_url":"https://api.github.com/users/appprova/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appprova/action_tracker","description":"Easy way to track actions in your application","fork":false,"url":"https://api.github.com/repos/appprova/action_tracker","forks_url":"https://api.github.com/repos/appprova/action_tracker/forks","keys_url":"https://api.github.com/repos/appprova/action_tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appprova/action_tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appprova/action_tracker/teams","hooks_url":"https://api.github.com/repos/appprova/action_tracker/hooks","issue_events_url":"https://api.github.com/repos/appprova/action_tracker/issues/events{/number}","events_url":"https://api.github.com/repos/appprova/action_tracker/events","assignees_url":"https://api.github.com/repos/appprova/action_tracker/assignees{/user}","branches_url":"https://api.github.com/repos/appprova/action_tracker/branches{/branch}","tags_url":"https://api.github.com/repos/appprova/action_tracker/tags","blobs_url":"https://api.github.com/repos/appprova/action_tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appprova/action_tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appprova/action_tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/appprova/action_tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appprova/action_tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/appprova/action_tracker/languages","stargazers_url":"https://api.github.com/repos/appprova/action_tracker/stargazers","contributors_url":"https://api.github.com/repos/appprova/action_tracker/contributors","subscribers_url":"https://api.github.com/repos/appprova/action_tracker/subscribers","subscription_url":"https://api.github.com/repos/appprova/action_tracker/subscription","commits_url":"https://api.github.com/repos/appprova/action_tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/appprova/action_tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/appprova/action_tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/appprova/action_tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/appprova/action_tracker/contents/{+path}","compare_url":"https://api.github.com/repos/appprova/action_tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appprova/action_tracker/merges","archive_url":"https://api.github.com/repos/appprova/action_tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appprova/action_tracker/downloads","issues_url":"https://api.github.com/repos/appprova/action_tracker/issues{/number}","pulls_url":"https://api.github.com/repos/appprova/action_tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/appprova/action_tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/appprova/action_tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appprova/action_tracker/labels{/name}","releases_url":"https://api.github.com/repos/appprova/action_tracker/releases{/id}","deployments_url":"https://api.github.com/repos/appprova/action_tracker/deployments","created_at":"2016-04-14T18:32:32Z","updated_at":"2016-04-28T18:37:09Z","pushed_at":"2016-05-02T16:10:00Z","git_url":"git://github.com/appprova/action_tracker.git","ssh_url":"git@github.com:appprova/action_tracker.git","clone_url":"https://github.com/appprova/action_tracker.git","svn_url":"https://github.com/appprova/action_tracker","homepage":null,"size":50,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/17"},"html":{"href":"https://github.com/appprova/action_tracker/pull/17"},"issue":{"href":"https://api.github.com/repos/appprova/action_tracker/issues/17"},"comments":{"href":"https://api.github.com/repos/appprova/action_tracker/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appprova/action_tracker/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/appprova/action_tracker/statuses/f2595725cdb86819b7137af4b61bc73ce389e04a"}}}}