{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6754","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6754/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6754/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6754/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6754","id":155349692,"number":6754,"title":"server: support protobuf-over-HTTP","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-05-17T20:08:32Z","updated_at":"2016-05-20T14:57:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6754","html_url":"https://github.com/cockroachdb/cockroach/pull/6754","diff_url":"https://github.com/cockroachdb/cockroach/pull/6754.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6754.patch"},"body":"<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6754)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/220629113","html_url":"https://github.com/cockroachdb/cockroach/pull/6754#issuecomment-220629113","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6754","id":220629113,"user":{"login":"d4l3k","id":909104,"avatar_url":"https://avatars.githubusercontent.com/u/909104?v=3","gravatar_id":"","url":"https://api.github.com/users/d4l3k","html_url":"https://github.com/d4l3k","followers_url":"https://api.github.com/users/d4l3k/followers","following_url":"https://api.github.com/users/d4l3k/following{/other_user}","gists_url":"https://api.github.com/users/d4l3k/gists{/gist_id}","starred_url":"https://api.github.com/users/d4l3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d4l3k/subscriptions","organizations_url":"https://api.github.com/users/d4l3k/orgs","repos_url":"https://api.github.com/users/d4l3k/repos","events_url":"https://api.github.com/users/d4l3k/events{/privacy}","received_events_url":"https://api.github.com/users/d4l3k/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T14:57:25Z","updated_at":"2016-05-20T14:57:25Z","body":"\n\n\n\n\n\nReviewed 2 of 2 files at r7.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.\n\n---\n\n*[util/jsonpb_marshal.go, line 30 \\[r6\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/6754#-KI9043DqEe64dkAaqm9:-KIDeOTEDQ3kZAQsFKnW:-1024557721) ([raw file](https://github.com/cockroachdb/cockroach/blob/dbb0756a0c44e35c238da810ed9b48fe09282260/util/jsonpb_marshal.go#L30)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> Not sure what you mean; in your sentence, what is \"this\"? The docs are reachable via go-to-definition from just two lines up from here.\n</details>\nFair enough.\n\n---\n\n*[util/jsonpb_marshal.go, line 31 \\[r6\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/6754#-KI90fJV8Qc2lvbwHWLM:-KIDeS-ZdwXofJlK0ZUp:1826585197) ([raw file](https://github.com/cockroachdb/cockroach/blob/dbb0756a0c44e35c238da810ed9b48fe09282260/util/jsonpb_marshal.go#L31)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> Upstream uses `golang/protobuf/jsonpb`; this uses `gogo/protobuf/jsonpb`. The former doesn't correctly handle protobuf structs generated by the latter.\n</details>\nMake sense.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/6754)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"d4l3k"}}