{"action":"created","comment":{"url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/comments/49267932","id":49267932,"diff_hunk":"@@ -102,19 +102,21 @@ private Width(final int width) {\n     }\n \n     static enum TupleType {\n-        BYTES(0),\n-        STRING(1),\n-        UINT(2),\n-        INT(3);\n+        BYTES(0, \"bytes\"),\n+        STRING(1, \"string\"),\n+        UINT(2, \"uint\"),\n+        INT(3, \"int\");\n \n         public final byte ord;\n+        private String name;\n \n-        private TupleType(int ord) {\n+        private TupleType(int ord, String name) {\n             this.ord = (byte) ord;\n+            this.name = name;\n         }\n \n         public String getName() {\n-            return name().toLowerCase();\n+            return name;","path":"PebbleKit/PebbleKit/src/main/java/com/getpebble/android/kit/util/PebbleTuple.java","position":24,"original_position":24,"commit_id":"887940f684b5093272590351f47ac7acefab74fd","original_commit_id":"887940f684b5093272590351f47ac7acefab74fd","user":{"login":"rastadrian","id":982808,"avatar_url":"https://avatars.githubusercontent.com/u/982808?v=3","gravatar_id":"","url":"https://api.github.com/users/rastadrian","html_url":"https://github.com/rastadrian","followers_url":"https://api.github.com/users/rastadrian/followers","following_url":"https://api.github.com/users/rastadrian/following{/other_user}","gists_url":"https://api.github.com/users/rastadrian/gists{/gist_id}","starred_url":"https://api.github.com/users/rastadrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rastadrian/subscriptions","organizations_url":"https://api.github.com/users/rastadrian/orgs","repos_url":"https://api.github.com/users/rastadrian/repos","events_url":"https://api.github.com/users/rastadrian/events{/privacy}","received_events_url":"https://api.github.com/users/rastadrian/received_events","type":"User","site_admin":false},"body":"agree, it seems overly engineered for the purpose.","created_at":"2016-01-09T20:35:17Z","updated_at":"2016-01-09T20:35:17Z","html_url":"https://github.com/pebble/pebble-android-sdk/pull/5#discussion_r49267932","pull_request_url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/comments/49267932"},"html":{"href":"https://github.com/pebble/pebble-android-sdk/pull/5#discussion_r49267932"},"pull_request":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5","id":55481526,"html_url":"https://github.com/pebble/pebble-android-sdk/pull/5","diff_url":"https://github.com/pebble/pebble-android-sdk/pull/5.diff","patch_url":"https://github.com/pebble/pebble-android-sdk/pull/5.patch","issue_url":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/5","number":5,"state":"open","locked":false,"title":"Do not use toLowerCase() for determining JSON keys.","user":{"login":"matejdro","id":507922,"avatar_url":"https://avatars.githubusercontent.com/u/507922?v=3","gravatar_id":"","url":"https://api.github.com/users/matejdro","html_url":"https://github.com/matejdro","followers_url":"https://api.github.com/users/matejdro/followers","following_url":"https://api.github.com/users/matejdro/following{/other_user}","gists_url":"https://api.github.com/users/matejdro/gists{/gist_id}","starred_url":"https://api.github.com/users/matejdro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejdro/subscriptions","organizations_url":"https://api.github.com/users/matejdro/orgs","repos_url":"https://api.github.com/users/matejdro/repos","events_url":"https://api.github.com/users/matejdro/events{/privacy}","received_events_url":"https://api.github.com/users/matejdro/received_events","type":"User","site_admin":false},"body":"toLowerCase() method in Android is Locale-dependent. That means that in some languages method may return different result than one expected. And since this is used to determine JSON keys, it may cause parsing failure.\r\n\r\nDue to this issue, PebbleKit for Android does not work if your language is set to Turkish for example.","created_at":"2016-01-08T16:34:28Z","updated_at":"2016-01-09T20:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e125f7e821b3bd0e03c267b9829b62c9efa56604","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5/commits","review_comments_url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5/comments","review_comment_url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/5/comments","statuses_url":"https://api.github.com/repos/pebble/pebble-android-sdk/statuses/887940f684b5093272590351f47ac7acefab74fd","head":{"label":"matejdro:master","ref":"master","sha":"887940f684b5093272590351f47ac7acefab74fd","user":{"login":"matejdro","id":507922,"avatar_url":"https://avatars.githubusercontent.com/u/507922?v=3","gravatar_id":"","url":"https://api.github.com/users/matejdro","html_url":"https://github.com/matejdro","followers_url":"https://api.github.com/users/matejdro/followers","following_url":"https://api.github.com/users/matejdro/following{/other_user}","gists_url":"https://api.github.com/users/matejdro/gists{/gist_id}","starred_url":"https://api.github.com/users/matejdro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejdro/subscriptions","organizations_url":"https://api.github.com/users/matejdro/orgs","repos_url":"https://api.github.com/users/matejdro/repos","events_url":"https://api.github.com/users/matejdro/events{/privacy}","received_events_url":"https://api.github.com/users/matejdro/received_events","type":"User","site_admin":false},"repo":{"id":49272863,"name":"pebble-android-sdk","full_name":"matejdro/pebble-android-sdk","owner":{"login":"matejdro","id":507922,"avatar_url":"https://avatars.githubusercontent.com/u/507922?v=3","gravatar_id":"","url":"https://api.github.com/users/matejdro","html_url":"https://github.com/matejdro","followers_url":"https://api.github.com/users/matejdro/followers","following_url":"https://api.github.com/users/matejdro/following{/other_user}","gists_url":"https://api.github.com/users/matejdro/gists{/gist_id}","starred_url":"https://api.github.com/users/matejdro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejdro/subscriptions","organizations_url":"https://api.github.com/users/matejdro/orgs","repos_url":"https://api.github.com/users/matejdro/repos","events_url":"https://api.github.com/users/matejdro/events{/privacy}","received_events_url":"https://api.github.com/users/matejdro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matejdro/pebble-android-sdk","description":"Android PebbleKit SDK to talk to the Pebble via Bluetooth","fork":true,"url":"https://api.github.com/repos/matejdro/pebble-android-sdk","forks_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/forks","keys_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/teams","hooks_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/events","assignees_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/tags","blobs_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/languages","stargazers_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/subscription","commits_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/merges","archive_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/downloads","issues_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/matejdro/pebble-android-sdk/releases{/id}","created_at":"2016-01-08T13:14:05Z","updated_at":"2016-01-08T13:14:06Z","pushed_at":"2016-01-08T16:32:02Z","git_url":"git://github.com/matejdro/pebble-android-sdk.git","ssh_url":"git@github.com:matejdro/pebble-android-sdk.git","clone_url":"https://github.com/matejdro/pebble-android-sdk.git","svn_url":"https://github.com/matejdro/pebble-android-sdk","homepage":null,"size":2162,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pebble:master","ref":"master","sha":"625e63b460bfbc295a768dfa751d2050f8cf540f","user":{"login":"pebble","id":1048268,"avatar_url":"https://avatars.githubusercontent.com/u/1048268?v=3","gravatar_id":"","url":"https://api.github.com/users/pebble","html_url":"https://github.com/pebble","followers_url":"https://api.github.com/users/pebble/followers","following_url":"https://api.github.com/users/pebble/following{/other_user}","gists_url":"https://api.github.com/users/pebble/gists{/gist_id}","starred_url":"https://api.github.com/users/pebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pebble/subscriptions","organizations_url":"https://api.github.com/users/pebble/orgs","repos_url":"https://api.github.com/users/pebble/repos","events_url":"https://api.github.com/users/pebble/events{/privacy}","received_events_url":"https://api.github.com/users/pebble/received_events","type":"Organization","site_admin":false},"repo":{"id":21903818,"name":"pebble-android-sdk","full_name":"pebble/pebble-android-sdk","owner":{"login":"pebble","id":1048268,"avatar_url":"https://avatars.githubusercontent.com/u/1048268?v=3","gravatar_id":"","url":"https://api.github.com/users/pebble","html_url":"https://github.com/pebble","followers_url":"https://api.github.com/users/pebble/followers","following_url":"https://api.github.com/users/pebble/following{/other_user}","gists_url":"https://api.github.com/users/pebble/gists{/gist_id}","starred_url":"https://api.github.com/users/pebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pebble/subscriptions","organizations_url":"https://api.github.com/users/pebble/orgs","repos_url":"https://api.github.com/users/pebble/repos","events_url":"https://api.github.com/users/pebble/events{/privacy}","received_events_url":"https://api.github.com/users/pebble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pebble/pebble-android-sdk","description":"Android PebbleKit SDK to talk to the Pebble via Bluetooth","fork":false,"url":"https://api.github.com/repos/pebble/pebble-android-sdk","forks_url":"https://api.github.com/repos/pebble/pebble-android-sdk/forks","keys_url":"https://api.github.com/repos/pebble/pebble-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pebble/pebble-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pebble/pebble-android-sdk/teams","hooks_url":"https://api.github.com/repos/pebble/pebble-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/pebble/pebble-android-sdk/events","assignees_url":"https://api.github.com/repos/pebble/pebble-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/pebble/pebble-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/pebble/pebble-android-sdk/tags","blobs_url":"https://api.github.com/repos/pebble/pebble-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pebble/pebble-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pebble/pebble-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/pebble/pebble-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pebble/pebble-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/pebble/pebble-android-sdk/languages","stargazers_url":"https://api.github.com/repos/pebble/pebble-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/pebble/pebble-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/pebble/pebble-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/pebble/pebble-android-sdk/subscription","commits_url":"https://api.github.com/repos/pebble/pebble-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/pebble/pebble-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/pebble/pebble-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/pebble/pebble-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/pebble/pebble-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pebble/pebble-android-sdk/merges","archive_url":"https://api.github.com/repos/pebble/pebble-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pebble/pebble-android-sdk/downloads","issues_url":"https://api.github.com/repos/pebble/pebble-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/pebble/pebble-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/pebble/pebble-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pebble/pebble-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/pebble/pebble-android-sdk/releases{/id}","created_at":"2014-07-16T14:22:35Z","updated_at":"2015-12-30T11:26:16Z","pushed_at":"2016-01-08T16:34:28Z","git_url":"git://github.com/pebble/pebble-android-sdk.git","ssh_url":"git@github.com:pebble/pebble-android-sdk.git","clone_url":"https://github.com/pebble/pebble-android-sdk.git","svn_url":"https://github.com/pebble/pebble-android-sdk","homepage":null,"size":2387,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5"},"html":{"href":"https://github.com/pebble/pebble-android-sdk/pull/5"},"issue":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/5"},"comments":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/pebble/pebble-android-sdk/statuses/887940f684b5093272590351f47ac7acefab74fd"}}}}