{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/75899027","id":75899027,"diff_hunk":"@@ -50,16 +50,19 @@\n import java.util.List;\n import java.util.Map;\n \n+@SuppressWarnings(\"rawtypes\")\n public class PipelineTriggersJobProperty extends JobProperty<WorkflowJob> {\n     private List<Trigger<?>> triggers = new ArrayList<>();\n \n     @DataBoundConstructor\n-    public PipelineTriggersJobProperty(List<Trigger<?>> triggers) {\n+    public PipelineTriggersJobProperty(List<Trigger> triggers) {\n         // Defensive handling of when we get called via {@code Descriptor.newInstance} with no form data.\n         if (triggers == null) {\n             this.triggers = new ArrayList<>();\n         } else {\n-            this.triggers = triggers;\n+            for (Trigger t : triggers) {\n+                this.triggers.add((Trigger<?>)t);\n+            }","path":"src/main/java/org/jenkinsci/plugins/workflow/job/properties/PipelineTriggersJobProperty.java","position":18,"original_position":18,"commit_id":"b7e4bf92c00e409521d8651afd068202acbdc801","original_commit_id":"0fcaff04e2982488ff895668ad62b80ecea949aa","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"You can use an unchecked cast, would reduce code changes.","created_at":"2016-08-23T16:10:18Z","updated_at":"2016-08-23T16:10:18Z","html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/17#discussion_r75899027","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/75899027"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/17#discussion_r75899027"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17","id":82223848,"html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/17","diff_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/17.diff","patch_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/17.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/17","number":17,"state":"open","locked":false,"title":"[FIXED JENKINS-37477] - Docs and snippet generator work properly for triggers.","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"[JENKINS-37477](https://issues.jenkins-ci.org/browse/JENKINS-37477)\r\n\r\n- [x] Fix doc generation.\r\n- [x] Fix snippet generator\r\n\r\nSnippet generator still not working, so more work to do.\r\n\r\ncc @reviewbybees esp @jglick @kwhetstone","created_at":"2016-08-22T16:42:24Z","updated_at":"2016-08-23T16:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2062f52daedee4761af899c22773c5573bd71d98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/17/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/b7e4bf92c00e409521d8651afd068202acbdc801","head":{"label":"abayer:jenkins-37477","ref":"jenkins-37477","sha":"b7e4bf92c00e409521d8651afd068202acbdc801","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":59842920,"name":"workflow-job-plugin","full_name":"abayer/workflow-job-plugin","owner":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/workflow-job-plugin","description":"","fork":true,"url":"https://api.github.com/repos/abayer/workflow-job-plugin","forks_url":"https://api.github.com/repos/abayer/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/abayer/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/abayer/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/abayer/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/abayer/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/abayer/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/abayer/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/abayer/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/abayer/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/abayer/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/abayer/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/workflow-job-plugin/deployments","created_at":"2016-05-27T15:03:51Z","updated_at":"2016-05-27T15:03:52Z","pushed_at":"2016-08-23T15:59:14Z","git_url":"git://github.com/abayer/workflow-job-plugin.git","ssh_url":"git@github.com:abayer/workflow-job-plugin.git","clone_url":"https://github.com/abayer/workflow-job-plugin.git","svn_url":"https://github.com/abayer/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"6e3d7f4c1bea84eadcf0e14d6b2044116da88a48","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543389,"name":"workflow-job-plugin","full_name":"jenkinsci/workflow-job-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-job-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/deployments","created_at":"2016-04-05T20:27:07Z","updated_at":"2016-08-20T14:25:23Z","pushed_at":"2016-08-23T15:59:14Z","git_url":"git://github.com/jenkinsci/workflow-job-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-job-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-job-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":387,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/17"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/17"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/b7e4bf92c00e409521d8651afd068202acbdc801"}}}}
{"actor":{"display_login":"jglick"}}