{"action":"created","comment":{"url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/comments/77321033","id":77321033,"diff_hunk":"@@ -126,41 +126,37 @@\n #\n \n module RDP\n-  \n+\n   class NegReqAction\n-    \n+\n     def initialize(socket)\n       @socket = socket\n     end\n-    \n+\n     def read_tpkt\n-      \n+\n       payload      = @socket.read(4) unless @socket.closed?\n-      \n+\n       # can be nil with some clients, that is no headers were sent again/first time\n       return false if payload.nil?\n-      \n+\n       @tpkt_header = TPKTHeaderParser.new(payload)\n-      \n+\n       true\n     end\n-    \n+\n     def read_x224_crq\n       to_read      = @tpkt_header.data - RDP::TPKT_HEADER_LENGTH # size to read minus the header size\n       full_data    = @socket.read(to_read).to_s\n-      \n+\n       @x224_header = X224Header.new(full_data)\n-    \n+","path":"lib/rdp/negotiation/rdp_negotition.rb","position":38,"original_position":38,"commit_id":"b11ab0f468828f6f17c00b821b18bdabcf334730","original_commit_id":"b11ab0f468828f6f17c00b821b18bdabcf334730","user":{"login":"dhiachou","id":6137390,"avatar_url":"https://avatars.githubusercontent.com/u/6137390?v=3","gravatar_id":"","url":"https://api.github.com/users/dhiachou","html_url":"https://github.com/dhiachou","followers_url":"https://api.github.com/users/dhiachou/followers","following_url":"https://api.github.com/users/dhiachou/following{/other_user}","gists_url":"https://api.github.com/users/dhiachou/gists{/gist_id}","starred_url":"https://api.github.com/users/dhiachou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhiachou/subscriptions","organizations_url":"https://api.github.com/users/dhiachou/orgs","repos_url":"https://api.github.com/users/dhiachou/repos","events_url":"https://api.github.com/users/dhiachou/events{/privacy}","received_events_url":"https://api.github.com/users/dhiachou/received_events","type":"User","site_admin":false},"body":"same as above","created_at":"2016-09-02T09:47:21Z","updated_at":"2016-09-02T09:47:21Z","html_url":"https://github.com/Safe-T/rdp-rb/pull/9#discussion_r77321033","pull_request_url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/comments/77321033"},"html":{"href":"https://github.com/Safe-T/rdp-rb/pull/9#discussion_r77321033"},"pull_request":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9","id":83751781,"html_url":"https://github.com/Safe-T/rdp-rb/pull/9","diff_url":"https://github.com/Safe-T/rdp-rb/pull/9.diff","patch_url":"https://github.com/Safe-T/rdp-rb/pull/9.patch","issue_url":"https://api.github.com/repos/Safe-T/rdp-rb/issues/9","number":9,"state":"open","locked":false,"title":"Fix style issues","user":{"login":"orgads","id":1246544,"avatar_url":"https://avatars.githubusercontent.com/u/1246544?v=3","gravatar_id":"","url":"https://api.github.com/users/orgads","html_url":"https://github.com/orgads","followers_url":"https://api.github.com/users/orgads/followers","following_url":"https://api.github.com/users/orgads/following{/other_user}","gists_url":"https://api.github.com/users/orgads/gists{/gist_id}","starred_url":"https://api.github.com/users/orgads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orgads/subscriptions","organizations_url":"https://api.github.com/users/orgads/orgs","repos_url":"https://api.github.com/users/orgads/repos","events_url":"https://api.github.com/users/orgads/events{/privacy}","received_events_url":"https://api.github.com/users/orgads/received_events","type":"User","site_admin":false},"body":"\\+ some real errors","created_at":"2016-09-02T06:32:18Z","updated_at":"2016-09-02T09:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"147654eeb46b5376bc981a97e3cf5797f957a615","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Safe-T/rdp-rb/issues/9/comments","statuses_url":"https://api.github.com/repos/Safe-T/rdp-rb/statuses/b11ab0f468828f6f17c00b821b18bdabcf334730","head":{"label":"orgads:style","ref":"style","sha":"b11ab0f468828f6f17c00b821b18bdabcf334730","user":{"login":"orgads","id":1246544,"avatar_url":"https://avatars.githubusercontent.com/u/1246544?v=3","gravatar_id":"","url":"https://api.github.com/users/orgads","html_url":"https://github.com/orgads","followers_url":"https://api.github.com/users/orgads/followers","following_url":"https://api.github.com/users/orgads/following{/other_user}","gists_url":"https://api.github.com/users/orgads/gists{/gist_id}","starred_url":"https://api.github.com/users/orgads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orgads/subscriptions","organizations_url":"https://api.github.com/users/orgads/orgs","repos_url":"https://api.github.com/users/orgads/repos","events_url":"https://api.github.com/users/orgads/events{/privacy}","received_events_url":"https://api.github.com/users/orgads/received_events","type":"User","site_admin":false},"repo":{"id":67194098,"name":"rdp-rb","full_name":"orgads/rdp-rb","owner":{"login":"orgads","id":1246544,"avatar_url":"https://avatars.githubusercontent.com/u/1246544?v=3","gravatar_id":"","url":"https://api.github.com/users/orgads","html_url":"https://github.com/orgads","followers_url":"https://api.github.com/users/orgads/followers","following_url":"https://api.github.com/users/orgads/following{/other_user}","gists_url":"https://api.github.com/users/orgads/gists{/gist_id}","starred_url":"https://api.github.com/users/orgads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orgads/subscriptions","organizations_url":"https://api.github.com/users/orgads/orgs","repos_url":"https://api.github.com/users/orgads/repos","events_url":"https://api.github.com/users/orgads/events{/privacy}","received_events_url":"https://api.github.com/users/orgads/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orgads/rdp-rb","description":"Implementation in pure Ruby for Microsoft RDP protocol","fork":true,"url":"https://api.github.com/repos/orgads/rdp-rb","forks_url":"https://api.github.com/repos/orgads/rdp-rb/forks","keys_url":"https://api.github.com/repos/orgads/rdp-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orgads/rdp-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orgads/rdp-rb/teams","hooks_url":"https://api.github.com/repos/orgads/rdp-rb/hooks","issue_events_url":"https://api.github.com/repos/orgads/rdp-rb/issues/events{/number}","events_url":"https://api.github.com/repos/orgads/rdp-rb/events","assignees_url":"https://api.github.com/repos/orgads/rdp-rb/assignees{/user}","branches_url":"https://api.github.com/repos/orgads/rdp-rb/branches{/branch}","tags_url":"https://api.github.com/repos/orgads/rdp-rb/tags","blobs_url":"https://api.github.com/repos/orgads/rdp-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orgads/rdp-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orgads/rdp-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/orgads/rdp-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orgads/rdp-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/orgads/rdp-rb/languages","stargazers_url":"https://api.github.com/repos/orgads/rdp-rb/stargazers","contributors_url":"https://api.github.com/repos/orgads/rdp-rb/contributors","subscribers_url":"https://api.github.com/repos/orgads/rdp-rb/subscribers","subscription_url":"https://api.github.com/repos/orgads/rdp-rb/subscription","commits_url":"https://api.github.com/repos/orgads/rdp-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/orgads/rdp-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/orgads/rdp-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/orgads/rdp-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/orgads/rdp-rb/contents/{+path}","compare_url":"https://api.github.com/repos/orgads/rdp-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orgads/rdp-rb/merges","archive_url":"https://api.github.com/repos/orgads/rdp-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orgads/rdp-rb/downloads","issues_url":"https://api.github.com/repos/orgads/rdp-rb/issues{/number}","pulls_url":"https://api.github.com/repos/orgads/rdp-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/orgads/rdp-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/orgads/rdp-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orgads/rdp-rb/labels{/name}","releases_url":"https://api.github.com/repos/orgads/rdp-rb/releases{/id}","deployments_url":"https://api.github.com/repos/orgads/rdp-rb/deployments","created_at":"2016-09-02T05:51:45Z","updated_at":"2016-09-02T05:51:46Z","pushed_at":"2016-09-02T06:39:09Z","git_url":"git://github.com/orgads/rdp-rb.git","ssh_url":"git@github.com:orgads/rdp-rb.git","clone_url":"https://github.com/orgads/rdp-rb.git","svn_url":"https://github.com/orgads/rdp-rb","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Safe-T:master","ref":"master","sha":"f384e9b6913cecd25952b7fe5483736e2495f9b3","user":{"login":"Safe-T","id":11737948,"avatar_url":"https://avatars.githubusercontent.com/u/11737948?v=3","gravatar_id":"","url":"https://api.github.com/users/Safe-T","html_url":"https://github.com/Safe-T","followers_url":"https://api.github.com/users/Safe-T/followers","following_url":"https://api.github.com/users/Safe-T/following{/other_user}","gists_url":"https://api.github.com/users/Safe-T/gists{/gist_id}","starred_url":"https://api.github.com/users/Safe-T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safe-T/subscriptions","organizations_url":"https://api.github.com/users/Safe-T/orgs","repos_url":"https://api.github.com/users/Safe-T/repos","events_url":"https://api.github.com/users/Safe-T/events{/privacy}","received_events_url":"https://api.github.com/users/Safe-T/received_events","type":"Organization","site_admin":false},"repo":{"id":67125385,"name":"rdp-rb","full_name":"Safe-T/rdp-rb","owner":{"login":"Safe-T","id":11737948,"avatar_url":"https://avatars.githubusercontent.com/u/11737948?v=3","gravatar_id":"","url":"https://api.github.com/users/Safe-T","html_url":"https://github.com/Safe-T","followers_url":"https://api.github.com/users/Safe-T/followers","following_url":"https://api.github.com/users/Safe-T/following{/other_user}","gists_url":"https://api.github.com/users/Safe-T/gists{/gist_id}","starred_url":"https://api.github.com/users/Safe-T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safe-T/subscriptions","organizations_url":"https://api.github.com/users/Safe-T/orgs","repos_url":"https://api.github.com/users/Safe-T/repos","events_url":"https://api.github.com/users/Safe-T/events{/privacy}","received_events_url":"https://api.github.com/users/Safe-T/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Safe-T/rdp-rb","description":"Implementation in pure Ruby for Microsoft RDP protocol","fork":false,"url":"https://api.github.com/repos/Safe-T/rdp-rb","forks_url":"https://api.github.com/repos/Safe-T/rdp-rb/forks","keys_url":"https://api.github.com/repos/Safe-T/rdp-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Safe-T/rdp-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Safe-T/rdp-rb/teams","hooks_url":"https://api.github.com/repos/Safe-T/rdp-rb/hooks","issue_events_url":"https://api.github.com/repos/Safe-T/rdp-rb/issues/events{/number}","events_url":"https://api.github.com/repos/Safe-T/rdp-rb/events","assignees_url":"https://api.github.com/repos/Safe-T/rdp-rb/assignees{/user}","branches_url":"https://api.github.com/repos/Safe-T/rdp-rb/branches{/branch}","tags_url":"https://api.github.com/repos/Safe-T/rdp-rb/tags","blobs_url":"https://api.github.com/repos/Safe-T/rdp-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Safe-T/rdp-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Safe-T/rdp-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Safe-T/rdp-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Safe-T/rdp-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/Safe-T/rdp-rb/languages","stargazers_url":"https://api.github.com/repos/Safe-T/rdp-rb/stargazers","contributors_url":"https://api.github.com/repos/Safe-T/rdp-rb/contributors","subscribers_url":"https://api.github.com/repos/Safe-T/rdp-rb/subscribers","subscription_url":"https://api.github.com/repos/Safe-T/rdp-rb/subscription","commits_url":"https://api.github.com/repos/Safe-T/rdp-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Safe-T/rdp-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Safe-T/rdp-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Safe-T/rdp-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Safe-T/rdp-rb/contents/{+path}","compare_url":"https://api.github.com/repos/Safe-T/rdp-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Safe-T/rdp-rb/merges","archive_url":"https://api.github.com/repos/Safe-T/rdp-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Safe-T/rdp-rb/downloads","issues_url":"https://api.github.com/repos/Safe-T/rdp-rb/issues{/number}","pulls_url":"https://api.github.com/repos/Safe-T/rdp-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/Safe-T/rdp-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/Safe-T/rdp-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Safe-T/rdp-rb/labels{/name}","releases_url":"https://api.github.com/repos/Safe-T/rdp-rb/releases{/id}","deployments_url":"https://api.github.com/repos/Safe-T/rdp-rb/deployments","created_at":"2016-09-01T11:28:21Z","updated_at":"2016-09-02T06:56:15Z","pushed_at":"2016-09-02T06:39:09Z","git_url":"git://github.com/Safe-T/rdp-rb.git","ssh_url":"git@github.com:Safe-T/rdp-rb.git","clone_url":"https://github.com/Safe-T/rdp-rb.git","svn_url":"https://github.com/Safe-T/rdp-rb","homepage":null,"size":21,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9"},"html":{"href":"https://github.com/Safe-T/rdp-rb/pull/9"},"issue":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/issues/9"},"comments":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Safe-T/rdp-rb/statuses/b11ab0f468828f6f17c00b821b18bdabcf334730"}}}}
{"actor":{"display_login":"dhiachou"}}