{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/comments/80264343","id":80264343,"diff_hunk":"@@ -19,31 +19,29 @@\n   end\n \n   describe 'attributes' do\n-    context 'mandatory' do\n-      it 'name' do\n-        correspondence.name = nil\n-        expect(correspondence).not_to be_valid\n-      end\n-\n-      it 'email' do\n-        correspondence.email = nil\n-        expect(correspondence).not_to be_valid\n-      end\n+    context 'mandatory' do      ","path":"spec/models/correspondence_spec.rb","position":14,"original_position":14,"commit_id":"d5ed5cbe7f1b408d4a0e552cc0238ece9b548b0a","original_commit_id":"d5ed5cbe7f1b408d4a0e552cc0238ece9b548b0a","user":{"login":"misaka","id":15608,"avatar_url":"https://avatars.githubusercontent.com/u/15608?v=3","gravatar_id":"","url":"https://api.github.com/users/misaka","html_url":"https://github.com/misaka","followers_url":"https://api.github.com/users/misaka/followers","following_url":"https://api.github.com/users/misaka/following{/other_user}","gists_url":"https://api.github.com/users/misaka/gists{/gist_id}","starred_url":"https://api.github.com/users/misaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misaka/subscriptions","organizations_url":"https://api.github.com/users/misaka/orgs","repos_url":"https://api.github.com/users/misaka/repos","events_url":"https://api.github.com/users/misaka/events{/privacy}","received_events_url":"https://api.github.com/users/misaka/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand the use of the `contexts` here. Contexts should describe a situation and (usually) should be reflected in changes to the setup of fixtures, etc. Here they seem to be a way of grouping tests that don't really need it, especially with the `should` syntax you've now added.","created_at":"2016-09-23T15:11:07Z","updated_at":"2016-09-23T15:16:54Z","html_url":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63#discussion_r80264343","pull_request_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/comments/80264343"},"html":{"href":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63#discussion_r80264343"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63","id":86499319,"html_url":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63","diff_url":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63.diff","patch_url":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63.patch","issue_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/63","number":63,"state":"open","locked":false,"title":"143 better validations","user":{"login":"EdwardAndress","id":7963978,"avatar_url":"https://avatars.githubusercontent.com/u/7963978?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwardAndress","html_url":"https://github.com/EdwardAndress","followers_url":"https://api.github.com/users/EdwardAndress/followers","following_url":"https://api.github.com/users/EdwardAndress/following{/other_user}","gists_url":"https://api.github.com/users/EdwardAndress/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwardAndress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwardAndress/subscriptions","organizations_url":"https://api.github.com/users/EdwardAndress/orgs","repos_url":"https://api.github.com/users/EdwardAndress/repos","events_url":"https://api.github.com/users/EdwardAndress/events{/privacy}","received_events_url":"https://api.github.com/users/EdwardAndress/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/J4RP5Rwh/143-better-validations-both-in-public-and-staff-app\r\n\r\nI've also done a little refactoring here, in the initial commits, to implement shoulda matchers and break up some long lines.","created_at":"2016-09-23T11:48:41Z","updated_at":"2016-09-23T15:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d2805771985b2092a9c9c16ebf7549508d04883","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/63/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/statuses/d5ed5cbe7f1b408d4a0e552cc0238ece9b548b0a","head":{"label":"ministryofjustice:143_better_validations","ref":"143_better_validations","sha":"d5ed5cbe7f1b408d4a0e552cc0238ece9b548b0a","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":62798174,"name":"correspondence_tool_public","full_name":"ministryofjustice/correspondence_tool_public","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/correspondence_tool_public","description":"Correspondence Tool Public - Rails App","fork":false,"url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public","forks_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/forks","keys_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/events","assignees_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/merges","archive_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/deployments","created_at":"2016-07-07T10:23:53Z","updated_at":"2016-09-20T15:28:34Z","pushed_at":"2016-09-23T15:15:49Z","git_url":"git://github.com/ministryofjustice/correspondence_tool_public.git","ssh_url":"git@github.com:ministryofjustice/correspondence_tool_public.git","clone_url":"https://github.com/ministryofjustice/correspondence_tool_public.git","svn_url":"https://github.com/ministryofjustice/correspondence_tool_public","homepage":"http://correspondance.herokuapp.com/","size":213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"ministryofjustice:develop","ref":"develop","sha":"a9cda6463a5981ebab1d907395db01ba6ffee1e3","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":62798174,"name":"correspondence_tool_public","full_name":"ministryofjustice/correspondence_tool_public","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/correspondence_tool_public","description":"Correspondence Tool Public - Rails App","fork":false,"url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public","forks_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/forks","keys_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/events","assignees_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/merges","archive_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/deployments","created_at":"2016-07-07T10:23:53Z","updated_at":"2016-09-20T15:28:34Z","pushed_at":"2016-09-23T15:15:49Z","git_url":"git://github.com/ministryofjustice/correspondence_tool_public.git","ssh_url":"git@github.com:ministryofjustice/correspondence_tool_public.git","clone_url":"https://github.com/ministryofjustice/correspondence_tool_public.git","svn_url":"https://github.com/ministryofjustice/correspondence_tool_public","homepage":"http://correspondance.herokuapp.com/","size":213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63"},"html":{"href":"https://github.com/ministryofjustice/correspondence_tool_public/pull/63"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/63"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/correspondence_tool_public/statuses/d5ed5cbe7f1b408d4a0e552cc0238ece9b548b0a"}}}}
{"actor":{"display_login":"misaka"}}