{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/comments/68277534","id":68277534,"diff_hunk":"@@ -66,23 +66,26 @@ exports.exec = (rawConn, muxer, pInfo, callback) => {\n           callback(null, otherPInfo)\n         }))\n \n-      const obsMultiaddr = rawConn.getObservedAddrs()[0]\n+      rawConn.getObservedAddrs((err, addrs) => {\n+        if (err) {}","path":"src/identify.js","position":15,"original_position":15,"commit_id":"c86ead479dc8b3de2dde9454c17feb2ee872d7d6","original_commit_id":"c86ead479dc8b3de2dde9454c17feb2ee872d7d6","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"body":"or return?","created_at":"2016-06-23T17:26:19Z","updated_at":"2016-06-23T17:26:19Z","html_url":"https://github.com/libp2p/js-libp2p-swarm/pull/79#discussion_r68277534","pull_request_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/comments/68277534"},"html":{"href":"https://github.com/libp2p/js-libp2p-swarm/pull/79#discussion_r68277534"},"pull_request":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79","id":74983703,"html_url":"https://github.com/libp2p/js-libp2p-swarm/pull/79","diff_url":"https://github.com/libp2p/js-libp2p-swarm/pull/79.diff","patch_url":"https://github.com/libp2p/js-libp2p-swarm/pull/79.patch","issue_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/79","number":79,"state":"open","locked":false,"title":"update the transports","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"This PR updates the transport dependencies and adapts swarm to work with the interface-transport and interface-connection, without compromising any guarantees or interface.","created_at":"2016-06-23T16:15:33Z","updated_at":"2016-06-23T17:26:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5fa12457567063889ee81e27eec6b60a398c60","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79/commits","review_comments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79/comments","review_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/79/comments","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/statuses/c86ead479dc8b3de2dde9454c17feb2ee872d7d6","head":{"label":"libp2p:update-transports","ref":"update-transports","sha":"c86ead479dc8b3de2dde9454c17feb2ee872d7d6","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":38784511,"name":"js-libp2p-swarm","full_name":"libp2p/js-libp2p-swarm","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/js-libp2p-swarm","description":"IPFS swarm implementation in Node.js","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-swarm","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/deployments","created_at":"2015-07-08T22:59:25Z","updated_at":"2016-06-18T16:20:38Z","pushed_at":"2016-06-23T16:21:09Z","git_url":"git://github.com/libp2p/js-libp2p-swarm.git","ssh_url":"git@github.com:libp2p/js-libp2p-swarm.git","clone_url":"https://github.com/libp2p/js-libp2p-swarm.git","svn_url":"https://github.com/libp2p/js-libp2p-swarm","homepage":null,"size":414,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":16,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"edee20ba1aea9b2d80a5e23d9c6009c4c8dc355c","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":38784511,"name":"js-libp2p-swarm","full_name":"libp2p/js-libp2p-swarm","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/js-libp2p-swarm","description":"IPFS swarm implementation in Node.js","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-swarm","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-swarm/deployments","created_at":"2015-07-08T22:59:25Z","updated_at":"2016-06-18T16:20:38Z","pushed_at":"2016-06-23T16:21:09Z","git_url":"git://github.com/libp2p/js-libp2p-swarm.git","ssh_url":"git@github.com:libp2p/js-libp2p-swarm.git","clone_url":"https://github.com/libp2p/js-libp2p-swarm.git","svn_url":"https://github.com/libp2p/js-libp2p-swarm","homepage":null,"size":414,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79"},"html":{"href":"https://github.com/libp2p/js-libp2p-swarm/pull/79"},"issue":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/79"},"comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/js-libp2p-swarm/statuses/c86ead479dc8b3de2dde9454c17feb2ee872d7d6"}}}}
{"actor":{"display_login":"dignifiedquire"}}