{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24095","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24095/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24095/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24095/events","html_url":"https://github.com/docker/docker/issues/24095","id":162827965,"number":24095,"title":"[1.12-rc2] daemon.ID should be replaced with swarm NodeID","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"labels":[{"id":392678049,"url":"https://api.github.com/repos/docker/docker/labels/area/swarm","name":"area/swarm","color":"fbca04","default":false},{"id":190258329,"url":"https://api.github.com/repos/docker/docker/labels/kind/bug","name":"kind/bug","color":"FF8C94","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":126,"closed_issues":869,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-18T20:35:45Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-06-29T02:27:21Z","updated_at":"2016-11-18T21:01:51Z","closed_at":null,"body":"Currently, the output of `docker info` and the `Daemon` struct have an identifier set with the `trustKey`. Since this isn't really used, we should probably set this to the actual cryptographic node identity when the daemon changes to swarm mode.\n\nThis will ensure that we have a really node identity associated with an engine and ensure that it is available to users.\n\nSee docker/swarmkit#1075\n\ncc @diogomonica @dmcgowan @aluzzardi \n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/261640852","html_url":"https://github.com/docker/docker/issues/24095#issuecomment-261640852","issue_url":"https://api.github.com/repos/docker/docker/issues/24095","id":261640852,"user":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T21:01:51Z","updated_at":"2016-11-18T21:01:51Z","body":"I agree with Diogo that it is safe to assume the format is not being relied on, but it is possible that tooling is expecting this ID to not mutate. Could this cause problems with updating from swarm v1 to swarm mode?\r\n\r\nI agree that basing it off the trust key is no longer useful, but why not keep the ID specific to the machine and use the Swarm NodeID when it is needed. Are we going to define some method to verify the cryptographic ID of a node, if not all we need is a UUID. The only reason we used a cryptographic key before is we had plans for using it for signing and a known hosts feature."}}
{"actor":{"display_login":"dmcgowan"}}