{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/60612575","id":60612575,"diff_hunk":"@@ -22,21 +23,79 @@\n #include <algorithm>\n #include <limits>\n \n+// TODO: Replace this with something better that can handle MooseSharedPointer<T>\n+template<typename T>\n+struct DereferenceSorter\n+{\n+  bool operator()(const T & lhs, const T & rhs) const\n+  {\n+    return *lhs < *rhs;\n+  }\n+};\n+\n+template<> void dataStore(std::ostream & stream, FeatureFloodCount::FeatureData & feature, void * context)","path":"modules/phase_field/src/postprocessors/FeatureFloodCount.C","position":22,"original_position":22,"commit_id":"bb3fcbbd8ddb3a6675297785d56af0891c102c34","original_commit_id":"bb3fcbbd8ddb3a6675297785d56af0891c102c34","user":{"login":"jwpeterson","id":1775907,"avatar_url":"https://avatars.githubusercontent.com/u/1775907?v=3","gravatar_id":"","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"I think the coding convention is that `template<>` goes on a separate line.","created_at":"2016-04-21T16:25:24Z","updated_at":"2016-04-21T16:25:24Z","html_url":"https://github.com/idaholab/moose/pull/6713#discussion_r60612575","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/6713","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/60612575"},"html":{"href":"https://github.com/idaholab/moose/pull/6713#discussion_r60612575"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6713"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/6713","id":65553792,"html_url":"https://github.com/idaholab/moose/pull/6713","diff_url":"https://github.com/idaholab/moose/pull/6713.diff","patch_url":"https://github.com/idaholab/moose/pull/6713.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/6713","number":6713,"state":"open","locked":false,"title":"Grain tracker/halos recursive","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"This is a big one. I'm planning on merging in about 5 months of work soon. I'd prefer to leave the history if possible even if I have to go back and clean it up a bit. I know this currently breaks Marmot a little bit and probably a few external people but it'll need to get deployed sooner or later.\r\n\r\n# Description\r\nThis is a complete rewrite of the grain tracker.\r\n - Communication is drastically reduced by only sending information on ghosted entities\r\n - Using new packed range routines for serializing/deserializing complex data structures\r\n - Using a new \"Halo\" technique to track grain intersections instead of bounding spheres\r\n - A new recursive remapping algorithm has been implemented for handling low numbers of OPs\r\n - 2D problems seem to run with less than 10 OPs now fairly consistently\r\n - Sensible defaults for GrainTracker parameters\r\n\r\n```\r\n[Postprocessors]\r\n  [./grain_tracker]\r\n    type = GrainTracker\r\n    # This works great for many types of runs now, no need for clutter\r\n  [../]\r\n[]\r\n```\r\n\r\nI don't have timing information yet but this thing is much faster than before. That'll all be in a publication at a later date. Let's get some feedback.\r\n\r\n@dschwen, @tonkmr,  @jhbradley, @laagesen, @frombs","created_at":"2016-04-06T23:41:38Z","updated_at":"2016-04-21T16:25:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d1774808eba1bdb010879303722491e6edfe16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/6713/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/6713/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/6713/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/bb3fcbbd8ddb3a6675297785d56af0891c102c34","head":{"label":"permcody:grain_tracker/halos_recursive","ref":"grain_tracker/halos_recursive","sha":"bb3fcbbd8ddb3a6675297785d56af0891c102c34","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"repo":{"id":16853237,"name":"moose","full_name":"permcody/moose","owner":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/permcody/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/permcody/moose","forks_url":"https://api.github.com/repos/permcody/moose/forks","keys_url":"https://api.github.com/repos/permcody/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/permcody/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/permcody/moose/teams","hooks_url":"https://api.github.com/repos/permcody/moose/hooks","issue_events_url":"https://api.github.com/repos/permcody/moose/issues/events{/number}","events_url":"https://api.github.com/repos/permcody/moose/events","assignees_url":"https://api.github.com/repos/permcody/moose/assignees{/user}","branches_url":"https://api.github.com/repos/permcody/moose/branches{/branch}","tags_url":"https://api.github.com/repos/permcody/moose/tags","blobs_url":"https://api.github.com/repos/permcody/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/permcody/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/permcody/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/permcody/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/permcody/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/permcody/moose/languages","stargazers_url":"https://api.github.com/repos/permcody/moose/stargazers","contributors_url":"https://api.github.com/repos/permcody/moose/contributors","subscribers_url":"https://api.github.com/repos/permcody/moose/subscribers","subscription_url":"https://api.github.com/repos/permcody/moose/subscription","commits_url":"https://api.github.com/repos/permcody/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/permcody/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/permcody/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/permcody/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/permcody/moose/contents/{+path}","compare_url":"https://api.github.com/repos/permcody/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/permcody/moose/merges","archive_url":"https://api.github.com/repos/permcody/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/permcody/moose/downloads","issues_url":"https://api.github.com/repos/permcody/moose/issues{/number}","pulls_url":"https://api.github.com/repos/permcody/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/permcody/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/permcody/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/permcody/moose/labels{/name}","releases_url":"https://api.github.com/repos/permcody/moose/releases{/id}","deployments_url":"https://api.github.com/repos/permcody/moose/deployments","created_at":"2014-02-15T00:18:23Z","updated_at":"2015-09-23T17:09:41Z","pushed_at":"2016-04-21T15:44:36Z","git_url":"git://github.com/permcody/moose.git","ssh_url":"git@github.com:permcody/moose.git","clone_url":"https://github.com/permcody/moose.git","svn_url":"https://github.com/permcody/moose","homepage":null,"size":130150,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"28f91926390bdcad2d9c87c2eac607735b9a43f7","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-04-19T06:51:14Z","pushed_at":"2016-04-21T15:59:15Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":141392,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":581,"forks":233,"open_issues":581,"watchers":148,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6713"},"html":{"href":"https://github.com/idaholab/moose/pull/6713"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/6713"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/6713/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6713/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6713/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/bb3fcbbd8ddb3a6675297785d56af0891c102c34"}}}}