{"action":"created","comment":{"url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/comments/80357306","id":80357306,"diff_hunk":"@@ -101,13 +103,12 @@ protected final int addField(int sizeBits, int alignBits, Offset offset) {\n         }\n \n         protected final int addField(int sizeBits, int alignBits) {\n-            final int off = resetIndex ? 0 : align(this.size, alignBits >> 3);\n-            this.size = Math.max(this.size, off + (sizeBits >> 3));\n-            this.minAlign = Math.max(this.minAlign, alignBits >> 3);\n-            return off;\n+            final int alignment = this.alignment.intValue() > 0 ? Math.min(this.alignment.intValue(), (alignBits >> 3)) : (alignBits >> 3);","path":"src/main/java/jnr/ffi/Struct.java","position":26,"original_position":26,"commit_id":"2920a77a34b691780cddc28e106db8db39458f69","original_commit_id":"2920a77a34b691780cddc28e106db8db39458f69","user":{"login":"goto1134","id":9569795,"avatar_url":"https://avatars.githubusercontent.com/u/9569795?v=3","gravatar_id":"","url":"https://api.github.com/users/goto1134","html_url":"https://github.com/goto1134","followers_url":"https://api.github.com/users/goto1134/followers","following_url":"https://api.github.com/users/goto1134/following{/other_user}","gists_url":"https://api.github.com/users/goto1134/gists{/gist_id}","starred_url":"https://api.github.com/users/goto1134/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goto1134/subscriptions","organizations_url":"https://api.github.com/users/goto1134/orgs","repos_url":"https://api.github.com/users/goto1134/repos","events_url":"https://api.github.com/users/goto1134/events{/privacy}","received_events_url":"https://api.github.com/users/goto1134/received_events","type":"User","site_admin":false},"body":"@henriquemotaesteves ah, now I see that I just misunderstood the way it works.","created_at":"2016-09-24T09:19:07Z","updated_at":"2016-09-24T09:19:07Z","html_url":"https://github.com/jnr/jnr-ffi/pull/46#discussion_r80357306","pull_request_url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/comments/80357306"},"html":{"href":"https://github.com/jnr/jnr-ffi/pull/46#discussion_r80357306"},"pull_request":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46","id":38447425,"html_url":"https://github.com/jnr/jnr-ffi/pull/46","diff_url":"https://github.com/jnr/jnr-ffi/pull/46.diff","patch_url":"https://github.com/jnr/jnr-ffi/pull/46.patch","issue_url":"https://api.github.com/repos/jnr/jnr-ffi/issues/46","number":46,"state":"closed","locked":false,"title":"Add support to define the alignment of structs","user":{"login":"henriquemotaesteves","id":73287,"avatar_url":"https://avatars.githubusercontent.com/u/73287?v=3","gravatar_id":"","url":"https://api.github.com/users/henriquemotaesteves","html_url":"https://github.com/henriquemotaesteves","followers_url":"https://api.github.com/users/henriquemotaesteves/followers","following_url":"https://api.github.com/users/henriquemotaesteves/following{/other_user}","gists_url":"https://api.github.com/users/henriquemotaesteves/gists{/gist_id}","starred_url":"https://api.github.com/users/henriquemotaesteves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henriquemotaesteves/subscriptions","organizations_url":"https://api.github.com/users/henriquemotaesteves/orgs","repos_url":"https://api.github.com/users/henriquemotaesteves/repos","events_url":"https://api.github.com/users/henriquemotaesteves/events{/privacy}","received_events_url":"https://api.github.com/users/henriquemotaesteves/received_events","type":"User","site_admin":false},"body":"This pull request is related to the issue #8.\r\n\r\nThis pull request was tested in the following platforms:\r\n\r\nOS | Arch\r\n------------ | -------------\r\nWindows 7 | X86 - 32-bit\r\nWindows 7 | X86 - 64-bit\r\nUbuntu 14.04 | X86 - 32-bit\r\nUbuntu 14.04 | X86 - 64-bit\r\nMax OS X 10.10.2 | X86 - 64-bit","created_at":"2015-06-24T14:25:22Z","updated_at":"2016-09-24T09:19:07Z","closed_at":"2016-09-22T17:27:20Z","merged_at":"2016-09-22T17:27:20Z","merge_commit_sha":"94c073e373d9fdf3467a17498e0cb1f3b21a00a8","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jnr/jnr-ffi/milestones/9","html_url":"https://github.com/jnr/jnr-ffi/milestones/2.1.0","labels_url":"https://api.github.com/repos/jnr/jnr-ffi/milestones/9/labels","id":1643871,"number":9,"title":"2.1.0","description":"","creator":{"login":"headius","id":10135,"avatar_url":"https://avatars.githubusercontent.com/u/10135?v=3","gravatar_id":"","url":"https://api.github.com/users/headius","html_url":"https://github.com/headius","followers_url":"https://api.github.com/users/headius/followers","following_url":"https://api.github.com/users/headius/following{/other_user}","gists_url":"https://api.github.com/users/headius/gists{/gist_id}","starred_url":"https://api.github.com/users/headius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headius/subscriptions","organizations_url":"https://api.github.com/users/headius/orgs","repos_url":"https://api.github.com/users/headius/repos","events_url":"https://api.github.com/users/headius/events{/privacy}","received_events_url":"https://api.github.com/users/headius/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":13,"state":"open","created_at":"2016-03-14T18:18:38Z","updated_at":"2016-09-23T22:50:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46/commits","review_comments_url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46/comments","review_comment_url":"https://api.github.com/repos/jnr/jnr-ffi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jnr/jnr-ffi/issues/46/comments","statuses_url":"https://api.github.com/repos/jnr/jnr-ffi/statuses/2920a77a34b691780cddc28e106db8db39458f69","head":{"label":"henriquemotaesteves:struct-alignment","ref":"struct-alignment","sha":"2920a77a34b691780cddc28e106db8db39458f69","user":{"login":"henriquemotaesteves","id":73287,"avatar_url":"https://avatars.githubusercontent.com/u/73287?v=3","gravatar_id":"","url":"https://api.github.com/users/henriquemotaesteves","html_url":"https://github.com/henriquemotaesteves","followers_url":"https://api.github.com/users/henriquemotaesteves/followers","following_url":"https://api.github.com/users/henriquemotaesteves/following{/other_user}","gists_url":"https://api.github.com/users/henriquemotaesteves/gists{/gist_id}","starred_url":"https://api.github.com/users/henriquemotaesteves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henriquemotaesteves/subscriptions","organizations_url":"https://api.github.com/users/henriquemotaesteves/orgs","repos_url":"https://api.github.com/users/henriquemotaesteves/repos","events_url":"https://api.github.com/users/henriquemotaesteves/events{/privacy}","received_events_url":"https://api.github.com/users/henriquemotaesteves/received_events","type":"User","site_admin":false},"repo":{"id":32338373,"name":"jnr-ffi","full_name":"henriquemotaesteves/jnr-ffi","owner":{"login":"henriquemotaesteves","id":73287,"avatar_url":"https://avatars.githubusercontent.com/u/73287?v=3","gravatar_id":"","url":"https://api.github.com/users/henriquemotaesteves","html_url":"https://github.com/henriquemotaesteves","followers_url":"https://api.github.com/users/henriquemotaesteves/followers","following_url":"https://api.github.com/users/henriquemotaesteves/following{/other_user}","gists_url":"https://api.github.com/users/henriquemotaesteves/gists{/gist_id}","starred_url":"https://api.github.com/users/henriquemotaesteves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henriquemotaesteves/subscriptions","organizations_url":"https://api.github.com/users/henriquemotaesteves/orgs","repos_url":"https://api.github.com/users/henriquemotaesteves/repos","events_url":"https://api.github.com/users/henriquemotaesteves/events{/privacy}","received_events_url":"https://api.github.com/users/henriquemotaesteves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henriquemotaesteves/jnr-ffi","description":"Java Abstracted Foreign Function Layer","fork":true,"url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi","forks_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/forks","keys_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/teams","hooks_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/hooks","issue_events_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/issues/events{/number}","events_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/events","assignees_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/assignees{/user}","branches_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/branches{/branch}","tags_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/tags","blobs_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/git/refs{/sha}","trees_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/statuses/{sha}","languages_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/languages","stargazers_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/stargazers","contributors_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/contributors","subscribers_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/subscribers","subscription_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/subscription","commits_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/commits{/sha}","git_commits_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/git/commits{/sha}","comments_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/comments{/number}","issue_comment_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/issues/comments{/number}","contents_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/contents/{+path}","compare_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/merges","archive_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/downloads","issues_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/issues{/number}","pulls_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/pulls{/number}","milestones_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/milestones{/number}","notifications_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/labels{/name}","releases_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/releases{/id}","deployments_url":"https://api.github.com/repos/henriquemotaesteves/jnr-ffi/deployments","created_at":"2015-03-16T16:33:15Z","updated_at":"2015-04-23T14:39:32Z","pushed_at":"2016-09-23T16:59:53Z","git_url":"git://github.com/henriquemotaesteves/jnr-ffi.git","ssh_url":"git@github.com:henriquemotaesteves/jnr-ffi.git","clone_url":"https://github.com/henriquemotaesteves/jnr-ffi.git","svn_url":"https://github.com/henriquemotaesteves/jnr-ffi","homepage":"","size":5483,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jnr:master","ref":"master","sha":"4900cc67a14a0a714400c28943be27522b40b1af","user":{"login":"jnr","id":598014,"avatar_url":"https://avatars.githubusercontent.com/u/598014?v=3","gravatar_id":"","url":"https://api.github.com/users/jnr","html_url":"https://github.com/jnr","followers_url":"https://api.github.com/users/jnr/followers","following_url":"https://api.github.com/users/jnr/following{/other_user}","gists_url":"https://api.github.com/users/jnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnr/subscriptions","organizations_url":"https://api.github.com/users/jnr/orgs","repos_url":"https://api.github.com/users/jnr/repos","events_url":"https://api.github.com/users/jnr/events{/privacy}","received_events_url":"https://api.github.com/users/jnr/received_events","type":"Organization","site_admin":false},"repo":{"id":1323052,"name":"jnr-ffi","full_name":"jnr/jnr-ffi","owner":{"login":"jnr","id":598014,"avatar_url":"https://avatars.githubusercontent.com/u/598014?v=3","gravatar_id":"","url":"https://api.github.com/users/jnr","html_url":"https://github.com/jnr","followers_url":"https://api.github.com/users/jnr/followers","following_url":"https://api.github.com/users/jnr/following{/other_user}","gists_url":"https://api.github.com/users/jnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnr/subscriptions","organizations_url":"https://api.github.com/users/jnr/orgs","repos_url":"https://api.github.com/users/jnr/repos","events_url":"https://api.github.com/users/jnr/events{/privacy}","received_events_url":"https://api.github.com/users/jnr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jnr/jnr-ffi","description":"Java Abstracted Foreign Function Layer","fork":false,"url":"https://api.github.com/repos/jnr/jnr-ffi","forks_url":"https://api.github.com/repos/jnr/jnr-ffi/forks","keys_url":"https://api.github.com/repos/jnr/jnr-ffi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnr/jnr-ffi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnr/jnr-ffi/teams","hooks_url":"https://api.github.com/repos/jnr/jnr-ffi/hooks","issue_events_url":"https://api.github.com/repos/jnr/jnr-ffi/issues/events{/number}","events_url":"https://api.github.com/repos/jnr/jnr-ffi/events","assignees_url":"https://api.github.com/repos/jnr/jnr-ffi/assignees{/user}","branches_url":"https://api.github.com/repos/jnr/jnr-ffi/branches{/branch}","tags_url":"https://api.github.com/repos/jnr/jnr-ffi/tags","blobs_url":"https://api.github.com/repos/jnr/jnr-ffi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnr/jnr-ffi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnr/jnr-ffi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnr/jnr-ffi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnr/jnr-ffi/statuses/{sha}","languages_url":"https://api.github.com/repos/jnr/jnr-ffi/languages","stargazers_url":"https://api.github.com/repos/jnr/jnr-ffi/stargazers","contributors_url":"https://api.github.com/repos/jnr/jnr-ffi/contributors","subscribers_url":"https://api.github.com/repos/jnr/jnr-ffi/subscribers","subscription_url":"https://api.github.com/repos/jnr/jnr-ffi/subscription","commits_url":"https://api.github.com/repos/jnr/jnr-ffi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnr/jnr-ffi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnr/jnr-ffi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnr/jnr-ffi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnr/jnr-ffi/contents/{+path}","compare_url":"https://api.github.com/repos/jnr/jnr-ffi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnr/jnr-ffi/merges","archive_url":"https://api.github.com/repos/jnr/jnr-ffi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnr/jnr-ffi/downloads","issues_url":"https://api.github.com/repos/jnr/jnr-ffi/issues{/number}","pulls_url":"https://api.github.com/repos/jnr/jnr-ffi/pulls{/number}","milestones_url":"https://api.github.com/repos/jnr/jnr-ffi/milestones{/number}","notifications_url":"https://api.github.com/repos/jnr/jnr-ffi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnr/jnr-ffi/labels{/name}","releases_url":"https://api.github.com/repos/jnr/jnr-ffi/releases{/id}","deployments_url":"https://api.github.com/repos/jnr/jnr-ffi/deployments","created_at":"2011-02-03T04:25:56Z","updated_at":"2016-09-23T09:09:53Z","pushed_at":"2016-09-23T21:34:09Z","git_url":"git://github.com/jnr/jnr-ffi.git","ssh_url":"git@github.com:jnr/jnr-ffi.git","clone_url":"https://github.com/jnr/jnr-ffi.git","svn_url":"https://github.com/jnr/jnr-ffi","homepage":"","size":5901,"stargazers_count":316,"watchers_count":316,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":31,"forks":47,"open_issues":31,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46"},"html":{"href":"https://github.com/jnr/jnr-ffi/pull/46"},"issue":{"href":"https://api.github.com/repos/jnr/jnr-ffi/issues/46"},"comments":{"href":"https://api.github.com/repos/jnr/jnr-ffi/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jnr/jnr-ffi/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/jnr/jnr-ffi/statuses/2920a77a34b691780cddc28e106db8db39458f69"}}}}
{"actor":{"display_login":"goto1134"}}