{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/63068484","id":63068484,"diff_hunk":"@@ -276,7 +264,26 @@\n \t\treturn\n \tplaysound(src, \"shatter\", 70, 1)\n \tvar/turf/T = loc\n-\tfor(var/obj/item/I in storeditems)\n+\tvar/produced_items = list()\n+\n+\tif(!(flags & NODECONSTRUCT))\n+\t\tvar/shards = 1\n+\t\tif(fulltile)\n+\t\t\tshards++\n+\t\tvar/rods = 0\n+\t\tif(reinf)\n+\t\t\trods++\n+\t\t\tif(fulltile)\n+\t\t\t\trods++\n+\n+\t\tfor(var/i in 1 to shards)\n+\t\t\tproduced_items += new /obj/item/weapon/shard(src)\n+\t\tif(rods)\n+\t\t\tproduced_items += new /obj/item/stack/rods(src, rods)","path":"code/game/objects/structures/window.dm","position":46,"original_position":46,"commit_id":"d9bfa9e82050eb26ed9860178d1584b96714c8c2","original_commit_id":"d9bfa9e82050eb26ed9860178d1584b96714c8c2","user":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"body":"Also, why don't all deconstructable objects keep their innards preloaded anyway?","created_at":"2016-05-12T18:07:35Z","updated_at":"2016-05-12T18:07:35Z","html_url":"https://github.com/tgstation/-tg-station/pull/17613#discussion_r63068484","pull_request_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613","_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/63068484"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/17613#discussion_r63068484"},"pull_request":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613","id":69857981,"html_url":"https://github.com/tgstation/-tg-station/pull/17613","diff_url":"https://github.com/tgstation/-tg-station/pull/17613.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/17613.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/17613","number":17613,"state":"open","locked":false,"title":"Removes materials from holodeck chairs and windows (Fixes #17612)","user":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"body":"- Breaking a chair with NODECONSTRUCT no longer produces materials.\r\n- Breaking a window with NODECONSTRUCT now reliably does not produce\r\nmaterials.\r\n- Also moved the creation of debris into the window's shatter() proc,\r\nbecause doing it on creation is dumb, and unreliable.","created_at":"2016-05-12T15:32:27Z","updated_at":"2016-05-12T18:07:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cd8afa55ebea955950f29828e1431b5214ce06b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/17613/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/d9bfa9e82050eb26ed9860178d1584b96714c8c2","head":{"label":"coiax:morphling-holodeck","ref":"morphling-holodeck","sha":"d9bfa9e82050eb26ed9860178d1584b96714c8c2","user":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"repo":{"id":54189694,"name":"-tg-station","full_name":"coiax/-tg-station","owner":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coiax/-tg-station","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/coiax/-tg-station","forks_url":"https://api.github.com/repos/coiax/-tg-station/forks","keys_url":"https://api.github.com/repos/coiax/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coiax/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coiax/-tg-station/teams","hooks_url":"https://api.github.com/repos/coiax/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/coiax/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/coiax/-tg-station/events","assignees_url":"https://api.github.com/repos/coiax/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/coiax/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/coiax/-tg-station/tags","blobs_url":"https://api.github.com/repos/coiax/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coiax/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coiax/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/coiax/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coiax/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/coiax/-tg-station/languages","stargazers_url":"https://api.github.com/repos/coiax/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/coiax/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/coiax/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/coiax/-tg-station/subscription","commits_url":"https://api.github.com/repos/coiax/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/coiax/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/coiax/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/coiax/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/coiax/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/coiax/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coiax/-tg-station/merges","archive_url":"https://api.github.com/repos/coiax/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coiax/-tg-station/downloads","issues_url":"https://api.github.com/repos/coiax/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/coiax/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/coiax/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/coiax/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coiax/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/coiax/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/coiax/-tg-station/deployments","created_at":"2016-03-18T09:28:37Z","updated_at":"2016-03-18T09:28:48Z","pushed_at":"2016-05-12T16:53:19Z","git_url":"git://github.com/coiax/-tg-station.git","ssh_url":"git@github.com:coiax/-tg-station.git","clone_url":"https://github.com/coiax/-tg-station.git","svn_url":"https://github.com/coiax/-tg-station","homepage":"http://www.tgstation13.org/","size":582356,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"bb2a746390a3541500620735a2878cac9906d1bf","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/-tg-station/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-05-11T18:53:52Z","pushed_at":"2016-05-12T17:45:06Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":856201,"stargazers_count":292,"watchers_count":292,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1047,"mirror_url":null,"open_issues_count":967,"forks":1047,"open_issues":967,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/17613"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/17613"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/17613/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17613/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/d9bfa9e82050eb26ed9860178d1584b96714c8c2"}}}}