{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/89677976","pull_request_review_id":10220639,"id":89677976,"diff_hunk":"@@ -906,17 +906,18 @@ void TGlslangToSpvTraverser::dumpSpv(std::vector<unsigned int>& out)\n     for (auto it = iOSet.cbegin(); it != iOSet.cend(); ++it)\n         entryPoint->addIdOperand(*it);\n \n+\tif (!mainTerminated) {","path":"SPIRV/GlslangToSpv.cpp","position":4,"original_position":4,"commit_id":"e3af3edb9c307064741dcb5b95a1e7a1486d1452","original_commit_id":"e3af3edb9c307064741dcb5b95a1e7a1486d1452","user":{"login":"johnkslang","id":5607714,"avatar_url":"https://avatars.githubusercontent.com/u/5607714?v=3","gravatar_id":"","url":"https://api.github.com/users/johnkslang","html_url":"https://github.com/johnkslang","followers_url":"https://api.github.com/users/johnkslang/followers","following_url":"https://api.github.com/users/johnkslang/following{/other_user}","gists_url":"https://api.github.com/users/johnkslang/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkslang/subscriptions","organizations_url":"https://api.github.com/users/johnkslang/orgs","repos_url":"https://api.github.com/users/johnkslang/repos","events_url":"https://api.github.com/users/johnkslang/events{/privacy}","received_events_url":"https://api.github.com/users/johnkslang/received_events","type":"User","site_admin":false},"body":"Spaces turned to tabs, causing incorrect indentation. Glslang uses 4 spaces per indent, and never tabs.","created_at":"2016-11-26T20:57:10Z","updated_at":"2016-11-26T20:57:10Z","html_url":"https://github.com/KhronosGroup/glslang/pull/600#discussion_r89677976","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/89677976"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/600#discussion_r89677976"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600","id":94507376,"html_url":"https://github.com/KhronosGroup/glslang/pull/600","diff_url":"https://github.com/KhronosGroup/glslang/pull/600.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/600.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/600","number":600,"state":"open","locked":false,"title":"Fix a wrong entry point generates code","user":{"login":"durswd","id":5775729,"avatar_url":"https://avatars.githubusercontent.com/u/5775729?v=3","gravatar_id":"","url":"https://api.github.com/users/durswd","html_url":"https://github.com/durswd","followers_url":"https://api.github.com/users/durswd/followers","following_url":"https://api.github.com/users/durswd/following{/other_user}","gists_url":"https://api.github.com/users/durswd/gists{/gist_id}","starred_url":"https://api.github.com/users/durswd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durswd/subscriptions","organizations_url":"https://api.github.com/users/durswd/orgs","repos_url":"https://api.github.com/users/durswd/repos","events_url":"https://api.github.com/users/durswd/events{/privacy}","received_events_url":"https://api.github.com/users/durswd/received_events","type":"User","site_admin":false},"body":"I fixed a bug.\r\nhttps://github.com/KhronosGroup/glslang/issues/588\r\n\r\nThe cause of bag is that builder.leaveFunction is not called before calling dumpSpv.\r\n\r\nIn addition, I found that some entry points in tests don't match shaders.\r\nSo I make names of entry point match between tests and shaders.","created_at":"2016-11-20T04:58:37Z","updated_at":"2016-11-26T20:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8656368f6dc3cfb074bd15262fb5daec1fdcbbfd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/600/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/e3af3edb9c307064741dcb5b95a1e7a1486d1452","head":{"label":"durswd:dev","ref":"dev","sha":"e3af3edb9c307064741dcb5b95a1e7a1486d1452","user":{"login":"durswd","id":5775729,"avatar_url":"https://avatars.githubusercontent.com/u/5775729?v=3","gravatar_id":"","url":"https://api.github.com/users/durswd","html_url":"https://github.com/durswd","followers_url":"https://api.github.com/users/durswd/followers","following_url":"https://api.github.com/users/durswd/following{/other_user}","gists_url":"https://api.github.com/users/durswd/gists{/gist_id}","starred_url":"https://api.github.com/users/durswd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durswd/subscriptions","organizations_url":"https://api.github.com/users/durswd/orgs","repos_url":"https://api.github.com/users/durswd/repos","events_url":"https://api.github.com/users/durswd/events{/privacy}","received_events_url":"https://api.github.com/users/durswd/received_events","type":"User","site_admin":false},"repo":{"id":74226575,"name":"glslang","full_name":"durswd/glslang","owner":{"login":"durswd","id":5775729,"avatar_url":"https://avatars.githubusercontent.com/u/5775729?v=3","gravatar_id":"","url":"https://api.github.com/users/durswd","html_url":"https://github.com/durswd","followers_url":"https://api.github.com/users/durswd/followers","following_url":"https://api.github.com/users/durswd/following{/other_user}","gists_url":"https://api.github.com/users/durswd/gists{/gist_id}","starred_url":"https://api.github.com/users/durswd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durswd/subscriptions","organizations_url":"https://api.github.com/users/durswd/orgs","repos_url":"https://api.github.com/users/durswd/repos","events_url":"https://api.github.com/users/durswd/events{/privacy}","received_events_url":"https://api.github.com/users/durswd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/durswd/glslang","description":"Khronos reference front-end for GLSL and ESSL, and sample SPIR-V generator","fork":true,"url":"https://api.github.com/repos/durswd/glslang","forks_url":"https://api.github.com/repos/durswd/glslang/forks","keys_url":"https://api.github.com/repos/durswd/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/durswd/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/durswd/glslang/teams","hooks_url":"https://api.github.com/repos/durswd/glslang/hooks","issue_events_url":"https://api.github.com/repos/durswd/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/durswd/glslang/events","assignees_url":"https://api.github.com/repos/durswd/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/durswd/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/durswd/glslang/tags","blobs_url":"https://api.github.com/repos/durswd/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/durswd/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/durswd/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/durswd/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/durswd/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/durswd/glslang/languages","stargazers_url":"https://api.github.com/repos/durswd/glslang/stargazers","contributors_url":"https://api.github.com/repos/durswd/glslang/contributors","subscribers_url":"https://api.github.com/repos/durswd/glslang/subscribers","subscription_url":"https://api.github.com/repos/durswd/glslang/subscription","commits_url":"https://api.github.com/repos/durswd/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/durswd/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/durswd/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/durswd/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/durswd/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/durswd/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/durswd/glslang/merges","archive_url":"https://api.github.com/repos/durswd/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/durswd/glslang/downloads","issues_url":"https://api.github.com/repos/durswd/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/durswd/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/durswd/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/durswd/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/durswd/glslang/labels{/name}","releases_url":"https://api.github.com/repos/durswd/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/durswd/glslang/deployments","created_at":"2016-11-19T18:18:43Z","updated_at":"2016-11-19T18:18:51Z","pushed_at":"2016-11-20T04:52:10Z","git_url":"git://github.com/durswd/glslang.git","ssh_url":"git@github.com:durswd/glslang.git","clone_url":"https://github.com/durswd/glslang.git","svn_url":"https://github.com/durswd/glslang","homepage":"","size":31449,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"fabe7d6a613782d49becaef86aa0161ed7d3c4d7","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"name":"glslang","full_name":"KhronosGroup/glslang","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL, and sample SPIR-V generator","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/glslang/deployments","created_at":"2015-06-25T17:54:39Z","updated_at":"2016-11-23T19:53:43Z","pushed_at":"2016-11-26T20:47:22Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":"","size":32884,"stargazers_count":408,"watchers_count":408,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":76,"forks":128,"open_issues":76,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/600"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/600"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/600/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/600/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/e3af3edb9c307064741dcb5b95a1e7a1486d1452"}}}}
{"actor":{"display_login":"johnkslang"}}