{"action":"created","comment":{"url":"https://api.github.com/repos/malirod/boost-log/pulls/comments/81444867","pull_request_review_id":2427186,"id":81444867,"diff_hunk":"@@ -1,4 +1,28 @@\n #pragma once\n+\n+#include <fstream>\n+\n #include <boost/log/trivial.hpp>\n+#include <boost/log/utility/setup/from_stream.hpp>\n+#include <boost/log/core/core.hpp>\n+#include <boost/log/sources/logger.hpp>\n+\n+namespace logging = boost::log;\n+namespace src = boost::log::sources;\n+using LoggerType = src::logger_mt;\n+\n+#define CREATE_LOCAL_LOGGER(logger) \\","path":"src/logger.h","position":14,"original_position":14,"commit_id":"1d1cc3bab72a4835a7cdbee8187586d67c49ed8f","original_commit_id":"1d1cc3bab72a4835a7cdbee8187586d67c49ed8f","user":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"body":"@AGaliuzov, what `logger` is used for? With hierarchical loggers (e.g. log4cxx) this is usually a logger name passed to the macro. But boost seems has no names.\r\n\r\nHave you checked #4 ? There I've described how I see macroses, e.g. DECLARE_GET_LOGGER . So I want to return logger from a function.","created_at":"2016-10-01T06:17:28Z","updated_at":"2016-10-01T06:17:28Z","html_url":"https://github.com/malirod/boost-log/pull/11#discussion_r81444867","pull_request_url":"https://api.github.com/repos/malirod/boost-log/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/comments/81444867"},"html":{"href":"https://github.com/malirod/boost-log/pull/11#discussion_r81444867"},"pull_request":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/malirod/boost-log/pulls/11","id":87576392,"html_url":"https://github.com/malirod/boost-log/pull/11","diff_url":"https://github.com/malirod/boost-log/pull/11.diff","patch_url":"https://github.com/malirod/boost-log/pull/11.patch","issue_url":"https://api.github.com/repos/malirod/boost-log/issues/11","number":11,"state":"open","locked":false,"title":"Add ability to initialize logger from the config","user":{"login":"AGaliuzov","id":11158516,"avatar_url":"https://avatars.githubusercontent.com/u/11158516?v=3","gravatar_id":"","url":"https://api.github.com/users/AGaliuzov","html_url":"https://github.com/AGaliuzov","followers_url":"https://api.github.com/users/AGaliuzov/followers","following_url":"https://api.github.com/users/AGaliuzov/following{/other_user}","gists_url":"https://api.github.com/users/AGaliuzov/gists{/gist_id}","starred_url":"https://api.github.com/users/AGaliuzov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGaliuzov/subscriptions","organizations_url":"https://api.github.com/users/AGaliuzov/orgs","repos_url":"https://api.github.com/users/AGaliuzov/repos","events_url":"https://api.github.com/users/AGaliuzov/events{/privacy}","received_events_url":"https://api.github.com/users/AGaliuzov/received_events","type":"User","site_admin":false},"body":"- Add config file and put basic initialization taken from the boost guide\r\n- Add simplest macroses for the logger\r\n\r\nAdresses #4","created_at":"2016-09-30T22:32:02Z","updated_at":"2016-10-01T06:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a74bcdb731e5545abb583a4e81872fc5d62344bc","assignee":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"assignees":[{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/malirod/boost-log/pulls/11/commits","review_comments_url":"https://api.github.com/repos/malirod/boost-log/pulls/11/comments","review_comment_url":"https://api.github.com/repos/malirod/boost-log/pulls/comments{/number}","comments_url":"https://api.github.com/repos/malirod/boost-log/issues/11/comments","statuses_url":"https://api.github.com/repos/malirod/boost-log/statuses/1d1cc3bab72a4835a7cdbee8187586d67c49ed8f","head":{"label":"AGaliuzov:add-log-initialization","ref":"add-log-initialization","sha":"1d1cc3bab72a4835a7cdbee8187586d67c49ed8f","user":{"login":"AGaliuzov","id":11158516,"avatar_url":"https://avatars.githubusercontent.com/u/11158516?v=3","gravatar_id":"","url":"https://api.github.com/users/AGaliuzov","html_url":"https://github.com/AGaliuzov","followers_url":"https://api.github.com/users/AGaliuzov/followers","following_url":"https://api.github.com/users/AGaliuzov/following{/other_user}","gists_url":"https://api.github.com/users/AGaliuzov/gists{/gist_id}","starred_url":"https://api.github.com/users/AGaliuzov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGaliuzov/subscriptions","organizations_url":"https://api.github.com/users/AGaliuzov/orgs","repos_url":"https://api.github.com/users/AGaliuzov/repos","events_url":"https://api.github.com/users/AGaliuzov/events{/privacy}","received_events_url":"https://api.github.com/users/AGaliuzov/received_events","type":"User","site_admin":false},"repo":{"id":68544160,"name":"boost-log","full_name":"AGaliuzov/boost-log","owner":{"login":"AGaliuzov","id":11158516,"avatar_url":"https://avatars.githubusercontent.com/u/11158516?v=3","gravatar_id":"","url":"https://api.github.com/users/AGaliuzov","html_url":"https://github.com/AGaliuzov","followers_url":"https://api.github.com/users/AGaliuzov/followers","following_url":"https://api.github.com/users/AGaliuzov/following{/other_user}","gists_url":"https://api.github.com/users/AGaliuzov/gists{/gist_id}","starred_url":"https://api.github.com/users/AGaliuzov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGaliuzov/subscriptions","organizations_url":"https://api.github.com/users/AGaliuzov/orgs","repos_url":"https://api.github.com/users/AGaliuzov/repos","events_url":"https://api.github.com/users/AGaliuzov/events{/privacy}","received_events_url":"https://api.github.com/users/AGaliuzov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AGaliuzov/boost-log","description":"Boost logger sample","fork":true,"url":"https://api.github.com/repos/AGaliuzov/boost-log","forks_url":"https://api.github.com/repos/AGaliuzov/boost-log/forks","keys_url":"https://api.github.com/repos/AGaliuzov/boost-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AGaliuzov/boost-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AGaliuzov/boost-log/teams","hooks_url":"https://api.github.com/repos/AGaliuzov/boost-log/hooks","issue_events_url":"https://api.github.com/repos/AGaliuzov/boost-log/issues/events{/number}","events_url":"https://api.github.com/repos/AGaliuzov/boost-log/events","assignees_url":"https://api.github.com/repos/AGaliuzov/boost-log/assignees{/user}","branches_url":"https://api.github.com/repos/AGaliuzov/boost-log/branches{/branch}","tags_url":"https://api.github.com/repos/AGaliuzov/boost-log/tags","blobs_url":"https://api.github.com/repos/AGaliuzov/boost-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AGaliuzov/boost-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AGaliuzov/boost-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/AGaliuzov/boost-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AGaliuzov/boost-log/statuses/{sha}","languages_url":"https://api.github.com/repos/AGaliuzov/boost-log/languages","stargazers_url":"https://api.github.com/repos/AGaliuzov/boost-log/stargazers","contributors_url":"https://api.github.com/repos/AGaliuzov/boost-log/contributors","subscribers_url":"https://api.github.com/repos/AGaliuzov/boost-log/subscribers","subscription_url":"https://api.github.com/repos/AGaliuzov/boost-log/subscription","commits_url":"https://api.github.com/repos/AGaliuzov/boost-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/AGaliuzov/boost-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/AGaliuzov/boost-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/AGaliuzov/boost-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/AGaliuzov/boost-log/contents/{+path}","compare_url":"https://api.github.com/repos/AGaliuzov/boost-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AGaliuzov/boost-log/merges","archive_url":"https://api.github.com/repos/AGaliuzov/boost-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AGaliuzov/boost-log/downloads","issues_url":"https://api.github.com/repos/AGaliuzov/boost-log/issues{/number}","pulls_url":"https://api.github.com/repos/AGaliuzov/boost-log/pulls{/number}","milestones_url":"https://api.github.com/repos/AGaliuzov/boost-log/milestones{/number}","notifications_url":"https://api.github.com/repos/AGaliuzov/boost-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AGaliuzov/boost-log/labels{/name}","releases_url":"https://api.github.com/repos/AGaliuzov/boost-log/releases{/id}","deployments_url":"https://api.github.com/repos/AGaliuzov/boost-log/deployments","created_at":"2016-09-18T19:59:26Z","updated_at":"2016-09-18T19:59:28Z","pushed_at":"2016-09-30T22:31:22Z","git_url":"git://github.com/AGaliuzov/boost-log.git","ssh_url":"git@github.com:AGaliuzov/boost-log.git","clone_url":"https://github.com/AGaliuzov/boost-log.git","svn_url":"https://github.com/AGaliuzov/boost-log","homepage":null,"size":458,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"malirod:develop","ref":"develop","sha":"6d43b068fe19c9035014e7565387e03c05eabd92","user":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"repo":{"id":68472055,"name":"boost-log","full_name":"malirod/boost-log","owner":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/malirod/boost-log","description":"Boost logger sample","fork":false,"url":"https://api.github.com/repos/malirod/boost-log","forks_url":"https://api.github.com/repos/malirod/boost-log/forks","keys_url":"https://api.github.com/repos/malirod/boost-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/malirod/boost-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/malirod/boost-log/teams","hooks_url":"https://api.github.com/repos/malirod/boost-log/hooks","issue_events_url":"https://api.github.com/repos/malirod/boost-log/issues/events{/number}","events_url":"https://api.github.com/repos/malirod/boost-log/events","assignees_url":"https://api.github.com/repos/malirod/boost-log/assignees{/user}","branches_url":"https://api.github.com/repos/malirod/boost-log/branches{/branch}","tags_url":"https://api.github.com/repos/malirod/boost-log/tags","blobs_url":"https://api.github.com/repos/malirod/boost-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/malirod/boost-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/malirod/boost-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/malirod/boost-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/malirod/boost-log/statuses/{sha}","languages_url":"https://api.github.com/repos/malirod/boost-log/languages","stargazers_url":"https://api.github.com/repos/malirod/boost-log/stargazers","contributors_url":"https://api.github.com/repos/malirod/boost-log/contributors","subscribers_url":"https://api.github.com/repos/malirod/boost-log/subscribers","subscription_url":"https://api.github.com/repos/malirod/boost-log/subscription","commits_url":"https://api.github.com/repos/malirod/boost-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/malirod/boost-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/malirod/boost-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/malirod/boost-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/malirod/boost-log/contents/{+path}","compare_url":"https://api.github.com/repos/malirod/boost-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/malirod/boost-log/merges","archive_url":"https://api.github.com/repos/malirod/boost-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/malirod/boost-log/downloads","issues_url":"https://api.github.com/repos/malirod/boost-log/issues{/number}","pulls_url":"https://api.github.com/repos/malirod/boost-log/pulls{/number}","milestones_url":"https://api.github.com/repos/malirod/boost-log/milestones{/number}","notifications_url":"https://api.github.com/repos/malirod/boost-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/malirod/boost-log/labels{/name}","releases_url":"https://api.github.com/repos/malirod/boost-log/releases{/id}","deployments_url":"https://api.github.com/repos/malirod/boost-log/deployments","created_at":"2016-09-17T18:54:41Z","updated_at":"2016-09-24T18:28:43Z","pushed_at":"2016-10-01T05:40:51Z","git_url":"git://github.com/malirod/boost-log.git","ssh_url":"git@github.com:malirod/boost-log.git","clone_url":"https://github.com/malirod/boost-log.git","svn_url":"https://github.com/malirod/boost-log","homepage":null,"size":457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/11"},"html":{"href":"https://github.com/malirod/boost-log/pull/11"},"issue":{"href":"https://api.github.com/repos/malirod/boost-log/issues/11"},"comments":{"href":"https://api.github.com/repos/malirod/boost-log/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/malirod/boost-log/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/malirod/boost-log/statuses/1d1cc3bab72a4835a7cdbee8187586d67c49ed8f"}}}}
{"actor":{"display_login":"malirod"}}