{"action":"created","comment":{"url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/comments/89771044","pull_request_review_id":10304450,"id":89771044,"diff_hunk":"@@ -128,30 +132,49 @@ def check_volumedrivers(logger):\n                 name = \"ovs-healthcheck-test-{0}.raw\".format(VolumedriverHealthCheck.MACHINE_ID)\n                 if vp.guid in VolumedriverHealthCheck.MACHINE_DETAILS.vpools_guids:\n                     try:\n-                        file_path = \"/mnt/{0}/{1}\".format(vp.name, name)\n-                        vdisk_guid = VolumedriverHealthCheck._check_volumedriver(name, vp.guid)\n-                        time.sleep(VolumedriverHealthCheck.VDISK_TIMEOUT_BEFORE_DELETE)\n-                        if os.path.exists(file_path):\n-                            # working\n-                            VolumedriverHealthCheck._check_volumedriver_remove(vdisk_guid)\n-                            logger.success(\"Volumedriver of vPool '{0}' is working fine!\".format(vp.name),\n-                                           'volumedriver_{0}'.format(vp.name))\n+                        # delete if previous vdisk with this name exists\n+                        if VolumedriverHealthCheck._check_volumedriver_remove(vpool_name=vp.name, vdisk_name=name,","path":"ovs/extensions/healthcheck/volumedriver/volumedriver_health_check.py","position":121,"original_position":121,"commit_id":"e32cd5f814e8c73f2fdf401782efa12e35cf30a5","original_commit_id":"e32cd5f814e8c73f2fdf401782efa12e35cf30a5","user":{"login":"JeffreyDevloo","id":17570109,"avatar_url":"https://avatars.githubusercontent.com/u/17570109?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffreyDevloo","html_url":"https://github.com/JeffreyDevloo","followers_url":"https://api.github.com/users/JeffreyDevloo/followers","following_url":"https://api.github.com/users/JeffreyDevloo/following{/other_user}","gists_url":"https://api.github.com/users/JeffreyDevloo/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffreyDevloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffreyDevloo/subscriptions","organizations_url":"https://api.github.com/users/JeffreyDevloo/orgs","repos_url":"https://api.github.com/users/JeffreyDevloo/repos","events_url":"https://api.github.com/users/JeffreyDevloo/events{/privacy}","received_events_url":"https://api.github.com/users/JeffreyDevloo/received_events","type":"User","site_admin":false},"body":"Why do you expect there to be a vdisk already present with the name?\r\nThis points out that the healthcheck can't cleanup decently after a previous failed run.","created_at":"2016-11-28T12:25:26Z","updated_at":"2016-11-28T12:25:28Z","html_url":"https://github.com/openvstorage/openvstorage-health-check/pull/161#discussion_r89771044","pull_request_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/comments/89771044"},"html":{"href":"https://github.com/openvstorage/openvstorage-health-check/pull/161#discussion_r89771044"},"pull_request":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161","id":95487226,"html_url":"https://github.com/openvstorage/openvstorage-health-check/pull/161","diff_url":"https://github.com/openvstorage/openvstorage-health-check/pull/161.diff","patch_url":"https://github.com/openvstorage/openvstorage-health-check/pull/161.patch","issue_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/161","number":161,"state":"open","locked":false,"title":"volumedriver fixes","user":{"login":"kinvaris","id":4190375,"avatar_url":"https://avatars.githubusercontent.com/u/4190375?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvaris","html_url":"https://github.com/kinvaris","followers_url":"https://api.github.com/users/kinvaris/followers","following_url":"https://api.github.com/users/kinvaris/following{/other_user}","gists_url":"https://api.github.com/users/kinvaris/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvaris/subscriptions","organizations_url":"https://api.github.com/users/kinvaris/orgs","repos_url":"https://api.github.com/users/kinvaris/repos","events_url":"https://api.github.com/users/kinvaris/events{/privacy}","received_events_url":"https://api.github.com/users/kinvaris/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-28T12:09:46Z","updated_at":"2016-11-28T12:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ce0382b3f4249b9484f7d5858bc614b3a23cfbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161/commits","review_comments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161/comments","review_comment_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/161/comments","statuses_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/statuses/e32cd5f814e8c73f2fdf401782efa12e35cf30a5","head":{"label":"openvstorage:fargo-volfixes","ref":"fargo-volfixes","sha":"e32cd5f814e8c73f2fdf401782efa12e35cf30a5","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":52349527,"name":"openvstorage-health-check","full_name":"openvstorage/openvstorage-health-check","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/openvstorage-health-check","description":"The health check is classified as a monitoring, detection and healing tool for Open vStorage.","fork":false,"url":"https://api.github.com/repos/openvstorage/openvstorage-health-check","forks_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/forks","keys_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/teams","hooks_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/events","assignees_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/tags","blobs_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/languages","stargazers_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/subscription","commits_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/merges","archive_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/downloads","issues_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/deployments","created_at":"2016-02-23T10:05:01Z","updated_at":"2016-10-24T12:09:03Z","pushed_at":"2016-11-28T12:10:32Z","git_url":"git://github.com/openvstorage/openvstorage-health-check.git","ssh_url":"git@github.com:openvstorage/openvstorage-health-check.git","clone_url":"https://github.com/openvstorage/openvstorage-health-check.git","svn_url":"https://github.com/openvstorage/openvstorage-health-check","homepage":"","size":497,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":2,"default_branch":"master"}},"base":{"label":"openvstorage:fargo","ref":"fargo","sha":"67a27c061d33edb5435563eb061a60f6f2d473be","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":52349527,"name":"openvstorage-health-check","full_name":"openvstorage/openvstorage-health-check","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/openvstorage-health-check","description":"The health check is classified as a monitoring, detection and healing tool for Open vStorage.","fork":false,"url":"https://api.github.com/repos/openvstorage/openvstorage-health-check","forks_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/forks","keys_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/teams","hooks_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/events","assignees_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/tags","blobs_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/languages","stargazers_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/subscription","commits_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/merges","archive_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/downloads","issues_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/openvstorage-health-check/deployments","created_at":"2016-02-23T10:05:01Z","updated_at":"2016-10-24T12:09:03Z","pushed_at":"2016-11-28T12:10:32Z","git_url":"git://github.com/openvstorage/openvstorage-health-check.git","ssh_url":"git@github.com:openvstorage/openvstorage-health-check.git","clone_url":"https://github.com/openvstorage/openvstorage-health-check.git","svn_url":"https://github.com/openvstorage/openvstorage-health-check","homepage":"","size":497,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161"},"html":{"href":"https://github.com/openvstorage/openvstorage-health-check/pull/161"},"issue":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/161"},"comments":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/openvstorage/openvstorage-health-check/statuses/e32cd5f814e8c73f2fdf401782efa12e35cf30a5"}}}}
{"actor":{"display_login":"JeffreyDevloo"}}