{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/ocitools/pulls/comments/75906277","id":75906277,"diff_hunk":"@@ -340,6 +336,14 @@ func checkLinux(spec rspec.Spec, rootfs string, hostCheck bool) (msgs []string)\n \t\t}\n \t}\n \n+\tif (len(spec.Linux.UIDMappings) > 0 || len(spec.Linux.GIDMappings) > 0) && !userExists {\n+\t\tmsgs = append(msgs, \"UID/GID mappings require User namespace exists\")","path":"cmd/ocitools/validate.go","position":26,"original_position":26,"commit_id":"b4775363ee6cd030f65afabd4f63f752e5c52b74","original_commit_id":"b4775363ee6cd030f65afabd4f63f752e5c52b74","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"The phrasing used by existing similar warnings is:\r\n\r\n> {setting} requires a new {type} namespace to be specified as well\r\n","created_at":"2016-08-23T16:50:22Z","updated_at":"2016-08-23T16:50:22Z","html_url":"https://github.com/opencontainers/ocitools/pull/199#discussion_r75906277","pull_request_url":"https://api.github.com/repos/opencontainers/ocitools/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/comments/75906277"},"html":{"href":"https://github.com/opencontainers/ocitools/pull/199#discussion_r75906277"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/ocitools/pulls/199","id":82313921,"html_url":"https://github.com/opencontainers/ocitools/pull/199","diff_url":"https://github.com/opencontainers/ocitools/pull/199.diff","patch_url":"https://github.com/opencontainers/ocitools/pull/199.patch","issue_url":"https://api.github.com/repos/opencontainers/ocitools/issues/199","number":199,"state":"open","locked":false,"title":"add namespace check for uid/gid mappings","user":{"login":"Mashimiao","id":4852224,"avatar_url":"https://avatars.githubusercontent.com/u/4852224?v=3","gravatar_id":"","url":"https://api.github.com/users/Mashimiao","html_url":"https://github.com/Mashimiao","followers_url":"https://api.github.com/users/Mashimiao/followers","following_url":"https://api.github.com/users/Mashimiao/following{/other_user}","gists_url":"https://api.github.com/users/Mashimiao/gists{/gist_id}","starred_url":"https://api.github.com/users/Mashimiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mashimiao/subscriptions","organizations_url":"https://api.github.com/users/Mashimiao/orgs","repos_url":"https://api.github.com/users/Mashimiao/repos","events_url":"https://api.github.com/users/Mashimiao/events{/privacy}","received_events_url":"https://api.github.com/users/Mashimiao/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>","created_at":"2016-08-23T07:12:19Z","updated_at":"2016-08-23T16:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e31ae7a9007979dd336ea19f61f1dd4806dbc0aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/ocitools/pulls/199/commits","review_comments_url":"https://api.github.com/repos/opencontainers/ocitools/pulls/199/comments","review_comment_url":"https://api.github.com/repos/opencontainers/ocitools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/ocitools/issues/199/comments","statuses_url":"https://api.github.com/repos/opencontainers/ocitools/statuses/b4775363ee6cd030f65afabd4f63f752e5c52b74","head":{"label":"Mashimiao:add-namespace-check-for-mappings","ref":"add-namespace-check-for-mappings","sha":"b4775363ee6cd030f65afabd4f63f752e5c52b74","user":{"login":"Mashimiao","id":4852224,"avatar_url":"https://avatars.githubusercontent.com/u/4852224?v=3","gravatar_id":"","url":"https://api.github.com/users/Mashimiao","html_url":"https://github.com/Mashimiao","followers_url":"https://api.github.com/users/Mashimiao/followers","following_url":"https://api.github.com/users/Mashimiao/following{/other_user}","gists_url":"https://api.github.com/users/Mashimiao/gists{/gist_id}","starred_url":"https://api.github.com/users/Mashimiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mashimiao/subscriptions","organizations_url":"https://api.github.com/users/Mashimiao/orgs","repos_url":"https://api.github.com/users/Mashimiao/repos","events_url":"https://api.github.com/users/Mashimiao/events{/privacy}","received_events_url":"https://api.github.com/users/Mashimiao/received_events","type":"User","site_admin":false},"repo":{"id":57274243,"name":"ocitools","full_name":"Mashimiao/ocitools","owner":{"login":"Mashimiao","id":4852224,"avatar_url":"https://avatars.githubusercontent.com/u/4852224?v=3","gravatar_id":"","url":"https://api.github.com/users/Mashimiao","html_url":"https://github.com/Mashimiao","followers_url":"https://api.github.com/users/Mashimiao/followers","following_url":"https://api.github.com/users/Mashimiao/following{/other_user}","gists_url":"https://api.github.com/users/Mashimiao/gists{/gist_id}","starred_url":"https://api.github.com/users/Mashimiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mashimiao/subscriptions","organizations_url":"https://api.github.com/users/Mashimiao/orgs","repos_url":"https://api.github.com/users/Mashimiao/repos","events_url":"https://api.github.com/users/Mashimiao/events{/privacy}","received_events_url":"https://api.github.com/users/Mashimiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mashimiao/ocitools","description":"OCI Testing Toolset","fork":true,"url":"https://api.github.com/repos/Mashimiao/ocitools","forks_url":"https://api.github.com/repos/Mashimiao/ocitools/forks","keys_url":"https://api.github.com/repos/Mashimiao/ocitools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mashimiao/ocitools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mashimiao/ocitools/teams","hooks_url":"https://api.github.com/repos/Mashimiao/ocitools/hooks","issue_events_url":"https://api.github.com/repos/Mashimiao/ocitools/issues/events{/number}","events_url":"https://api.github.com/repos/Mashimiao/ocitools/events","assignees_url":"https://api.github.com/repos/Mashimiao/ocitools/assignees{/user}","branches_url":"https://api.github.com/repos/Mashimiao/ocitools/branches{/branch}","tags_url":"https://api.github.com/repos/Mashimiao/ocitools/tags","blobs_url":"https://api.github.com/repos/Mashimiao/ocitools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mashimiao/ocitools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mashimiao/ocitools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mashimiao/ocitools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mashimiao/ocitools/statuses/{sha}","languages_url":"https://api.github.com/repos/Mashimiao/ocitools/languages","stargazers_url":"https://api.github.com/repos/Mashimiao/ocitools/stargazers","contributors_url":"https://api.github.com/repos/Mashimiao/ocitools/contributors","subscribers_url":"https://api.github.com/repos/Mashimiao/ocitools/subscribers","subscription_url":"https://api.github.com/repos/Mashimiao/ocitools/subscription","commits_url":"https://api.github.com/repos/Mashimiao/ocitools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mashimiao/ocitools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mashimiao/ocitools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mashimiao/ocitools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mashimiao/ocitools/contents/{+path}","compare_url":"https://api.github.com/repos/Mashimiao/ocitools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mashimiao/ocitools/merges","archive_url":"https://api.github.com/repos/Mashimiao/ocitools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mashimiao/ocitools/downloads","issues_url":"https://api.github.com/repos/Mashimiao/ocitools/issues{/number}","pulls_url":"https://api.github.com/repos/Mashimiao/ocitools/pulls{/number}","milestones_url":"https://api.github.com/repos/Mashimiao/ocitools/milestones{/number}","notifications_url":"https://api.github.com/repos/Mashimiao/ocitools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mashimiao/ocitools/labels{/name}","releases_url":"https://api.github.com/repos/Mashimiao/ocitools/releases{/id}","deployments_url":"https://api.github.com/repos/Mashimiao/ocitools/deployments","created_at":"2016-04-28T05:42:23Z","updated_at":"2016-04-28T05:46:00Z","pushed_at":"2016-08-23T08:29:26Z","git_url":"git://github.com/Mashimiao/ocitools.git","ssh_url":"git@github.com:Mashimiao/ocitools.git","clone_url":"https://github.com/Mashimiao/ocitools.git","svn_url":"https://github.com/Mashimiao/ocitools","homepage":"https://www.opencontainers.org/","size":2792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"ebda26c0fe4a5edbc2b308ebf6e6f6738165c7e2","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":49598840,"name":"ocitools","full_name":"opencontainers/ocitools","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/ocitools","description":"OCI runtime tools","fork":false,"url":"https://api.github.com/repos/opencontainers/ocitools","forks_url":"https://api.github.com/repos/opencontainers/ocitools/forks","keys_url":"https://api.github.com/repos/opencontainers/ocitools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/ocitools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/ocitools/teams","hooks_url":"https://api.github.com/repos/opencontainers/ocitools/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/ocitools/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/ocitools/events","assignees_url":"https://api.github.com/repos/opencontainers/ocitools/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/ocitools/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/ocitools/tags","blobs_url":"https://api.github.com/repos/opencontainers/ocitools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/ocitools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/ocitools/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/ocitools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/ocitools/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/ocitools/languages","stargazers_url":"https://api.github.com/repos/opencontainers/ocitools/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/ocitools/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/ocitools/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/ocitools/subscription","commits_url":"https://api.github.com/repos/opencontainers/ocitools/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/ocitools/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/ocitools/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/ocitools/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/ocitools/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/ocitools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/ocitools/merges","archive_url":"https://api.github.com/repos/opencontainers/ocitools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/ocitools/downloads","issues_url":"https://api.github.com/repos/opencontainers/ocitools/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/ocitools/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/ocitools/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/ocitools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/ocitools/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/ocitools/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/ocitools/deployments","created_at":"2016-01-13T20:10:21Z","updated_at":"2016-08-08T21:47:19Z","pushed_at":"2016-08-23T08:30:19Z","git_url":"git://github.com/opencontainers/ocitools.git","ssh_url":"git@github.com:opencontainers/ocitools.git","clone_url":"https://github.com/opencontainers/ocitools.git","svn_url":"https://github.com/opencontainers/ocitools","homepage":"https://www.opencontainers.org/","size":2997,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/199"},"html":{"href":"https://github.com/opencontainers/ocitools/pull/199"},"issue":{"href":"https://api.github.com/repos/opencontainers/ocitools/issues/199"},"comments":{"href":"https://api.github.com/repos/opencontainers/ocitools/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/ocitools/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/ocitools/statuses/b4775363ee6cd030f65afabd4f63f752e5c52b74"}}}}
{"actor":{"display_login":"wking"}}