{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/79895085","id":79895085,"diff_hunk":"@@ -4963,6 +4982,10 @@ void Compiler::compCompileFinish()\n         // Make the updates.\n         genMemStats.nraTotalSizeAlloc = compGetAllocator()->getTotalBytesAllocated();\n         genMemStats.nraTotalSizeUsed  = compGetAllocator()->getTotalBytesUsed();\n+#if MEASURE_MEM_ALLOC\n+        memAllocHist.record((unsigned)((genMemStats.nraTotalSizeAlloc + 1023) / 1024));\n+        memUsedHist .record((unsigned)((genMemStats.nraTotalSizeUsed  + 1023) / 1024));","path":"src/jit/compiler.cpp","position":39,"original_position":39,"commit_id":"75ea33c97698ec47dead374874de13bd8eb5c4b6","original_commit_id":"75ea33c97698ec47dead374874de13bd8eb5c4b6","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"body":"Yes there is.","created_at":"2016-09-21T18:00:49Z","updated_at":"2016-09-21T18:00:49Z","html_url":"https://github.com/dotnet/coreclr/pull/7286#discussion_r79895085","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7286","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/79895085"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7286#discussion_r79895085"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7286"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7286","id":86089504,"html_url":"https://github.com/dotnet/coreclr/pull/7286","diff_url":"https://github.com/dotnet/coreclr/pull/7286.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7286.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7286","number":7286,"state":"open","locked":false,"title":"Display histogram of total memory per method when MEASURE_MEM_ALLOC is on.","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"body":"I made the bucket limits nice numbers like the other ones in the same file.\r\n@pgavlin @mikedn PTAL\r\n/cc @dotnet/jit-contrib\r\n\r\n","created_at":"2016-09-21T02:47:25Z","updated_at":"2016-09-21T18:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"081c38f855418c13ff964e1529090b3c97658477","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7286/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7286/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7286/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/75ea33c97698ec47dead374874de13bd8eb5c4b6","head":{"label":"pkukol:memSizeHisto","ref":"memSizeHisto","sha":"75ea33c97698ec47dead374874de13bd8eb5c4b6","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"repo":{"id":67154822,"name":"coreclr","full_name":"pkukol/coreclr","owner":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkukol/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/pkukol/coreclr","forks_url":"https://api.github.com/repos/pkukol/coreclr/forks","keys_url":"https://api.github.com/repos/pkukol/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkukol/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkukol/coreclr/teams","hooks_url":"https://api.github.com/repos/pkukol/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pkukol/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pkukol/coreclr/events","assignees_url":"https://api.github.com/repos/pkukol/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pkukol/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pkukol/coreclr/tags","blobs_url":"https://api.github.com/repos/pkukol/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkukol/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkukol/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkukol/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkukol/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pkukol/coreclr/languages","stargazers_url":"https://api.github.com/repos/pkukol/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pkukol/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pkukol/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pkukol/coreclr/subscription","commits_url":"https://api.github.com/repos/pkukol/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkukol/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkukol/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkukol/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkukol/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pkukol/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkukol/coreclr/merges","archive_url":"https://api.github.com/repos/pkukol/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkukol/coreclr/downloads","issues_url":"https://api.github.com/repos/pkukol/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pkukol/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pkukol/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pkukol/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkukol/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pkukol/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pkukol/coreclr/deployments","created_at":"2016-09-01T18:07:57Z","updated_at":"2016-09-01T18:10:20Z","pushed_at":"2016-09-21T02:44:35Z","git_url":"git://github.com/pkukol/coreclr.git","ssh_url":"git@github.com:pkukol/coreclr.git","clone_url":"https://github.com/pkukol/coreclr.git","svn_url":"https://github.com/pkukol/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":108905,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"171962f54145236ab354f64961b2174f404d605f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-09-21T12:20:01Z","pushed_at":"2016-09-21T18:00:44Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":122318,"stargazers_count":6923,"watchers_count":6923,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1655,"mirror_url":null,"open_issues_count":984,"forks":1655,"open_issues":984,"watchers":6923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7286"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7286"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7286"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7286/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7286/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7286/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/75ea33c97698ec47dead374874de13bd8eb5c4b6"}}}}
{"actor":{"display_login":"pkukol"}}