{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/52625386","id":52625386,"diff_hunk":"@@ -85,14 +96,26 @@ func TestAppCreateWithAlreadyExists(t *testing.T) {\n \ttest.AssertStatus(t, 403, \"POST\", \"http://convox/apps\", val)\n }\n \n+func TestAppCreateWithAlreadyExistsBound(t *testing.T) {\n+\taws := test.StubAws(\n+\t\ttest.DescribeStackNotFound(\"application\"),\n+\t\ttest.CreateAppStackExistsCycle(\"convox-test-application\"),\n+\t\ttest.DescribeAppStackCycle(\"convox-test-application\"),\n+\t)\n+\tdefer aws.Close()\n+\n+\tval := url.Values{\"name\": []string{\"application\"}}\n+\ttest.AssertStatus(t, 403, \"POST\", \"http://convox/apps\", val)\n+}\n+\n // TODO: test bucket cleanup. this is handled via goroutines.\n /* NOTE: the S3 stuff fucks up b.c the client ries to prepend the\n bucket name to the ephermeral host, so you get `app-XXX.127.0.0.1`\n */\n func TestAppDelete(t *testing.T) {","path":"api/controllers/apps_test.go","position":92,"original_position":92,"commit_id":"13ef519f68a43332ba034ffa46748291ed94a160","original_commit_id":"13ef519f68a43332ba034ffa46748291ed94a160","user":{"login":"nzoschke","id":147410,"avatar_url":"https://avatars.githubusercontent.com/u/147410?v=3","gravatar_id":"","url":"https://api.github.com/users/nzoschke","html_url":"https://github.com/nzoschke","followers_url":"https://api.github.com/users/nzoschke/followers","following_url":"https://api.github.com/users/nzoschke/following{/other_user}","gists_url":"https://api.github.com/users/nzoschke/gists{/gist_id}","starred_url":"https://api.github.com/users/nzoschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzoschke/subscriptions","organizations_url":"https://api.github.com/users/nzoschke/orgs","repos_url":"https://api.github.com/users/nzoschke/repos","events_url":"https://api.github.com/users/nzoschke/events{/privacy}","received_events_url":"https://api.github.com/users/nzoschke/received_events","type":"User","site_admin":false},"body":"perfect","created_at":"2016-02-11T16:24:59Z","updated_at":"2016-02-11T16:24:59Z","html_url":"https://github.com/convox/rack/pull/328#discussion_r52625386","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/328","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/52625386"},"html":{"href":"https://github.com/convox/rack/pull/328#discussion_r52625386"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/328"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/328","id":58668927,"html_url":"https://github.com/convox/rack/pull/328","diff_url":"https://github.com/convox/rack/pull/328.diff","patch_url":"https://github.com/convox/rack/pull/328.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/328","number":328,"state":"open","locked":false,"title":"Prefix app and service StackNames with the rack name.","user":{"login":"xtfxme","id":202141,"avatar_url":"https://avatars.githubusercontent.com/u/202141?v=3","gravatar_id":"","url":"https://api.github.com/users/xtfxme","html_url":"https://github.com/xtfxme","followers_url":"https://api.github.com/users/xtfxme/followers","following_url":"https://api.github.com/users/xtfxme/following{/other_user}","gists_url":"https://api.github.com/users/xtfxme/gists{/gist_id}","starred_url":"https://api.github.com/users/xtfxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtfxme/subscriptions","organizations_url":"https://api.github.com/users/xtfxme/orgs","repos_url":"https://api.github.com/users/xtfxme/repos","events_url":"https://api.github.com/users/xtfxme/events{/privacy}","received_events_url":"https://api.github.com/users/xtfxme/received_events","type":"User","site_admin":false},"body":"Calls to `GetApp` and `GetService` attempt to resolve `name` then `rack-name`.\r\nThis preserves backwards compatibility with apps and services created before\r\nthis patch. A side-effect of this behavior is rack names will continue\r\nconflicting with app names until we can be certain no \"prefix-less\" apps exist.\r\n\r\nPatch introduces a new model helper, `shortNameToStackName`, and two new\r\nmethods, `App.StackName` and `Service.StackName`.","created_at":"2016-02-08T21:23:13Z","updated_at":"2016-02-11T16:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8410f81d9d295257960b23a5ccea53d216f7a60f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/328/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/328/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/328/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/13ef519f68a43332ba034ffa46748291ed94a160","head":{"label":"xtfxme:stack-prefixes","ref":"stack-prefixes","sha":"13ef519f68a43332ba034ffa46748291ed94a160","user":{"login":"xtfxme","id":202141,"avatar_url":"https://avatars.githubusercontent.com/u/202141?v=3","gravatar_id":"","url":"https://api.github.com/users/xtfxme","html_url":"https://github.com/xtfxme","followers_url":"https://api.github.com/users/xtfxme/followers","following_url":"https://api.github.com/users/xtfxme/following{/other_user}","gists_url":"https://api.github.com/users/xtfxme/gists{/gist_id}","starred_url":"https://api.github.com/users/xtfxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtfxme/subscriptions","organizations_url":"https://api.github.com/users/xtfxme/orgs","repos_url":"https://api.github.com/users/xtfxme/repos","events_url":"https://api.github.com/users/xtfxme/events{/privacy}","received_events_url":"https://api.github.com/users/xtfxme/received_events","type":"User","site_admin":false},"repo":{"id":49510469,"name":"rack","full_name":"xtfxme/rack","owner":{"login":"xtfxme","id":202141,"avatar_url":"https://avatars.githubusercontent.com/u/202141?v=3","gravatar_id":"","url":"https://api.github.com/users/xtfxme","html_url":"https://github.com/xtfxme","followers_url":"https://api.github.com/users/xtfxme/followers","following_url":"https://api.github.com/users/xtfxme/following{/other_user}","gists_url":"https://api.github.com/users/xtfxme/gists{/gist_id}","starred_url":"https://api.github.com/users/xtfxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtfxme/subscriptions","organizations_url":"https://api.github.com/users/xtfxme/orgs","repos_url":"https://api.github.com/users/xtfxme/repos","events_url":"https://api.github.com/users/xtfxme/events{/privacy}","received_events_url":"https://api.github.com/users/xtfxme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xtfxme/rack","description":"Open-source PaaS on AWS","fork":true,"url":"https://api.github.com/repos/xtfxme/rack","forks_url":"https://api.github.com/repos/xtfxme/rack/forks","keys_url":"https://api.github.com/repos/xtfxme/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtfxme/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtfxme/rack/teams","hooks_url":"https://api.github.com/repos/xtfxme/rack/hooks","issue_events_url":"https://api.github.com/repos/xtfxme/rack/issues/events{/number}","events_url":"https://api.github.com/repos/xtfxme/rack/events","assignees_url":"https://api.github.com/repos/xtfxme/rack/assignees{/user}","branches_url":"https://api.github.com/repos/xtfxme/rack/branches{/branch}","tags_url":"https://api.github.com/repos/xtfxme/rack/tags","blobs_url":"https://api.github.com/repos/xtfxme/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtfxme/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtfxme/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtfxme/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtfxme/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/xtfxme/rack/languages","stargazers_url":"https://api.github.com/repos/xtfxme/rack/stargazers","contributors_url":"https://api.github.com/repos/xtfxme/rack/contributors","subscribers_url":"https://api.github.com/repos/xtfxme/rack/subscribers","subscription_url":"https://api.github.com/repos/xtfxme/rack/subscription","commits_url":"https://api.github.com/repos/xtfxme/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtfxme/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtfxme/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtfxme/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/xtfxme/rack/contents/{+path}","compare_url":"https://api.github.com/repos/xtfxme/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtfxme/rack/merges","archive_url":"https://api.github.com/repos/xtfxme/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtfxme/rack/downloads","issues_url":"https://api.github.com/repos/xtfxme/rack/issues{/number}","pulls_url":"https://api.github.com/repos/xtfxme/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/xtfxme/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/xtfxme/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtfxme/rack/labels{/name}","releases_url":"https://api.github.com/repos/xtfxme/rack/releases{/id}","deployments_url":"https://api.github.com/repos/xtfxme/rack/deployments","created_at":"2016-01-12T15:49:05Z","updated_at":"2016-01-12T15:49:06Z","pushed_at":"2016-02-11T04:10:29Z","git_url":"git://github.com/xtfxme/rack.git","ssh_url":"git@github.com:xtfxme/rack.git","clone_url":"https://github.com/xtfxme/rack.git","svn_url":"https://github.com/xtfxme/rack","homepage":"https://convox.com","size":40659,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"da1873ea7768e92a87dd11d1c23720295311c781","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-02-09T21:10:51Z","pushed_at":"2016-02-11T07:13:19Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":40720,"stargazers_count":143,"watchers_count":143,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":51,"forks":24,"open_issues":51,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/328"},"html":{"href":"https://github.com/convox/rack/pull/328"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/328"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/13ef519f68a43332ba034ffa46748291ed94a160"}}}}