{"action":"closed","number":1651,"pull_request":{"url":"https://api.github.com/repos/numba/numba/pulls/1651","id":56979492,"html_url":"https://github.com/numba/numba/pull/1651","diff_url":"https://github.com/numba/numba/pull/1651.diff","patch_url":"https://github.com/numba/numba/pull/1651.patch","issue_url":"https://api.github.com/repos/numba/numba/issues/1651","number":1651,"state":"closed","locked":false,"title":"Implementation of np.linalg.inv using Lapack","user":{"login":"MatthieuDartiailh","id":4481740,"avatar_url":"https://avatars.githubusercontent.com/u/4481740?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthieuDartiailh","html_url":"https://github.com/MatthieuDartiailh","followers_url":"https://api.github.com/users/MatthieuDartiailh/followers","following_url":"https://api.github.com/users/MatthieuDartiailh/following{/other_user}","gists_url":"https://api.github.com/users/MatthieuDartiailh/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthieuDartiailh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthieuDartiailh/subscriptions","organizations_url":"https://api.github.com/users/MatthieuDartiailh/orgs","repos_url":"https://api.github.com/users/MatthieuDartiailh/repos","events_url":"https://api.github.com/users/MatthieuDartiailh/events{/privacy}","received_events_url":"https://api.github.com/users/MatthieuDartiailh/received_events","type":"User","site_admin":false},"body":"I started working on implementing np.linalg.inv using the cython Lapack binding found in scipy. I am far from finished but I would like some advices as I am not at all familiar with the internals of numba.\r\nI will summarize my main questions here (they also appear as inline comments in my changes) : \r\n-  in _helperlib.c integer seems to always be passed as Py_ssize_t. When calling LAPACK functions I need to provide integer pointers used as return values should I also use Py_ssize_t.\r\n- to create new arrays for internal use I compiled functions calling numpy functions. Is this the right way to go ? If yes, what is the exact return type of the function ? should it be treated as the numpy arrays passed as input arguments ?\r\n- for raising exceptions I am also using compile_internal, is that correct ?\r\n- when using numba types (such as integer), how should those types be instantiated in signatures ?\r\n\r\nAny other comment is of course welcomed !\r\n\r\nThanks\r\nMatthieu","created_at":"2016-01-23T16:13:09Z","updated_at":"2016-01-28T17:58:21Z","closed_at":"2016-01-28T17:58:21Z","merged_at":"2016-01-28T17:58:21Z","merge_commit_sha":"f55aa94dac50afa2536f2235a5f749ae83c1c305","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numba/numba/pulls/1651/commits","review_comments_url":"https://api.github.com/repos/numba/numba/pulls/1651/comments","review_comment_url":"https://api.github.com/repos/numba/numba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numba/numba/issues/1651/comments","statuses_url":"https://api.github.com/repos/numba/numba/statuses/02f66e4424fb1342088eb1d42c85596892b45dd8","head":{"label":"MatthieuDartiailh:lapack","ref":"lapack","sha":"02f66e4424fb1342088eb1d42c85596892b45dd8","user":{"login":"MatthieuDartiailh","id":4481740,"avatar_url":"https://avatars.githubusercontent.com/u/4481740?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthieuDartiailh","html_url":"https://github.com/MatthieuDartiailh","followers_url":"https://api.github.com/users/MatthieuDartiailh/followers","following_url":"https://api.github.com/users/MatthieuDartiailh/following{/other_user}","gists_url":"https://api.github.com/users/MatthieuDartiailh/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthieuDartiailh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthieuDartiailh/subscriptions","organizations_url":"https://api.github.com/users/MatthieuDartiailh/orgs","repos_url":"https://api.github.com/users/MatthieuDartiailh/repos","events_url":"https://api.github.com/users/MatthieuDartiailh/events{/privacy}","received_events_url":"https://api.github.com/users/MatthieuDartiailh/received_events","type":"User","site_admin":false},"repo":{"id":50117481,"name":"numba","full_name":"MatthieuDartiailh/numba","owner":{"login":"MatthieuDartiailh","id":4481740,"avatar_url":"https://avatars.githubusercontent.com/u/4481740?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthieuDartiailh","html_url":"https://github.com/MatthieuDartiailh","followers_url":"https://api.github.com/users/MatthieuDartiailh/followers","following_url":"https://api.github.com/users/MatthieuDartiailh/following{/other_user}","gists_url":"https://api.github.com/users/MatthieuDartiailh/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthieuDartiailh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthieuDartiailh/subscriptions","organizations_url":"https://api.github.com/users/MatthieuDartiailh/orgs","repos_url":"https://api.github.com/users/MatthieuDartiailh/repos","events_url":"https://api.github.com/users/MatthieuDartiailh/events{/privacy}","received_events_url":"https://api.github.com/users/MatthieuDartiailh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatthieuDartiailh/numba","description":"NumPy aware dynamic Python compiler using LLVM","fork":true,"url":"https://api.github.com/repos/MatthieuDartiailh/numba","forks_url":"https://api.github.com/repos/MatthieuDartiailh/numba/forks","keys_url":"https://api.github.com/repos/MatthieuDartiailh/numba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatthieuDartiailh/numba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatthieuDartiailh/numba/teams","hooks_url":"https://api.github.com/repos/MatthieuDartiailh/numba/hooks","issue_events_url":"https://api.github.com/repos/MatthieuDartiailh/numba/issues/events{/number}","events_url":"https://api.github.com/repos/MatthieuDartiailh/numba/events","assignees_url":"https://api.github.com/repos/MatthieuDartiailh/numba/assignees{/user}","branches_url":"https://api.github.com/repos/MatthieuDartiailh/numba/branches{/branch}","tags_url":"https://api.github.com/repos/MatthieuDartiailh/numba/tags","blobs_url":"https://api.github.com/repos/MatthieuDartiailh/numba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatthieuDartiailh/numba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatthieuDartiailh/numba/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatthieuDartiailh/numba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatthieuDartiailh/numba/statuses/{sha}","languages_url":"https://api.github.com/repos/MatthieuDartiailh/numba/languages","stargazers_url":"https://api.github.com/repos/MatthieuDartiailh/numba/stargazers","contributors_url":"https://api.github.com/repos/MatthieuDartiailh/numba/contributors","subscribers_url":"https://api.github.com/repos/MatthieuDartiailh/numba/subscribers","subscription_url":"https://api.github.com/repos/MatthieuDartiailh/numba/subscription","commits_url":"https://api.github.com/repos/MatthieuDartiailh/numba/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatthieuDartiailh/numba/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatthieuDartiailh/numba/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatthieuDartiailh/numba/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatthieuDartiailh/numba/contents/{+path}","compare_url":"https://api.github.com/repos/MatthieuDartiailh/numba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatthieuDartiailh/numba/merges","archive_url":"https://api.github.com/repos/MatthieuDartiailh/numba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatthieuDartiailh/numba/downloads","issues_url":"https://api.github.com/repos/MatthieuDartiailh/numba/issues{/number}","pulls_url":"https://api.github.com/repos/MatthieuDartiailh/numba/pulls{/number}","milestones_url":"https://api.github.com/repos/MatthieuDartiailh/numba/milestones{/number}","notifications_url":"https://api.github.com/repos/MatthieuDartiailh/numba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatthieuDartiailh/numba/labels{/name}","releases_url":"https://api.github.com/repos/MatthieuDartiailh/numba/releases{/id}","deployments_url":"https://api.github.com/repos/MatthieuDartiailh/numba/deployments","created_at":"2016-01-21T15:43:19Z","updated_at":"2016-01-21T15:43:21Z","pushed_at":"2016-01-28T17:30:20Z","git_url":"git://github.com/MatthieuDartiailh/numba.git","ssh_url":"git@github.com:MatthieuDartiailh/numba.git","clone_url":"https://github.com/MatthieuDartiailh/numba.git","svn_url":"https://github.com/MatthieuDartiailh/numba","homepage":"http://numba.pydata.org/","size":26889,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numba:master","ref":"master","sha":"26714bb289844bb02c0fab2566a44915a183483e","user":{"login":"numba","id":1628082,"avatar_url":"https://avatars.githubusercontent.com/u/1628082?v=3","gravatar_id":"","url":"https://api.github.com/users/numba","html_url":"https://github.com/numba","followers_url":"https://api.github.com/users/numba/followers","following_url":"https://api.github.com/users/numba/following{/other_user}","gists_url":"https://api.github.com/users/numba/gists{/gist_id}","starred_url":"https://api.github.com/users/numba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numba/subscriptions","organizations_url":"https://api.github.com/users/numba/orgs","repos_url":"https://api.github.com/users/numba/repos","events_url":"https://api.github.com/users/numba/events{/privacy}","received_events_url":"https://api.github.com/users/numba/received_events","type":"Organization","site_admin":false},"repo":{"id":3659275,"name":"numba","full_name":"numba/numba","owner":{"login":"numba","id":1628082,"avatar_url":"https://avatars.githubusercontent.com/u/1628082?v=3","gravatar_id":"","url":"https://api.github.com/users/numba","html_url":"https://github.com/numba","followers_url":"https://api.github.com/users/numba/followers","following_url":"https://api.github.com/users/numba/following{/other_user}","gists_url":"https://api.github.com/users/numba/gists{/gist_id}","starred_url":"https://api.github.com/users/numba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numba/subscriptions","organizations_url":"https://api.github.com/users/numba/orgs","repos_url":"https://api.github.com/users/numba/repos","events_url":"https://api.github.com/users/numba/events{/privacy}","received_events_url":"https://api.github.com/users/numba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numba/numba","description":"NumPy aware dynamic Python compiler using LLVM","fork":false,"url":"https://api.github.com/repos/numba/numba","forks_url":"https://api.github.com/repos/numba/numba/forks","keys_url":"https://api.github.com/repos/numba/numba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numba/numba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numba/numba/teams","hooks_url":"https://api.github.com/repos/numba/numba/hooks","issue_events_url":"https://api.github.com/repos/numba/numba/issues/events{/number}","events_url":"https://api.github.com/repos/numba/numba/events","assignees_url":"https://api.github.com/repos/numba/numba/assignees{/user}","branches_url":"https://api.github.com/repos/numba/numba/branches{/branch}","tags_url":"https://api.github.com/repos/numba/numba/tags","blobs_url":"https://api.github.com/repos/numba/numba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numba/numba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numba/numba/git/refs{/sha}","trees_url":"https://api.github.com/repos/numba/numba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numba/numba/statuses/{sha}","languages_url":"https://api.github.com/repos/numba/numba/languages","stargazers_url":"https://api.github.com/repos/numba/numba/stargazers","contributors_url":"https://api.github.com/repos/numba/numba/contributors","subscribers_url":"https://api.github.com/repos/numba/numba/subscribers","subscription_url":"https://api.github.com/repos/numba/numba/subscription","commits_url":"https://api.github.com/repos/numba/numba/commits{/sha}","git_commits_url":"https://api.github.com/repos/numba/numba/git/commits{/sha}","comments_url":"https://api.github.com/repos/numba/numba/comments{/number}","issue_comment_url":"https://api.github.com/repos/numba/numba/issues/comments{/number}","contents_url":"https://api.github.com/repos/numba/numba/contents/{+path}","compare_url":"https://api.github.com/repos/numba/numba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numba/numba/merges","archive_url":"https://api.github.com/repos/numba/numba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numba/numba/downloads","issues_url":"https://api.github.com/repos/numba/numba/issues{/number}","pulls_url":"https://api.github.com/repos/numba/numba/pulls{/number}","milestones_url":"https://api.github.com/repos/numba/numba/milestones{/number}","notifications_url":"https://api.github.com/repos/numba/numba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numba/numba/labels{/name}","releases_url":"https://api.github.com/repos/numba/numba/releases{/id}","deployments_url":"https://api.github.com/repos/numba/numba/deployments","created_at":"2012-03-08T11:12:43Z","updated_at":"2016-01-28T17:31:11Z","pushed_at":"2016-01-28T17:58:21Z","git_url":"git://github.com/numba/numba.git","ssh_url":"git@github.com:numba/numba.git","clone_url":"https://github.com/numba/numba.git","svn_url":"https://github.com/numba/numba","homepage":"http://numba.pydata.org/","size":27577,"stargazers_count":1708,"watchers_count":1708,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":184,"mirror_url":null,"open_issues_count":191,"forks":184,"open_issues":191,"watchers":1708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numba/numba/pulls/1651"},"html":{"href":"https://github.com/numba/numba/pull/1651"},"issue":{"href":"https://api.github.com/repos/numba/numba/issues/1651"},"comments":{"href":"https://api.github.com/repos/numba/numba/issues/1651/comments"},"review_comments":{"href":"https://api.github.com/repos/numba/numba/pulls/1651/comments"},"review_comment":{"href":"https://api.github.com/repos/numba/numba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numba/numba/pulls/1651/commits"},"statuses":{"href":"https://api.github.com/repos/numba/numba/statuses/02f66e4424fb1342088eb1d42c85596892b45dd8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pitrou","id":1721820,"avatar_url":"https://avatars.githubusercontent.com/u/1721820?v=3","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"comments":28,"review_comments":35,"commits":1,"additions":458,"deletions":17,"changed_files":6}}