{"action":"created","issue":{"url":"https://api.github.com/repos/moio/sumaform/issues/28","repository_url":"https://api.github.com/repos/moio/sumaform","labels_url":"https://api.github.com/repos/moio/sumaform/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/moio/sumaform/issues/28/comments","events_url":"https://api.github.com/repos/moio/sumaform/issues/28/events","html_url":"https://github.com/moio/sumaform/pull/28","id":191353064,"number":28,"title":"Speed-up tests-machines","user":{"login":"MalloZup","id":10886597,"avatar_url":"https://avatars.githubusercontent.com/u/10886597?v=3","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-23T18:48:23Z","updated_at":"2016-11-24T07:45:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moio/sumaform/pulls/28","html_url":"https://github.com/moio/sumaform/pull/28","diff_url":"https://github.com/moio/sumaform/pull/28.diff","patch_url":"https://github.com/moio/sumaform/pull/28.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/moio/sumaform/issues/comments/262710463","html_url":"https://github.com/moio/sumaform/pull/28#issuecomment-262710463","issue_url":"https://api.github.com/repos/moio/sumaform/issues/28","id":262710463,"user":{"login":"moio","id":250541,"avatar_url":"https://avatars.githubusercontent.com/u/250541?v=3","gravatar_id":"","url":"https://api.github.com/users/moio","html_url":"https://github.com/moio","followers_url":"https://api.github.com/users/moio/followers","following_url":"https://api.github.com/users/moio/following{/other_user}","gists_url":"https://api.github.com/users/moio/gists{/gist_id}","starred_url":"https://api.github.com/users/moio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moio/subscriptions","organizations_url":"https://api.github.com/users/moio/orgs","repos_url":"https://api.github.com/users/moio/repos","events_url":"https://api.github.com/users/moio/events{/privacy}","received_events_url":"https://api.github.com/users/moio/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T07:45:04Z","updated_at":"2016-11-24T07:45:04Z","body":"Hey, thank you for this PR!\r\n\r\nI am afraid I do not agree with the current solution though.\r\n\r\nThe reason why that dependency is mandatory is that we typically want to wait for VMs - this is needed for correct functioning in all cases apart from the testsuite, which is important but not the main use case for sumaform.\r\n\r\nWith this patch we \"lose\" the parser error if we forget `server_configuration`, and that's not a good thing.\r\n\r\nInstead, I would propose to specify a custom map for the specific case of the testsuite. This would be optional (the testsuite works with standard configuration anyway, albeit slower) and retain the parser error in case we forget something for non-testsuite use cases.\r\n\r\nI am proposing something like this in `main.tf.libvirt-testsuite.example`:\r\n```hcl\r\nserver_configuration = { hostname =  \"suma3pg.tf.local\" }\r\n```\r\n\r\nDoes this make sense to you?"}}
{"actor":{"display_login":"moio"}}