{"action":"created","comment":{"url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/comments/71376124","id":71376124,"diff_hunk":"@@ -25,48 +31,85 @@\n @Singleton\n public class EventsServlet extends HttpServlet {\n \n-  public static final String LEAVE_MSG = \"Sorry, All agents are busy. Please leave a message. \"\n+  protected static final String LEAVE_MSG = \"Sorry, All agents are busy. Please leave a message. \"","path":"src/main/java/com/twilio/taskrouter/application/servlet/EventsServlet.java","position":28,"original_position":28,"commit_id":"6066d7d9bd5999289b33133f453d7c04f9345fcb","original_commit_id":"6066d7d9bd5999289b33133f453d7c04f9345fcb","user":{"login":"acamino","id":957202,"avatar_url":"https://avatars.githubusercontent.com/u/957202?v=3","gravatar_id":"","url":"https://api.github.com/users/acamino","html_url":"https://github.com/acamino","followers_url":"https://api.github.com/users/acamino/followers","following_url":"https://api.github.com/users/acamino/following{/other_user}","gists_url":"https://api.github.com/users/acamino/gists{/gist_id}","starred_url":"https://api.github.com/users/acamino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acamino/subscriptions","organizations_url":"https://api.github.com/users/acamino/orgs","repos_url":"https://api.github.com/users/acamino/repos","events_url":"https://api.github.com/users/acamino/events{/privacy}","received_events_url":"https://api.github.com/users/acamino/received_events","type":"User","site_admin":false},"body":"Do we intend to use `LEAVE_MSG`, `OFFLINE_MSG` outside the scope of this class through inheritance? If the answer is no, would you mind make them private please?","created_at":"2016-07-19T16:40:49Z","updated_at":"2016-07-19T16:40:49Z","html_url":"https://github.com/TwilioDevEd/task-router-servlets/pull/8#discussion_r71376124","pull_request_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/comments/71376124"},"html":{"href":"https://github.com/TwilioDevEd/task-router-servlets/pull/8#discussion_r71376124"},"pull_request":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8","id":78000376,"html_url":"https://github.com/TwilioDevEd/task-router-servlets/pull/8","diff_url":"https://github.com/TwilioDevEd/task-router-servlets/pull/8.diff","patch_url":"https://github.com/TwilioDevEd/task-router-servlets/pull/8.patch","issue_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/8","number":8,"state":"open","locked":false,"title":"Changes for Revision","user":{"login":"acamino","id":957202,"avatar_url":"https://avatars.githubusercontent.com/u/957202?v=3","gravatar_id":"","url":"https://api.github.com/users/acamino","html_url":"https://github.com/acamino","followers_url":"https://api.github.com/users/acamino/followers","following_url":"https://api.github.com/users/acamino/following{/other_user}","gists_url":"https://api.github.com/users/acamino/gists{/gist_id}","starred_url":"https://api.github.com/users/acamino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acamino/subscriptions","organizations_url":"https://api.github.com/users/acamino/orgs","repos_url":"https://api.github.com/users/acamino/repos","events_url":"https://api.github.com/users/acamino/events{/privacy}","received_events_url":"https://api.github.com/users/acamino/received_events","type":"User","site_admin":false},"body":"**Don't merge**. This pull request exists only for code review purposes.\r\n\r\ncc/ @EliuX ","created_at":"2016-07-19T15:44:10Z","updated_at":"2016-07-19T16:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"819f05c675bb03bad298970a181d0f8ca1d12c47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8/commits","review_comments_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8/comments","review_comment_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/8/comments","statuses_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/statuses/6066d7d9bd5999289b33133f453d7c04f9345fcb","head":{"label":"acamino:code-review","ref":"code-review","sha":"6066d7d9bd5999289b33133f453d7c04f9345fcb","user":{"login":"acamino","id":957202,"avatar_url":"https://avatars.githubusercontent.com/u/957202?v=3","gravatar_id":"","url":"https://api.github.com/users/acamino","html_url":"https://github.com/acamino","followers_url":"https://api.github.com/users/acamino/followers","following_url":"https://api.github.com/users/acamino/following{/other_user}","gists_url":"https://api.github.com/users/acamino/gists{/gist_id}","starred_url":"https://api.github.com/users/acamino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acamino/subscriptions","organizations_url":"https://api.github.com/users/acamino/orgs","repos_url":"https://api.github.com/users/acamino/repos","events_url":"https://api.github.com/users/acamino/events{/privacy}","received_events_url":"https://api.github.com/users/acamino/received_events","type":"User","site_admin":false},"repo":{"id":63706835,"name":"task-router-servlets","full_name":"acamino/task-router-servlets","owner":{"login":"acamino","id":957202,"avatar_url":"https://avatars.githubusercontent.com/u/957202?v=3","gravatar_id":"","url":"https://api.github.com/users/acamino","html_url":"https://github.com/acamino","followers_url":"https://api.github.com/users/acamino/followers","following_url":"https://api.github.com/users/acamino/following{/other_user}","gists_url":"https://api.github.com/users/acamino/gists{/gist_id}","starred_url":"https://api.github.com/users/acamino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acamino/subscriptions","organizations_url":"https://api.github.com/users/acamino/orgs","repos_url":"https://api.github.com/users/acamino/repos","events_url":"https://api.github.com/users/acamino/events{/privacy}","received_events_url":"https://api.github.com/users/acamino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acamino/task-router-servlets","description":"Task Router with Servlets and Twilio","fork":true,"url":"https://api.github.com/repos/acamino/task-router-servlets","forks_url":"https://api.github.com/repos/acamino/task-router-servlets/forks","keys_url":"https://api.github.com/repos/acamino/task-router-servlets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acamino/task-router-servlets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acamino/task-router-servlets/teams","hooks_url":"https://api.github.com/repos/acamino/task-router-servlets/hooks","issue_events_url":"https://api.github.com/repos/acamino/task-router-servlets/issues/events{/number}","events_url":"https://api.github.com/repos/acamino/task-router-servlets/events","assignees_url":"https://api.github.com/repos/acamino/task-router-servlets/assignees{/user}","branches_url":"https://api.github.com/repos/acamino/task-router-servlets/branches{/branch}","tags_url":"https://api.github.com/repos/acamino/task-router-servlets/tags","blobs_url":"https://api.github.com/repos/acamino/task-router-servlets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acamino/task-router-servlets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acamino/task-router-servlets/git/refs{/sha}","trees_url":"https://api.github.com/repos/acamino/task-router-servlets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acamino/task-router-servlets/statuses/{sha}","languages_url":"https://api.github.com/repos/acamino/task-router-servlets/languages","stargazers_url":"https://api.github.com/repos/acamino/task-router-servlets/stargazers","contributors_url":"https://api.github.com/repos/acamino/task-router-servlets/contributors","subscribers_url":"https://api.github.com/repos/acamino/task-router-servlets/subscribers","subscription_url":"https://api.github.com/repos/acamino/task-router-servlets/subscription","commits_url":"https://api.github.com/repos/acamino/task-router-servlets/commits{/sha}","git_commits_url":"https://api.github.com/repos/acamino/task-router-servlets/git/commits{/sha}","comments_url":"https://api.github.com/repos/acamino/task-router-servlets/comments{/number}","issue_comment_url":"https://api.github.com/repos/acamino/task-router-servlets/issues/comments{/number}","contents_url":"https://api.github.com/repos/acamino/task-router-servlets/contents/{+path}","compare_url":"https://api.github.com/repos/acamino/task-router-servlets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acamino/task-router-servlets/merges","archive_url":"https://api.github.com/repos/acamino/task-router-servlets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acamino/task-router-servlets/downloads","issues_url":"https://api.github.com/repos/acamino/task-router-servlets/issues{/number}","pulls_url":"https://api.github.com/repos/acamino/task-router-servlets/pulls{/number}","milestones_url":"https://api.github.com/repos/acamino/task-router-servlets/milestones{/number}","notifications_url":"https://api.github.com/repos/acamino/task-router-servlets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acamino/task-router-servlets/labels{/name}","releases_url":"https://api.github.com/repos/acamino/task-router-servlets/releases{/id}","deployments_url":"https://api.github.com/repos/acamino/task-router-servlets/deployments","created_at":"2016-07-19T15:36:39Z","updated_at":"2016-07-19T15:36:40Z","pushed_at":"2016-07-19T15:41:16Z","git_url":"git://github.com/acamino/task-router-servlets.git","ssh_url":"git@github.com:acamino/task-router-servlets.git","clone_url":"https://github.com/acamino/task-router-servlets.git","svn_url":"https://github.com/acamino/task-router-servlets","homepage":"","size":1433,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TwilioDevEd:master","ref":"master","sha":"d2d5ce3a8e06fc000ece71d8a5d076416db68743","user":{"login":"TwilioDevEd","id":8114879,"avatar_url":"https://avatars.githubusercontent.com/u/8114879?v=3","gravatar_id":"","url":"https://api.github.com/users/TwilioDevEd","html_url":"https://github.com/TwilioDevEd","followers_url":"https://api.github.com/users/TwilioDevEd/followers","following_url":"https://api.github.com/users/TwilioDevEd/following{/other_user}","gists_url":"https://api.github.com/users/TwilioDevEd/gists{/gist_id}","starred_url":"https://api.github.com/users/TwilioDevEd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwilioDevEd/subscriptions","organizations_url":"https://api.github.com/users/TwilioDevEd/orgs","repos_url":"https://api.github.com/users/TwilioDevEd/repos","events_url":"https://api.github.com/users/TwilioDevEd/events{/privacy}","received_events_url":"https://api.github.com/users/TwilioDevEd/received_events","type":"Organization","site_admin":false},"repo":{"id":61329133,"name":"task-router-servlets","full_name":"TwilioDevEd/task-router-servlets","owner":{"login":"TwilioDevEd","id":8114879,"avatar_url":"https://avatars.githubusercontent.com/u/8114879?v=3","gravatar_id":"","url":"https://api.github.com/users/TwilioDevEd","html_url":"https://github.com/TwilioDevEd","followers_url":"https://api.github.com/users/TwilioDevEd/followers","following_url":"https://api.github.com/users/TwilioDevEd/following{/other_user}","gists_url":"https://api.github.com/users/TwilioDevEd/gists{/gist_id}","starred_url":"https://api.github.com/users/TwilioDevEd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwilioDevEd/subscriptions","organizations_url":"https://api.github.com/users/TwilioDevEd/orgs","repos_url":"https://api.github.com/users/TwilioDevEd/repos","events_url":"https://api.github.com/users/TwilioDevEd/events{/privacy}","received_events_url":"https://api.github.com/users/TwilioDevEd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TwilioDevEd/task-router-servlets","description":"Task Router with Servlets and Twilio","fork":false,"url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets","forks_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/forks","keys_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/teams","hooks_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/hooks","issue_events_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/events{/number}","events_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/events","assignees_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/assignees{/user}","branches_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/branches{/branch}","tags_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/tags","blobs_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/git/refs{/sha}","trees_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/statuses/{sha}","languages_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/languages","stargazers_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/stargazers","contributors_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/contributors","subscribers_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/subscribers","subscription_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/subscription","commits_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/commits{/sha}","git_commits_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/git/commits{/sha}","comments_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/comments{/number}","issue_comment_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/comments{/number}","contents_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/contents/{+path}","compare_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/merges","archive_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/downloads","issues_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues{/number}","pulls_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls{/number}","milestones_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/milestones{/number}","notifications_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/labels{/name}","releases_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/releases{/id}","deployments_url":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/deployments","created_at":"2016-06-16T22:13:14Z","updated_at":"2016-07-01T13:53:05Z","pushed_at":"2016-07-19T16:35:22Z","git_url":"git://github.com/TwilioDevEd/task-router-servlets.git","ssh_url":"git@github.com:TwilioDevEd/task-router-servlets.git","clone_url":"https://github.com/TwilioDevEd/task-router-servlets.git","svn_url":"https://github.com/TwilioDevEd/task-router-servlets","homepage":"","size":1431,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8"},"html":{"href":"https://github.com/TwilioDevEd/task-router-servlets/pull/8"},"issue":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/8"},"comments":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/TwilioDevEd/task-router-servlets/statuses/6066d7d9bd5999289b33133f453d7c04f9345fcb"}}}}
{"actor":{"display_login":"acamino"}}