{"action":"created","comment":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/comments/92723464","pull_request_review_id":13244869,"id":92723464,"diff_hunk":"@@ -45,14 +45,14 @@ def download_if_in_repo(svn_loc, input_data_root, rel_path):\n         logging.warning(\"FAIL: SVN repo '%s' does not have file '%s'\\nReason:%s\\n%s\\n\" % (svn_loc, full_url, out, err))\n         return False\n     else:\n+        # Use umask to make sure files are group read/writable. As long as parent directories\n+        # have +s, then everything should work.\n         stat, output, errput = \\\n-            run_cmd(\"svn --non-interactive --trust-server-cert export %s %s\" % (full_url, full_path))\n+            run_cmd(\"umask 002 && svn --non-interactive --trust-server-cert export %s %s\" % (full_url, full_path))","path":"utils/python/CIME/check_input_data.py","position":8,"original_position":8,"commit_id":"4a2a905e3b8902b6fed0ae039fb8430d5cab4f24","original_commit_id":"4a2a905e3b8902b6fed0ae039fb8430d5cab4f24","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"body":"Why is this an improvement?","created_at":"2016-12-15T23:30:14Z","updated_at":"2016-12-15T23:30:19Z","html_url":"https://github.com/ESMCI/cime/pull/931#discussion_r92723464","pull_request_url":"https://api.github.com/repos/ESMCI/cime/pulls/931","_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments/92723464"},"html":{"href":"https://github.com/ESMCI/cime/pull/931#discussion_r92723464"},"pull_request":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/931"}}},"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/931","id":98247306,"html_url":"https://github.com/ESMCI/cime/pull/931","diff_url":"https://github.com/ESMCI/cime/pull/931.diff","patch_url":"https://github.com/ESMCI/cime/pull/931.patch","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/931","number":931,"state":"open","locked":false,"title":"check_input_data: Use umask before svn export","user":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"body":"Will ensure all files and directories that get created will have\r\npermissions that allow for collaboration between users.\r\n\r\nTest suite: code_checker\r\nTest baseline: \r\nTest namelist changes: \r\nTest status: bit for bit\r\n\r\nFixes [CIME Github issue #]\r\n\r\nUser interface changes?: None\r\n\r\nCode review: jedwards\r\n\r\n","created_at":"2016-12-15T22:53:03Z","updated_at":"2016-12-15T23:30:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b0d25065a089f7db3a8ff89b044f4cc53330bfe","assignee":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"assignees":[{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ESMCI/cime/pulls/931/commits","review_comments_url":"https://api.github.com/repos/ESMCI/cime/pulls/931/comments","review_comment_url":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/931/comments","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/4a2a905e3b8902b6fed0ae039fb8430d5cab4f24","head":{"label":"ESMCI:jgfouca/use_umask_for_check_input","ref":"jgfouca/use_umask_for_check_input","sha":"4a2a905e3b8902b6fed0ae039fb8430d5cab4f24","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2016-10-23T17:33:46Z","pushed_at":"2016-12-15T22:53:03Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":21144,"stargazers_count":5,"watchers_count":5,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":139,"forks":33,"open_issues":139,"watchers":5,"default_branch":"master"}},"base":{"label":"ESMCI:master","ref":"master","sha":"731c093ed0678f8ce01a1191fca476606c9be495","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2016-10-23T17:33:46Z","pushed_at":"2016-12-15T22:53:03Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":21144,"stargazers_count":5,"watchers_count":5,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":139,"forks":33,"open_issues":139,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/931"},"html":{"href":"https://github.com/ESMCI/cime/pull/931"},"issue":{"href":"https://api.github.com/repos/ESMCI/cime/issues/931"},"comments":{"href":"https://api.github.com/repos/ESMCI/cime/issues/931/comments"},"review_comments":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/931/comments"},"review_comment":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/931/commits"},"statuses":{"href":"https://api.github.com/repos/ESMCI/cime/statuses/4a2a905e3b8902b6fed0ae039fb8430d5cab4f24"}}}}
{"actor":{"display_login":"jedwards4b"}}