{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/88475818","pull_request_review_id":9048034,"id":88475818,"diff_hunk":"@@ -0,0 +1,42 @@\n+'use strict';\n+var common = require('../common');\n+var assert = require('assert');\n+\n+var spawn = require('child_process').spawn;\n+\n+var exitCode;\n+var termSignal;\n+var gotStdoutEOF = false;\n+var gotStderrEOF = false;\n+\n+var cat = spawn(common.isWindows ? 'cmd' : 'cat');\n+\n+\n+cat.stdout.on('end', function() {\n+  gotStdoutEOF = true;\n+});\n+\n+cat.stderr.on('data', function(chunk) {\n+  assert.ok(false);","path":"test/parallel/test-child-process-kill-numeric.js","position":20,"original_position":20,"commit_id":"410c5897338d23da241bdb1bd6e4387846967e7d","original_commit_id":"410c5897338d23da241bdb1bd6e4387846967e7d","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"Please use `common.fail()` here.","created_at":"2016-11-17T15:31:37Z","updated_at":"2016-11-17T15:31:37Z","html_url":"https://github.com/nodejs/node/pull/9651#discussion_r88475818","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9651","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/88475818"},"html":{"href":"https://github.com/nodejs/node/pull/9651#discussion_r88475818"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9651"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9651","id":94085362,"html_url":"https://github.com/nodejs/node/pull/9651","diff_url":"https://github.com/nodejs/node/pull/9651.diff","patch_url":"https://github.com/nodejs/node/pull/9651.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9651","number":9651,"state":"open","locked":false,"title":"child_process: support numeric signal argument to kill.","user":{"login":"gerrard00","id":5355921,"avatar_url":"https://avatars.githubusercontent.com/u/5355921?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrard00","html_url":"https://github.com/gerrard00","followers_url":"https://api.github.com/users/gerrard00/followers","following_url":"https://api.github.com/users/gerrard00/following{/other_user}","gists_url":"https://api.github.com/users/gerrard00/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrard00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrard00/subscriptions","organizations_url":"https://api.github.com/users/gerrard00/orgs","repos_url":"https://api.github.com/users/gerrard00/repos","events_url":"https://api.github.com/users/gerrard00/events{/privacy}","received_events_url":"https://api.github.com/users/gerrard00/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nchild_process\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nModifies the kill function to support numeric signals. I used a type check instead of `Number.isInteger` because that was the pattern used elsewhere in the code base.\r\n\r\nAddresses: https://github.com/nodejs/node/issues/9519\r\n","created_at":"2016-11-17T01:24:28Z","updated_at":"2016-11-17T15:33:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcde0070edd6c0af84abb01d815d4da929de319b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9651/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9651/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9651/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/410c5897338d23da241bdb1bd6e4387846967e7d","head":{"label":"gerrard00:support_numeric_kill","ref":"support_numeric_kill","sha":"410c5897338d23da241bdb1bd6e4387846967e7d","user":{"login":"gerrard00","id":5355921,"avatar_url":"https://avatars.githubusercontent.com/u/5355921?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrard00","html_url":"https://github.com/gerrard00","followers_url":"https://api.github.com/users/gerrard00/followers","following_url":"https://api.github.com/users/gerrard00/following{/other_user}","gists_url":"https://api.github.com/users/gerrard00/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrard00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrard00/subscriptions","organizations_url":"https://api.github.com/users/gerrard00/orgs","repos_url":"https://api.github.com/users/gerrard00/repos","events_url":"https://api.github.com/users/gerrard00/events{/privacy}","received_events_url":"https://api.github.com/users/gerrard00/received_events","type":"User","site_admin":false},"repo":{"id":73975064,"name":"node","full_name":"gerrard00/node","owner":{"login":"gerrard00","id":5355921,"avatar_url":"https://avatars.githubusercontent.com/u/5355921?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrard00","html_url":"https://github.com/gerrard00","followers_url":"https://api.github.com/users/gerrard00/followers","following_url":"https://api.github.com/users/gerrard00/following{/other_user}","gists_url":"https://api.github.com/users/gerrard00/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrard00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrard00/subscriptions","organizations_url":"https://api.github.com/users/gerrard00/orgs","repos_url":"https://api.github.com/users/gerrard00/repos","events_url":"https://api.github.com/users/gerrard00/events{/privacy}","received_events_url":"https://api.github.com/users/gerrard00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerrard00/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/gerrard00/node","forks_url":"https://api.github.com/repos/gerrard00/node/forks","keys_url":"https://api.github.com/repos/gerrard00/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerrard00/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerrard00/node/teams","hooks_url":"https://api.github.com/repos/gerrard00/node/hooks","issue_events_url":"https://api.github.com/repos/gerrard00/node/issues/events{/number}","events_url":"https://api.github.com/repos/gerrard00/node/events","assignees_url":"https://api.github.com/repos/gerrard00/node/assignees{/user}","branches_url":"https://api.github.com/repos/gerrard00/node/branches{/branch}","tags_url":"https://api.github.com/repos/gerrard00/node/tags","blobs_url":"https://api.github.com/repos/gerrard00/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerrard00/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerrard00/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerrard00/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerrard00/node/statuses/{sha}","languages_url":"https://api.github.com/repos/gerrard00/node/languages","stargazers_url":"https://api.github.com/repos/gerrard00/node/stargazers","contributors_url":"https://api.github.com/repos/gerrard00/node/contributors","subscribers_url":"https://api.github.com/repos/gerrard00/node/subscribers","subscription_url":"https://api.github.com/repos/gerrard00/node/subscription","commits_url":"https://api.github.com/repos/gerrard00/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerrard00/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerrard00/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerrard00/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerrard00/node/contents/{+path}","compare_url":"https://api.github.com/repos/gerrard00/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerrard00/node/merges","archive_url":"https://api.github.com/repos/gerrard00/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerrard00/node/downloads","issues_url":"https://api.github.com/repos/gerrard00/node/issues{/number}","pulls_url":"https://api.github.com/repos/gerrard00/node/pulls{/number}","milestones_url":"https://api.github.com/repos/gerrard00/node/milestones{/number}","notifications_url":"https://api.github.com/repos/gerrard00/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerrard00/node/labels{/name}","releases_url":"https://api.github.com/repos/gerrard00/node/releases{/id}","deployments_url":"https://api.github.com/repos/gerrard00/node/deployments","created_at":"2016-11-17T00:47:48Z","updated_at":"2016-11-17T00:48:12Z","pushed_at":"2016-11-17T01:55:40Z","git_url":"git://github.com/gerrard00/node.git","ssh_url":"git@github.com:gerrard00/node.git","clone_url":"https://github.com/gerrard00/node.git","svn_url":"https://github.com/gerrard00/node","homepage":"https://nodejs.org","size":244672,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5dea1e2a5d054ab2ca97bedb88d06b664f67bd09","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-17T14:56:46Z","pushed_at":"2016-11-17T15:20:11Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":364272,"stargazers_count":28956,"watchers_count":28956,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4961,"mirror_url":null,"open_issues_count":930,"forks":4961,"open_issues":930,"watchers":28956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9651"},"html":{"href":"https://github.com/nodejs/node/pull/9651"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9651"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9651/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9651/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9651/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/410c5897338d23da241bdb1bd6e4387846967e7d"}}}}
{"actor":{"display_login":"cjihrig"}}