{"action":"created","issue":{"url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/457","repository_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij","labels_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/457/comments","events_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/457/events","html_url":"https://github.com/ceylon/ceylon-ide-intellij/issues/457","id":175102746,"number":457,"title":"rename refactoring misses some uses","user":{"login":"jvasileff","id":236050,"avatar_url":"https://avatars.githubusercontent.com/u/236050?v=3","gravatar_id":"","url":"https://api.github.com/users/jvasileff","html_url":"https://github.com/jvasileff","followers_url":"https://api.github.com/users/jvasileff/followers","following_url":"https://api.github.com/users/jvasileff/following{/other_user}","gists_url":"https://api.github.com/users/jvasileff/gists{/gist_id}","starred_url":"https://api.github.com/users/jvasileff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvasileff/subscriptions","organizations_url":"https://api.github.com/users/jvasileff/orgs","repos_url":"https://api.github.com/users/jvasileff/repos","events_url":"https://api.github.com/users/jvasileff/events{/privacy}","received_events_url":"https://api.github.com/users/jvasileff/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/labels/c-refactorings","name":"c-refactorings","color":"5319e7"},{"url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/labels/t-bug","name":"t-bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"bjansen","id":281528,"avatar_url":"https://avatars.githubusercontent.com/u/281528?v=3","gravatar_id":"","url":"https://api.github.com/users/bjansen","html_url":"https://github.com/bjansen","followers_url":"https://api.github.com/users/bjansen/followers","following_url":"https://api.github.com/users/bjansen/following{/other_user}","gists_url":"https://api.github.com/users/bjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/bjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjansen/subscriptions","organizations_url":"https://api.github.com/users/bjansen/orgs","repos_url":"https://api.github.com/users/bjansen/repos","events_url":"https://api.github.com/users/bjansen/events{/privacy}","received_events_url":"https://api.github.com/users/bjansen/received_events","type":"User","site_admin":false},"assignees":[{"login":"bjansen","id":281528,"avatar_url":"https://avatars.githubusercontent.com/u/281528?v=3","gravatar_id":"","url":"https://api.github.com/users/bjansen","html_url":"https://github.com/bjansen","followers_url":"https://api.github.com/users/bjansen/followers","following_url":"https://api.github.com/users/bjansen/following{/other_user}","gists_url":"https://api.github.com/users/bjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/bjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjansen/subscriptions","organizations_url":"https://api.github.com/users/bjansen/orgs","repos_url":"https://api.github.com/users/bjansen/repos","events_url":"https://api.github.com/users/bjansen/events{/privacy}","received_events_url":"https://api.github.com/users/bjansen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/milestones/1","html_url":"https://github.com/ceylon/ceylon-ide-intellij/milestones/1.3.0","labels_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/milestones/1/labels","id":481614,"number":1,"title":"1.3.0","description":"The plugin should allow developing on a real project, but will not necessarily contain fancy features (yet):\r\n\r\n- basic editing:\r\n  - open/create a project containing ceylon files, recognized as such\r\n  - ability to edit files without errors/exceptions\r\n  - report errors in source files\r\n- syntax highlighting\r\n- show structure view (#70)\r\n- show documentation popup (#29)\r\n- compile file/project\r\n- run program (JVM and JS)\r\n- basic autocompletion (#26)\r\n- assign to local variable (#71)\r\n- navigate > class (#72)\r\n- go to declaration (#13)\r\n- find references (partly #13)\r\n- rename refactoring (partly #13)","creator":{"login":"bjansen","id":281528,"avatar_url":"https://avatars.githubusercontent.com/u/281528?v=3","gravatar_id":"","url":"https://api.github.com/users/bjansen","html_url":"https://github.com/bjansen","followers_url":"https://api.github.com/users/bjansen/followers","following_url":"https://api.github.com/users/bjansen/following{/other_user}","gists_url":"https://api.github.com/users/bjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/bjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjansen/subscriptions","organizations_url":"https://api.github.com/users/bjansen/orgs","repos_url":"https://api.github.com/users/bjansen/repos","events_url":"https://api.github.com/users/bjansen/events{/privacy}","received_events_url":"https://api.github.com/users/bjansen/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":394,"state":"open","created_at":"2013-11-11T19:57:33Z","updated_at":"2016-09-06T10:06:20Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-09-05T16:31:39Z","updated_at":"2016-09-06T13:13:37Z","closed_at":null,"body":"After attempting to rename the parameter `x` to `y` below, only the `x` in `is Anything x` is renamed.\r\n\r\nOriginal:\r\n```ceylon\r\nvoid testit(String x) {\r\n    value a = if (is Anything x) then x else x;\r\n    value b = if (x.empty) then x else x;\r\n\r\n    Anything c;\r\n    if (x.empty) {\r\n        c = x;\r\n    }\r\n}\r\n```\r\nafter:\r\n```ceylon\r\nvoid testit(String y) {\r\n    value a = if (is Anything y ) then x else x;\r\n    value b = if (x.empty) then x else x;\r\n\r\n    Anything c;\r\n    if (x.empty) {\r\n        c = x;\r\n    }\r\n}\r\n```\r\n\r\nEdit: also notice the extra space in `(is Anything y )`"},"comment":{"url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/comments/244945586","html_url":"https://github.com/ceylon/ceylon-ide-intellij/issues/457#issuecomment-244945586","issue_url":"https://api.github.com/repos/ceylon/ceylon-ide-intellij/issues/457","id":244945586,"user":{"login":"bjansen","id":281528,"avatar_url":"https://avatars.githubusercontent.com/u/281528?v=3","gravatar_id":"","url":"https://api.github.com/users/bjansen","html_url":"https://github.com/bjansen","followers_url":"https://api.github.com/users/bjansen/followers","following_url":"https://api.github.com/users/bjansen/following{/other_user}","gists_url":"https://api.github.com/users/bjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/bjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjansen/subscriptions","organizations_url":"https://api.github.com/users/bjansen/orgs","repos_url":"https://api.github.com/users/bjansen/repos","events_url":"https://api.github.com/users/bjansen/events{/privacy}","received_events_url":"https://api.github.com/users/bjansen/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T13:13:37Z","updated_at":"2016-09-06T13:13:37Z","body":"Can't reproduce here, no matter what occurrence of `x` I try to rename, the result is correct:\r\n\r\n```ceylon\r\nvoid testit(String foo) {\r\n    value a = if (is Anything foo ) then foo else foo;\r\n    value b = if (foo.empty) then foo else foo;\r\n\r\n    Anything c;\r\n    if (foo.empty) {\r\n        c = foo;\r\n    }\r\n}\r\n```\r\n\r\nIn your case, are all the usages correctly highlighted?"}}
{"actor":{"display_login":"bjansen"}}