{"action":"created","comment":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/72658949","id":72658949,"diff_hunk":"@@ -38,8 +38,10 @@ describe('configurations', function() {\n       assert.equal(configName.indexOf('react/'), 0);\n       assert.equal(plugin.configs.all.rules[configName], 2);\n     });\n-    rules.forEach(function(ruleName) {\n-      assert(plugin.configs.all.rules['react/' + ruleName]);\n+    ruleFiles.forEach(function(ruleName) {\n+      var inDeprecatedRules = Boolean(plugin.deprecatedRules[ruleName]);","path":"tests/index.js","position":23,"original_position":23,"commit_id":"312b24d223a30a3d3a45bea9b1115b61406568c4","original_commit_id":"312b24d223a30a3d3a45bea9b1115b61406568c4","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Sounds good, keep it as `Boolean` for now then. We can change it to `!!` separately, if desired.","created_at":"2016-07-28T16:51:14Z","updated_at":"2016-07-28T16:51:14Z","html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/723#discussion_r72658949","pull_request_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723","_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/72658949"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/723#discussion_r72658949"},"pull_request":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723","id":79115581,"html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/723","diff_url":"https://github.com/yannickcr/eslint-plugin-react/pull/723.diff","patch_url":"https://github.com/yannickcr/eslint-plugin-react/pull/723.patch","issue_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/723","number":723,"state":"open","locked":false,"title":"Don't include deprecated rules in `all` config","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"body":"Since they are replaced by better versions","created_at":"2016-07-27T23:34:20Z","updated_at":"2016-07-28T16:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0660f2a33c0ccc78382da9fd90bbcf09db7bf0e2","assignee":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"assignees":[{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723/commits","review_comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723/comments","review_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/723/comments","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/312b24d223a30a3d3a45bea9b1115b61406568c4","head":{"label":"pfhayes:deprecated","ref":"deprecated","sha":"312b24d223a30a3d3a45bea9b1115b61406568c4","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"repo":{"id":63378927,"name":"eslint-plugin-react","full_name":"pfhayes/eslint-plugin-react","owner":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfhayes/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":true,"url":"https://api.github.com/repos/pfhayes/eslint-plugin-react","forks_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/deployments","created_at":"2016-07-15T00:32:37Z","updated_at":"2016-07-15T00:32:38Z","pushed_at":"2016-07-28T01:18:19Z","git_url":"git://github.com/pfhayes/eslint-plugin-react.git","ssh_url":"git@github.com:pfhayes/eslint-plugin-react.git","clone_url":"https://github.com/pfhayes/eslint-plugin-react.git","svn_url":"https://github.com/pfhayes/eslint-plugin-react","homepage":null,"size":1096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yannickcr:master","ref":"master","sha":"10c6f23866b58dff5a7f8d16eb8b8a62cc997a66","user":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"repo":{"id":28061676,"name":"eslint-plugin-react","full_name":"yannickcr/eslint-plugin-react","owner":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannickcr/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":false,"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react","forks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/deployments","created_at":"2014-12-15T23:44:14Z","updated_at":"2016-07-28T07:07:21Z","pushed_at":"2016-07-28T07:37:54Z","git_url":"git://github.com/yannickcr/eslint-plugin-react.git","ssh_url":"git@github.com:yannickcr/eslint-plugin-react.git","clone_url":"https://github.com/yannickcr/eslint-plugin-react.git","svn_url":"https://github.com/yannickcr/eslint-plugin-react","homepage":null,"size":1304,"stargazers_count":1538,"watchers_count":1538,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":135,"forks":259,"open_issues":135,"watchers":1538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/723"},"issue":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/723"},"comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/312b24d223a30a3d3a45bea9b1115b61406568c4"}}}}
{"actor":{"display_login":"ljharb"}}