{"action":"closed","number":3800,"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800","id":80318614,"html_url":"https://github.com/Alluxio/alluxio/pull/3800","diff_url":"https://github.com/Alluxio/alluxio/pull/3800.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/3800.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3800","number":3800,"state":"closed","locked":false,"title":"[SMALLFIX] Worker address cleanup","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"The worker launches three servers on different ports: RPC, Web, and Data. When ports are specified (non-zero) it's easy to tell which port everything will run on. When the ports are set to 0, it's a little more complicated. \r\n\r\nThe thrift RPC and Netty Data servers would determine their port on construction, so we could figure out what our RPC and Data ports would be in the AlluxioWorker constructor. The web server, however, wouldn't decide on a port until it was started. This forced us to awkwardly store the web port into WorkerContext from the web server so that it could later be read by the block worker.\r\n\r\nThis change fixes this by finding an available port during the AlluxioWorker and AlluxioMaster constructors so that the web server never needs to search for a port and we know at the end of the constructors what all of our ports will be.\r\n\r\nI've tested by running Alluxio workers locally with both default ports and with ports set to 0.\r\n\r\nThe API tests needed to be changed due to a classloading issue with using Powermock + Jetty. ","created_at":"2016-08-05T23:04:16Z","updated_at":"2016-08-15T17:59:22Z","closed_at":"2016-08-15T17:59:22Z","merged_at":"2016-08-15T17:59:22Z","merge_commit_sha":"da79b1a9c1f1877b4b523b0b11a8b3e68c68622b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3800/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/b2f82b0205b05e0486bc45463f738ab4e978892b","head":{"label":"aaudiber:worker-address-cleanup","ref":"worker-address-cleanup","sha":"b2f82b0205b05e0486bc45463f738ab4e978892b","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"repo":{"id":52421920,"name":"alluxio","full_name":"aaudiber/alluxio","owner":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaudiber/alluxio","description":"Memory-Centric Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/aaudiber/alluxio","forks_url":"https://api.github.com/repos/aaudiber/alluxio/forks","keys_url":"https://api.github.com/repos/aaudiber/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaudiber/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaudiber/alluxio/teams","hooks_url":"https://api.github.com/repos/aaudiber/alluxio/hooks","issue_events_url":"https://api.github.com/repos/aaudiber/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/aaudiber/alluxio/events","assignees_url":"https://api.github.com/repos/aaudiber/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/aaudiber/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/aaudiber/alluxio/tags","blobs_url":"https://api.github.com/repos/aaudiber/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaudiber/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaudiber/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaudiber/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaudiber/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/aaudiber/alluxio/languages","stargazers_url":"https://api.github.com/repos/aaudiber/alluxio/stargazers","contributors_url":"https://api.github.com/repos/aaudiber/alluxio/contributors","subscribers_url":"https://api.github.com/repos/aaudiber/alluxio/subscribers","subscription_url":"https://api.github.com/repos/aaudiber/alluxio/subscription","commits_url":"https://api.github.com/repos/aaudiber/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaudiber/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaudiber/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaudiber/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaudiber/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/aaudiber/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaudiber/alluxio/merges","archive_url":"https://api.github.com/repos/aaudiber/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaudiber/alluxio/downloads","issues_url":"https://api.github.com/repos/aaudiber/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/aaudiber/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/aaudiber/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/aaudiber/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaudiber/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/aaudiber/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/aaudiber/alluxio/deployments","created_at":"2016-02-24T07:07:15Z","updated_at":"2016-02-24T07:07:19Z","pushed_at":"2016-08-12T19:34:55Z","git_url":"git://github.com/aaudiber/alluxio.git","ssh_url":"git@github.com:aaudiber/alluxio.git","clone_url":"https://github.com/aaudiber/alluxio.git","svn_url":"https://github.com/aaudiber/alluxio","homepage":"http://www.alluxio.org/","size":57381,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"840b8a13111945f22379b6690c7c13b6530cfa0d","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-08-15T06:46:38Z","pushed_at":"2016-08-15T17:59:22Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":90292,"stargazers_count":2547,"watchers_count":2547,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1050,"mirror_url":null,"open_issues_count":22,"forks":1050,"open_issues":22,"watchers":2547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3800"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3800"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3800/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3800/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/b2f82b0205b05e0486bc45463f738ab4e978892b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"comments":17,"review_comments":2,"commits":18,"additions":421,"deletions":710,"changed_files":18}}
{"actor":{"display_login":"apc999"}}