{"action":"created","comment":{"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments/68742802","id":68742802,"diff_hunk":"@@ -108,7 +108,13 @@ module Create() = struct\n         Some (Sys.getenv name)\n       with Not_found -> None\n \n-    let get_param ~(converter:'a converter) ~default ~name =\n+    let get_conv : 'a converter -> 'a Arg.converter =","path":"lib/bap/bap_self.ml","position":14,"original_position":14,"commit_id":"3290a43f2e3af50cf9b16b4fc5486e5dde978080","original_commit_id":"3290a43f2e3af50cf9b16b4fc5486e5dde978080","user":{"login":"ivg","id":2336698,"avatar_url":"https://avatars.githubusercontent.com/u/2336698?v=3","gravatar_id":"","url":"https://api.github.com/users/ivg","html_url":"https://github.com/ivg","followers_url":"https://api.github.com/users/ivg/followers","following_url":"https://api.github.com/users/ivg/following{/other_user}","gists_url":"https://api.github.com/users/ivg/gists{/gist_id}","starred_url":"https://api.github.com/users/ivg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivg/subscriptions","organizations_url":"https://api.github.com/users/ivg/orgs","repos_url":"https://api.github.com/users/ivg/repos","events_url":"https://api.github.com/users/ivg/events{/privacy}","received_events_url":"https://api.github.com/users/ivg/received_events","type":"User","site_admin":false},"body":"We have a convention that if a function has a verb in its name, then it has some side effect, e.g., `fetch_data` vs. `data`. So, for functions that just projects a field `x` we use a noun `x`. This is to emphasize a declarative nature of the specification, and that an operation actually doesn't have any const. ","created_at":"2016-06-28T11:58:49Z","updated_at":"2016-06-28T11:58:49Z","html_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/494#discussion_r68742802","pull_request_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments/68742802"},"html":{"href":"https://github.com/BinaryAnalysisPlatform/bap/pull/494#discussion_r68742802"},"pull_request":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494","id":75396004,"html_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/494","diff_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/494.diff","patch_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/494.patch","issue_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/494","number":494,"state":"open","locked":false,"title":"Config defaults","user":{"login":"jaybosamiya","id":5683582,"avatar_url":"https://avatars.githubusercontent.com/u/5683582?v=3","gravatar_id":"","url":"https://api.github.com/users/jaybosamiya","html_url":"https://github.com/jaybosamiya","followers_url":"https://api.github.com/users/jaybosamiya/followers","following_url":"https://api.github.com/users/jaybosamiya/following{/other_user}","gists_url":"https://api.github.com/users/jaybosamiya/gists{/gist_id}","starred_url":"https://api.github.com/users/jaybosamiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaybosamiya/subscriptions","organizations_url":"https://api.github.com/users/jaybosamiya/orgs","repos_url":"https://api.github.com/users/jaybosamiya/repos","events_url":"https://api.github.com/users/jaybosamiya/events{/privacy}","received_events_url":"https://api.github.com/users/jaybosamiya/received_events","type":"User","site_admin":false},"body":"Make the defaults a bit more easier to use. Now, defaults are optional for most converters (which actually hold the defaults now).\r\n\r\nFor example, one can just say `Config.(param string \"x\")` instead of the older `Config.(param string \"x\" ~default:\"\")`\r\n\r\nFixed up issues that might have come up in #493 ","created_at":"2016-06-27T23:23:04Z","updated_at":"2016-06-28T11:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42c0a94336063b47f323e973c3e9df3efccae5d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494/commits","review_comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494/comments","review_comment_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/494/comments","statuses_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/3290a43f2e3af50cf9b16b4fc5486e5dde978080","head":{"label":"jaybosamiya:config-default","ref":"config-default","sha":"3290a43f2e3af50cf9b16b4fc5486e5dde978080","user":{"login":"jaybosamiya","id":5683582,"avatar_url":"https://avatars.githubusercontent.com/u/5683582?v=3","gravatar_id":"","url":"https://api.github.com/users/jaybosamiya","html_url":"https://github.com/jaybosamiya","followers_url":"https://api.github.com/users/jaybosamiya/followers","following_url":"https://api.github.com/users/jaybosamiya/following{/other_user}","gists_url":"https://api.github.com/users/jaybosamiya/gists{/gist_id}","starred_url":"https://api.github.com/users/jaybosamiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaybosamiya/subscriptions","organizations_url":"https://api.github.com/users/jaybosamiya/orgs","repos_url":"https://api.github.com/users/jaybosamiya/repos","events_url":"https://api.github.com/users/jaybosamiya/events{/privacy}","received_events_url":"https://api.github.com/users/jaybosamiya/received_events","type":"User","site_admin":false},"repo":{"id":59225447,"name":"bap","full_name":"jaybosamiya/bap","owner":{"login":"jaybosamiya","id":5683582,"avatar_url":"https://avatars.githubusercontent.com/u/5683582?v=3","gravatar_id":"","url":"https://api.github.com/users/jaybosamiya","html_url":"https://github.com/jaybosamiya","followers_url":"https://api.github.com/users/jaybosamiya/followers","following_url":"https://api.github.com/users/jaybosamiya/following{/other_user}","gists_url":"https://api.github.com/users/jaybosamiya/gists{/gist_id}","starred_url":"https://api.github.com/users/jaybosamiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaybosamiya/subscriptions","organizations_url":"https://api.github.com/users/jaybosamiya/orgs","repos_url":"https://api.github.com/users/jaybosamiya/repos","events_url":"https://api.github.com/users/jaybosamiya/events{/privacy}","received_events_url":"https://api.github.com/users/jaybosamiya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaybosamiya/bap","description":"BAP Core Library","fork":true,"url":"https://api.github.com/repos/jaybosamiya/bap","forks_url":"https://api.github.com/repos/jaybosamiya/bap/forks","keys_url":"https://api.github.com/repos/jaybosamiya/bap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaybosamiya/bap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaybosamiya/bap/teams","hooks_url":"https://api.github.com/repos/jaybosamiya/bap/hooks","issue_events_url":"https://api.github.com/repos/jaybosamiya/bap/issues/events{/number}","events_url":"https://api.github.com/repos/jaybosamiya/bap/events","assignees_url":"https://api.github.com/repos/jaybosamiya/bap/assignees{/user}","branches_url":"https://api.github.com/repos/jaybosamiya/bap/branches{/branch}","tags_url":"https://api.github.com/repos/jaybosamiya/bap/tags","blobs_url":"https://api.github.com/repos/jaybosamiya/bap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaybosamiya/bap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaybosamiya/bap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaybosamiya/bap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaybosamiya/bap/statuses/{sha}","languages_url":"https://api.github.com/repos/jaybosamiya/bap/languages","stargazers_url":"https://api.github.com/repos/jaybosamiya/bap/stargazers","contributors_url":"https://api.github.com/repos/jaybosamiya/bap/contributors","subscribers_url":"https://api.github.com/repos/jaybosamiya/bap/subscribers","subscription_url":"https://api.github.com/repos/jaybosamiya/bap/subscription","commits_url":"https://api.github.com/repos/jaybosamiya/bap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaybosamiya/bap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaybosamiya/bap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaybosamiya/bap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaybosamiya/bap/contents/{+path}","compare_url":"https://api.github.com/repos/jaybosamiya/bap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaybosamiya/bap/merges","archive_url":"https://api.github.com/repos/jaybosamiya/bap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaybosamiya/bap/downloads","issues_url":"https://api.github.com/repos/jaybosamiya/bap/issues{/number}","pulls_url":"https://api.github.com/repos/jaybosamiya/bap/pulls{/number}","milestones_url":"https://api.github.com/repos/jaybosamiya/bap/milestones{/number}","notifications_url":"https://api.github.com/repos/jaybosamiya/bap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaybosamiya/bap/labels{/name}","releases_url":"https://api.github.com/repos/jaybosamiya/bap/releases{/id}","deployments_url":"https://api.github.com/repos/jaybosamiya/bap/deployments","created_at":"2016-05-19T16:52:50Z","updated_at":"2016-05-26T10:00:12Z","pushed_at":"2016-06-27T23:13:43Z","git_url":"git://github.com/jaybosamiya/bap.git","ssh_url":"git@github.com:jaybosamiya/bap.git","clone_url":"https://github.com/jaybosamiya/bap.git","svn_url":"https://github.com/jaybosamiya/bap","homepage":null,"size":3007,"stargazers_count":2,"watchers_count":2,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"BinaryAnalysisPlatform:master","ref":"master","sha":"9af145de4759f1044a79f50d6bae2ae4d5d4c8a5","user":{"login":"BinaryAnalysisPlatform","id":8669375,"avatar_url":"https://avatars.githubusercontent.com/u/8669375?v=3","gravatar_id":"","url":"https://api.github.com/users/BinaryAnalysisPlatform","html_url":"https://github.com/BinaryAnalysisPlatform","followers_url":"https://api.github.com/users/BinaryAnalysisPlatform/followers","following_url":"https://api.github.com/users/BinaryAnalysisPlatform/following{/other_user}","gists_url":"https://api.github.com/users/BinaryAnalysisPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/BinaryAnalysisPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BinaryAnalysisPlatform/subscriptions","organizations_url":"https://api.github.com/users/BinaryAnalysisPlatform/orgs","repos_url":"https://api.github.com/users/BinaryAnalysisPlatform/repos","events_url":"https://api.github.com/users/BinaryAnalysisPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/BinaryAnalysisPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":25968851,"name":"bap","full_name":"BinaryAnalysisPlatform/bap","owner":{"login":"BinaryAnalysisPlatform","id":8669375,"avatar_url":"https://avatars.githubusercontent.com/u/8669375?v=3","gravatar_id":"","url":"https://api.github.com/users/BinaryAnalysisPlatform","html_url":"https://github.com/BinaryAnalysisPlatform","followers_url":"https://api.github.com/users/BinaryAnalysisPlatform/followers","following_url":"https://api.github.com/users/BinaryAnalysisPlatform/following{/other_user}","gists_url":"https://api.github.com/users/BinaryAnalysisPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/BinaryAnalysisPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BinaryAnalysisPlatform/subscriptions","organizations_url":"https://api.github.com/users/BinaryAnalysisPlatform/orgs","repos_url":"https://api.github.com/users/BinaryAnalysisPlatform/repos","events_url":"https://api.github.com/users/BinaryAnalysisPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/BinaryAnalysisPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BinaryAnalysisPlatform/bap","description":"BAP Core Library","fork":false,"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap","forks_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/forks","keys_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/teams","hooks_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/hooks","issue_events_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/events{/number}","events_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/events","assignees_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/assignees{/user}","branches_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/branches{/branch}","tags_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/tags","blobs_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/refs{/sha}","trees_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/{sha}","languages_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/languages","stargazers_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/stargazers","contributors_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/contributors","subscribers_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/subscribers","subscription_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/subscription","commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/commits{/sha}","git_commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/commits{/sha}","comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/comments{/number}","issue_comment_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/comments{/number}","contents_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/contents/{+path}","compare_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/merges","archive_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/downloads","issues_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues{/number}","pulls_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls{/number}","milestones_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/milestones{/number}","notifications_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/labels{/name}","releases_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/releases{/id}","deployments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/deployments","created_at":"2014-10-30T11:59:43Z","updated_at":"2016-06-15T08:37:27Z","pushed_at":"2016-06-27T23:23:04Z","git_url":"git://github.com/BinaryAnalysisPlatform/bap.git","ssh_url":"git@github.com:BinaryAnalysisPlatform/bap.git","clone_url":"https://github.com/BinaryAnalysisPlatform/bap.git","svn_url":"https://github.com/BinaryAnalysisPlatform/bap","homepage":null,"size":4687,"stargazers_count":229,"watchers_count":229,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":23,"forks":58,"open_issues":23,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494"},"html":{"href":"https://github.com/BinaryAnalysisPlatform/bap/pull/494"},"issue":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/494"},"comments":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/3290a43f2e3af50cf9b16b4fc5486e5dde978080"}}}}
{"actor":{"display_login":"ivg"}}