{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/173","repository_url":"https://api.github.com/repos/Microsoft/sqltoolsservice","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/173/comments","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/173/events","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/173","id":194492148,"number":173,"title":"Adding Milliseconds to DateTime fields","user":{"login":"benrr101","id":585878,"avatar_url":"https://avatars.githubusercontent.com/u/585878?v=3","gravatar_id":"","url":"https://api.github.com/users/benrr101","html_url":"https://github.com/benrr101","followers_url":"https://api.github.com/users/benrr101/followers","following_url":"https://api.github.com/users/benrr101/following{/other_user}","gists_url":"https://api.github.com/users/benrr101/gists{/gist_id}","starred_url":"https://api.github.com/users/benrr101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrr101/subscriptions","organizations_url":"https://api.github.com/users/benrr101/orgs","repos_url":"https://api.github.com/users/benrr101/repos","events_url":"https://api.github.com/users/benrr101/events{/privacy}","received_events_url":"https://api.github.com/users/benrr101/received_events","type":"User","site_admin":false},"labels":[{"id":481657897,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"kburtram","id":599935,"avatar_url":"https://avatars.githubusercontent.com/u/599935?v=3","gravatar_id":"","url":"https://api.github.com/users/kburtram","html_url":"https://github.com/kburtram","followers_url":"https://api.github.com/users/kburtram/followers","following_url":"https://api.github.com/users/kburtram/following{/other_user}","gists_url":"https://api.github.com/users/kburtram/gists{/gist_id}","starred_url":"https://api.github.com/users/kburtram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kburtram/subscriptions","organizations_url":"https://api.github.com/users/kburtram/orgs","repos_url":"https://api.github.com/users/kburtram/repos","events_url":"https://api.github.com/users/kburtram/events{/privacy}","received_events_url":"https://api.github.com/users/kburtram/received_events","type":"User","site_admin":false},"assignees":[{"login":"kburtram","id":599935,"avatar_url":"https://avatars.githubusercontent.com/u/599935?v=3","gravatar_id":"","url":"https://api.github.com/users/kburtram","html_url":"https://github.com/kburtram","followers_url":"https://api.github.com/users/kburtram/followers","following_url":"https://api.github.com/users/kburtram/following{/other_user}","gists_url":"https://api.github.com/users/kburtram/gists{/gist_id}","starred_url":"https://api.github.com/users/kburtram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kburtram/subscriptions","organizations_url":"https://api.github.com/users/kburtram/orgs","repos_url":"https://api.github.com/users/kburtram/repos","events_url":"https://api.github.com/users/kburtram/events{/privacy}","received_events_url":"https://api.github.com/users/kburtram/received_events","type":"User","site_admin":false},{"login":"kevcunnane","id":10819925,"avatar_url":"https://avatars.githubusercontent.com/u/10819925?v=3","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},{"login":"coquagli","id":24420239,"avatar_url":"https://avatars.githubusercontent.com/u/24420239?v=3","gravatar_id":"","url":"https://api.github.com/users/coquagli","html_url":"https://github.com/coquagli","followers_url":"https://api.github.com/users/coquagli/followers","following_url":"https://api.github.com/users/coquagli/following{/other_user}","gists_url":"https://api.github.com/users/coquagli/gists{/gist_id}","starred_url":"https://api.github.com/users/coquagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coquagli/subscriptions","organizations_url":"https://api.github.com/users/coquagli/orgs","repos_url":"https://api.github.com/users/coquagli/repos","events_url":"https://api.github.com/users/coquagli/events{/privacy}","received_events_url":"https://api.github.com/users/coquagli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-09T01:37:36Z","updated_at":"2016-12-09T20:27:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/173","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/173","diff_url":"https://github.com/Microsoft/sqltoolsservice/pull/173.diff","patch_url":"https://github.com/Microsoft/sqltoolsservice/pull/173.patch"},"body":"This is a slightly larger change than anticipated due the difference between `DATETIME`, `DATETIME2`, and `DateTime`. The `DATETIME` type always uses 3 decimal points of a second, while the `DATETIME2` type has 7 (although since `DATETIME2(7)` is default in SSMS suggesting that it is a variable precision type). Regardless of the db type, the engine returns `DateTime` C# type. The db types are only made visible via the column info, via the numeric precision and numeric scale. My findings were as such:\r\n`DATETIME `: Precision = 23, Scale = 3\r\n`DATETIME2`: Precision = 255, Scale = 7\r\n\r\nThe scale corresponds neatly with the number of second decimal points to show. The buffer file writer was modified to store both the scale and the number of ticks. Then the buffer file reader was modified to read in the precision and the number of ticks and generate the ToString version of the DateTime to add \"f\" as many times as there is scale, which corresponds to milliseconds.\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments/266114649","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/173#issuecomment-266114649","issue_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/173","id":266114649,"user":{"login":"kevcunnane","id":10819925,"avatar_url":"https://avatars.githubusercontent.com/u/10819925?v=3","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T20:27:08Z","updated_at":"2016-12-09T20:27:08Z","body":":shipit:"}}
{"actor":{"display_login":"kevcunnane"}}