{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81730200","pull_request_review_id":2687675,"id":81730200,"diff_hunk":"@@ -123,10 +124,19 @@ void LogManager::Log(LogTypes::LOG_LEVELS level, LogTypes::LOG_TYPE type, const\n   if (!log->IsEnabled() || level > log->GetLevel() || !log->HasListeners())\n     return;\n \n+  static size_t pos;\n+  std::string pattern = DIR_SEP \"Source\" DIR_SEP \"Core\" DIR_SEP;\n+  if (!pos)\n+  {\n+    pos = static_cast<std::string>(file).find(pattern);","path":"Source/Core/Common/Logging/LogManager.cpp","position":null,"original_position":16,"commit_id":"89c3b83cc49b89131df62478b5e76d898b85e2fc","original_commit_id":"b87ab35848cdfa36388ef31f07c3046b074ae2a1","user":{"login":"aldelaro5","id":8932978,"avatar_url":"https://avatars.githubusercontent.com/u/8932978?v=3","gravatar_id":"","url":"https://api.github.com/users/aldelaro5","html_url":"https://github.com/aldelaro5","followers_url":"https://api.github.com/users/aldelaro5/followers","following_url":"https://api.github.com/users/aldelaro5/following{/other_user}","gists_url":"https://api.github.com/users/aldelaro5/gists{/gist_id}","starred_url":"https://api.github.com/users/aldelaro5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldelaro5/subscriptions","organizations_url":"https://api.github.com/users/aldelaro5/orgs","repos_url":"https://api.github.com/users/aldelaro5/repos","events_url":"https://api.github.com/users/aldelaro5/events{/privacy}","received_events_url":"https://api.github.com/users/aldelaro5/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-10-04T10:46:23Z","updated_at":"2016-10-04T10:46:23Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/4288#discussion_r81730200","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81730200"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4288#discussion_r81730200"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288","id":87845433,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4288","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4288.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4288.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4288","number":4288,"state":"open","locked":false,"title":"Reduce the filepath of logs","user":{"login":"aldelaro5","id":8932978,"avatar_url":"https://avatars.githubusercontent.com/u/8932978?v=3","gravatar_id":"","url":"https://api.github.com/users/aldelaro5","html_url":"https://github.com/aldelaro5","followers_url":"https://api.github.com/users/aldelaro5/followers","following_url":"https://api.github.com/users/aldelaro5/following{/other_user}","gists_url":"https://api.github.com/users/aldelaro5/gists{/gist_id}","starred_url":"https://api.github.com/users/aldelaro5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldelaro5/subscriptions","organizations_url":"https://api.github.com/users/aldelaro5/orgs","repos_url":"https://api.github.com/users/aldelaro5/repos","events_url":"https://api.github.com/users/aldelaro5/events{/privacy}","received_events_url":"https://api.github.com/users/aldelaro5/received_events","type":"User","site_admin":false},"body":"Using cmake and GCC, logs would contain the full file path when logging making logs line unnecessarily long.  This is solved by removing everything from the filepath before \"/Source/Core/\" (also including the removal of that string).  That way, all logs display a relative path from /Source/Core/ which is much less printing and you still can locate the source file.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4288)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-04T07:38:05Z","updated_at":"2016-10-04T10:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be053bbc6dca4d771cf4a45dbdd3efdcdb0c2a7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4288/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/89c3b83cc49b89131df62478b5e76d898b85e2fc","head":{"label":"aldelaro5:reduce-logged-filename","ref":"reduce-logged-filename","sha":"89c3b83cc49b89131df62478b5e76d898b85e2fc","user":{"login":"aldelaro5","id":8932978,"avatar_url":"https://avatars.githubusercontent.com/u/8932978?v=3","gravatar_id":"","url":"https://api.github.com/users/aldelaro5","html_url":"https://github.com/aldelaro5","followers_url":"https://api.github.com/users/aldelaro5/followers","following_url":"https://api.github.com/users/aldelaro5/following{/other_user}","gists_url":"https://api.github.com/users/aldelaro5/gists{/gist_id}","starred_url":"https://api.github.com/users/aldelaro5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldelaro5/subscriptions","organizations_url":"https://api.github.com/users/aldelaro5/orgs","repos_url":"https://api.github.com/users/aldelaro5/repos","events_url":"https://api.github.com/users/aldelaro5/events{/privacy}","received_events_url":"https://api.github.com/users/aldelaro5/received_events","type":"User","site_admin":false},"repo":{"id":65404748,"name":"dolphin","full_name":"aldelaro5/dolphin","owner":{"login":"aldelaro5","id":8932978,"avatar_url":"https://avatars.githubusercontent.com/u/8932978?v=3","gravatar_id":"","url":"https://api.github.com/users/aldelaro5","html_url":"https://github.com/aldelaro5","followers_url":"https://api.github.com/users/aldelaro5/followers","following_url":"https://api.github.com/users/aldelaro5/following{/other_user}","gists_url":"https://api.github.com/users/aldelaro5/gists{/gist_id}","starred_url":"https://api.github.com/users/aldelaro5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldelaro5/subscriptions","organizations_url":"https://api.github.com/users/aldelaro5/orgs","repos_url":"https://api.github.com/users/aldelaro5/repos","events_url":"https://api.github.com/users/aldelaro5/events{/privacy}","received_events_url":"https://api.github.com/users/aldelaro5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldelaro5/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/aldelaro5/dolphin","forks_url":"https://api.github.com/repos/aldelaro5/dolphin/forks","keys_url":"https://api.github.com/repos/aldelaro5/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldelaro5/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldelaro5/dolphin/teams","hooks_url":"https://api.github.com/repos/aldelaro5/dolphin/hooks","issue_events_url":"https://api.github.com/repos/aldelaro5/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/aldelaro5/dolphin/events","assignees_url":"https://api.github.com/repos/aldelaro5/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/aldelaro5/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/aldelaro5/dolphin/tags","blobs_url":"https://api.github.com/repos/aldelaro5/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldelaro5/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldelaro5/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldelaro5/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldelaro5/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/aldelaro5/dolphin/languages","stargazers_url":"https://api.github.com/repos/aldelaro5/dolphin/stargazers","contributors_url":"https://api.github.com/repos/aldelaro5/dolphin/contributors","subscribers_url":"https://api.github.com/repos/aldelaro5/dolphin/subscribers","subscription_url":"https://api.github.com/repos/aldelaro5/dolphin/subscription","commits_url":"https://api.github.com/repos/aldelaro5/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldelaro5/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldelaro5/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldelaro5/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldelaro5/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/aldelaro5/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldelaro5/dolphin/merges","archive_url":"https://api.github.com/repos/aldelaro5/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldelaro5/dolphin/downloads","issues_url":"https://api.github.com/repos/aldelaro5/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/aldelaro5/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/aldelaro5/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/aldelaro5/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldelaro5/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/aldelaro5/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/aldelaro5/dolphin/deployments","created_at":"2016-08-10T17:59:29Z","updated_at":"2016-08-10T17:59:54Z","pushed_at":"2016-10-04T10:45:34Z","git_url":"git://github.com/aldelaro5/dolphin.git","ssh_url":"git@github.com:aldelaro5/dolphin.git","clone_url":"https://github.com/aldelaro5/dolphin.git","svn_url":"https://github.com/aldelaro5/dolphin","homepage":"https://dolphin-emu.org/","size":266433,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"ea33405febf183058bb30a22f4f627fed4bb8e17","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-10-04T07:36:10Z","pushed_at":"2016-10-04T10:45:39Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":329482,"stargazers_count":2761,"watchers_count":2761,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":737,"mirror_url":null,"open_issues_count":103,"forks":737,"open_issues":103,"watchers":2761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4288"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4288"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4288/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4288/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/89c3b83cc49b89131df62478b5e76d898b85e2fc"}}}}
{"actor":{"display_login":"aldelaro5"}}