{"action":"created","comment":{"url":"https://api.github.com/repos/intuit/wasabi/pulls/comments/78267731","id":78267731,"diff_hunk":"@@ -175,39 +166,24 @@ start_cassandra() {\n }\n \n console_cassandra() {\n-  wcip=$(docker inspect --format \"{{ .NetworkSettings.Networks.${docker_network}.IPAddress }}\" ${project}-cassandra)\n-\n-  docker run --net=${docker_network} -it --rm ${cassandra} cqlsh ${wcip} || \\\n-    usage \"unable to run command: docker run --net=${docker_network} -it --rm ${cassandra} cqlsh ${wcip}\" 1\n+  docker exec -it ${project}-cassandra cqlsh || \\\n+    usage \"unable to run command: docker exec -it ${project}-cassandra cqlsh\" 1\n }\n \n start_mysql() {\n   pwd=mypass\n \n   start_docker\n-  start_container ${project}-mysql ${mysql} \"-p 3306:3306 -e MYSQL_ROOT_PASSWORD=${pwd}\"\n-\n-  wmip=$(docker inspect --format \"{{ .NetworkSettings.Networks.${docker_network}.IPAddress }}\" ${project}-mysql)\n-  sql=$(cat << EOF\n-    create database if not exists ${project};\n-    grant all privileges on ${project}.* to 'readwrite'@'localhost' identified by 'readwrite';\n-    grant all on *.* to 'readwrite'@'%' identified by 'readwrite';\n-    flush privileges;\n-EOF\n-)\n-\n-  docker run --net=${docker_network} -it --rm ${mysql} mysql -h${wmip} -P3306 -uroot -p${pwd} -e \"${sql}\" || \\\n-    usage \"unable to run command: % docker run --net=${docker_network} -it --rm ${mysql} mysql -h${wmip} -P3306 -uroot -p${pwd} -e \\\"${sql}\\\"\" 1\n+  start_container ${project}-mysql ${mysql} \"-p 3306:3306 -e MYSQL_ROOT_PASSWORD=${pwd} -e MYSQL_DATABASE=wasabi -e MYSQL_USER=readwrite -e MYSQL_PASSWORD=readwrite\"\n \n   [ \"${verify}\" = true ] && console_mysql\n }\n \n console_mysql() {\n   pwd=mypass\n-  wmip=$(docker inspect --format \"{{ .NetworkSettings.Networks.${docker_network}.IPAddress }}\" ${project}-mysql)\n \n-  docker run --net=${docker_network} -it --rm ${mysql} mysql -h${wmip} -P3306 -uroot -p${pwd} || \\\n-    usage \"unable to run command: % docker run --net=${docker_network} -it --rm ${mysql} mysql -h${wmip} -P3306 -uroot -p${pwd}\" 1\n+  docker exec -it ${project}-mysql mysql -uroot -p${pwd} || \\","path":"bin/container.sh","position":90,"original_position":90,"commit_id":"b1a3e33252d4780ed6674c182fc5a0731074b15a","original_commit_id":"b1a3e33252d4780ed6674c182fc5a0731074b15a","user":{"login":"jwtodd","id":99516,"avatar_url":"https://avatars.githubusercontent.com/u/99516?v=3","gravatar_id":"","url":"https://api.github.com/users/jwtodd","html_url":"https://github.com/jwtodd","followers_url":"https://api.github.com/users/jwtodd/followers","following_url":"https://api.github.com/users/jwtodd/following{/other_user}","gists_url":"https://api.github.com/users/jwtodd/gists{/gist_id}","starred_url":"https://api.github.com/users/jwtodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwtodd/subscriptions","organizations_url":"https://api.github.com/users/jwtodd/orgs","repos_url":"https://api.github.com/users/jwtodd/repos","events_url":"https://api.github.com/users/jwtodd/events{/privacy}","received_events_url":"https://api.github.com/users/jwtodd/received_events","type":"User","site_admin":false},"body":"my thoughts around using 'run' vs 'exec' was that it ensured a \"new\" cqlsh client could network connect to the cas container, vs just starting a cqlsh client on the existing cas container ... which doesn't seem like a real network-reachability test. make sense?\r\n\r\nthoughts?","created_at":"2016-09-10T01:07:16Z","updated_at":"2016-09-10T01:07:16Z","html_url":"https://github.com/intuit/wasabi/pull/78#discussion_r78267731","pull_request_url":"https://api.github.com/repos/intuit/wasabi/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/comments/78267731"},"html":{"href":"https://github.com/intuit/wasabi/pull/78#discussion_r78267731"},"pull_request":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/intuit/wasabi/pulls/78","id":84443740,"html_url":"https://github.com/intuit/wasabi/pull/78","diff_url":"https://github.com/intuit/wasabi/pull/78.diff","patch_url":"https://github.com/intuit/wasabi/pull/78.patch","issue_url":"https://api.github.com/repos/intuit/wasabi/issues/78","number":78,"state":"open","locked":false,"title":"Feature/windows","user":{"login":"shoeffner","id":1836815,"avatar_url":"https://avatars.githubusercontent.com/u/1836815?v=3","gravatar_id":"","url":"https://api.github.com/users/shoeffner","html_url":"https://github.com/shoeffner","followers_url":"https://api.github.com/users/shoeffner/followers","following_url":"https://api.github.com/users/shoeffner/following{/other_user}","gists_url":"https://api.github.com/users/shoeffner/gists{/gist_id}","starred_url":"https://api.github.com/users/shoeffner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoeffner/subscriptions","organizations_url":"https://api.github.com/users/shoeffner/orgs","repos_url":"https://api.github.com/users/shoeffner/repos","events_url":"https://api.github.com/users/shoeffner/events{/privacy}","received_events_url":"https://api.github.com/users/shoeffner/received_events","type":"User","site_admin":false},"body":"- Supplying several scripts for windows to build/start/stop/remove wasabi via docker-machine.\r\n- Minimizing Dockerfile to only 6 steps.\r\n- Adjusted (i.e. simplified) container.sh according to the learnings I had with windows.\r\n- Added instructions to `README.md`.\r\n- Changing IntegrationTest behavior slightly: fixing some tests (rollups, tests using assignments) and duct-taped the bucket tests.","created_at":"2016-09-08T09:32:35Z","updated_at":"2016-09-10T01:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf8e014fca0ff38a09bea3a700efff3e6e4ef95a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intuit/wasabi/pulls/78/commits","review_comments_url":"https://api.github.com/repos/intuit/wasabi/pulls/78/comments","review_comment_url":"https://api.github.com/repos/intuit/wasabi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intuit/wasabi/issues/78/comments","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/b1a3e33252d4780ed6674c182fc5a0731074b15a","head":{"label":"intuit:feature/windows","ref":"feature/windows","sha":"b1a3e33252d4780ed6674c182fc5a0731074b15a","user":{"login":"intuit","id":2495066,"avatar_url":"https://avatars.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"repo":{"id":61667990,"name":"wasabi","full_name":"intuit/wasabi","owner":{"login":"intuit","id":2495066,"avatar_url":"https://avatars.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intuit/wasabi","description":"Wasabi A/B Testing Service is a real-time, enterprise-grade, 100% API driven project.","fork":false,"url":"https://api.github.com/repos/intuit/wasabi","forks_url":"https://api.github.com/repos/intuit/wasabi/forks","keys_url":"https://api.github.com/repos/intuit/wasabi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intuit/wasabi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intuit/wasabi/teams","hooks_url":"https://api.github.com/repos/intuit/wasabi/hooks","issue_events_url":"https://api.github.com/repos/intuit/wasabi/issues/events{/number}","events_url":"https://api.github.com/repos/intuit/wasabi/events","assignees_url":"https://api.github.com/repos/intuit/wasabi/assignees{/user}","branches_url":"https://api.github.com/repos/intuit/wasabi/branches{/branch}","tags_url":"https://api.github.com/repos/intuit/wasabi/tags","blobs_url":"https://api.github.com/repos/intuit/wasabi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intuit/wasabi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intuit/wasabi/git/refs{/sha}","trees_url":"https://api.github.com/repos/intuit/wasabi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/{sha}","languages_url":"https://api.github.com/repos/intuit/wasabi/languages","stargazers_url":"https://api.github.com/repos/intuit/wasabi/stargazers","contributors_url":"https://api.github.com/repos/intuit/wasabi/contributors","subscribers_url":"https://api.github.com/repos/intuit/wasabi/subscribers","subscription_url":"https://api.github.com/repos/intuit/wasabi/subscription","commits_url":"https://api.github.com/repos/intuit/wasabi/commits{/sha}","git_commits_url":"https://api.github.com/repos/intuit/wasabi/git/commits{/sha}","comments_url":"https://api.github.com/repos/intuit/wasabi/comments{/number}","issue_comment_url":"https://api.github.com/repos/intuit/wasabi/issues/comments{/number}","contents_url":"https://api.github.com/repos/intuit/wasabi/contents/{+path}","compare_url":"https://api.github.com/repos/intuit/wasabi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intuit/wasabi/merges","archive_url":"https://api.github.com/repos/intuit/wasabi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intuit/wasabi/downloads","issues_url":"https://api.github.com/repos/intuit/wasabi/issues{/number}","pulls_url":"https://api.github.com/repos/intuit/wasabi/pulls{/number}","milestones_url":"https://api.github.com/repos/intuit/wasabi/milestones{/number}","notifications_url":"https://api.github.com/repos/intuit/wasabi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intuit/wasabi/labels{/name}","releases_url":"https://api.github.com/repos/intuit/wasabi/releases{/id}","deployments_url":"https://api.github.com/repos/intuit/wasabi/deployments","created_at":"2016-06-21T21:21:06Z","updated_at":"2016-09-07T21:46:27Z","pushed_at":"2016-09-10T00:31:57Z","git_url":"git://github.com/intuit/wasabi.git","ssh_url":"git@github.com:intuit/wasabi.git","clone_url":"https://github.com/intuit/wasabi.git","svn_url":"https://github.com/intuit/wasabi","homepage":"","size":10864,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":68,"default_branch":"develop"}},"base":{"label":"intuit:develop","ref":"develop","sha":"e111a89879e6d9b757ad03cdfdfaaecf7aac04e8","user":{"login":"intuit","id":2495066,"avatar_url":"https://avatars.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"repo":{"id":61667990,"name":"wasabi","full_name":"intuit/wasabi","owner":{"login":"intuit","id":2495066,"avatar_url":"https://avatars.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intuit/wasabi","description":"Wasabi A/B Testing Service is a real-time, enterprise-grade, 100% API driven project.","fork":false,"url":"https://api.github.com/repos/intuit/wasabi","forks_url":"https://api.github.com/repos/intuit/wasabi/forks","keys_url":"https://api.github.com/repos/intuit/wasabi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intuit/wasabi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intuit/wasabi/teams","hooks_url":"https://api.github.com/repos/intuit/wasabi/hooks","issue_events_url":"https://api.github.com/repos/intuit/wasabi/issues/events{/number}","events_url":"https://api.github.com/repos/intuit/wasabi/events","assignees_url":"https://api.github.com/repos/intuit/wasabi/assignees{/user}","branches_url":"https://api.github.com/repos/intuit/wasabi/branches{/branch}","tags_url":"https://api.github.com/repos/intuit/wasabi/tags","blobs_url":"https://api.github.com/repos/intuit/wasabi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intuit/wasabi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intuit/wasabi/git/refs{/sha}","trees_url":"https://api.github.com/repos/intuit/wasabi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/{sha}","languages_url":"https://api.github.com/repos/intuit/wasabi/languages","stargazers_url":"https://api.github.com/repos/intuit/wasabi/stargazers","contributors_url":"https://api.github.com/repos/intuit/wasabi/contributors","subscribers_url":"https://api.github.com/repos/intuit/wasabi/subscribers","subscription_url":"https://api.github.com/repos/intuit/wasabi/subscription","commits_url":"https://api.github.com/repos/intuit/wasabi/commits{/sha}","git_commits_url":"https://api.github.com/repos/intuit/wasabi/git/commits{/sha}","comments_url":"https://api.github.com/repos/intuit/wasabi/comments{/number}","issue_comment_url":"https://api.github.com/repos/intuit/wasabi/issues/comments{/number}","contents_url":"https://api.github.com/repos/intuit/wasabi/contents/{+path}","compare_url":"https://api.github.com/repos/intuit/wasabi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intuit/wasabi/merges","archive_url":"https://api.github.com/repos/intuit/wasabi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intuit/wasabi/downloads","issues_url":"https://api.github.com/repos/intuit/wasabi/issues{/number}","pulls_url":"https://api.github.com/repos/intuit/wasabi/pulls{/number}","milestones_url":"https://api.github.com/repos/intuit/wasabi/milestones{/number}","notifications_url":"https://api.github.com/repos/intuit/wasabi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intuit/wasabi/labels{/name}","releases_url":"https://api.github.com/repos/intuit/wasabi/releases{/id}","deployments_url":"https://api.github.com/repos/intuit/wasabi/deployments","created_at":"2016-06-21T21:21:06Z","updated_at":"2016-09-07T21:46:27Z","pushed_at":"2016-09-10T00:31:57Z","git_url":"git://github.com/intuit/wasabi.git","ssh_url":"git@github.com:intuit/wasabi.git","clone_url":"https://github.com/intuit/wasabi.git","svn_url":"https://github.com/intuit/wasabi","homepage":"","size":10864,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":68,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/78"},"html":{"href":"https://github.com/intuit/wasabi/pull/78"},"issue":{"href":"https://api.github.com/repos/intuit/wasabi/issues/78"},"comments":{"href":"https://api.github.com/repos/intuit/wasabi/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/intuit/wasabi/statuses/b1a3e33252d4780ed6674c182fc5a0731074b15a"}}}}
{"actor":{"display_login":"jwtodd"}}