{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/52381832","id":52381832,"diff_hunk":"@@ -33,6 +33,7 @@ func (s *DockerSuite) TearDownTest(c *check.C) {\n \tdeleteAllImages()\n \tdeleteAllVolumes()\n \tdeleteAllNetworks()\n+\tcleanupShm()","path":"integration-cli/check_test.go","position":4,"original_position":4,"commit_id":"6e288f6f9bb843fe443a5c21e9dbffaeecdce207","original_commit_id":"6e288f6f9bb843fe443a5c21e9dbffaeecdce207","user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"body":"Couldn't figure out a way to do so. If the previous test crashes this is the only certain way to clean up behind that I found. As far as CI is concerned this could be safely removed though since we start from scratch every time. It just means that after a test failure there is no warranty that the test actually passes if it also uses shm.\r\n\r\n\r\nAny suggestions?\r\n","created_at":"2016-02-09T22:05:06Z","updated_at":"2016-02-09T22:05:06Z","html_url":"https://github.com/docker/docker/pull/20133#discussion_r52381832","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/20133","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/52381832"},"html":{"href":"https://github.com/docker/docker/pull/20133#discussion_r52381832"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/20133"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20133","id":58692185,"html_url":"https://github.com/docker/docker/pull/20133","diff_url":"https://github.com/docker/docker/pull/20133.diff","patch_url":"https://github.com/docker/docker/pull/20133.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/20133","number":20133,"state":"open","locked":false,"title":"Prevent mqueue from implicitely becoming a bind mount with --ipc=host","user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"body":"Currently, when running a container with `--ipc=host`, if `/dev/mqueue` is\r\na standard directory on the hos the daemon will bind mount it allowing\r\nthe container to create/modify files on the host.\r\n\r\nThis commit forces `/dev/mqueue` to always be of type `mqueue` except when\r\nthe user explicitely requested something to be bind mounted to\r\n`/dev/mqueue`.\r\n\r\nSigned-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>\r\n\r\n---\r\nping @crosbymichael @rhatdan ","created_at":"2016-02-09T01:04:16Z","updated_at":"2016-02-09T22:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d187d30ba378ea32c75349a3793c59a11307e9b1","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/50","html_url":"https://github.com/docker/docker/milestones/1.10.1","labels_url":"https://api.github.com/repos/docker/docker/milestones/50/labels","id":1563843,"number":50,"title":"1.10.1","description":"This milestone may never be actually released, but is to collect issues / PR's that may possibly warrant a 1.10.1 release; See our patch-release policy: https://github.com/docker/docker/blob/master/project/PATCH-RELEASES.md\r\n\r\n","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":18,"state":"open","created_at":"2016-02-04T17:09:40Z","updated_at":"2016-02-09T19:31:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/20133/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/20133/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/20133/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/6e288f6f9bb843fe443a5c21e9dbffaeecdce207","head":{"label":"mlaventure:dont-bind-mount-mqueue","ref":"dont-bind-mount-mqueue","sha":"6e288f6f9bb843fe443a5c21e9dbffaeecdce207","user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"repo":{"id":48391432,"name":"docker","full_name":"mlaventure/docker","owner":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlaventure/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mlaventure/docker","forks_url":"https://api.github.com/repos/mlaventure/docker/forks","keys_url":"https://api.github.com/repos/mlaventure/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlaventure/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlaventure/docker/teams","hooks_url":"https://api.github.com/repos/mlaventure/docker/hooks","issue_events_url":"https://api.github.com/repos/mlaventure/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mlaventure/docker/events","assignees_url":"https://api.github.com/repos/mlaventure/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mlaventure/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mlaventure/docker/tags","blobs_url":"https://api.github.com/repos/mlaventure/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlaventure/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlaventure/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlaventure/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlaventure/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mlaventure/docker/languages","stargazers_url":"https://api.github.com/repos/mlaventure/docker/stargazers","contributors_url":"https://api.github.com/repos/mlaventure/docker/contributors","subscribers_url":"https://api.github.com/repos/mlaventure/docker/subscribers","subscription_url":"https://api.github.com/repos/mlaventure/docker/subscription","commits_url":"https://api.github.com/repos/mlaventure/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlaventure/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlaventure/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlaventure/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlaventure/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mlaventure/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlaventure/docker/merges","archive_url":"https://api.github.com/repos/mlaventure/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlaventure/docker/downloads","issues_url":"https://api.github.com/repos/mlaventure/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mlaventure/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mlaventure/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mlaventure/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlaventure/docker/labels{/name}","releases_url":"https://api.github.com/repos/mlaventure/docker/releases{/id}","deployments_url":"https://api.github.com/repos/mlaventure/docker/deployments","created_at":"2015-12-21T20:00:27Z","updated_at":"2015-12-21T20:00:37Z","pushed_at":"2016-02-09T21:36:56Z","git_url":"git://github.com/mlaventure/docker.git","ssh_url":"git@github.com:mlaventure/docker.git","clone_url":"https://github.com/mlaventure/docker.git","svn_url":"https://github.com/mlaventure/docker","homepage":"http://www.docker.com","size":81262,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"fa860c86ff0a368e686535c2689d1099fa9ea7a2","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-02-09T21:32:53Z","pushed_at":"2016-02-09T21:36:57Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":135717,"stargazers_count":28546,"watchers_count":28546,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7911,"mirror_url":null,"open_issues_count":1296,"forks":7911,"open_issues":1296,"watchers":28546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/20133"},"html":{"href":"https://github.com/docker/docker/pull/20133"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/20133"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/20133/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/20133/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/20133/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/6e288f6f9bb843fe443a5c21e9dbffaeecdce207"}}}}