{"action":"created","issue":{"url":"https://api.github.com/repos/o0ragman0o/ITT/issues/5","repository_url":"https://api.github.com/repos/o0ragman0o/ITT","labels_url":"https://api.github.com/repos/o0ragman0o/ITT/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/o0ragman0o/ITT/issues/5/comments","events_url":"https://api.github.com/repos/o0ragman0o/ITT/issues/5/events","html_url":"https://github.com/o0ragman0o/ITT/issues/5","id":193979475,"number":5,"title":"wrong price, buyer and seller field of Sale event","user":{"login":"bezalel","id":8152718,"avatar_url":"https://avatars.githubusercontent.com/u/8152718?v=3","gravatar_id":"","url":"https://api.github.com/users/bezalel","html_url":"https://github.com/bezalel","followers_url":"https://api.github.com/users/bezalel/followers","following_url":"https://api.github.com/users/bezalel/following{/other_user}","gists_url":"https://api.github.com/users/bezalel/gists{/gist_id}","starred_url":"https://api.github.com/users/bezalel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezalel/subscriptions","organizations_url":"https://api.github.com/users/bezalel/orgs","repos_url":"https://api.github.com/users/bezalel/repos","events_url":"https://api.github.com/users/bezalel/events{/privacy}","received_events_url":"https://api.github.com/users/bezalel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-12-07T07:45:47Z","updated_at":"2016-12-07T11:02:08Z","closed_at":"2016-12-07T11:02:08Z","body":"It seems that next order's price is logged on \"Sale\" event\r\n\r\nline 440 of ITT.sol\r\n`              // prep for next order`\r\n`            bestPrice = spread(!tmsg.side);`\r\n`            Sale (bestPrice, takeAmount, msg.sender, maker);`\r\n\r\nI think Sale event should be fired before going to next order\r\n\r\n`          Sale (bestPrice, takeAmount, msg.sender, maker);`\r\n`            // prep for next order`\r\n`            bestPrice = spread(!tmsg.side);`"},"comment":{"url":"https://api.github.com/repos/o0ragman0o/ITT/issues/comments/265418854","html_url":"https://github.com/o0ragman0o/ITT/issues/5#issuecomment-265418854","issue_url":"https://api.github.com/repos/o0ragman0o/ITT/issues/5","id":265418854,"user":{"login":"o0ragman0o","id":12790330,"avatar_url":"https://avatars.githubusercontent.com/u/12790330?v=3","gravatar_id":"","url":"https://api.github.com/users/o0ragman0o","html_url":"https://github.com/o0ragman0o","followers_url":"https://api.github.com/users/o0ragman0o/followers","following_url":"https://api.github.com/users/o0ragman0o/following{/other_user}","gists_url":"https://api.github.com/users/o0ragman0o/gists{/gist_id}","starred_url":"https://api.github.com/users/o0ragman0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o0ragman0o/subscriptions","organizations_url":"https://api.github.com/users/o0ragman0o/orgs","repos_url":"https://api.github.com/users/o0ragman0o/repos","events_url":"https://api.github.com/users/o0ragman0o/events{/privacy}","received_events_url":"https://api.github.com/users/o0ragman0o/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T11:02:08Z","updated_at":"2016-12-07T11:02:08Z","body":"Fixed next price before `Sale` event. Added `bool tmsg.side`"}}
{"actor":{"display_login":"o0ragman0o"}}