{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/8257","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/8257/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/8257/comments","events_url":"https://api.github.com/repos/angular/angular/issues/8257/events","html_url":"https://github.com/angular/angular/pull/8257","id":151230533,"number":8257,"title":"chore(testing): Refactor test methods to have a uniform interface.","user":{"login":"vikerman","id":85066,"avatar_url":"https://avatars.githubusercontent.com/u/85066?v=3","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_action:%20cleanup","name":"pr_action: cleanup","color":"e11d21"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_state:%20LGTM","name":"pr_state: LGTM","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"vikerman","id":85066,"avatar_url":"https://avatars.githubusercontent.com/u/85066?v=3","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-04-26T20:24:35Z","updated_at":"2016-04-26T22:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/8257","html_url":"https://github.com/angular/angular/pull/8257","diff_url":"https://github.com/angular/angular/pull/8257.diff","patch_url":"https://github.com/angular/angular/pull/8257.patch"},"body":"Remove FunctionWithParamTokens.\r\n\r\nAll test wrappers async, fakeAsync and inject now return just a Function instead of FunctionWithParamTokens. This makes them directly consumable by the test framework. Also the test framework code does not have to handle a union of Function and FunctionWithParamTokens everywhere.\r\n\r\nThe Function returned by the above are considered asynchronous by the test framework if they return a Promise, synchronous otherwise.\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/214908100","html_url":"https://github.com/angular/angular/pull/8257#issuecomment-214908100","issue_url":"https://api.github.com/repos/angular/angular/issues/8257","id":214908100,"user":{"login":"vikerman","id":85066,"avatar_url":"https://avatars.githubusercontent.com/u/85066?v=3","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T22:34:54Z","updated_at":"2016-04-26T22:34:54Z","body":"Test timing after all \"it\" methods are wrapped with (done)=> {}\r\n\r\nJS(No change):\r\nmaster: SUCCESS (27.341 secs / 23.577 secs)\r\nPR: SUCCESS (26.694 secs / 23.059 secs)\r\n\r\nCJS (Maybe little slower after change)\r\nmaster: Finished in 12.52 seconds\r\nPR: Finished in 13.01 seconds "}}