{"action":"created","issue":{"url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/37","repository_url":"https://api.github.com/repos/SleepyTrousers/EnderCore","labels_url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/37/comments","events_url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/37/events","html_url":"https://github.com/SleepyTrousers/EnderCore/pull/37","id":148915309,"number":37,"title":"Fix several classloading and transformation issues","user":{"login":"Aaron1011","id":1408859,"avatar_url":"https://avatars.githubusercontent.com/u/1408859?v=3","gravatar_id":"","url":"https://api.github.com/users/Aaron1011","html_url":"https://github.com/Aaron1011","followers_url":"https://api.github.com/users/Aaron1011/followers","following_url":"https://api.github.com/users/Aaron1011/following{/other_user}","gists_url":"https://api.github.com/users/Aaron1011/gists{/gist_id}","starred_url":"https://api.github.com/users/Aaron1011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aaron1011/subscriptions","organizations_url":"https://api.github.com/users/Aaron1011/orgs","repos_url":"https://api.github.com/users/Aaron1011/repos","events_url":"https://api.github.com/users/Aaron1011/events{/privacy}","received_events_url":"https://api.github.com/users/Aaron1011/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-17T03:36:43Z","updated_at":"2016-06-07T04:35:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SleepyTrousers/EnderCore/pulls/37","html_url":"https://github.com/SleepyTrousers/EnderCore/pull/37","diff_url":"https://github.com/SleepyTrousers/EnderCore/pull/37.diff","patch_url":"https://github.com/SleepyTrousers/EnderCore/pull/37.patch"},"body":"`EnderCoreTransformer` is causing several classes to be loaded earlier than they should be. While this is normally not a problem, the [SpongeForge](https://github.com/SpongePowered/SpongeForge) mod is experiencing [an issue due to this](https://github.com/SpongePowered/SpongeForge/issues/610).\r\n\r\nI've provided a more thorough explanation in the form of comments within the PR, but the root of the issue is that `EnderCore` class is being referenced from the transformer (through a reference to the static `logger` field).\r\n\r\nThis PR removes the reference to `EnderCore` in `EnderCoreTransformer` by copying over the `logger` field. Unfortunately, the `EnderCore.NAME` field cannot be used for the same reason that the `logger` field cannot. However, I can abstract that out to a separate class if necessary.\r\n\r\nI've also added some transformer exclusions for classes loaded directly and indirectly by `EnderCoreTransformer`. This is less of an issue than the `EnderCore` reference, but will prevent any future compatibility issues with [SpongeForge](https://github.com/SpongePowered/SpongeForge) or other [Mixin](https://github.com/SpongePowered/Mixin)-based projects."},"comment":{"url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/comments/224173282","html_url":"https://github.com/SleepyTrousers/EnderCore/pull/37#issuecomment-224173282","issue_url":"https://api.github.com/repos/SleepyTrousers/EnderCore/issues/37","id":224173282,"user":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars.githubusercontent.com/u/1203877?v=3","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T04:35:13Z","updated_at":"2016-06-07T04:35:13Z","body":"@CrazyPants @HenryLoenwind Is it possible we can get this resolved sooner than later as it affects now not just 1.8.9, but also 1.9? "}}
{"actor":{"display_login":"gabizou"}}