{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7721","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7721/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7721/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7721/events","html_url":"https://github.com/cockroachdb/cockroach/pull/7721","id":164703038,"number":7721,"title":"storage: Maintain contains_estimates flag on MVCCStats","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"assignees":[{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-07-10T06:59:17Z","updated_at":"2016-07-10T15:45:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7721","html_url":"https://github.com/cockroachdb/cockroach/pull/7721","diff_url":"https://github.com/cockroachdb/cockroach/pull/7721.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/7721.patch"},"body":"Closes #7290.\r\n\r\nThis change adds a `contains_estimates` to the `MVCCStats` object. The\r\nflag is set whenever a stats computation is only an estimate (such as\r\nwith Merge requests), and is propagated through stats arithmetic. Later,\r\ncomputations which require accurate statistics can use this field to\r\ndetermine if they need to recompute the stats or not.\r\n\r\nThe only case where this is currently necessary is during range splits,\r\nwhere stats arithmetic is only possible if the current stats object is 100%\r\naccurate. If not, the split will call `ComputeStatsForRange` for both\r\nhalves of the split, instead of just the left half.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/7721)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/231595567","html_url":"https://github.com/cockroachdb/cockroach/pull/7721#issuecomment-231595567","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7721","id":231595567,"user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"created_at":"2016-07-10T15:45:55Z","updated_at":"2016-07-10T15:45:55Z","body":"There's the usual slight migration concern about ranges being caught\nmid-split by this upgrade, so maybe you want to give Ben a chance to chime\nin. As far as I know we hit timeseries inaccuracies quite a bit (right? If\nso is that tracked anywhere?), and so this change would only add\ninconsistencies in MVCCStats for those ranges, which seems ... acceptable\nto me.\n\nOn Sun, Jul 10, 2016 at 11:32 AM Peter Mattis <notifications@github.com>\nwrote:\n\n> Not sure how I missed the changes to storage/engine/enginepb/mvcc.go.\n> Apparently I can't use search correctly. [image: :lgtm_strong:]\n> <https://camo.githubusercontent.com/aef7967e4818b7dc97469bd2853c2255784874e2/68747470733a2f2f72657669657761626c652e696f2f6c67746d5f7374726f6e672e706e67>\n> ------------------------------\n>\n> Review status: all files reviewed at latest revision, all discussions\n> resolved, some commit checks failed.\n> ------------------------------\n>\n> *Comments from Reviewable\n> <https://reviewable.io:443/reviews/cockroachdb/cockroach/7721#-:-KMKQnEYXbxk2x4ZbsCd:776422841>*\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cockroachdb/cockroach/pull/7721#issuecomment-231594887>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AE135FH3V8KBxt-XSOHg8EGl4S_JpjLhks5qURCEgaJpZM4JIx2b>\n> .\n>\n-- \n\n-- Tobias\n"}}
{"actor":{"display_login":"tschottdorf"}}