{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/66477165","id":66477165,"diff_hunk":"@@ -0,0 +1,40 @@\n+'use strict';\n+\n+const angular = require('angular');\n+\n+module.exports = angular\n+  .module('spinnaker.core.application.modal.applicationProviderFields.directive', [\n+    require('../../cloudProvider/cloudProvider.registry'),\n+    require('../../utils/lodash.js'),\n+  ])\n+  .directive('applicationProviderFields', function() {","path":"app/scripts/modules/core/application/modal/applicationProviderFields.directive.js","position":10,"original_position":10,"commit_id":"45af475897ac1b9969279bd4fb6896f0d1bc735c","original_commit_id":"45af475897ac1b9969279bd4fb6896f0d1bc735c","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"It's preferable to use components when possible. This would become:\r\n```javascript\r\n.component('applicationProviderFields', {\r\n  bindings: {\r\n    application: '=',\r\n    cloudProviders: '='\r\n  },\r\n  templateUrl: require('./applicationProviderFields.component.html')\r\n})\r\n```\r\nThen, replace `vm` with `$ctrl` in the template.","created_at":"2016-06-09T16:43:12Z","updated_at":"2016-06-09T16:43:12Z","html_url":"https://github.com/spinnaker/deck/pull/2331#discussion_r66477165","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/2331","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/66477165"},"html":{"href":"https://github.com/spinnaker/deck/pull/2331#discussion_r66477165"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2331"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/2331","id":73230028,"html_url":"https://github.com/spinnaker/deck/pull/2331","diff_url":"https://github.com/spinnaker/deck/pull/2331.diff","patch_url":"https://github.com/spinnaker/deck/pull/2331.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/2331","number":2331,"state":"open","locked":false,"title":" Adds support to New/Edit Application dialog for provider-specific settings","user":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"body":" Adds support to New/Edit Application dialog for provider-specific settings.\r\n\r\nThis PR includes an AWS setting because the setting is desired (and demonstrates the directive's usage), but I can pull it out.\r\n\r\n@lwander @anotherchrisberry PTAL","created_at":"2016-06-09T15:01:23Z","updated_at":"2016-06-09T16:43:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a08525a180651d2f4bf6c5fddec42e9e5409d02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/2331/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/2331/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/2331/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/45af475897ac1b9969279bd4fb6896f0d1bc735c","head":{"label":"danielpeach:new-and-edit-app-provider-settings","ref":"new-and-edit-app-provider-settings","sha":"45af475897ac1b9969279bd4fb6896f0d1bc735c","user":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"repo":{"id":59520395,"name":"deck","full_name":"danielpeach/deck","owner":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielpeach/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/danielpeach/deck","forks_url":"https://api.github.com/repos/danielpeach/deck/forks","keys_url":"https://api.github.com/repos/danielpeach/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpeach/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpeach/deck/teams","hooks_url":"https://api.github.com/repos/danielpeach/deck/hooks","issue_events_url":"https://api.github.com/repos/danielpeach/deck/issues/events{/number}","events_url":"https://api.github.com/repos/danielpeach/deck/events","assignees_url":"https://api.github.com/repos/danielpeach/deck/assignees{/user}","branches_url":"https://api.github.com/repos/danielpeach/deck/branches{/branch}","tags_url":"https://api.github.com/repos/danielpeach/deck/tags","blobs_url":"https://api.github.com/repos/danielpeach/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpeach/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpeach/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpeach/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpeach/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpeach/deck/languages","stargazers_url":"https://api.github.com/repos/danielpeach/deck/stargazers","contributors_url":"https://api.github.com/repos/danielpeach/deck/contributors","subscribers_url":"https://api.github.com/repos/danielpeach/deck/subscribers","subscription_url":"https://api.github.com/repos/danielpeach/deck/subscription","commits_url":"https://api.github.com/repos/danielpeach/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpeach/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpeach/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpeach/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpeach/deck/contents/{+path}","compare_url":"https://api.github.com/repos/danielpeach/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpeach/deck/merges","archive_url":"https://api.github.com/repos/danielpeach/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpeach/deck/downloads","issues_url":"https://api.github.com/repos/danielpeach/deck/issues{/number}","pulls_url":"https://api.github.com/repos/danielpeach/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpeach/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpeach/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpeach/deck/labels{/name}","releases_url":"https://api.github.com/repos/danielpeach/deck/releases{/id}","deployments_url":"https://api.github.com/repos/danielpeach/deck/deployments","created_at":"2016-05-23T21:43:32Z","updated_at":"2016-05-23T21:43:37Z","pushed_at":"2016-06-09T14:57:45Z","git_url":"git://github.com/danielpeach/deck.git","ssh_url":"git@github.com:danielpeach/deck.git","clone_url":"https://github.com/danielpeach/deck.git","svn_url":"https://github.com/danielpeach/deck","homepage":"","size":18583,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"52a982adeaceb988dedbac2426b427fe83b4f30a","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2016-06-01T14:51:26Z","pushed_at":"2016-06-09T16:35:50Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":30788,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":7,"forks":67,"open_issues":7,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2331"},"html":{"href":"https://github.com/spinnaker/deck/pull/2331"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/2331"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/2331/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2331/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2331/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/45af475897ac1b9969279bd4fb6896f0d1bc735c"}}}}
{"actor":{"display_login":"anotherchrisberry"}}