{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/4541","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/4541/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/4541/comments","events_url":"https://api.github.com/repos/apple/swift/issues/4541/events","html_url":"https://github.com/apple/swift/pull/4541","id":173689553,"number":4541,"title":"[Sema] [gardening] Refactor diagnoseMemoryLayoutMigration [NFC]","user":{"login":"xwu","id":13952,"avatar_url":"https://avatars.githubusercontent.com/u/13952?v=3","gravatar_id":"","url":"https://api.github.com/users/xwu","html_url":"https://github.com/xwu","followers_url":"https://api.github.com/users/xwu/followers","following_url":"https://api.github.com/users/xwu/following{/other_user}","gists_url":"https://api.github.com/users/xwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu/subscriptions","organizations_url":"https://api.github.com/users/xwu/orgs","repos_url":"https://api.github.com/users/xwu/repos","events_url":"https://api.github.com/users/xwu/events{/privacy}","received_events_url":"https://api.github.com/users/xwu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"assignees":[{"login":"slavapestov","id":66486,"avatar_url":"https://avatars.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-08-29T03:26:54Z","updated_at":"2016-10-27T15:40:42Z","closed_at":"2016-10-27T05:48:41Z","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4541","html_url":"https://github.com/apple/swift/pull/4541","diff_url":"https://github.com/apple/swift/pull/4541.diff","patch_url":"https://github.com/apple/swift/pull/4541.patch"},"body":"During implementation of SE-0136 in #4041 (restoring `MemoryLayout.size(ofValue:)` and related methods), a chunk of the diagnostics for `MemoryLayout` migration interfered with the restored methods and were therefore removed.\r\n\r\nAlthough all functional changes were made in that PR, the diagnostics that remain could use some clean-up to remove unused plumbing. This PR provides that refactoring.\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/256680542","html_url":"https://github.com/apple/swift/pull/4541#issuecomment-256680542","issue_url":"https://api.github.com/repos/apple/swift/issues/4541","id":256680542,"user":{"login":"erg","id":27430,"avatar_url":"https://avatars.githubusercontent.com/u/27430?v=3","gravatar_id":"","url":"https://api.github.com/users/erg","html_url":"https://github.com/erg","followers_url":"https://api.github.com/users/erg/followers","following_url":"https://api.github.com/users/erg/following{/other_user}","gists_url":"https://api.github.com/users/erg/gists{/gist_id}","starred_url":"https://api.github.com/users/erg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erg/subscriptions","organizations_url":"https://api.github.com/users/erg/orgs","repos_url":"https://api.github.com/users/erg/repos","events_url":"https://api.github.com/users/erg/events{/privacy}","received_events_url":"https://api.github.com/users/erg/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T15:40:42Z","updated_at":"2016-10-27T15:40:42Z","body":"This was due to a change that has been fixed.\n\n\n> On Oct 26, 2016, at 6:22 PM, Slava Pestov <notifications@github.com> wrote:\n> \n> Looks like all builds are failing right now:\n> \n> b/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_posix.cc.o: In function `__sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)':\n> /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:362: multiple definition of `__sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)'\n> lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_linux.cc.o:/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:1393: first defined here\n> @shahmishal <https://github.com/shahmishal> Any ideas?\n> \n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub <https://github.com/apple/swift/pull/4541#issuecomment-256521881>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABrJt1qF3n_r8VW3FSTtIClO6A6hNVDks5q3_y5gaJpZM4JvHS3>.\n> \n\n"}}
{"actor":{"display_login":"erg"}}