{"action":"created","comment":{"url":"https://api.github.com/repos/repenaxa/node/pulls/comments/57985065","id":57985065,"diff_hunk":"@@ -4268,21 +4284,23 @@ int Start(int argc, char** argv) {\n \n   int exit_code = 1;\n   {\n-    uv_loop_t worker_loop;\n-    int rc = uv_loop_init(&worker_loop);\n-    CHECK_EQ(0, rc);\n-    // Remote debug server\n-    const char* argv2[] = { argv[0], \"--remote_debugging_server\" };\n-    NodeInstanceData worker_instance_data(NodeInstanceType::REMOTE_DEBUG_SERVER,\n-                                   &worker_loop,\n-                                   2, //argc,\n-                                   argv2, //const_cast<const char**>(argv),\n-                                   exec_argc,\n-                                   exec_argv,\n-                                   false);\n-    uv_thread_t worker_thread;\n-    rc = uv_thread_create(&worker_thread, &DevToolsRun, &worker_instance_data);\n-    CHECK_EQ(0, rc);\n+    if (use_devtools) {","path":"src/node.cc","position":74,"original_position":74,"commit_id":"6af6424650c8dd732f9779862d3818be8520d557","original_commit_id":"6af6424650c8dd732f9779862d3818be8520d557","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"(minor) Analogous to how debug-agent.cc is structured, it would be good to move this code, `DevToolsRun` (and possibly more) into node_debugger.cc.","created_at":"2016-03-31T00:17:38Z","updated_at":"2016-03-31T00:17:38Z","html_url":"https://github.com/repenaxa/node/pull/6#discussion_r57985065","pull_request_url":"https://api.github.com/repos/repenaxa/node/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/repenaxa/node/pulls/comments/57985065"},"html":{"href":"https://github.com/repenaxa/node/pull/6#discussion_r57985065"},"pull_request":{"href":"https://api.github.com/repos/repenaxa/node/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/repenaxa/node/pulls/6","id":63820714,"html_url":"https://github.com/repenaxa/node/pull/6","diff_url":"https://github.com/repenaxa/node/pull/6.diff","patch_url":"https://github.com/repenaxa/node/pull/6.patch","issue_url":"https://api.github.com/repos/repenaxa/node/issues/6","number":6,"state":"open","locked":false,"title":"Pause Node.js process UI connects","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2016-03-23T01:54:15Z","updated_at":"2016-03-31T00:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a79d638f3b7f55bb70c1d0f10a7bc417c24b127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/repenaxa/node/pulls/6/commits","review_comments_url":"https://api.github.com/repos/repenaxa/node/pulls/6/comments","review_comment_url":"https://api.github.com/repos/repenaxa/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/repenaxa/node/issues/6/comments","statuses_url":"https://api.github.com/repos/repenaxa/node/statuses/6af6424650c8dd732f9779862d3818be8520d557","head":{"label":"matthewloring:startup","ref":"startup","sha":"6af6424650c8dd732f9779862d3818be8520d557","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":38261750,"name":"io.js","full_name":"matthewloring/io.js","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/io.js","description":"Future Node.js releases will be based on io.js","fork":true,"url":"https://api.github.com/repos/matthewloring/io.js","forks_url":"https://api.github.com/repos/matthewloring/io.js/forks","keys_url":"https://api.github.com/repos/matthewloring/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/io.js/teams","hooks_url":"https://api.github.com/repos/matthewloring/io.js/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/io.js/events","assignees_url":"https://api.github.com/repos/matthewloring/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/io.js/tags","blobs_url":"https://api.github.com/repos/matthewloring/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/io.js/languages","stargazers_url":"https://api.github.com/repos/matthewloring/io.js/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/io.js/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/io.js/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/io.js/subscription","commits_url":"https://api.github.com/repos/matthewloring/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/io.js/merges","archive_url":"https://api.github.com/repos/matthewloring/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/io.js/downloads","issues_url":"https://api.github.com/repos/matthewloring/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/io.js/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/matthewloring/io.js/deployments","created_at":"2015-06-29T17:49:00Z","updated_at":"2016-01-19T17:17:45Z","pushed_at":"2016-03-28T17:39:50Z","git_url":"git://github.com/matthewloring/io.js.git","ssh_url":"git@github.com:matthewloring/io.js.git","clone_url":"https://github.com/matthewloring/io.js.git","svn_url":"https://github.com/matthewloring/io.js","homepage":"https://iojs.org","size":181679,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"repenaxa:v8_inspector","ref":"v8_inspector","sha":"9ee288ad676587d985096936df2ebc44fd2ed767","user":{"login":"repenaxa","id":883973,"avatar_url":"https://avatars.githubusercontent.com/u/883973?v=3","gravatar_id":"","url":"https://api.github.com/users/repenaxa","html_url":"https://github.com/repenaxa","followers_url":"https://api.github.com/users/repenaxa/followers","following_url":"https://api.github.com/users/repenaxa/following{/other_user}","gists_url":"https://api.github.com/users/repenaxa/gists{/gist_id}","starred_url":"https://api.github.com/users/repenaxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repenaxa/subscriptions","organizations_url":"https://api.github.com/users/repenaxa/orgs","repos_url":"https://api.github.com/users/repenaxa/repos","events_url":"https://api.github.com/users/repenaxa/events{/privacy}","received_events_url":"https://api.github.com/users/repenaxa/received_events","type":"User","site_admin":false},"repo":{"id":51238632,"name":"node","full_name":"repenaxa/node","owner":{"login":"repenaxa","id":883973,"avatar_url":"https://avatars.githubusercontent.com/u/883973?v=3","gravatar_id":"","url":"https://api.github.com/users/repenaxa","html_url":"https://github.com/repenaxa","followers_url":"https://api.github.com/users/repenaxa/followers","following_url":"https://api.github.com/users/repenaxa/following{/other_user}","gists_url":"https://api.github.com/users/repenaxa/gists{/gist_id}","starred_url":"https://api.github.com/users/repenaxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repenaxa/subscriptions","organizations_url":"https://api.github.com/users/repenaxa/orgs","repos_url":"https://api.github.com/users/repenaxa/repos","events_url":"https://api.github.com/users/repenaxa/events{/privacy}","received_events_url":"https://api.github.com/users/repenaxa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/repenaxa/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/repenaxa/node","forks_url":"https://api.github.com/repos/repenaxa/node/forks","keys_url":"https://api.github.com/repos/repenaxa/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/repenaxa/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/repenaxa/node/teams","hooks_url":"https://api.github.com/repos/repenaxa/node/hooks","issue_events_url":"https://api.github.com/repos/repenaxa/node/issues/events{/number}","events_url":"https://api.github.com/repos/repenaxa/node/events","assignees_url":"https://api.github.com/repos/repenaxa/node/assignees{/user}","branches_url":"https://api.github.com/repos/repenaxa/node/branches{/branch}","tags_url":"https://api.github.com/repos/repenaxa/node/tags","blobs_url":"https://api.github.com/repos/repenaxa/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/repenaxa/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/repenaxa/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/repenaxa/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/repenaxa/node/statuses/{sha}","languages_url":"https://api.github.com/repos/repenaxa/node/languages","stargazers_url":"https://api.github.com/repos/repenaxa/node/stargazers","contributors_url":"https://api.github.com/repos/repenaxa/node/contributors","subscribers_url":"https://api.github.com/repos/repenaxa/node/subscribers","subscription_url":"https://api.github.com/repos/repenaxa/node/subscription","commits_url":"https://api.github.com/repos/repenaxa/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/repenaxa/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/repenaxa/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/repenaxa/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/repenaxa/node/contents/{+path}","compare_url":"https://api.github.com/repos/repenaxa/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/repenaxa/node/merges","archive_url":"https://api.github.com/repos/repenaxa/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/repenaxa/node/downloads","issues_url":"https://api.github.com/repos/repenaxa/node/issues{/number}","pulls_url":"https://api.github.com/repos/repenaxa/node/pulls{/number}","milestones_url":"https://api.github.com/repos/repenaxa/node/milestones{/number}","notifications_url":"https://api.github.com/repos/repenaxa/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/repenaxa/node/labels{/name}","releases_url":"https://api.github.com/repos/repenaxa/node/releases{/id}","deployments_url":"https://api.github.com/repos/repenaxa/node/deployments","created_at":"2016-02-07T06:50:59Z","updated_at":"2016-02-29T17:40:28Z","pushed_at":"2016-03-28T17:39:51Z","git_url":"git://github.com/repenaxa/node.git","ssh_url":"git@github.com:repenaxa/node.git","clone_url":"https://github.com/repenaxa/node.git","svn_url":"https://github.com/repenaxa/node","homepage":"https://nodejs.org","size":186846,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"v8_inspector"}},"_links":{"self":{"href":"https://api.github.com/repos/repenaxa/node/pulls/6"},"html":{"href":"https://github.com/repenaxa/node/pull/6"},"issue":{"href":"https://api.github.com/repos/repenaxa/node/issues/6"},"comments":{"href":"https://api.github.com/repos/repenaxa/node/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/repenaxa/node/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/repenaxa/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/repenaxa/node/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/repenaxa/node/statuses/6af6424650c8dd732f9779862d3818be8520d557"}}}}