{"action":"closed","number":1804,"pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/1804","id":59273707,"html_url":"https://github.com/zeromq/libzmq/pull/1804","diff_url":"https://github.com/zeromq/libzmq/pull/1804.diff","patch_url":"https://github.com/zeromq/libzmq/pull/1804.patch","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/1804","number":1804,"state":"closed","locked":false,"title":"Various test fixes","user":{"login":"bluca","id":782193,"avatar_url":"https://avatars.githubusercontent.com/u/782193?v=3","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"body":"Refactored the tests to use a common approach for waiting for sockets to be settled after a connect. Currently it was a mix of sleep, usleep, msleep and zmq_poll. I think it's way cleaner and easier to always use msleep (SETTLE_TIME) everywhere, and also I documented that in the new tests/README.md.\r\n\r\nAlso a few tests didn't clean up after themselves, or didn't wait for settle at all, and others used uninitialised memory, which causes background noise when running in Valgrind.\r\n\r\nFinally, compilation is currently broken on OSX/CMake, as a pthread.h include was removed from test_shutdown_stress_tipc. Put it back in testutils.h.\r\n\r\nWith these changes, Valgrind's memcheck runs clean on all tests.","created_at":"2016-02-13T18:14:42Z","updated_at":"2016-02-13T18:15:32Z","closed_at":"2016-02-13T18:15:32Z","merged_at":null,"merge_commit_sha":"ef6b108ae0181fc659de1d3534dd40b0936720e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/libzmq/pulls/1804/commits","review_comments_url":"https://api.github.com/repos/zeromq/libzmq/pulls/1804/comments","review_comment_url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/1804/comments","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/217f6c438ed1937c011d504e0c0fdcb75ca0001a","head":{"label":"bluca:test_fixes","ref":"test_fixes","sha":"217f6c438ed1937c011d504e0c0fdcb75ca0001a","user":{"login":"bluca","id":782193,"avatar_url":"https://avatars.githubusercontent.com/u/782193?v=3","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"repo":{"id":39922024,"name":"libzmq","full_name":"bluca/libzmq","owner":{"login":"bluca","id":782193,"avatar_url":"https://avatars.githubusercontent.com/u/782193?v=3","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluca/libzmq","description":"ZeroMQ core engine in C++","fork":true,"url":"https://api.github.com/repos/bluca/libzmq","forks_url":"https://api.github.com/repos/bluca/libzmq/forks","keys_url":"https://api.github.com/repos/bluca/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluca/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluca/libzmq/teams","hooks_url":"https://api.github.com/repos/bluca/libzmq/hooks","issue_events_url":"https://api.github.com/repos/bluca/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/bluca/libzmq/events","assignees_url":"https://api.github.com/repos/bluca/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/bluca/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/bluca/libzmq/tags","blobs_url":"https://api.github.com/repos/bluca/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluca/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluca/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluca/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluca/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/bluca/libzmq/languages","stargazers_url":"https://api.github.com/repos/bluca/libzmq/stargazers","contributors_url":"https://api.github.com/repos/bluca/libzmq/contributors","subscribers_url":"https://api.github.com/repos/bluca/libzmq/subscribers","subscription_url":"https://api.github.com/repos/bluca/libzmq/subscription","commits_url":"https://api.github.com/repos/bluca/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluca/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluca/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluca/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluca/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/bluca/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluca/libzmq/merges","archive_url":"https://api.github.com/repos/bluca/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluca/libzmq/downloads","issues_url":"https://api.github.com/repos/bluca/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/bluca/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/bluca/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/bluca/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluca/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/bluca/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/bluca/libzmq/deployments","created_at":"2015-07-30T00:00:03Z","updated_at":"2015-07-30T00:00:05Z","pushed_at":"2016-02-13T18:07:16Z","git_url":"git://github.com/bluca/libzmq.git","ssh_url":"git@github.com:bluca/libzmq.git","clone_url":"https://github.com/bluca/libzmq.git","svn_url":"https://github.com/bluca/libzmq","homepage":"http://www.zeromq.org","size":15151,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"18dcc32ac3ad0e3b0d89429b61c4c27e4d424520","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":263379,"name":"libzmq","full_name":"zeromq/libzmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.0","fork":false,"url":"https://api.github.com/repos/zeromq/libzmq","forks_url":"https://api.github.com/repos/zeromq/libzmq/forks","keys_url":"https://api.github.com/repos/zeromq/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/libzmq/teams","hooks_url":"https://api.github.com/repos/zeromq/libzmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/libzmq/events","assignees_url":"https://api.github.com/repos/zeromq/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/libzmq/tags","blobs_url":"https://api.github.com/repos/zeromq/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/libzmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/libzmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/libzmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/libzmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/libzmq/subscription","commits_url":"https://api.github.com/repos/zeromq/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/libzmq/merges","archive_url":"https://api.github.com/repos/zeromq/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/libzmq/downloads","issues_url":"https://api.github.com/repos/zeromq/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/zeromq/libzmq/deployments","created_at":"2009-07-29T09:56:41Z","updated_at":"2016-02-13T15:24:45Z","pushed_at":"2016-02-13T18:14:42Z","git_url":"git://github.com/zeromq/libzmq.git","ssh_url":"git@github.com:zeromq/libzmq.git","clone_url":"https://github.com/zeromq/libzmq.git","svn_url":"https://github.com/zeromq/libzmq","homepage":"http://www.zeromq.org","size":17043,"stargazers_count":2280,"watchers_count":2280,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":719,"mirror_url":null,"open_issues_count":172,"forks":719,"open_issues":172,"watchers":2280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1804"},"html":{"href":"https://github.com/zeromq/libzmq/pull/1804"},"issue":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/1804"},"comments":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/1804/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1804/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1804/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/libzmq/statuses/217f6c438ed1937c011d504e0c0fdcb75ca0001a"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":13,"additions":91,"deletions":76,"changed_files":24}}