{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/51672844","id":51672844,"diff_hunk":"@@ -417,6 +423,10 @@ object KafkaConfig {\n   val NumRecoveryThreadsPerDataDirDoc = \"The number of threads per data directory to be used for log recovery at startup and flushing at shutdown\"\n   val AutoCreateTopicsEnableDoc = \"Enable auto creation of topic on the server\"\n   val MinInSyncReplicasDoc = \"define the minimum number of replicas in ISR needed to satisfy a produce request with acks=all (or -1)\"\n+  val MessageFormatVersionDoc = \"Specify the message format version the broker will use to append messages to the logs.\"","path":"core/src/main/scala/kafka/server/KafkaConfig.scala","position":30,"original_position":30,"commit_id":"c44c6b5f6680885bbc7ec693713eb3187dd8a604","original_commit_id":"391acc0aa1535c8d83893da0399b1df260f74aac","user":{"login":"junrao","id":132330,"avatar_url":"https://avatars.githubusercontent.com/u/132330?v=3","gravatar_id":"","url":"https://api.github.com/users/junrao","html_url":"https://github.com/junrao","followers_url":"https://api.github.com/users/junrao/followers","following_url":"https://api.github.com/users/junrao/following{/other_user}","gists_url":"https://api.github.com/users/junrao/gists{/gist_id}","starred_url":"https://api.github.com/users/junrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junrao/subscriptions","organizations_url":"https://api.github.com/users/junrao/orgs","repos_url":"https://api.github.com/users/junrao/repos","events_url":"https://api.github.com/users/junrao/events{/privacy}","received_events_url":"https://api.github.com/users/junrao/received_events","type":"User","site_admin":false},"body":"Right, we can use sth like v0, v1 to make it consistent.","created_at":"2016-02-03T02:57:49Z","updated_at":"2016-02-03T02:57:49Z","html_url":"https://github.com/apache/kafka/pull/764#discussion_r51672844","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/764","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/51672844"},"html":{"href":"https://github.com/apache/kafka/pull/764#discussion_r51672844"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/764","id":55900829,"html_url":"https://github.com/apache/kafka/pull/764","diff_url":"https://github.com/apache/kafka/pull/764.diff","patch_url":"https://github.com/apache/kafka/pull/764.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/764","number":764,"state":"open","locked":false,"title":"KAFKA-3025 Added timetamp to Message and use relative offset.","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"body":"See KIP-31 and KIP-32 for details.\r\n\r\nA few notes on the patch:\r\n1. This patch implements KIP-31 and KIP-32. The patch includes features in both KAFKA-3025,  KAFKA-3026 and KAFKA-3036\r\n2. All unit tests passed.\r\n3. The unit tests were run with new and old message format.\r\n4. When message format conversion occurs during consumption, the consumer will not be able to detect the message size too large situation. I did not try to fix this because the situation seems rare and only happen during migration phase.\r\n","created_at":"2016-01-13T14:03:13Z","updated_at":"2016-02-03T02:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ce3c2e74252e24fd52406e5eca89dc5600a4f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/764/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/764/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/764/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/c44c6b5f6680885bbc7ec693713eb3187dd8a604","head":{"label":"becketqin:KAFKA-3025","ref":"KAFKA-3025","sha":"c44c6b5f6680885bbc7ec693713eb3187dd8a604","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"repo":{"id":21048134,"name":"kafka","full_name":"becketqin/kafka","owner":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/becketqin/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/becketqin/kafka","forks_url":"https://api.github.com/repos/becketqin/kafka/forks","keys_url":"https://api.github.com/repos/becketqin/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/becketqin/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/becketqin/kafka/teams","hooks_url":"https://api.github.com/repos/becketqin/kafka/hooks","issue_events_url":"https://api.github.com/repos/becketqin/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/becketqin/kafka/events","assignees_url":"https://api.github.com/repos/becketqin/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/becketqin/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/becketqin/kafka/tags","blobs_url":"https://api.github.com/repos/becketqin/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/becketqin/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/becketqin/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/becketqin/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/becketqin/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/becketqin/kafka/languages","stargazers_url":"https://api.github.com/repos/becketqin/kafka/stargazers","contributors_url":"https://api.github.com/repos/becketqin/kafka/contributors","subscribers_url":"https://api.github.com/repos/becketqin/kafka/subscribers","subscription_url":"https://api.github.com/repos/becketqin/kafka/subscription","commits_url":"https://api.github.com/repos/becketqin/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/becketqin/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/becketqin/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/becketqin/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/becketqin/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/becketqin/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/becketqin/kafka/merges","archive_url":"https://api.github.com/repos/becketqin/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/becketqin/kafka/downloads","issues_url":"https://api.github.com/repos/becketqin/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/becketqin/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/becketqin/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/becketqin/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/becketqin/kafka/labels{/name}","releases_url":"https://api.github.com/repos/becketqin/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/becketqin/kafka/deployments","created_at":"2014-06-20T18:28:55Z","updated_at":"2014-06-20T18:28:55Z","pushed_at":"2016-02-03T00:22:56Z","git_url":"git://github.com/becketqin/kafka.git","ssh_url":"git@github.com:becketqin/kafka.git","clone_url":"https://github.com/becketqin/kafka.git","svn_url":"https://github.com/becketqin/kafka","homepage":null,"size":26906,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"79cda0472b8e3af915c45daca9cce82d7c964182","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-02-03T01:55:49Z","pushed_at":"2016-02-03T02:29:48Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":34603,"stargazers_count":2594,"watchers_count":2594,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1544,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":118,"forks":1544,"open_issues":118,"watchers":2594,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/764"},"html":{"href":"https://github.com/apache/kafka/pull/764"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/764"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/c44c6b5f6680885bbc7ec693713eb3187dd8a604"}}}}