{"action":"closed","number":2032,"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032","id":19256027,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/2032","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/2032.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/2032.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/2032","number":2032,"state":"closed","locked":false,"title":"[*] FO Dynamically get excluded_key in FrontController->canonicalRedirection()","user":{"login":"zimmi1","id":4647640,"avatar_url":"https://avatars.githubusercontent.com/u/4647640?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmi1","html_url":"https://github.com/zimmi1","followers_url":"https://api.github.com/users/zimmi1/followers","following_url":"https://api.github.com/users/zimmi1/following{/other_user}","gists_url":"https://api.github.com/users/zimmi1/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmi1/subscriptions","organizations_url":"https://api.github.com/users/zimmi1/orgs","repos_url":"https://api.github.com/users/zimmi1/repos","events_url":"https://api.github.com/users/zimmi1/events{/privacy}","received_events_url":"https://api.github.com/users/zimmi1/received_events","type":"User","site_admin":false},"body":"May be example will be easier to undersand: if you go to example.com/fr/content/category/1-hoooome, you are redirected to example.com/fr/content/category/1-home?id_cms_category=1, because id_cms_category is not in the excluded_key array. Better is it to fill this excluded_key array dynamically, especially as now there is also the possibility for module to define custom routes through hookModuleRoutes, which may contain any kind of parameters, that shouldn't appear again in canonical url. I'm quite sure of the idea, but quite unsure of the way I've done it... especially I do not knwo how it will behave with multishop feature on. Hope it can help!","created_at":"2014-08-03T14:18:44Z","updated_at":"2016-03-02T14:14:29Z","closed_at":"2016-03-02T14:14:29Z","merged_at":null,"merge_commit_sha":"fc09c259c19e7ad8b3410f67c3aa3fe7d4a03168","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/2032/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/305b42794816f21cd83e03f324a968f28bdc238b","head":{"label":"zimmi1:1.6","ref":"1.6","sha":"305b42794816f21cd83e03f324a968f28bdc238b","user":{"login":"zimmi1","id":4647640,"avatar_url":"https://avatars.githubusercontent.com/u/4647640?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmi1","html_url":"https://github.com/zimmi1","followers_url":"https://api.github.com/users/zimmi1/followers","following_url":"https://api.github.com/users/zimmi1/following{/other_user}","gists_url":"https://api.github.com/users/zimmi1/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmi1/subscriptions","organizations_url":"https://api.github.com/users/zimmi1/orgs","repos_url":"https://api.github.com/users/zimmi1/repos","events_url":"https://api.github.com/users/zimmi1/events{/privacy}","received_events_url":"https://api.github.com/users/zimmi1/received_events","type":"User","site_admin":false},"repo":{"id":10568156,"name":"PrestaShop","full_name":"zimmi1/PrestaShop","owner":{"login":"zimmi1","id":4647640,"avatar_url":"https://avatars.githubusercontent.com/u/4647640?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmi1","html_url":"https://github.com/zimmi1","followers_url":"https://api.github.com/users/zimmi1/followers","following_url":"https://api.github.com/users/zimmi1/following{/other_user}","gists_url":"https://api.github.com/users/zimmi1/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmi1/subscriptions","organizations_url":"https://api.github.com/users/zimmi1/orgs","repos_url":"https://api.github.com/users/zimmi1/repos","events_url":"https://api.github.com/users/zimmi1/events{/privacy}","received_events_url":"https://api.github.com/users/zimmi1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimmi1/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/zimmi1/PrestaShop","forks_url":"https://api.github.com/repos/zimmi1/PrestaShop/forks","keys_url":"https://api.github.com/repos/zimmi1/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimmi1/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimmi1/PrestaShop/teams","hooks_url":"https://api.github.com/repos/zimmi1/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/zimmi1/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/zimmi1/PrestaShop/events","assignees_url":"https://api.github.com/repos/zimmi1/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/zimmi1/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/zimmi1/PrestaShop/tags","blobs_url":"https://api.github.com/repos/zimmi1/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimmi1/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimmi1/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimmi1/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimmi1/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/zimmi1/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/zimmi1/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/zimmi1/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/zimmi1/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/zimmi1/PrestaShop/subscription","commits_url":"https://api.github.com/repos/zimmi1/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimmi1/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimmi1/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimmi1/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimmi1/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/zimmi1/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimmi1/PrestaShop/merges","archive_url":"https://api.github.com/repos/zimmi1/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimmi1/PrestaShop/downloads","issues_url":"https://api.github.com/repos/zimmi1/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/zimmi1/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/zimmi1/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/zimmi1/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimmi1/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/zimmi1/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/zimmi1/PrestaShop/deployments","created_at":"2013-06-08T12:14:07Z","updated_at":"2014-08-01T16:25:54Z","pushed_at":"2015-11-20T14:23:00Z","git_url":"git://github.com/zimmi1/PrestaShop.git","ssh_url":"git@github.com:zimmi1/PrestaShop.git","clone_url":"https://github.com/zimmi1/PrestaShop.git","svn_url":"https://github.com/zimmi1/PrestaShop","homepage":"http://www.prestashop.com/","size":215445,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrestaShop:1.6","ref":"1.6","sha":"f93afeb59c60c2a6cff4b6c3fecc06379522185a","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2016-03-02T09:17:46Z","pushed_at":"2016-03-02T13:15:52Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":262739,"stargazers_count":1664,"watchers_count":1664,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1818,"mirror_url":null,"open_issues_count":411,"forks":1818,"open_issues":411,"watchers":1664,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/2032"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/2032"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/2032/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/2032/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/305b42794816f21cd83e03f324a968f28bdc238b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":21,"deletions":1,"changed_files":2}}