{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments/74340606","id":74340606,"diff_hunk":"@@ -0,0 +1,81 @@\n+sudo: required","path":".travis.yml","position":1,"original_position":1,"commit_id":"da0cb969d0bc463e9e7aaf347c23a34b50c326a0","original_commit_id":"da0cb969d0bc463e9e7aaf347c23a34b50c326a0","user":{"login":"agentzh","id":56241,"avatar_url":"https://avatars.githubusercontent.com/u/56241?v=3","gravatar_id":"","url":"https://api.github.com/users/agentzh","html_url":"https://github.com/agentzh","followers_url":"https://api.github.com/users/agentzh/followers","following_url":"https://api.github.com/users/agentzh/following{/other_user}","gists_url":"https://api.github.com/users/agentzh/gists{/gist_id}","starred_url":"https://api.github.com/users/agentzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentzh/subscriptions","organizations_url":"https://api.github.com/users/agentzh/orgs","repos_url":"https://api.github.com/users/agentzh/repos","events_url":"https://api.github.com/users/agentzh/events{/privacy}","received_events_url":"https://api.github.com/users/agentzh/received_events","type":"User","site_admin":false},"body":"The git master branch already has this file. Please rebase to it.","created_at":"2016-08-10T22:09:49Z","updated_at":"2016-08-10T22:09:49Z","html_url":"https://github.com/openresty/stream-lua-nginx-module/pull/30#discussion_r74340606","pull_request_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments/74340606"},"html":{"href":"https://github.com/openresty/stream-lua-nginx-module/pull/30#discussion_r74340606"},"pull_request":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30","id":80718929,"html_url":"https://github.com/openresty/stream-lua-nginx-module/pull/30","diff_url":"https://github.com/openresty/stream-lua-nginx-module/pull/30.diff","patch_url":"https://github.com/openresty/stream-lua-nginx-module/pull/30.patch","issue_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/30","number":30,"state":"open","locked":false,"title":"balancer_by_lua for streams","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"Hi @agentzh \r\n here is the PR for balancer_by_lua based on @splitice's work (https://github.com/openresty/stream-lua-nginx-module/pull/7).\r\n\r\nChanges on top of his commits:\r\n * Fixed styling issues reported by ngx-style.pl\r\n * Fixed bugs in the test suite (t/138-balancer.t that was ported from ngx_http_lua_module)\r\n\r\n The tests pertaining to balancer_by_lua are passing: https://travis-ci.org/rshriram/stream-lua-nginx-module/jobs/151088688\r\n However, an unrelated test suite (069-null.t) is failing due to missing dependency cjson.lua.\r\n If you want me to remove the `.travis.yml` file let me know. Somehow, GH seems to show that the `.travis.yml` is a new addition to your existing repo.\r\n\r\n*Note*: I found that ngx.exit does not work inside the balancer_by_lua block. It throws an exception saying `attempt to yield across C-call boundary`. Given that this is a TCP stream block, ngx.exit does not really make sense, and so the above error seems like a valid one. I added a test to this effect. However, this behavior is not documented in the main README.","created_at":"2016-08-10T00:49:49Z","updated_at":"2016-08-10T22:09:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d2ca3e7ad2c659b8c1007b6f513e71a88d37bc2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30/commits","review_comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30/comments","review_comment_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/30/comments","statuses_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/da0cb969d0bc463e9e7aaf347c23a34b50c326a0","head":{"label":"rshriram:master","ref":"master","sha":"da0cb969d0bc463e9e7aaf347c23a34b50c326a0","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"repo":{"id":65293567,"name":"stream-lua-nginx-module","full_name":"rshriram/stream-lua-nginx-module","owner":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rshriram/stream-lua-nginx-module","description":"Embed the power of Lua into NGINX stream/TCP servers","fork":true,"url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module","forks_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/forks","keys_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/events","assignees_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/merges","archive_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/rshriram/stream-lua-nginx-module/deployments","created_at":"2016-08-09T12:35:07Z","updated_at":"2016-08-09T12:35:24Z","pushed_at":"2016-08-10T00:30:28Z","git_url":"git://github.com/rshriram/stream-lua-nginx-module.git","ssh_url":"git@github.com:rshriram/stream-lua-nginx-module.git","clone_url":"https://github.com/rshriram/stream-lua-nginx-module.git","svn_url":"https://github.com/rshriram/stream-lua-nginx-module","homepage":null,"size":474,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"6ed0a0e52064e482af7eb9c40b1bdb3ba4d0d922","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":49554190,"name":"stream-lua-nginx-module","full_name":"openresty/stream-lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/stream-lua-nginx-module","description":"Embed the power of Lua into NGINX TCP servers","fork":false,"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/deployments","created_at":"2016-01-13T06:23:38Z","updated_at":"2016-08-10T12:07:13Z","pushed_at":"2016-08-10T22:01:31Z","git_url":"git://github.com/openresty/stream-lua-nginx-module.git","ssh_url":"git@github.com:openresty/stream-lua-nginx-module.git","clone_url":"https://github.com/openresty/stream-lua-nginx-module.git","svn_url":"https://github.com/openresty/stream-lua-nginx-module","homepage":"","size":470,"stargazers_count":165,"watchers_count":165,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":9,"forks":35,"open_issues":9,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30"},"html":{"href":"https://github.com/openresty/stream-lua-nginx-module/pull/30"},"issue":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/30"},"comments":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/da0cb969d0bc463e9e7aaf347c23a34b50c326a0"}}}}
{"actor":{"display_login":"agentzh"}}