{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/2007","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/2007/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/2007/comments","events_url":"https://api.github.com/repos/apache/flink/issues/2007/events","html_url":"https://github.com/apache/flink/pull/2007","id":155694877,"number":2007,"title":"[FLINK-3908] Fixed Parser's error state reset","user":{"login":"fpompermaier","id":3776037,"avatar_url":"https://avatars.githubusercontent.com/u/3776037?v=3","gravatar_id":"","url":"https://api.github.com/users/fpompermaier","html_url":"https://github.com/fpompermaier","followers_url":"https://api.github.com/users/fpompermaier/followers","following_url":"https://api.github.com/users/fpompermaier/following{/other_user}","gists_url":"https://api.github.com/users/fpompermaier/gists{/gist_id}","starred_url":"https://api.github.com/users/fpompermaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpompermaier/subscriptions","organizations_url":"https://api.github.com/users/fpompermaier/orgs","repos_url":"https://api.github.com/users/fpompermaier/repos","events_url":"https://api.github.com/users/fpompermaier/events{/privacy}","received_events_url":"https://api.github.com/users/fpompermaier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-19T09:42:33Z","updated_at":"2016-05-26T12:55:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2007","html_url":"https://github.com/apache/flink/pull/2007","diff_url":"https://github.com/apache/flink/pull/2007.diff","patch_url":"https://github.com/apache/flink/pull/2007.patch"},"body":"Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.\r\nIf your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).\r\nIn addition to going through the list, please provide a meaningful description of your changes.\r\n\r\n- [X] General\r\n  - The pull request references the related JIRA issue (\"[FLINK-XXX] Jira title text\")\r\n  - The pull request addresses only one issue\r\n  - Each commit in the PR has a meaningful commit message (including the JIRA id)\r\n\r\n- [X] Documentation\r\n  - Documentation has been added for new functionality\r\n  - Old documentation affected by the pull request has been updated\r\n  - JavaDoc for public methods has been added\r\n\r\n- [X] Tests & Build\r\n  - Functionality added by the pull request is covered by tests\r\n  - `mvn clean verify` has been executed successfully locally or a Travis build has passed\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/221862570","html_url":"https://github.com/apache/flink/pull/2007#issuecomment-221862570","issue_url":"https://api.github.com/repos/apache/flink/issues/2007","id":221862570,"user":{"login":"fpompermaier","id":3776037,"avatar_url":"https://avatars.githubusercontent.com/u/3776037?v=3","gravatar_id":"","url":"https://api.github.com/users/fpompermaier","html_url":"https://github.com/fpompermaier","followers_url":"https://api.github.com/users/fpompermaier/followers","following_url":"https://api.github.com/users/fpompermaier/following{/other_user}","gists_url":"https://api.github.com/users/fpompermaier/gists{/gist_id}","starred_url":"https://api.github.com/users/fpompermaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpompermaier/subscriptions","organizations_url":"https://api.github.com/users/fpompermaier/orgs","repos_url":"https://api.github.com/users/fpompermaier/repos","events_url":"https://api.github.com/users/fpompermaier/events{/privacy}","received_events_url":"https://api.github.com/users/fpompermaier/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T12:55:19Z","updated_at":"2016-05-26T12:55:19Z","body":"Hi Stephan, thanks for reviewing this PR.\r\nThese are my reasons to not apply your suggestions to my PR, and I'd like to hear your opinion (anyone interested by this discussion is also welcome) before reissuing the PR with such modifications:\r\n\r\n- rename `reset` to `resetErrorStateAndParse`: for almost all parsers this doesn't do anything more than those 2 operations but what if for a further parserImpl you need to do anything else before parsing? \r\n- resetting the error state is something that must always be done, by all parser implementations. The `parseFieldImpl` is a way to force this thing, otherwise you should rely on classes using such parser to remember this thing (as you suggested with \"GenericCsvInputCormat would call the resetErrorStateAndParse\") or ensure that every parser call it at the very beginning of the `parseField()`.\r\nI'm really concerned about this. In this way, my PR doesn't break the current APIs\r\n\r\nDoes it makes sense?\r\n"}}
{"actor":{"display_login":"fpompermaier"}}