{"action":"created","comment":{"url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/comments/71703740","id":71703740,"diff_hunk":"@@ -0,0 +1,18 @@\n+// -----------------------------------------------------------------------------\n+// COMPONENTS\n+// -----------------------------------------------------------------------------\n+\n+@import 'components.buttons',","path":"core/static_src/scss/components/_index.scss","position":5,"original_position":5,"commit_id":"776cce1f5b7e7192d496464593b8bef6e1f4554b","original_commit_id":"776cce1f5b7e7192d496464593b8bef6e1f4554b","user":{"login":"ThibWeb","id":877585,"avatar_url":"https://avatars.githubusercontent.com/u/877585?v=3","gravatar_id":"","url":"https://api.github.com/users/ThibWeb","html_url":"https://github.com/ThibWeb","followers_url":"https://api.github.com/users/ThibWeb/followers","following_url":"https://api.github.com/users/ThibWeb/following{/other_user}","gists_url":"https://api.github.com/users/ThibWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/ThibWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThibWeb/subscriptions","organizations_url":"https://api.github.com/users/ThibWeb/orgs","repos_url":"https://api.github.com/users/ThibWeb/repos","events_url":"https://api.github.com/users/ThibWeb/events{/privacy}","received_events_url":"https://api.github.com/users/ThibWeb/received_events","type":"User","site_admin":false},"body":"I would suggest having an import statement per line:\r\n\r\n```sass\r\n@import 'components.buttons';\r\n@import 'components.button-groups';\r\n[...]\r\n```\r\n\r\nThis makes it slightly easier to add/remove items to that list of import: you only ever touch the lines you actually want to change (here we'd have to alter multiple lines in order to add something right at the top of the list, or right at the bottom). It's the same reason we use comma-dangles for arrays and objects in JS, and declare variables in multiple lines instead of single `var`/`const` statements.","created_at":"2016-07-21T13:24:57Z","updated_at":"2016-07-21T13:24:57Z","html_url":"https://github.com/springload/frontend-starter-kit/pull/12#discussion_r71703740","pull_request_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/comments/71703740"},"html":{"href":"https://github.com/springload/frontend-starter-kit/pull/12#discussion_r71703740"},"pull_request":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12","id":78291069,"html_url":"https://github.com/springload/frontend-starter-kit/pull/12","diff_url":"https://github.com/springload/frontend-starter-kit/pull/12.diff","patch_url":"https://github.com/springload/frontend-starter-kit/pull/12.patch","issue_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/12","number":12,"state":"open","locked":false,"title":"Feature/itcss restructure","user":{"login":"JoshBarr","id":1715456,"avatar_url":"https://avatars.githubusercontent.com/u/1715456?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBarr","html_url":"https://github.com/JoshBarr","followers_url":"https://api.github.com/users/JoshBarr/followers","following_url":"https://api.github.com/users/JoshBarr/following{/other_user}","gists_url":"https://api.github.com/users/JoshBarr/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBarr/subscriptions","organizations_url":"https://api.github.com/users/JoshBarr/orgs","repos_url":"https://api.github.com/users/JoshBarr/repos","events_url":"https://api.github.com/users/JoshBarr/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBarr/received_events","type":"User","site_admin":false},"body":"Opening a PR for the discussion about this proposed change.\r\n\r\n- I think it's a good idea to consolidate itcss + scss into one directory. \r\n- standardising on `scss` instead of `sass` is good. \r\n- following the atomic structure with index files is a good way to tame the ITCSS.\r\n- there's a lot of moving files around. We should squash all the commits to keep the project history clean.\r\n\r\n@samanthaksanders what else needs to be resolved to merge this in?","created_at":"2016-07-21T10:16:58Z","updated_at":"2016-07-21T13:24:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed70f865e429f2532051b9b9ce0d5ff3e16fbb09","assignee":{"login":"samanthaksanders","id":1756527,"avatar_url":"https://avatars.githubusercontent.com/u/1756527?v=3","gravatar_id":"","url":"https://api.github.com/users/samanthaksanders","html_url":"https://github.com/samanthaksanders","followers_url":"https://api.github.com/users/samanthaksanders/followers","following_url":"https://api.github.com/users/samanthaksanders/following{/other_user}","gists_url":"https://api.github.com/users/samanthaksanders/gists{/gist_id}","starred_url":"https://api.github.com/users/samanthaksanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanthaksanders/subscriptions","organizations_url":"https://api.github.com/users/samanthaksanders/orgs","repos_url":"https://api.github.com/users/samanthaksanders/repos","events_url":"https://api.github.com/users/samanthaksanders/events{/privacy}","received_events_url":"https://api.github.com/users/samanthaksanders/received_events","type":"User","site_admin":false},"assignees":[{"login":"samanthaksanders","id":1756527,"avatar_url":"https://avatars.githubusercontent.com/u/1756527?v=3","gravatar_id":"","url":"https://api.github.com/users/samanthaksanders","html_url":"https://github.com/samanthaksanders","followers_url":"https://api.github.com/users/samanthaksanders/followers","following_url":"https://api.github.com/users/samanthaksanders/following{/other_user}","gists_url":"https://api.github.com/users/samanthaksanders/gists{/gist_id}","starred_url":"https://api.github.com/users/samanthaksanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanthaksanders/subscriptions","organizations_url":"https://api.github.com/users/samanthaksanders/orgs","repos_url":"https://api.github.com/users/samanthaksanders/repos","events_url":"https://api.github.com/users/samanthaksanders/events{/privacy}","received_events_url":"https://api.github.com/users/samanthaksanders/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12/commits","review_comments_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12/comments","review_comment_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/12/comments","statuses_url":"https://api.github.com/repos/springload/frontend-starter-kit/statuses/776cce1f5b7e7192d496464593b8bef6e1f4554b","head":{"label":"springload:feature/itcss-restructure","ref":"feature/itcss-restructure","sha":"776cce1f5b7e7192d496464593b8bef6e1f4554b","user":{"login":"springload","id":1691454,"avatar_url":"https://avatars.githubusercontent.com/u/1691454?v=3","gravatar_id":"","url":"https://api.github.com/users/springload","html_url":"https://github.com/springload","followers_url":"https://api.github.com/users/springload/followers","following_url":"https://api.github.com/users/springload/following{/other_user}","gists_url":"https://api.github.com/users/springload/gists{/gist_id}","starred_url":"https://api.github.com/users/springload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springload/subscriptions","organizations_url":"https://api.github.com/users/springload/orgs","repos_url":"https://api.github.com/users/springload/repos","events_url":"https://api.github.com/users/springload/events{/privacy}","received_events_url":"https://api.github.com/users/springload/received_events","type":"Organization","site_admin":false},"repo":{"id":26238415,"name":"frontend-starter-kit","full_name":"springload/frontend-starter-kit","owner":{"login":"springload","id":1691454,"avatar_url":"https://avatars.githubusercontent.com/u/1691454?v=3","gravatar_id":"","url":"https://api.github.com/users/springload","html_url":"https://github.com/springload","followers_url":"https://api.github.com/users/springload/followers","following_url":"https://api.github.com/users/springload/following{/other_user}","gists_url":"https://api.github.com/users/springload/gists{/gist_id}","starred_url":"https://api.github.com/users/springload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springload/subscriptions","organizations_url":"https://api.github.com/users/springload/orgs","repos_url":"https://api.github.com/users/springload/repos","events_url":"https://api.github.com/users/springload/events{/privacy}","received_events_url":"https://api.github.com/users/springload/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springload/frontend-starter-kit","description":"CSS component framework, take two.","fork":false,"url":"https://api.github.com/repos/springload/frontend-starter-kit","forks_url":"https://api.github.com/repos/springload/frontend-starter-kit/forks","keys_url":"https://api.github.com/repos/springload/frontend-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springload/frontend-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springload/frontend-starter-kit/teams","hooks_url":"https://api.github.com/repos/springload/frontend-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/springload/frontend-starter-kit/events","assignees_url":"https://api.github.com/repos/springload/frontend-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/springload/frontend-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/springload/frontend-starter-kit/tags","blobs_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springload/frontend-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/springload/frontend-starter-kit/languages","stargazers_url":"https://api.github.com/repos/springload/frontend-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/springload/frontend-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/springload/frontend-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/springload/frontend-starter-kit/subscription","commits_url":"https://api.github.com/repos/springload/frontend-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/springload/frontend-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/springload/frontend-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/springload/frontend-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springload/frontend-starter-kit/merges","archive_url":"https://api.github.com/repos/springload/frontend-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springload/frontend-starter-kit/downloads","issues_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/springload/frontend-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/springload/frontend-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springload/frontend-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/springload/frontend-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/springload/frontend-starter-kit/deployments","created_at":"2014-11-05T20:32:10Z","updated_at":"2016-07-04T07:02:23Z","pushed_at":"2016-07-21T10:16:58Z","git_url":"git://github.com/springload/frontend-starter-kit.git","ssh_url":"git@github.com:springload/frontend-starter-kit.git","clone_url":"https://github.com/springload/frontend-starter-kit.git","svn_url":"https://github.com/springload/frontend-starter-kit","homepage":"http://www.springload.co.nz/blog/a-stable-front-end-stack-for-2016/","size":477,"stargazers_count":8,"watchers_count":8,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"springload:master","ref":"master","sha":"3af4be23c4a2107d18ab1a13094361456e583c1f","user":{"login":"springload","id":1691454,"avatar_url":"https://avatars.githubusercontent.com/u/1691454?v=3","gravatar_id":"","url":"https://api.github.com/users/springload","html_url":"https://github.com/springload","followers_url":"https://api.github.com/users/springload/followers","following_url":"https://api.github.com/users/springload/following{/other_user}","gists_url":"https://api.github.com/users/springload/gists{/gist_id}","starred_url":"https://api.github.com/users/springload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springload/subscriptions","organizations_url":"https://api.github.com/users/springload/orgs","repos_url":"https://api.github.com/users/springload/repos","events_url":"https://api.github.com/users/springload/events{/privacy}","received_events_url":"https://api.github.com/users/springload/received_events","type":"Organization","site_admin":false},"repo":{"id":26238415,"name":"frontend-starter-kit","full_name":"springload/frontend-starter-kit","owner":{"login":"springload","id":1691454,"avatar_url":"https://avatars.githubusercontent.com/u/1691454?v=3","gravatar_id":"","url":"https://api.github.com/users/springload","html_url":"https://github.com/springload","followers_url":"https://api.github.com/users/springload/followers","following_url":"https://api.github.com/users/springload/following{/other_user}","gists_url":"https://api.github.com/users/springload/gists{/gist_id}","starred_url":"https://api.github.com/users/springload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springload/subscriptions","organizations_url":"https://api.github.com/users/springload/orgs","repos_url":"https://api.github.com/users/springload/repos","events_url":"https://api.github.com/users/springload/events{/privacy}","received_events_url":"https://api.github.com/users/springload/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springload/frontend-starter-kit","description":"CSS component framework, take two.","fork":false,"url":"https://api.github.com/repos/springload/frontend-starter-kit","forks_url":"https://api.github.com/repos/springload/frontend-starter-kit/forks","keys_url":"https://api.github.com/repos/springload/frontend-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springload/frontend-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springload/frontend-starter-kit/teams","hooks_url":"https://api.github.com/repos/springload/frontend-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/springload/frontend-starter-kit/events","assignees_url":"https://api.github.com/repos/springload/frontend-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/springload/frontend-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/springload/frontend-starter-kit/tags","blobs_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springload/frontend-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/springload/frontend-starter-kit/languages","stargazers_url":"https://api.github.com/repos/springload/frontend-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/springload/frontend-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/springload/frontend-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/springload/frontend-starter-kit/subscription","commits_url":"https://api.github.com/repos/springload/frontend-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/springload/frontend-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/springload/frontend-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/springload/frontend-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/springload/frontend-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springload/frontend-starter-kit/merges","archive_url":"https://api.github.com/repos/springload/frontend-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springload/frontend-starter-kit/downloads","issues_url":"https://api.github.com/repos/springload/frontend-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/springload/frontend-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/springload/frontend-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/springload/frontend-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springload/frontend-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/springload/frontend-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/springload/frontend-starter-kit/deployments","created_at":"2014-11-05T20:32:10Z","updated_at":"2016-07-04T07:02:23Z","pushed_at":"2016-07-21T10:16:58Z","git_url":"git://github.com/springload/frontend-starter-kit.git","ssh_url":"git@github.com:springload/frontend-starter-kit.git","clone_url":"https://github.com/springload/frontend-starter-kit.git","svn_url":"https://github.com/springload/frontend-starter-kit","homepage":"http://www.springload.co.nz/blog/a-stable-front-end-stack-for-2016/","size":477,"stargazers_count":8,"watchers_count":8,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12"},"html":{"href":"https://github.com/springload/frontend-starter-kit/pull/12"},"issue":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/issues/12"},"comments":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/springload/frontend-starter-kit/statuses/776cce1f5b7e7192d496464593b8bef6e1f4554b"}}}}
{"actor":{"display_login":"ThibWeb"}}