{"action":"created","comment":{"url":"https://api.github.com/repos/sttts/kubernetes/pulls/comments/67852579","id":67852579,"diff_hunk":"@@ -226,6 +226,37 @@ func IsHTTPHeaderName(value string) bool {\n \treturn httpHeaderNameRegexp.MatchString(value)\n }\n \n+var namespacedSysctls = map[string]bool{\n+\t\t\"kernel.msgmax\":          true,\n+\t\t\"kernel.msgmnb\":          true,\n+\t\t\"kernel.msgmni\":          true,\n+\t\t\"kernel.sem\":             true,\n+\t\t\"kernel.shmall\":          true,\n+\t\t\"kernel.shmmax\":          true,\n+\t\t\"kernel.shmmni\":          true,\n+\t\t\"kernel.shm_rmid_forced\": true,\n+}\n+\n+var namespacedPrefixes = []string{\n+\t\t\"net.\",\n+\t\t\"fs.mqueue.\",\n+}\n+\n+// IsWhitelistedSysctlOpt checks that a sysctl option is supported by docker\n+// TODO: add validation of supported sysctl options in rkt and other\n+func IsWhitelistedSysctlOpt(val string) bool {\n+","path":"pkg/util/validation/validation.go","position":23,"original_position":23,"commit_id":"d035e7ce74f498c4f229794cc7281f5b9947891f","original_commit_id":"d035e7ce74f498c4f229794cc7281f5b9947891f","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"nit: no blank line here","created_at":"2016-06-21T11:41:36Z","updated_at":"2016-06-21T11:41:36Z","html_url":"https://github.com/sttts/kubernetes/pull/4#discussion_r67852579","pull_request_url":"https://api.github.com/repos/sttts/kubernetes/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/comments/67852579"},"html":{"href":"https://github.com/sttts/kubernetes/pull/4#discussion_r67852579"},"pull_request":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/sttts/kubernetes/pulls/4","id":74443664,"html_url":"https://github.com/sttts/kubernetes/pull/4","diff_url":"https://github.com/sttts/kubernetes/pull/4.diff","patch_url":"https://github.com/sttts/kubernetes/pull/4.patch","issue_url":"https://api.github.com/repos/sttts/kubernetes/issues/4","number":4,"state":"open","locked":false,"title":"Sysctl validation","user":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-20T13:32:53Z","updated_at":"2016-06-21T11:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e509edeec597d5647503cfd8acb404386755eacf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sttts/kubernetes/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sttts/kubernetes/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sttts/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sttts/kubernetes/issues/4/comments","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/d035e7ce74f498c4f229794cc7281f5b9947891f","head":{"label":"hodovska:sysctl","ref":"sysctl","sha":"d035e7ce74f498c4f229794cc7281f5b9947891f","user":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"repo":{"id":55980907,"name":"kubernetes","full_name":"hodovska/kubernetes","owner":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hodovska/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hodovska/kubernetes","forks_url":"https://api.github.com/repos/hodovska/kubernetes/forks","keys_url":"https://api.github.com/repos/hodovska/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hodovska/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hodovska/kubernetes/teams","hooks_url":"https://api.github.com/repos/hodovska/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hodovska/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hodovska/kubernetes/events","assignees_url":"https://api.github.com/repos/hodovska/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hodovska/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hodovska/kubernetes/tags","blobs_url":"https://api.github.com/repos/hodovska/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hodovska/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hodovska/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hodovska/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hodovska/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hodovska/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hodovska/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hodovska/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hodovska/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hodovska/kubernetes/subscription","commits_url":"https://api.github.com/repos/hodovska/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hodovska/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hodovska/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hodovska/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hodovska/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hodovska/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hodovska/kubernetes/merges","archive_url":"https://api.github.com/repos/hodovska/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hodovska/kubernetes/downloads","issues_url":"https://api.github.com/repos/hodovska/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hodovska/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hodovska/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hodovska/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hodovska/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hodovska/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hodovska/kubernetes/deployments","created_at":"2016-04-11T14:47:55Z","updated_at":"2016-04-11T14:48:09Z","pushed_at":"2016-06-21T08:36:51Z","git_url":"git://github.com/hodovska/kubernetes.git","ssh_url":"git@github.com:hodovska/kubernetes.git","clone_url":"https://github.com/hodovska/kubernetes.git","svn_url":"https://github.com/hodovska/kubernetes","homepage":"http://kubernetes.io","size":268730,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sttts:sysctl-implementation","ref":"sysctl-implementation","sha":"ee67f5ac0f16a01dc0ce1fb4042924502aab04f8","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":36099048,"name":"kubernetes","full_name":"sttts/kubernetes","owner":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttts/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sttts/kubernetes","forks_url":"https://api.github.com/repos/sttts/kubernetes/forks","keys_url":"https://api.github.com/repos/sttts/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/kubernetes/teams","hooks_url":"https://api.github.com/repos/sttts/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sttts/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/kubernetes/events","assignees_url":"https://api.github.com/repos/sttts/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/kubernetes/tags","blobs_url":"https://api.github.com/repos/sttts/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sttts/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sttts/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sttts/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sttts/kubernetes/subscription","commits_url":"https://api.github.com/repos/sttts/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/kubernetes/merges","archive_url":"https://api.github.com/repos/sttts/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/kubernetes/downloads","issues_url":"https://api.github.com/repos/sttts/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sttts/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/kubernetes/deployments","created_at":"2015-05-22T23:09:55Z","updated_at":"2015-05-22T23:10:00Z","pushed_at":"2016-06-21T11:38:14Z","git_url":"git://github.com/sttts/kubernetes.git","ssh_url":"git@github.com:sttts/kubernetes.git","clone_url":"https://github.com/sttts/kubernetes.git","svn_url":"https://github.com/sttts/kubernetes","homepage":null,"size":266104,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/4"},"html":{"href":"https://github.com/sttts/kubernetes/pull/4"},"issue":{"href":"https://api.github.com/repos/sttts/kubernetes/issues/4"},"comments":{"href":"https://api.github.com/repos/sttts/kubernetes/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sttts/kubernetes/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sttts/kubernetes/statuses/d035e7ce74f498c4f229794cc7281f5b9947891f"}}}}
{"actor":{"display_login":"sttts"}}