{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/79170318","id":79170318,"diff_hunk":"@@ -119,7 +126,16 @@ abstract class AbstractInstancesCheckTask extends AbstractCloudProviderAwareTask\n         }\n       }\n \n-      verifyServerGroupsExist(stage)\n+      try {\n+        verifyServerGroupsExist(stage)\n+      } catch (MissingServerGroupException e) {\n+        if (waitForUpServerGroup()) {","path":"orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/instance/AbstractInstancesCheckTask.groovy","position":22,"original_position":22,"commit_id":"4e8fb20d9ffee82ab556e5da10514d2553860b65","original_commit_id":"4e8fb20d9ffee82ab556e5da10514d2553860b65","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"Yeah makes sense, should the timeout for the whole abstract task be changed? Or just wait for up instances? Or do are theses classes instantiated once per stage, and keep their state through the execution allowing me to timeout only when the server group is missing?","created_at":"2016-09-16T13:38:11Z","updated_at":"2016-09-16T13:38:11Z","html_url":"https://github.com/spinnaker/orca/pull/973#discussion_r79170318","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/973","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/79170318"},"html":{"href":"https://github.com/spinnaker/orca/pull/973#discussion_r79170318"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/973"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/973","id":85457708,"html_url":"https://github.com/spinnaker/orca/pull/973","diff_url":"https://github.com/spinnaker/orca/pull/973.diff","patch_url":"https://github.com/spinnaker/orca/pull/973.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/973","number":973,"state":"open","locked":false,"title":"(core) wait for server group during up instance check","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"It's possible to have the \"wait for up instances to fail\" task if a server group isn't caught in the \"force cache refresh\" preceding it. This is easy to verify by modifying deploy handler to deploy nothing (but report deployment details), causing the \"force cache refresh\" task to simply report that the server doesn't exist (and attempt to evict it from the cache), which succeeds happily. Finally \"wait for up instances\" tries to verify that the server group exists, which throws an exception.\r\n\r\nThis only happens when a no blocking action happens during a deploy stage, and takes around a minute after the deploy for the server group to even show up (ignoring instances).\r\n\r\n@ajordens @duftler ","created_at":"2016-09-15T18:41:52Z","updated_at":"2016-09-16T13:38:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15fec73fbb42b4ff7a190d7bc22ae70a6b5a2994","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/973/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/973/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/973/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/4e8fb20d9ffee82ab556e5da10514d2553860b65","head":{"label":"lwander:core-wait-for-server-group","ref":"core-wait-for-server-group","sha":"4e8fb20d9ffee82ab556e5da10514d2553860b65","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"repo":{"id":47214636,"name":"orca","full_name":"lwander/orca","owner":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwander/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/lwander/orca","forks_url":"https://api.github.com/repos/lwander/orca/forks","keys_url":"https://api.github.com/repos/lwander/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwander/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwander/orca/teams","hooks_url":"https://api.github.com/repos/lwander/orca/hooks","issue_events_url":"https://api.github.com/repos/lwander/orca/issues/events{/number}","events_url":"https://api.github.com/repos/lwander/orca/events","assignees_url":"https://api.github.com/repos/lwander/orca/assignees{/user}","branches_url":"https://api.github.com/repos/lwander/orca/branches{/branch}","tags_url":"https://api.github.com/repos/lwander/orca/tags","blobs_url":"https://api.github.com/repos/lwander/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwander/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwander/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwander/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwander/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/lwander/orca/languages","stargazers_url":"https://api.github.com/repos/lwander/orca/stargazers","contributors_url":"https://api.github.com/repos/lwander/orca/contributors","subscribers_url":"https://api.github.com/repos/lwander/orca/subscribers","subscription_url":"https://api.github.com/repos/lwander/orca/subscription","commits_url":"https://api.github.com/repos/lwander/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwander/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwander/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwander/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwander/orca/contents/{+path}","compare_url":"https://api.github.com/repos/lwander/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwander/orca/merges","archive_url":"https://api.github.com/repos/lwander/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwander/orca/downloads","issues_url":"https://api.github.com/repos/lwander/orca/issues{/number}","pulls_url":"https://api.github.com/repos/lwander/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/lwander/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/lwander/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwander/orca/labels{/name}","releases_url":"https://api.github.com/repos/lwander/orca/releases{/id}","deployments_url":"https://api.github.com/repos/lwander/orca/deployments","created_at":"2015-12-01T20:12:51Z","updated_at":"2016-02-08T18:05:23Z","pushed_at":"2016-09-15T20:38:39Z","git_url":"git://github.com/lwander/orca.git","ssh_url":"git@github.com:lwander/orca.git","clone_url":"https://github.com/lwander/orca.git","svn_url":"https://github.com/lwander/orca","homepage":"","size":6543,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"100fb218bc30a61864efecedf1a30e0ccfa27472","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2016-09-13T15:38:38Z","pushed_at":"2016-09-16T02:46:22Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":9978,"stargazers_count":37,"watchers_count":37,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":48,"forks":65,"open_issues":48,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/973"},"html":{"href":"https://github.com/spinnaker/orca/pull/973"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/973"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/4e8fb20d9ffee82ab556e5da10514d2553860b65"}}}}
{"actor":{"display_login":"lwander"}}