{"action":"closed","number":200,"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200","id":83852925,"html_url":"https://github.com/hawkular/hawkular-alerts/pull/200","diff_url":"https://github.com/hawkular/hawkular-alerts/pull/200.diff","patch_url":"https://github.com/hawkular/hawkular-alerts/pull/200.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/200","number":200,"state":"closed","locked":false,"title":"HWKALERTS-157 Proposed Enhancements","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=3","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"body":"- Optimize the single-condition Trigger or single ConditionEval use cases\r\n  - This common use case deserves streamlined processing.\r\n  - Added some more comments in .drl to better describe the HA-157 problem use case\r\n    and provide an explanation of the rule additions\r\n- Changes to TriggerConditionEval\r\n  - rename to TriggerConditionEvalSet for clarity\r\n  - repackage to org.hawkular.alerts.api.model.dampening as this is used\r\n    specfically for dampening reasons (actually, it would be nice if we\r\n    could keep this out of api but I don't think we can.)\r\n  - removed unnecessary 'mode' attribute\r\n- .drl logging (tangential, sorry)\r\n  - changed to log.debugf for clarity\r\n  - ensured debug logging all rule firings\r\n\r\nPerformance Note\r\n--------------------\r\nI did some simple perf testing by running  PerfRulesEngineTest+RulesEngineTest 3 times each for the current version in master and this revision.  The perf gain was 5.13% using the code optimized for the single condition eval.\r\n\r\n@lucasponce For your consideration, please review at your convenience.","created_at":"2016-09-02T19:27:54Z","updated_at":"2016-09-07T07:25:15Z","closed_at":"2016-09-07T07:25:15Z","merged_at":"2016-09-07T07:25:15Z","merge_commit_sha":"39d5a45b607df0eefd889e832897baa55d852c9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/200/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/5b7f00d94d63e15f76c6741828742f4099ef2ec9","head":{"label":"jshaughn:hwkagent-157","ref":"hwkagent-157","sha":"5b7f00d94d63e15f76c6741828742f4099ef2ec9","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=3","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"repo":{"id":32933334,"name":"hawkular-alerts","full_name":"jshaughn/hawkular-alerts","owner":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=3","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jshaughn/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":true,"url":"https://api.github.com/repos/jshaughn/hawkular-alerts","forks_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/releases{/id}","deployments_url":"https://api.github.com/repos/jshaughn/hawkular-alerts/deployments","created_at":"2015-03-26T14:49:41Z","updated_at":"2015-03-26T14:49:42Z","pushed_at":"2016-09-06T17:24:01Z","git_url":"git://github.com/jshaughn/hawkular-alerts.git","ssh_url":"git@github.com:jshaughn/hawkular-alerts.git","clone_url":"https://github.com/jshaughn/hawkular-alerts.git","svn_url":"https://github.com/jshaughn/hawkular-alerts","homepage":null,"size":3540,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"efc075cf7f019b7ee1a5749095858ee930112fa5","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":29608496,"name":"hawkular-alerts","full_name":"hawkular/hawkular-alerts","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-alerts","forks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-alerts/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/deployments","created_at":"2015-01-21T19:59:08Z","updated_at":"2016-09-07T01:11:46Z","pushed_at":"2016-09-07T07:25:15Z","git_url":"git://github.com/hawkular/hawkular-alerts.git","ssh_url":"git@github.com:hawkular/hawkular-alerts.git","clone_url":"https://github.com/hawkular/hawkular-alerts.git","svn_url":"https://github.com/hawkular/hawkular-alerts","homepage":null,"size":3656,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":0,"forks":15,"open_issues":0,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200"},"html":{"href":"https://github.com/hawkular/hawkular-alerts/pull/200"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/200"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/5b7f00d94d63e15f76c6741828742f4099ef2ec9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":1,"additions":68,"deletions":200,"changed_files":3}}
{"actor":{"display_login":"lucasponce"}}