{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/83","repository_url":"https://api.github.com/repos/voxpupuli/puppet-gluster","labels_url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/83/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/83/events","html_url":"https://github.com/voxpupuli/puppet-gluster/pull/83","id":190045915,"number":83,"title":"Make use of defined() to check for the existence of Fact","user":{"login":"tux-o-matic","id":4562092,"avatar_url":"https://avatars.githubusercontent.com/u/4562092?v=3","gravatar_id":"","url":"https://api.github.com/users/tux-o-matic","html_url":"https://github.com/tux-o-matic","followers_url":"https://api.github.com/users/tux-o-matic/followers","following_url":"https://api.github.com/users/tux-o-matic/following{/other_user}","gists_url":"https://api.github.com/users/tux-o-matic/gists{/gist_id}","starred_url":"https://api.github.com/users/tux-o-matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux-o-matic/subscriptions","organizations_url":"https://api.github.com/users/tux-o-matic/orgs","repos_url":"https://api.github.com/users/tux-o-matic/repos","events_url":"https://api.github.com/users/tux-o-matic/events{/privacy}","received_events_url":"https://api.github.com/users/tux-o-matic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-11-17T13:24:40Z","updated_at":"2016-11-24T08:26:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-gluster/pulls/83","html_url":"https://github.com/voxpupuli/puppet-gluster/pull/83","diff_url":"https://github.com/voxpupuli/puppet-gluster/pull/83.diff","patch_url":"https://github.com/voxpupuli/puppet-gluster/pull/83.patch"},"body":"As pointed out in #82, the Puppet parser using strict variable check will throw an error when check if a Fact not yet initialized is Undef.\r\nUsing the defined() function to lookup the existence of the Fact should work on all version and type of parser."},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/comments/262716880","html_url":"https://github.com/voxpupuli/puppet-gluster/pull/83#issuecomment-262716880","issue_url":"https://api.github.com/repos/voxpupuli/puppet-gluster/issues/83","id":262716880,"user":{"login":"ross-w","id":2508364,"avatar_url":"https://avatars.githubusercontent.com/u/2508364?v=3","gravatar_id":"","url":"https://api.github.com/users/ross-w","html_url":"https://github.com/ross-w","followers_url":"https://api.github.com/users/ross-w/followers","following_url":"https://api.github.com/users/ross-w/following{/other_user}","gists_url":"https://api.github.com/users/ross-w/gists{/gist_id}","starred_url":"https://api.github.com/users/ross-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ross-w/subscriptions","organizations_url":"https://api.github.com/users/ross-w/orgs","repos_url":"https://api.github.com/users/ross-w/repos","events_url":"https://api.github.com/users/ross-w/events{/privacy}","received_events_url":"https://api.github.com/users/ross-w/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T08:26:01Z","updated_at":"2016-11-24T08:26:01Z","body":"Hey Alex\n\nLooks great to me, I haven't tried it out yet but from first glance it looks like it would sort out the issue with strict variables. I sort of wish there was a definitive direction from Puppet rather than simply blog posts. If that fixes it it's good with me :)\n\n\nRoss\n\n> On 24 Nov. 2016, at 7:21 pm, Alex Fisher <notifications@github.com> wrote:\n> \n> @sammcj No worries, I'm fine with nagging! #87 looks ok to you?\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"ross-w"}}