{"action":"closed","number":713,"pull_request":{"url":"https://api.github.com/repos/gap-system/gap/pulls/713","id":65097490,"html_url":"https://github.com/gap-system/gap/pull/713","diff_url":"https://github.com/gap-system/gap/pull/713.diff","patch_url":"https://github.com/gap-system/gap/pull/713.patch","issue_url":"https://api.github.com/repos/gap-system/gap/issues/713","number":713,"state":"closed","locked":false,"title":"Remove CanComputeSize check in DirectFactorsOfGroup","user":{"login":"hungaborhorvath","id":11720671,"avatar_url":"https://avatars.githubusercontent.com/u/11720671?v=3","gravatar_id":"","url":"https://api.github.com/users/hungaborhorvath","html_url":"https://github.com/hungaborhorvath","followers_url":"https://api.github.com/users/hungaborhorvath/followers","following_url":"https://api.github.com/users/hungaborhorvath/following{/other_user}","gists_url":"https://api.github.com/users/hungaborhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/hungaborhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungaborhorvath/subscriptions","organizations_url":"https://api.github.com/users/hungaborhorvath/orgs","repos_url":"https://api.github.com/users/hungaborhorvath/repos","events_url":"https://api.github.com/users/hungaborhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/hungaborhorvath/received_events","type":"User","site_admin":false},"body":"Fixes issue #712 \r\n\r\nTest is added.\r\n\r\nWhile we are at it, I would like the opinion of people. Here there are basically two methods. One for abelian groups and another for finite groups. Currently there is only one method installed which forces the abelian and finite checks. \r\n\r\nWhat would be the preference? To have an ````IsFinite```` and an ````IsAbelian```` method with properly ordered redispatches, or have it the way it is now? Currently it is in the way previously existed. \r\n\r\nI somehow had the feeling that it is not entirely clear which version is preferred, so that is why I am asking.","created_at":"2016-04-04T05:25:19Z","updated_at":"2016-04-11T12:19:44Z","closed_at":"2016-04-11T12:19:44Z","merged_at":"2016-04-11T12:19:44Z","merge_commit_sha":"e948e84e80dedd6e79dd8af089735a869bf34261","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gap-system/gap/pulls/713/commits","review_comments_url":"https://api.github.com/repos/gap-system/gap/pulls/713/comments","review_comment_url":"https://api.github.com/repos/gap-system/gap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gap-system/gap/issues/713/comments","statuses_url":"https://api.github.com/repos/gap-system/gap/statuses/0ea756ab5c7ee80dc077fae1aa9e232bae9d80b5","head":{"label":"hungaborhorvath:DirectFactorBug","ref":"DirectFactorBug","sha":"0ea756ab5c7ee80dc077fae1aa9e232bae9d80b5","user":{"login":"hungaborhorvath","id":11720671,"avatar_url":"https://avatars.githubusercontent.com/u/11720671?v=3","gravatar_id":"","url":"https://api.github.com/users/hungaborhorvath","html_url":"https://github.com/hungaborhorvath","followers_url":"https://api.github.com/users/hungaborhorvath/followers","following_url":"https://api.github.com/users/hungaborhorvath/following{/other_user}","gists_url":"https://api.github.com/users/hungaborhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/hungaborhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungaborhorvath/subscriptions","organizations_url":"https://api.github.com/users/hungaborhorvath/orgs","repos_url":"https://api.github.com/users/hungaborhorvath/repos","events_url":"https://api.github.com/users/hungaborhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/hungaborhorvath/received_events","type":"User","site_admin":false},"repo":{"id":33125962,"name":"gap","full_name":"hungaborhorvath/gap","owner":{"login":"hungaborhorvath","id":11720671,"avatar_url":"https://avatars.githubusercontent.com/u/11720671?v=3","gravatar_id":"","url":"https://api.github.com/users/hungaborhorvath","html_url":"https://github.com/hungaborhorvath","followers_url":"https://api.github.com/users/hungaborhorvath/followers","following_url":"https://api.github.com/users/hungaborhorvath/following{/other_user}","gists_url":"https://api.github.com/users/hungaborhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/hungaborhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungaborhorvath/subscriptions","organizations_url":"https://api.github.com/users/hungaborhorvath/orgs","repos_url":"https://api.github.com/users/hungaborhorvath/repos","events_url":"https://api.github.com/users/hungaborhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/hungaborhorvath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hungaborhorvath/gap","description":"grpnames fork of GAP - Groups, Algorithms, Programming - a System for Computational Discrete Algebra","fork":true,"url":"https://api.github.com/repos/hungaborhorvath/gap","forks_url":"https://api.github.com/repos/hungaborhorvath/gap/forks","keys_url":"https://api.github.com/repos/hungaborhorvath/gap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hungaborhorvath/gap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hungaborhorvath/gap/teams","hooks_url":"https://api.github.com/repos/hungaborhorvath/gap/hooks","issue_events_url":"https://api.github.com/repos/hungaborhorvath/gap/issues/events{/number}","events_url":"https://api.github.com/repos/hungaborhorvath/gap/events","assignees_url":"https://api.github.com/repos/hungaborhorvath/gap/assignees{/user}","branches_url":"https://api.github.com/repos/hungaborhorvath/gap/branches{/branch}","tags_url":"https://api.github.com/repos/hungaborhorvath/gap/tags","blobs_url":"https://api.github.com/repos/hungaborhorvath/gap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hungaborhorvath/gap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hungaborhorvath/gap/git/refs{/sha}","trees_url":"https://api.github.com/repos/hungaborhorvath/gap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hungaborhorvath/gap/statuses/{sha}","languages_url":"https://api.github.com/repos/hungaborhorvath/gap/languages","stargazers_url":"https://api.github.com/repos/hungaborhorvath/gap/stargazers","contributors_url":"https://api.github.com/repos/hungaborhorvath/gap/contributors","subscribers_url":"https://api.github.com/repos/hungaborhorvath/gap/subscribers","subscription_url":"https://api.github.com/repos/hungaborhorvath/gap/subscription","commits_url":"https://api.github.com/repos/hungaborhorvath/gap/commits{/sha}","git_commits_url":"https://api.github.com/repos/hungaborhorvath/gap/git/commits{/sha}","comments_url":"https://api.github.com/repos/hungaborhorvath/gap/comments{/number}","issue_comment_url":"https://api.github.com/repos/hungaborhorvath/gap/issues/comments{/number}","contents_url":"https://api.github.com/repos/hungaborhorvath/gap/contents/{+path}","compare_url":"https://api.github.com/repos/hungaborhorvath/gap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hungaborhorvath/gap/merges","archive_url":"https://api.github.com/repos/hungaborhorvath/gap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hungaborhorvath/gap/downloads","issues_url":"https://api.github.com/repos/hungaborhorvath/gap/issues{/number}","pulls_url":"https://api.github.com/repos/hungaborhorvath/gap/pulls{/number}","milestones_url":"https://api.github.com/repos/hungaborhorvath/gap/milestones{/number}","notifications_url":"https://api.github.com/repos/hungaborhorvath/gap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hungaborhorvath/gap/labels{/name}","releases_url":"https://api.github.com/repos/hungaborhorvath/gap/releases{/id}","deployments_url":"https://api.github.com/repos/hungaborhorvath/gap/deployments","created_at":"2015-03-30T13:51:57Z","updated_at":"2016-01-21T23:01:02Z","pushed_at":"2016-04-09T10:52:15Z","git_url":"git://github.com/hungaborhorvath/gap.git","ssh_url":"git@github.com:hungaborhorvath/gap.git","clone_url":"https://github.com/hungaborhorvath/gap.git","svn_url":"https://github.com/hungaborhorvath/gap","homepage":"http://www.gap-system.org","size":385535,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gap-system:master","ref":"master","sha":"761f59dabe72b39952c813933bbbccdc92f82435","user":{"login":"gap-system","id":5344223,"avatar_url":"https://avatars.githubusercontent.com/u/5344223?v=3","gravatar_id":"","url":"https://api.github.com/users/gap-system","html_url":"https://github.com/gap-system","followers_url":"https://api.github.com/users/gap-system/followers","following_url":"https://api.github.com/users/gap-system/following{/other_user}","gists_url":"https://api.github.com/users/gap-system/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-system/subscriptions","organizations_url":"https://api.github.com/users/gap-system/orgs","repos_url":"https://api.github.com/users/gap-system/repos","events_url":"https://api.github.com/users/gap-system/events{/privacy}","received_events_url":"https://api.github.com/users/gap-system/received_events","type":"Organization","site_admin":false},"repo":{"id":31270208,"name":"gap","full_name":"gap-system/gap","owner":{"login":"gap-system","id":5344223,"avatar_url":"https://avatars.githubusercontent.com/u/5344223?v=3","gravatar_id":"","url":"https://api.github.com/users/gap-system","html_url":"https://github.com/gap-system","followers_url":"https://api.github.com/users/gap-system/followers","following_url":"https://api.github.com/users/gap-system/following{/other_user}","gists_url":"https://api.github.com/users/gap-system/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-system/subscriptions","organizations_url":"https://api.github.com/users/gap-system/orgs","repos_url":"https://api.github.com/users/gap-system/repos","events_url":"https://api.github.com/users/gap-system/events{/privacy}","received_events_url":"https://api.github.com/users/gap-system/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gap-system/gap","description":"Main development repository for GAP - Groups, Algorithms, Programming, a System for Computational Discrete Algebra","fork":false,"url":"https://api.github.com/repos/gap-system/gap","forks_url":"https://api.github.com/repos/gap-system/gap/forks","keys_url":"https://api.github.com/repos/gap-system/gap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gap-system/gap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gap-system/gap/teams","hooks_url":"https://api.github.com/repos/gap-system/gap/hooks","issue_events_url":"https://api.github.com/repos/gap-system/gap/issues/events{/number}","events_url":"https://api.github.com/repos/gap-system/gap/events","assignees_url":"https://api.github.com/repos/gap-system/gap/assignees{/user}","branches_url":"https://api.github.com/repos/gap-system/gap/branches{/branch}","tags_url":"https://api.github.com/repos/gap-system/gap/tags","blobs_url":"https://api.github.com/repos/gap-system/gap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gap-system/gap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gap-system/gap/git/refs{/sha}","trees_url":"https://api.github.com/repos/gap-system/gap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gap-system/gap/statuses/{sha}","languages_url":"https://api.github.com/repos/gap-system/gap/languages","stargazers_url":"https://api.github.com/repos/gap-system/gap/stargazers","contributors_url":"https://api.github.com/repos/gap-system/gap/contributors","subscribers_url":"https://api.github.com/repos/gap-system/gap/subscribers","subscription_url":"https://api.github.com/repos/gap-system/gap/subscription","commits_url":"https://api.github.com/repos/gap-system/gap/commits{/sha}","git_commits_url":"https://api.github.com/repos/gap-system/gap/git/commits{/sha}","comments_url":"https://api.github.com/repos/gap-system/gap/comments{/number}","issue_comment_url":"https://api.github.com/repos/gap-system/gap/issues/comments{/number}","contents_url":"https://api.github.com/repos/gap-system/gap/contents/{+path}","compare_url":"https://api.github.com/repos/gap-system/gap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gap-system/gap/merges","archive_url":"https://api.github.com/repos/gap-system/gap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gap-system/gap/downloads","issues_url":"https://api.github.com/repos/gap-system/gap/issues{/number}","pulls_url":"https://api.github.com/repos/gap-system/gap/pulls{/number}","milestones_url":"https://api.github.com/repos/gap-system/gap/milestones{/number}","notifications_url":"https://api.github.com/repos/gap-system/gap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gap-system/gap/labels{/name}","releases_url":"https://api.github.com/repos/gap-system/gap/releases{/id}","deployments_url":"https://api.github.com/repos/gap-system/gap/deployments","created_at":"2015-02-24T16:47:50Z","updated_at":"2016-04-10T23:06:21Z","pushed_at":"2016-04-11T12:19:44Z","git_url":"git://github.com/gap-system/gap.git","ssh_url":"git@github.com:gap-system/gap.git","clone_url":"https://github.com/gap-system/gap.git","svn_url":"https://github.com/gap-system/gap","homepage":"http://www.gap-system.org","size":393277,"stargazers_count":62,"watchers_count":62,"language":"GAP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":169,"forks":33,"open_issues":169,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gap-system/gap/pulls/713"},"html":{"href":"https://github.com/gap-system/gap/pull/713"},"issue":{"href":"https://api.github.com/repos/gap-system/gap/issues/713"},"comments":{"href":"https://api.github.com/repos/gap-system/gap/issues/713/comments"},"review_comments":{"href":"https://api.github.com/repos/gap-system/gap/pulls/713/comments"},"review_comment":{"href":"https://api.github.com/repos/gap-system/gap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gap-system/gap/pulls/713/commits"},"statuses":{"href":"https://api.github.com/repos/gap-system/gap/statuses/0ea756ab5c7ee80dc077fae1aa9e232bae9d80b5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"markuspf","id":3589190,"avatar_url":"https://avatars.githubusercontent.com/u/3589190?v=3","gravatar_id":"","url":"https://api.github.com/users/markuspf","html_url":"https://github.com/markuspf","followers_url":"https://api.github.com/users/markuspf/followers","following_url":"https://api.github.com/users/markuspf/following{/other_user}","gists_url":"https://api.github.com/users/markuspf/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspf/subscriptions","organizations_url":"https://api.github.com/users/markuspf/orgs","repos_url":"https://api.github.com/users/markuspf/repos","events_url":"https://api.github.com/users/markuspf/events{/privacy}","received_events_url":"https://api.github.com/users/markuspf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":2}}