{"action":"created","comment":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/comments/79713746","id":79713746,"diff_hunk":"@@ -263,16 +264,16 @@ def test_neville2d(self):\n                 val = utils.neville2d(xx, yy, x, y, fval)\n                 self.assertTrue(utils.Knuth_close(answer, val, tol))\n \n-    def test_parallel_map(self):\n-        ncpus = multiprocessing.cpu_count()\n \n+@pytest.mark.parametrize(\"num_tasks\", [1, 3, 100])\n+def test_parallel_map(num_tasks):","path":"sherpa/utils/tests/test_utils.py","position":16,"original_position":16,"commit_id":"316a183df31cae3b4b0bd591a41613c1ef6c4f72","original_commit_id":"316a183df31cae3b4b0bd591a41613c1ef6c4f72","user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"body":"I'm not happy with the function argument being called `num_tasks` as it is too similar to `numtasks` and makes it harder to see what is going on with the tests.","created_at":"2016-09-20T21:12:42Z","updated_at":"2016-09-20T21:12:42Z","html_url":"https://github.com/sherpa/sherpa/pull/278#discussion_r79713746","pull_request_url":"https://api.github.com/repos/sherpa/sherpa/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/comments/79713746"},"html":{"href":"https://github.com/sherpa/sherpa/pull/278#discussion_r79713746"},"pull_request":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/278","id":86035143,"html_url":"https://github.com/sherpa/sherpa/pull/278","diff_url":"https://github.com/sherpa/sherpa/pull/278.diff","patch_url":"https://github.com/sherpa/sherpa/pull/278.patch","issue_url":"https://api.github.com/repos/sherpa/sherpa/issues/278","number":278,"state":"open","locked":false,"title":"fix #277 - parallel_map not working on py3 with numcores=1","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"body":"Fix #277.\r\n\r\n# Release Note\r\nThe `utils` function `parallel_map` failed on Python 3 when called with `numcores=1`, i.e. on systems with only one processor/core. This has been fixed.\r\n\r\n# Description\r\nNote that the tests have been changed to make them fail (with the fix removed) on all platforms, whatever the number of cores. So, when testing I made sure I would see the 1-core test fail on a system where the old test would pass and then, with the fix back in place, I made sure the test passes again.","created_at":"2016-09-20T18:54:46Z","updated_at":"2016-09-20T21:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a45422d647512a1f5ff24f1011909090b33820","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sherpa/sherpa/pulls/278/commits","review_comments_url":"https://api.github.com/repos/sherpa/sherpa/pulls/278/comments","review_comment_url":"https://api.github.com/repos/sherpa/sherpa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sherpa/sherpa/issues/278/comments","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/316a183df31cae3b4b0bd591a41613c1ef6c4f72","head":{"label":"sherpa:fix-277-parallel-map","ref":"fix-277-parallel-map","sha":"316a183df31cae3b4b0bd591a41613c1ef6c4f72","user":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"repo":{"id":18777006,"name":"sherpa","full_name":"sherpa/sherpa","owner":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sherpa/sherpa","description":"Sherpa is a modeling and fitting application for Python","fork":false,"url":"https://api.github.com/repos/sherpa/sherpa","forks_url":"https://api.github.com/repos/sherpa/sherpa/forks","keys_url":"https://api.github.com/repos/sherpa/sherpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherpa/sherpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherpa/sherpa/teams","hooks_url":"https://api.github.com/repos/sherpa/sherpa/hooks","issue_events_url":"https://api.github.com/repos/sherpa/sherpa/issues/events{/number}","events_url":"https://api.github.com/repos/sherpa/sherpa/events","assignees_url":"https://api.github.com/repos/sherpa/sherpa/assignees{/user}","branches_url":"https://api.github.com/repos/sherpa/sherpa/branches{/branch}","tags_url":"https://api.github.com/repos/sherpa/sherpa/tags","blobs_url":"https://api.github.com/repos/sherpa/sherpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherpa/sherpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherpa/sherpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherpa/sherpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/{sha}","languages_url":"https://api.github.com/repos/sherpa/sherpa/languages","stargazers_url":"https://api.github.com/repos/sherpa/sherpa/stargazers","contributors_url":"https://api.github.com/repos/sherpa/sherpa/contributors","subscribers_url":"https://api.github.com/repos/sherpa/sherpa/subscribers","subscription_url":"https://api.github.com/repos/sherpa/sherpa/subscription","commits_url":"https://api.github.com/repos/sherpa/sherpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherpa/sherpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherpa/sherpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherpa/sherpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherpa/sherpa/contents/{+path}","compare_url":"https://api.github.com/repos/sherpa/sherpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherpa/sherpa/merges","archive_url":"https://api.github.com/repos/sherpa/sherpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherpa/sherpa/downloads","issues_url":"https://api.github.com/repos/sherpa/sherpa/issues{/number}","pulls_url":"https://api.github.com/repos/sherpa/sherpa/pulls{/number}","milestones_url":"https://api.github.com/repos/sherpa/sherpa/milestones{/number}","notifications_url":"https://api.github.com/repos/sherpa/sherpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherpa/sherpa/labels{/name}","releases_url":"https://api.github.com/repos/sherpa/sherpa/releases{/id}","deployments_url":"https://api.github.com/repos/sherpa/sherpa/deployments","created_at":"2014-04-14T21:13:46Z","updated_at":"2016-09-19T01:14:36Z","pushed_at":"2016-09-20T19:50:53Z","git_url":"git://github.com/sherpa/sherpa.git","ssh_url":"git@github.com:sherpa/sherpa.git","clone_url":"https://github.com/sherpa/sherpa.git","svn_url":"https://github.com/sherpa/sherpa","homepage":"http://cxc.cfa.harvard.edu/contrib/sherpa","size":17601,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":89,"forks":21,"open_issues":89,"watchers":19,"default_branch":"master"}},"base":{"label":"sherpa:release/4.8.2","ref":"release/4.8.2","sha":"93834846f02bfcf1106c8f753f0bdbb8af7ae0a7","user":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"repo":{"id":18777006,"name":"sherpa","full_name":"sherpa/sherpa","owner":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sherpa/sherpa","description":"Sherpa is a modeling and fitting application for Python","fork":false,"url":"https://api.github.com/repos/sherpa/sherpa","forks_url":"https://api.github.com/repos/sherpa/sherpa/forks","keys_url":"https://api.github.com/repos/sherpa/sherpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherpa/sherpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherpa/sherpa/teams","hooks_url":"https://api.github.com/repos/sherpa/sherpa/hooks","issue_events_url":"https://api.github.com/repos/sherpa/sherpa/issues/events{/number}","events_url":"https://api.github.com/repos/sherpa/sherpa/events","assignees_url":"https://api.github.com/repos/sherpa/sherpa/assignees{/user}","branches_url":"https://api.github.com/repos/sherpa/sherpa/branches{/branch}","tags_url":"https://api.github.com/repos/sherpa/sherpa/tags","blobs_url":"https://api.github.com/repos/sherpa/sherpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherpa/sherpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherpa/sherpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherpa/sherpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/{sha}","languages_url":"https://api.github.com/repos/sherpa/sherpa/languages","stargazers_url":"https://api.github.com/repos/sherpa/sherpa/stargazers","contributors_url":"https://api.github.com/repos/sherpa/sherpa/contributors","subscribers_url":"https://api.github.com/repos/sherpa/sherpa/subscribers","subscription_url":"https://api.github.com/repos/sherpa/sherpa/subscription","commits_url":"https://api.github.com/repos/sherpa/sherpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherpa/sherpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherpa/sherpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherpa/sherpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherpa/sherpa/contents/{+path}","compare_url":"https://api.github.com/repos/sherpa/sherpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherpa/sherpa/merges","archive_url":"https://api.github.com/repos/sherpa/sherpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherpa/sherpa/downloads","issues_url":"https://api.github.com/repos/sherpa/sherpa/issues{/number}","pulls_url":"https://api.github.com/repos/sherpa/sherpa/pulls{/number}","milestones_url":"https://api.github.com/repos/sherpa/sherpa/milestones{/number}","notifications_url":"https://api.github.com/repos/sherpa/sherpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherpa/sherpa/labels{/name}","releases_url":"https://api.github.com/repos/sherpa/sherpa/releases{/id}","deployments_url":"https://api.github.com/repos/sherpa/sherpa/deployments","created_at":"2014-04-14T21:13:46Z","updated_at":"2016-09-19T01:14:36Z","pushed_at":"2016-09-20T19:50:53Z","git_url":"git://github.com/sherpa/sherpa.git","ssh_url":"git@github.com:sherpa/sherpa.git","clone_url":"https://github.com/sherpa/sherpa.git","svn_url":"https://github.com/sherpa/sherpa","homepage":"http://cxc.cfa.harvard.edu/contrib/sherpa","size":17601,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":89,"forks":21,"open_issues":89,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/278"},"html":{"href":"https://github.com/sherpa/sherpa/pull/278"},"issue":{"href":"https://api.github.com/repos/sherpa/sherpa/issues/278"},"comments":{"href":"https://api.github.com/repos/sherpa/sherpa/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/sherpa/sherpa/statuses/316a183df31cae3b4b0bd591a41613c1ef6c4f72"}}}}
{"actor":{"display_login":"DougBurke"}}