{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/2240","labels_url":"https://api.github.com/repos/systemd/systemd/issues/2240/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/2240/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/2240/events","html_url":"https://github.com/systemd/systemd/pull/2240","id":124265479,"number":2240,"title":"coredump: fix bug that loses core dump files when core dumps are compressed and disk space is low.","user":{"login":"hgwalles","id":16295135,"avatar_url":"https://avatars.githubusercontent.com/u/16295135?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwalles","html_url":"https://github.com/hgwalles","followers_url":"https://api.github.com/users/hgwalles/followers","following_url":"https://api.github.com/users/hgwalles/following{/other_user}","gists_url":"https://api.github.com/users/hgwalles/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwalles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwalles/subscriptions","organizations_url":"https://api.github.com/users/hgwalles/orgs","repos_url":"https://api.github.com/users/hgwalles/repos","events_url":"https://api.github.com/users/hgwalles/events{/privacy}","received_events_url":"https://api.github.com/users/hgwalles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemd/systemd/labels/coredump","name":"coredump","color":"f7c6c7"},{"url":"https://api.github.com/repos/systemd/systemd/labels/reviewed/needs-rework","name":"reviewed/needs-rework","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-29T20:39:56Z","updated_at":"2016-01-25T13:44:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/2240","html_url":"https://github.com/systemd/systemd/pull/2240","diff_url":"https://github.com/systemd/systemd/pull/2240.diff","patch_url":"https://github.com/systemd/systemd/pull/2240.patch"},"body":"Previously the save_external_coredump function returned a file\r\ndescriptor corresponding to the dumped file.  This descriptor was used\r\nfor two different purposes by calling code: a) access to the raw core\r\ndump data; b) testing candidate files (via inode comparisons) while\r\nvacuuming to protect the current core dump against vacuuming.\r\n\r\nThe descriptor returned always corresponded to a file containing the raw\r\ncore dump data.  However if compression was used and the core dump was\r\ncompressed then the descriptor returned did not correspond to the file\r\nthat would eventually be left on disk (ie the compressed file).  Thus\r\nthe file was never protected by vacuuming.  When disk space was scarce\r\nall core dumps including the current one would be vacuumed and the\r\ncorresponding log message referred to a file that no longer existed.\r\n\r\nThis resulted in the following error message from coredumpctl if the\r\nmissing core dump was requested:\r\n   Cannot retrieve coredump from journal nor disk.\r\n   Failed to retrieve core: No such file or directory\r\n\r\nWith this patch, save_external_coredump now returns two descriptors, one to be used for\r\nraw data access, and one to be used for inode comparisons to prevent\r\noverzealous vacuuming.  Corresponding usage of these returned\r\ndescriptors also updated."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/174513129","html_url":"https://github.com/systemd/systemd/pull/2240#issuecomment-174513129","issue_url":"https://api.github.com/repos/systemd/systemd/issues/2240","id":174513129,"user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T13:44:16Z","updated_at":"2016-01-25T13:44:16Z","body":"Could you please rebase this and merge the two patches into one?"}}