{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/66765060","id":66765060,"diff_hunk":"@@ -0,0 +1,209 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package e2e\n+\n+import (\n+\t\"time\"\n+\n+\t\"k8s.io/kubernetes/federation/apis/federation\"\n+\t\"k8s.io/kubernetes/federation/client/clientset_generated/federation_internalclientset\"\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/api/v1\"\n+\t\"k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3\"\n+\t\"k8s.io/kubernetes/pkg/client/restclient\"\n+\t\"k8s.io/kubernetes/pkg/client/unversioned/clientcmd\"\n+\tclientcmdapi \"k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api\"\n+\t\"k8s.io/kubernetes/pkg/util/intstr\"\n+\t\"k8s.io/kubernetes/test/e2e/framework\"\n+\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+)\n+\n+const (\n+\tUserAgentName = \"federation-e2e-service-controller\"\n+\t// TODO(madhusudancs): Using the same values as defined in the federated\n+\t// service controller. Replace it with the values from the e2e framework.\n+\tKubeAPIQPS   = 20.0\n+\tKubeAPIBurst = 30\n+\n+\tFederatedServiceTimeout = 5 * time.Minute\n+\n+\tFederatedServiceName = \"federated-service\"\n+\tFederatedServicePod  = \"federated-service-test-pod\"\n+\n+\t// TODO: Only suppoprts IPv4 addresses. Also add a regexp for IPv6 addresses.\n+\tFederatedIPAddrRegexp  = `(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])`\n+\tFederatedDNS1123Regexp = `([a-z0-9]([-a-z0-9]*[a-z0-9])?\\.)*([a-z0-9]([-a-z0-9]*[a-z0-9])?)`\n+)\n+\n+var _ = framework.KubeDescribe(\"Service [Feature:Federation]\", func() {\n+\tvar clusterClientSets []*release_1_3.Clientset\n+\tf := framework.NewDefaultFederatedFramework(\"service\")\n+\n+\tBeforeEach(func() {\n+\t\tcontexts := f.GetUnderlyingFederatedContexts()\n+\n+\t\tfor _, context := range contexts {\n+\t\t\tframework.Logf(\"Creating cluster object: %s (%s)\", context.Name, context.Cluster.Cluster.Server)\n+\t\t\tcluster := federation.Cluster{\n+\t\t\t\tObjectMeta: api.ObjectMeta{\n+\t\t\t\t\tName: context.Name,\n+\t\t\t\t},\n+\t\t\t\tSpec: federation.ClusterSpec{\n+\t\t\t\t\tServerAddressByClientCIDRs: []federation.ServerAddressByClientCIDR{\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\tClientCIDR:    \"0.0.0.0/0\",\n+\t\t\t\t\t\t\tServerAddress: context.Cluster.Cluster.Server,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t}\n+\t\t\t_, err := f.FederationClientset.Federation().Clusters().Create(&cluster)\n+\t\t\tframework.ExpectNoError(err, \"Creating cluster\")\n+\t\t}\n+\n+\t\tBy(\"Obtaining a list of all the clusters\")\n+\t\tclusterList, err := f.FederationClientset.Federation().Clusters().List(api.ListOptions{})\n+\t\tExpect(err).NotTo(HaveOccurred())\n+\t\tframework.Logf(\"%d clusters found\", len(clusterList.Items))\n+\n+\t\tfor _, cluster := range clusterList.Items {\n+\t\t\tframework.Logf(\"Creating a clientset for the cluster %s\", cluster.Name)\n+\n+\t\t\tExpect(framework.TestContext.KubeConfig).ToNot(Equal(\"\"), \"KubeConfig must be specified to load clusters' client config\")\n+\t\t\tkubecfg, err := clientcmd.LoadFromFile(framework.TestContext.KubeConfig)\n+\t\t\tframework.ExpectNoError(err, \"error loading KubeConfig: %v\", err)\n+\n+\t\t\tcfgOverride := &clientcmd.ConfigOverrides{\n+\t\t\t\tClusterInfo: clientcmdapi.Cluster{\n+\t\t\t\t\tServer: cluster.Spec.ServerAddressByClientCIDRs[0].ServerAddress,\n+\t\t\t\t},\n+\t\t\t}\n+\t\t\tccfg := clientcmd.NewNonInteractiveClientConfig(*kubecfg, cluster.Name, cfgOverride, clientcmd.NewDefaultClientConfigLoadingRules())\n+\t\t\tcfg, err := ccfg.ClientConfig()\n+\t\t\tExpect(err).NotTo(HaveOccurred())\n+\n+\t\t\tcfg.QPS = KubeAPIQPS\n+\t\t\tcfg.Burst = KubeAPIBurst\n+\t\t\tclset := release_1_3.NewForConfigOrDie(restclient.AddUserAgent(cfg, UserAgentName))\n+\t\t\tclusterClientSets = append(clusterClientSets, clset)\n+\t\t}\n+\t})\n+\n+\tIt(\"should be able to discover a federated service\", func() {\n+\t\tframework.SkipUnlessFederated(f.Client)\n+\n+\t\tcreateService(f.FederationClientset, clusterClientSets, f.Namespace.Name)\n+\n+\t\tdiscoverService(f)\n+\t})\n+\n+\tIt(\"should be able to discover a non-local federated service\", func() {\n+\t\tframework.SkipUnlessFederated(f.Client)\n+\n+\t\tcreateService(f.FederationClientset, clusterClientSets, f.Namespace.Name)\n+\n+\t\t// Delete a federated service shard in the default e2e Kubernetes cluster.\n+\t\terr := f.Clientset_1_3.Core().Services(f.Namespace.Name).Delete(FederatedServiceName, &api.DeleteOptions{})\n+\t\tExpect(err).NotTo(HaveOccurred())\n+\t\twaitForFederatedServiceShard(f.Clientset_1_3, f.Namespace.Name, nil, 0)\n+\n+\t\tdiscoverService(f)\n+\t})\n+})\n+\n+func waitForFederatedServiceShard(cs *release_1_3.Clientset, namespace string, service *api.Service, numSvcs int) {\n+\tBy(\"Fetching a federated service shard\")\n+\tvar clSvcList *v1.ServiceList\n+\tfor t := time.Now(); time.Since(t) < FederatedServiceTimeout; time.Sleep(framework.Poll) {\n+\t\tvar err error\n+\t\tclSvcList, err = cs.Core().Services(namespace).List(api.ListOptions{})\n+\t\tExpect(err).NotTo(HaveOccurred())\n+\t\tn := len(clSvcList.Items)\n+\t\tif n == numSvcs {\n+\t\t\tbreak\n+\t\t}\n+\t\tframework.Logf(\"%d services found, trying again in %s\", n, framework.Poll)\n+\t}\n+\n+\tExpect(len(clSvcList.Items)).To(Equal(numSvcs))\n+\tif numSvcs > 0 {\n+\t\t// Renaming for clarity/readability\n+\t\tclSvc := clSvcList.Items[0]","path":"test/e2e/federated-service.go","position":147,"original_position":147,"commit_id":"1988dbfa2652c2b2444c597c7eecfd56b04de06c","original_commit_id":"1988dbfa2652c2b2444c597c7eecfd56b04de06c","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"body":"> This only seems to work for numSvcs == 1 ?\r\n\r\nThat's right and that's intentional. It only makes sense to execute the block inside the `if` only if we expect to have at least one shard.\r\n \r\n> The semantics of this function are rather confusing. As far as I can tell it will wait until the number of services in the specifed namespace reaches numSvcs, and (presumably this only works if 'service' is not nil) if numSvcs >0, that the first listed service matches the one passed in? You should definitely document the semantics in the header, and also check for service != nil before dereferencing it.\r\n\r\nThanks for catching that. Added a check for service != nil. Also added the doc string for the function.","created_at":"2016-06-13T09:45:21Z","updated_at":"2016-06-13T09:45:21Z","html_url":"https://github.com/kubernetes/kubernetes/pull/26636#discussion_r66765060","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/66765060"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26636#discussion_r66765060"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636","id":72193947,"html_url":"https://github.com/kubernetes/kubernetes/pull/26636","diff_url":"https://github.com/kubernetes/kubernetes/pull/26636.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26636.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26636","number":26636,"state":"open","locked":false,"title":"Implement first set of federated service e2e tests.","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"body":"These tests are untested and there is no guarantee that they work. The ongoing auth problems is blocking these e2es from being tested and upon @quinton-hoole's request I am submitting them now.\r\n\r\nOnly the last commit here needs review.\r\n\r\nDepends on #26953\r\n\r\ncc @nikhiljindal @colhom @mfanjie @kubernetes/sig-cluster-federation ","created_at":"2016-06-01T14:46:12Z","updated_at":"2016-06-13T09:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ea71560f79ff33876c822818ca1656784ca0bb5","assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":163,"closed_issues":642,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-13T08:00:17Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26636/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1988dbfa2652c2b2444c597c7eecfd56b04de06c","head":{"label":"madhusudancs:fed-svc-e2e","ref":"fed-svc-e2e","sha":"1988dbfa2652c2b2444c597c7eecfd56b04de06c","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"repo":{"id":43526269,"name":"kubernetes","full_name":"madhusudancs/kubernetes","owner":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhusudancs/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/madhusudancs/kubernetes","forks_url":"https://api.github.com/repos/madhusudancs/kubernetes/forks","keys_url":"https://api.github.com/repos/madhusudancs/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhusudancs/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhusudancs/kubernetes/teams","hooks_url":"https://api.github.com/repos/madhusudancs/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/madhusudancs/kubernetes/events","assignees_url":"https://api.github.com/repos/madhusudancs/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/madhusudancs/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/madhusudancs/kubernetes/tags","blobs_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhusudancs/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/madhusudancs/kubernetes/languages","stargazers_url":"https://api.github.com/repos/madhusudancs/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/madhusudancs/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/madhusudancs/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/madhusudancs/kubernetes/subscription","commits_url":"https://api.github.com/repos/madhusudancs/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhusudancs/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/madhusudancs/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/madhusudancs/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhusudancs/kubernetes/merges","archive_url":"https://api.github.com/repos/madhusudancs/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhusudancs/kubernetes/downloads","issues_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/madhusudancs/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/madhusudancs/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/madhusudancs/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhusudancs/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/madhusudancs/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/madhusudancs/kubernetes/deployments","created_at":"2015-10-01T23:19:31Z","updated_at":"2016-01-11T22:54:35Z","pushed_at":"2016-06-13T09:09:20Z","git_url":"git://github.com/madhusudancs/kubernetes.git","ssh_url":"git@github.com:madhusudancs/kubernetes.git","clone_url":"https://github.com/madhusudancs/kubernetes.git","svn_url":"https://github.com/madhusudancs/kubernetes","homepage":"http://kubernetes.io","size":265054,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7476d97781563b70e8b89a8bd3f99ea75ae6c290","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-13T09:33:43Z","pushed_at":"2016-06-13T09:09:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":477809,"stargazers_count":14882,"watchers_count":14882,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4567,"mirror_url":null,"open_issues_count":3715,"forks":4567,"open_issues":3715,"watchers":14882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26636"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26636"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26636/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26636/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1988dbfa2652c2b2444c597c7eecfd56b04de06c"}}}}
{"actor":{"display_login":"madhusudancs"}}