{"action":"closed","number":2909,"pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/2909","id":92664259,"html_url":"https://github.com/mautic/mautic/pull/2909","diff_url":"https://github.com/mautic/mautic/pull/2909.diff","patch_url":"https://github.com/mautic/mautic/pull/2909.patch","issue_url":"https://api.github.com/repos/mautic/mautic/issues/2909","number":2909,"state":"closed","locked":false,"title":"More options for setup notifications","user":{"login":"kuzmany","id":462477,"avatar_url":"https://avatars.githubusercontent.com/u/462477?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzmany","html_url":"https://github.com/kuzmany","followers_url":"https://api.github.com/users/kuzmany/followers","following_url":"https://api.github.com/users/kuzmany/following{/other_user}","gists_url":"https://api.github.com/users/kuzmany/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzmany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzmany/subscriptions","organizations_url":"https://api.github.com/users/kuzmany/orgs","repos_url":"https://api.github.com/users/kuzmany/repos","events_url":"https://api.github.com/users/kuzmany/events{/privacy}","received_events_url":"https://api.github.com/users/kuzmany/received_events","type":"User","site_admin":false},"body":"[//]: # ( Please answer the following questions: )\r\n\r\n| Q  | A\r\n| --- | ---\r\n| Bug fix? | n\r\n| New feature? | y\r\n| Related user documentation PR URL | https://github.com/mautic/documentation/pull/134 \r\n| Related developer documentation PR URL | n\r\n| Issues addressed (#s or URLs) | n\r\n| BC breaks? | n\r\n| Deprecations? | n\r\n\r\n#### Description:\r\nPR added 2 new options to configuration pane:\r\n1, \r\nOneSignal use gcm_sender_id as verification for web push service. \r\nThey recommend use default value (482941778795), but in past we had to generate own gcm_sender_id  for every account.\r\nIt's better use it in configuration due backwards compatibility.\r\nMore in documentation, part. 2.2 Edit manifest.json:\r\nhttps://documentation.onesignal.com/docs/web-push-sdk-setup-https\r\nAt the moment use Mautic gcm_sender_id  in code.\r\n\r\n2, Options for disable welcome notification\r\n\r\n![notifications](https://cloud.githubusercontent.com/assets/462477/20137624/dea049dc-a67b-11e6-8c39-b8ebb20f02cb.PNG)\r\n\r\n#### Steps to test this PR:\r\n1. Open http://your-mautic-domain.tld/manifest.json before apply PR\r\n2. Apply PR, go to Configuration > Web Notification settings and enable  it\r\n3. Change default Shared key for push notifications from documentation to your anyhting else\r\n4. See change in url http://your-mautic-domain.tld/manifest.json\r\n5. Disable Welcome Notification\r\n6. Open whatever landing page and see source code, you should see something like this\r\n![notification_example_code](https://cloud.githubusercontent.com/assets/462477/20138043/5c446e66-a67e-11e6-8493-9de469564736.PNG)\r\n\r\n","created_at":"2016-11-07T21:08:08Z","updated_at":"2016-11-19T16:37:46Z","closed_at":"2016-11-19T16:37:46Z","merged_at":"2016-11-19T16:37:46Z","merge_commit_sha":"f4f64528e075c686805dd894ca33b97caf6f3304","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mautic/mautic/milestones/21","html_url":"https://github.com/mautic/mautic/milestones/2.3","labels_url":"https://api.github.com/repos/mautic/mautic/milestones/21/labels","id":2034542,"number":21,"title":"2.3","description":"","creator":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":5,"state":"open","created_at":"2016-09-28T11:59:00Z","updated_at":"2016-11-19T16:37:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mautic/mautic/pulls/2909/commits","review_comments_url":"https://api.github.com/repos/mautic/mautic/pulls/2909/comments","review_comment_url":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/2909/comments","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/89ec2d6714e9b2d23167ba60fd3de4b94a246948","head":{"label":"kuzmany:notication-manifest-to-config","ref":"notication-manifest-to-config","sha":"89ec2d6714e9b2d23167ba60fd3de4b94a246948","user":{"login":"kuzmany","id":462477,"avatar_url":"https://avatars.githubusercontent.com/u/462477?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzmany","html_url":"https://github.com/kuzmany","followers_url":"https://api.github.com/users/kuzmany/followers","following_url":"https://api.github.com/users/kuzmany/following{/other_user}","gists_url":"https://api.github.com/users/kuzmany/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzmany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzmany/subscriptions","organizations_url":"https://api.github.com/users/kuzmany/orgs","repos_url":"https://api.github.com/users/kuzmany/repos","events_url":"https://api.github.com/users/kuzmany/events{/privacy}","received_events_url":"https://api.github.com/users/kuzmany/received_events","type":"User","site_admin":false},"repo":{"id":53777141,"name":"mautic","full_name":"kuzmany/mautic","owner":{"login":"kuzmany","id":462477,"avatar_url":"https://avatars.githubusercontent.com/u/462477?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzmany","html_url":"https://github.com/kuzmany","followers_url":"https://api.github.com/users/kuzmany/followers","following_url":"https://api.github.com/users/kuzmany/following{/other_user}","gists_url":"https://api.github.com/users/kuzmany/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzmany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzmany/subscriptions","organizations_url":"https://api.github.com/users/kuzmany/orgs","repos_url":"https://api.github.com/users/kuzmany/repos","events_url":"https://api.github.com/users/kuzmany/events{/privacy}","received_events_url":"https://api.github.com/users/kuzmany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kuzmany/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":true,"url":"https://api.github.com/repos/kuzmany/mautic","forks_url":"https://api.github.com/repos/kuzmany/mautic/forks","keys_url":"https://api.github.com/repos/kuzmany/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzmany/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzmany/mautic/teams","hooks_url":"https://api.github.com/repos/kuzmany/mautic/hooks","issue_events_url":"https://api.github.com/repos/kuzmany/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/kuzmany/mautic/events","assignees_url":"https://api.github.com/repos/kuzmany/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/kuzmany/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/kuzmany/mautic/tags","blobs_url":"https://api.github.com/repos/kuzmany/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzmany/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzmany/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzmany/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzmany/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzmany/mautic/languages","stargazers_url":"https://api.github.com/repos/kuzmany/mautic/stargazers","contributors_url":"https://api.github.com/repos/kuzmany/mautic/contributors","subscribers_url":"https://api.github.com/repos/kuzmany/mautic/subscribers","subscription_url":"https://api.github.com/repos/kuzmany/mautic/subscription","commits_url":"https://api.github.com/repos/kuzmany/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzmany/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzmany/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzmany/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzmany/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/kuzmany/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzmany/mautic/merges","archive_url":"https://api.github.com/repos/kuzmany/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzmany/mautic/downloads","issues_url":"https://api.github.com/repos/kuzmany/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/kuzmany/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzmany/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzmany/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzmany/mautic/labels{/name}","releases_url":"https://api.github.com/repos/kuzmany/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/kuzmany/mautic/deployments","created_at":"2016-03-13T09:29:51Z","updated_at":"2016-03-13T09:29:56Z","pushed_at":"2016-11-19T16:31:03Z","git_url":"git://github.com/kuzmany/mautic.git","ssh_url":"git@github.com:kuzmany/mautic.git","clone_url":"https://github.com/kuzmany/mautic.git","svn_url":"https://github.com/kuzmany/mautic","homepage":"https://www.mautic.org","size":60453,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"mautic:staging","ref":"staging","sha":"afb4da4491ac2f12e8500d504906bd20f8ff47ee","user":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":12204147,"name":"mautic","full_name":"mautic/mautic","owner":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mautic/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":false,"url":"https://api.github.com/repos/mautic/mautic","forks_url":"https://api.github.com/repos/mautic/mautic/forks","keys_url":"https://api.github.com/repos/mautic/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/mautic/teams","hooks_url":"https://api.github.com/repos/mautic/mautic/hooks","issue_events_url":"https://api.github.com/repos/mautic/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/mautic/events","assignees_url":"https://api.github.com/repos/mautic/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/mautic/tags","blobs_url":"https://api.github.com/repos/mautic/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/mautic/languages","stargazers_url":"https://api.github.com/repos/mautic/mautic/stargazers","contributors_url":"https://api.github.com/repos/mautic/mautic/contributors","subscribers_url":"https://api.github.com/repos/mautic/mautic/subscribers","subscription_url":"https://api.github.com/repos/mautic/mautic/subscription","commits_url":"https://api.github.com/repos/mautic/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/mautic/merges","archive_url":"https://api.github.com/repos/mautic/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/mautic/downloads","issues_url":"https://api.github.com/repos/mautic/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/mautic/labels{/name}","releases_url":"https://api.github.com/repos/mautic/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/mautic/mautic/deployments","created_at":"2013-08-19T00:36:28Z","updated_at":"2016-11-18T19:27:11Z","pushed_at":"2016-11-19T16:37:46Z","git_url":"git://github.com/mautic/mautic.git","ssh_url":"git@github.com:mautic/mautic.git","clone_url":"https://github.com/mautic/mautic.git","svn_url":"https://github.com/mautic/mautic","homepage":"https://www.mautic.org","size":70668,"stargazers_count":1152,"watchers_count":1152,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"open_issues_count":625,"forks":410,"open_issues":625,"watchers":1152,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2909"},"html":{"href":"https://github.com/mautic/mautic/pull/2909"},"issue":{"href":"https://api.github.com/repos/mautic/mautic/issues/2909"},"comments":{"href":"https://api.github.com/repos/mautic/mautic/issues/2909/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2909/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2909/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/mautic/statuses/89ec2d6714e9b2d23167ba60fd3de4b94a246948"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"commits":8,"additions":41,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"escopecz"}}