{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/53673072","id":53673072,"diff_hunk":"@@ -38,6 +38,7 @@\n      */\n     public static final String GROUP_ID_CONFIG = \"group.id\";\n     private static final String GROUP_ID_DOC = \"A unique string that identifies the Connect cluster group this worker belongs to.\";\n+    private static final String GROUP_ID_CONFIG_DEFAULT = \"connect\";","path":"connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java","position":4,"original_position":4,"commit_id":"4608e7b9411e9368ebc04818a3c16b38a0d24617","original_commit_id":"4608e7b9411e9368ebc04818a3c16b38a0d24617","user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"body":"I wonder if it's a good idea to have a default for this and the storage topics below. It's convenient when getting started, but it also increases the chances for conflict since users might not know it needs to be unique. Thoughts?","created_at":"2016-02-22T18:56:35Z","updated_at":"2016-02-22T18:56:35Z","html_url":"https://github.com/apache/kafka/pull/734#discussion_r53673072","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/734","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/53673072"},"html":{"href":"https://github.com/apache/kafka/pull/734#discussion_r53673072"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/734"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/734","id":55096199,"html_url":"https://github.com/apache/kafka/pull/734","diff_url":"https://github.com/apache/kafka/pull/734.diff","patch_url":"https://github.com/apache/kafka/pull/734.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/734","number":734,"state":"open","locked":false,"title":"KAFKA-2934: Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig","user":{"login":"ZoneMayor","id":4058918,"avatar_url":"https://avatars.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoneMayor","html_url":"https://github.com/ZoneMayor","followers_url":"https://api.github.com/users/ZoneMayor/followers","following_url":"https://api.github.com/users/ZoneMayor/following{/other_user}","gists_url":"https://api.github.com/users/ZoneMayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoneMayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoneMayor/subscriptions","organizations_url":"https://api.github.com/users/ZoneMayor/orgs","repos_url":"https://api.github.com/users/ZoneMayor/repos","events_url":"https://api.github.com/users/ZoneMayor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoneMayor/received_events","type":"User","site_admin":false},"body":"Added offsetBackingStore config to StandaloneConfig and DistributedConfig;\r\nAdded config for offset.storage.topic and config.storage.topic into DistributedConfig;","created_at":"2016-01-05T14:24:09Z","updated_at":"2016-02-22T18:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48eb260fe78e6238b3c9dca71ca5d773c69e38fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/734/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/734/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/734/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/4608e7b9411e9368ebc04818a3c16b38a0d24617","head":{"label":"ZoneMayor:trunk-KAFKA-2934","ref":"trunk-KAFKA-2934","sha":"4608e7b9411e9368ebc04818a3c16b38a0d24617","user":{"login":"ZoneMayor","id":4058918,"avatar_url":"https://avatars.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoneMayor","html_url":"https://github.com/ZoneMayor","followers_url":"https://api.github.com/users/ZoneMayor/followers","following_url":"https://api.github.com/users/ZoneMayor/following{/other_user}","gists_url":"https://api.github.com/users/ZoneMayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoneMayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoneMayor/subscriptions","organizations_url":"https://api.github.com/users/ZoneMayor/orgs","repos_url":"https://api.github.com/users/ZoneMayor/repos","events_url":"https://api.github.com/users/ZoneMayor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoneMayor/received_events","type":"User","site_admin":false},"repo":{"id":46220223,"name":"kafka","full_name":"ZoneMayor/kafka","owner":{"login":"ZoneMayor","id":4058918,"avatar_url":"https://avatars.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoneMayor","html_url":"https://github.com/ZoneMayor","followers_url":"https://api.github.com/users/ZoneMayor/followers","following_url":"https://api.github.com/users/ZoneMayor/following{/other_user}","gists_url":"https://api.github.com/users/ZoneMayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoneMayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoneMayor/subscriptions","organizations_url":"https://api.github.com/users/ZoneMayor/orgs","repos_url":"https://api.github.com/users/ZoneMayor/repos","events_url":"https://api.github.com/users/ZoneMayor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoneMayor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZoneMayor/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ZoneMayor/kafka","forks_url":"https://api.github.com/repos/ZoneMayor/kafka/forks","keys_url":"https://api.github.com/repos/ZoneMayor/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZoneMayor/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZoneMayor/kafka/teams","hooks_url":"https://api.github.com/repos/ZoneMayor/kafka/hooks","issue_events_url":"https://api.github.com/repos/ZoneMayor/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ZoneMayor/kafka/events","assignees_url":"https://api.github.com/repos/ZoneMayor/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ZoneMayor/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ZoneMayor/kafka/tags","blobs_url":"https://api.github.com/repos/ZoneMayor/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZoneMayor/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZoneMayor/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZoneMayor/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZoneMayor/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ZoneMayor/kafka/languages","stargazers_url":"https://api.github.com/repos/ZoneMayor/kafka/stargazers","contributors_url":"https://api.github.com/repos/ZoneMayor/kafka/contributors","subscribers_url":"https://api.github.com/repos/ZoneMayor/kafka/subscribers","subscription_url":"https://api.github.com/repos/ZoneMayor/kafka/subscription","commits_url":"https://api.github.com/repos/ZoneMayor/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZoneMayor/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZoneMayor/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZoneMayor/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZoneMayor/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ZoneMayor/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZoneMayor/kafka/merges","archive_url":"https://api.github.com/repos/ZoneMayor/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZoneMayor/kafka/downloads","issues_url":"https://api.github.com/repos/ZoneMayor/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ZoneMayor/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ZoneMayor/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ZoneMayor/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZoneMayor/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ZoneMayor/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ZoneMayor/kafka/deployments","created_at":"2015-11-15T14:12:50Z","updated_at":"2015-12-18T07:21:30Z","pushed_at":"2016-02-21T08:40:04Z","git_url":"git://github.com/ZoneMayor/kafka.git","ssh_url":"git@github.com:ZoneMayor/kafka.git","clone_url":"https://github.com/ZoneMayor/kafka.git","svn_url":"https://github.com/ZoneMayor/kafka","homepage":null,"size":26329,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.7"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"5caa800e217c6b83f62ee3e6b5f02f56e331b309","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-02-22T08:50:49Z","pushed_at":"2016-02-22T18:43:39Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":34503,"stargazers_count":2660,"watchers_count":2660,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1601,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":137,"forks":1601,"open_issues":137,"watchers":2660,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/734"},"html":{"href":"https://github.com/apache/kafka/pull/734"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/734"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/734/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/734/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/734/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/4608e7b9411e9368ebc04818a3c16b38a0d24617"}}}}