{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2","id":19563906,"html_url":"https://github.com/krisajenkins/knapsack-haskell/pull/2","diff_url":"https://github.com/krisajenkins/knapsack-haskell/pull/2.diff","patch_url":"https://github.com/krisajenkins/knapsack-haskell/pull/2.patch","issue_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/2","number":2,"state":"closed","locked":false,"title":"Eliminate Costed typeclass","user":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"body":"Imagine that songs have both prices and durations, so you might want to\r\nknapsack them by duration into a time limit, or instead pack them by\r\nprice into a total budget.\r\n\r\nUsing a Costed typeclass for this, you're limited to a single instance\r\nof Costed per module, which is a code smell. The solution is to simply\r\nparameterise knapsack on the costing function, so that the Costed\r\ntypeclass becomes a regular type.","created_at":"2014-08-09T12:24:31Z","updated_at":"2016-06-26T02:06:26Z","closed_at":"2016-06-26T02:06:26Z","merged_at":null,"merge_commit_sha":"9b35af307018a22cec6568a07cfd6338e84ae319","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2/commits","review_comments_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2/comments","review_comment_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/2/comments","statuses_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/statuses/c54add625326899ea6ca1acc0b2360c561dadda7","head":{"label":"purcell:master","ref":"master","sha":"c54add625326899ea6ca1acc0b2360c561dadda7","user":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"repo":{"id":22506508,"name":"knapsack-haskell","full_name":"purcell/knapsack-haskell","owner":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purcell/knapsack-haskell","description":"The Knapsack Problem in Haskell","fork":true,"url":"https://api.github.com/repos/purcell/knapsack-haskell","forks_url":"https://api.github.com/repos/purcell/knapsack-haskell/forks","keys_url":"https://api.github.com/repos/purcell/knapsack-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purcell/knapsack-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purcell/knapsack-haskell/teams","hooks_url":"https://api.github.com/repos/purcell/knapsack-haskell/hooks","issue_events_url":"https://api.github.com/repos/purcell/knapsack-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/purcell/knapsack-haskell/events","assignees_url":"https://api.github.com/repos/purcell/knapsack-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/purcell/knapsack-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/purcell/knapsack-haskell/tags","blobs_url":"https://api.github.com/repos/purcell/knapsack-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purcell/knapsack-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purcell/knapsack-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/purcell/knapsack-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purcell/knapsack-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/purcell/knapsack-haskell/languages","stargazers_url":"https://api.github.com/repos/purcell/knapsack-haskell/stargazers","contributors_url":"https://api.github.com/repos/purcell/knapsack-haskell/contributors","subscribers_url":"https://api.github.com/repos/purcell/knapsack-haskell/subscribers","subscription_url":"https://api.github.com/repos/purcell/knapsack-haskell/subscription","commits_url":"https://api.github.com/repos/purcell/knapsack-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/purcell/knapsack-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/purcell/knapsack-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/purcell/knapsack-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/purcell/knapsack-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/purcell/knapsack-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purcell/knapsack-haskell/merges","archive_url":"https://api.github.com/repos/purcell/knapsack-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purcell/knapsack-haskell/downloads","issues_url":"https://api.github.com/repos/purcell/knapsack-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/purcell/knapsack-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/purcell/knapsack-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/purcell/knapsack-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purcell/knapsack-haskell/labels{/name}","releases_url":"https://api.github.com/repos/purcell/knapsack-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/purcell/knapsack-haskell/deployments","created_at":"2014-08-01T11:17:47Z","updated_at":"2014-08-09T12:22:34Z","pushed_at":"2014-08-10T14:35:18Z","git_url":"git://github.com/purcell/knapsack-haskell.git","ssh_url":"git@github.com:purcell/knapsack-haskell.git","clone_url":"https://github.com/purcell/knapsack-haskell.git","svn_url":"https://github.com/purcell/knapsack-haskell","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krisajenkins:master","ref":"master","sha":"acb185da821fe367c27d9dd25963d992d136a807","user":{"login":"krisajenkins","id":380756,"avatar_url":"https://avatars.githubusercontent.com/u/380756?v=3","gravatar_id":"","url":"https://api.github.com/users/krisajenkins","html_url":"https://github.com/krisajenkins","followers_url":"https://api.github.com/users/krisajenkins/followers","following_url":"https://api.github.com/users/krisajenkins/following{/other_user}","gists_url":"https://api.github.com/users/krisajenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/krisajenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisajenkins/subscriptions","organizations_url":"https://api.github.com/users/krisajenkins/orgs","repos_url":"https://api.github.com/users/krisajenkins/repos","events_url":"https://api.github.com/users/krisajenkins/events{/privacy}","received_events_url":"https://api.github.com/users/krisajenkins/received_events","type":"User","site_admin":false},"repo":{"id":22481698,"name":"knapsack-haskell","full_name":"krisajenkins/knapsack-haskell","owner":{"login":"krisajenkins","id":380756,"avatar_url":"https://avatars.githubusercontent.com/u/380756?v=3","gravatar_id":"","url":"https://api.github.com/users/krisajenkins","html_url":"https://github.com/krisajenkins","followers_url":"https://api.github.com/users/krisajenkins/followers","following_url":"https://api.github.com/users/krisajenkins/following{/other_user}","gists_url":"https://api.github.com/users/krisajenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/krisajenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisajenkins/subscriptions","organizations_url":"https://api.github.com/users/krisajenkins/orgs","repos_url":"https://api.github.com/users/krisajenkins/repos","events_url":"https://api.github.com/users/krisajenkins/events{/privacy}","received_events_url":"https://api.github.com/users/krisajenkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krisajenkins/knapsack-haskell","description":"The Knapsack Problem in Haskell","fork":false,"url":"https://api.github.com/repos/krisajenkins/knapsack-haskell","forks_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/forks","keys_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/teams","hooks_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/hooks","issue_events_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/events","assignees_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/tags","blobs_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/languages","stargazers_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/stargazers","contributors_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/contributors","subscribers_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/subscribers","subscription_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/subscription","commits_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/merges","archive_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/downloads","issues_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/labels{/name}","releases_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/krisajenkins/knapsack-haskell/deployments","created_at":"2014-07-31T19:21:05Z","updated_at":"2014-07-31T19:24:00Z","pushed_at":"2014-08-11T08:29:22Z","git_url":"git://github.com/krisajenkins/knapsack-haskell.git","ssh_url":"git@github.com:krisajenkins/knapsack-haskell.git","clone_url":"https://github.com/krisajenkins/knapsack-haskell.git","svn_url":"https://github.com/krisajenkins/knapsack-haskell","homepage":null,"size":249,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2"},"html":{"href":"https://github.com/krisajenkins/knapsack-haskell/pull/2"},"issue":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/2"},"comments":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/krisajenkins/knapsack-haskell/statuses/c54add625326899ea6ca1acc0b2360c561dadda7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":5,"additions":24,"deletions":30,"changed_files":1}}
{"actor":{"display_login":"purcell"}}