{"action":"closed","number":317,"pull_request":{"url":"https://api.github.com/repos/mapzen/styleguide/pulls/317","id":89881184,"html_url":"https://github.com/mapzen/styleguide/pull/317","diff_url":"https://github.com/mapzen/styleguide/pull/317.diff","patch_url":"https://github.com/mapzen/styleguide/pull/317.patch","issue_url":"https://api.github.com/repos/mapzen/styleguide/issues/317","number":317,"state":"closed","locked":false,"title":"new login nav","user":{"login":"hanbyul-here","id":4583806,"avatar_url":"https://avatars.githubusercontent.com/u/4583806?v=3","gravatar_id":"","url":"https://api.github.com/users/hanbyul-here","html_url":"https://github.com/hanbyul-here","followers_url":"https://api.github.com/users/hanbyul-here/followers","following_url":"https://api.github.com/users/hanbyul-here/following{/other_user}","gists_url":"https://api.github.com/users/hanbyul-here/gists{/gist_id}","starred_url":"https://api.github.com/users/hanbyul-here/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanbyul-here/subscriptions","organizations_url":"https://api.github.com/users/hanbyul-here/orgs","repos_url":"https://api.github.com/users/hanbyul-here/repos","events_url":"https://api.github.com/users/hanbyul-here/events{/privacy}","received_events_url":"https://api.github.com/users/hanbyul-here/received_events","type":"User","site_admin":false},"body":"- new nav reflecint user's login state\r\n- Since nav menus are not going to have straight href, `active-nav-link.js` to `main-nav.js`. `main-nav.js` does two things, 1.detecting user is logged in or not, manipulates dom. 2. detecting which tab should be active. It will be better to separate 2 function from 1 for future. \r\n- No affects until DOM part changes. \r\n- The example with new header is in `samples` folder (`blog-main-w-new-header.html`) ","created_at":"2016-10-18T19:20:43Z","updated_at":"2016-10-26T15:09:36Z","closed_at":"2016-10-26T15:09:36Z","merged_at":"2016-10-26T15:09:36Z","merge_commit_sha":"96b77ffd2cf543ca4f8f83de8d7620e187663d2b","assignee":{"login":"sleepylemur","id":5049698,"avatar_url":"https://avatars.githubusercontent.com/u/5049698?v=3","gravatar_id":"","url":"https://api.github.com/users/sleepylemur","html_url":"https://github.com/sleepylemur","followers_url":"https://api.github.com/users/sleepylemur/followers","following_url":"https://api.github.com/users/sleepylemur/following{/other_user}","gists_url":"https://api.github.com/users/sleepylemur/gists{/gist_id}","starred_url":"https://api.github.com/users/sleepylemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleepylemur/subscriptions","organizations_url":"https://api.github.com/users/sleepylemur/orgs","repos_url":"https://api.github.com/users/sleepylemur/repos","events_url":"https://api.github.com/users/sleepylemur/events{/privacy}","received_events_url":"https://api.github.com/users/sleepylemur/received_events","type":"User","site_admin":false},"assignees":[{"login":"sleepylemur","id":5049698,"avatar_url":"https://avatars.githubusercontent.com/u/5049698?v=3","gravatar_id":"","url":"https://api.github.com/users/sleepylemur","html_url":"https://github.com/sleepylemur","followers_url":"https://api.github.com/users/sleepylemur/followers","following_url":"https://api.github.com/users/sleepylemur/following{/other_user}","gists_url":"https://api.github.com/users/sleepylemur/gists{/gist_id}","starred_url":"https://api.github.com/users/sleepylemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleepylemur/subscriptions","organizations_url":"https://api.github.com/users/sleepylemur/orgs","repos_url":"https://api.github.com/users/sleepylemur/repos","events_url":"https://api.github.com/users/sleepylemur/events{/privacy}","received_events_url":"https://api.github.com/users/sleepylemur/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapzen/styleguide/pulls/317/commits","review_comments_url":"https://api.github.com/repos/mapzen/styleguide/pulls/317/comments","review_comment_url":"https://api.github.com/repos/mapzen/styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapzen/styleguide/issues/317/comments","statuses_url":"https://api.github.com/repos/mapzen/styleguide/statuses/70733d960197c315b89883017377eea137d82b9c","head":{"label":"mapzen:hanb/new-login-w-dropdown","ref":"hanb/new-login-w-dropdown","sha":"70733d960197c315b89883017377eea137d82b9c","user":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"repo":{"id":45061234,"name":"styleguide","full_name":"mapzen/styleguide","owner":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapzen/styleguide","description":"A living styleguide powering the Mapzen brand (TM)","fork":false,"url":"https://api.github.com/repos/mapzen/styleguide","forks_url":"https://api.github.com/repos/mapzen/styleguide/forks","keys_url":"https://api.github.com/repos/mapzen/styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapzen/styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapzen/styleguide/teams","hooks_url":"https://api.github.com/repos/mapzen/styleguide/hooks","issue_events_url":"https://api.github.com/repos/mapzen/styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/mapzen/styleguide/events","assignees_url":"https://api.github.com/repos/mapzen/styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/mapzen/styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/mapzen/styleguide/tags","blobs_url":"https://api.github.com/repos/mapzen/styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapzen/styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapzen/styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapzen/styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapzen/styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/mapzen/styleguide/languages","stargazers_url":"https://api.github.com/repos/mapzen/styleguide/stargazers","contributors_url":"https://api.github.com/repos/mapzen/styleguide/contributors","subscribers_url":"https://api.github.com/repos/mapzen/styleguide/subscribers","subscription_url":"https://api.github.com/repos/mapzen/styleguide/subscription","commits_url":"https://api.github.com/repos/mapzen/styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapzen/styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapzen/styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapzen/styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapzen/styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/mapzen/styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapzen/styleguide/merges","archive_url":"https://api.github.com/repos/mapzen/styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapzen/styleguide/downloads","issues_url":"https://api.github.com/repos/mapzen/styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/mapzen/styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/mapzen/styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/mapzen/styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapzen/styleguide/labels{/name}","releases_url":"https://api.github.com/repos/mapzen/styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/mapzen/styleguide/deployments","created_at":"2015-10-27T18:24:08Z","updated_at":"2016-03-28T16:46:35Z","pushed_at":"2016-10-26T15:09:36Z","git_url":"git://github.com/mapzen/styleguide.git","ssh_url":"git@github.com:mapzen/styleguide.git","clone_url":"https://github.com/mapzen/styleguide.git","svn_url":"https://github.com/mapzen/styleguide","homepage":"https://mapzen.com/common/styleguide","size":773,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":30,"forks":2,"open_issues":30,"watchers":2,"default_branch":"master"}},"base":{"label":"mapzen:master","ref":"master","sha":"6a018e597ec4d58c60d987dcbdd81dd8cb16e400","user":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"repo":{"id":45061234,"name":"styleguide","full_name":"mapzen/styleguide","owner":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapzen/styleguide","description":"A living styleguide powering the Mapzen brand (TM)","fork":false,"url":"https://api.github.com/repos/mapzen/styleguide","forks_url":"https://api.github.com/repos/mapzen/styleguide/forks","keys_url":"https://api.github.com/repos/mapzen/styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapzen/styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapzen/styleguide/teams","hooks_url":"https://api.github.com/repos/mapzen/styleguide/hooks","issue_events_url":"https://api.github.com/repos/mapzen/styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/mapzen/styleguide/events","assignees_url":"https://api.github.com/repos/mapzen/styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/mapzen/styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/mapzen/styleguide/tags","blobs_url":"https://api.github.com/repos/mapzen/styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapzen/styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapzen/styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapzen/styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapzen/styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/mapzen/styleguide/languages","stargazers_url":"https://api.github.com/repos/mapzen/styleguide/stargazers","contributors_url":"https://api.github.com/repos/mapzen/styleguide/contributors","subscribers_url":"https://api.github.com/repos/mapzen/styleguide/subscribers","subscription_url":"https://api.github.com/repos/mapzen/styleguide/subscription","commits_url":"https://api.github.com/repos/mapzen/styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapzen/styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapzen/styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapzen/styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapzen/styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/mapzen/styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapzen/styleguide/merges","archive_url":"https://api.github.com/repos/mapzen/styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapzen/styleguide/downloads","issues_url":"https://api.github.com/repos/mapzen/styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/mapzen/styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/mapzen/styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/mapzen/styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapzen/styleguide/labels{/name}","releases_url":"https://api.github.com/repos/mapzen/styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/mapzen/styleguide/deployments","created_at":"2015-10-27T18:24:08Z","updated_at":"2016-03-28T16:46:35Z","pushed_at":"2016-10-26T15:09:36Z","git_url":"git://github.com/mapzen/styleguide.git","ssh_url":"git@github.com:mapzen/styleguide.git","clone_url":"https://github.com/mapzen/styleguide.git","svn_url":"https://github.com/mapzen/styleguide","homepage":"https://mapzen.com/common/styleguide","size":773,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":30,"forks":2,"open_issues":30,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapzen/styleguide/pulls/317"},"html":{"href":"https://github.com/mapzen/styleguide/pull/317"},"issue":{"href":"https://api.github.com/repos/mapzen/styleguide/issues/317"},"comments":{"href":"https://api.github.com/repos/mapzen/styleguide/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/mapzen/styleguide/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/mapzen/styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapzen/styleguide/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/mapzen/styleguide/statuses/70733d960197c315b89883017377eea137d82b9c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hanbyul-here","id":4583806,"avatar_url":"https://avatars.githubusercontent.com/u/4583806?v=3","gravatar_id":"","url":"https://api.github.com/users/hanbyul-here","html_url":"https://github.com/hanbyul-here","followers_url":"https://api.github.com/users/hanbyul-here/followers","following_url":"https://api.github.com/users/hanbyul-here/following{/other_user}","gists_url":"https://api.github.com/users/hanbyul-here/gists{/gist_id}","starred_url":"https://api.github.com/users/hanbyul-here/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanbyul-here/subscriptions","organizations_url":"https://api.github.com/users/hanbyul-here/orgs","repos_url":"https://api.github.com/users/hanbyul-here/repos","events_url":"https://api.github.com/users/hanbyul-here/events{/privacy}","received_events_url":"https://api.github.com/users/hanbyul-here/received_events","type":"User","site_admin":false},"comments":9,"review_comments":2,"commits":18,"additions":1908,"deletions":59,"changed_files":8}}
{"actor":{"display_login":"hanbyul-here"}}