{"action":"created","comment":{"url":"https://api.github.com/repos/adrai/node-eventstore/pulls/comments/86745862","pull_request_review_id":7387003,"id":86745862,"diff_hunk":"@@ -821,7 +821,11 @@ describe('eventstore', function () {\n                   snapshotsTableName: 'snapshots' + token\n               }\n             }\n-\n+            if (type === 'redis') {\n+              options = {\n+                db: 3","path":"test/eventstoreTest.js","position":7,"original_position":7,"commit_id":"e94af5bddecaf82cfdefd7c9522f5752435af571","original_commit_id":"e94af5bddecaf82cfdefd7c9522f5752435af571","user":{"login":"adrai","id":1086194,"avatar_url":"https://avatars.githubusercontent.com/u/1086194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrai","html_url":"https://github.com/adrai","followers_url":"https://api.github.com/users/adrai/followers","following_url":"https://api.github.com/users/adrai/following{/other_user}","gists_url":"https://api.github.com/users/adrai/gists{/gist_id}","starred_url":"https://api.github.com/users/adrai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrai/subscriptions","organizations_url":"https://api.github.com/users/adrai/orgs","repos_url":"https://api.github.com/users/adrai/repos","events_url":"https://api.github.com/users/adrai/events{/privacy}","received_events_url":"https://api.github.com/users/adrai/received_events","type":"User","site_admin":false},"body":"it's ok, just to know it ;-)\r\n","created_at":"2016-11-07T10:18:43Z","updated_at":"2016-11-07T10:18:43Z","html_url":"https://github.com/adrai/node-eventstore/pull/91#discussion_r86745862","pull_request_url":"https://api.github.com/repos/adrai/node-eventstore/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/comments/86745862"},"html":{"href":"https://github.com/adrai/node-eventstore/pull/91#discussion_r86745862"},"pull_request":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/adrai/node-eventstore/pulls/91","id":92372715,"html_url":"https://github.com/adrai/node-eventstore/pull/91","diff_url":"https://github.com/adrai/node-eventstore/pull/91.diff","patch_url":"https://github.com/adrai/node-eventstore/pull/91.patch","issue_url":"https://api.github.com/repos/adrai/node-eventstore/issues/91","number":91,"state":"open","locked":false,"title":"improve event revision accuracy in redis, to avoid revisions duplications for an aggregate","user":{"login":"rehia","id":2240738,"avatar_url":"https://avatars.githubusercontent.com/u/2240738?v=3","gravatar_id":"","url":"https://api.github.com/users/rehia","html_url":"https://github.com/rehia","followers_url":"https://api.github.com/users/rehia/followers","following_url":"https://api.github.com/users/rehia/following{/other_user}","gists_url":"https://api.github.com/users/rehia/gists{/gist_id}","starred_url":"https://api.github.com/users/rehia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehia/subscriptions","organizations_url":"https://api.github.com/users/rehia/orgs","repos_url":"https://api.github.com/users/rehia/repos","events_url":"https://api.github.com/users/rehia/events{/privacy}","received_events_url":"https://api.github.com/users/rehia/received_events","type":"User","site_admin":false},"body":"instead of using last event revision, redis use a lua script so that revision is always accurate\r\nFixes #90","created_at":"2016-11-04T16:29:23Z","updated_at":"2016-11-07T10:18:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04d65c9fc32fa90108349d88f12e79eaedd7348d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adrai/node-eventstore/pulls/91/commits","review_comments_url":"https://api.github.com/repos/adrai/node-eventstore/pulls/91/comments","review_comment_url":"https://api.github.com/repos/adrai/node-eventstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adrai/node-eventstore/issues/91/comments","statuses_url":"https://api.github.com/repos/adrai/node-eventstore/statuses/e94af5bddecaf82cfdefd7c9522f5752435af571","head":{"label":"rehia:redis-revision","ref":"redis-revision","sha":"e94af5bddecaf82cfdefd7c9522f5752435af571","user":{"login":"rehia","id":2240738,"avatar_url":"https://avatars.githubusercontent.com/u/2240738?v=3","gravatar_id":"","url":"https://api.github.com/users/rehia","html_url":"https://github.com/rehia","followers_url":"https://api.github.com/users/rehia/followers","following_url":"https://api.github.com/users/rehia/following{/other_user}","gists_url":"https://api.github.com/users/rehia/gists{/gist_id}","starred_url":"https://api.github.com/users/rehia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehia/subscriptions","organizations_url":"https://api.github.com/users/rehia/orgs","repos_url":"https://api.github.com/users/rehia/repos","events_url":"https://api.github.com/users/rehia/events{/privacy}","received_events_url":"https://api.github.com/users/rehia/received_events","type":"User","site_admin":false},"repo":{"id":52787908,"name":"node-eventstore","full_name":"rehia/node-eventstore","owner":{"login":"rehia","id":2240738,"avatar_url":"https://avatars.githubusercontent.com/u/2240738?v=3","gravatar_id":"","url":"https://api.github.com/users/rehia","html_url":"https://github.com/rehia","followers_url":"https://api.github.com/users/rehia/followers","following_url":"https://api.github.com/users/rehia/following{/other_user}","gists_url":"https://api.github.com/users/rehia/gists{/gist_id}","starred_url":"https://api.github.com/users/rehia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehia/subscriptions","organizations_url":"https://api.github.com/users/rehia/orgs","repos_url":"https://api.github.com/users/rehia/repos","events_url":"https://api.github.com/users/rehia/events{/privacy}","received_events_url":"https://api.github.com/users/rehia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rehia/node-eventstore","description":"EventStore Implementation in node.js","fork":true,"url":"https://api.github.com/repos/rehia/node-eventstore","forks_url":"https://api.github.com/repos/rehia/node-eventstore/forks","keys_url":"https://api.github.com/repos/rehia/node-eventstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rehia/node-eventstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rehia/node-eventstore/teams","hooks_url":"https://api.github.com/repos/rehia/node-eventstore/hooks","issue_events_url":"https://api.github.com/repos/rehia/node-eventstore/issues/events{/number}","events_url":"https://api.github.com/repos/rehia/node-eventstore/events","assignees_url":"https://api.github.com/repos/rehia/node-eventstore/assignees{/user}","branches_url":"https://api.github.com/repos/rehia/node-eventstore/branches{/branch}","tags_url":"https://api.github.com/repos/rehia/node-eventstore/tags","blobs_url":"https://api.github.com/repos/rehia/node-eventstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rehia/node-eventstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rehia/node-eventstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rehia/node-eventstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rehia/node-eventstore/statuses/{sha}","languages_url":"https://api.github.com/repos/rehia/node-eventstore/languages","stargazers_url":"https://api.github.com/repos/rehia/node-eventstore/stargazers","contributors_url":"https://api.github.com/repos/rehia/node-eventstore/contributors","subscribers_url":"https://api.github.com/repos/rehia/node-eventstore/subscribers","subscription_url":"https://api.github.com/repos/rehia/node-eventstore/subscription","commits_url":"https://api.github.com/repos/rehia/node-eventstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rehia/node-eventstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rehia/node-eventstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rehia/node-eventstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/rehia/node-eventstore/contents/{+path}","compare_url":"https://api.github.com/repos/rehia/node-eventstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rehia/node-eventstore/merges","archive_url":"https://api.github.com/repos/rehia/node-eventstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rehia/node-eventstore/downloads","issues_url":"https://api.github.com/repos/rehia/node-eventstore/issues{/number}","pulls_url":"https://api.github.com/repos/rehia/node-eventstore/pulls{/number}","milestones_url":"https://api.github.com/repos/rehia/node-eventstore/milestones{/number}","notifications_url":"https://api.github.com/repos/rehia/node-eventstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rehia/node-eventstore/labels{/name}","releases_url":"https://api.github.com/repos/rehia/node-eventstore/releases{/id}","deployments_url":"https://api.github.com/repos/rehia/node-eventstore/deployments","created_at":"2016-02-29T12:00:43Z","updated_at":"2016-02-29T12:00:45Z","pushed_at":"2016-11-07T09:46:35Z","git_url":"git://github.com/rehia/node-eventstore.git","ssh_url":"git@github.com:rehia/node-eventstore.git","clone_url":"https://github.com/rehia/node-eventstore.git","svn_url":"https://github.com/rehia/node-eventstore","homepage":"http://eventstore.js.org/","size":902,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adrai:master","ref":"master","sha":"663fb9fc3d0765ae22196c1bff3ea9aa8e79b305","user":{"login":"adrai","id":1086194,"avatar_url":"https://avatars.githubusercontent.com/u/1086194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrai","html_url":"https://github.com/adrai","followers_url":"https://api.github.com/users/adrai/followers","following_url":"https://api.github.com/users/adrai/following{/other_user}","gists_url":"https://api.github.com/users/adrai/gists{/gist_id}","starred_url":"https://api.github.com/users/adrai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrai/subscriptions","organizations_url":"https://api.github.com/users/adrai/orgs","repos_url":"https://api.github.com/users/adrai/repos","events_url":"https://api.github.com/users/adrai/events{/privacy}","received_events_url":"https://api.github.com/users/adrai/received_events","type":"User","site_admin":false},"repo":{"id":2306324,"name":"node-eventstore","full_name":"adrai/node-eventstore","owner":{"login":"adrai","id":1086194,"avatar_url":"https://avatars.githubusercontent.com/u/1086194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrai","html_url":"https://github.com/adrai","followers_url":"https://api.github.com/users/adrai/followers","following_url":"https://api.github.com/users/adrai/following{/other_user}","gists_url":"https://api.github.com/users/adrai/gists{/gist_id}","starred_url":"https://api.github.com/users/adrai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrai/subscriptions","organizations_url":"https://api.github.com/users/adrai/orgs","repos_url":"https://api.github.com/users/adrai/repos","events_url":"https://api.github.com/users/adrai/events{/privacy}","received_events_url":"https://api.github.com/users/adrai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrai/node-eventstore","description":"EventStore Implementation in node.js","fork":false,"url":"https://api.github.com/repos/adrai/node-eventstore","forks_url":"https://api.github.com/repos/adrai/node-eventstore/forks","keys_url":"https://api.github.com/repos/adrai/node-eventstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrai/node-eventstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrai/node-eventstore/teams","hooks_url":"https://api.github.com/repos/adrai/node-eventstore/hooks","issue_events_url":"https://api.github.com/repos/adrai/node-eventstore/issues/events{/number}","events_url":"https://api.github.com/repos/adrai/node-eventstore/events","assignees_url":"https://api.github.com/repos/adrai/node-eventstore/assignees{/user}","branches_url":"https://api.github.com/repos/adrai/node-eventstore/branches{/branch}","tags_url":"https://api.github.com/repos/adrai/node-eventstore/tags","blobs_url":"https://api.github.com/repos/adrai/node-eventstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrai/node-eventstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrai/node-eventstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrai/node-eventstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrai/node-eventstore/statuses/{sha}","languages_url":"https://api.github.com/repos/adrai/node-eventstore/languages","stargazers_url":"https://api.github.com/repos/adrai/node-eventstore/stargazers","contributors_url":"https://api.github.com/repos/adrai/node-eventstore/contributors","subscribers_url":"https://api.github.com/repos/adrai/node-eventstore/subscribers","subscription_url":"https://api.github.com/repos/adrai/node-eventstore/subscription","commits_url":"https://api.github.com/repos/adrai/node-eventstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrai/node-eventstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrai/node-eventstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrai/node-eventstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrai/node-eventstore/contents/{+path}","compare_url":"https://api.github.com/repos/adrai/node-eventstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrai/node-eventstore/merges","archive_url":"https://api.github.com/repos/adrai/node-eventstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrai/node-eventstore/downloads","issues_url":"https://api.github.com/repos/adrai/node-eventstore/issues{/number}","pulls_url":"https://api.github.com/repos/adrai/node-eventstore/pulls{/number}","milestones_url":"https://api.github.com/repos/adrai/node-eventstore/milestones{/number}","notifications_url":"https://api.github.com/repos/adrai/node-eventstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrai/node-eventstore/labels{/name}","releases_url":"https://api.github.com/repos/adrai/node-eventstore/releases{/id}","deployments_url":"https://api.github.com/repos/adrai/node-eventstore/deployments","created_at":"2011-09-01T06:54:16Z","updated_at":"2016-11-04T06:16:54Z","pushed_at":"2016-11-07T09:46:35Z","git_url":"git://github.com/adrai/node-eventstore.git","ssh_url":"git@github.com:adrai/node-eventstore.git","clone_url":"https://github.com/adrai/node-eventstore.git","svn_url":"https://github.com/adrai/node-eventstore","homepage":"http://eventstore.js.org/","size":935,"stargazers_count":201,"watchers_count":201,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":13,"forks":56,"open_issues":13,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/91"},"html":{"href":"https://github.com/adrai/node-eventstore/pull/91"},"issue":{"href":"https://api.github.com/repos/adrai/node-eventstore/issues/91"},"comments":{"href":"https://api.github.com/repos/adrai/node-eventstore/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adrai/node-eventstore/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/adrai/node-eventstore/statuses/e94af5bddecaf82cfdefd7c9522f5752435af571"}}}}
{"actor":{"display_login":"adrai"}}