{"action":"created","issue":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/271","labels_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/271/comments","events_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/271/events","html_url":"https://github.com/makersacademy/airport_challenge/pull/271","id":128314059,"number":271,"title":"Airport Challenge","user":{"login":"seanhawkridge","id":1470147,"avatar_url":"https://avatars.githubusercontent.com/u/1470147?v=3","gravatar_id":"","url":"https://api.github.com/users/seanhawkridge","html_url":"https://github.com/seanhawkridge","followers_url":"https://api.github.com/users/seanhawkridge/followers","following_url":"https://api.github.com/users/seanhawkridge/following{/other_user}","gists_url":"https://api.github.com/users/seanhawkridge/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhawkridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhawkridge/subscriptions","organizations_url":"https://api.github.com/users/seanhawkridge/orgs","repos_url":"https://api.github.com/users/seanhawkridge/repos","events_url":"https://api.github.com/users/seanhawkridge/events{/privacy}","received_events_url":"https://api.github.com/users/seanhawkridge/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/makersacademy/airport_challenge/labels/QA","name":"QA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-23T08:29:01Z","updated_at":"2016-01-25T12:10:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/271","html_url":"https://github.com/makersacademy/airport_challenge/pull/271","diff_url":"https://github.com/makersacademy/airport_challenge/pull/271.diff","patch_url":"https://github.com/makersacademy/airport_challenge/pull/271.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/comments/174487259","html_url":"https://github.com/makersacademy/airport_challenge/pull/271#issuecomment-174487259","issue_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/271","id":174487259,"user":{"login":"mechacoach","id":14219150,"avatar_url":"https://avatars.githubusercontent.com/u/14219150?v=3","gravatar_id":"","url":"https://api.github.com/users/mechacoach","html_url":"https://github.com/mechacoach","followers_url":"https://api.github.com/users/mechacoach/followers","following_url":"https://api.github.com/users/mechacoach/following{/other_user}","gists_url":"https://api.github.com/users/mechacoach/gists{/gist_id}","starred_url":"https://api.github.com/users/mechacoach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mechacoach/subscriptions","organizations_url":"https://api.github.com/users/mechacoach/orgs","repos_url":"https://api.github.com/users/mechacoach/repos","events_url":"https://api.github.com/users/mechacoach/events{/privacy}","received_events_url":"https://api.github.com/users/mechacoach/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T12:10:25Z","updated_at":"2016-01-25T12:10:25Z","body":"You had your airport_challenge reviewed by **Tristan Crossley**\n\n### The good points are:\n\n* Overview of project in the README\n* `context` or `describe` blocks are used (where appropriate) to group tests\n* The solution avoids vacuous tests\n* `before` blocks are used where appropriate\n* There are a minimal number of untested paths in the code\n* Unit tests all have single expectations\n* Random behaviour is stubbed where appropriate\n* The code follows Ruby naming conventions, Readability is supported by consistent naming\n* Guard clauses are used where appropriate, Booleans are returned implicitly where appropriate, removeallcommented-outcode: There is no commented-out code in the submission\n* Code avoids unnecessary public methods, Code avoids public access to internal objects (e.g. planes array)\n* Classes have single responsibilities, Each methods has a single responsibility\n* Code avoids strings where it should use symbols\n* Command/Query naming is not an issue in the code\n* The solution does not have any redundant code\n\n### You should consider the following improvements:\n\n* Installation Instructions should be in the README\n* Use named subject with `described_class`\n* Get rid of redundant `respond_to` expectations\n* Remove all commented-out code\n* Avoid magic numbers (e.g. on capacity)\n* Improper use of attr_*\n\n### Additional comments:\nVery concise and readable code. Amazing work!, avoidmagicnumberse.g.oncapacity: Code avoids magic numbers\n\nsee https://github.com/makersacademy/airport_challenge/blob/master/docs/review.md for more details\n"}}