{"action":"created","issue":{"url":"https://api.github.com/repos/WheatonCS/Lexos/issues/393","repository_url":"https://api.github.com/repos/WheatonCS/Lexos","labels_url":"https://api.github.com/repos/WheatonCS/Lexos/issues/393/labels{/name}","comments_url":"https://api.github.com/repos/WheatonCS/Lexos/issues/393/comments","events_url":"https://api.github.com/repos/WheatonCS/Lexos/issues/393/events","html_url":"https://github.com/WheatonCS/Lexos/issues/393","id":162354354,"number":393,"title":"Remove All Punctuation on scrub page causing problems related to tags","user":{"login":"chantisnake","id":10100995,"avatar_url":"https://avatars.githubusercontent.com/u/10100995?v=3","gravatar_id":"","url":"https://api.github.com/users/chantisnake","html_url":"https://github.com/chantisnake","followers_url":"https://api.github.com/users/chantisnake/followers","following_url":"https://api.github.com/users/chantisnake/following{/other_user}","gists_url":"https://api.github.com/users/chantisnake/gists{/gist_id}","starred_url":"https://api.github.com/users/chantisnake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantisnake/subscriptions","organizations_url":"https://api.github.com/users/chantisnake/orgs","repos_url":"https://api.github.com/users/chantisnake/repos","events_url":"https://api.github.com/users/chantisnake/events{/privacy}","received_events_url":"https://api.github.com/users/chantisnake/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-26T23:46:44Z","updated_at":"2016-06-27T00:09:29Z","closed_at":null,"body":"Please give us some of the following information, \r\nThat will be really helpful to track the bug:\r\n\r\n* **if you are proposing an enhancement, please delete all of these**\r\n\r\n### which option did I check\r\n`Remove All Punctuation` and `Remove Tags`(probably should be called handle tag)\r\n\r\n### which file did I use\r\nGen AB\r\n\r\n### what the bug looks like\r\nthe `Remove All Punctuation` removes punctuation within the tag, therefore damage the following info in the tag:\r\n  - the closing tag (`</a>` turns into `<a>` after scrub)\r\n  - the attribute in the tag (`<a name='test'>` turns into `<a nametest>` after scrub)\r\n  - even the tag name itself. (`<tei.2>` turns into `<tei>` after scrub)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/WheatonCS/Lexos/issues/comments/228631649","html_url":"https://github.com/WheatonCS/Lexos/issues/393#issuecomment-228631649","issue_url":"https://api.github.com/repos/WheatonCS/Lexos/issues/393","id":228631649,"user":{"login":"scottkleinman","id":1125917,"avatar_url":"https://avatars.githubusercontent.com/u/1125917?v=3","gravatar_id":"","url":"https://api.github.com/users/scottkleinman","html_url":"https://github.com/scottkleinman","followers_url":"https://api.github.com/users/scottkleinman/followers","following_url":"https://api.github.com/users/scottkleinman/following{/other_user}","gists_url":"https://api.github.com/users/scottkleinman/gists{/gist_id}","starred_url":"https://api.github.com/users/scottkleinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottkleinman/subscriptions","organizations_url":"https://api.github.com/users/scottkleinman/orgs","repos_url":"https://api.github.com/users/scottkleinman/repos","events_url":"https://api.github.com/users/scottkleinman/events{/privacy}","received_events_url":"https://api.github.com/users/scottkleinman/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T00:09:29Z","updated_at":"2016-06-27T00:09:29Z","body":"The best way to do that would be to use an xml parser. But my point is that it is easiest to advise the user to scrub in two steps. First, remove tags without any other scrubbing options. Then scrub again with options like removing punctuation and converting to lower case. They should really be separate processes. It's possible that the user could leave in markup that would be affected by the subsequent scrubbing, but it's unlikely if they are forewarned."}}
{"actor":{"display_login":"scottkleinman"}}