{"action":"created","comment":{"url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/comments/58425275","id":58425275,"diff_hunk":"@@ -197,18 +186,23 @@ interface ISignal<T, U> {\n  */\n export\n function disconnectSender(sender: any): void {\n-  let list = senderMap.get(sender);\n-  if (!list) {\n+  // If there are no receivers, there is nothing to do.\n+  let receiverList = senderData.get(sender);\n+  if (receiverList === void 0) {\n     return;\n   }\n-  let conn = list.first;\n-  while (conn !== null) {\n-    removeFromSendersList(conn);\n-    conn.callback = null;\n-    conn.thisArg = null;\n-    conn = conn.nextReceiver;\n+\n+  // Clear the connections and schedule a cleanup of the\n+  // receiver's corresponding list of sender connections.\n+  for (let i = 0, n = receiverList.length; i < n; ++i) {","path":"src/patterns/signaling.ts","position":267,"original_position":267,"commit_id":"5191a01ebe22ee9ad21bfd16654a1d13f7803a15","original_commit_id":"5191a01ebe22ee9ad21bfd16654a1d13f7803a15","user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars.githubusercontent.com/u/137289?v=3","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"body":"Yes on both fronts :)","created_at":"2016-04-04T18:37:27Z","updated_at":"2016-04-04T18:37:27Z","html_url":"https://github.com/phosphorjs/phosphor-core/pull/25#discussion_r58425275","pull_request_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/comments/58425275"},"html":{"href":"https://github.com/phosphorjs/phosphor-core/pull/25#discussion_r58425275"},"pull_request":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25","id":65059184,"html_url":"https://github.com/phosphorjs/phosphor-core/pull/25","diff_url":"https://github.com/phosphorjs/phosphor-core/pull/25.diff","patch_url":"https://github.com/phosphorjs/phosphor-core/pull/25.patch","issue_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/25","number":25,"state":"open","locked":false,"title":"Feature signaling-2","user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars.githubusercontent.com/u/137289?v=3","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"body":"This is ready for review. Probably better to just look at the `src/patterns/signaling.ts` file rather than the diff.\r\n\r\nThe public API reflects our discussions. The internal implementation is now also much simpler. \r\n\r\nping @blink1073 @dwillmer @afshin @jasongrout","created_at":"2016-04-03T04:52:15Z","updated_at":"2016-04-04T18:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33e4509a2b5f9619a4af13efcf884f7e10afb0d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25/commits","review_comments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25/comments","review_comment_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/25/comments","statuses_url":"https://api.github.com/repos/phosphorjs/phosphor-core/statuses/5191a01ebe22ee9ad21bfd16654a1d13f7803a15","head":{"label":"phosphorjs:feature-signaling2","ref":"feature-signaling2","sha":"5191a01ebe22ee9ad21bfd16654a1d13f7803a15","user":{"login":"phosphorjs","id":9534026,"avatar_url":"https://avatars.githubusercontent.com/u/9534026?v=3","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"repo":{"id":52226433,"name":"phosphor-core","full_name":"phosphorjs/phosphor-core","owner":{"login":"phosphorjs","id":9534026,"avatar_url":"https://avatars.githubusercontent.com/u/9534026?v=3","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phosphorjs/phosphor-core","description":"The core non-ui functionality of the PhosphorJS project.","fork":false,"url":"https://api.github.com/repos/phosphorjs/phosphor-core","forks_url":"https://api.github.com/repos/phosphorjs/phosphor-core/forks","keys_url":"https://api.github.com/repos/phosphorjs/phosphor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phosphorjs/phosphor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phosphorjs/phosphor-core/teams","hooks_url":"https://api.github.com/repos/phosphorjs/phosphor-core/hooks","issue_events_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/events{/number}","events_url":"https://api.github.com/repos/phosphorjs/phosphor-core/events","assignees_url":"https://api.github.com/repos/phosphorjs/phosphor-core/assignees{/user}","branches_url":"https://api.github.com/repos/phosphorjs/phosphor-core/branches{/branch}","tags_url":"https://api.github.com/repos/phosphorjs/phosphor-core/tags","blobs_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phosphorjs/phosphor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/phosphorjs/phosphor-core/languages","stargazers_url":"https://api.github.com/repos/phosphorjs/phosphor-core/stargazers","contributors_url":"https://api.github.com/repos/phosphorjs/phosphor-core/contributors","subscribers_url":"https://api.github.com/repos/phosphorjs/phosphor-core/subscribers","subscription_url":"https://api.github.com/repos/phosphorjs/phosphor-core/subscription","commits_url":"https://api.github.com/repos/phosphorjs/phosphor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phosphorjs/phosphor-core/contents/{+path}","compare_url":"https://api.github.com/repos/phosphorjs/phosphor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phosphorjs/phosphor-core/merges","archive_url":"https://api.github.com/repos/phosphorjs/phosphor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phosphorjs/phosphor-core/downloads","issues_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues{/number}","pulls_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/phosphorjs/phosphor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/phosphorjs/phosphor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phosphorjs/phosphor-core/labels{/name}","releases_url":"https://api.github.com/repos/phosphorjs/phosphor-core/releases{/id}","deployments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/deployments","created_at":"2016-02-21T20:30:18Z","updated_at":"2016-03-03T08:37:07Z","pushed_at":"2016-04-04T14:28:29Z","git_url":"git://github.com/phosphorjs/phosphor-core.git","ssh_url":"git@github.com:phosphorjs/phosphor-core.git","clone_url":"https://github.com/phosphorjs/phosphor-core.git","svn_url":"https://github.com/phosphorjs/phosphor-core","homepage":null,"size":251,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"phosphorjs:master","ref":"master","sha":"4822b0c1af15b54db9c42b5a80837b1a52c9c84f","user":{"login":"phosphorjs","id":9534026,"avatar_url":"https://avatars.githubusercontent.com/u/9534026?v=3","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"repo":{"id":52226433,"name":"phosphor-core","full_name":"phosphorjs/phosphor-core","owner":{"login":"phosphorjs","id":9534026,"avatar_url":"https://avatars.githubusercontent.com/u/9534026?v=3","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phosphorjs/phosphor-core","description":"The core non-ui functionality of the PhosphorJS project.","fork":false,"url":"https://api.github.com/repos/phosphorjs/phosphor-core","forks_url":"https://api.github.com/repos/phosphorjs/phosphor-core/forks","keys_url":"https://api.github.com/repos/phosphorjs/phosphor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phosphorjs/phosphor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phosphorjs/phosphor-core/teams","hooks_url":"https://api.github.com/repos/phosphorjs/phosphor-core/hooks","issue_events_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/events{/number}","events_url":"https://api.github.com/repos/phosphorjs/phosphor-core/events","assignees_url":"https://api.github.com/repos/phosphorjs/phosphor-core/assignees{/user}","branches_url":"https://api.github.com/repos/phosphorjs/phosphor-core/branches{/branch}","tags_url":"https://api.github.com/repos/phosphorjs/phosphor-core/tags","blobs_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phosphorjs/phosphor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/phosphorjs/phosphor-core/languages","stargazers_url":"https://api.github.com/repos/phosphorjs/phosphor-core/stargazers","contributors_url":"https://api.github.com/repos/phosphorjs/phosphor-core/contributors","subscribers_url":"https://api.github.com/repos/phosphorjs/phosphor-core/subscribers","subscription_url":"https://api.github.com/repos/phosphorjs/phosphor-core/subscription","commits_url":"https://api.github.com/repos/phosphorjs/phosphor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phosphorjs/phosphor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phosphorjs/phosphor-core/contents/{+path}","compare_url":"https://api.github.com/repos/phosphorjs/phosphor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phosphorjs/phosphor-core/merges","archive_url":"https://api.github.com/repos/phosphorjs/phosphor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phosphorjs/phosphor-core/downloads","issues_url":"https://api.github.com/repos/phosphorjs/phosphor-core/issues{/number}","pulls_url":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/phosphorjs/phosphor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/phosphorjs/phosphor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phosphorjs/phosphor-core/labels{/name}","releases_url":"https://api.github.com/repos/phosphorjs/phosphor-core/releases{/id}","deployments_url":"https://api.github.com/repos/phosphorjs/phosphor-core/deployments","created_at":"2016-02-21T20:30:18Z","updated_at":"2016-03-03T08:37:07Z","pushed_at":"2016-04-04T14:28:29Z","git_url":"git://github.com/phosphorjs/phosphor-core.git","ssh_url":"git@github.com:phosphorjs/phosphor-core.git","clone_url":"https://github.com/phosphorjs/phosphor-core.git","svn_url":"https://github.com/phosphorjs/phosphor-core","homepage":null,"size":251,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25"},"html":{"href":"https://github.com/phosphorjs/phosphor-core/pull/25"},"issue":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/25"},"comments":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/phosphorjs/phosphor-core/statuses/5191a01ebe22ee9ad21bfd16654a1d13f7803a15"}}}}