{"action":"created","comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/comments/76811423","id":76811423,"diff_hunk":"@@ -1,10 +1,11 @@\n-.imageblock(id=@id class=[@style,role]\n-    style=[(\"text-align: #{attr :align}\" if attr? :align),(\"float: #{attr :float}\" if attr? :float)].compact.join('; '))\n-  .content\n-    - if attr? :link\n-      a.image href=(attr :link)\n+- unless attr(1) == 'background' || attr(1) == \"canvas\"\n+  .imageblock(id=@id class=[@style,role]","path":"templates/slim/block_image.html.slim","position":7,"original_position":7,"commit_id":"2e5a460f31cfaaa02b7557ef6a970d599d48a6c4","original_commit_id":"2e5a460f31cfaaa02b7557ef6a970d599d48a6c4","user":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"body":"I have to admit, I don't know what `@style` does and where it comes from... I just copied and pasted stuff around. I'm a sham. ;)","created_at":"2016-08-30T14:53:32Z","updated_at":"2016-08-30T14:53:32Z","html_url":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52#discussion_r76811423","pull_request_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/comments/76811423"},"html":{"href":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52#discussion_r76811423"},"pull_request":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52","id":46857426,"html_url":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52","diff_url":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52.diff","patch_url":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/52","number":52,"state":"open","locked":false,"title":"data-background attributes rework","user":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"body":"Integrated the work in #38 and the ideas I proposed in #34 for background image support as block image attributes. The PoC is there but the documentation is missing, I'll be waiting on feedback. There are suboptimal and non-rubyish things in there since I'm not familiar with that language.\r\n\r\nBreaking changes:\r\n\r\n* `data-background-image` is now `background` referring to the CSS attribute that reveal.js supports\r\n* similarily, `data-transition`, `data-transition-speed`, `data-background-size`,  `data-background-repeat`, `data-background-transition` all lost their data- prefix since it was not required and seen as redundant (see #38 and #18)\r\n* `:imagesdir:` is now honored on background attribute making image handling more consistent\r\n\r\nTODO:\r\n* [x] in addition to `background`, `canvas` should be supported when looking for background images\r\n* [x] doc: background image URLs work\r\n* [x] doc: background is now relative to :imagesdir: if set\r\n* [x] doc: attributes supports whatever CSS supports\r\n* [x] document new syntax format\r\n* [x] link to https://github.com/hakimel/reveal.js/#slide-backgrounds, https://github.com/hakimel/reveal.js/#slide-transitions\r\n* [x] ~~link to the relevant moz doc attributes since reveal.js hasn't documented them~~ upstream did it\r\n\r\nI pushed my test slides so you can try to reproduce in your environments: \r\n* with section attributes: https://github.com/obilodeau/my-asciidoctor-tests/blob/master/data-background-oldstyle.adoc\r\n* with new block image background attribute syntax: https://github.com/obilodeau/my-asciidoctor-tests/blob/master/data-background-newstyle.adoc\r\n\r\nIf accepted, I'll merge Dan's title-slide work and apply the same block_image syntax too.\r\n\r\nEdit: added elements to doc TODO","created_at":"2015-10-06T02:46:31Z","updated_at":"2016-08-30T14:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"857a2a7348519253e4a9920124bc0b37e12ab10c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/52/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/statuses/2e5a460f31cfaaa02b7557ef6a970d599d48a6c4","head":{"label":"obilodeau:data-background-rework","ref":"data-background-rework","sha":"2e5a460f31cfaaa02b7557ef6a970d599d48a6c4","user":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"repo":{"id":38165980,"name":"asciidoctor-reveal.js","full_name":"obilodeau/asciidoctor-reveal.js","owner":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obilodeau/asciidoctor-reveal.js","description":"reveal.js backend templates for Asciidoctor, implemented in Slim","fork":true,"url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js","forks_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/forks","keys_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/teams","hooks_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/hooks","issue_events_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/issues/events{/number}","events_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/events","assignees_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/assignees{/user}","branches_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/branches{/branch}","tags_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/tags","blobs_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/statuses/{sha}","languages_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/languages","stargazers_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/stargazers","contributors_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/contributors","subscribers_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/subscribers","subscription_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/subscription","commits_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/contents/{+path}","compare_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/merges","archive_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/downloads","issues_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/issues{/number}","pulls_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/pulls{/number}","milestones_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/milestones{/number}","notifications_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/labels{/name}","releases_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/releases{/id}","deployments_url":"https://api.github.com/repos/obilodeau/asciidoctor-reveal.js/deployments","created_at":"2015-06-27T16:01:43Z","updated_at":"2016-03-12T21:06:59Z","pushed_at":"2016-08-29T17:49:48Z","git_url":"git://github.com/obilodeau/asciidoctor-reveal.js.git","ssh_url":"git@github.com:obilodeau/asciidoctor-reveal.js.git","clone_url":"https://github.com/obilodeau/asciidoctor-reveal.js.git","svn_url":"https://github.com/obilodeau/asciidoctor-reveal.js","homepage":"http://asciidoctor.org","size":1217,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:master","ref":"master","sha":"e996e4403c426933fd55a944959949ae7c31dbcb","user":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":25130822,"name":"asciidoctor-reveal.js","full_name":"asciidoctor/asciidoctor-reveal.js","owner":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asciidoctor/asciidoctor-reveal.js","description":"reveal.js backend templates for Asciidoctor, implemented in Slim","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/releases{/id}","deployments_url":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/deployments","created_at":"2014-10-12T20:15:53Z","updated_at":"2016-08-23T07:29:12Z","pushed_at":"2016-08-29T19:07:52Z","git_url":"git://github.com/asciidoctor/asciidoctor-reveal.js.git","ssh_url":"git@github.com:asciidoctor/asciidoctor-reveal.js.git","clone_url":"https://github.com/asciidoctor/asciidoctor-reveal.js.git","svn_url":"https://github.com/asciidoctor/asciidoctor-reveal.js","homepage":"http://asciidoctor.org","size":2264,"stargazers_count":35,"watchers_count":35,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":34,"forks":41,"open_issues":34,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52"},"html":{"href":"https://github.com/asciidoctor/asciidoctor-reveal.js/pull/52"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/52"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor-reveal.js/statuses/2e5a460f31cfaaa02b7557ef6a970d599d48a6c4"}}}}
{"actor":{"display_login":"obilodeau"}}