{"action":"closed","number":2120,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/2120","id":94553983,"html_url":"https://github.com/aframevr/aframe/pull/2120","diff_url":"https://github.com/aframevr/aframe/pull/2120.diff","patch_url":"https://github.com/aframevr/aframe/pull/2120.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/2120","number":2120,"state":"closed","locked":false,"title":"Fix material update referencing the sceneEl when it has not loaded","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"body":"This bug was unveiled by the inspector. The material update method was triggering a `sceneEl.addBehaviour(self)`. If the entity has not loaded there's no reference to `sceneEl`. It turns that that call was also unnecessary since the `play` / `pause` methods will take care of adding / removing the behavior when appropriate. I made sure that the sky shader example still works since it uses a property with `time` type. This is an example that reproduces the bug ![bug](https://d3vv6lp55qjaqc.cloudfront.net/items/2M3E3G3K2u0m0W0F0o0I/Image%202016-11-20%20at%208.47.28%20PM.png?X-CloudApp-Visitor-Id=9d04ec9f60e3cd874a1089e40fcaad60&v=8d11f4b3)\r\n\r\n","created_at":"2016-11-21T04:48:55Z","updated_at":"2016-11-23T02:50:01Z","closed_at":"2016-11-23T02:50:01Z","merged_at":"2016-11-23T02:50:01Z","merge_commit_sha":"03fcd0e1b662209770445151c36be93efbfa7219","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/2120/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/2120/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2120/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/015b2ce6eb1a20bcc3c20b36adcabc2d7794173e","head":{"label":"dmarcos:fixMaterialUpdate","ref":"fixMaterialUpdate","sha":"015b2ce6eb1a20bcc3c20b36adcabc2d7794173e","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"repo":{"id":49595885,"name":"aframe","full_name":"dmarcos/aframe","owner":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmarcos/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/dmarcos/aframe","forks_url":"https://api.github.com/repos/dmarcos/aframe/forks","keys_url":"https://api.github.com/repos/dmarcos/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmarcos/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmarcos/aframe/teams","hooks_url":"https://api.github.com/repos/dmarcos/aframe/hooks","issue_events_url":"https://api.github.com/repos/dmarcos/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/dmarcos/aframe/events","assignees_url":"https://api.github.com/repos/dmarcos/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/dmarcos/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/dmarcos/aframe/tags","blobs_url":"https://api.github.com/repos/dmarcos/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmarcos/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmarcos/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmarcos/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmarcos/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/dmarcos/aframe/languages","stargazers_url":"https://api.github.com/repos/dmarcos/aframe/stargazers","contributors_url":"https://api.github.com/repos/dmarcos/aframe/contributors","subscribers_url":"https://api.github.com/repos/dmarcos/aframe/subscribers","subscription_url":"https://api.github.com/repos/dmarcos/aframe/subscription","commits_url":"https://api.github.com/repos/dmarcos/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmarcos/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmarcos/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmarcos/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmarcos/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/dmarcos/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmarcos/aframe/merges","archive_url":"https://api.github.com/repos/dmarcos/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmarcos/aframe/downloads","issues_url":"https://api.github.com/repos/dmarcos/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/dmarcos/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/dmarcos/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/dmarcos/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmarcos/aframe/labels{/name}","releases_url":"https://api.github.com/repos/dmarcos/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/dmarcos/aframe/deployments","created_at":"2016-01-13T19:17:26Z","updated_at":"2016-01-13T19:17:26Z","pushed_at":"2016-11-21T04:44:08Z","git_url":"git://github.com/dmarcos/aframe.git","ssh_url":"git@github.com:dmarcos/aframe.git","clone_url":"https://github.com/dmarcos/aframe.git","svn_url":"https://github.com/dmarcos/aframe","homepage":"https://aframe.io/","size":127603,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"626ba85486fa036a7e6a6d409370ef24f61deeb5","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"A web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-11-23T02:49:00Z","pushed_at":"2016-11-23T02:50:01Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":155431,"stargazers_count":3981,"watchers_count":3981,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":786,"mirror_url":null,"open_issues_count":211,"forks":786,"open_issues":211,"watchers":3981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2120"},"html":{"href":"https://github.com/aframevr/aframe/pull/2120"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2120"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2120/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2120/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2120/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/015b2ce6eb1a20bcc3c20b36adcabc2d7794173e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"ngokevin"}}