{"action":"created","comment":{"url":"https://api.github.com/repos/magfest/ubersystem/pulls/comments/67127968","id":67127968,"diff_hunk":"@@ -205,7 +150,39 @@\n                             </ul>\n                         </li>\n                     </ul>\n-                    <ul class=\"nav navbar-nav\" id=\"main-menu\"></ul>\n+                    {% block mainmenu %}\n+                    <ul class=\"nav navbar-nav\" id=\"main-menu\">\n+                        {% block mainmenu_items %}\n+                        {% for menu_item in c.MENU_JSON_DECODED %}\n+                            {% if menu_item.href %}\n+                                <li><a href=\"{{ menu_item.href }}\">{{ menu_item.name }}</a></li>\n+                            {% elif menu_item.submenu %}\n+\n+                                <li class=\"dropdown\">\n+                                    <a href=\"#\" class=\"dropdown-toggle\" data-toggle=\"dropdown\">\n+                                        {{  menu_item.name }}\n+                                        <span class=\"caret\"></span>\n+                                    </a>\n+\n+                                    <ul class=\"dropdown-menu\" role=\"menu\">\n+                                    {% for submenu_item in menu_item.submenu %}\n+                                        <li>\n+                                            {% if not submenu_item.href %}","path":"uber/templates/base.html","position":91,"original_position":91,"commit_id":"a26d4217f3024aacd89e9c1b4ccd8377a7e17d90","original_commit_id":"a26d4217f3024aacd89e9c1b4ccd8377a7e17d90","user":{"login":"kitsuta","id":7198215,"avatar_url":"https://avatars.githubusercontent.com/u/7198215?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsuta","html_url":"https://github.com/kitsuta","followers_url":"https://api.github.com/users/kitsuta/followers","following_url":"https://api.github.com/users/kitsuta/following{/other_user}","gists_url":"https://api.github.com/users/kitsuta/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsuta/subscriptions","organizations_url":"https://api.github.com/users/kitsuta/orgs","repos_url":"https://api.github.com/users/kitsuta/repos","events_url":"https://api.github.com/users/kitsuta/events{/privacy}","received_events_url":"https://api.github.com/users/kitsuta/received_events","type":"User","site_admin":false},"body":"I think you mean `if submenu_item.href` here, not `if not`.","created_at":"2016-06-15T09:24:21Z","updated_at":"2016-06-15T09:24:21Z","html_url":"https://github.com/magfest/ubersystem/pull/1857#discussion_r67127968","pull_request_url":"https://api.github.com/repos/magfest/ubersystem/pulls/1857","_links":{"self":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/comments/67127968"},"html":{"href":"https://github.com/magfest/ubersystem/pull/1857#discussion_r67127968"},"pull_request":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/1857"}}},"pull_request":{"url":"https://api.github.com/repos/magfest/ubersystem/pulls/1857","id":73576013,"html_url":"https://github.com/magfest/ubersystem/pull/1857","diff_url":"https://github.com/magfest/ubersystem/pull/1857.diff","patch_url":"https://github.com/magfest/ubersystem/pull/1857.patch","issue_url":"https://api.github.com/repos/magfest/ubersystem/issues/1857","number":1857,"state":"open","locked":false,"title":"WIP: Move menu data into python - no javascript","user":{"login":"binary1230","id":5413064,"avatar_url":"https://avatars.githubusercontent.com/u/5413064?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1230","html_url":"https://github.com/binary1230","followers_url":"https://api.github.com/users/binary1230/followers","following_url":"https://api.github.com/users/binary1230/following{/other_user}","gists_url":"https://api.github.com/users/binary1230/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1230/subscriptions","organizations_url":"https://api.github.com/users/binary1230/orgs","repos_url":"https://api.github.com/users/binary1230/repos","events_url":"https://api.github.com/users/binary1230/events{/privacy}","received_events_url":"https://api.github.com/users/binary1230/received_events","type":"User","site_admin":false},"body":"WIP ONLY! DO NOT MERGE YET.  This is 100% functional, but needs a little more refactoring to clean it up.\r\n\r\nMove all template rendering from a hybrid of javascript+templates+dynamically modifying the DOM with jquery to purely python + template rendering.\r\n\r\nThis is a 100% functional module, however, it's WIP because we're encoding then decoding JSON (it's leftover from a previous iteration that used JSON).  This is completely functional but stupid, and once those JSON changes are cleaned up, this will be ready to go.\r\n\r\nThe important bit is that the javascript parts are gone, and the menu is rendered just via templates.\r\n\r\nSee previous discussion on https://github.com/magfest/ubersystem/pull/1849, which this pull request replaces.","created_at":"2016-06-13T13:33:51Z","updated_at":"2016-06-15T09:24:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d07f97615cde3bc4374c32c209bff32022d64d2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magfest/ubersystem/pulls/1857/commits","review_comments_url":"https://api.github.com/repos/magfest/ubersystem/pulls/1857/comments","review_comment_url":"https://api.github.com/repos/magfest/ubersystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magfest/ubersystem/issues/1857/comments","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/a26d4217f3024aacd89e9c1b4ccd8377a7e17d90","head":{"label":"magfest:move_menu_data_no_js","ref":"move_menu_data_no_js","sha":"a26d4217f3024aacd89e9c1b4ccd8377a7e17d90","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":16427229,"name":"ubersystem","full_name":"magfest/ubersystem","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/ubersystem","description":"MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more","fork":true,"url":"https://api.github.com/repos/magfest/ubersystem","forks_url":"https://api.github.com/repos/magfest/ubersystem/forks","keys_url":"https://api.github.com/repos/magfest/ubersystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/ubersystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/ubersystem/teams","hooks_url":"https://api.github.com/repos/magfest/ubersystem/hooks","issue_events_url":"https://api.github.com/repos/magfest/ubersystem/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/ubersystem/events","assignees_url":"https://api.github.com/repos/magfest/ubersystem/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/ubersystem/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/ubersystem/tags","blobs_url":"https://api.github.com/repos/magfest/ubersystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/ubersystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/ubersystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/ubersystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/ubersystem/languages","stargazers_url":"https://api.github.com/repos/magfest/ubersystem/stargazers","contributors_url":"https://api.github.com/repos/magfest/ubersystem/contributors","subscribers_url":"https://api.github.com/repos/magfest/ubersystem/subscribers","subscription_url":"https://api.github.com/repos/magfest/ubersystem/subscription","commits_url":"https://api.github.com/repos/magfest/ubersystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/ubersystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/ubersystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/ubersystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/ubersystem/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/ubersystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/ubersystem/merges","archive_url":"https://api.github.com/repos/magfest/ubersystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/ubersystem/downloads","issues_url":"https://api.github.com/repos/magfest/ubersystem/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/ubersystem/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/ubersystem/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/ubersystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/ubersystem/labels{/name}","releases_url":"https://api.github.com/repos/magfest/ubersystem/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/ubersystem/deployments","created_at":"2014-02-01T02:56:25Z","updated_at":"2016-02-21T21:39:47Z","pushed_at":"2016-06-15T08:00:14Z","git_url":"git://github.com/magfest/ubersystem.git","ssh_url":"git@github.com:magfest/ubersystem.git","clone_url":"https://github.com/magfest/ubersystem.git","svn_url":"https://github.com/magfest/ubersystem","homepage":"http://magfest.org","size":62018,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":270,"forks":3,"open_issues":270,"watchers":24,"default_branch":"master"}},"base":{"label":"magfest:master","ref":"master","sha":"b12fe57255dca3ab70f8e7fccdc3910ceaac027e","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":16427229,"name":"ubersystem","full_name":"magfest/ubersystem","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/ubersystem","description":"MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more","fork":true,"url":"https://api.github.com/repos/magfest/ubersystem","forks_url":"https://api.github.com/repos/magfest/ubersystem/forks","keys_url":"https://api.github.com/repos/magfest/ubersystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/ubersystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/ubersystem/teams","hooks_url":"https://api.github.com/repos/magfest/ubersystem/hooks","issue_events_url":"https://api.github.com/repos/magfest/ubersystem/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/ubersystem/events","assignees_url":"https://api.github.com/repos/magfest/ubersystem/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/ubersystem/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/ubersystem/tags","blobs_url":"https://api.github.com/repos/magfest/ubersystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/ubersystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/ubersystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/ubersystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/ubersystem/languages","stargazers_url":"https://api.github.com/repos/magfest/ubersystem/stargazers","contributors_url":"https://api.github.com/repos/magfest/ubersystem/contributors","subscribers_url":"https://api.github.com/repos/magfest/ubersystem/subscribers","subscription_url":"https://api.github.com/repos/magfest/ubersystem/subscription","commits_url":"https://api.github.com/repos/magfest/ubersystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/ubersystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/ubersystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/ubersystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/ubersystem/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/ubersystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/ubersystem/merges","archive_url":"https://api.github.com/repos/magfest/ubersystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/ubersystem/downloads","issues_url":"https://api.github.com/repos/magfest/ubersystem/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/ubersystem/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/ubersystem/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/ubersystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/ubersystem/labels{/name}","releases_url":"https://api.github.com/repos/magfest/ubersystem/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/ubersystem/deployments","created_at":"2014-02-01T02:56:25Z","updated_at":"2016-02-21T21:39:47Z","pushed_at":"2016-06-15T08:00:14Z","git_url":"git://github.com/magfest/ubersystem.git","ssh_url":"git@github.com:magfest/ubersystem.git","clone_url":"https://github.com/magfest/ubersystem.git","svn_url":"https://github.com/magfest/ubersystem","homepage":"http://magfest.org","size":62018,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":270,"forks":3,"open_issues":270,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/1857"},"html":{"href":"https://github.com/magfest/ubersystem/pull/1857"},"issue":{"href":"https://api.github.com/repos/magfest/ubersystem/issues/1857"},"comments":{"href":"https://api.github.com/repos/magfest/ubersystem/issues/1857/comments"},"review_comments":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/1857/comments"},"review_comment":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/1857/commits"},"statuses":{"href":"https://api.github.com/repos/magfest/ubersystem/statuses/a26d4217f3024aacd89e9c1b4ccd8377a7e17d90"}}}}
{"actor":{"display_login":"kitsuta"}}