{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/775","repository_url":"https://api.github.com/repos/palantir/atlasdb","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/775/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/775/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/775/events","html_url":"https://github.com/palantir/atlasdb/pull/775","id":170841622,"number":775,"title":"Enable baseline for atlasdb-impl-shared","user":{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/palantir/atlasdb/labels/component:%20devEx","name":"component: devEx","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false},"assignees":[{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-12T10:19:22Z","updated_at":"2016-08-18T14:02:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/775","html_url":"https://github.com/palantir/atlasdb/pull/775","diff_url":"https://github.com/palantir/atlasdb/pull/775.diff","patch_url":"https://github.com/palantir/atlasdb/pull/775.patch"},"body":"Changes:\r\n  - Mainly cosmetic to match baseline style\r\n  - A few changes are for correctness bugs (supposedly) found by findbugs. \r\n    - ~~We don't always `synchronise(this)` in `DynamicPartitionMapImpl`. Inside that class, we also don't check `operationsInProgress` in `equals`/`hashCode` anymore.~~ **reverted**\r\n  - A few changes are for efficiency reasons found by findbugs.\r\n    - We were iterating over `keySet`, then using `Map#get`.\r\n\r\nLooking through by commit is probably easier.\r\n\r\n| Project | Checkstyle main bugs | Checkstyle test bugs |\r\n| --- | --- | --- |\r\n| atlasdb-impl-shared | 1086 | 20 |\r\n\r\n**Baseline modifications**\r\n  - Checkstyle\r\n    - Suppress abbreviations in files that have KV in their name (examples: TransactionKVSWrapper, KVTableMappingService)\r\n  - Findbugs suppressions\r\n    - IS_FIELD_NOT_GUARDED for DynamicPartitionMapImpl\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/775)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/240732116","html_url":"https://github.com/palantir/atlasdb/pull/775#issuecomment-240732116","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/775","id":240732116,"user":{"login":"gsheasby","id":15610492,"avatar_url":"https://avatars.githubusercontent.com/u/15610492?v=3","gravatar_id":"","url":"https://api.github.com/users/gsheasby","html_url":"https://github.com/gsheasby","followers_url":"https://api.github.com/users/gsheasby/followers","following_url":"https://api.github.com/users/gsheasby/following{/other_user}","gists_url":"https://api.github.com/users/gsheasby/gists{/gist_id}","starred_url":"https://api.github.com/users/gsheasby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsheasby/subscriptions","organizations_url":"https://api.github.com/users/gsheasby/orgs","repos_url":"https://api.github.com/users/gsheasby/repos","events_url":"https://api.github.com/users/gsheasby/events{/privacy}","received_events_url":"https://api.github.com/users/gsheasby/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T14:02:17Z","updated_at":"2016-08-18T14:02:17Z","body":"\n\n\n\nReviewed 1 of 130 files at r1.\nReview status: 128 of 129 files reviewed at latest revision, 16 unresolved discussions, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/palantir/atlasdb/775)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"gsheasby"}}