{"action":"closed","number":694,"pull_request":{"url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694","id":83824393,"html_url":"https://github.com/gotwarlost/istanbul/pull/694","diff_url":"https://github.com/gotwarlost/istanbul/pull/694.diff","patch_url":"https://github.com/gotwarlost/istanbul/pull/694.patch","issue_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/694","number":694,"state":"closed","locked":false,"title":"Make istanbul blazing fast","user":{"login":"mourner","id":25395,"avatar_url":"https://avatars.githubusercontent.com/u/25395?v=3","gravatar_id":"","url":"https://api.github.com/users/mourner","html_url":"https://github.com/mourner","followers_url":"https://api.github.com/users/mourner/followers","following_url":"https://api.github.com/users/mourner/following{/other_user}","gists_url":"https://api.github.com/users/mourner/gists{/gist_id}","starred_url":"https://api.github.com/users/mourner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourner/subscriptions","organizations_url":"https://api.github.com/users/mourner/orgs","repos_url":"https://api.github.com/users/mourner/repos","events_url":"https://api.github.com/users/mourner/events{/privacy}","received_events_url":"https://api.github.com/users/mourner/received_events","type":"User","site_admin":false},"body":"A work in progress, closes #556. \r\n\r\nI finally figured out why an `istanbul cover` run in [our project](https://github.com/mapbox/mapbox-gl-js) took 4-5 times as much as the non-istanbul test run! For some reason, V8 has a very hard time accessing string-keyed object properties (`cov.s['0']++` etc.) on every line. Changing coverage stats to use simple arrays instead of objects and do `cov.s[0]++` **gets rid of all the huge overhead**. \r\n\r\nFor our project, this change brings a 4-minute coverage run down to 1 minute, almost the same time as a clean test run takes. Awesome!\r\n\r\n- [x] convert `*Map` objects to arrays as well\r\n- [x] fix stats iterations in `object-utils.js`\r\n- [ ] update tests to reflect coverage JSON structure change\r\n- [ ] perhaps explore using a shorter id for coverage (e.g. `__cov_FFp_xOkOtMOF6AXOIHanfg` -> `_c`, first var that's not used in any of the scopes in a file)? Should make things faster because of V8 inlining.\r\n\r\ncc @gotwarlost  @mramato @jfirebaugh @springmeyer @lucaswoj","created_at":"2016-09-02T15:52:50Z","updated_at":"2016-09-02T22:27:42Z","closed_at":"2016-09-02T22:27:42Z","merged_at":null,"merge_commit_sha":"70c09726f0f7ec9f47dffd96dcddb7c6f92b61d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694/commits","review_comments_url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694/comments","review_comment_url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/694/comments","statuses_url":"https://api.github.com/repos/gotwarlost/istanbul/statuses/c667c2ede088f97afaed65ac4a1bd3bf0044219d","head":{"label":"mourner:fast-intrumentation","ref":"fast-intrumentation","sha":"c667c2ede088f97afaed65ac4a1bd3bf0044219d","user":{"login":"mourner","id":25395,"avatar_url":"https://avatars.githubusercontent.com/u/25395?v=3","gravatar_id":"","url":"https://api.github.com/users/mourner","html_url":"https://github.com/mourner","followers_url":"https://api.github.com/users/mourner/followers","following_url":"https://api.github.com/users/mourner/following{/other_user}","gists_url":"https://api.github.com/users/mourner/gists{/gist_id}","starred_url":"https://api.github.com/users/mourner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourner/subscriptions","organizations_url":"https://api.github.com/users/mourner/orgs","repos_url":"https://api.github.com/users/mourner/repos","events_url":"https://api.github.com/users/mourner/events{/privacy}","received_events_url":"https://api.github.com/users/mourner/received_events","type":"User","site_admin":false},"repo":{"id":67234166,"name":"istanbul","full_name":"mourner/istanbul","owner":{"login":"mourner","id":25395,"avatar_url":"https://avatars.githubusercontent.com/u/25395?v=3","gravatar_id":"","url":"https://api.github.com/users/mourner","html_url":"https://github.com/mourner","followers_url":"https://api.github.com/users/mourner/followers","following_url":"https://api.github.com/users/mourner/following{/other_user}","gists_url":"https://api.github.com/users/mourner/gists{/gist_id}","starred_url":"https://api.github.com/users/mourner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourner/subscriptions","organizations_url":"https://api.github.com/users/mourner/orgs","repos_url":"https://api.github.com/users/mourner/repos","events_url":"https://api.github.com/users/mourner/events{/privacy}","received_events_url":"https://api.github.com/users/mourner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mourner/istanbul","description":"Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.","fork":true,"url":"https://api.github.com/repos/mourner/istanbul","forks_url":"https://api.github.com/repos/mourner/istanbul/forks","keys_url":"https://api.github.com/repos/mourner/istanbul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mourner/istanbul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mourner/istanbul/teams","hooks_url":"https://api.github.com/repos/mourner/istanbul/hooks","issue_events_url":"https://api.github.com/repos/mourner/istanbul/issues/events{/number}","events_url":"https://api.github.com/repos/mourner/istanbul/events","assignees_url":"https://api.github.com/repos/mourner/istanbul/assignees{/user}","branches_url":"https://api.github.com/repos/mourner/istanbul/branches{/branch}","tags_url":"https://api.github.com/repos/mourner/istanbul/tags","blobs_url":"https://api.github.com/repos/mourner/istanbul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mourner/istanbul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mourner/istanbul/git/refs{/sha}","trees_url":"https://api.github.com/repos/mourner/istanbul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mourner/istanbul/statuses/{sha}","languages_url":"https://api.github.com/repos/mourner/istanbul/languages","stargazers_url":"https://api.github.com/repos/mourner/istanbul/stargazers","contributors_url":"https://api.github.com/repos/mourner/istanbul/contributors","subscribers_url":"https://api.github.com/repos/mourner/istanbul/subscribers","subscription_url":"https://api.github.com/repos/mourner/istanbul/subscription","commits_url":"https://api.github.com/repos/mourner/istanbul/commits{/sha}","git_commits_url":"https://api.github.com/repos/mourner/istanbul/git/commits{/sha}","comments_url":"https://api.github.com/repos/mourner/istanbul/comments{/number}","issue_comment_url":"https://api.github.com/repos/mourner/istanbul/issues/comments{/number}","contents_url":"https://api.github.com/repos/mourner/istanbul/contents/{+path}","compare_url":"https://api.github.com/repos/mourner/istanbul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mourner/istanbul/merges","archive_url":"https://api.github.com/repos/mourner/istanbul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mourner/istanbul/downloads","issues_url":"https://api.github.com/repos/mourner/istanbul/issues{/number}","pulls_url":"https://api.github.com/repos/mourner/istanbul/pulls{/number}","milestones_url":"https://api.github.com/repos/mourner/istanbul/milestones{/number}","notifications_url":"https://api.github.com/repos/mourner/istanbul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mourner/istanbul/labels{/name}","releases_url":"https://api.github.com/repos/mourner/istanbul/releases{/id}","deployments_url":"https://api.github.com/repos/mourner/istanbul/deployments","created_at":"2016-09-02T15:30:23Z","updated_at":"2016-09-02T15:30:24Z","pushed_at":"2016-09-02T16:44:19Z","git_url":"git://github.com/mourner/istanbul.git","ssh_url":"git@github.com:mourner/istanbul.git","clone_url":"https://github.com/mourner/istanbul.git","svn_url":"https://github.com/mourner/istanbul","homepage":null,"size":2622,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gotwarlost:master","ref":"master","sha":"89e338fcb1c8a7dea3b9e8f851aa55de2bc3abee","user":{"login":"gotwarlost","id":1056819,"avatar_url":"https://avatars.githubusercontent.com/u/1056819?v=3","gravatar_id":"","url":"https://api.github.com/users/gotwarlost","html_url":"https://github.com/gotwarlost","followers_url":"https://api.github.com/users/gotwarlost/followers","following_url":"https://api.github.com/users/gotwarlost/following{/other_user}","gists_url":"https://api.github.com/users/gotwarlost/gists{/gist_id}","starred_url":"https://api.github.com/users/gotwarlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotwarlost/subscriptions","organizations_url":"https://api.github.com/users/gotwarlost/orgs","repos_url":"https://api.github.com/users/gotwarlost/repos","events_url":"https://api.github.com/users/gotwarlost/events{/privacy}","received_events_url":"https://api.github.com/users/gotwarlost/received_events","type":"User","site_admin":false},"repo":{"id":5775917,"name":"istanbul","full_name":"gotwarlost/istanbul","owner":{"login":"gotwarlost","id":1056819,"avatar_url":"https://avatars.githubusercontent.com/u/1056819?v=3","gravatar_id":"","url":"https://api.github.com/users/gotwarlost","html_url":"https://github.com/gotwarlost","followers_url":"https://api.github.com/users/gotwarlost/followers","following_url":"https://api.github.com/users/gotwarlost/following{/other_user}","gists_url":"https://api.github.com/users/gotwarlost/gists{/gist_id}","starred_url":"https://api.github.com/users/gotwarlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotwarlost/subscriptions","organizations_url":"https://api.github.com/users/gotwarlost/orgs","repos_url":"https://api.github.com/users/gotwarlost/repos","events_url":"https://api.github.com/users/gotwarlost/events{/privacy}","received_events_url":"https://api.github.com/users/gotwarlost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gotwarlost/istanbul","description":"Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.","fork":false,"url":"https://api.github.com/repos/gotwarlost/istanbul","forks_url":"https://api.github.com/repos/gotwarlost/istanbul/forks","keys_url":"https://api.github.com/repos/gotwarlost/istanbul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gotwarlost/istanbul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gotwarlost/istanbul/teams","hooks_url":"https://api.github.com/repos/gotwarlost/istanbul/hooks","issue_events_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/events{/number}","events_url":"https://api.github.com/repos/gotwarlost/istanbul/events","assignees_url":"https://api.github.com/repos/gotwarlost/istanbul/assignees{/user}","branches_url":"https://api.github.com/repos/gotwarlost/istanbul/branches{/branch}","tags_url":"https://api.github.com/repos/gotwarlost/istanbul/tags","blobs_url":"https://api.github.com/repos/gotwarlost/istanbul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gotwarlost/istanbul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gotwarlost/istanbul/git/refs{/sha}","trees_url":"https://api.github.com/repos/gotwarlost/istanbul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gotwarlost/istanbul/statuses/{sha}","languages_url":"https://api.github.com/repos/gotwarlost/istanbul/languages","stargazers_url":"https://api.github.com/repos/gotwarlost/istanbul/stargazers","contributors_url":"https://api.github.com/repos/gotwarlost/istanbul/contributors","subscribers_url":"https://api.github.com/repos/gotwarlost/istanbul/subscribers","subscription_url":"https://api.github.com/repos/gotwarlost/istanbul/subscription","commits_url":"https://api.github.com/repos/gotwarlost/istanbul/commits{/sha}","git_commits_url":"https://api.github.com/repos/gotwarlost/istanbul/git/commits{/sha}","comments_url":"https://api.github.com/repos/gotwarlost/istanbul/comments{/number}","issue_comment_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/comments{/number}","contents_url":"https://api.github.com/repos/gotwarlost/istanbul/contents/{+path}","compare_url":"https://api.github.com/repos/gotwarlost/istanbul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gotwarlost/istanbul/merges","archive_url":"https://api.github.com/repos/gotwarlost/istanbul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gotwarlost/istanbul/downloads","issues_url":"https://api.github.com/repos/gotwarlost/istanbul/issues{/number}","pulls_url":"https://api.github.com/repos/gotwarlost/istanbul/pulls{/number}","milestones_url":"https://api.github.com/repos/gotwarlost/istanbul/milestones{/number}","notifications_url":"https://api.github.com/repos/gotwarlost/istanbul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gotwarlost/istanbul/labels{/name}","releases_url":"https://api.github.com/repos/gotwarlost/istanbul/releases{/id}","deployments_url":"https://api.github.com/repos/gotwarlost/istanbul/deployments","created_at":"2012-09-12T06:36:32Z","updated_at":"2016-09-02T22:04:03Z","pushed_at":"2016-09-02T16:44:19Z","git_url":"git://github.com/gotwarlost/istanbul.git","ssh_url":"git@github.com:gotwarlost/istanbul.git","clone_url":"https://github.com/gotwarlost/istanbul.git","svn_url":"https://github.com/gotwarlost/istanbul","homepage":null,"size":5214,"stargazers_count":4971,"watchers_count":4971,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":508,"mirror_url":null,"open_issues_count":235,"forks":508,"open_issues":235,"watchers":4971,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694"},"html":{"href":"https://github.com/gotwarlost/istanbul/pull/694"},"issue":{"href":"https://api.github.com/repos/gotwarlost/istanbul/issues/694"},"comments":{"href":"https://api.github.com/repos/gotwarlost/istanbul/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/gotwarlost/istanbul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gotwarlost/istanbul/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/gotwarlost/istanbul/statuses/c667c2ede088f97afaed65ac4a1bd3bf0044219d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":39,"deletions":57,"changed_files":2}}
{"actor":{"display_login":"mourner"}}