{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75232350","id":75232350,"diff_hunk":"@@ -962,3 +981,25 @@ func (vs *VSphere) DeleteVolume(vmDiskPath string) error {\n \n \treturn task.Wait(ctx)\n }\n+\n+func mkdirInDatastore(c *govmomi.Client, dc *object.Datacenter, path string, createParents bool) error {\n+\n+\tctx, cancel := context.WithCancel(context.Background())\n+\tdefer cancel()\n+\n+\tfileManger := object.NewFileManager(c.Client)","path":"pkg/cloudprovider/providers/vsphere/vsphere.go","position":60,"original_position":60,"commit_id":"d0fcd1c9646ad3b8a9e8417977e83b8fcc60fd8c","original_commit_id":"d0fcd1c9646ad3b8a9e8417977e83b8fcc60fd8c","user":{"login":"msterin","id":4379889,"avatar_url":"https://avatars.githubusercontent.com/u/4379889?v=3","gravatar_id":"","url":"https://api.github.com/users/msterin","html_url":"https://github.com/msterin","followers_url":"https://api.github.com/users/msterin/followers","following_url":"https://api.github.com/users/msterin/following{/other_user}","gists_url":"https://api.github.com/users/msterin/gists{/gist_id}","starred_url":"https://api.github.com/users/msterin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msterin/subscriptions","organizations_url":"https://api.github.com/users/msterin/orgs","repos_url":"https://api.github.com/users/msterin/repos","events_url":"https://api.github.com/users/msterin/events{/privacy}","received_events_url":"https://api.github.com/users/msterin/received_events","type":"User","site_admin":false},"body":"maybe fileManager ? ","created_at":"2016-08-18T00:34:13Z","updated_at":"2016-08-18T00:34:13Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30836#discussion_r75232350","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75232350"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30836#discussion_r75232350"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836","id":81739405,"html_url":"https://github.com/kubernetes/kubernetes/pull/30836","diff_url":"https://github.com/kubernetes/kubernetes/pull/30836.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30836.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30836","number":30836,"state":"open","locked":false,"title":"Fix: dynamic provisioning for vSphere","user":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"body":"This PR does the following,\r\n\r\n1. Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes.\r\n2. Adds VSAN support for dynamic provisioning.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30836)\n<!-- Reviewable:end -->\n","created_at":"2016-08-18T00:22:50Z","updated_at":"2016-08-18T00:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085fecb8e14a75e952e8c774a052c6db46d5209b","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30836/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d0fcd1c9646ad3b8a9e8417977e83b8fcc60fd8c","head":{"label":"abrarshivani:vsphere_dynamic_proviosioning","ref":"vsphere_dynamic_proviosioning","sha":"d0fcd1c9646ad3b8a9e8417977e83b8fcc60fd8c","user":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"repo":{"id":63636237,"name":"kubernetes","full_name":"abrarshivani/kubernetes","owner":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abrarshivani/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/abrarshivani/kubernetes","forks_url":"https://api.github.com/repos/abrarshivani/kubernetes/forks","keys_url":"https://api.github.com/repos/abrarshivani/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrarshivani/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrarshivani/kubernetes/teams","hooks_url":"https://api.github.com/repos/abrarshivani/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/abrarshivani/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/abrarshivani/kubernetes/events","assignees_url":"https://api.github.com/repos/abrarshivani/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/abrarshivani/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/abrarshivani/kubernetes/tags","blobs_url":"https://api.github.com/repos/abrarshivani/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrarshivani/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrarshivani/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrarshivani/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrarshivani/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/abrarshivani/kubernetes/languages","stargazers_url":"https://api.github.com/repos/abrarshivani/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/abrarshivani/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/abrarshivani/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/abrarshivani/kubernetes/subscription","commits_url":"https://api.github.com/repos/abrarshivani/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrarshivani/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrarshivani/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrarshivani/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrarshivani/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/abrarshivani/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrarshivani/kubernetes/merges","archive_url":"https://api.github.com/repos/abrarshivani/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrarshivani/kubernetes/downloads","issues_url":"https://api.github.com/repos/abrarshivani/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/abrarshivani/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/abrarshivani/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/abrarshivani/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrarshivani/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/abrarshivani/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/abrarshivani/kubernetes/deployments","created_at":"2016-07-18T20:53:43Z","updated_at":"2016-07-18T20:54:01Z","pushed_at":"2016-08-18T00:17:36Z","git_url":"git://github.com/abrarshivani/kubernetes.git","ssh_url":"git@github.com:abrarshivani/kubernetes.git","clone_url":"https://github.com/abrarshivani/kubernetes.git","svn_url":"https://github.com/abrarshivani/kubernetes","homepage":"http://kubernetes.io","size":306799,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"332edf8bb383d770078dd759ad54942ef4382f97","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-17T23:04:00Z","pushed_at":"2016-08-18T00:26:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":529038,"stargazers_count":16175,"watchers_count":16175,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5168,"mirror_url":null,"open_issues_count":4238,"forks":5168,"open_issues":4238,"watchers":16175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30836"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30836"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30836/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30836/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d0fcd1c9646ad3b8a9e8417977e83b8fcc60fd8c"}}}}
{"actor":{"display_login":"msterin"}}