{"action":"closed","issue":{"url":"https://api.github.com/repos/Andrettin/Wyrmgus/issues/101","repository_url":"https://api.github.com/repos/Andrettin/Wyrmgus","labels_url":"https://api.github.com/repos/Andrettin/Wyrmgus/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/Andrettin/Wyrmgus/issues/101/comments","events_url":"https://api.github.com/repos/Andrettin/Wyrmgus/issues/101/events","html_url":"https://github.com/Andrettin/Wyrmgus/issues/101","id":172291978,"number":101,"title":"String format error with GCC 5 [-Werror=format-security]","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-20T21:36:15Z","updated_at":"2016-08-21T10:51:39Z","closed_at":"2016-08-21T10:51:39Z","body":"Fails to build with GCC 5 and wyrmgus 2.4.0:\r\n```\r\n[ 78%] Building CXX object CMakeFiles/stratagus.dir/src/stratagus/script_player.cpp.o\r\n/bin/c++   -DHAVE_GETOPT -DHAVE_STRCASESTR -DHAVE_STRNLEN -DPIXMAPS=\\\"/usr/share/pixmaps\\\" -DUSE_LINUX -DUSE_MIKMOD -DUSE_OAML -DUSE_OPENGL -DUSE_THEORA -DUSE_VORBIS -DUSE_X11 -DUSE_ZLIB -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/guichan/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/guichan/include/guichan -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/xbrz/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/build -I/usr/include/. -I/usr/include/SDL -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/oaml/include  -std=c++11 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4  -fsigned-char -std=c++11 -DNDEBUG   -o CMakeFiles/stratagus.dir/src/stratagus/script_player.cpp.o -c /home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/stratagus/script_player.cpp\r\n/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/stratagus/script_player.cpp: In function 'int CclSetThisPlayer(lua_State*)':\r\n/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/stratagus/script_player.cpp:505:69: error: format not a string literal and no format arguments [-Werror=format-security]\r\n     SetObjective(ThisPlayer->CurrentQuests[i]->Objectives[j].c_str());\r\n                                                                     ^\r\n```\r\n\r\nAlso, a format-related warning:\r\n```\r\n[ 46%] Building CXX object CMakeFiles/stratagus.dir/src/map/tileset.cpp.o\r\n/bin/c++   -DHAVE_GETOPT -DHAVE_STRCASESTR -DHAVE_STRNLEN -DPIXMAPS=\\\"/usr/share/pixmaps\\\" -DUSE_LINUX -DUSE_MIKMOD -DUSE_OAML -DUSE_OPENGL -DUSE_THEORA -DUSE_VORBIS -DUSE_X11 -DUSE_ZLIB -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/guichan/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/guichan/include/guichan -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/xbrz/include -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/build -I/usr/include/. -I/usr/include/SDL -I/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/oaml/include  -std=c++11 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4  -fsigned-char -std=c++11 -DNDEBUG   -o CMakeFiles/stratagus.dir/src/map/tileset.cpp.o -c /home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/map/tileset.cpp\r\nIn file included from /home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/map/script_map.cpp:41:0:\r\n/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/map/script_map.cpp: In function 'int CclDefineTerrainType(lua_State*)':\r\n/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/include/script.h:80:23: warning: format '%s' expects a matching 'char*' argument [-Wformat=]\r\n   fprintf(stdout, args); \\\r\n                       ^\r\n/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-2.4.0/src/map/script_map.cpp:1198:6: note: in expansion of macro 'LuaError'\r\n      LuaError(l, \"Flag \\\"%s\\\" doesn't exist.\");\r\n      ^\r\n```"}}
{"actor":{"display_login":"akien-mga"}}