{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/837","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/837/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/837/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/837/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/837","id":173439334,"number":837,"title":"Changed Action classes to use LuaUtilities","user":{"login":"NogginBops","id":3778357,"avatar_url":"https://avatars.githubusercontent.com/u/3778357?v=3","gravatar_id":"","url":"https://api.github.com/users/NogginBops","html_url":"https://github.com/NogginBops","followers_url":"https://api.github.com/users/NogginBops/followers","following_url":"https://api.github.com/users/NogginBops/following{/other_user}","gists_url":"https://api.github.com/users/NogginBops/gists{/gist_id}","starred_url":"https://api.github.com/users/NogginBops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NogginBops/subscriptions","organizations_url":"https://api.github.com/users/NogginBops/orgs","repos_url":"https://api.github.com/users/NogginBops/repos","events_url":"https://api.github.com/users/NogginBops/events{/privacy}","received_events_url":"https://api.github.com/users/NogginBops/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-26T12:12:14Z","updated_at":"2016-08-30T04:14:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/837","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/837","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/837.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/837.patch"},"body":"I made this change to remove a lot of code duplication that existed in e.g. FurnitureActions and NeedActions.\r\n\r\nThe only drawback I think should be considered is that if every lua file that gets loaded is in the same script, the search space for global functions could get pretty big."},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/243328415","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/837#issuecomment-243328415","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/837","id":243328415,"user":{"login":"TomMalbran","id":1299997,"avatar_url":"https://avatars.githubusercontent.com/u/1299997?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMalbran","html_url":"https://github.com/TomMalbran","followers_url":"https://api.github.com/users/TomMalbran/followers","following_url":"https://api.github.com/users/TomMalbran/following{/other_user}","gists_url":"https://api.github.com/users/TomMalbran/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMalbran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMalbran/subscriptions","organizations_url":"https://api.github.com/users/TomMalbran/orgs","repos_url":"https://api.github.com/users/TomMalbran/repos","events_url":"https://api.github.com/users/TomMalbran/events{/privacy}","received_events_url":"https://api.github.com/users/TomMalbran/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T04:14:57Z","updated_at":"2016-08-30T04:14:57Z","body":"I would like to eventually have something similar to what I did with the PrototypeManager, some sort of ActionsManager.\r\n\r\nLoadScripts was called when creating the instance, and the instance was created when a method called the Instance property. Check how the FurnitureActions is done. The constructor is created inside WorldController and the ModsManager calls the mods loading function.\r\n\r\nWhen we make the current xml/lua/images files be part of a default mod, my idea was that the ModManager would be in charge of reading the files and call all the required loaders passing them the file content."}}
{"actor":{"display_login":"TomMalbran"}}