{"action":"created","comment":{"url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments/91455351","pull_request_review_id":11963156,"id":91455351,"diff_hunk":"@@ -299,14 +306,26 @@ public EmbedBuilder setFooter(String text, String iconUrl)\n         {\n             if (text != null && text.length() > TEXT_MAX_LENGTH)\n                 throw new IllegalArgumentException(\"Text cannot be longer than \" + TEXT_MAX_LENGTH + \" characters.\");\n-            httpsCheck(iconUrl);\n+            urlCheck(iconUrl);\n             this.footer = new MessageEmbed.Footer(text, iconUrl, null);\n         }\n         return this;\n     }\n     \n     /**\n+     * Adds a Field to the embed\n+     * \n+     * @param field the field object to add\n+     * @return the builder after the field has been added\n+     */\n+    public EmbedBuilder addField(MessageEmbed.Field field)\n+    {\n+        return addField(field.getName(), field.getValue(), field.isInline());","path":"src/main/java/net/dv8tion/jda/core/EmbedBuilder.java","position":103,"original_position":103,"commit_id":"d571c29a8c26351deb6d748a9a50cecf0202ccfd","original_commit_id":"d571c29a8c26351deb6d748a9a50cecf0202ccfd","user":{"login":"DV8FromTheWorld","id":1479909,"avatar_url":"https://avatars.githubusercontent.com/u/1479909?v=3","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"body":"Na, not an npe. It results in an IllegalArgumentException. ","created_at":"2016-12-08T07:00:09Z","updated_at":"2016-12-08T07:00:09Z","html_url":"https://github.com/DV8FromTheWorld/JDA/pull/203#discussion_r91455351","pull_request_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments/91455351"},"html":{"href":"https://github.com/DV8FromTheWorld/JDA/pull/203#discussion_r91455351"},"pull_request":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203","id":96455168,"html_url":"https://github.com/DV8FromTheWorld/JDA/pull/203","diff_url":"https://github.com/DV8FromTheWorld/JDA/pull/203.diff","patch_url":"https://github.com/DV8FromTheWorld/JDA/pull/203.patch","issue_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/203","number":203,"state":"closed","locked":false,"title":"EmbedBuilder bugfixes, changes, and permission check","user":{"login":"jagrosh","id":12754382,"avatar_url":"https://avatars.githubusercontent.com/u/12754382?v=3","gravatar_id":"","url":"https://api.github.com/users/jagrosh","html_url":"https://github.com/jagrosh","followers_url":"https://api.github.com/users/jagrosh/followers","following_url":"https://api.github.com/users/jagrosh/following{/other_user}","gists_url":"https://api.github.com/users/jagrosh/gists{/gist_id}","starred_url":"https://api.github.com/users/jagrosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagrosh/subscriptions","organizations_url":"https://api.github.com/users/jagrosh/orgs","repos_url":"https://api.github.com/users/jagrosh/repos","events_url":"https://api.github.com/users/jagrosh/events{/privacy}","received_events_url":"https://api.github.com/users/jagrosh/received_events","type":"User","site_admin":false},"body":"no more https check\r\ncan add a MessageEmbed.Field object\r\nadded isEmpty() method\r\nremoved unused imports\r\nfixed deprecated messagebuilder method usage\r\nadded permission check for embed + empty message\r\nmade lock final because my IDE kept yelling at me","created_at":"2016-12-05T00:42:05Z","updated_at":"2016-12-08T07:00:09Z","closed_at":"2016-12-05T03:53:44Z","merged_at":"2016-12-05T03:53:44Z","merge_commit_sha":"f1b1f1288d477c7c3331e4a8546a202d42fcf2f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203/commits","review_comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203/comments","review_comment_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/203/comments","statuses_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/d571c29a8c26351deb6d748a9a50cecf0202ccfd","head":{"label":"jagrosh:embed-changes","ref":"embed-changes","sha":"d571c29a8c26351deb6d748a9a50cecf0202ccfd","user":{"login":"jagrosh","id":12754382,"avatar_url":"https://avatars.githubusercontent.com/u/12754382?v=3","gravatar_id":"","url":"https://api.github.com/users/jagrosh","html_url":"https://github.com/jagrosh","followers_url":"https://api.github.com/users/jagrosh/followers","following_url":"https://api.github.com/users/jagrosh/following{/other_user}","gists_url":"https://api.github.com/users/jagrosh/gists{/gist_id}","starred_url":"https://api.github.com/users/jagrosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagrosh/subscriptions","organizations_url":"https://api.github.com/users/jagrosh/orgs","repos_url":"https://api.github.com/users/jagrosh/repos","events_url":"https://api.github.com/users/jagrosh/events{/privacy}","received_events_url":"https://api.github.com/users/jagrosh/received_events","type":"User","site_admin":false},"repo":{"id":68458979,"name":"JDA","full_name":"jagrosh/JDA","owner":{"login":"jagrosh","id":12754382,"avatar_url":"https://avatars.githubusercontent.com/u/12754382?v=3","gravatar_id":"","url":"https://api.github.com/users/jagrosh","html_url":"https://github.com/jagrosh","followers_url":"https://api.github.com/users/jagrosh/followers","following_url":"https://api.github.com/users/jagrosh/following{/other_user}","gists_url":"https://api.github.com/users/jagrosh/gists{/gist_id}","starred_url":"https://api.github.com/users/jagrosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagrosh/subscriptions","organizations_url":"https://api.github.com/users/jagrosh/orgs","repos_url":"https://api.github.com/users/jagrosh/repos","events_url":"https://api.github.com/users/jagrosh/events{/privacy}","received_events_url":"https://api.github.com/users/jagrosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagrosh/JDA","description":"Java REST wrapper for the popular chat & VOIP service: Discord. https://discordapp.com/","fork":true,"url":"https://api.github.com/repos/jagrosh/JDA","forks_url":"https://api.github.com/repos/jagrosh/JDA/forks","keys_url":"https://api.github.com/repos/jagrosh/JDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagrosh/JDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagrosh/JDA/teams","hooks_url":"https://api.github.com/repos/jagrosh/JDA/hooks","issue_events_url":"https://api.github.com/repos/jagrosh/JDA/issues/events{/number}","events_url":"https://api.github.com/repos/jagrosh/JDA/events","assignees_url":"https://api.github.com/repos/jagrosh/JDA/assignees{/user}","branches_url":"https://api.github.com/repos/jagrosh/JDA/branches{/branch}","tags_url":"https://api.github.com/repos/jagrosh/JDA/tags","blobs_url":"https://api.github.com/repos/jagrosh/JDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagrosh/JDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagrosh/JDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagrosh/JDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagrosh/JDA/statuses/{sha}","languages_url":"https://api.github.com/repos/jagrosh/JDA/languages","stargazers_url":"https://api.github.com/repos/jagrosh/JDA/stargazers","contributors_url":"https://api.github.com/repos/jagrosh/JDA/contributors","subscribers_url":"https://api.github.com/repos/jagrosh/JDA/subscribers","subscription_url":"https://api.github.com/repos/jagrosh/JDA/subscription","commits_url":"https://api.github.com/repos/jagrosh/JDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagrosh/JDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagrosh/JDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagrosh/JDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagrosh/JDA/contents/{+path}","compare_url":"https://api.github.com/repos/jagrosh/JDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagrosh/JDA/merges","archive_url":"https://api.github.com/repos/jagrosh/JDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagrosh/JDA/downloads","issues_url":"https://api.github.com/repos/jagrosh/JDA/issues{/number}","pulls_url":"https://api.github.com/repos/jagrosh/JDA/pulls{/number}","milestones_url":"https://api.github.com/repos/jagrosh/JDA/milestones{/number}","notifications_url":"https://api.github.com/repos/jagrosh/JDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagrosh/JDA/labels{/name}","releases_url":"https://api.github.com/repos/jagrosh/JDA/releases{/id}","deployments_url":"https://api.github.com/repos/jagrosh/JDA/deployments","created_at":"2016-09-17T15:01:57Z","updated_at":"2016-10-14T05:45:46Z","pushed_at":"2016-12-05T00:40:08Z","git_url":"git://github.com/jagrosh/JDA.git","ssh_url":"git@github.com:jagrosh/JDA.git","clone_url":"https://github.com/jagrosh/JDA.git","svn_url":"https://github.com/jagrosh/JDA","homepage":"","size":21450,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DV8FromTheWorld:development","ref":"development","sha":"f05e4d33caaddcc1ec3081f5c58123f9cb59a2f1","user":{"login":"DV8FromTheWorld","id":1479909,"avatar_url":"https://avatars.githubusercontent.com/u/1479909?v=3","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"repo":{"id":47880207,"name":"JDA","full_name":"DV8FromTheWorld/JDA","owner":{"login":"DV8FromTheWorld","id":1479909,"avatar_url":"https://avatars.githubusercontent.com/u/1479909?v=3","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DV8FromTheWorld/JDA","description":"Java REST wrapper for the popular chat & VOIP service: Discord. https://discordapp.com/","fork":false,"url":"https://api.github.com/repos/DV8FromTheWorld/JDA","forks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/forks","keys_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/teams","hooks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/hooks","issue_events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/events{/number}","events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/events","assignees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/assignees{/user}","branches_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/branches{/branch}","tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/tags","blobs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/{sha}","languages_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/languages","stargazers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/stargazers","contributors_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contributors","subscribers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscribers","subscription_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscription","commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contents/{+path}","compare_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/merges","archive_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/downloads","issues_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues{/number}","pulls_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls{/number}","milestones_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/milestones{/number}","notifications_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels{/name}","releases_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/releases{/id}","deployments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/deployments","created_at":"2015-12-12T13:57:32Z","updated_at":"2016-12-06T19:23:10Z","pushed_at":"2016-12-07T16:45:40Z","git_url":"git://github.com/DV8FromTheWorld/JDA.git","ssh_url":"git@github.com:DV8FromTheWorld/JDA.git","clone_url":"https://github.com/DV8FromTheWorld/JDA.git","svn_url":"https://github.com/DV8FromTheWorld/JDA","homepage":"","size":21750,"stargazers_count":113,"watchers_count":113,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":13,"forks":39,"open_issues":13,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203"},"html":{"href":"https://github.com/DV8FromTheWorld/JDA/pull/203"},"issue":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/203"},"comments":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/d571c29a8c26351deb6d748a9a50cecf0202ccfd"}}}}
{"actor":{"display_login":"DV8FromTheWorld"}}