{"action":"opened","number":1071,"pull_request":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071","id":67990614,"html_url":"https://github.com/camptocamp/ngeo/pull/1071","diff_url":"https://github.com/camptocamp/ngeo/pull/1071.diff","patch_url":"https://github.com/camptocamp/ngeo/pull/1071.patch","issue_url":"https://api.github.com/repos/camptocamp/ngeo/issues/1071","number":1071,"state":"open","locked":false,"title":"Fix styling issue with the modify rectangle.","user":{"login":"jlap","id":4561544,"avatar_url":"https://avatars.githubusercontent.com/u/4561544?v=3","gravatar_id":"","url":"https://api.github.com/users/jlap","html_url":"https://github.com/jlap","followers_url":"https://api.github.com/users/jlap/followers","following_url":"https://api.github.com/users/jlap/following{/other_user}","gists_url":"https://api.github.com/users/jlap/gists{/gist_id}","starred_url":"https://api.github.com/users/jlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlap/subscriptions","organizations_url":"https://api.github.com/users/jlap/orgs","repos_url":"https://api.github.com/users/jlap/repos","events_url":"https://api.github.com/users/jlap/events{/privacy}","received_events_url":"https://api.github.com/users/jlap/received_events","type":"User","site_admin":false},"body":"This commit fixes a glitch with the modify rectangle that only occurs on the built version, and it also fixes a the styling issue in the gmf draw feature example where selecting the rectangle causes the style to be added twice.\r\n\r\nThis was occurring by a combination of the modify rectangle wanting to manage its own layer of polygons, which really wasn't necessary, and a bad management of added / removed features when creating / removing their corner handles.\r\n\r\nThe example now working well in the integrated draw feature example is available here: http://jlap.github.io/ngeo/modify-rectangle-style-bug/examples/contribs/gmf/drawfeature.html\r\n\r\nThe modify rectangle should work exactly the same as it used to: http://jlap.github.io/ngeo/modify-rectangle-style-bug/examples/modifyrectangle.html","created_at":"2016-04-27T03:13:34Z","updated_at":"2016-04-27T03:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071/commits","review_comments_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071/comments","review_comment_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/issues/1071/comments","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/8f5bc6bc48945a06453e98e3318900b3431ac3c2","head":{"label":"jlap:modify-rectangle-style-bug","ref":"modify-rectangle-style-bug","sha":"8f5bc6bc48945a06453e98e3318900b3431ac3c2","user":{"login":"jlap","id":4561544,"avatar_url":"https://avatars.githubusercontent.com/u/4561544?v=3","gravatar_id":"","url":"https://api.github.com/users/jlap","html_url":"https://github.com/jlap","followers_url":"https://api.github.com/users/jlap/followers","following_url":"https://api.github.com/users/jlap/following{/other_user}","gists_url":"https://api.github.com/users/jlap/gists{/gist_id}","starred_url":"https://api.github.com/users/jlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlap/subscriptions","organizations_url":"https://api.github.com/users/jlap/orgs","repos_url":"https://api.github.com/users/jlap/repos","events_url":"https://api.github.com/users/jlap/events{/privacy}","received_events_url":"https://api.github.com/users/jlap/received_events","type":"User","site_admin":false},"repo":{"id":56701373,"name":"ngeo","full_name":"jlap/ngeo","owner":{"login":"jlap","id":4561544,"avatar_url":"https://avatars.githubusercontent.com/u/4561544?v=3","gravatar_id":"","url":"https://api.github.com/users/jlap","html_url":"https://github.com/jlap","followers_url":"https://api.github.com/users/jlap/followers","following_url":"https://api.github.com/users/jlap/following{/other_user}","gists_url":"https://api.github.com/users/jlap/gists{/gist_id}","starred_url":"https://api.github.com/users/jlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlap/subscriptions","organizations_url":"https://api.github.com/users/jlap/orgs","repos_url":"https://api.github.com/users/jlap/repos","events_url":"https://api.github.com/users/jlap/events{/privacy}","received_events_url":"https://api.github.com/users/jlap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlap/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":true,"url":"https://api.github.com/repos/jlap/ngeo","forks_url":"https://api.github.com/repos/jlap/ngeo/forks","keys_url":"https://api.github.com/repos/jlap/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlap/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlap/ngeo/teams","hooks_url":"https://api.github.com/repos/jlap/ngeo/hooks","issue_events_url":"https://api.github.com/repos/jlap/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/jlap/ngeo/events","assignees_url":"https://api.github.com/repos/jlap/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/jlap/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/jlap/ngeo/tags","blobs_url":"https://api.github.com/repos/jlap/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlap/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlap/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlap/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlap/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/jlap/ngeo/languages","stargazers_url":"https://api.github.com/repos/jlap/ngeo/stargazers","contributors_url":"https://api.github.com/repos/jlap/ngeo/contributors","subscribers_url":"https://api.github.com/repos/jlap/ngeo/subscribers","subscription_url":"https://api.github.com/repos/jlap/ngeo/subscription","commits_url":"https://api.github.com/repos/jlap/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlap/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlap/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlap/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlap/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/jlap/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlap/ngeo/merges","archive_url":"https://api.github.com/repos/jlap/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlap/ngeo/downloads","issues_url":"https://api.github.com/repos/jlap/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/jlap/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/jlap/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/jlap/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlap/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/jlap/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/jlap/ngeo/deployments","created_at":"2016-04-20T16:03:31Z","updated_at":"2016-04-20T16:03:33Z","pushed_at":"2016-04-27T03:07:25Z","git_url":"git://github.com/jlap/ngeo.git","ssh_url":"git@github.com:jlap/ngeo.git","clone_url":"https://github.com/jlap/ngeo.git","svn_url":"https://github.com/jlap/ngeo","homepage":null,"size":92036,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"065171a96bfed9f038d2ce803dae156711a75843","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":20212761,"name":"ngeo","full_name":"camptocamp/ngeo","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":false,"url":"https://api.github.com/repos/camptocamp/ngeo","forks_url":"https://api.github.com/repos/camptocamp/ngeo/forks","keys_url":"https://api.github.com/repos/camptocamp/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/ngeo/teams","hooks_url":"https://api.github.com/repos/camptocamp/ngeo/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/ngeo/events","assignees_url":"https://api.github.com/repos/camptocamp/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/ngeo/tags","blobs_url":"https://api.github.com/repos/camptocamp/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/ngeo/languages","stargazers_url":"https://api.github.com/repos/camptocamp/ngeo/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/ngeo/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/ngeo/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/ngeo/subscription","commits_url":"https://api.github.com/repos/camptocamp/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/ngeo/merges","archive_url":"https://api.github.com/repos/camptocamp/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/ngeo/downloads","issues_url":"https://api.github.com/repos/camptocamp/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/ngeo/deployments","created_at":"2014-05-27T08:34:54Z","updated_at":"2016-04-20T17:56:00Z","pushed_at":"2016-04-27T03:13:34Z","git_url":"git://github.com/camptocamp/ngeo.git","ssh_url":"git@github.com:camptocamp/ngeo.git","clone_url":"https://github.com/camptocamp/ngeo.git","svn_url":"https://github.com/camptocamp/ngeo","homepage":null,"size":92179,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":65,"forks":44,"open_issues":65,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/1071"},"issue":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/1071"},"comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/1071/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1071/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/ngeo/statuses/8f5bc6bc48945a06453e98e3318900b3431ac3c2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":24,"changed_files":2}}