{"action":"created","issue":{"url":"https://api.github.com/repos/mzabriskie/axios/issues/423","repository_url":"https://api.github.com/repos/mzabriskie/axios","labels_url":"https://api.github.com/repos/mzabriskie/axios/issues/423/labels{/name}","comments_url":"https://api.github.com/repos/mzabriskie/axios/issues/423/comments","events_url":"https://api.github.com/repos/mzabriskie/axios/issues/423/events","html_url":"https://github.com/mzabriskie/axios/pull/423","id":172386384,"number":423,"title":"Split progress event handlers into upload and download. ","user":{"login":"diesal11","id":4567380,"avatar_url":"https://avatars.githubusercontent.com/u/4567380?v=3","gravatar_id":"","url":"https://api.github.com/users/diesal11","html_url":"https://github.com/diesal11","followers_url":"https://api.github.com/users/diesal11/followers","following_url":"https://api.github.com/users/diesal11/following{/other_user}","gists_url":"https://api.github.com/users/diesal11/gists{/gist_id}","starred_url":"https://api.github.com/users/diesal11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesal11/subscriptions","organizations_url":"https://api.github.com/users/diesal11/orgs","repos_url":"https://api.github.com/users/diesal11/repos","events_url":"https://api.github.com/users/diesal11/events{/privacy}","received_events_url":"https://api.github.com/users/diesal11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-22T07:34:26Z","updated_at":"2016-08-23T03:47:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mzabriskie/axios/pulls/423","html_url":"https://github.com/mzabriskie/axios/pull/423","diff_url":"https://github.com/mzabriskie/axios/pull/423.diff","patch_url":"https://github.com/mzabriskie/axios/pull/423.patch"},"body":"Splits progress config into two options, `progressDownload` and `progressUpload`. No longer limits these to `GET`/`POST`/`PUT` requests.\r\n\r\nPreviously there were no tests for progress handling...so i've added some. But testing is difficult as the Jasmine-AJAX plugin doesn't handle `xhr.upload.addEventListener` correctly. Im also not overly familiar with Jasmine and it's tools so if you have any ideas on how i could improve the tests please let me know :) \r\n\r\nAt some point in future i'll do a PR to allow progress events in the Node world."},"comment":{"url":"https://api.github.com/repos/mzabriskie/axios/issues/comments/241619106","html_url":"https://github.com/mzabriskie/axios/pull/423#issuecomment-241619106","issue_url":"https://api.github.com/repos/mzabriskie/axios/issues/423","id":241619106,"user":{"login":"diesal11","id":4567380,"avatar_url":"https://avatars.githubusercontent.com/u/4567380?v=3","gravatar_id":"","url":"https://api.github.com/users/diesal11","html_url":"https://github.com/diesal11","followers_url":"https://api.github.com/users/diesal11/followers","following_url":"https://api.github.com/users/diesal11/following{/other_user}","gists_url":"https://api.github.com/users/diesal11/gists{/gist_id}","starred_url":"https://api.github.com/users/diesal11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesal11/subscriptions","organizations_url":"https://api.github.com/users/diesal11/orgs","repos_url":"https://api.github.com/users/diesal11/repos","events_url":"https://api.github.com/users/diesal11/events{/privacy}","received_events_url":"https://api.github.com/users/diesal11/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T03:47:40Z","updated_at":"2016-08-23T03:47:40Z","body":"@nickuraltsev the Jasmine AJAX fakeXHR hasn't implemented upload events. So i can't do any tests on that yet. I'm gonna create an issue/PR over there so we can test this properly, not sure if you wanna wait for that before merging this.\r\n\r\nIn the meantime i've switched the tests to use spies which is much nicer."}}
{"actor":{"display_login":"diesal11"}}