{"action":"created","issue":{"url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/72","repository_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment","labels_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/72/comments","events_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/72/events","html_url":"https://github.com/flipdazed/SoftwareDevelopment/issues/72","id":142130487,"number":72,"title":"game_engine.py is becoming crowded","user":{"login":"flipdazed","id":8991915,"avatar_url":"https://avatars.githubusercontent.com/u/8991915?v=3","gravatar_id":"","url":"https://api.github.com/users/flipdazed","html_url":"https://github.com/flipdazed","followers_url":"https://api.github.com/users/flipdazed/followers","following_url":"https://api.github.com/users/flipdazed/following{/other_user}","gists_url":"https://api.github.com/users/flipdazed/gists{/gist_id}","starred_url":"https://api.github.com/users/flipdazed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipdazed/subscriptions","organizations_url":"https://api.github.com/users/flipdazed/orgs","repos_url":"https://api.github.com/users/flipdazed/repos","events_url":"https://api.github.com/users/flipdazed/events{/privacy}","received_events_url":"https://api.github.com/users/flipdazed/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/labels/medium","name":"medium","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/milestones/10","html_url":"https://github.com/flipdazed/SoftwareDevelopment/milestones/Building%20Testable%20Structures","labels_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/milestones/10/labels","id":1655250,"number":10,"title":"Building Testable Structures","description":"**Time** 1 days\r\n**Time Taken**\r\n\r\n**Aims**\r\n - Revisit the Constructors in the Classes and assess appropriateness for testing\r\n - Reassess the creation of cards\r\n - Remove interdependency\r\n - Assess redundancies in initial parameterisation\r\n - Care *must* be taken to ensure improvements are small and regular to minimise risk\r\n\r\n**Result**\r\nConstructors have to go. As does the creation of cards in its current format. Moved all settings to external file. Created method to pass parameters using python `**kwargs` directly. Significant issues in testing as the test structure had to be rewritten. Lots of car taken to ensure that each addition was a small addition and was tested thoroughly.","creator":{"login":"flipdazed","id":8991915,"avatar_url":"https://avatars.githubusercontent.com/u/8991915?v=3","gravatar_id":"","url":"https://api.github.com/users/flipdazed","html_url":"https://github.com/flipdazed","followers_url":"https://api.github.com/users/flipdazed/followers","following_url":"https://api.github.com/users/flipdazed/following{/other_user}","gists_url":"https://api.github.com/users/flipdazed/gists{/gist_id}","starred_url":"https://api.github.com/users/flipdazed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipdazed/subscriptions","organizations_url":"https://api.github.com/users/flipdazed/orgs","repos_url":"https://api.github.com/users/flipdazed/repos","events_url":"https://api.github.com/users/flipdazed/events{/privacy}","received_events_url":"https://api.github.com/users/flipdazed/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":5,"state":"open","created_at":"2016-03-19T19:22:17Z","updated_at":"2016-03-20T05:10:58Z","due_on":"2016-03-20T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-03-20T05:10:40Z","updated_at":"2016-03-20T05:10:58Z","closed_at":"2016-03-20T05:10:58Z","body":"**Bugged Version** c52fbd93047de39213dac3d2b2060d2f0c0b4505\r\n**File** `All Common Classes`\r\n**Lines** `All lines with actions`\r\n\r\n**Issue**\r\nThe `game_engine.py` file is becoming crowded and the common functions do not directly interact with their inheritants\r\n\r\n**Fix**\r\nShould move common classes outside this file to a `common.py file`"},"comment":{"url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/comments/198852190","html_url":"https://github.com/flipdazed/SoftwareDevelopment/issues/72#issuecomment-198852190","issue_url":"https://api.github.com/repos/flipdazed/SoftwareDevelopment/issues/72","id":198852190,"user":{"login":"flipdazed","id":8991915,"avatar_url":"https://avatars.githubusercontent.com/u/8991915?v=3","gravatar_id":"","url":"https://api.github.com/users/flipdazed","html_url":"https://github.com/flipdazed","followers_url":"https://api.github.com/users/flipdazed/followers","following_url":"https://api.github.com/users/flipdazed/following{/other_user}","gists_url":"https://api.github.com/users/flipdazed/gists{/gist_id}","starred_url":"https://api.github.com/users/flipdazed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipdazed/subscriptions","organizations_url":"https://api.github.com/users/flipdazed/orgs","repos_url":"https://api.github.com/users/flipdazed/repos","events_url":"https://api.github.com/users/flipdazed/events{/privacy}","received_events_url":"https://api.github.com/users/flipdazed/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T05:10:58Z","updated_at":"2016-03-20T05:10:58Z","body":"fixed"}}