{"action":"created","comment":{"url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/comments/71537328","id":71537328,"diff_hunk":"@@ -734,12 +734,12 @@ var FormValidator = A.Component.create({\n          * Gets the stack error container of a field.\n          *\n          * @method getFieldStackErrorContainer\n-         * @param {Node} field\n+         * @param {Node|String} field\n          * @return {Node}\n          */\n         getFieldStackErrorContainer: function(field) {\n             var instance = this,\n-                name = field.get('name'),\n+                name = isNode(field) ? field.get('name') : field,\n                 stackContainers = instance._stackErrorContainers;","path":"src/aui-form-validator/js/aui-form-validator.js","position":12,"original_position":12,"commit_id":"bd633c2f8ca9fe7304aea47c5fbcd429b94e0d9d","original_commit_id":"377807628c5840e58eba9cee3d3fea6e5a443d95","user":{"login":"blzaugg","id":1626739,"avatar_url":"https://avatars.githubusercontent.com/u/1626739?v=3","gravatar_id":"","url":"https://api.github.com/users/blzaugg","html_url":"https://github.com/blzaugg","followers_url":"https://api.github.com/users/blzaugg/followers","following_url":"https://api.github.com/users/blzaugg/following{/other_user}","gists_url":"https://api.github.com/users/blzaugg/gists{/gist_id}","starred_url":"https://api.github.com/users/blzaugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blzaugg/subscriptions","organizations_url":"https://api.github.com/users/blzaugg/orgs","repos_url":"https://api.github.com/users/blzaugg/repos","events_url":"https://api.github.com/users/blzaugg/events{/privacy}","received_events_url":"https://api.github.com/users/blzaugg/received_events","type":"User","site_admin":false},"body":"I've thought about doing this across all uses of `field`, to always return the \"correct\" one. But declined to do it here, for this ticket.\r\n\r\nIf we want to generally improve the code to support that, I figured we could do it on a dedicated ticket.","created_at":"2016-07-20T14:38:31Z","updated_at":"2016-07-20T14:38:31Z","html_url":"https://github.com/thiago-rocha/alloy-ui/pull/93#discussion_r71537328","pull_request_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/comments/71537328"},"html":{"href":"https://github.com/thiago-rocha/alloy-ui/pull/93#discussion_r71537328"},"pull_request":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93","id":77889333,"html_url":"https://github.com/thiago-rocha/alloy-ui/pull/93","diff_url":"https://github.com/thiago-rocha/alloy-ui/pull/93.diff","patch_url":"https://github.com/thiago-rocha/alloy-ui/pull/93.patch","issue_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/93","number":93,"state":"open","locked":false,"title":"AUI-2820","user":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"body":"Hey @thiago-rocha,\r\n\r\nAttached is an update for https://issues.liferay.com/browse/AUI-2820.\r\n\r\nPlease let me know if you have any questions. Thanks!","created_at":"2016-07-18T22:19:48Z","updated_at":"2016-07-20T14:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9be94eb52975c9a2aea3f48ed3feb3fdaa08fd75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93/commits","review_comments_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93/comments","review_comment_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/93/comments","statuses_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/statuses/bd633c2f8ca9fe7304aea47c5fbcd429b94e0d9d","head":{"label":"jonmak08:pull-request-347-AUI-2822","ref":"pull-request-347-AUI-2822","sha":"bd633c2f8ca9fe7304aea47c5fbcd429b94e0d9d","user":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"repo":{"id":1986124,"name":"alloy-ui","full_name":"jonmak08/alloy-ui","owner":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonmak08/alloy-ui","description":"","fork":true,"url":"https://api.github.com/repos/jonmak08/alloy-ui","forks_url":"https://api.github.com/repos/jonmak08/alloy-ui/forks","keys_url":"https://api.github.com/repos/jonmak08/alloy-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonmak08/alloy-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonmak08/alloy-ui/teams","hooks_url":"https://api.github.com/repos/jonmak08/alloy-ui/hooks","issue_events_url":"https://api.github.com/repos/jonmak08/alloy-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jonmak08/alloy-ui/events","assignees_url":"https://api.github.com/repos/jonmak08/alloy-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jonmak08/alloy-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jonmak08/alloy-ui/tags","blobs_url":"https://api.github.com/repos/jonmak08/alloy-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonmak08/alloy-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonmak08/alloy-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonmak08/alloy-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonmak08/alloy-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jonmak08/alloy-ui/languages","stargazers_url":"https://api.github.com/repos/jonmak08/alloy-ui/stargazers","contributors_url":"https://api.github.com/repos/jonmak08/alloy-ui/contributors","subscribers_url":"https://api.github.com/repos/jonmak08/alloy-ui/subscribers","subscription_url":"https://api.github.com/repos/jonmak08/alloy-ui/subscription","commits_url":"https://api.github.com/repos/jonmak08/alloy-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonmak08/alloy-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonmak08/alloy-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonmak08/alloy-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonmak08/alloy-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jonmak08/alloy-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonmak08/alloy-ui/merges","archive_url":"https://api.github.com/repos/jonmak08/alloy-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonmak08/alloy-ui/downloads","issues_url":"https://api.github.com/repos/jonmak08/alloy-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jonmak08/alloy-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jonmak08/alloy-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jonmak08/alloy-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonmak08/alloy-ui/labels{/name}","releases_url":"https://api.github.com/repos/jonmak08/alloy-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jonmak08/alloy-ui/deployments","created_at":"2011-07-02T00:54:01Z","updated_at":"2015-04-27T19:47:29Z","pushed_at":"2016-07-18T22:46:18Z","git_url":"git://github.com/jonmak08/alloy-ui.git","ssh_url":"git@github.com:jonmak08/alloy-ui.git","clone_url":"https://github.com/jonmak08/alloy-ui.git","svn_url":"https://github.com/jonmak08/alloy-ui","homepage":"http://alloy.liferay.com","size":633797,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"thiago-rocha:master","ref":"master","sha":"fc75b0e50c71a53d8d059b3a9e5586e4eb89031c","user":{"login":"thiago-rocha","id":1565721,"avatar_url":"https://avatars.githubusercontent.com/u/1565721?v=3","gravatar_id":"","url":"https://api.github.com/users/thiago-rocha","html_url":"https://github.com/thiago-rocha","followers_url":"https://api.github.com/users/thiago-rocha/followers","following_url":"https://api.github.com/users/thiago-rocha/following{/other_user}","gists_url":"https://api.github.com/users/thiago-rocha/gists{/gist_id}","starred_url":"https://api.github.com/users/thiago-rocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiago-rocha/subscriptions","organizations_url":"https://api.github.com/users/thiago-rocha/orgs","repos_url":"https://api.github.com/users/thiago-rocha/repos","events_url":"https://api.github.com/users/thiago-rocha/events{/privacy}","received_events_url":"https://api.github.com/users/thiago-rocha/received_events","type":"User","site_admin":false},"repo":{"id":15402922,"name":"alloy-ui","full_name":"thiago-rocha/alloy-ui","owner":{"login":"thiago-rocha","id":1565721,"avatar_url":"https://avatars.githubusercontent.com/u/1565721?v=3","gravatar_id":"","url":"https://api.github.com/users/thiago-rocha","html_url":"https://github.com/thiago-rocha","followers_url":"https://api.github.com/users/thiago-rocha/followers","following_url":"https://api.github.com/users/thiago-rocha/following{/other_user}","gists_url":"https://api.github.com/users/thiago-rocha/gists{/gist_id}","starred_url":"https://api.github.com/users/thiago-rocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiago-rocha/subscriptions","organizations_url":"https://api.github.com/users/thiago-rocha/orgs","repos_url":"https://api.github.com/users/thiago-rocha/repos","events_url":"https://api.github.com/users/thiago-rocha/events{/privacy}","received_events_url":"https://api.github.com/users/thiago-rocha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thiago-rocha/alloy-ui","description":"AlloyUI is a framework built on top of YUI3 (JavaScript) that uses Bootstrap (HTML/CSS) to provide a simple API for building high scalable applications","fork":true,"url":"https://api.github.com/repos/thiago-rocha/alloy-ui","forks_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/forks","keys_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/teams","hooks_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/hooks","issue_events_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/events{/number}","events_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/events","assignees_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/assignees{/user}","branches_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/branches{/branch}","tags_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/tags","blobs_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/languages","stargazers_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/stargazers","contributors_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/contributors","subscribers_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/subscribers","subscription_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/subscription","commits_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/contents/{+path}","compare_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/merges","archive_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/downloads","issues_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues{/number}","pulls_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/labels{/name}","releases_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/releases{/id}","deployments_url":"https://api.github.com/repos/thiago-rocha/alloy-ui/deployments","created_at":"2013-12-23T19:25:56Z","updated_at":"2015-04-28T18:58:59Z","pushed_at":"2016-07-19T16:35:45Z","git_url":"git://github.com/thiago-rocha/alloy-ui.git","ssh_url":"git@github.com:thiago-rocha/alloy-ui.git","clone_url":"https://github.com/thiago-rocha/alloy-ui.git","svn_url":"https://github.com/thiago-rocha/alloy-ui","homepage":"http://alloyui.com","size":578724,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93"},"html":{"href":"https://github.com/thiago-rocha/alloy-ui/pull/93"},"issue":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/93"},"comments":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/thiago-rocha/alloy-ui/statuses/bd633c2f8ca9fe7304aea47c5fbcd429b94e0d9d"}}}}
{"actor":{"display_login":"blzaugg"}}