{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9300","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9300/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9300/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9300/events","html_url":"https://github.com/cockroachdb/cockroach/pull/9300","id":176453475,"number":9300,"title":"storage: Store.updateReplicationGauges will now hold the store lock for less time","user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cockroachdb/cockroach/milestones/5","html_url":"https://github.com/cockroachdb/cockroach/milestones/Q3","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones/5/labels","id":1875804,"number":5,"title":"Q3","description":"","creator":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"open_issues":142,"closed_issues":218,"state":"open","created_at":"2016-07-11T13:25:51Z","updated_at":"2016-09-12T21:11:41Z","due_on":"2016-10-01T04:00:00Z","closed_at":null},"comments":5,"created_at":"2016-09-12T18:48:31Z","updated_at":"2016-09-12T23:01:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9300","html_url":"https://github.com/cockroachdb/cockroach/pull/9300","diff_url":"https://github.com/cockroachdb/cockroach/pull/9300.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/9300.patch"},"body":"\r\nCloses #9261\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/9300)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/246522751","html_url":"https://github.com/cockroachdb/cockroach/pull/9300#issuecomment-246522751","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9300","id":246522751,"user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T23:01:13Z","updated_at":"2016-09-12T23:01:13Z","body":"I'm actually wondering if it's worth fixing up the RangeSet to not get the lock each time, and to only get the store lock once and store the pointers.   Would be an easy fix.  (also renaming it to replicaSet while I'm at it.\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/9300#-:-KRVc6EVZGpNGtDDoUOn:bbgizbd)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"BramGruneir"}}