{"action":"opened","number":175,"pull_request":{"url":"https://api.github.com/repos/chjj/pty.js/pulls/175","id":88744092,"html_url":"https://github.com/chjj/pty.js/pull/175","diff_url":"https://github.com/chjj/pty.js/pull/175.diff","patch_url":"https://github.com/chjj/pty.js/pull/175.patch","issue_url":"https://api.github.com/repos/chjj/pty.js/issues/175","number":175,"state":"open","locked":false,"title":"Fixes #137: Follow Windows conventions when composing cmdline","user":{"login":"the-ress","id":1612377,"avatar_url":"https://avatars.githubusercontent.com/u/1612377?v=3","gravatar_id":"","url":"https://api.github.com/users/the-ress","html_url":"https://github.com/the-ress","followers_url":"https://api.github.com/users/the-ress/followers","following_url":"https://api.github.com/users/the-ress/following{/other_user}","gists_url":"https://api.github.com/users/the-ress/gists{/gist_id}","starred_url":"https://api.github.com/users/the-ress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-ress/subscriptions","organizations_url":"https://api.github.com/users/the-ress/orgs","repos_url":"https://api.github.com/users/the-ress/repos","events_url":"https://api.github.com/users/the-ress/events{/privacy}","received_events_url":"https://api.github.com/users/the-ress/received_events","type":"User","site_admin":false},"body":"1. All parts of the command line are being escaped following the [convention documented on MSDN](https://msdn.microsoft.com/en-us/library/windows/desktop/bb776391(v=vs.85).aspx)\r\n\r\n2. The application is added as the first argument to follow the Windows convention:\r\n\r\n> Because argv[0] is the module name, C programmers generally repeat the module name as the first token in the command line.\r\n> [MSDN](https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx)\r\n\r\n>(...) if you are launching other programs and passing an explicit lpApplicationName, then it behooves you to format the command line in a compatible manner. Otherwise, the results may not be what you expect.\r\n> [The Old New Thing](https://blogs.msdn.microsoft.com/oldnewthing/20060515-07/?p=31203)\r\n","created_at":"2016-10-10T22:50:10Z","updated_at":"2016-10-10T22:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chjj/pty.js/pulls/175/commits","review_comments_url":"https://api.github.com/repos/chjj/pty.js/pulls/175/comments","review_comment_url":"https://api.github.com/repos/chjj/pty.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chjj/pty.js/issues/175/comments","statuses_url":"https://api.github.com/repos/chjj/pty.js/statuses/1b1c6cbe90d66e50c024cbfd085fb2e95dc1e87f","head":{"label":"the-ress:windows-cmdline","ref":"windows-cmdline","sha":"1b1c6cbe90d66e50c024cbfd085fb2e95dc1e87f","user":{"login":"the-ress","id":1612377,"avatar_url":"https://avatars.githubusercontent.com/u/1612377?v=3","gravatar_id":"","url":"https://api.github.com/users/the-ress","html_url":"https://github.com/the-ress","followers_url":"https://api.github.com/users/the-ress/followers","following_url":"https://api.github.com/users/the-ress/following{/other_user}","gists_url":"https://api.github.com/users/the-ress/gists{/gist_id}","starred_url":"https://api.github.com/users/the-ress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-ress/subscriptions","organizations_url":"https://api.github.com/users/the-ress/orgs","repos_url":"https://api.github.com/users/the-ress/repos","events_url":"https://api.github.com/users/the-ress/events{/privacy}","received_events_url":"https://api.github.com/users/the-ress/received_events","type":"User","site_admin":false},"repo":{"id":70530672,"name":"pty.js","full_name":"the-ress/pty.js","owner":{"login":"the-ress","id":1612377,"avatar_url":"https://avatars.githubusercontent.com/u/1612377?v=3","gravatar_id":"","url":"https://api.github.com/users/the-ress","html_url":"https://github.com/the-ress","followers_url":"https://api.github.com/users/the-ress/followers","following_url":"https://api.github.com/users/the-ress/following{/other_user}","gists_url":"https://api.github.com/users/the-ress/gists{/gist_id}","starred_url":"https://api.github.com/users/the-ress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-ress/subscriptions","organizations_url":"https://api.github.com/users/the-ress/orgs","repos_url":"https://api.github.com/users/the-ress/repos","events_url":"https://api.github.com/users/the-ress/events{/privacy}","received_events_url":"https://api.github.com/users/the-ress/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/the-ress/pty.js","description":"Bindings to forkpty(3) for node.js.","fork":true,"url":"https://api.github.com/repos/the-ress/pty.js","forks_url":"https://api.github.com/repos/the-ress/pty.js/forks","keys_url":"https://api.github.com/repos/the-ress/pty.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-ress/pty.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-ress/pty.js/teams","hooks_url":"https://api.github.com/repos/the-ress/pty.js/hooks","issue_events_url":"https://api.github.com/repos/the-ress/pty.js/issues/events{/number}","events_url":"https://api.github.com/repos/the-ress/pty.js/events","assignees_url":"https://api.github.com/repos/the-ress/pty.js/assignees{/user}","branches_url":"https://api.github.com/repos/the-ress/pty.js/branches{/branch}","tags_url":"https://api.github.com/repos/the-ress/pty.js/tags","blobs_url":"https://api.github.com/repos/the-ress/pty.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-ress/pty.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-ress/pty.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-ress/pty.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-ress/pty.js/statuses/{sha}","languages_url":"https://api.github.com/repos/the-ress/pty.js/languages","stargazers_url":"https://api.github.com/repos/the-ress/pty.js/stargazers","contributors_url":"https://api.github.com/repos/the-ress/pty.js/contributors","subscribers_url":"https://api.github.com/repos/the-ress/pty.js/subscribers","subscription_url":"https://api.github.com/repos/the-ress/pty.js/subscription","commits_url":"https://api.github.com/repos/the-ress/pty.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-ress/pty.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-ress/pty.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-ress/pty.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-ress/pty.js/contents/{+path}","compare_url":"https://api.github.com/repos/the-ress/pty.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-ress/pty.js/merges","archive_url":"https://api.github.com/repos/the-ress/pty.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-ress/pty.js/downloads","issues_url":"https://api.github.com/repos/the-ress/pty.js/issues{/number}","pulls_url":"https://api.github.com/repos/the-ress/pty.js/pulls{/number}","milestones_url":"https://api.github.com/repos/the-ress/pty.js/milestones{/number}","notifications_url":"https://api.github.com/repos/the-ress/pty.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-ress/pty.js/labels{/name}","releases_url":"https://api.github.com/repos/the-ress/pty.js/releases{/id}","deployments_url":"https://api.github.com/repos/the-ress/pty.js/deployments","created_at":"2016-10-10T21:33:46Z","updated_at":"2016-10-10T21:33:47Z","pushed_at":"2016-10-10T22:38:36Z","git_url":"git://github.com/the-ress/pty.js.git","ssh_url":"git@github.com:the-ress/pty.js.git","clone_url":"https://github.com/the-ress/pty.js.git","svn_url":"https://github.com/the-ress/pty.js","homepage":"","size":1799,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"prebuilt"}},"base":{"label":"chjj:master","ref":"master","sha":"fe63a412574f45ee6bb6d8fab4a5c102107b5201","user":{"login":"chjj","id":470564,"avatar_url":"https://avatars.githubusercontent.com/u/470564?v=3","gravatar_id":"","url":"https://api.github.com/users/chjj","html_url":"https://github.com/chjj","followers_url":"https://api.github.com/users/chjj/followers","following_url":"https://api.github.com/users/chjj/following{/other_user}","gists_url":"https://api.github.com/users/chjj/gists{/gist_id}","starred_url":"https://api.github.com/users/chjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chjj/subscriptions","organizations_url":"https://api.github.com/users/chjj/orgs","repos_url":"https://api.github.com/users/chjj/repos","events_url":"https://api.github.com/users/chjj/events{/privacy}","received_events_url":"https://api.github.com/users/chjj/received_events","type":"User","site_admin":false},"repo":{"id":3507871,"name":"pty.js","full_name":"chjj/pty.js","owner":{"login":"chjj","id":470564,"avatar_url":"https://avatars.githubusercontent.com/u/470564?v=3","gravatar_id":"","url":"https://api.github.com/users/chjj","html_url":"https://github.com/chjj","followers_url":"https://api.github.com/users/chjj/followers","following_url":"https://api.github.com/users/chjj/following{/other_user}","gists_url":"https://api.github.com/users/chjj/gists{/gist_id}","starred_url":"https://api.github.com/users/chjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chjj/subscriptions","organizations_url":"https://api.github.com/users/chjj/orgs","repos_url":"https://api.github.com/users/chjj/repos","events_url":"https://api.github.com/users/chjj/events{/privacy}","received_events_url":"https://api.github.com/users/chjj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chjj/pty.js","description":"Bindings to forkpty(3) for node.js.","fork":false,"url":"https://api.github.com/repos/chjj/pty.js","forks_url":"https://api.github.com/repos/chjj/pty.js/forks","keys_url":"https://api.github.com/repos/chjj/pty.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chjj/pty.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chjj/pty.js/teams","hooks_url":"https://api.github.com/repos/chjj/pty.js/hooks","issue_events_url":"https://api.github.com/repos/chjj/pty.js/issues/events{/number}","events_url":"https://api.github.com/repos/chjj/pty.js/events","assignees_url":"https://api.github.com/repos/chjj/pty.js/assignees{/user}","branches_url":"https://api.github.com/repos/chjj/pty.js/branches{/branch}","tags_url":"https://api.github.com/repos/chjj/pty.js/tags","blobs_url":"https://api.github.com/repos/chjj/pty.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chjj/pty.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chjj/pty.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chjj/pty.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chjj/pty.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chjj/pty.js/languages","stargazers_url":"https://api.github.com/repos/chjj/pty.js/stargazers","contributors_url":"https://api.github.com/repos/chjj/pty.js/contributors","subscribers_url":"https://api.github.com/repos/chjj/pty.js/subscribers","subscription_url":"https://api.github.com/repos/chjj/pty.js/subscription","commits_url":"https://api.github.com/repos/chjj/pty.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chjj/pty.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chjj/pty.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chjj/pty.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chjj/pty.js/contents/{+path}","compare_url":"https://api.github.com/repos/chjj/pty.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chjj/pty.js/merges","archive_url":"https://api.github.com/repos/chjj/pty.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chjj/pty.js/downloads","issues_url":"https://api.github.com/repos/chjj/pty.js/issues{/number}","pulls_url":"https://api.github.com/repos/chjj/pty.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chjj/pty.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chjj/pty.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chjj/pty.js/labels{/name}","releases_url":"https://api.github.com/repos/chjj/pty.js/releases{/id}","deployments_url":"https://api.github.com/repos/chjj/pty.js/deployments","created_at":"2012-02-21T20:32:10Z","updated_at":"2016-10-10T20:12:03Z","pushed_at":"2016-10-10T22:50:10Z","git_url":"git://github.com/chjj/pty.js.git","ssh_url":"git@github.com:chjj/pty.js.git","clone_url":"https://github.com/chjj/pty.js.git","svn_url":"https://github.com/chjj/pty.js","homepage":"","size":4170,"stargazers_count":530,"watchers_count":530,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":71,"forks":170,"open_issues":71,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chjj/pty.js/pulls/175"},"html":{"href":"https://github.com/chjj/pty.js/pull/175"},"issue":{"href":"https://api.github.com/repos/chjj/pty.js/issues/175"},"comments":{"href":"https://api.github.com/repos/chjj/pty.js/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/chjj/pty.js/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/chjj/pty.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chjj/pty.js/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/chjj/pty.js/statuses/1b1c6cbe90d66e50c024cbfd085fb2e95dc1e87f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":113,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"the-ress"}}