{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11","id":74322642,"html_url":"https://github.com/deis/controller-sdk-go/pull/11","diff_url":"https://github.com/deis/controller-sdk-go/pull/11.diff","patch_url":"https://github.com/deis/controller-sdk-go/pull/11.patch","issue_url":"https://api.github.com/repos/deis/controller-sdk-go/issues/11","number":11,"state":"closed","locked":false,"title":"ref(*): pass io.ReadCloser instead of string body","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"body":"Requested by @arschles \r\n\r\nNote that this PR removes the current system of error messages, because it is incompatible with the `io.ReadCloser` refactor.\r\nMy work over the next few days will be to implement a new error system based on error constants that can be checked by sdk users and that will be compatible with `io.Readers`. If we don't want to temporarily remove verbose error messages, I can get this reviewed, then submit a new PR with both this refactor and the error messages refactor.\r\n\r\nAlso note that this does not affect `LimitedRequest()`. This is because it needs to parse the json body in order to work, meaning that the response already has to be converted to a string. I'm open for ways that this could be better implemented.\r\n\r\nI'm returning the entire `*http.Response` object as opposed to just the body, because some of the information, such as response code, can be used to return specific error messages for an action with my error messages rewrite.","created_at":"2016-06-18T00:52:38Z","updated_at":"2016-06-21T17:44:02Z","closed_at":"2016-06-21T17:44:02Z","merged_at":"2016-06-21T17:44:02Z","merge_commit_sha":"70f7e86ef4f9061b26a4dde2777e1c14cf8cd491","assignee":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller-sdk-go/milestones/8","html_url":"https://github.com/deis/controller-sdk-go/milestones/v2.1-pre1","labels_url":"https://api.github.com/repos/deis/controller-sdk-go/milestones/8/labels","id":1831016,"number":8,"title":"v2.1-pre1","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":4,"state":"open","created_at":"2016-06-15T22:42:03Z","updated_at":"2016-06-21T17:44:02Z","due_on":"2016-06-22T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11/commits","review_comments_url":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11/comments","review_comment_url":"https://api.github.com/repos/deis/controller-sdk-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/controller-sdk-go/issues/11/comments","statuses_url":"https://api.github.com/repos/deis/controller-sdk-go/statuses/bcca709056d8a6eeca1498dda01778985f442b94","head":{"label":"Joshua-Anderson:use-reader","ref":"use-reader","sha":"bcca709056d8a6eeca1498dda01778985f442b94","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"repo":{"id":61147726,"name":"controller-sdk-go","full_name":"Joshua-Anderson/controller-sdk-go","owner":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Joshua-Anderson/controller-sdk-go","description":"The Go SDK for the Deis Controller API","fork":true,"url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go","forks_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/forks","keys_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/teams","hooks_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/events","assignees_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/tags","blobs_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/languages","stargazers_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/subscription","commits_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/merges","archive_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/downloads","issues_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/Joshua-Anderson/controller-sdk-go/deployments","created_at":"2016-06-14T18:50:12Z","updated_at":"2016-06-15T18:30:46Z","pushed_at":"2016-06-21T15:51:54Z","git_url":"git://github.com/Joshua-Anderson/controller-sdk-go.git","ssh_url":"git@github.com:Joshua-Anderson/controller-sdk-go.git","clone_url":"https://github.com/Joshua-Anderson/controller-sdk-go.git","svn_url":"https://github.com/Joshua-Anderson/controller-sdk-go","homepage":null,"size":1310,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"aba8426cebe1717cd8fb755543002894d0453a73","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":61147483,"name":"controller-sdk-go","full_name":"deis/controller-sdk-go","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/controller-sdk-go","description":"The Go SDK for the Deis Controller API","fork":false,"url":"https://api.github.com/repos/deis/controller-sdk-go","forks_url":"https://api.github.com/repos/deis/controller-sdk-go/forks","keys_url":"https://api.github.com/repos/deis/controller-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/controller-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/controller-sdk-go/teams","hooks_url":"https://api.github.com/repos/deis/controller-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/deis/controller-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/deis/controller-sdk-go/events","assignees_url":"https://api.github.com/repos/deis/controller-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/deis/controller-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/deis/controller-sdk-go/tags","blobs_url":"https://api.github.com/repos/deis/controller-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/controller-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/controller-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/controller-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/controller-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/controller-sdk-go/languages","stargazers_url":"https://api.github.com/repos/deis/controller-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/deis/controller-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/deis/controller-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/deis/controller-sdk-go/subscription","commits_url":"https://api.github.com/repos/deis/controller-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/controller-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/controller-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/controller-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/controller-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/deis/controller-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/controller-sdk-go/merges","archive_url":"https://api.github.com/repos/deis/controller-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/controller-sdk-go/downloads","issues_url":"https://api.github.com/repos/deis/controller-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/deis/controller-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/controller-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/controller-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/controller-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/deis/controller-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/deis/controller-sdk-go/deployments","created_at":"2016-06-14T18:46:27Z","updated_at":"2016-06-15T16:41:12Z","pushed_at":"2016-06-21T17:44:03Z","git_url":"git://github.com/deis/controller-sdk-go.git","ssh_url":"git@github.com:deis/controller-sdk-go.git","clone_url":"https://github.com/deis/controller-sdk-go.git","svn_url":"https://github.com/deis/controller-sdk-go","homepage":null,"size":1307,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11"},"html":{"href":"https://github.com/deis/controller-sdk-go/pull/11"},"issue":{"href":"https://api.github.com/repos/deis/controller-sdk-go/issues/11"},"comments":{"href":"https://api.github.com/repos/deis/controller-sdk-go/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/controller-sdk-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/controller-sdk-go/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/deis/controller-sdk-go/statuses/bcca709056d8a6eeca1498dda01778985f442b94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"commits":1,"additions":222,"deletions":208,"changed_files":13}}
{"actor":{"display_login":"Joshua-Anderson"}}