{"action":"created","comment":{"url":"https://api.github.com/repos/xapian/xapian/pulls/comments/69823171","id":69823171,"diff_hunk":"@@ -377,13 +379,279 @@ dnl this warning.\n PERCENT='%'\n AC_SUBST([PERCENT])\n \n+dnl If valgrind is installed and new enough, we use it for leak checking in the\n+dnl testsuite.  If VALGRIND is set to an empty value, then skip the check and\n+dnl don't use valgrind.\n+if test -n \"${VALGRIND-unset}\" ; then\n+  AC_PATH_PROG([VALGRIND], [valgrind], [])\n+  if test -n \"$VALGRIND\" ; then\n+    dnl Check that the installed valgrind version works, and supports the\n+    dnl options we use.  This means we won't try to use valgrind < 3.3.0\n+    dnl (released 7/12/2007) since before that --log-file didn't expand\n+    dnl %p (and appended the process id).\n+    dnl\n+    dnl No need to check for VALGRIND_COUNT_LEAKS now - that was added before\n+    dnl 2.0.0.\n+    AC_MSG_CHECKING([if valgrind supports --log-file with %p])\n+    vglog=config.vglog.%p.tmp\n+    vglogwild=\"config.vglog.*.tmp*\"\n+    rm -f $vglogwild\n+    if $VALGRIND --log-file=\"$vglog\" -q true 2>&AS_MESSAGE_LOG_FD ; then\n+      for f in $vglogwild ; do\n+        case $f in\n+    $vglog*) VALGRIND= ;;\n+    esac\n+      done\n+      if test x\"$VALGRIND\" = x ; then\n+    AC_MSG_RESULT([no])\n+      else\n+    AC_MSG_RESULT([yes])\n+    AC_CHECK_HEADERS([valgrind/memcheck.h], [], [VALGRIND=], [ ])\n+      fi\n+    else\n+      dnl The valgrind detected doesn't seem to work!  Perhaps this is an\n+      dnl x86_64 box with a 32 bit valgrind.\n+      AC_MSG_RESULT([$VALGRIND doesn't work])\n+      VALGRIND=\n+    fi\n+    rm -f $vglogwild\n+  fi\n+fi\n+\n+if test -n \"$VALGRIND\" ; then\n+  AC_DEFINE([HAVE_VALGRIND], [1], [Define if a suitable valgrind is installed])\n+fi\n+\n+dnl If eatmydata is installed, we run the testsuite under it to speed it up.\n+dnl If EATMYDATA is set to an empty value, then skip this check and don't use\n+dnl eatmydata.\n+if test -n \"${EATMYDATA-unset}\" ; then\n+  AC_PATH_PROG([EATMYDATA], [eatmydata], [])\n+fi\n+\n+dnl Used by tests/harness/testsuite.cc\n+AC_CHECK_FUNCS([sigaction])\n+AC_MSG_CHECKING([for sigsetjmp and siglongjmp])\n+AC_TRY_COMPILE([#include <setjmp.h>],\n+  [sigjmp_buf jb; if (sigsetjmp(jb, 1)) { siglongjmp(jb, 1);  }],\n+  AC_DEFINE([HAVE_SIGSETJMP], [1], [Define to 1 if you have the 'sigsetjmp' function])\n+  AC_MSG_RESULT([yes]),\n+  AC_MSG_RESULT([no]))\n+\n+dnl ***************************\n+dnl * Select modules to build *\n+dnl ***************************\n+\n+dnl Check which database backends should be built.","path":"xapian-letor/configure.ac","position":76,"original_position":76,"commit_id":"8144dd2eaa4d46ea2e519f49274d3df0eaba11fd","original_commit_id":"8144dd2eaa4d46ea2e519f49274d3df0eaba11fd","user":{"login":"jaylett","id":80187,"avatar_url":"https://avatars.githubusercontent.com/u/80187?v=3","gravatar_id":"","url":"https://api.github.com/users/jaylett","html_url":"https://github.com/jaylett","followers_url":"https://api.github.com/users/jaylett/followers","following_url":"https://api.github.com/users/jaylett/following{/other_user}","gists_url":"https://api.github.com/users/jaylett/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylett/subscriptions","organizations_url":"https://api.github.com/users/jaylett/orgs","repos_url":"https://api.github.com/users/jaylett/repos","events_url":"https://api.github.com/users/jaylett/events{/privacy}","received_events_url":"https://api.github.com/users/jaylett/received_events","type":"User","site_admin":false},"body":":)\r\n\r\nDefinitely worth at least understanding what the bits are doing, which shouldn't take all that long to get into. Knowing how to write autoconf takes longer, because of things like m4 quoting :-(","created_at":"2016-07-06T22:28:43Z","updated_at":"2016-07-06T22:28:43Z","html_url":"https://github.com/xapian/xapian/pull/110#discussion_r69823171","pull_request_url":"https://api.github.com/repos/xapian/xapian/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments/69823171"},"html":{"href":"https://github.com/xapian/xapian/pull/110#discussion_r69823171"},"pull_request":{"href":"https://api.github.com/repos/xapian/xapian/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/xapian/xapian/pulls/110","id":76083205,"html_url":"https://github.com/xapian/xapian/pull/110","diff_url":"https://github.com/xapian/xapian/pull/110.diff","patch_url":"https://github.com/xapian/xapian/pull/110.patch","issue_url":"https://api.github.com/repos/xapian/xapian/issues/110","number":110,"state":"open","locked":false,"title":"Add test suite for xapian-letor","user":{"login":"ayshtmr","id":6681897,"avatar_url":"https://avatars.githubusercontent.com/u/6681897?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshtmr","html_url":"https://github.com/ayshtmr","followers_url":"https://api.github.com/users/ayshtmr/followers","following_url":"https://api.github.com/users/ayshtmr/following{/other_user}","gists_url":"https://api.github.com/users/ayshtmr/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshtmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshtmr/subscriptions","organizations_url":"https://api.github.com/users/ayshtmr/orgs","repos_url":"https://api.github.com/users/ayshtmr/repos","events_url":"https://api.github.com/users/ayshtmr/events{/privacy}","received_events_url":"https://api.github.com/users/ayshtmr/received_events","type":"User","site_admin":false},"body":"This PR adds test suite to xapian-letor, by simply copying the test harness from xapian-core and cutting out everything except supporting code for apitests.","created_at":"2016-07-03T07:42:51Z","updated_at":"2016-07-06T22:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e78fe28c3907800c5a3c98130fb3b1fa4c7b715","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapian/xapian/pulls/110/commits","review_comments_url":"https://api.github.com/repos/xapian/xapian/pulls/110/comments","review_comment_url":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapian/xapian/issues/110/comments","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/8144dd2eaa4d46ea2e519f49274d3df0eaba11fd","head":{"label":"ayshtmr:letor-intro-2","ref":"letor-intro-2","sha":"8144dd2eaa4d46ea2e519f49274d3df0eaba11fd","user":{"login":"ayshtmr","id":6681897,"avatar_url":"https://avatars.githubusercontent.com/u/6681897?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshtmr","html_url":"https://github.com/ayshtmr","followers_url":"https://api.github.com/users/ayshtmr/followers","following_url":"https://api.github.com/users/ayshtmr/following{/other_user}","gists_url":"https://api.github.com/users/ayshtmr/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshtmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshtmr/subscriptions","organizations_url":"https://api.github.com/users/ayshtmr/orgs","repos_url":"https://api.github.com/users/ayshtmr/repos","events_url":"https://api.github.com/users/ayshtmr/events{/privacy}","received_events_url":"https://api.github.com/users/ayshtmr/received_events","type":"User","site_admin":false},"repo":{"id":53319064,"name":"xapian","full_name":"ayshtmr/xapian","owner":{"login":"ayshtmr","id":6681897,"avatar_url":"https://avatars.githubusercontent.com/u/6681897?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshtmr","html_url":"https://github.com/ayshtmr","followers_url":"https://api.github.com/users/ayshtmr/followers","following_url":"https://api.github.com/users/ayshtmr/following{/other_user}","gists_url":"https://api.github.com/users/ayshtmr/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshtmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshtmr/subscriptions","organizations_url":"https://api.github.com/users/ayshtmr/orgs","repos_url":"https://api.github.com/users/ayshtmr/repos","events_url":"https://api.github.com/users/ayshtmr/events{/privacy}","received_events_url":"https://api.github.com/users/ayshtmr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayshtmr/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":true,"url":"https://api.github.com/repos/ayshtmr/xapian","forks_url":"https://api.github.com/repos/ayshtmr/xapian/forks","keys_url":"https://api.github.com/repos/ayshtmr/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayshtmr/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayshtmr/xapian/teams","hooks_url":"https://api.github.com/repos/ayshtmr/xapian/hooks","issue_events_url":"https://api.github.com/repos/ayshtmr/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/ayshtmr/xapian/events","assignees_url":"https://api.github.com/repos/ayshtmr/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/ayshtmr/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/ayshtmr/xapian/tags","blobs_url":"https://api.github.com/repos/ayshtmr/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayshtmr/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayshtmr/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayshtmr/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayshtmr/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/ayshtmr/xapian/languages","stargazers_url":"https://api.github.com/repos/ayshtmr/xapian/stargazers","contributors_url":"https://api.github.com/repos/ayshtmr/xapian/contributors","subscribers_url":"https://api.github.com/repos/ayshtmr/xapian/subscribers","subscription_url":"https://api.github.com/repos/ayshtmr/xapian/subscription","commits_url":"https://api.github.com/repos/ayshtmr/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayshtmr/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayshtmr/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayshtmr/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayshtmr/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/ayshtmr/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayshtmr/xapian/merges","archive_url":"https://api.github.com/repos/ayshtmr/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayshtmr/xapian/downloads","issues_url":"https://api.github.com/repos/ayshtmr/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/ayshtmr/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/ayshtmr/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/ayshtmr/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayshtmr/xapian/labels{/name}","releases_url":"https://api.github.com/repos/ayshtmr/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/ayshtmr/xapian/deployments","created_at":"2016-03-07T11:06:41Z","updated_at":"2016-03-07T11:06:47Z","pushed_at":"2016-07-03T13:07:23Z","git_url":"git://github.com/ayshtmr/xapian.git","ssh_url":"git@github.com:ayshtmr/xapian.git","clone_url":"https://github.com/ayshtmr/xapian.git","svn_url":"https://github.com/ayshtmr/xapian","homepage":"https://xapian.org/","size":77427,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapian:master","ref":"master","sha":"ea0f24080aa73f8048ee59896ed3dea2fae02789","user":{"login":"xapian","id":312861,"avatar_url":"https://avatars.githubusercontent.com/u/312861?v=3","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"repo":{"id":735981,"name":"xapian","full_name":"xapian/xapian","owner":{"login":"xapian","id":312861,"avatar_url":"https://avatars.githubusercontent.com/u/312861?v=3","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapian/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":false,"url":"https://api.github.com/repos/xapian/xapian","forks_url":"https://api.github.com/repos/xapian/xapian/forks","keys_url":"https://api.github.com/repos/xapian/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapian/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapian/xapian/teams","hooks_url":"https://api.github.com/repos/xapian/xapian/hooks","issue_events_url":"https://api.github.com/repos/xapian/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/xapian/xapian/events","assignees_url":"https://api.github.com/repos/xapian/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/xapian/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/xapian/xapian/tags","blobs_url":"https://api.github.com/repos/xapian/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapian/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapian/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapian/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/xapian/xapian/languages","stargazers_url":"https://api.github.com/repos/xapian/xapian/stargazers","contributors_url":"https://api.github.com/repos/xapian/xapian/contributors","subscribers_url":"https://api.github.com/repos/xapian/xapian/subscribers","subscription_url":"https://api.github.com/repos/xapian/xapian/subscription","commits_url":"https://api.github.com/repos/xapian/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapian/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapian/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapian/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapian/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/xapian/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapian/xapian/merges","archive_url":"https://api.github.com/repos/xapian/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapian/xapian/downloads","issues_url":"https://api.github.com/repos/xapian/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/xapian/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/xapian/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/xapian/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapian/xapian/labels{/name}","releases_url":"https://api.github.com/repos/xapian/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/xapian/xapian/deployments","created_at":"2010-06-23T15:51:03Z","updated_at":"2016-07-03T18:05:59Z","pushed_at":"2016-07-06T20:53:08Z","git_url":"git://github.com/xapian/xapian.git","ssh_url":"git@github.com:xapian/xapian.git","clone_url":"https://github.com/xapian/xapian.git","svn_url":"https://github.com/xapian/xapian","homepage":"https://xapian.org/","size":89060,"stargazers_count":266,"watchers_count":266,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":18,"forks":141,"open_issues":18,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/110"},"html":{"href":"https://github.com/xapian/xapian/pull/110"},"issue":{"href":"https://api.github.com/repos/xapian/xapian/issues/110"},"comments":{"href":"https://api.github.com/repos/xapian/xapian/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/xapian/xapian/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapian/xapian/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/xapian/xapian/statuses/8144dd2eaa4d46ea2e519f49274d3df0eaba11fd"}}}}
{"actor":{"display_login":"jaylett"}}