{"action":"created","comment":{"url":"https://api.github.com/repos/electron/brightray/pulls/comments/58986795","id":58986795,"diff_hunk":"@@ -129,6 +131,19 @@ int X11EmptyIOErrorHandler(Display* d) {\n }\n #endif\n \n+base::string16 MediaStringProvider(media::MessageId id) {\n+  switch (id) {\n+    case media::DEFAULT_AUDIO_DEVICE_NAME:\n+      return l10n_util::GetStringUTF16(IDS_DEFAULT_AUDIO_DEVICE_NAME);","path":"browser/browser_main_parts.cc","position":18,"original_position":18,"commit_id":"648f28585fff2914ea48df70b5e87ab21bf1f680","original_commit_id":"648f28585fff2914ea48df70b5e87ab21bf1f680","user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"body":"How about just returning `\"Default\"` directly so we don't have to patch libchromiumcontent?","created_at":"2016-04-08T07:00:47Z","updated_at":"2016-04-08T07:00:47Z","html_url":"https://github.com/electron/brightray/pull/207#discussion_r58986795","pull_request_url":"https://api.github.com/repos/electron/brightray/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/electron/brightray/pulls/comments/58986795"},"html":{"href":"https://github.com/electron/brightray/pull/207#discussion_r58986795"},"pull_request":{"href":"https://api.github.com/repos/electron/brightray/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/electron/brightray/pulls/207","id":65611080,"html_url":"https://github.com/electron/brightray/pull/207","diff_url":"https://github.com/electron/brightray/pull/207.diff","patch_url":"https://github.com/electron/brightray/pull/207.patch","issue_url":"https://api.github.com/repos/electron/brightray/issues/207","number":207,"state":"open","locked":false,"title":"register localized media strings","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Depends on https://github.com/electron/libchromiumcontent/pull/195\r\n\r\nFixes https://github.com/electron/electron/issues/4931","created_at":"2016-04-07T11:00:13Z","updated_at":"2016-04-08T07:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fd02c3add80735f7afb6a68bb22267dd5cbdff5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electron/brightray/pulls/207/commits","review_comments_url":"https://api.github.com/repos/electron/brightray/pulls/207/comments","review_comment_url":"https://api.github.com/repos/electron/brightray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/brightray/issues/207/comments","statuses_url":"https://api.github.com/repos/electron/brightray/statuses/648f28585fff2914ea48df70b5e87ab21bf1f680","head":{"label":"deepak1556:localized_media_strings_patch","ref":"localized_media_strings_patch","sha":"648f28585fff2914ea48df70b5e87ab21bf1f680","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":31939088,"name":"brightray","full_name":"deepak1556/brightray","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/brightray","description":"A thin shim over Chromium’s Content module","fork":true,"url":"https://api.github.com/repos/deepak1556/brightray","forks_url":"https://api.github.com/repos/deepak1556/brightray/forks","keys_url":"https://api.github.com/repos/deepak1556/brightray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/brightray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/brightray/teams","hooks_url":"https://api.github.com/repos/deepak1556/brightray/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/brightray/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/brightray/events","assignees_url":"https://api.github.com/repos/deepak1556/brightray/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/brightray/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/brightray/tags","blobs_url":"https://api.github.com/repos/deepak1556/brightray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/brightray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/brightray/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/brightray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/brightray/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/brightray/languages","stargazers_url":"https://api.github.com/repos/deepak1556/brightray/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/brightray/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/brightray/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/brightray/subscription","commits_url":"https://api.github.com/repos/deepak1556/brightray/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/brightray/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/brightray/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/brightray/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepak1556/brightray/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/brightray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/brightray/merges","archive_url":"https://api.github.com/repos/deepak1556/brightray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/brightray/downloads","issues_url":"https://api.github.com/repos/deepak1556/brightray/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/brightray/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/brightray/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/brightray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/brightray/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/brightray/releases{/id}","deployments_url":"https://api.github.com/repos/deepak1556/brightray/deployments","created_at":"2015-03-10T04:53:32Z","updated_at":"2016-04-04T18:07:43Z","pushed_at":"2016-04-07T10:55:45Z","git_url":"git://github.com/deepak1556/brightray.git","ssh_url":"git@github.com:deepak1556/brightray.git","clone_url":"https://github.com/deepak1556/brightray.git","svn_url":"https://github.com/deepak1556/brightray","homepage":null,"size":960,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"2844a30ad2837417beb4c8528accd538f45bffa5","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":8752625,"name":"brightray","full_name":"electron/brightray","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/brightray","description":"A thin shim over Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/electron/brightray","forks_url":"https://api.github.com/repos/electron/brightray/forks","keys_url":"https://api.github.com/repos/electron/brightray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/brightray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/brightray/teams","hooks_url":"https://api.github.com/repos/electron/brightray/hooks","issue_events_url":"https://api.github.com/repos/electron/brightray/issues/events{/number}","events_url":"https://api.github.com/repos/electron/brightray/events","assignees_url":"https://api.github.com/repos/electron/brightray/assignees{/user}","branches_url":"https://api.github.com/repos/electron/brightray/branches{/branch}","tags_url":"https://api.github.com/repos/electron/brightray/tags","blobs_url":"https://api.github.com/repos/electron/brightray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/brightray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/brightray/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/brightray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/brightray/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/brightray/languages","stargazers_url":"https://api.github.com/repos/electron/brightray/stargazers","contributors_url":"https://api.github.com/repos/electron/brightray/contributors","subscribers_url":"https://api.github.com/repos/electron/brightray/subscribers","subscription_url":"https://api.github.com/repos/electron/brightray/subscription","commits_url":"https://api.github.com/repos/electron/brightray/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/brightray/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/brightray/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/brightray/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/brightray/contents/{+path}","compare_url":"https://api.github.com/repos/electron/brightray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/brightray/merges","archive_url":"https://api.github.com/repos/electron/brightray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/brightray/downloads","issues_url":"https://api.github.com/repos/electron/brightray/issues{/number}","pulls_url":"https://api.github.com/repos/electron/brightray/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/brightray/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/brightray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/brightray/labels{/name}","releases_url":"https://api.github.com/repos/electron/brightray/releases{/id}","deployments_url":"https://api.github.com/repos/electron/brightray/deployments","created_at":"2013-03-13T13:24:49Z","updated_at":"2016-04-04T18:07:43Z","pushed_at":"2016-04-07T11:00:13Z","git_url":"git://github.com/electron/brightray.git","ssh_url":"git@github.com:electron/brightray.git","clone_url":"https://github.com/electron/brightray.git","svn_url":"https://github.com/electron/brightray","homepage":null,"size":1228,"stargazers_count":153,"watchers_count":153,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":14,"forks":43,"open_issues":14,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/brightray/pulls/207"},"html":{"href":"https://github.com/electron/brightray/pull/207"},"issue":{"href":"https://api.github.com/repos/electron/brightray/issues/207"},"comments":{"href":"https://api.github.com/repos/electron/brightray/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/brightray/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/brightray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/brightray/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/electron/brightray/statuses/648f28585fff2914ea48df70b5e87ab21bf1f680"}}}}