{"action":"closed","number":586,"pull_request":{"url":"https://api.github.com/repos/antirez/redis-doc/pulls/586","id":41530408,"html_url":"https://github.com/antirez/redis-doc/pull/586","diff_url":"https://github.com/antirez/redis-doc/pull/586.diff","patch_url":"https://github.com/antirez/redis-doc/pull/586.patch","issue_url":"https://api.github.com/repos/antirez/redis-doc/issues/586","number":586,"state":"closed","locked":false,"title":"fix lru-cache.md: allkeys-lru is not suitable for persistent situation","user":{"login":"swordflychen","id":7500885,"avatar_url":"https://avatars.githubusercontent.com/u/7500885?v=3","gravatar_id":"","url":"https://api.github.com/users/swordflychen","html_url":"https://github.com/swordflychen","followers_url":"https://api.github.com/users/swordflychen/followers","following_url":"https://api.github.com/users/swordflychen/following{/other_user}","gists_url":"https://api.github.com/users/swordflychen/gists{/gist_id}","starred_url":"https://api.github.com/users/swordflychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swordflychen/subscriptions","organizations_url":"https://api.github.com/users/swordflychen/orgs","repos_url":"https://api.github.com/users/swordflychen/repos","events_url":"https://api.github.com/users/swordflychen/events{/privacy}","received_events_url":"https://api.github.com/users/swordflychen/received_events","type":"User","site_admin":false},"body":"**allkeys-lru** is not suitable for both caching and to have a set of persistent keys in one instance. But **volatile-lru** is very suitable for the situation. \r\n \r\nThis is just my point of view, please check it. Very thanks.","created_at":"2015-08-04T03:01:59Z","updated_at":"2016-03-31T12:57:26Z","closed_at":"2016-03-31T12:57:26Z","merged_at":"2016-03-31T12:57:26Z","merge_commit_sha":"6afe768d2a97a8e6e844070a49c9b148a3e381d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/antirez/redis-doc/pulls/586/commits","review_comments_url":"https://api.github.com/repos/antirez/redis-doc/pulls/586/comments","review_comment_url":"https://api.github.com/repos/antirez/redis-doc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/antirez/redis-doc/issues/586/comments","statuses_url":"https://api.github.com/repos/antirez/redis-doc/statuses/d8a3ec7b2ffd16269bd88a54261e33d276f91f68","head":{"label":"swordflychen:master","ref":"master","sha":"d8a3ec7b2ffd16269bd88a54261e33d276f91f68","user":{"login":"swordflychen","id":7500885,"avatar_url":"https://avatars.githubusercontent.com/u/7500885?v=3","gravatar_id":"","url":"https://api.github.com/users/swordflychen","html_url":"https://github.com/swordflychen","followers_url":"https://api.github.com/users/swordflychen/followers","following_url":"https://api.github.com/users/swordflychen/following{/other_user}","gists_url":"https://api.github.com/users/swordflychen/gists{/gist_id}","starred_url":"https://api.github.com/users/swordflychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swordflychen/subscriptions","organizations_url":"https://api.github.com/users/swordflychen/orgs","repos_url":"https://api.github.com/users/swordflychen/repos","events_url":"https://api.github.com/users/swordflychen/events{/privacy}","received_events_url":"https://api.github.com/users/swordflychen/received_events","type":"User","site_admin":false},"repo":{"id":40159553,"name":"redis-doc","full_name":"swordflychen/redis-doc","owner":{"login":"swordflychen","id":7500885,"avatar_url":"https://avatars.githubusercontent.com/u/7500885?v=3","gravatar_id":"","url":"https://api.github.com/users/swordflychen","html_url":"https://github.com/swordflychen","followers_url":"https://api.github.com/users/swordflychen/followers","following_url":"https://api.github.com/users/swordflychen/following{/other_user}","gists_url":"https://api.github.com/users/swordflychen/gists{/gist_id}","starred_url":"https://api.github.com/users/swordflychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swordflychen/subscriptions","organizations_url":"https://api.github.com/users/swordflychen/orgs","repos_url":"https://api.github.com/users/swordflychen/repos","events_url":"https://api.github.com/users/swordflychen/events{/privacy}","received_events_url":"https://api.github.com/users/swordflychen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swordflychen/redis-doc","description":"Redis documentation source code for markdown and metadata files, conversion scripts, and so forth","fork":true,"url":"https://api.github.com/repos/swordflychen/redis-doc","forks_url":"https://api.github.com/repos/swordflychen/redis-doc/forks","keys_url":"https://api.github.com/repos/swordflychen/redis-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swordflychen/redis-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swordflychen/redis-doc/teams","hooks_url":"https://api.github.com/repos/swordflychen/redis-doc/hooks","issue_events_url":"https://api.github.com/repos/swordflychen/redis-doc/issues/events{/number}","events_url":"https://api.github.com/repos/swordflychen/redis-doc/events","assignees_url":"https://api.github.com/repos/swordflychen/redis-doc/assignees{/user}","branches_url":"https://api.github.com/repos/swordflychen/redis-doc/branches{/branch}","tags_url":"https://api.github.com/repos/swordflychen/redis-doc/tags","blobs_url":"https://api.github.com/repos/swordflychen/redis-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swordflychen/redis-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swordflychen/redis-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/swordflychen/redis-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swordflychen/redis-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/swordflychen/redis-doc/languages","stargazers_url":"https://api.github.com/repos/swordflychen/redis-doc/stargazers","contributors_url":"https://api.github.com/repos/swordflychen/redis-doc/contributors","subscribers_url":"https://api.github.com/repos/swordflychen/redis-doc/subscribers","subscription_url":"https://api.github.com/repos/swordflychen/redis-doc/subscription","commits_url":"https://api.github.com/repos/swordflychen/redis-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/swordflychen/redis-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/swordflychen/redis-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/swordflychen/redis-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/swordflychen/redis-doc/contents/{+path}","compare_url":"https://api.github.com/repos/swordflychen/redis-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swordflychen/redis-doc/merges","archive_url":"https://api.github.com/repos/swordflychen/redis-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swordflychen/redis-doc/downloads","issues_url":"https://api.github.com/repos/swordflychen/redis-doc/issues{/number}","pulls_url":"https://api.github.com/repos/swordflychen/redis-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/swordflychen/redis-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/swordflychen/redis-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swordflychen/redis-doc/labels{/name}","releases_url":"https://api.github.com/repos/swordflychen/redis-doc/releases{/id}","deployments_url":"https://api.github.com/repos/swordflychen/redis-doc/deployments","created_at":"2015-08-04T02:44:13Z","updated_at":"2015-08-04T02:44:14Z","pushed_at":"2015-08-04T02:53:15Z","git_url":"git://github.com/swordflychen/redis-doc.git","ssh_url":"git@github.com:swordflychen/redis-doc.git","clone_url":"https://github.com/swordflychen/redis-doc.git","svn_url":"https://github.com/swordflychen/redis-doc","homepage":"","size":2937,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"antirez:master","ref":"master","sha":"8046337f42ea4062e023f56e993fbcf8c593d8b1","user":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"repo":{"id":915844,"name":"redis-doc","full_name":"antirez/redis-doc","owner":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antirez/redis-doc","description":"Redis documentation source code for markdown and metadata files, conversion scripts, and so forth","fork":false,"url":"https://api.github.com/repos/antirez/redis-doc","forks_url":"https://api.github.com/repos/antirez/redis-doc/forks","keys_url":"https://api.github.com/repos/antirez/redis-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antirez/redis-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antirez/redis-doc/teams","hooks_url":"https://api.github.com/repos/antirez/redis-doc/hooks","issue_events_url":"https://api.github.com/repos/antirez/redis-doc/issues/events{/number}","events_url":"https://api.github.com/repos/antirez/redis-doc/events","assignees_url":"https://api.github.com/repos/antirez/redis-doc/assignees{/user}","branches_url":"https://api.github.com/repos/antirez/redis-doc/branches{/branch}","tags_url":"https://api.github.com/repos/antirez/redis-doc/tags","blobs_url":"https://api.github.com/repos/antirez/redis-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antirez/redis-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antirez/redis-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/antirez/redis-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antirez/redis-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/antirez/redis-doc/languages","stargazers_url":"https://api.github.com/repos/antirez/redis-doc/stargazers","contributors_url":"https://api.github.com/repos/antirez/redis-doc/contributors","subscribers_url":"https://api.github.com/repos/antirez/redis-doc/subscribers","subscription_url":"https://api.github.com/repos/antirez/redis-doc/subscription","commits_url":"https://api.github.com/repos/antirez/redis-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/antirez/redis-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/antirez/redis-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/antirez/redis-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/antirez/redis-doc/contents/{+path}","compare_url":"https://api.github.com/repos/antirez/redis-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antirez/redis-doc/merges","archive_url":"https://api.github.com/repos/antirez/redis-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antirez/redis-doc/downloads","issues_url":"https://api.github.com/repos/antirez/redis-doc/issues{/number}","pulls_url":"https://api.github.com/repos/antirez/redis-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/antirez/redis-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/antirez/redis-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antirez/redis-doc/labels{/name}","releases_url":"https://api.github.com/repos/antirez/redis-doc/releases{/id}","deployments_url":"https://api.github.com/repos/antirez/redis-doc/deployments","created_at":"2010-09-16T15:34:02Z","updated_at":"2016-03-30T01:45:07Z","pushed_at":"2016-03-31T12:57:26Z","git_url":"git://github.com/antirez/redis-doc.git","ssh_url":"git@github.com:antirez/redis-doc.git","clone_url":"https://github.com/antirez/redis-doc.git","svn_url":"https://github.com/antirez/redis-doc","homepage":"","size":4488,"stargazers_count":679,"watchers_count":679,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"open_issues_count":23,"forks":586,"open_issues":23,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/586"},"html":{"href":"https://github.com/antirez/redis-doc/pull/586"},"issue":{"href":"https://api.github.com/repos/antirez/redis-doc/issues/586"},"comments":{"href":"https://api.github.com/repos/antirez/redis-doc/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/antirez/redis-doc/statuses/d8a3ec7b2ffd16269bd88a54261e33d276f91f68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}