{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/reddit/event-collector/pulls/10","id":59455778,"html_url":"https://github.com/reddit/event-collector/pull/10","diff_url":"https://github.com/reddit/event-collector/pull/10.diff","patch_url":"https://github.com/reddit/event-collector/pull/10.patch","issue_url":"https://api.github.com/repos/reddit/event-collector/issues/10","number":10,"state":"closed","locked":false,"title":"Move to baseplate message queues","user":{"login":"spladug","id":338853,"avatar_url":"https://avatars.githubusercontent.com/u/338853?v=3","gravatar_id":"","url":"https://api.github.com/users/spladug","html_url":"https://github.com/spladug","followers_url":"https://api.github.com/users/spladug/followers","following_url":"https://api.github.com/users/spladug/following{/other_user}","gists_url":"https://api.github.com/users/spladug/gists{/gist_id}","starred_url":"https://api.github.com/users/spladug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spladug/subscriptions","organizations_url":"https://api.github.com/users/spladug/orgs","repos_url":"https://api.github.com/users/spladug/repos","events_url":"https://api.github.com/users/spladug/events{/privacy}","received_events_url":"https://api.github.com/users/spladug/received_events","type":"User","site_admin":false},"body":"This gives us a few advantages:\r\n\r\n* POSIX message queue code is in Baseplate now, so we get some\r\n  commonality. The puppet backing work will serve baseplate services\r\n  too.\r\n* The POSIX queue code is gevent friendly, allowing us to gevent the\r\n  collectors eventually.\r\n* The queue names are not integers but strings instead, this is\r\n  easier to read/understand.\r\n* We can store more data in the POSIX queues (65k messages instead\r\n  of 10k) which gives us more time if things go wrong with Kafka.\r\n\r\nalso includes use of the constant_time_compare function in baseplate and some cleanup of the error path.\r\n\r\nsee also: reddit/baseplate#13\r\n\r\n:eyeglasses: @bsimpson63 @Deimos @ketralnis  \r\n\r\ncc: @Kaitaan ","created_at":"2016-02-16T08:09:34Z","updated_at":"2016-02-18T00:33:16Z","closed_at":"2016-02-18T00:33:16Z","merged_at":"2016-02-18T00:33:16Z","merge_commit_sha":"a9e9397b02f32ee26e8253f2d6d21e594aace8ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/event-collector/pulls/10/commits","review_comments_url":"https://api.github.com/repos/reddit/event-collector/pulls/10/comments","review_comment_url":"https://api.github.com/repos/reddit/event-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/event-collector/issues/10/comments","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/3ce4e5081597469f5df4eff1f471407b22830db1","head":{"label":"reddit:baseplate-queue","ref":"baseplate-queue","sha":"3ce4e5081597469f5df4eff1f471407b22830db1","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":31198028,"name":"event-collector","full_name":"reddit/event-collector","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/event-collector","description":"data collection service","fork":false,"url":"https://api.github.com/repos/reddit/event-collector","forks_url":"https://api.github.com/repos/reddit/event-collector/forks","keys_url":"https://api.github.com/repos/reddit/event-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/event-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/event-collector/teams","hooks_url":"https://api.github.com/repos/reddit/event-collector/hooks","issue_events_url":"https://api.github.com/repos/reddit/event-collector/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/event-collector/events","assignees_url":"https://api.github.com/repos/reddit/event-collector/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/event-collector/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/event-collector/tags","blobs_url":"https://api.github.com/repos/reddit/event-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/event-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/event-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/event-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/event-collector/languages","stargazers_url":"https://api.github.com/repos/reddit/event-collector/stargazers","contributors_url":"https://api.github.com/repos/reddit/event-collector/contributors","subscribers_url":"https://api.github.com/repos/reddit/event-collector/subscribers","subscription_url":"https://api.github.com/repos/reddit/event-collector/subscription","commits_url":"https://api.github.com/repos/reddit/event-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/event-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/event-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/event-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/event-collector/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/event-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/event-collector/merges","archive_url":"https://api.github.com/repos/reddit/event-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/event-collector/downloads","issues_url":"https://api.github.com/repos/reddit/event-collector/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/event-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/event-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/event-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/event-collector/labels{/name}","releases_url":"https://api.github.com/repos/reddit/event-collector/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/event-collector/deployments","created_at":"2015-02-23T07:32:03Z","updated_at":"2016-01-14T00:06:54Z","pushed_at":"2016-02-18T00:33:16Z","git_url":"git://github.com/reddit/event-collector.git","ssh_url":"git@github.com:reddit/event-collector.git","clone_url":"https://github.com/reddit/event-collector.git","svn_url":"https://github.com/reddit/event-collector","homepage":null,"size":51,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"817510a68ac9ce464229697e629f5997e66e883d","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":31198028,"name":"event-collector","full_name":"reddit/event-collector","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/event-collector","description":"data collection service","fork":false,"url":"https://api.github.com/repos/reddit/event-collector","forks_url":"https://api.github.com/repos/reddit/event-collector/forks","keys_url":"https://api.github.com/repos/reddit/event-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/event-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/event-collector/teams","hooks_url":"https://api.github.com/repos/reddit/event-collector/hooks","issue_events_url":"https://api.github.com/repos/reddit/event-collector/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/event-collector/events","assignees_url":"https://api.github.com/repos/reddit/event-collector/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/event-collector/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/event-collector/tags","blobs_url":"https://api.github.com/repos/reddit/event-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/event-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/event-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/event-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/event-collector/languages","stargazers_url":"https://api.github.com/repos/reddit/event-collector/stargazers","contributors_url":"https://api.github.com/repos/reddit/event-collector/contributors","subscribers_url":"https://api.github.com/repos/reddit/event-collector/subscribers","subscription_url":"https://api.github.com/repos/reddit/event-collector/subscription","commits_url":"https://api.github.com/repos/reddit/event-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/event-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/event-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/event-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/event-collector/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/event-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/event-collector/merges","archive_url":"https://api.github.com/repos/reddit/event-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/event-collector/downloads","issues_url":"https://api.github.com/repos/reddit/event-collector/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/event-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/event-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/event-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/event-collector/labels{/name}","releases_url":"https://api.github.com/repos/reddit/event-collector/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/event-collector/deployments","created_at":"2015-02-23T07:32:03Z","updated_at":"2016-01-14T00:06:54Z","pushed_at":"2016-02-18T00:33:16Z","git_url":"git://github.com/reddit/event-collector.git","ssh_url":"git@github.com:reddit/event-collector.git","clone_url":"https://github.com/reddit/event-collector.git","svn_url":"https://github.com/reddit/event-collector","homepage":null,"size":51,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/10"},"html":{"href":"https://github.com/reddit/event-collector/pull/10"},"issue":{"href":"https://api.github.com/repos/reddit/event-collector/issues/10"},"comments":{"href":"https://api.github.com/repos/reddit/event-collector/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/event-collector/statuses/3ce4e5081597469f5df4eff1f471407b22830db1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"spladug","id":338853,"avatar_url":"https://avatars.githubusercontent.com/u/338853?v=3","gravatar_id":"","url":"https://api.github.com/users/spladug","html_url":"https://github.com/spladug","followers_url":"https://api.github.com/users/spladug/followers","following_url":"https://api.github.com/users/spladug/following{/other_user}","gists_url":"https://api.github.com/users/spladug/gists{/gist_id}","starred_url":"https://api.github.com/users/spladug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spladug/subscriptions","organizations_url":"https://api.github.com/users/spladug/orgs","repos_url":"https://api.github.com/users/spladug/repos","events_url":"https://api.github.com/users/spladug/events{/privacy}","received_events_url":"https://api.github.com/users/spladug/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":73,"deletions":213,"changed_files":11}}