{"action":"opened","number":1291,"pull_request":{"url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291","id":65506081,"html_url":"https://github.com/TelescopeJS/Telescope/pull/1291","diff_url":"https://github.com/TelescopeJS/Telescope/pull/1291.diff","patch_url":"https://github.com/TelescopeJS/Telescope/pull/1291.patch","issue_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/1291","number":1291,"state":"open","locked":false,"title":"HeadTags: dochead instead of react-helmet","user":{"login":"xavcz","id":13962779,"avatar_url":"https://avatars.githubusercontent.com/u/13962779?v=3","gravatar_id":"","url":"https://api.github.com/users/xavcz","html_url":"https://github.com/xavcz","followers_url":"https://api.github.com/users/xavcz/followers","following_url":"https://api.github.com/users/xavcz/following{/other_user}","gists_url":"https://api.github.com/users/xavcz/gists{/gist_id}","starred_url":"https://api.github.com/users/xavcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavcz/subscriptions","organizations_url":"https://api.github.com/users/xavcz/orgs","repos_url":"https://api.github.com/users/xavcz/repos","events_url":"https://api.github.com/users/xavcz/events{/privacy}","received_events_url":"https://api.github.com/users/xavcz/received_events","type":"User","site_admin":false},"body":"Well, seems to work better with dochead than react-helmet @SachaG :)\r\n\r\nI wrapped the rendering in a component as recommended by the doc in order to have SSR.\r\n\r\nThe component accept props, which by default are set to the general information of the Telescope.\r\n\r\nI removed the old one from `Header` and placed it in 3 places :\r\n1. `PostPage` container to have access to post props.\r\n2. `PostListHeader` which is displayed on \"basic view\".\r\n3. `UserProfile` component to have access to a user data.\r\n\r\nWhat do you think of the \"placement\"?\r\n\r\nI'm thinking about using new utils/helpers like `Telescope.utils.getLogoUrl()` instead of `Telescope.utils.getSiteUrl() + Telescope.settings.get(\"logoUrl\"); ` and `Posts.getPostThumbnailUrl()` instead of `post.thumbnailUrl`. It would give a shorthand for access absolute url to logo and postThumbnail (maybe get it from embedly if active?).","created_at":"2016-04-06T17:36:28Z","updated_at":"2016-04-06T17:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee7ca8e2dad78274e8138762c2bfd0b1dd33b3af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291/commits","review_comments_url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291/comments","review_comment_url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/1291/comments","statuses_url":"https://api.github.com/repos/TelescopeJS/Telescope/statuses/cff06ab199114cce077407bb03fab3e62270b7c6","head":{"label":"xavcz:dochead","ref":"dochead","sha":"cff06ab199114cce077407bb03fab3e62270b7c6","user":{"login":"xavcz","id":13962779,"avatar_url":"https://avatars.githubusercontent.com/u/13962779?v=3","gravatar_id":"","url":"https://api.github.com/users/xavcz","html_url":"https://github.com/xavcz","followers_url":"https://api.github.com/users/xavcz/followers","following_url":"https://api.github.com/users/xavcz/following{/other_user}","gists_url":"https://api.github.com/users/xavcz/gists{/gist_id}","starred_url":"https://api.github.com/users/xavcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavcz/subscriptions","organizations_url":"https://api.github.com/users/xavcz/orgs","repos_url":"https://api.github.com/users/xavcz/repos","events_url":"https://api.github.com/users/xavcz/events{/privacy}","received_events_url":"https://api.github.com/users/xavcz/received_events","type":"User","site_admin":false},"repo":{"id":54885475,"name":"Telescope","full_name":"xavcz/Telescope","owner":{"login":"xavcz","id":13962779,"avatar_url":"https://avatars.githubusercontent.com/u/13962779?v=3","gravatar_id":"","url":"https://api.github.com/users/xavcz","html_url":"https://github.com/xavcz","followers_url":"https://api.github.com/users/xavcz/followers","following_url":"https://api.github.com/users/xavcz/following{/other_user}","gists_url":"https://api.github.com/users/xavcz/gists{/gist_id}","starred_url":"https://api.github.com/users/xavcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavcz/subscriptions","organizations_url":"https://api.github.com/users/xavcz/orgs","repos_url":"https://api.github.com/users/xavcz/repos","events_url":"https://api.github.com/users/xavcz/events{/privacy}","received_events_url":"https://api.github.com/users/xavcz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xavcz/Telescope","description":"An open-source social news app built with Meteor","fork":true,"url":"https://api.github.com/repos/xavcz/Telescope","forks_url":"https://api.github.com/repos/xavcz/Telescope/forks","keys_url":"https://api.github.com/repos/xavcz/Telescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xavcz/Telescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xavcz/Telescope/teams","hooks_url":"https://api.github.com/repos/xavcz/Telescope/hooks","issue_events_url":"https://api.github.com/repos/xavcz/Telescope/issues/events{/number}","events_url":"https://api.github.com/repos/xavcz/Telescope/events","assignees_url":"https://api.github.com/repos/xavcz/Telescope/assignees{/user}","branches_url":"https://api.github.com/repos/xavcz/Telescope/branches{/branch}","tags_url":"https://api.github.com/repos/xavcz/Telescope/tags","blobs_url":"https://api.github.com/repos/xavcz/Telescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xavcz/Telescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xavcz/Telescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/xavcz/Telescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xavcz/Telescope/statuses/{sha}","languages_url":"https://api.github.com/repos/xavcz/Telescope/languages","stargazers_url":"https://api.github.com/repos/xavcz/Telescope/stargazers","contributors_url":"https://api.github.com/repos/xavcz/Telescope/contributors","subscribers_url":"https://api.github.com/repos/xavcz/Telescope/subscribers","subscription_url":"https://api.github.com/repos/xavcz/Telescope/subscription","commits_url":"https://api.github.com/repos/xavcz/Telescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/xavcz/Telescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/xavcz/Telescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/xavcz/Telescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/xavcz/Telescope/contents/{+path}","compare_url":"https://api.github.com/repos/xavcz/Telescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xavcz/Telescope/merges","archive_url":"https://api.github.com/repos/xavcz/Telescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xavcz/Telescope/downloads","issues_url":"https://api.github.com/repos/xavcz/Telescope/issues{/number}","pulls_url":"https://api.github.com/repos/xavcz/Telescope/pulls{/number}","milestones_url":"https://api.github.com/repos/xavcz/Telescope/milestones{/number}","notifications_url":"https://api.github.com/repos/xavcz/Telescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xavcz/Telescope/labels{/name}","releases_url":"https://api.github.com/repos/xavcz/Telescope/releases{/id}","deployments_url":"https://api.github.com/repos/xavcz/Telescope/deployments","created_at":"2016-03-28T10:40:02Z","updated_at":"2016-03-28T10:40:04Z","pushed_at":"2016-04-06T17:25:25Z","git_url":"git://github.com/xavcz/Telescope.git","ssh_url":"git@github.com:xavcz/Telescope.git","clone_url":"https://github.com/xavcz/Telescope.git","svn_url":"https://github.com/xavcz/Telescope","homepage":"http://www.telescopeapp.org","size":7872,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TelescopeJS:nova","ref":"nova","sha":"f4a2a7a8824a6f71418c4f4b60263e4bbb08747e","user":{"login":"TelescopeJS","id":6634779,"avatar_url":"https://avatars.githubusercontent.com/u/6634779?v=3","gravatar_id":"","url":"https://api.github.com/users/TelescopeJS","html_url":"https://github.com/TelescopeJS","followers_url":"https://api.github.com/users/TelescopeJS/followers","following_url":"https://api.github.com/users/TelescopeJS/following{/other_user}","gists_url":"https://api.github.com/users/TelescopeJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TelescopeJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TelescopeJS/subscriptions","organizations_url":"https://api.github.com/users/TelescopeJS/orgs","repos_url":"https://api.github.com/users/TelescopeJS/repos","events_url":"https://api.github.com/users/TelescopeJS/events{/privacy}","received_events_url":"https://api.github.com/users/TelescopeJS/received_events","type":"Organization","site_admin":false},"repo":{"id":5710848,"name":"Telescope","full_name":"TelescopeJS/Telescope","owner":{"login":"TelescopeJS","id":6634779,"avatar_url":"https://avatars.githubusercontent.com/u/6634779?v=3","gravatar_id":"","url":"https://api.github.com/users/TelescopeJS","html_url":"https://github.com/TelescopeJS","followers_url":"https://api.github.com/users/TelescopeJS/followers","following_url":"https://api.github.com/users/TelescopeJS/following{/other_user}","gists_url":"https://api.github.com/users/TelescopeJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TelescopeJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TelescopeJS/subscriptions","organizations_url":"https://api.github.com/users/TelescopeJS/orgs","repos_url":"https://api.github.com/users/TelescopeJS/repos","events_url":"https://api.github.com/users/TelescopeJS/events{/privacy}","received_events_url":"https://api.github.com/users/TelescopeJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TelescopeJS/Telescope","description":"An open-source social news app built with Meteor","fork":false,"url":"https://api.github.com/repos/TelescopeJS/Telescope","forks_url":"https://api.github.com/repos/TelescopeJS/Telescope/forks","keys_url":"https://api.github.com/repos/TelescopeJS/Telescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TelescopeJS/Telescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TelescopeJS/Telescope/teams","hooks_url":"https://api.github.com/repos/TelescopeJS/Telescope/hooks","issue_events_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/events{/number}","events_url":"https://api.github.com/repos/TelescopeJS/Telescope/events","assignees_url":"https://api.github.com/repos/TelescopeJS/Telescope/assignees{/user}","branches_url":"https://api.github.com/repos/TelescopeJS/Telescope/branches{/branch}","tags_url":"https://api.github.com/repos/TelescopeJS/Telescope/tags","blobs_url":"https://api.github.com/repos/TelescopeJS/Telescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TelescopeJS/Telescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TelescopeJS/Telescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/TelescopeJS/Telescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TelescopeJS/Telescope/statuses/{sha}","languages_url":"https://api.github.com/repos/TelescopeJS/Telescope/languages","stargazers_url":"https://api.github.com/repos/TelescopeJS/Telescope/stargazers","contributors_url":"https://api.github.com/repos/TelescopeJS/Telescope/contributors","subscribers_url":"https://api.github.com/repos/TelescopeJS/Telescope/subscribers","subscription_url":"https://api.github.com/repos/TelescopeJS/Telescope/subscription","commits_url":"https://api.github.com/repos/TelescopeJS/Telescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/TelescopeJS/Telescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/TelescopeJS/Telescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/TelescopeJS/Telescope/contents/{+path}","compare_url":"https://api.github.com/repos/TelescopeJS/Telescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TelescopeJS/Telescope/merges","archive_url":"https://api.github.com/repos/TelescopeJS/Telescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TelescopeJS/Telescope/downloads","issues_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues{/number}","pulls_url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls{/number}","milestones_url":"https://api.github.com/repos/TelescopeJS/Telescope/milestones{/number}","notifications_url":"https://api.github.com/repos/TelescopeJS/Telescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TelescopeJS/Telescope/labels{/name}","releases_url":"https://api.github.com/repos/TelescopeJS/Telescope/releases{/id}","deployments_url":"https://api.github.com/repos/TelescopeJS/Telescope/deployments","created_at":"2012-09-07T01:13:24Z","updated_at":"2016-04-06T13:56:44Z","pushed_at":"2016-04-06T17:36:29Z","git_url":"git://github.com/TelescopeJS/Telescope.git","ssh_url":"git@github.com:TelescopeJS/Telescope.git","clone_url":"https://github.com/TelescopeJS/Telescope.git","svn_url":"https://github.com/TelescopeJS/Telescope","homepage":"http://www.telescopeapp.org","size":9892,"stargazers_count":4412,"watchers_count":4412,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1736,"mirror_url":null,"open_issues_count":185,"forks":1736,"open_issues":185,"watchers":4412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291"},"html":{"href":"https://github.com/TelescopeJS/Telescope/pull/1291"},"issue":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/issues/1291"},"comments":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/issues/1291/comments"},"review_comments":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291/comments"},"review_comment":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/1291/commits"},"statuses":{"href":"https://api.github.com/repos/TelescopeJS/Telescope/statuses/cff06ab199114cce077407bb03fab3e62270b7c6"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":62,"deletions":36,"changed_files":8}}