{"action":"closed","number":126,"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126","id":55011512,"html_url":"https://github.com/labrad/scalabrad-web/pull/126","diff_url":"https://github.com/labrad/scalabrad-web/pull/126.diff","patch_url":"https://github.com/labrad/scalabrad-web/pull/126.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/126","number":126,"state":"closed","locked":false,"title":"Clean up the login logic","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"There was a subtle concurrency bug with the login logic which sometimes resulted in a login dialog popping up, even when the credentials had already been saved in local or session storage. This fixes that problem and also cleans up the logic overall to use promises and async functions more consistently.","created_at":"2016-01-04T19:24:28Z","updated_at":"2016-01-08T05:42:27Z","closed_at":"2016-01-08T05:42:27Z","merged_at":"2016-01-08T05:42:27Z","merge_commit_sha":"93abb51a41de55876afa68d242950ad85b999ed0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/126/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/5717e9331e45216272b3bc3f48696167c441e47a","head":{"label":"labrad:u/maffoo/login-fix","ref":"u/maffoo/login-fix","sha":"5717e9331e45216272b3bc3f48696167c441e47a","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-10-26T17:44:45Z","pushed_at":"2016-01-08T05:42:27Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":604,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":35,"forks":0,"open_issues":35,"watchers":0,"default_branch":"master"}},"base":{"label":"labrad:master","ref":"master","sha":"ad6cb863d822f16df3d74912cc60f987f360b379","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-10-26T17:44:45Z","pushed_at":"2016-01-08T05:42:27Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":604,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":35,"forks":0,"open_issues":35,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/126"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/126"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad-web/statuses/5717e9331e45216272b3bc3f48696167c441e47a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":1,"additions":34,"deletions":14,"changed_files":1}}