{"action":"created","issue":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/3000","repository_url":"https://api.github.com/repos/wiredtiger/wiredtiger","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/3000/labels{/name}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/3000/comments","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/3000/events","html_url":"https://github.com/wiredtiger/wiredtiger/pull/3000","id":174126743,"number":3000,"title":"WT-2873 Refactor CRC32 code","user":{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false},"assignees":[{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-30T21:09:35Z","updated_at":"2016-08-31T21:43:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/3000","html_url":"https://github.com/wiredtiger/wiredtiger/pull/3000","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/3000.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/3000.patch"},"body":"Refactor CRC32 code, better support for zSeries boxes that don't support hardware CRC32."},"comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments/243912119","html_url":"https://github.com/wiredtiger/wiredtiger/pull/3000#issuecomment-243912119","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/3000","id":243912119,"user":{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T21:43:47Z","updated_at":"2016-08-31T21:43:47Z","body":"@michaelcahill: \r\n\r\n> Can we have an inlined wrapper function called __wt_checksum to call through the function pointer in __wt_process, rather than making callers do that?\r\n\r\nDone & pushed (I used `__wt_cksum`, that way most of the code doesn't change).\r\n\r\n> Generally, can we stick to \"checksum\" (the whole word) rather than having function names not match file names?\r\n\r\nI'm happy to make that pass (I thought about doing it too). If we do it everywhere (for example, change `multi->cksum = bnd->cksum` to `multi->checksum = bnd->checksum` in the reconciliation code), it's a big pass, maybe 300 or so occurrences. We could:\r\n\r\n1. change the file names to `cksum`\r\n2. only change function names from `cksum` to `checksum`\r\n3. change everything from `cksum` to `checksum`\r\n\r\nI'd be inclined to do either 1 or 3, number 2 seems inconsistent (but I won't fight about it). What's your pleasure?\r\n\r\n> If we want to add a Windows implementation of the X86 hardware accelerated checksums one day would this structure have to change again? I'm concerned that \"software\" vs \"x86\" isn't sufficient.\r\n\r\nWe could do that by adding `checksum/x86/crc32-win-x86.c` and changing `dist/filelist`:\r\n```\r\nsrc/checksum/x86/crc32-x86.c        POSIX_HOST\r\nsrc/checksum/x86/crc32-win-x86.c    WINDOWS_HOST\r\n```\r\nOr if there's a Windows-specific software implementation:\r\n```\r\nsrc/checksum/software/checksum.c            POSIX_HOST\r\nsrc/checksum/software/checksum-win-x86.c    WINDOWS_HOST\r\n```"}}
{"actor":{"display_login":"keithbostic"}}