{"action":"created","comment":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/53518831","id":53518831,"diff_hunk":"@@ -96,7 +96,8 @@ func (cs *ConsensusSet) threadedReceiveBlocks(conn modules.PeerConn) error {\n \t\t\t// The last block received will be the current block since\n \t\t\t// managedAcceptBlock only returns nil if a block extends the longest chain.\n \t\t\tcurrentBlock := cs.CurrentBlock()\n-\t\t\tgo cs.gateway.Broadcast(\"RelayBlock\", currentBlock)\n+\t\t\t// TODO: only broadcast blocks to peers v0.5.1 and below and headers to peers v0.5.2 and above.","path":"modules/consensus/synchronize.go","position":5,"original_position":5,"commit_id":"c72202233f753982bff9a18c125a17aa67dfd913","original_commit_id":"c72202233f753982bff9a18c125a17aa67dfd913","user":{"login":"VoidingWarranties","id":5420909,"avatar_url":"https://avatars.githubusercontent.com/u/5420909?v=3","gravatar_id":"","url":"https://api.github.com/users/VoidingWarranties","html_url":"https://github.com/VoidingWarranties","followers_url":"https://api.github.com/users/VoidingWarranties/followers","following_url":"https://api.github.com/users/VoidingWarranties/following{/other_user}","gists_url":"https://api.github.com/users/VoidingWarranties/gists{/gist_id}","starred_url":"https://api.github.com/users/VoidingWarranties/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoidingWarranties/subscriptions","organizations_url":"https://api.github.com/users/VoidingWarranties/orgs","repos_url":"https://api.github.com/users/VoidingWarranties/repos","events_url":"https://api.github.com/users/VoidingWarranties/events{/privacy}","received_events_url":"https://api.github.com/users/VoidingWarranties/received_events","type":"User","site_admin":false},"body":"The TODO is already gone in the `header-broadcast` branch. That PR is ready to go as soon as this one is merged.","created_at":"2016-02-19T21:12:27Z","updated_at":"2016-02-19T21:12:27Z","html_url":"https://github.com/NebulousLabs/Sia/pull/981#discussion_r53518831","pull_request_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981","_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/53518831"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/981#discussion_r53518831"},"pull_request":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981"}}},"pull_request":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981","id":59600087,"html_url":"https://github.com/NebulousLabs/Sia/pull/981","diff_url":"https://github.com/NebulousLabs/Sia/pull/981.diff","patch_url":"https://github.com/NebulousLabs/Sia/pull/981.patch","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/981","number":981,"state":"open","locked":false,"title":"Versioned broadcast","user":{"login":"VoidingWarranties","id":5420909,"avatar_url":"https://avatars.githubusercontent.com/u/5420909?v=3","gravatar_id":"","url":"https://api.github.com/users/VoidingWarranties","html_url":"https://github.com/VoidingWarranties","followers_url":"https://api.github.com/users/VoidingWarranties/followers","following_url":"https://api.github.com/users/VoidingWarranties/following{/other_user}","gists_url":"https://api.github.com/users/VoidingWarranties/gists{/gist_id}","starred_url":"https://api.github.com/users/VoidingWarranties/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoidingWarranties/subscriptions","organizations_url":"https://api.github.com/users/VoidingWarranties/orgs","repos_url":"https://api.github.com/users/VoidingWarranties/repos","events_url":"https://api.github.com/users/VoidingWarranties/events{/privacy}","received_events_url":"https://api.github.com/users/VoidingWarranties/received_events","type":"User","site_admin":false},"body":"`BroadcastMinVersion` and `BroadcastMaxVersion` broadcast only to peers that are of at least or at most the specified version, respectively. This is necessary for the upcoming header broadcast PR which will need to broadcast blocks to older peers and headers to newer peers. It is also useful for general backwards compatibility considerations. As an example use, RelayTransactionSet is now only broadcast to peers that are at least v0.4.7, so as to limit the number of conflicting calls to the colliding old RPC name RelayTransaction.\r\n\r\nI'm not too sure about the names, as `BroadcastMinVersion` makes it sound like it's broadcasting some version number.","created_at":"2016-02-17T06:01:34Z","updated_at":"2016-02-19T21:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e2e9b5d04dc365617ca84c2b545f21b9f7e7220","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981/commits","review_comments_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981/comments","review_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/981/comments","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/c72202233f753982bff9a18c125a17aa67dfd913","head":{"label":"NebulousLabs:versioned-broadcast","ref":"versioned-broadcast","sha":"c72202233f753982bff9a18c125a17aa67dfd913","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":25370072,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blockchain-based marketplace for file storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","deployments_url":"https://api.github.com/repos/NebulousLabs/Sia/deployments","created_at":"2014-10-17T17:50:25Z","updated_at":"2016-02-19T12:39:45Z","pushed_at":"2016-02-19T20:49:00Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":"https://sia.tech","size":27468,"stargazers_count":155,"watchers_count":155,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":30,"forks":30,"open_issues":30,"watchers":155,"default_branch":"master"}},"base":{"label":"NebulousLabs:master","ref":"master","sha":"61f8375ed9b6c7359c4e98381a5236463f91289a","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":25370072,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blockchain-based marketplace for file storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","deployments_url":"https://api.github.com/repos/NebulousLabs/Sia/deployments","created_at":"2014-10-17T17:50:25Z","updated_at":"2016-02-19T12:39:45Z","pushed_at":"2016-02-19T20:49:00Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":"https://sia.tech","size":27468,"stargazers_count":155,"watchers_count":155,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":30,"forks":30,"open_issues":30,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/981"},"issue":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/981"},"comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/981/comments"},"review_comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981/comments"},"review_comment":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/981/commits"},"statuses":{"href":"https://api.github.com/repos/NebulousLabs/Sia/statuses/c72202233f753982bff9a18c125a17aa67dfd913"}}}}