{"action":"closed","number":132,"pull_request":{"url":"https://api.github.com/repos/atomix/copycat/pulls/132","id":58397187,"html_url":"https://github.com/atomix/copycat/pull/132","diff_url":"https://github.com/atomix/copycat/pull/132.diff","patch_url":"https://github.com/atomix/copycat/pull/132.patch","issue_url":"https://api.github.com/repos/atomix/copycat/issues/132","number":132,"state":"closed","locked":false,"title":"Prevent infinite recursion when submitting keep-alive or unregister requests","user":{"login":"kuujo","id":823318,"avatar_url":"https://avatars.githubusercontent.com/u/823318?v=3","gravatar_id":"","url":"https://api.github.com/users/kuujo","html_url":"https://github.com/kuujo","followers_url":"https://api.github.com/users/kuujo/followers","following_url":"https://api.github.com/users/kuujo/following{/other_user}","gists_url":"https://api.github.com/users/kuujo/gists{/gist_id}","starred_url":"https://api.github.com/users/kuujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuujo/subscriptions","organizations_url":"https://api.github.com/users/kuujo/orgs","repos_url":"https://api.github.com/users/kuujo/repos","events_url":"https://api.github.com/users/kuujo/events{/privacy}","received_events_url":"https://api.github.com/users/kuujo/received_events","type":"User","site_admin":false},"body":"This PR fixes a bug in clients when submitting `KeepAliveRequest` or `UnregisterRequest` to a cluster where the leader was recently demoted. When the leader is demoted, some period of time must pass for servers to learn that the leader stepped down. During that time, when a keep-alive request from the client fails, the client will reset its leader and contact all nodes. However, because the client relearns of the same leader, the client will recursively learn and unlearn and continue to resubmit requests until all nodes have learned that the leader stepped down. This prevents that recursion with a simple boolean flag.","created_at":"2016-02-05T07:39:55Z","updated_at":"2016-02-05T07:39:59Z","closed_at":"2016-02-05T07:39:58Z","merged_at":"2016-02-05T07:39:58Z","merge_commit_sha":"13f3467bd0a4332fe3000df3432b257ec0baa22b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atomix/copycat/pulls/132/commits","review_comments_url":"https://api.github.com/repos/atomix/copycat/pulls/132/comments","review_comment_url":"https://api.github.com/repos/atomix/copycat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atomix/copycat/issues/132/comments","statuses_url":"https://api.github.com/repos/atomix/copycat/statuses/ae28858c32086a6066ca89a10ef105a412408abd","head":{"label":"atomix:client-session-retry-recursion","ref":"client-session-retry-recursion","sha":"ae28858c32086a6066ca89a10ef105a412408abd","user":{"login":"atomix","id":14324067,"avatar_url":"https://avatars.githubusercontent.com/u/14324067?v=3","gravatar_id":"","url":"https://api.github.com/users/atomix","html_url":"https://github.com/atomix","followers_url":"https://api.github.com/users/atomix/followers","following_url":"https://api.github.com/users/atomix/following{/other_user}","gists_url":"https://api.github.com/users/atomix/gists{/gist_id}","starred_url":"https://api.github.com/users/atomix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomix/subscriptions","organizations_url":"https://api.github.com/users/atomix/orgs","repos_url":"https://api.github.com/users/atomix/repos","events_url":"https://api.github.com/users/atomix/events{/privacy}","received_events_url":"https://api.github.com/users/atomix/received_events","type":"Organization","site_admin":false},"repo":{"id":42548113,"name":"copycat","full_name":"atomix/copycat","owner":{"login":"atomix","id":14324067,"avatar_url":"https://avatars.githubusercontent.com/u/14324067?v=3","gravatar_id":"","url":"https://api.github.com/users/atomix","html_url":"https://github.com/atomix","followers_url":"https://api.github.com/users/atomix/followers","following_url":"https://api.github.com/users/atomix/following{/other_user}","gists_url":"https://api.github.com/users/atomix/gists{/gist_id}","starred_url":"https://api.github.com/users/atomix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomix/subscriptions","organizations_url":"https://api.github.com/users/atomix/orgs","repos_url":"https://api.github.com/users/atomix/repos","events_url":"https://api.github.com/users/atomix/events{/privacy}","received_events_url":"https://api.github.com/users/atomix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atomix/copycat","description":"A novel implementation of the Raft consensus algorithm","fork":false,"url":"https://api.github.com/repos/atomix/copycat","forks_url":"https://api.github.com/repos/atomix/copycat/forks","keys_url":"https://api.github.com/repos/atomix/copycat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomix/copycat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomix/copycat/teams","hooks_url":"https://api.github.com/repos/atomix/copycat/hooks","issue_events_url":"https://api.github.com/repos/atomix/copycat/issues/events{/number}","events_url":"https://api.github.com/repos/atomix/copycat/events","assignees_url":"https://api.github.com/repos/atomix/copycat/assignees{/user}","branches_url":"https://api.github.com/repos/atomix/copycat/branches{/branch}","tags_url":"https://api.github.com/repos/atomix/copycat/tags","blobs_url":"https://api.github.com/repos/atomix/copycat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomix/copycat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomix/copycat/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomix/copycat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomix/copycat/statuses/{sha}","languages_url":"https://api.github.com/repos/atomix/copycat/languages","stargazers_url":"https://api.github.com/repos/atomix/copycat/stargazers","contributors_url":"https://api.github.com/repos/atomix/copycat/contributors","subscribers_url":"https://api.github.com/repos/atomix/copycat/subscribers","subscription_url":"https://api.github.com/repos/atomix/copycat/subscription","commits_url":"https://api.github.com/repos/atomix/copycat/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomix/copycat/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomix/copycat/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomix/copycat/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomix/copycat/contents/{+path}","compare_url":"https://api.github.com/repos/atomix/copycat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomix/copycat/merges","archive_url":"https://api.github.com/repos/atomix/copycat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomix/copycat/downloads","issues_url":"https://api.github.com/repos/atomix/copycat/issues{/number}","pulls_url":"https://api.github.com/repos/atomix/copycat/pulls{/number}","milestones_url":"https://api.github.com/repos/atomix/copycat/milestones{/number}","notifications_url":"https://api.github.com/repos/atomix/copycat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomix/copycat/labels{/name}","releases_url":"https://api.github.com/repos/atomix/copycat/releases{/id}","deployments_url":"https://api.github.com/repos/atomix/copycat/deployments","created_at":"2015-09-15T21:38:20Z","updated_at":"2016-02-03T07:23:06Z","pushed_at":"2016-02-05T07:39:58Z","git_url":"git://github.com/atomix/copycat.git","ssh_url":"git@github.com:atomix/copycat.git","clone_url":"https://github.com/atomix/copycat.git","svn_url":"https://github.com/atomix/copycat","homepage":"http://atomix.io/copycat","size":2609,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":14,"forks":17,"open_issues":14,"watchers":63,"default_branch":"master"}},"base":{"label":"atomix:master","ref":"master","sha":"41196d3f0bd02065fe8dacfdb43a5e9c8800b507","user":{"login":"atomix","id":14324067,"avatar_url":"https://avatars.githubusercontent.com/u/14324067?v=3","gravatar_id":"","url":"https://api.github.com/users/atomix","html_url":"https://github.com/atomix","followers_url":"https://api.github.com/users/atomix/followers","following_url":"https://api.github.com/users/atomix/following{/other_user}","gists_url":"https://api.github.com/users/atomix/gists{/gist_id}","starred_url":"https://api.github.com/users/atomix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomix/subscriptions","organizations_url":"https://api.github.com/users/atomix/orgs","repos_url":"https://api.github.com/users/atomix/repos","events_url":"https://api.github.com/users/atomix/events{/privacy}","received_events_url":"https://api.github.com/users/atomix/received_events","type":"Organization","site_admin":false},"repo":{"id":42548113,"name":"copycat","full_name":"atomix/copycat","owner":{"login":"atomix","id":14324067,"avatar_url":"https://avatars.githubusercontent.com/u/14324067?v=3","gravatar_id":"","url":"https://api.github.com/users/atomix","html_url":"https://github.com/atomix","followers_url":"https://api.github.com/users/atomix/followers","following_url":"https://api.github.com/users/atomix/following{/other_user}","gists_url":"https://api.github.com/users/atomix/gists{/gist_id}","starred_url":"https://api.github.com/users/atomix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomix/subscriptions","organizations_url":"https://api.github.com/users/atomix/orgs","repos_url":"https://api.github.com/users/atomix/repos","events_url":"https://api.github.com/users/atomix/events{/privacy}","received_events_url":"https://api.github.com/users/atomix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atomix/copycat","description":"A novel implementation of the Raft consensus algorithm","fork":false,"url":"https://api.github.com/repos/atomix/copycat","forks_url":"https://api.github.com/repos/atomix/copycat/forks","keys_url":"https://api.github.com/repos/atomix/copycat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomix/copycat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomix/copycat/teams","hooks_url":"https://api.github.com/repos/atomix/copycat/hooks","issue_events_url":"https://api.github.com/repos/atomix/copycat/issues/events{/number}","events_url":"https://api.github.com/repos/atomix/copycat/events","assignees_url":"https://api.github.com/repos/atomix/copycat/assignees{/user}","branches_url":"https://api.github.com/repos/atomix/copycat/branches{/branch}","tags_url":"https://api.github.com/repos/atomix/copycat/tags","blobs_url":"https://api.github.com/repos/atomix/copycat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomix/copycat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomix/copycat/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomix/copycat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomix/copycat/statuses/{sha}","languages_url":"https://api.github.com/repos/atomix/copycat/languages","stargazers_url":"https://api.github.com/repos/atomix/copycat/stargazers","contributors_url":"https://api.github.com/repos/atomix/copycat/contributors","subscribers_url":"https://api.github.com/repos/atomix/copycat/subscribers","subscription_url":"https://api.github.com/repos/atomix/copycat/subscription","commits_url":"https://api.github.com/repos/atomix/copycat/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomix/copycat/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomix/copycat/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomix/copycat/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomix/copycat/contents/{+path}","compare_url":"https://api.github.com/repos/atomix/copycat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomix/copycat/merges","archive_url":"https://api.github.com/repos/atomix/copycat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomix/copycat/downloads","issues_url":"https://api.github.com/repos/atomix/copycat/issues{/number}","pulls_url":"https://api.github.com/repos/atomix/copycat/pulls{/number}","milestones_url":"https://api.github.com/repos/atomix/copycat/milestones{/number}","notifications_url":"https://api.github.com/repos/atomix/copycat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomix/copycat/labels{/name}","releases_url":"https://api.github.com/repos/atomix/copycat/releases{/id}","deployments_url":"https://api.github.com/repos/atomix/copycat/deployments","created_at":"2015-09-15T21:38:20Z","updated_at":"2016-02-03T07:23:06Z","pushed_at":"2016-02-05T07:39:58Z","git_url":"git://github.com/atomix/copycat.git","ssh_url":"git@github.com:atomix/copycat.git","clone_url":"https://github.com/atomix/copycat.git","svn_url":"https://github.com/atomix/copycat","homepage":"http://atomix.io/copycat","size":2609,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":14,"forks":17,"open_issues":14,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atomix/copycat/pulls/132"},"html":{"href":"https://github.com/atomix/copycat/pull/132"},"issue":{"href":"https://api.github.com/repos/atomix/copycat/issues/132"},"comments":{"href":"https://api.github.com/repos/atomix/copycat/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/atomix/copycat/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/atomix/copycat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atomix/copycat/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/atomix/copycat/statuses/ae28858c32086a6066ca89a10ef105a412408abd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kuujo","id":823318,"avatar_url":"https://avatars.githubusercontent.com/u/823318?v=3","gravatar_id":"","url":"https://api.github.com/users/kuujo","html_url":"https://github.com/kuujo","followers_url":"https://api.github.com/users/kuujo/followers","following_url":"https://api.github.com/users/kuujo/following{/other_user}","gists_url":"https://api.github.com/users/kuujo/gists{/gist_id}","starred_url":"https://api.github.com/users/kuujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuujo/subscriptions","organizations_url":"https://api.github.com/users/kuujo/orgs","repos_url":"https://api.github.com/users/kuujo/repos","events_url":"https://api.github.com/users/kuujo/events{/privacy}","received_events_url":"https://api.github.com/users/kuujo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":9,"changed_files":1}}