{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/2889","labels_url":"https://api.github.com/repos/videojs/video.js/issues/2889/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2889/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/2889/events","html_url":"https://github.com/videojs/video.js/pull/2889","id":120524798,"number":2889,"title":"Fix keyboard (Space or Enter) operation of buttons. Fixes #2888.","user":{"login":"OwenEdwards","id":2245205,"avatar_url":"https://avatars.githubusercontent.com/u/2245205?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenEdwards","html_url":"https://github.com/OwenEdwards","followers_url":"https://api.github.com/users/OwenEdwards/followers","following_url":"https://api.github.com/users/OwenEdwards/following{/other_user}","gists_url":"https://api.github.com/users/OwenEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenEdwards/subscriptions","organizations_url":"https://api.github.com/users/OwenEdwards/orgs","repos_url":"https://api.github.com/users/OwenEdwards/repos","events_url":"https://api.github.com/users/OwenEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/OwenEdwards/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/videojs/video.js/labels/accessibility","name":"accessibility","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-05T03:04:46Z","updated_at":"2016-01-12T19:11:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2889","html_url":"https://github.com/videojs/video.js/pull/2889","diff_url":"https://github.com/videojs/video.js/pull/2889.diff","patch_url":"https://github.com/videojs/video.js/pull/2889.patch"},"body":"When video.js moved to using button elements instead of DIVs for buttons in V5, it kept the keyboard handling to simulate a click on Space or Enter key press, even though the browser does this for buttons. This causes an issue with Firefox when performing keyboard operation of buttons like the Play/Pause button."},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/171019311","html_url":"https://github.com/videojs/video.js/pull/2889#issuecomment-171019311","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2889","id":171019311,"user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T19:11:59Z","updated_at":"2016-01-12T19:11:59Z","body":"Have a question about role/type attributes.\r\nLGTM."}}