{"action":"created","comment":{"url":"https://api.github.com/repos/hoaproject/Irc/pulls/comments/86130053","pull_request_review_id":6802453,"id":86130053,"diff_hunk":"@@ -49,21 +49,201 @@\n class Socket extends HoaSocket\n {\n     /**\n+     * Entity type: isuser.\n+     *\n+     * @const string\n+     */\n+    const ENTTYPE_ISUSER = 'isuser';\n+\n+    /**\n+     * Entity type: ischannel.\n+     *\n+     * @const string\n+     */\n+    const ENTTYPE_ISCHANNEL = 'ischannel';\n+\n+    /**\n+     * Host type: isserver.\n+     *\n+     * @const string\n+     */\n+    const HOSTTYPE_ISSERVER = 'isserver';\n+\n+    /**\n+     * Host type: isnetwork.\n+     *\n+     * @const string\n+     */\n+    const HOSTTYPE_ISNETWORK = 'isnetwork';\n+\n+    /**\n+     * Entity.\n+     * @var string\n+     */\n+    private $_entity;\n+\n+    /**\n+     * Entity type.\n+     * @var string\n+     */\n+    private $_entityType = self::ENTTYPE_ISCHANNEL;\n+\n+    /**\n+     * Host type.\n+     * @var string\n+     */\n+    private $_hostType;","path":"Socket.php","position":47,"original_position":47,"commit_id":"8f7e08d387d30e29a11ccc373075ab970b489503","original_commit_id":"8f7e08d387d30e29a11ccc373075ab970b489503","user":{"login":"Hywan","id":946104,"avatar_url":"https://avatars.githubusercontent.com/u/946104?v=3","gravatar_id":"","url":"https://api.github.com/users/Hywan","html_url":"https://github.com/Hywan","followers_url":"https://api.github.com/users/Hywan/followers","following_url":"https://api.github.com/users/Hywan/following{/other_user}","gists_url":"https://api.github.com/users/Hywan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hywan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hywan/subscriptions","organizations_url":"https://api.github.com/users/Hywan/orgs","repos_url":"https://api.github.com/users/Hywan/repos","events_url":"https://api.github.com/users/Hywan/events{/privacy}","received_events_url":"https://api.github.com/users/Hywan/received_events","type":"User","site_admin":false},"body":"Any reason to put everything in the private scope? By default, we prefer to use the protected scope, except strong reasons.","created_at":"2016-11-02T12:30:26Z","updated_at":"2016-11-02T12:30:26Z","html_url":"https://github.com/hoaproject/Irc/pull/30#discussion_r86130053","pull_request_url":"https://api.github.com/repos/hoaproject/Irc/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/comments/86130053"},"html":{"href":"https://github.com/hoaproject/Irc/pull/30#discussion_r86130053"},"pull_request":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/hoaproject/Irc/pulls/30","id":90845790,"html_url":"https://github.com/hoaproject/Irc/pull/30","diff_url":"https://github.com/hoaproject/Irc/pull/30.diff","patch_url":"https://github.com/hoaproject/Irc/pull/30.patch","issue_url":"https://api.github.com/repos/hoaproject/Irc/issues/30","number":30,"state":"open","locked":false,"title":"WIP: Extract useful information from connection url","user":{"login":"shulard","id":482993,"avatar_url":"https://avatars.githubusercontent.com/u/482993?v=3","gravatar_id":"","url":"https://api.github.com/users/shulard","html_url":"https://github.com/shulard","followers_url":"https://api.github.com/users/shulard/followers","following_url":"https://api.github.com/users/shulard/following{/other_user}","gists_url":"https://api.github.com/users/shulard/gists{/gist_id}","starred_url":"https://api.github.com/users/shulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shulard/subscriptions","organizations_url":"https://api.github.com/users/shulard/orgs","repos_url":"https://api.github.com/users/shulard/repos","events_url":"https://api.github.com/users/shulard/events{/privacy}","received_events_url":"https://api.github.com/users/shulard/received_events","type":"User","site_admin":false},"body":"Work on the #25 issue about URL details extraction.\n\nThis PR must allow the library to extract connection URL details and use it during connection :\n- Entity name to join\n- Credentials\n- Connection options\n- Connection flags (used to define entity more precisely)\n\nExample :\n\n```\n$uri    = 'irc://user:pass@irc.efnet.org:194/#channel?key=abcd';\n$client = new Hoa\\Irc\\Client(new Hoa\\Socket\\Client($uri));\n```\n\nThe given code is valid and can be used to join the channel `#channel` with the option `key=abcd`.\n","created_at":"2016-10-25T16:40:07Z","updated_at":"2016-11-02T12:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2f292c29c59f1ec654dd08d195305024a783fd3","assignee":{"login":"Hywan","id":946104,"avatar_url":"https://avatars.githubusercontent.com/u/946104?v=3","gravatar_id":"","url":"https://api.github.com/users/Hywan","html_url":"https://github.com/Hywan","followers_url":"https://api.github.com/users/Hywan/followers","following_url":"https://api.github.com/users/Hywan/following{/other_user}","gists_url":"https://api.github.com/users/Hywan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hywan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hywan/subscriptions","organizations_url":"https://api.github.com/users/Hywan/orgs","repos_url":"https://api.github.com/users/Hywan/repos","events_url":"https://api.github.com/users/Hywan/events{/privacy}","received_events_url":"https://api.github.com/users/Hywan/received_events","type":"User","site_admin":false},"assignees":[{"login":"Hywan","id":946104,"avatar_url":"https://avatars.githubusercontent.com/u/946104?v=3","gravatar_id":"","url":"https://api.github.com/users/Hywan","html_url":"https://github.com/Hywan","followers_url":"https://api.github.com/users/Hywan/followers","following_url":"https://api.github.com/users/Hywan/following{/other_user}","gists_url":"https://api.github.com/users/Hywan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hywan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hywan/subscriptions","organizations_url":"https://api.github.com/users/Hywan/orgs","repos_url":"https://api.github.com/users/Hywan/repos","events_url":"https://api.github.com/users/Hywan/events{/privacy}","received_events_url":"https://api.github.com/users/Hywan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hoaproject/Irc/pulls/30/commits","review_comments_url":"https://api.github.com/repos/hoaproject/Irc/pulls/30/comments","review_comment_url":"https://api.github.com/repos/hoaproject/Irc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoaproject/Irc/issues/30/comments","statuses_url":"https://api.github.com/repos/hoaproject/Irc/statuses/8f7e08d387d30e29a11ccc373075ab970b489503","head":{"label":"shulard:feature/extract-useful-information-from-connection-url","ref":"feature/extract-useful-information-from-connection-url","sha":"8f7e08d387d30e29a11ccc373075ab970b489503","user":{"login":"shulard","id":482993,"avatar_url":"https://avatars.githubusercontent.com/u/482993?v=3","gravatar_id":"","url":"https://api.github.com/users/shulard","html_url":"https://github.com/shulard","followers_url":"https://api.github.com/users/shulard/followers","following_url":"https://api.github.com/users/shulard/following{/other_user}","gists_url":"https://api.github.com/users/shulard/gists{/gist_id}","starred_url":"https://api.github.com/users/shulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shulard/subscriptions","organizations_url":"https://api.github.com/users/shulard/orgs","repos_url":"https://api.github.com/users/shulard/repos","events_url":"https://api.github.com/users/shulard/events{/privacy}","received_events_url":"https://api.github.com/users/shulard/received_events","type":"User","site_admin":false},"repo":{"id":41363690,"name":"Irc","full_name":"shulard/Irc","owner":{"login":"shulard","id":482993,"avatar_url":"https://avatars.githubusercontent.com/u/482993?v=3","gravatar_id":"","url":"https://api.github.com/users/shulard","html_url":"https://github.com/shulard","followers_url":"https://api.github.com/users/shulard/followers","following_url":"https://api.github.com/users/shulard/following{/other_user}","gists_url":"https://api.github.com/users/shulard/gists{/gist_id}","starred_url":"https://api.github.com/users/shulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shulard/subscriptions","organizations_url":"https://api.github.com/users/shulard/orgs","repos_url":"https://api.github.com/users/shulard/repos","events_url":"https://api.github.com/users/shulard/events{/privacy}","received_events_url":"https://api.github.com/users/shulard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shulard/Irc","description":"The Hoa\\Irc library.","fork":true,"url":"https://api.github.com/repos/shulard/Irc","forks_url":"https://api.github.com/repos/shulard/Irc/forks","keys_url":"https://api.github.com/repos/shulard/Irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shulard/Irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shulard/Irc/teams","hooks_url":"https://api.github.com/repos/shulard/Irc/hooks","issue_events_url":"https://api.github.com/repos/shulard/Irc/issues/events{/number}","events_url":"https://api.github.com/repos/shulard/Irc/events","assignees_url":"https://api.github.com/repos/shulard/Irc/assignees{/user}","branches_url":"https://api.github.com/repos/shulard/Irc/branches{/branch}","tags_url":"https://api.github.com/repos/shulard/Irc/tags","blobs_url":"https://api.github.com/repos/shulard/Irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shulard/Irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shulard/Irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/shulard/Irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shulard/Irc/statuses/{sha}","languages_url":"https://api.github.com/repos/shulard/Irc/languages","stargazers_url":"https://api.github.com/repos/shulard/Irc/stargazers","contributors_url":"https://api.github.com/repos/shulard/Irc/contributors","subscribers_url":"https://api.github.com/repos/shulard/Irc/subscribers","subscription_url":"https://api.github.com/repos/shulard/Irc/subscription","commits_url":"https://api.github.com/repos/shulard/Irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/shulard/Irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/shulard/Irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/shulard/Irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/shulard/Irc/contents/{+path}","compare_url":"https://api.github.com/repos/shulard/Irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shulard/Irc/merges","archive_url":"https://api.github.com/repos/shulard/Irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shulard/Irc/downloads","issues_url":"https://api.github.com/repos/shulard/Irc/issues{/number}","pulls_url":"https://api.github.com/repos/shulard/Irc/pulls{/number}","milestones_url":"https://api.github.com/repos/shulard/Irc/milestones{/number}","notifications_url":"https://api.github.com/repos/shulard/Irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shulard/Irc/labels{/name}","releases_url":"https://api.github.com/repos/shulard/Irc/releases{/id}","deployments_url":"https://api.github.com/repos/shulard/Irc/deployments","created_at":"2015-08-25T13:04:15Z","updated_at":"2016-02-02T14:31:11Z","pushed_at":"2016-10-25T16:35:53Z","git_url":"git://github.com/shulard/Irc.git","ssh_url":"git@github.com:shulard/Irc.git","clone_url":"https://github.com/shulard/Irc.git","svn_url":"https://github.com/shulard/Irc","homepage":"http://hoa-project.net","size":57,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hoaproject:master","ref":"master","sha":"e42bef31461ea3e38a00a97e9828f36e7c34893f","user":{"login":"hoaproject","id":1519718,"avatar_url":"https://avatars.githubusercontent.com/u/1519718?v=3","gravatar_id":"","url":"https://api.github.com/users/hoaproject","html_url":"https://github.com/hoaproject","followers_url":"https://api.github.com/users/hoaproject/followers","following_url":"https://api.github.com/users/hoaproject/following{/other_user}","gists_url":"https://api.github.com/users/hoaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaproject/subscriptions","organizations_url":"https://api.github.com/users/hoaproject/orgs","repos_url":"https://api.github.com/users/hoaproject/repos","events_url":"https://api.github.com/users/hoaproject/events{/privacy}","received_events_url":"https://api.github.com/users/hoaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":9619102,"name":"Irc","full_name":"hoaproject/Irc","owner":{"login":"hoaproject","id":1519718,"avatar_url":"https://avatars.githubusercontent.com/u/1519718?v=3","gravatar_id":"","url":"https://api.github.com/users/hoaproject","html_url":"https://github.com/hoaproject","followers_url":"https://api.github.com/users/hoaproject/followers","following_url":"https://api.github.com/users/hoaproject/following{/other_user}","gists_url":"https://api.github.com/users/hoaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaproject/subscriptions","organizations_url":"https://api.github.com/users/hoaproject/orgs","repos_url":"https://api.github.com/users/hoaproject/repos","events_url":"https://api.github.com/users/hoaproject/events{/privacy}","received_events_url":"https://api.github.com/users/hoaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hoaproject/Irc","description":"The Hoa\\Irc library.","fork":false,"url":"https://api.github.com/repos/hoaproject/Irc","forks_url":"https://api.github.com/repos/hoaproject/Irc/forks","keys_url":"https://api.github.com/repos/hoaproject/Irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoaproject/Irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoaproject/Irc/teams","hooks_url":"https://api.github.com/repos/hoaproject/Irc/hooks","issue_events_url":"https://api.github.com/repos/hoaproject/Irc/issues/events{/number}","events_url":"https://api.github.com/repos/hoaproject/Irc/events","assignees_url":"https://api.github.com/repos/hoaproject/Irc/assignees{/user}","branches_url":"https://api.github.com/repos/hoaproject/Irc/branches{/branch}","tags_url":"https://api.github.com/repos/hoaproject/Irc/tags","blobs_url":"https://api.github.com/repos/hoaproject/Irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoaproject/Irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoaproject/Irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoaproject/Irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoaproject/Irc/statuses/{sha}","languages_url":"https://api.github.com/repos/hoaproject/Irc/languages","stargazers_url":"https://api.github.com/repos/hoaproject/Irc/stargazers","contributors_url":"https://api.github.com/repos/hoaproject/Irc/contributors","subscribers_url":"https://api.github.com/repos/hoaproject/Irc/subscribers","subscription_url":"https://api.github.com/repos/hoaproject/Irc/subscription","commits_url":"https://api.github.com/repos/hoaproject/Irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoaproject/Irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoaproject/Irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoaproject/Irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoaproject/Irc/contents/{+path}","compare_url":"https://api.github.com/repos/hoaproject/Irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoaproject/Irc/merges","archive_url":"https://api.github.com/repos/hoaproject/Irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoaproject/Irc/downloads","issues_url":"https://api.github.com/repos/hoaproject/Irc/issues{/number}","pulls_url":"https://api.github.com/repos/hoaproject/Irc/pulls{/number}","milestones_url":"https://api.github.com/repos/hoaproject/Irc/milestones{/number}","notifications_url":"https://api.github.com/repos/hoaproject/Irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoaproject/Irc/labels{/name}","releases_url":"https://api.github.com/repos/hoaproject/Irc/releases{/id}","deployments_url":"https://api.github.com/repos/hoaproject/Irc/deployments","created_at":"2013-04-23T08:59:10Z","updated_at":"2016-10-24T13:24:28Z","pushed_at":"2016-10-26T22:13:33Z","git_url":"git://github.com/hoaproject/Irc.git","ssh_url":"git@github.com:hoaproject/Irc.git","clone_url":"https://github.com/hoaproject/Irc.git","svn_url":"https://github.com/hoaproject/Irc","homepage":"http://hoa-project.net","size":62,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/30"},"html":{"href":"https://github.com/hoaproject/Irc/pull/30"},"issue":{"href":"https://api.github.com/repos/hoaproject/Irc/issues/30"},"comments":{"href":"https://api.github.com/repos/hoaproject/Irc/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoaproject/Irc/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/hoaproject/Irc/statuses/8f7e08d387d30e29a11ccc373075ab970b489503"}}}}
{"actor":{"display_login":"Hywan"}}