{"push_id":1129141539,"size":1,"distinct_size":1,"ref":"refs/heads/dxia/refactor-temp-jobs","head":"d59b2b55fb9bbb29ead96b0e9527fd2e1862b37c","before":"50033d7072a944a29bf0a5d755cff85ea6f17d5e","commits":[{"sha":"d59b2b55fb9bbb29ead96b0e9527fd2e1862b37c","author":{"email":"92cf52aba7504809dfd074dfbc5a71f259728dd1@spotify.com","name":"David Xia"},"message":"helios-testing: TemporaryJobs manages HeliosSoloDeployment\n\n`TemporaryJobs` creates, starts, and stops an instance of\n`HeliosSoloDeployment` instead of the user needing to manage it.\n\nI.e.\n```\n@Rule public TemporaryJobs temporaryJobs = TemporaryJobs.create();\n```\n\ninstead of\n\n```\nprivate static final HeliosDeploymentResource soloResource =\n  new HeliosDeploymentResource(HeliosSoloDeployment.fromEnv().build());\n\nprivate static final TemporaryJobs temporaryJobs =\n  TemporaryJobs.builder().client(soloResource.client()).build();\n\n@ClassRule\npublic static final RuleChain chain = RuleChain\n    .outerRule(soloResource)\n    .around(temporaryJobs);\n```\n\nN.B. If an integration test deploys containers using helios-solo\nand the test runner dies without calling\n`TemporaryJobs.after()` -> `HeliosSoloDeployment.close()`,\nwe could be left with stray containers on the Docker host.\n\nWe can fix this with a helios-solo container that has logic to clean\nitself up and kill itself. To be done in a later commit.\n\nSigned-off-by: David Xia <dxia@spotify.com>","distinct":true,"url":"https://api.github.com/repos/spotify/helios/commits/d59b2b55fb9bbb29ead96b0e9527fd2e1862b37c"}]}
{"actor":{"display_login":"davidxia"}}