{"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/68082586","id":68082586,"diff_hunk":"@@ -59,12 +66,31 @@ public void configure(String forumId, Boolean isCurrentUserModerator, Set<Long>\n \t\tthis.moderatorIds = moderatorIds;\n \t\toffset = 0L;\n \t\tthis.forumId = forumId;\n+\t\tinvokeCheckForInViewAndLoadData = new Callback() {\n+\t\t\t@Override\n+\t\t\tpublic void invoke() {\n+\t\t\t\tcheckForInViewAndLoadData();\n+\t\t\t}\n+\t\t};\n \t\tloadMore();\n \t\tDiscussionThreadCountAlert threadCountAlert = ginInjector.getDiscussionThreadCountAlert();\n \t\tview.setThreadCountAlert(threadCountAlert.asWidget());\n \t\tthreadCountAlert.configure(forumId);\n \t}\n \n+\tpublic void checkForInViewAndLoadData() {\n+\t\tif (!view.isLoadMoreAttached()) {","path":"src/main/java/org/sagebionetworks/web/client/widget/discussion/DiscussionThreadListWidget.java","position":59,"original_position":59,"commit_id":"0236119084be73688b0e29afcd0b3f2017958fbe","original_commit_id":"0236119084be73688b0e29afcd0b3f2017958fbe","user":{"login":"jay-hodgson","id":1864447,"avatar_url":"https://avatars.githubusercontent.com/u/1864447?v=3","gravatar_id":"","url":"https://api.github.com/users/jay-hodgson","html_url":"https://github.com/jay-hodgson","followers_url":"https://api.github.com/users/jay-hodgson/followers","following_url":"https://api.github.com/users/jay-hodgson/following{/other_user}","gists_url":"https://api.github.com/users/jay-hodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/jay-hodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay-hodgson/subscriptions","organizations_url":"https://api.github.com/users/jay-hodgson/orgs","repos_url":"https://api.github.com/users/jay-hodgson/repos","events_url":"https://api.github.com/users/jay-hodgson/events{/privacy}","received_events_url":"https://api.github.com/users/jay-hodgson/received_events","type":"User","site_admin":false},"body":"Shouldn't this loop also end if the load more is no longer visible?  (!view.getLoadMoreVisibility())","created_at":"2016-06-22T16:04:25Z","updated_at":"2016-06-22T16:04:25Z","html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356#discussion_r68082586","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/68082586"},"html":{"href":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356#discussion_r68082586"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356"}}},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356","id":74700450,"html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356","diff_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356.diff","patch_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/2356","number":2356,"state":"open","locked":false,"title":"SWC-3109: scroll down to load more threads/ replies","user":{"login":"kimyen","id":4404426,"avatar_url":"https://avatars.githubusercontent.com/u/4404426?v=3","gravatar_id":"","url":"https://api.github.com/users/kimyen","html_url":"https://github.com/kimyen","followers_url":"https://api.github.com/users/kimyen/followers","following_url":"https://api.github.com/users/kimyen/following{/other_user}","gists_url":"https://api.github.com/users/kimyen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimyen/subscriptions","organizations_url":"https://api.github.com/users/kimyen/orgs","repos_url":"https://api.github.com/users/kimyen/repos","events_url":"https://api.github.com/users/kimyen/events{/privacy}","received_events_url":"https://api.github.com/users/kimyen/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-21T23:05:12Z","updated_at":"2016-06-22T16:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afbce69369ad475f7bda0b2dff2b6333c7679811","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/2356/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/0236119084be73688b0e29afcd0b3f2017958fbe","head":{"label":"kimyen:discussion","ref":"discussion","sha":"0236119084be73688b0e29afcd0b3f2017958fbe","user":{"login":"kimyen","id":4404426,"avatar_url":"https://avatars.githubusercontent.com/u/4404426?v=3","gravatar_id":"","url":"https://api.github.com/users/kimyen","html_url":"https://github.com/kimyen","followers_url":"https://api.github.com/users/kimyen/followers","following_url":"https://api.github.com/users/kimyen/following{/other_user}","gists_url":"https://api.github.com/users/kimyen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimyen/subscriptions","organizations_url":"https://api.github.com/users/kimyen/orgs","repos_url":"https://api.github.com/users/kimyen/repos","events_url":"https://api.github.com/users/kimyen/events{/privacy}","received_events_url":"https://api.github.com/users/kimyen/received_events","type":"User","site_admin":false},"repo":{"id":30001383,"name":"SynapseWebClient","full_name":"kimyen/SynapseWebClient","owner":{"login":"kimyen","id":4404426,"avatar_url":"https://avatars.githubusercontent.com/u/4404426?v=3","gravatar_id":"","url":"https://api.github.com/users/kimyen","html_url":"https://github.com/kimyen","followers_url":"https://api.github.com/users/kimyen/followers","following_url":"https://api.github.com/users/kimyen/following{/other_user}","gists_url":"https://api.github.com/users/kimyen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimyen/subscriptions","organizations_url":"https://api.github.com/users/kimyen/orgs","repos_url":"https://api.github.com/users/kimyen/repos","events_url":"https://api.github.com/users/kimyen/events{/privacy}","received_events_url":"https://api.github.com/users/kimyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimyen/SynapseWebClient","description":"The web client of the Synapse REST service core","fork":true,"url":"https://api.github.com/repos/kimyen/SynapseWebClient","forks_url":"https://api.github.com/repos/kimyen/SynapseWebClient/forks","keys_url":"https://api.github.com/repos/kimyen/SynapseWebClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimyen/SynapseWebClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimyen/SynapseWebClient/teams","hooks_url":"https://api.github.com/repos/kimyen/SynapseWebClient/hooks","issue_events_url":"https://api.github.com/repos/kimyen/SynapseWebClient/issues/events{/number}","events_url":"https://api.github.com/repos/kimyen/SynapseWebClient/events","assignees_url":"https://api.github.com/repos/kimyen/SynapseWebClient/assignees{/user}","branches_url":"https://api.github.com/repos/kimyen/SynapseWebClient/branches{/branch}","tags_url":"https://api.github.com/repos/kimyen/SynapseWebClient/tags","blobs_url":"https://api.github.com/repos/kimyen/SynapseWebClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimyen/SynapseWebClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimyen/SynapseWebClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimyen/SynapseWebClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimyen/SynapseWebClient/statuses/{sha}","languages_url":"https://api.github.com/repos/kimyen/SynapseWebClient/languages","stargazers_url":"https://api.github.com/repos/kimyen/SynapseWebClient/stargazers","contributors_url":"https://api.github.com/repos/kimyen/SynapseWebClient/contributors","subscribers_url":"https://api.github.com/repos/kimyen/SynapseWebClient/subscribers","subscription_url":"https://api.github.com/repos/kimyen/SynapseWebClient/subscription","commits_url":"https://api.github.com/repos/kimyen/SynapseWebClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimyen/SynapseWebClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimyen/SynapseWebClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimyen/SynapseWebClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/kimyen/SynapseWebClient/contents/{+path}","compare_url":"https://api.github.com/repos/kimyen/SynapseWebClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimyen/SynapseWebClient/merges","archive_url":"https://api.github.com/repos/kimyen/SynapseWebClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimyen/SynapseWebClient/downloads","issues_url":"https://api.github.com/repos/kimyen/SynapseWebClient/issues{/number}","pulls_url":"https://api.github.com/repos/kimyen/SynapseWebClient/pulls{/number}","milestones_url":"https://api.github.com/repos/kimyen/SynapseWebClient/milestones{/number}","notifications_url":"https://api.github.com/repos/kimyen/SynapseWebClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimyen/SynapseWebClient/labels{/name}","releases_url":"https://api.github.com/repos/kimyen/SynapseWebClient/releases{/id}","deployments_url":"https://api.github.com/repos/kimyen/SynapseWebClient/deployments","created_at":"2015-01-29T03:16:11Z","updated_at":"2016-02-16T20:59:27Z","pushed_at":"2016-06-22T00:28:15Z","git_url":"git://github.com/kimyen/SynapseWebClient.git","ssh_url":"git@github.com:kimyen/SynapseWebClient.git","clone_url":"https://github.com/kimyen/SynapseWebClient.git","svn_url":"https://github.com/kimyen/SynapseWebClient","homepage":null,"size":57549,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Sage-Bionetworks:develop","ref":"develop","sha":"b31ff499200cb3dece9989f265f9960e9330ae83","user":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":4302671,"name":"SynapseWebClient","full_name":"Sage-Bionetworks/SynapseWebClient","owner":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient","description":"The web client of the Synapse REST service core","fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient","forks_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/deployments","created_at":"2012-05-11T23:11:54Z","updated_at":"2016-02-06T14:16:25Z","pushed_at":"2016-06-22T00:28:16Z","git_url":"git://github.com/Sage-Bionetworks/SynapseWebClient.git","ssh_url":"git@github.com:Sage-Bionetworks/SynapseWebClient.git","clone_url":"https://github.com/Sage-Bionetworks/SynapseWebClient.git","svn_url":"https://github.com/Sage-Bionetworks/SynapseWebClient","homepage":null,"size":58567,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356"},"html":{"href":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/2356"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/2356"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/2356/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/2356/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/0236119084be73688b0e29afcd0b3f2017958fbe"}}}}
{"actor":{"display_login":"jay-hodgson"}}