{"action":"created","issue":{"url":"https://api.github.com/repos/omegaup/omegaup/issues/967","repository_url":"https://api.github.com/repos/omegaup/omegaup","labels_url":"https://api.github.com/repos/omegaup/omegaup/issues/967/labels{/name}","comments_url":"https://api.github.com/repos/omegaup/omegaup/issues/967/comments","events_url":"https://api.github.com/repos/omegaup/omegaup/issues/967/events","html_url":"https://github.com/omegaup/omegaup/pull/967","id":191047279,"number":967,"title":"Implementando la UI para Agregar Estudiantes","user":{"login":"joemmanuel","id":207097,"avatar_url":"https://avatars.githubusercontent.com/u/207097?v=3","gravatar_id":"","url":"https://api.github.com/users/joemmanuel","html_url":"https://github.com/joemmanuel","followers_url":"https://api.github.com/users/joemmanuel/followers","following_url":"https://api.github.com/users/joemmanuel/following{/other_user}","gists_url":"https://api.github.com/users/joemmanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/joemmanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemmanuel/subscriptions","organizations_url":"https://api.github.com/users/joemmanuel/orgs","repos_url":"https://api.github.com/users/joemmanuel/repos","events_url":"https://api.github.com/users/joemmanuel/events{/privacy}","received_events_url":"https://api.github.com/users/joemmanuel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-22T16:01:20Z","updated_at":"2016-11-22T20:03:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/omegaup/omegaup/pulls/967","html_url":"https://github.com/omegaup/omegaup/pull/967","diff_url":"https://github.com/omegaup/omegaup/pull/967.diff","patch_url":"https://github.com/omegaup/omegaup/pull/967.patch"},"body":"Incluye un pequeño refactor para poner `refreshStudentList()` en un lugar común (`course.edit.js`) dado que es usado en View Progress y Add Student. "},"comment":{"url":"https://api.github.com/repos/omegaup/omegaup/issues/comments/262350141","html_url":"https://github.com/omegaup/omegaup/pull/967#issuecomment-262350141","issue_url":"https://api.github.com/repos/omegaup/omegaup/issues/967","id":262350141,"user":{"login":"pabloaguilar","id":189223,"avatar_url":"https://avatars.githubusercontent.com/u/189223?v=3","gravatar_id":"","url":"https://api.github.com/users/pabloaguilar","html_url":"https://github.com/pabloaguilar","followers_url":"https://api.github.com/users/pabloaguilar/followers","following_url":"https://api.github.com/users/pabloaguilar/following{/other_user}","gists_url":"https://api.github.com/users/pabloaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloaguilar/subscriptions","organizations_url":"https://api.github.com/users/pabloaguilar/orgs","repos_url":"https://api.github.com/users/pabloaguilar/repos","events_url":"https://api.github.com/users/pabloaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/pabloaguilar/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T20:03:33Z","updated_at":"2016-11-22T20:03:33Z","body":"Voto por no depender de la suposicion courseAlias == groupAlias.\nEl link via Foreign Key tiene mas garantias en la base de datos.\n\nUna solucion es, como dice @Joe, jalar el group alias cuando sea necesario\nY otra seria agregar addStudentToCourse en CourseController que haga lo\nmismo pero en el backend\n\n2016-11-22 11:57 GMT-08:00 Joemmanuel Ponce <notifications@github.com>:\n\n> *@joemmanuel* commented on this pull request.\n> ------------------------------\n>\n> In frontend/www/js/course.add.students.js\n> <https://github.com/omegaup/omegaup/pull/967>:\n>\n> > @@ -0,0 +1,19 @@\n> +$('document')\n> +    .ready(function() {\n> +      $('#add-member-form')\n> +          .submit(function() {\n> +            var courseAlias = /\\/course\\/([^\\/]+)\\/edit\\/?.*/.exec(\n> +                window.location.pathname)[1];\n> +\n> +            omegaup.API.addUserToGroup(\n> +                courseAlias, $('#member-username').val(), function(data) {\n>\n> De acuerdo - hay que decidir si ya lo dejamos como convención (prefered\n> por simplicidad - Cursos va ser el caso de uso principal de Grupos) o lo\n> hacemos bien - que getCourseDetails se traiga el group alias y lo reusamos\n> aquí. @omegaup/reviewers <https://github.com/orgs/omegaup/teams/reviewers>\n> comentarios?\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/omegaup/omegaup/pull/967>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AALjJxth134-25E_rlurb8_O9KOPBjCjks5rA0kvgaJpZM4K5nAa>\n> .\n>\n\n\n\n-- \nPablo Aguilar\npablo.aguilar@gmail.com\n"}}
{"actor":{"display_login":"pabloaguilar"}}