{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/promu/pulls/comments/84006024","pull_request_review_id":4810981,"id":84006024,"diff_hunk":"@@ -109,7 +110,7 @@ func runBuild() {\n \t\tparams = append(params, path.Join(repoPath, binary.Path))\n \t\terr := sh.RunCommand(\"go\", params...)\n \t\tif err != nil {\n-\t\t\tfmt.Println(\"command failed:\", err)\n+\t\t\tlog.Fatal(\"command failed:\", err, strings.Join(params, \" \"))","path":"cmd/build.go","position":null,"original_position":13,"commit_id":"bbf89f40b5bf9819b7f91decf9fd94486ea1cd07","original_commit_id":"9938f3e5a506527bb26467c1eb8c2062434ff367","user":{"login":"martinlindhe","id":181531,"avatar_url":"https://avatars.githubusercontent.com/u/181531?v=3","gravatar_id":"","url":"https://api.github.com/users/martinlindhe","html_url":"https://github.com/martinlindhe","followers_url":"https://api.github.com/users/martinlindhe/followers","following_url":"https://api.github.com/users/martinlindhe/following{/other_user}","gists_url":"https://api.github.com/users/martinlindhe/gists{/gist_id}","starred_url":"https://api.github.com/users/martinlindhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinlindhe/subscriptions","organizations_url":"https://api.github.com/users/martinlindhe/orgs","repos_url":"https://api.github.com/users/martinlindhe/repos","events_url":"https://api.github.com/users/martinlindhe/events{/privacy}","received_events_url":"https://api.github.com/users/martinlindhe/received_events","type":"User","site_admin":false},"body":"patch updated to use fatalMsg()","created_at":"2016-10-19T06:50:15Z","updated_at":"2016-10-19T06:50:15Z","html_url":"https://github.com/prometheus/promu/pull/50#discussion_r84006024","pull_request_url":"https://api.github.com/repos/prometheus/promu/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/prometheus/promu/pulls/comments/84006024"},"html":{"href":"https://github.com/prometheus/promu/pull/50#discussion_r84006024"},"pull_request":{"href":"https://api.github.com/repos/prometheus/promu/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/promu/pulls/50","id":89819888,"html_url":"https://github.com/prometheus/promu/pull/50","diff_url":"https://github.com/prometheus/promu/pull/50.diff","patch_url":"https://github.com/prometheus/promu/pull/50.patch","issue_url":"https://api.github.com/repos/prometheus/promu/issues/50","number":50,"state":"open","locked":false,"title":"return with error code on command failure","user":{"login":"martinlindhe","id":181531,"avatar_url":"https://avatars.githubusercontent.com/u/181531?v=3","gravatar_id":"","url":"https://api.github.com/users/martinlindhe","html_url":"https://github.com/martinlindhe","followers_url":"https://api.github.com/users/martinlindhe/followers","following_url":"https://api.github.com/users/martinlindhe/following{/other_user}","gists_url":"https://api.github.com/users/martinlindhe/gists{/gist_id}","starred_url":"https://api.github.com/users/martinlindhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinlindhe/subscriptions","organizations_url":"https://api.github.com/users/martinlindhe/orgs","repos_url":"https://api.github.com/users/martinlindhe/repos","events_url":"https://api.github.com/users/martinlindhe/events{/privacy}","received_events_url":"https://api.github.com/users/martinlindhe/received_events","type":"User","site_admin":false},"body":"While looking into a failure on appveyor [1], we noticed `command failed: fork/exec c:\\go\\bin\\go.exe: invalid argument`, but appveyor failed to pick up the failure.\r\n\r\nThis patch quits on command failure using log.Fatal(), which signals an exit code to the OS so it can be picked up by appveyor.\r\n\r\nThe root cause of the failing command is still under investigation\r\n\r\n1: https://ci.appveyor.com/project/martinlindhe/wmi-exporter/build/170","created_at":"2016-10-18T13:53:29Z","updated_at":"2016-10-19T06:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ddbc504faddb3094fd022757960db246e5e9413","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/promu/pulls/50/commits","review_comments_url":"https://api.github.com/repos/prometheus/promu/pulls/50/comments","review_comment_url":"https://api.github.com/repos/prometheus/promu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/promu/issues/50/comments","statuses_url":"https://api.github.com/repos/prometheus/promu/statuses/bbf89f40b5bf9819b7f91decf9fd94486ea1cd07","head":{"label":"martinlindhe:signal-failure","ref":"signal-failure","sha":"bbf89f40b5bf9819b7f91decf9fd94486ea1cd07","user":{"login":"martinlindhe","id":181531,"avatar_url":"https://avatars.githubusercontent.com/u/181531?v=3","gravatar_id":"","url":"https://api.github.com/users/martinlindhe","html_url":"https://github.com/martinlindhe","followers_url":"https://api.github.com/users/martinlindhe/followers","following_url":"https://api.github.com/users/martinlindhe/following{/other_user}","gists_url":"https://api.github.com/users/martinlindhe/gists{/gist_id}","starred_url":"https://api.github.com/users/martinlindhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinlindhe/subscriptions","organizations_url":"https://api.github.com/users/martinlindhe/orgs","repos_url":"https://api.github.com/users/martinlindhe/repos","events_url":"https://api.github.com/users/martinlindhe/events{/privacy}","received_events_url":"https://api.github.com/users/martinlindhe/received_events","type":"User","site_admin":false},"repo":{"id":71253482,"name":"promu","full_name":"martinlindhe/promu","owner":{"login":"martinlindhe","id":181531,"avatar_url":"https://avatars.githubusercontent.com/u/181531?v=3","gravatar_id":"","url":"https://api.github.com/users/martinlindhe","html_url":"https://github.com/martinlindhe","followers_url":"https://api.github.com/users/martinlindhe/followers","following_url":"https://api.github.com/users/martinlindhe/following{/other_user}","gists_url":"https://api.github.com/users/martinlindhe/gists{/gist_id}","starred_url":"https://api.github.com/users/martinlindhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinlindhe/subscriptions","organizations_url":"https://api.github.com/users/martinlindhe/orgs","repos_url":"https://api.github.com/users/martinlindhe/repos","events_url":"https://api.github.com/users/martinlindhe/events{/privacy}","received_events_url":"https://api.github.com/users/martinlindhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinlindhe/promu","description":"Prometheus Utility Tool","fork":true,"url":"https://api.github.com/repos/martinlindhe/promu","forks_url":"https://api.github.com/repos/martinlindhe/promu/forks","keys_url":"https://api.github.com/repos/martinlindhe/promu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinlindhe/promu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinlindhe/promu/teams","hooks_url":"https://api.github.com/repos/martinlindhe/promu/hooks","issue_events_url":"https://api.github.com/repos/martinlindhe/promu/issues/events{/number}","events_url":"https://api.github.com/repos/martinlindhe/promu/events","assignees_url":"https://api.github.com/repos/martinlindhe/promu/assignees{/user}","branches_url":"https://api.github.com/repos/martinlindhe/promu/branches{/branch}","tags_url":"https://api.github.com/repos/martinlindhe/promu/tags","blobs_url":"https://api.github.com/repos/martinlindhe/promu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinlindhe/promu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinlindhe/promu/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinlindhe/promu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinlindhe/promu/statuses/{sha}","languages_url":"https://api.github.com/repos/martinlindhe/promu/languages","stargazers_url":"https://api.github.com/repos/martinlindhe/promu/stargazers","contributors_url":"https://api.github.com/repos/martinlindhe/promu/contributors","subscribers_url":"https://api.github.com/repos/martinlindhe/promu/subscribers","subscription_url":"https://api.github.com/repos/martinlindhe/promu/subscription","commits_url":"https://api.github.com/repos/martinlindhe/promu/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinlindhe/promu/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinlindhe/promu/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinlindhe/promu/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinlindhe/promu/contents/{+path}","compare_url":"https://api.github.com/repos/martinlindhe/promu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinlindhe/promu/merges","archive_url":"https://api.github.com/repos/martinlindhe/promu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinlindhe/promu/downloads","issues_url":"https://api.github.com/repos/martinlindhe/promu/issues{/number}","pulls_url":"https://api.github.com/repos/martinlindhe/promu/pulls{/number}","milestones_url":"https://api.github.com/repos/martinlindhe/promu/milestones{/number}","notifications_url":"https://api.github.com/repos/martinlindhe/promu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinlindhe/promu/labels{/name}","releases_url":"https://api.github.com/repos/martinlindhe/promu/releases{/id}","deployments_url":"https://api.github.com/repos/martinlindhe/promu/deployments","created_at":"2016-10-18T13:53:10Z","updated_at":"2016-10-18T13:53:11Z","pushed_at":"2016-10-19T06:49:59Z","git_url":"git://github.com/martinlindhe/promu.git","ssh_url":"git@github.com:martinlindhe/promu.git","clone_url":"https://github.com/martinlindhe/promu.git","svn_url":"https://github.com/martinlindhe/promu","homepage":null,"size":2569,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"15dd722c63ead47409bad99b1dd5a3381c44756e","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":55760054,"name":"promu","full_name":"prometheus/promu","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/promu","description":"Prometheus Utility Tool","fork":false,"url":"https://api.github.com/repos/prometheus/promu","forks_url":"https://api.github.com/repos/prometheus/promu/forks","keys_url":"https://api.github.com/repos/prometheus/promu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/promu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/promu/teams","hooks_url":"https://api.github.com/repos/prometheus/promu/hooks","issue_events_url":"https://api.github.com/repos/prometheus/promu/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/promu/events","assignees_url":"https://api.github.com/repos/prometheus/promu/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/promu/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/promu/tags","blobs_url":"https://api.github.com/repos/prometheus/promu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/promu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/promu/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/promu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/promu/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/promu/languages","stargazers_url":"https://api.github.com/repos/prometheus/promu/stargazers","contributors_url":"https://api.github.com/repos/prometheus/promu/contributors","subscribers_url":"https://api.github.com/repos/prometheus/promu/subscribers","subscription_url":"https://api.github.com/repos/prometheus/promu/subscription","commits_url":"https://api.github.com/repos/prometheus/promu/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/promu/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/promu/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/promu/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/promu/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/promu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/promu/merges","archive_url":"https://api.github.com/repos/prometheus/promu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/promu/downloads","issues_url":"https://api.github.com/repos/prometheus/promu/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/promu/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/promu/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/promu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/promu/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/promu/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/promu/deployments","created_at":"2016-04-08T07:40:18Z","updated_at":"2016-10-17T11:17:01Z","pushed_at":"2016-10-19T06:49:59Z","git_url":"git://github.com/prometheus/promu.git","ssh_url":"git@github.com:prometheus/promu.git","clone_url":"https://github.com/prometheus/promu.git","svn_url":"https://github.com/prometheus/promu","homepage":null,"size":2571,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/promu/pulls/50"},"html":{"href":"https://github.com/prometheus/promu/pull/50"},"issue":{"href":"https://api.github.com/repos/prometheus/promu/issues/50"},"comments":{"href":"https://api.github.com/repos/prometheus/promu/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/promu/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/promu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/promu/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/promu/statuses/bbf89f40b5bf9819b7f91decf9fd94486ea1cd07"}}}}
{"actor":{"display_login":"martinlindhe"}}