{"push_id":975992218,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"2dae6567c67baee7194c2b8851c00d00b0db0392","before":"6a61cb2540e95ba8668c0296a97451809867098a","commits":[{"sha":"1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6","author":{"email":"896bf5df543c1f948ee12a103581bcfc066264b5@easystack.cn","name":"Tang Chen"},"message":"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--> Command\n     |--> DisplayCommandBase\n          |--> Lister\n          |--> ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 1 in all identity tests.\n\nChange-Id: Id7180d10c050c6286b2c05cd990e2e275fbc3d38\nPartial-bug: #1477199","distinct":true,"url":"https://api.github.com/repos/openstack/python-openstackclient/commits/1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6"},{"sha":"2dae6567c67baee7194c2b8851c00d00b0db0392","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","name":"Jenkins"},"message":"Merge \"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests\"","distinct":true,"url":"https://api.github.com/repos/openstack/python-openstackclient/commits/2dae6567c67baee7194c2b8851c00d00b0db0392"}]}