{"action":"created","issue":{"url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/10","repository_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle","labels_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/10/comments","events_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/10/events","html_url":"https://github.com/Shnoulle/LimeSurvey-Shnoulle/issues/10","id":173148533,"number":10,"title":"Remove unneeded checkbox and radio classes on input and wrapper within answers","user":{"login":"PeterEmil","id":2565012,"avatar_url":"https://avatars.githubusercontent.com/u/2565012?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterEmil","html_url":"https://github.com/PeterEmil","followers_url":"https://api.github.com/users/PeterEmil/followers","following_url":"https://api.github.com/users/PeterEmil/following{/other_user}","gists_url":"https://api.github.com/users/PeterEmil/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterEmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterEmil/subscriptions","organizations_url":"https://api.github.com/users/PeterEmil/orgs","repos_url":"https://api.github.com/users/PeterEmil/repos","events_url":"https://api.github.com/users/PeterEmil/events{/privacy}","received_events_url":"https://api.github.com/users/PeterEmil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"PeterEmil","id":2565012,"avatar_url":"https://avatars.githubusercontent.com/u/2565012?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterEmil","html_url":"https://github.com/PeterEmil","followers_url":"https://api.github.com/users/PeterEmil/followers","following_url":"https://api.github.com/users/PeterEmil/following{/other_user}","gists_url":"https://api.github.com/users/PeterEmil/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterEmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterEmil/subscriptions","organizations_url":"https://api.github.com/users/PeterEmil/orgs","repos_url":"https://api.github.com/users/PeterEmil/repos","events_url":"https://api.github.com/users/PeterEmil/events{/privacy}","received_events_url":"https://api.github.com/users/PeterEmil/received_events","type":"User","site_admin":false},"assignees":[{"login":"PeterEmil","id":2565012,"avatar_url":"https://avatars.githubusercontent.com/u/2565012?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterEmil","html_url":"https://github.com/PeterEmil","followers_url":"https://api.github.com/users/PeterEmil/followers","following_url":"https://api.github.com/users/PeterEmil/following{/other_user}","gists_url":"https://api.github.com/users/PeterEmil/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterEmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterEmil/subscriptions","organizations_url":"https://api.github.com/users/PeterEmil/orgs","repos_url":"https://api.github.com/users/PeterEmil/repos","events_url":"https://api.github.com/users/PeterEmil/events{/privacy}","received_events_url":"https://api.github.com/users/PeterEmil/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/milestones/1","html_url":"https://github.com/Shnoulle/LimeSurvey-Shnoulle/milestones/2.52","labels_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/milestones/1/labels","id":1912110,"number":1,"title":"2.52","description":"The FIRST milestone maybe LS 3.00 with Cint\r\n","creator":{"login":"Shnoulle","id":1439428,"avatar_url":"https://avatars.githubusercontent.com/u/1439428?v=3","gravatar_id":"","url":"https://api.github.com/users/Shnoulle","html_url":"https://github.com/Shnoulle","followers_url":"https://api.github.com/users/Shnoulle/followers","following_url":"https://api.github.com/users/Shnoulle/following{/other_user}","gists_url":"https://api.github.com/users/Shnoulle/gists{/gist_id}","starred_url":"https://api.github.com/users/Shnoulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shnoulle/subscriptions","organizations_url":"https://api.github.com/users/Shnoulle/orgs","repos_url":"https://api.github.com/users/Shnoulle/repos","events_url":"https://api.github.com/users/Shnoulle/events{/privacy}","received_events_url":"https://api.github.com/users/Shnoulle/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-07-29T16:14:31Z","updated_at":"2016-09-06T13:21:58Z","due_on":"2016-09-16T00:00:00Z","closed_at":null},"comments":27,"created_at":"2016-08-25T08:57:28Z","updated_at":"2016-09-07T12:30:49Z","closed_at":null,"body":"Working with vanilla Bootstrap the classes on the input and wrapper elements giving unwanted results. Best is to remove the `checkbox` and `radio` classes on the wrapper and input.\r\n\r\nThis issue arises in the following views:\r\nanswer_td_input.php (arrays: 5point and 10point)\r\nanswer_row.php (arrays: increasesamedecrease)\r\nanswer.php (arrays: dualscale)\r\nanswer_row_noanswer.php (arrays: listradio)\r\nanswer_row_other.php (arrays: listradio)\r\nitem.php (yesno: radio)\r\n\r\nI can change those files and create pull request for them.\r\n\r\nFor now we had to remove them via JS but I'm no fan of this way of working. See this code:\r\n```\r\n    //* !  Remove .radio and .checkbox on divs, lis and tds within answers */\r\n    // Because BS default styling is interfering\r\n    // This removal is twofold: first we remove the class on the div or tablecell itself\r\n    // Then we remove the class on the nested input\r\n    // This way we have an unstyled clean base to work from\r\n    // As fallback we override it with css so there is less of a style-jump when refreshing the page\r\n    $('div.radio, li.radio, td.radio').each(function(){\r\n        // Remove on the tablecell\r\n        $(this).removeClass('radio');\r\n        // Remove on the input\r\n        $(this).find('input').removeClass('radio');\r\n    });\r\n    $('div.checkbox, li.checkbox, td.checkbox').each(function(){\r\n        // Remove on the tablecell\r\n        $(this).removeClass('checkbox');\r\n        // Remove on the input\r\n        $(this).find('input').removeClass('checkbox');\r\n    });\r\n    // Even better to remove this junk from views via pull request\r\n```\r\n\r\nThis issue is related to #5 "},"comment":{"url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/comments/245265463","html_url":"https://github.com/Shnoulle/LimeSurvey-Shnoulle/issues/10#issuecomment-245265463","issue_url":"https://api.github.com/repos/Shnoulle/LimeSurvey-Shnoulle/issues/10","id":245265463,"user":{"login":"Shnoulle","id":1439428,"avatar_url":"https://avatars.githubusercontent.com/u/1439428?v=3","gravatar_id":"","url":"https://api.github.com/users/Shnoulle","html_url":"https://github.com/Shnoulle","followers_url":"https://api.github.com/users/Shnoulle/followers","following_url":"https://api.github.com/users/Shnoulle/following{/other_user}","gists_url":"https://api.github.com/users/Shnoulle/gists{/gist_id}","starred_url":"https://api.github.com/users/Shnoulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shnoulle/subscriptions","organizations_url":"https://api.github.com/users/Shnoulle/orgs","repos_url":"https://api.github.com/users/Shnoulle/repos","events_url":"https://api.github.com/users/Shnoulle/events{/privacy}","received_events_url":"https://api.github.com/users/Shnoulle/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T12:30:49Z","updated_at":"2016-09-07T12:30:49Z","body":"awesome-bootstrap is easy because it was very simple. But, in fact : they use .radio but need another html.\r\n\r\nThen i'm not sure awesome team make the good decison here ....\r\n\r\nNot so easy .... \r\n\r\nawesome-bootsrap is template system , right ? Or default by core ?\r\n\r\n"}}
{"actor":{"display_login":"Shnoulle"}}