{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/244","id":77192359,"html_url":"https://github.com/learningequality/kolibri/pull/244","diff_url":"https://github.com/learningequality/kolibri/pull/244.diff","patch_url":"https://github.com/learningequality/kolibri/pull/244.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/244","number":244,"state":"closed","locked":false,"title":"WIP - Adding 'alt' attribute to images and icons","user":{"login":"radinamatic","id":1457929,"avatar_url":"https://avatars.githubusercontent.com/u/1457929?v=3","gravatar_id":"","url":"https://api.github.com/users/radinamatic","html_url":"https://github.com/radinamatic","followers_url":"https://api.github.com/users/radinamatic/followers","following_url":"https://api.github.com/users/radinamatic/following{/other_user}","gists_url":"https://api.github.com/users/radinamatic/gists{/gist_id}","starred_url":"https://api.github.com/users/radinamatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radinamatic/subscriptions","organizations_url":"https://api.github.com/users/radinamatic/orgs","repos_url":"https://api.github.com/users/radinamatic/repos","events_url":"https://api.github.com/users/radinamatic/events{/privacy}","received_events_url":"https://api.github.com/users/radinamatic/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nEmpty 'alt' attribute for both thumbnail and icon on content card, with addition of `visuallyhidden` content that renders progress and content kind. \r\n\r\nWith the same logic svg folder icon is also rendered invisible with the empty `alt` in order to avoid constant repetition with each content group. The lazy solution would be to add `alt=\"folder\"`, but screen reader users do not have the option of visually ignoring purely presentational icon like sighted users, and will be forced to listen to SR output `grafic folder topic title 1` `grafic folder topic title 2` `grafic folder topic title 3` `grafic folder topic title 4`, etc... \r\n\r\n## TODO\r\n\r\n- [x] How do I exclude a `span` on final node of the breadcrumb? Is there a `v-if-not`? :stuck_out_tongue:\r\n- [x] Discuss the inclusion of `visuallyhidden` class into `core-global.styl`\r\n\r\n\r\n## Issues addressed\r\n\r\nAccessibility errors regarding the missing `alt` attributes. \r\n\r\n## Screenshots (if appropriate)\r\n\r\n![- kolibri - google chrome_544](https://cloud.githubusercontent.com/assets/1457929/16783657/3e4d2bf2-4885-11e6-84a2-4f5c4e3d185a.png)\r\n\r\n\r\n","created_at":"2016-07-12T21:12:23Z","updated_at":"2016-07-14T03:24:23Z","closed_at":"2016-07-14T03:24:23Z","merged_at":null,"merge_commit_sha":"0ad82c861b9c13d24677f44e532595e5b84ac6cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/244/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/244/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/244/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/b692099b6efdc40268f90bb46775d9409d598413","head":{"label":"radinamatic:img-thumb-alt","ref":"img-thumb-alt","sha":"b692099b6efdc40268f90bb46775d9409d598413","user":{"login":"radinamatic","id":1457929,"avatar_url":"https://avatars.githubusercontent.com/u/1457929?v=3","gravatar_id":"","url":"https://api.github.com/users/radinamatic","html_url":"https://github.com/radinamatic","followers_url":"https://api.github.com/users/radinamatic/followers","following_url":"https://api.github.com/users/radinamatic/following{/other_user}","gists_url":"https://api.github.com/users/radinamatic/gists{/gist_id}","starred_url":"https://api.github.com/users/radinamatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radinamatic/subscriptions","organizations_url":"https://api.github.com/users/radinamatic/orgs","repos_url":"https://api.github.com/users/radinamatic/repos","events_url":"https://api.github.com/users/radinamatic/events{/privacy}","received_events_url":"https://api.github.com/users/radinamatic/received_events","type":"User","site_admin":false},"repo":{"id":60271784,"name":"kolibri","full_name":"radinamatic/kolibri","owner":{"login":"radinamatic","id":1457929,"avatar_url":"https://avatars.githubusercontent.com/u/1457929?v=3","gravatar_id":"","url":"https://api.github.com/users/radinamatic","html_url":"https://github.com/radinamatic","followers_url":"https://api.github.com/users/radinamatic/followers","following_url":"https://api.github.com/users/radinamatic/following{/other_user}","gists_url":"https://api.github.com/users/radinamatic/gists{/gist_id}","starred_url":"https://api.github.com/users/radinamatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radinamatic/subscriptions","organizations_url":"https://api.github.com/users/radinamatic/orgs","repos_url":"https://api.github.com/users/radinamatic/repos","events_url":"https://api.github.com/users/radinamatic/events{/privacy}","received_events_url":"https://api.github.com/users/radinamatic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radinamatic/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/radinamatic/kolibri","forks_url":"https://api.github.com/repos/radinamatic/kolibri/forks","keys_url":"https://api.github.com/repos/radinamatic/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radinamatic/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radinamatic/kolibri/teams","hooks_url":"https://api.github.com/repos/radinamatic/kolibri/hooks","issue_events_url":"https://api.github.com/repos/radinamatic/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/radinamatic/kolibri/events","assignees_url":"https://api.github.com/repos/radinamatic/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/radinamatic/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/radinamatic/kolibri/tags","blobs_url":"https://api.github.com/repos/radinamatic/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radinamatic/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radinamatic/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/radinamatic/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radinamatic/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/radinamatic/kolibri/languages","stargazers_url":"https://api.github.com/repos/radinamatic/kolibri/stargazers","contributors_url":"https://api.github.com/repos/radinamatic/kolibri/contributors","subscribers_url":"https://api.github.com/repos/radinamatic/kolibri/subscribers","subscription_url":"https://api.github.com/repos/radinamatic/kolibri/subscription","commits_url":"https://api.github.com/repos/radinamatic/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/radinamatic/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/radinamatic/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/radinamatic/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/radinamatic/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/radinamatic/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radinamatic/kolibri/merges","archive_url":"https://api.github.com/repos/radinamatic/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radinamatic/kolibri/downloads","issues_url":"https://api.github.com/repos/radinamatic/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/radinamatic/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/radinamatic/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/radinamatic/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radinamatic/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/radinamatic/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/radinamatic/kolibri/deployments","created_at":"2016-06-02T14:40:52Z","updated_at":"2016-06-02T14:40:53Z","pushed_at":"2016-07-14T03:04:33Z","git_url":"git://github.com/radinamatic/kolibri.git","ssh_url":"git@github.com:radinamatic/kolibri.git","clone_url":"https://github.com/radinamatic/kolibri.git","svn_url":"https://github.com/radinamatic/kolibri","homepage":"http://learningequality.org/kolibri/","size":6182,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:master","ref":"master","sha":"19bf413854cb4b8fcf05131d211265c891f26fdc","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2016-07-13T10:40:18Z","pushed_at":"2016-07-14T03:21:46Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":6681,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":31,"forks":29,"open_issues":31,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/244"},"html":{"href":"https://github.com/learningequality/kolibri/pull/244"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/244"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/b692099b6efdc40268f90bb46775d9409d598413"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":3,"commits":2,"additions":19,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"indirectlylit"}}