{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/51941801","id":51941801,"diff_hunk":"@@ -89,7 +89,7 @@ public static ProtocolNegotiator serverPlaintext() {\n     return new ProtocolNegotiator() {\n       @Override\n       public Handler newHandler(final Http2ConnectionHandler handler) {\n-        return new Handler() {\n+        class PlaintextHandler extends ChannelDuplexHandler implements Handler {","path":"netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java","position":5,"original_position":5,"commit_id":"ef653306119834b51fd62b7d597e1d8945ca46ec","original_commit_id":"ef653306119834b51fd62b7d597e1d8945ca46ec","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"Handler is an interface, which most instances are of ChannelDuplexHandler.  Handler also has a scheme() method, so it can't return an anonymous class (can't both extend and implement).  I tried changing halnder over to ChannelInboundHandler, but then that messes up our instances.  ","created_at":"2016-02-04T21:39:13Z","updated_at":"2016-02-04T21:39:13Z","html_url":"https://github.com/grpc/grpc-java/pull/1390#discussion_r51941801","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1390","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/51941801"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1390#discussion_r51941801"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1390"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/1390","id":58349859,"html_url":"https://github.com/grpc/grpc-java/pull/1390","diff_url":"https://github.com/grpc/grpc-java/pull/1390.diff","patch_url":"https://github.com/grpc/grpc-java/pull/1390.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/1390","number":1390,"state":"open","locked":false,"title":"Remove deprecated call and TODO in Protocol negotiators","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-04T21:13:47Z","updated_at":"2016-02-04T21:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"476a794932d3b3a7144f3e80cd35b29c3f02aa36","assignee":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1390/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1390/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/1390/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/ef653306119834b51fd62b7d597e1d8945ca46ec","head":{"label":"carl-mastrangelo:dedeprecate","ref":"dedeprecate","sha":"ef653306119834b51fd62b7d597e1d8945ca46ec","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"repo":{"id":38781678,"name":"grpc-java","full_name":"carl-mastrangelo/grpc-java","owner":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carl-mastrangelo/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/carl-mastrangelo/grpc-java","forks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/forks","keys_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/teams","hooks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/events","assignees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/tags","blobs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/languages","stargazers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscription","commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/merges","archive_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/downloads","issues_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/deployments","created_at":"2015-07-08T21:45:19Z","updated_at":"2016-01-12T21:50:07Z","pushed_at":"2016-02-04T21:13:21Z","git_url":"git://github.com/carl-mastrangelo/grpc-java.git","ssh_url":"git@github.com:carl-mastrangelo/grpc-java.git","clone_url":"https://github.com/carl-mastrangelo/grpc-java.git","svn_url":"https://github.com/carl-mastrangelo/grpc-java","homepage":"","size":5182,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"e61e6c27ad91017f9d47e29cb38cffe1175d0946","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2016-02-04T07:48:09Z","pushed_at":"2016-02-04T21:13:47Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"http://grpc.io","size":20456,"stargazers_count":1127,"watchers_count":1127,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":289,"mirror_url":null,"open_issues_count":110,"forks":289,"open_issues":110,"watchers":1127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1390"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1390"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1390"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1390/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1390/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1390/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/ef653306119834b51fd62b7d597e1d8945ca46ec"}}}}