{"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments/49717420","id":49717420,"diff_hunk":"@@ -279,17 +331,37 @@ export default class {\n       if (!info.vdis[vdiUUID]) {\n         info.vdis[vdiUUID] = { ...vdi }\n         promises.push(\n-          this._rollingDeltaVdiBackup({vdi: vdiXo, path, depth}).then(\n-            ([ backupPath, backupFile ]) => {\n-              info.vdis[vdiUUID].xoPath = `${backupPath}/${backupFile}`\n-              return backupPath // Used by _removeOldDeltaVdiBackups\n+          this._deltaVdiBackup({vdi: vdiXo, path, depth}).then(\n+            async vdiBackup => {\n+              const { backupDirectory, vdiFilename } = vdiBackup\n+              info.vdis[vdiUUID].xoPath = `${backupDirectory}/${vdiFilename}`\n+\n+              return vdiBackup\n             }\n           )\n         )\n       }\n     }\n \n-    const vdiDirPaths = await Promise.all(promises)\n+    const vdiBackups = await pSettle(promises)\n+\n+    // One or many vdi backups have failed.\n+    const fulFilledVdiBackups = filter(vdiBackups, vdiBackup => vdiBackup.isFulfilled())\n+\n+    if (vdiBackups.length !== fulFilledVdiBackups.length) {\n+      await this._failedRollingDeltaVmBackup(xapi, path, fulFilledVdiBackups)\n+      throw new Error('Rolling delta vm backup failed.')\n+    }","path":"src/xo-mixins/backups.js","position":227,"original_position":227,"commit_id":"a7e62ddcea44e60e841c330d9d980962e283061d","original_commit_id":"a7e62ddcea44e60e841c330d9d980962e283061d","user":{"login":"julien-f","id":298721,"avatar_url":"https://avatars.githubusercontent.com/u/298721?v=3","gravatar_id":"","url":"https://api.github.com/users/julien-f","html_url":"https://github.com/julien-f","followers_url":"https://api.github.com/users/julien-f/followers","following_url":"https://api.github.com/users/julien-f/following{/other_user}","gists_url":"https://api.github.com/users/julien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/julien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien-f/subscriptions","organizations_url":"https://api.github.com/users/julien-f/orgs","repos_url":"https://api.github.com/users/julien-f/repos","events_url":"https://api.github.com/users/julien-f/events{/privacy}","received_events_url":"https://api.github.com/users/julien-f/received_events","type":"User","site_admin":false},"body":"Why not simply use a `try {} catch (e) {}` and a `await Promise.all(promise)`?","created_at":"2016-01-14T11:54:56Z","updated_at":"2016-01-14T11:54:56Z","html_url":"https://github.com/vatesfr/xo-server/pull/196#discussion_r49717420","pull_request_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments/49717420"},"html":{"href":"https://github.com/vatesfr/xo-server/pull/196#discussion_r49717420"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xo-server/pulls/196","id":56021955,"html_url":"https://github.com/vatesfr/xo-server/pull/196","diff_url":"https://github.com/vatesfr/xo-server/pull/196.diff","patch_url":"https://github.com/vatesfr/xo-server/pull/196.patch","issue_url":"https://api.github.com/repos/vatesfr/xo-server/issues/196","number":196,"state":"open","locked":false,"title":"Forever forward incremental backup (fix vatesfr/xo-web#576)","user":{"login":"Wescoeur","id":5610873,"avatar_url":"https://avatars.githubusercontent.com/u/5610873?v=3","gravatar_id":"","url":"https://api.github.com/users/Wescoeur","html_url":"https://github.com/Wescoeur","followers_url":"https://api.github.com/users/Wescoeur/followers","following_url":"https://api.github.com/users/Wescoeur/following{/other_user}","gists_url":"https://api.github.com/users/Wescoeur/gists{/gist_id}","starred_url":"https://api.github.com/users/Wescoeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wescoeur/subscriptions","organizations_url":"https://api.github.com/users/Wescoeur/orgs","repos_url":"https://api.github.com/users/Wescoeur/repos","events_url":"https://api.github.com/users/Wescoeur/events{/privacy}","received_events_url":"https://api.github.com/users/Wescoeur/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-14T11:17:23Z","updated_at":"2016-01-14T11:54:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6d6bf320ce9929cf7b946c7b09b35dd4fe1665a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/196/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/196/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/issues/196/comments","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/a7e62ddcea44e60e841c330d9d980962e283061d","head":{"label":"vatesfr:abhamonr-forever-forward-incremental-backup","ref":"abhamonr-forever-forward-incremental-backup","sha":"a7e62ddcea44e60e841c330d9d980962e283061d","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":7262203,"name":"xo-server","full_name":"vatesfr/xo-server","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-server","description":"Server part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-server","forks_url":"https://api.github.com/repos/vatesfr/xo-server/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-server/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-server/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-server/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-server/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-server/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-server/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-server/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-server/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-server/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-server/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-server/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-server/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-server/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-server/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-server/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-server/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-server/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-server/releases{/id}","created_at":"2012-12-20T18:23:37Z","updated_at":"2016-01-11T09:06:30Z","pushed_at":"2016-01-14T11:17:23Z","git_url":"git://github.com/vatesfr/xo-server.git","ssh_url":"git@github.com:vatesfr/xo-server.git","clone_url":"https://github.com/vatesfr/xo-server.git","svn_url":"https://github.com/vatesfr/xo-server","homepage":"","size":1872,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":47,"default_branch":"next-release"}},"base":{"label":"vatesfr:next-release","ref":"next-release","sha":"2b4ee96ed705e7002cb428fd9422a40160909dbb","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":7262203,"name":"xo-server","full_name":"vatesfr/xo-server","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-server","description":"Server part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-server","forks_url":"https://api.github.com/repos/vatesfr/xo-server/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-server/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-server/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-server/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-server/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-server/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-server/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-server/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-server/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-server/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-server/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-server/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-server/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-server/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-server/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-server/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-server/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-server/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-server/releases{/id}","created_at":"2012-12-20T18:23:37Z","updated_at":"2016-01-11T09:06:30Z","pushed_at":"2016-01-14T11:17:23Z","git_url":"git://github.com/vatesfr/xo-server.git","ssh_url":"git@github.com:vatesfr/xo-server.git","clone_url":"https://github.com/vatesfr/xo-server.git","svn_url":"https://github.com/vatesfr/xo-server","homepage":"","size":1872,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":47,"default_branch":"next-release"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/196"},"html":{"href":"https://github.com/vatesfr/xo-server/pull/196"},"issue":{"href":"https://api.github.com/repos/vatesfr/xo-server/issues/196"},"comments":{"href":"https://api.github.com/repos/vatesfr/xo-server/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xo-server/statuses/a7e62ddcea44e60e841c330d9d980962e283061d"}}}}