{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2360","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2360/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2360/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2360/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2360","id":125789884,"number":2360,"title":"Add PlayerArmorChangeEvent","user":{"login":"TheTemportalist","id":5315176,"avatar_url":"https://avatars.githubusercontent.com/u/5315176?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTemportalist","html_url":"https://github.com/TheTemportalist","followers_url":"https://api.github.com/users/TheTemportalist/followers","following_url":"https://api.github.com/users/TheTemportalist/following{/other_user}","gists_url":"https://api.github.com/users/TheTemportalist/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTemportalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTemportalist/subscriptions","organizations_url":"https://api.github.com/users/TheTemportalist/orgs","repos_url":"https://api.github.com/users/TheTemportalist/repos","events_url":"https://api.github.com/users/TheTemportalist/events{/privacy}","received_events_url":"https://api.github.com/users/TheTemportalist/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-10T00:13:22Z","updated_at":"2016-01-10T01:11:53Z","closed_at":"2016-01-10T01:11:52Z","pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2360","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2360","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2360.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2360.patch"},"body":"This event notifies listeners when the player's armor is changed, passing the old stack, new stack, and slot. It would be helpful for mod's whose armor has a special effect, but only does its effect when added to the inventory (like changing the player's health). The reason why this should be an event (as opposed to editing net.minecraftforge.common.ISpecialArmor) is because a mod could be implementing NBT effects on other armor items and has no control over those item classes, merely the NBT data of their stacks.\r\nFor some more context, Baubles provides this for its external equipment slots:\r\nhttps://github.com/Azanor/Baubles/blob/master/src/main/java/baubles/api/IBauble.java#L26-L34\r\nhttps://github.com/Azanor/Baubles/blob/6dc6951904f4bda090a9c3f78ddf010f066864c9/src/main/java/baubles/common/container/InventoryBaubles.java#L147-L153\r\n\r\nSee #2329, #2359"},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/170298875","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2360#issuecomment-170298875","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2360","id":170298875,"user":{"login":"TheTemportalist","id":5315176,"avatar_url":"https://avatars.githubusercontent.com/u/5315176?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTemportalist","html_url":"https://github.com/TheTemportalist","followers_url":"https://api.github.com/users/TheTemportalist/followers","following_url":"https://api.github.com/users/TheTemportalist/following{/other_user}","gists_url":"https://api.github.com/users/TheTemportalist/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTemportalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTemportalist/subscriptions","organizations_url":"https://api.github.com/users/TheTemportalist/orgs","repos_url":"https://api.github.com/users/TheTemportalist/repos","events_url":"https://api.github.com/users/TheTemportalist/events{/privacy}","received_events_url":"https://api.github.com/users/TheTemportalist/received_events","type":"User","site_admin":false},"created_at":"2016-01-10T01:11:52Z","updated_at":"2016-01-10T01:11:52Z","body":"Even as it is right now though, the event wont be fully functional because there are multiple places where it would need implementing in the InventoryPlayer. Im going to close the PR for now, because there is no great way to implement this."}}