{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/76330353","id":76330353,"diff_hunk":"@@ -620,6 +623,16 @@ class Main extends ImmutableComponent {\n     windowActions.setUrlBarActive(false)\n   }\n \n+  onFindHide () {\n+    const activeFrame = FrameStateUtil.getActiveFrame(this.props.windowState)\n+    windowActions.setFindbarShown(activeFrame, false)\n+    webviewActions.stopFindInPage()","path":"js/components/main.js","position":24,"original_position":24,"commit_id":"fc7767f198ebf06f1d0b9b54f0dca3b4bc2bd950","original_commit_id":"fc7767f198ebf06f1d0b9b54f0dca3b4bc2bd950","user":{"login":"bridiver","id":34129,"avatar_url":"https://avatars.githubusercontent.com/u/34129?v=3","gravatar_id":"","url":"https://api.github.com/users/bridiver","html_url":"https://github.com/bridiver","followers_url":"https://api.github.com/users/bridiver/followers","following_url":"https://api.github.com/users/bridiver/following{/other_user}","gists_url":"https://api.github.com/users/bridiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bridiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridiver/subscriptions","organizations_url":"https://api.github.com/users/bridiver/orgs","repos_url":"https://api.github.com/users/bridiver/repos","events_url":"https://api.github.com/users/bridiver/events{/privacy}","received_events_url":"https://api.github.com/users/bridiver/received_events","type":"User","site_admin":false},"body":"it doesn't remember the next position, that was the bug. I started a slack conversation to explain","created_at":"2016-08-25T21:42:09Z","updated_at":"2016-08-25T21:42:09Z","html_url":"https://github.com/brave/browser-laptop/pull/3315#discussion_r76330353","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/3315","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/76330353"},"html":{"href":"https://github.com/brave/browser-laptop/pull/3315#discussion_r76330353"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/3315"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/3315","id":82262223,"html_url":"https://github.com/brave/browser-laptop/pull/3315","diff_url":"https://github.com/brave/browser-laptop/pull/3315.diff","patch_url":"https://github.com/brave/browser-laptop/pull/3315.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/3315","number":3315,"state":"open","locked":false,"title":"Improved UI/UX of find bar","user":{"login":"jkup","id":490294,"avatar_url":"https://avatars.githubusercontent.com/u/490294?v=3","gravatar_id":"","url":"https://api.github.com/users/jkup","html_url":"https://github.com/jkup","followers_url":"https://api.github.com/users/jkup/followers","following_url":"https://api.github.com/users/jkup/following{/other_user}","gists_url":"https://api.github.com/users/jkup/gists{/gist_id}","starred_url":"https://api.github.com/users/jkup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkup/subscriptions","organizations_url":"https://api.github.com/users/jkup/orgs","repos_url":"https://api.github.com/users/jkup/repos","events_url":"https://api.github.com/users/jkup/events{/privacy}","received_events_url":"https://api.github.com/users/jkup/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Ran `git rebase -i` to squash commits if needed.\r\n\r\nFix #3159\r\n\r\nSorry, I got my git history in a really bad state. This is the same UI/UX PR as #3255 but I fixed the bugs outlined by @bbondy.\r\n\r\nThe last thing I know to need work is the design of the buttons when tab color is in effect. Screenshots posted below. @bradleyrichter can you give me a little feedback on the buttons?\r\n<img width=\"608\" alt=\"screen shot 2016-08-22 at 1 58 07 pm\" src=\"https://cloud.githubusercontent.com/assets/490294/17871463/815cdd24-6870-11e6-9f0b-52b6e049fc1b.png\">\r\n<img width=\"781\" alt=\"screen shot 2016-08-22 at 1 58 16 pm\" src=\"https://cloud.githubusercontent.com/assets/490294/17871466/855eb938-6870-11e6-91ae-f527b2a1715c.png\">\r\n\r\n\r\n","created_at":"2016-08-22T20:59:16Z","updated_at":"2016-08-25T21:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4495bb14a4fa4e9ef611aeb5a1c8a01694add5a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/3315/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/3315/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/3315/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/fc7767f198ebf06f1d0b9b54f0dca3b4bc2bd950","head":{"label":"brave:improve-findbar-ui-ux","ref":"improve-findbar-ui-ux","sha":"fc7767f198ebf06f1d0b9b54f0dca3b4bc2bd950","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-08-25T18:51:06Z","pushed_at":"2016-08-25T21:35:41Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":28345,"stargazers_count":3282,"watchers_count":3282,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":376,"mirror_url":null,"open_issues_count":957,"forks":376,"open_issues":957,"watchers":3282,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"911fcb14ef474448be4810010d9c7526c0123e49","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-08-25T18:51:06Z","pushed_at":"2016-08-25T21:35:41Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":28345,"stargazers_count":3282,"watchers_count":3282,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":376,"mirror_url":null,"open_issues_count":957,"forks":376,"open_issues":957,"watchers":3282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/3315"},"html":{"href":"https://github.com/brave/browser-laptop/pull/3315"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/3315"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/3315/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/3315/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/3315/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/fc7767f198ebf06f1d0b9b54f0dca3b4bc2bd950"}}}}
{"actor":{"display_login":"bridiver"}}