{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10","id":83058429,"html_url":"https://github.com/Fierydemise/ShadowCraft-Engine/pull/10","diff_url":"https://github.com/Fierydemise/ShadowCraft-Engine/pull/10.diff","patch_url":"https://github.com/Fierydemise/ShadowCraft-Engine/pull/10.patch","issue_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/10","number":10,"state":"closed","locked":false,"title":"Trinkets and neck enchants","user":{"login":"WaveFunctionP","id":6851336,"avatar_url":"https://avatars.githubusercontent.com/u/6851336?v=3","gravatar_id":"","url":"https://api.github.com/users/WaveFunctionP","html_url":"https://github.com/WaveFunctionP","followers_url":"https://api.github.com/users/WaveFunctionP/followers","following_url":"https://api.github.com/users/WaveFunctionP/following{/other_user}","gists_url":"https://api.github.com/users/WaveFunctionP/gists{/gist_id}","starred_url":"https://api.github.com/users/WaveFunctionP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WaveFunctionP/subscriptions","organizations_url":"https://api.github.com/users/WaveFunctionP/orgs","repos_url":"https://api.github.com/users/WaveFunctionP/repos","events_url":"https://api.github.com/users/WaveFunctionP/events{/privacy}","received_events_url":"https://api.github.com/users/WaveFunctionP/received_events","type":"User","site_admin":false},"body":"Done poorly.\r\n\r\nI verified the numbers I could, simplifed where possible, but quite few will need special handling. Many of the outputs are going to be non-sense, but afaik, no exceptions.\r\n\r\nI changed update_proc_value in procs to support raw damage values. IDK if that is correct, but the the alternative would be to pass a dict always and handle inside the class module, or disable scaling, and again pass into the class module, neither of which seemed proper.\r\n\r\nIf you want to do it another way, let me know.","created_at":"2016-08-29T07:54:56Z","updated_at":"2016-08-29T17:15:35Z","closed_at":"2016-08-29T17:15:35Z","merged_at":"2016-08-29T17:15:35Z","merge_commit_sha":"77b3c3761ea6b84de81d3d8334aadd8c131b837f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/10/comments","statuses_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/statuses/4c000b1b2c306f2290b6cb9f4bf1d82396c644d6","head":{"label":"WaveFunctionP:trinket","ref":"trinket","sha":"4c000b1b2c306f2290b6cb9f4bf1d82396c644d6","user":{"login":"WaveFunctionP","id":6851336,"avatar_url":"https://avatars.githubusercontent.com/u/6851336?v=3","gravatar_id":"","url":"https://api.github.com/users/WaveFunctionP","html_url":"https://github.com/WaveFunctionP","followers_url":"https://api.github.com/users/WaveFunctionP/followers","following_url":"https://api.github.com/users/WaveFunctionP/following{/other_user}","gists_url":"https://api.github.com/users/WaveFunctionP/gists{/gist_id}","starred_url":"https://api.github.com/users/WaveFunctionP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WaveFunctionP/subscriptions","organizations_url":"https://api.github.com/users/WaveFunctionP/orgs","repos_url":"https://api.github.com/users/WaveFunctionP/repos","events_url":"https://api.github.com/users/WaveFunctionP/events{/privacy}","received_events_url":"https://api.github.com/users/WaveFunctionP/received_events","type":"User","site_admin":false},"repo":{"id":65622052,"name":"ShadowCraft-Engine","full_name":"WaveFunctionP/ShadowCraft-Engine","owner":{"login":"WaveFunctionP","id":6851336,"avatar_url":"https://avatars.githubusercontent.com/u/6851336?v=3","gravatar_id":"","url":"https://api.github.com/users/WaveFunctionP","html_url":"https://github.com/WaveFunctionP","followers_url":"https://api.github.com/users/WaveFunctionP/followers","following_url":"https://api.github.com/users/WaveFunctionP/following{/other_user}","gists_url":"https://api.github.com/users/WaveFunctionP/gists{/gist_id}","starred_url":"https://api.github.com/users/WaveFunctionP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WaveFunctionP/subscriptions","organizations_url":"https://api.github.com/users/WaveFunctionP/orgs","repos_url":"https://api.github.com/users/WaveFunctionP/repos","events_url":"https://api.github.com/users/WaveFunctionP/events{/privacy}","received_events_url":"https://api.github.com/users/WaveFunctionP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WaveFunctionP/ShadowCraft-Engine","description":"Calculations backend for ShadowCraft, a WoW theorycraft project.","fork":true,"url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine","forks_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/forks","keys_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/teams","hooks_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/hooks","issue_events_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/events","assignees_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/tags","blobs_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/languages","stargazers_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/stargazers","contributors_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/contributors","subscribers_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/subscribers","subscription_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/subscription","commits_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/merges","archive_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/downloads","issues_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/labels{/name}","releases_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/WaveFunctionP/ShadowCraft-Engine/deployments","created_at":"2016-08-13T14:49:03Z","updated_at":"2016-08-13T14:49:06Z","pushed_at":"2016-08-29T07:45:09Z","git_url":"git://github.com/WaveFunctionP/ShadowCraft-Engine.git","ssh_url":"git@github.com:WaveFunctionP/ShadowCraft-Engine.git","clone_url":"https://github.com/WaveFunctionP/ShadowCraft-Engine.git","svn_url":"https://github.com/WaveFunctionP/ShadowCraft-Engine","homepage":"","size":2970,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fierydemise:legion","ref":"legion","sha":"eec630a7c151d863af7e3a650305336e0c0d4a83","user":{"login":"Fierydemise","id":1976961,"avatar_url":"https://avatars.githubusercontent.com/u/1976961?v=3","gravatar_id":"","url":"https://api.github.com/users/Fierydemise","html_url":"https://github.com/Fierydemise","followers_url":"https://api.github.com/users/Fierydemise/followers","following_url":"https://api.github.com/users/Fierydemise/following{/other_user}","gists_url":"https://api.github.com/users/Fierydemise/gists{/gist_id}","starred_url":"https://api.github.com/users/Fierydemise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fierydemise/subscriptions","organizations_url":"https://api.github.com/users/Fierydemise/orgs","repos_url":"https://api.github.com/users/Fierydemise/repos","events_url":"https://api.github.com/users/Fierydemise/events{/privacy}","received_events_url":"https://api.github.com/users/Fierydemise/received_events","type":"User","site_admin":false},"repo":{"id":23095107,"name":"ShadowCraft-Engine","full_name":"Fierydemise/ShadowCraft-Engine","owner":{"login":"Fierydemise","id":1976961,"avatar_url":"https://avatars.githubusercontent.com/u/1976961?v=3","gravatar_id":"","url":"https://api.github.com/users/Fierydemise","html_url":"https://github.com/Fierydemise","followers_url":"https://api.github.com/users/Fierydemise/followers","following_url":"https://api.github.com/users/Fierydemise/following{/other_user}","gists_url":"https://api.github.com/users/Fierydemise/gists{/gist_id}","starred_url":"https://api.github.com/users/Fierydemise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fierydemise/subscriptions","organizations_url":"https://api.github.com/users/Fierydemise/orgs","repos_url":"https://api.github.com/users/Fierydemise/repos","events_url":"https://api.github.com/users/Fierydemise/events{/privacy}","received_events_url":"https://api.github.com/users/Fierydemise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fierydemise/ShadowCraft-Engine","description":"Calculations backend for ShadowCraft, a WoW theorycraft project.","fork":true,"url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine","forks_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/forks","keys_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/teams","hooks_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/hooks","issue_events_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/events","assignees_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/tags","blobs_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/languages","stargazers_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/stargazers","contributors_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/contributors","subscribers_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/subscribers","subscription_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/subscription","commits_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/merges","archive_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/downloads","issues_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/labels{/name}","releases_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/deployments","created_at":"2014-08-19T03:11:40Z","updated_at":"2016-07-26T01:19:53Z","pushed_at":"2016-08-29T17:15:35Z","git_url":"git://github.com/Fierydemise/ShadowCraft-Engine.git","ssh_url":"git@github.com:Fierydemise/ShadowCraft-Engine.git","clone_url":"https://github.com/Fierydemise/ShadowCraft-Engine.git","svn_url":"https://github.com/Fierydemise/ShadowCraft-Engine","homepage":"","size":3011,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10"},"html":{"href":"https://github.com/Fierydemise/ShadowCraft-Engine/pull/10"},"issue":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/10"},"comments":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Fierydemise/ShadowCraft-Engine/statuses/4c000b1b2c306f2290b6cb9f4bf1d82396c644d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Fierydemise","id":1976961,"avatar_url":"https://avatars.githubusercontent.com/u/1976961?v=3","gravatar_id":"","url":"https://api.github.com/users/Fierydemise","html_url":"https://github.com/Fierydemise","followers_url":"https://api.github.com/users/Fierydemise/followers","following_url":"https://api.github.com/users/Fierydemise/following{/other_user}","gists_url":"https://api.github.com/users/Fierydemise/gists{/gist_id}","starred_url":"https://api.github.com/users/Fierydemise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fierydemise/subscriptions","organizations_url":"https://api.github.com/users/Fierydemise/orgs","repos_url":"https://api.github.com/users/Fierydemise/repos","events_url":"https://api.github.com/users/Fierydemise/events{/privacy}","received_events_url":"https://api.github.com/users/Fierydemise/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":413,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"Fierydemise"}}