{"action":"closed","issue":{"url":"https://api.github.com/repos/linkedin/ambry/issues/328","repository_url":"https://api.github.com/repos/linkedin/ambry","labels_url":"https://api.github.com/repos/linkedin/ambry/issues/328/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/328/comments","events_url":"https://api.github.com/repos/linkedin/ambry/issues/328/events","html_url":"https://github.com/linkedin/ambry/issues/328","id":156383735,"number":328,"title":"Selector poll does not return explicitly closed connections","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-23T22:48:15Z","updated_at":"2016-06-21T22:53:29Z","closed_at":"2016-06-21T22:53:29Z","body":"If a connection is explicitly closed using the `close(connid)` method, then the closed connection immediately gets added to `disconnected` list. This list is cleared at the start of every `poll()`. This means that an explicitly closed connection will not be returned as part of disconnections after a poll. This is unintuitive and incorrect.\r\n\r\nInstead, the selector should add these disconnections to a temporary list and use it to populate the `disconnected` list *during* a poll. Basically any additions to `connected`, `disconnected`, `completedSends` and `completedReceives` should happen as part of a poll."}}
{"actor":{"display_login":"nsivabalan"}}