{"action":"closed","number":2386,"pull_request":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386","id":89098164,"html_url":"https://github.com/Valloric/YouCompleteMe/pull/2386","diff_url":"https://github.com/Valloric/YouCompleteMe/pull/2386.diff","patch_url":"https://github.com/Valloric/YouCompleteMe/pull/2386.patch","issue_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2386","number":2386,"state":"closed","locked":false,"title":"[READY] Refactor tests using a YouCompleteMe instance","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"body":"This PR adds a decorator function, similar to the `IsolatedYcmd` and `SharedYcmd` decorators from ycmd, that passes a YouCompleteMe object to tests. Its options can be customized with the parameter of the decorator. I need this to write new tests.\r\n\r\nThere is one thing annoying with this change is that Vim does not highlight a decorator function with no character between the parentheses so `@YouCompleteMeInstance()` will not be highlighted. I've contacted the maintainer of the Python syntax file about this bug. Anyway, that's not a good reason to not make this change.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2386)\n<!-- Reviewable:end -->\n","created_at":"2016-10-12T21:32:42Z","updated_at":"2016-10-15T01:30:20Z","closed_at":"2016-10-15T01:30:20Z","merged_at":"2016-10-15T01:30:20Z","merge_commit_sha":"8d015c95ccf79e72d492c352e665c2230365d7c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386/commits","review_comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386/comments","review_comment_url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2386/comments","statuses_url":"https://api.github.com/repos/Valloric/YouCompleteMe/statuses/8d015c95ccf79e72d492c352e665c2230365d7c3","head":{"label":"micbou:refactor-tests","ref":"refactor-tests","sha":"8d015c95ccf79e72d492c352e665c2230365d7c3","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"repo":{"id":31660881,"name":"YouCompleteMe","full_name":"micbou/YouCompleteMe","owner":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micbou/YouCompleteMe","description":"A code-completion engine for Vim","fork":true,"url":"https://api.github.com/repos/micbou/YouCompleteMe","forks_url":"https://api.github.com/repos/micbou/YouCompleteMe/forks","keys_url":"https://api.github.com/repos/micbou/YouCompleteMe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micbou/YouCompleteMe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micbou/YouCompleteMe/teams","hooks_url":"https://api.github.com/repos/micbou/YouCompleteMe/hooks","issue_events_url":"https://api.github.com/repos/micbou/YouCompleteMe/issues/events{/number}","events_url":"https://api.github.com/repos/micbou/YouCompleteMe/events","assignees_url":"https://api.github.com/repos/micbou/YouCompleteMe/assignees{/user}","branches_url":"https://api.github.com/repos/micbou/YouCompleteMe/branches{/branch}","tags_url":"https://api.github.com/repos/micbou/YouCompleteMe/tags","blobs_url":"https://api.github.com/repos/micbou/YouCompleteMe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micbou/YouCompleteMe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micbou/YouCompleteMe/git/refs{/sha}","trees_url":"https://api.github.com/repos/micbou/YouCompleteMe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micbou/YouCompleteMe/statuses/{sha}","languages_url":"https://api.github.com/repos/micbou/YouCompleteMe/languages","stargazers_url":"https://api.github.com/repos/micbou/YouCompleteMe/stargazers","contributors_url":"https://api.github.com/repos/micbou/YouCompleteMe/contributors","subscribers_url":"https://api.github.com/repos/micbou/YouCompleteMe/subscribers","subscription_url":"https://api.github.com/repos/micbou/YouCompleteMe/subscription","commits_url":"https://api.github.com/repos/micbou/YouCompleteMe/commits{/sha}","git_commits_url":"https://api.github.com/repos/micbou/YouCompleteMe/git/commits{/sha}","comments_url":"https://api.github.com/repos/micbou/YouCompleteMe/comments{/number}","issue_comment_url":"https://api.github.com/repos/micbou/YouCompleteMe/issues/comments{/number}","contents_url":"https://api.github.com/repos/micbou/YouCompleteMe/contents/{+path}","compare_url":"https://api.github.com/repos/micbou/YouCompleteMe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micbou/YouCompleteMe/merges","archive_url":"https://api.github.com/repos/micbou/YouCompleteMe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micbou/YouCompleteMe/downloads","issues_url":"https://api.github.com/repos/micbou/YouCompleteMe/issues{/number}","pulls_url":"https://api.github.com/repos/micbou/YouCompleteMe/pulls{/number}","milestones_url":"https://api.github.com/repos/micbou/YouCompleteMe/milestones{/number}","notifications_url":"https://api.github.com/repos/micbou/YouCompleteMe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micbou/YouCompleteMe/labels{/name}","releases_url":"https://api.github.com/repos/micbou/YouCompleteMe/releases{/id}","deployments_url":"https://api.github.com/repos/micbou/YouCompleteMe/deployments","created_at":"2015-03-04T14:26:10Z","updated_at":"2016-01-27T22:14:56Z","pushed_at":"2016-10-14T09:31:07Z","git_url":"git://github.com/micbou/YouCompleteMe.git","ssh_url":"git@github.com:micbou/YouCompleteMe.git","clone_url":"https://github.com/micbou/YouCompleteMe.git","svn_url":"https://github.com/micbou/YouCompleteMe","homepage":"http://valloric.github.io/YouCompleteMe/","size":29740,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Valloric:master","ref":"master","sha":"5465bb08920e8c31869daaf3fdd948a1e5be06e9","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":4037197,"name":"YouCompleteMe","full_name":"Valloric/YouCompleteMe","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/YouCompleteMe","description":"A code-completion engine for Vim","fork":false,"url":"https://api.github.com/repos/Valloric/YouCompleteMe","forks_url":"https://api.github.com/repos/Valloric/YouCompleteMe/forks","keys_url":"https://api.github.com/repos/Valloric/YouCompleteMe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/YouCompleteMe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/YouCompleteMe/teams","hooks_url":"https://api.github.com/repos/Valloric/YouCompleteMe/hooks","issue_events_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/YouCompleteMe/events","assignees_url":"https://api.github.com/repos/Valloric/YouCompleteMe/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/YouCompleteMe/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/YouCompleteMe/tags","blobs_url":"https://api.github.com/repos/Valloric/YouCompleteMe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/YouCompleteMe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/YouCompleteMe/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/YouCompleteMe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/YouCompleteMe/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/YouCompleteMe/languages","stargazers_url":"https://api.github.com/repos/Valloric/YouCompleteMe/stargazers","contributors_url":"https://api.github.com/repos/Valloric/YouCompleteMe/contributors","subscribers_url":"https://api.github.com/repos/Valloric/YouCompleteMe/subscribers","subscription_url":"https://api.github.com/repos/Valloric/YouCompleteMe/subscription","commits_url":"https://api.github.com/repos/Valloric/YouCompleteMe/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/YouCompleteMe/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/YouCompleteMe/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/YouCompleteMe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/YouCompleteMe/merges","archive_url":"https://api.github.com/repos/Valloric/YouCompleteMe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/YouCompleteMe/downloads","issues_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/YouCompleteMe/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/YouCompleteMe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/YouCompleteMe/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/YouCompleteMe/releases{/id}","deployments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/deployments","created_at":"2012-04-16T03:12:14Z","updated_at":"2016-10-14T21:45:52Z","pushed_at":"2016-10-15T01:30:16Z","git_url":"git://github.com/Valloric/YouCompleteMe.git","ssh_url":"git@github.com:Valloric/YouCompleteMe.git","clone_url":"https://github.com/Valloric/YouCompleteMe.git","svn_url":"https://github.com/Valloric/YouCompleteMe","homepage":"http://valloric.github.io/YouCompleteMe/","size":32492,"stargazers_count":12024,"watchers_count":12024,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1405,"mirror_url":null,"open_issues_count":66,"forks":1405,"open_issues":66,"watchers":12024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386"},"html":{"href":"https://github.com/Valloric/YouCompleteMe/pull/2386"},"issue":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2386"},"comments":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2386/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2386/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/YouCompleteMe/statuses/8d015c95ccf79e72d492c352e665c2230365d7c3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"homu","id":10212162,"avatar_url":"https://avatars.githubusercontent.com/u/10212162?v=3","gravatar_id":"","url":"https://api.github.com/users/homu","html_url":"https://github.com/homu","followers_url":"https://api.github.com/users/homu/followers","following_url":"https://api.github.com/users/homu/following{/other_user}","gists_url":"https://api.github.com/users/homu/gists{/gist_id}","starred_url":"https://api.github.com/users/homu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homu/subscriptions","organizations_url":"https://api.github.com/users/homu/orgs","repos_url":"https://api.github.com/users/homu/repos","events_url":"https://api.github.com/users/homu/events{/privacy}","received_events_url":"https://api.github.com/users/homu/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":1257,"deletions":1279,"changed_files":6}}
{"actor":{"display_login":"homu"}}