{"action":"created","issue":{"url":"https://api.github.com/repos/sourcegraph/appdash/issues/97","labels_url":"https://api.github.com/repos/sourcegraph/appdash/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/issues/97/comments","events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/97/events","html_url":"https://github.com/sourcegraph/appdash/pull/97","id":126593773,"number":97,"title":"Added sort buttons on trace view","user":{"login":"evalphobia","id":2827521,"avatar_url":"https://avatars.githubusercontent.com/u/2827521?v=3","gravatar_id":"","url":"https://api.github.com/users/evalphobia","html_url":"https://github.com/evalphobia","followers_url":"https://api.github.com/users/evalphobia/followers","following_url":"https://api.github.com/users/evalphobia/following{/other_user}","gists_url":"https://api.github.com/users/evalphobia/gists{/gist_id}","starred_url":"https://api.github.com/users/evalphobia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evalphobia/subscriptions","organizations_url":"https://api.github.com/users/evalphobia/orgs","repos_url":"https://api.github.com/users/evalphobia/repos","events_url":"https://api.github.com/users/evalphobia/events{/privacy}","received_events_url":"https://api.github.com/users/evalphobia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-14T07:02:51Z","updated_at":"2016-01-21T19:22:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/97","html_url":"https://github.com/sourcegraph/appdash/pull/97","diff_url":"https://github.com/sourcegraph/appdash/pull/97.diff","patch_url":"https://github.com/sourcegraph/appdash/pull/97.patch"},"body":"This PR sort feature on trace view.\r\n\r\n1. sort order by `starting_time`\r\n2. sort order by `ending_time`\r\n3. sort order by `latency` (added new filed)\r\n4. sort order by `label` (alphabetically)\r\n\r\nEach sort is worked as `ascending order` first click and `descending order` by clicking same button.\r\n"},"comment":{"url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments/173681083","html_url":"https://github.com/sourcegraph/appdash/pull/97#issuecomment-173681083","issue_url":"https://api.github.com/repos/sourcegraph/appdash/issues/97","id":173681083,"user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T19:22:18Z","updated_at":"2016-01-21T19:22:18Z","body":"This looks really great!\r\n\r\nI left some comments inline, and let's change the wording slightly:\r\n\r\n- Rename `latency` to `duration` (we use `span duration` elsewhere in the code, so this is more accurate IMO).\r\n- Rename `alphabet` to `label` (because it's sorting by span label, this makes more sense / matches other UIs for sorting)\r\n\r\nApologies for the delay on reviewing this!"}}