{"action":"closed","number":6720,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6720","id":93249709,"html_url":"https://github.com/playframework/playframework/pull/6720","diff_url":"https://github.com/playframework/playframework/pull/6720.diff","patch_url":"https://github.com/playframework/playframework/pull/6720.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6720","number":6720,"state":"closed","locked":false,"title":"Fix documentation error (usage of noop setContentType)","user":{"login":"diamondo25","id":39577,"avatar_url":"https://avatars.githubusercontent.com/u/39577?v=3","gravatar_id":"","url":"https://api.github.com/users/diamondo25","html_url":"https://github.com/diamondo25","followers_url":"https://api.github.com/users/diamondo25/followers","following_url":"https://api.github.com/users/diamondo25/following{/other_user}","gists_url":"https://api.github.com/users/diamondo25/gists{/gist_id}","starred_url":"https://api.github.com/users/diamondo25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamondo25/subscriptions","organizations_url":"https://api.github.com/users/diamondo25/orgs","repos_url":"https://api.github.com/users/diamondo25/repos","events_url":"https://api.github.com/users/diamondo25/events{/privacy}","received_events_url":"https://api.github.com/users/diamondo25/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n\r\n* [ ] Have you read [How to write the perfect pull request](https://github.com/blog/1943-how-to-write-the-perfect-pull-request)?\r\n* [ ] Have you read through the [contributor guidelines](https://www.playframework.com/contributing)?\r\n* [x] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [ ] Have you [squashed your commits]? (Optional, but makes merge messages nicer.)\r\n* [ ] Have you added copyright headers to new files?\r\n* [ ] Have you checked that both Scala and Java APIs are updated?\r\n* [ ] Have you updated the documentation for both Scala and Java sections?\r\n* [ ] Have you added tests for any changed functionality?\r\n\r\n# Helpful things\r\n\r\n## Fixes\r\n\r\nFixes #6707\r\n\r\n## Purpose\r\n\r\nFixes a documentation error that made people use the noop `setContentType` of `play.mvc.Http.Response`\r\n\r\n## Background Context\r\n\r\nCleaning up an issue that had no real priority but gave backlog.\r\n\r\n## References\r\n\r\nhttps://github.com/playframework/playframework/issues/6707","created_at":"2016-11-10T23:08:52Z","updated_at":"2016-11-11T08:04:37Z","closed_at":"2016-11-11T08:04:37Z","merged_at":"2016-11-11T08:04:36Z","merge_commit_sha":"1996aa47204868e71374d9ae8df92938f6c327b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6720/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6720/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6720/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/f993468c28b69d8f62631bb055e2abf6c09cc35c","head":{"label":"diamondo25:patch-5","ref":"patch-5","sha":"f993468c28b69d8f62631bb055e2abf6c09cc35c","user":{"login":"diamondo25","id":39577,"avatar_url":"https://avatars.githubusercontent.com/u/39577?v=3","gravatar_id":"","url":"https://api.github.com/users/diamondo25","html_url":"https://github.com/diamondo25","followers_url":"https://api.github.com/users/diamondo25/followers","following_url":"https://api.github.com/users/diamondo25/following{/other_user}","gists_url":"https://api.github.com/users/diamondo25/gists{/gist_id}","starred_url":"https://api.github.com/users/diamondo25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamondo25/subscriptions","organizations_url":"https://api.github.com/users/diamondo25/orgs","repos_url":"https://api.github.com/users/diamondo25/repos","events_url":"https://api.github.com/users/diamondo25/events{/privacy}","received_events_url":"https://api.github.com/users/diamondo25/received_events","type":"User","site_admin":false},"repo":{"id":40883208,"name":"playframework","full_name":"diamondo25/playframework","owner":{"login":"diamondo25","id":39577,"avatar_url":"https://avatars.githubusercontent.com/u/39577?v=3","gravatar_id":"","url":"https://api.github.com/users/diamondo25","html_url":"https://github.com/diamondo25","followers_url":"https://api.github.com/users/diamondo25/followers","following_url":"https://api.github.com/users/diamondo25/following{/other_user}","gists_url":"https://api.github.com/users/diamondo25/gists{/gist_id}","starred_url":"https://api.github.com/users/diamondo25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamondo25/subscriptions","organizations_url":"https://api.github.com/users/diamondo25/orgs","repos_url":"https://api.github.com/users/diamondo25/repos","events_url":"https://api.github.com/users/diamondo25/events{/privacy}","received_events_url":"https://api.github.com/users/diamondo25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diamondo25/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/diamondo25/playframework","forks_url":"https://api.github.com/repos/diamondo25/playframework/forks","keys_url":"https://api.github.com/repos/diamondo25/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diamondo25/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diamondo25/playframework/teams","hooks_url":"https://api.github.com/repos/diamondo25/playframework/hooks","issue_events_url":"https://api.github.com/repos/diamondo25/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/diamondo25/playframework/events","assignees_url":"https://api.github.com/repos/diamondo25/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/diamondo25/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/diamondo25/playframework/tags","blobs_url":"https://api.github.com/repos/diamondo25/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diamondo25/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diamondo25/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/diamondo25/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diamondo25/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/diamondo25/playframework/languages","stargazers_url":"https://api.github.com/repos/diamondo25/playframework/stargazers","contributors_url":"https://api.github.com/repos/diamondo25/playframework/contributors","subscribers_url":"https://api.github.com/repos/diamondo25/playframework/subscribers","subscription_url":"https://api.github.com/repos/diamondo25/playframework/subscription","commits_url":"https://api.github.com/repos/diamondo25/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/diamondo25/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/diamondo25/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/diamondo25/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/diamondo25/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/diamondo25/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diamondo25/playframework/merges","archive_url":"https://api.github.com/repos/diamondo25/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diamondo25/playframework/downloads","issues_url":"https://api.github.com/repos/diamondo25/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/diamondo25/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/diamondo25/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/diamondo25/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diamondo25/playframework/labels{/name}","releases_url":"https://api.github.com/repos/diamondo25/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/diamondo25/playframework/deployments","created_at":"2015-08-17T09:52:02Z","updated_at":"2015-08-17T09:52:06Z","pushed_at":"2016-11-10T23:08:37Z","git_url":"git://github.com/diamondo25/playframework.git","ssh_url":"git@github.com:diamondo25/playframework.git","clone_url":"https://github.com/diamondo25/playframework.git","svn_url":"https://github.com/diamondo25/playframework","homepage":"http://www.playframework.com/","size":83614,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"07a1971d68e5085887b91e3f4dccf17fac8a0354","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-11-10T23:04:39Z","pushed_at":"2016-11-11T08:04:37Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":96553,"stargazers_count":8587,"watchers_count":8587,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2974,"mirror_url":null,"open_issues_count":272,"forks":2974,"open_issues":272,"watchers":8587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6720"},"html":{"href":"https://github.com/playframework/playframework/pull/6720"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6720"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6720/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6720/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6720/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/f993468c28b69d8f62631bb055e2abf6c09cc35c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"schmitch"}}