{"action":"created","issue":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/477","repository_url":"https://api.github.com/repos/Parsely/pykafka","labels_url":"https://api.github.com/repos/Parsely/pykafka/issues/477/labels{/name}","comments_url":"https://api.github.com/repos/Parsely/pykafka/issues/477/comments","events_url":"https://api.github.com/repos/Parsely/pykafka/issues/477/events","html_url":"https://github.com/Parsely/pykafka/pull/477","id":137165143,"number":477,"title":"ssl support","user":{"login":"yungchin","id":780001,"avatar_url":"https://avatars.githubusercontent.com/u/780001?v=3","gravatar_id":"","url":"https://api.github.com/users/yungchin","html_url":"https://github.com/yungchin","followers_url":"https://api.github.com/users/yungchin/followers","following_url":"https://api.github.com/users/yungchin/following{/other_user}","gists_url":"https://api.github.com/users/yungchin/gists{/gist_id}","starred_url":"https://api.github.com/users/yungchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungchin/subscriptions","organizations_url":"https://api.github.com/users/yungchin/orgs","repos_url":"https://api.github.com/users/yungchin/repos","events_url":"https://api.github.com/users/yungchin/events{/privacy}","received_events_url":"https://api.github.com/users/yungchin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Parsely/pykafka/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/Parsely/pykafka/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/Parsely/pykafka/labels/needs%20review","name":"needs review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"yungchin","id":780001,"avatar_url":"https://avatars.githubusercontent.com/u/780001?v=3","gravatar_id":"","url":"https://api.github.com/users/yungchin","html_url":"https://github.com/yungchin","followers_url":"https://api.github.com/users/yungchin/followers","following_url":"https://api.github.com/users/yungchin/following{/other_user}","gists_url":"https://api.github.com/users/yungchin/gists{/gist_id}","starred_url":"https://api.github.com/users/yungchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungchin/subscriptions","organizations_url":"https://api.github.com/users/yungchin/orgs","repos_url":"https://api.github.com/users/yungchin/repos","events_url":"https://api.github.com/users/yungchin/events{/privacy}","received_events_url":"https://api.github.com/users/yungchin/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-02-29T06:35:44Z","updated_at":"2016-04-29T23:34:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Parsely/pykafka/pulls/477","html_url":"https://github.com/Parsely/pykafka/pull/477","diff_url":"https://github.com/Parsely/pykafka/pull/477.diff","patch_url":"https://github.com/Parsely/pykafka/pull/477.patch"},"body":"This leverages the standard library's `ssl` module to wrap our `BrokerConnection` sockets, enabling TLS connections to Kafka. It's a work-in-progress:\r\n\r\n - [x] auto-generate certificates for use in test suite\r\n - [x] enable `KafkaInstance` SSL ports for testing (where possible)\r\n - [x] build successfully with librdkafka 0.9.x (see #445)\r\n - [x] insert necessary config for rdkafka-backed classes\r\n - [x] wrap `BrokerConnection` sockets\r\n - [x] decide a non-ugly `KafkaClient` init-signature that can support both the non-rdkafka and rdkafka-backed classes (this is the most difficult step in all)\r\n - [x] add connection examples to documentation\r\n - [x] add (suitably scoped) tests\r\n"},"comment":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/comments/215907664","html_url":"https://github.com/Parsely/pykafka/pull/477#issuecomment-215907664","issue_url":"https://api.github.com/repos/Parsely/pykafka/issues/477","id":215907664,"user":{"login":"yungchin","id":780001,"avatar_url":"https://avatars.githubusercontent.com/u/780001?v=3","gravatar_id":"","url":"https://api.github.com/users/yungchin","html_url":"https://github.com/yungchin","followers_url":"https://api.github.com/users/yungchin/followers","following_url":"https://api.github.com/users/yungchin/following{/other_user}","gists_url":"https://api.github.com/users/yungchin/gists{/gist_id}","starred_url":"https://api.github.com/users/yungchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungchin/subscriptions","organizations_url":"https://api.github.com/users/yungchin/orgs","repos_url":"https://api.github.com/users/yungchin/repos","events_url":"https://api.github.com/users/yungchin/events{/privacy}","received_events_url":"https://api.github.com/users/yungchin/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T23:34:08Z","updated_at":"2016-04-29T23:34:08Z","body":"Thanks for picking this up so promptly @emmett9001 - I think I've addressed everything except the fixme (which I'd forgotten about, thanks!). I'm not super-clear how to deal with that one quite yet. The connection errors aren't easy to identify as ssl-related..."}}