{"action":"created","comment":{"url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/comments/72532364","id":72532364,"diff_hunk":"@@ -44,7 +44,19 @@ func (key BlockAffinityKey) asEtcdKey() (string, error) {\n }\n \n func (key BlockAffinityKey) asEtcdDeleteKey() (string, error) {\n-\treturn key.asEtcdKey()\n+\t// Must specify at least a host to remove.\n+\tif key.Host == \"\" {\n+\t\treturn \"\", common.ErrorInsufficientIdentifiers{}\n+\t}\n+\tk := \"/calico/ipam/v2/host/\" + key.Host","path":"lib/backend/block_affinity.go","position":20,"original_position":9,"commit_id":"40ddd1db466f6b902c5a045100eaaeb035b5e4f3","original_commit_id":"b399aaba6a4e3b391e4f73215bcc0f7a84ec119d","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"w.r.t WorkloadEndpoint - Tom, Alex and I were just discussing.  Let's chat about it.","created_at":"2016-07-27T22:00:28Z","updated_at":"2016-07-27T22:00:28Z","html_url":"https://github.com/caseydavenport/libcalico-go/pull/1#discussion_r72532364","pull_request_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/comments/72532364"},"html":{"href":"https://github.com/caseydavenport/libcalico-go/pull/1#discussion_r72532364"},"pull_request":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1","id":79060262,"html_url":"https://github.com/caseydavenport/libcalico-go/pull/1","diff_url":"https://github.com/caseydavenport/libcalico-go/pull/1.diff","patch_url":"https://github.com/caseydavenport/libcalico-go/pull/1.patch","issue_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/1","number":1,"state":"open","locked":false,"title":"RemoveIPAMHost implementation","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"Includes a few fixes each in its own commit:\r\n- RemoveIPAMHost implementation\r\n- Minimize datastore writes when releasing IP address","created_at":"2016-07-27T16:59:07Z","updated_at":"2016-07-27T22:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe6ff17e9ba860447c0d393f347d2d7559060455","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1/commits","review_comments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1/comments","review_comment_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/1/comments","statuses_url":"https://api.github.com/repos/caseydavenport/libcalico-go/statuses/40ddd1db466f6b902c5a045100eaaeb035b5e4f3","head":{"label":"caseydavenport:remove_ipam_host","ref":"remove_ipam_host","sha":"40ddd1db466f6b902c5a045100eaaeb035b5e4f3","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"repo":{"id":63621502,"name":"libcalico-go","full_name":"caseydavenport/libcalico-go","owner":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseydavenport/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":true,"url":"https://api.github.com/repos/caseydavenport/libcalico-go","forks_url":"https://api.github.com/repos/caseydavenport/libcalico-go/forks","keys_url":"https://api.github.com/repos/caseydavenport/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseydavenport/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseydavenport/libcalico-go/teams","hooks_url":"https://api.github.com/repos/caseydavenport/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/caseydavenport/libcalico-go/events","assignees_url":"https://api.github.com/repos/caseydavenport/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/caseydavenport/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/caseydavenport/libcalico-go/tags","blobs_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseydavenport/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/caseydavenport/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/caseydavenport/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/caseydavenport/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/caseydavenport/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/caseydavenport/libcalico-go/subscription","commits_url":"https://api.github.com/repos/caseydavenport/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseydavenport/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/caseydavenport/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseydavenport/libcalico-go/merges","archive_url":"https://api.github.com/repos/caseydavenport/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseydavenport/libcalico-go/downloads","issues_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/caseydavenport/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/caseydavenport/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseydavenport/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/caseydavenport/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/deployments","created_at":"2016-07-18T17:02:22Z","updated_at":"2016-07-18T17:02:23Z","pushed_at":"2016-07-27T21:58:27Z","git_url":"git://github.com/caseydavenport/libcalico-go.git","ssh_url":"git@github.com:caseydavenport/libcalico-go.git","clone_url":"https://github.com/caseydavenport/libcalico-go.git","svn_url":"https://github.com/caseydavenport/libcalico-go","homepage":null,"size":266,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"caseydavenport:fix-ipam-todos","ref":"fix-ipam-todos","sha":"13437ef7fcbf1e958b727ab54ce4d570c31b58e0","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"repo":{"id":63621502,"name":"libcalico-go","full_name":"caseydavenport/libcalico-go","owner":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseydavenport/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":true,"url":"https://api.github.com/repos/caseydavenport/libcalico-go","forks_url":"https://api.github.com/repos/caseydavenport/libcalico-go/forks","keys_url":"https://api.github.com/repos/caseydavenport/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseydavenport/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseydavenport/libcalico-go/teams","hooks_url":"https://api.github.com/repos/caseydavenport/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/caseydavenport/libcalico-go/events","assignees_url":"https://api.github.com/repos/caseydavenport/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/caseydavenport/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/caseydavenport/libcalico-go/tags","blobs_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseydavenport/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/caseydavenport/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/caseydavenport/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/caseydavenport/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/caseydavenport/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/caseydavenport/libcalico-go/subscription","commits_url":"https://api.github.com/repos/caseydavenport/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseydavenport/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseydavenport/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/caseydavenport/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseydavenport/libcalico-go/merges","archive_url":"https://api.github.com/repos/caseydavenport/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseydavenport/libcalico-go/downloads","issues_url":"https://api.github.com/repos/caseydavenport/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/caseydavenport/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/caseydavenport/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseydavenport/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/caseydavenport/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/caseydavenport/libcalico-go/deployments","created_at":"2016-07-18T17:02:22Z","updated_at":"2016-07-18T17:02:23Z","pushed_at":"2016-07-27T21:58:27Z","git_url":"git://github.com/caseydavenport/libcalico-go.git","ssh_url":"git@github.com:caseydavenport/libcalico-go.git","clone_url":"https://github.com/caseydavenport/libcalico-go.git","svn_url":"https://github.com/caseydavenport/libcalico-go","homepage":null,"size":266,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1"},"html":{"href":"https://github.com/caseydavenport/libcalico-go/pull/1"},"issue":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/1"},"comments":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/caseydavenport/libcalico-go/statuses/40ddd1db466f6b902c5a045100eaaeb035b5e4f3"}}}}
{"actor":{"display_login":"caseydavenport"}}