{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1116","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1116/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1116/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1116/events","html_url":"https://github.com/ReactiveX/RxJS/pull/1116","id":124317658,"number":1116,"title":"refactor(subscriber): Make Subscriber and derived classes' internal methods protected","user":{"login":"saneyuki","id":180104,"avatar_url":"https://avatars.githubusercontent.com/u/180104?v=3","gravatar_id":"","url":"https://api.github.com/users/saneyuki","html_url":"https://github.com/saneyuki","followers_url":"https://api.github.com/users/saneyuki/followers","following_url":"https://api.github.com/users/saneyuki/following{/other_user}","gists_url":"https://api.github.com/users/saneyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/saneyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneyuki/subscriptions","organizations_url":"https://api.github.com/users/saneyuki/orgs","repos_url":"https://api.github.com/users/saneyuki/repos","events_url":"https://api.github.com/users/saneyuki/events{/privacy}","received_events_url":"https://api.github.com/users/saneyuki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-30T08:08:02Z","updated_at":"2016-01-11T03:21:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1116","html_url":"https://github.com/ReactiveX/RxJS/pull/1116","diff_url":"https://github.com/ReactiveX/RxJS/pull/1116.diff","patch_url":"https://github.com/ReactiveX/RxJS/pull/1116.patch"},"body":"This change make these members `protected`:\r\n\r\n- `Subscriber._next()`\r\n- `Subscriber._error()`\r\n- `Subscriber._complete()`\r\n\r\nAt current codebase, these members is only used in drived class of\r\n`Subscriber` or itself. Thus we should hide them from public.\r\n(If we need to make them public, then we should make them so).\r\n\r\n## Exception\r\n- `WindowSubscriber`'s members are used from\r\n  `WindowClosingNotifierSubscriber`. So `WindowSubscriber`'s members are\r\n  not `protected`.\r\n    - These classes are a private class of `window.ts` modules.\r\n    - I think this exception would not be a serious problem."},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments/170422815","html_url":"https://github.com/ReactiveX/RxJS/pull/1116#issuecomment-170422815","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1116","id":170422815,"user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T03:21:55Z","updated_at":"2016-01-11T03:21:55Z","body":"No hurries at all, just checking :)"}}