{"action":"created","comment":{"url":"https://api.github.com/repos/lxde/liblxqt/pulls/comments/61048736","id":61048736,"diff_hunk":"@@ -102,12 +103,14 @@ QSize PageSelectWidget::sizeHint() const\n     int w = 0;\n     for(int i=0; i< count(); ++i)\n     {\n-        QRect rect = fontMetrics().boundingRect(QRect(), Qt::AlignLeft | Qt::TextWordWrap, item(i)->text());\n+        QRect rect = fontMetrics().boundingRect(QRect(), Qt::AlignHCenter | Qt::TextWordWrap, item(i)->text());\n         w = qMax(w, rect.width());\n     }\n+    // consider the icon size too\n+    w = qMax(w, QApplication::style()->pixelMetric(QStyle::PM_IconViewIconSize));","path":"configdialog/lxqtpageselectwidget.cpp","position":17,"original_position":17,"commit_id":"9e3ed69af41ec50d9008a52a59a6deeac1925aa3","original_commit_id":"9e3ed69af41ec50d9008a52a59a6deeac1925aa3","user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars.githubusercontent.com/u/981076?v=3","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"body":"Please see `qcommonstyle.cpp` → `QCommonStyle::pixelMetric` → `case PM_ScrollBarExtent:`! `widget` has no part in it.","created_at":"2016-04-26T08:46:35Z","updated_at":"2016-04-26T08:46:35Z","html_url":"https://github.com/lxde/liblxqt/pull/83#discussion_r61048736","pull_request_url":"https://api.github.com/repos/lxde/liblxqt/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/comments/61048736"},"html":{"href":"https://github.com/lxde/liblxqt/pull/83#discussion_r61048736"},"pull_request":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/lxde/liblxqt/pulls/83","id":61669555,"html_url":"https://github.com/lxde/liblxqt/pull/83","diff_url":"https://github.com/lxde/liblxqt/pull/83.diff","patch_url":"https://github.com/lxde/liblxqt/pull/83.patch","issue_url":"https://api.github.com/repos/lxde/liblxqt/issues/83","number":83,"state":"closed","locked":false,"title":"A few size corrections.","user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars.githubusercontent.com/u/981076?v=3","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-04T05:38:57Z","updated_at":"2016-04-26T08:46:35Z","closed_at":"2016-04-25T23:26:52Z","merged_at":"2016-04-25T23:26:52Z","merge_commit_sha":"b4372f25dc61285d4638f6616d64791352d52ef8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxde/liblxqt/pulls/83/commits","review_comments_url":"https://api.github.com/repos/lxde/liblxqt/pulls/83/comments","review_comment_url":"https://api.github.com/repos/lxde/liblxqt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxde/liblxqt/issues/83/comments","statuses_url":"https://api.github.com/repos/lxde/liblxqt/statuses/9e3ed69af41ec50d9008a52a59a6deeac1925aa3","head":{"label":"lxde:size_corrections","ref":"size_corrections","sha":"9e3ed69af41ec50d9008a52a59a6deeac1925aa3","user":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"repo":{"id":11924937,"name":"liblxqt","full_name":"lxde/liblxqt","owner":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxde/liblxqt","description":"Core utility library for all LXQt components","fork":false,"url":"https://api.github.com/repos/lxde/liblxqt","forks_url":"https://api.github.com/repos/lxde/liblxqt/forks","keys_url":"https://api.github.com/repos/lxde/liblxqt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxde/liblxqt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxde/liblxqt/teams","hooks_url":"https://api.github.com/repos/lxde/liblxqt/hooks","issue_events_url":"https://api.github.com/repos/lxde/liblxqt/issues/events{/number}","events_url":"https://api.github.com/repos/lxde/liblxqt/events","assignees_url":"https://api.github.com/repos/lxde/liblxqt/assignees{/user}","branches_url":"https://api.github.com/repos/lxde/liblxqt/branches{/branch}","tags_url":"https://api.github.com/repos/lxde/liblxqt/tags","blobs_url":"https://api.github.com/repos/lxde/liblxqt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxde/liblxqt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxde/liblxqt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxde/liblxqt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxde/liblxqt/statuses/{sha}","languages_url":"https://api.github.com/repos/lxde/liblxqt/languages","stargazers_url":"https://api.github.com/repos/lxde/liblxqt/stargazers","contributors_url":"https://api.github.com/repos/lxde/liblxqt/contributors","subscribers_url":"https://api.github.com/repos/lxde/liblxqt/subscribers","subscription_url":"https://api.github.com/repos/lxde/liblxqt/subscription","commits_url":"https://api.github.com/repos/lxde/liblxqt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxde/liblxqt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxde/liblxqt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxde/liblxqt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxde/liblxqt/contents/{+path}","compare_url":"https://api.github.com/repos/lxde/liblxqt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxde/liblxqt/merges","archive_url":"https://api.github.com/repos/lxde/liblxqt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxde/liblxqt/downloads","issues_url":"https://api.github.com/repos/lxde/liblxqt/issues{/number}","pulls_url":"https://api.github.com/repos/lxde/liblxqt/pulls{/number}","milestones_url":"https://api.github.com/repos/lxde/liblxqt/milestones{/number}","notifications_url":"https://api.github.com/repos/lxde/liblxqt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxde/liblxqt/labels{/name}","releases_url":"https://api.github.com/repos/lxde/liblxqt/releases{/id}","deployments_url":"https://api.github.com/repos/lxde/liblxqt/deployments","created_at":"2013-08-06T13:39:51Z","updated_at":"2016-04-17T15:22:12Z","pushed_at":"2016-04-25T23:26:52Z","git_url":"git://github.com/lxde/liblxqt.git","ssh_url":"git@github.com:lxde/liblxqt.git","clone_url":"https://github.com/lxde/liblxqt.git","svn_url":"https://github.com/lxde/liblxqt","homepage":"http://lxqt.org","size":1104,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":5,"forks":26,"open_issues":5,"watchers":15,"default_branch":"master"}},"base":{"label":"lxde:master","ref":"master","sha":"1e5dbbc5be2e1ac5adda335075e53b875f5ac7f9","user":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"repo":{"id":11924937,"name":"liblxqt","full_name":"lxde/liblxqt","owner":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxde/liblxqt","description":"Core utility library for all LXQt components","fork":false,"url":"https://api.github.com/repos/lxde/liblxqt","forks_url":"https://api.github.com/repos/lxde/liblxqt/forks","keys_url":"https://api.github.com/repos/lxde/liblxqt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxde/liblxqt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxde/liblxqt/teams","hooks_url":"https://api.github.com/repos/lxde/liblxqt/hooks","issue_events_url":"https://api.github.com/repos/lxde/liblxqt/issues/events{/number}","events_url":"https://api.github.com/repos/lxde/liblxqt/events","assignees_url":"https://api.github.com/repos/lxde/liblxqt/assignees{/user}","branches_url":"https://api.github.com/repos/lxde/liblxqt/branches{/branch}","tags_url":"https://api.github.com/repos/lxde/liblxqt/tags","blobs_url":"https://api.github.com/repos/lxde/liblxqt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxde/liblxqt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxde/liblxqt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxde/liblxqt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxde/liblxqt/statuses/{sha}","languages_url":"https://api.github.com/repos/lxde/liblxqt/languages","stargazers_url":"https://api.github.com/repos/lxde/liblxqt/stargazers","contributors_url":"https://api.github.com/repos/lxde/liblxqt/contributors","subscribers_url":"https://api.github.com/repos/lxde/liblxqt/subscribers","subscription_url":"https://api.github.com/repos/lxde/liblxqt/subscription","commits_url":"https://api.github.com/repos/lxde/liblxqt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxde/liblxqt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxde/liblxqt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxde/liblxqt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxde/liblxqt/contents/{+path}","compare_url":"https://api.github.com/repos/lxde/liblxqt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxde/liblxqt/merges","archive_url":"https://api.github.com/repos/lxde/liblxqt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxde/liblxqt/downloads","issues_url":"https://api.github.com/repos/lxde/liblxqt/issues{/number}","pulls_url":"https://api.github.com/repos/lxde/liblxqt/pulls{/number}","milestones_url":"https://api.github.com/repos/lxde/liblxqt/milestones{/number}","notifications_url":"https://api.github.com/repos/lxde/liblxqt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxde/liblxqt/labels{/name}","releases_url":"https://api.github.com/repos/lxde/liblxqt/releases{/id}","deployments_url":"https://api.github.com/repos/lxde/liblxqt/deployments","created_at":"2013-08-06T13:39:51Z","updated_at":"2016-04-17T15:22:12Z","pushed_at":"2016-04-25T23:26:52Z","git_url":"git://github.com/lxde/liblxqt.git","ssh_url":"git@github.com:lxde/liblxqt.git","clone_url":"https://github.com/lxde/liblxqt.git","svn_url":"https://github.com/lxde/liblxqt","homepage":"http://lxqt.org","size":1104,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":5,"forks":26,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/83"},"html":{"href":"https://github.com/lxde/liblxqt/pull/83"},"issue":{"href":"https://api.github.com/repos/lxde/liblxqt/issues/83"},"comments":{"href":"https://api.github.com/repos/lxde/liblxqt/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxde/liblxqt/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/lxde/liblxqt/statuses/9e3ed69af41ec50d9008a52a59a6deeac1925aa3"}}}}