{"action":"created","issue":{"url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/104","repository_url":"https://api.github.com/repos/cloudinary/cloudinary_js","labels_url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/104/comments","events_url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/104/events","html_url":"https://github.com/cloudinary/cloudinary_js/issues/104","id":184029956,"number":104,"title":"broken dependency `blueimp-file-upload` when using bower/amd","user":{"login":"bestrada","id":221388,"avatar_url":"https://avatars.githubusercontent.com/u/221388?v=3","gravatar_id":"","url":"https://api.github.com/users/bestrada","html_url":"https://github.com/bestrada","followers_url":"https://api.github.com/users/bestrada/followers","following_url":"https://api.github.com/users/bestrada/following{/other_user}","gists_url":"https://api.github.com/users/bestrada/gists{/gist_id}","starred_url":"https://api.github.com/users/bestrada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestrada/subscriptions","organizations_url":"https://api.github.com/users/bestrada/orgs","repos_url":"https://api.github.com/users/bestrada/repos","events_url":"https://api.github.com/users/bestrada/events{/privacy}","received_events_url":"https://api.github.com/users/bestrada/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-19T17:48:37Z","updated_at":"2016-10-20T16:34:40Z","closed_at":null,"body":"https://github.com/cloudinary/cloudinary_js/blob/6a8f2dbf6463ac00892e9e13679935ec3b76a59c/bower.json#L48\r\n\r\nthis dependency made some breaking changes in `9.12.6` which was released 10/17/2016. the jquery-ui folks updated the AMD module naming convention, but it looks like your library has hard-coded against the old naming convention.\r\n\r\nhttps://github.com/blueimp/jQuery-File-Upload/commit/a9bfde1cfe7c5295b3757a28fbffe06087701749\r\n\r\nyou should either change the dependency to be max `9.12.5` or otherwise somehow fix this dependency."},"comment":{"url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/comments/255158784","html_url":"https://github.com/cloudinary/cloudinary_js/issues/104#issuecomment-255158784","issue_url":"https://api.github.com/repos/cloudinary/cloudinary_js/issues/104","id":255158784,"user":{"login":"tocker","id":346642,"avatar_url":"https://avatars.githubusercontent.com/u/346642?v=3","gravatar_id":"","url":"https://api.github.com/users/tocker","html_url":"https://github.com/tocker","followers_url":"https://api.github.com/users/tocker/followers","following_url":"https://api.github.com/users/tocker/following{/other_user}","gists_url":"https://api.github.com/users/tocker/gists{/gist_id}","starred_url":"https://api.github.com/users/tocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocker/subscriptions","organizations_url":"https://api.github.com/users/tocker/orgs","repos_url":"https://api.github.com/users/tocker/repos","events_url":"https://api.github.com/users/tocker/events{/privacy}","received_events_url":"https://api.github.com/users/tocker/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T16:34:39Z","updated_at":"2016-10-20T16:34:39Z","body":"Hi @bestrada,\r\n\r\nThanks for catching this!\r\nWe will change our sources to reflect this change.\r\n\r\nPlease note that while the dependency has changed in Blueimp, there are a few issues to consider:\r\n\r\n1. The recommendation on the [jQuery documentation](https://learn.jquery.com/jquery-ui/environments/amd/) that led to the change requires a _particular file structure_ that may not conform to all websites. Specifically, it differs greatly from the bower installation.\r\n2. The `cloudinary_js` is the source repository for the Cloudinary JavaScript libraries. You should use the distribution pakcage [`cloudinary-jquery-file-upload`](https://bower.io/search/?q=cloudinary-jquery-file-upload) instead. In that library we removed the `jquery-ui` dependency.\r\n3. The Blueimp distribution includes the jQuery UI widget, so you can include it directly without installing the full jQuery UI library.\r\n\r\nWhen using **bower** or **npm** as a package manager we recommend configuring requirejs rather then moving the sources to a new folder structure. See our [test file](https://github.com/cloudinary/cloudinary_js/blob/6a8f2dbf6463ac00892e9e13679935ec3b76a59c/test/docRoot/amd.html#L23-L32) as an example:\r\n\r\n```javascript\r\nrequirejs.config({\r\n    baseUrl: 'bower_components',\r\n    paths: {\r\n        'jquery': 'jquery/dist/jquery.min',\r\n        'jquery-ui/widget': 'blueimp-file-upload/js/vendor/jquery.ui.widget',\r\n        'jquery.iframe-transport': 'blueimp-file-upload/js/jquery.iframe-transport',\r\n        'jquery.fileupload': 'blueimp-file-upload/js/jquery.fileupload'\r\n    }\r\n});\r\n```\r\n(Notice that the `jquery-ui/widget` entry above is not included yet in our source and will be fixed.)\r\n\r\nIf you prefer to use the widget from jquery-ui bower distribution, modify the above configuration to include:\r\n\r\n```javascript\r\n  'jquery-ui/widget': 'jquery-ui/ui/widget'\r\n```"}}
{"actor":{"display_login":"tocker"}}