{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/comments/81149837","pull_request_review_id":2150646,"id":81149837,"diff_hunk":"@@ -406,15 +409,24 @@ def update(self):\n             # you are not allowed to change it.\n             try:\n                 address = IPNetwork(current['address'])\n-\n                 new_addr = \"%s/%s\" % (address.ip, netmask)\n                 nipnet = IPNetwork(new_addr)\n+                # edited by manuadoor for rd feature\n+                if rd is not None:\n+                    nipnet = \"%s%s%s\" % (address.ip, rd, netmask)\n \n                 cur_addr = \"%s/%s\" % (current['address'], current['netmask'])\n                 cipnet = IPNetwork(cur_addr)\n+                # edited by manuadoor for rd feature\n+                if rd is not None:\n+                    cipnet = \"%s%s%s\" % (current['address'], current['rd'], current['netmask'])\n \n                 if nipnet != cipnet:\n-                    address = \"%s/%s\" % (nipnet.ip, nipnet.prefixlen)\n+                    # edited by manuadoor for rd feature","path":"library/bigip_selfip.py","position":null,"original_position":165,"commit_id":"0bbfe090f972b9e9e7ee96193ec08c8ad77df65d","original_commit_id":"e584ebe95da0f4ab669cc0fa8190662c5ed18069","user":{"login":"manuadoor","id":20935309,"avatar_url":"https://avatars.githubusercontent.com/u/20935309?v=3","gravatar_id":"","url":"https://api.github.com/users/manuadoor","html_url":"https://github.com/manuadoor","followers_url":"https://api.github.com/users/manuadoor/followers","following_url":"https://api.github.com/users/manuadoor/following{/other_user}","gists_url":"https://api.github.com/users/manuadoor/gists{/gist_id}","starred_url":"https://api.github.com/users/manuadoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuadoor/subscriptions","organizations_url":"https://api.github.com/users/manuadoor/orgs","repos_url":"https://api.github.com/users/manuadoor/repos","events_url":"https://api.github.com/users/manuadoor/events{/privacy}","received_events_url":"https://api.github.com/users/manuadoor/received_events","type":"User","site_admin":false},"body":"Done..","created_at":"2016-09-29T14:30:27Z","updated_at":"2016-09-29T14:30:27Z","html_url":"https://github.com/F5Networks/f5-ansible/pull/33#discussion_r81149837","pull_request_url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/comments/81149837"},"html":{"href":"https://github.com/F5Networks/f5-ansible/pull/33#discussion_r81149837"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33","id":87131669,"html_url":"https://github.com/F5Networks/f5-ansible/pull/33","diff_url":"https://github.com/F5Networks/f5-ansible/pull/33.diff","patch_url":"https://github.com/F5Networks/f5-ansible/pull/33.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-ansible/issues/33","number":33,"state":"open","locked":false,"title":"Adding rd Functionality","user":{"login":"manuadoor","id":20935309,"avatar_url":"https://avatars.githubusercontent.com/u/20935309?v=3","gravatar_id":"","url":"https://api.github.com/users/manuadoor","html_url":"https://github.com/manuadoor","followers_url":"https://api.github.com/users/manuadoor/followers","following_url":"https://api.github.com/users/manuadoor/following{/other_user}","gists_url":"https://api.github.com/users/manuadoor/gists{/gist_id}","starred_url":"https://api.github.com/users/manuadoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuadoor/subscriptions","organizations_url":"https://api.github.com/users/manuadoor/orgs","repos_url":"https://api.github.com/users/manuadoor/repos","events_url":"https://api.github.com/users/manuadoor/events{/privacy}","received_events_url":"https://api.github.com/users/manuadoor/received_events","type":"User","site_admin":false},"body":"I have enabled the optional functionality of creating self IP for a specific route domain. Please review and consider approving the pull request.\r\n- Manu\r\n\r\nExample:\r\n\r\nname: Create Self IP with a Route Domain bigip_selfip: server: \"lb.mydomain.com\" user: \"admin\" password: \"secret\" validate_certs: \"no\" name: \"self1\" address: \"10.10.10.10\" netmask: \"255.255.255.0\" vlan: \"vlan1\" rd: \"10\" allow_service: \"default\" delegate_to: localhost","created_at":"2016-09-28T14:30:59Z","updated_at":"2016-09-29T14:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8bfc84101f77410befd893c9b93ca000a5ecfb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-ansible/issues/33/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-ansible/statuses/0bbfe090f972b9e9e7ee96193ec08c8ad77df65d","head":{"label":"manuadoor:master","ref":"master","sha":"0bbfe090f972b9e9e7ee96193ec08c8ad77df65d","user":{"login":"manuadoor","id":20935309,"avatar_url":"https://avatars.githubusercontent.com/u/20935309?v=3","gravatar_id":"","url":"https://api.github.com/users/manuadoor","html_url":"https://github.com/manuadoor","followers_url":"https://api.github.com/users/manuadoor/followers","following_url":"https://api.github.com/users/manuadoor/following{/other_user}","gists_url":"https://api.github.com/users/manuadoor/gists{/gist_id}","starred_url":"https://api.github.com/users/manuadoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuadoor/subscriptions","organizations_url":"https://api.github.com/users/manuadoor/orgs","repos_url":"https://api.github.com/users/manuadoor/repos","events_url":"https://api.github.com/users/manuadoor/events{/privacy}","received_events_url":"https://api.github.com/users/manuadoor/received_events","type":"User","site_admin":false},"repo":{"id":69460010,"name":"f5-ansible","full_name":"manuadoor/f5-ansible","owner":{"login":"manuadoor","id":20935309,"avatar_url":"https://avatars.githubusercontent.com/u/20935309?v=3","gravatar_id":"","url":"https://api.github.com/users/manuadoor","html_url":"https://github.com/manuadoor","followers_url":"https://api.github.com/users/manuadoor/followers","following_url":"https://api.github.com/users/manuadoor/following{/other_user}","gists_url":"https://api.github.com/users/manuadoor/gists{/gist_id}","starred_url":"https://api.github.com/users/manuadoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuadoor/subscriptions","organizations_url":"https://api.github.com/users/manuadoor/orgs","repos_url":"https://api.github.com/users/manuadoor/repos","events_url":"https://api.github.com/users/manuadoor/events{/privacy}","received_events_url":"https://api.github.com/users/manuadoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manuadoor/f5-ansible","description":"Ansible modules that can manipulate F5 products","fork":true,"url":"https://api.github.com/repos/manuadoor/f5-ansible","forks_url":"https://api.github.com/repos/manuadoor/f5-ansible/forks","keys_url":"https://api.github.com/repos/manuadoor/f5-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manuadoor/f5-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manuadoor/f5-ansible/teams","hooks_url":"https://api.github.com/repos/manuadoor/f5-ansible/hooks","issue_events_url":"https://api.github.com/repos/manuadoor/f5-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/manuadoor/f5-ansible/events","assignees_url":"https://api.github.com/repos/manuadoor/f5-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/manuadoor/f5-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/manuadoor/f5-ansible/tags","blobs_url":"https://api.github.com/repos/manuadoor/f5-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manuadoor/f5-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manuadoor/f5-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/manuadoor/f5-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manuadoor/f5-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/manuadoor/f5-ansible/languages","stargazers_url":"https://api.github.com/repos/manuadoor/f5-ansible/stargazers","contributors_url":"https://api.github.com/repos/manuadoor/f5-ansible/contributors","subscribers_url":"https://api.github.com/repos/manuadoor/f5-ansible/subscribers","subscription_url":"https://api.github.com/repos/manuadoor/f5-ansible/subscription","commits_url":"https://api.github.com/repos/manuadoor/f5-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/manuadoor/f5-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/manuadoor/f5-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/manuadoor/f5-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/manuadoor/f5-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/manuadoor/f5-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manuadoor/f5-ansible/merges","archive_url":"https://api.github.com/repos/manuadoor/f5-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manuadoor/f5-ansible/downloads","issues_url":"https://api.github.com/repos/manuadoor/f5-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/manuadoor/f5-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/manuadoor/f5-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/manuadoor/f5-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manuadoor/f5-ansible/labels{/name}","releases_url":"https://api.github.com/repos/manuadoor/f5-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/manuadoor/f5-ansible/deployments","created_at":"2016-09-28T12:16:35Z","updated_at":"2016-09-28T12:16:37Z","pushed_at":"2016-09-29T09:52:33Z","git_url":"git://github.com/manuadoor/f5-ansible.git","ssh_url":"git@github.com:manuadoor/f5-ansible.git","clone_url":"https://github.com/manuadoor/f5-ansible.git","svn_url":"https://github.com/manuadoor/f5-ansible","homepage":null,"size":809,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"7009960846c4080dc2de518bd2111f4d7622fabc","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":46580696,"name":"f5-ansible","full_name":"F5Networks/f5-ansible","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-ansible","description":"Ansible modules that can manipulate F5 products","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-ansible","forks_url":"https://api.github.com/repos/F5Networks/f5-ansible/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-ansible/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-ansible/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-ansible/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-ansible/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-ansible/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-ansible/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-ansible/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-ansible/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-ansible/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-ansible/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-ansible/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-ansible/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-ansible/deployments","created_at":"2015-11-20T18:54:31Z","updated_at":"2016-09-23T02:35:55Z","pushed_at":"2016-09-29T09:52:34Z","git_url":"git://github.com/F5Networks/f5-ansible.git","ssh_url":"git@github.com:F5Networks/f5-ansible.git","clone_url":"https://github.com/F5Networks/f5-ansible.git","svn_url":"https://github.com/F5Networks/f5-ansible","homepage":null,"size":803,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":10,"forks":15,"open_issues":10,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33"},"html":{"href":"https://github.com/F5Networks/f5-ansible/pull/33"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/issues/33"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-ansible/statuses/0bbfe090f972b9e9e7ee96193ec08c8ad77df65d"}}}}
{"actor":{"display_login":"manuadoor"}}