{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/comments/52162531","id":52162531,"diff_hunk":"@@ -91,23 +91,24 @@ type addGTMPoolMember struct {\n }\n \n //Name returns the backend service name\n-func (be Baboon) Name() string {\n+func (be *Baboon) Name() string {\n \treturn be.config[\"name\"]\n }\n \n // Register reads backend config for baboon\n-func (be Baboon) Register() (error, Backend) {\n+func (be *Baboon) Register() error {","path":"backend/baboon.go","position":12,"original_position":11,"commit_id":"96d327be987ad8b5ee769da8a55c2297a729749c","original_commit_id":"b844e46d67f5e635f5ec0c16bed13c184cf94fbf","user":{"login":"skoenig","id":537955,"avatar_url":"https://avatars.githubusercontent.com/u/537955?v=3","gravatar_id":"","url":"https://api.github.com/users/skoenig","html_url":"https://github.com/skoenig","followers_url":"https://api.github.com/users/skoenig/followers","following_url":"https://api.github.com/users/skoenig/following{/other_user}","gists_url":"https://api.github.com/users/skoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/skoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skoenig/subscriptions","organizations_url":"https://api.github.com/users/skoenig/orgs","repos_url":"https://api.github.com/users/skoenig/repos","events_url":"https://api.github.com/users/skoenig/events{/privacy}","received_events_url":"https://api.github.com/users/skoenig/received_events","type":"User","site_admin":false},"body":"This is kind of optional, because the Register function is intended for setting up connections, reading in values etc. Errors from this calls should be returned as the error to the RegistgerBackends function.","created_at":"2016-02-08T12:24:10Z","updated_at":"2016-02-08T12:24:10Z","html_url":"https://github.com/zalando-techmonkeys/howler/pull/19#discussion_r52162531","pull_request_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/comments/52162531"},"html":{"href":"https://github.com/zalando-techmonkeys/howler/pull/19#discussion_r52162531"},"pull_request":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19","id":58592157,"html_url":"https://github.com/zalando-techmonkeys/howler/pull/19","diff_url":"https://github.com/zalando-techmonkeys/howler/pull/19.diff","patch_url":"https://github.com/zalando-techmonkeys/howler/pull/19.patch","issue_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/19","number":19,"state":"open","locked":false,"title":"backend-stucts are now referenced by pointer","user":{"login":"skoenig","id":537955,"avatar_url":"https://avatars.githubusercontent.com/u/537955?v=3","gravatar_id":"","url":"https://api.github.com/users/skoenig","html_url":"https://github.com/skoenig","followers_url":"https://api.github.com/users/skoenig/followers","following_url":"https://api.github.com/users/skoenig/following{/other_user}","gists_url":"https://api.github.com/users/skoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/skoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skoenig/subscriptions","organizations_url":"https://api.github.com/users/skoenig/orgs","repos_url":"https://api.github.com/users/skoenig/repos","events_url":"https://api.github.com/users/skoenig/events{/privacy}","received_events_url":"https://api.github.com/users/skoenig/received_events","type":"User","site_admin":false},"body":"In this PR I try to fix a) that the backends are creating an instance of themselves and return it in Register() and b) that the backend assined functions reference the stucts by pointer now, thus are able to change it now. This is more a RFC how it could be done.","created_at":"2016-02-08T10:35:43Z","updated_at":"2016-02-08T12:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f722a16e360bc63ba9a0b5651031a62f71e84202","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19/commits","review_comments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19/comments","review_comment_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/19/comments","statuses_url":"https://api.github.com/repos/zalando-techmonkeys/howler/statuses/96d327be987ad8b5ee769da8a55c2297a729749c","head":{"label":"zalando-techmonkeys:bugfix/backends-referenced-by-pointer","ref":"bugfix/backends-referenced-by-pointer","sha":"96d327be987ad8b5ee769da8a55c2297a729749c","user":{"login":"zalando-techmonkeys","id":12731255,"avatar_url":"https://avatars.githubusercontent.com/u/12731255?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-techmonkeys","html_url":"https://github.com/zalando-techmonkeys","followers_url":"https://api.github.com/users/zalando-techmonkeys/followers","following_url":"https://api.github.com/users/zalando-techmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/zalando-techmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-techmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-techmonkeys/subscriptions","organizations_url":"https://api.github.com/users/zalando-techmonkeys/orgs","repos_url":"https://api.github.com/users/zalando-techmonkeys/repos","events_url":"https://api.github.com/users/zalando-techmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-techmonkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":46748610,"name":"howler","full_name":"zalando-techmonkeys/howler","owner":{"login":"zalando-techmonkeys","id":12731255,"avatar_url":"https://avatars.githubusercontent.com/u/12731255?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-techmonkeys","html_url":"https://github.com/zalando-techmonkeys","followers_url":"https://api.github.com/users/zalando-techmonkeys/followers","following_url":"https://api.github.com/users/zalando-techmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/zalando-techmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-techmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-techmonkeys/subscriptions","organizations_url":"https://api.github.com/users/zalando-techmonkeys/orgs","repos_url":"https://api.github.com/users/zalando-techmonkeys/repos","events_url":"https://api.github.com/users/zalando-techmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-techmonkeys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-techmonkeys/howler","description":"Howler: waits to hear something in the Marathon Event Bus and shouts it to the other monkeys","fork":false,"url":"https://api.github.com/repos/zalando-techmonkeys/howler","forks_url":"https://api.github.com/repos/zalando-techmonkeys/howler/forks","keys_url":"https://api.github.com/repos/zalando-techmonkeys/howler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-techmonkeys/howler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-techmonkeys/howler/teams","hooks_url":"https://api.github.com/repos/zalando-techmonkeys/howler/hooks","issue_events_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-techmonkeys/howler/events","assignees_url":"https://api.github.com/repos/zalando-techmonkeys/howler/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-techmonkeys/howler/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-techmonkeys/howler/tags","blobs_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-techmonkeys/howler/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-techmonkeys/howler/languages","stargazers_url":"https://api.github.com/repos/zalando-techmonkeys/howler/stargazers","contributors_url":"https://api.github.com/repos/zalando-techmonkeys/howler/contributors","subscribers_url":"https://api.github.com/repos/zalando-techmonkeys/howler/subscribers","subscription_url":"https://api.github.com/repos/zalando-techmonkeys/howler/subscription","commits_url":"https://api.github.com/repos/zalando-techmonkeys/howler/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-techmonkeys/howler/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-techmonkeys/howler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-techmonkeys/howler/merges","archive_url":"https://api.github.com/repos/zalando-techmonkeys/howler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-techmonkeys/howler/downloads","issues_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-techmonkeys/howler/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-techmonkeys/howler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-techmonkeys/howler/labels{/name}","releases_url":"https://api.github.com/repos/zalando-techmonkeys/howler/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/deployments","created_at":"2015-11-23T21:18:21Z","updated_at":"2016-02-08T08:55:16Z","pushed_at":"2016-02-08T12:22:03Z","git_url":"git://github.com/zalando-techmonkeys/howler.git","ssh_url":"git@github.com:zalando-techmonkeys/howler.git","clone_url":"https://github.com/zalando-techmonkeys/howler.git","svn_url":"https://github.com/zalando-techmonkeys/howler","homepage":null,"size":71,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"zalando-techmonkeys:master","ref":"master","sha":"136c33d1822fcd58a9130c2c4a9806c21c4b2cbe","user":{"login":"zalando-techmonkeys","id":12731255,"avatar_url":"https://avatars.githubusercontent.com/u/12731255?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-techmonkeys","html_url":"https://github.com/zalando-techmonkeys","followers_url":"https://api.github.com/users/zalando-techmonkeys/followers","following_url":"https://api.github.com/users/zalando-techmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/zalando-techmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-techmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-techmonkeys/subscriptions","organizations_url":"https://api.github.com/users/zalando-techmonkeys/orgs","repos_url":"https://api.github.com/users/zalando-techmonkeys/repos","events_url":"https://api.github.com/users/zalando-techmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-techmonkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":46748610,"name":"howler","full_name":"zalando-techmonkeys/howler","owner":{"login":"zalando-techmonkeys","id":12731255,"avatar_url":"https://avatars.githubusercontent.com/u/12731255?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-techmonkeys","html_url":"https://github.com/zalando-techmonkeys","followers_url":"https://api.github.com/users/zalando-techmonkeys/followers","following_url":"https://api.github.com/users/zalando-techmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/zalando-techmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-techmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-techmonkeys/subscriptions","organizations_url":"https://api.github.com/users/zalando-techmonkeys/orgs","repos_url":"https://api.github.com/users/zalando-techmonkeys/repos","events_url":"https://api.github.com/users/zalando-techmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-techmonkeys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-techmonkeys/howler","description":"Howler: waits to hear something in the Marathon Event Bus and shouts it to the other monkeys","fork":false,"url":"https://api.github.com/repos/zalando-techmonkeys/howler","forks_url":"https://api.github.com/repos/zalando-techmonkeys/howler/forks","keys_url":"https://api.github.com/repos/zalando-techmonkeys/howler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-techmonkeys/howler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-techmonkeys/howler/teams","hooks_url":"https://api.github.com/repos/zalando-techmonkeys/howler/hooks","issue_events_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-techmonkeys/howler/events","assignees_url":"https://api.github.com/repos/zalando-techmonkeys/howler/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-techmonkeys/howler/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-techmonkeys/howler/tags","blobs_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-techmonkeys/howler/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-techmonkeys/howler/languages","stargazers_url":"https://api.github.com/repos/zalando-techmonkeys/howler/stargazers","contributors_url":"https://api.github.com/repos/zalando-techmonkeys/howler/contributors","subscribers_url":"https://api.github.com/repos/zalando-techmonkeys/howler/subscribers","subscription_url":"https://api.github.com/repos/zalando-techmonkeys/howler/subscription","commits_url":"https://api.github.com/repos/zalando-techmonkeys/howler/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-techmonkeys/howler/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-techmonkeys/howler/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-techmonkeys/howler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-techmonkeys/howler/merges","archive_url":"https://api.github.com/repos/zalando-techmonkeys/howler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-techmonkeys/howler/downloads","issues_url":"https://api.github.com/repos/zalando-techmonkeys/howler/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-techmonkeys/howler/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-techmonkeys/howler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-techmonkeys/howler/labels{/name}","releases_url":"https://api.github.com/repos/zalando-techmonkeys/howler/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-techmonkeys/howler/deployments","created_at":"2015-11-23T21:18:21Z","updated_at":"2016-02-08T08:55:16Z","pushed_at":"2016-02-08T12:22:03Z","git_url":"git://github.com/zalando-techmonkeys/howler.git","ssh_url":"git@github.com:zalando-techmonkeys/howler.git","clone_url":"https://github.com/zalando-techmonkeys/howler.git","svn_url":"https://github.com/zalando-techmonkeys/howler","homepage":null,"size":71,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19"},"html":{"href":"https://github.com/zalando-techmonkeys/howler/pull/19"},"issue":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/19"},"comments":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-techmonkeys/howler/statuses/96d327be987ad8b5ee769da8a55c2297a729749c"}}}}