{"action":"created","issue":{"url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/16","labels_url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/16/comments","events_url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/16/events","html_url":"https://github.com/tburgin/AbsoluteManageExport/issues/16","id":126447841,"number":16,"title":"Please test fork for OS platform additions","user":{"login":"patgmac","id":614564,"avatar_url":"https://avatars.githubusercontent.com/u/614564?v=3","gravatar_id":"","url":"https://api.github.com/users/patgmac","html_url":"https://github.com/patgmac","followers_url":"https://api.github.com/users/patgmac/followers","following_url":"https://api.github.com/users/patgmac/following{/other_user}","gists_url":"https://api.github.com/users/patgmac/gists{/gist_id}","starred_url":"https://api.github.com/users/patgmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patgmac/subscriptions","organizations_url":"https://api.github.com/users/patgmac/orgs","repos_url":"https://api.github.com/users/patgmac/repos","events_url":"https://api.github.com/users/patgmac/events{/privacy}","received_events_url":"https://api.github.com/users/patgmac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-13T15:48:08Z","updated_at":"2016-01-15T15:30:21Z","closed_at":null,"body":"I have some proposed additions I'd like some help with testing before I do a PR. This fork adds the ability to add additional criteria to a LANrev SD package, including: os_platform min_os max_os platform_arch. \r\n\r\nSee the README for some additional details. \r\n\r\nhttps://github.com/patgmac/AbsoluteManageExport"},"comment":{"url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/comments/171991845","html_url":"https://github.com/tburgin/AbsoluteManageExport/issues/16#issuecomment-171991845","issue_url":"https://api.github.com/repos/tburgin/AbsoluteManageExport/issues/16","id":171991845,"user":{"login":"jbaker10","id":4367889,"avatar_url":"https://avatars.githubusercontent.com/u/4367889?v=3","gravatar_id":"","url":"https://api.github.com/users/jbaker10","html_url":"https://github.com/jbaker10","followers_url":"https://api.github.com/users/jbaker10/followers","following_url":"https://api.github.com/users/jbaker10/following{/other_user}","gists_url":"https://api.github.com/users/jbaker10/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaker10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaker10/subscriptions","organizations_url":"https://api.github.com/users/jbaker10/orgs","repos_url":"https://api.github.com/users/jbaker10/repos","events_url":"https://api.github.com/users/jbaker10/events{/privacy}","received_events_url":"https://api.github.com/users/jbaker10/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T15:30:21Z","updated_at":"2016-01-15T15:30:21Z","body":"@patgmac I have tested the following successfully:\r\n* Running the recipe without any of the new conditions\r\n* Only using one at a time:\r\n  * `max_os`\r\n  * `min_os`\r\n  * `os_platform`\r\n  * `platform_arch`\r\n* Using all 4 in the same recipe\r\n* Using only `max_os` and `min_os`\r\n* Lots of variations in between haha\r\n\r\nI have a suggestion for the `platform_arch`. It seems that if this is only used for Windows, it should automatically change the `OS_platform` to be Windows (`4`), or have a condition that checks and fails gracefully if the user uses `platform_arch` without _also_ using `os_platform`.\r\n\r\nThere are a lot of different pieces here that somewhat rely on each other in order to work properly, so while I think some of this can be put on the user to ensure they have it set properly, the setting of the `os_platform` automatically when using `platform_arch` I think would be fairly easy and one that I think makes sense to automate."}}