{"action":"created","comment":{"url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/comments/57991408","id":57991408,"diff_hunk":"@@ -4,14 +4,14 @@ const by: typeof selwd.By = selwd.By;\n import {getBrowser} from \"./index\";\n import Locator from \"./locator\";\n \n-export class BaseElement {\n+export default class BaseElement {\n     private _locator: Locator;\n \n     constructor(locator: Locator) {\n         this._locator = locator;\n     }\n \n-    click(): selwd.promise.Promise<void> {\n+    public click(): selwd.promise.Promise<void> {","path":"src/base.ts","position":13,"original_position":13,"commit_id":"7d474aff4836d13f7e39dd1e64087600547bd110","original_commit_id":"7d474aff4836d13f7e39dd1e64087600547bd110","user":{"login":"YashdalfTheGray","id":3102848,"avatar_url":"https://avatars.githubusercontent.com/u/3102848?v=3","gravatar_id":"","url":"https://api.github.com/users/YashdalfTheGray","html_url":"https://github.com/YashdalfTheGray","followers_url":"https://api.github.com/users/YashdalfTheGray/followers","following_url":"https://api.github.com/users/YashdalfTheGray/following{/other_user}","gists_url":"https://api.github.com/users/YashdalfTheGray/gists{/gist_id}","starred_url":"https://api.github.com/users/YashdalfTheGray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YashdalfTheGray/subscriptions","organizations_url":"https://api.github.com/users/YashdalfTheGray/orgs","repos_url":"https://api.github.com/users/YashdalfTheGray/repos","events_url":"https://api.github.com/users/YashdalfTheGray/events{/privacy}","received_events_url":"https://api.github.com/users/YashdalfTheGray/received_events","type":"User","site_admin":false},"body":"@kwpeters is this needed? Tslint seems to think it is. ","created_at":"2016-03-31T01:45:09Z","updated_at":"2016-03-31T01:45:09Z","html_url":"https://github.com/page-object-js/page-object-js/pull/8#discussion_r57991408","pull_request_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/comments/57991408"},"html":{"href":"https://github.com/page-object-js/page-object-js/pull/8#discussion_r57991408"},"pull_request":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8","id":64723491,"html_url":"https://github.com/page-object-js/page-object-js/pull/8","diff_url":"https://github.com/page-object-js/page-object-js/pull/8.diff","patch_url":"https://github.com/page-object-js/page-object-js/pull/8.patch","issue_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/8","number":8,"state":"open","locked":false,"title":"Base element and weirdness","user":{"login":"YashdalfTheGray","id":3102848,"avatar_url":"https://avatars.githubusercontent.com/u/3102848?v=3","gravatar_id":"","url":"https://api.github.com/users/YashdalfTheGray","html_url":"https://github.com/YashdalfTheGray","followers_url":"https://api.github.com/users/YashdalfTheGray/followers","following_url":"https://api.github.com/users/YashdalfTheGray/following{/other_user}","gists_url":"https://api.github.com/users/YashdalfTheGray/gists{/gist_id}","starred_url":"https://api.github.com/users/YashdalfTheGray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YashdalfTheGray/subscriptions","organizations_url":"https://api.github.com/users/YashdalfTheGray/orgs","repos_url":"https://api.github.com/users/YashdalfTheGray/repos","events_url":"https://api.github.com/users/YashdalfTheGray/events{/privacy}","received_events_url":"https://api.github.com/users/YashdalfTheGray/received_events","type":"User","site_admin":false},"body":"Alright, so I tried to get span to inherit from the base element but I wasn't able to run the cukes, mostly (I think) because Atom rewriting my tsconfig like an butthole. \r\n\r\nAnyway, I wanted to get @kwpeters' opinion on some of the stuff that I've highlighted in this PR. Mostly that I don't know if I really need the `public` keyword before `click()` in my `BaseElement` class or the `public` before `id` in my locator class. \r\n\r\nAlso, am I doing the export correctly? Should I use non-default exports instead?\r\n\r\nLike I said, I wasn't able to run the cukes, @kmckee, can I get some input on that? Does your Atom do weird things with your `tsconfig.json` too? Does it stop you from running the cukes?","created_at":"2016-03-31T01:44:37Z","updated_at":"2016-03-31T01:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5281e248eed9f22059264bfca301723966da2cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8/commits","review_comments_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8/comments","review_comment_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/8/comments","statuses_url":"https://api.github.com/repos/page-object-js/page-object-js/statuses/7d474aff4836d13f7e39dd1e64087600547bd110","head":{"label":"page-object-js:base_element","ref":"base_element","sha":"7d474aff4836d13f7e39dd1e64087600547bd110","user":{"login":"page-object-js","id":17197101,"avatar_url":"https://avatars.githubusercontent.com/u/17197101?v=3","gravatar_id":"","url":"https://api.github.com/users/page-object-js","html_url":"https://github.com/page-object-js","followers_url":"https://api.github.com/users/page-object-js/followers","following_url":"https://api.github.com/users/page-object-js/following{/other_user}","gists_url":"https://api.github.com/users/page-object-js/gists{/gist_id}","starred_url":"https://api.github.com/users/page-object-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/page-object-js/subscriptions","organizations_url":"https://api.github.com/users/page-object-js/orgs","repos_url":"https://api.github.com/users/page-object-js/repos","events_url":"https://api.github.com/users/page-object-js/events{/privacy}","received_events_url":"https://api.github.com/users/page-object-js/received_events","type":"Organization","site_admin":false},"repo":{"id":51169642,"name":"page-object-js","full_name":"page-object-js/page-object-js","owner":{"login":"page-object-js","id":17197101,"avatar_url":"https://avatars.githubusercontent.com/u/17197101?v=3","gravatar_id":"","url":"https://api.github.com/users/page-object-js","html_url":"https://github.com/page-object-js","followers_url":"https://api.github.com/users/page-object-js/followers","following_url":"https://api.github.com/users/page-object-js/following{/other_user}","gists_url":"https://api.github.com/users/page-object-js/gists{/gist_id}","starred_url":"https://api.github.com/users/page-object-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/page-object-js/subscriptions","organizations_url":"https://api.github.com/users/page-object-js/orgs","repos_url":"https://api.github.com/users/page-object-js/repos","events_url":"https://api.github.com/users/page-object-js/events{/privacy}","received_events_url":"https://api.github.com/users/page-object-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/page-object-js/page-object-js","description":"","fork":false,"url":"https://api.github.com/repos/page-object-js/page-object-js","forks_url":"https://api.github.com/repos/page-object-js/page-object-js/forks","keys_url":"https://api.github.com/repos/page-object-js/page-object-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/page-object-js/page-object-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/page-object-js/page-object-js/teams","hooks_url":"https://api.github.com/repos/page-object-js/page-object-js/hooks","issue_events_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/events{/number}","events_url":"https://api.github.com/repos/page-object-js/page-object-js/events","assignees_url":"https://api.github.com/repos/page-object-js/page-object-js/assignees{/user}","branches_url":"https://api.github.com/repos/page-object-js/page-object-js/branches{/branch}","tags_url":"https://api.github.com/repos/page-object-js/page-object-js/tags","blobs_url":"https://api.github.com/repos/page-object-js/page-object-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/page-object-js/page-object-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/page-object-js/page-object-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/page-object-js/page-object-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/page-object-js/page-object-js/statuses/{sha}","languages_url":"https://api.github.com/repos/page-object-js/page-object-js/languages","stargazers_url":"https://api.github.com/repos/page-object-js/page-object-js/stargazers","contributors_url":"https://api.github.com/repos/page-object-js/page-object-js/contributors","subscribers_url":"https://api.github.com/repos/page-object-js/page-object-js/subscribers","subscription_url":"https://api.github.com/repos/page-object-js/page-object-js/subscription","commits_url":"https://api.github.com/repos/page-object-js/page-object-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/page-object-js/page-object-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/page-object-js/page-object-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/page-object-js/page-object-js/contents/{+path}","compare_url":"https://api.github.com/repos/page-object-js/page-object-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/page-object-js/page-object-js/merges","archive_url":"https://api.github.com/repos/page-object-js/page-object-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/page-object-js/page-object-js/downloads","issues_url":"https://api.github.com/repos/page-object-js/page-object-js/issues{/number}","pulls_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls{/number}","milestones_url":"https://api.github.com/repos/page-object-js/page-object-js/milestones{/number}","notifications_url":"https://api.github.com/repos/page-object-js/page-object-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/page-object-js/page-object-js/labels{/name}","releases_url":"https://api.github.com/repos/page-object-js/page-object-js/releases{/id}","deployments_url":"https://api.github.com/repos/page-object-js/page-object-js/deployments","created_at":"2016-02-05T19:39:43Z","updated_at":"2016-02-12T15:56:21Z","pushed_at":"2016-03-31T01:44:37Z","git_url":"git://github.com/page-object-js/page-object-js.git","ssh_url":"git@github.com:page-object-js/page-object-js.git","clone_url":"https://github.com/page-object-js/page-object-js.git","svn_url":"https://github.com/page-object-js/page-object-js","homepage":null,"size":66,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"page-object-js:master","ref":"master","sha":"381da29297e527b397c6e3e0d7bd9a5770ba2daf","user":{"login":"page-object-js","id":17197101,"avatar_url":"https://avatars.githubusercontent.com/u/17197101?v=3","gravatar_id":"","url":"https://api.github.com/users/page-object-js","html_url":"https://github.com/page-object-js","followers_url":"https://api.github.com/users/page-object-js/followers","following_url":"https://api.github.com/users/page-object-js/following{/other_user}","gists_url":"https://api.github.com/users/page-object-js/gists{/gist_id}","starred_url":"https://api.github.com/users/page-object-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/page-object-js/subscriptions","organizations_url":"https://api.github.com/users/page-object-js/orgs","repos_url":"https://api.github.com/users/page-object-js/repos","events_url":"https://api.github.com/users/page-object-js/events{/privacy}","received_events_url":"https://api.github.com/users/page-object-js/received_events","type":"Organization","site_admin":false},"repo":{"id":51169642,"name":"page-object-js","full_name":"page-object-js/page-object-js","owner":{"login":"page-object-js","id":17197101,"avatar_url":"https://avatars.githubusercontent.com/u/17197101?v=3","gravatar_id":"","url":"https://api.github.com/users/page-object-js","html_url":"https://github.com/page-object-js","followers_url":"https://api.github.com/users/page-object-js/followers","following_url":"https://api.github.com/users/page-object-js/following{/other_user}","gists_url":"https://api.github.com/users/page-object-js/gists{/gist_id}","starred_url":"https://api.github.com/users/page-object-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/page-object-js/subscriptions","organizations_url":"https://api.github.com/users/page-object-js/orgs","repos_url":"https://api.github.com/users/page-object-js/repos","events_url":"https://api.github.com/users/page-object-js/events{/privacy}","received_events_url":"https://api.github.com/users/page-object-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/page-object-js/page-object-js","description":"","fork":false,"url":"https://api.github.com/repos/page-object-js/page-object-js","forks_url":"https://api.github.com/repos/page-object-js/page-object-js/forks","keys_url":"https://api.github.com/repos/page-object-js/page-object-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/page-object-js/page-object-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/page-object-js/page-object-js/teams","hooks_url":"https://api.github.com/repos/page-object-js/page-object-js/hooks","issue_events_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/events{/number}","events_url":"https://api.github.com/repos/page-object-js/page-object-js/events","assignees_url":"https://api.github.com/repos/page-object-js/page-object-js/assignees{/user}","branches_url":"https://api.github.com/repos/page-object-js/page-object-js/branches{/branch}","tags_url":"https://api.github.com/repos/page-object-js/page-object-js/tags","blobs_url":"https://api.github.com/repos/page-object-js/page-object-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/page-object-js/page-object-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/page-object-js/page-object-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/page-object-js/page-object-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/page-object-js/page-object-js/statuses/{sha}","languages_url":"https://api.github.com/repos/page-object-js/page-object-js/languages","stargazers_url":"https://api.github.com/repos/page-object-js/page-object-js/stargazers","contributors_url":"https://api.github.com/repos/page-object-js/page-object-js/contributors","subscribers_url":"https://api.github.com/repos/page-object-js/page-object-js/subscribers","subscription_url":"https://api.github.com/repos/page-object-js/page-object-js/subscription","commits_url":"https://api.github.com/repos/page-object-js/page-object-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/page-object-js/page-object-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/page-object-js/page-object-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/page-object-js/page-object-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/page-object-js/page-object-js/contents/{+path}","compare_url":"https://api.github.com/repos/page-object-js/page-object-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/page-object-js/page-object-js/merges","archive_url":"https://api.github.com/repos/page-object-js/page-object-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/page-object-js/page-object-js/downloads","issues_url":"https://api.github.com/repos/page-object-js/page-object-js/issues{/number}","pulls_url":"https://api.github.com/repos/page-object-js/page-object-js/pulls{/number}","milestones_url":"https://api.github.com/repos/page-object-js/page-object-js/milestones{/number}","notifications_url":"https://api.github.com/repos/page-object-js/page-object-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/page-object-js/page-object-js/labels{/name}","releases_url":"https://api.github.com/repos/page-object-js/page-object-js/releases{/id}","deployments_url":"https://api.github.com/repos/page-object-js/page-object-js/deployments","created_at":"2016-02-05T19:39:43Z","updated_at":"2016-02-12T15:56:21Z","pushed_at":"2016-03-31T01:44:37Z","git_url":"git://github.com/page-object-js/page-object-js.git","ssh_url":"git@github.com:page-object-js/page-object-js.git","clone_url":"https://github.com/page-object-js/page-object-js.git","svn_url":"https://github.com/page-object-js/page-object-js","homepage":null,"size":66,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8"},"html":{"href":"https://github.com/page-object-js/page-object-js/pull/8"},"issue":{"href":"https://api.github.com/repos/page-object-js/page-object-js/issues/8"},"comments":{"href":"https://api.github.com/repos/page-object-js/page-object-js/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/page-object-js/page-object-js/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/page-object-js/page-object-js/statuses/7d474aff4836d13f7e39dd1e64087600547bd110"}}}}