{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/669","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/669/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/669/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/669/events","html_url":"https://github.com/apache/cloudstack/pull/669","id":99994950,"number":669,"title":"Made the adding new keyboard language support easier","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-08-10T07:38:56Z","updated_at":"2016-05-19T22:02:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/669","html_url":"https://github.com/apache/cloudstack/pull/669","diff_url":"https://github.com/apache/cloudstack/pull/669.diff","patch_url":"https://github.com/apache/cloudstack/pull/669.patch"},"body":"https://issues.apache.org/jira/browse/CLOUDSTACK-8665\r\n\r\nThis branch has implemented following improvements in console proxy keyboard language support\r\n\r\n1) ajaxviewer.js and ajaxkeys.js are main files involved in key code translations. These files now can be copied in systemvm/js folder and they will be copied to CPVM with stop/start performed on it.\r\n2) Started passing parameters to CPVM needed to resolve the ambiguous cases of keycode translations.\r\n3) Generalise the framework such that one needs to modify only ajaxkeys.js (file which has keycode mappings) without need of much knowledge in js.\r\n\r\nFS for this feature is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy\r\n\r\nAfter these changes how to add keyboard support for new language or fix existing broken keys WIP document  is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+support+for+non-US+Keyboard+for+Console+Proxy"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/220464828","html_url":"https://github.com/apache/cloudstack/pull/669#issuecomment-220464828","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/669","id":220464828,"user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T22:02:33Z","updated_at":"2016-05-19T22:02:33Z","body":"Really like the functionality so I think we must get this in. I have some remarks about the code that I stand by even though they are not entirely to blame on @anshul1886 as he calls methods fthrowing Exception, rom SshHelper mainly. It is a bad smell due to the older code and will not facilitate trouble shooting for the end user. So I would like to see the exception-handlers be enriched with some better diagnosis and *maybe* messages. nothing else to nag about."}}
{"actor":{"display_login":"DaanHoogland"}}