{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/documentation/issues/302","repository_url":"https://api.github.com/repos/aurelia/documentation","labels_url":"https://api.github.com/repos/aurelia/documentation/issues/302/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/documentation/issues/302/comments","events_url":"https://api.github.com/repos/aurelia/documentation/issues/302/events","html_url":"https://github.com/aurelia/documentation/issues/302","id":184924248,"number":302,"title":"Validation.CustomRules.addRule example code looks wrong","user":{"login":"dkent600","id":1821666,"avatar_url":"https://avatars.githubusercontent.com/u/1821666?v=3","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"labels":[{"id":173620129,"url":"https://api.github.com/repos/aurelia/documentation/labels/documentation","name":"documentation","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":{"login":"jdanyow","id":1306747,"avatar_url":"https://avatars.githubusercontent.com/u/1306747?v=3","gravatar_id":"","url":"https://api.github.com/users/jdanyow","html_url":"https://github.com/jdanyow","followers_url":"https://api.github.com/users/jdanyow/followers","following_url":"https://api.github.com/users/jdanyow/following{/other_user}","gists_url":"https://api.github.com/users/jdanyow/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanyow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanyow/subscriptions","organizations_url":"https://api.github.com/users/jdanyow/orgs","repos_url":"https://api.github.com/users/jdanyow/repos","events_url":"https://api.github.com/users/jdanyow/events{/privacy}","received_events_url":"https://api.github.com/users/jdanyow/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdanyow","id":1306747,"avatar_url":"https://avatars.githubusercontent.com/u/1306747?v=3","gravatar_id":"","url":"https://api.github.com/users/jdanyow","html_url":"https://github.com/jdanyow","followers_url":"https://api.github.com/users/jdanyow/followers","following_url":"https://api.github.com/users/jdanyow/following{/other_user}","gists_url":"https://api.github.com/users/jdanyow/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanyow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanyow/subscriptions","organizations_url":"https://api.github.com/users/jdanyow/orgs","repos_url":"https://api.github.com/users/jdanyow/repos","events_url":"https://api.github.com/users/jdanyow/events{/privacy}","received_events_url":"https://api.github.com/users/jdanyow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-24T18:53:34Z","updated_at":"2016-11-10T01:11:13Z","closed_at":"2016-11-10T01:11:13Z","body":"In the section Validation.CustomRules.addRule when supplying parameters, does not make sense to me.\n\nWhy is the rule evaluation function like this:\n\n`value >= config.min && value <= config.max` \n\ninstead of like this:\n\n`value >= min && value <= max`\n\nHere is what the docs have:\n\n```\nValidationRules.customRule(\n  'integerRange',\n  (value, obj, min, max) => value === null || value === undefined \n    || Number.isInteger(value) && value >= config.min && value <= config.max,\n  `\\${$displayName} must be an integer between \\${$config.min} and \\${$config.max}.`,\n  (min, max) => ({ min, max }) \n);\n```\n"},"comment":{"url":"https://api.github.com/repos/aurelia/documentation/issues/comments/259574413","html_url":"https://github.com/aurelia/documentation/issues/302#issuecomment-259574413","issue_url":"https://api.github.com/repos/aurelia/documentation/issues/302","id":259574413,"user":{"login":"jdanyow","id":1306747,"avatar_url":"https://avatars.githubusercontent.com/u/1306747?v=3","gravatar_id":"","url":"https://api.github.com/users/jdanyow","html_url":"https://github.com/jdanyow","followers_url":"https://api.github.com/users/jdanyow/followers","following_url":"https://api.github.com/users/jdanyow/following{/other_user}","gists_url":"https://api.github.com/users/jdanyow/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanyow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanyow/subscriptions","organizations_url":"https://api.github.com/users/jdanyow/orgs","repos_url":"https://api.github.com/users/jdanyow/repos","events_url":"https://api.github.com/users/jdanyow/events{/privacy}","received_events_url":"https://api.github.com/users/jdanyow/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T01:11:13Z","updated_at":"2016-11-10T01:11:13Z","body":"closing- we received and merged a PR that fixed this."}}
{"actor":{"display_login":"jdanyow"}}