{"action":"created","issue":{"url":"https://api.github.com/repos/NodeBB/NodeBB/issues/3807","repository_url":"https://api.github.com/repos/NodeBB/NodeBB","labels_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/3807/labels{/name}","comments_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/3807/comments","events_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/3807/events","html_url":"https://github.com/NodeBB/NodeBB/pull/3807","id":114389367,"number":3807,"title":"A much faster findBootstrapEnvironment method","user":{"login":"pitaj","id":803701,"avatar_url":"https://avatars.githubusercontent.com/u/803701?v=3","gravatar_id":"","url":"https://api.github.com/users/pitaj","html_url":"https://github.com/pitaj","followers_url":"https://api.github.com/users/pitaj/followers","following_url":"https://api.github.com/users/pitaj/following{/other_user}","gists_url":"https://api.github.com/users/pitaj/gists{/gist_id}","starred_url":"https://api.github.com/users/pitaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitaj/subscriptions","organizations_url":"https://api.github.com/users/pitaj/orgs","repos_url":"https://api.github.com/users/pitaj/repos","events_url":"https://api.github.com/users/pitaj/events{/privacy}","received_events_url":"https://api.github.com/users/pitaj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-10-31T05:39:41Z","updated_at":"2016-07-04T03:53:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NodeBB/NodeBB/pulls/3807","html_url":"https://github.com/NodeBB/NodeBB/pull/3807","diff_url":"https://github.com/NodeBB/NodeBB/pull/3807.diff","patch_url":"https://github.com/NodeBB/NodeBB/pull/3807.patch"},"body":"It might be a little less accurate in cases where the `min-nv-width` variables are overridden, but I think its worth it. People should not be overriding those variables in the first place."},"comment":{"url":"https://api.github.com/repos/NodeBB/NodeBB/issues/comments/230199983","html_url":"https://github.com/NodeBB/NodeBB/pull/3807#issuecomment-230199983","issue_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/3807","id":230199983,"user":{"login":"julianlam","id":923011,"avatar_url":"https://avatars.githubusercontent.com/u/923011?v=3","gravatar_id":"","url":"https://api.github.com/users/julianlam","html_url":"https://github.com/julianlam","followers_url":"https://api.github.com/users/julianlam/followers","following_url":"https://api.github.com/users/julianlam/following{/other_user}","gists_url":"https://api.github.com/users/julianlam/gists{/gist_id}","starred_url":"https://api.github.com/users/julianlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianlam/subscriptions","organizations_url":"https://api.github.com/users/julianlam/orgs","repos_url":"https://api.github.com/users/julianlam/repos","events_url":"https://api.github.com/users/julianlam/events{/privacy}","received_events_url":"https://api.github.com/users/julianlam/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T03:53:46Z","updated_at":"2016-07-04T03:53:46Z","body":"My main concern is that the original method was written in such a way due to it being future proof. Bootstrap can change all the values they want for xs, sm, etc, and this method won't break.\r\n\r\nIf the pixel values are hardcoded in, then it doesn't quite work if they're changed in Bootstrap itself.\r\n\r\nThat, and I have no idea what would happen on different zoom levels... "}}
{"actor":{"display_login":"julianlam"}}