{"action":"created","issue":{"url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/102","repository_url":"https://api.github.com/repos/hyperion-project/hyperion.ng","labels_url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/102/comments","events_url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/102/events","html_url":"https://github.com/hyperion-project/hyperion.ng/pull/102","id":164855533,"number":102,"title":"logging rework json/proto","user":{"login":"brindosch","id":15967679,"avatar_url":"https://avatars.githubusercontent.com/u/15967679?v=3","gravatar_id":"","url":"https://api.github.com/users/brindosch","html_url":"https://github.com/brindosch","followers_url":"https://api.github.com/users/brindosch/followers","following_url":"https://api.github.com/users/brindosch/following{/other_user}","gists_url":"https://api.github.com/users/brindosch/gists{/gist_id}","starred_url":"https://api.github.com/users/brindosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brindosch/subscriptions","organizations_url":"https://api.github.com/users/brindosch/orgs","repos_url":"https://api.github.com/users/brindosch/repos","events_url":"https://api.github.com/users/brindosch/events{/privacy}","received_events_url":"https://api.github.com/users/brindosch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-11T14:47:38Z","updated_at":"2016-07-11T15:19:23Z","closed_at":"2016-07-11T15:08:22Z","pull_request":{"url":"https://api.github.com/repos/hyperion-project/hyperion.ng/pulls/102","html_url":"https://github.com/hyperion-project/hyperion.ng/pull/102","diff_url":"https://github.com/hyperion-project/hyperion.ng/pull/102.diff","patch_url":"https://github.com/hyperion-project/hyperion.ng/pull/102.patch"},"body":"**1.** Tell us something about your changes.\r\n- rework logging for ptoto and json component\r\n- mDNS responter moved to Debug level\r\n- Blackborder to debug, until this is enhanced\r\n\r\nWhat shall i do with the: throw std exceptions?\r\n\r\n**2.** If this changes affect the .conf file. Please provide the changed section\r\n\r\n**3.** Reference a issue (optional)\r\n- https://github.com/hyperion-project/hyperion.ng/issues/25\r\nNote: I need to clean the commit history\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/comments/231766876","html_url":"https://github.com/hyperion-project/hyperion.ng/pull/102#issuecomment-231766876","issue_url":"https://api.github.com/repos/hyperion-project/hyperion.ng/issues/102","id":231766876,"user":{"login":"redPanther","id":6893049,"avatar_url":"https://avatars.githubusercontent.com/u/6893049?v=3","gravatar_id":"","url":"https://api.github.com/users/redPanther","html_url":"https://github.com/redPanther","followers_url":"https://api.github.com/users/redPanther/followers","following_url":"https://api.github.com/users/redPanther/following{/other_user}","gists_url":"https://api.github.com/users/redPanther/gists{/gist_id}","starred_url":"https://api.github.com/users/redPanther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redPanther/subscriptions","organizations_url":"https://api.github.com/users/redPanther/orgs","repos_url":"https://api.github.com/users/redPanther/repos","events_url":"https://api.github.com/users/redPanther/events{/privacy}","received_events_url":"https://api.github.com/users/redPanther/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T15:19:23Z","updated_at":"2016-07-11T15:19:23Z","body":"BTW I reformated the initializer list in code that I changed in that last times. Perhaps you do the same? My experience is, that the new format is better readable and prevent mistakes when modifying the initializers.\r\n\r\nwhat I mean:\r\nchanging from:\r\n```\r\nMyClass::MyClass() :\r\n  QObject(),\r\n  _myvar1(\"blub\"),\r\n  _myvar2(1000),\r\n  _myvar3(true)\r\n{\r\n....\r\n}\r\n```\r\nto\r\n\r\n```\r\nMyClass::MyClass()\r\n  : QObject()\r\n  , _myvar1(\"blub\")\r\n  , _myvar2(1000)\r\n  , _myvar3(true)\r\n{\r\n....\r\n}\r\n```\r\n\r\ninitializer indention is one 'tab'."}}
{"actor":{"display_login":"redPanther"}}