{"action":"opened","number":883,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog/pulls/883","id":90091875,"html_url":"https://github.com/serilog/serilog/pull/883","diff_url":"https://github.com/serilog/serilog/pull/883.diff","patch_url":"https://github.com/serilog/serilog/pull/883.patch","issue_url":"https://api.github.com/repos/serilog/serilog/issues/883","number":883,"state":"open","locked":false,"title":"Improve MessageTemplateCache performance","user":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"body":"- fixes #823 for all except  `netstandard10-12`\r\n- added perf tests for normal (cached) and leaking scenarios: [netcoreapp10](https://github.com/skomis-mm/serilog/tree/msgtplcache/results/netcoreapp1.0/MessageTemplateCache), [net452](https://github.com/skomis-mm/serilog/tree/msgtplcache/results/net4.5.2/MessageTemplateCache)\r\n\r\nbased on old forgotten **Hashtable**. According to [docs](https://msdn.microsoft.com/en-us/library/system.collections.hashtable(v=vs.110).aspx#Anchor_10) it is thread-safe for multiple readers (no enumerations) *and* single writer. So looked like a good fit for this specific scenario with tradeoff on locking only writers in exchange on a cheap `Count` property.","created_at":"2016-10-19T21:13:56Z","updated_at":"2016-10-19T21:13:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog/pulls/883/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog/pulls/883/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/883/comments","statuses_url":"https://api.github.com/repos/serilog/serilog/statuses/97f297c288557034ff99ff13eabcd7ad36f261b0","head":{"label":"skomis-mm:msgtplcache","ref":"msgtplcache","sha":"97f297c288557034ff99ff13eabcd7ad36f261b0","user":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"repo":{"id":60272546,"name":"serilog","full_name":"skomis-mm/serilog","owner":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skomis-mm/serilog","description":"Simple .NET logging with fully-structured events","fork":true,"url":"https://api.github.com/repos/skomis-mm/serilog","forks_url":"https://api.github.com/repos/skomis-mm/serilog/forks","keys_url":"https://api.github.com/repos/skomis-mm/serilog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skomis-mm/serilog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skomis-mm/serilog/teams","hooks_url":"https://api.github.com/repos/skomis-mm/serilog/hooks","issue_events_url":"https://api.github.com/repos/skomis-mm/serilog/issues/events{/number}","events_url":"https://api.github.com/repos/skomis-mm/serilog/events","assignees_url":"https://api.github.com/repos/skomis-mm/serilog/assignees{/user}","branches_url":"https://api.github.com/repos/skomis-mm/serilog/branches{/branch}","tags_url":"https://api.github.com/repos/skomis-mm/serilog/tags","blobs_url":"https://api.github.com/repos/skomis-mm/serilog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skomis-mm/serilog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skomis-mm/serilog/git/refs{/sha}","trees_url":"https://api.github.com/repos/skomis-mm/serilog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skomis-mm/serilog/statuses/{sha}","languages_url":"https://api.github.com/repos/skomis-mm/serilog/languages","stargazers_url":"https://api.github.com/repos/skomis-mm/serilog/stargazers","contributors_url":"https://api.github.com/repos/skomis-mm/serilog/contributors","subscribers_url":"https://api.github.com/repos/skomis-mm/serilog/subscribers","subscription_url":"https://api.github.com/repos/skomis-mm/serilog/subscription","commits_url":"https://api.github.com/repos/skomis-mm/serilog/commits{/sha}","git_commits_url":"https://api.github.com/repos/skomis-mm/serilog/git/commits{/sha}","comments_url":"https://api.github.com/repos/skomis-mm/serilog/comments{/number}","issue_comment_url":"https://api.github.com/repos/skomis-mm/serilog/issues/comments{/number}","contents_url":"https://api.github.com/repos/skomis-mm/serilog/contents/{+path}","compare_url":"https://api.github.com/repos/skomis-mm/serilog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skomis-mm/serilog/merges","archive_url":"https://api.github.com/repos/skomis-mm/serilog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skomis-mm/serilog/downloads","issues_url":"https://api.github.com/repos/skomis-mm/serilog/issues{/number}","pulls_url":"https://api.github.com/repos/skomis-mm/serilog/pulls{/number}","milestones_url":"https://api.github.com/repos/skomis-mm/serilog/milestones{/number}","notifications_url":"https://api.github.com/repos/skomis-mm/serilog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skomis-mm/serilog/labels{/name}","releases_url":"https://api.github.com/repos/skomis-mm/serilog/releases{/id}","deployments_url":"https://api.github.com/repos/skomis-mm/serilog/deployments","created_at":"2016-06-02T14:50:27Z","updated_at":"2016-06-02T14:50:29Z","pushed_at":"2016-10-19T20:28:18Z","git_url":"git://github.com/skomis-mm/serilog.git","ssh_url":"git@github.com:skomis-mm/serilog.git","clone_url":"https://github.com/skomis-mm/serilog.git","svn_url":"https://github.com/skomis-mm/serilog","homepage":"http://serilog.net","size":75049,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"serilog:dev","ref":"dev","sha":"0c8f64611758e6611cb806ec9a3d2dbb03f192b3","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":8198511,"name":"serilog","full_name":"serilog/serilog","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog","description":"Simple .NET logging with fully-structured events","fork":false,"url":"https://api.github.com/repos/serilog/serilog","forks_url":"https://api.github.com/repos/serilog/serilog/forks","keys_url":"https://api.github.com/repos/serilog/serilog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog/teams","hooks_url":"https://api.github.com/repos/serilog/serilog/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog/events","assignees_url":"https://api.github.com/repos/serilog/serilog/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog/tags","blobs_url":"https://api.github.com/repos/serilog/serilog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog/subscription","commits_url":"https://api.github.com/repos/serilog/serilog/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog/merges","archive_url":"https://api.github.com/repos/serilog/serilog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog/downloads","issues_url":"https://api.github.com/repos/serilog/serilog/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog/deployments","created_at":"2013-02-14T11:44:03Z","updated_at":"2016-10-19T15:14:17Z","pushed_at":"2016-10-19T21:13:56Z","git_url":"git://github.com/serilog/serilog.git","ssh_url":"git@github.com:serilog/serilog.git","clone_url":"https://github.com/serilog/serilog.git","svn_url":"https://github.com/serilog/serilog","homepage":"https://serilog.net","size":93231,"stargazers_count":1031,"watchers_count":1031,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":290,"mirror_url":null,"open_issues_count":24,"forks":290,"open_issues":24,"watchers":1031,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog/pulls/883"},"html":{"href":"https://github.com/serilog/serilog/pull/883"},"issue":{"href":"https://api.github.com/repos/serilog/serilog/issues/883"},"comments":{"href":"https://api.github.com/repos/serilog/serilog/issues/883/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog/pulls/883/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog/pulls/883/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog/statuses/97f297c288557034ff99ff13eabcd7ad36f261b0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":472,"deletions":11,"changed_files":14}}
{"actor":{"display_login":"skomis-mm"}}