{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-cmark/issues/1","repository_url":"https://api.github.com/repos/apple/swift-cmark","labels_url":"https://api.github.com/repos/apple/swift-cmark/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-cmark/issues/1/comments","events_url":"https://api.github.com/repos/apple/swift-cmark/issues/1/events","html_url":"https://github.com/apple/swift-cmark/pull/1","id":188261169,"number":1,"title":"Fix CMAKE_C_VISIBILITY_PRESET for cmake versions greater than 1.8","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-09T14:32:20Z","updated_at":"2016-11-09T17:07:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift-cmark/pulls/1","html_url":"https://github.com/apple/swift-cmark/pull/1","diff_url":"https://github.com/apple/swift-cmark/pull/1.diff","patch_url":"https://github.com/apple/swift-cmark/pull/1.patch"},"body":"This lets us build swift-cmark on Windows, using clang-cl\r\n\r\nThis was an oversight: CMAKE_C_VISIBILITY_PRESET is only available on CMAKE 1.8 or greater. However, the current check doesn't work for a version such as CMAKE 3.6.2, for example.\r\n\r\nIf this is not added, we get an error: `error: unknown argument: '-fvisibility=hidden'`\r\n\r\n```bash\r\nmkdir \"C:/Users/hughb/Documents/GitHub/my-swift/build/Ninja-DebugAssert/cmark-windows-amd64\"\r\npushd \"C:/Users/hughb/Documents/GitHub/my-swift/build/Ninja-DebugAssert/cmark-windows-amd64\"\r\ncmake -G Ninja -DCMAKE_C_COMPILER=\"C:/Program Files/LLVM/msbuild-bin/cl.exe\" -DCMAKE_CXX_COMPILER=\"C:/Program Files/LLVM/msbuild-bin/cl.exe\" -DCMAKE_CXX_FLAGS=\"-Xclang -std=c++14\" \"C:/Users/hughb/Documents/GitHub/my-swift/cmark\"\r\npopd\r\ncmake --build \"C:/Users/hughb/Documents/GitHub/my-swift/build/Ninja-DebugAssert/cmark-windows-amd64/\" -- -j6 all\r\n```\r\n\r\n@jrose-apple could you help triage this :)"},"comment":{"url":"https://api.github.com/repos/apple/swift-cmark/issues/comments/259467936","html_url":"https://github.com/apple/swift-cmark/pull/1#issuecomment-259467936","issue_url":"https://api.github.com/repos/apple/swift-cmark/issues/1","id":259467936,"user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T17:07:02Z","updated_at":"2016-11-09T17:07:02Z","body":"Heh. Merged almost immediately upstream, so I'll merge here too. (We should probably consider pulling from upstream soon.)"}}
{"actor":{"display_login":"jrose-apple"}}