{"action":"created","comment":{"url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/comments/64379074","id":64379074,"diff_hunk":"@@ -51,7 +51,7 @@ def setup_ftp(self):\n         handler.abstracted_fs = UnifiedFilesystem\n         handler.abstracted_fs.basepaths = basepaths\n         authorizer.add_anonymous(basepaths[0])\n-        address = (self.config['ftp.host'], self.config['ftp.port'])\n+        address = ('', self.config['ftp.port'])","path":"lftp/ftpserver.py","position":null,"original_position":5,"commit_id":"7f1e788ff39cc169ace07e28860a9f1197949557","original_commit_id":"34919759ce199ac99081ba7be55caff1ba4e5b32","user":{"login":"foxbunny","id":65413,"avatar_url":"https://avatars.githubusercontent.com/u/65413?v=3","gravatar_id":"","url":"https://api.github.com/users/foxbunny","html_url":"https://github.com/foxbunny","followers_url":"https://api.github.com/users/foxbunny/followers","following_url":"https://api.github.com/users/foxbunny/following{/other_user}","gists_url":"https://api.github.com/users/foxbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/foxbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxbunny/subscriptions","organizations_url":"https://api.github.com/users/foxbunny/orgs","repos_url":"https://api.github.com/users/foxbunny/repos","events_url":"https://api.github.com/users/foxbunny/events{/privacy}","received_events_url":"https://api.github.com/users/foxbunny/received_events","type":"User","site_admin":false},"body":"Actually, you're right, it should listen on all interfaces.","created_at":"2016-05-24T12:10:44Z","updated_at":"2016-05-24T12:10:44Z","html_url":"https://github.com/Outernet-Project/lftp/pull/2#discussion_r64379074","pull_request_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/comments/64379074"},"html":{"href":"https://github.com/Outernet-Project/lftp/pull/2#discussion_r64379074"},"pull_request":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2","id":71207207,"html_url":"https://github.com/Outernet-Project/lftp/pull/2","diff_url":"https://github.com/Outernet-Project/lftp/pull/2.diff","patch_url":"https://github.com/Outernet-Project/lftp/pull/2.patch","issue_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/2","number":2,"state":"open","locked":false,"title":"Convert LFTP from a standalone application to a Librarian component","user":{"login":"goodbadwolf","id":154797,"avatar_url":"https://avatars.githubusercontent.com/u/154797?v=3","gravatar_id":"","url":"https://api.github.com/users/goodbadwolf","html_url":"https://github.com/goodbadwolf","followers_url":"https://api.github.com/users/goodbadwolf/followers","following_url":"https://api.github.com/users/goodbadwolf/following{/other_user}","gists_url":"https://api.github.com/users/goodbadwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/goodbadwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodbadwolf/subscriptions","organizations_url":"https://api.github.com/users/goodbadwolf/orgs","repos_url":"https://api.github.com/users/goodbadwolf/repos","events_url":"https://api.github.com/users/goodbadwolf/events{/privacy}","received_events_url":"https://api.github.com/users/goodbadwolf/received_events","type":"User","site_admin":false},"body":"LFTP is best served as a Librarian component, sharing the python interpreter & runtime, thereby reducing RAM pressure on devices with less RAM. \r\n\r\nThis PR converts the standalone application to a librarian component, with following changes: \r\n- Removing the control server & client classes and the corresponding socket IPC.\r\n- Adding a dashboard plugin\r\n- Using settings mechanism provided by librarian-settings (via supervisor extensions)","created_at":"2016-05-24T12:01:21Z","updated_at":"2016-05-24T12:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"848cb96fc098db110b5dc7f3d4393625db26467e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/2/comments","statuses_url":"https://api.github.com/repos/Outernet-Project/lftp/statuses/7f1e788ff39cc169ace07e28860a9f1197949557","head":{"label":"Outernet-Project:feature/librarian-component-conversion","ref":"feature/librarian-component-conversion","sha":"7f1e788ff39cc169ace07e28860a9f1197949557","user":{"login":"Outernet-Project","id":6324442,"avatar_url":"https://avatars.githubusercontent.com/u/6324442?v=3","gravatar_id":"","url":"https://api.github.com/users/Outernet-Project","html_url":"https://github.com/Outernet-Project","followers_url":"https://api.github.com/users/Outernet-Project/followers","following_url":"https://api.github.com/users/Outernet-Project/following{/other_user}","gists_url":"https://api.github.com/users/Outernet-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Outernet-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Outernet-Project/subscriptions","organizations_url":"https://api.github.com/users/Outernet-Project/orgs","repos_url":"https://api.github.com/users/Outernet-Project/repos","events_url":"https://api.github.com/users/Outernet-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Outernet-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":59200357,"name":"lftp","full_name":"Outernet-Project/lftp","owner":{"login":"Outernet-Project","id":6324442,"avatar_url":"https://avatars.githubusercontent.com/u/6324442?v=3","gravatar_id":"","url":"https://api.github.com/users/Outernet-Project","html_url":"https://github.com/Outernet-Project","followers_url":"https://api.github.com/users/Outernet-Project/followers","following_url":"https://api.github.com/users/Outernet-Project/following{/other_user}","gists_url":"https://api.github.com/users/Outernet-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Outernet-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Outernet-Project/subscriptions","organizations_url":"https://api.github.com/users/Outernet-Project/orgs","repos_url":"https://api.github.com/users/Outernet-Project/repos","events_url":"https://api.github.com/users/Outernet-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Outernet-Project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Outernet-Project/lftp","description":"FTP server application","fork":false,"url":"https://api.github.com/repos/Outernet-Project/lftp","forks_url":"https://api.github.com/repos/Outernet-Project/lftp/forks","keys_url":"https://api.github.com/repos/Outernet-Project/lftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Outernet-Project/lftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Outernet-Project/lftp/teams","hooks_url":"https://api.github.com/repos/Outernet-Project/lftp/hooks","issue_events_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/events{/number}","events_url":"https://api.github.com/repos/Outernet-Project/lftp/events","assignees_url":"https://api.github.com/repos/Outernet-Project/lftp/assignees{/user}","branches_url":"https://api.github.com/repos/Outernet-Project/lftp/branches{/branch}","tags_url":"https://api.github.com/repos/Outernet-Project/lftp/tags","blobs_url":"https://api.github.com/repos/Outernet-Project/lftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Outernet-Project/lftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Outernet-Project/lftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Outernet-Project/lftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Outernet-Project/lftp/statuses/{sha}","languages_url":"https://api.github.com/repos/Outernet-Project/lftp/languages","stargazers_url":"https://api.github.com/repos/Outernet-Project/lftp/stargazers","contributors_url":"https://api.github.com/repos/Outernet-Project/lftp/contributors","subscribers_url":"https://api.github.com/repos/Outernet-Project/lftp/subscribers","subscription_url":"https://api.github.com/repos/Outernet-Project/lftp/subscription","commits_url":"https://api.github.com/repos/Outernet-Project/lftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Outernet-Project/lftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Outernet-Project/lftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Outernet-Project/lftp/contents/{+path}","compare_url":"https://api.github.com/repos/Outernet-Project/lftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Outernet-Project/lftp/merges","archive_url":"https://api.github.com/repos/Outernet-Project/lftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Outernet-Project/lftp/downloads","issues_url":"https://api.github.com/repos/Outernet-Project/lftp/issues{/number}","pulls_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls{/number}","milestones_url":"https://api.github.com/repos/Outernet-Project/lftp/milestones{/number}","notifications_url":"https://api.github.com/repos/Outernet-Project/lftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Outernet-Project/lftp/labels{/name}","releases_url":"https://api.github.com/repos/Outernet-Project/lftp/releases{/id}","deployments_url":"https://api.github.com/repos/Outernet-Project/lftp/deployments","created_at":"2016-05-19T11:31:03Z","updated_at":"2016-05-19T11:33:47Z","pushed_at":"2016-05-24T12:01:21Z","git_url":"git://github.com/Outernet-Project/lftp.git","ssh_url":"git@github.com:Outernet-Project/lftp.git","clone_url":"https://github.com/Outernet-Project/lftp.git","svn_url":"https://github.com/Outernet-Project/lftp","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Outernet-Project:develop","ref":"develop","sha":"9bd5b8529e4f37381b9fbe0da776ff2e40947fdb","user":{"login":"Outernet-Project","id":6324442,"avatar_url":"https://avatars.githubusercontent.com/u/6324442?v=3","gravatar_id":"","url":"https://api.github.com/users/Outernet-Project","html_url":"https://github.com/Outernet-Project","followers_url":"https://api.github.com/users/Outernet-Project/followers","following_url":"https://api.github.com/users/Outernet-Project/following{/other_user}","gists_url":"https://api.github.com/users/Outernet-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Outernet-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Outernet-Project/subscriptions","organizations_url":"https://api.github.com/users/Outernet-Project/orgs","repos_url":"https://api.github.com/users/Outernet-Project/repos","events_url":"https://api.github.com/users/Outernet-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Outernet-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":59200357,"name":"lftp","full_name":"Outernet-Project/lftp","owner":{"login":"Outernet-Project","id":6324442,"avatar_url":"https://avatars.githubusercontent.com/u/6324442?v=3","gravatar_id":"","url":"https://api.github.com/users/Outernet-Project","html_url":"https://github.com/Outernet-Project","followers_url":"https://api.github.com/users/Outernet-Project/followers","following_url":"https://api.github.com/users/Outernet-Project/following{/other_user}","gists_url":"https://api.github.com/users/Outernet-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Outernet-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Outernet-Project/subscriptions","organizations_url":"https://api.github.com/users/Outernet-Project/orgs","repos_url":"https://api.github.com/users/Outernet-Project/repos","events_url":"https://api.github.com/users/Outernet-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Outernet-Project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Outernet-Project/lftp","description":"FTP server application","fork":false,"url":"https://api.github.com/repos/Outernet-Project/lftp","forks_url":"https://api.github.com/repos/Outernet-Project/lftp/forks","keys_url":"https://api.github.com/repos/Outernet-Project/lftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Outernet-Project/lftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Outernet-Project/lftp/teams","hooks_url":"https://api.github.com/repos/Outernet-Project/lftp/hooks","issue_events_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/events{/number}","events_url":"https://api.github.com/repos/Outernet-Project/lftp/events","assignees_url":"https://api.github.com/repos/Outernet-Project/lftp/assignees{/user}","branches_url":"https://api.github.com/repos/Outernet-Project/lftp/branches{/branch}","tags_url":"https://api.github.com/repos/Outernet-Project/lftp/tags","blobs_url":"https://api.github.com/repos/Outernet-Project/lftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Outernet-Project/lftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Outernet-Project/lftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Outernet-Project/lftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Outernet-Project/lftp/statuses/{sha}","languages_url":"https://api.github.com/repos/Outernet-Project/lftp/languages","stargazers_url":"https://api.github.com/repos/Outernet-Project/lftp/stargazers","contributors_url":"https://api.github.com/repos/Outernet-Project/lftp/contributors","subscribers_url":"https://api.github.com/repos/Outernet-Project/lftp/subscribers","subscription_url":"https://api.github.com/repos/Outernet-Project/lftp/subscription","commits_url":"https://api.github.com/repos/Outernet-Project/lftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Outernet-Project/lftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Outernet-Project/lftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Outernet-Project/lftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Outernet-Project/lftp/contents/{+path}","compare_url":"https://api.github.com/repos/Outernet-Project/lftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Outernet-Project/lftp/merges","archive_url":"https://api.github.com/repos/Outernet-Project/lftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Outernet-Project/lftp/downloads","issues_url":"https://api.github.com/repos/Outernet-Project/lftp/issues{/number}","pulls_url":"https://api.github.com/repos/Outernet-Project/lftp/pulls{/number}","milestones_url":"https://api.github.com/repos/Outernet-Project/lftp/milestones{/number}","notifications_url":"https://api.github.com/repos/Outernet-Project/lftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Outernet-Project/lftp/labels{/name}","releases_url":"https://api.github.com/repos/Outernet-Project/lftp/releases{/id}","deployments_url":"https://api.github.com/repos/Outernet-Project/lftp/deployments","created_at":"2016-05-19T11:31:03Z","updated_at":"2016-05-19T11:33:47Z","pushed_at":"2016-05-24T12:01:21Z","git_url":"git://github.com/Outernet-Project/lftp.git","ssh_url":"git@github.com:Outernet-Project/lftp.git","clone_url":"https://github.com/Outernet-Project/lftp.git","svn_url":"https://github.com/Outernet-Project/lftp","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2"},"html":{"href":"https://github.com/Outernet-Project/lftp/pull/2"},"issue":{"href":"https://api.github.com/repos/Outernet-Project/lftp/issues/2"},"comments":{"href":"https://api.github.com/repos/Outernet-Project/lftp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Outernet-Project/lftp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Outernet-Project/lftp/statuses/7f1e788ff39cc169ace07e28860a9f1197949557"}}}}
{"actor":{"display_login":"foxbunny"}}