{"push_id":1309854389,"size":88,"distinct_size":88,"ref":"refs/heads/dev/FT/opensource","head":"527b4df7342a193d7073424c354fe0a955bb5036","before":"7a846b84cfe312698490277a8ad270780046546c","commits":[{"sha":"17fdcc0c3f87ac0e8e1ab6ddea0aa6c1741c6cdb","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Coding style: Use the 'eslint-config' package\n\nWe created a new common `eslint-config` npm package [1] for all\nrepositories to share the same linting rules. Now checking the code\nstyle can be done with:\n\n    node_modules/.bin/eslint $(git ls-files '*.js')\n\nor:\n\n    npm run --silent lint","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/17fdcc0c3f87ac0e8e1ab6ddea0aa6c1741c6cdb"},{"sha":"21a4762dac67d8343fcb158c62f0b9c380f72389","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Do not `git submodule' Kinetic/kinetic-protocol\n\nThe Kinetic code depends on the `kinetic.proto` declaration file, which\nis sourced from a git submodule. Problem: when Arsenal / Kinetic is\ninstalled with npm (as a dependency for another project such as\nIronMan-Data), submobules are not cloned and `kinetic.proto` is missing.\n\nSince we only need the `kinetic.proto` file from\nKinetic/kinetic-protocol, and this specification is not supposed to\nchange, let's copy it in our repo and drop the annoying submodule\ndependency.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/21a4762dac67d8343fcb158c62f0b9c380f72389"},{"sha":"90c05e2c6b7ce5127801ed0f6e32a18dc9c8cf4b","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Fix missing parenthesis in Kinetic.parse\n\nMessage parsing currently doesn't work because `Kinetic.getChunkSize` is\ncompared to an integer. What we really want is `Kinetic.getChunkSize()`\nto get the integer value.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/90c05e2c6b7ce5127801ed0f6e32a18dc9c8cf4b"},{"sha":"55ef9266c8a1b07b99b328fcc502e361420139ca","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Coding style: Fix error causing linter to fail\n\nFor a few days, linting tests have began checking spaces before\nkeywords. This revealed a hidden coding style error in a js file, and\nprevents new pull requests to pass.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/55ef9266c8a1b07b99b328fcc502e361420139ca"},{"sha":"7efffda870fc9379487c3dd012c53df7ba55e5fd","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"CI: Remove unneeded gcc/g++ installation\n\nThe Arsenal code base currently does not contain any C or C++ code.\nTherefore, installing gcc and g++ during builds is useless and resource\nwasting.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/7efffda870fc9379487c3dd012c53df7ba55e5fd"},{"sha":"fb48918191e76a49bd483d2a70b8589925be5efd","author":{"name":"Antonin Coulibaly","email":"20d85eb906522dd9053b25e33895e7520e1085a2@scality.com"},"message":"FT(kinetic) add simulator and corresponding tests\n\n* simulator submodule:\n  - git submodule sync\n  - git submodule update --init\n* npm scripts for setting the simulator with the kinetic-java submodule\n  - npm run setupSimulator (set the simulator, need mvn)\n  - npm run startSimulator (start the simulator)\n  - npm run simultest (the firsts tests verified the simulator response)","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/fb48918191e76a49bd483d2a70b8589925be5efd"},{"sha":"a3277a4a43de34b66834a99ba62fc1c4621b4914","author":{"name":"Antonin Coulibaly","email":"20d85eb906522dd9053b25e33895e7520e1085a2@scality.com"},"message":"FT(kinetic) Implement kinetic simul compatibility\n\n* Implement the HMAC computer when creating protobuf message\n* Implement better hmacIntegrity\n* Implement simlator tests\n* Update old tests\n* Update package.json (scripts and dependencies)\n* Update documentation\n* Add the HMAC compute in the pb message builder","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/a3277a4a43de34b66834a99ba62fc1c4621b4914"},{"sha":"a157846772e7445011272a552b406876fa1d7248","author":{"name":"Antonin Coulibaly","email":"20d85eb906522dd9053b25e33895e7520e1085a2@scality.com"},"message":"DOC(kinetic) Update the JSDoc with linter","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/a157846772e7445011272a552b406876fa1d7248"},{"sha":"e518298610bf285e73da5839a2bfcafd76be5a92","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Simulator: Use a Makefile to reduce build time\n\nUse a custom Makefile in tests/functional to run simulator tests. This\nMakefile ensures the git submodule `kinetic-java` is synced, installs\ndependencies if needed, launches the simulator and finally runs tests.\nOn finishing the simulator is cleaning shut down. Also, the Makefile\nmakes sure dependency steps are run only if needed.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/e518298610bf285e73da5839a2bfcafd76be5a92"},{"sha":"5c2973ff4ae31c431c53d9915de4ef58155046cc","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Simulator: Cache maven and .jar files for CI\n\nDownloading and building the simulator is a long step (~ minutes)\nbecause there are lots of .jar files to download and compose with.\nThis causes builds to last much longer than before. To palliate this,\nlet's add a `build_cache` Makefile directive and call it in an early\nstage of the build, so CircleCI can cache it for future builds.\n\nThis enhancement reduce `npm run tests_functional_simulator` duration\nfrom 174s to 3s.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/5c2973ff4ae31c431c53d9915de4ef58155046cc"},{"sha":"4ea65a3ffa3e276c29e0980b43d1ac25a30ad387","author":{"name":"Antonin Coulibaly","email":"20d85eb906522dd9053b25e33895e7520e1085a2@scality.com"},"message":"CLEANUP(kinetic) clean kinetic.js (code duplication)\n\n* Optimization of the message build for avoiding the code duplication\n  of setCommande().setMessage() finaly just 1 function is needed.\n* Clean the this.getProtobuf() called for nothing replace by\n  this._message.\n* Update API.md\n* Indentation","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/4ea65a3ffa3e276c29e0980b43d1ac25a30ad387"},{"sha":"e7b7c69bbbb33214c985730ea247b257103ad22e","author":{"name":"Antonin Coulibaly","email":"20d85eb906522dd9053b25e33895e7520e1085a2@scality.com"},"message":"DOC(kinetic) - Add TESTING.md\n\nExplain how the tests works","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/e7b7c69bbbb33214c985730ea247b257103ad22e"},{"sha":"db199c4c28f433c98481d3c52711c239a2578b08","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Fix Kinetic messages all failing except PUT and GET\n\nMessages that do not have a payload (example: NOOP, FLUSH) provoked\nexceptions because the Kinetic class didn't handle them.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/db199c4c28f433c98481d3c52711c239a2578b08"},{"sha":"023c7444ff3ab13718583a3ee094e03fc8b01726","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Rename `identity` var to `connectionID`\n\nThe `identity` field name already exists and references another\nproperty. Change this to avoid confusion.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/023c7444ff3ab13718583a3ee094e03fc8b01726"},{"sha":"4bce88f4d22ad760aec2c003dd0da8337a262aea","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Functional tests: Remove old tests (without simulator)\n\nOld tests were buggy (HMAC problems) and we don't have guarantees on the\nmessages contents validity. Now that we have trustable tests with a\nthird-party simulator, we don't need them anymore.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/4bce88f4d22ad760aec2c003dd0da8337a262aea"},{"sha":"fb665a37090537593ad15702f221f05af9d17af9","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Refactor Kinetic lib for static constants and PDU class\n\nBig refactor of the Kinetic library:\n- move constants out of instances (memory footprint)\n- give a proper name to instances (`Kinetic.PDU`)\n- modify tests consequently\n- document library usage in README.md\n\n    import Kinetic from 'Kinetic';\n\n    const rawData = new Buffer('\\x46\\x00\\x00\\x00\\x32\\x00');\n    const kineticPDU = new Kinetic.PDU(rawData);\n\n    const sock = net.connect(1234, 'localhost');\n    const ret = kineticPDU.send(sock);\n    if (ret !== Kinetic.errors.SUCCESS)\n        throw new Error(\"argh: \" + Kinetic.getErrorName(ret) + \"!\");\n\nFixes: #18","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/fb665a37090537593ad15702f221f05af9d17af9"},{"sha":"2f24897d5885c3a3e6da05db946b339712eb8561","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Remove the function to \"Compare two buffers\"\n\nThe Node.js standard `Buffer.equals()` already exists for that.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/2f24897d5885c3a3e6da05db946b339712eb8561"},{"sha":"fcfc7d4df841ecf385a250030e34d1e08c3fce71","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Improve HMAC related functions\n\n- Add a `_computeHMAC` function to avoid code duplication.\n- Have consistent return type in `hmacIntegrity` instead of returning\n  either `true` or `errors.HMAC_FAILURE`.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/fcfc7d4df841ecf385a250030e34d1e08c3fce71"},{"sha":"f1a6df19c6120174270b829040b37910d8387179","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Define PDU commands as classes\n\nCurrently to create a \"PUT\" Kinetic PDU, one must run:\n\n    const pdu = new Kinetic.PDU();\n    pdu.put();\n\nThis is not object-oriented programming, and is error-prone since\nwe don't expect commands like `put`, `flush` etc. to create messages\nwith a given type.\n\nThis patch creates classes that inherit from `PDU`, e.g. `PutPDU`,\n`GetPDU`, `GetLogPDU` etc. and that can be used the same way.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/f1a6df19c6120174270b829040b37910d8387179"},{"sha":"3a00182c82f9d17309995d45d8f9ae5b2573a7c9","author":{"name":"Adrien Vergé","email":"b2e367113b2301a057facb6bd0b3c0f3cfe5b2ba@scality.com"},"message":"Kinetic: Fix HMAC failure\n\nRemove an unneeded test that was provoking errors.HMAC when parsing\nKinetic PDUs.","distinct":true,"url":"https://api.github.com/repos/scality/kineticlib/commits/3a00182c82f9d17309995d45d8f9ae5b2573a7c9"}]}
{"actor":{"display_login":"AntoninCoulibaly"}}