{"action":"created","issue":{"url":"https://api.github.com/repos/brianmckeen/sqitch/issues/6","labels_url":"https://api.github.com/repos/brianmckeen/sqitch/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/brianmckeen/sqitch/issues/6/comments","events_url":"https://api.github.com/repos/brianmckeen/sqitch/issues/6/events","html_url":"https://github.com/brianmckeen/sqitch/pull/6","id":126929224,"number":6,"title":"Add driver logic to MSSQL engine.","user":{"login":"drmuey","id":1204812,"avatar_url":"https://avatars.githubusercontent.com/u/1204812?v=3","gravatar_id":"","url":"https://api.github.com/users/drmuey","html_url":"https://github.com/drmuey","followers_url":"https://api.github.com/users/drmuey/followers","following_url":"https://api.github.com/users/drmuey/following{/other_user}","gists_url":"https://api.github.com/users/drmuey/gists{/gist_id}","starred_url":"https://api.github.com/users/drmuey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmuey/subscriptions","organizations_url":"https://api.github.com/users/drmuey/orgs","repos_url":"https://api.github.com/users/drmuey/repos","events_url":"https://api.github.com/users/drmuey/events{/privacy}","received_events_url":"https://api.github.com/users/drmuey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-15T18:26:28Z","updated_at":"2016-01-18T13:20:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianmckeen/sqitch/pulls/6","html_url":"https://github.com/brianmckeen/sqitch/pull/6","diff_url":"https://github.com/brianmckeen/sqitch/pull/6.diff","patch_url":"https://github.com/brianmckeen/sqitch/pull/6.patch"},"body":"## Changes:\r\n\r\nNote sure why it is including the first 3 SHAs (2 from PR #4 and my fork update), these are the ones that it actually includes:\r\n\r\n* b620e51 Add driver logic to MSSQL engine.\r\n* 6abf98b Remove unused module Win32::SqlServer\r\n* 905bcb1 Address “Global symbol  requires explicit package name” error\r\n* c157b6a Add comment for later follow up\r\n* a7cc192 Run mssql.pm through perltidy\r\n\r\n## Testing:\r\n\r\n* prove -lw t/mod/App-Sqitch-Engine-mssql.t == All tests successful.\r\n\r\n## FWiW:\r\n\r\nWe still need (probably issues for)\r\n\r\n1. Typical engine tests for mssql.pm (which will be difficult for me to do ATM)\r\n2. POD for new()’s _driver attr (or do we?)\r\n3. Determine if the `?how does $uri->dbi_dsn know what $self->driver to use?` comment is a thing or not.\r\n4. Determine if the `this being necessary seems like a bug, no?` comment is a thing or not."},"comment":{"url":"https://api.github.com/repos/brianmckeen/sqitch/issues/comments/172525909","html_url":"https://github.com/brianmckeen/sqitch/pull/6#issuecomment-172525909","issue_url":"https://api.github.com/repos/brianmckeen/sqitch/issues/6","id":172525909,"user":{"login":"drmuey","id":1204812,"avatar_url":"https://avatars.githubusercontent.com/u/1204812?v=3","gravatar_id":"","url":"https://api.github.com/users/drmuey","html_url":"https://github.com/drmuey","followers_url":"https://api.github.com/users/drmuey/followers","following_url":"https://api.github.com/users/drmuey/following{/other_user}","gists_url":"https://api.github.com/users/drmuey/gists{/gist_id}","starred_url":"https://api.github.com/users/drmuey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmuey/subscriptions","organizations_url":"https://api.github.com/users/drmuey/orgs","repos_url":"https://api.github.com/users/drmuey/repos","events_url":"https://api.github.com/users/drmuey/events{/privacy}","received_events_url":"https://api.github.com/users/drmuey/received_events","type":"User","site_admin":false},"created_at":"2016-01-18T13:20:49Z","updated_at":"2016-01-18T13:20:49Z","body":"@theory \r\n\r\nI'll see what I can do, @brianmckeen do you want the DSN part as part if this pull request or are you OK with it being separate?"}}