{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/32576","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/32576/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/32576/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/32576/events","html_url":"https://github.com/rust-lang/rust/pull/32576","id":144299470,"number":32576,"title":"mk: Fix cross-host builds","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-29T15:27:20Z","updated_at":"2016-03-29T18:21:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/32576","html_url":"https://github.com/rust-lang/rust/pull/32576","diff_url":"https://github.com/rust-lang/rust/pull/32576.diff","patch_url":"https://github.com/rust-lang/rust/pull/32576.patch"},"body":"The change in b20e748 had the unintended consequence of breaking cross-host\r\nbuilds as we apparently relied on the incorrect definition of this variable in\r\nthe makefiles. That change, however, was required to get tests passing so we\r\ncouldn't just revert it.\r\n\r\nThis commit fixes the underlying bug by leaving the \"more correct\" definition of\r\n`LD_LIBRARY_PATH_ENV_TARGETDIR` (also fixing it with a hardcoded reference to\r\n`CFG_BUILD`) and updating the `RPATH_VAR` definition below. Turned out we\r\nalready had special-casing logic for passing `--cfg stage1` during the\r\nwell-we-print-this-as-stage0 build of a cross-host. That logic was just updated\r\nto pull from a different variable as opposed to relying on the definition of\r\nthat variable to accommodate this.\r\n\r\nCloses #32568"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/203036700","html_url":"https://github.com/rust-lang/rust/pull/32576#issuecomment-203036700","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/32576","id":203036700,"user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T18:21:44Z","updated_at":"2016-03-29T18:21:44Z","body":"@bors r+ p=1"}}