{"action":"created","comment":{"url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/comments/85697453","pull_request_review_id":6397568,"id":85697453,"diff_hunk":"@@ -75,29 +33,71 @@ public override Script CombineScriptSig(Script scriptPubKey, Script a, Script b)\n \t\t\tvar para = PayToMultiSigTemplate.Instance.ExtractScriptPubKeyParameters(scriptPubKey);\r\n \t\t\t// Combine all the signatures we've got:\r\n \t\t\tvar aSigs = PayToMultiSigTemplate.Instance.ExtractScriptSigParameters(a);\r\n-\t\t\tif(aSigs == null)\r\n+\t\t\tif (aSigs == null)\r\n \t\t\t\treturn b;\r\n \t\t\tvar bSigs = PayToMultiSigTemplate.Instance.ExtractScriptSigParameters(b);\r\n-\t\t\tif(bSigs == null)\r\n+\t\t\tif (bSigs == null)\r\n \t\t\t\treturn a;\r\n \t\t\tint pubkeyCount = 0;\r\n \t\t\tTransactionSignature[] sigs = new TransactionSignature[para.PubKeys.Length];\r\n-\t\t\tfor(int i = 0; i < para.PubKeys.Length; i++)\r\n+\t\t\tfor (int i = 0; i < para.PubKeys.Length; i++)\r","path":"NBitcoin/BuilderExtensions/P2MultiSigBuilderExtension.cs","position":84,"original_position":84,"commit_id":"c5e69d6d4f719ce916b50712325bad5252ec4799","original_commit_id":"c5e69d6d4f719ce916b50712325bad5252ec4799","user":{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars.githubusercontent.com/u/3020646?v=3","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"body":"can you fix those spaces after for and if ?","created_at":"2016-10-31T08:15:43Z","updated_at":"2016-10-31T08:15:43Z","html_url":"https://github.com/MetacoSA/NBitcoin/pull/199#discussion_r85697453","pull_request_url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/comments/85697453"},"html":{"href":"https://github.com/MetacoSA/NBitcoin/pull/199#discussion_r85697453"},"pull_request":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199","id":91327345,"html_url":"https://github.com/MetacoSA/NBitcoin/pull/199","diff_url":"https://github.com/MetacoSA/NBitcoin/pull/199.diff","patch_url":"https://github.com/MetacoSA/NBitcoin/pull/199.patch","issue_url":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/199","number":199,"state":"open","locked":false,"title":"Minor cosmetics (inconsistent naming and method order)","user":{"login":"nopara73","id":9156103,"avatar_url":"https://avatars.githubusercontent.com/u/9156103?v=3","gravatar_id":"","url":"https://api.github.com/users/nopara73","html_url":"https://github.com/nopara73","followers_url":"https://api.github.com/users/nopara73/followers","following_url":"https://api.github.com/users/nopara73/following{/other_user}","gists_url":"https://api.github.com/users/nopara73/gists{/gist_id}","starred_url":"https://api.github.com/users/nopara73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopara73/subscriptions","organizations_url":"https://api.github.com/users/nopara73/orgs","repos_url":"https://api.github.com/users/nopara73/repos","events_url":"https://api.github.com/users/nopara73/events{/privacy}","received_events_url":"https://api.github.com/users/nopara73/received_events","type":"User","site_admin":false},"body":"Just minor cosmetics refactoring. I felt like it's a good way to get familiar with these classes.\n\n-Fix inconsistent method parameter naming inside the BuilderExtension child classes (sometimes scriptPubkey is used instead of scriptPubKey)\n\n-Reorder methods of BuilderExtension child classes to be present in the same order as in  the BuilderExtension base class\n","created_at":"2016-10-28T06:13:00Z","updated_at":"2016-10-31T08:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09fd73bf135a9b37062759b1ddef1262c8a30540","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199/commits","review_comments_url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199/comments","review_comment_url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/199/comments","statuses_url":"https://api.github.com/repos/MetacoSA/NBitcoin/statuses/c5e69d6d4f719ce916b50712325bad5252ec4799","head":{"label":"nopara73:master","ref":"master","sha":"c5e69d6d4f719ce916b50712325bad5252ec4799","user":{"login":"nopara73","id":9156103,"avatar_url":"https://avatars.githubusercontent.com/u/9156103?v=3","gravatar_id":"","url":"https://api.github.com/users/nopara73","html_url":"https://github.com/nopara73","followers_url":"https://api.github.com/users/nopara73/followers","following_url":"https://api.github.com/users/nopara73/following{/other_user}","gists_url":"https://api.github.com/users/nopara73/gists{/gist_id}","starred_url":"https://api.github.com/users/nopara73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopara73/subscriptions","organizations_url":"https://api.github.com/users/nopara73/orgs","repos_url":"https://api.github.com/users/nopara73/repos","events_url":"https://api.github.com/users/nopara73/events{/privacy}","received_events_url":"https://api.github.com/users/nopara73/received_events","type":"User","site_admin":false},"repo":{"id":72178378,"name":"NBitcoin","full_name":"nopara73/NBitcoin","owner":{"login":"nopara73","id":9156103,"avatar_url":"https://avatars.githubusercontent.com/u/9156103?v=3","gravatar_id":"","url":"https://api.github.com/users/nopara73","html_url":"https://github.com/nopara73","followers_url":"https://api.github.com/users/nopara73/followers","following_url":"https://api.github.com/users/nopara73/following{/other_user}","gists_url":"https://api.github.com/users/nopara73/gists{/gist_id}","starred_url":"https://api.github.com/users/nopara73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopara73/subscriptions","organizations_url":"https://api.github.com/users/nopara73/orgs","repos_url":"https://api.github.com/users/nopara73/repos","events_url":"https://api.github.com/users/nopara73/events{/privacy}","received_events_url":"https://api.github.com/users/nopara73/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nopara73/NBitcoin","description":"Comprehensive Bitcoin library for the .NET framework.","fork":true,"url":"https://api.github.com/repos/nopara73/NBitcoin","forks_url":"https://api.github.com/repos/nopara73/NBitcoin/forks","keys_url":"https://api.github.com/repos/nopara73/NBitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nopara73/NBitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nopara73/NBitcoin/teams","hooks_url":"https://api.github.com/repos/nopara73/NBitcoin/hooks","issue_events_url":"https://api.github.com/repos/nopara73/NBitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/nopara73/NBitcoin/events","assignees_url":"https://api.github.com/repos/nopara73/NBitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/nopara73/NBitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/nopara73/NBitcoin/tags","blobs_url":"https://api.github.com/repos/nopara73/NBitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nopara73/NBitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nopara73/NBitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nopara73/NBitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nopara73/NBitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/nopara73/NBitcoin/languages","stargazers_url":"https://api.github.com/repos/nopara73/NBitcoin/stargazers","contributors_url":"https://api.github.com/repos/nopara73/NBitcoin/contributors","subscribers_url":"https://api.github.com/repos/nopara73/NBitcoin/subscribers","subscription_url":"https://api.github.com/repos/nopara73/NBitcoin/subscription","commits_url":"https://api.github.com/repos/nopara73/NBitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nopara73/NBitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nopara73/NBitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nopara73/NBitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nopara73/NBitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/nopara73/NBitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nopara73/NBitcoin/merges","archive_url":"https://api.github.com/repos/nopara73/NBitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nopara73/NBitcoin/downloads","issues_url":"https://api.github.com/repos/nopara73/NBitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/nopara73/NBitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/nopara73/NBitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/nopara73/NBitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nopara73/NBitcoin/labels{/name}","releases_url":"https://api.github.com/repos/nopara73/NBitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/nopara73/NBitcoin/deployments","created_at":"2016-10-28T06:03:46Z","updated_at":"2016-10-28T06:03:48Z","pushed_at":"2016-10-29T05:28:59Z","git_url":"git://github.com/nopara73/NBitcoin.git","ssh_url":"git@github.com:nopara73/NBitcoin.git","clone_url":"https://github.com/nopara73/NBitcoin.git","svn_url":"https://github.com/nopara73/NBitcoin","homepage":"","size":38802,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MetacoSA:master","ref":"master","sha":"d9db954ee281e547d98e55480abe418b3d423810","user":{"login":"MetacoSA","id":13436162,"avatar_url":"https://avatars.githubusercontent.com/u/13436162?v=3","gravatar_id":"","url":"https://api.github.com/users/MetacoSA","html_url":"https://github.com/MetacoSA","followers_url":"https://api.github.com/users/MetacoSA/followers","following_url":"https://api.github.com/users/MetacoSA/following{/other_user}","gists_url":"https://api.github.com/users/MetacoSA/gists{/gist_id}","starred_url":"https://api.github.com/users/MetacoSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetacoSA/subscriptions","organizations_url":"https://api.github.com/users/MetacoSA/orgs","repos_url":"https://api.github.com/users/MetacoSA/repos","events_url":"https://api.github.com/users/MetacoSA/events{/privacy}","received_events_url":"https://api.github.com/users/MetacoSA/received_events","type":"Organization","site_admin":false},"repo":{"id":18596168,"name":"NBitcoin","full_name":"MetacoSA/NBitcoin","owner":{"login":"MetacoSA","id":13436162,"avatar_url":"https://avatars.githubusercontent.com/u/13436162?v=3","gravatar_id":"","url":"https://api.github.com/users/MetacoSA","html_url":"https://github.com/MetacoSA","followers_url":"https://api.github.com/users/MetacoSA/followers","following_url":"https://api.github.com/users/MetacoSA/following{/other_user}","gists_url":"https://api.github.com/users/MetacoSA/gists{/gist_id}","starred_url":"https://api.github.com/users/MetacoSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetacoSA/subscriptions","organizations_url":"https://api.github.com/users/MetacoSA/orgs","repos_url":"https://api.github.com/users/MetacoSA/repos","events_url":"https://api.github.com/users/MetacoSA/events{/privacy}","received_events_url":"https://api.github.com/users/MetacoSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetacoSA/NBitcoin","description":"Comprehensive Bitcoin library for the .NET framework.","fork":false,"url":"https://api.github.com/repos/MetacoSA/NBitcoin","forks_url":"https://api.github.com/repos/MetacoSA/NBitcoin/forks","keys_url":"https://api.github.com/repos/MetacoSA/NBitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetacoSA/NBitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetacoSA/NBitcoin/teams","hooks_url":"https://api.github.com/repos/MetacoSA/NBitcoin/hooks","issue_events_url":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MetacoSA/NBitcoin/events","assignees_url":"https://api.github.com/repos/MetacoSA/NBitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MetacoSA/NBitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MetacoSA/NBitcoin/tags","blobs_url":"https://api.github.com/repos/MetacoSA/NBitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetacoSA/NBitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetacoSA/NBitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetacoSA/NBitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetacoSA/NBitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MetacoSA/NBitcoin/languages","stargazers_url":"https://api.github.com/repos/MetacoSA/NBitcoin/stargazers","contributors_url":"https://api.github.com/repos/MetacoSA/NBitcoin/contributors","subscribers_url":"https://api.github.com/repos/MetacoSA/NBitcoin/subscribers","subscription_url":"https://api.github.com/repos/MetacoSA/NBitcoin/subscription","commits_url":"https://api.github.com/repos/MetacoSA/NBitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetacoSA/NBitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetacoSA/NBitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetacoSA/NBitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MetacoSA/NBitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetacoSA/NBitcoin/merges","archive_url":"https://api.github.com/repos/MetacoSA/NBitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetacoSA/NBitcoin/downloads","issues_url":"https://api.github.com/repos/MetacoSA/NBitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MetacoSA/NBitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MetacoSA/NBitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetacoSA/NBitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MetacoSA/NBitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/MetacoSA/NBitcoin/deployments","created_at":"2014-04-09T12:22:52Z","updated_at":"2016-10-28T08:29:30Z","pushed_at":"2016-10-31T08:12:09Z","git_url":"git://github.com/MetacoSA/NBitcoin.git","ssh_url":"git@github.com:MetacoSA/NBitcoin.git","clone_url":"https://github.com/MetacoSA/NBitcoin.git","svn_url":"https://github.com/MetacoSA/NBitcoin","homepage":"","size":39908,"stargazers_count":259,"watchers_count":259,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":3,"forks":125,"open_issues":3,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199"},"html":{"href":"https://github.com/MetacoSA/NBitcoin/pull/199"},"issue":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/199"},"comments":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/MetacoSA/NBitcoin/statuses/c5e69d6d4f719ce916b50712325bad5252ec4799"}}}}
{"actor":{"display_login":"NicolasDorier"}}