{"action":"created","comment":{"url":"https://api.github.com/repos/amalgam8/registry/pulls/comments/69149447","id":69149447,"diff_hunk":"@@ -50,6 +51,11 @@ func newK8sClient(k8sURL string) (*k8sClient, error) {\n \t\treturn nil, err\n \t}\n \n+\tt, err := ioutil.ReadFile(\"/var/run/secrets/kubernetes.io/serviceaccount/token\")","path":"store/kubernetes/client.go","position":null,"original_position":12,"commit_id":"78071122dbf347462ea3c1b6c094ba2eed507d77","original_commit_id":"c8ff98fd7e5911df7d8b7b39bdc185c63b9ce133","user":{"login":"zcahana","id":17428696,"avatar_url":"https://avatars.githubusercontent.com/u/17428696?v=3","gravatar_id":"","url":"https://api.github.com/users/zcahana","html_url":"https://github.com/zcahana","followers_url":"https://api.github.com/users/zcahana/followers","following_url":"https://api.github.com/users/zcahana/following{/other_user}","gists_url":"https://api.github.com/users/zcahana/gists{/gist_id}","starred_url":"https://api.github.com/users/zcahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcahana/subscriptions","organizations_url":"https://api.github.com/users/zcahana/orgs","repos_url":"https://api.github.com/users/zcahana/repos","events_url":"https://api.github.com/users/zcahana/events{/privacy}","received_events_url":"https://api.github.com/users/zcahana/received_events","type":"User","site_admin":false},"body":"I'm guessing this file gets mounted into k8s containers by the k8s daemon?\r\nWhat happens if we want to run the a k8s-enabled registry on a non-k8s node?\r\nWe should probably switch to a more general mechanism of hooking up with the k8s API token.","created_at":"2016-06-30T15:03:18Z","updated_at":"2016-06-30T15:03:18Z","html_url":"https://github.com/amalgam8/registry/pull/13#discussion_r69149447","pull_request_url":"https://api.github.com/repos/amalgam8/registry/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/comments/69149447"},"html":{"href":"https://github.com/amalgam8/registry/pull/13#discussion_r69149447"},"pull_request":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/amalgam8/registry/pulls/13","id":75812341,"html_url":"https://github.com/amalgam8/registry/pull/13","diff_url":"https://github.com/amalgam8/registry/pull/13.diff","patch_url":"https://github.com/amalgam8/registry/pull/13.patch","issue_url":"https://api.github.com/repos/amalgam8/registry/issues/13","number":13,"state":"open","locked":false,"title":"Multi catalogs","user":{"login":"zachidan","id":15229727,"avatar_url":"https://avatars.githubusercontent.com/u/15229727?v=3","gravatar_id":"","url":"https://api.github.com/users/zachidan","html_url":"https://github.com/zachidan","followers_url":"https://api.github.com/users/zachidan/followers","following_url":"https://api.github.com/users/zachidan/following{/other_user}","gists_url":"https://api.github.com/users/zachidan/gists{/gist_id}","starred_url":"https://api.github.com/users/zachidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachidan/subscriptions","organizations_url":"https://api.github.com/users/zachidan/orgs","repos_url":"https://api.github.com/users/zachidan/repos","events_url":"https://api.github.com/users/zachidan/events{/privacy}","received_events_url":"https://api.github.com/users/zachidan/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-30T12:42:13Z","updated_at":"2016-06-30T15:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bff5e828d9e8968ad187c1127fdde95bcc04b597","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/amalgam8/registry/pulls/13/commits","review_comments_url":"https://api.github.com/repos/amalgam8/registry/pulls/13/comments","review_comment_url":"https://api.github.com/repos/amalgam8/registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amalgam8/registry/issues/13/comments","statuses_url":"https://api.github.com/repos/amalgam8/registry/statuses/78071122dbf347462ea3c1b6c094ba2eed507d77","head":{"label":"amalgam8:multi-catalogs","ref":"multi-catalogs","sha":"78071122dbf347462ea3c1b6c094ba2eed507d77","user":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"repo":{"id":60637159,"name":"registry","full_name":"amalgam8/registry","owner":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amalgam8/registry","description":"Amalgam8 Microservice Fabric Service Registry","fork":false,"url":"https://api.github.com/repos/amalgam8/registry","forks_url":"https://api.github.com/repos/amalgam8/registry/forks","keys_url":"https://api.github.com/repos/amalgam8/registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amalgam8/registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amalgam8/registry/teams","hooks_url":"https://api.github.com/repos/amalgam8/registry/hooks","issue_events_url":"https://api.github.com/repos/amalgam8/registry/issues/events{/number}","events_url":"https://api.github.com/repos/amalgam8/registry/events","assignees_url":"https://api.github.com/repos/amalgam8/registry/assignees{/user}","branches_url":"https://api.github.com/repos/amalgam8/registry/branches{/branch}","tags_url":"https://api.github.com/repos/amalgam8/registry/tags","blobs_url":"https://api.github.com/repos/amalgam8/registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amalgam8/registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amalgam8/registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/amalgam8/registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amalgam8/registry/statuses/{sha}","languages_url":"https://api.github.com/repos/amalgam8/registry/languages","stargazers_url":"https://api.github.com/repos/amalgam8/registry/stargazers","contributors_url":"https://api.github.com/repos/amalgam8/registry/contributors","subscribers_url":"https://api.github.com/repos/amalgam8/registry/subscribers","subscription_url":"https://api.github.com/repos/amalgam8/registry/subscription","commits_url":"https://api.github.com/repos/amalgam8/registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/amalgam8/registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/amalgam8/registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/amalgam8/registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/amalgam8/registry/contents/{+path}","compare_url":"https://api.github.com/repos/amalgam8/registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amalgam8/registry/merges","archive_url":"https://api.github.com/repos/amalgam8/registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amalgam8/registry/downloads","issues_url":"https://api.github.com/repos/amalgam8/registry/issues{/number}","pulls_url":"https://api.github.com/repos/amalgam8/registry/pulls{/number}","milestones_url":"https://api.github.com/repos/amalgam8/registry/milestones{/number}","notifications_url":"https://api.github.com/repos/amalgam8/registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amalgam8/registry/labels{/name}","releases_url":"https://api.github.com/repos/amalgam8/registry/releases{/id}","deployments_url":"https://api.github.com/repos/amalgam8/registry/deployments","created_at":"2016-06-07T18:37:20Z","updated_at":"2016-06-17T12:33:33Z","pushed_at":"2016-06-30T13:31:54Z","git_url":"git://github.com/amalgam8/registry.git","ssh_url":"git@github.com:amalgam8/registry.git","clone_url":"https://github.com/amalgam8/registry.git","svn_url":"https://github.com/amalgam8/registry","homepage":null,"size":1390,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"amalgam8:master","ref":"master","sha":"dc1d3770982268ff7c2f6140d45972182b9f9e7c","user":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"repo":{"id":60637159,"name":"registry","full_name":"amalgam8/registry","owner":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amalgam8/registry","description":"Amalgam8 Microservice Fabric Service Registry","fork":false,"url":"https://api.github.com/repos/amalgam8/registry","forks_url":"https://api.github.com/repos/amalgam8/registry/forks","keys_url":"https://api.github.com/repos/amalgam8/registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amalgam8/registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amalgam8/registry/teams","hooks_url":"https://api.github.com/repos/amalgam8/registry/hooks","issue_events_url":"https://api.github.com/repos/amalgam8/registry/issues/events{/number}","events_url":"https://api.github.com/repos/amalgam8/registry/events","assignees_url":"https://api.github.com/repos/amalgam8/registry/assignees{/user}","branches_url":"https://api.github.com/repos/amalgam8/registry/branches{/branch}","tags_url":"https://api.github.com/repos/amalgam8/registry/tags","blobs_url":"https://api.github.com/repos/amalgam8/registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amalgam8/registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amalgam8/registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/amalgam8/registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amalgam8/registry/statuses/{sha}","languages_url":"https://api.github.com/repos/amalgam8/registry/languages","stargazers_url":"https://api.github.com/repos/amalgam8/registry/stargazers","contributors_url":"https://api.github.com/repos/amalgam8/registry/contributors","subscribers_url":"https://api.github.com/repos/amalgam8/registry/subscribers","subscription_url":"https://api.github.com/repos/amalgam8/registry/subscription","commits_url":"https://api.github.com/repos/amalgam8/registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/amalgam8/registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/amalgam8/registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/amalgam8/registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/amalgam8/registry/contents/{+path}","compare_url":"https://api.github.com/repos/amalgam8/registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amalgam8/registry/merges","archive_url":"https://api.github.com/repos/amalgam8/registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amalgam8/registry/downloads","issues_url":"https://api.github.com/repos/amalgam8/registry/issues{/number}","pulls_url":"https://api.github.com/repos/amalgam8/registry/pulls{/number}","milestones_url":"https://api.github.com/repos/amalgam8/registry/milestones{/number}","notifications_url":"https://api.github.com/repos/amalgam8/registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amalgam8/registry/labels{/name}","releases_url":"https://api.github.com/repos/amalgam8/registry/releases{/id}","deployments_url":"https://api.github.com/repos/amalgam8/registry/deployments","created_at":"2016-06-07T18:37:20Z","updated_at":"2016-06-17T12:33:33Z","pushed_at":"2016-06-30T13:31:54Z","git_url":"git://github.com/amalgam8/registry.git","ssh_url":"git@github.com:amalgam8/registry.git","clone_url":"https://github.com/amalgam8/registry.git","svn_url":"https://github.com/amalgam8/registry","homepage":null,"size":1390,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/13"},"html":{"href":"https://github.com/amalgam8/registry/pull/13"},"issue":{"href":"https://api.github.com/repos/amalgam8/registry/issues/13"},"comments":{"href":"https://api.github.com/repos/amalgam8/registry/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amalgam8/registry/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/amalgam8/registry/statuses/78071122dbf347462ea3c1b6c094ba2eed507d77"}}}}
{"actor":{"display_login":"zcahana"}}