{"action":"created","comment":{"url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments/76207110","id":76207110,"diff_hunk":"@@ -135,35 +144,35 @@ tfw_strcpy(TfwStr *dst, const TfwStr *src)\n \n \tswitch (mode) {\n \tcase 3: /* The both are plain. */\n-\t\tmemcpy(dst->ptr, src->ptr, min(src->len, dst->len));\n+\t\tmemcpy(dst->data, src->data, min(src->len, dst->len));\n \t\tbreak;\n \tcase 1: /* @src is compound, @dst is plain. */\n \t\tn1 = TFW_STR_CHUNKN(src);\n-\t\tend = (TfwStr *)src->ptr + n1;\n-\t\tfor (c1 = (TfwStr *)src->ptr; c1 < end; ++c1) {\n-\t\t\tmemcpy((char *)dst->ptr + o2, c1->ptr, c1->len);\n+\t\tend = src->chunks + n1;\n+\t\tfor (c1 = src->chunks; c1 < end; ++c1) {\n+\t\t\tmemcpy((char *)dst->data + o2, c1->data, c1->len);","path":"tempesta_fw/str.c","position":92,"original_position":92,"commit_id":"23a7be2344f79a53c38eba5e632cb83f05b3b476","original_commit_id":"23a7be2344f79a53c38eba5e632cb83f05b3b476","user":{"login":"keshonok","id":6352580,"avatar_url":"https://avatars.githubusercontent.com/u/6352580?v=3","gravatar_id":"","url":"https://api.github.com/users/keshonok","html_url":"https://github.com/keshonok","followers_url":"https://api.github.com/users/keshonok/followers","following_url":"https://api.github.com/users/keshonok/following{/other_user}","gists_url":"https://api.github.com/users/keshonok/gists{/gist_id}","starred_url":"https://api.github.com/users/keshonok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keshonok/subscriptions","organizations_url":"https://api.github.com/users/keshonok/orgs","repos_url":"https://api.github.com/users/keshonok/repos","events_url":"https://api.github.com/users/keshonok/events{/privacy}","received_events_url":"https://api.github.com/users/keshonok/received_events","type":"User","site_admin":false},"body":"Is the typecast necessary here?","created_at":"2016-08-25T09:11:15Z","updated_at":"2016-08-25T09:11:15Z","html_url":"https://github.com/tempesta-tech/tempesta/pull/582#discussion_r76207110","pull_request_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments/76207110"},"html":{"href":"https://github.com/tempesta-tech/tempesta/pull/582#discussion_r76207110"},"pull_request":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582","id":76928235,"html_url":"https://github.com/tempesta-tech/tempesta/pull/582","diff_url":"https://github.com/tempesta-tech/tempesta/pull/582.diff","patch_url":"https://github.com/tempesta-tech/tempesta/pull/582.patch","issue_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/582","number":582,"state":"open","locked":false,"title":"215","user":{"login":"sergsever","id":10198669,"avatar_url":"https://avatars.githubusercontent.com/u/10198669?v=3","gravatar_id":"","url":"https://api.github.com/users/sergsever","html_url":"https://github.com/sergsever","followers_url":"https://api.github.com/users/sergsever/followers","following_url":"https://api.github.com/users/sergsever/following{/other_user}","gists_url":"https://api.github.com/users/sergsever/gists{/gist_id}","starred_url":"https://api.github.com/users/sergsever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergsever/subscriptions","organizations_url":"https://api.github.com/users/sergsever/orgs","repos_url":"https://api.github.com/users/sergsever/repos","events_url":"https://api.github.com/users/sergsever/events{/privacy}","received_events_url":"https://api.github.com/users/sergsever/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-11T10:04:27Z","updated_at":"2016-08-25T09:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53ccd021e98ead44d6e60fa0e39ed3669ad6ced6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582/commits","review_comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582/comments","review_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/582/comments","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/23a7be2344f79a53c38eba5e632cb83f05b3b476","head":{"label":"tempesta-tech:sl_215","ref":"sl_215","sha":"23a7be2344f79a53c38eba5e632cb83f05b3b476","user":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":23121600,"name":"tempesta","full_name":"tempesta-tech/tempesta","owner":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/tempesta","description":"High performance HTTP accelerator and firewall for WAF and DDoS prevention","fork":false,"url":"https://api.github.com/repos/tempesta-tech/tempesta","forks_url":"https://api.github.com/repos/tempesta-tech/tempesta/forks","keys_url":"https://api.github.com/repos/tempesta-tech/tempesta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/tempesta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/tempesta/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/tempesta/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/tempesta/events","assignees_url":"https://api.github.com/repos/tempesta-tech/tempesta/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/tempesta/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/tempesta/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/tempesta/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/tempesta/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/tempesta/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/tempesta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/tempesta/merges","archive_url":"https://api.github.com/repos/tempesta-tech/tempesta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/tempesta/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/tempesta/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/tempesta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/tempesta/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/tempesta/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/tempesta/deployments","created_at":"2014-08-19T18:44:05Z","updated_at":"2016-08-19T13:48:02Z","pushed_at":"2016-08-25T09:03:42Z","git_url":"git://github.com/tempesta-tech/tempesta.git","ssh_url":"git@github.com:tempesta-tech/tempesta.git","clone_url":"https://github.com/tempesta-tech/tempesta.git","svn_url":"https://github.com/tempesta-tech/tempesta","homepage":"","size":6836,"stargazers_count":114,"watchers_count":114,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":90,"forks":26,"open_issues":90,"watchers":114,"default_branch":"master"}},"base":{"label":"tempesta-tech:master","ref":"master","sha":"e5117c22840ae32fa6d17175976c2cf133571b35","user":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":23121600,"name":"tempesta","full_name":"tempesta-tech/tempesta","owner":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/tempesta","description":"High performance HTTP accelerator and firewall for WAF and DDoS prevention","fork":false,"url":"https://api.github.com/repos/tempesta-tech/tempesta","forks_url":"https://api.github.com/repos/tempesta-tech/tempesta/forks","keys_url":"https://api.github.com/repos/tempesta-tech/tempesta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/tempesta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/tempesta/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/tempesta/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/tempesta/events","assignees_url":"https://api.github.com/repos/tempesta-tech/tempesta/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/tempesta/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/tempesta/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/tempesta/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/tempesta/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/tempesta/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/tempesta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/tempesta/merges","archive_url":"https://api.github.com/repos/tempesta-tech/tempesta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/tempesta/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/tempesta/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/tempesta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/tempesta/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/tempesta/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/tempesta/deployments","created_at":"2014-08-19T18:44:05Z","updated_at":"2016-08-19T13:48:02Z","pushed_at":"2016-08-25T09:03:42Z","git_url":"git://github.com/tempesta-tech/tempesta.git","ssh_url":"git@github.com:tempesta-tech/tempesta.git","clone_url":"https://github.com/tempesta-tech/tempesta.git","svn_url":"https://github.com/tempesta-tech/tempesta","homepage":"","size":6836,"stargazers_count":114,"watchers_count":114,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":90,"forks":26,"open_issues":90,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582"},"html":{"href":"https://github.com/tempesta-tech/tempesta/pull/582"},"issue":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/issues/582"},"comments":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/23a7be2344f79a53c38eba5e632cb83f05b3b476"}}}}
{"actor":{"display_login":"keshonok"}}