{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/676","repository_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards","labels_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/676/comments","events_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/676/events","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/676","id":174125939,"number":676,"title":"Remove WordPress-Core from WordPress-VIP standard","user":{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-08-30T21:05:36Z","updated_at":"2016-12-24T10:40:46Z","closed_at":"2016-09-07T00:03:13Z","pull_request":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/pulls/676","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/676","diff_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/676.diff","patch_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/676.patch"},"body":"There is a lot of noise reported from the `WordPress-Core` standard that the VIP team doesn't care about. They don't care about whitespace and bracket usage, but rather they care about issues like security and not using restricted functions. As such, the `WordPress-VIP` standard should remove `WordPress-Core`. If the `WordPress-Core` are desired alongside the `WordPress-VIP` sniffs then all that is required is for both standards to be used when invoking PHPCS:\n\n```\nphpcs --standard=WordPress-Core,WordPress-VIP\n```\n\nEither this, or a custom project-specific `ruleset.xml` can be used which calls in both of these standards.\n"},"comment":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/comments/269079082","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/676#issuecomment-269079082","issue_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/676","id":269079082,"user":{"login":"GaryJones","id":88371,"avatar_url":"https://avatars.githubusercontent.com/u/88371?v=3","gravatar_id":"","url":"https://api.github.com/users/GaryJones","html_url":"https://github.com/GaryJones","followers_url":"https://api.github.com/users/GaryJones/followers","following_url":"https://api.github.com/users/GaryJones/following{/other_user}","gists_url":"https://api.github.com/users/GaryJones/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryJones/subscriptions","organizations_url":"https://api.github.com/users/GaryJones/orgs","repos_url":"https://api.github.com/users/GaryJones/repos","events_url":"https://api.github.com/users/GaryJones/events{/privacy}","received_events_url":"https://api.github.com/users/GaryJones/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T10:40:46Z","updated_at":"2016-12-24T10:40:46Z","body":"The approach of splitting `WordPress Core` up into `WordPress Core` + `WordPress Coding Style`, is that it will break BC - not as many checks will be done on code as it was previously if someone has specified `WordPress-Core` in their `phpcs.xml`.\r\n\r\nI'm not convinced of the value in splitting up WP Core into yet another subgroup. If a rule is in the handbook, then it's in the handbook, regardless of whether it's for security, whitespace or general formatting. The Core standard is already somewhat broken up, by the directories the Sniffs are stored in, and excludes can be done on that basis.\r\n\r\nMy understanding of the VIP rules here, is that they are for developers who are writing code that could be used on the VIP platform.\r\n\r\nWhat the Automattic employees (a different group of people) want is their own ruleset which includes our VIP rules, but excludes certain others.\r\n\r\nAgain, both the VIP, and the \"VIP Review\" rulesets are very company-specific, and I'm uncomfortable with that. I'd rather our efforts were spent in identifying, agreeing and moving the best practice parts of VIP over to Extras (I agree, some are useful), and encouraging Automattic to create their own \"VIP Review\" ruleset (it's their internal tool after all), and ideally taking ownership of the VIP ruleset as well. \r\n\r\nFor me, we should be maintaining and improving just the following standards:\r\n\r\n* `WordPress-Core` (`WordPress-Handbook` / `WordPress`) - Code standard from the Handbook\r\n* `WordPress-Docs` - Inline Docs standard from the Handbook\r\n* `WordPress-Extras` - Recommended best practices, not sufficiently covered in the Handbook.\r\n\r\n> There is a lot of noise reported from the WordPress-Core standard that the **VIP team** doesn't care about.\r\n\r\nIn short, I don't think this is our problem to solve, so long as there are sufficient ways for them (or anyone) to exclude whatever rules they don't want reported."}}
{"actor":{"display_login":"GaryJones"}}