{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5137","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5137/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5137/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5137/events","html_url":"https://github.com/apple/swift/pull/5137","id":181279930,"number":5137,"title":"Fix no asserts build","user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-05T22:16:35Z","updated_at":"2016-10-05T23:23:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5137","html_url":"https://github.com/apple/swift/pull/5137","diff_url":"https://github.com/apple/swift/pull/5137.diff","patch_url":"https://github.com/apple/swift/pull/5137.patch"},"body":"This group of commits does two things:\r\n\r\n1. It responds to some post commit review from @llvm-beanz on e4d8cc7. Specifically, we only need to stop -g from being put on the command line by cmake when we compile with LTO+RelWithDebInfo.\r\n2. In a separate commit, it adds -DNDEBUG to the overridden flags line for RelWithDebInfo to ensure that asserts are properly enabled given how LLVM implements LLVM_ENABLE_ASSERTIONS (it just rewrites the cflags flag to change the -D in -DNDEBUG to -U).\r\n\r\nI am going to file a radar for a separate piece of work to fix LLVM to do something sane, namely, adding -DNDEBUG or -UNDEBUG to the end of command lines and perhaps create some sort of verification on the swift side that we are getting asserts where we think they are supposed to be."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/251827881","html_url":"https://github.com/apple/swift/pull/5137#issuecomment-251827881","issue_url":"https://api.github.com/repos/apple/swift/issues/5137","id":251827881,"user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T23:23:35Z","updated_at":"2016-10-05T23:23:35Z","body":"I do not think the benchmark test did a clean build. @shahmishal Can you cause it to always do a clean build?"}}
{"actor":{"display_login":"gottesmm"}}