{"action":"created","comment":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments/72344232","id":72344232,"diff_hunk":"@@ -78,7 +78,7 @@ public void sort() {\n         public int compare(Map<String,Integer> o1, Map<String,Integer> o2) {\n             int s1 = o1.size();\n             int s2 = o2.size();\n-            if (o1 == o2) {\n+            if (s1 == s2) {","path":"deeplearning4j-core/src/main/java/org/deeplearning4j/util/StringCluster.java","position":5,"original_position":5,"commit_id":"9b27d563c94608aa5276b52af43723062b81ec1f","original_commit_id":"9b27d563c94608aa5276b52af43723062b81ec1f","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"I assume this was the intent, to compare values only if sizes are the same","created_at":"2016-07-26T21:48:53Z","updated_at":"2016-07-26T21:48:53Z","html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/1891#discussion_r72344232","pull_request_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891","_links":{"self":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments/72344232"},"html":{"href":"https://github.com/deeplearning4j/deeplearning4j/pull/1891#discussion_r72344232"},"pull_request":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891"}}},"pull_request":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891","id":78931614,"html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/1891","diff_url":"https://github.com/deeplearning4j/deeplearning4j/pull/1891.diff","patch_url":"https://github.com/deeplearning4j/deeplearning4j/pull/1891.patch","issue_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/1891","number":1891,"state":"open","locked":false,"title":"Fix various problems related to equals/hashCode, or using inappropriate values (wrong type even) in collections operations","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"(Let me know if this type of change is of interest -- there's some more modest improvements that could come from some more static analysis.)\r\n\r\nHere I found some potential equals/hashCode problems, and probable bugs based on wrong types used in collections. I'll annotate some of the changes below.","created_at":"2016-07-26T21:48:23Z","updated_at":"2016-07-26T21:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c759e1f0770a42a5060e0f4831494020787e30e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891/commits","review_comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891/comments","review_comment_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/1891/comments","statuses_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/9b27d563c94608aa5276b52af43723062b81ec1f","head":{"label":"srowen:EqualsHashCodeKeyValueErrors","ref":"EqualsHashCodeKeyValueErrors","sha":"9b27d563c94608aa5276b52af43723062b81ec1f","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"repo":{"id":63788245,"name":"deeplearning4j","full_name":"srowen/deeplearning4j","owner":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srowen/deeplearning4j","description":"Deep Learning for Java, Scala & Clojure on Hadoop & Spark With GPUs - From Skymind","fork":true,"url":"https://api.github.com/repos/srowen/deeplearning4j","forks_url":"https://api.github.com/repos/srowen/deeplearning4j/forks","keys_url":"https://api.github.com/repos/srowen/deeplearning4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srowen/deeplearning4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srowen/deeplearning4j/teams","hooks_url":"https://api.github.com/repos/srowen/deeplearning4j/hooks","issue_events_url":"https://api.github.com/repos/srowen/deeplearning4j/issues/events{/number}","events_url":"https://api.github.com/repos/srowen/deeplearning4j/events","assignees_url":"https://api.github.com/repos/srowen/deeplearning4j/assignees{/user}","branches_url":"https://api.github.com/repos/srowen/deeplearning4j/branches{/branch}","tags_url":"https://api.github.com/repos/srowen/deeplearning4j/tags","blobs_url":"https://api.github.com/repos/srowen/deeplearning4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srowen/deeplearning4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srowen/deeplearning4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/srowen/deeplearning4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srowen/deeplearning4j/statuses/{sha}","languages_url":"https://api.github.com/repos/srowen/deeplearning4j/languages","stargazers_url":"https://api.github.com/repos/srowen/deeplearning4j/stargazers","contributors_url":"https://api.github.com/repos/srowen/deeplearning4j/contributors","subscribers_url":"https://api.github.com/repos/srowen/deeplearning4j/subscribers","subscription_url":"https://api.github.com/repos/srowen/deeplearning4j/subscription","commits_url":"https://api.github.com/repos/srowen/deeplearning4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/srowen/deeplearning4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/srowen/deeplearning4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/srowen/deeplearning4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/srowen/deeplearning4j/contents/{+path}","compare_url":"https://api.github.com/repos/srowen/deeplearning4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srowen/deeplearning4j/merges","archive_url":"https://api.github.com/repos/srowen/deeplearning4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srowen/deeplearning4j/downloads","issues_url":"https://api.github.com/repos/srowen/deeplearning4j/issues{/number}","pulls_url":"https://api.github.com/repos/srowen/deeplearning4j/pulls{/number}","milestones_url":"https://api.github.com/repos/srowen/deeplearning4j/milestones{/number}","notifications_url":"https://api.github.com/repos/srowen/deeplearning4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srowen/deeplearning4j/labels{/name}","releases_url":"https://api.github.com/repos/srowen/deeplearning4j/releases{/id}","deployments_url":"https://api.github.com/repos/srowen/deeplearning4j/deployments","created_at":"2016-07-20T14:29:39Z","updated_at":"2016-07-20T14:29:45Z","pushed_at":"2016-07-26T21:46:09Z","git_url":"git://github.com/srowen/deeplearning4j.git","ssh_url":"git@github.com:srowen/deeplearning4j.git","clone_url":"https://github.com/srowen/deeplearning4j.git","svn_url":"https://github.com/srowen/deeplearning4j","homepage":"http://deeplearning4j.org","size":1349952,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deeplearning4j:master","ref":"master","sha":"5ed3098356eb02a64885d2a63ff6ea58a03effac","user":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"repo":{"id":14734876,"name":"deeplearning4j","full_name":"deeplearning4j/deeplearning4j","owner":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeplearning4j/deeplearning4j","description":"Deep Learning for Java, Scala & Clojure on Hadoop & Spark With GPUs - From Skymind","fork":false,"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j","forks_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/forks","keys_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/teams","hooks_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/hooks","issue_events_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/events{/number}","events_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/events","assignees_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/assignees{/user}","branches_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/branches{/branch}","tags_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/tags","blobs_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/{sha}","languages_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/languages","stargazers_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/stargazers","contributors_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/contributors","subscribers_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/subscribers","subscription_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/subscription","commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/contents/{+path}","compare_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/merges","archive_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/downloads","issues_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues{/number}","pulls_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls{/number}","milestones_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/milestones{/number}","notifications_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/labels{/name}","releases_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/releases{/id}","deployments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/deployments","created_at":"2013-11-27T02:03:28Z","updated_at":"2016-07-26T21:34:29Z","pushed_at":"2016-07-26T21:48:24Z","git_url":"git://github.com/deeplearning4j/deeplearning4j.git","ssh_url":"git@github.com:deeplearning4j/deeplearning4j.git","clone_url":"https://github.com/deeplearning4j/deeplearning4j.git","svn_url":"https://github.com/deeplearning4j/deeplearning4j","homepage":"http://deeplearning4j.org","size":1358390,"stargazers_count":3500,"watchers_count":3500,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1199,"mirror_url":null,"open_issues_count":215,"forks":1199,"open_issues":215,"watchers":3500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891"},"html":{"href":"https://github.com/deeplearning4j/deeplearning4j/pull/1891"},"issue":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/1891"},"comments":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/1891/comments"},"review_comments":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891/comments"},"review_comment":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/1891/commits"},"statuses":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/9b27d563c94608aa5276b52af43723062b81ec1f"}}}}
{"actor":{"display_login":"srowen"}}