{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694/events","html_url":"https://github.com/kubernetes/kubernetes/pull/23694","id":144997841,"number":23694,"title":"etcd v3 watcher implementation","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-merge","name":"needs-ok-to-merge","color":"ededed"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"}],"state":"open","locked":false,"assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"milestone":null,"comments":23,"created_at":"2016-03-31T19:40:12Z","updated_at":"2016-04-08T04:03:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694","html_url":"https://github.com/kubernetes/kubernetes/pull/23694","diff_url":"https://github.com/kubernetes/kubernetes/pull/23694.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23694.patch"},"body":"ref: https://github.com/kubernetes/kubernetes/issues/22448\r\n\r\nThis PR does:\r\n- Provide a watcher that uses etcd v3 API to watch changes via etcd and process them based on existing logic of storage.Interface.Watch(), WatchList().\r\n- By using the watcher, very trivial to implement Watch() and WatchList() in etcd3 storage.Interface implementation.\r\n\r\nTODO:\r\n- I'm still writing tests for both watcher and the Watch(), WatchList() methods.\r\n- Wait for https://github.com/kubernetes/kubernetes/pull/24022\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/207199797","html_url":"https://github.com/kubernetes/kubernetes/pull/23694#issuecomment-207199797","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694","id":207199797,"user":{"login":"magicwang-cn","id":7587313,"avatar_url":"https://avatars.githubusercontent.com/u/7587313?v=3","gravatar_id":"","url":"https://api.github.com/users/magicwang-cn","html_url":"https://github.com/magicwang-cn","followers_url":"https://api.github.com/users/magicwang-cn/followers","following_url":"https://api.github.com/users/magicwang-cn/following{/other_user}","gists_url":"https://api.github.com/users/magicwang-cn/gists{/gist_id}","starred_url":"https://api.github.com/users/magicwang-cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicwang-cn/subscriptions","organizations_url":"https://api.github.com/users/magicwang-cn/orgs","repos_url":"https://api.github.com/users/magicwang-cn/repos","events_url":"https://api.github.com/users/magicwang-cn/events{/privacy}","received_events_url":"https://api.github.com/users/magicwang-cn/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T04:03:51Z","updated_at":"2016-04-08T04:03:51Z","body":"Ok, I see. thanks\r\n\r\n发件人: Xiang Li [mailto:notifications@github.com]\r\n发送时间: 2016年4月8日 11:54\r\n收件人: kubernetes/kubernetes\r\n抄送: Wangbo (U)\r\n主题: Re: [kubernetes/kubernetes] etcd v3 watcher implementation (#23694)\r\n\r\n\r\n@magicwang-cn<https://github.com/magicwang-cn>\r\n\r\nthanks for your reply. does this mean a range with 10 minute window?\r\n\r\nYes. By default, we save the most recent 10 minutes event history. It should be more than enough for slow watchers. It is not number based, so it can tolerate event bursts too. We do not want to save longer since the current storage API cannot take advantage of the multi-version key yet. We might keep a longer history in the future.\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly or view it on GitHub<https://github.com/kubernetes/kubernetes/pull/23694#issuecomment-207198366>\r\n"}}