{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/1621","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/1621/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/1621/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/1621/events","html_url":"https://github.com/brave/browser-laptop/issues/1621","id":153607234,"number":1621,"title":"Bravery panel, and per-site settings","user":{"login":"bradleyrichter","id":13509546,"avatar_url":"https://avatars.githubusercontent.com/u/13509546?v=3","gravatar_id":"","url":"https://api.github.com/users/bradleyrichter","html_url":"https://github.com/bradleyrichter","followers_url":"https://api.github.com/users/bradleyrichter/followers","following_url":"https://api.github.com/users/bradleyrichter/following{/other_user}","gists_url":"https://api.github.com/users/bradleyrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleyrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleyrichter/subscriptions","organizations_url":"https://api.github.com/users/bradleyrichter/orgs","repos_url":"https://api.github.com/users/bradleyrichter/repos","events_url":"https://api.github.com/users/bradleyrichter/events{/privacy}","received_events_url":"https://api.github.com/users/bradleyrichter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brave/browser-laptop/labels/design","name":"design","color":"207de5"},{"url":"https://api.github.com/repos/brave/browser-laptop/labels/Major","name":"Major","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/14","html_url":"https://github.com/brave/browser-laptop/milestones/0.10.0dev","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/14/labels","id":1702200,"number":14,"title":"0.10.0dev","description":"","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":28,"state":"open","created_at":"2016-04-12T19:07:16Z","updated_at":"2016-05-20T17:41:47Z","due_on":"2016-05-20T04:00:00Z","closed_at":null},"comments":8,"created_at":"2016-05-07T17:36:00Z","updated_at":"2016-05-20T18:24:42Z","closed_at":"2016-05-19T19:20:53Z","body":"**Overview:**\r\nAs we complete the plumbing for maintaining per-site settings for various blocking and cookie attributes, users need a quick-access UI to control one or more of these attributes IF the need arrises for a particular site. \r\n\r\nSome users may want to white-list sites for various reasons. This may include allowing one site to display normal ads and another to allow popups or 3rd party cookies if these settings are required for the purpose of browsing that site. \r\n\r\nOccasionally a site may refuse to load because of our agressive blocking defaults.\r\n\r\nBrave refers to these settings as \"shields\".\r\n\r\n**Plan**\r\nQuick access to per-site shields will be available through a panel that opens via the Bravery button in the navigation bar. This panel defaults to a collapsed view, and offers an easy-switch to bring all site shields UP or DOWN with one simple switch. This allows a user to quickly fix a site that may not be loading or doesn't appear as they expected. (a double-click on the Bravery button will serve as an advanced short-cut to the shields toggle switch for the current site.)\r\n\r\nWhen the user needs more granular control over a particular setting, the advanced controls can be displayed. (the viewable state is remembered so they are visible again next time the panel is opened)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13509546/15115269/0bf9bb48-15b3-11e6-80f3-89bfb69f86cf.png)\r\n\r\n\r\n\r\nThe display area shows a readout for the currently blocked ad count and tracker count for the current page, and provides access to more detail through a secondary popup list which is toggled by clicking on the number.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13509546/15093417/f4e4c416-143b-11e6-888f-245abe33166a.png)\r\n\r\n\r\n\r\nIf shields are down, no information is displayed in this area:\r\n![image](https://cloud.githubusercontent.com/assets/13509546/15115317/45a897b0-15b3-11e6-9eda-fff5273618e9.png)\r\n\r\n\r\nAlso shown in the above image, the bravery button changes it's color state to represent the state of Shields for that site. \r\n\r\nFunctionally, when shields are \"down\", all settings are reduced to thier minimum or off states until the shields are brought back \"up\". (also - this on/off state is site-wide and not just per page)\r\n\r\nA decision to make related to this is whether these settings should simply be disabled (but viewable) while shields are down, or if they should be editable which would then create a new baseline for the site's shields settings as soon as one setting is changed from its off-state.\r\n\r\n(the first iteration will use the disabled approach:)\r\n![image](https://cloud.githubusercontent.com/assets/13509546/15115368/7ef373c8-15b3-11e6-8b62-92cd4cdabb01.png)\r\n\r\n\r\n\r\nOther V1 differences are listed and shown here:\r\n- the site icon will start by using the site favicon in it's largest available size, but 16x will be acceptable\r\n- time-saved will require more work and will come later\r\n- global shield setting overrides will not be available yet so the link to Prefs will be hidden\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13509546/15093480/63266964-143e-11e6-8d70-d7684ae56049.png)\r\n\r\n\r\n\r\nCommunity feedback is encouraged as always!\r\n\r\nWe know that many advanced users have requested per-element/per-site blocking control. We will not have this initially but will evaluate the necessity as we move forward.\r\n\r\nAlso, not shown in this UI are future exception lists that will be accessed through the settings/prefs panels. \r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/220682349","html_url":"https://github.com/brave/browser-laptop/issues/1621#issuecomment-220682349","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/1621","id":220682349,"user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T18:24:42Z","updated_at":"2016-05-20T18:24:42Z","body":"yeah that will be much more understandable"}}
{"actor":{"display_login":"luixxiul"}}