{"action":"closed","number":2319,"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2319","id":67320508,"html_url":"https://github.com/sulu/sulu/pull/2319","diff_url":"https://github.com/sulu/sulu/pull/2319.diff","patch_url":"https://github.com/sulu/sulu/pull/2319.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2319","number":2319,"state":"closed","locked":false,"title":"Validate unknown vat-number as valid","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | fixes #2317\r\n| Related issues/PRs | none\r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nThe validation of UID is quite strict which leads into an unusable field in some cases. This PR introduces that the UID is only validated if the country is detected and a regex is there to validate the UID if the schema cannot be detected the UID is always valid.\r\n\r\nI have tested all the examples from https://www.bmf.gv.at/steuern/selbststaendige-unternehmer/umsatzsteuer/UID-und-ZM.html\r\n#### Why?\r\n\r\nThe UID could be used for something else or for countries which are not \"supported\" by the sulu regex.\r\n","created_at":"2016-04-21T09:13:10Z","updated_at":"2016-04-21T09:32:25Z","closed_at":"2016-04-21T09:32:24Z","merged_at":"2016-04-21T09:32:24Z","merge_commit_sha":"7f2377f390299fc773b797d20b8786e03dae685a","assignee":{"login":"chirimoya","id":627313,"avatar_url":"https://avatars.githubusercontent.com/u/627313?v=3","gravatar_id":"","url":"https://api.github.com/users/chirimoya","html_url":"https://github.com/chirimoya","followers_url":"https://api.github.com/users/chirimoya/followers","following_url":"https://api.github.com/users/chirimoya/following{/other_user}","gists_url":"https://api.github.com/users/chirimoya/gists{/gist_id}","starred_url":"https://api.github.com/users/chirimoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirimoya/subscriptions","organizations_url":"https://api.github.com/users/chirimoya/orgs","repos_url":"https://api.github.com/users/chirimoya/repos","events_url":"https://api.github.com/users/chirimoya/events{/privacy}","received_events_url":"https://api.github.com/users/chirimoya/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2319/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2319/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2319/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/15b6136ca1da8f960efeaf55e068d6a61a2aee78","head":{"label":"wachterjohannes:hotfix/uid-validation","ref":"hotfix/uid-validation","sha":"15b6136ca1da8f960efeaf55e068d6a61a2aee78","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"repo":{"id":53324547,"name":"sulu","full_name":"wachterjohannes/sulu","owner":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wachterjohannes/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/wachterjohannes/sulu","forks_url":"https://api.github.com/repos/wachterjohannes/sulu/forks","keys_url":"https://api.github.com/repos/wachterjohannes/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wachterjohannes/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wachterjohannes/sulu/teams","hooks_url":"https://api.github.com/repos/wachterjohannes/sulu/hooks","issue_events_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/wachterjohannes/sulu/events","assignees_url":"https://api.github.com/repos/wachterjohannes/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/wachterjohannes/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/wachterjohannes/sulu/tags","blobs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wachterjohannes/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/wachterjohannes/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wachterjohannes/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/wachterjohannes/sulu/languages","stargazers_url":"https://api.github.com/repos/wachterjohannes/sulu/stargazers","contributors_url":"https://api.github.com/repos/wachterjohannes/sulu/contributors","subscribers_url":"https://api.github.com/repos/wachterjohannes/sulu/subscribers","subscription_url":"https://api.github.com/repos/wachterjohannes/sulu/subscription","commits_url":"https://api.github.com/repos/wachterjohannes/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/wachterjohannes/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/wachterjohannes/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/wachterjohannes/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/wachterjohannes/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wachterjohannes/sulu/merges","archive_url":"https://api.github.com/repos/wachterjohannes/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wachterjohannes/sulu/downloads","issues_url":"https://api.github.com/repos/wachterjohannes/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/wachterjohannes/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/wachterjohannes/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/wachterjohannes/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wachterjohannes/sulu/labels{/name}","releases_url":"https://api.github.com/repos/wachterjohannes/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/wachterjohannes/sulu/deployments","created_at":"2016-03-07T12:38:55Z","updated_at":"2016-03-07T12:39:01Z","pushed_at":"2016-04-21T09:27:12Z","git_url":"git://github.com/wachterjohannes/sulu.git","ssh_url":"git@github.com:wachterjohannes/sulu.git","clone_url":"https://github.com/wachterjohannes/sulu.git","svn_url":"https://github.com/wachterjohannes/sulu","homepage":"sulu.io","size":65380,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:master","ref":"master","sha":"98ef3eabccfff846396c30116f60812941531121","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-04-14T09:06:25Z","pushed_at":"2016-04-21T09:32:25Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":75475,"stargazers_count":111,"watchers_count":111,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":356,"forks":30,"open_issues":356,"watchers":111,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2319"},"html":{"href":"https://github.com/sulu/sulu/pull/2319"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2319"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2319/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2319/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2319/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/15b6136ca1da8f960efeaf55e068d6a61a2aee78"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chirimoya","id":627313,"avatar_url":"https://avatars.githubusercontent.com/u/627313?v=3","gravatar_id":"","url":"https://api.github.com/users/chirimoya","html_url":"https://github.com/chirimoya","followers_url":"https://api.github.com/users/chirimoya/followers","following_url":"https://api.github.com/users/chirimoya/following{/other_user}","gists_url":"https://api.github.com/users/chirimoya/gists{/gist_id}","starred_url":"https://api.github.com/users/chirimoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirimoya/subscriptions","organizations_url":"https://api.github.com/users/chirimoya/orgs","repos_url":"https://api.github.com/users/chirimoya/repos","events_url":"https://api.github.com/users/chirimoya/events{/privacy}","received_events_url":"https://api.github.com/users/chirimoya/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":3}}