{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/kinto.js/pulls/comments/51767407","id":51767407,"diff_hunk":"@@ -14,11 +14,11 @@ You can read more about Kinto features [here](http://kinto.readthedocs.org).\n \n Kinto.js won't try to outsmart you as a conflict resolver. Instead, it provides very explicit ways to know about conflicts, and [simple helpers to handle them](api.md#resolving-conflicts).\n \n-## Transactions\n+## Transactions & rollback\n \n-Ideally, we should wrap the whole synchronization flow related operations within a single transaction. While that's a goal and [part of our roadmap](https://github.com/Kinto/kinto.js/issues/16), right now this isn't implemented.\n+Ideally, we should wrap the whole synchronization flow related operations within a single transaction. While that's a goal and [part of our roadmap](https://github.com/Kinto/kinto.js/issues/16), right now this isn't fully implemented.\n \n-That means if anything fails during the sync flow while some records have already been processed locally, there won't be any rollback performed — and you'll have to handle the situation by hand.\n+That means if anything fails during a given step of the sync flow while some records have already been processed locally already in the previous one, the database should turn into an intermediate inconsistent state.","path":"docs/limitations.md","position":11,"original_position":11,"commit_id":"6a496179a999c0f563d772c83cfdf85f1afa950e","original_commit_id":"6a496179a999c0f563d772c83cfdf85f1afa950e","user":{"login":"rnewman","id":91722,"avatar_url":"https://avatars.githubusercontent.com/u/91722?v=3","gravatar_id":"","url":"https://api.github.com/users/rnewman","html_url":"https://github.com/rnewman","followers_url":"https://api.github.com/users/rnewman/followers","following_url":"https://api.github.com/users/rnewman/following{/other_user}","gists_url":"https://api.github.com/users/rnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/rnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnewman/subscriptions","organizations_url":"https://api.github.com/users/rnewman/orgs","repos_url":"https://api.github.com/users/rnewman/repos","events_url":"https://api.github.com/users/rnewman/events{/privacy}","received_events_url":"https://api.github.com/users/rnewman/received_events","type":"User","site_admin":false},"body":"This sentence needs a little bit of English fixing. Not urgent.","created_at":"2016-02-03T18:47:20Z","updated_at":"2016-02-03T18:47:20Z","html_url":"https://github.com/Kinto/kinto.js/pull/303#discussion_r51767407","pull_request_url":"https://api.github.com/repos/Kinto/kinto.js/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/comments/51767407"},"html":{"href":"https://github.com/Kinto/kinto.js/pull/303#discussion_r51767407"},"pull_request":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/kinto.js/pulls/303","id":56788020,"html_url":"https://github.com/Kinto/kinto.js/pull/303","diff_url":"https://github.com/Kinto/kinto.js/pull/303.diff","patch_url":"https://github.com/Kinto/kinto.js/pull/303.patch","issue_url":"https://api.github.com/repos/Kinto/kinto.js/issues/303","number":303,"state":"closed","locked":false,"title":"Add support for transactions at the adapter level (fixes #16, fixes #93, fixes #172, fixes #177)","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"body":"Currently we have ~50% percent of performance improvement :)\r\n\r\nIn order to be merged, this PR would require:\r\n* [x] Migration of Firefox adapter to new API\r\n* [x] Get rid of localstorage\r\n* [x] Documentation update\r\n* [x] File an issue to get rid of `Object.assign` using rest-object spread plugin - #304\r\n* [x] Docstrings for `execute()`\r\n* [x] Check the demo :)\r\n* [x] Add a new section with breaking changes (Upgrade/changelog)\r\n* [x] Check that documentation does not mention anymore anything like «*kinto.js does not handle transactions*»\r\n* [x] Push to try\r\n* [x] Add a test in firefox storage to assert rollbacks\r\n* [ ] Review of mark or/and richard\r\n* [x] Get rid of atomic operations in adapters\r\n* [x] Clarify how transactions errors should be presented in sync result\r\n* [x] Turn the `TransactionProxy` class into a function\r\n* [x] Check all package npm commands keep running properly","created_at":"2016-01-21T18:17:10Z","updated_at":"2016-02-03T18:47:21Z","closed_at":"2016-01-28T12:18:21Z","merged_at":"2016-01-28T12:18:21Z","merge_commit_sha":"e975847fe3ff8bce24bb6f90e568ac28a2fe016f","assignee":null,"milestone":{"url":"https://api.github.com/repos/Kinto/kinto.js/milestones/2","html_url":"https://github.com/Kinto/kinto.js/milestones/2.0.0","labels_url":"https://api.github.com/repos/Kinto/kinto.js/milestones/2/labels","id":1293356,"number":2,"title":"2.0.0","description":"","creator":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":15,"state":"open","created_at":"2015-09-07T09:04:43Z","updated_at":"2016-02-03T15:13:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Kinto/kinto.js/pulls/303/commits","review_comments_url":"https://api.github.com/repos/Kinto/kinto.js/pulls/303/comments","review_comment_url":"https://api.github.com/repos/Kinto/kinto.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/kinto.js/issues/303/comments","statuses_url":"https://api.github.com/repos/Kinto/kinto.js/statuses/6a496179a999c0f563d772c83cfdf85f1afa950e","head":{"label":"Kinto:transactions-adapter","ref":"transactions-adapter","sha":"6a496179a999c0f563d772c83cfdf85f1afa950e","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":35978199,"name":"kinto.js","full_name":"Kinto/kinto.js","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto.js","description":"A JavaScript client for Kinto.","fork":false,"url":"https://api.github.com/repos/Kinto/kinto.js","forks_url":"https://api.github.com/repos/Kinto/kinto.js/forks","keys_url":"https://api.github.com/repos/Kinto/kinto.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto.js/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto.js/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto.js/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto.js/events","assignees_url":"https://api.github.com/repos/Kinto/kinto.js/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto.js/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto.js/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto.js/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto.js/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto.js/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto.js/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto.js/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto.js/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto.js/merges","archive_url":"https://api.github.com/repos/Kinto/kinto.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto.js/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto.js/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto.js/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto.js/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto.js/deployments","created_at":"2015-05-20T22:46:31Z","updated_at":"2016-02-01T15:36:04Z","pushed_at":"2016-02-03T14:51:43Z","git_url":"git://github.com/Kinto/kinto.js.git","ssh_url":"git@github.com:Kinto/kinto.js.git","clone_url":"https://github.com/Kinto/kinto.js.git","svn_url":"https://github.com/Kinto/kinto.js","homepage":"http://kintojs.readthedocs.org/","size":7019,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":27,"forks":8,"open_issues":27,"watchers":63,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"26dc17b6a9533dc51c135ef093e93c5ce083aa73","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":35978199,"name":"kinto.js","full_name":"Kinto/kinto.js","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto.js","description":"A JavaScript client for Kinto.","fork":false,"url":"https://api.github.com/repos/Kinto/kinto.js","forks_url":"https://api.github.com/repos/Kinto/kinto.js/forks","keys_url":"https://api.github.com/repos/Kinto/kinto.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto.js/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto.js/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto.js/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto.js/events","assignees_url":"https://api.github.com/repos/Kinto/kinto.js/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto.js/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto.js/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto.js/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto.js/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto.js/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto.js/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto.js/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto.js/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto.js/merges","archive_url":"https://api.github.com/repos/Kinto/kinto.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto.js/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto.js/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto.js/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto.js/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto.js/deployments","created_at":"2015-05-20T22:46:31Z","updated_at":"2016-02-01T15:36:04Z","pushed_at":"2016-02-03T14:51:43Z","git_url":"git://github.com/Kinto/kinto.js.git","ssh_url":"git@github.com:Kinto/kinto.js.git","clone_url":"https://github.com/Kinto/kinto.js.git","svn_url":"https://github.com/Kinto/kinto.js","homepage":"http://kintojs.readthedocs.org/","size":7019,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":27,"forks":8,"open_issues":27,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/303"},"html":{"href":"https://github.com/Kinto/kinto.js/pull/303"},"issue":{"href":"https://api.github.com/repos/Kinto/kinto.js/issues/303"},"comments":{"href":"https://api.github.com/repos/Kinto/kinto.js/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/kinto.js/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/kinto.js/statuses/6a496179a999c0f563d772c83cfdf85f1afa950e"}}}}