{"action":"created","issue":{"url":"https://api.github.com/repos/philsquared/Catch/issues/701","repository_url":"https://api.github.com/repos/philsquared/Catch","labels_url":"https://api.github.com/repos/philsquared/Catch/issues/701/labels{/name}","comments_url":"https://api.github.com/repos/philsquared/Catch/issues/701/comments","events_url":"https://api.github.com/repos/philsquared/Catch/issues/701/events","html_url":"https://github.com/philsquared/Catch/pull/701","id":172985064,"number":701,"title":"Fixes for XML encoding.","user":{"login":"razeh","id":174737,"avatar_url":"https://avatars.githubusercontent.com/u/174737?v=3","gravatar_id":"","url":"https://api.github.com/users/razeh","html_url":"https://github.com/razeh","followers_url":"https://api.github.com/users/razeh/followers","following_url":"https://api.github.com/users/razeh/following{/other_user}","gists_url":"https://api.github.com/users/razeh/gists{/gist_id}","starred_url":"https://api.github.com/users/razeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razeh/subscriptions","organizations_url":"https://api.github.com/users/razeh/orgs","repos_url":"https://api.github.com/users/razeh/repos","events_url":"https://api.github.com/users/razeh/events{/privacy}","received_events_url":"https://api.github.com/users/razeh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-24T15:31:34Z","updated_at":"2016-10-14T18:06:41Z","closed_at":"2016-09-22T16:44:14Z","pull_request":{"url":"https://api.github.com/repos/philsquared/Catch/pulls/701","html_url":"https://github.com/philsquared/Catch/pull/701","diff_url":"https://github.com/philsquared/Catch/pull/701.diff","patch_url":"https://github.com/philsquared/Catch/pull/701.patch"},"body":"This commit fixes the following scenario:\r\n  * You have a test that compares strings with embedded control\r\n  characters.\r\n  * The test fails.\r\n  * You are using JUnit tests within TeamCity.\r\n\r\nBefore this commit, the JUnit report watcher fails on parsing the XML\r\nfor two reasons: the control characters are missing a semicolon at the\r\nend, and the XML document doesn't specify that it is XML 1.1.\r\n\r\nXML 1.0 --- what we get if we don't specify an XML version --- doesn't support embedding control characters --- see\r\nhttp://stackoverflow.com/questions/404107/why-are-control-characters-illegal-in-xml\r\nfor all of the gory details.\r\n\r\nThis is based on PR #588 by @mrpi"},"comment":{"url":"https://api.github.com/repos/philsquared/Catch/issues/comments/253877827","html_url":"https://github.com/philsquared/Catch/pull/701#issuecomment-253877827","issue_url":"https://api.github.com/repos/philsquared/Catch/issues/701","id":253877827,"user":{"login":"razeh","id":174737,"avatar_url":"https://avatars.githubusercontent.com/u/174737?v=3","gravatar_id":"","url":"https://api.github.com/users/razeh","html_url":"https://github.com/razeh","followers_url":"https://api.github.com/users/razeh/followers","following_url":"https://api.github.com/users/razeh/following{/other_user}","gists_url":"https://api.github.com/users/razeh/gists{/gist_id}","starred_url":"https://api.github.com/users/razeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razeh/subscriptions","organizations_url":"https://api.github.com/users/razeh/orgs","repos_url":"https://api.github.com/users/razeh/repos","events_url":"https://api.github.com/users/razeh/events{/privacy}","received_events_url":"https://api.github.com/users/razeh/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T18:06:40Z","updated_at":"2016-10-14T18:06:40Z","body":"Argh.  I hit send too soon.\n\nAn alternative would be to escape the strings into normal text --- and not\ntrying to come up with the right XML representation for binary.\n\nIf you'd be willing to go entertain that line of thought, I can try coming\nup with something over the weekend.\n\nRobert\n\nOn Fri, Oct 14, 2016 at 1:05 PM, Robert Zeh <robert.a.zeh@gmail.com> wrote:\n\n> Yeap :-(\n>\n> An alternative would be to escape the strings ourselves into something\n> normal text, rather than trying to represent them as XML.\n>\n> If you'd be willing to go down that line of thought, I can try coming up\n> with something over the weekend.\n>\n> Robert\n>\n>\n> On Fri, Oct 14, 2016 at 1:02 PM, Phil Nash <notifications@github.com>\n> wrote:\n>\n>> /insert face palm gif here\n>>\n>> I'll have to look at making it optional.\n>> That's going to suck, though. Looks like there's no clear win here?\n>>\n>> —\n>> You are receiving this because you authored the thread.\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/philsquared/Catch/pull/701#issuecomment-253876501>,\n>> or mute the thread\n>> <https://github.com/notifications/unsubscribe-auth/AAKqkU4ZV5HgHPKAbS5N_3MXNsdcFIW5ks5qz8PPgaJpZM4JsJAN>\n>> .\n>>\n>\n>\n"}}
{"actor":{"display_login":"razeh"}}