{"action":"closed","number":495,"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495","id":68482254,"html_url":"https://github.com/phoenixframework/phoenix_guides/pull/495","diff_url":"https://github.com/phoenixframework/phoenix_guides/pull/495.diff","patch_url":"https://github.com/phoenixframework/phoenix_guides/pull/495.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/495","number":495,"state":"closed","locked":false,"title":"Remove duplicate reviews path in routing guide","user":{"login":"brunozrk","id":2067900,"avatar_url":"https://avatars.githubusercontent.com/u/2067900?v=3","gravatar_id":"","url":"https://api.github.com/users/brunozrk","html_url":"https://github.com/brunozrk","followers_url":"https://api.github.com/users/brunozrk/followers","following_url":"https://api.github.com/users/brunozrk/following{/other_user}","gists_url":"https://api.github.com/users/brunozrk/gists{/gist_id}","starred_url":"https://api.github.com/users/brunozrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunozrk/subscriptions","organizations_url":"https://api.github.com/users/brunozrk/orgs","repos_url":"https://api.github.com/users/brunozrk/repos","events_url":"https://api.github.com/users/brunozrk/events{/privacy}","received_events_url":"https://api.github.com/users/brunozrk/received_events","type":"User","site_admin":false},"body":"When I say `duplicate`, I mean this:\r\n\r\n`/reviews/reviews/`\r\n\r\nIn routing guide, we have codes like this:\r\n\r\n    scope \"/reviews\" do\r\n      # Use the default browser stack.\r\n      pipe_through [:browser, :review_checks, :other_great_stuff]\r\n\r\n      resources \"/reviews\", HelloPhoenix.ReviewController\r\n    end\r\n\r\nwhich generates the following paths:\r\n\r\n    review_path  GET     /reviews/reviews           HelloPhoenix.ReviewController :index\r\n    review_path  GET     /reviews/reviews/:id/edit  HelloPhoenix.ReviewController :edit\r\n    review_path  GET     /reviews/reviews/new       HelloPhoenix.ReviewController :new\r\n    review_path  GET     /reviews/reviews/:id       HelloPhoenix.ReviewController :show\r\n    review_path  POST    /reviews/reviews           HelloPhoenix.ReviewController :create\r\n    review_path  PATCH   /reviews/reviews/:id       HelloPhoenix.ReviewController :update\r\n                 PUT     /reviews/reviews/:id       HelloPhoenix.ReviewController :update\r\n    review_path  DELETE  /reviews/reviews/:id       HelloPhoenix.ReviewController :delete\r\n \r\nI think it should be only:\r\n\r\n        review_path  GET     /reviews          HelloPhoenix.ReviewController :index\r\n        .\r\n        .\r\n        .\r\n\r\nAm I right?","created_at":"2016-04-30T23:38:45Z","updated_at":"2016-05-23T19:18:03Z","closed_at":"2016-05-23T19:18:03Z","merged_at":"2016-05-23T19:18:03Z","merge_commit_sha":"c74ad48aca2e1205caaef3eb3446b5fa8306a871","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/495/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/865065298b63024dd0a466be0880c6c417e664ba","head":{"label":"brunozrk:adjust-review-resources","ref":"adjust-review-resources","sha":"865065298b63024dd0a466be0880c6c417e664ba","user":{"login":"brunozrk","id":2067900,"avatar_url":"https://avatars.githubusercontent.com/u/2067900?v=3","gravatar_id":"","url":"https://api.github.com/users/brunozrk","html_url":"https://github.com/brunozrk","followers_url":"https://api.github.com/users/brunozrk/followers","following_url":"https://api.github.com/users/brunozrk/following{/other_user}","gists_url":"https://api.github.com/users/brunozrk/gists{/gist_id}","starred_url":"https://api.github.com/users/brunozrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunozrk/subscriptions","organizations_url":"https://api.github.com/users/brunozrk/orgs","repos_url":"https://api.github.com/users/brunozrk/repos","events_url":"https://api.github.com/users/brunozrk/events{/privacy}","received_events_url":"https://api.github.com/users/brunozrk/received_events","type":"User","site_admin":false},"repo":{"id":57465747,"name":"phoenix_guides","full_name":"brunozrk/phoenix_guides","owner":{"login":"brunozrk","id":2067900,"avatar_url":"https://avatars.githubusercontent.com/u/2067900?v=3","gravatar_id":"","url":"https://api.github.com/users/brunozrk","html_url":"https://github.com/brunozrk","followers_url":"https://api.github.com/users/brunozrk/followers","following_url":"https://api.github.com/users/brunozrk/following{/other_user}","gists_url":"https://api.github.com/users/brunozrk/gists{/gist_id}","starred_url":"https://api.github.com/users/brunozrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunozrk/subscriptions","organizations_url":"https://api.github.com/users/brunozrk/orgs","repos_url":"https://api.github.com/users/brunozrk/repos","events_url":"https://api.github.com/users/brunozrk/events{/privacy}","received_events_url":"https://api.github.com/users/brunozrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brunozrk/phoenix_guides","description":"User guides for the Phoenix web development framework.","fork":true,"url":"https://api.github.com/repos/brunozrk/phoenix_guides","forks_url":"https://api.github.com/repos/brunozrk/phoenix_guides/forks","keys_url":"https://api.github.com/repos/brunozrk/phoenix_guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunozrk/phoenix_guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunozrk/phoenix_guides/teams","hooks_url":"https://api.github.com/repos/brunozrk/phoenix_guides/hooks","issue_events_url":"https://api.github.com/repos/brunozrk/phoenix_guides/issues/events{/number}","events_url":"https://api.github.com/repos/brunozrk/phoenix_guides/events","assignees_url":"https://api.github.com/repos/brunozrk/phoenix_guides/assignees{/user}","branches_url":"https://api.github.com/repos/brunozrk/phoenix_guides/branches{/branch}","tags_url":"https://api.github.com/repos/brunozrk/phoenix_guides/tags","blobs_url":"https://api.github.com/repos/brunozrk/phoenix_guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunozrk/phoenix_guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunozrk/phoenix_guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunozrk/phoenix_guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunozrk/phoenix_guides/statuses/{sha}","languages_url":"https://api.github.com/repos/brunozrk/phoenix_guides/languages","stargazers_url":"https://api.github.com/repos/brunozrk/phoenix_guides/stargazers","contributors_url":"https://api.github.com/repos/brunozrk/phoenix_guides/contributors","subscribers_url":"https://api.github.com/repos/brunozrk/phoenix_guides/subscribers","subscription_url":"https://api.github.com/repos/brunozrk/phoenix_guides/subscription","commits_url":"https://api.github.com/repos/brunozrk/phoenix_guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunozrk/phoenix_guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunozrk/phoenix_guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunozrk/phoenix_guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunozrk/phoenix_guides/contents/{+path}","compare_url":"https://api.github.com/repos/brunozrk/phoenix_guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunozrk/phoenix_guides/merges","archive_url":"https://api.github.com/repos/brunozrk/phoenix_guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunozrk/phoenix_guides/downloads","issues_url":"https://api.github.com/repos/brunozrk/phoenix_guides/issues{/number}","pulls_url":"https://api.github.com/repos/brunozrk/phoenix_guides/pulls{/number}","milestones_url":"https://api.github.com/repos/brunozrk/phoenix_guides/milestones{/number}","notifications_url":"https://api.github.com/repos/brunozrk/phoenix_guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunozrk/phoenix_guides/labels{/name}","releases_url":"https://api.github.com/repos/brunozrk/phoenix_guides/releases{/id}","deployments_url":"https://api.github.com/repos/brunozrk/phoenix_guides/deployments","created_at":"2016-04-30T23:14:24Z","updated_at":"2016-04-30T23:14:25Z","pushed_at":"2016-04-30T23:24:05Z","git_url":"git://github.com/brunozrk/phoenix_guides.git","ssh_url":"git@github.com:brunozrk/phoenix_guides.git","clone_url":"https://github.com/brunozrk/phoenix_guides.git","svn_url":"https://github.com/brunozrk/phoenix_guides","homepage":null,"size":1719,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"f0c60aed0efcf58d8382d9263d8c4c0a3c9a9596","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":22436876,"name":"phoenix_guides","full_name":"phoenixframework/phoenix_guides","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix_guides","description":"User guides for the Phoenix web development framework.","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix_guides","forks_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/releases{/id}","deployments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/deployments","created_at":"2014-07-30T17:00:36Z","updated_at":"2016-05-23T18:59:41Z","pushed_at":"2016-05-23T19:18:03Z","git_url":"git://github.com/phoenixframework/phoenix_guides.git","ssh_url":"git@github.com:phoenixframework/phoenix_guides.git","clone_url":"https://github.com/phoenixframework/phoenix_guides.git","svn_url":"https://github.com/phoenixframework/phoenix_guides","homepage":null,"size":1881,"stargazers_count":340,"watchers_count":340,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":34,"forks":181,"open_issues":34,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495"},"html":{"href":"https://github.com/phoenixframework/phoenix_guides/pull/495"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/495"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/865065298b63024dd0a466be0880c6c417e664ba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeregrine","id":100886,"avatar_url":"https://avatars.githubusercontent.com/u/100886?v=3","gravatar_id":"","url":"https://api.github.com/users/jeregrine","html_url":"https://github.com/jeregrine","followers_url":"https://api.github.com/users/jeregrine/followers","following_url":"https://api.github.com/users/jeregrine/following{/other_user}","gists_url":"https://api.github.com/users/jeregrine/gists{/gist_id}","starred_url":"https://api.github.com/users/jeregrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeregrine/subscriptions","organizations_url":"https://api.github.com/users/jeregrine/orgs","repos_url":"https://api.github.com/users/jeregrine/repos","events_url":"https://api.github.com/users/jeregrine/events{/privacy}","received_events_url":"https://api.github.com/users/jeregrine/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jeregrine"}}