{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/38","repository_url":"https://api.github.com/repos/openmrs/openmrs-module-owa","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/38/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/38/events","html_url":"https://github.com/openmrs/openmrs-module-owa/pull/38","id":132305757,"number":38,"title":"📗 Fixed filter to use global property","user":{"login":"psbrandt","id":668093,"avatar_url":"https://avatars.githubusercontent.com/u/668093?v=3","gravatar_id":"","url":"https://api.github.com/users/psbrandt","html_url":"https://github.com/psbrandt","followers_url":"https://api.github.com/users/psbrandt/followers","following_url":"https://api.github.com/users/psbrandt/following{/other_user}","gists_url":"https://api.github.com/users/psbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/psbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psbrandt/subscriptions","organizations_url":"https://api.github.com/users/psbrandt/orgs","repos_url":"https://api.github.com/users/psbrandt/repos","events_url":"https://api.github.com/users/psbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/psbrandt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-09T01:24:12Z","updated_at":"2016-03-01T10:37:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-owa/pulls/38","html_url":"https://github.com/openmrs/openmrs-module-owa/pull/38","diff_url":"https://github.com/openmrs/openmrs-module-owa/pull/38.diff","patch_url":"https://github.com/openmrs/openmrs-module-owa/pull/38.patch"},"body":"The baseUrl global property wasn't working because the path it was checking for (and invoked on) was hard coded. The filter is now invoked for every URL and checks programatically using the global property. The solution doesn't seem optimal, so I'm open to suggestions for improvement."},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/comments/190655795","html_url":"https://github.com/openmrs/openmrs-module-owa/pull/38#issuecomment-190655795","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-owa/issues/38","id":190655795,"user":{"login":"sunbiz","id":1017771,"avatar_url":"https://avatars.githubusercontent.com/u/1017771?v=3","gravatar_id":"","url":"https://api.github.com/users/sunbiz","html_url":"https://github.com/sunbiz","followers_url":"https://api.github.com/users/sunbiz/followers","following_url":"https://api.github.com/users/sunbiz/following{/other_user}","gists_url":"https://api.github.com/users/sunbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/sunbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunbiz/subscriptions","organizations_url":"https://api.github.com/users/sunbiz/orgs","repos_url":"https://api.github.com/users/sunbiz/repos","events_url":"https://api.github.com/users/sunbiz/events{/privacy}","received_events_url":"https://api.github.com/users/sunbiz/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T10:37:27Z","updated_at":"2016-03-01T10:37:27Z","body":"This is useful when you want to run apps from another server besides openmrs-hosting servlet container. like someone writing a php owa, and hosting it from nginx instead of tomcat. So its base URL is different. Off course one has to then deal with CORS on openmrs host. But think of an nginx reverse proxy in front of tomcat and the apps are hosted through nginx instead of tomcat. I think that should be the default way to do it in a large, multi-tenant production environment."}}