{"action":"created","comment":{"url":"https://api.github.com/repos/o19s/grand_central/pulls/comments/63736962","id":63736962,"diff_hunk":"@@ -343,7 +344,7 @@ else if (left.getLastRequest() < right.getLastRequest())\n    * @throws IOException\n    */\n   private void refreshPods() throws IOException {\n-    HttpGet podsGet = new HttpGet(\"https://\" + k8sConfiguration.getMasterIp() + \":443/api/v1/namespaces/\" + k8sConfiguration.getNamespace() + \"/pods\");\n+    HttpGet podsGet = new HttpGet(k8sConfiguration.getProtocol() + \"://\" + k8sConfiguration.getMasterIp() + \"/api/v1/namespaces/\" + k8sConfiguration.getNamespace() + \"/pods\");","path":"src/main/java/com/o19s/grandcentral/kubernetes/PodManager.java","position":13,"original_position":13,"commit_id":"36fa649c8da1d0d74db04350b6894abcc4028e73","original_commit_id":"36fa649c8da1d0d74db04350b6894abcc4028e73","user":{"login":"bradfordcp","id":135264,"avatar_url":"https://avatars.githubusercontent.com/u/135264?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfordcp","html_url":"https://github.com/bradfordcp","followers_url":"https://api.github.com/users/bradfordcp/followers","following_url":"https://api.github.com/users/bradfordcp/following{/other_user}","gists_url":"https://api.github.com/users/bradfordcp/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfordcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfordcp/subscriptions","organizations_url":"https://api.github.com/users/bradfordcp/orgs","repos_url":"https://api.github.com/users/bradfordcp/repos","events_url":"https://api.github.com/users/bradfordcp/events{/privacy}","received_events_url":"https://api.github.com/users/bradfordcp/received_events","type":"User","site_admin":false},"body":"I'd like to see the GKE dashboard again and verify they just surface up an IP. \r\n\r\nIf we rename the parameter to `master_url` and include `https` in the sample config file we have the same number of parameters today and don't rely on a hidden configuration value.","created_at":"2016-05-18T16:30:45Z","updated_at":"2016-05-18T16:30:45Z","html_url":"https://github.com/o19s/grand_central/pull/9#discussion_r63736962","pull_request_url":"https://api.github.com/repos/o19s/grand_central/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/comments/63736962"},"html":{"href":"https://github.com/o19s/grand_central/pull/9#discussion_r63736962"},"pull_request":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/o19s/grand_central/pulls/9","id":70525729,"html_url":"https://github.com/o19s/grand_central/pull/9","diff_url":"https://github.com/o19s/grand_central/pull/9.diff","patch_url":"https://github.com/o19s/grand_central/pull/9.patch","issue_url":"https://api.github.com/repos/o19s/grand_central/issues/9","number":9,"state":"open","locked":false,"title":"Initial support for testing","user":{"login":"omnifroodle","id":2264,"avatar_url":"https://avatars.githubusercontent.com/u/2264?v=3","gravatar_id":"","url":"https://api.github.com/users/omnifroodle","html_url":"https://github.com/omnifroodle","followers_url":"https://api.github.com/users/omnifroodle/followers","following_url":"https://api.github.com/users/omnifroodle/following{/other_user}","gists_url":"https://api.github.com/users/omnifroodle/gists{/gist_id}","starred_url":"https://api.github.com/users/omnifroodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnifroodle/subscriptions","organizations_url":"https://api.github.com/users/omnifroodle/orgs","repos_url":"https://api.github.com/users/omnifroodle/repos","events_url":"https://api.github.com/users/omnifroodle/events{/privacy}","received_events_url":"https://api.github.com/users/omnifroodle/received_events","type":"User","site_admin":false},"body":"More to come..\r\n\r\nThis approach to testing uses a disposable web server to impersonate kubernetes(wire mock).  To make this simpler I've setup the action I'm testing to allow for http or https (with https as the default).\r\n\r\nAlso, why does Java not have multiline strings 😦 ","created_at":"2016-05-18T13:17:33Z","updated_at":"2016-05-18T16:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45b855884c6426ee698bb1be1b3467a3da2f1c97","assignee":{"login":"bradfordcp","id":135264,"avatar_url":"https://avatars.githubusercontent.com/u/135264?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfordcp","html_url":"https://github.com/bradfordcp","followers_url":"https://api.github.com/users/bradfordcp/followers","following_url":"https://api.github.com/users/bradfordcp/following{/other_user}","gists_url":"https://api.github.com/users/bradfordcp/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfordcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfordcp/subscriptions","organizations_url":"https://api.github.com/users/bradfordcp/orgs","repos_url":"https://api.github.com/users/bradfordcp/repos","events_url":"https://api.github.com/users/bradfordcp/events{/privacy}","received_events_url":"https://api.github.com/users/bradfordcp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/o19s/grand_central/pulls/9/commits","review_comments_url":"https://api.github.com/repos/o19s/grand_central/pulls/9/comments","review_comment_url":"https://api.github.com/repos/o19s/grand_central/pulls/comments{/number}","comments_url":"https://api.github.com/repos/o19s/grand_central/issues/9/comments","statuses_url":"https://api.github.com/repos/o19s/grand_central/statuses/36fa649c8da1d0d74db04350b6894abcc4028e73","head":{"label":"o19s:testing","ref":"testing","sha":"36fa649c8da1d0d74db04350b6894abcc4028e73","user":{"login":"o19s","id":339001,"avatar_url":"https://avatars.githubusercontent.com/u/339001?v=3","gravatar_id":"","url":"https://api.github.com/users/o19s","html_url":"https://github.com/o19s","followers_url":"https://api.github.com/users/o19s/followers","following_url":"https://api.github.com/users/o19s/following{/other_user}","gists_url":"https://api.github.com/users/o19s/gists{/gist_id}","starred_url":"https://api.github.com/users/o19s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o19s/subscriptions","organizations_url":"https://api.github.com/users/o19s/orgs","repos_url":"https://api.github.com/users/o19s/repos","events_url":"https://api.github.com/users/o19s/events{/privacy}","received_events_url":"https://api.github.com/users/o19s/received_events","type":"Organization","site_admin":false},"repo":{"id":51393768,"name":"grand_central","full_name":"o19s/grand_central","owner":{"login":"o19s","id":339001,"avatar_url":"https://avatars.githubusercontent.com/u/339001?v=3","gravatar_id":"","url":"https://api.github.com/users/o19s","html_url":"https://github.com/o19s","followers_url":"https://api.github.com/users/o19s/followers","following_url":"https://api.github.com/users/o19s/following{/other_user}","gists_url":"https://api.github.com/users/o19s/gists{/gist_id}","starred_url":"https://api.github.com/users/o19s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o19s/subscriptions","organizations_url":"https://api.github.com/users/o19s/orgs","repos_url":"https://api.github.com/users/o19s/repos","events_url":"https://api.github.com/users/o19s/events{/privacy}","received_events_url":"https://api.github.com/users/o19s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/o19s/grand_central","description":"Docker & Kubernetes deployment system for dynamic environments.","fork":false,"url":"https://api.github.com/repos/o19s/grand_central","forks_url":"https://api.github.com/repos/o19s/grand_central/forks","keys_url":"https://api.github.com/repos/o19s/grand_central/keys{/key_id}","collaborators_url":"https://api.github.com/repos/o19s/grand_central/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/o19s/grand_central/teams","hooks_url":"https://api.github.com/repos/o19s/grand_central/hooks","issue_events_url":"https://api.github.com/repos/o19s/grand_central/issues/events{/number}","events_url":"https://api.github.com/repos/o19s/grand_central/events","assignees_url":"https://api.github.com/repos/o19s/grand_central/assignees{/user}","branches_url":"https://api.github.com/repos/o19s/grand_central/branches{/branch}","tags_url":"https://api.github.com/repos/o19s/grand_central/tags","blobs_url":"https://api.github.com/repos/o19s/grand_central/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/o19s/grand_central/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/o19s/grand_central/git/refs{/sha}","trees_url":"https://api.github.com/repos/o19s/grand_central/git/trees{/sha}","statuses_url":"https://api.github.com/repos/o19s/grand_central/statuses/{sha}","languages_url":"https://api.github.com/repos/o19s/grand_central/languages","stargazers_url":"https://api.github.com/repos/o19s/grand_central/stargazers","contributors_url":"https://api.github.com/repos/o19s/grand_central/contributors","subscribers_url":"https://api.github.com/repos/o19s/grand_central/subscribers","subscription_url":"https://api.github.com/repos/o19s/grand_central/subscription","commits_url":"https://api.github.com/repos/o19s/grand_central/commits{/sha}","git_commits_url":"https://api.github.com/repos/o19s/grand_central/git/commits{/sha}","comments_url":"https://api.github.com/repos/o19s/grand_central/comments{/number}","issue_comment_url":"https://api.github.com/repos/o19s/grand_central/issues/comments{/number}","contents_url":"https://api.github.com/repos/o19s/grand_central/contents/{+path}","compare_url":"https://api.github.com/repos/o19s/grand_central/compare/{base}...{head}","merges_url":"https://api.github.com/repos/o19s/grand_central/merges","archive_url":"https://api.github.com/repos/o19s/grand_central/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/o19s/grand_central/downloads","issues_url":"https://api.github.com/repos/o19s/grand_central/issues{/number}","pulls_url":"https://api.github.com/repos/o19s/grand_central/pulls{/number}","milestones_url":"https://api.github.com/repos/o19s/grand_central/milestones{/number}","notifications_url":"https://api.github.com/repos/o19s/grand_central/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/o19s/grand_central/labels{/name}","releases_url":"https://api.github.com/repos/o19s/grand_central/releases{/id}","deployments_url":"https://api.github.com/repos/o19s/grand_central/deployments","created_at":"2016-02-09T19:37:22Z","updated_at":"2016-04-17T05:28:54Z","pushed_at":"2016-05-18T13:17:34Z","git_url":"git://github.com/o19s/grand_central.git","ssh_url":"git@github.com:o19s/grand_central.git","clone_url":"https://github.com/o19s/grand_central.git","svn_url":"https://github.com/o19s/grand_central","homepage":"","size":26,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"o19s:master","ref":"master","sha":"17746c72ef92ea66483814b42f50743f56c72b8e","user":{"login":"o19s","id":339001,"avatar_url":"https://avatars.githubusercontent.com/u/339001?v=3","gravatar_id":"","url":"https://api.github.com/users/o19s","html_url":"https://github.com/o19s","followers_url":"https://api.github.com/users/o19s/followers","following_url":"https://api.github.com/users/o19s/following{/other_user}","gists_url":"https://api.github.com/users/o19s/gists{/gist_id}","starred_url":"https://api.github.com/users/o19s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o19s/subscriptions","organizations_url":"https://api.github.com/users/o19s/orgs","repos_url":"https://api.github.com/users/o19s/repos","events_url":"https://api.github.com/users/o19s/events{/privacy}","received_events_url":"https://api.github.com/users/o19s/received_events","type":"Organization","site_admin":false},"repo":{"id":51393768,"name":"grand_central","full_name":"o19s/grand_central","owner":{"login":"o19s","id":339001,"avatar_url":"https://avatars.githubusercontent.com/u/339001?v=3","gravatar_id":"","url":"https://api.github.com/users/o19s","html_url":"https://github.com/o19s","followers_url":"https://api.github.com/users/o19s/followers","following_url":"https://api.github.com/users/o19s/following{/other_user}","gists_url":"https://api.github.com/users/o19s/gists{/gist_id}","starred_url":"https://api.github.com/users/o19s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o19s/subscriptions","organizations_url":"https://api.github.com/users/o19s/orgs","repos_url":"https://api.github.com/users/o19s/repos","events_url":"https://api.github.com/users/o19s/events{/privacy}","received_events_url":"https://api.github.com/users/o19s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/o19s/grand_central","description":"Docker & Kubernetes deployment system for dynamic environments.","fork":false,"url":"https://api.github.com/repos/o19s/grand_central","forks_url":"https://api.github.com/repos/o19s/grand_central/forks","keys_url":"https://api.github.com/repos/o19s/grand_central/keys{/key_id}","collaborators_url":"https://api.github.com/repos/o19s/grand_central/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/o19s/grand_central/teams","hooks_url":"https://api.github.com/repos/o19s/grand_central/hooks","issue_events_url":"https://api.github.com/repos/o19s/grand_central/issues/events{/number}","events_url":"https://api.github.com/repos/o19s/grand_central/events","assignees_url":"https://api.github.com/repos/o19s/grand_central/assignees{/user}","branches_url":"https://api.github.com/repos/o19s/grand_central/branches{/branch}","tags_url":"https://api.github.com/repos/o19s/grand_central/tags","blobs_url":"https://api.github.com/repos/o19s/grand_central/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/o19s/grand_central/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/o19s/grand_central/git/refs{/sha}","trees_url":"https://api.github.com/repos/o19s/grand_central/git/trees{/sha}","statuses_url":"https://api.github.com/repos/o19s/grand_central/statuses/{sha}","languages_url":"https://api.github.com/repos/o19s/grand_central/languages","stargazers_url":"https://api.github.com/repos/o19s/grand_central/stargazers","contributors_url":"https://api.github.com/repos/o19s/grand_central/contributors","subscribers_url":"https://api.github.com/repos/o19s/grand_central/subscribers","subscription_url":"https://api.github.com/repos/o19s/grand_central/subscription","commits_url":"https://api.github.com/repos/o19s/grand_central/commits{/sha}","git_commits_url":"https://api.github.com/repos/o19s/grand_central/git/commits{/sha}","comments_url":"https://api.github.com/repos/o19s/grand_central/comments{/number}","issue_comment_url":"https://api.github.com/repos/o19s/grand_central/issues/comments{/number}","contents_url":"https://api.github.com/repos/o19s/grand_central/contents/{+path}","compare_url":"https://api.github.com/repos/o19s/grand_central/compare/{base}...{head}","merges_url":"https://api.github.com/repos/o19s/grand_central/merges","archive_url":"https://api.github.com/repos/o19s/grand_central/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/o19s/grand_central/downloads","issues_url":"https://api.github.com/repos/o19s/grand_central/issues{/number}","pulls_url":"https://api.github.com/repos/o19s/grand_central/pulls{/number}","milestones_url":"https://api.github.com/repos/o19s/grand_central/milestones{/number}","notifications_url":"https://api.github.com/repos/o19s/grand_central/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/o19s/grand_central/labels{/name}","releases_url":"https://api.github.com/repos/o19s/grand_central/releases{/id}","deployments_url":"https://api.github.com/repos/o19s/grand_central/deployments","created_at":"2016-02-09T19:37:22Z","updated_at":"2016-04-17T05:28:54Z","pushed_at":"2016-05-18T13:17:34Z","git_url":"git://github.com/o19s/grand_central.git","ssh_url":"git@github.com:o19s/grand_central.git","clone_url":"https://github.com/o19s/grand_central.git","svn_url":"https://github.com/o19s/grand_central","homepage":"","size":26,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/9"},"html":{"href":"https://github.com/o19s/grand_central/pull/9"},"issue":{"href":"https://api.github.com/repos/o19s/grand_central/issues/9"},"comments":{"href":"https://api.github.com/repos/o19s/grand_central/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/o19s/grand_central/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/o19s/grand_central/statuses/36fa649c8da1d0d74db04350b6894abcc4028e73"}}}}