{"action":"opened","number":12757,"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/12757","id":64787017,"html_url":"https://github.com/pydata/pandas/pull/12757","diff_url":"https://github.com/pydata/pandas/pull/12757.diff","patch_url":"https://github.com/pydata/pandas/pull/12757.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/12757","number":12757,"state":"open","locked":false,"title":"BUG: `loffset` argument not applied for `resample().count()` on timeseries","user":{"login":"onesandzeroes","id":1460294,"avatar_url":"https://avatars.githubusercontent.com/u/1460294?v=3","gravatar_id":"","url":"https://api.github.com/users/onesandzeroes","html_url":"https://github.com/onesandzeroes","followers_url":"https://api.github.com/users/onesandzeroes/followers","following_url":"https://api.github.com/users/onesandzeroes/following{/other_user}","gists_url":"https://api.github.com/users/onesandzeroes/gists{/gist_id}","starred_url":"https://api.github.com/users/onesandzeroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onesandzeroes/subscriptions","organizations_url":"https://api.github.com/users/onesandzeroes/orgs","repos_url":"https://api.github.com/users/onesandzeroes/repos","events_url":"https://api.github.com/users/onesandzeroes/events{/privacy}","received_events_url":"https://api.github.com/users/onesandzeroes/received_events","type":"User","site_admin":false},"body":" - [x] closes #12725\r\n - [ ] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n\r\nThe code to do this already existed in the `_downsample` method, which is called when using functions like `mean`. `max`, etc., but there was nothing in the `_groupby_and_aggregate` method used for `count` and `size`. If we pull out the offset code from the `_downsample` method into a separate method, we can reuse it without duplicating it.","created_at":"2016-03-31T13:08:17Z","updated_at":"2016-03-31T13:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/12757/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/12757/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/12757/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/627429a2e546cae26576acfdd00855dca968de85","head":{"label":"onesandzeroes:loffset-count","ref":"loffset-count","sha":"627429a2e546cae26576acfdd00855dca968de85","user":{"login":"onesandzeroes","id":1460294,"avatar_url":"https://avatars.githubusercontent.com/u/1460294?v=3","gravatar_id":"","url":"https://api.github.com/users/onesandzeroes","html_url":"https://github.com/onesandzeroes","followers_url":"https://api.github.com/users/onesandzeroes/followers","following_url":"https://api.github.com/users/onesandzeroes/following{/other_user}","gists_url":"https://api.github.com/users/onesandzeroes/gists{/gist_id}","starred_url":"https://api.github.com/users/onesandzeroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onesandzeroes/subscriptions","organizations_url":"https://api.github.com/users/onesandzeroes/orgs","repos_url":"https://api.github.com/users/onesandzeroes/repos","events_url":"https://api.github.com/users/onesandzeroes/events{/privacy}","received_events_url":"https://api.github.com/users/onesandzeroes/received_events","type":"User","site_admin":false},"repo":{"id":10490814,"name":"pandas","full_name":"onesandzeroes/pandas","owner":{"login":"onesandzeroes","id":1460294,"avatar_url":"https://avatars.githubusercontent.com/u/1460294?v=3","gravatar_id":"","url":"https://api.github.com/users/onesandzeroes","html_url":"https://github.com/onesandzeroes","followers_url":"https://api.github.com/users/onesandzeroes/followers","following_url":"https://api.github.com/users/onesandzeroes/following{/other_user}","gists_url":"https://api.github.com/users/onesandzeroes/gists{/gist_id}","starred_url":"https://api.github.com/users/onesandzeroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onesandzeroes/subscriptions","organizations_url":"https://api.github.com/users/onesandzeroes/orgs","repos_url":"https://api.github.com/users/onesandzeroes/repos","events_url":"https://api.github.com/users/onesandzeroes/events{/privacy}","received_events_url":"https://api.github.com/users/onesandzeroes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onesandzeroes/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/onesandzeroes/pandas","forks_url":"https://api.github.com/repos/onesandzeroes/pandas/forks","keys_url":"https://api.github.com/repos/onesandzeroes/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onesandzeroes/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onesandzeroes/pandas/teams","hooks_url":"https://api.github.com/repos/onesandzeroes/pandas/hooks","issue_events_url":"https://api.github.com/repos/onesandzeroes/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/onesandzeroes/pandas/events","assignees_url":"https://api.github.com/repos/onesandzeroes/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/onesandzeroes/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/onesandzeroes/pandas/tags","blobs_url":"https://api.github.com/repos/onesandzeroes/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onesandzeroes/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onesandzeroes/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/onesandzeroes/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onesandzeroes/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/onesandzeroes/pandas/languages","stargazers_url":"https://api.github.com/repos/onesandzeroes/pandas/stargazers","contributors_url":"https://api.github.com/repos/onesandzeroes/pandas/contributors","subscribers_url":"https://api.github.com/repos/onesandzeroes/pandas/subscribers","subscription_url":"https://api.github.com/repos/onesandzeroes/pandas/subscription","commits_url":"https://api.github.com/repos/onesandzeroes/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/onesandzeroes/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/onesandzeroes/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/onesandzeroes/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/onesandzeroes/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/onesandzeroes/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onesandzeroes/pandas/merges","archive_url":"https://api.github.com/repos/onesandzeroes/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onesandzeroes/pandas/downloads","issues_url":"https://api.github.com/repos/onesandzeroes/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/onesandzeroes/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/onesandzeroes/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/onesandzeroes/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onesandzeroes/pandas/labels{/name}","releases_url":"https://api.github.com/repos/onesandzeroes/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/onesandzeroes/pandas/deployments","created_at":"2013-06-04T23:17:27Z","updated_at":"2015-03-26T09:51:23Z","pushed_at":"2016-03-31T13:01:33Z","git_url":"git://github.com/onesandzeroes/pandas.git","ssh_url":"git@github.com:onesandzeroes/pandas.git","clone_url":"https://github.com/onesandzeroes/pandas.git","svn_url":"https://github.com/onesandzeroes/pandas","homepage":"http://pandas.pydata.org","size":79616,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"b04ee0553a78bda4cf7ffe930eab92ea10e95e97","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-03-31T12:30:50Z","pushed_at":"2016-03-31T13:08:17Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":142460,"stargazers_count":5974,"watchers_count":5974,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2443,"mirror_url":null,"open_issues_count":1726,"forks":2443,"open_issues":1726,"watchers":5974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12757"},"html":{"href":"https://github.com/pydata/pandas/pull/12757"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/12757"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/12757/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12757/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12757/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/627429a2e546cae26576acfdd00855dca968de85"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":42,"deletions":8,"changed_files":3}}