{"push_id":1146381225,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"b877548e091c72b836324d65c4714e7461b53a45","before":"1115180ce6d49fc39914468be968e464ad7bed2b","commits":[{"sha":"471891bce03357535c96dc8c5ab5761804e41f36","author":{"name":"fdoray","email":"d478c5035851f621c5d23622e55aa98fa4b3ff2b@chromium.org"},"message":"Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1 id:1 of https://codereview.chromium.org/2037853002/ )\n\nReason for revert:\nMessageLoopForIO::current() has a DCHECK but ThreadTaskRunnerHandle::Get() doesn't. See discussion https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Wj_cNO2l2qE\n\nOriginal issue's description:\n> Remove use of deprecated MessageLoop methods in ipc.\n>\n> MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon\n> are deprecated. This CL makes the following replacements to\n> remove some uses of these methods:\n>\n> \"MessageLoop(ForUI|ForIO)::current()->PostTask\" ->\n>   \"ThreadTaskRunnerHandle::Get()->PostTask\"\n> \"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask\" ->\n>   \"ThreadTaskRunnerHandle::Get()->PostDelayedTask\"\n> \"MessageLoop(ForUI|ForIO)::current()->DeleteSoon\" ->\n>   \"ThreadTaskRunnerHandle::Get()->DeleteSoon\"\n> \"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon\" ->\n>   \"ThreadTaskRunnerHandle::Get()->ReleaseSoon\"\n>\n> In files where these replacements are made, it adds these includes:\n>   #include \"base/location.h\"\n>   #include \"base/single_thread_task_runner.h\"\n>   #include \"base/threading/thread_task_runner_handle.h\"\n>\n> And removes this include if it is no longer required:\n>   #include \"base/message_loop/message_loop.h\"\n>\n> Why ThreadTaskRunnerHandle::Get() instead of\n> MessageLoop::current()->task_runner()?\n>  - The two are equivalent on threads that run a MessageLoop.\n>  - MessageLoop::current() doesn't work in base/task_scheduler\n>    because the scheduler's thread don't run MessageLoops.\n>    This CL will therefore facilitate the migration of browser\n>    threads to base/task_scheduler.\n>\n> Steps to generate this patch:\n> 1. Run message_loop_cleanup.py (see code on the bug).\n> 2. Run tools/sort-headers.py on modified files.\n> 3. Run git cl format.\n>\n> BUG=616447\n> R=cpu@chromium.org\n>\n> Committed: https://crrev.com/2eb9714a01e03a8b091a8ea34f023e24f62e5a9f\n> Cr-Commit-Position: refs/heads/master@{#398040}\n\nTBR=cpu@chromium.org\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT=true\nNOTREECHECKS=true\nNOTRY=true\nBUG=616447\n\nReview-Url: https://codereview.chromium.org/2038363004\nCr-Commit-Position: refs/heads/master@{#398140}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/471891bce03357535c96dc8c5ab5761804e41f36"},{"sha":"b877548e091c72b836324d65c4714e7461b53a45","author":{"name":"janeliulwq","email":"6396c97b52add03e02025bd166f10dddc6e18fde@google.com"},"message":"Changed two icons for desktop user menu on Linux/Windows:\n1. Changed the icon for the \"Manage people\" button;\n2. Changed the icon for sync error on the titlebar.\n\nSee design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz\n\nThis CL is dependent on https://codereview.chromium.org/2028473002/\n\nBUG=615893\n\nReview-Url: https://codereview.chromium.org/2019053002\nCr-Commit-Position: refs/heads/master@{#398141}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/b877548e091c72b836324d65c4714e7461b53a45"}]}
{"actor":{"display_login":"dstockwell"}}