{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/71911284","id":71911284,"diff_hunk":"@@ -81,18 +115,20 @@ function verify_and_test(d::UnivariateDistribution, dct::Dict, n_tsamples::Int)\n         lp = Float64(pt[\"logpdf\"])\n         cf = Float64(pt[\"cdf\"])\n         Base.Test.test_approx_eq(logpdf(d, x), lp, \"logpdf(d, $x)\", \"lp\")\n-        Base.Test.test_approx_eq(cdf(d, x), cf, \"cdf(d, $x)\", \"cf\")\n+        if !isa(d, Skellam)\n+            Base.Test.test_approx_eq(cdf(d, x), cf, \"cdf(d, $x)\", \"cf\")\n+        end\n     end\n \n     try\n         m = mgf(d,0.0)\n-        @test m == 1.0\n+        Base.Test.test_approx_eq(m, 1.0, \"mgf(d, 0.0)\", \"1.0\")","path":"test/univariates.jl","position":79,"original_position":79,"commit_id":"cb2f87c8124e599d28da1fa8d2af9b4fc3e8d955","original_commit_id":"cb2f87c8124e599d28da1fa8d2af9b4fc3e8d955","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"body":"Why is this necessary and why not use the macro?","created_at":"2016-07-22T17:03:36Z","updated_at":"2016-07-22T17:03:36Z","html_url":"https://github.com/JuliaStats/Distributions.jl/pull/511#discussion_r71911284","pull_request_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511","_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/71911284"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/511#discussion_r71911284"},"pull_request":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511","id":76441314,"html_url":"https://github.com/JuliaStats/Distributions.jl/pull/511","diff_url":"https://github.com/JuliaStats/Distributions.jl/pull/511.diff","patch_url":"https://github.com/JuliaStats/Distributions.jl/pull/511.patch","issue_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/511","number":511,"state":"open","locked":false,"title":"Dual number compatibility","user":{"login":"Halmoni100","id":8940025,"avatar_url":"https://avatars.githubusercontent.com/u/8940025?v=3","gravatar_id":"","url":"https://api.github.com/users/Halmoni100","html_url":"https://github.com/Halmoni100","followers_url":"https://api.github.com/users/Halmoni100/followers","following_url":"https://api.github.com/users/Halmoni100/following{/other_user}","gists_url":"https://api.github.com/users/Halmoni100/gists{/gist_id}","starred_url":"https://api.github.com/users/Halmoni100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halmoni100/subscriptions","organizations_url":"https://api.github.com/users/Halmoni100/orgs","repos_url":"https://api.github.com/users/Halmoni100/repos","events_url":"https://api.github.com/users/Halmoni100/events{/privacy}","received_events_url":"https://api.github.com/users/Halmoni100/received_events","type":"User","site_admin":false},"body":"Added compatibility for dual numbers while resolving type instabilities.\r\n\r\nContributed changes to univariate distributions and unit tests, while @jmxpearson contributed to other distributions and some other bug fixes.","created_at":"2016-07-06T14:26:55Z","updated_at":"2016-07-22T17:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a35ca38eb727ba1b63c89549359c5b75580c8d2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511/commits","review_comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511/comments","review_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/511/comments","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/cb2f87c8124e599d28da1fa8d2af9b4fc3e8d955","head":{"label":"Halmoni100:dualnum_compat","ref":"dualnum_compat","sha":"cb2f87c8124e599d28da1fa8d2af9b4fc3e8d955","user":{"login":"Halmoni100","id":8940025,"avatar_url":"https://avatars.githubusercontent.com/u/8940025?v=3","gravatar_id":"","url":"https://api.github.com/users/Halmoni100","html_url":"https://github.com/Halmoni100","followers_url":"https://api.github.com/users/Halmoni100/followers","following_url":"https://api.github.com/users/Halmoni100/following{/other_user}","gists_url":"https://api.github.com/users/Halmoni100/gists{/gist_id}","starred_url":"https://api.github.com/users/Halmoni100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halmoni100/subscriptions","organizations_url":"https://api.github.com/users/Halmoni100/orgs","repos_url":"https://api.github.com/users/Halmoni100/repos","events_url":"https://api.github.com/users/Halmoni100/events{/privacy}","received_events_url":"https://api.github.com/users/Halmoni100/received_events","type":"User","site_admin":false},"repo":{"id":62071563,"name":"Distributions.jl","full_name":"Halmoni100/Distributions.jl","owner":{"login":"Halmoni100","id":8940025,"avatar_url":"https://avatars.githubusercontent.com/u/8940025?v=3","gravatar_id":"","url":"https://api.github.com/users/Halmoni100","html_url":"https://github.com/Halmoni100","followers_url":"https://api.github.com/users/Halmoni100/followers","following_url":"https://api.github.com/users/Halmoni100/following{/other_user}","gists_url":"https://api.github.com/users/Halmoni100/gists{/gist_id}","starred_url":"https://api.github.com/users/Halmoni100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halmoni100/subscriptions","organizations_url":"https://api.github.com/users/Halmoni100/orgs","repos_url":"https://api.github.com/users/Halmoni100/repos","events_url":"https://api.github.com/users/Halmoni100/events{/privacy}","received_events_url":"https://api.github.com/users/Halmoni100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Halmoni100/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":true,"url":"https://api.github.com/repos/Halmoni100/Distributions.jl","forks_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/forks","keys_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/events","assignees_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/merges","archive_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/releases{/id}","deployments_url":"https://api.github.com/repos/Halmoni100/Distributions.jl/deployments","created_at":"2016-06-27T16:36:09Z","updated_at":"2016-06-27T16:36:10Z","pushed_at":"2016-07-19T13:45:30Z","git_url":"git://github.com/Halmoni100/Distributions.jl.git","ssh_url":"git@github.com:Halmoni100/Distributions.jl.git","clone_url":"https://github.com/Halmoni100/Distributions.jl.git","svn_url":"https://github.com/Halmoni100/Distributions.jl","homepage":"","size":2577,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaStats:master","ref":"master","sha":"3bbaf7b7f4a7987bbc71b7ecbf94a36a04e9c0a9","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":6619192,"name":"Distributions.jl","full_name":"JuliaStats/Distributions.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":false,"url":"https://api.github.com/repos/JuliaStats/Distributions.jl","forks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/deployments","created_at":"2012-11-09T20:01:33Z","updated_at":"2016-07-19T11:14:05Z","pushed_at":"2016-07-19T13:45:31Z","git_url":"git://github.com/JuliaStats/Distributions.jl.git","ssh_url":"git@github.com:JuliaStats/Distributions.jl.git","clone_url":"https://github.com/JuliaStats/Distributions.jl.git","svn_url":"https://github.com/JuliaStats/Distributions.jl","homepage":"","size":2713,"stargazers_count":189,"watchers_count":189,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":122,"mirror_url":null,"open_issues_count":79,"forks":122,"open_issues":79,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/511"},"issue":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/511"},"comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/cb2f87c8124e599d28da1fa8d2af9b4fc3e8d955"}}}}
{"actor":{"display_login":"andreasnoack"}}