{"action":"closed","issue":{"url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/165","repository_url":"https://api.github.com/repos/dotse/zonemaster-engine","labels_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/165/comments","events_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/165/events","html_url":"https://github.com/dotse/zonemaster-engine/issues/165","id":124350966,"number":165,"title":"JSON/JSON::XS usage and requirement","user":{"login":"jelu","id":1446909,"avatar_url":"https://avatars.githubusercontent.com/u/1446909?v=3","gravatar_id":"","url":"https://api.github.com/users/jelu","html_url":"https://github.com/jelu","followers_url":"https://api.github.com/users/jelu/followers","following_url":"https://api.github.com/users/jelu/following{/other_user}","gists_url":"https://api.github.com/users/jelu/gists{/gist_id}","starred_url":"https://api.github.com/users/jelu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelu/subscriptions","organizations_url":"https://api.github.com/users/jelu/orgs","repos_url":"https://api.github.com/users/jelu/repos","events_url":"https://api.github.com/users/jelu/events{/privacy}","received_events_url":"https://api.github.com/users/jelu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotse/zonemaster-engine/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/dotse/zonemaster-engine/labels/Usability","name":"Usability","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"vlevigneron","id":5500216,"avatar_url":"https://avatars.githubusercontent.com/u/5500216?v=3","gravatar_id":"","url":"https://api.github.com/users/vlevigneron","html_url":"https://github.com/vlevigneron","followers_url":"https://api.github.com/users/vlevigneron/followers","following_url":"https://api.github.com/users/vlevigneron/following{/other_user}","gists_url":"https://api.github.com/users/vlevigneron/gists{/gist_id}","starred_url":"https://api.github.com/users/vlevigneron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlevigneron/subscriptions","organizations_url":"https://api.github.com/users/vlevigneron/orgs","repos_url":"https://api.github.com/users/vlevigneron/repos","events_url":"https://api.github.com/users/vlevigneron/events{/privacy}","received_events_url":"https://api.github.com/users/vlevigneron/received_events","type":"User","site_admin":false},"assignees":[{"login":"vlevigneron","id":5500216,"avatar_url":"https://avatars.githubusercontent.com/u/5500216?v=3","gravatar_id":"","url":"https://api.github.com/users/vlevigneron","html_url":"https://github.com/vlevigneron","followers_url":"https://api.github.com/users/vlevigneron/followers","following_url":"https://api.github.com/users/vlevigneron/following{/other_user}","gists_url":"https://api.github.com/users/vlevigneron/gists{/gist_id}","starred_url":"https://api.github.com/users/vlevigneron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlevigneron/subscriptions","organizations_url":"https://api.github.com/users/vlevigneron/orgs","repos_url":"https://api.github.com/users/vlevigneron/repos","events_url":"https://api.github.com/users/vlevigneron/events{/privacy}","received_events_url":"https://api.github.com/users/vlevigneron/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotse/zonemaster-engine/milestones/4","html_url":"https://github.com/dotse/zonemaster-engine/milestones/Release%202016.1","labels_url":"https://api.github.com/repos/dotse/zonemaster-engine/milestones/4/labels","id":1439494,"number":4,"title":"Release 2016.1","description":"","creator":{"login":"pawal","id":285882,"avatar_url":"https://avatars.githubusercontent.com/u/285882?v=3","gravatar_id":"","url":"https://api.github.com/users/pawal","html_url":"https://github.com/pawal","followers_url":"https://api.github.com/users/pawal/followers","following_url":"https://api.github.com/users/pawal/following{/other_user}","gists_url":"https://api.github.com/users/pawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawal/subscriptions","organizations_url":"https://api.github.com/users/pawal/orgs","repos_url":"https://api.github.com/users/pawal/repos","events_url":"https://api.github.com/users/pawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawal/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":8,"state":"open","created_at":"2015-12-02T12:52:55Z","updated_at":"2016-06-26T12:38:55Z","due_on":"2016-03-29T22:00:00Z","closed_at":null},"comments":5,"created_at":"2015-12-30T13:54:51Z","updated_at":"2016-06-26T12:38:55Z","closed_at":"2016-06-26T12:38:55Z","body":"If you look at `Makefile.PL`, JSON is required and JSON::XS is recommended but:\r\n- `lib/Zonemaster/Logger.pm` does `use JSON::XS`\r\n- `lib/Zonemaster/Nameserver.pm` does `use JSON::XS`\r\n- `lib/Zonemaster/Test/Nameserver.pm` uses `JSON::XS->new` when creating an object but does not use any JSON*\r\n- `lib/Zonemaster/Logger/Entry.pm` does `use JSON` but uses `JSON::XS->new` when creating an object\r\n- `docs/installation.md` specifies to install JSON::XS altho its just recommended\r\n\r\nEither code and documentation should be changed so that it uses JSON (which uses JSON::XS if available) or JSON::XS should be required and used everywhere."}}
{"actor":{"display_login":"matsduf"}}