{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments/77170567","id":77170567,"diff_hunk":"@@ -556,7 +542,7 @@ def export_mesh(self, node, armature=None, skeyindex=-1, skel_source=None,\n         if armature is not None:\n             si = self.skeleton_info[armature]\n \n-        has_tangents = self.config[\"use_tangent_arrays\"]  # could detect..\n+        has_tangents = self.config[\"use_tangent_arrays\"]  # TODO: Review","path":"io_scene_dae/export_dae.py","position":null,"original_position":114,"commit_id":"24366bc353dcaa472ee80cf764b9a0598b073dcf","original_commit_id":"4b6008a0a4dad0100b97e4c34cab64ce1fec1010","user":{"login":"paper-pauper","id":6094089,"avatar_url":"https://avatars.githubusercontent.com/u/6094089?v=3","gravatar_id":"","url":"https://api.github.com/users/paper-pauper","html_url":"https://github.com/paper-pauper","followers_url":"https://api.github.com/users/paper-pauper/followers","following_url":"https://api.github.com/users/paper-pauper/following{/other_user}","gists_url":"https://api.github.com/users/paper-pauper/gists{/gist_id}","starred_url":"https://api.github.com/users/paper-pauper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paper-pauper/subscriptions","organizations_url":"https://api.github.com/users/paper-pauper/orgs","repos_url":"https://api.github.com/users/paper-pauper/repos","events_url":"https://api.github.com/users/paper-pauper/events{/privacy}","received_events_url":"https://api.github.com/users/paper-pauper/received_events","type":"User","site_admin":false},"body":"@akien-mga Did not read your comments above, I have implemented the change you suggested.","created_at":"2016-09-01T13:14:17Z","updated_at":"2016-09-01T13:14:17Z","html_url":"https://github.com/godotengine/collada-exporter/pull/30#discussion_r77170567","pull_request_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments/77170567"},"html":{"href":"https://github.com/godotengine/collada-exporter/pull/30#discussion_r77170567"},"pull_request":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30","id":83624802,"html_url":"https://github.com/godotengine/collada-exporter/pull/30","diff_url":"https://github.com/godotengine/collada-exporter/pull/30.diff","patch_url":"https://github.com/godotengine/collada-exporter/pull/30.patch","issue_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/30","number":30,"state":"open","locked":false,"title":"Comment cleanup","user":{"login":"paper-pauper","id":6094089,"avatar_url":"https://avatars.githubusercontent.com/u/6094089?v=3","gravatar_id":"","url":"https://api.github.com/users/paper-pauper","html_url":"https://github.com/paper-pauper","followers_url":"https://api.github.com/users/paper-pauper/followers","following_url":"https://api.github.com/users/paper-pauper/following{/other_user}","gists_url":"https://api.github.com/users/paper-pauper/gists{/gist_id}","starred_url":"https://api.github.com/users/paper-pauper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paper-pauper/subscriptions","organizations_url":"https://api.github.com/users/paper-pauper/orgs","repos_url":"https://api.github.com/users/paper-pauper/repos","events_url":"https://api.github.com/users/paper-pauper/events{/privacy}","received_events_url":"https://api.github.com/users/paper-pauper/received_events","type":"User","site_admin":false},"body":"Fixes #8 for good :facepunch: (the emoticon says facepunch but it should be fistbump)\r\n\r\nI removed all redundant comments (commenting a single line whose purpose is self-evident isn't very helpful), left all comments which help organize or explain larger chunks of code and refactored all puzzled remarks to `TODO` statements so that they are easy to find (and eventually fix).\r\n\r\nIn particular, those lines which require a review (by the Blender devs, hopefully) are marked as `TODO: Review`.","created_at":"2016-09-01T12:40:52Z","updated_at":"2016-09-01T13:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8b3510d79723d837525154a8c4db9d06492c5fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30/commits","review_comments_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30/comments","review_comment_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/30/comments","statuses_url":"https://api.github.com/repos/godotengine/collada-exporter/statuses/24366bc353dcaa472ee80cf764b9a0598b073dcf","head":{"label":"paper-pauper:comment-cleanup","ref":"comment-cleanup","sha":"24366bc353dcaa472ee80cf764b9a0598b073dcf","user":{"login":"paper-pauper","id":6094089,"avatar_url":"https://avatars.githubusercontent.com/u/6094089?v=3","gravatar_id":"","url":"https://api.github.com/users/paper-pauper","html_url":"https://github.com/paper-pauper","followers_url":"https://api.github.com/users/paper-pauper/followers","following_url":"https://api.github.com/users/paper-pauper/following{/other_user}","gists_url":"https://api.github.com/users/paper-pauper/gists{/gist_id}","starred_url":"https://api.github.com/users/paper-pauper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paper-pauper/subscriptions","organizations_url":"https://api.github.com/users/paper-pauper/orgs","repos_url":"https://api.github.com/users/paper-pauper/repos","events_url":"https://api.github.com/users/paper-pauper/events{/privacy}","received_events_url":"https://api.github.com/users/paper-pauper/received_events","type":"User","site_admin":false},"repo":{"id":67127754,"name":"collada-exporter","full_name":"paper-pauper/collada-exporter","owner":{"login":"paper-pauper","id":6094089,"avatar_url":"https://avatars.githubusercontent.com/u/6094089?v=3","gravatar_id":"","url":"https://api.github.com/users/paper-pauper","html_url":"https://github.com/paper-pauper","followers_url":"https://api.github.com/users/paper-pauper/followers","following_url":"https://api.github.com/users/paper-pauper/following{/other_user}","gists_url":"https://api.github.com/users/paper-pauper/gists{/gist_id}","starred_url":"https://api.github.com/users/paper-pauper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paper-pauper/subscriptions","organizations_url":"https://api.github.com/users/paper-pauper/orgs","repos_url":"https://api.github.com/users/paper-pauper/repos","events_url":"https://api.github.com/users/paper-pauper/events{/privacy}","received_events_url":"https://api.github.com/users/paper-pauper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paper-pauper/collada-exporter","description":"\"Better\" Collada exporter for Blender, orignally developed by the Godot Engine community","fork":true,"url":"https://api.github.com/repos/paper-pauper/collada-exporter","forks_url":"https://api.github.com/repos/paper-pauper/collada-exporter/forks","keys_url":"https://api.github.com/repos/paper-pauper/collada-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paper-pauper/collada-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paper-pauper/collada-exporter/teams","hooks_url":"https://api.github.com/repos/paper-pauper/collada-exporter/hooks","issue_events_url":"https://api.github.com/repos/paper-pauper/collada-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/paper-pauper/collada-exporter/events","assignees_url":"https://api.github.com/repos/paper-pauper/collada-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/paper-pauper/collada-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/paper-pauper/collada-exporter/tags","blobs_url":"https://api.github.com/repos/paper-pauper/collada-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paper-pauper/collada-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paper-pauper/collada-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/paper-pauper/collada-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paper-pauper/collada-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/paper-pauper/collada-exporter/languages","stargazers_url":"https://api.github.com/repos/paper-pauper/collada-exporter/stargazers","contributors_url":"https://api.github.com/repos/paper-pauper/collada-exporter/contributors","subscribers_url":"https://api.github.com/repos/paper-pauper/collada-exporter/subscribers","subscription_url":"https://api.github.com/repos/paper-pauper/collada-exporter/subscription","commits_url":"https://api.github.com/repos/paper-pauper/collada-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/paper-pauper/collada-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/paper-pauper/collada-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/paper-pauper/collada-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/paper-pauper/collada-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/paper-pauper/collada-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paper-pauper/collada-exporter/merges","archive_url":"https://api.github.com/repos/paper-pauper/collada-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paper-pauper/collada-exporter/downloads","issues_url":"https://api.github.com/repos/paper-pauper/collada-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/paper-pauper/collada-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/paper-pauper/collada-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/paper-pauper/collada-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paper-pauper/collada-exporter/labels{/name}","releases_url":"https://api.github.com/repos/paper-pauper/collada-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/paper-pauper/collada-exporter/deployments","created_at":"2016-09-01T12:06:42Z","updated_at":"2016-09-01T12:06:43Z","pushed_at":"2016-09-01T13:14:14Z","git_url":"git://github.com/paper-pauper/collada-exporter.git","ssh_url":"git@github.com:paper-pauper/collada-exporter.git","clone_url":"https://github.com/paper-pauper/collada-exporter.git","svn_url":"https://github.com/paper-pauper/collada-exporter","homepage":"https://godotengine.org","size":229,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"aeb2947b2b38d54f4f35f0a4d60634044146fbcd","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":63009565,"name":"collada-exporter","full_name":"godotengine/collada-exporter","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/collada-exporter","description":"\"Better\" Collada exporter for Blender, orignally developed by the Godot Engine community","fork":false,"url":"https://api.github.com/repos/godotengine/collada-exporter","forks_url":"https://api.github.com/repos/godotengine/collada-exporter/forks","keys_url":"https://api.github.com/repos/godotengine/collada-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/collada-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/collada-exporter/teams","hooks_url":"https://api.github.com/repos/godotengine/collada-exporter/hooks","issue_events_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/collada-exporter/events","assignees_url":"https://api.github.com/repos/godotengine/collada-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/collada-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/collada-exporter/tags","blobs_url":"https://api.github.com/repos/godotengine/collada-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/collada-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/collada-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/collada-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/collada-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/collada-exporter/languages","stargazers_url":"https://api.github.com/repos/godotengine/collada-exporter/stargazers","contributors_url":"https://api.github.com/repos/godotengine/collada-exporter/contributors","subscribers_url":"https://api.github.com/repos/godotengine/collada-exporter/subscribers","subscription_url":"https://api.github.com/repos/godotengine/collada-exporter/subscription","commits_url":"https://api.github.com/repos/godotengine/collada-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/collada-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/collada-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/collada-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/collada-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/collada-exporter/merges","archive_url":"https://api.github.com/repos/godotengine/collada-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/collada-exporter/downloads","issues_url":"https://api.github.com/repos/godotengine/collada-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/collada-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/collada-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/collada-exporter/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/collada-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/collada-exporter/deployments","created_at":"2016-07-10T17:09:19Z","updated_at":"2016-07-18T08:32:02Z","pushed_at":"2016-09-01T13:14:15Z","git_url":"git://github.com/godotengine/collada-exporter.git","ssh_url":"git@github.com:godotengine/collada-exporter.git","clone_url":"https://github.com/godotengine/collada-exporter.git","svn_url":"https://github.com/godotengine/collada-exporter","homepage":"https://godotengine.org","size":229,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30"},"html":{"href":"https://github.com/godotengine/collada-exporter/pull/30"},"issue":{"href":"https://api.github.com/repos/godotengine/collada-exporter/issues/30"},"comments":{"href":"https://api.github.com/repos/godotengine/collada-exporter/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/collada-exporter/statuses/24366bc353dcaa472ee80cf764b9a0598b073dcf"}}}}
{"actor":{"display_login":"paper-pauper"}}