{"action":"created","comment":{"url":"https://api.github.com/repos/iExperience/ixjourney/pulls/comments/70440211","id":70440211,"diff_hunk":"@@ -8,22 +8,66 @@\n       @user = create(:user_as_basic_info)\n       authenticate_user @user\n     end\n-    \n+\n     describe \"PUT#update\" do\n       context \"all profile params valid\" do\n+        values = { phone: \"+1234567890\", home_city: \"Here\", current_city: \"There\", birthday: 19.years.ago, gender: \"Female\" }\n         it \"updates to valid model\" do\n           put :update, id: @user.id,\n-            user: {\n-              phone: \"+1234567890\",\n-              home_city: \"Here\",\n-              current_city: \"There\",\n-              birthday: 19.years.ago,\n-              gender: \"Male\",\n-            }\n+            user: values\n           expect(@user.as(user_scope)).to be_valid\n           expect(response).to redirect_to(root_path)\n         end\n       end\n+      \n+      context \"profile params invalid\" do\n+        generic_params = {\n+          phone: \"+1234567890\",\n+          home_city: \"Here\",\n+          current_city: \"There\",\n+          birthday: 19.years.ago,\n+          gender: \"Male\",\n+        }\n+\n+        params_hash = {\n+          \"no valid params\" => {\n+              phone: \"234567890\",","path":"spec/controllers/apply/profiles_controller_spec.rb","position":35,"original_position":35,"commit_id":"bcb0a4c373d2594477ba2fad340c4751b30db4f3","original_commit_id":"bcb0a4c373d2594477ba2fad340c4751b30db4f3","user":{"login":"JoshBroomberg","id":12767768,"avatar_url":"https://avatars.githubusercontent.com/u/12767768?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBroomberg","html_url":"https://github.com/JoshBroomberg","followers_url":"https://api.github.com/users/JoshBroomberg/followers","following_url":"https://api.github.com/users/JoshBroomberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshBroomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBroomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBroomberg/subscriptions","organizations_url":"https://api.github.com/users/JoshBroomberg/orgs","repos_url":"https://api.github.com/users/JoshBroomberg/repos","events_url":"https://api.github.com/users/JoshBroomberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBroomberg/received_events","type":"User","site_admin":false},"body":"I don't think we need this test. Can just test each individual field.","created_at":"2016-07-12T13:44:40Z","updated_at":"2016-07-12T13:44:40Z","html_url":"https://github.com/iExperience/ixjourney/pull/24#discussion_r70440211","pull_request_url":"https://api.github.com/repos/iExperience/ixjourney/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/comments/70440211"},"html":{"href":"https://github.com/iExperience/ixjourney/pull/24#discussion_r70440211"},"pull_request":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/iExperience/ixjourney/pulls/24","id":76857831,"html_url":"https://github.com/iExperience/ixjourney/pull/24","diff_url":"https://github.com/iExperience/ixjourney/pull/24.diff","patch_url":"https://github.com/iExperience/ixjourney/pull/24.patch","issue_url":"https://api.github.com/repos/iExperience/ixjourney/issues/24","number":24,"state":"open","locked":false,"title":"Apply: tests","user":{"login":"JoshBroomberg","id":12767768,"avatar_url":"https://avatars.githubusercontent.com/u/12767768?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBroomberg","html_url":"https://github.com/JoshBroomberg","followers_url":"https://api.github.com/users/JoshBroomberg/followers","following_url":"https://api.github.com/users/JoshBroomberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshBroomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBroomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBroomberg/subscriptions","organizations_url":"https://api.github.com/users/JoshBroomberg/orgs","repos_url":"https://api.github.com/users/JoshBroomberg/repos","events_url":"https://api.github.com/users/JoshBroomberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBroomberg/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-09T21:44:00Z","updated_at":"2016-07-12T13:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"110dd00562d7cafa0ec918a7bd4f17b0f7fcbfae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/iExperience/ixjourney/pulls/24/commits","review_comments_url":"https://api.github.com/repos/iExperience/ixjourney/pulls/24/comments","review_comment_url":"https://api.github.com/repos/iExperience/ixjourney/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iExperience/ixjourney/issues/24/comments","statuses_url":"https://api.github.com/repos/iExperience/ixjourney/statuses/bcb0a4c373d2594477ba2fad340c4751b30db4f3","head":{"label":"iExperience:apply-tests","ref":"apply-tests","sha":"bcb0a4c373d2594477ba2fad340c4751b30db4f3","user":{"login":"iExperience","id":7220596,"avatar_url":"https://avatars.githubusercontent.com/u/7220596?v=3","gravatar_id":"","url":"https://api.github.com/users/iExperience","html_url":"https://github.com/iExperience","followers_url":"https://api.github.com/users/iExperience/followers","following_url":"https://api.github.com/users/iExperience/following{/other_user}","gists_url":"https://api.github.com/users/iExperience/gists{/gist_id}","starred_url":"https://api.github.com/users/iExperience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExperience/subscriptions","organizations_url":"https://api.github.com/users/iExperience/orgs","repos_url":"https://api.github.com/users/iExperience/repos","events_url":"https://api.github.com/users/iExperience/events{/privacy}","received_events_url":"https://api.github.com/users/iExperience/received_events","type":"Organization","site_admin":false},"repo":{"id":61960222,"name":"ixjourney","full_name":"iExperience/ixjourney","owner":{"login":"iExperience","id":7220596,"avatar_url":"https://avatars.githubusercontent.com/u/7220596?v=3","gravatar_id":"","url":"https://api.github.com/users/iExperience","html_url":"https://github.com/iExperience","followers_url":"https://api.github.com/users/iExperience/followers","following_url":"https://api.github.com/users/iExperience/following{/other_user}","gists_url":"https://api.github.com/users/iExperience/gists{/gist_id}","starred_url":"https://api.github.com/users/iExperience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExperience/subscriptions","organizations_url":"https://api.github.com/users/iExperience/orgs","repos_url":"https://api.github.com/users/iExperience/repos","events_url":"https://api.github.com/users/iExperience/events{/privacy}","received_events_url":"https://api.github.com/users/iExperience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iExperience/ixjourney","description":"Second generation of the students portal","fork":false,"url":"https://api.github.com/repos/iExperience/ixjourney","forks_url":"https://api.github.com/repos/iExperience/ixjourney/forks","keys_url":"https://api.github.com/repos/iExperience/ixjourney/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iExperience/ixjourney/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iExperience/ixjourney/teams","hooks_url":"https://api.github.com/repos/iExperience/ixjourney/hooks","issue_events_url":"https://api.github.com/repos/iExperience/ixjourney/issues/events{/number}","events_url":"https://api.github.com/repos/iExperience/ixjourney/events","assignees_url":"https://api.github.com/repos/iExperience/ixjourney/assignees{/user}","branches_url":"https://api.github.com/repos/iExperience/ixjourney/branches{/branch}","tags_url":"https://api.github.com/repos/iExperience/ixjourney/tags","blobs_url":"https://api.github.com/repos/iExperience/ixjourney/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iExperience/ixjourney/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iExperience/ixjourney/git/refs{/sha}","trees_url":"https://api.github.com/repos/iExperience/ixjourney/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iExperience/ixjourney/statuses/{sha}","languages_url":"https://api.github.com/repos/iExperience/ixjourney/languages","stargazers_url":"https://api.github.com/repos/iExperience/ixjourney/stargazers","contributors_url":"https://api.github.com/repos/iExperience/ixjourney/contributors","subscribers_url":"https://api.github.com/repos/iExperience/ixjourney/subscribers","subscription_url":"https://api.github.com/repos/iExperience/ixjourney/subscription","commits_url":"https://api.github.com/repos/iExperience/ixjourney/commits{/sha}","git_commits_url":"https://api.github.com/repos/iExperience/ixjourney/git/commits{/sha}","comments_url":"https://api.github.com/repos/iExperience/ixjourney/comments{/number}","issue_comment_url":"https://api.github.com/repos/iExperience/ixjourney/issues/comments{/number}","contents_url":"https://api.github.com/repos/iExperience/ixjourney/contents/{+path}","compare_url":"https://api.github.com/repos/iExperience/ixjourney/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iExperience/ixjourney/merges","archive_url":"https://api.github.com/repos/iExperience/ixjourney/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iExperience/ixjourney/downloads","issues_url":"https://api.github.com/repos/iExperience/ixjourney/issues{/number}","pulls_url":"https://api.github.com/repos/iExperience/ixjourney/pulls{/number}","milestones_url":"https://api.github.com/repos/iExperience/ixjourney/milestones{/number}","notifications_url":"https://api.github.com/repos/iExperience/ixjourney/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iExperience/ixjourney/labels{/name}","releases_url":"https://api.github.com/repos/iExperience/ixjourney/releases{/id}","deployments_url":"https://api.github.com/repos/iExperience/ixjourney/deployments","created_at":"2016-06-25T20:22:40Z","updated_at":"2016-07-05T10:05:19Z","pushed_at":"2016-07-11T17:23:17Z","git_url":"git://github.com/iExperience/ixjourney.git","ssh_url":"git@github.com:iExperience/ixjourney.git","clone_url":"https://github.com/iExperience/ixjourney.git","svn_url":"https://github.com/iExperience/ixjourney","homepage":null,"size":11178,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"iExperience:feature-apply","ref":"feature-apply","sha":"5149fe4f40f93382ae4c7cbb1fbda2feb5b18d02","user":{"login":"iExperience","id":7220596,"avatar_url":"https://avatars.githubusercontent.com/u/7220596?v=3","gravatar_id":"","url":"https://api.github.com/users/iExperience","html_url":"https://github.com/iExperience","followers_url":"https://api.github.com/users/iExperience/followers","following_url":"https://api.github.com/users/iExperience/following{/other_user}","gists_url":"https://api.github.com/users/iExperience/gists{/gist_id}","starred_url":"https://api.github.com/users/iExperience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExperience/subscriptions","organizations_url":"https://api.github.com/users/iExperience/orgs","repos_url":"https://api.github.com/users/iExperience/repos","events_url":"https://api.github.com/users/iExperience/events{/privacy}","received_events_url":"https://api.github.com/users/iExperience/received_events","type":"Organization","site_admin":false},"repo":{"id":61960222,"name":"ixjourney","full_name":"iExperience/ixjourney","owner":{"login":"iExperience","id":7220596,"avatar_url":"https://avatars.githubusercontent.com/u/7220596?v=3","gravatar_id":"","url":"https://api.github.com/users/iExperience","html_url":"https://github.com/iExperience","followers_url":"https://api.github.com/users/iExperience/followers","following_url":"https://api.github.com/users/iExperience/following{/other_user}","gists_url":"https://api.github.com/users/iExperience/gists{/gist_id}","starred_url":"https://api.github.com/users/iExperience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExperience/subscriptions","organizations_url":"https://api.github.com/users/iExperience/orgs","repos_url":"https://api.github.com/users/iExperience/repos","events_url":"https://api.github.com/users/iExperience/events{/privacy}","received_events_url":"https://api.github.com/users/iExperience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iExperience/ixjourney","description":"Second generation of the students portal","fork":false,"url":"https://api.github.com/repos/iExperience/ixjourney","forks_url":"https://api.github.com/repos/iExperience/ixjourney/forks","keys_url":"https://api.github.com/repos/iExperience/ixjourney/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iExperience/ixjourney/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iExperience/ixjourney/teams","hooks_url":"https://api.github.com/repos/iExperience/ixjourney/hooks","issue_events_url":"https://api.github.com/repos/iExperience/ixjourney/issues/events{/number}","events_url":"https://api.github.com/repos/iExperience/ixjourney/events","assignees_url":"https://api.github.com/repos/iExperience/ixjourney/assignees{/user}","branches_url":"https://api.github.com/repos/iExperience/ixjourney/branches{/branch}","tags_url":"https://api.github.com/repos/iExperience/ixjourney/tags","blobs_url":"https://api.github.com/repos/iExperience/ixjourney/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iExperience/ixjourney/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iExperience/ixjourney/git/refs{/sha}","trees_url":"https://api.github.com/repos/iExperience/ixjourney/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iExperience/ixjourney/statuses/{sha}","languages_url":"https://api.github.com/repos/iExperience/ixjourney/languages","stargazers_url":"https://api.github.com/repos/iExperience/ixjourney/stargazers","contributors_url":"https://api.github.com/repos/iExperience/ixjourney/contributors","subscribers_url":"https://api.github.com/repos/iExperience/ixjourney/subscribers","subscription_url":"https://api.github.com/repos/iExperience/ixjourney/subscription","commits_url":"https://api.github.com/repos/iExperience/ixjourney/commits{/sha}","git_commits_url":"https://api.github.com/repos/iExperience/ixjourney/git/commits{/sha}","comments_url":"https://api.github.com/repos/iExperience/ixjourney/comments{/number}","issue_comment_url":"https://api.github.com/repos/iExperience/ixjourney/issues/comments{/number}","contents_url":"https://api.github.com/repos/iExperience/ixjourney/contents/{+path}","compare_url":"https://api.github.com/repos/iExperience/ixjourney/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iExperience/ixjourney/merges","archive_url":"https://api.github.com/repos/iExperience/ixjourney/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iExperience/ixjourney/downloads","issues_url":"https://api.github.com/repos/iExperience/ixjourney/issues{/number}","pulls_url":"https://api.github.com/repos/iExperience/ixjourney/pulls{/number}","milestones_url":"https://api.github.com/repos/iExperience/ixjourney/milestones{/number}","notifications_url":"https://api.github.com/repos/iExperience/ixjourney/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iExperience/ixjourney/labels{/name}","releases_url":"https://api.github.com/repos/iExperience/ixjourney/releases{/id}","deployments_url":"https://api.github.com/repos/iExperience/ixjourney/deployments","created_at":"2016-06-25T20:22:40Z","updated_at":"2016-07-05T10:05:19Z","pushed_at":"2016-07-11T17:23:17Z","git_url":"git://github.com/iExperience/ixjourney.git","ssh_url":"git@github.com:iExperience/ixjourney.git","clone_url":"https://github.com/iExperience/ixjourney.git","svn_url":"https://github.com/iExperience/ixjourney","homepage":null,"size":11178,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/24"},"html":{"href":"https://github.com/iExperience/ixjourney/pull/24"},"issue":{"href":"https://api.github.com/repos/iExperience/ixjourney/issues/24"},"comments":{"href":"https://api.github.com/repos/iExperience/ixjourney/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iExperience/ixjourney/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/iExperience/ixjourney/statuses/bcb0a4c373d2594477ba2fad340c4751b30db4f3"}}}}
{"actor":{"display_login":"JoshBroomberg"}}