{"action":"created","comment":{"url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/comments/77699142","id":77699142,"diff_hunk":"@@ -19,10 +19,6 @@ var noExportProperties = [\n     'treeColumnPropertiesColumnSelection',\n ];\n \n-var isNull = {\n-    isNull: true\n-};","path":"src/behaviors/Behavior.js","position":6,"original_position":6,"commit_id":"e10d90656df56868c0fcbeeae72ec9f5fd17fb4a","original_commit_id":"66530871a03d09f9c51c2550a4c180de5dee9422","user":{"login":"Dwaynekj","id":1011448,"avatar_url":"https://avatars.githubusercontent.com/u/1011448?v=3","gravatar_id":"","url":"https://api.github.com/users/Dwaynekj","html_url":"https://github.com/Dwaynekj","followers_url":"https://api.github.com/users/Dwaynekj/followers","following_url":"https://api.github.com/users/Dwaynekj/following{/other_user}","gists_url":"https://api.github.com/users/Dwaynekj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dwaynekj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dwaynekj/subscriptions","organizations_url":"https://api.github.com/users/Dwaynekj/orgs","repos_url":"https://api.github.com/users/Dwaynekj/repos","events_url":"https://api.github.com/users/Dwaynekj/events{/privacy}","received_events_url":"https://api.github.com/users/Dwaynekj/received_events","type":"User","site_admin":false},"body":"Ok","created_at":"2016-09-06T19:08:56Z","updated_at":"2016-09-06T19:08:56Z","html_url":"https://github.com/openfin/fin-hypergrid/pull/317#discussion_r77699142","pull_request_url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/comments/77699142"},"html":{"href":"https://github.com/openfin/fin-hypergrid/pull/317#discussion_r77699142"},"pull_request":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317","id":83905718,"html_url":"https://github.com/openfin/fin-hypergrid/pull/317","diff_url":"https://github.com/openfin/fin-hypergrid/pull/317.diff","patch_url":"https://github.com/openfin/fin-hypergrid/pull/317.patch","issue_url":"https://api.github.com/repos/openfin/fin-hypergrid/issues/317","number":317,"state":"open","locked":false,"title":"cell props obj now created from column props obj","user":{"login":"joneit","id":5996304,"avatar_url":"https://avatars.githubusercontent.com/u/5996304?v=3","gravatar_id":"","url":"https://api.github.com/users/joneit","html_url":"https://github.com/joneit","followers_url":"https://api.github.com/users/joneit/followers","following_url":"https://api.github.com/users/joneit/following{/other_user}","gists_url":"https://api.github.com/users/joneit/gists{/gist_id}","starred_url":"https://api.github.com/users/joneit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneit/subscriptions","organizations_url":"https://api.github.com/users/joneit/orgs","repos_url":"https://api.github.com/users/joneit/repos","events_url":"https://api.github.com/users/joneit/events{/privacy}","received_events_url":"https://api.github.com/users/joneit/received_events","type":"User","site_admin":false},"body":"Polishes off the way we build and handle the cell properties object, bringing it into line with the way the other properties objects work:\r\n\r\n* The cell properties object is now `Object.create`'d from the column properties objects. This is in keeping with the way the column properties object is created from the grid properties object. Up to now, this cascade had to be done explicitly inline wherever it was needed.\r\n* With this new paradigm, the renderer no longer needs to mix in the cell properties object as a final step after calling `getCell` but before calling the cell renderer's `paint` method. (However, added a new render property `reapplyCellProperties` to get the old behavior, where cell properties override `getCell` settings.)\r\n* Cell properties objects no longer restricted to data cells and can now be used for header cells.\r\n* Isolated all cell properties code into a separate (new) file, behavior/Cell.js. (This is actually just mixed into Columns.prototype by Columns.js, but separating it out should make writing tests for it much cleaner and simpler.)\r\n* This solution does maintain, for efficiency reasons, the paradigm of _avoiding_ creating a cell properties object for every cell (unlike the column properties objects, which are guaranteed to exist for every column). They are creating only when actually needed.\r\n","created_at":"2016-09-03T20:50:36Z","updated_at":"2016-09-06T19:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75bcae769fe0b264428694ffa64d149dd0b48da2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317/commits","review_comments_url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317/comments","review_comment_url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfin/fin-hypergrid/issues/317/comments","statuses_url":"https://api.github.com/repos/openfin/fin-hypergrid/statuses/e10d90656df56868c0fcbeeae72ec9f5fd17fb4a","head":{"label":"joneit:fix-cell-properties-methods","ref":"fix-cell-properties-methods","sha":"e10d90656df56868c0fcbeeae72ec9f5fd17fb4a","user":{"login":"joneit","id":5996304,"avatar_url":"https://avatars.githubusercontent.com/u/5996304?v=3","gravatar_id":"","url":"https://api.github.com/users/joneit","html_url":"https://github.com/joneit","followers_url":"https://api.github.com/users/joneit/followers","following_url":"https://api.github.com/users/joneit/following{/other_user}","gists_url":"https://api.github.com/users/joneit/gists{/gist_id}","starred_url":"https://api.github.com/users/joneit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneit/subscriptions","organizations_url":"https://api.github.com/users/joneit/orgs","repos_url":"https://api.github.com/users/joneit/repos","events_url":"https://api.github.com/users/joneit/events{/privacy}","received_events_url":"https://api.github.com/users/joneit/received_events","type":"User","site_admin":false},"repo":{"id":58580690,"name":"fin-hypergrid","full_name":"joneit/fin-hypergrid","owner":{"login":"joneit","id":5996304,"avatar_url":"https://avatars.githubusercontent.com/u/5996304?v=3","gravatar_id":"","url":"https://api.github.com/users/joneit","html_url":"https://github.com/joneit","followers_url":"https://api.github.com/users/joneit/followers","following_url":"https://api.github.com/users/joneit/following{/other_user}","gists_url":"https://api.github.com/users/joneit/gists{/gist_id}","starred_url":"https://api.github.com/users/joneit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneit/subscriptions","organizations_url":"https://api.github.com/users/joneit/orgs","repos_url":"https://api.github.com/users/joneit/repos","events_url":"https://api.github.com/users/joneit/events{/privacy}","received_events_url":"https://api.github.com/users/joneit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joneit/fin-hypergrid","description":"a canvas-based super high performant grid control","fork":true,"url":"https://api.github.com/repos/joneit/fin-hypergrid","forks_url":"https://api.github.com/repos/joneit/fin-hypergrid/forks","keys_url":"https://api.github.com/repos/joneit/fin-hypergrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joneit/fin-hypergrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joneit/fin-hypergrid/teams","hooks_url":"https://api.github.com/repos/joneit/fin-hypergrid/hooks","issue_events_url":"https://api.github.com/repos/joneit/fin-hypergrid/issues/events{/number}","events_url":"https://api.github.com/repos/joneit/fin-hypergrid/events","assignees_url":"https://api.github.com/repos/joneit/fin-hypergrid/assignees{/user}","branches_url":"https://api.github.com/repos/joneit/fin-hypergrid/branches{/branch}","tags_url":"https://api.github.com/repos/joneit/fin-hypergrid/tags","blobs_url":"https://api.github.com/repos/joneit/fin-hypergrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joneit/fin-hypergrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joneit/fin-hypergrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/joneit/fin-hypergrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joneit/fin-hypergrid/statuses/{sha}","languages_url":"https://api.github.com/repos/joneit/fin-hypergrid/languages","stargazers_url":"https://api.github.com/repos/joneit/fin-hypergrid/stargazers","contributors_url":"https://api.github.com/repos/joneit/fin-hypergrid/contributors","subscribers_url":"https://api.github.com/repos/joneit/fin-hypergrid/subscribers","subscription_url":"https://api.github.com/repos/joneit/fin-hypergrid/subscription","commits_url":"https://api.github.com/repos/joneit/fin-hypergrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/joneit/fin-hypergrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/joneit/fin-hypergrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/joneit/fin-hypergrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/joneit/fin-hypergrid/contents/{+path}","compare_url":"https://api.github.com/repos/joneit/fin-hypergrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joneit/fin-hypergrid/merges","archive_url":"https://api.github.com/repos/joneit/fin-hypergrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joneit/fin-hypergrid/downloads","issues_url":"https://api.github.com/repos/joneit/fin-hypergrid/issues{/number}","pulls_url":"https://api.github.com/repos/joneit/fin-hypergrid/pulls{/number}","milestones_url":"https://api.github.com/repos/joneit/fin-hypergrid/milestones{/number}","notifications_url":"https://api.github.com/repos/joneit/fin-hypergrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joneit/fin-hypergrid/labels{/name}","releases_url":"https://api.github.com/repos/joneit/fin-hypergrid/releases{/id}","deployments_url":"https://api.github.com/repos/joneit/fin-hypergrid/deployments","created_at":"2016-05-11T20:56:08Z","updated_at":"2016-05-11T20:56:09Z","pushed_at":"2016-09-06T15:34:29Z","git_url":"git://github.com/joneit/fin-hypergrid.git","ssh_url":"git@github.com:joneit/fin-hypergrid.git","clone_url":"https://github.com/joneit/fin-hypergrid.git","svn_url":"https://github.com/joneit/fin-hypergrid","homepage":"","size":103966,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfin:develop","ref":"develop","sha":"4f794a93b955a79c052c2e4267968ac3e55c1ef5","user":{"login":"openfin","id":1569661,"avatar_url":"https://avatars.githubusercontent.com/u/1569661?v=3","gravatar_id":"","url":"https://api.github.com/users/openfin","html_url":"https://github.com/openfin","followers_url":"https://api.github.com/users/openfin/followers","following_url":"https://api.github.com/users/openfin/following{/other_user}","gists_url":"https://api.github.com/users/openfin/gists{/gist_id}","starred_url":"https://api.github.com/users/openfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfin/subscriptions","organizations_url":"https://api.github.com/users/openfin/orgs","repos_url":"https://api.github.com/users/openfin/repos","events_url":"https://api.github.com/users/openfin/events{/privacy}","received_events_url":"https://api.github.com/users/openfin/received_events","type":"Organization","site_admin":false},"repo":{"id":26558202,"name":"fin-hypergrid","full_name":"openfin/fin-hypergrid","owner":{"login":"openfin","id":1569661,"avatar_url":"https://avatars.githubusercontent.com/u/1569661?v=3","gravatar_id":"","url":"https://api.github.com/users/openfin","html_url":"https://github.com/openfin","followers_url":"https://api.github.com/users/openfin/followers","following_url":"https://api.github.com/users/openfin/following{/other_user}","gists_url":"https://api.github.com/users/openfin/gists{/gist_id}","starred_url":"https://api.github.com/users/openfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfin/subscriptions","organizations_url":"https://api.github.com/users/openfin/orgs","repos_url":"https://api.github.com/users/openfin/repos","events_url":"https://api.github.com/users/openfin/events{/privacy}","received_events_url":"https://api.github.com/users/openfin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openfin/fin-hypergrid","description":"a canvas-based super high performant grid control","fork":false,"url":"https://api.github.com/repos/openfin/fin-hypergrid","forks_url":"https://api.github.com/repos/openfin/fin-hypergrid/forks","keys_url":"https://api.github.com/repos/openfin/fin-hypergrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfin/fin-hypergrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfin/fin-hypergrid/teams","hooks_url":"https://api.github.com/repos/openfin/fin-hypergrid/hooks","issue_events_url":"https://api.github.com/repos/openfin/fin-hypergrid/issues/events{/number}","events_url":"https://api.github.com/repos/openfin/fin-hypergrid/events","assignees_url":"https://api.github.com/repos/openfin/fin-hypergrid/assignees{/user}","branches_url":"https://api.github.com/repos/openfin/fin-hypergrid/branches{/branch}","tags_url":"https://api.github.com/repos/openfin/fin-hypergrid/tags","blobs_url":"https://api.github.com/repos/openfin/fin-hypergrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfin/fin-hypergrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfin/fin-hypergrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfin/fin-hypergrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfin/fin-hypergrid/statuses/{sha}","languages_url":"https://api.github.com/repos/openfin/fin-hypergrid/languages","stargazers_url":"https://api.github.com/repos/openfin/fin-hypergrid/stargazers","contributors_url":"https://api.github.com/repos/openfin/fin-hypergrid/contributors","subscribers_url":"https://api.github.com/repos/openfin/fin-hypergrid/subscribers","subscription_url":"https://api.github.com/repos/openfin/fin-hypergrid/subscription","commits_url":"https://api.github.com/repos/openfin/fin-hypergrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfin/fin-hypergrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfin/fin-hypergrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfin/fin-hypergrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfin/fin-hypergrid/contents/{+path}","compare_url":"https://api.github.com/repos/openfin/fin-hypergrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfin/fin-hypergrid/merges","archive_url":"https://api.github.com/repos/openfin/fin-hypergrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfin/fin-hypergrid/downloads","issues_url":"https://api.github.com/repos/openfin/fin-hypergrid/issues{/number}","pulls_url":"https://api.github.com/repos/openfin/fin-hypergrid/pulls{/number}","milestones_url":"https://api.github.com/repos/openfin/fin-hypergrid/milestones{/number}","notifications_url":"https://api.github.com/repos/openfin/fin-hypergrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfin/fin-hypergrid/labels{/name}","releases_url":"https://api.github.com/repos/openfin/fin-hypergrid/releases{/id}","deployments_url":"https://api.github.com/repos/openfin/fin-hypergrid/deployments","created_at":"2014-11-12T21:59:13Z","updated_at":"2016-09-03T17:00:16Z","pushed_at":"2016-09-06T15:34:30Z","git_url":"git://github.com/openfin/fin-hypergrid.git","ssh_url":"git@github.com:openfin/fin-hypergrid.git","clone_url":"https://github.com/openfin/fin-hypergrid.git","svn_url":"https://github.com/openfin/fin-hypergrid","homepage":"","size":109185,"stargazers_count":289,"watchers_count":289,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":14,"forks":74,"open_issues":14,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317"},"html":{"href":"https://github.com/openfin/fin-hypergrid/pull/317"},"issue":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/issues/317"},"comments":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/openfin/fin-hypergrid/statuses/e10d90656df56868c0fcbeeae72ec9f5fd17fb4a"}}}}
{"actor":{"display_login":"Dwaynekj"}}