{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4760","repository_url":"https://api.github.com/repos/Leaflet/Leaflet","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4760/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4760/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4760/events","html_url":"https://github.com/Leaflet/Leaflet/issues/4760","id":168131766,"number":4760,"title":"New Tooltip feature in v.1.0rc2 breaks compatibility with Leaflet.draw plugin","user":{"login":"daverayment","id":7127766,"avatar_url":"https://avatars.githubusercontent.com/u/7127766?v=3","gravatar_id":"","url":"https://api.github.com/users/daverayment","html_url":"https://github.com/daverayment","followers_url":"https://api.github.com/users/daverayment/followers","following_url":"https://api.github.com/users/daverayment/following{/other_user}","gists_url":"https://api.github.com/users/daverayment/gists{/gist_id}","starred_url":"https://api.github.com/users/daverayment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daverayment/subscriptions","organizations_url":"https://api.github.com/users/daverayment/orgs","repos_url":"https://api.github.com/users/daverayment/repos","events_url":"https://api.github.com/users/daverayment/events{/privacy}","received_events_url":"https://api.github.com/users/daverayment/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-28T15:55:29Z","updated_at":"2016-07-30T16:47:15Z","closed_at":null,"body":"The popular Leaflet.draw plugin already uses an L.Tooltip class. Unfortunately, Leaflet v1.0rc2 also uses a separate Tooltip class for the new label functionality; this causes errors when adding one to the map when the draw plugin is also in use.\r\n\r\nExample:\r\n\r\nhttps://jsfiddle.net/o6odc298/1/\r\n\r\n(Please note that I've had to copy in the Leaflet.draw code into the main script area, as there's no distribution for this version yet. The code that sets up the map, adds the marker and binds the label/tooltip is at the bottom. Remove the plugin code to see that the new tooltip code works without it.)\r\n\r\nThe plugin team's latest code is here, with the aim for this to be compatible with Leaflet v1:\r\n\r\nhttps://github.com/Leaflet/Leaflet.draw/tree/leaflet-master\r\n\r\nTheir Tooltip code is here:\r\n\r\nhttps://github.com/Leaflet/Leaflet.draw/blob/leaflet-master/src/Tooltip.js\r\n\r\nIf the external Label plugin is now deprecated and the included replacement Tooltip API is similar to that, would it be an option to rename it to Label, too? This would have the added advantage of reducing the number of changes required when updating old applications to v1.\r\n\r\nAn alternative would be to get the Leaflet.draw authors to change the name of their Tooltip class. This is what I've done for my own project, but this may break other applications which have extended the plugin code."},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments/236375701","html_url":"https://github.com/Leaflet/Leaflet/issues/4760#issuecomment-236375701","issue_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4760","id":236375701,"user":{"login":"ddproxy","id":105473,"avatar_url":"https://avatars.githubusercontent.com/u/105473?v=3","gravatar_id":"","url":"https://api.github.com/users/ddproxy","html_url":"https://github.com/ddproxy","followers_url":"https://api.github.com/users/ddproxy/followers","following_url":"https://api.github.com/users/ddproxy/following{/other_user}","gists_url":"https://api.github.com/users/ddproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/ddproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddproxy/subscriptions","organizations_url":"https://api.github.com/users/ddproxy/orgs","repos_url":"https://api.github.com/users/ddproxy/repos","events_url":"https://api.github.com/users/ddproxy/events{/privacy}","received_events_url":"https://api.github.com/users/ddproxy/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T16:47:15Z","updated_at":"2016-07-30T16:47:15Z","body":"I'm in support, I'm on Gitter today (off and on) - actually had a few questions and I'd be ready to start that process."}}
{"actor":{"display_login":"ddproxy"}}