{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/75353409","id":75353409,"diff_hunk":"@@ -72,6 +72,11 @@ createPrimaryPlot <- function(data, month){\n         plot_object <- extendYaxisLimits(plot_object, primaryStyles[[err]])\n       }\n       \n+      which_rect <- grep('rect', names(primaryStyles))","path":"R/uvhydrograph-render.R","position":4,"original_position":4,"commit_id":"850acb270038d38cc95e599c7385c878abb1111c","original_commit_id":"850acb270038d38cc95e599c7385c878abb1111c","user":{"login":"lindsaycarr","id":13220910,"avatar_url":"https://avatars.githubusercontent.com/u/13220910?v=3","gravatar_id":"","url":"https://api.github.com/users/lindsaycarr","html_url":"https://github.com/lindsaycarr","followers_url":"https://api.github.com/users/lindsaycarr/followers","following_url":"https://api.github.com/users/lindsaycarr/following{/other_user}","gists_url":"https://api.github.com/users/lindsaycarr/gists{/gist_id}","starred_url":"https://api.github.com/users/lindsaycarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindsaycarr/subscriptions","organizations_url":"https://api.github.com/users/lindsaycarr/orgs","repos_url":"https://api.github.com/users/lindsaycarr/repos","events_url":"https://api.github.com/users/lindsaycarr/events{/privacy}","received_events_url":"https://api.github.com/users/lindsaycarr/received_events","type":"User","site_admin":false},"body":"if the implementation of addHeight I commented above works then this and the for loop after it can be deleted","created_at":"2016-08-18T17:39:57Z","updated_at":"2016-08-18T17:39:57Z","html_url":"https://github.com/USGS-R/repgen/pull/388#discussion_r75353409","pull_request_url":"https://api.github.com/repos/USGS-R/repgen/pulls/388","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/75353409"},"html":{"href":"https://github.com/USGS-R/repgen/pull/388#discussion_r75353409"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/388","id":81549988,"html_url":"https://github.com/USGS-R/repgen/pull/388","diff_url":"https://github.com/USGS-R/repgen/pull/388.diff","patch_url":"https://github.com/USGS-R/repgen/pull/388.patch","issue_url":"https://api.github.com/repos/USGS-R/repgen/issues/388","number":388,"state":"open","locked":false,"title":"WIP for AQCU-775","user":{"login":"mhines-usgs","id":6920344,"avatar_url":"https://avatars.githubusercontent.com/u/6920344?v=3","gravatar_id":"","url":"https://api.github.com/users/mhines-usgs","html_url":"https://github.com/mhines-usgs","followers_url":"https://api.github.com/users/mhines-usgs/followers","following_url":"https://api.github.com/users/mhines-usgs/following{/other_user}","gists_url":"https://api.github.com/users/mhines-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/mhines-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhines-usgs/subscriptions","organizations_url":"https://api.github.com/users/mhines-usgs/orgs","repos_url":"https://api.github.com/users/mhines-usgs/repos","events_url":"https://api.github.com/users/mhines-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/mhines-usgs/received_events","type":"User","site_admin":false},"body":"@lindsaycarr I feel like this is kind of right, but I haven't been able to get it to show up on the plot. \r\n\r\nI essentially branched the getApprovals function into two chunks, should the approvals show at the bottom? If not - it's daily values, so do the regular plot of daily points like before. \r\n\r\nIf it is at the bottom, I branched that to make sure we get the date with times (note in the code about that) and then created a rectangle with that information, using your suggestion in the ticket for what it needs. However, I'm not seeing it show up. Can you take a look and suggest what's missing or wrong? Thanks!   ","created_at":"2016-08-16T21:42:23Z","updated_at":"2016-08-18T17:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454cee27c975b3c8023e14d6e851ece3cff911b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/repgen/pulls/388/commits","review_comments_url":"https://api.github.com/repos/USGS-R/repgen/pulls/388/comments","review_comment_url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/repgen/issues/388/comments","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/850acb270038d38cc95e599c7385c878abb1111c","head":{"label":"mhines-usgs:master","ref":"master","sha":"850acb270038d38cc95e599c7385c878abb1111c","user":{"login":"mhines-usgs","id":6920344,"avatar_url":"https://avatars.githubusercontent.com/u/6920344?v=3","gravatar_id":"","url":"https://api.github.com/users/mhines-usgs","html_url":"https://github.com/mhines-usgs","followers_url":"https://api.github.com/users/mhines-usgs/followers","following_url":"https://api.github.com/users/mhines-usgs/following{/other_user}","gists_url":"https://api.github.com/users/mhines-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/mhines-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhines-usgs/subscriptions","organizations_url":"https://api.github.com/users/mhines-usgs/orgs","repos_url":"https://api.github.com/users/mhines-usgs/repos","events_url":"https://api.github.com/users/mhines-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/mhines-usgs/received_events","type":"User","site_admin":false},"repo":{"id":62729012,"name":"repgen","full_name":"mhines-usgs/repgen","owner":{"login":"mhines-usgs","id":6920344,"avatar_url":"https://avatars.githubusercontent.com/u/6920344?v=3","gravatar_id":"","url":"https://api.github.com/users/mhines-usgs","html_url":"https://github.com/mhines-usgs","followers_url":"https://api.github.com/users/mhines-usgs/followers","following_url":"https://api.github.com/users/mhines-usgs/following{/other_user}","gists_url":"https://api.github.com/users/mhines-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/mhines-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhines-usgs/subscriptions","organizations_url":"https://api.github.com/users/mhines-usgs/orgs","repos_url":"https://api.github.com/users/mhines-usgs/repos","events_url":"https://api.github.com/users/mhines-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/mhines-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhines-usgs/repgen","description":"report generation in R","fork":true,"url":"https://api.github.com/repos/mhines-usgs/repgen","forks_url":"https://api.github.com/repos/mhines-usgs/repgen/forks","keys_url":"https://api.github.com/repos/mhines-usgs/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhines-usgs/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhines-usgs/repgen/teams","hooks_url":"https://api.github.com/repos/mhines-usgs/repgen/hooks","issue_events_url":"https://api.github.com/repos/mhines-usgs/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/mhines-usgs/repgen/events","assignees_url":"https://api.github.com/repos/mhines-usgs/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/mhines-usgs/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/mhines-usgs/repgen/tags","blobs_url":"https://api.github.com/repos/mhines-usgs/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhines-usgs/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhines-usgs/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhines-usgs/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhines-usgs/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/mhines-usgs/repgen/languages","stargazers_url":"https://api.github.com/repos/mhines-usgs/repgen/stargazers","contributors_url":"https://api.github.com/repos/mhines-usgs/repgen/contributors","subscribers_url":"https://api.github.com/repos/mhines-usgs/repgen/subscribers","subscription_url":"https://api.github.com/repos/mhines-usgs/repgen/subscription","commits_url":"https://api.github.com/repos/mhines-usgs/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhines-usgs/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhines-usgs/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhines-usgs/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhines-usgs/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/mhines-usgs/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhines-usgs/repgen/merges","archive_url":"https://api.github.com/repos/mhines-usgs/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhines-usgs/repgen/downloads","issues_url":"https://api.github.com/repos/mhines-usgs/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/mhines-usgs/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/mhines-usgs/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/mhines-usgs/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhines-usgs/repgen/labels{/name}","releases_url":"https://api.github.com/repos/mhines-usgs/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/mhines-usgs/repgen/deployments","created_at":"2016-07-06T14:49:49Z","updated_at":"2016-07-06T14:49:50Z","pushed_at":"2016-08-18T17:22:50Z","git_url":"git://github.com/mhines-usgs/repgen.git","ssh_url":"git@github.com:mhines-usgs/repgen.git","clone_url":"https://github.com/mhines-usgs/repgen.git","svn_url":"https://github.com/mhines-usgs/repgen","homepage":null,"size":10954,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:master","ref":"master","sha":"c5f8abe6c44db5b5cd4104186296c854c6110a44","user":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":31678130,"name":"repgen","full_name":"USGS-R/repgen","owner":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/repgen","description":"report generation in R","fork":false,"url":"https://api.github.com/repos/USGS-R/repgen","forks_url":"https://api.github.com/repos/USGS-R/repgen/forks","keys_url":"https://api.github.com/repos/USGS-R/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/repgen/teams","hooks_url":"https://api.github.com/repos/USGS-R/repgen/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/repgen/events","assignees_url":"https://api.github.com/repos/USGS-R/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/repgen/tags","blobs_url":"https://api.github.com/repos/USGS-R/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/repgen/languages","stargazers_url":"https://api.github.com/repos/USGS-R/repgen/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/repgen/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/repgen/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/repgen/subscription","commits_url":"https://api.github.com/repos/USGS-R/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/repgen/merges","archive_url":"https://api.github.com/repos/USGS-R/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/repgen/downloads","issues_url":"https://api.github.com/repos/USGS-R/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/repgen/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/repgen/deployments","created_at":"2015-03-04T20:24:02Z","updated_at":"2016-08-02T00:54:30Z","pushed_at":"2016-08-18T17:22:51Z","git_url":"git://github.com/USGS-R/repgen.git","ssh_url":"git@github.com:USGS-R/repgen.git","clone_url":"https://github.com/USGS-R/repgen.git","svn_url":"https://github.com/USGS-R/repgen","homepage":null,"size":10972,"stargazers_count":6,"watchers_count":6,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/388"},"html":{"href":"https://github.com/USGS-R/repgen/pull/388"},"issue":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/388"},"comments":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/repgen/statuses/850acb270038d38cc95e599c7385c878abb1111c"}}}}
{"actor":{"display_login":"lindsaycarr"}}