{"action":"created","comment":{"url":"https://api.github.com/repos/greymatter0101/gm/pulls/comments/73998881","id":73998881,"diff_hunk":"@@ -1,6 +1,6 @@\n // colors\n $midnight: #000000;","path":"imports/ui/stylesheets/variables.scss","position":null,"original_position":2,"commit_id":"474ed6885c04a4f91780fdd3c0523091556f80fb","original_commit_id":"a952031459a480a49b116d9bdb4eb91bfaba83ff","user":{"login":"sameckmeier","id":6589185,"avatar_url":"https://avatars.githubusercontent.com/u/6589185?v=3","gravatar_id":"","url":"https://api.github.com/users/sameckmeier","html_url":"https://github.com/sameckmeier","followers_url":"https://api.github.com/users/sameckmeier/followers","following_url":"https://api.github.com/users/sameckmeier/following{/other_user}","gists_url":"https://api.github.com/users/sameckmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/sameckmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameckmeier/subscriptions","organizations_url":"https://api.github.com/users/sameckmeier/orgs","repos_url":"https://api.github.com/users/sameckmeier/repos","events_url":"https://api.github.com/users/sameckmeier/events{/privacy}","received_events_url":"https://api.github.com/users/sameckmeier/received_events","type":"User","site_admin":false},"body":"im wondering if we want to have a more consistent naming scheme? what if we used crayola color names so that we could reference: https://en.wikipedia.org/wiki/List_of_Crayola_crayon_colors#Standard_colors\r\n\r\nthat idea came from http://coryetzkorn.com/blog/color-variables-in-sass/ \r\n\r\nim also intrigued by how this guy prefixes all color var names with 'color-'. i can see the benefit but it also seems a little redundant. \r\n\r\nlastly, what are your thoughts on setting functional variable names (eg $border-color) within stylesheets? the thought is that we'd have a colors.scss and then in Reviews.scss we set all of the colors that we use for that component at the top of the stylesheet. again, these are just thoughts, and i havent really decided if they'd be useful or just redundant and tedious.","created_at":"2016-08-09T05:12:26Z","updated_at":"2016-08-09T05:12:26Z","html_url":"https://github.com/greymatter0101/gm/pull/25#discussion_r73998881","pull_request_url":"https://api.github.com/repos/greymatter0101/gm/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/comments/73998881"},"html":{"href":"https://github.com/greymatter0101/gm/pull/25#discussion_r73998881"},"pull_request":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/greymatter0101/gm/pulls/25","id":79854153,"html_url":"https://github.com/greymatter0101/gm/pull/25","diff_url":"https://github.com/greymatter0101/gm/pull/25.diff","patch_url":"https://github.com/greymatter0101/gm/pull/25.patch","issue_url":"https://api.github.com/repos/greymatter0101/gm/issues/25","number":25,"state":"open","locked":false,"title":"ui components","user":{"login":"rosscreighton","id":5814182,"avatar_url":"https://avatars.githubusercontent.com/u/5814182?v=3","gravatar_id":"","url":"https://api.github.com/users/rosscreighton","html_url":"https://github.com/rosscreighton","followers_url":"https://api.github.com/users/rosscreighton/followers","following_url":"https://api.github.com/users/rosscreighton/following{/other_user}","gists_url":"https://api.github.com/users/rosscreighton/gists{/gist_id}","starred_url":"https://api.github.com/users/rosscreighton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosscreighton/subscriptions","organizations_url":"https://api.github.com/users/rosscreighton/orgs","repos_url":"https://api.github.com/users/rosscreighton/repos","events_url":"https://api.github.com/users/rosscreighton/events{/privacy}","received_events_url":"https://api.github.com/users/rosscreighton/received_events","type":"User","site_admin":false},"body":"keeping all my recent react work in this PR until we have a chance to talk. this also give you a chance to look at how the components work together before we merge them to maser.","created_at":"2016-08-03T06:27:57Z","updated_at":"2016-08-09T05:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4dee10af6d423e4fb3d29c451983d09af78fb86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greymatter0101/gm/pulls/25/commits","review_comments_url":"https://api.github.com/repos/greymatter0101/gm/pulls/25/comments","review_comment_url":"https://api.github.com/repos/greymatter0101/gm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greymatter0101/gm/issues/25/comments","statuses_url":"https://api.github.com/repos/greymatter0101/gm/statuses/474ed6885c04a4f91780fdd3c0523091556f80fb","head":{"label":"greymatter0101:ui-components","ref":"ui-components","sha":"474ed6885c04a4f91780fdd3c0523091556f80fb","user":{"login":"greymatter0101","id":18176938,"avatar_url":"https://avatars.githubusercontent.com/u/18176938?v=3","gravatar_id":"","url":"https://api.github.com/users/greymatter0101","html_url":"https://github.com/greymatter0101","followers_url":"https://api.github.com/users/greymatter0101/followers","following_url":"https://api.github.com/users/greymatter0101/following{/other_user}","gists_url":"https://api.github.com/users/greymatter0101/gists{/gist_id}","starred_url":"https://api.github.com/users/greymatter0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greymatter0101/subscriptions","organizations_url":"https://api.github.com/users/greymatter0101/orgs","repos_url":"https://api.github.com/users/greymatter0101/repos","events_url":"https://api.github.com/users/greymatter0101/events{/privacy}","received_events_url":"https://api.github.com/users/greymatter0101/received_events","type":"User","site_admin":false},"repo":{"id":55097955,"name":"gm","full_name":"greymatter0101/gm","owner":{"login":"greymatter0101","id":18176938,"avatar_url":"https://avatars.githubusercontent.com/u/18176938?v=3","gravatar_id":"","url":"https://api.github.com/users/greymatter0101","html_url":"https://github.com/greymatter0101","followers_url":"https://api.github.com/users/greymatter0101/followers","following_url":"https://api.github.com/users/greymatter0101/following{/other_user}","gists_url":"https://api.github.com/users/greymatter0101/gists{/gist_id}","starred_url":"https://api.github.com/users/greymatter0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greymatter0101/subscriptions","organizations_url":"https://api.github.com/users/greymatter0101/orgs","repos_url":"https://api.github.com/users/greymatter0101/repos","events_url":"https://api.github.com/users/greymatter0101/events{/privacy}","received_events_url":"https://api.github.com/users/greymatter0101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greymatter0101/gm","description":"","fork":false,"url":"https://api.github.com/repos/greymatter0101/gm","forks_url":"https://api.github.com/repos/greymatter0101/gm/forks","keys_url":"https://api.github.com/repos/greymatter0101/gm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greymatter0101/gm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greymatter0101/gm/teams","hooks_url":"https://api.github.com/repos/greymatter0101/gm/hooks","issue_events_url":"https://api.github.com/repos/greymatter0101/gm/issues/events{/number}","events_url":"https://api.github.com/repos/greymatter0101/gm/events","assignees_url":"https://api.github.com/repos/greymatter0101/gm/assignees{/user}","branches_url":"https://api.github.com/repos/greymatter0101/gm/branches{/branch}","tags_url":"https://api.github.com/repos/greymatter0101/gm/tags","blobs_url":"https://api.github.com/repos/greymatter0101/gm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greymatter0101/gm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greymatter0101/gm/git/refs{/sha}","trees_url":"https://api.github.com/repos/greymatter0101/gm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greymatter0101/gm/statuses/{sha}","languages_url":"https://api.github.com/repos/greymatter0101/gm/languages","stargazers_url":"https://api.github.com/repos/greymatter0101/gm/stargazers","contributors_url":"https://api.github.com/repos/greymatter0101/gm/contributors","subscribers_url":"https://api.github.com/repos/greymatter0101/gm/subscribers","subscription_url":"https://api.github.com/repos/greymatter0101/gm/subscription","commits_url":"https://api.github.com/repos/greymatter0101/gm/commits{/sha}","git_commits_url":"https://api.github.com/repos/greymatter0101/gm/git/commits{/sha}","comments_url":"https://api.github.com/repos/greymatter0101/gm/comments{/number}","issue_comment_url":"https://api.github.com/repos/greymatter0101/gm/issues/comments{/number}","contents_url":"https://api.github.com/repos/greymatter0101/gm/contents/{+path}","compare_url":"https://api.github.com/repos/greymatter0101/gm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greymatter0101/gm/merges","archive_url":"https://api.github.com/repos/greymatter0101/gm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greymatter0101/gm/downloads","issues_url":"https://api.github.com/repos/greymatter0101/gm/issues{/number}","pulls_url":"https://api.github.com/repos/greymatter0101/gm/pulls{/number}","milestones_url":"https://api.github.com/repos/greymatter0101/gm/milestones{/number}","notifications_url":"https://api.github.com/repos/greymatter0101/gm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greymatter0101/gm/labels{/name}","releases_url":"https://api.github.com/repos/greymatter0101/gm/releases{/id}","deployments_url":"https://api.github.com/repos/greymatter0101/gm/deployments","created_at":"2016-03-30T21:08:17Z","updated_at":"2016-04-03T22:57:18Z","pushed_at":"2016-08-08T23:46:25Z","git_url":"git://github.com/greymatter0101/gm.git","ssh_url":"git@github.com:greymatter0101/gm.git","clone_url":"https://github.com/greymatter0101/gm.git","svn_url":"https://github.com/greymatter0101/gm","homepage":null,"size":1970,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"greymatter0101:master","ref":"master","sha":"c549a775f01ea20feabefa45b8eee90b0a507159","user":{"login":"greymatter0101","id":18176938,"avatar_url":"https://avatars.githubusercontent.com/u/18176938?v=3","gravatar_id":"","url":"https://api.github.com/users/greymatter0101","html_url":"https://github.com/greymatter0101","followers_url":"https://api.github.com/users/greymatter0101/followers","following_url":"https://api.github.com/users/greymatter0101/following{/other_user}","gists_url":"https://api.github.com/users/greymatter0101/gists{/gist_id}","starred_url":"https://api.github.com/users/greymatter0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greymatter0101/subscriptions","organizations_url":"https://api.github.com/users/greymatter0101/orgs","repos_url":"https://api.github.com/users/greymatter0101/repos","events_url":"https://api.github.com/users/greymatter0101/events{/privacy}","received_events_url":"https://api.github.com/users/greymatter0101/received_events","type":"User","site_admin":false},"repo":{"id":55097955,"name":"gm","full_name":"greymatter0101/gm","owner":{"login":"greymatter0101","id":18176938,"avatar_url":"https://avatars.githubusercontent.com/u/18176938?v=3","gravatar_id":"","url":"https://api.github.com/users/greymatter0101","html_url":"https://github.com/greymatter0101","followers_url":"https://api.github.com/users/greymatter0101/followers","following_url":"https://api.github.com/users/greymatter0101/following{/other_user}","gists_url":"https://api.github.com/users/greymatter0101/gists{/gist_id}","starred_url":"https://api.github.com/users/greymatter0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greymatter0101/subscriptions","organizations_url":"https://api.github.com/users/greymatter0101/orgs","repos_url":"https://api.github.com/users/greymatter0101/repos","events_url":"https://api.github.com/users/greymatter0101/events{/privacy}","received_events_url":"https://api.github.com/users/greymatter0101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greymatter0101/gm","description":"","fork":false,"url":"https://api.github.com/repos/greymatter0101/gm","forks_url":"https://api.github.com/repos/greymatter0101/gm/forks","keys_url":"https://api.github.com/repos/greymatter0101/gm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greymatter0101/gm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greymatter0101/gm/teams","hooks_url":"https://api.github.com/repos/greymatter0101/gm/hooks","issue_events_url":"https://api.github.com/repos/greymatter0101/gm/issues/events{/number}","events_url":"https://api.github.com/repos/greymatter0101/gm/events","assignees_url":"https://api.github.com/repos/greymatter0101/gm/assignees{/user}","branches_url":"https://api.github.com/repos/greymatter0101/gm/branches{/branch}","tags_url":"https://api.github.com/repos/greymatter0101/gm/tags","blobs_url":"https://api.github.com/repos/greymatter0101/gm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greymatter0101/gm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greymatter0101/gm/git/refs{/sha}","trees_url":"https://api.github.com/repos/greymatter0101/gm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greymatter0101/gm/statuses/{sha}","languages_url":"https://api.github.com/repos/greymatter0101/gm/languages","stargazers_url":"https://api.github.com/repos/greymatter0101/gm/stargazers","contributors_url":"https://api.github.com/repos/greymatter0101/gm/contributors","subscribers_url":"https://api.github.com/repos/greymatter0101/gm/subscribers","subscription_url":"https://api.github.com/repos/greymatter0101/gm/subscription","commits_url":"https://api.github.com/repos/greymatter0101/gm/commits{/sha}","git_commits_url":"https://api.github.com/repos/greymatter0101/gm/git/commits{/sha}","comments_url":"https://api.github.com/repos/greymatter0101/gm/comments{/number}","issue_comment_url":"https://api.github.com/repos/greymatter0101/gm/issues/comments{/number}","contents_url":"https://api.github.com/repos/greymatter0101/gm/contents/{+path}","compare_url":"https://api.github.com/repos/greymatter0101/gm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greymatter0101/gm/merges","archive_url":"https://api.github.com/repos/greymatter0101/gm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greymatter0101/gm/downloads","issues_url":"https://api.github.com/repos/greymatter0101/gm/issues{/number}","pulls_url":"https://api.github.com/repos/greymatter0101/gm/pulls{/number}","milestones_url":"https://api.github.com/repos/greymatter0101/gm/milestones{/number}","notifications_url":"https://api.github.com/repos/greymatter0101/gm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greymatter0101/gm/labels{/name}","releases_url":"https://api.github.com/repos/greymatter0101/gm/releases{/id}","deployments_url":"https://api.github.com/repos/greymatter0101/gm/deployments","created_at":"2016-03-30T21:08:17Z","updated_at":"2016-04-03T22:57:18Z","pushed_at":"2016-08-08T23:46:25Z","git_url":"git://github.com/greymatter0101/gm.git","ssh_url":"git@github.com:greymatter0101/gm.git","clone_url":"https://github.com/greymatter0101/gm.git","svn_url":"https://github.com/greymatter0101/gm","homepage":null,"size":1970,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/25"},"html":{"href":"https://github.com/greymatter0101/gm/pull/25"},"issue":{"href":"https://api.github.com/repos/greymatter0101/gm/issues/25"},"comments":{"href":"https://api.github.com/repos/greymatter0101/gm/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greymatter0101/gm/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/greymatter0101/gm/statuses/474ed6885c04a4f91780fdd3c0523091556f80fb"}}}}
{"actor":{"display_login":"sameckmeier"}}