{"action":"closed","number":164,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164","id":70162483,"html_url":"https://github.com/facebook/react-native-fbsdk/pull/164","diff_url":"https://github.com/facebook/react-native-fbsdk/pull/164.diff","patch_url":"https://github.com/facebook/react-native-fbsdk/pull/164.patch","issue_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/164","number":164,"state":"closed","locked":false,"title":"Fix flow issue in FBLoginButton","user":{"login":"maarekj","id":1654977,"avatar_url":"https://avatars.githubusercontent.com/u/1654977?v=3","gravatar_id":"","url":"https://api.github.com/users/maarekj","html_url":"https://github.com/maarekj","followers_url":"https://api.github.com/users/maarekj/followers","following_url":"https://api.github.com/users/maarekj/following{/other_user}","gists_url":"https://api.github.com/users/maarekj/gists{/gist_id}","starred_url":"https://api.github.com/users/maarekj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maarekj/subscriptions","organizations_url":"https://api.github.com/users/maarekj/orgs","repos_url":"https://api.github.com/users/maarekj/repos","events_url":"https://api.github.com/users/maarekj/events{/privacy}","received_events_url":"https://api.github.com/users/maarekj/received_events","type":"User","site_admin":false},"body":"The **onLoginFinished** was typed with a callback of type **LoginResultCallback** (therefore only one parameter), but **onLoginFinished** is used with two parameters at line 108.\r\n\r\nThere are two solutions to this problem.\r\nThe first is to change the call to line 108 in `this.props.onLoginFinished(eventDict)` instead of `this.props.onLoginFinished(eventDict.error, eventDict.result)`\r\n\r\nThe second is to change the typing of onLoginFinished (like in this pull request).\r\n\r\nThe first solution is breaking compatibility, the second solution isn't breaking compatibility","created_at":"2016-05-16T07:58:47Z","updated_at":"2016-05-19T20:14:43Z","closed_at":"2016-05-19T20:14:43Z","merged_at":"2016-05-19T20:14:43Z","merge_commit_sha":"79f7fec130596fce745e1b6df2cfb416935f71e8","assignee":{"login":"dzhuowen","id":14930169,"avatar_url":"https://avatars.githubusercontent.com/u/14930169?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhuowen","html_url":"https://github.com/dzhuowen","followers_url":"https://api.github.com/users/dzhuowen/followers","following_url":"https://api.github.com/users/dzhuowen/following{/other_user}","gists_url":"https://api.github.com/users/dzhuowen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhuowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhuowen/subscriptions","organizations_url":"https://api.github.com/users/dzhuowen/orgs","repos_url":"https://api.github.com/users/dzhuowen/repos","events_url":"https://api.github.com/users/dzhuowen/events{/privacy}","received_events_url":"https://api.github.com/users/dzhuowen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/164/comments","statuses_url":"https://api.github.com/repos/facebook/react-native-fbsdk/statuses/24b6037df0b112c1dc55a22dd2058dc96b2b245d","head":{"label":"maarekj:patch-1","ref":"patch-1","sha":"24b6037df0b112c1dc55a22dd2058dc96b2b245d","user":{"login":"maarekj","id":1654977,"avatar_url":"https://avatars.githubusercontent.com/u/1654977?v=3","gravatar_id":"","url":"https://api.github.com/users/maarekj","html_url":"https://github.com/maarekj","followers_url":"https://api.github.com/users/maarekj/followers","following_url":"https://api.github.com/users/maarekj/following{/other_user}","gists_url":"https://api.github.com/users/maarekj/gists{/gist_id}","starred_url":"https://api.github.com/users/maarekj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maarekj/subscriptions","organizations_url":"https://api.github.com/users/maarekj/orgs","repos_url":"https://api.github.com/users/maarekj/repos","events_url":"https://api.github.com/users/maarekj/events{/privacy}","received_events_url":"https://api.github.com/users/maarekj/received_events","type":"User","site_admin":false},"repo":{"id":58913743,"name":"react-native-fbsdk","full_name":"maarekj/react-native-fbsdk","owner":{"login":"maarekj","id":1654977,"avatar_url":"https://avatars.githubusercontent.com/u/1654977?v=3","gravatar_id":"","url":"https://api.github.com/users/maarekj","html_url":"https://github.com/maarekj","followers_url":"https://api.github.com/users/maarekj/followers","following_url":"https://api.github.com/users/maarekj/following{/other_user}","gists_url":"https://api.github.com/users/maarekj/gists{/gist_id}","starred_url":"https://api.github.com/users/maarekj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maarekj/subscriptions","organizations_url":"https://api.github.com/users/maarekj/orgs","repos_url":"https://api.github.com/users/maarekj/repos","events_url":"https://api.github.com/users/maarekj/events{/privacy}","received_events_url":"https://api.github.com/users/maarekj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maarekj/react-native-fbsdk","description":"A React Native wrapper around the Facebook SDKs for Android and iOS.  Provides access to Facebook login, sharing, graph requests, app events etc.","fork":true,"url":"https://api.github.com/repos/maarekj/react-native-fbsdk","forks_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/forks","keys_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/teams","hooks_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/hooks","issue_events_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/issues/events{/number}","events_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/events","assignees_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/assignees{/user}","branches_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/branches{/branch}","tags_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/tags","blobs_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/languages","stargazers_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/stargazers","contributors_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/contributors","subscribers_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/subscribers","subscription_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/subscription","commits_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/contents/{+path}","compare_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/merges","archive_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/downloads","issues_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/issues{/number}","pulls_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/labels{/name}","releases_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/releases{/id}","deployments_url":"https://api.github.com/repos/maarekj/react-native-fbsdk/deployments","created_at":"2016-05-16T07:50:30Z","updated_at":"2016-05-16T07:50:31Z","pushed_at":"2016-05-16T07:57:56Z","git_url":"git://github.com/maarekj/react-native-fbsdk.git","ssh_url":"git@github.com:maarekj/react-native-fbsdk.git","clone_url":"https://github.com/maarekj/react-native-fbsdk.git","svn_url":"https://github.com/maarekj/react-native-fbsdk","homepage":"https://developers.facebook.com/docs/react-native","size":519,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0c51d46fe68ab91ca9cc19eb4e77e6293a919e72","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":40137508,"name":"react-native-fbsdk","full_name":"facebook/react-native-fbsdk","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native-fbsdk","description":"A React Native wrapper around the Facebook SDKs for Android and iOS.  Provides access to Facebook login, sharing, graph requests, app events etc.","fork":false,"url":"https://api.github.com/repos/facebook/react-native-fbsdk","forks_url":"https://api.github.com/repos/facebook/react-native-fbsdk/forks","keys_url":"https://api.github.com/repos/facebook/react-native-fbsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native-fbsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native-fbsdk/teams","hooks_url":"https://api.github.com/repos/facebook/react-native-fbsdk/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native-fbsdk/events","assignees_url":"https://api.github.com/repos/facebook/react-native-fbsdk/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native-fbsdk/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native-fbsdk/tags","blobs_url":"https://api.github.com/repos/facebook/react-native-fbsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native-fbsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native-fbsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native-fbsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native-fbsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native-fbsdk/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native-fbsdk/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native-fbsdk/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native-fbsdk/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native-fbsdk/subscription","commits_url":"https://api.github.com/repos/facebook/react-native-fbsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native-fbsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native-fbsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native-fbsdk/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native-fbsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native-fbsdk/merges","archive_url":"https://api.github.com/repos/facebook/react-native-fbsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native-fbsdk/downloads","issues_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native-fbsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native-fbsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native-fbsdk/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native-fbsdk/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native-fbsdk/deployments","created_at":"2015-08-03T17:10:14Z","updated_at":"2016-05-19T11:43:42Z","pushed_at":"2016-05-19T20:14:43Z","git_url":"git://github.com/facebook/react-native-fbsdk.git","ssh_url":"git@github.com:facebook/react-native-fbsdk.git","clone_url":"https://github.com/facebook/react-native-fbsdk.git","svn_url":"https://github.com/facebook/react-native-fbsdk","homepage":"https://developers.facebook.com/docs/react-native","size":587,"stargazers_count":546,"watchers_count":546,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":15,"forks":92,"open_issues":15,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164"},"html":{"href":"https://github.com/facebook/react-native-fbsdk/pull/164"},"issue":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/164"},"comments":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native-fbsdk/statuses/24b6037df0b112c1dc55a22dd2058dc96b2b245d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dzhuowen","id":14930169,"avatar_url":"https://avatars.githubusercontent.com/u/14930169?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhuowen","html_url":"https://github.com/dzhuowen","followers_url":"https://api.github.com/users/dzhuowen/followers","following_url":"https://api.github.com/users/dzhuowen/following{/other_user}","gists_url":"https://api.github.com/users/dzhuowen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhuowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhuowen/subscriptions","organizations_url":"https://api.github.com/users/dzhuowen/orgs","repos_url":"https://api.github.com/users/dzhuowen/repos","events_url":"https://api.github.com/users/dzhuowen/events{/privacy}","received_events_url":"https://api.github.com/users/dzhuowen/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":1,"deletions":5,"changed_files":1}}