{"action":"reopened","number":316,"pull_request":{"url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316","id":56268627,"html_url":"https://github.com/PrismarineJS/node-minecraft-protocol/pull/316","diff_url":"https://github.com/PrismarineJS/node-minecraft-protocol/pull/316.diff","patch_url":"https://github.com/PrismarineJS/node-minecraft-protocol/pull/316.patch","issue_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/316","number":316,"state":"open","locked":false,"title":"[WIP] Send framed packets in one push()","user":{"login":"deathcap","id":5897956,"avatar_url":"https://avatars.githubusercontent.com/u/5897956?v=3","gravatar_id":"","url":"https://api.github.com/users/deathcap","html_url":"https://github.com/deathcap","followers_url":"https://api.github.com/users/deathcap/followers","following_url":"https://api.github.com/users/deathcap/following{/other_user}","gists_url":"https://api.github.com/users/deathcap/gists{/gist_id}","starred_url":"https://api.github.com/users/deathcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathcap/subscriptions","organizations_url":"https://api.github.com/users/deathcap/orgs","repos_url":"https://api.github.com/users/deathcap/repos","events_url":"https://api.github.com/users/deathcap/events{/privacy}","received_events_url":"https://api.github.com/users/deathcap/received_events","type":"User","site_admin":false},"body":"Before the streams refactor, MC packets were sent with the packet length prefix and payload combined in one call. This PR restores this behavior, instead of sending the packet length and payload in two separate `this.push()` calls.\r\n\r\nref: https://github.com/deathcap/wsmc/pull/21#issuecomment-172284334\r\n\r\n(With this change, browserified mineflayer now works with the latest node-minecraft-protocol)","created_at":"2016-01-17T02:23:28Z","updated_at":"2016-01-18T21:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f95ce3c3e09e6b38af3b32565797f9f854bee57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316/commits","review_comments_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316/comments","review_comment_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/316/comments","statuses_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/statuses/d48759d428072654d10eb2d7bd1e2d2e3042cbf4","head":{"label":"deathcap:frame1","ref":"frame1","sha":"d48759d428072654d10eb2d7bd1e2d2e3042cbf4","user":{"login":"deathcap","id":5897956,"avatar_url":"https://avatars.githubusercontent.com/u/5897956?v=3","gravatar_id":"","url":"https://api.github.com/users/deathcap","html_url":"https://github.com/deathcap","followers_url":"https://api.github.com/users/deathcap/followers","following_url":"https://api.github.com/users/deathcap/following{/other_user}","gists_url":"https://api.github.com/users/deathcap/gists{/gist_id}","starred_url":"https://api.github.com/users/deathcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathcap/subscriptions","organizations_url":"https://api.github.com/users/deathcap/orgs","repos_url":"https://api.github.com/users/deathcap/repos","events_url":"https://api.github.com/users/deathcap/events{/privacy}","received_events_url":"https://api.github.com/users/deathcap/received_events","type":"User","site_admin":false},"repo":{"id":15627192,"name":"node-minecraft-protocol","full_name":"deathcap/node-minecraft-protocol","owner":{"login":"deathcap","id":5897956,"avatar_url":"https://avatars.githubusercontent.com/u/5897956?v=3","gravatar_id":"","url":"https://api.github.com/users/deathcap","html_url":"https://github.com/deathcap","followers_url":"https://api.github.com/users/deathcap/followers","following_url":"https://api.github.com/users/deathcap/following{/other_user}","gists_url":"https://api.github.com/users/deathcap/gists{/gist_id}","starred_url":"https://api.github.com/users/deathcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathcap/subscriptions","organizations_url":"https://api.github.com/users/deathcap/orgs","repos_url":"https://api.github.com/users/deathcap/repos","events_url":"https://api.github.com/users/deathcap/events{/privacy}","received_events_url":"https://api.github.com/users/deathcap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deathcap/node-minecraft-protocol","description":"Parse and serialize minecraft packets, plus authentication and encryption.","fork":true,"url":"https://api.github.com/repos/deathcap/node-minecraft-protocol","forks_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/forks","keys_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/teams","hooks_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/hooks","issue_events_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/events","assignees_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/tags","blobs_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/languages","stargazers_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/stargazers","contributors_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/contributors","subscribers_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/subscribers","subscription_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/subscription","commits_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/merges","archive_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/downloads","issues_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/labels{/name}","releases_url":"https://api.github.com/repos/deathcap/node-minecraft-protocol/releases{/id}","created_at":"2014-01-04T05:44:25Z","updated_at":"2015-03-08T23:34:54Z","pushed_at":"2016-01-18T21:39:26Z","git_url":"git://github.com/deathcap/node-minecraft-protocol.git","ssh_url":"git@github.com:deathcap/node-minecraft-protocol.git","clone_url":"https://github.com/deathcap/node-minecraft-protocol.git","svn_url":"https://github.com/deathcap/node-minecraft-protocol","homepage":"","size":875,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"PrismarineJS:master","ref":"master","sha":"3ba152eba3410f98897a24c54c911938409e9945","user":{"login":"PrismarineJS","id":11053411,"avatar_url":"https://avatars.githubusercontent.com/u/11053411?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismarineJS","html_url":"https://github.com/PrismarineJS","followers_url":"https://api.github.com/users/PrismarineJS/followers","following_url":"https://api.github.com/users/PrismarineJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismarineJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismarineJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismarineJS/subscriptions","organizations_url":"https://api.github.com/users/PrismarineJS/orgs","repos_url":"https://api.github.com/users/PrismarineJS/repos","events_url":"https://api.github.com/users/PrismarineJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismarineJS/received_events","type":"Organization","site_admin":false},"repo":{"id":7394347,"name":"node-minecraft-protocol","full_name":"PrismarineJS/node-minecraft-protocol","owner":{"login":"PrismarineJS","id":11053411,"avatar_url":"https://avatars.githubusercontent.com/u/11053411?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismarineJS","html_url":"https://github.com/PrismarineJS","followers_url":"https://api.github.com/users/PrismarineJS/followers","following_url":"https://api.github.com/users/PrismarineJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismarineJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismarineJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismarineJS/subscriptions","organizations_url":"https://api.github.com/users/PrismarineJS/orgs","repos_url":"https://api.github.com/users/PrismarineJS/repos","events_url":"https://api.github.com/users/PrismarineJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismarineJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrismarineJS/node-minecraft-protocol","description":"Parse and serialize minecraft packets, plus authentication and encryption.","fork":false,"url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol","forks_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/forks","keys_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/teams","hooks_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/hooks","issue_events_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/events","assignees_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/tags","blobs_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/languages","stargazers_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/stargazers","contributors_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/contributors","subscribers_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/subscribers","subscription_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/subscription","commits_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/merges","archive_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/downloads","issues_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/labels{/name}","releases_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/releases{/id}","created_at":"2013-01-01T09:17:05Z","updated_at":"2016-01-17T13:00:57Z","pushed_at":"2016-01-18T21:39:26Z","git_url":"git://github.com/PrismarineJS/node-minecraft-protocol.git","ssh_url":"git@github.com:PrismarineJS/node-minecraft-protocol.git","clone_url":"https://github.com/PrismarineJS/node-minecraft-protocol.git","svn_url":"https://github.com/PrismarineJS/node-minecraft-protocol","homepage":"http://prismarinejs.github.io/","size":1019,"stargazers_count":203,"watchers_count":203,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":28,"forks":52,"open_issues":28,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316"},"html":{"href":"https://github.com/PrismarineJS/node-minecraft-protocol/pull/316"},"issue":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/316"},"comments":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/statuses/d48759d428072654d10eb2d7bd1e2d2e3042cbf4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}