{"action":"created","comment":{"url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments/66488043","id":66488043,"diff_hunk":"@@ -94,13 +143,17 @@ class ContentController {\n      * Hook the different rawdata trackers to DOM.\n      * @param database   the database that should be used when logging.\n      */\n-    private hookSyntacticToDOM(database: DatabaseAdaptable) {\n-        // tslint:disable:no-unused-variable\n-        let windowResolutionTracker = new WindowResolutionTracker(database);\n-        let keystrokeTracker = new KeystrokeTracker(database);\n-        let mouseClickTracker = new MouseClickTracker(database);\n-        let mouseScrollTracker = new MouseScrollTracker(database);\n-        let mousePositionTracker = new MousePositionTracker(database);\n-        // tslint:enable:no-unused-variable\n+    private hookTrackersToDOM(database: DatabaseAdaptable) {\n+        const list: EventTracker[] = [","path":"src/octopeer-github/content/ContentController.ts","position":115,"original_position":115,"commit_id":"3d72de4ae4fe33eed0f969e7b2df68bad8a87041","original_commit_id":"3d72de4ae4fe33eed0f969e7b2df68bad8a87041","user":{"login":"MathiasMeuleman","id":9725373,"avatar_url":"https://avatars.githubusercontent.com/u/9725373?v=3","gravatar_id":"","url":"https://api.github.com/users/MathiasMeuleman","html_url":"https://github.com/MathiasMeuleman","followers_url":"https://api.github.com/users/MathiasMeuleman/followers","following_url":"https://api.github.com/users/MathiasMeuleman/following{/other_user}","gists_url":"https://api.github.com/users/MathiasMeuleman/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasMeuleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasMeuleman/subscriptions","organizations_url":"https://api.github.com/users/MathiasMeuleman/orgs","repos_url":"https://api.github.com/users/MathiasMeuleman/repos","events_url":"https://api.github.com/users/MathiasMeuleman/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasMeuleman/received_events","type":"User","site_admin":false},"body":"wouldn't it be cleaner to have this list as private field of the class?","created_at":"2016-06-09T17:47:49Z","updated_at":"2016-06-09T17:47:49Z","html_url":"https://github.com/thervh70/ContextProject_RDD/pull/130#discussion_r66488043","pull_request_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments/66488043"},"html":{"href":"https://github.com/thervh70/ContextProject_RDD/pull/130#discussion_r66488043"},"pull_request":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130","id":73183637,"html_url":"https://github.com/thervh70/ContextProject_RDD/pull/130","diff_url":"https://github.com/thervh70/ContextProject_RDD/pull/130.diff","patch_url":"https://github.com/thervh70/ContextProject_RDD/pull/130.patch","issue_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/130","number":130,"state":"open","locked":false,"title":"80 connect global logging switch","user":{"login":"mpsijm","id":9739541,"avatar_url":"https://avatars.githubusercontent.com/u/9739541?v=3","gravatar_id":"","url":"https://api.github.com/users/mpsijm","html_url":"https://github.com/mpsijm","followers_url":"https://api.github.com/users/mpsijm/followers","following_url":"https://api.github.com/users/mpsijm/following{/other_user}","gists_url":"https://api.github.com/users/mpsijm/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsijm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsijm/subscriptions","organizations_url":"https://api.github.com/users/mpsijm/orgs","repos_url":"https://api.github.com/users/mpsijm/repos","events_url":"https://api.github.com/users/mpsijm/events{/privacy}","received_events_url":"https://api.github.com/users/mpsijm/received_events","type":"User","site_admin":false},"body":"Will close #80 \r\n\r\nNow, finally, the global logging switch will trigger changes in the back-end! :D Quite some things have been changed in order to do this, such as:\r\n- Wait a week until the ESB and EEB lists were done\r\n- The chrome message to the content script now contains a boolean that corresponds to Options.LOGGING instead of always \"true\"\r\n- All EventBindings and EventTrackers now have `addDOMEvent` and `removeDOMEvent` functions\r\n- Switching the logging state will immediately trigger the removal of all DOMEvents\r\n- When a content script should be reloaded, it _will_ be reloaded by the extension (GitHub remembers everything anyway)\r\n\r\nJavaDoc is still being added, so don't hate on that, at least you have something to review now :)","created_at":"2016-06-09T09:39:01Z","updated_at":"2016-06-09T17:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ad9330d9dd488b0ded889d98891cd9d5db59ac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130/commits","review_comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130/comments","review_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/130/comments","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/3d72de4ae4fe33eed0f969e7b2df68bad8a87041","head":{"label":"thervh70:80-connect-global-logging-switch","ref":"80-connect-global-logging-switch","sha":"3d72de4ae4fe33eed0f969e7b2df68bad8a87041","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":56582349,"name":"ContextProject_RDD","full_name":"thervh70/ContextProject_RDD","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/ContextProject_RDD","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/ContextProject_RDD","forks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/forks","keys_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/teams","hooks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/hooks","issue_events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/events","assignees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/tags","blobs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/languages","stargazers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/stargazers","contributors_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contributors","subscribers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscribers","subscription_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscription","commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/merges","archive_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/downloads","issues_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/releases{/id}","deployments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/deployments","created_at":"2016-04-19T09:12:06Z","updated_at":"2016-05-20T15:46:07Z","pushed_at":"2016-06-09T15:23:39Z","git_url":"git://github.com/thervh70/ContextProject_RDD.git","ssh_url":"git@github.com:thervh70/ContextProject_RDD.git","clone_url":"https://github.com/thervh70/ContextProject_RDD.git","svn_url":"https://github.com/thervh70/ContextProject_RDD","homepage":null,"size":5657,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"thervh70:dev","ref":"dev","sha":"49ed441edddd241386ee6d6edead3ddbc863ee65","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":56582349,"name":"ContextProject_RDD","full_name":"thervh70/ContextProject_RDD","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/ContextProject_RDD","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/ContextProject_RDD","forks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/forks","keys_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/teams","hooks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/hooks","issue_events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/events","assignees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/tags","blobs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/languages","stargazers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/stargazers","contributors_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contributors","subscribers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscribers","subscription_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscription","commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/merges","archive_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/downloads","issues_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/releases{/id}","deployments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/deployments","created_at":"2016-04-19T09:12:06Z","updated_at":"2016-05-20T15:46:07Z","pushed_at":"2016-06-09T15:23:39Z","git_url":"git://github.com/thervh70/ContextProject_RDD.git","ssh_url":"git@github.com:thervh70/ContextProject_RDD.git","clone_url":"https://github.com/thervh70/ContextProject_RDD.git","svn_url":"https://github.com/thervh70/ContextProject_RDD","homepage":null,"size":5657,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130"},"html":{"href":"https://github.com/thervh70/ContextProject_RDD/pull/130"},"issue":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/130"},"comments":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/3d72de4ae4fe33eed0f969e7b2df68bad8a87041"}}}}
{"actor":{"display_login":"MathiasMeuleman"}}