{"action":"created","issue":{"url":"https://api.github.com/repos/SoCo/SoCo/issues/437","repository_url":"https://api.github.com/repos/SoCo/SoCo","labels_url":"https://api.github.com/repos/SoCo/SoCo/issues/437/labels{/name}","comments_url":"https://api.github.com/repos/SoCo/SoCo/issues/437/comments","events_url":"https://api.github.com/repos/SoCo/SoCo/issues/437/events","html_url":"https://github.com/SoCo/SoCo/pull/437","id":184938176,"number":437,"title":"Event listener thread safety","user":{"login":"bjarniivarsson","id":1349807,"avatar_url":"https://avatars.githubusercontent.com/u/1349807?v=3","gravatar_id":"","url":"https://api.github.com/users/bjarniivarsson","html_url":"https://github.com/bjarniivarsson","followers_url":"https://api.github.com/users/bjarniivarsson/followers","following_url":"https://api.github.com/users/bjarniivarsson/following{/other_user}","gists_url":"https://api.github.com/users/bjarniivarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/bjarniivarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjarniivarsson/subscriptions","organizations_url":"https://api.github.com/users/bjarniivarsson/orgs","repos_url":"https://api.github.com/users/bjarniivarsson/repos","events_url":"https://api.github.com/users/bjarniivarsson/events{/privacy}","received_events_url":"https://api.github.com/users/bjarniivarsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-24T19:54:03Z","updated_at":"2016-10-26T18:39:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SoCo/SoCo/pulls/437","html_url":"https://github.com/SoCo/SoCo/pull/437","diff_url":"https://github.com/SoCo/SoCo/pull/437.diff","patch_url":"https://github.com/SoCo/SoCo/pull/437.patch"},"body":"EventListener.start would sometimes blow up if attempting to subscribe to multiple services from different threads. This happens when for example you have a thread per-speaker subscribing to events. This also fixes a thread crash that would occur when receiving events that you have not subscribed for (no service for sid). This may happen when restarting applications based on SoCo."},"comment":{"url":"https://api.github.com/repos/SoCo/SoCo/issues/comments/256439251","html_url":"https://github.com/SoCo/SoCo/pull/437#issuecomment-256439251","issue_url":"https://api.github.com/repos/SoCo/SoCo/issues/437","id":256439251,"user":{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars.githubusercontent.com/u/1611076?v=3","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T18:39:07Z","updated_at":"2016-10-26T18:39:07Z","body":"Ah ok. One more (but a follow up), then I'm done nit-picking. I guess the comment that went along with the if check you just removed:\r\n```python\r\n# It might have been removed by another thread\r\n```\r\nshould now be moved up to before ```if service:```."}}
{"actor":{"display_login":"KennethNielsen"}}