{"action":"created","issue":{"url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/2","repository_url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse","labels_url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/2/comments","events_url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/2/events","html_url":"https://github.com/FatJohn/TestDrivenDevelopCourse/issues/2","id":140878879,"number":2,"title":"review completed","user":{"login":"hatelove","id":1528587,"avatar_url":"https://avatars.githubusercontent.com/u/1528587?v=3","gravatar_id":"","url":"https://api.github.com/users/hatelove","html_url":"https://github.com/hatelove","followers_url":"https://api.github.com/users/hatelove/followers","following_url":"https://api.github.com/users/hatelove/following{/other_user}","gists_url":"https://api.github.com/users/hatelove/gists{/gist_id}","starred_url":"https://api.github.com/users/hatelove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatelove/subscriptions","organizations_url":"https://api.github.com/users/hatelove/orgs","repos_url":"https://api.github.com/users/hatelove/repos","events_url":"https://api.github.com/users/hatelove/events{/privacy}","received_events_url":"https://api.github.com/users/hatelove/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-15T05:33:54Z","updated_at":"2016-03-15T05:49:11Z","closed_at":null,"body":"因為 day2 homework 的部分沒有細部的 commit history, 所以我無法給比較細的 comments。\r\n\r\n唯一的建議是 測試案例的 expected 不需要解釋太多 how，因為 how 是會變的。測試案例只管 what。"},"comment":{"url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/comments/196675780","html_url":"https://github.com/FatJohn/TestDrivenDevelopCourse/issues/2#issuecomment-196675780","issue_url":"https://api.github.com/repos/FatJohn/TestDrivenDevelopCourse/issues/2","id":196675780,"user":{"login":"FatJohn","id":6370796,"avatar_url":"https://avatars.githubusercontent.com/u/6370796?v=3","gravatar_id":"","url":"https://api.github.com/users/FatJohn","html_url":"https://github.com/FatJohn","followers_url":"https://api.github.com/users/FatJohn/followers","following_url":"https://api.github.com/users/FatJohn/following{/other_user}","gists_url":"https://api.github.com/users/FatJohn/gists{/gist_id}","starred_url":"https://api.github.com/users/FatJohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatJohn/subscriptions","organizations_url":"https://api.github.com/users/FatJohn/orgs","repos_url":"https://api.github.com/users/FatJohn/repos","events_url":"https://api.github.com/users/FatJohn/events{/privacy}","received_events_url":"https://api.github.com/users/FatJohn/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T05:49:11Z","updated_at":"2016-03-15T05:49:11Z","body":"收到，感謝~\r\n沒有分別把每一個 test case 的步驟都放上的原因是... 寫了第一個 test case，寫 production code的時候，花了比較多的時間想要怎麼寫完後續的需求，然後寫好了後，第一個 test case 過了，其他的 test case 寫完 test case 就測試過了... 就沒一個一個 commit，下次會注意\r\n\r\nInitial commit 後續的 commit 是發現一些其他自己 production code 的問題就補上其他的 test case，以及調整\r\n\r\n關於於 expected ，那時候有想是要寫在 method name ？還是目前的寫法？還是直接寫最後的數值？\r\n\r\n因為知道需求會變，所以這樣寫是因為 (1) 怕自己算錯就交給電腦算 (2) 描述目前計算折扣的方式（雖然的目的似乎也沒有很清楚），因為不清楚 how 可能會把 expected 寫錯？\r\n\r\n大概是這樣，請多多指教"}}