{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/16758","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/16758/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/16758/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/16758/events","html_url":"https://github.com/rust-lang/rust/issues/16758","id":41135578,"number":16758,"title":"No drop flag check for DST structs","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/A-dst","name":"A-dst","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2014-08-26T04:06:19Z","updated_at":"2016-08-22T17:24:48Z","closed_at":null,"body":"Since drop flags come after all named fields and the last field in a DST struct is unsized, finding the drop flag is a bit tricky. Therefore, it is currently not checked. A possible fix is to find the alignment by taking the size of the struct from its vtable and subtracting the size of the drop flag. However, since the plan is to remove the drop flag anyway (#5016), I have just left a FIXME and issue a warning when we skip the check.\r\n\r\ncc @pnkfelix"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/241485822","html_url":"https://github.com/rust-lang/rust/issues/16758#issuecomment-241485822","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/16758","id":241485822,"user":{"login":"jonas-schievink","id":1786438,"avatar_url":"https://avatars.githubusercontent.com/u/1786438?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas-schievink","html_url":"https://github.com/jonas-schievink","followers_url":"https://api.github.com/users/jonas-schievink/followers","following_url":"https://api.github.com/users/jonas-schievink/following{/other_user}","gists_url":"https://api.github.com/users/jonas-schievink/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas-schievink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas-schievink/subscriptions","organizations_url":"https://api.github.com/users/jonas-schievink/orgs","repos_url":"https://api.github.com/users/jonas-schievink/repos","events_url":"https://api.github.com/users/jonas-schievink/events{/privacy}","received_events_url":"https://api.github.com/users/jonas-schievink/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T17:24:48Z","updated_at":"2016-08-22T17:24:48Z","body":"This should no longer be relevant after #35764 lands since it will remove in-struct drop flags"}}
{"actor":{"display_login":"jonas-schievink"}}