{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/90846587","pull_request_review_id":11360293,"id":90846587,"diff_hunk":"@@ -160,6 +167,31 @@ in {\n             if activated.\n           '';\n         };\n+\n+        resample-method = mkOption {\n+          type = types.str;","path":"nixos/modules/config/pulseaudio.nix","position":27,"original_position":27,"commit_id":"1888c667738563257e16c06ddad6b0ce253f4192","original_commit_id":"1888c667738563257e16c06ddad6b0ce253f4192","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"sounds like a lot, who will keep this list up-to-date?","created_at":"2016-12-05T11:26:48Z","updated_at":"2016-12-05T11:26:48Z","html_url":"https://github.com/NixOS/nixpkgs/pull/20888#discussion_r90846587","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/90846587"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/20888#discussion_r90846587"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888","id":96416977,"html_url":"https://github.com/NixOS/nixpkgs/pull/20888","diff_url":"https://github.com/NixOS/nixpkgs/pull/20888.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/20888.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20888","number":20888,"state":"open","locked":false,"title":"nixos/pulseaudio: make daemon.conf configurable","user":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThere is no possibilty to adjust the behavior of the pulseadio daemon via the daemon.conf file at the moment.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nThis adds the following options:\r\n\r\n* `pulseaudio.daemon.flat-volumes`: wether to allow pulseaudio to adjust\r\n  the sink volume based on playback volumes\r\n* `pulseaudio.daemon.resample-method`: set pulseaudios resampling method\r\n* `pulseaudio.daemon.extraConfig`: extra config for daemon.conf\r\n\r\nOpen question: Should we change the default value of flat-volumes?\r\nThe behavior has caused some controversy and Ubuntu as well as ArchLinux\r\nchose to disable the feature.\r\n\r\n---\r\n\r\nNote: This is my first change involving `nixos/modules` and I am happy to receive suggestions to improve the code.","created_at":"2016-12-04T01:00:42Z","updated_at":"2016-12-05T11:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b38cc549bfa171a3c71821894f5db77d9f810f0b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20888/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1888c667738563257e16c06ddad6b0ce253f4192","head":{"label":"sternenseemann:pulse","ref":"pulse","sha":"1888c667738563257e16c06ddad6b0ce253f4192","user":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"repo":{"id":64657078,"name":"nixpkgs","full_name":"sternenseemann/nixpkgs","owner":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sternenseemann/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/sternenseemann/nixpkgs","forks_url":"https://api.github.com/repos/sternenseemann/nixpkgs/forks","keys_url":"https://api.github.com/repos/sternenseemann/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sternenseemann/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sternenseemann/nixpkgs/teams","hooks_url":"https://api.github.com/repos/sternenseemann/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/sternenseemann/nixpkgs/events","assignees_url":"https://api.github.com/repos/sternenseemann/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/sternenseemann/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/sternenseemann/nixpkgs/tags","blobs_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sternenseemann/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/sternenseemann/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/sternenseemann/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/sternenseemann/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/sternenseemann/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/sternenseemann/nixpkgs/subscription","commits_url":"https://api.github.com/repos/sternenseemann/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sternenseemann/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sternenseemann/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/sternenseemann/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sternenseemann/nixpkgs/merges","archive_url":"https://api.github.com/repos/sternenseemann/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sternenseemann/nixpkgs/downloads","issues_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/sternenseemann/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/sternenseemann/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/sternenseemann/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sternenseemann/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/sternenseemann/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/sternenseemann/nixpkgs/deployments","created_at":"2016-08-01T10:10:35Z","updated_at":"2016-08-01T10:11:06Z","pushed_at":"2016-12-04T00:58:23Z","git_url":"git://github.com/sternenseemann/nixpkgs.git","ssh_url":"git@github.com:sternenseemann/nixpkgs.git","clone_url":"https://github.com/sternenseemann/nixpkgs.git","svn_url":"https://github.com/sternenseemann/nixpkgs","homepage":null,"size":379861,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"69bee1b361afdd4e5348c210c9253995c8cb171a","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-12-04T21:58:45Z","pushed_at":"2016-12-05T11:06:20Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":657728,"stargazers_count":1404,"watchers_count":1404,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1735,"mirror_url":null,"open_issues_count":1666,"forks":1735,"open_issues":1666,"watchers":1404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/20888"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/20888"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/20888/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20888/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1888c667738563257e16c06ddad6b0ce253f4192"}}}}
{"actor":{"display_login":"Mic92"}}