{"action":"created","issue":{"url":"https://api.github.com/repos/apollostack/react-apollo/issues/342","repository_url":"https://api.github.com/repos/apollostack/react-apollo","labels_url":"https://api.github.com/repos/apollostack/react-apollo/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/apollostack/react-apollo/issues/342/comments","events_url":"https://api.github.com/repos/apollostack/react-apollo/issues/342/events","html_url":"https://github.com/apollostack/react-apollo/pull/342","id":191553211,"number":342,"title":"fix resetStore / skip logic","user":{"login":"machard","id":5071029,"avatar_url":"https://avatars.githubusercontent.com/u/5071029?v=3","gravatar_id":"","url":"https://api.github.com/users/machard","html_url":"https://github.com/machard","followers_url":"https://api.github.com/users/machard/followers","following_url":"https://api.github.com/users/machard/following{/other_user}","gists_url":"https://api.github.com/users/machard/gists{/gist_id}","starred_url":"https://api.github.com/users/machard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machard/subscriptions","organizations_url":"https://api.github.com/users/machard/orgs","repos_url":"https://api.github.com/users/machard/repos","events_url":"https://api.github.com/users/machard/events{/privacy}","received_events_url":"https://api.github.com/users/machard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-24T15:59:25Z","updated_at":"2016-11-25T14:40:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apollostack/react-apollo/pulls/342","html_url":"https://github.com/apollostack/react-apollo/pull/342","diff_url":"https://github.com/apollostack/react-apollo/pull/342.diff","patch_url":"https://github.com/apollostack/react-apollo/pull/342.patch"},"body":"When skip is true, then switch back to false, if we call resetStore, it will run the query.\r\nThis fix propose to tearDown the queryObservable instead of just unsubscribing.\r\nThe queryObservable is already recreated if it's missing\r\n\r\nNeed https://github.com/apollostack/apollo-client/pull/960\r\n\r\nsee https://github.com/apollostack/react-apollo/issues/289#issuecomment-262803767"},"comment":{"url":"https://api.github.com/repos/apollostack/react-apollo/issues/comments/262969479","html_url":"https://github.com/apollostack/react-apollo/pull/342#issuecomment-262969479","issue_url":"https://api.github.com/repos/apollostack/react-apollo/issues/342","id":262969479,"user":{"login":"machard","id":5071029,"avatar_url":"https://avatars.githubusercontent.com/u/5071029?v=3","gravatar_id":"","url":"https://api.github.com/users/machard","html_url":"https://github.com/machard","followers_url":"https://api.github.com/users/machard/followers","following_url":"https://api.github.com/users/machard/following{/other_user}","gists_url":"https://api.github.com/users/machard/gists{/gist_id}","starred_url":"https://api.github.com/users/machard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machard/subscriptions","organizations_url":"https://api.github.com/users/machard/orgs","repos_url":"https://api.github.com/users/machard/repos","events_url":"https://api.github.com/users/machard/events{/privacy}","received_events_url":"https://api.github.com/users/machard/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T14:40:36Z","updated_at":"2016-11-25T14:40:36Z","body":"I think tearing down the query is actually not a good idea because when teardowned, the component is updated without the data ... i would like the data to still be available"}}
{"actor":{"display_login":"machard"}}