{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14756","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14756/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14756/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14756/events","html_url":"https://github.com/cms-sw/cmssw/pull/14756","id":158252103,"number":14756,"title":"fix CaloTowerTopology for HGCal/BH","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":64,"closed_issues":776,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-06-08T05:00:38Z","due_on":null,"closed_at":null},"comments":22,"created_at":"2016-06-02T22:16:37Z","updated_at":"2016-06-08T05:31:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14756","html_url":"https://github.com/cms-sw/cmssw/pull/14756","diff_url":"https://github.com/cms-sw/cmssw/pull/14756.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14756.patch"},"body":"Testing #14713 revealed an issue with `CaloTowerHardcodeGeometryLoader`. This was fixed by modifying the definition of `CaloTowerTopology::lastHERing_` for correct handling of the case where HE is skipped (currently, no CaloTowers are desired for the Phase2 endcap with HGCal). I also switched to using `std::vector::at()` in `CaloTowerHardcodeGeometryLoader` to make the proximate cause of the issue more visible in case something similar pops up in the future, and added a bunch of debug statements behind a preprocessor flag.\r\n\r\nI noticed that some of the changes in #14713 messed up the dense indexing for CaloTowers, because the CaloTower ieta was not continuous. This is fixed now, even though it leads to the somewhat strange convention of Phase2 HF CaloTowers starting at ieta=17.\r\n\r\nNB: To test Phase2 workflows (I used 11000.0) in the latest IB, #14755 is also needed.\r\n\r\nattn: @bsunanda"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/224492098","html_url":"https://github.com/cms-sw/cmssw/pull/14756#issuecomment-224492098","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14756","id":224492098,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T05:31:42Z","updated_at":"2016-06-08T05:31:42Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/14786\t656037d\r\n- reco code change is minimal: commented out lines were removed in RecoJets/Configuration/python/CaloTowersES_cfi.py \r\n- jenkins tests pass and comparisons with baseline show no differences\r\n- in CMSSW_8_1_X_2016-06-07-1100 10600.0 (2023 GReco wflow) now runs"}}
{"actor":{"display_login":"slava77"}}