{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1824","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1824/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1824/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1824/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1824","id":188272863,"number":1824,"title":"Fix EZP-26554: download filename fallback must be ASCII in Content-Disposition","user":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-09T15:20:14Z","updated_at":"2016-11-11T08:50:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1824","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1824","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1824.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1824.patch"},"body":"JIRA: https://jira.ez.no/browse/EZP-26554\r\n\r\nUsing a non-ascii filename will result in an exception, as Symfony's `ResponseHeaderBag` checks the value but  does not automatically convert it.\r\n\r\nThis means that the `setContentDisposition()` function must perform this conversion, at least if no fallbakc is provided, according to the doc:\r\n\r\n\r\n> * @ param string $filenameFallback A fallback filename, containing only ASCII characters. Defaults to an automatically encoded filename\r\n"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/259910274","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1824#issuecomment-259910274","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1824","id":259910274,"user":{"login":"glye","id":289744,"avatar_url":"https://avatars.githubusercontent.com/u/289744?v=3","gravatar_id":"","url":"https://api.github.com/users/glye","html_url":"https://github.com/glye","followers_url":"https://api.github.com/users/glye/followers","following_url":"https://api.github.com/users/glye/following{/other_user}","gists_url":"https://api.github.com/users/glye/gists{/gist_id}","starred_url":"https://api.github.com/users/glye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glye/subscriptions","organizations_url":"https://api.github.com/users/glye/orgs","repos_url":"https://api.github.com/users/glye/repos","events_url":"https://api.github.com/users/glye/events{/privacy}","received_events_url":"https://api.github.com/users/glye/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T08:50:10Z","updated_at":"2016-11-11T08:50:10Z","body":"What happens if the filename contains only non-ascii chars?\r\n`mb_convert_encoding('æøå.æøå', 'ASCII')` yields `???.???`, will that download work?"}}
{"actor":{"display_login":"glye"}}