{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/57311966","id":57311966,"diff_hunk":"@@ -4,12 +4,31 @@ class ServiceOrder < ActiveRecord::Base\n   has_many :miq_requests, :dependent => :nullify\n \n   validates :state, :inclusion => {:in => %w(wish cart ordered)}\n-  validates :name, :presence => true\n   validates :state, :presence => true\n+  validates :name, :presence => true, :on => :update\n \n-  before_create :assign_user_name\n+  before_create :assign_user_name, :assign_tenant","path":"app/models/service_order.rb","position":9,"original_position":9,"commit_id":"849a7d7fb28b2d225ad48bf0ef7f76b2cd022455","original_commit_id":"849a7d7fb28b2d225ad48bf0ef7f76b2cd022455","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"@tinaafitz The tests are failing because the user does not get passed through, but they are setting `User.current_user/User.current_tenant` which we can reference here.\r\n\r\nI am thinking we change `assign_user_name` to `assign_user` and have it populate `user` and `tenant` for the service order if user is not provided along with setting the user_name field.\r\n\r\nSomething like this:\r\n```ruby\r\ndef assign_user\r\n  self.user ||= begin\r\n    self.tenant = User.current_tenant\r\n    User.current_user\r\n  end\r\n  self.user_name = user.try(:name)\r\nend\r\n```","created_at":"2016-03-24T12:56:24Z","updated_at":"2016-03-24T12:56:24Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7247#discussion_r57311966","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/57311966"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7247#discussion_r57311966"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247","id":62602539,"html_url":"https://github.com/ManageIQ/manageiq/pull/7247","diff_url":"https://github.com/ManageIQ/manageiq/pull/7247.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7247.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7247","number":7247,"state":"open","locked":false,"title":"[WIP] Added service_order processing for service requests.","user":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"body":"Initially, create_service_order when service miq_request is created, and checkout immediately following. New miq_request column \"process\" set to false for request and checkout changes it to true.\r\nAdd tests and migration.\r\nAdded assertion in the automate model to stop an miq_request from processing while it is is still in a\r\nprocess=false state(cart).","created_at":"2016-03-11T21:06:24Z","updated_at":"2016-03-24T12:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e1d44c36d9abb8abfc94e83758a4717f8ec9a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7247/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/849a7d7fb28b2d225ad48bf0ef7f76b2cd022455","head":{"label":"tinaafitz:service_request_cart","ref":"service_request_cart","sha":"849a7d7fb28b2d225ad48bf0ef7f76b2cd022455","user":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"repo":{"id":20941192,"name":"manageiq","full_name":"tinaafitz/manageiq","owner":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinaafitz/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/tinaafitz/manageiq","forks_url":"https://api.github.com/repos/tinaafitz/manageiq/forks","keys_url":"https://api.github.com/repos/tinaafitz/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinaafitz/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinaafitz/manageiq/teams","hooks_url":"https://api.github.com/repos/tinaafitz/manageiq/hooks","issue_events_url":"https://api.github.com/repos/tinaafitz/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/tinaafitz/manageiq/events","assignees_url":"https://api.github.com/repos/tinaafitz/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/tinaafitz/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/tinaafitz/manageiq/tags","blobs_url":"https://api.github.com/repos/tinaafitz/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinaafitz/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinaafitz/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinaafitz/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinaafitz/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/tinaafitz/manageiq/languages","stargazers_url":"https://api.github.com/repos/tinaafitz/manageiq/stargazers","contributors_url":"https://api.github.com/repos/tinaafitz/manageiq/contributors","subscribers_url":"https://api.github.com/repos/tinaafitz/manageiq/subscribers","subscription_url":"https://api.github.com/repos/tinaafitz/manageiq/subscription","commits_url":"https://api.github.com/repos/tinaafitz/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinaafitz/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinaafitz/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinaafitz/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinaafitz/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/tinaafitz/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinaafitz/manageiq/merges","archive_url":"https://api.github.com/repos/tinaafitz/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinaafitz/manageiq/downloads","issues_url":"https://api.github.com/repos/tinaafitz/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/tinaafitz/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/tinaafitz/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/tinaafitz/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinaafitz/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/tinaafitz/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/tinaafitz/manageiq/deployments","created_at":"2014-06-17T22:10:42Z","updated_at":"2014-06-23T14:25:51Z","pushed_at":"2016-03-23T20:01:48Z","git_url":"git://github.com/tinaafitz/manageiq.git","ssh_url":"git@github.com:tinaafitz/manageiq.git","clone_url":"https://github.com/tinaafitz/manageiq.git","svn_url":"https://github.com/tinaafitz/manageiq","homepage":null,"size":111397,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"85ed45eef4f015ffd69f3e1f558a38b20a5405f3","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-03-19T13:38:08Z","pushed_at":"2016-03-24T12:53:56Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":149844,"stargazers_count":239,"watchers_count":239,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":620,"forks":262,"open_issues":620,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7247"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7247"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7247/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7247/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/849a7d7fb28b2d225ad48bf0ef7f76b2cd022455"}}}}