{"action":"created","issue":{"url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/37","repository_url":"https://api.github.com/repos/meh/rust-ffmpeg-sys","labels_url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/37/comments","events_url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/37/events","html_url":"https://github.com/meh/rust-ffmpeg-sys/pull/37","id":193049453,"number":37,"title":"Support macos","user":{"login":"trlim","id":2832379,"avatar_url":"https://avatars.githubusercontent.com/u/2832379?v=3","gravatar_id":"","url":"https://api.github.com/users/trlim","html_url":"https://github.com/trlim","followers_url":"https://api.github.com/users/trlim/followers","following_url":"https://api.github.com/users/trlim/following{/other_user}","gists_url":"https://api.github.com/users/trlim/gists{/gist_id}","starred_url":"https://api.github.com/users/trlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trlim/subscriptions","organizations_url":"https://api.github.com/users/trlim/orgs","repos_url":"https://api.github.com/users/trlim/repos","events_url":"https://api.github.com/users/trlim/events{/privacy}","received_events_url":"https://api.github.com/users/trlim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-02T07:11:05Z","updated_at":"2016-12-04T00:48:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/pulls/37","html_url":"https://github.com/meh/rust-ffmpeg-sys/pull/37","diff_url":"https://github.com/meh/rust-ffmpeg-sys/pull/37.diff","patch_url":"https://github.com/meh/rust-ffmpeg-sys/pull/37.patch"},"body":"This PR enables building for macos and some additional features which will be also helpful for other targets.\r\n\r\n* uses `gcc` crate to detect proper compiler for a target\r\n* uses `pkg-config` by default to find preinstalled ffmpeg library when you are not building from source.\r\n  This helps to detect brew installed library on macos.\r\n* By setting `FFMPEG_DIR` environment variable, user can bypass `pkg-config` and override library path.\r\n* User can also select dynamic vs static linking with `static` feature flag.\r\n* But if you force building from source code, none of above applies except detecting `gcc` and works as before.\r\n\r\nI also tried to make travis pass on macos but it still fails at `cargo test` step because there is an issue in current implementation of tests.\r\n"},"comment":{"url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/comments/264676194","html_url":"https://github.com/meh/rust-ffmpeg-sys/pull/37#issuecomment-264676194","issue_url":"https://api.github.com/repos/meh/rust-ffmpeg-sys/issues/37","id":264676194,"user":{"login":"trlim","id":2832379,"avatar_url":"https://avatars.githubusercontent.com/u/2832379?v=3","gravatar_id":"","url":"https://api.github.com/users/trlim","html_url":"https://github.com/trlim","followers_url":"https://api.github.com/users/trlim/followers","following_url":"https://api.github.com/users/trlim/following{/other_user}","gists_url":"https://api.github.com/users/trlim/gists{/gist_id}","starred_url":"https://api.github.com/users/trlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trlim/subscriptions","organizations_url":"https://api.github.com/users/trlim/orgs","repos_url":"https://api.github.com/users/trlim/repos","events_url":"https://api.github.com/users/trlim/events{/privacy}","received_events_url":"https://api.github.com/users/trlim/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T00:48:23Z","updated_at":"2016-12-04T00:48:23Z","body":"Ir's good for merge.\n\n2016. 12. 4. 오전 2:40 meh. <notifications@github.com> 작성:\n\n> Looks good, is it ready for merge or do you need to change anything else?\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"trlim"}}