{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/fili/pulls/comments/78810991","id":78810991,"diff_hunk":"@@ -0,0 +1,211 @@\n+package com.yahoo.bard.webservice.async\n+\n+import com.yahoo.bard.webservice.application.JerseyTestBinder\n+import com.yahoo.bard.webservice.models.druid.client.impl.TestDruidWebService\n+import com.yahoo.bard.webservice.table.availability.AvailabilityTestingUtils\n+import com.yahoo.bard.webservice.web.endpoints.BaseDataServletComponentSpec\n+import com.yahoo.bard.webservice.web.endpoints.DataServlet\n+import com.yahoo.bard.webservice.web.endpoints.JobsServlet\n+\n+import com.fasterxml.jackson.databind.ObjectMapper\n+import com.fasterxml.jackson.datatype.jdk8.Jdk8Module\n+\n+import org.joda.time.Interval\n+\n+import spock.lang.Specification\n+import spock.lang.Timeout\n+\n+import javax.validation.constraints.NotNull\n+import javax.ws.rs.core.Response\n+\n+","path":"fili-core/src/test/groovy/com/yahoo/bard/webservice/async/AsyncFunctionalSpec.groovy","position":21,"original_position":21,"commit_id":"e03ce89537fd9231c9ecd1d57d5b9d5c16178b73","original_commit_id":"e03ce89537fd9231c9ecd1d57d5b9d5c16178b73","user":{"login":"cdeszaq","id":612084,"avatar_url":"https://avatars.githubusercontent.com/u/612084?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeszaq","html_url":"https://github.com/cdeszaq","followers_url":"https://api.github.com/users/cdeszaq/followers","following_url":"https://api.github.com/users/cdeszaq/following{/other_user}","gists_url":"https://api.github.com/users/cdeszaq/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeszaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeszaq/subscriptions","organizations_url":"https://api.github.com/users/cdeszaq/orgs","repos_url":"https://api.github.com/users/cdeszaq/repos","events_url":"https://api.github.com/users/cdeszaq/events{/privacy}","received_events_url":"https://api.github.com/users/cdeszaq/received_events","type":"User","site_admin":false},"body":"Extra space not needed","created_at":"2016-09-14T18:44:55Z","updated_at":"2016-09-14T18:44:55Z","html_url":"https://github.com/yahoo/fili/pull/35#discussion_r78810991","pull_request_url":"https://api.github.com/repos/yahoo/fili/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments/78810991"},"html":{"href":"https://github.com/yahoo/fili/pull/35#discussion_r78810991"},"pull_request":{"href":"https://api.github.com/repos/yahoo/fili/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/fili/pulls/35","id":84502337,"html_url":"https://github.com/yahoo/fili/pull/35","diff_url":"https://github.com/yahoo/fili/pull/35.diff","patch_url":"https://github.com/yahoo/fili/pull/35.patch","issue_url":"https://api.github.com/repos/yahoo/fili/issues/35","number":35,"state":"open","locked":false,"title":"Async functional tests","user":{"login":"archolewa","id":11720815,"avatar_url":"https://avatars.githubusercontent.com/u/11720815?v=3","gravatar_id":"","url":"https://api.github.com/users/archolewa","html_url":"https://github.com/archolewa","followers_url":"https://api.github.com/users/archolewa/followers","following_url":"https://api.github.com/users/archolewa/following{/other_user}","gists_url":"https://api.github.com/users/archolewa/gists{/gist_id}","starred_url":"https://api.github.com/users/archolewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archolewa/subscriptions","organizations_url":"https://api.github.com/users/archolewa/orgs","repos_url":"https://api.github.com/users/archolewa/repos","events_url":"https://api.github.com/users/archolewa/events{/privacy}","received_events_url":"https://api.github.com/users/archolewa/received_events","type":"User","site_admin":false},"body":"Adds the functional tests for asynchronous queries.\r\n\r\nIn order to support this, I had to slightly modify the TestDruidServlet to have a `Producer<String>` that generates a fake Druid response on demand, rather than having the Druid response directly. This was needed to support delaying the Druid response, so that we could test the path where results aren't yet ready from the backend.\r\n\r\nThe base spec for the asynchronous queries is rather complex, and I still don't think I explained it well. Suggestions on improving the documentation for that test are especially welcome.\r\n","created_at":"2016-09-08T15:40:16Z","updated_at":"2016-09-14T18:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900dcb0ac408100bc9930e970d1bdc4237229263","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fili/pulls/35/commits","review_comments_url":"https://api.github.com/repos/yahoo/fili/pulls/35/comments","review_comment_url":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fili/issues/35/comments","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/e03ce89537fd9231c9ecd1d57d5b9d5c16178b73","head":{"label":"yahoo:async-functional-tests","ref":"async-functional-tests","sha":"e03ce89537fd9231c9ecd1d57d5b9d5c16178b73","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2016-09-09T01:06:19Z","pushed_at":"2016-09-14T18:46:57Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":null,"size":1212,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":11,"forks":6,"open_issues":11,"watchers":10,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"51348b203d646cc966b29f1a70634c52aade148b","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2016-09-09T01:06:19Z","pushed_at":"2016-09-14T18:46:57Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":null,"size":1212,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":11,"forks":6,"open_issues":11,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/35"},"html":{"href":"https://github.com/yahoo/fili/pull/35"},"issue":{"href":"https://api.github.com/repos/yahoo/fili/issues/35"},"comments":{"href":"https://api.github.com/repos/yahoo/fili/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fili/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fili/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fili/statuses/e03ce89537fd9231c9ecd1d57d5b9d5c16178b73"}}}}
{"actor":{"display_login":"cdeszaq"}}