{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7068","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7068/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7068/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7068/events","html_url":"https://github.com/nodejs/node/pull/7068","id":157541684,"number":7068,"title":"fs: execute mkdtemp's callback with no context","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-05-30T18:19:59Z","updated_at":"2016-07-12T16:48:00Z","closed_at":"2016-06-04T11:03:11Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7068","html_url":"https://github.com/nodejs/node/pull/7068","diff_url":"https://github.com/nodejs/node/pull/7068.diff","patch_url":"https://github.com/nodejs/node/pull/7068.patch"},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nfs\r\n\r\n##### Description of change\r\n\r\nAll the callback functions in `fs` module are supposed to be executed\r\nwith no context (`this` value should not be a valid object). But\r\n`mkdtemp`'s callback will have the `FSReqWrap` object as the context.\r\n\r\nSample code to reproduce the problem\r\n\r\n    'use strict';\r\n\r\n    const fs = require('fs');\r\n    fs.mkdtemp('/tmp/abcd', null, function() {\r\n      console.log(this);\r\n    });\r\n\r\nThis would print\r\n\r\n    FSReqWrap { oncomplete: [Function] }\r\n\r\nBut that should have printed `null` and this patch fixes that.\r\n\r\ncc @nodejs/fs \r\n\r\n-----\r\n\r\nCI Run: https://ci.nodejs.org/job/node-test-pull-request/2865/"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/232106142","html_url":"https://github.com/nodejs/node/pull/7068#issuecomment-232106142","issue_url":"https://api.github.com/repos/nodejs/node/issues/7068","id":232106142,"user":{"login":"TheAlphaNerd","id":498775,"avatar_url":"https://avatars.githubusercontent.com/u/498775?v=3","gravatar_id":"","url":"https://api.github.com/users/TheAlphaNerd","html_url":"https://github.com/TheAlphaNerd","followers_url":"https://api.github.com/users/TheAlphaNerd/followers","following_url":"https://api.github.com/users/TheAlphaNerd/following{/other_user}","gists_url":"https://api.github.com/users/TheAlphaNerd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlphaNerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlphaNerd/subscriptions","organizations_url":"https://api.github.com/users/TheAlphaNerd/orgs","repos_url":"https://api.github.com/users/TheAlphaNerd/repos","events_url":"https://api.github.com/users/TheAlphaNerd/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlphaNerd/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T16:48:00Z","updated_at":"2016-07-12T16:48:00Z","body":"marking as don't land as the other mentioned pr's are as well. Please feel free to revisit as a backport PR if you think it is necessary for LTS stability"}}
{"actor":{"display_login":"TheAlphaNerd"}}