{"action":"created","issue":{"url":"https://api.github.com/repos/nengo/nengo/issues/998","repository_url":"https://api.github.com/repos/nengo/nengo","labels_url":"https://api.github.com/repos/nengo/nengo/issues/998/labels{/name}","comments_url":"https://api.github.com/repos/nengo/nengo/issues/998/comments","events_url":"https://api.github.com/repos/nengo/nengo/issues/998/events","html_url":"https://github.com/nengo/nengo/pull/998","id":144006432,"number":998,"title":"Learning rule error size is connection size out","user":{"login":"hunse","id":1952250,"avatar_url":"https://avatars.githubusercontent.com/u/1952250?v=3","gravatar_id":"","url":"https://api.github.com/users/hunse","html_url":"https://github.com/hunse","followers_url":"https://api.github.com/users/hunse/followers","following_url":"https://api.github.com/users/hunse/following{/other_user}","gists_url":"https://api.github.com/users/hunse/gists{/gist_id}","starred_url":"https://api.github.com/users/hunse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunse/subscriptions","organizations_url":"https://api.github.com/users/hunse/orgs","repos_url":"https://api.github.com/users/hunse/repos","events_url":"https://api.github.com/users/hunse/events{/privacy}","received_events_url":"https://api.github.com/users/hunse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nengo/nengo/labels/needs%20review","name":"needs review","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nengo/nengo/milestones/6","html_url":"https://github.com/nengo/nengo/milestones/2.1.0%20release","labels_url":"https://api.github.com/repos/nengo/nengo/milestones/6/labels","id":747893,"number":6,"title":"2.1.0 release","description":"","creator":{"login":"tbekolay","id":203709,"avatar_url":"https://avatars.githubusercontent.com/u/203709?v=3","gravatar_id":"","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":139,"state":"open","created_at":"2014-08-08T17:42:35Z","updated_at":"2016-03-28T19:12:06Z","due_on":"2016-03-29T04:00:00Z","closed_at":null},"comments":5,"created_at":"2016-03-28T15:39:03Z","updated_at":"2016-03-28T22:15:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nengo/nengo/pulls/998","html_url":"https://github.com/nengo/nengo/pull/998","diff_url":"https://github.com/nengo/nengo/pull/998.diff","patch_url":"https://github.com/nengo/nengo/pull/998.patch"},"body":"As discussed in #957, our error signal should always be in the\r\ndimensionality of the transform output. This fixes the learning\r\nrule error size to adhere to that.\r\n\r\nEven though this removes a ValidationError, we're already checking that the pre object is an Ensemble or Neurons in ConnectionLearningRuleTypeParam above, so I think we're fine."},"comment":{"url":"https://api.github.com/repos/nengo/nengo/issues/comments/202601510","html_url":"https://github.com/nengo/nengo/pull/998#issuecomment-202601510","issue_url":"https://api.github.com/repos/nengo/nengo/issues/998","id":202601510,"user":{"login":"arvoelke","id":5420057,"avatar_url":"https://avatars.githubusercontent.com/u/5420057?v=3","gravatar_id":"","url":"https://api.github.com/users/arvoelke","html_url":"https://github.com/arvoelke","followers_url":"https://api.github.com/users/arvoelke/followers","following_url":"https://api.github.com/users/arvoelke/following{/other_user}","gists_url":"https://api.github.com/users/arvoelke/gists{/gist_id}","starred_url":"https://api.github.com/users/arvoelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvoelke/subscriptions","organizations_url":"https://api.github.com/users/arvoelke/orgs","repos_url":"https://api.github.com/users/arvoelke/repos","events_url":"https://api.github.com/users/arvoelke/events{/privacy}","received_events_url":"https://api.github.com/users/arvoelke/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T22:15:35Z","updated_at":"2016-03-28T22:15:35Z","body":"With fixes like this I think it's essential to add a new unit test that passes with the change and fails without it. It not only helps document the fix, but ensures that no future change accidentally reverts what you've done here."}}