{"action":"created","comment":{"url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments/77122648","id":77122648,"diff_hunk":"@@ -4907,7 +4907,9 @@\n     var doc = cm.doc, x = pos.left, y;\n     if (unit == \"page\") {\n       var pageSize = Math.min(cm.display.wrapper.clientHeight, window.innerHeight || document.documentElement.clientHeight);\n-      y = pos.top + dir * (pageSize - (dir < 0 ? 1.5 : .5) * textHeight(cm.display));\n+      var moveAmount = pageSize - (dir < 0 ? 1.5 : .5) * textHeight(cm.display);\n+      moveAmount = Math.max(moveAmount, 1);","path":"lib/codemirror.js","position":6,"original_position":6,"commit_id":"9060f0622ec74d107eed52dec04a8f69b5b70c98","original_commit_id":"9060f0622ec74d107eed52dec04a8f69b5b70c98","user":{"login":"marijnh","id":144427,"avatar_url":"https://avatars.githubusercontent.com/u/144427?v=3","gravatar_id":"","url":"https://api.github.com/users/marijnh","html_url":"https://github.com/marijnh","followers_url":"https://api.github.com/users/marijnh/followers","following_url":"https://api.github.com/users/marijnh/following{/other_user}","gists_url":"https://api.github.com/users/marijnh/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnh/subscriptions","organizations_url":"https://api.github.com/users/marijnh/orgs","repos_url":"https://api.github.com/users/marijnh/repos","events_url":"https://api.github.com/users/marijnh/events{/privacy}","received_events_url":"https://api.github.com/users/marijnh/received_events","type":"User","site_admin":false},"body":"Why do you clip to 1, and not 0?","created_at":"2016-09-01T06:56:56Z","updated_at":"2016-09-01T06:56:56Z","html_url":"https://github.com/codemirror/CodeMirror/pull/4215#discussion_r77122648","pull_request_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215","_links":{"self":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments/77122648"},"html":{"href":"https://github.com/codemirror/CodeMirror/pull/4215#discussion_r77122648"},"pull_request":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215"}}},"pull_request":{"url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215","id":83551976,"html_url":"https://github.com/codemirror/CodeMirror/pull/4215","diff_url":"https://github.com/codemirror/CodeMirror/pull/4215.diff","patch_url":"https://github.com/codemirror/CodeMirror/pull/4215.patch","issue_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/4215","number":4215,"state":"open","locked":false,"title":"Always move in the right direction for PageUp/PageDown","user":{"login":"JoelEinbinder","id":4624233,"avatar_url":"https://avatars.githubusercontent.com/u/4624233?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelEinbinder","html_url":"https://github.com/JoelEinbinder","followers_url":"https://api.github.com/users/JoelEinbinder/followers","following_url":"https://api.github.com/users/JoelEinbinder/following{/other_user}","gists_url":"https://api.github.com/users/JoelEinbinder/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelEinbinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelEinbinder/subscriptions","organizations_url":"https://api.github.com/users/JoelEinbinder/orgs","repos_url":"https://api.github.com/users/JoelEinbinder/repos","events_url":"https://api.github.com/users/JoelEinbinder/events{/privacy}","received_events_url":"https://api.github.com/users/JoelEinbinder/received_events","type":"User","site_admin":false},"body":"Closes #4213","created_at":"2016-09-01T00:22:25Z","updated_at":"2016-09-01T06:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9484591263a0da6fd49bb35c4a9196e5be282e66","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215/commits","review_comments_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215/comments","review_comment_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/4215/comments","statuses_url":"https://api.github.com/repos/codemirror/CodeMirror/statuses/9060f0622ec74d107eed52dec04a8f69b5b70c98","head":{"label":"JoelEinbinder:master","ref":"master","sha":"9060f0622ec74d107eed52dec04a8f69b5b70c98","user":{"login":"JoelEinbinder","id":4624233,"avatar_url":"https://avatars.githubusercontent.com/u/4624233?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelEinbinder","html_url":"https://github.com/JoelEinbinder","followers_url":"https://api.github.com/users/JoelEinbinder/followers","following_url":"https://api.github.com/users/JoelEinbinder/following{/other_user}","gists_url":"https://api.github.com/users/JoelEinbinder/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelEinbinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelEinbinder/subscriptions","organizations_url":"https://api.github.com/users/JoelEinbinder/orgs","repos_url":"https://api.github.com/users/JoelEinbinder/repos","events_url":"https://api.github.com/users/JoelEinbinder/events{/privacy}","received_events_url":"https://api.github.com/users/JoelEinbinder/received_events","type":"User","site_admin":false},"repo":{"id":64505541,"name":"CodeMirror","full_name":"JoelEinbinder/CodeMirror","owner":{"login":"JoelEinbinder","id":4624233,"avatar_url":"https://avatars.githubusercontent.com/u/4624233?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelEinbinder","html_url":"https://github.com/JoelEinbinder","followers_url":"https://api.github.com/users/JoelEinbinder/followers","following_url":"https://api.github.com/users/JoelEinbinder/following{/other_user}","gists_url":"https://api.github.com/users/JoelEinbinder/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelEinbinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelEinbinder/subscriptions","organizations_url":"https://api.github.com/users/JoelEinbinder/orgs","repos_url":"https://api.github.com/users/JoelEinbinder/repos","events_url":"https://api.github.com/users/JoelEinbinder/events{/privacy}","received_events_url":"https://api.github.com/users/JoelEinbinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoelEinbinder/CodeMirror","description":"In-browser code editor","fork":true,"url":"https://api.github.com/repos/JoelEinbinder/CodeMirror","forks_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/forks","keys_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/teams","hooks_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/hooks","issue_events_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/issues/events{/number}","events_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/events","assignees_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/assignees{/user}","branches_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/branches{/branch}","tags_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/tags","blobs_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/statuses/{sha}","languages_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/languages","stargazers_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/stargazers","contributors_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/contributors","subscribers_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/subscribers","subscription_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/subscription","commits_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/contents/{+path}","compare_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/merges","archive_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/downloads","issues_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/issues{/number}","pulls_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/pulls{/number}","milestones_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/milestones{/number}","notifications_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/labels{/name}","releases_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/releases{/id}","deployments_url":"https://api.github.com/repos/JoelEinbinder/CodeMirror/deployments","created_at":"2016-07-29T19:29:42Z","updated_at":"2016-07-29T19:29:45Z","pushed_at":"2016-09-01T00:18:09Z","git_url":"git://github.com/JoelEinbinder/CodeMirror.git","ssh_url":"git@github.com:JoelEinbinder/CodeMirror.git","clone_url":"https://github.com/JoelEinbinder/CodeMirror.git","svn_url":"https://github.com/JoelEinbinder/CodeMirror","homepage":"http://codemirror.net/","size":12213,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codemirror:master","ref":"master","sha":"607d0e8a9fbbd0c5faa2db318937d92337b3cf53","user":{"login":"codemirror","id":8876537,"avatar_url":"https://avatars.githubusercontent.com/u/8876537?v=3","gravatar_id":"","url":"https://api.github.com/users/codemirror","html_url":"https://github.com/codemirror","followers_url":"https://api.github.com/users/codemirror/followers","following_url":"https://api.github.com/users/codemirror/following{/other_user}","gists_url":"https://api.github.com/users/codemirror/gists{/gist_id}","starred_url":"https://api.github.com/users/codemirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemirror/subscriptions","organizations_url":"https://api.github.com/users/codemirror/orgs","repos_url":"https://api.github.com/users/codemirror/repos","events_url":"https://api.github.com/users/codemirror/events{/privacy}","received_events_url":"https://api.github.com/users/codemirror/received_events","type":"Organization","site_admin":false},"repo":{"id":1254497,"name":"CodeMirror","full_name":"codemirror/CodeMirror","owner":{"login":"codemirror","id":8876537,"avatar_url":"https://avatars.githubusercontent.com/u/8876537?v=3","gravatar_id":"","url":"https://api.github.com/users/codemirror","html_url":"https://github.com/codemirror","followers_url":"https://api.github.com/users/codemirror/followers","following_url":"https://api.github.com/users/codemirror/following{/other_user}","gists_url":"https://api.github.com/users/codemirror/gists{/gist_id}","starred_url":"https://api.github.com/users/codemirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemirror/subscriptions","organizations_url":"https://api.github.com/users/codemirror/orgs","repos_url":"https://api.github.com/users/codemirror/repos","events_url":"https://api.github.com/users/codemirror/events{/privacy}","received_events_url":"https://api.github.com/users/codemirror/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codemirror/CodeMirror","description":"In-browser code editor","fork":false,"url":"https://api.github.com/repos/codemirror/CodeMirror","forks_url":"https://api.github.com/repos/codemirror/CodeMirror/forks","keys_url":"https://api.github.com/repos/codemirror/CodeMirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemirror/CodeMirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemirror/CodeMirror/teams","hooks_url":"https://api.github.com/repos/codemirror/CodeMirror/hooks","issue_events_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/events{/number}","events_url":"https://api.github.com/repos/codemirror/CodeMirror/events","assignees_url":"https://api.github.com/repos/codemirror/CodeMirror/assignees{/user}","branches_url":"https://api.github.com/repos/codemirror/CodeMirror/branches{/branch}","tags_url":"https://api.github.com/repos/codemirror/CodeMirror/tags","blobs_url":"https://api.github.com/repos/codemirror/CodeMirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemirror/CodeMirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemirror/CodeMirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemirror/CodeMirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemirror/CodeMirror/statuses/{sha}","languages_url":"https://api.github.com/repos/codemirror/CodeMirror/languages","stargazers_url":"https://api.github.com/repos/codemirror/CodeMirror/stargazers","contributors_url":"https://api.github.com/repos/codemirror/CodeMirror/contributors","subscribers_url":"https://api.github.com/repos/codemirror/CodeMirror/subscribers","subscription_url":"https://api.github.com/repos/codemirror/CodeMirror/subscription","commits_url":"https://api.github.com/repos/codemirror/CodeMirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemirror/CodeMirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemirror/CodeMirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemirror/CodeMirror/contents/{+path}","compare_url":"https://api.github.com/repos/codemirror/CodeMirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemirror/CodeMirror/merges","archive_url":"https://api.github.com/repos/codemirror/CodeMirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemirror/CodeMirror/downloads","issues_url":"https://api.github.com/repos/codemirror/CodeMirror/issues{/number}","pulls_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls{/number}","milestones_url":"https://api.github.com/repos/codemirror/CodeMirror/milestones{/number}","notifications_url":"https://api.github.com/repos/codemirror/CodeMirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemirror/CodeMirror/labels{/name}","releases_url":"https://api.github.com/repos/codemirror/CodeMirror/releases{/id}","deployments_url":"https://api.github.com/repos/codemirror/CodeMirror/deployments","created_at":"2011-01-14T13:44:03Z","updated_at":"2016-09-01T06:11:15Z","pushed_at":"2016-09-01T00:22:25Z","git_url":"git://github.com/codemirror/CodeMirror.git","ssh_url":"git@github.com:codemirror/CodeMirror.git","clone_url":"https://github.com/codemirror/CodeMirror.git","svn_url":"https://github.com/codemirror/CodeMirror","homepage":"http://codemirror.net/","size":25979,"stargazers_count":9796,"watchers_count":9796,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2489,"mirror_url":null,"open_issues_count":154,"forks":2489,"open_issues":154,"watchers":9796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215"},"html":{"href":"https://github.com/codemirror/CodeMirror/pull/4215"},"issue":{"href":"https://api.github.com/repos/codemirror/CodeMirror/issues/4215"},"comments":{"href":"https://api.github.com/repos/codemirror/CodeMirror/issues/4215/comments"},"review_comments":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215/comments"},"review_comment":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/4215/commits"},"statuses":{"href":"https://api.github.com/repos/codemirror/CodeMirror/statuses/9060f0622ec74d107eed52dec04a8f69b5b70c98"}}}}
{"actor":{"display_login":"marijnh"}}