{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/85643090","pull_request_review_id":6349847,"id":85643090,"diff_hunk":"@@ -53,8 +52,7 @@ modularResolver sc (Platform arch os) cinfo iidx sidx pkgConfigDB pprefs pcs pns\n       -- Results have to be converted into an install plan. 'convCP' removes\n       -- package qualifiers, which means that linked packages become duplicates\n       -- and can be removed.\n-      -- TODO: Use ordNubBy instead of nubBy.\n-      postprocess a rdm = nubBy ((==) `on` nodeKey) $\n+      postprocess a rdm = ordNubBy nodeKey $","path":"cabal-install/Distribution/Solver/Modular.hs","position":27,"original_position":27,"commit_id":"aed18972f204abbb2af1ff69c158db1afe773b38","original_commit_id":"aed18972f204abbb2af1ff69c158db1afe773b38","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2016-10-29T15:59:34Z","updated_at":"2016-10-29T15:59:34Z","html_url":"https://github.com/haskell/cabal/pull/4053#discussion_r85643090","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/4053","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/85643090"},"html":{"href":"https://github.com/haskell/cabal/pull/4053#discussion_r85643090"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4053"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/4053","id":91465278,"html_url":"https://github.com/haskell/cabal/pull/4053","diff_url":"https://github.com/haskell/cabal/pull/4053.diff","patch_url":"https://github.com/haskell/cabal/pull/4053.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/4053","number":4053,"state":"open","locked":false,"title":"Graph duplicate checks","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"body":"This is a continuation and update of #4027 (which got closed automatically for some reason).\r\n\r\nChange Graph.fromList to fromDistinctList and fix consequences.\r\n\r\nIt's really an error to try and build a graph where you have duplicate node keys, so remove Graph.fromList and add Graph.fromDistinctList. This check is always on, not just an assertion, becuase we get it for free given the way Maps can be constructed.\r\n\r\nAll uses of Graph.fromList are now ok to convert to fromDistinctList, since #4038 and #4039 were merged.","created_at":"2016-10-28T22:55:57Z","updated_at":"2016-10-29T15:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f10c17efae57255e756305dfc9ae25b7b0b6ae29","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/4053/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/4053/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/4053/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/aed18972f204abbb2af1ff69c158db1afe773b38","head":{"label":"dcoutts:graph-dupe-checks","ref":"graph-dupe-checks","sha":"aed18972f204abbb2af1ff69c158db1afe773b38","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"repo":{"id":10475196,"name":"cabal","full_name":"dcoutts/cabal","owner":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcoutts/cabal","description":"Duncan's random Cabal hacking","fork":true,"url":"https://api.github.com/repos/dcoutts/cabal","forks_url":"https://api.github.com/repos/dcoutts/cabal/forks","keys_url":"https://api.github.com/repos/dcoutts/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcoutts/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcoutts/cabal/teams","hooks_url":"https://api.github.com/repos/dcoutts/cabal/hooks","issue_events_url":"https://api.github.com/repos/dcoutts/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/dcoutts/cabal/events","assignees_url":"https://api.github.com/repos/dcoutts/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/dcoutts/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/dcoutts/cabal/tags","blobs_url":"https://api.github.com/repos/dcoutts/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcoutts/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcoutts/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcoutts/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcoutts/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/dcoutts/cabal/languages","stargazers_url":"https://api.github.com/repos/dcoutts/cabal/stargazers","contributors_url":"https://api.github.com/repos/dcoutts/cabal/contributors","subscribers_url":"https://api.github.com/repos/dcoutts/cabal/subscribers","subscription_url":"https://api.github.com/repos/dcoutts/cabal/subscription","commits_url":"https://api.github.com/repos/dcoutts/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcoutts/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcoutts/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcoutts/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcoutts/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/dcoutts/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcoutts/cabal/merges","archive_url":"https://api.github.com/repos/dcoutts/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcoutts/cabal/downloads","issues_url":"https://api.github.com/repos/dcoutts/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/dcoutts/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/dcoutts/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/dcoutts/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcoutts/cabal/labels{/name}","releases_url":"https://api.github.com/repos/dcoutts/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/dcoutts/cabal/deployments","created_at":"2013-06-04T09:31:49Z","updated_at":"2015-04-28T14:55:48Z","pushed_at":"2016-10-28T22:53:21Z","git_url":"git://github.com/dcoutts/cabal.git","ssh_url":"git@github.com:dcoutts/cabal.git","clone_url":"https://github.com/dcoutts/cabal.git","svn_url":"https://github.com/dcoutts/cabal","homepage":"http://haskell.org/cabal","size":29471,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"32d2395c10f9dfe50b7abe49d99e71e3273e7382","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-10-27T10:31:42Z","pushed_at":"2016-10-29T09:05:33Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":34247,"stargazers_count":656,"watchers_count":656,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":757,"forks":355,"open_issues":757,"watchers":656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4053"},"html":{"href":"https://github.com/haskell/cabal/pull/4053"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/4053"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/4053/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4053/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4053/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/aed18972f204abbb2af1ff69c158db1afe773b38"}}}}
{"actor":{"display_login":"grayjay"}}