{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/90183815","pull_request_review_id":10704110,"id":90183815,"diff_hunk":"@@ -59,3 +62,14 @@ func main() {\n \n \tfmt.Println(server.Serve(*listen))\n }\n+\n+func getStreamingConfig() *streaming.Config {\n+\tconfig := &streaming.Config{\n+\t\tAddr:                  \"localhost:\" + *streamingServerPort,","path":"cmd/frakti/frakti.go","position":33,"original_position":33,"commit_id":"63fb51596cbfb88b4f8822d78a5b11aab5fb8302","original_commit_id":"a9386e67f9854ca94e9364e05e0aa8e9d6f6d5d7","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"Should make it configurable, so users could set the address same with kubelet.","created_at":"2016-11-30T08:01:47Z","updated_at":"2016-11-30T08:02:25Z","html_url":"https://github.com/kubernetes/frakti/pull/49#discussion_r90183815","pull_request_url":"https://api.github.com/repos/kubernetes/frakti/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/90183815"},"html":{"href":"https://github.com/kubernetes/frakti/pull/49#discussion_r90183815"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/49","id":95266178,"html_url":"https://github.com/kubernetes/frakti/pull/49","diff_url":"https://github.com/kubernetes/frakti/pull/49.diff","patch_url":"https://github.com/kubernetes/frakti/pull/49.patch","issue_url":"https://api.github.com/repos/kubernetes/frakti/issues/49","number":49,"state":"open","locked":false,"title":"Implement exec/attach api","user":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"body":"part of #41 \r\n\r\n- [x] add streaming server support\r\n- [x] add releated hyper client\r\n- [x] implement exec api\r\n- [x] implement attach api\r\n- [x] add some test case in e2e\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/frakti/49)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-11-25T08:33:07Z","updated_at":"2016-11-30T08:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e2fd1a22fa46a75e8b4b293895716779e9623c2","assignee":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/frakti/pulls/49/commits","review_comments_url":"https://api.github.com/repos/kubernetes/frakti/pulls/49/comments","review_comment_url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/frakti/issues/49/comments","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/63fb51596cbfb88b4f8822d78a5b11aab5fb8302","head":{"label":"Crazykev:implement-exec-api","ref":"implement-exec-api","sha":"63fb51596cbfb88b4f8822d78a5b11aab5fb8302","user":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"repo":{"id":66491571,"name":"frakti","full_name":"Crazykev/frakti","owner":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crazykev/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":true,"url":"https://api.github.com/repos/Crazykev/frakti","forks_url":"https://api.github.com/repos/Crazykev/frakti/forks","keys_url":"https://api.github.com/repos/Crazykev/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crazykev/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crazykev/frakti/teams","hooks_url":"https://api.github.com/repos/Crazykev/frakti/hooks","issue_events_url":"https://api.github.com/repos/Crazykev/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/Crazykev/frakti/events","assignees_url":"https://api.github.com/repos/Crazykev/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/Crazykev/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/Crazykev/frakti/tags","blobs_url":"https://api.github.com/repos/Crazykev/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crazykev/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crazykev/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crazykev/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crazykev/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/Crazykev/frakti/languages","stargazers_url":"https://api.github.com/repos/Crazykev/frakti/stargazers","contributors_url":"https://api.github.com/repos/Crazykev/frakti/contributors","subscribers_url":"https://api.github.com/repos/Crazykev/frakti/subscribers","subscription_url":"https://api.github.com/repos/Crazykev/frakti/subscription","commits_url":"https://api.github.com/repos/Crazykev/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crazykev/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crazykev/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crazykev/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crazykev/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/Crazykev/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crazykev/frakti/merges","archive_url":"https://api.github.com/repos/Crazykev/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crazykev/frakti/downloads","issues_url":"https://api.github.com/repos/Crazykev/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/Crazykev/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/Crazykev/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/Crazykev/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crazykev/frakti/labels{/name}","releases_url":"https://api.github.com/repos/Crazykev/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/Crazykev/frakti/deployments","created_at":"2016-08-24T19:02:15Z","updated_at":"2016-08-24T19:02:18Z","pushed_at":"2016-11-28T08:39:26Z","git_url":"git://github.com/Crazykev/frakti.git","ssh_url":"git@github.com:Crazykev/frakti.git","clone_url":"https://github.com/Crazykev/frakti.git","svn_url":"https://github.com/Crazykev/frakti","homepage":"","size":3082,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3e763b2d7803920ca50061f9d9da34ab2de442a0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62069434,"name":"frakti","full_name":"kubernetes/frakti","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubernetes/frakti","forks_url":"https://api.github.com/repos/kubernetes/frakti/forks","keys_url":"https://api.github.com/repos/kubernetes/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/frakti/teams","hooks_url":"https://api.github.com/repos/kubernetes/frakti/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/frakti/events","assignees_url":"https://api.github.com/repos/kubernetes/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/frakti/tags","blobs_url":"https://api.github.com/repos/kubernetes/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/frakti/languages","stargazers_url":"https://api.github.com/repos/kubernetes/frakti/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/frakti/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/frakti/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/frakti/subscription","commits_url":"https://api.github.com/repos/kubernetes/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/frakti/merges","archive_url":"https://api.github.com/repos/kubernetes/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/frakti/downloads","issues_url":"https://api.github.com/repos/kubernetes/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/frakti/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/frakti/deployments","created_at":"2016-06-27T16:04:23Z","updated_at":"2016-11-27T04:25:07Z","pushed_at":"2016-11-28T08:39:33Z","git_url":"git://github.com/kubernetes/frakti.git","ssh_url":"git@github.com:kubernetes/frakti.git","clone_url":"https://github.com/kubernetes/frakti.git","svn_url":"https://github.com/kubernetes/frakti","homepage":"","size":3115,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/49"},"html":{"href":"https://github.com/kubernetes/frakti/pull/49"},"issue":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/49"},"comments":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/frakti/statuses/63fb51596cbfb88b4f8822d78a5b11aab5fb8302"}}}}
{"actor":{"display_login":"feiskyer"}}