{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2356","repository_url":"https://api.github.com/repos/MovingBlocks/Terasology","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2356/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2356/comments","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2356/events","html_url":"https://github.com/MovingBlocks/Terasology/pull/2356","id":160332056,"number":2356,"title":"Major change to DelayedActionSystem.","user":{"login":"xrtariq2594","id":8609763,"avatar_url":"https://avatars.githubusercontent.com/u/8609763?v=3","gravatar_id":"","url":"https://api.github.com/users/xrtariq2594","html_url":"https://github.com/xrtariq2594","followers_url":"https://api.github.com/users/xrtariq2594/followers","following_url":"https://api.github.com/users/xrtariq2594/following{/other_user}","gists_url":"https://api.github.com/users/xrtariq2594/gists{/gist_id}","starred_url":"https://api.github.com/users/xrtariq2594/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrtariq2594/subscriptions","organizations_url":"https://api.github.com/users/xrtariq2594/orgs","repos_url":"https://api.github.com/users/xrtariq2594/repos","events_url":"https://api.github.com/users/xrtariq2594/events{/privacy}","received_events_url":"https://api.github.com/users/xrtariq2594/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/Architecture","name":"Architecture","color":"A13027"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-15T03:39:50Z","updated_at":"2016-06-25T23:54:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2356","html_url":"https://github.com/MovingBlocks/Terasology/pull/2356","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2356.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2356.patch"},"body":"### Contains\r\n\r\nMinor yet important alteration to how the delayedActionComponent and PeriodicActionComponent are checked in the addDelayedAction and addPeriodicAction methods. \r\n\r\nIn short, even if the old earliest operation wakeup time of the \"...OperationsSortedByTime\" is not less than the new earliest operation wakeup time, the new action should still be added to delayedOperationsSortedByTime/periodicOperationsSortedByTime. This will allow the event to be fired off when it's duration expires.\r\n\r\n### How to test\r\n\r\nCall addDelayedAction with various delay values, and see if the approraite events are sent out at the correct time. \r\n\r\n### Outstanding before merging\r\n\r\n- [x] Need to consider all uses of addDelayedAction/addPeriodicAction in the engine.\r\n- [ ] Need to consider uses of addDelayedAction/addPeriodicAction in other modules..\r\n- [ ] Need to perform unit testing."},"comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments/228576444","html_url":"https://github.com/MovingBlocks/Terasology/pull/2356#issuecomment-228576444","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2356","id":228576444,"user":{"login":"GooeyHub","id":4524000,"avatar_url":"https://avatars.githubusercontent.com/u/4524000?v=3","gravatar_id":"","url":"https://api.github.com/users/GooeyHub","html_url":"https://github.com/GooeyHub","followers_url":"https://api.github.com/users/GooeyHub/followers","following_url":"https://api.github.com/users/GooeyHub/following{/other_user}","gists_url":"https://api.github.com/users/GooeyHub/gists{/gist_id}","starred_url":"https://api.github.com/users/GooeyHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GooeyHub/subscriptions","organizations_url":"https://api.github.com/users/GooeyHub/orgs","repos_url":"https://api.github.com/users/GooeyHub/repos","events_url":"https://api.github.com/users/GooeyHub/events{/privacy}","received_events_url":"https://api.github.com/users/GooeyHub/received_events","type":"User","site_admin":false},"created_at":"2016-06-25T23:54:54Z","updated_at":"2016-06-25T23:54:54Z","body":"Hooray Jenkins reported success with all tests good!\n"}}
{"actor":{"display_login":"GooeyHub"}}