{"action":"created","comment":{"url":"https://api.github.com/repos/bebraw/pypandoc/pulls/comments/62427373","id":62427373,"diff_hunk":"@@ -112,53 +127,50 @@ pypandoc now supports easy addition of\n filters = ['pandoc-citeproc']\n pdoc_args = ['--mathjax',\n              '--smart']\n-output = pd.convert(source=filename,\n-                    to='html5',\n-                    format='md',\n-                    extra_args=pdoc_args,\n-                    filters=filters)\n+output = pd.convert_file(source=filename,\n+                         to='html5',\n+                         format='md',\n+                         extra_args=pdoc_args,\n+                         filters=filters)\n ```\n-Please pass any filters in as a list and not a string.\n+Please pass any filters in as a list and not as a string.\n \n Please refer to `pandoc -h` and the\n [official documentation](http://johnmacfarlane.net/pandoc/README.html) for further details.\n \n+Note: the old way of using `convert(input, output)` is deprecated as in some cases it wasn't\n+possible to determine whether the input should be used as a filename or as text.\n+\n ## Dealing with Formatting Arguments\n \n-Pandoc supports custom formatting though `-V` parameter. In order to use it through pypandoc, use code such as this:\n+Pandoc supports custom formatting though `-V` parameter. In order to use it through\n+pypandoc, use code such as this:\n \n ```python\n-output = pypandoc.convert('demo.md', 'pdf', outputfile='demo.pdf',\n+output = pypandoc.convert_file('demo.md', 'pdf', outputfile='demo.pdf',\n   extra_args=['-V', 'geometry:margin=1.5cm'])\n ```\n \n-Note that it's important to separate `-V` and its argument within a list like that or else it won't work. This gotcha has to do with the way `subprocess.Popen` works.\n+Note that it's important to separate `-V` and its argument within a list like that or else\n+it won't work. This gotcha has to do with the way `subprocess.Popen` works.","path":"README.md","position":132,"original_position":132,"commit_id":"35f363a3f6c4fc91eefe01a16b1037bc32664a46","original_commit_id":"35f363a3f6c4fc91eefe01a16b1037bc32664a46","user":{"login":"bebraw","id":166921,"avatar_url":"https://avatars.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"body":"It would be good to link to `subprocess.Popen` here so the user can understand it better.","created_at":"2016-05-08T06:07:17Z","updated_at":"2016-05-08T06:07:17Z","html_url":"https://github.com/bebraw/pypandoc/pull/96#discussion_r62427373","pull_request_url":"https://api.github.com/repos/bebraw/pypandoc/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/comments/62427373"},"html":{"href":"https://github.com/bebraw/pypandoc/pull/96#discussion_r62427373"},"pull_request":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/bebraw/pypandoc/pulls/96","id":69253513,"html_url":"https://github.com/bebraw/pypandoc/pull/96","diff_url":"https://github.com/bebraw/pypandoc/pull/96.diff","patch_url":"https://github.com/bebraw/pypandoc/pull/96.patch","issue_url":"https://api.github.com/repos/bebraw/pypandoc/issues/96","number":96,"state":"open","locked":false,"title":"New main api: convert_file and convert_text","user":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"body":"This introduces `convert_text()` and `convert_file()` as a successor to `convert()`. It also adds a few tweaks to the `convert()` path, so that it will give better error messages (more or less for https://github.com/bebraw/pypandoc/issues/86), but the real fix is to convert `convert()` calls into the new  `conver_*()` ones...\r\n\r\nAlso cleans up the old separation of the functions which seems to be only used by the tests, reactors tests and enables more tests on windows, adds tests for the new ways to use the library and updates the readme (including a new source where you can get the conda packages)\r\n\r\nThis closes: https://github.com/bebraw/pypandoc/issues/86","created_at":"2016-05-07T21:23:27Z","updated_at":"2016-05-08T06:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"225ec860d779a4d31032ce0400e7ad6b55364f8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bebraw/pypandoc/pulls/96/commits","review_comments_url":"https://api.github.com/repos/bebraw/pypandoc/pulls/96/comments","review_comment_url":"https://api.github.com/repos/bebraw/pypandoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bebraw/pypandoc/issues/96/comments","statuses_url":"https://api.github.com/repos/bebraw/pypandoc/statuses/35f363a3f6c4fc91eefe01a16b1037bc32664a46","head":{"label":"janschulz:new_main_api","ref":"new_main_api","sha":"35f363a3f6c4fc91eefe01a16b1037bc32664a46","user":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"repo":{"id":31906405,"name":"pypandoc","full_name":"janschulz/pypandoc","owner":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janschulz/pypandoc","description":"Thin wrapper for \"pandoc\" (MIT)","fork":true,"url":"https://api.github.com/repos/janschulz/pypandoc","forks_url":"https://api.github.com/repos/janschulz/pypandoc/forks","keys_url":"https://api.github.com/repos/janschulz/pypandoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janschulz/pypandoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janschulz/pypandoc/teams","hooks_url":"https://api.github.com/repos/janschulz/pypandoc/hooks","issue_events_url":"https://api.github.com/repos/janschulz/pypandoc/issues/events{/number}","events_url":"https://api.github.com/repos/janschulz/pypandoc/events","assignees_url":"https://api.github.com/repos/janschulz/pypandoc/assignees{/user}","branches_url":"https://api.github.com/repos/janschulz/pypandoc/branches{/branch}","tags_url":"https://api.github.com/repos/janschulz/pypandoc/tags","blobs_url":"https://api.github.com/repos/janschulz/pypandoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janschulz/pypandoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janschulz/pypandoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/janschulz/pypandoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janschulz/pypandoc/statuses/{sha}","languages_url":"https://api.github.com/repos/janschulz/pypandoc/languages","stargazers_url":"https://api.github.com/repos/janschulz/pypandoc/stargazers","contributors_url":"https://api.github.com/repos/janschulz/pypandoc/contributors","subscribers_url":"https://api.github.com/repos/janschulz/pypandoc/subscribers","subscription_url":"https://api.github.com/repos/janschulz/pypandoc/subscription","commits_url":"https://api.github.com/repos/janschulz/pypandoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/janschulz/pypandoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/janschulz/pypandoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/janschulz/pypandoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/janschulz/pypandoc/contents/{+path}","compare_url":"https://api.github.com/repos/janschulz/pypandoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janschulz/pypandoc/merges","archive_url":"https://api.github.com/repos/janschulz/pypandoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janschulz/pypandoc/downloads","issues_url":"https://api.github.com/repos/janschulz/pypandoc/issues{/number}","pulls_url":"https://api.github.com/repos/janschulz/pypandoc/pulls{/number}","milestones_url":"https://api.github.com/repos/janschulz/pypandoc/milestones{/number}","notifications_url":"https://api.github.com/repos/janschulz/pypandoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janschulz/pypandoc/labels{/name}","releases_url":"https://api.github.com/repos/janschulz/pypandoc/releases{/id}","deployments_url":"https://api.github.com/repos/janschulz/pypandoc/deployments","created_at":"2015-03-09T15:29:51Z","updated_at":"2015-03-09T15:29:51Z","pushed_at":"2016-05-07T22:23:52Z","git_url":"git://github.com/janschulz/pypandoc.git","ssh_url":"git@github.com:janschulz/pypandoc.git","clone_url":"https://github.com/janschulz/pypandoc.git","svn_url":"https://github.com/janschulz/pypandoc","homepage":"http://pypi.python.org/pypi/pypandoc/","size":177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bebraw:master","ref":"master","sha":"edeb43ebdea8bd09e98c479af88b4fbd957c452e","user":{"login":"bebraw","id":166921,"avatar_url":"https://avatars.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"repo":{"id":2786727,"name":"pypandoc","full_name":"bebraw/pypandoc","owner":{"login":"bebraw","id":166921,"avatar_url":"https://avatars.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bebraw/pypandoc","description":"Thin wrapper for \"pandoc\" (MIT)","fork":false,"url":"https://api.github.com/repos/bebraw/pypandoc","forks_url":"https://api.github.com/repos/bebraw/pypandoc/forks","keys_url":"https://api.github.com/repos/bebraw/pypandoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bebraw/pypandoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bebraw/pypandoc/teams","hooks_url":"https://api.github.com/repos/bebraw/pypandoc/hooks","issue_events_url":"https://api.github.com/repos/bebraw/pypandoc/issues/events{/number}","events_url":"https://api.github.com/repos/bebraw/pypandoc/events","assignees_url":"https://api.github.com/repos/bebraw/pypandoc/assignees{/user}","branches_url":"https://api.github.com/repos/bebraw/pypandoc/branches{/branch}","tags_url":"https://api.github.com/repos/bebraw/pypandoc/tags","blobs_url":"https://api.github.com/repos/bebraw/pypandoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bebraw/pypandoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bebraw/pypandoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bebraw/pypandoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bebraw/pypandoc/statuses/{sha}","languages_url":"https://api.github.com/repos/bebraw/pypandoc/languages","stargazers_url":"https://api.github.com/repos/bebraw/pypandoc/stargazers","contributors_url":"https://api.github.com/repos/bebraw/pypandoc/contributors","subscribers_url":"https://api.github.com/repos/bebraw/pypandoc/subscribers","subscription_url":"https://api.github.com/repos/bebraw/pypandoc/subscription","commits_url":"https://api.github.com/repos/bebraw/pypandoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bebraw/pypandoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bebraw/pypandoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bebraw/pypandoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bebraw/pypandoc/contents/{+path}","compare_url":"https://api.github.com/repos/bebraw/pypandoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bebraw/pypandoc/merges","archive_url":"https://api.github.com/repos/bebraw/pypandoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bebraw/pypandoc/downloads","issues_url":"https://api.github.com/repos/bebraw/pypandoc/issues{/number}","pulls_url":"https://api.github.com/repos/bebraw/pypandoc/pulls{/number}","milestones_url":"https://api.github.com/repos/bebraw/pypandoc/milestones{/number}","notifications_url":"https://api.github.com/repos/bebraw/pypandoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bebraw/pypandoc/labels{/name}","releases_url":"https://api.github.com/repos/bebraw/pypandoc/releases{/id}","deployments_url":"https://api.github.com/repos/bebraw/pypandoc/deployments","created_at":"2011-11-16T09:21:06Z","updated_at":"2016-05-07T14:50:52Z","pushed_at":"2016-05-07T22:23:52Z","git_url":"git://github.com/bebraw/pypandoc.git","ssh_url":"git@github.com:bebraw/pypandoc.git","clone_url":"https://github.com/bebraw/pypandoc.git","svn_url":"https://github.com/bebraw/pypandoc","homepage":"http://pypi.python.org/pypi/pypandoc/","size":14540,"stargazers_count":135,"watchers_count":135,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":4,"forks":31,"open_issues":4,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/96"},"html":{"href":"https://github.com/bebraw/pypandoc/pull/96"},"issue":{"href":"https://api.github.com/repos/bebraw/pypandoc/issues/96"},"comments":{"href":"https://api.github.com/repos/bebraw/pypandoc/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bebraw/pypandoc/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/bebraw/pypandoc/statuses/35f363a3f6c4fc91eefe01a16b1037bc32664a46"}}}}