{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/83576006","pull_request_review_id":4410304,"id":83576006,"diff_hunk":"@@ -456,7 +456,7 @@ More details can be found [here](https://github.com/kubernetes/kubernetes/tree/{\n ### vsphereVolume\n \n A `vsphereVolume` is used to mount a vSphere VMDK Volume into your Pod.  The contents\n-of a volume are preserved when it is unmounted.\n+of a volume are preserved when it is unmounted. It supports both VMFS and VSAN datastore.\n \n __Important: You must create a VMDK volume using `vmware-vdiskmanager -c` or\n the VSphere API before you can use it__","path":"docs/user-guide/volumes.md","position":8,"original_position":8,"commit_id":"c7a6c0804336d8836fc05140c86e21944b97cb32","original_commit_id":"c7a6c0804336d8836fc05140c86e21944b97cb32","user":{"login":"pdhamdhere","id":16676511,"avatar_url":"https://avatars.githubusercontent.com/u/16676511?v=3","gravatar_id":"","url":"https://api.github.com/users/pdhamdhere","html_url":"https://github.com/pdhamdhere","followers_url":"https://api.github.com/users/pdhamdhere/followers","following_url":"https://api.github.com/users/pdhamdhere/following{/other_user}","gists_url":"https://api.github.com/users/pdhamdhere/gists{/gist_id}","starred_url":"https://api.github.com/users/pdhamdhere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdhamdhere/subscriptions","organizations_url":"https://api.github.com/users/pdhamdhere/orgs","repos_url":"https://api.github.com/users/pdhamdhere/repos","events_url":"https://api.github.com/users/pdhamdhere/events{/privacy}","received_events_url":"https://api.github.com/users/pdhamdhere/received_events","type":"User","site_admin":false},"body":"May be add a pre-requisite section and link to \"vSphere getting started guide\"?\r\nPrerequisite:\r\n1. vSphere Cloud Provider Configuration\r\n2. Node configuration to enable diskUUID\r\n3. Creating VMDK","created_at":"2016-10-17T04:20:37Z","updated_at":"2016-10-17T04:23:28Z","html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/1487#discussion_r83576006","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/83576006"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/1487#discussion_r83576006"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487","id":89553350,"html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/1487","diff_url":"https://github.com/kubernetes/kubernetes.github.io/pull/1487.diff","patch_url":"https://github.com/kubernetes/kubernetes.github.io/pull/1487.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/1487","number":1487,"state":"open","locked":false,"title":"Add vSphere Storage class","user":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"body":"This PR does the following,\r\n\r\n1. Add vSphere storage class to Persistent Volumes.\r\n2. Fixes Pod definition for vsphereVolume.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes.github.io/1487)\n<!-- Reviewable:end -->\n","created_at":"2016-10-17T02:48:18Z","updated_at":"2016-10-17T04:23:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff65fd3f9d4cadf2c5b52372245488c5a9ade5c0","assignee":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/1487/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/c7a6c0804336d8836fc05140c86e21944b97cb32","head":{"label":"abrarshivani:vsphere_storage_class","ref":"vsphere_storage_class","sha":"c7a6c0804336d8836fc05140c86e21944b97cb32","user":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"repo":{"id":65589029,"name":"kubernetes.github.io","full_name":"abrarshivani/kubernetes.github.io","owner":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abrarshivani/kubernetes.github.io","description":"Website/documentation repo","fork":true,"url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io","forks_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/abrarshivani/kubernetes.github.io/deployments","created_at":"2016-08-12T23:24:27Z","updated_at":"2016-08-12T23:24:29Z","pushed_at":"2016-10-17T02:56:38Z","git_url":"git://github.com/abrarshivani/kubernetes.github.io.git","ssh_url":"git@github.com:abrarshivani/kubernetes.github.io.git","clone_url":"https://github.com/abrarshivani/kubernetes.github.io.git","svn_url":"https://github.com/abrarshivani/kubernetes.github.io","homepage":null,"size":39365,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"965eb76254eeb2870111cfc48c793118443d028d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"name":"kubernetes.github.io","full_name":"kubernetes/kubernetes.github.io","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes.github.io","description":"Website/documentation repo","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io","forks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2016-10-14T20:18:36Z","pushed_at":"2016-10-17T02:56:44Z","git_url":"git://github.com/kubernetes/kubernetes.github.io.git","ssh_url":"git@github.com:kubernetes/kubernetes.github.io.git","clone_url":"https://github.com/kubernetes/kubernetes.github.io.git","svn_url":"https://github.com/kubernetes/kubernetes.github.io","homepage":null,"size":48683,"stargazers_count":76,"watchers_count":76,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":544,"mirror_url":null,"open_issues_count":455,"forks":544,"open_issues":455,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/1487"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/1487"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/1487/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/1487/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/c7a6c0804336d8836fc05140c86e21944b97cb32"}}}}
{"actor":{"display_login":"pdhamdhere"}}