{"action":"created","comment":{"url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/comments/88799958","pull_request_review_id":9363083,"id":88799958,"diff_hunk":"@@ -419,18 +425,18 @@ void update_density_and_factors(float mass, Float3* pos, float* dens, float* sca\n \t\t\tdy = pos->y[particle] - pos->y[neighbor_index];\n \t\t\tdz = pos->z[particle] - pos->z[neighbor_index];\n \n-\t\t\tkernel_gradient_x = mass*dx*scalar_values[linear_ind];\n-\t\t\tkernel_gradient_y = mass*dy*scalar_values[linear_ind];\n-\t\t\tkernel_gradient_z = mass*dz*scalar_values[linear_ind];\n+\t\t\tscalar_value = scalar_values[linear_ind];","path":"src/SPH.cpp","position":null,"original_position":71,"commit_id":"52af24f6f7382c1081c14527a2246dfb3320c247","original_commit_id":"52af24f6f7382c1081c14527a2246dfb3320c247","user":{"login":"Isafo","id":3956824,"avatar_url":"https://avatars.githubusercontent.com/u/3956824?v=3","gravatar_id":"","url":"https://api.github.com/users/Isafo","html_url":"https://github.com/Isafo","followers_url":"https://api.github.com/users/Isafo/followers","following_url":"https://api.github.com/users/Isafo/following{/other_user}","gists_url":"https://api.github.com/users/Isafo/gists{/gist_id}","starred_url":"https://api.github.com/users/Isafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isafo/subscriptions","organizations_url":"https://api.github.com/users/Isafo/orgs","repos_url":"https://api.github.com/users/Isafo/repos","events_url":"https://api.github.com/users/Isafo/events{/privacy}","received_events_url":"https://api.github.com/users/Isafo/received_events","type":"User","site_admin":false},"body":"multiplicera denna med mass","created_at":"2016-11-20T12:30:46Z","updated_at":"2016-11-20T12:33:32Z","html_url":"https://github.com/Isafo/Hybrid_Sim/pull/12#discussion_r88799958","pull_request_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/comments/88799958"},"html":{"href":"https://github.com/Isafo/Hybrid_Sim/pull/12#discussion_r88799958"},"pull_request":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12","id":94514587,"html_url":"https://github.com/Isafo/Hybrid_Sim/pull/12","diff_url":"https://github.com/Isafo/Hybrid_Sim/pull/12.diff","patch_url":"https://github.com/Isafo/Hybrid_Sim/pull/12.patch","issue_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/12","number":12,"state":"open","locked":false,"title":"Divergence error finished and some small fixes","user":{"login":"chren574","id":5877440,"avatar_url":"https://avatars.githubusercontent.com/u/5877440?v=3","gravatar_id":"","url":"https://api.github.com/users/chren574","html_url":"https://github.com/chren574","followers_url":"https://api.github.com/users/chren574/followers","following_url":"https://api.github.com/users/chren574/following{/other_user}","gists_url":"https://api.github.com/users/chren574/gists{/gist_id}","starred_url":"https://api.github.com/users/chren574/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chren574/subscriptions","organizations_url":"https://api.github.com/users/chren574/orgs","repos_url":"https://api.github.com/users/chren574/repos","events_url":"https://api.github.com/users/chren574/events{/privacy}","received_events_url":"https://api.github.com/users/chren574/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-20T11:14:42Z","updated_at":"2016-11-20T12:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/12/comments","statuses_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/statuses/52af24f6f7382c1081c14527a2246dfb3320c247","head":{"label":"Isafo:redo_divergence_error","ref":"redo_divergence_error","sha":"52af24f6f7382c1081c14527a2246dfb3320c247","user":{"login":"Isafo","id":3956824,"avatar_url":"https://avatars.githubusercontent.com/u/3956824?v=3","gravatar_id":"","url":"https://api.github.com/users/Isafo","html_url":"https://github.com/Isafo","followers_url":"https://api.github.com/users/Isafo/followers","following_url":"https://api.github.com/users/Isafo/following{/other_user}","gists_url":"https://api.github.com/users/Isafo/gists{/gist_id}","starred_url":"https://api.github.com/users/Isafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isafo/subscriptions","organizations_url":"https://api.github.com/users/Isafo/orgs","repos_url":"https://api.github.com/users/Isafo/repos","events_url":"https://api.github.com/users/Isafo/events{/privacy}","received_events_url":"https://api.github.com/users/Isafo/received_events","type":"User","site_admin":false},"repo":{"id":67602709,"name":"Hybrid_Sim","full_name":"Isafo/Hybrid_Sim","owner":{"login":"Isafo","id":3956824,"avatar_url":"https://avatars.githubusercontent.com/u/3956824?v=3","gravatar_id":"","url":"https://api.github.com/users/Isafo","html_url":"https://github.com/Isafo","followers_url":"https://api.github.com/users/Isafo/followers","following_url":"https://api.github.com/users/Isafo/following{/other_user}","gists_url":"https://api.github.com/users/Isafo/gists{/gist_id}","starred_url":"https://api.github.com/users/Isafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isafo/subscriptions","organizations_url":"https://api.github.com/users/Isafo/orgs","repos_url":"https://api.github.com/users/Isafo/repos","events_url":"https://api.github.com/users/Isafo/events{/privacy}","received_events_url":"https://api.github.com/users/Isafo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Isafo/Hybrid_Sim","description":"DFSPH fluid simulation for the course TN1008","fork":false,"url":"https://api.github.com/repos/Isafo/Hybrid_Sim","forks_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/forks","keys_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/teams","hooks_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/hooks","issue_events_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/events{/number}","events_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/events","assignees_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/assignees{/user}","branches_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/branches{/branch}","tags_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/tags","blobs_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/statuses/{sha}","languages_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/languages","stargazers_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/stargazers","contributors_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/contributors","subscribers_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/subscribers","subscription_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/subscription","commits_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/contents/{+path}","compare_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/merges","archive_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/downloads","issues_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues{/number}","pulls_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls{/number}","milestones_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/milestones{/number}","notifications_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/labels{/name}","releases_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/releases{/id}","deployments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/deployments","created_at":"2016-09-07T12:01:32Z","updated_at":"2016-11-03T18:12:48Z","pushed_at":"2016-11-20T12:27:35Z","git_url":"git://github.com/Isafo/Hybrid_Sim.git","ssh_url":"git@github.com:Isafo/Hybrid_Sim.git","clone_url":"https://github.com/Isafo/Hybrid_Sim.git","svn_url":"https://github.com/Isafo/Hybrid_Sim","homepage":"","size":10445,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"Isafo:master","ref":"master","sha":"b89ce3026b4e03751e1f852ff84ab855b35bcea5","user":{"login":"Isafo","id":3956824,"avatar_url":"https://avatars.githubusercontent.com/u/3956824?v=3","gravatar_id":"","url":"https://api.github.com/users/Isafo","html_url":"https://github.com/Isafo","followers_url":"https://api.github.com/users/Isafo/followers","following_url":"https://api.github.com/users/Isafo/following{/other_user}","gists_url":"https://api.github.com/users/Isafo/gists{/gist_id}","starred_url":"https://api.github.com/users/Isafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isafo/subscriptions","organizations_url":"https://api.github.com/users/Isafo/orgs","repos_url":"https://api.github.com/users/Isafo/repos","events_url":"https://api.github.com/users/Isafo/events{/privacy}","received_events_url":"https://api.github.com/users/Isafo/received_events","type":"User","site_admin":false},"repo":{"id":67602709,"name":"Hybrid_Sim","full_name":"Isafo/Hybrid_Sim","owner":{"login":"Isafo","id":3956824,"avatar_url":"https://avatars.githubusercontent.com/u/3956824?v=3","gravatar_id":"","url":"https://api.github.com/users/Isafo","html_url":"https://github.com/Isafo","followers_url":"https://api.github.com/users/Isafo/followers","following_url":"https://api.github.com/users/Isafo/following{/other_user}","gists_url":"https://api.github.com/users/Isafo/gists{/gist_id}","starred_url":"https://api.github.com/users/Isafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isafo/subscriptions","organizations_url":"https://api.github.com/users/Isafo/orgs","repos_url":"https://api.github.com/users/Isafo/repos","events_url":"https://api.github.com/users/Isafo/events{/privacy}","received_events_url":"https://api.github.com/users/Isafo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Isafo/Hybrid_Sim","description":"DFSPH fluid simulation for the course TN1008","fork":false,"url":"https://api.github.com/repos/Isafo/Hybrid_Sim","forks_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/forks","keys_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/teams","hooks_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/hooks","issue_events_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/events{/number}","events_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/events","assignees_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/assignees{/user}","branches_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/branches{/branch}","tags_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/tags","blobs_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/statuses/{sha}","languages_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/languages","stargazers_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/stargazers","contributors_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/contributors","subscribers_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/subscribers","subscription_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/subscription","commits_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/contents/{+path}","compare_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/merges","archive_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/downloads","issues_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues{/number}","pulls_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls{/number}","milestones_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/milestones{/number}","notifications_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/labels{/name}","releases_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/releases{/id}","deployments_url":"https://api.github.com/repos/Isafo/Hybrid_Sim/deployments","created_at":"2016-09-07T12:01:32Z","updated_at":"2016-11-03T18:12:48Z","pushed_at":"2016-11-20T12:27:35Z","git_url":"git://github.com/Isafo/Hybrid_Sim.git","ssh_url":"git@github.com:Isafo/Hybrid_Sim.git","clone_url":"https://github.com/Isafo/Hybrid_Sim.git","svn_url":"https://github.com/Isafo/Hybrid_Sim","homepage":"","size":10445,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12"},"html":{"href":"https://github.com/Isafo/Hybrid_Sim/pull/12"},"issue":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/12"},"comments":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Isafo/Hybrid_Sim/statuses/52af24f6f7382c1081c14527a2246dfb3320c247"}}}}
{"actor":{"display_login":"Isafo"}}