{"action":"opened","number":3496,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3496","id":83493284,"html_url":"https://github.com/mono/mono/pull/3496","diff_url":"https://github.com/mono/mono/pull/3496.diff","patch_url":"https://github.com/mono/mono/pull/3496.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/3496","number":3496,"state":"open","locked":false,"title":"Fixes two heap corruptions in the corlib tests on Windows","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"body":"The patch of mono/metadata/marshal.c makes sure that Marshal.StringToHGlobalAnsi() allocates a memory area for the returned C string which is at least as large as the length of the string object. This is the behavior on non-Windows platforms. Without this patch the MarshalTest.StringToHGlobalAnsiWithNullValues() test wrote outside of a memory area and corrupted the heap which later on caused a heap corruption crash when running the corlib test suite on Windows.\r\n\r\nThe patch of mono/metadata/mono-security.c fixes the freeing of the memory returned by GetNamedSecurityInfoW(). When GetNamedSecurityInfoW() is used to request a DACL one must also pass an argument for the ppSecurityDescriptor parameter and this is the one that should be freed later on, not the pointer to the DACL as the original code used to free. Before this patch\r\nDSACryptoServiceProviderTest.UseMachineKeyStore() crashed because of a heap corruption.","created_at":"2016-08-31T17:15:13Z","updated_at":"2016-08-31T17:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/3496/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/3496/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/3496/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/e8fd99043a05583108ed461c797f09f9b0999224","head":{"label":"ntherning:fix-heap-corruption-on-windows","ref":"fix-heap-corruption-on-windows","sha":"e8fd99043a05583108ed461c797f09f9b0999224","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"repo":{"id":53493195,"name":"mono","full_name":"ntherning/mono","owner":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntherning/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/ntherning/mono","forks_url":"https://api.github.com/repos/ntherning/mono/forks","keys_url":"https://api.github.com/repos/ntherning/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntherning/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntherning/mono/teams","hooks_url":"https://api.github.com/repos/ntherning/mono/hooks","issue_events_url":"https://api.github.com/repos/ntherning/mono/issues/events{/number}","events_url":"https://api.github.com/repos/ntherning/mono/events","assignees_url":"https://api.github.com/repos/ntherning/mono/assignees{/user}","branches_url":"https://api.github.com/repos/ntherning/mono/branches{/branch}","tags_url":"https://api.github.com/repos/ntherning/mono/tags","blobs_url":"https://api.github.com/repos/ntherning/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntherning/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntherning/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntherning/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntherning/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/ntherning/mono/languages","stargazers_url":"https://api.github.com/repos/ntherning/mono/stargazers","contributors_url":"https://api.github.com/repos/ntherning/mono/contributors","subscribers_url":"https://api.github.com/repos/ntherning/mono/subscribers","subscription_url":"https://api.github.com/repos/ntherning/mono/subscription","commits_url":"https://api.github.com/repos/ntherning/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntherning/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntherning/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntherning/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntherning/mono/contents/{+path}","compare_url":"https://api.github.com/repos/ntherning/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntherning/mono/merges","archive_url":"https://api.github.com/repos/ntherning/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntherning/mono/downloads","issues_url":"https://api.github.com/repos/ntherning/mono/issues{/number}","pulls_url":"https://api.github.com/repos/ntherning/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/ntherning/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/ntherning/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntherning/mono/labels{/name}","releases_url":"https://api.github.com/repos/ntherning/mono/releases{/id}","deployments_url":"https://api.github.com/repos/ntherning/mono/deployments","created_at":"2016-03-09T11:42:37Z","updated_at":"2016-03-09T11:43:56Z","pushed_at":"2016-08-31T17:14:10Z","git_url":"git://github.com/ntherning/mono.git","ssh_url":"git@github.com:ntherning/mono.git","clone_url":"https://github.com/ntherning/mono.git","svn_url":"https://github.com/ntherning/mono","homepage":"http://www.mono-project.com/","size":412589,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"07f9a6fc173efc6e0c6718603981be12442b75bc","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-08-31T05:20:19Z","pushed_at":"2016-08-31T17:15:13Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":499910,"stargazers_count":4855,"watchers_count":4855,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2315,"mirror_url":null,"open_issues_count":138,"forks":2315,"open_issues":138,"watchers":4855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/3496"},"html":{"href":"https://github.com/mono/mono/pull/3496"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/3496"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/3496/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/3496/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/3496/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/e8fd99043a05583108ed461c797f09f9b0999224"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"ntherning"}}