{"action":"created","comment":{"url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/comments/54015203","id":54015203,"diff_hunk":"@@ -254,6 +254,11 @@ allowed_nodes() ->\n nodes_in_zone(Nodes, Zone) ->\n     [Node || Node <- Nodes, Zone == mem3:node_info(Node, <<\"zone\">>)].\n \n+non_maintenance_nodes() ->\n+    Nodes = [node() | erlang:nodes()],\n+    {Modes, _} = rpc:multicall(config, get, [\"couchdb\", \"maintenance_mode\"]),","path":"src/mem3.erl","position":15,"original_position":15,"commit_id":"bfd83b4e952a7f9f62ecd89c0e424c851b10128e","original_commit_id":"bfd83b4e952a7f9f62ecd89c0e424c851b10128e","user":{"login":"iilyak","id":9804420,"avatar_url":"https://avatars.githubusercontent.com/u/9804420?v=3","gravatar_id":"","url":"https://api.github.com/users/iilyak","html_url":"https://github.com/iilyak","followers_url":"https://api.github.com/users/iilyak/followers","following_url":"https://api.github.com/users/iilyak/following{/other_user}","gists_url":"https://api.github.com/users/iilyak/gists{/gist_id}","starred_url":"https://api.github.com/users/iilyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iilyak/subscriptions","organizations_url":"https://api.github.com/users/iilyak/orgs","repos_url":"https://api.github.com/users/iilyak/repos","events_url":"https://api.github.com/users/iilyak/events{/privacy}","received_events_url":"https://api.github.com/users/iilyak/received_events","type":"User","site_admin":false},"body":"Here you rely on implementation detail that `rpc:multicall` uses `[node() | erlang:nodes()]`. The order of results is not documented either. \r\n","created_at":"2016-02-24T22:08:46Z","updated_at":"2016-02-24T22:08:46Z","html_url":"https://github.com/apache/couchdb-mem3/pull/17#discussion_r54015203","pull_request_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/comments/54015203"},"html":{"href":"https://github.com/apache/couchdb-mem3/pull/17#discussion_r54015203"},"pull_request":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17","id":60578431,"html_url":"https://github.com/apache/couchdb-mem3/pull/17","diff_url":"https://github.com/apache/couchdb-mem3/pull/17.diff","patch_url":"https://github.com/apache/couchdb-mem3/pull/17.patch","issue_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/17","number":17,"state":"open","locked":false,"title":"Remove nodes from ushards with maintenance mode","user":{"login":"tonysun83","id":6991573,"avatar_url":"https://avatars.githubusercontent.com/u/6991573?v=3","gravatar_id":"","url":"https://api.github.com/users/tonysun83","html_url":"https://github.com/tonysun83","followers_url":"https://api.github.com/users/tonysun83/followers","following_url":"https://api.github.com/users/tonysun83/following{/other_user}","gists_url":"https://api.github.com/users/tonysun83/gists{/gist_id}","starred_url":"https://api.github.com/users/tonysun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonysun83/subscriptions","organizations_url":"https://api.github.com/users/tonysun83/orgs","repos_url":"https://api.github.com/users/tonysun83/repos","events_url":"https://api.github.com/users/tonysun83/events{/privacy}","received_events_url":"https://api.github.com/users/tonysun83/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-24T21:07:30Z","updated_at":"2016-02-24T22:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc07e260d3025475a7f52dfc2f7a5eb28529f3e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17/commits","review_comments_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17/comments","review_comment_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/17/comments","statuses_url":"https://api.github.com/repos/apache/couchdb-mem3/statuses/bfd83b4e952a7f9f62ecd89c0e424c851b10128e","head":{"label":"apache:2953-ushards-mm","ref":"2953-ushards-mm","sha":"bfd83b4e952a7f9f62ecd89c0e424c851b10128e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15993615,"name":"couchdb-mem3","full_name":"apache/couchdb-mem3","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/couchdb-mem3","description":"Mirror of Apache CouchDB","fork":false,"url":"https://api.github.com/repos/apache/couchdb-mem3","forks_url":"https://api.github.com/repos/apache/couchdb-mem3/forks","keys_url":"https://api.github.com/repos/apache/couchdb-mem3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/couchdb-mem3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/couchdb-mem3/teams","hooks_url":"https://api.github.com/repos/apache/couchdb-mem3/hooks","issue_events_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/events{/number}","events_url":"https://api.github.com/repos/apache/couchdb-mem3/events","assignees_url":"https://api.github.com/repos/apache/couchdb-mem3/assignees{/user}","branches_url":"https://api.github.com/repos/apache/couchdb-mem3/branches{/branch}","tags_url":"https://api.github.com/repos/apache/couchdb-mem3/tags","blobs_url":"https://api.github.com/repos/apache/couchdb-mem3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/couchdb-mem3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/couchdb-mem3/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/couchdb-mem3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/couchdb-mem3/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/couchdb-mem3/languages","stargazers_url":"https://api.github.com/repos/apache/couchdb-mem3/stargazers","contributors_url":"https://api.github.com/repos/apache/couchdb-mem3/contributors","subscribers_url":"https://api.github.com/repos/apache/couchdb-mem3/subscribers","subscription_url":"https://api.github.com/repos/apache/couchdb-mem3/subscription","commits_url":"https://api.github.com/repos/apache/couchdb-mem3/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/couchdb-mem3/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/couchdb-mem3/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/couchdb-mem3/contents/{+path}","compare_url":"https://api.github.com/repos/apache/couchdb-mem3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/couchdb-mem3/merges","archive_url":"https://api.github.com/repos/apache/couchdb-mem3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/couchdb-mem3/downloads","issues_url":"https://api.github.com/repos/apache/couchdb-mem3/issues{/number}","pulls_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/couchdb-mem3/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/couchdb-mem3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/couchdb-mem3/labels{/name}","releases_url":"https://api.github.com/repos/apache/couchdb-mem3/releases{/id}","deployments_url":"https://api.github.com/repos/apache/couchdb-mem3/deployments","created_at":"2014-01-17T08:00:09Z","updated_at":"2015-03-16T23:34:44Z","pushed_at":"2016-02-24T21:07:30Z","git_url":"git://github.com/apache/couchdb-mem3.git","ssh_url":"git@github.com:apache/couchdb-mem3.git","clone_url":"https://github.com/apache/couchdb-mem3.git","svn_url":"https://github.com/apache/couchdb-mem3","homepage":null,"size":609,"stargazers_count":6,"watchers_count":6,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":"git://git.apache.org/couchdb-mem3.git","open_issues_count":5,"forks":14,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f20843714eee54c687739c94c6ac870e7a1e6a00","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15993615,"name":"couchdb-mem3","full_name":"apache/couchdb-mem3","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/couchdb-mem3","description":"Mirror of Apache CouchDB","fork":false,"url":"https://api.github.com/repos/apache/couchdb-mem3","forks_url":"https://api.github.com/repos/apache/couchdb-mem3/forks","keys_url":"https://api.github.com/repos/apache/couchdb-mem3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/couchdb-mem3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/couchdb-mem3/teams","hooks_url":"https://api.github.com/repos/apache/couchdb-mem3/hooks","issue_events_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/events{/number}","events_url":"https://api.github.com/repos/apache/couchdb-mem3/events","assignees_url":"https://api.github.com/repos/apache/couchdb-mem3/assignees{/user}","branches_url":"https://api.github.com/repos/apache/couchdb-mem3/branches{/branch}","tags_url":"https://api.github.com/repos/apache/couchdb-mem3/tags","blobs_url":"https://api.github.com/repos/apache/couchdb-mem3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/couchdb-mem3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/couchdb-mem3/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/couchdb-mem3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/couchdb-mem3/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/couchdb-mem3/languages","stargazers_url":"https://api.github.com/repos/apache/couchdb-mem3/stargazers","contributors_url":"https://api.github.com/repos/apache/couchdb-mem3/contributors","subscribers_url":"https://api.github.com/repos/apache/couchdb-mem3/subscribers","subscription_url":"https://api.github.com/repos/apache/couchdb-mem3/subscription","commits_url":"https://api.github.com/repos/apache/couchdb-mem3/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/couchdb-mem3/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/couchdb-mem3/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/couchdb-mem3/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/couchdb-mem3/contents/{+path}","compare_url":"https://api.github.com/repos/apache/couchdb-mem3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/couchdb-mem3/merges","archive_url":"https://api.github.com/repos/apache/couchdb-mem3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/couchdb-mem3/downloads","issues_url":"https://api.github.com/repos/apache/couchdb-mem3/issues{/number}","pulls_url":"https://api.github.com/repos/apache/couchdb-mem3/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/couchdb-mem3/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/couchdb-mem3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/couchdb-mem3/labels{/name}","releases_url":"https://api.github.com/repos/apache/couchdb-mem3/releases{/id}","deployments_url":"https://api.github.com/repos/apache/couchdb-mem3/deployments","created_at":"2014-01-17T08:00:09Z","updated_at":"2015-03-16T23:34:44Z","pushed_at":"2016-02-24T21:07:30Z","git_url":"git://github.com/apache/couchdb-mem3.git","ssh_url":"git@github.com:apache/couchdb-mem3.git","clone_url":"https://github.com/apache/couchdb-mem3.git","svn_url":"https://github.com/apache/couchdb-mem3","homepage":null,"size":609,"stargazers_count":6,"watchers_count":6,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":"git://git.apache.org/couchdb-mem3.git","open_issues_count":5,"forks":14,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17"},"html":{"href":"https://github.com/apache/couchdb-mem3/pull/17"},"issue":{"href":"https://api.github.com/repos/apache/couchdb-mem3/issues/17"},"comments":{"href":"https://api.github.com/repos/apache/couchdb-mem3/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/couchdb-mem3/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/apache/couchdb-mem3/statuses/bfd83b4e952a7f9f62ecd89c0e424c851b10128e"}}}}