{"action":"created","issue":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/188","repository_url":"https://api.github.com/repos/dwmkerr/angular-modal-service","labels_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/188/comments","events_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/188/events","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/188","id":194665124,"number":188,"title":"On Location Change don't pass event as result","user":{"login":"SergeyCherman","id":10699293,"avatar_url":"https://avatars.githubusercontent.com/u/10699293?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyCherman","html_url":"https://github.com/SergeyCherman","followers_url":"https://api.github.com/users/SergeyCherman/followers","following_url":"https://api.github.com/users/SergeyCherman/following{/other_user}","gists_url":"https://api.github.com/users/SergeyCherman/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyCherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyCherman/subscriptions","organizations_url":"https://api.github.com/users/SergeyCherman/orgs","repos_url":"https://api.github.com/users/SergeyCherman/repos","events_url":"https://api.github.com/users/SergeyCherman/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyCherman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-09T18:30:55Z","updated_at":"2016-12-12T15:35:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/pulls/188","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/188","diff_url":"https://github.com/dwmkerr/angular-modal-service/pull/188.diff","patch_url":"https://github.com/dwmkerr/angular-modal-service/pull/188.patch"},"body":"I think when closing the modal on location change it shouldn't pass event as the result ."},"comment":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/comments/266462161","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/188#issuecomment-266462161","issue_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/188","id":266462161,"user":{"login":"SergeyCherman","id":10699293,"avatar_url":"https://avatars.githubusercontent.com/u/10699293?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyCherman","html_url":"https://github.com/SergeyCherman","followers_url":"https://api.github.com/users/SergeyCherman/followers","following_url":"https://api.github.com/users/SergeyCherman/following{/other_user}","gists_url":"https://api.github.com/users/SergeyCherman/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyCherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyCherman/subscriptions","organizations_url":"https://api.github.com/users/SergeyCherman/orgs","repos_url":"https://api.github.com/users/SergeyCherman/repos","events_url":"https://api.github.com/users/SergeyCherman/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyCherman/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T15:35:52Z","updated_at":"2016-12-12T15:35:52Z","body":"I can see it both ways, however it's possible users of the service have one function for ok/cancel which then uses the function input to decide what to do. In this case if a user has any cleanup logic on modal close it wouldn't run.  \r\nCurrently reject doesn't fire unless the service isn't being used correct, so it would be a change for service users as they probably don't have logic for the reject case."}}
{"actor":{"display_login":"SergeyCherman"}}