{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11077","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11077/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11077/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11077/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11077","id":175555753,"number":11077,"title":"Don't use interpolation if it's not required (core backend files)","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/cleanup/rubocop","name":"cleanup/rubocop","color":"fef2c0"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/core","name":"core","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/no","name":"darga/no","color":"000000"}],"state":"open","locked":false,"assignee":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"assignees":[{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-07T17:01:51Z","updated_at":"2016-09-07T20:43:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11077","html_url":"https://github.com/ManageIQ/manageiq/pull/11077","diff_url":"https://github.com/ManageIQ/manageiq/pull/11077.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11077.patch"},"body":"Purpose or Intent\r\n-----------------\r\n\r\nFollow up to #11074, but for the core backend ruby files\r\n\r\nInterpolation syntax can be error prone so don't use it when you can just\r\nconvert to string.\r\n\r\nPrefer `variable.to_s` over `\"#{variable}\"`\r\n\r\nAlso, some places we use Array#join which returns a String already:\r\n`\"#{rate_detail.errors.full_messages.join(', ')}\"`\r\nBecomes:\r\n\r\n`rate_detail.errors.full_messages.join(', ')`\r\n\r\nAlso, some places already created a message string but then wanted to interpolate\r\nit for good measure:\r\n\r\n```diff\r\nmsg = \"Authentication failed for userid #{username}, unable to find user object in #{self.class.proper_name}\"\r\n-            _log.warn(\"#{msg}\")\r\n+            _log.warn(msg)\r\n```\r\n\r\nrubocop -a --only \"Lint/StringConversionInInterpolation,Style/UnneededInterpolation\" ..."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/245412361","html_url":"https://github.com/ManageIQ/manageiq/pull/11077#issuecomment-245412361","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11077","id":245412361,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T20:43:45Z","updated_at":"2016-09-07T20:43:45Z","body":"@Fryguy Fixed the 4 places doing `define_method(action.to_s)` to take the symbol `action` as you suggested 👍 "}}
{"actor":{"display_login":"jrafanie"}}