{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/event-collector/pulls/comments/80575734","id":80575734,"diff_hunk":"@@ -39,6 +37,20 @@ def put(self, event, timeout=None):\n         self.events.append(event)\n \n \n+class MockTransport(baseplate.metrics.Transport):","path":"tests/collector_tests.py","position":null,"original_position":13,"commit_id":"a2d5950d474617abe2f8b791955ce6091fcfe1a4","original_commit_id":"6fa0924b829dae95f61ab809191a67ff05d55a49","user":{"login":"spladug","id":338853,"avatar_url":"https://avatars.githubusercontent.com/u/338853?v=3","gravatar_id":"","url":"https://api.github.com/users/spladug","html_url":"https://github.com/spladug","followers_url":"https://api.github.com/users/spladug/followers","following_url":"https://api.github.com/users/spladug/following{/other_user}","gists_url":"https://api.github.com/users/spladug/gists{/gist_id}","starred_url":"https://api.github.com/users/spladug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spladug/subscriptions","organizations_url":"https://api.github.com/users/spladug/orgs","repos_url":"https://api.github.com/users/spladug/repos","events_url":"https://api.github.com/users/spladug/events{/privacy}","received_events_url":"https://api.github.com/users/spladug/received_events","type":"User","site_admin":false},"body":"good point, done","created_at":"2016-09-26T21:18:55Z","updated_at":"2016-09-26T21:18:55Z","html_url":"https://github.com/reddit/event-collector/pull/14#discussion_r80575734","pull_request_url":"https://api.github.com/repos/reddit/event-collector/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/comments/80575734"},"html":{"href":"https://github.com/reddit/event-collector/pull/14#discussion_r80575734"},"pull_request":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/event-collector/pulls/14","id":86818398,"html_url":"https://github.com/reddit/event-collector/pull/14","diff_url":"https://github.com/reddit/event-collector/pull/14.diff","patch_url":"https://github.com/reddit/event-collector/pull/14.patch","issue_url":"https://api.github.com/repos/reddit/event-collector/issues/14","number":14,"state":"open","locked":false,"title":"Categorize graphite metrics by client key + Local dev environment setup","user":{"login":"spladug","id":338853,"avatar_url":"https://avatars.githubusercontent.com/u/338853?v=3","gravatar_id":"","url":"https://api.github.com/users/spladug","html_url":"https://github.com/spladug","followers_url":"https://api.github.com/users/spladug/followers","following_url":"https://api.github.com/users/spladug/following{/other_user}","gists_url":"https://api.github.com/users/spladug/gists{/gist_id}","starred_url":"https://api.github.com/users/spladug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spladug/subscriptions","organizations_url":"https://api.github.com/users/spladug/orgs","repos_url":"https://api.github.com/users/spladug/repos","events_url":"https://api.github.com/users/spladug/events{/privacy}","received_events_url":"https://api.github.com/users/spladug/received_events","type":"User","site_admin":false},"body":"Now that we have a bunch of clients, it's useful to break down metrics per client. This will make it so that event collection volume and error rates are both segmented by the auth key being used, effectively letting us see which client is doing what. Hopefully this helps diagnosis of event errors without having to dig into logs or kafka.\r\n\r\nI'll be doing another pull request to make the events going onto the error topic a bit more interesting as per IO-712.\r\n\r\n:eyeglasses: @ckwang8128 @dellis23 \r\n\r\ncc: @Kaitaan ","created_at":"2016-09-26T21:03:33Z","updated_at":"2016-09-26T21:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d56735e90827c81d4e3cd92e69bab65967178369","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reddit/event-collector/pulls/14/commits","review_comments_url":"https://api.github.com/repos/reddit/event-collector/pulls/14/comments","review_comment_url":"https://api.github.com/repos/reddit/event-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/event-collector/issues/14/comments","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/a2d5950d474617abe2f8b791955ce6091fcfe1a4","head":{"label":"reddit:error-tracking","ref":"error-tracking","sha":"a2d5950d474617abe2f8b791955ce6091fcfe1a4","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":31198028,"name":"event-collector","full_name":"reddit/event-collector","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/event-collector","description":"data collection service","fork":false,"url":"https://api.github.com/repos/reddit/event-collector","forks_url":"https://api.github.com/repos/reddit/event-collector/forks","keys_url":"https://api.github.com/repos/reddit/event-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/event-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/event-collector/teams","hooks_url":"https://api.github.com/repos/reddit/event-collector/hooks","issue_events_url":"https://api.github.com/repos/reddit/event-collector/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/event-collector/events","assignees_url":"https://api.github.com/repos/reddit/event-collector/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/event-collector/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/event-collector/tags","blobs_url":"https://api.github.com/repos/reddit/event-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/event-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/event-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/event-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/event-collector/languages","stargazers_url":"https://api.github.com/repos/reddit/event-collector/stargazers","contributors_url":"https://api.github.com/repos/reddit/event-collector/contributors","subscribers_url":"https://api.github.com/repos/reddit/event-collector/subscribers","subscription_url":"https://api.github.com/repos/reddit/event-collector/subscription","commits_url":"https://api.github.com/repos/reddit/event-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/event-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/event-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/event-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/event-collector/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/event-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/event-collector/merges","archive_url":"https://api.github.com/repos/reddit/event-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/event-collector/downloads","issues_url":"https://api.github.com/repos/reddit/event-collector/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/event-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/event-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/event-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/event-collector/labels{/name}","releases_url":"https://api.github.com/repos/reddit/event-collector/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/event-collector/deployments","created_at":"2015-02-23T07:32:03Z","updated_at":"2016-09-26T13:02:37Z","pushed_at":"2016-09-26T21:18:52Z","git_url":"git://github.com/reddit/event-collector.git","ssh_url":"git@github.com:reddit/event-collector.git","clone_url":"https://github.com/reddit/event-collector.git","svn_url":"https://github.com/reddit/event-collector","homepage":null,"size":62,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"b4513eee0248cb9c4b497519055340da50059e57","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":31198028,"name":"event-collector","full_name":"reddit/event-collector","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/event-collector","description":"data collection service","fork":false,"url":"https://api.github.com/repos/reddit/event-collector","forks_url":"https://api.github.com/repos/reddit/event-collector/forks","keys_url":"https://api.github.com/repos/reddit/event-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/event-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/event-collector/teams","hooks_url":"https://api.github.com/repos/reddit/event-collector/hooks","issue_events_url":"https://api.github.com/repos/reddit/event-collector/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/event-collector/events","assignees_url":"https://api.github.com/repos/reddit/event-collector/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/event-collector/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/event-collector/tags","blobs_url":"https://api.github.com/repos/reddit/event-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/event-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/event-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/event-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/event-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/event-collector/languages","stargazers_url":"https://api.github.com/repos/reddit/event-collector/stargazers","contributors_url":"https://api.github.com/repos/reddit/event-collector/contributors","subscribers_url":"https://api.github.com/repos/reddit/event-collector/subscribers","subscription_url":"https://api.github.com/repos/reddit/event-collector/subscription","commits_url":"https://api.github.com/repos/reddit/event-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/event-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/event-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/event-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/event-collector/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/event-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/event-collector/merges","archive_url":"https://api.github.com/repos/reddit/event-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/event-collector/downloads","issues_url":"https://api.github.com/repos/reddit/event-collector/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/event-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/event-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/event-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/event-collector/labels{/name}","releases_url":"https://api.github.com/repos/reddit/event-collector/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/event-collector/deployments","created_at":"2015-02-23T07:32:03Z","updated_at":"2016-09-26T13:02:37Z","pushed_at":"2016-09-26T21:18:52Z","git_url":"git://github.com/reddit/event-collector.git","ssh_url":"git@github.com:reddit/event-collector.git","clone_url":"https://github.com/reddit/event-collector.git","svn_url":"https://github.com/reddit/event-collector","homepage":null,"size":62,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/14"},"html":{"href":"https://github.com/reddit/event-collector/pull/14"},"issue":{"href":"https://api.github.com/repos/reddit/event-collector/issues/14"},"comments":{"href":"https://api.github.com/repos/reddit/event-collector/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/event-collector/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/event-collector/statuses/a2d5950d474617abe2f8b791955ce6091fcfe1a4"}}}}
{"actor":{"display_login":"spladug"}}