{"push_id":1294616915,"size":1,"distinct_size":1,"ref":"refs/heads/logging-prefix-by-wrapping","head":"f9112bf3e321d3cc05c0bf51a87fdfebc65d12e5","before":"9e13474f9b43a42755fc6dfbcc12200eb89f4862","commits":[{"sha":"f9112bf3e321d3cc05c0bf51a87fdfebc65d12e5","author":{"name":"Jason Tedor","email":"158e602a35675d2a0b685478824aa5995557a235@tedor.me"},"message":"Fix prefix logging\n\nToday we add a prefix when logging within Elasticsearch. This prefix\ncontains the node name, and index and shard-level components if\nappropriate.\n\nDue to some implementation details with Log4j 2 , this does not work for\nintegration tests; instead what we see is the node name for the last\nnode to startup. The implementation detail here is that Log4j 2 there is\nonly one logger for a name, message factory pair, and the key derived\nfrom the message factory is the class name of the message factory. So,\nwhen the last node starts up and starts setting prefixes on its message\nfactories, it will impact the loggers for the other nodes.\n\nAdditionally, the prefixes are lost when logging an exception. This is\ndue to another implementation detail in Log4j 2. Namely, since we log\nexceptions using a parameterized message, Log4j 2 decides that that\nmeans that we do not want to use the message factory that we have\nprovided (the prefix message factory) and so logs the exception without\nthe prefix.\n\nThis commit fixes both of these issues.","distinct":true,"url":"https://api.github.com/repos/jasontedor/elasticsearch/commits/f9112bf3e321d3cc05c0bf51a87fdfebc65d12e5"}]}
{"actor":{"display_login":"jasontedor"}}