{"action":"created","issue":{"url":"https://api.github.com/repos/wooorm/unified-engine/issues/2","repository_url":"https://api.github.com/repos/wooorm/unified-engine","labels_url":"https://api.github.com/repos/wooorm/unified-engine/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/wooorm/unified-engine/issues/2/comments","events_url":"https://api.github.com/repos/wooorm/unified-engine/issues/2/events","html_url":"https://github.com/wooorm/unified-engine/issues/2","id":160990385,"number":2,"title":"Allowing `node_modules`","user":{"login":"kgryte","id":2643044,"avatar_url":"https://avatars.githubusercontent.com/u/2643044?v=3","gravatar_id":"","url":"https://api.github.com/users/kgryte","html_url":"https://github.com/kgryte","followers_url":"https://api.github.com/users/kgryte/followers","following_url":"https://api.github.com/users/kgryte/following{/other_user}","gists_url":"https://api.github.com/users/kgryte/gists{/gist_id}","starred_url":"https://api.github.com/users/kgryte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgryte/subscriptions","organizations_url":"https://api.github.com/users/kgryte/orgs","repos_url":"https://api.github.com/users/kgryte/repos","events_url":"https://api.github.com/users/kgryte/events{/privacy}","received_events_url":"https://api.github.com/users/kgryte/received_events","type":"User","site_admin":false},"labels":[{"id":389715426,"url":"https://api.github.com/repos/wooorm/unified-engine/labels/enhancement","name":"enhancement","color":"859900","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-06-17T23:04:30Z","updated_at":"2016-12-27T09:06:22Z","closed_at":null,"body":"The blanket ban on _any_ path containing `node_modules` is problematic; see [finder.js](https://github.com/wooorm/unified-engine/blob/db7257f6320fe90344f59beb447e66b3f5c7c1ef/lib/finder.js#L40). Specifying whether files/paths should be ignored should be left to the `.remarkignore` file.\n\nFor instance, suppose I wanted to ignore only the top-level `node_modules` directory. My `.remarkignore` file (just as with a `.gitignore` file) would be\n\n```\n/node_modules/\n```\n\nIf I wanted to ignore all paths containing `node_modules`, I could do\n\n```\nnode_modules/\n**/node_modules\n```\n\nBut this is not how the `unified-engine` currently works. Instead, it just assumes that any path which has `node_modules` is off limits. This is problematic for project structures like\n\n```\nbin/\nlib/node_modules/\nlib/node_modules/**/node_modules/\nnode_modules/\ntest\n```\n\nwhere the top-level `node_modules` directory is reserved for external libraries and `lib` node modules directories are used for local modules. These local node modules are not in any sense \"external\" and will, for most cases, be considered part of the core library; e.g., tested and used like any other internal file.\n\nHence, I would suggest removing the blanket ban on `node_modules` and leave it to the user to specify if, and how, `node_modules` should be ignored.\n"},"comment":{"url":"https://api.github.com/repos/wooorm/unified-engine/issues/comments/269297575","html_url":"https://github.com/wooorm/unified-engine/issues/2#issuecomment-269297575","issue_url":"https://api.github.com/repos/wooorm/unified-engine/issues/2","id":269297575,"user":{"login":"kgryte","id":2643044,"avatar_url":"https://avatars.githubusercontent.com/u/2643044?v=3","gravatar_id":"","url":"https://api.github.com/users/kgryte","html_url":"https://github.com/kgryte","followers_url":"https://api.github.com/users/kgryte/followers","following_url":"https://api.github.com/users/kgryte/following{/other_user}","gists_url":"https://api.github.com/users/kgryte/gists{/gist_id}","starred_url":"https://api.github.com/users/kgryte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgryte/subscriptions","organizations_url":"https://api.github.com/users/kgryte/orgs","repos_url":"https://api.github.com/users/kgryte/repos","events_url":"https://api.github.com/users/kgryte/events{/privacy}","received_events_url":"https://api.github.com/users/kgryte/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T09:06:22Z","updated_at":"2016-12-27T09:06:22Z","body":"Will try and do so tomorrow."}}
{"actor":{"display_login":"kgryte"}}