{"action":"created","issue":{"url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/212","repository_url":"https://api.github.com/repos/nyanp/tiny-cnn","labels_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/212/comments","events_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/212/events","html_url":"https://github.com/nyanp/tiny-cnn/pull/212","id":163492956,"number":212,"title":"Cmake export config","user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-02T00:22:30Z","updated_at":"2016-07-06T09:38:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/212","html_url":"https://github.com/nyanp/tiny-cnn/pull/212","diff_url":"https://github.com/nyanp/tiny-cnn/pull/212.diff","patch_url":"https://github.com/nyanp/tiny-cnn/pull/212.patch"},"body":"- Reorganize CMake\r\n- Generate a proper summary\r\n- Export library configs\r\n- Add command to install library"},"comment":{"url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/comments/230725315","html_url":"https://github.com/nyanp/tiny-cnn/pull/212#issuecomment-230725315","issue_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/212","id":230725315,"user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T09:38:16Z","updated_at":"2016-07-06T09:38:16Z","body":"@vrabaud thx for the comments! I'll fix the inconsistencies you pointed out. \r\n\r\nSome considerations:\r\n- there's something wrong somewhere with the installed files since when the package is exported then an external `find_package` command finds the build/TinyCNNConfig.cmake instead of the build/install/share/tiny_cnn/TinyCNNConfig.cmake\r\n- regarding CMake versions, I think that there are specific macros for header-only projects that might fit for us (check this [project](https://github.com/nlohmann/json/blob/develop/CMakeLists.txt#L20-L37)). However, it requires a minimum CMake 3.x, backward compatibility will be a problem then. Any experience with that?\r\n\r\n@nyanp we need to find a policy for compiler flags setting and as @vrabaud the tests definition."}}
{"actor":{"display_login":"edgarriba"}}