{"action":"closed","number":146,"pull_request":{"url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146","id":73476800,"html_url":"https://github.com/symposion/roll20-shaped-scripts/pull/146","diff_url":"https://github.com/symposion/roll20-shaped-scripts/pull/146.diff","patch_url":"https://github.com/symposion/roll20-shaped-scripts/pull/146.patch","issue_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/146","number":146,"state":"closed","locked":false,"title":"changes based on sheet 4.2.1","user":{"login":"mlenser","id":235857,"avatar_url":"https://avatars.githubusercontent.com/u/235857?v=3","gravatar_id":"","url":"https://api.github.com/users/mlenser","html_url":"https://github.com/mlenser","followers_url":"https://api.github.com/users/mlenser/followers","following_url":"https://api.github.com/users/mlenser/following{/other_user}","gists_url":"https://api.github.com/users/mlenser/gists{/gist_id}","starred_url":"https://api.github.com/users/mlenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlenser/subscriptions","organizations_url":"https://api.github.com/users/mlenser/orgs","repos_url":"https://api.github.com/users/mlenser/repos","events_url":"https://api.github.com/users/mlenser/events{/privacy}","received_events_url":"https://api.github.com/users/mlenser/received_events","type":"User","site_admin":false},"body":"Hey Lucian,\r\n\r\nThere will also need to be a change of behavior in the auto-revert to not auto-revert when initiative or a skill rolls with advantage. That should only happen if they roll with advantage and the roll_setting is set appropriately.\r\n\r\n\"newCharSettings\" doesn't need to set default variables. This should actually be wiped out and each place that references this should check if the parameters exist or not.\r\n\r\nFeel free to make the necessary changes to anything I did here.\r\n\r\nTests all pass","created_at":"2016-06-11T19:51:06Z","updated_at":"2016-06-19T12:18:49Z","closed_at":"2016-06-19T12:18:49Z","merged_at":null,"merge_commit_sha":"76a6d7579b3a9265aa12ac444482f1253e14660d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146/commits","review_comments_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146/comments","review_comment_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/146/comments","statuses_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/statuses/e5b42a08d574c6647faeaca9ae893a7df8b751f1","head":{"label":"mlenser:master","ref":"master","sha":"e5b42a08d574c6647faeaca9ae893a7df8b751f1","user":{"login":"mlenser","id":235857,"avatar_url":"https://avatars.githubusercontent.com/u/235857?v=3","gravatar_id":"","url":"https://api.github.com/users/mlenser","html_url":"https://github.com/mlenser","followers_url":"https://api.github.com/users/mlenser/followers","following_url":"https://api.github.com/users/mlenser/following{/other_user}","gists_url":"https://api.github.com/users/mlenser/gists{/gist_id}","starred_url":"https://api.github.com/users/mlenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlenser/subscriptions","organizations_url":"https://api.github.com/users/mlenser/orgs","repos_url":"https://api.github.com/users/mlenser/repos","events_url":"https://api.github.com/users/mlenser/events{/privacy}","received_events_url":"https://api.github.com/users/mlenser/received_events","type":"User","site_admin":false},"repo":{"id":60924531,"name":"roll20-shaped-scripts","full_name":"mlenser/roll20-shaped-scripts","owner":{"login":"mlenser","id":235857,"avatar_url":"https://avatars.githubusercontent.com/u/235857?v=3","gravatar_id":"","url":"https://api.github.com/users/mlenser","html_url":"https://github.com/mlenser","followers_url":"https://api.github.com/users/mlenser/followers","following_url":"https://api.github.com/users/mlenser/following{/other_user}","gists_url":"https://api.github.com/users/mlenser/gists{/gist_id}","starred_url":"https://api.github.com/users/mlenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlenser/subscriptions","organizations_url":"https://api.github.com/users/mlenser/orgs","repos_url":"https://api.github.com/users/mlenser/repos","events_url":"https://api.github.com/users/mlenser/events{/privacy}","received_events_url":"https://api.github.com/users/mlenser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlenser/roll20-shaped-scripts","description":"Support script for 5e Shaped Character Sheet on Roll20.net","fork":true,"url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts","forks_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/forks","keys_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/teams","hooks_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/hooks","issue_events_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/events","assignees_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/tags","blobs_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/languages","stargazers_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/stargazers","contributors_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/contributors","subscribers_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/subscribers","subscription_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/subscription","commits_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/merges","archive_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/downloads","issues_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/labels{/name}","releases_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/mlenser/roll20-shaped-scripts/deployments","created_at":"2016-06-11T19:33:46Z","updated_at":"2016-06-11T19:33:47Z","pushed_at":"2016-06-11T19:50:24Z","git_url":"git://github.com/mlenser/roll20-shaped-scripts.git","ssh_url":"git@github.com:mlenser/roll20-shaped-scripts.git","clone_url":"https://github.com/mlenser/roll20-shaped-scripts.git","svn_url":"https://github.com/mlenser/roll20-shaped-scripts","homepage":"http://roll20.net/","size":341,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symposion:master","ref":"master","sha":"d53247be05eea7ae161b116bb1381756d3da8426","user":{"login":"symposion","id":625085,"avatar_url":"https://avatars.githubusercontent.com/u/625085?v=3","gravatar_id":"","url":"https://api.github.com/users/symposion","html_url":"https://github.com/symposion","followers_url":"https://api.github.com/users/symposion/followers","following_url":"https://api.github.com/users/symposion/following{/other_user}","gists_url":"https://api.github.com/users/symposion/gists{/gist_id}","starred_url":"https://api.github.com/users/symposion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symposion/subscriptions","organizations_url":"https://api.github.com/users/symposion/orgs","repos_url":"https://api.github.com/users/symposion/repos","events_url":"https://api.github.com/users/symposion/events{/privacy}","received_events_url":"https://api.github.com/users/symposion/received_events","type":"User","site_admin":false},"repo":{"id":56245705,"name":"roll20-shaped-scripts","full_name":"symposion/roll20-shaped-scripts","owner":{"login":"symposion","id":625085,"avatar_url":"https://avatars.githubusercontent.com/u/625085?v=3","gravatar_id":"","url":"https://api.github.com/users/symposion","html_url":"https://github.com/symposion","followers_url":"https://api.github.com/users/symposion/followers","following_url":"https://api.github.com/users/symposion/following{/other_user}","gists_url":"https://api.github.com/users/symposion/gists{/gist_id}","starred_url":"https://api.github.com/users/symposion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symposion/subscriptions","organizations_url":"https://api.github.com/users/symposion/orgs","repos_url":"https://api.github.com/users/symposion/repos","events_url":"https://api.github.com/users/symposion/events{/privacy}","received_events_url":"https://api.github.com/users/symposion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/symposion/roll20-shaped-scripts","description":"Support script for 5e Shaped Character Sheet on Roll20.net","fork":false,"url":"https://api.github.com/repos/symposion/roll20-shaped-scripts","forks_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/forks","keys_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/teams","hooks_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/hooks","issue_events_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/events","assignees_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/tags","blobs_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/languages","stargazers_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/stargazers","contributors_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/contributors","subscribers_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/subscribers","subscription_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/subscription","commits_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/merges","archive_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/downloads","issues_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/labels{/name}","releases_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/symposion/roll20-shaped-scripts/deployments","created_at":"2016-04-14T14:46:39Z","updated_at":"2016-04-17T22:04:57Z","pushed_at":"2016-06-19T12:15:41Z","git_url":"git://github.com/symposion/roll20-shaped-scripts.git","ssh_url":"git@github.com:symposion/roll20-shaped-scripts.git","clone_url":"https://github.com/symposion/roll20-shaped-scripts.git","svn_url":"https://github.com/symposion/roll20-shaped-scripts","homepage":"http://roll20.net/","size":334,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146"},"html":{"href":"https://github.com/symposion/roll20-shaped-scripts/pull/146"},"issue":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/146"},"comments":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/symposion/roll20-shaped-scripts/statuses/e5b42a08d574c6647faeaca9ae893a7df8b751f1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":47,"deletions":52,"changed_files":4}}
{"actor":{"display_login":"symposion"}}