{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-core/issues/430","repository_url":"https://api.github.com/repos/dimagi/commcare-core","labels_url":"https://api.github.com/repos/dimagi/commcare-core/issues/430/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-core/issues/430/comments","events_url":"https://api.github.com/repos/dimagi/commcare-core/issues/430/events","html_url":"https://github.com/dimagi/commcare-core/pull/430","id":184247960,"number":430,"title":"Allow super big strings to be serialized","user":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dimagi/commcare-core/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/dimagi/commcare-core/labels/don't%20pull","name":"don't pull","color":"f7c6c7"},{"url":"https://api.github.com/repos/dimagi/commcare-core/labels/ready%20for%20review","name":"ready for review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dimagi/commcare-core/milestones/9","html_url":"https://github.com/dimagi/commcare-core/milestones/commcare_2.31","labels_url":"https://api.github.com/repos/dimagi/commcare-core/milestones/9/labels","id":1985812,"number":9,"title":"commcare_2.31","description":null,"creator":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":22,"state":"open","created_at":"2016-09-06T10:06:44Z","updated_at":"2016-10-20T14:38:19Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-10-20T14:38:19Z","updated_at":"2016-10-20T18:12:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-core/pulls/430","html_url":"https://github.com/dimagi/commcare-core/pull/430","diff_url":"https://github.com/dimagi/commcare-core/pull/430.diff","patch_url":"https://github.com/dimagi/commcare-core/pull/430.patch"},"body":"There is a limitation in our serialization framework where strings over `65535` bytes cannot be serialized. The fix I've implemented checks the length of the string as bytes and dispatches to more robust serialization logic if the string is above the limit. This does not require a migration because of some sneaky uses of tagging. This does come with a limitation that if you try to directly read out a large string that was serialized using `readString`, it doesn't work. On the plus side, in the case of case properties, which are stored using `ExtWrapMapPoly`, everything works because `ExtWrapMapPoly` utilizes tags.\r\n\r\nTargeting 2.31, but can change it to master if we think the change is too big for 2.31.\r\n\r\nFix for http://manage.dimagi.com/default.asp?237711"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-core/issues/comments/255184279","html_url":"https://github.com/dimagi/commcare-core/pull/430#issuecomment-255184279","issue_url":"https://api.github.com/repos/dimagi/commcare-core/issues/430","id":255184279,"user":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T18:12:07Z","updated_at":"2016-10-20T18:12:07Z","body":"Closing out due to memory / runtime concerns"}}
{"actor":{"display_login":"phillipm"}}