{"action":"created","issue":{"url":"https://api.github.com/repos/davehunt/PyPOM/issues/4","labels_url":"https://api.github.com/repos/davehunt/PyPOM/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/davehunt/PyPOM/issues/4/comments","events_url":"https://api.github.com/repos/davehunt/PyPOM/issues/4/events","html_url":"https://github.com/davehunt/PyPOM/pull/4","id":126512847,"number":4,"title":"Address suggestions from the meeting of Jan 13","user":{"login":"bobsilverberg","id":142755,"avatar_url":"https://avatars.githubusercontent.com/u/142755?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsilverberg","html_url":"https://github.com/bobsilverberg","followers_url":"https://api.github.com/users/bobsilverberg/followers","following_url":"https://api.github.com/users/bobsilverberg/following{/other_user}","gists_url":"https://api.github.com/users/bobsilverberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsilverberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsilverberg/subscriptions","organizations_url":"https://api.github.com/users/bobsilverberg/orgs","repos_url":"https://api.github.com/users/bobsilverberg/repos","events_url":"https://api.github.com/users/bobsilverberg/events{/privacy}","received_events_url":"https://api.github.com/users/bobsilverberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-13T21:02:13Z","updated_at":"2016-01-13T21:38:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davehunt/PyPOM/pulls/4","html_url":"https://github.com/davehunt/PyPOM/pull/4","diff_url":"https://github.com/davehunt/PyPOM/pull/4.diff","patch_url":"https://github.com/davehunt/PyPOM/pull/4.patch"},"body":"Make base_url optional, and reorder arguments to place selenium first\r\nRename _url to URL_TEMPLATE\r\nRename url to target_url\r\nPrepend base_url to the result of URL_TEMPLATE if it does not result in an absolute URL\r\nRename kwargs to url_kwargs\r\nRemove timeout property and replace with an argument to WebView.__init__\r\nMove find_element* methods into Page and Region\r\nIn wait_for_page_to_load, only perform the URL check if target_url yields a value\r\nAdd/change tests for new/changed functionality"},"comment":{"url":"https://api.github.com/repos/davehunt/PyPOM/issues/comments/171442737","html_url":"https://github.com/davehunt/PyPOM/pull/4#issuecomment-171442737","issue_url":"https://api.github.com/repos/davehunt/PyPOM/issues/4","id":171442737,"user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T21:38:41Z","updated_at":"2016-01-13T21:38:41Z","body":"This is a little hard to review because there's so much changing. Could we at least get separate commits, if not separate pull requests? It will be easier then to discuss and iterate on them as I'm sure there's more bikeshedding to do. :smile: :bike: :house: :zap: "}}