{"action":"closed","number":3436,"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/3436","id":57006338,"html_url":"https://github.com/godotengine/godot/pull/3436","diff_url":"https://github.com/godotengine/godot/pull/3436.diff","patch_url":"https://github.com/godotengine/godot/pull/3436.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/3436","number":3436,"state":"closed","locked":false,"title":"Removed debugger X (hide) button","user":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars.githubusercontent.com/u/7718100?v=3","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"body":"The button stopped working after 74a48a0. I suppose the following change should fix it:\r\n\r\n``` diff\r\n@@ -783,7 +783,7 @@ void ScriptEditorDebugger::_stack_dump_frame_selected() {\r\n \r\n void ScriptEditorDebugger::_hide_request() {\r\n \r\n-\tif (EditorNode::get_log()->is_visible())\r\n+\tif (is_visible())\r\n \t\tEditorNode::get_singleton()->hide_bottom_panel();\r\n \temit_signal(\"show_debugger\",false);\r\n }\r\n```\r\n\r\nHowever, since now you can hide the debugger from the bottom bar, this button no longer makes sense, so I just removed it.\r\n\r\nCloses #3418","created_at":"2016-01-24T15:58:00Z","updated_at":"2016-01-25T10:02:27Z","closed_at":"2016-01-25T10:02:26Z","merged_at":"2016-01-25T10:02:26Z","merge_commit_sha":"1104f77332ace480afcf57f3d1fc6efd010d6c21","assignee":null,"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/1","html_url":"https://github.com/godotengine/godot/milestones/2.0","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/1/labels","id":1381437,"number":1,"title":"2.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":334,"state":"open","created_at":"2015-10-28T13:37:45Z","updated_at":"2016-01-25T10:02:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/3436/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/3436/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/3436/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/dd197cd6d3348dbe1b0f9a8190b10ec6c545df68","head":{"label":"neikeq:rm_dbg_x","ref":"rm_dbg_x","sha":"dd197cd6d3348dbe1b0f9a8190b10ec6c545df68","user":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars.githubusercontent.com/u/7718100?v=3","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"repo":{"id":31860636,"name":"godot","full_name":"neikeq/godot","owner":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars.githubusercontent.com/u/7718100?v=3","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neikeq/godot","description":"Godot Game Engine","fork":true,"url":"https://api.github.com/repos/neikeq/godot","forks_url":"https://api.github.com/repos/neikeq/godot/forks","keys_url":"https://api.github.com/repos/neikeq/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neikeq/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neikeq/godot/teams","hooks_url":"https://api.github.com/repos/neikeq/godot/hooks","issue_events_url":"https://api.github.com/repos/neikeq/godot/issues/events{/number}","events_url":"https://api.github.com/repos/neikeq/godot/events","assignees_url":"https://api.github.com/repos/neikeq/godot/assignees{/user}","branches_url":"https://api.github.com/repos/neikeq/godot/branches{/branch}","tags_url":"https://api.github.com/repos/neikeq/godot/tags","blobs_url":"https://api.github.com/repos/neikeq/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neikeq/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neikeq/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/neikeq/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neikeq/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/neikeq/godot/languages","stargazers_url":"https://api.github.com/repos/neikeq/godot/stargazers","contributors_url":"https://api.github.com/repos/neikeq/godot/contributors","subscribers_url":"https://api.github.com/repos/neikeq/godot/subscribers","subscription_url":"https://api.github.com/repos/neikeq/godot/subscription","commits_url":"https://api.github.com/repos/neikeq/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/neikeq/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/neikeq/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/neikeq/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/neikeq/godot/contents/{+path}","compare_url":"https://api.github.com/repos/neikeq/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neikeq/godot/merges","archive_url":"https://api.github.com/repos/neikeq/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neikeq/godot/downloads","issues_url":"https://api.github.com/repos/neikeq/godot/issues{/number}","pulls_url":"https://api.github.com/repos/neikeq/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/neikeq/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/neikeq/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neikeq/godot/labels{/name}","releases_url":"https://api.github.com/repos/neikeq/godot/releases{/id}","deployments_url":"https://api.github.com/repos/neikeq/godot/deployments","created_at":"2015-03-08T18:35:47Z","updated_at":"2015-03-29T19:48:23Z","pushed_at":"2016-01-24T15:45:15Z","git_url":"git://github.com/neikeq/godot.git","ssh_url":"git@github.com:neikeq/godot.git","clone_url":"https://github.com/neikeq/godot.git","svn_url":"https://github.com/neikeq/godot","homepage":null,"size":71291,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"35a28f34426eb6c44a5e321bbd630c64d8b38de0","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Game Engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2016-01-25T09:30:57Z","pushed_at":"2016-01-25T10:02:26Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":null,"size":107121,"stargazers_count":5020,"watchers_count":5020,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1337,"mirror_url":null,"open_issues_count":660,"forks":1337,"open_issues":660,"watchers":5020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3436"},"html":{"href":"https://github.com/godotengine/godot/pull/3436"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/3436"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/3436/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3436/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3436/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/dd197cd6d3348dbe1b0f9a8190b10ec6c545df68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":0,"deletions":22,"changed_files":2}}