{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2325","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2325/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2325/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2325/events","html_url":"https://github.com/RobotLocomotion/drake/pull/2325","id":154351596,"number":2325,"title":"Fix some issues with RigidBodyConstraint not conforming to the style guide.","user":{"login":"sammy-tri","id":17596504,"avatar_url":"https://avatars.githubusercontent.com/u/17596504?v=3","gravatar_id":"","url":"https://api.github.com/users/sammy-tri","html_url":"https://github.com/sammy-tri","followers_url":"https://api.github.com/users/sammy-tri/followers","following_url":"https://api.github.com/users/sammy-tri/following{/other_user}","gists_url":"https://api.github.com/users/sammy-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy-tri/subscriptions","organizations_url":"https://api.github.com/users/sammy-tri/orgs","repos_url":"https://api.github.com/users/sammy-tri/repos","events_url":"https://api.github.com/users/sammy-tri/events{/privacy}","received_events_url":"https://api.github.com/users/sammy-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-11T21:52:45Z","updated_at":"2016-05-12T15:55:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/2325","html_url":"https://github.com/RobotLocomotion/drake/pull/2325","diff_url":"https://github.com/RobotLocomotion/drake/pull/2325.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/2325.patch"},"body":"Fixes #2306...   well, partly.  I could, I think, spend days cleaning up in there.  But it fixes the spacing issue identified there along with access controls and variable names.  I did not get to function names, namespaces, etc...\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/2325)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/218801833","html_url":"https://github.com/RobotLocomotion/drake/pull/2325#issuecomment-218801833","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2325","id":218801833,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T15:55:23Z","updated_at":"2016-05-12T15:55:23Z","body":"\n\n\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[drake/systems/plants/constraint/RigidBodyConstraint.h, line 73 \\[r1\\]](https://reviewable.io:443/reviews/robotlocomotion/drake/2325#-KH_Oko_Pb7nzuApwoyP:-KH_fDSRBGLutaB2lXWw:959837684) ([raw file](https://github.com/robotlocomotion/drake/blob/25de4752690b67ae1353fada6cc8b7773b313cfd/drake/systems/plants/constraint/RigidBodyConstraint.h#L73)):*\n<details><summary><i>Previously, liangfok (Chien-Liang Fok) wrote…</i></summary>\n> I believe the ability to create a \"batch of 1 of N style fixes\" where each element in the batch is \"small\" is in conflict with the fact that it's difficult, if not impossible, to undergo a rational process when creating a new feature. Perhaps this gets back to my other post about needing to first charge forward developing a new feature, then go back and \"fake\" a batch of 1-N incremental and rational changes that eventually lead up to the new feature being integrated into master.</details>\nBut this PR isn't a feature.  It's _only_ a style fix, for which there is a well-known checklist to traverse (the list of rules), and a clear intermediate pass criteria (CI passes and every edit is a strict improvement).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/2325)*\n<!-- Sent from Reviewable.io -->\n"}}