{"action":"closed","number":1655,"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655","id":90028492,"html_url":"https://github.com/webdriverio/webdriverio/pull/1655","diff_url":"https://github.com/webdriverio/webdriverio/pull/1655.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/1655.patch","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1655","number":1655,"state":"closed","locked":false,"title":"fix 2 errors reported by eslint:target","user":{"login":"fustic","id":1506504,"avatar_url":"https://avatars.githubusercontent.com/u/1506504?v=3","gravatar_id":"","url":"https://api.github.com/users/fustic","html_url":"https://github.com/fustic","followers_url":"https://api.github.com/users/fustic/followers","following_url":"https://api.github.com/users/fustic/following{/other_user}","gists_url":"https://api.github.com/users/fustic/gists{/gist_id}","starred_url":"https://api.github.com/users/fustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fustic/subscriptions","organizations_url":"https://api.github.com/users/fustic/orgs","repos_url":"https://api.github.com/users/fustic/repos","events_url":"https://api.github.com/users/fustic/events{/privacy}","received_events_url":"https://api.github.com/users/fustic/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nI cloned the repo and run ```npm install```. It appeared that eslint:target failed on 2 lines.\r\nI fixed them according to eslint rules.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce to WebdriverIO?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [x] I have read the [CONTRIBUTING](/CONTRIBUTING.md) doc\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\n### Reviewers: @christian-bromann\r\n\r\n","created_at":"2016-10-19T15:04:28Z","updated_at":"2016-10-19T15:43:11Z","closed_at":"2016-10-19T15:43:11Z","merged_at":"2016-10-19T15:43:11Z","merge_commit_sha":"64fd7c0e062d72adfd0d45cdd1a5ea266851ba8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655/commits","review_comments_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655/comments","review_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1655/comments","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/032e717e8a4d19f4a19a3aed11e49908e88d4fc0","head":{"label":"fustic:master","ref":"master","sha":"032e717e8a4d19f4a19a3aed11e49908e88d4fc0","user":{"login":"fustic","id":1506504,"avatar_url":"https://avatars.githubusercontent.com/u/1506504?v=3","gravatar_id":"","url":"https://api.github.com/users/fustic","html_url":"https://github.com/fustic","followers_url":"https://api.github.com/users/fustic/followers","following_url":"https://api.github.com/users/fustic/following{/other_user}","gists_url":"https://api.github.com/users/fustic/gists{/gist_id}","starred_url":"https://api.github.com/users/fustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fustic/subscriptions","organizations_url":"https://api.github.com/users/fustic/orgs","repos_url":"https://api.github.com/users/fustic/repos","events_url":"https://api.github.com/users/fustic/events{/privacy}","received_events_url":"https://api.github.com/users/fustic/received_events","type":"User","site_admin":false},"repo":{"id":71368806,"name":"webdriverio","full_name":"fustic/webdriverio","owner":{"login":"fustic","id":1506504,"avatar_url":"https://avatars.githubusercontent.com/u/1506504?v=3","gravatar_id":"","url":"https://api.github.com/users/fustic","html_url":"https://github.com/fustic","followers_url":"https://api.github.com/users/fustic/followers","following_url":"https://api.github.com/users/fustic/following{/other_user}","gists_url":"https://api.github.com/users/fustic/gists{/gist_id}","starred_url":"https://api.github.com/users/fustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fustic/subscriptions","organizations_url":"https://api.github.com/users/fustic/orgs","repos_url":"https://api.github.com/users/fustic/repos","events_url":"https://api.github.com/users/fustic/events{/privacy}","received_events_url":"https://api.github.com/users/fustic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fustic/webdriverio","description":"Webdriver/Selenium 2.0 JavaScript bindings for Node.js","fork":true,"url":"https://api.github.com/repos/fustic/webdriverio","forks_url":"https://api.github.com/repos/fustic/webdriverio/forks","keys_url":"https://api.github.com/repos/fustic/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fustic/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fustic/webdriverio/teams","hooks_url":"https://api.github.com/repos/fustic/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/fustic/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/fustic/webdriverio/events","assignees_url":"https://api.github.com/repos/fustic/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/fustic/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/fustic/webdriverio/tags","blobs_url":"https://api.github.com/repos/fustic/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fustic/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fustic/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/fustic/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fustic/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/fustic/webdriverio/languages","stargazers_url":"https://api.github.com/repos/fustic/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/fustic/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/fustic/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/fustic/webdriverio/subscription","commits_url":"https://api.github.com/repos/fustic/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/fustic/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/fustic/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/fustic/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/fustic/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/fustic/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fustic/webdriverio/merges","archive_url":"https://api.github.com/repos/fustic/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fustic/webdriverio/downloads","issues_url":"https://api.github.com/repos/fustic/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/fustic/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/fustic/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/fustic/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fustic/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/fustic/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/fustic/webdriverio/deployments","created_at":"2016-10-19T14:59:26Z","updated_at":"2016-10-19T14:59:28Z","pushed_at":"2016-10-19T15:01:09Z","git_url":"git://github.com/fustic/webdriverio.git","ssh_url":"git@github.com:fustic/webdriverio.git","clone_url":"https://github.com/fustic/webdriverio.git","svn_url":"https://github.com/fustic/webdriverio","homepage":"www.webdriver.io","size":127480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webdriverio:master","ref":"master","sha":"504f9fc73e54146123a49ae439f885f175562f5e","user":{"login":"webdriverio","id":6512473,"avatar_url":"https://avatars.githubusercontent.com/u/6512473?v=3","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"repo":{"id":2296970,"name":"webdriverio","full_name":"webdriverio/webdriverio","owner":{"login":"webdriverio","id":6512473,"avatar_url":"https://avatars.githubusercontent.com/u/6512473?v=3","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webdriverio/webdriverio","description":"Webdriver/Selenium 2.0 JavaScript bindings for Node.js","fork":false,"url":"https://api.github.com/repos/webdriverio/webdriverio","forks_url":"https://api.github.com/repos/webdriverio/webdriverio/forks","keys_url":"https://api.github.com/repos/webdriverio/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio/webdriverio/teams","hooks_url":"https://api.github.com/repos/webdriverio/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio/webdriverio/events","assignees_url":"https://api.github.com/repos/webdriverio/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio/webdriverio/tags","blobs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio/webdriverio/languages","stargazers_url":"https://api.github.com/repos/webdriverio/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/webdriverio/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/webdriverio/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/webdriverio/webdriverio/subscription","commits_url":"https://api.github.com/repos/webdriverio/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio/webdriverio/merges","archive_url":"https://api.github.com/repos/webdriverio/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio/webdriverio/downloads","issues_url":"https://api.github.com/repos/webdriverio/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio/webdriverio/deployments","created_at":"2011-08-30T19:02:35Z","updated_at":"2016-10-19T08:55:13Z","pushed_at":"2016-10-19T15:43:11Z","git_url":"git://github.com/webdriverio/webdriverio.git","ssh_url":"git@github.com:webdriverio/webdriverio.git","clone_url":"https://github.com/webdriverio/webdriverio.git","svn_url":"https://github.com/webdriverio/webdriverio","homepage":"www.webdriver.io","size":127480,"stargazers_count":2316,"watchers_count":2316,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":614,"mirror_url":null,"open_issues_count":64,"forks":614,"open_issues":64,"watchers":2316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655"},"html":{"href":"https://github.com/webdriverio/webdriverio/pull/1655"},"issue":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/1655"},"comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/1655/comments"},"review_comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655/comments"},"review_comment":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1655/commits"},"statuses":{"href":"https://api.github.com/repos/webdriverio/webdriverio/statuses/032e717e8a4d19f4a19a3aed11e49908e88d4fc0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"christian-bromann","id":731337,"avatar_url":"https://avatars.githubusercontent.com/u/731337?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"christian-bromann"}}