{"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/micropython/micropython-lib/pulls/88","id":80447393,"html_url":"https://github.com/micropython/micropython-lib/pull/88","diff_url":"https://github.com/micropython/micropython-lib/pull/88.diff","patch_url":"https://github.com/micropython/micropython-lib/pull/88.patch","issue_url":"https://api.github.com/repos/micropython/micropython-lib/issues/88","number":88,"state":"closed","locked":false,"title":"umqtt.simple: do not close the socket in ping()","user":{"login":"puuu","id":19514939,"avatar_url":"https://avatars.githubusercontent.com/u/19514939?v=3","gravatar_id":"","url":"https://api.github.com/users/puuu","html_url":"https://github.com/puuu","followers_url":"https://api.github.com/users/puuu/followers","following_url":"https://api.github.com/users/puuu/following{/other_user}","gists_url":"https://api.github.com/users/puuu/gists{/gist_id}","starred_url":"https://api.github.com/users/puuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puuu/subscriptions","organizations_url":"https://api.github.com/users/puuu/orgs","repos_url":"https://api.github.com/users/puuu/repos","events_url":"https://api.github.com/users/puuu/events{/privacy}","received_events_url":"https://api.github.com/users/puuu/received_events","type":"User","site_admin":false},"body":"IMHO there is no need to close the socket in `ping()` and it  break the MQTT connection.","created_at":"2016-08-08T13:05:46Z","updated_at":"2016-08-10T19:04:50Z","closed_at":"2016-08-10T19:04:50Z","merged_at":"2016-08-10T19:04:50Z","merge_commit_sha":"a261f4b4d71518f2612754a851eb9bd4e8271fca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython-lib/pulls/88/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython-lib/pulls/88/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython-lib/issues/88/comments","statuses_url":"https://api.github.com/repos/micropython/micropython-lib/statuses/a261f4b4d71518f2612754a851eb9bd4e8271fca","head":{"label":"puuu:umqtt-ping","ref":"umqtt-ping","sha":"a261f4b4d71518f2612754a851eb9bd4e8271fca","user":{"login":"puuu","id":19514939,"avatar_url":"https://avatars.githubusercontent.com/u/19514939?v=3","gravatar_id":"","url":"https://api.github.com/users/puuu","html_url":"https://github.com/puuu","followers_url":"https://api.github.com/users/puuu/followers","following_url":"https://api.github.com/users/puuu/following{/other_user}","gists_url":"https://api.github.com/users/puuu/gists{/gist_id}","starred_url":"https://api.github.com/users/puuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puuu/subscriptions","organizations_url":"https://api.github.com/users/puuu/orgs","repos_url":"https://api.github.com/users/puuu/repos","events_url":"https://api.github.com/users/puuu/events{/privacy}","received_events_url":"https://api.github.com/users/puuu/received_events","type":"User","site_admin":false},"repo":{"id":64230235,"name":"micropython-lib","full_name":"puuu/micropython-lib","owner":{"login":"puuu","id":19514939,"avatar_url":"https://avatars.githubusercontent.com/u/19514939?v=3","gravatar_id":"","url":"https://api.github.com/users/puuu","html_url":"https://github.com/puuu","followers_url":"https://api.github.com/users/puuu/followers","following_url":"https://api.github.com/users/puuu/following{/other_user}","gists_url":"https://api.github.com/users/puuu/gists{/gist_id}","starred_url":"https://api.github.com/users/puuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puuu/subscriptions","organizations_url":"https://api.github.com/users/puuu/orgs","repos_url":"https://api.github.com/users/puuu/repos","events_url":"https://api.github.com/users/puuu/events{/privacy}","received_events_url":"https://api.github.com/users/puuu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/puuu/micropython-lib","description":"Core Python libraries ported to MicroPython","fork":true,"url":"https://api.github.com/repos/puuu/micropython-lib","forks_url":"https://api.github.com/repos/puuu/micropython-lib/forks","keys_url":"https://api.github.com/repos/puuu/micropython-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puuu/micropython-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puuu/micropython-lib/teams","hooks_url":"https://api.github.com/repos/puuu/micropython-lib/hooks","issue_events_url":"https://api.github.com/repos/puuu/micropython-lib/issues/events{/number}","events_url":"https://api.github.com/repos/puuu/micropython-lib/events","assignees_url":"https://api.github.com/repos/puuu/micropython-lib/assignees{/user}","branches_url":"https://api.github.com/repos/puuu/micropython-lib/branches{/branch}","tags_url":"https://api.github.com/repos/puuu/micropython-lib/tags","blobs_url":"https://api.github.com/repos/puuu/micropython-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puuu/micropython-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puuu/micropython-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/puuu/micropython-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puuu/micropython-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/puuu/micropython-lib/languages","stargazers_url":"https://api.github.com/repos/puuu/micropython-lib/stargazers","contributors_url":"https://api.github.com/repos/puuu/micropython-lib/contributors","subscribers_url":"https://api.github.com/repos/puuu/micropython-lib/subscribers","subscription_url":"https://api.github.com/repos/puuu/micropython-lib/subscription","commits_url":"https://api.github.com/repos/puuu/micropython-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/puuu/micropython-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/puuu/micropython-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/puuu/micropython-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/puuu/micropython-lib/contents/{+path}","compare_url":"https://api.github.com/repos/puuu/micropython-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puuu/micropython-lib/merges","archive_url":"https://api.github.com/repos/puuu/micropython-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puuu/micropython-lib/downloads","issues_url":"https://api.github.com/repos/puuu/micropython-lib/issues{/number}","pulls_url":"https://api.github.com/repos/puuu/micropython-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/puuu/micropython-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/puuu/micropython-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puuu/micropython-lib/labels{/name}","releases_url":"https://api.github.com/repos/puuu/micropython-lib/releases{/id}","deployments_url":"https://api.github.com/repos/puuu/micropython-lib/deployments","created_at":"2016-07-26T14:57:37Z","updated_at":"2016-07-26T14:57:39Z","pushed_at":"2016-08-09T06:30:16Z","git_url":"git://github.com/puuu/micropython-lib.git","ssh_url":"git@github.com:puuu/micropython-lib.git","clone_url":"https://github.com/puuu/micropython-lib.git","svn_url":"https://github.com/puuu/micropython-lib","homepage":"","size":842,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"9f7b60bedef527eb0ba8474a87edb1ec070b6384","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":18326156,"name":"micropython-lib","full_name":"micropython/micropython-lib","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython-lib","description":"Core Python libraries ported to MicroPython","fork":false,"url":"https://api.github.com/repos/micropython/micropython-lib","forks_url":"https://api.github.com/repos/micropython/micropython-lib/forks","keys_url":"https://api.github.com/repos/micropython/micropython-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython-lib/teams","hooks_url":"https://api.github.com/repos/micropython/micropython-lib/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython-lib/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython-lib/events","assignees_url":"https://api.github.com/repos/micropython/micropython-lib/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython-lib/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython-lib/tags","blobs_url":"https://api.github.com/repos/micropython/micropython-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython-lib/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython-lib/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython-lib/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython-lib/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython-lib/subscription","commits_url":"https://api.github.com/repos/micropython/micropython-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython-lib/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython-lib/merges","archive_url":"https://api.github.com/repos/micropython/micropython-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython-lib/downloads","issues_url":"https://api.github.com/repos/micropython/micropython-lib/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython-lib/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython-lib/releases{/id}","deployments_url":"https://api.github.com/repos/micropython/micropython-lib/deployments","created_at":"2014-04-01T10:47:14Z","updated_at":"2016-08-08T20:47:54Z","pushed_at":"2016-08-10T19:04:50Z","git_url":"git://github.com/micropython/micropython-lib.git","ssh_url":"git@github.com:micropython/micropython-lib.git","clone_url":"https://github.com/micropython/micropython-lib.git","svn_url":"https://github.com/micropython/micropython-lib","homepage":"","size":1280,"stargazers_count":182,"watchers_count":182,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":21,"forks":82,"open_issues":21,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython-lib/pulls/88"},"html":{"href":"https://github.com/micropython/micropython-lib/pull/88"},"issue":{"href":"https://api.github.com/repos/micropython/micropython-lib/issues/88"},"comments":{"href":"https://api.github.com/repos/micropython/micropython-lib/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython-lib/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython-lib/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython-lib/statuses/a261f4b4d71518f2612754a851eb9bd4e8271fca"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"pfalcon"}}