{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/63222818","id":63222818,"diff_hunk":"@@ -100,8 +100,8 @@\n   hosts: oo_masters_to_config:oo_nodes_to_config\n   vars:\n     target_version: \"{{ '1.2' if deployment_type == 'origin' else '3.1.1.900' }}\"\n-    openshift_docker_hosted_registry_insecure: True\n-    openshift_docker_hosted_registry_network: \"{{ hostvars[groups.oo_first_master.0].openshift.common.portal_net }}\"\n+    docker_hosted_registry_insecure: \"{{ openshift_docker_hosted_registry_insecure | default(True) }}\"","path":"playbooks/common/openshift-cluster/upgrades/v3_1_to_v3_2/pre.yml","position":6,"original_position":6,"commit_id":"687c5a11c876069f791ffdc9f025e1b1092f7e18","original_commit_id":"687c5a11c876069f791ffdc9f025e1b1092f7e18","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"> I think we could remove all openshift_docker_hosted_registry_insecure settings from playbooks and let openshift_docker_facts default the variable to True OR we could default to True wherever the value is accessed if the intent was to not persist this fact when the user didn't provide it.\r\n\r\nOr we could default it to false in openshift_facts. I believe we need to make sure that this setting doesn't get exposed directly in the docker role, since it is an OpenShift specific configuration item, the hosted registry belongs to OpenShift (openshift_docker) and not Docker.","created_at":"2016-05-13T17:44:35Z","updated_at":"2016-05-13T17:44:35Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1880#discussion_r63222818","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/63222818"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1880#discussion_r63222818"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880","id":69731189,"html_url":"https://github.com/openshift/openshift-ansible/pull/1880","diff_url":"https://github.com/openshift/openshift-ansible/pull/1880.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1880.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1880","number":1880,"state":"open","locked":false,"title":"Fixes for openshift_docker_hosted_registry_insecure var.","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"Fixes a failure on masters if you explicitly set\r\nopenshift_docker_hosted_registry_insecure=true. This is the default but\r\nif you tried to set it an error would trigger as a relevant variable was\r\nnot passed in the master playbooks.\r\n\r\nFixes setting the variable to false being ignored.\r\nmaster/node playbooks were referencing the docker fact, which was not\r\nset at that point and thus we were always getting the default of true,\r\nregardless what was in your inventory.\r\n\r\nIt felt like in playbooks we should instead reference inventory vars,\r\nrather than rely on more fact loading. This however led to a circular\r\nreference because the variable was being passed as the same name as the\r\ninventory variable. As such the internal variable name has been changed\r\nto avoid this.","created_at":"2016-05-11T19:49:28Z","updated_at":"2016-05-13T17:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0d3d61d2b39cb8c3d4780d3de07903a277813ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1880/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/687c5a11c876069f791ffdc9f025e1b1092f7e18","head":{"label":"dgoodwin:registry-insecure","ref":"registry-insecure","sha":"687c5a11c876069f791ffdc9f025e1b1092f7e18","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"repo":{"id":43770383,"name":"openshift-ansible","full_name":"dgoodwin/openshift-ansible","owner":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgoodwin/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/dgoodwin/openshift-ansible","forks_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/forks","keys_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/events","assignees_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/merges","archive_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/dgoodwin/openshift-ansible/deployments","created_at":"2015-10-06T18:30:27Z","updated_at":"2016-04-15T18:36:05Z","pushed_at":"2016-05-13T11:42:33Z","git_url":"git://github.com/dgoodwin/openshift-ansible.git","ssh_url":"git@github.com:dgoodwin/openshift-ansible.git","clone_url":"https://github.com/dgoodwin/openshift-ansible.git","svn_url":"https://github.com/dgoodwin/openshift-ansible","homepage":"","size":4658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"45e5e99b1d8d155a9680f1ac00ac5fb8cfab8bec","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-05-11T07:28:55Z","pushed_at":"2016-05-13T17:38:44Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":6273,"stargazers_count":166,"watchers_count":166,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":293,"forks":292,"open_issues":293,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1880"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1880"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1880/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1880/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/687c5a11c876069f791ffdc9f025e1b1092f7e18"}}}}