{"action":"created","issue":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/502","repository_url":"https://api.github.com/repos/farkam135/GoIV","labels_url":"https://api.github.com/repos/farkam135/GoIV/issues/502/labels{/name}","comments_url":"https://api.github.com/repos/farkam135/GoIV/issues/502/comments","events_url":"https://api.github.com/repos/farkam135/GoIV/issues/502/events","html_url":"https://github.com/farkam135/GoIV/pull/502","id":180544378,"number":502,"title":"Candy cost identification v3","user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-10-03T00:01:56Z","updated_at":"2016-10-15T09:03:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/farkam135/GoIV/pulls/502","html_url":"https://github.com/farkam135/GoIV/pull/502","diff_url":"https://github.com/farkam135/GoIV/pull/502.diff","patch_url":"https://github.com/farkam135/GoIV/pull/502.patch"},"body":"Supersedes #408 and #431. I rebased #431 on master, used the new version of `replaceColors` and added Checkstyle fixes."},"comment":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/comments/253972153","html_url":"https://github.com/farkam135/GoIV/pull/502#issuecomment-253972153","issue_url":"https://api.github.com/repos/farkam135/GoIV/issues/502","id":253972153,"user":{"login":"nahojjjen","id":8545451,"avatar_url":"https://avatars.githubusercontent.com/u/8545451?v=3","gravatar_id":"","url":"https://api.github.com/users/nahojjjen","html_url":"https://github.com/nahojjjen","followers_url":"https://api.github.com/users/nahojjjen/followers","following_url":"https://api.github.com/users/nahojjjen/following{/other_user}","gists_url":"https://api.github.com/users/nahojjjen/gists{/gist_id}","starred_url":"https://api.github.com/users/nahojjjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nahojjjen/subscriptions","organizations_url":"https://api.github.com/users/nahojjjen/orgs","repos_url":"https://api.github.com/users/nahojjjen/repos","events_url":"https://api.github.com/users/nahojjjen/events{/privacy}","received_events_url":"https://api.github.com/users/nahojjjen/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T09:03:20Z","updated_at":"2016-10-15T09:03:20Z","body":"Regarding user corrections, I think they should be added in before stage 4.\r\n\r\n     * 1. check if the nickname perfectly matches a pokemon\r\n     * 2. check if candyname + evolution cost perfectly matches a pokemon\r\n     * 3. check if there's a cached result for the scanned pokemon name\r\n     * 4. get the pokemon with the closest name within the evolution line guessed from the candy\r\n\r\nSo the new logic would be \r\n\r\n\r\n     * 1. check if the nickname perfectly matches a pokemon\r\n     * 2. check if candyname + evolution cost perfectly matches a pokemon\r\n     * 3. check if there's a cached result for the scanned pokemon name\r\n     * 3. check if there's a stored user correction\r\n     * 5 get the pokemon with the closest name within the evolution line guessed from the candy\r\n\r\n\r\nUser corrections should not take priority over step 1 & 2, they are \"perfect identifiers\" & \"fail silent\" modules. The first check  can only result in service failure if the user manually renamed a pokemon to another pokemon name, and the risk of the second module giving erroneous data is extremely low (It's also fail-silent). \r\n\r\nIf we add user corrections as step 1, it causes errorous results every time a pokemon has the same name as another, which is one of the things this new identification module was suppsed to solve. \r\nFor example the described scenario in https://www.reddit.com/r/GoIV/comments/57dsl1/320_offline_build_no_longer_scans_renamed_pokemon/d8rqyrk breaks if user corrections are considered most important.\r\n\r\n\r\nBasically we have different guessing modules, and they're all supposed to be fail silent except the last one, and the modules should be called in order of accuracy. Stored name corrections is not accurate, because it will have a collision every time a user has the same nickname for two different pokemon, which happens quite often.\r\n\r\n\r\n"}}
{"actor":{"display_login":"nahojjjen"}}