{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/ansible/pulls/comments/66834648","id":66834648,"diff_hunk":"@@ -0,0 +1,36 @@\n+---\n+- name: install nfs server (redhat)\n+  yum: \"update_cache=yes name={{ item }}\"\n+  with_items:\n+    - nfs-utils\n+    - libnfsidmap\n+  when: ansible_os_family == \"RedHat\"\n+\n+- name: install nfs server (debian)\n+  apt: \"update_cache=yes name={{ item }}\"\n+  with_items:\n+    - nfs-kernel-server\n+    - rpcbind\n+  when: ansible_os_family == \"Debian\"\n+\n+- name: enable nfs server services (redhat)\n+  service: \"name={{item}} enabled=yes\"","path":"roles/nfs/tasks/server.yml","position":17,"original_position":17,"commit_id":"95364544c1326cdd8c4b643041e94ed14b7440df","original_commit_id":"95364544c1326cdd8c4b643041e94ed14b7440df","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"body":"thinking more, we should perhaps not enable these services as it will run them automatically at reboot. This will cause incorrect behavior if the node was decommissioned and cleaned-up earlier. wdyt?\r\n\r\nAs of now we don't enable (non-base) services by default as that ensures when a node get's rebooted (i.e. disappears from cluster), it can be brought back into cluster by cluster-manager which will ensure pushing the configuration as per the current cluster state.\r\n\r\nAlso, may be slightly unrelated if there are multiple masters, is it safe to start nfs-server on all nodes?","created_at":"2016-06-13T17:40:26Z","updated_at":"2016-06-13T17:40:26Z","html_url":"https://github.com/contiv/ansible/pull/225#discussion_r66834648","pull_request_url":"https://api.github.com/repos/contiv/ansible/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/contiv/ansible/pulls/comments/66834648"},"html":{"href":"https://github.com/contiv/ansible/pull/225#discussion_r66834648"},"pull_request":{"href":"https://api.github.com/repos/contiv/ansible/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/ansible/pulls/225","id":73542029,"html_url":"https://github.com/contiv/ansible/pull/225","diff_url":"https://github.com/contiv/ansible/pull/225.diff","patch_url":"https://github.com/contiv/ansible/pull/225.patch","issue_url":"https://api.github.com/repos/contiv/ansible/issues/225","number":225,"state":"open","locked":false,"title":"install and start services required for nfs","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"body":"* Installs the necessary packages for nfs for (redhat and debian)\r\n* Start the necessary services for nfs (redhat and debian)\r\n* `cleanup.yml` will stop the services that were started earlier.\r\n","created_at":"2016-06-13T09:00:28Z","updated_at":"2016-06-13T17:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc45d9c16ce4b93062ebfc569982e5fcd606dd2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/ansible/pulls/225/commits","review_comments_url":"https://api.github.com/repos/contiv/ansible/pulls/225/comments","review_comment_url":"https://api.github.com/repos/contiv/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/ansible/issues/225/comments","statuses_url":"https://api.github.com/repos/contiv/ansible/statuses/95364544c1326cdd8c4b643041e94ed14b7440df","head":{"label":"vvb:nfs","ref":"nfs","sha":"95364544c1326cdd8c4b643041e94ed14b7440df","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"repo":{"id":51621962,"name":"ansible","full_name":"vvb/ansible","owner":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvb/ansible","description":"ansible scripts for contiv cluster","fork":true,"url":"https://api.github.com/repos/vvb/ansible","forks_url":"https://api.github.com/repos/vvb/ansible/forks","keys_url":"https://api.github.com/repos/vvb/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvb/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvb/ansible/teams","hooks_url":"https://api.github.com/repos/vvb/ansible/hooks","issue_events_url":"https://api.github.com/repos/vvb/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/vvb/ansible/events","assignees_url":"https://api.github.com/repos/vvb/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/vvb/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/vvb/ansible/tags","blobs_url":"https://api.github.com/repos/vvb/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvb/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvb/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvb/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvb/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/vvb/ansible/languages","stargazers_url":"https://api.github.com/repos/vvb/ansible/stargazers","contributors_url":"https://api.github.com/repos/vvb/ansible/contributors","subscribers_url":"https://api.github.com/repos/vvb/ansible/subscribers","subscription_url":"https://api.github.com/repos/vvb/ansible/subscription","commits_url":"https://api.github.com/repos/vvb/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvb/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvb/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvb/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvb/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/vvb/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvb/ansible/merges","archive_url":"https://api.github.com/repos/vvb/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvb/ansible/downloads","issues_url":"https://api.github.com/repos/vvb/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/vvb/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/vvb/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/vvb/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvb/ansible/labels{/name}","releases_url":"https://api.github.com/repos/vvb/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/vvb/ansible/deployments","created_at":"2016-02-12T22:54:49Z","updated_at":"2016-02-12T22:54:51Z","pushed_at":"2016-06-13T17:09:21Z","git_url":"git://github.com/vvb/ansible.git","ssh_url":"git@github.com:vvb/ansible.git","clone_url":"https://github.com/vvb/ansible.git","svn_url":"https://github.com/vvb/ansible","homepage":null,"size":330,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"c5e1b33e9d527b341ce5874d85930c741dd08f3a","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":46880794,"name":"ansible","full_name":"contiv/ansible","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/ansible","description":"ansible scripts for contiv cluster","fork":false,"url":"https://api.github.com/repos/contiv/ansible","forks_url":"https://api.github.com/repos/contiv/ansible/forks","keys_url":"https://api.github.com/repos/contiv/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/ansible/teams","hooks_url":"https://api.github.com/repos/contiv/ansible/hooks","issue_events_url":"https://api.github.com/repos/contiv/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/ansible/events","assignees_url":"https://api.github.com/repos/contiv/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/ansible/tags","blobs_url":"https://api.github.com/repos/contiv/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/ansible/languages","stargazers_url":"https://api.github.com/repos/contiv/ansible/stargazers","contributors_url":"https://api.github.com/repos/contiv/ansible/contributors","subscribers_url":"https://api.github.com/repos/contiv/ansible/subscribers","subscription_url":"https://api.github.com/repos/contiv/ansible/subscription","commits_url":"https://api.github.com/repos/contiv/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/ansible/merges","archive_url":"https://api.github.com/repos/contiv/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/ansible/downloads","issues_url":"https://api.github.com/repos/contiv/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/ansible/labels{/name}","releases_url":"https://api.github.com/repos/contiv/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/ansible/deployments","created_at":"2015-11-25T19:00:58Z","updated_at":"2016-05-23T18:20:34Z","pushed_at":"2016-06-13T17:09:21Z","git_url":"git://github.com/contiv/ansible.git","ssh_url":"git@github.com:contiv/ansible.git","clone_url":"https://github.com/contiv/ansible.git","svn_url":"https://github.com/contiv/ansible","homepage":null,"size":374,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":15,"forks":13,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/ansible/pulls/225"},"html":{"href":"https://github.com/contiv/ansible/pull/225"},"issue":{"href":"https://api.github.com/repos/contiv/ansible/issues/225"},"comments":{"href":"https://api.github.com/repos/contiv/ansible/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/ansible/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/ansible/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/ansible/statuses/95364544c1326cdd8c4b643041e94ed14b7440df"}}}}
{"actor":{"display_login":"mapuri"}}