{"action":"created","issue":{"url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/7","repository_url":"https://api.github.com/repos/graphitemaster/glsl-parser","labels_url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/7/comments","events_url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/7/events","html_url":"https://github.com/graphitemaster/glsl-parser/issues/7","id":172605740,"number":7,"title":"Warnings shadowing variables","user":{"login":"bkaradzic","id":814772,"avatar_url":"https://avatars.githubusercontent.com/u/814772?v=3","gravatar_id":"","url":"https://api.github.com/users/bkaradzic","html_url":"https://github.com/bkaradzic","followers_url":"https://api.github.com/users/bkaradzic/followers","following_url":"https://api.github.com/users/bkaradzic/following{/other_user}","gists_url":"https://api.github.com/users/bkaradzic/gists{/gist_id}","starred_url":"https://api.github.com/users/bkaradzic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkaradzic/subscriptions","organizations_url":"https://api.github.com/users/bkaradzic/orgs","repos_url":"https://api.github.com/users/bkaradzic/repos","events_url":"https://api.github.com/users/bkaradzic/events{/privacy}","received_events_url":"https://api.github.com/users/bkaradzic/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-23T03:40:44Z","updated_at":"2016-08-26T20:06:15Z","closed_at":"2016-08-25T04:53:41Z","body":"There are bunch of warnings about shadowing variables (add -Wshadow to Makefile).\r\n\r\nExample:\r\n```\r\nast.h: In constructor ‘glsl::astMemory::astMemory(T*)’:\r\nast.h:18:24: warning: declaration of ‘data’ shadows a member of ‘glsl::astMemory’ [-Wshadow]\r\n     astMemory(T *data) : data((void*)data), dtor(&astDestroy<T>) { }\r\n                        ^\r\nast.h:19:11: note: shadowed declaration is here\r\n     void *data;\r\n```\r\n\r\nI can send PR with fix for these, but not sure what you would prefer for naming them?"},"comment":{"url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/comments/242837735","html_url":"https://github.com/graphitemaster/glsl-parser/issues/7#issuecomment-242837735","issue_url":"https://api.github.com/repos/graphitemaster/glsl-parser/issues/7","id":242837735,"user":{"login":"graphitemaster","id":343195,"avatar_url":"https://avatars.githubusercontent.com/u/343195?v=3","gravatar_id":"","url":"https://api.github.com/users/graphitemaster","html_url":"https://github.com/graphitemaster","followers_url":"https://api.github.com/users/graphitemaster/followers","following_url":"https://api.github.com/users/graphitemaster/following{/other_user}","gists_url":"https://api.github.com/users/graphitemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/graphitemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphitemaster/subscriptions","organizations_url":"https://api.github.com/users/graphitemaster/orgs","repos_url":"https://api.github.com/users/graphitemaster/repos","events_url":"https://api.github.com/users/graphitemaster/events{/privacy}","received_events_url":"https://api.github.com/users/graphitemaster/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T20:06:15Z","updated_at":"2016-08-26T20:06:15Z","body":"That is too tedious and would require more changes than the wrapper :)"}}
{"actor":{"display_login":"graphitemaster"}}