{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/12128","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/12128/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/12128/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/12128/events","html_url":"https://github.com/openshift/origin/pull/12128","id":193261644,"number":12128,"title":"fix some cli command description","user":{"login":"guangxuli","id":17472298,"avatar_url":"https://avatars.githubusercontent.com/u/17472298?v=3","gravatar_id":"","url":"https://api.github.com/users/guangxuli","html_url":"https://github.com/guangxuli","followers_url":"https://api.github.com/users/guangxuli/followers","following_url":"https://api.github.com/users/guangxuli/following{/other_user}","gists_url":"https://api.github.com/users/guangxuli/gists{/gist_id}","starred_url":"https://api.github.com/users/guangxuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guangxuli/subscriptions","organizations_url":"https://api.github.com/users/guangxuli/orgs","repos_url":"https://api.github.com/users/guangxuli/repos","events_url":"https://api.github.com/users/guangxuli/events{/privacy}","received_events_url":"https://api.github.com/users/guangxuli/received_events","type":"User","site_admin":false},"labels":[{"id":200493322,"url":"https://api.github.com/repos/openshift/origin/labels/component/cli","name":"component/cli","color":"0052cc","default":false},{"id":118251701,"url":"https://api.github.com/repos/openshift/origin/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false},{"id":276708012,"url":"https://api.github.com/repos/openshift/origin/labels/needs-rebase","name":"needs-rebase","color":"cccccc","default":false},{"id":210151912,"url":"https://api.github.com/repos/openshift/origin/labels/priority/P2","name":"priority/P2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-12-03T03:10:16Z","updated_at":"2016-12-09T16:40:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/12128","html_url":"https://github.com/openshift/origin/pull/12128","diff_url":"https://github.com/openshift/origin/pull/12128.diff","patch_url":"https://github.com/openshift/origin/pull/12128.patch"},"body":"**what this PR does:**\r\n\r\nMainly fix some description of some `oc` command, especially for the default value of option is false.\r\n\r\nwhen i run `oc deploy -h`, the output : \r\n```\r\nOptions:\r\n      --cancel=false: Cancel the in-progress deployment.\r\n      --enable-triggers=false: Enables all image triggers for the deployment config.\r\n      --follow=false: Follow the logs of a deployment\r\n      --latest=false: Start a new deployment now.\r\n      --retry=false: Retry the latest failed deployment.   \r\n```\r\n\r\nI think the annotation of the options is confusing, since all the description are about `* = true` condition,\r\nwhile the default value of these options are false.  I thought this is our rules at beginning, but when I run `oc new-build -h` command, I saw some outputs are more reasonable, like this(not all):\r\n\r\n```\r\nOptions:\r\n      --allow-missing-images=false: If true, indicates that referenced Docker images that cannot be found locally or in\r\na registry should still be used.\r\n      --allow-missing-imagestream-tags=false: If true, indicates that image stream tags that don't exist should still be\r\nused.\r\n      --dry-run=false: If true, show the result of the operation without performing it.\r\n      --no-output=false: If true, the build output will not be pushed anywhere.\r\n```\r\n  I think we should add` if true` when the bool value of description before colons is **false**, that seems more clear.\r\n\r\n**what I have fixed:**\r\n1. option=false, but the description is about in case of the value is true, add `if true` to the description if not exist:\r\n```\r\ncmd.Flags().BoolVar(&o.Confirmed, \"confirm\", o.Confirmed, \"**Specify** that cluster role bindings should be modified. Defaults to false, displaying what would be replaced but not actually replacing anything.\")\r\ncmd.Flags().BoolVar(&o.Confirmed, \"confirm\", o.Confirmed, \"**If true, specify** that cluster role bindings should be modified. Defaults to false, displaying what would be replaced but not actually replacing anything.\")\r\n```\r\n2. description `if present` change it to` if true` just for keeping consistent:\r\n```\r\ncmd.Flags().Bool(\"all-namespaces\", false, \"**If present,** list the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace.\")\r\ncmd.Flags().Bool(\"all-namespaces\", false, \"**If true**, list the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace.\")\r\n```\r\n\r\n\r\n**what I do not fixed:**\r\n1. description include all false/true, just like:\r\n```\r\ncmd.Flags().BoolVar(&options.Readiness, \"readiness\", options.Readiness, \"Set or remove a readiness probe to indicate when this container should receive traffic\")\r\ncmd.Flags().BoolVar(&options.Liveness, \"liveness\", options.Liveness, \"Set or remove a liveness probe to verify this container is running\")\r\n```\r\n2. description have include clear option content, just like:\r\n```\r\ncmd.Flags().BoolVar(&opts.aliasTag, \"alias\", false, \"Should the destination tag be updated whenever the source tag changes. **Defaults to false**.\")cmd.Flags().BoolVar(&opts.referenceTag, \"reference\", false, \"Should the destination tag continue to pull from the source namespace. **Defaults to false**.\")\r\n```\r\n3.the option have two format, just like:\r\n`-t, --tty=false: Force a pseudo-terminal to be allocated`\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/266060084","html_url":"https://github.com/openshift/origin/pull/12128#issuecomment-266060084","issue_url":"https://api.github.com/repos/openshift/origin/issues/12128","id":266060084,"user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T16:40:47Z","updated_at":"2016-12-09T16:40:47Z","body":"integration check flaked on https://github.com/openshift/origin/issues/8571\r\nre[test]\r\n\r\n\r\n@guangxuli looks like you'll need to rebase as well"}}
{"actor":{"display_login":"juanvallejo"}}