{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/events","html_url":"https://github.com/elastic/elasticsearch/pull/20301","id":174782116,"number":20301,"title":"Remove specialized timeValueField() methods in XContentBuilder","user":{"login":"tlrx","id":642733,"avatar_url":"https://avatars.githubusercontent.com/u/642733?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrx","html_url":"https://github.com/tlrx","followers_url":"https://api.github.com/users/tlrx/followers","following_url":"https://api.github.com/users/tlrx/following{/other_user}","gists_url":"https://api.github.com/users/tlrx/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrx/subscriptions","organizations_url":"https://api.github.com/users/tlrx/orgs","repos_url":"https://api.github.com/users/tlrx/repos","events_url":"https://api.github.com/users/tlrx/events{/privacy}","received_events_url":"https://api.github.com/users/tlrx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:REST","name":":REST","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.0.0","name":"v5.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-02T15:08:56Z","updated_at":"2016-09-02T15:37:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20301","html_url":"https://github.com/elastic/elasticsearch/pull/20301","diff_url":"https://github.com/elastic/elasticsearch/pull/20301.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/20301.patch"},"body":"This PR renames some specialized method like \r\n\r\n`timeValueField(String rawFieldName, String readableFieldName, TimeValue timeValue) `\r\n\r\nin favor of a bit more concise method:\r\n\r\n`field(String name, TimeValue timeValue) `\r\n\r\nThe method takes care of writing the human readable field and also the time value field using a default `TimeUnit` configured at the `XContentBuilder` level. This ensures that human readable field and time value fields share the exact same prefix and allows to build objects using a specific time unit.\r\n\r\nNote: this PR breaks some field names that were not fully coherent. If agreed, I'll document them as breaking change before merging."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/244410022","html_url":"https://github.com/elastic/elasticsearch/pull/20301#issuecomment-244410022","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301","id":244410022,"user":{"login":"nik9000","id":215970,"avatar_url":"https://avatars.githubusercontent.com/u/215970?v=3","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T15:37:19Z","updated_at":"2016-09-02T15:37:19Z","body":"> Actually I'd like to clean up all specialized method like bytesize and dates on the same way\r\n\r\nThat sounds like a good plan. I left some comments one the specifics but the plan of removing the specialized variants sounds good to me."}}
{"actor":{"display_login":"nik9000"}}