{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/478","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/478/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/478/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/478/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478","id":139307234,"number":478,"title":"Make inner classes static as suggested by FindBugs","user":{"login":"chanseokoh","id":10523105,"avatar_url":"https://avatars.githubusercontent.com/u/10523105?v=3","gravatar_id":"","url":"https://api.github.com/users/chanseokoh","html_url":"https://github.com/chanseokoh","followers_url":"https://api.github.com/users/chanseokoh/followers","following_url":"https://api.github.com/users/chanseokoh/following{/other_user}","gists_url":"https://api.github.com/users/chanseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/chanseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanseokoh/subscriptions","organizations_url":"https://api.github.com/users/chanseokoh/orgs","repos_url":"https://api.github.com/users/chanseokoh/repos","events_url":"https://api.github.com/users/chanseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/chanseokoh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-08T15:34:29Z","updated_at":"2016-03-08T16:06:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/478","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478.patch"},"body":"This pull request addresses one of FindBugs issues: SIC_INNER_SHOULD_BE_STATIC. Inner classes do not use the embedded reference to their outer classes, so no need to be non-static. A test case is also fixed according to the these changes.\r\n\r\nNote: I am learning Java and Java practices now. I am also trying to familiarize myself with the GitHub workflow for making contributions to this repo by addressing issues reported by FindBugs. Any kind of feedback is more than welcome."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/comments/193840964","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478#issuecomment-193840964","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/478","id":193840964,"user":{"login":"patflynn","id":7862557,"avatar_url":"https://avatars.githubusercontent.com/u/7862557?v=3","gravatar_id":"","url":"https://api.github.com/users/patflynn","html_url":"https://github.com/patflynn","followers_url":"https://api.github.com/users/patflynn/followers","following_url":"https://api.github.com/users/patflynn/following{/other_user}","gists_url":"https://api.github.com/users/patflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/patflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patflynn/subscriptions","organizations_url":"https://api.github.com/users/patflynn/orgs","repos_url":"https://api.github.com/users/patflynn/repos","events_url":"https://api.github.com/users/patflynn/events{/privacy}","received_events_url":"https://api.github.com/users/patflynn/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T16:06:01Z","updated_at":"2016-03-08T16:06:01Z","body":"It's only on your branch so should not be an issue.  There's no danger that\nyou can mess with the project's history as the master is protected.\n\nOn Tue, Mar 8, 2016 at 11:05 AM, Chanseok Oh <notifications@github.com>\nwrote:\n\n> #241 <https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/241>\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/478#issuecomment-193840687>\n> .\n>\n"}}