{"action":"created","comment":{"url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/comments/87452054","pull_request_review_id":8065215,"id":87452054,"diff_hunk":"@@ -14,7 +14,7 @@ class OrderContents\n     # @return [Spree::LineItem]\n     #   the created (or adjusted) line item\n     def add(variant, quantity)\n-      add_to_line_item(variant, quantity).tap do\n+      order.add_to_line_item(variant, quantity).tap do\n         propagate_changes","path":"core/app/models/spree/order_contents.rb","position":6,"original_position":6,"commit_id":"4ded67ea7da362986ff0a36655d04f3f893d2a1c","original_commit_id":"7fb4ced7046e36eea9d0ad92003aa13a879be9c0","user":{"login":"dkubb","id":133,"avatar_url":"https://avatars.githubusercontent.com/u/133?v=3","gravatar_id":"","url":"https://api.github.com/users/dkubb","html_url":"https://github.com/dkubb","followers_url":"https://api.github.com/users/dkubb/followers","following_url":"https://api.github.com/users/dkubb/following{/other_user}","gists_url":"https://api.github.com/users/dkubb/gists{/gist_id}","starred_url":"https://api.github.com/users/dkubb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkubb/subscriptions","organizations_url":"https://api.github.com/users/dkubb/orgs","repos_url":"https://api.github.com/users/dkubb/repos","events_url":"https://api.github.com/users/dkubb/events{/privacy}","received_events_url":"https://api.github.com/users/dkubb/received_events","type":"User","site_admin":false},"body":"> I wanted to do this as a followup.\r\n\r\nWhat if we do it in this PR to get things working then extract it out?","created_at":"2016-11-10T18:08:10Z","updated_at":"2016-11-10T18:08:10Z","html_url":"https://github.com/MountainRoseHerbs/spree/pull/547#discussion_r87452054","pull_request_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547","_links":{"self":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/comments/87452054"},"html":{"href":"https://github.com/MountainRoseHerbs/spree/pull/547#discussion_r87452054"},"pull_request":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547"}}},"pull_request":{"url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547","id":92440870,"html_url":"https://github.com/MountainRoseHerbs/spree/pull/547","diff_url":"https://github.com/MountainRoseHerbs/spree/pull/547.diff","patch_url":"https://github.com/MountainRoseHerbs/spree/pull/547.patch","issue_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/547","number":547,"state":"open","locked":false,"title":"Optimize order merger","user":{"login":"mbj","id":117966,"avatar_url":"https://avatars.githubusercontent.com/u/117966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbj","html_url":"https://github.com/mbj","followers_url":"https://api.github.com/users/mbj/followers","following_url":"https://api.github.com/users/mbj/following{/other_user}","gists_url":"https://api.github.com/users/mbj/gists{/gist_id}","starred_url":"https://api.github.com/users/mbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbj/subscriptions","organizations_url":"https://api.github.com/users/mbj/orgs","repos_url":"https://api.github.com/users/mbj/repos","events_url":"https://api.github.com/users/mbj/events{/privacy}","received_events_url":"https://api.github.com/users/mbj/received_events","type":"User","site_admin":false},"body":"Depends on:\r\n\r\n* [x] https://github.com/MountainRoseHerbs/spree/pull/548\r\n* [x] https://github.com/MountainRoseHerbs/spree/pull/549","created_at":"2016-11-05T03:34:41Z","updated_at":"2016-11-10T18:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa4c757e4e3537c893b098cc76c737f09acb030","assignee":{"login":"mbj","id":117966,"avatar_url":"https://avatars.githubusercontent.com/u/117966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbj","html_url":"https://github.com/mbj","followers_url":"https://api.github.com/users/mbj/followers","following_url":"https://api.github.com/users/mbj/following{/other_user}","gists_url":"https://api.github.com/users/mbj/gists{/gist_id}","starred_url":"https://api.github.com/users/mbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbj/subscriptions","organizations_url":"https://api.github.com/users/mbj/orgs","repos_url":"https://api.github.com/users/mbj/repos","events_url":"https://api.github.com/users/mbj/events{/privacy}","received_events_url":"https://api.github.com/users/mbj/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbj","id":117966,"avatar_url":"https://avatars.githubusercontent.com/u/117966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbj","html_url":"https://github.com/mbj","followers_url":"https://api.github.com/users/mbj/followers","following_url":"https://api.github.com/users/mbj/following{/other_user}","gists_url":"https://api.github.com/users/mbj/gists{/gist_id}","starred_url":"https://api.github.com/users/mbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbj/subscriptions","organizations_url":"https://api.github.com/users/mbj/orgs","repos_url":"https://api.github.com/users/mbj/repos","events_url":"https://api.github.com/users/mbj/events{/privacy}","received_events_url":"https://api.github.com/users/mbj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547/commits","review_comments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547/comments","review_comment_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/547/comments","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/spree/statuses/4ded67ea7da362986ff0a36655d04f3f893d2a1c","head":{"label":"MountainRoseHerbs:fix/optimize-order-merger","ref":"fix/optimize-order-merger","sha":"4ded67ea7da362986ff0a36655d04f3f893d2a1c","user":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"repo":{"id":12473049,"name":"spree","full_name":"MountainRoseHerbs/spree","owner":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MountainRoseHerbs/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/MountainRoseHerbs/spree","forks_url":"https://api.github.com/repos/MountainRoseHerbs/spree/forks","keys_url":"https://api.github.com/repos/MountainRoseHerbs/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MountainRoseHerbs/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MountainRoseHerbs/spree/teams","hooks_url":"https://api.github.com/repos/MountainRoseHerbs/spree/hooks","issue_events_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/events{/number}","events_url":"https://api.github.com/repos/MountainRoseHerbs/spree/events","assignees_url":"https://api.github.com/repos/MountainRoseHerbs/spree/assignees{/user}","branches_url":"https://api.github.com/repos/MountainRoseHerbs/spree/branches{/branch}","tags_url":"https://api.github.com/repos/MountainRoseHerbs/spree/tags","blobs_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/MountainRoseHerbs/spree/languages","stargazers_url":"https://api.github.com/repos/MountainRoseHerbs/spree/stargazers","contributors_url":"https://api.github.com/repos/MountainRoseHerbs/spree/contributors","subscribers_url":"https://api.github.com/repos/MountainRoseHerbs/spree/subscribers","subscription_url":"https://api.github.com/repos/MountainRoseHerbs/spree/subscription","commits_url":"https://api.github.com/repos/MountainRoseHerbs/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/MountainRoseHerbs/spree/contents/{+path}","compare_url":"https://api.github.com/repos/MountainRoseHerbs/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MountainRoseHerbs/spree/merges","archive_url":"https://api.github.com/repos/MountainRoseHerbs/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MountainRoseHerbs/spree/downloads","issues_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues{/number}","pulls_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/MountainRoseHerbs/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/MountainRoseHerbs/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MountainRoseHerbs/spree/labels{/name}","releases_url":"https://api.github.com/repos/MountainRoseHerbs/spree/releases{/id}","deployments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/deployments","created_at":"2013-08-29T22:58:09Z","updated_at":"2016-10-31T21:04:41Z","pushed_at":"2016-11-10T18:07:41Z","git_url":"git://github.com/MountainRoseHerbs/spree.git","ssh_url":"git@github.com:MountainRoseHerbs/spree.git","clone_url":"https://github.com/MountainRoseHerbs/spree.git","svn_url":"https://github.com/MountainRoseHerbs/spree","homepage":"http://spreecommerce.com","size":64640,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"MountainRoseHerbs:master","ref":"master","sha":"2e0e704f94160ff29a9a18d88212ac5de6a70360","user":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"repo":{"id":12473049,"name":"spree","full_name":"MountainRoseHerbs/spree","owner":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MountainRoseHerbs/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/MountainRoseHerbs/spree","forks_url":"https://api.github.com/repos/MountainRoseHerbs/spree/forks","keys_url":"https://api.github.com/repos/MountainRoseHerbs/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MountainRoseHerbs/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MountainRoseHerbs/spree/teams","hooks_url":"https://api.github.com/repos/MountainRoseHerbs/spree/hooks","issue_events_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/events{/number}","events_url":"https://api.github.com/repos/MountainRoseHerbs/spree/events","assignees_url":"https://api.github.com/repos/MountainRoseHerbs/spree/assignees{/user}","branches_url":"https://api.github.com/repos/MountainRoseHerbs/spree/branches{/branch}","tags_url":"https://api.github.com/repos/MountainRoseHerbs/spree/tags","blobs_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/MountainRoseHerbs/spree/languages","stargazers_url":"https://api.github.com/repos/MountainRoseHerbs/spree/stargazers","contributors_url":"https://api.github.com/repos/MountainRoseHerbs/spree/contributors","subscribers_url":"https://api.github.com/repos/MountainRoseHerbs/spree/subscribers","subscription_url":"https://api.github.com/repos/MountainRoseHerbs/spree/subscription","commits_url":"https://api.github.com/repos/MountainRoseHerbs/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/MountainRoseHerbs/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/MountainRoseHerbs/spree/contents/{+path}","compare_url":"https://api.github.com/repos/MountainRoseHerbs/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MountainRoseHerbs/spree/merges","archive_url":"https://api.github.com/repos/MountainRoseHerbs/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MountainRoseHerbs/spree/downloads","issues_url":"https://api.github.com/repos/MountainRoseHerbs/spree/issues{/number}","pulls_url":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/MountainRoseHerbs/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/MountainRoseHerbs/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MountainRoseHerbs/spree/labels{/name}","releases_url":"https://api.github.com/repos/MountainRoseHerbs/spree/releases{/id}","deployments_url":"https://api.github.com/repos/MountainRoseHerbs/spree/deployments","created_at":"2013-08-29T22:58:09Z","updated_at":"2016-10-31T21:04:41Z","pushed_at":"2016-11-10T18:07:41Z","git_url":"git://github.com/MountainRoseHerbs/spree.git","ssh_url":"git@github.com:MountainRoseHerbs/spree.git","clone_url":"https://github.com/MountainRoseHerbs/spree.git","svn_url":"https://github.com/MountainRoseHerbs/spree","homepage":"http://spreecommerce.com","size":64640,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547"},"html":{"href":"https://github.com/MountainRoseHerbs/spree/pull/547"},"issue":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/547"},"comments":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/MountainRoseHerbs/spree/statuses/4ded67ea7da362986ff0a36655d04f3f893d2a1c"}}}}
{"actor":{"display_login":"dkubb"}}