{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/raven-js/pulls/comments/49146348","id":49146348,"diff_hunk":"@@ -498,6 +496,41 @@ Raven.prototype = {\n         }\n     },\n \n+    showReportDialog: function (options) {\n+        if (!window.document) // doesn't work without a document (React native)\n+            return;\n+\n+        options = options || {};\n+\n+        var lastEventId = options.eventId || this.lastEventId();\n+        if (!lastEventId) {\n+            throw new RavenConfigError('Missing eventId');","path":"src/raven.js","position":39,"original_position":39,"commit_id":"fbe377ef45e9937db0d0706fd793d59204426134","original_commit_id":"fbe377ef45e9937db0d0706fd793d59204426134","user":{"login":"mattrobenolt","id":375744,"avatar_url":"https://avatars.githubusercontent.com/u/375744?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrobenolt","html_url":"https://github.com/mattrobenolt","followers_url":"https://api.github.com/users/mattrobenolt/followers","following_url":"https://api.github.com/users/mattrobenolt/following{/other_user}","gists_url":"https://api.github.com/users/mattrobenolt/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrobenolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrobenolt/subscriptions","organizations_url":"https://api.github.com/users/mattrobenolt/orgs","repos_url":"https://api.github.com/users/mattrobenolt/repos","events_url":"https://api.github.com/users/mattrobenolt/events{/privacy}","received_events_url":"https://api.github.com/users/mattrobenolt/received_events","type":"User","site_admin":false},"body":"We probably shouldn't throw errors like this since they'd then get caught and in turn reported to Sentry. Thoughts?\r\n\r\nOr we have a rule to ignore RavenConfigError's. This wasn't an issue before because RavenConfigError was only ever thrown before raven was even hooked up. Now we'll be throwing errors that will be caught and logged.\r\n\r\nNot sure if bad or not, just pointing it out.","created_at":"2016-01-08T00:37:51Z","updated_at":"2016-01-08T00:37:51Z","html_url":"https://github.com/getsentry/raven-js/pull/456#discussion_r49146348","pull_request_url":"https://api.github.com/repos/getsentry/raven-js/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/comments/49146348"},"html":{"href":"https://github.com/getsentry/raven-js/pull/456#discussion_r49146348"},"pull_request":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/raven-js/pulls/456","id":55406402,"html_url":"https://github.com/getsentry/raven-js/pull/456","diff_url":"https://github.com/getsentry/raven-js/pull/456.diff","patch_url":"https://github.com/getsentry/raven-js/pull/456.patch","issue_url":"https://api.github.com/repos/getsentry/raven-js/issues/456","number":456,"state":"open","locked":false,"title":"Add Raven.showReportDialog (experimental)","user":{"login":"benvinegar","id":2153,"avatar_url":"https://avatars.githubusercontent.com/u/2153?v=3","gravatar_id":"","url":"https://api.github.com/users/benvinegar","html_url":"https://github.com/benvinegar","followers_url":"https://api.github.com/users/benvinegar/followers","following_url":"https://api.github.com/users/benvinegar/following{/other_user}","gists_url":"https://api.github.com/users/benvinegar/gists{/gist_id}","starred_url":"https://api.github.com/users/benvinegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvinegar/subscriptions","organizations_url":"https://api.github.com/users/benvinegar/orgs","repos_url":"https://api.github.com/users/benvinegar/repos","events_url":"https://api.github.com/users/benvinegar/events{/privacy}","received_events_url":"https://api.github.com/users/benvinegar/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-07T23:34:33Z","updated_at":"2016-01-08T00:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6171acb5727aa258c7c51f087410aeb1e68b9a1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/raven-js/pulls/456/commits","review_comments_url":"https://api.github.com/repos/getsentry/raven-js/pulls/456/comments","review_comment_url":"https://api.github.com/repos/getsentry/raven-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/raven-js/issues/456/comments","statuses_url":"https://api.github.com/repos/getsentry/raven-js/statuses/fbe377ef45e9937db0d0706fd793d59204426134","head":{"label":"getsentry:show-dialog","ref":"show-dialog","sha":"fbe377ef45e9937db0d0706fd793d59204426134","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":3328572,"name":"raven-js","full_name":"getsentry/raven-js","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-js","description":"JavaScript client for Sentry","fork":false,"url":"https://api.github.com/repos/getsentry/raven-js","forks_url":"https://api.github.com/repos/getsentry/raven-js/forks","keys_url":"https://api.github.com/repos/getsentry/raven-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-js/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-js/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-js/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-js/events","assignees_url":"https://api.github.com/repos/getsentry/raven-js/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-js/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-js/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-js/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-js/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-js/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-js/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-js/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-js/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-js/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-js/merges","archive_url":"https://api.github.com/repos/getsentry/raven-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-js/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-js/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-js/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-js/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-js/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-js/releases{/id}","created_at":"2012-02-01T20:16:25Z","updated_at":"2016-01-06T11:54:58Z","pushed_at":"2016-01-08T00:33:31Z","git_url":"git://github.com/getsentry/raven-js.git","ssh_url":"git@github.com:getsentry/raven-js.git","clone_url":"https://github.com/getsentry/raven-js.git","svn_url":"https://github.com/getsentry/raven-js","homepage":"https://getsentry.com","size":2058,"stargazers_count":643,"watchers_count":643,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":218,"mirror_url":null,"open_issues_count":55,"forks":218,"open_issues":55,"watchers":643,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"6d5a919eeae5eb86bda6146fa8be3834f204d0e2","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":3328572,"name":"raven-js","full_name":"getsentry/raven-js","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-js","description":"JavaScript client for Sentry","fork":false,"url":"https://api.github.com/repos/getsentry/raven-js","forks_url":"https://api.github.com/repos/getsentry/raven-js/forks","keys_url":"https://api.github.com/repos/getsentry/raven-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-js/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-js/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-js/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-js/events","assignees_url":"https://api.github.com/repos/getsentry/raven-js/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-js/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-js/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-js/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-js/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-js/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-js/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-js/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-js/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-js/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-js/merges","archive_url":"https://api.github.com/repos/getsentry/raven-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-js/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-js/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-js/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-js/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-js/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-js/releases{/id}","created_at":"2012-02-01T20:16:25Z","updated_at":"2016-01-06T11:54:58Z","pushed_at":"2016-01-08T00:33:31Z","git_url":"git://github.com/getsentry/raven-js.git","ssh_url":"git@github.com:getsentry/raven-js.git","clone_url":"https://github.com/getsentry/raven-js.git","svn_url":"https://github.com/getsentry/raven-js","homepage":"https://getsentry.com","size":2058,"stargazers_count":643,"watchers_count":643,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":218,"mirror_url":null,"open_issues_count":55,"forks":218,"open_issues":55,"watchers":643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/456"},"html":{"href":"https://github.com/getsentry/raven-js/pull/456"},"issue":{"href":"https://api.github.com/repos/getsentry/raven-js/issues/456"},"comments":{"href":"https://api.github.com/repos/getsentry/raven-js/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/raven-js/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/raven-js/statuses/fbe377ef45e9937db0d0706fd793d59204426134"}}}}