{"action":"closed","number":349,"pull_request":{"url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349","id":85448642,"html_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/349","diff_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/349.diff","patch_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/349.patch","issue_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/349","number":349,"state":"closed","locked":false,"title":"2597.windows integration.0","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"Fixes integration tests to run properly on windows. Killing subprocesses might be NP-Hard on windows, I think. In any case, the `tahoe.exe` things generated by `pip` don't correctly kill their own subprocess (\"or something\") so I bypass that by running via `python -m allmydata.scripts.runner` ... which is non-ideal from integration test perspective, but on the upside it works.\r\n\r\nI also had to lengthen the default timeouts a bit, at least for my VM.\r\n\r\nI added `tox -e integration` to the travis config to see if travis will run these against this PR. \"Exercise for the merge\" if we actually want that longer-term (I can rebase it out if you want).","created_at":"2016-09-15T17:46:10Z","updated_at":"2016-09-26T20:34:40Z","closed_at":"2016-09-26T20:34:40Z","merged_at":null,"merge_commit_sha":"6146d2c40e760d852f54e486e93ddb5c610a21e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349/commits","review_comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349/comments","review_comment_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/349/comments","statuses_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/82b6dea1c5a2f31e931cb6feff3c7fb804e5b3ff","head":{"label":"meejah:2597.windows-integration.0","ref":"2597.windows-integration.0","sha":"82b6dea1c5a2f31e931cb6feff3c7fb804e5b3ff","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":42634043,"name":"tahoe-lafs","full_name":"meejah/tahoe-lafs","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/tahoe-lafs","description":"The Tahoe-LAFS decentralized secure filesystem.","fork":true,"url":"https://api.github.com/repos/meejah/tahoe-lafs","forks_url":"https://api.github.com/repos/meejah/tahoe-lafs/forks","keys_url":"https://api.github.com/repos/meejah/tahoe-lafs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/tahoe-lafs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/tahoe-lafs/teams","hooks_url":"https://api.github.com/repos/meejah/tahoe-lafs/hooks","issue_events_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/tahoe-lafs/events","assignees_url":"https://api.github.com/repos/meejah/tahoe-lafs/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/tahoe-lafs/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/tahoe-lafs/tags","blobs_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/tahoe-lafs/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/tahoe-lafs/languages","stargazers_url":"https://api.github.com/repos/meejah/tahoe-lafs/stargazers","contributors_url":"https://api.github.com/repos/meejah/tahoe-lafs/contributors","subscribers_url":"https://api.github.com/repos/meejah/tahoe-lafs/subscribers","subscription_url":"https://api.github.com/repos/meejah/tahoe-lafs/subscription","commits_url":"https://api.github.com/repos/meejah/tahoe-lafs/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/tahoe-lafs/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/tahoe-lafs/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/tahoe-lafs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/tahoe-lafs/merges","archive_url":"https://api.github.com/repos/meejah/tahoe-lafs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/tahoe-lafs/downloads","issues_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/tahoe-lafs/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/tahoe-lafs/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/tahoe-lafs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/tahoe-lafs/labels{/name}","releases_url":"https://api.github.com/repos/meejah/tahoe-lafs/releases{/id}","deployments_url":"https://api.github.com/repos/meejah/tahoe-lafs/deployments","created_at":"2015-09-17T04:05:14Z","updated_at":"2016-01-19T19:35:02Z","pushed_at":"2016-09-24T02:28:25Z","git_url":"git://github.com/meejah/tahoe-lafs.git","ssh_url":"git@github.com:meejah/tahoe-lafs.git","clone_url":"https://github.com/meejah/tahoe-lafs.git","svn_url":"https://github.com/meejah/tahoe-lafs","homepage":"https://tahoe-lafs.org/","size":68134,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tahoe-lafs:master","ref":"master","sha":"b7d561f458dbf0b82da8126a5a36701d7c3e2a37","user":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"repo":{"id":3007569,"name":"tahoe-lafs","full_name":"tahoe-lafs/tahoe-lafs","owner":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tahoe-lafs/tahoe-lafs","description":"The Tahoe-LAFS decentralized secure filesystem.","fork":false,"url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs","forks_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/forks","keys_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/teams","hooks_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/hooks","issue_events_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/events{/number}","events_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/events","assignees_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/assignees{/user}","branches_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/branches{/branch}","tags_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/tags","blobs_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/{sha}","languages_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/languages","stargazers_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/stargazers","contributors_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/contributors","subscribers_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/subscribers","subscription_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/subscription","commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/contents/{+path}","compare_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/merges","archive_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/downloads","issues_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues{/number}","pulls_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls{/number}","milestones_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/milestones{/number}","notifications_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/labels{/name}","releases_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/releases{/id}","deployments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/deployments","created_at":"2011-12-18T19:33:55Z","updated_at":"2016-09-26T10:20:16Z","pushed_at":"2016-09-26T20:34:38Z","git_url":"git://github.com/tahoe-lafs/tahoe-lafs.git","ssh_url":"git@github.com:tahoe-lafs/tahoe-lafs.git","clone_url":"https://github.com/tahoe-lafs/tahoe-lafs.git","svn_url":"https://github.com/tahoe-lafs/tahoe-lafs","homepage":"https://tahoe-lafs.org/","size":73861,"stargazers_count":528,"watchers_count":528,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":17,"forks":149,"open_issues":17,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349"},"html":{"href":"https://github.com/tahoe-lafs/tahoe-lafs/pull/349"},"issue":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/349"},"comments":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/82b6dea1c5a2f31e931cb6feff3c7fb804e5b3ff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":0,"commits":7,"additions":74,"deletions":68,"changed_files":5}}
{"actor":{"display_login":"warner"}}