{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/84964027","pull_request_review_id":5708338,"id":84964027,"diff_hunk":"@@ -50,32 +56,26 @@ describe('amp-ad-xorigin-iframe-handler', () => {\n   });\n \n   describe('init() returned promise', () => {\n-    let iframe;\n     let initPromise;\n \n     describe('if render-start is implemented', () => {\n \n       let noContentSpy;\n \n-      beforeEach(() => {\n+      beforeEach(done => {","path":"extensions/amp-ad/0.1/test/test-amp-ad-xorigin-iframe-handler.js","position":50,"original_position":35,"commit_id":"c514516a682fb3a01542a536d09e052639c40d89","original_commit_id":"afb0790492c91bbe61e31b6e8a32a4c93ba4928d","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"It's a nodeback (an async callback that takes an error for the first parameter, if one occurred).","created_at":"2016-10-25T18:04:03Z","updated_at":"2016-10-25T18:04:04Z","html_url":"https://github.com/ampproject/amphtml/pull/5795#discussion_r84964027","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5795","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/84964027"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5795#discussion_r84964027"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5795"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/5795","id":90740299,"html_url":"https://github.com/ampproject/amphtml/pull/5795","diff_url":"https://github.com/ampproject/amphtml/pull/5795.diff","patch_url":"https://github.com/ampproject/amphtml/pull/5795.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/5795","number":5795,"state":"open","locked":false,"title":"Be tolerant to string numbers in iframe resizing request.","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"body":"Refactored test code to reproduce the issue in test. The iframe should not be attached to document.body, but amp-ad element.\r\n\r\nFixes #5608","created_at":"2016-10-25T05:11:02Z","updated_at":"2016-10-25T18:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6ade020b62d7d5f79a28fb196bf2d0e34707007","assignee":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5795/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5795/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5795/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/c514516a682fb3a01542a536d09e052639c40d89","head":{"label":"lannka:parse_string_dimension","ref":"parse_string_dimension","sha":"c514516a682fb3a01542a536d09e052639c40d89","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"repo":{"id":60651806,"name":"amphtml","full_name":"lannka/amphtml","owner":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lannka/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/lannka/amphtml","forks_url":"https://api.github.com/repos/lannka/amphtml/forks","keys_url":"https://api.github.com/repos/lannka/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lannka/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lannka/amphtml/teams","hooks_url":"https://api.github.com/repos/lannka/amphtml/hooks","issue_events_url":"https://api.github.com/repos/lannka/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/lannka/amphtml/events","assignees_url":"https://api.github.com/repos/lannka/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/lannka/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/lannka/amphtml/tags","blobs_url":"https://api.github.com/repos/lannka/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lannka/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lannka/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lannka/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lannka/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/lannka/amphtml/languages","stargazers_url":"https://api.github.com/repos/lannka/amphtml/stargazers","contributors_url":"https://api.github.com/repos/lannka/amphtml/contributors","subscribers_url":"https://api.github.com/repos/lannka/amphtml/subscribers","subscription_url":"https://api.github.com/repos/lannka/amphtml/subscription","commits_url":"https://api.github.com/repos/lannka/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lannka/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lannka/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lannka/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lannka/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/lannka/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lannka/amphtml/merges","archive_url":"https://api.github.com/repos/lannka/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lannka/amphtml/downloads","issues_url":"https://api.github.com/repos/lannka/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/lannka/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/lannka/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/lannka/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lannka/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/lannka/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/lannka/amphtml/deployments","created_at":"2016-06-07T22:50:13Z","updated_at":"2016-06-07T22:50:18Z","pushed_at":"2016-10-25T17:59:41Z","git_url":"git://github.com/lannka/amphtml.git","ssh_url":"git@github.com:lannka/amphtml.git","clone_url":"https://github.com/lannka/amphtml.git","svn_url":"https://github.com/lannka/amphtml","homepage":"https://ampproject.org","size":177952,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"44edf672a7b7cedd7aff89495d2664ff7eefeebd","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-10-25T18:02:23Z","pushed_at":"2016-10-25T17:59:41Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":218947,"stargazers_count":8898,"watchers_count":8898,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1351,"mirror_url":null,"open_issues_count":919,"forks":1351,"open_issues":919,"watchers":8898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5795"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5795"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5795"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5795/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5795/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5795/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/c514516a682fb3a01542a536d09e052639c40d89"}}}}
{"actor":{"display_login":"jridgewell"}}