{"action":"closed","number":77,"pull_request":{"url":"https://api.github.com/repos/juttle/juttle-service/pulls/77","id":64095378,"html_url":"https://github.com/juttle/juttle-service/pull/77","diff_url":"https://github.com/juttle/juttle-service/pull/77.diff","patch_url":"https://github.com/juttle/juttle-service/pull/77.patch","issue_url":"https://api.github.com/repos/juttle/juttle-service/issues/77","number":77,"state":"closed","locked":false,"title":"Fix juttle-service so it can run with no options.","user":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"body":"https://github.com/juttle/juttle-service/pull/67/files introduced a\r\nregression where juttle-service could not be run at all. Testing for _\r\nin options is not a good indicator of whether there are non-option\r\narguments. You must also check to see whether the array is empty or\r\nnot.\r\n\r\nAdditionally, the unit tests that would have caught this also had\r\nbugs:\r\n\r\n - child_process.spawn does not throw an error when the process exits\r\n   with non-zero, so the catch {} block wasn't actually being\r\n   invoked. Switch to using spawnSync and checking the result.\r\n\r\n - For the test that did specify a port, you must also positively\r\n   check that you saw the startup line, and not simply assume that if\r\n   it exits the test succeeds.","created_at":"2016-03-24T20:40:29Z","updated_at":"2016-03-24T21:28:58Z","closed_at":"2016-03-24T21:28:57Z","merged_at":"2016-03-24T21:28:57Z","merge_commit_sha":"bc93ddc12561c0acabc012ce234d229526fe2db3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juttle/juttle-service/pulls/77/commits","review_comments_url":"https://api.github.com/repos/juttle/juttle-service/pulls/77/comments","review_comment_url":"https://api.github.com/repos/juttle/juttle-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juttle/juttle-service/issues/77/comments","statuses_url":"https://api.github.com/repos/juttle/juttle-service/statuses/511e82ddc46c2cebc0ea9cc65248067cf7fa9299","head":{"label":"juttle:fix-noargs-juttle-service","ref":"fix-noargs-juttle-service","sha":"511e82ddc46c2cebc0ea9cc65248067cf7fa9299","user":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"repo":{"id":50863155,"name":"juttle-service","full_name":"juttle/juttle-service","owner":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juttle/juttle-service","description":"API-based execution engine for juttle programs","fork":false,"url":"https://api.github.com/repos/juttle/juttle-service","forks_url":"https://api.github.com/repos/juttle/juttle-service/forks","keys_url":"https://api.github.com/repos/juttle/juttle-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juttle/juttle-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juttle/juttle-service/teams","hooks_url":"https://api.github.com/repos/juttle/juttle-service/hooks","issue_events_url":"https://api.github.com/repos/juttle/juttle-service/issues/events{/number}","events_url":"https://api.github.com/repos/juttle/juttle-service/events","assignees_url":"https://api.github.com/repos/juttle/juttle-service/assignees{/user}","branches_url":"https://api.github.com/repos/juttle/juttle-service/branches{/branch}","tags_url":"https://api.github.com/repos/juttle/juttle-service/tags","blobs_url":"https://api.github.com/repos/juttle/juttle-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juttle/juttle-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juttle/juttle-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/juttle/juttle-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juttle/juttle-service/statuses/{sha}","languages_url":"https://api.github.com/repos/juttle/juttle-service/languages","stargazers_url":"https://api.github.com/repos/juttle/juttle-service/stargazers","contributors_url":"https://api.github.com/repos/juttle/juttle-service/contributors","subscribers_url":"https://api.github.com/repos/juttle/juttle-service/subscribers","subscription_url":"https://api.github.com/repos/juttle/juttle-service/subscription","commits_url":"https://api.github.com/repos/juttle/juttle-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/juttle/juttle-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/juttle/juttle-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/juttle/juttle-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/juttle/juttle-service/contents/{+path}","compare_url":"https://api.github.com/repos/juttle/juttle-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juttle/juttle-service/merges","archive_url":"https://api.github.com/repos/juttle/juttle-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juttle/juttle-service/downloads","issues_url":"https://api.github.com/repos/juttle/juttle-service/issues{/number}","pulls_url":"https://api.github.com/repos/juttle/juttle-service/pulls{/number}","milestones_url":"https://api.github.com/repos/juttle/juttle-service/milestones{/number}","notifications_url":"https://api.github.com/repos/juttle/juttle-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juttle/juttle-service/labels{/name}","releases_url":"https://api.github.com/repos/juttle/juttle-service/releases{/id}","deployments_url":"https://api.github.com/repos/juttle/juttle-service/deployments","created_at":"2016-02-01T19:03:14Z","updated_at":"2016-03-14T18:04:57Z","pushed_at":"2016-03-24T21:28:57Z","git_url":"git://github.com/juttle/juttle-service.git","ssh_url":"git@github.com:juttle/juttle-service.git","clone_url":"https://github.com/juttle/juttle-service.git","svn_url":"https://github.com/juttle/juttle-service","homepage":null,"size":805,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"juttle:master","ref":"master","sha":"54538f381df2cfc09aa7b70675505b98916b448c","user":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"repo":{"id":50863155,"name":"juttle-service","full_name":"juttle/juttle-service","owner":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juttle/juttle-service","description":"API-based execution engine for juttle programs","fork":false,"url":"https://api.github.com/repos/juttle/juttle-service","forks_url":"https://api.github.com/repos/juttle/juttle-service/forks","keys_url":"https://api.github.com/repos/juttle/juttle-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juttle/juttle-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juttle/juttle-service/teams","hooks_url":"https://api.github.com/repos/juttle/juttle-service/hooks","issue_events_url":"https://api.github.com/repos/juttle/juttle-service/issues/events{/number}","events_url":"https://api.github.com/repos/juttle/juttle-service/events","assignees_url":"https://api.github.com/repos/juttle/juttle-service/assignees{/user}","branches_url":"https://api.github.com/repos/juttle/juttle-service/branches{/branch}","tags_url":"https://api.github.com/repos/juttle/juttle-service/tags","blobs_url":"https://api.github.com/repos/juttle/juttle-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juttle/juttle-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juttle/juttle-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/juttle/juttle-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juttle/juttle-service/statuses/{sha}","languages_url":"https://api.github.com/repos/juttle/juttle-service/languages","stargazers_url":"https://api.github.com/repos/juttle/juttle-service/stargazers","contributors_url":"https://api.github.com/repos/juttle/juttle-service/contributors","subscribers_url":"https://api.github.com/repos/juttle/juttle-service/subscribers","subscription_url":"https://api.github.com/repos/juttle/juttle-service/subscription","commits_url":"https://api.github.com/repos/juttle/juttle-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/juttle/juttle-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/juttle/juttle-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/juttle/juttle-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/juttle/juttle-service/contents/{+path}","compare_url":"https://api.github.com/repos/juttle/juttle-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juttle/juttle-service/merges","archive_url":"https://api.github.com/repos/juttle/juttle-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juttle/juttle-service/downloads","issues_url":"https://api.github.com/repos/juttle/juttle-service/issues{/number}","pulls_url":"https://api.github.com/repos/juttle/juttle-service/pulls{/number}","milestones_url":"https://api.github.com/repos/juttle/juttle-service/milestones{/number}","notifications_url":"https://api.github.com/repos/juttle/juttle-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juttle/juttle-service/labels{/name}","releases_url":"https://api.github.com/repos/juttle/juttle-service/releases{/id}","deployments_url":"https://api.github.com/repos/juttle/juttle-service/deployments","created_at":"2016-02-01T19:03:14Z","updated_at":"2016-03-14T18:04:57Z","pushed_at":"2016-03-24T21:28:57Z","git_url":"git://github.com/juttle/juttle-service.git","ssh_url":"git@github.com:juttle/juttle-service.git","clone_url":"https://github.com/juttle/juttle-service.git","svn_url":"https://github.com/juttle/juttle-service","homepage":null,"size":805,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juttle/juttle-service/pulls/77"},"html":{"href":"https://github.com/juttle/juttle-service/pull/77"},"issue":{"href":"https://api.github.com/repos/juttle/juttle-service/issues/77"},"comments":{"href":"https://api.github.com/repos/juttle/juttle-service/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/juttle/juttle-service/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/juttle/juttle-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juttle/juttle-service/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/juttle/juttle-service/statuses/511e82ddc46c2cebc0ea9cc65248067cf7fa9299"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":1,"additions":22,"deletions":15,"changed_files":2}}