{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments/85431074","pull_request_review_id":6149190,"id":85431074,"diff_hunk":"@@ -83,4 +86,12 @@ def email_from_symphony\n       SymphonyUserNameRequest.new(libid: library_id).email\n     end if library_id_user?\n   end\n+\n+  private\n+\n+  def notify_honeybadger_of_unknown_webauth_email!\n+    Honeybadger.notify(\n+      \"Webauth user record being saved without a valid email address. Using #{webauth}@stanford.edu instead.\"\n+    ) if new_record?","path":"app/models/user.rb","position":24,"original_position":24,"commit_id":"e70d08b781c4ce3ee4d0dc4107c296b7a32c8f43","original_commit_id":"e70d08b781c4ce3ee4d0dc4107c296b7a32c8f43","user":{"login":"tingulfsen","id":3740294,"avatar_url":"https://avatars.githubusercontent.com/u/3740294?v=3","gravatar_id":"","url":"https://api.github.com/users/tingulfsen","html_url":"https://github.com/tingulfsen","followers_url":"https://api.github.com/users/tingulfsen/followers","following_url":"https://api.github.com/users/tingulfsen/following{/other_user}","gists_url":"https://api.github.com/users/tingulfsen/gists{/gist_id}","starred_url":"https://api.github.com/users/tingulfsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tingulfsen/subscriptions","organizations_url":"https://api.github.com/users/tingulfsen/orgs","repos_url":"https://api.github.com/users/tingulfsen/repos","events_url":"https://api.github.com/users/tingulfsen/events{/privacy}","received_events_url":"https://api.github.com/users/tingulfsen/received_events","type":"User","site_admin":false},"body":"Is it possible for this method to be called when retrieving and old user, and that we're not actually trying to save the user at this point? Just wondering if the Honeybadger message needs to be massaged a little here.","created_at":"2016-10-27T21:25:24Z","updated_at":"2016-10-27T21:26:32Z","html_url":"https://github.com/sul-dlss/sul-requests/pull/608#discussion_r85431074","pull_request_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments/85431074"},"html":{"href":"https://github.com/sul-dlss/sul-requests/pull/608#discussion_r85431074"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608","id":91280298,"html_url":"https://github.com/sul-dlss/sul-requests/pull/608","diff_url":"https://github.com/sul-dlss/sul-requests/pull/608.diff","patch_url":"https://github.com/sul-dlss/sul-requests/pull/608.patch","issue_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/608","number":608,"state":"open","locked":false,"title":"Persist LDAP derived email addresses for webauth users in the…","user":{"login":"jkeck","id":96776,"avatar_url":"https://avatars.githubusercontent.com/u/96776?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeck","html_url":"https://github.com/jkeck","followers_url":"https://api.github.com/users/jkeck/followers","following_url":"https://api.github.com/users/jkeck/following{/other_user}","gists_url":"https://api.github.com/users/jkeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeck/subscriptions","organizations_url":"https://api.github.com/users/jkeck/orgs","repos_url":"https://api.github.com/users/jkeck/repos","events_url":"https://api.github.com/users/jkeck/events{/privacy}","received_events_url":"https://api.github.com/users/jkeck/received_events","type":"User","site_admin":false},"body":"…User.email attribute.","created_at":"2016-10-27T21:03:47Z","updated_at":"2016-10-27T21:26:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a03a8c9f44e47a7251b7a609917185cf0747cb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/608/comments","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/e70d08b781c4ce3ee4d0dc4107c296b7a32c8f43","head":{"label":"sul-dlss:ldap-email-fix","ref":"ldap-email-fix","sha":"e70d08b781c4ce3ee4d0dc4107c296b7a32c8f43","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/sul-requests/deployments","created_at":"2015-03-31T22:27:27Z","updated_at":"2016-10-24T18:50:41Z","pushed_at":"2016-10-27T21:17:31Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":2879,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":33,"forks":0,"open_issues":33,"watchers":2,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"6cd758c6acd99c6b3ce60a68d4b5804f2b4b82cc","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/sul-requests/deployments","created_at":"2015-03-31T22:27:27Z","updated_at":"2016-10-24T18:50:41Z","pushed_at":"2016-10-27T21:17:31Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":2879,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":33,"forks":0,"open_issues":33,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608"},"html":{"href":"https://github.com/sul-dlss/sul-requests/pull/608"},"issue":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/608"},"comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/e70d08b781c4ce3ee4d0dc4107c296b7a32c8f43"}}}}
{"actor":{"display_login":"tingulfsen"}}