{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5645","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5645/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5645/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5645/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/5645","id":165653709,"number":5645,"title":"Move samd21 to samr21","user":{"login":"keestux","id":318839,"avatar_url":"https://avatars.githubusercontent.com/u/318839?v=3","gravatar_id":"","url":"https://api.github.com/users/keestux","html_url":"https://github.com/keestux","followers_url":"https://api.github.com/users/keestux/followers","following_url":"https://api.github.com/users/keestux/following{/other_user}","gists_url":"https://api.github.com/users/keestux/gists{/gist_id}","starred_url":"https://api.github.com/users/keestux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keestux/subscriptions","organizations_url":"https://api.github.com/users/keestux/orgs","repos_url":"https://api.github.com/users/keestux/repos","events_url":"https://api.github.com/users/keestux/events{/privacy}","received_events_url":"https://api.github.com/users/keestux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/arm","name":"arm","color":"dddddd"}],"state":"open","locked":false,"assignee":{"login":"PeterKietzmann","id":7765855,"avatar_url":"https://avatars.githubusercontent.com/u/7765855?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterKietzmann","html_url":"https://github.com/PeterKietzmann","followers_url":"https://api.github.com/users/PeterKietzmann/followers","following_url":"https://api.github.com/users/PeterKietzmann/following{/other_user}","gists_url":"https://api.github.com/users/PeterKietzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKietzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKietzmann/subscriptions","organizations_url":"https://api.github.com/users/PeterKietzmann/orgs","repos_url":"https://api.github.com/users/PeterKietzmann/repos","events_url":"https://api.github.com/users/PeterKietzmann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKietzmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"PeterKietzmann","id":7765855,"avatar_url":"https://avatars.githubusercontent.com/u/7765855?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterKietzmann","html_url":"https://github.com/PeterKietzmann","followers_url":"https://api.github.com/users/PeterKietzmann/followers","following_url":"https://api.github.com/users/PeterKietzmann/following{/other_user}","gists_url":"https://api.github.com/users/PeterKietzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKietzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKietzmann/subscriptions","organizations_url":"https://api.github.com/users/PeterKietzmann/orgs","repos_url":"https://api.github.com/users/PeterKietzmann/repos","events_url":"https://api.github.com/users/PeterKietzmann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKietzmann/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/15","html_url":"https://github.com/RIOT-OS/RIOT/milestones/Release%202016.10","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/15/labels","id":1875567,"number":15,"title":"Release 2016.10","description":"","creator":{"login":"kYc0o","id":5419775,"avatar_url":"https://avatars.githubusercontent.com/u/5419775?v=3","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":1,"state":"open","created_at":"2016-07-11T11:41:17Z","updated_at":"2016-07-20T18:34:54Z","due_on":"2016-10-30T23:00:00Z","closed_at":null},"comments":11,"created_at":"2016-07-14T20:41:07Z","updated_at":"2016-07-21T00:25:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5645","html_url":"https://github.com/RIOT-OS/RIOT/pull/5645","diff_url":"https://github.com/RIOT-OS/RIOT/pull/5645.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/5645.patch"},"body":"Here  is a new PR to move samd21 to samr21 and to make room for adding samd21.\r\n\r\nI promise to do my best to create / merge the code into common pieces that I will place in sam21_common. But I want this change to be merged so that the next steps can be small(er). Well, except for my board addition plus cpu/samd21."},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/234123527","html_url":"https://github.com/RIOT-OS/RIOT/pull/5645#issuecomment-234123527","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5645","id":234123527,"user":{"login":"kYc0o","id":5419775,"avatar_url":"https://avatars.githubusercontent.com/u/5419775?v=3","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T00:25:01Z","updated_at":"2016-07-21T00:25:01Z","body":"> In the case of Atmel, they have 12 CPU's (or MCU's or whatever we name them) that are very much alike. All are Cortex M0. All have a similar set of peripherals (SERCOM, timers, etc). Atmel has supplied a set of include files (CMSIS) in their ASF. Until now RIOT has added two \"cpu\"s from that set. One in cpu/samd21 and one in cpu/saml21. But the one in cpu/samd21 is in fact a SAMR21. The include files in cpu/samd21/include came from from Atmel but were renamed to samd21. (( This, BTW, is my biggest hurdle. ))\r\n\r\nOK I got your point but I need first to be sure why you insist on put the SAMR21 in the CPU forlder, assuming that we call them CPUs but they are MCUs. Looking at the Atmel MCU SAMx offer [here](http://www.atmel.com/products/microcontrollers/arm/default.aspx), I cannot see any SAM R Cortex-M0 based MCU. However the SAM D and SAM L are there.\r\n\r\n> I'd say, try out my PR and you'll see that it continues to work. Under the surface it is merely a name change samd21-to-samr21.\r\n\r\nOn my understanding the SAMR21 SoC is composed by a SAMD21 MCU + AT86RF233 radio transceiver, thus I don't see a reason to rename the current `cpu/samd21` to `cpu/samr21`. On the contrary, I think this could lead to a misunderstanding on which CPU code should be used, since other boards like the Arduino Zero are based on a samd21 MCU. Thus using code from `cpu/samr21` wouldn't be logic. However, I can easily understand why a samr21 based board can use the code from `cpu/samd21` since it embeds a samd21 MCU, even if there's no explicit reference to a samr21 folder, wherever it would be located.\r\n\r\n> Oh, believe me. I am all for readable code. And I hope that my new code for the SERCOMs (UART, I2C, SPI) improves readability and ease of configuration. This new code will first show up in cpu/samd21 or cpu/sam21_common and then the samr21 or saml21 branches can be gradually changed to it it too, making them leaner.\r\n\r\nI completely agree on this point. If there is code that can be shared by several SAMx21 MCU it needs to be factorised. I'd propose to put it in a folder called `cpu/samx21_common`, assuming that our current supported saml21 MCU can also use code from there (and that Atmel won't release a SAM X MCU)."}}
{"actor":{"display_login":"kYc0o"}}