{"action":"created","comment":{"url":"https://api.github.com/repos/resteasy/Resteasy/pulls/comments/64992876","id":64992876,"diff_hunk":"@@ -0,0 +1,29 @@\n+package org.jboss.resteasy.plugins.delegates;\n+\n+import javax.ws.rs.core.NewCookie;\n+\n+import org.jboss.resteasy.resteasy_jaxrs.i18n.Messages;\n+\n+/**\n+ * \n+ * @author <a href=\"mailto:ron.sigal@jboss.com\">Ron Sigal</a>\n+ * @date May 20, 2016\n+ */\n+public class ClientCookieHeaderDelegate extends NewCookieHeaderDelegate\n+{\n+   public String toString(Object value)\n+   {\n+      if (value == null)\n+      {\n+         throw new IllegalArgumentException(Messages.MESSAGES.paramNull());\n+      }\n+      NewCookie cookie = (NewCookie) value;\n+      StringBuilder b = new StringBuilder();\n+      b.append(cookie.getName()).append('=');\n+      if (cookie.getValue() != null)\n+      {\n+         quote(b, cookie.getValue());","path":"resteasy-jaxrs/src/main/java/org/jboss/resteasy/plugins/delegates/ClientCookieHeaderDelegate.java","position":25,"original_position":25,"commit_id":"8d1a0363ee3a576e0c62613670a8bbc0683f310b","original_commit_id":"8d1a0363ee3a576e0c62613670a8bbc0683f310b","user":{"login":"tbroyer","id":173813,"avatar_url":"https://avatars.githubusercontent.com/u/173813?v=3","gravatar_id":"","url":"https://api.github.com/users/tbroyer","html_url":"https://github.com/tbroyer","followers_url":"https://api.github.com/users/tbroyer/followers","following_url":"https://api.github.com/users/tbroyer/following{/other_user}","gists_url":"https://api.github.com/users/tbroyer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbroyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbroyer/subscriptions","organizations_url":"https://api.github.com/users/tbroyer/orgs","repos_url":"https://api.github.com/users/tbroyer/repos","events_url":"https://api.github.com/users/tbroyer/events{/privacy}","received_events_url":"https://api.github.com/users/tbroyer/received_events","type":"User","site_admin":false},"body":"This is serializing \"version 0\" cookies (which happens to match what the web uses, and has been spec'd in RFC 6265), but the JAX-RS spec relies on RFC 2965 (version 1 cookies, never actually deployed by anyone).\r\nSo while this works (except values aren't quoted, but their value range restricted), this breaks spec compliance.\r\nI've filed a bug against the spec a while ago, left without any response.","created_at":"2016-05-28T19:19:24Z","updated_at":"2016-05-28T19:19:24Z","html_url":"https://github.com/resteasy/Resteasy/pull/816#discussion_r64992876","pull_request_url":"https://api.github.com/repos/resteasy/Resteasy/pulls/816","_links":{"self":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/comments/64992876"},"html":{"href":"https://github.com/resteasy/Resteasy/pull/816#discussion_r64992876"},"pull_request":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/816"}}},"pull_request":{"url":"https://api.github.com/repos/resteasy/Resteasy/pulls/816","id":71717354,"html_url":"https://github.com/resteasy/Resteasy/pull/816","diff_url":"https://github.com/resteasy/Resteasy/pull/816.diff","patch_url":"https://github.com/resteasy/Resteasy/pull/816.patch","issue_url":"https://api.github.com/repos/resteasy/Resteasy/issues/816","number":816,"state":"open","locked":false,"title":"[RESTEASY-1266]","user":{"login":"ronsigal","id":538611,"avatar_url":"https://avatars.githubusercontent.com/u/538611?v=3","gravatar_id":"","url":"https://api.github.com/users/ronsigal","html_url":"https://github.com/ronsigal","followers_url":"https://api.github.com/users/ronsigal/followers","following_url":"https://api.github.com/users/ronsigal/following{/other_user}","gists_url":"https://api.github.com/users/ronsigal/gists{/gist_id}","starred_url":"https://api.github.com/users/ronsigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronsigal/subscriptions","organizations_url":"https://api.github.com/users/ronsigal/orgs","repos_url":"https://api.github.com/users/ronsigal/repos","events_url":"https://api.github.com/users/ronsigal/events{/privacy}","received_events_url":"https://api.github.com/users/ronsigal/received_events","type":"User","site_admin":false},"body":"Fixed cookie handling.","created_at":"2016-05-27T13:59:36Z","updated_at":"2016-05-28T19:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad270961bcd5981b19628366b78c8608e380fdb4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/resteasy/Resteasy/pulls/816/commits","review_comments_url":"https://api.github.com/repos/resteasy/Resteasy/pulls/816/comments","review_comment_url":"https://api.github.com/repos/resteasy/Resteasy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resteasy/Resteasy/issues/816/comments","statuses_url":"https://api.github.com/repos/resteasy/Resteasy/statuses/8d1a0363ee3a576e0c62613670a8bbc0683f310b","head":{"label":"ronsigal:1266b","ref":"1266b","sha":"8d1a0363ee3a576e0c62613670a8bbc0683f310b","user":{"login":"ronsigal","id":538611,"avatar_url":"https://avatars.githubusercontent.com/u/538611?v=3","gravatar_id":"","url":"https://api.github.com/users/ronsigal","html_url":"https://github.com/ronsigal","followers_url":"https://api.github.com/users/ronsigal/followers","following_url":"https://api.github.com/users/ronsigal/following{/other_user}","gists_url":"https://api.github.com/users/ronsigal/gists{/gist_id}","starred_url":"https://api.github.com/users/ronsigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronsigal/subscriptions","organizations_url":"https://api.github.com/users/ronsigal/orgs","repos_url":"https://api.github.com/users/ronsigal/repos","events_url":"https://api.github.com/users/ronsigal/events{/privacy}","received_events_url":"https://api.github.com/users/ronsigal/received_events","type":"User","site_admin":false},"repo":{"id":3166001,"name":"Resteasy","full_name":"ronsigal/Resteasy","owner":{"login":"ronsigal","id":538611,"avatar_url":"https://avatars.githubusercontent.com/u/538611?v=3","gravatar_id":"","url":"https://api.github.com/users/ronsigal","html_url":"https://github.com/ronsigal","followers_url":"https://api.github.com/users/ronsigal/followers","following_url":"https://api.github.com/users/ronsigal/following{/other_user}","gists_url":"https://api.github.com/users/ronsigal/gists{/gist_id}","starred_url":"https://api.github.com/users/ronsigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronsigal/subscriptions","organizations_url":"https://api.github.com/users/ronsigal/orgs","repos_url":"https://api.github.com/users/ronsigal/repos","events_url":"https://api.github.com/users/ronsigal/events{/privacy}","received_events_url":"https://api.github.com/users/ronsigal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronsigal/Resteasy","description":"REST and JAXRS","fork":true,"url":"https://api.github.com/repos/ronsigal/Resteasy","forks_url":"https://api.github.com/repos/ronsigal/Resteasy/forks","keys_url":"https://api.github.com/repos/ronsigal/Resteasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronsigal/Resteasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronsigal/Resteasy/teams","hooks_url":"https://api.github.com/repos/ronsigal/Resteasy/hooks","issue_events_url":"https://api.github.com/repos/ronsigal/Resteasy/issues/events{/number}","events_url":"https://api.github.com/repos/ronsigal/Resteasy/events","assignees_url":"https://api.github.com/repos/ronsigal/Resteasy/assignees{/user}","branches_url":"https://api.github.com/repos/ronsigal/Resteasy/branches{/branch}","tags_url":"https://api.github.com/repos/ronsigal/Resteasy/tags","blobs_url":"https://api.github.com/repos/ronsigal/Resteasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronsigal/Resteasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronsigal/Resteasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronsigal/Resteasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronsigal/Resteasy/statuses/{sha}","languages_url":"https://api.github.com/repos/ronsigal/Resteasy/languages","stargazers_url":"https://api.github.com/repos/ronsigal/Resteasy/stargazers","contributors_url":"https://api.github.com/repos/ronsigal/Resteasy/contributors","subscribers_url":"https://api.github.com/repos/ronsigal/Resteasy/subscribers","subscription_url":"https://api.github.com/repos/ronsigal/Resteasy/subscription","commits_url":"https://api.github.com/repos/ronsigal/Resteasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronsigal/Resteasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronsigal/Resteasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronsigal/Resteasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronsigal/Resteasy/contents/{+path}","compare_url":"https://api.github.com/repos/ronsigal/Resteasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronsigal/Resteasy/merges","archive_url":"https://api.github.com/repos/ronsigal/Resteasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronsigal/Resteasy/downloads","issues_url":"https://api.github.com/repos/ronsigal/Resteasy/issues{/number}","pulls_url":"https://api.github.com/repos/ronsigal/Resteasy/pulls{/number}","milestones_url":"https://api.github.com/repos/ronsigal/Resteasy/milestones{/number}","notifications_url":"https://api.github.com/repos/ronsigal/Resteasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronsigal/Resteasy/labels{/name}","releases_url":"https://api.github.com/repos/ronsigal/Resteasy/releases{/id}","deployments_url":"https://api.github.com/repos/ronsigal/Resteasy/deployments","created_at":"2012-01-12T21:30:45Z","updated_at":"2015-04-25T18:05:43Z","pushed_at":"2016-05-27T13:58:26Z","git_url":"git://github.com/ronsigal/Resteasy.git","ssh_url":"git@github.com:ronsigal/Resteasy.git","clone_url":"https://github.com/ronsigal/Resteasy.git","svn_url":"https://github.com/ronsigal/Resteasy","homepage":"http://jboss.org/resteasy","size":29162,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"resteasy:master","ref":"master","sha":"a27930e049cbd5a0514122d56673c422478c77ae","user":{"login":"resteasy","id":1252373,"avatar_url":"https://avatars.githubusercontent.com/u/1252373?v=3","gravatar_id":"","url":"https://api.github.com/users/resteasy","html_url":"https://github.com/resteasy","followers_url":"https://api.github.com/users/resteasy/followers","following_url":"https://api.github.com/users/resteasy/following{/other_user}","gists_url":"https://api.github.com/users/resteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/resteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resteasy/subscriptions","organizations_url":"https://api.github.com/users/resteasy/orgs","repos_url":"https://api.github.com/users/resteasy/repos","events_url":"https://api.github.com/users/resteasy/events{/privacy}","received_events_url":"https://api.github.com/users/resteasy/received_events","type":"Organization","site_admin":false},"repo":{"id":2948043,"name":"Resteasy","full_name":"resteasy/Resteasy","owner":{"login":"resteasy","id":1252373,"avatar_url":"https://avatars.githubusercontent.com/u/1252373?v=3","gravatar_id":"","url":"https://api.github.com/users/resteasy","html_url":"https://github.com/resteasy","followers_url":"https://api.github.com/users/resteasy/followers","following_url":"https://api.github.com/users/resteasy/following{/other_user}","gists_url":"https://api.github.com/users/resteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/resteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resteasy/subscriptions","organizations_url":"https://api.github.com/users/resteasy/orgs","repos_url":"https://api.github.com/users/resteasy/repos","events_url":"https://api.github.com/users/resteasy/events{/privacy}","received_events_url":"https://api.github.com/users/resteasy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resteasy/Resteasy","description":"REST and JAXRS","fork":false,"url":"https://api.github.com/repos/resteasy/Resteasy","forks_url":"https://api.github.com/repos/resteasy/Resteasy/forks","keys_url":"https://api.github.com/repos/resteasy/Resteasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resteasy/Resteasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resteasy/Resteasy/teams","hooks_url":"https://api.github.com/repos/resteasy/Resteasy/hooks","issue_events_url":"https://api.github.com/repos/resteasy/Resteasy/issues/events{/number}","events_url":"https://api.github.com/repos/resteasy/Resteasy/events","assignees_url":"https://api.github.com/repos/resteasy/Resteasy/assignees{/user}","branches_url":"https://api.github.com/repos/resteasy/Resteasy/branches{/branch}","tags_url":"https://api.github.com/repos/resteasy/Resteasy/tags","blobs_url":"https://api.github.com/repos/resteasy/Resteasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resteasy/Resteasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resteasy/Resteasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/resteasy/Resteasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resteasy/Resteasy/statuses/{sha}","languages_url":"https://api.github.com/repos/resteasy/Resteasy/languages","stargazers_url":"https://api.github.com/repos/resteasy/Resteasy/stargazers","contributors_url":"https://api.github.com/repos/resteasy/Resteasy/contributors","subscribers_url":"https://api.github.com/repos/resteasy/Resteasy/subscribers","subscription_url":"https://api.github.com/repos/resteasy/Resteasy/subscription","commits_url":"https://api.github.com/repos/resteasy/Resteasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/resteasy/Resteasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/resteasy/Resteasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/resteasy/Resteasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/resteasy/Resteasy/contents/{+path}","compare_url":"https://api.github.com/repos/resteasy/Resteasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resteasy/Resteasy/merges","archive_url":"https://api.github.com/repos/resteasy/Resteasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resteasy/Resteasy/downloads","issues_url":"https://api.github.com/repos/resteasy/Resteasy/issues{/number}","pulls_url":"https://api.github.com/repos/resteasy/Resteasy/pulls{/number}","milestones_url":"https://api.github.com/repos/resteasy/Resteasy/milestones{/number}","notifications_url":"https://api.github.com/repos/resteasy/Resteasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resteasy/Resteasy/labels{/name}","releases_url":"https://api.github.com/repos/resteasy/Resteasy/releases{/id}","deployments_url":"https://api.github.com/repos/resteasy/Resteasy/deployments","created_at":"2011-12-09T15:15:43Z","updated_at":"2016-05-27T09:13:36Z","pushed_at":"2016-05-27T23:32:33Z","git_url":"git://github.com/resteasy/Resteasy.git","ssh_url":"git@github.com:resteasy/Resteasy.git","clone_url":"https://github.com/resteasy/Resteasy.git","svn_url":"https://github.com/resteasy/Resteasy","homepage":"http://jboss.org/resteasy","size":31450,"stargazers_count":481,"watchers_count":481,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":54,"forks":588,"open_issues":54,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/816"},"html":{"href":"https://github.com/resteasy/Resteasy/pull/816"},"issue":{"href":"https://api.github.com/repos/resteasy/Resteasy/issues/816"},"comments":{"href":"https://api.github.com/repos/resteasy/Resteasy/issues/816/comments"},"review_comments":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/816/comments"},"review_comment":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resteasy/Resteasy/pulls/816/commits"},"statuses":{"href":"https://api.github.com/repos/resteasy/Resteasy/statuses/8d1a0363ee3a576e0c62613670a8bbc0683f310b"}}}}
{"actor":{"display_login":"tbroyer"}}