{"action":"created","comment":{"url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/comments/52622098","id":52622098,"diff_hunk":"@@ -135,10 +136,17 @@ ContentListView.prototype.add = function(content, forcedIndex, opts) {\n         // Remove non visible view\n         this.remove(viewToRemove);\n     }\n-    \n+\n+    this.recordImpression(content);\n     return newView;\n };\n \n+ContentListView.prototype.recordImpression = function (content) {","path":"src/content/views/content-list-view.js","position":18,"original_position":18,"commit_id":"4746871cf130cbd669dedae7c84f84096f10a5af","original_commit_id":"4746871cf130cbd669dedae7c84f84096f10a5af","user":{"login":"raviranjan-tudip","id":13483912,"avatar_url":"https://avatars.githubusercontent.com/u/13483912?v=3","gravatar_id":"","url":"https://api.github.com/users/raviranjan-tudip","html_url":"https://github.com/raviranjan-tudip","followers_url":"https://api.github.com/users/raviranjan-tudip/followers","following_url":"https://api.github.com/users/raviranjan-tudip/following{/other_user}","gists_url":"https://api.github.com/users/raviranjan-tudip/gists{/gist_id}","starred_url":"https://api.github.com/users/raviranjan-tudip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raviranjan-tudip/subscriptions","organizations_url":"https://api.github.com/users/raviranjan-tudip/orgs","repos_url":"https://api.github.com/users/raviranjan-tudip/repos","events_url":"https://api.github.com/users/raviranjan-tudip/events{/privacy}","received_events_url":"https://api.github.com/users/raviranjan-tudip/received_events","type":"User","site_admin":false},"body":"If the changes will be made in content-view.js and twitter-control-view.js then it will be reflected only to the mosaic-component. While changes in content-list-view.js and twitter-content-view.js will be reflected to all visualizations. Currently, the changes that is done is working for all visualizations.","created_at":"2016-02-11T16:05:50Z","updated_at":"2016-02-11T16:05:50Z","html_url":"https://github.com/Livefyre/streamhub-sdk/pull/356#discussion_r52622098","pull_request_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356","_links":{"self":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/comments/52622098"},"html":{"href":"https://github.com/Livefyre/streamhub-sdk/pull/356#discussion_r52622098"},"pull_request":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356","id":57971762,"html_url":"https://github.com/Livefyre/streamhub-sdk/pull/356","diff_url":"https://github.com/Livefyre/streamhub-sdk/pull/356.diff","patch_url":"https://github.com/Livefyre/streamhub-sdk/pull/356.patch","issue_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/356","number":356,"state":"open","locked":false,"title":"LF-20287: Add Twitter impression tracker to all apps that can display Twitter content","user":{"login":"raviranjan-tudip","id":13483912,"avatar_url":"https://avatars.githubusercontent.com/u/13483912?v=3","gravatar_id":"","url":"https://api.github.com/users/raviranjan-tudip","html_url":"https://github.com/raviranjan-tudip","followers_url":"https://api.github.com/users/raviranjan-tudip/followers","following_url":"https://api.github.com/users/raviranjan-tudip/following{/other_user}","gists_url":"https://api.github.com/users/raviranjan-tudip/gists{/gist_id}","starred_url":"https://api.github.com/users/raviranjan-tudip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raviranjan-tudip/subscriptions","organizations_url":"https://api.github.com/users/raviranjan-tudip/orgs","repos_url":"https://api.github.com/users/raviranjan-tudip/repos","events_url":"https://api.github.com/users/raviranjan-tudip/events{/privacy}","received_events_url":"https://api.github.com/users/raviranjan-tudip/received_events","type":"User","site_admin":false},"body":"Tracking of twitter impressions.","created_at":"2016-02-02T11:09:10Z","updated_at":"2016-02-11T16:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b481c2b33bfdb212bd4fbfb92acb54989840e22d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356/commits","review_comments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356/comments","review_comment_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/356/comments","statuses_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/statuses/4746871cf130cbd669dedae7c84f84096f10a5af","head":{"label":"Livefyre:tudip","ref":"tudip","sha":"4746871cf130cbd669dedae7c84f84096f10a5af","user":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?v=3","gravatar_id":"","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"repo":{"id":8787298,"name":"streamhub-sdk","full_name":"Livefyre/streamhub-sdk","owner":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?v=3","gravatar_id":"","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Livefyre/streamhub-sdk","description":"Build embeddable webapps with Livefyre StreamHub","fork":false,"url":"https://api.github.com/repos/Livefyre/streamhub-sdk","forks_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/forks","keys_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/teams","hooks_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/hooks","issue_events_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/events","assignees_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/tags","blobs_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/languages","stargazers_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/stargazers","contributors_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/contributors","subscribers_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/subscribers","subscription_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/subscription","commits_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/merges","archive_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/downloads","issues_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/deployments","created_at":"2013-03-14T23:01:09Z","updated_at":"2016-01-25T15:30:20Z","pushed_at":"2016-02-11T06:44:09Z","git_url":"git://github.com/Livefyre/streamhub-sdk.git","ssh_url":"git@github.com:Livefyre/streamhub-sdk.git","clone_url":"https://github.com/Livefyre/streamhub-sdk.git","svn_url":"https://github.com/Livefyre/streamhub-sdk","homepage":"http://livefyre.github.io/streamhub-sdk","size":7815,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":25,"default_branch":"master"}},"base":{"label":"Livefyre:master","ref":"master","sha":"e52a2eb2f634af562aff16ac285e459a1c325c09","user":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?v=3","gravatar_id":"","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"repo":{"id":8787298,"name":"streamhub-sdk","full_name":"Livefyre/streamhub-sdk","owner":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?v=3","gravatar_id":"","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Livefyre/streamhub-sdk","description":"Build embeddable webapps with Livefyre StreamHub","fork":false,"url":"https://api.github.com/repos/Livefyre/streamhub-sdk","forks_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/forks","keys_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/teams","hooks_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/hooks","issue_events_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/events","assignees_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/tags","blobs_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/languages","stargazers_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/stargazers","contributors_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/contributors","subscribers_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/subscribers","subscription_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/subscription","commits_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/merges","archive_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/downloads","issues_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Livefyre/streamhub-sdk/deployments","created_at":"2013-03-14T23:01:09Z","updated_at":"2016-01-25T15:30:20Z","pushed_at":"2016-02-11T06:44:09Z","git_url":"git://github.com/Livefyre/streamhub-sdk.git","ssh_url":"git@github.com:Livefyre/streamhub-sdk.git","clone_url":"https://github.com/Livefyre/streamhub-sdk.git","svn_url":"https://github.com/Livefyre/streamhub-sdk","homepage":"http://livefyre.github.io/streamhub-sdk","size":7815,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356"},"html":{"href":"https://github.com/Livefyre/streamhub-sdk/pull/356"},"issue":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/356"},"comments":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/Livefyre/streamhub-sdk/statuses/4746871cf130cbd669dedae7c84f84096f10a5af"}}}}