{"action":"opened","number":155,"pull_request":{"url":"https://api.github.com/repos/nsqio/pynsq/pulls/155","id":72404498,"html_url":"https://github.com/nsqio/pynsq/pull/155","diff_url":"https://github.com/nsqio/pynsq/pull/155.diff","patch_url":"https://github.com/nsqio/pynsq/pull/155.patch","issue_url":"https://api.github.com/repos/nsqio/pynsq/issues/155","number":155,"state":"open","locked":false,"title":"Use floats instead of Decimal class","user":{"login":"virtuald","id":567900,"avatar_url":"https://avatars.githubusercontent.com/u/567900?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"body":"It's not immediately clear why the Decimal class is being used here, when it seems like pure floats are just as good. \r\n\r\n- Profiling indicates lots of time spent here, reduced 50000 messages\r\n  from 23s to 18s (not raw NSQ timing, with custom layering on top)\r\n\r\nHaven't ran the tests yet, going to let Travis do that for me :)","created_at":"2016-06-02T19:36:28Z","updated_at":"2016-06-02T19:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"985240262e1a29760c4417e3950db9de5d26aec1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nsqio/pynsq/pulls/155/commits","review_comments_url":"https://api.github.com/repos/nsqio/pynsq/pulls/155/comments","review_comment_url":"https://api.github.com/repos/nsqio/pynsq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nsqio/pynsq/issues/155/comments","statuses_url":"https://api.github.com/repos/nsqio/pynsq/statuses/f992f783c6f422b3dbed69af54c099c5006fcade","head":{"label":"virtuald:perf-remove-decimal","ref":"perf-remove-decimal","sha":"f992f783c6f422b3dbed69af54c099c5006fcade","user":{"login":"virtuald","id":567900,"avatar_url":"https://avatars.githubusercontent.com/u/567900?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"repo":{"id":21723701,"name":"pynsq","full_name":"virtuald/pynsq","owner":{"login":"virtuald","id":567900,"avatar_url":"https://avatars.githubusercontent.com/u/567900?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/virtuald/pynsq","description":"official Python client library for NSQ","fork":true,"url":"https://api.github.com/repos/virtuald/pynsq","forks_url":"https://api.github.com/repos/virtuald/pynsq/forks","keys_url":"https://api.github.com/repos/virtuald/pynsq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtuald/pynsq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtuald/pynsq/teams","hooks_url":"https://api.github.com/repos/virtuald/pynsq/hooks","issue_events_url":"https://api.github.com/repos/virtuald/pynsq/issues/events{/number}","events_url":"https://api.github.com/repos/virtuald/pynsq/events","assignees_url":"https://api.github.com/repos/virtuald/pynsq/assignees{/user}","branches_url":"https://api.github.com/repos/virtuald/pynsq/branches{/branch}","tags_url":"https://api.github.com/repos/virtuald/pynsq/tags","blobs_url":"https://api.github.com/repos/virtuald/pynsq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtuald/pynsq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtuald/pynsq/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtuald/pynsq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtuald/pynsq/statuses/{sha}","languages_url":"https://api.github.com/repos/virtuald/pynsq/languages","stargazers_url":"https://api.github.com/repos/virtuald/pynsq/stargazers","contributors_url":"https://api.github.com/repos/virtuald/pynsq/contributors","subscribers_url":"https://api.github.com/repos/virtuald/pynsq/subscribers","subscription_url":"https://api.github.com/repos/virtuald/pynsq/subscription","commits_url":"https://api.github.com/repos/virtuald/pynsq/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtuald/pynsq/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtuald/pynsq/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtuald/pynsq/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtuald/pynsq/contents/{+path}","compare_url":"https://api.github.com/repos/virtuald/pynsq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtuald/pynsq/merges","archive_url":"https://api.github.com/repos/virtuald/pynsq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtuald/pynsq/downloads","issues_url":"https://api.github.com/repos/virtuald/pynsq/issues{/number}","pulls_url":"https://api.github.com/repos/virtuald/pynsq/pulls{/number}","milestones_url":"https://api.github.com/repos/virtuald/pynsq/milestones{/number}","notifications_url":"https://api.github.com/repos/virtuald/pynsq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtuald/pynsq/labels{/name}","releases_url":"https://api.github.com/repos/virtuald/pynsq/releases{/id}","deployments_url":"https://api.github.com/repos/virtuald/pynsq/deployments","created_at":"2014-07-11T05:50:53Z","updated_at":"2016-06-02T19:32:40Z","pushed_at":"2016-06-02T19:34:37Z","git_url":"git://github.com/virtuald/pynsq.git","ssh_url":"git@github.com:virtuald/pynsq.git","clone_url":"https://github.com/virtuald/pynsq.git","svn_url":"https://github.com/virtuald/pynsq","homepage":null,"size":352,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nsqio:master","ref":"master","sha":"40a637b02c28edfb7723373b81f7e7b9d5e364ed","user":{"login":"nsqio","id":8295919,"avatar_url":"https://avatars.githubusercontent.com/u/8295919?v=3","gravatar_id":"","url":"https://api.github.com/users/nsqio","html_url":"https://github.com/nsqio","followers_url":"https://api.github.com/users/nsqio/followers","following_url":"https://api.github.com/users/nsqio/following{/other_user}","gists_url":"https://api.github.com/users/nsqio/gists{/gist_id}","starred_url":"https://api.github.com/users/nsqio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsqio/subscriptions","organizations_url":"https://api.github.com/users/nsqio/orgs","repos_url":"https://api.github.com/users/nsqio/repos","events_url":"https://api.github.com/users/nsqio/events{/privacy}","received_events_url":"https://api.github.com/users/nsqio/received_events","type":"Organization","site_admin":false},"repo":{"id":6475842,"name":"pynsq","full_name":"nsqio/pynsq","owner":{"login":"nsqio","id":8295919,"avatar_url":"https://avatars.githubusercontent.com/u/8295919?v=3","gravatar_id":"","url":"https://api.github.com/users/nsqio","html_url":"https://github.com/nsqio","followers_url":"https://api.github.com/users/nsqio/followers","following_url":"https://api.github.com/users/nsqio/following{/other_user}","gists_url":"https://api.github.com/users/nsqio/gists{/gist_id}","starred_url":"https://api.github.com/users/nsqio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsqio/subscriptions","organizations_url":"https://api.github.com/users/nsqio/orgs","repos_url":"https://api.github.com/users/nsqio/repos","events_url":"https://api.github.com/users/nsqio/events{/privacy}","received_events_url":"https://api.github.com/users/nsqio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nsqio/pynsq","description":"The official Python client library for NSQ","fork":false,"url":"https://api.github.com/repos/nsqio/pynsq","forks_url":"https://api.github.com/repos/nsqio/pynsq/forks","keys_url":"https://api.github.com/repos/nsqio/pynsq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsqio/pynsq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsqio/pynsq/teams","hooks_url":"https://api.github.com/repos/nsqio/pynsq/hooks","issue_events_url":"https://api.github.com/repos/nsqio/pynsq/issues/events{/number}","events_url":"https://api.github.com/repos/nsqio/pynsq/events","assignees_url":"https://api.github.com/repos/nsqio/pynsq/assignees{/user}","branches_url":"https://api.github.com/repos/nsqio/pynsq/branches{/branch}","tags_url":"https://api.github.com/repos/nsqio/pynsq/tags","blobs_url":"https://api.github.com/repos/nsqio/pynsq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsqio/pynsq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsqio/pynsq/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsqio/pynsq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsqio/pynsq/statuses/{sha}","languages_url":"https://api.github.com/repos/nsqio/pynsq/languages","stargazers_url":"https://api.github.com/repos/nsqio/pynsq/stargazers","contributors_url":"https://api.github.com/repos/nsqio/pynsq/contributors","subscribers_url":"https://api.github.com/repos/nsqio/pynsq/subscribers","subscription_url":"https://api.github.com/repos/nsqio/pynsq/subscription","commits_url":"https://api.github.com/repos/nsqio/pynsq/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsqio/pynsq/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsqio/pynsq/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsqio/pynsq/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsqio/pynsq/contents/{+path}","compare_url":"https://api.github.com/repos/nsqio/pynsq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsqio/pynsq/merges","archive_url":"https://api.github.com/repos/nsqio/pynsq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsqio/pynsq/downloads","issues_url":"https://api.github.com/repos/nsqio/pynsq/issues{/number}","pulls_url":"https://api.github.com/repos/nsqio/pynsq/pulls{/number}","milestones_url":"https://api.github.com/repos/nsqio/pynsq/milestones{/number}","notifications_url":"https://api.github.com/repos/nsqio/pynsq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsqio/pynsq/labels{/name}","releases_url":"https://api.github.com/repos/nsqio/pynsq/releases{/id}","deployments_url":"https://api.github.com/repos/nsqio/pynsq/deployments","created_at":"2012-10-31T15:09:40Z","updated_at":"2016-05-28T06:20:50Z","pushed_at":"2016-06-02T19:36:28Z","git_url":"git://github.com/nsqio/pynsq.git","ssh_url":"git@github.com:nsqio/pynsq.git","clone_url":"https://github.com/nsqio/pynsq.git","svn_url":"https://github.com/nsqio/pynsq","homepage":"","size":506,"stargazers_count":170,"watchers_count":170,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":8,"forks":80,"open_issues":8,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nsqio/pynsq/pulls/155"},"html":{"href":"https://github.com/nsqio/pynsq/pull/155"},"issue":{"href":"https://api.github.com/repos/nsqio/pynsq/issues/155"},"comments":{"href":"https://api.github.com/repos/nsqio/pynsq/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/nsqio/pynsq/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/nsqio/pynsq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nsqio/pynsq/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/nsqio/pynsq/statuses/f992f783c6f422b3dbed69af54c099c5006fcade"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":23,"changed_files":1}}
{"actor":{"display_login":"virtuald"}}