{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/60474952","id":60474952,"diff_hunk":"@@ -0,0 +1,113 @@\n+from spack import *\n+import os\n+\n+class Intel(Package):\n+    \"\"\"Intel Compilers.\n+\n+    Note: You will have to add add the downolad file to a\n+    mirror so that Spack can find it. For instructions on how to set up a\n+    mirror, see http://software.llnl.gov/spack/mirrors.html\"\"\"\n+\n+    homepage = \"http://www.intel.com\"\n+\n+    # TODO: can also try the online installer (will download files on demand)\n+    version('composer.2016.2', '1133fb831312eb519f7da897fec223fa',\n+            url=\"file://%s/parallel_studio_xe_2016_composer_edition_update2.tgz\" % os.getcwd())\n+    version('professional.2016.2', '70be832f2d34c9bf596a5e99d5f2d832',\n+            url=\"file://%s/parallel_studio_xe_2016_update2.tgz\" % os.getcwd())\n+    version('cluster.2016.2', '70be832f2d34c9bf596a5e99d5f2d832',\n+            url=\"file://%s/parallel_studio_xe_2016_update2.tgz\" % os.getcwd())\n+\n+    variant('rpath', default=True, description=\"Add rpath to .cfg files\")\n+    variant('all', default=False, description=\"Install all files associated with the requested edition\")\n+    variant('mpi', default=True, description=\"Install the Intel MPI library and ITAC tool\")\n+    variant('mkl', default=True, description=\"Install the Intel MKL library\")\n+    variant('daal', default=True, description=\"Install the Intel DAAL libraries\")\n+    variant('ipp', default=True, description=\"Install the Intel IPP libraries\")\n+    variant('tools', default=True, description=\"Install the Intel Advisor, VTune Amplifier, and Inspector tools\")\n+\n+    provides('mpi', when='@cluster:+mpi')\n+    provides('mkl', when='+mkl')","path":"var/spack/repos/builtin/packages/intel/package.py","position":30,"original_position":30,"commit_id":"395cde41a28c7c08c27199ad5d2ee8572f8c1bce","original_commit_id":"46e8f2635114d539842f0703ac557983e2b08eb4","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"Great. I wonder if it's possible to expand `depends_on` to allow something like `depends_on('blas', 'mkl')` so it can depend on one or the other. Would this solve the problem?","created_at":"2016-04-20T19:46:59Z","updated_at":"2016-04-20T19:46:59Z","html_url":"https://github.com/LLNL/spack/pull/796#discussion_r60474952","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/796","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/60474952"},"html":{"href":"https://github.com/LLNL/spack/pull/796#discussion_r60474952"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/796"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/796","id":66929038,"html_url":"https://github.com/LLNL/spack/pull/796","diff_url":"https://github.com/LLNL/spack/pull/796.diff","patch_url":"https://github.com/LLNL/spack/pull/796.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/796","number":796,"state":"open","locked":false,"title":"initial package","user":{"login":"lee218llnl","id":3641995,"avatar_url":"https://avatars.githubusercontent.com/u/3641995?v=3","gravatar_id":"","url":"https://api.github.com/users/lee218llnl","html_url":"https://github.com/lee218llnl","followers_url":"https://api.github.com/users/lee218llnl/followers","following_url":"https://api.github.com/users/lee218llnl/following{/other_user}","gists_url":"https://api.github.com/users/lee218llnl/gists{/gist_id}","starred_url":"https://api.github.com/users/lee218llnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee218llnl/subscriptions","organizations_url":"https://api.github.com/users/lee218llnl/orgs","repos_url":"https://api.github.com/users/lee218llnl/repos","events_url":"https://api.github.com/users/lee218llnl/events{/privacy}","received_events_url":"https://api.github.com/users/lee218llnl/received_events","type":"User","site_admin":false},"body":"All,\r\n\r\nHere is my initial implementation of the Intel compiler package, addressing #761. It currently distinguishes between the \"cluster\", \"professional\", and \"composer\" editions. This whole thing is admittedly a bit of a mess, so feedback is much appreciated, particularly w.r.t. how versions and variants are being handled. A lot of the mess is due to flexibility I tried adding and we can certainly clean things up by just setting components to \"ALL\" and not allow the removal of the libraries. I know here at LLNL, we don't care much about daal and ipp, and both take up a lot of disk space. \r\n\r\nThe package will need to be updated to use the license features of #553 and in the meantime you will have to set your license_path appropriately.","created_at":"2016-04-18T21:57:31Z","updated_at":"2016-04-20T19:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f84f5c4ffcd805a16fa8a3d3f8b8c699313cbb09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/796/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/796/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/796/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/395cde41a28c7c08c27199ad5d2ee8572f8c1bce","head":{"label":"LLNL:features/intel","ref":"features/intel","sha":"395cde41a28c7c08c27199ad5d2ee8572f8c1bce","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-04-20T06:01:17Z","pushed_at":"2016-04-20T19:18:49Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":12717,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":171,"forks":95,"open_issues":171,"watchers":105,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"dd84a575807636159d80809f59962cf799b83fd7","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-04-20T06:01:17Z","pushed_at":"2016-04-20T19:18:49Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":12717,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":171,"forks":95,"open_issues":171,"watchers":105,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/796"},"html":{"href":"https://github.com/LLNL/spack/pull/796"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/796"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/395cde41a28c7c08c27199ad5d2ee8572f8c1bce"}}}}