{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/78197372","id":78197372,"diff_hunk":"@@ -0,0 +1,6 @@\n+from pulp.platform import ProgressBar, ProgressSpinner, Repository, RepositoryContent\n+\n+from .cataloger import Cataloger\n+from .distributor import RepositoryDistributor\n+from .importer import RepositoryImporter\n+from .profiler import Profiler","path":"plugin/pulp/plugin/__init__.py","position":6,"original_position":6,"commit_id":"34542f517e1837f8d4090e55980d6f89a8053c17","original_commit_id":"34542f517e1837f8d4090e55980d6f89a8053c17","user":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"body":"I think it' ok to use them. These modules should always be relative to this `__init__.py` file. Even a few weeks ago I was arguing against not using them. Recently I re-evaluated my thoughts on them and now I think they are OK. Django uses them in its examples so they can't be that bad. The issue we had in pulp 2.y was that you couldn't run only one test. There was something about the way the tests were setup, run, or the test runner which would cause a line like this to fail:\r\n\r\n`from ....base import PulpServerTests`\r\n\r\nI think that was due to some other issue and wasn't related to it being a relative import necessarily.\r\n\r\nI plan to leave them here for now and also leave them in in [pulp.platform.models](https://github.com/pulp/pulp/blob/6bb793295b65d041a7e10820d67e7c9eaa560865/platform/pulp/platform/models/__init__.py). If you want to change them I'm OK with that too.","created_at":"2016-09-09T15:14:30Z","updated_at":"2016-09-09T15:14:30Z","html_url":"https://github.com/pulp/pulp/pull/2734#discussion_r78197372","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/2734","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/78197372"},"html":{"href":"https://github.com/pulp/pulp/pull/2734#discussion_r78197372"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2734"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/2734","id":84028415,"html_url":"https://github.com/pulp/pulp/pull/2734","diff_url":"https://github.com/pulp/pulp/pull/2734.diff","patch_url":"https://github.com/pulp/pulp/pull/2734.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/2734","number":2734,"state":"open","locked":false,"title":"Creates basic pulp.plugin","user":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"body":"This PR adds a base Cataloger and Profiler objects to\r\npulp.plugin. It as imports the following objects from\r\npulp.platform.models for usage by plugins:\r\n\r\n* Distributor\r\n* Importer\r\n* Repository\r\n* RepositoryContent\r\n\r\nIt removes several modules from the old pulp.plugins\r\npackage.\r\n\r\nThis does not have an interface for upload. After thinking about it I believe platform can do everything for upload assuming that a plugin writer has defined the Content type correctly. If this turns out not to be the case we can easily add the upload interface.\r\n\r\ncloses #2181\r\nhttps://pulp.plan.io/issues/2181","created_at":"2016-09-05T17:35:26Z","updated_at":"2016-09-09T15:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9314dad6fa3e03a0a61d19fb4a536158fad84715","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/2734/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/2734/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/2734/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/34542f517e1837f8d4090e55980d6f89a8053c17","head":{"label":"bmbouter:2181-German-Pils","ref":"2181-German-Pils","sha":"34542f517e1837f8d4090e55980d6f89a8053c17","user":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"repo":{"id":24460180,"name":"pulp","full_name":"bmbouter/pulp","owner":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmbouter/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/bmbouter/pulp","forks_url":"https://api.github.com/repos/bmbouter/pulp/forks","keys_url":"https://api.github.com/repos/bmbouter/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmbouter/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmbouter/pulp/teams","hooks_url":"https://api.github.com/repos/bmbouter/pulp/hooks","issue_events_url":"https://api.github.com/repos/bmbouter/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/bmbouter/pulp/events","assignees_url":"https://api.github.com/repos/bmbouter/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/bmbouter/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/bmbouter/pulp/tags","blobs_url":"https://api.github.com/repos/bmbouter/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmbouter/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmbouter/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmbouter/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmbouter/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/bmbouter/pulp/languages","stargazers_url":"https://api.github.com/repos/bmbouter/pulp/stargazers","contributors_url":"https://api.github.com/repos/bmbouter/pulp/contributors","subscribers_url":"https://api.github.com/repos/bmbouter/pulp/subscribers","subscription_url":"https://api.github.com/repos/bmbouter/pulp/subscription","commits_url":"https://api.github.com/repos/bmbouter/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmbouter/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmbouter/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmbouter/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmbouter/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/bmbouter/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmbouter/pulp/merges","archive_url":"https://api.github.com/repos/bmbouter/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmbouter/pulp/downloads","issues_url":"https://api.github.com/repos/bmbouter/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/bmbouter/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/bmbouter/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/bmbouter/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmbouter/pulp/labels{/name}","releases_url":"https://api.github.com/repos/bmbouter/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/bmbouter/pulp/deployments","created_at":"2014-09-25T13:58:32Z","updated_at":"2016-07-14T16:48:25Z","pushed_at":"2016-09-07T20:27:42Z","git_url":"git://github.com/bmbouter/pulp.git","ssh_url":"git@github.com:bmbouter/pulp.git","clone_url":"https://github.com/bmbouter/pulp.git","svn_url":"https://github.com/bmbouter/pulp","homepage":"","size":91878,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pulp:3.0-dev","ref":"3.0-dev","sha":"d7cc916a5d75b856f8bd89258b8e3cadfa4399c3","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp/deployments","created_at":"2012-08-06T13:49:20Z","updated_at":"2016-09-07T06:13:12Z","pushed_at":"2016-09-09T13:48:18Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":102851,"stargazers_count":279,"watchers_count":279,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":23,"forks":113,"open_issues":23,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2734"},"html":{"href":"https://github.com/pulp/pulp/pull/2734"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/2734"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/2734/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2734/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2734/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/34542f517e1837f8d4090e55980d6f89a8053c17"}}}}
{"actor":{"display_login":"bmbouter"}}