{"action":"created","comment":{"url":"https://api.github.com/repos/zulily/stevedore/pulls/comments/64463138","id":64463138,"diff_hunk":"@@ -57,21 +61,30 @@ func (i Image) Push() (err error) {\n \treturn runCmdAndPipeOutput(cmd.Output, \"docker\", \"push\", i.Url)\n }\n \n-func detectRepoPathAndTag(wd string) (repo, path, tag string) {\n-\trepo, err := runCmdAndGetOutput(\"git\", \"config\", \"--get\", \"remote.origin.url\")\n-\tif err != nil {\n-\t\tlog.Fatal(\"error detecting git repo\", err)\n-\t}\n-\n-\tif index := strings.LastIndex(repo, \":\"); index != -1 {\n-\t\trepo = repo[index+1:]\n+func extractRepo(repo string) string {\n+\tif strings.HasPrefix(repo, \"git\") {","path":"stevedore.go","position":26,"original_position":26,"commit_id":"ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc","original_commit_id":"ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc","user":{"login":"smreed","id":100176,"avatar_url":"https://avatars.githubusercontent.com/u/100176?v=3","gravatar_id":"","url":"https://api.github.com/users/smreed","html_url":"https://github.com/smreed","followers_url":"https://api.github.com/users/smreed/followers","following_url":"https://api.github.com/users/smreed/following{/other_user}","gists_url":"https://api.github.com/users/smreed/gists{/gist_id}","starred_url":"https://api.github.com/users/smreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smreed/subscriptions","organizations_url":"https://api.github.com/users/smreed/orgs","repos_url":"https://api.github.com/users/smreed/repos","events_url":"https://api.github.com/users/smreed/events{/privacy}","received_events_url":"https://api.github.com/users/smreed/received_events","type":"User","site_admin":false},"body":"Sounds good.\n\nOn Tue, May 24, 2016 at 12:57 PM Kyle <notifications@github.com> wrote:\n\n> In stevedore.go\n> <https://github.com/zulily/stevedore/pull/12#discussion_r64458062>:\n>\n> > @@ -57,21 +61,30 @@ func (i Image) Push() (err error) {\n> >  \treturn runCmdAndPipeOutput(cmd.Output, \"docker\", \"push\", i.Url)\n> >  }\n> >\n> > -func detectRepoPathAndTag(wd string) (repo, path, tag string) {\n> > -\trepo, err := runCmdAndGetOutput(\"git\", \"config\", \"--get\", \"remote.origin.url\")\n> > -\tif err != nil {\n> > -\t\tlog.Fatal(\"error detecting git repo\", err)\n> > -\t}\n> > -\n> > -\tif index := strings.LastIndex(repo, \":\"); index != -1 {\n> > -\t\trepo = repo[index+1:]\n> > +func extractRepo(repo string) string {\n> > +\tif strings.HasPrefix(repo, \"git\") {\n>\n> Sounds good on all counts, thanks for catching the prefix bit - I'll also\n> pull in some more exhaustive test cases from whatever the remote spec\n> allows. On some level we don't really care about prefix, we just want\n> consistent fragment extraction.\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly or view it on GitHub\n> <https://github.com/zulily/stevedore/pull/12/files/ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc#r64458062>\n>\n","created_at":"2016-05-24T19:59:13Z","updated_at":"2016-05-24T19:59:13Z","html_url":"https://github.com/zulily/stevedore/pull/12#discussion_r64463138","pull_request_url":"https://api.github.com/repos/zulily/stevedore/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/comments/64463138"},"html":{"href":"https://github.com/zulily/stevedore/pull/12#discussion_r64463138"},"pull_request":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/zulily/stevedore/pulls/12","id":71141096,"html_url":"https://github.com/zulily/stevedore/pull/12","diff_url":"https://github.com/zulily/stevedore/pull/12.diff","patch_url":"https://github.com/zulily/stevedore/pull/12.patch","issue_url":"https://api.github.com/repos/zulily/stevedore/issues/12","number":12,"state":"open","locked":false,"title":"fix repo/path/tag detection to work with https repos","user":{"login":"serchaos","id":546176,"avatar_url":"https://avatars.githubusercontent.com/u/546176?v=3","gravatar_id":"","url":"https://api.github.com/users/serchaos","html_url":"https://github.com/serchaos","followers_url":"https://api.github.com/users/serchaos/followers","following_url":"https://api.github.com/users/serchaos/following{/other_user}","gists_url":"https://api.github.com/users/serchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/serchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serchaos/subscriptions","organizations_url":"https://api.github.com/users/serchaos/orgs","repos_url":"https://api.github.com/users/serchaos/repos","events_url":"https://api.github.com/users/serchaos/events{/privacy}","received_events_url":"https://api.github.com/users/serchaos/received_events","type":"User","site_admin":false},"body":"Fixing issue #9. Had to do some refactoring, so please let me know if anything's out of line.","created_at":"2016-05-24T00:23:45Z","updated_at":"2016-05-24T19:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25a4f2e55421174f09457eebf1e7e366ae3acd25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zulily/stevedore/pulls/12/commits","review_comments_url":"https://api.github.com/repos/zulily/stevedore/pulls/12/comments","review_comment_url":"https://api.github.com/repos/zulily/stevedore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulily/stevedore/issues/12/comments","statuses_url":"https://api.github.com/repos/zulily/stevedore/statuses/ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc","head":{"label":"zulily:https-repo","ref":"https-repo","sha":"ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc","user":{"login":"zulily","id":5273770,"avatar_url":"https://avatars.githubusercontent.com/u/5273770?v=3","gravatar_id":"","url":"https://api.github.com/users/zulily","html_url":"https://github.com/zulily","followers_url":"https://api.github.com/users/zulily/followers","following_url":"https://api.github.com/users/zulily/following{/other_user}","gists_url":"https://api.github.com/users/zulily/gists{/gist_id}","starred_url":"https://api.github.com/users/zulily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulily/subscriptions","organizations_url":"https://api.github.com/users/zulily/orgs","repos_url":"https://api.github.com/users/zulily/repos","events_url":"https://api.github.com/users/zulily/events{/privacy}","received_events_url":"https://api.github.com/users/zulily/received_events","type":"Organization","site_admin":false},"repo":{"id":34885418,"name":"stevedore","full_name":"zulily/stevedore","owner":{"login":"zulily","id":5273770,"avatar_url":"https://avatars.githubusercontent.com/u/5273770?v=3","gravatar_id":"","url":"https://api.github.com/users/zulily","html_url":"https://github.com/zulily","followers_url":"https://api.github.com/users/zulily/followers","following_url":"https://api.github.com/users/zulily/following{/other_user}","gists_url":"https://api.github.com/users/zulily/gists{/gist_id}","starred_url":"https://api.github.com/users/zulily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulily/subscriptions","organizations_url":"https://api.github.com/users/zulily/orgs","repos_url":"https://api.github.com/users/zulily/repos","events_url":"https://api.github.com/users/zulily/events{/privacy}","received_events_url":"https://api.github.com/users/zulily/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulily/stevedore","description":"A simple CI server for building and publishing Docker images to a private registry.","fork":false,"url":"https://api.github.com/repos/zulily/stevedore","forks_url":"https://api.github.com/repos/zulily/stevedore/forks","keys_url":"https://api.github.com/repos/zulily/stevedore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulily/stevedore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulily/stevedore/teams","hooks_url":"https://api.github.com/repos/zulily/stevedore/hooks","issue_events_url":"https://api.github.com/repos/zulily/stevedore/issues/events{/number}","events_url":"https://api.github.com/repos/zulily/stevedore/events","assignees_url":"https://api.github.com/repos/zulily/stevedore/assignees{/user}","branches_url":"https://api.github.com/repos/zulily/stevedore/branches{/branch}","tags_url":"https://api.github.com/repos/zulily/stevedore/tags","blobs_url":"https://api.github.com/repos/zulily/stevedore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulily/stevedore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulily/stevedore/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulily/stevedore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulily/stevedore/statuses/{sha}","languages_url":"https://api.github.com/repos/zulily/stevedore/languages","stargazers_url":"https://api.github.com/repos/zulily/stevedore/stargazers","contributors_url":"https://api.github.com/repos/zulily/stevedore/contributors","subscribers_url":"https://api.github.com/repos/zulily/stevedore/subscribers","subscription_url":"https://api.github.com/repos/zulily/stevedore/subscription","commits_url":"https://api.github.com/repos/zulily/stevedore/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulily/stevedore/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulily/stevedore/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulily/stevedore/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulily/stevedore/contents/{+path}","compare_url":"https://api.github.com/repos/zulily/stevedore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulily/stevedore/merges","archive_url":"https://api.github.com/repos/zulily/stevedore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulily/stevedore/downloads","issues_url":"https://api.github.com/repos/zulily/stevedore/issues{/number}","pulls_url":"https://api.github.com/repos/zulily/stevedore/pulls{/number}","milestones_url":"https://api.github.com/repos/zulily/stevedore/milestones{/number}","notifications_url":"https://api.github.com/repos/zulily/stevedore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulily/stevedore/labels{/name}","releases_url":"https://api.github.com/repos/zulily/stevedore/releases{/id}","deployments_url":"https://api.github.com/repos/zulily/stevedore/deployments","created_at":"2015-05-01T01:42:54Z","updated_at":"2016-05-11T12:38:33Z","pushed_at":"2016-05-24T00:23:45Z","git_url":"git://github.com/zulily/stevedore.git","ssh_url":"git@github.com:zulily/stevedore.git","clone_url":"https://github.com/zulily/stevedore.git","svn_url":"https://github.com/zulily/stevedore","homepage":null,"size":720,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"zulily:master","ref":"master","sha":"33f05d44a63d523ca49bb3b38f4ec3a79e4e91eb","user":{"login":"zulily","id":5273770,"avatar_url":"https://avatars.githubusercontent.com/u/5273770?v=3","gravatar_id":"","url":"https://api.github.com/users/zulily","html_url":"https://github.com/zulily","followers_url":"https://api.github.com/users/zulily/followers","following_url":"https://api.github.com/users/zulily/following{/other_user}","gists_url":"https://api.github.com/users/zulily/gists{/gist_id}","starred_url":"https://api.github.com/users/zulily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulily/subscriptions","organizations_url":"https://api.github.com/users/zulily/orgs","repos_url":"https://api.github.com/users/zulily/repos","events_url":"https://api.github.com/users/zulily/events{/privacy}","received_events_url":"https://api.github.com/users/zulily/received_events","type":"Organization","site_admin":false},"repo":{"id":34885418,"name":"stevedore","full_name":"zulily/stevedore","owner":{"login":"zulily","id":5273770,"avatar_url":"https://avatars.githubusercontent.com/u/5273770?v=3","gravatar_id":"","url":"https://api.github.com/users/zulily","html_url":"https://github.com/zulily","followers_url":"https://api.github.com/users/zulily/followers","following_url":"https://api.github.com/users/zulily/following{/other_user}","gists_url":"https://api.github.com/users/zulily/gists{/gist_id}","starred_url":"https://api.github.com/users/zulily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulily/subscriptions","organizations_url":"https://api.github.com/users/zulily/orgs","repos_url":"https://api.github.com/users/zulily/repos","events_url":"https://api.github.com/users/zulily/events{/privacy}","received_events_url":"https://api.github.com/users/zulily/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulily/stevedore","description":"A simple CI server for building and publishing Docker images to a private registry.","fork":false,"url":"https://api.github.com/repos/zulily/stevedore","forks_url":"https://api.github.com/repos/zulily/stevedore/forks","keys_url":"https://api.github.com/repos/zulily/stevedore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulily/stevedore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulily/stevedore/teams","hooks_url":"https://api.github.com/repos/zulily/stevedore/hooks","issue_events_url":"https://api.github.com/repos/zulily/stevedore/issues/events{/number}","events_url":"https://api.github.com/repos/zulily/stevedore/events","assignees_url":"https://api.github.com/repos/zulily/stevedore/assignees{/user}","branches_url":"https://api.github.com/repos/zulily/stevedore/branches{/branch}","tags_url":"https://api.github.com/repos/zulily/stevedore/tags","blobs_url":"https://api.github.com/repos/zulily/stevedore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulily/stevedore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulily/stevedore/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulily/stevedore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulily/stevedore/statuses/{sha}","languages_url":"https://api.github.com/repos/zulily/stevedore/languages","stargazers_url":"https://api.github.com/repos/zulily/stevedore/stargazers","contributors_url":"https://api.github.com/repos/zulily/stevedore/contributors","subscribers_url":"https://api.github.com/repos/zulily/stevedore/subscribers","subscription_url":"https://api.github.com/repos/zulily/stevedore/subscription","commits_url":"https://api.github.com/repos/zulily/stevedore/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulily/stevedore/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulily/stevedore/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulily/stevedore/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulily/stevedore/contents/{+path}","compare_url":"https://api.github.com/repos/zulily/stevedore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulily/stevedore/merges","archive_url":"https://api.github.com/repos/zulily/stevedore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulily/stevedore/downloads","issues_url":"https://api.github.com/repos/zulily/stevedore/issues{/number}","pulls_url":"https://api.github.com/repos/zulily/stevedore/pulls{/number}","milestones_url":"https://api.github.com/repos/zulily/stevedore/milestones{/number}","notifications_url":"https://api.github.com/repos/zulily/stevedore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulily/stevedore/labels{/name}","releases_url":"https://api.github.com/repos/zulily/stevedore/releases{/id}","deployments_url":"https://api.github.com/repos/zulily/stevedore/deployments","created_at":"2015-05-01T01:42:54Z","updated_at":"2016-05-11T12:38:33Z","pushed_at":"2016-05-24T00:23:45Z","git_url":"git://github.com/zulily/stevedore.git","ssh_url":"git@github.com:zulily/stevedore.git","clone_url":"https://github.com/zulily/stevedore.git","svn_url":"https://github.com/zulily/stevedore","homepage":null,"size":720,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/12"},"html":{"href":"https://github.com/zulily/stevedore/pull/12"},"issue":{"href":"https://api.github.com/repos/zulily/stevedore/issues/12"},"comments":{"href":"https://api.github.com/repos/zulily/stevedore/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulily/stevedore/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/zulily/stevedore/statuses/ae1789827b1a04be04b58d81fbbb8ab3ea3c08cc"}}}}
{"actor":{"display_login":"smreed"}}