{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/84452627","pull_request_review_id":5229101,"id":84452627,"diff_hunk":"@@ -1161,11 +1064,28 @@ impl<'a, ConcreteThreadSafeLayoutNode: ThreadSafeLayoutNode>\n \n     /// Builds a flow for a node with `display: table`. This yields a `TableWrapperFlow` with\n     /// possibly other `TableCaptionFlow`s or `TableFlow`s underneath it.\n-    fn build_flow_for_table_wrapper(&mut self, node: &ConcreteThreadSafeLayoutNode, float_value: float::T)\n-                                    -> ConstructionResult {\n-        let fragment = Fragment::new(node, SpecificFragmentInfo::TableWrapper, self.layout_context);\n-        let mut wrapper_flow: FlowRef = Arc::new(\n-            TableWrapperFlow::from_fragment(fragment, FloatKind::from_property(float_value)));\n+    fn build_flow_for_table(&mut self, node: &ConcreteThreadSafeLayoutNode, float_value: float::T)\n+                            -> ConstructionResult {\n+        let mut legalizer = Legalizer::new();\n+\n+        let table_style = node.style(self.style_context());\n+        let wrapper_style = self.style_context()\n+                                .stylist\n+                                .precomputed_values_for_pseudo(&PseudoElement::ServoTableWrapper,","path":"components/layout/construct.rs","position":341,"original_position":341,"commit_id":"392ab81f3cf75a616ba8e83ac9f853952ec0c85a","original_commit_id":"392ab81f3cf75a616ba8e83ac9f853952ec0c85a","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"body":"This pattern is becoming increasingly common, maybe add a helper for it in `SharedStyleContext`? Can be left as a followup, but please fill it if you decide to do so.","created_at":"2016-10-21T10:04:43Z","updated_at":"2016-10-21T10:07:20Z","html_url":"https://github.com/servo/servo/pull/13870#discussion_r84452627","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13870","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/84452627"},"html":{"href":"https://github.com/servo/servo/pull/13870#discussion_r84452627"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13870"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13870","id":90320337,"html_url":"https://github.com/servo/servo/pull/13870","diff_url":"https://github.com/servo/servo/pull/13870.diff","patch_url":"https://github.com/servo/servo/pull/13870.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13870","number":13870,"state":"open","locked":false,"title":"(DO NOT MERGE) layout: Rewrite table stuff.","user":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"body":"Closes #13782.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13870)\n<!-- Reviewable:end -->\n","created_at":"2016-10-21T04:10:46Z","updated_at":"2016-10-21T10:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fae62f7f6a0bee6d751a1348f7b7892d76fb463","assignee":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13870/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13870/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13870/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/392ab81f3cf75a616ba8e83ac9f853952ec0c85a","head":{"label":"pcwalton:anonymous-table-rewrite","ref":"anonymous-table-rewrite","sha":"392ab81f3cf75a616ba8e83ac9f853952ec0c85a","user":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"repo":{"id":9251720,"name":"servo","full_name":"pcwalton/servo","owner":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcwalton/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/pcwalton/servo","forks_url":"https://api.github.com/repos/pcwalton/servo/forks","keys_url":"https://api.github.com/repos/pcwalton/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcwalton/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcwalton/servo/teams","hooks_url":"https://api.github.com/repos/pcwalton/servo/hooks","issue_events_url":"https://api.github.com/repos/pcwalton/servo/issues/events{/number}","events_url":"https://api.github.com/repos/pcwalton/servo/events","assignees_url":"https://api.github.com/repos/pcwalton/servo/assignees{/user}","branches_url":"https://api.github.com/repos/pcwalton/servo/branches{/branch}","tags_url":"https://api.github.com/repos/pcwalton/servo/tags","blobs_url":"https://api.github.com/repos/pcwalton/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcwalton/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcwalton/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcwalton/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcwalton/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/pcwalton/servo/languages","stargazers_url":"https://api.github.com/repos/pcwalton/servo/stargazers","contributors_url":"https://api.github.com/repos/pcwalton/servo/contributors","subscribers_url":"https://api.github.com/repos/pcwalton/servo/subscribers","subscription_url":"https://api.github.com/repos/pcwalton/servo/subscription","commits_url":"https://api.github.com/repos/pcwalton/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcwalton/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcwalton/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcwalton/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcwalton/servo/contents/{+path}","compare_url":"https://api.github.com/repos/pcwalton/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcwalton/servo/merges","archive_url":"https://api.github.com/repos/pcwalton/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcwalton/servo/downloads","issues_url":"https://api.github.com/repos/pcwalton/servo/issues{/number}","pulls_url":"https://api.github.com/repos/pcwalton/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/pcwalton/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/pcwalton/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcwalton/servo/labels{/name}","releases_url":"https://api.github.com/repos/pcwalton/servo/releases{/id}","deployments_url":"https://api.github.com/repos/pcwalton/servo/deployments","created_at":"2013-04-05T22:11:24Z","updated_at":"2014-07-22T08:38:24Z","pushed_at":"2016-10-21T04:09:59Z","git_url":"git://github.com/pcwalton/servo.git","ssh_url":"git@github.com:pcwalton/servo.git","clone_url":"https://github.com/pcwalton/servo.git","svn_url":"https://github.com/pcwalton/servo","homepage":"","size":215582,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"4216224f9cc7f3430db2b59f4d77061824ba7a1e","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-21T07:55:06Z","pushed_at":"2016-10-21T09:34:26Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":302789,"stargazers_count":8081,"watchers_count":8081,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1314,"mirror_url":null,"open_issues_count":1846,"forks":1314,"open_issues":1846,"watchers":8081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13870"},"html":{"href":"https://github.com/servo/servo/pull/13870"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13870"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13870/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13870/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13870/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/392ab81f3cf75a616ba8e83ac9f853952ec0c85a"}}}}
{"actor":{"display_login":"emilio"}}