{"action":"created","issue":{"url":"https://api.github.com/repos/divio/django-filer/issues/857","repository_url":"https://api.github.com/repos/divio/django-filer","labels_url":"https://api.github.com/repos/divio/django-filer/issues/857/labels{/name}","comments_url":"https://api.github.com/repos/divio/django-filer/issues/857/comments","events_url":"https://api.github.com/repos/divio/django-filer/issues/857/events","html_url":"https://github.com/divio/django-filer/pull/857","id":158383008,"number":857,"title":"[WiP] Make Image model swappable using a Meta.swappable option","user":{"login":"skirsdeda","id":7189652,"avatar_url":"https://avatars.githubusercontent.com/u/7189652?v=3","gravatar_id":"","url":"https://api.github.com/users/skirsdeda","html_url":"https://github.com/skirsdeda","followers_url":"https://api.github.com/users/skirsdeda/followers","following_url":"https://api.github.com/users/skirsdeda/following{/other_user}","gists_url":"https://api.github.com/users/skirsdeda/gists{/gist_id}","starred_url":"https://api.github.com/users/skirsdeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirsdeda/subscriptions","organizations_url":"https://api.github.com/users/skirsdeda/orgs","repos_url":"https://api.github.com/users/skirsdeda/repos","events_url":"https://api.github.com/users/skirsdeda/events{/privacy}","received_events_url":"https://api.github.com/users/skirsdeda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/divio/django-filer/labels/work%20in%20progress","name":"work in progress","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/divio/django-filer/milestones/17","html_url":"https://github.com/divio/django-filer/milestones/1.3.0","labels_url":"https://api.github.com/repos/divio/django-filer/milestones/17/labels","id":1618094,"number":17,"title":"1.3.0","description":"Remove support for older versions (design decision needed). LTS release?\r\n\r\n- [ ] remove Django 1.5 support\r\n- [ ] ?? remove Django 1.6 and 1.7 support ?? (to follow what django-cms 3.3 is doing)\r\n    - [ ] code (no deprecation warnings should pop up in Django 1.8)\r\n    - [ ] docs\r\n- [ ] Django 1.10 support\r\n","creator":{"login":"stefanfoulis","id":14330,"avatar_url":"https://avatars.githubusercontent.com/u/14330?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanfoulis","html_url":"https://github.com/stefanfoulis","followers_url":"https://api.github.com/users/stefanfoulis/followers","following_url":"https://api.github.com/users/stefanfoulis/following{/other_user}","gists_url":"https://api.github.com/users/stefanfoulis/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanfoulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanfoulis/subscriptions","organizations_url":"https://api.github.com/users/stefanfoulis/orgs","repos_url":"https://api.github.com/users/stefanfoulis/repos","events_url":"https://api.github.com/users/stefanfoulis/events{/privacy}","received_events_url":"https://api.github.com/users/stefanfoulis/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":2,"state":"open","created_at":"2016-03-02T15:26:36Z","updated_at":"2016-06-24T15:25:49Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-06-03T14:42:21Z","updated_at":"2016-07-08T11:37:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/divio/django-filer/pulls/857","html_url":"https://github.com/divio/django-filer/pull/857","diff_url":"https://github.com/divio/django-filer/pull/857.diff","patch_url":"https://github.com/divio/django-filer/pull/857.patch"},"body":"Custom Image models are still problematic mostly because of issues with migrations. This is because Image model swappability implementation in filer is sort of broken by design :) I propose switching to a standard Django way for model swapping - Meta.swappable option.\r\n\r\nThe branch in it's current form is already working but I'm marking is as a Work in progress because there are some problems:\r\n\r\n* FILER_IMAGE_MODEL setting now uses django content type instead of full python path to model. This breaks compatibility, however it's very easy to fix.\r\n* FILER_FILE_MODELS setting default is currently broken for the same reason. I think it would be a good idea to switch FILER_FILE_MODELS setting to content type syntax as well but this is not for me to decide."},"comment":{"url":"https://api.github.com/repos/divio/django-filer/issues/comments/231338720","html_url":"https://github.com/divio/django-filer/pull/857#issuecomment-231338720","issue_url":"https://api.github.com/repos/divio/django-filer/issues/857","id":231338720,"user":{"login":"skirsdeda","id":7189652,"avatar_url":"https://avatars.githubusercontent.com/u/7189652?v=3","gravatar_id":"","url":"https://api.github.com/users/skirsdeda","html_url":"https://github.com/skirsdeda","followers_url":"https://api.github.com/users/skirsdeda/followers","following_url":"https://api.github.com/users/skirsdeda/following{/other_user}","gists_url":"https://api.github.com/users/skirsdeda/gists{/gist_id}","starred_url":"https://api.github.com/users/skirsdeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirsdeda/subscriptions","organizations_url":"https://api.github.com/users/skirsdeda/orgs","repos_url":"https://api.github.com/users/skirsdeda/repos","events_url":"https://api.github.com/users/skirsdeda/events{/privacy}","received_events_url":"https://api.github.com/users/skirsdeda/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T11:37:30Z","updated_at":"2016-07-08T11:37:30Z","body":"@mkoistinen This one is done. Changing ```FILER_FILE_MODELS``` to content type notation was almost too easy :) Let me know if anything else needs to be done to merge this."}}
{"actor":{"display_login":"skirsdeda"}}