{"action":"created","comment":{"url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/comments/61072121","id":61072121,"diff_hunk":"@@ -0,0 +1,4 @@\n+- if Rails.env.production?\n+  script src=\"http://gfw-assets.s3.amazonaws.com/static/gfw-assets.latest.js\" id=\"loader-gfw\" data-current=\".shape-climate\"\n+- else\n+  script src=\"http://gfw-assets.s3.amazonaws.com/static/gfw-assets.nightly.js\" id=\"loader-gfw\" data-current=\".shape-climate\"","path":"app/views/shared/_gfw_assets.html.slim","position":4,"original_position":4,"commit_id":"905c04ef8e8a660c52d42b1f46dc84e0de2d0619","original_commit_id":"905c04ef8e8a660c52d42b1f46dc84e0de2d0619","user":{"login":"davidsingal","id":674179,"avatar_url":"https://avatars.githubusercontent.com/u/674179?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsingal","html_url":"https://github.com/davidsingal","followers_url":"https://api.github.com/users/davidsingal/followers","following_url":"https://api.github.com/users/davidsingal/following{/other_user}","gists_url":"https://api.github.com/users/davidsingal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsingal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsingal/subscriptions","organizations_url":"https://api.github.com/users/davidsingal/orgs","repos_url":"https://api.github.com/users/davidsingal/repos","events_url":"https://api.github.com/users/davidsingal/events{/privacy}","received_events_url":"https://api.github.com/users/davidsingal/received_events","type":"User","site_admin":false},"body":"I prefer something like this:\r\n`assets_version= Rails.env.production? 'latest' : 'nightly'`\r\nbut better is:\r\nin dot env file add `ASSETS_VERSION=latest` and use this like `${ENV['ASSETS_VERSION']}`","created_at":"2016-04-26T11:54:41Z","updated_at":"2016-04-26T11:54:41Z","html_url":"https://github.com/Vizzuality/gfw-climate/pull/260#discussion_r61072121","pull_request_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/comments/61072121"},"html":{"href":"https://github.com/Vizzuality/gfw-climate/pull/260#discussion_r61072121"},"pull_request":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260","id":67866811,"html_url":"https://github.com/Vizzuality/gfw-climate/pull/260","diff_url":"https://github.com/Vizzuality/gfw-climate/pull/260.diff","patch_url":"https://github.com/Vizzuality/gfw-climate/pull/260.patch","issue_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/260","number":260,"state":"open","locked":false,"title":"Feat: GFW Assets version control ","user":{"login":"geriux","id":4885740,"avatar_url":"https://avatars.githubusercontent.com/u/4885740?v=3","gravatar_id":"","url":"https://api.github.com/users/geriux","html_url":"https://github.com/geriux","followers_url":"https://api.github.com/users/geriux/followers","following_url":"https://api.github.com/users/geriux/following{/other_user}","gists_url":"https://api.github.com/users/geriux/gists{/gist_id}","starred_url":"https://api.github.com/users/geriux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geriux/subscriptions","organizations_url":"https://api.github.com/users/geriux/orgs","repos_url":"https://api.github.com/users/geriux/repos","events_url":"https://api.github.com/users/geriux/events{/privacy}","received_events_url":"https://api.github.com/users/geriux/received_events","type":"User","site_admin":false},"body":"1- Added the staging environment so we can differentiate between production and staging.\r\n2- Manage GFW Assets version depending on the environment:\r\n* Latest -> Production only\r\n* Nightly -> Staging and dev\r\n* Dev -> Only development\r\n","created_at":"2016-04-26T11:10:07Z","updated_at":"2016-04-26T11:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8f0db745575f659c73d52a90d70387a7342098b","assignee":{"login":"simaob","id":10764,"avatar_url":"https://avatars.githubusercontent.com/u/10764?v=3","gravatar_id":"","url":"https://api.github.com/users/simaob","html_url":"https://github.com/simaob","followers_url":"https://api.github.com/users/simaob/followers","following_url":"https://api.github.com/users/simaob/following{/other_user}","gists_url":"https://api.github.com/users/simaob/gists{/gist_id}","starred_url":"https://api.github.com/users/simaob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaob/subscriptions","organizations_url":"https://api.github.com/users/simaob/orgs","repos_url":"https://api.github.com/users/simaob/repos","events_url":"https://api.github.com/users/simaob/events{/privacy}","received_events_url":"https://api.github.com/users/simaob/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260/commits","review_comments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260/comments","review_comment_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/260/comments","statuses_url":"https://api.github.com/repos/Vizzuality/gfw-climate/statuses/905c04ef8e8a660c52d42b1f46dc84e0de2d0619","head":{"label":"Vizzuality:feature/manage-gfw-assets-versions","ref":"feature/manage-gfw-assets-versions","sha":"905c04ef8e8a660c52d42b1f46dc84e0de2d0619","user":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"repo":{"id":39555400,"name":"gfw-climate","full_name":"Vizzuality/gfw-climate","owner":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vizzuality/gfw-climate","description":"","fork":false,"url":"https://api.github.com/repos/Vizzuality/gfw-climate","forks_url":"https://api.github.com/repos/Vizzuality/gfw-climate/forks","keys_url":"https://api.github.com/repos/Vizzuality/gfw-climate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vizzuality/gfw-climate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vizzuality/gfw-climate/teams","hooks_url":"https://api.github.com/repos/Vizzuality/gfw-climate/hooks","issue_events_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/events{/number}","events_url":"https://api.github.com/repos/Vizzuality/gfw-climate/events","assignees_url":"https://api.github.com/repos/Vizzuality/gfw-climate/assignees{/user}","branches_url":"https://api.github.com/repos/Vizzuality/gfw-climate/branches{/branch}","tags_url":"https://api.github.com/repos/Vizzuality/gfw-climate/tags","blobs_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vizzuality/gfw-climate/statuses/{sha}","languages_url":"https://api.github.com/repos/Vizzuality/gfw-climate/languages","stargazers_url":"https://api.github.com/repos/Vizzuality/gfw-climate/stargazers","contributors_url":"https://api.github.com/repos/Vizzuality/gfw-climate/contributors","subscribers_url":"https://api.github.com/repos/Vizzuality/gfw-climate/subscribers","subscription_url":"https://api.github.com/repos/Vizzuality/gfw-climate/subscription","commits_url":"https://api.github.com/repos/Vizzuality/gfw-climate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vizzuality/gfw-climate/contents/{+path}","compare_url":"https://api.github.com/repos/Vizzuality/gfw-climate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vizzuality/gfw-climate/merges","archive_url":"https://api.github.com/repos/Vizzuality/gfw-climate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vizzuality/gfw-climate/downloads","issues_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues{/number}","pulls_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls{/number}","milestones_url":"https://api.github.com/repos/Vizzuality/gfw-climate/milestones{/number}","notifications_url":"https://api.github.com/repos/Vizzuality/gfw-climate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vizzuality/gfw-climate/labels{/name}","releases_url":"https://api.github.com/repos/Vizzuality/gfw-climate/releases{/id}","deployments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/deployments","created_at":"2015-07-23T08:29:47Z","updated_at":"2016-01-11T17:22:17Z","pushed_at":"2016-04-26T11:10:08Z","git_url":"git://github.com/Vizzuality/gfw-climate.git","ssh_url":"git@github.com:Vizzuality/gfw-climate.git","clone_url":"https://github.com/Vizzuality/gfw-climate.git","svn_url":"https://github.com/Vizzuality/gfw-climate","homepage":"http://climate.globalforestwatch.org","size":21110,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"Vizzuality:master","ref":"master","sha":"74a15e2bb96f52b38262539c608022df3e5c8bdb","user":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"repo":{"id":39555400,"name":"gfw-climate","full_name":"Vizzuality/gfw-climate","owner":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vizzuality/gfw-climate","description":"","fork":false,"url":"https://api.github.com/repos/Vizzuality/gfw-climate","forks_url":"https://api.github.com/repos/Vizzuality/gfw-climate/forks","keys_url":"https://api.github.com/repos/Vizzuality/gfw-climate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vizzuality/gfw-climate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vizzuality/gfw-climate/teams","hooks_url":"https://api.github.com/repos/Vizzuality/gfw-climate/hooks","issue_events_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/events{/number}","events_url":"https://api.github.com/repos/Vizzuality/gfw-climate/events","assignees_url":"https://api.github.com/repos/Vizzuality/gfw-climate/assignees{/user}","branches_url":"https://api.github.com/repos/Vizzuality/gfw-climate/branches{/branch}","tags_url":"https://api.github.com/repos/Vizzuality/gfw-climate/tags","blobs_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vizzuality/gfw-climate/statuses/{sha}","languages_url":"https://api.github.com/repos/Vizzuality/gfw-climate/languages","stargazers_url":"https://api.github.com/repos/Vizzuality/gfw-climate/stargazers","contributors_url":"https://api.github.com/repos/Vizzuality/gfw-climate/contributors","subscribers_url":"https://api.github.com/repos/Vizzuality/gfw-climate/subscribers","subscription_url":"https://api.github.com/repos/Vizzuality/gfw-climate/subscription","commits_url":"https://api.github.com/repos/Vizzuality/gfw-climate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vizzuality/gfw-climate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vizzuality/gfw-climate/contents/{+path}","compare_url":"https://api.github.com/repos/Vizzuality/gfw-climate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vizzuality/gfw-climate/merges","archive_url":"https://api.github.com/repos/Vizzuality/gfw-climate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vizzuality/gfw-climate/downloads","issues_url":"https://api.github.com/repos/Vizzuality/gfw-climate/issues{/number}","pulls_url":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls{/number}","milestones_url":"https://api.github.com/repos/Vizzuality/gfw-climate/milestones{/number}","notifications_url":"https://api.github.com/repos/Vizzuality/gfw-climate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vizzuality/gfw-climate/labels{/name}","releases_url":"https://api.github.com/repos/Vizzuality/gfw-climate/releases{/id}","deployments_url":"https://api.github.com/repos/Vizzuality/gfw-climate/deployments","created_at":"2015-07-23T08:29:47Z","updated_at":"2016-01-11T17:22:17Z","pushed_at":"2016-04-26T11:10:08Z","git_url":"git://github.com/Vizzuality/gfw-climate.git","ssh_url":"git@github.com:Vizzuality/gfw-climate.git","clone_url":"https://github.com/Vizzuality/gfw-climate.git","svn_url":"https://github.com/Vizzuality/gfw-climate","homepage":"http://climate.globalforestwatch.org","size":21110,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260"},"html":{"href":"https://github.com/Vizzuality/gfw-climate/pull/260"},"issue":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/260"},"comments":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/Vizzuality/gfw-climate/statuses/905c04ef8e8a660c52d42b1f46dc84e0de2d0619"}}}}