{"action":"created","issue":{"url":"https://api.github.com/repos/frerich/clcache/issues/201","repository_url":"https://api.github.com/repos/frerich/clcache","labels_url":"https://api.github.com/repos/frerich/clcache/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/frerich/clcache/issues/201/comments","events_url":"https://api.github.com/repos/frerich/clcache/issues/201/events","html_url":"https://github.com/frerich/clcache/pull/201","id":170639533,"number":201,"title":"Hotfix race condition in mutex creation/deletion","user":{"login":"hubx","id":239553,"avatar_url":"https://avatars.githubusercontent.com/u/239553?v=3","gravatar_id":"","url":"https://api.github.com/users/hubx","html_url":"https://github.com/hubx","followers_url":"https://api.github.com/users/hubx/followers","following_url":"https://api.github.com/users/hubx/following{/other_user}","gists_url":"https://api.github.com/users/hubx/gists{/gist_id}","starred_url":"https://api.github.com/users/hubx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hubx/subscriptions","organizations_url":"https://api.github.com/users/hubx/orgs","repos_url":"https://api.github.com/users/hubx/repos","events_url":"https://api.github.com/users/hubx/events{/privacy}","received_events_url":"https://api.github.com/users/hubx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-11T12:58:31Z","updated_at":"2016-08-11T13:22:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/frerich/clcache/pulls/201","html_url":"https://github.com/frerich/clcache/pull/201","diff_url":"https://github.com/frerich/clcache/pull/201.diff","patch_url":"https://github.com/frerich/clcache/pull/201.patch"},"body":"On my machine TestHeaderChange.testDirect() fails in the second compileAndLink\r\n>            with open(\"version.h\", \"w\") as header:\r\n                header.write(\"#define VERSION 2\")\r\n\r\n>     self._compileAndLink()\r\n\r\nwith ERROR_INVALID_HANDLE\r\n\r\n>    with cache.lock, cache.statistics as stats:\r\n  File \"clcache.py\", line 211, in __enter__\r\n    self.acquire()\r\n  File \"clcache.py\", line 227, in acquire\r\n    raise CacheLockException(errorString)\r\n__main__.CacheLockException: Error! WaitForSingleObject returns -1, last error 6\r\n\r\nI'm not sure why the mutex gets invalidated in this case. Anyone else experiecing this or. I suspected the security descriptor https://msdn.microsoft.com/en-us/library/windows/desktop/ms682411(v=vs.85).aspx states\r\n>If lpMutexAttributes is NULL, the mutex gets a default security descriptor. The ACLs in the default security descriptor for a mutex come from the primary or impersonation token of the creator.\r\n\r\nThat would explain why it happens only on my setup, but then this should happen more regularly?\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/frerich/clcache/issues/comments/239158938","html_url":"https://github.com/frerich/clcache/pull/201#issuecomment-239158938","issue_url":"https://api.github.com/repos/frerich/clcache/issues/201","id":239158938,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T13:22:17Z","updated_at":"2016-08-11T13:22:17Z","body":"## [Current coverage](https://codecov.io/gh/frerich/clcache/pull/201?src=pr) is 78.31% (diff: 50.00%)\n> Merging [#201](https://codecov.io/gh/frerich/clcache/pull/201?src=pr) into [master](https://codecov.io/gh/frerich/clcache/branch/master?src=pr) will decrease coverage by **0.26%**\n\n```diff\n@@             master       #201   diff @@\n==========================================\n  Files             1          1          \n  Lines           929        936     +7   \n  Methods           0          0          \n  Messages          0          0          \n  Branches        155        156     +1   \n==========================================\n+ Hits            730        733     +3   \n- Misses          166        170     +4   \n  Partials         33         33          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [e25b61a...e778f2d](https://codecov.io/gh/frerich/clcache/compare/e25b61a463cc32b2864ac221ad7ea24dd52836d9...e778f2d8283a9f00bbf99e2bfca954d6dfb8600e?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}