{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/420","repository_url":"https://api.github.com/repos/spring-projects/spring-amqp","labels_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/420/comments","events_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/420/events","html_url":"https://github.com/spring-projects/spring-amqp/issues/420","id":155251013,"number":420,"title":"quick question...hopefully","user":{"login":"born2snipe","id":22510,"avatar_url":"https://avatars.githubusercontent.com/u/22510?v=3","gravatar_id":"","url":"https://api.github.com/users/born2snipe","html_url":"https://github.com/born2snipe","followers_url":"https://api.github.com/users/born2snipe/followers","following_url":"https://api.github.com/users/born2snipe/following{/other_user}","gists_url":"https://api.github.com/users/born2snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/born2snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/born2snipe/subscriptions","organizations_url":"https://api.github.com/users/born2snipe/orgs","repos_url":"https://api.github.com/users/born2snipe/repos","events_url":"https://api.github.com/users/born2snipe/events{/privacy}","received_events_url":"https://api.github.com/users/born2snipe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-17T12:49:12Z","updated_at":"2016-05-17T13:56:13Z","closed_at":null,"body":"Maybe the method is poorly named or I maybe I don't fully understand the domain but....this logic looked suspicious to me:\r\n\r\nhttps://github.com/spring-projects/spring-amqp/blob/master/spring-amqp/src/main/java/org/springframework/amqp/core/AcknowledgeMode.java#L32\r\n\r\nShouldn't the comparison be against AUTO instead of NONE?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/comments/219725019","html_url":"https://github.com/spring-projects/spring-amqp/issues/420#issuecomment-219725019","issue_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/420","id":219725019,"user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T13:56:13Z","updated_at":"2016-05-17T13:56:13Z","body":"It's a bit unfortunate, but correct.\r\n\r\nIn the RabbitMQ world, \"auto ack\" means no acks - i.e. the broker marks the message as delivered as soon as it is sent to the client.\r\n\r\nIn the Spring world (specifically JMS) `AUTO` ack means the listener container takes care of the ack when the listener returns normally (and nacks for exceptions).\r\n\r\nSo, when Spring AMQP was created, it was aligned more with spring-jms and `AUTO` means the container will send the acks, `MANUAL` means the user is responsible for acking and `NONE` means no acks (i.e. auto Ack in RabbitMQ-speak).\r\n\r\n(This is my understanding, I wasn't here at the time).\r\n\r\nI will, however, take this opportunity to add some javadocs there."}}