{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24237","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24237/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24237/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24237/events","html_url":"https://github.com/docker/docker/pull/24237","id":163467647,"number":24237,"title":"Require unambiguous listen IP at \"swarm init\"","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/area/swarm","name":"area/swarm","color":"fbca04"},{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"},{"url":"https://api.github.com/repos/docker/docker/labels/status/needs-attention","name":"status/needs-attention","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"feature/code freeze: June 14th, 2016","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":129,"closed_issues":622,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-07-14T01:01:20Z","due_on":"2016-07-28T07:00:00Z","closed_at":null},"comments":58,"created_at":"2016-07-01T20:20:40Z","updated_at":"2016-07-14T01:06:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24237","html_url":"https://github.com/docker/docker/pull/24237","diff_url":"https://github.com/docker/docker/pull/24237.diff","patch_url":"https://github.com/docker/docker/pull/24237.patch"},"body":"There are currently problems with \"swarm init\" and \"swarm join\" when an\r\nexplicit --listen-addr flag is not provided. swarmkit defaults to\r\nfinding the IP address associated with the default route, and in cloud\r\nsetups this is often the wrong choice.\r\n\r\nInstead of trying to use this magic, error out if there is more than one\r\nusable candidate IP address on the system. This requires a user to\r\nexplicitly choose instead of letting swarmkit make the wrong choice.\r\n\r\nAlso support specifying interface names to --listen-addr. This will fail\r\nif the interface has multiple IP addresses (unless it has a single IPv4\r\naddress and a single IPv6 address - then we resolve the tie in favor of\r\nIPv4).\r\n\r\nMake corresponding API and CLI docs changes.\r\n\r\nFixes #23828\r\nFixes #23877\r\nFixes #23995\r\nFixes #24587\r\n\r\ncc @aluzzardi @mrjana @tonistiigi @dnephin"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/232529896","html_url":"https://github.com/docker/docker/pull/24237#issuecomment-232529896","issue_url":"https://api.github.com/repos/docker/docker/issues/24237","id":232529896,"user":{"login":"aluzzardi","id":179503,"avatar_url":"https://avatars.githubusercontent.com/u/179503?v=3","gravatar_id":"","url":"https://api.github.com/users/aluzzardi","html_url":"https://github.com/aluzzardi","followers_url":"https://api.github.com/users/aluzzardi/followers","following_url":"https://api.github.com/users/aluzzardi/following{/other_user}","gists_url":"https://api.github.com/users/aluzzardi/gists{/gist_id}","starred_url":"https://api.github.com/users/aluzzardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluzzardi/subscriptions","organizations_url":"https://api.github.com/users/aluzzardi/orgs","repos_url":"https://api.github.com/users/aluzzardi/repos","events_url":"https://api.github.com/users/aluzzardi/events{/privacy}","received_events_url":"https://api.github.com/users/aluzzardi/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T01:06:21Z","updated_at":"2016-07-14T01:06:21Z","body":"> I think that this is a UX optimization that could easily come afterwards.\r\n\r\n@aaronlehmann LGTM to unblock but we have to acknowledge the following:\r\n\r\nThis PR **removes** support for auto detection. There is some code that a handful of Docker maintainers will hit when performing some dind testing but for everyone else, `--listen-addr` is now **mandatory**. \r\n\r\nWe can decide now whether we're going to fix it for 1.12 or remove auto detection as a feature from our docs."}}
{"actor":{"display_login":"aluzzardi"}}