{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/50447711","id":50447711,"diff_hunk":"@@ -222,8 +222,135 @@ fi\n source $TRAF_CONFIG\n }\n \n-function checkJavaVersion {\n+function checkManageNodeList {\n+\n+if [[ -z $MANAGE_NODES ]]; then","path":"install/installer/traf_config_check","position":7,"original_position":7,"commit_id":"ee4c25397f647805c112ffdec55bd9c24a30a432","original_commit_id":"ee4c25397f647805c112ffdec55bd9c24a30a432","user":{"login":"hegdean","id":12959032,"avatar_url":"https://avatars.githubusercontent.com/u/12959032?v=3","gravatar_id":"","url":"https://api.github.com/users/hegdean","html_url":"https://github.com/hegdean","followers_url":"https://api.github.com/users/hegdean/followers","following_url":"https://api.github.com/users/hegdean/following{/other_user}","gists_url":"https://api.github.com/users/hegdean/gists{/gist_id}","starred_url":"https://api.github.com/users/hegdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hegdean/subscriptions","organizations_url":"https://api.github.com/users/hegdean/orgs","repos_url":"https://api.github.com/users/hegdean/repos","events_url":"https://api.github.com/users/hegdean/events{/privacy}","received_events_url":"https://api.github.com/users/hegdean/received_events","type":"User","site_admin":false},"body":"can we rename this to MANAGEMENT_NODES instead of MANAGE_NODES","created_at":"2016-01-21T19:14:04Z","updated_at":"2016-01-21T19:14:04Z","html_url":"https://github.com/apache/incubator-trafodion/pull/274#discussion_r50447711","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/50447711"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/274#discussion_r50447711"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274","id":56686286,"html_url":"https://github.com/apache/incubator-trafodion/pull/274","diff_url":"https://github.com/apache/incubator-trafodion/pull/274.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/274.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/274","number":274,"state":"open","locked":false,"title":"Many bug fixes for Installer. All JIRA's listed.","user":{"login":"amandamoran","id":12958292,"avatar_url":"https://avatars.githubusercontent.com/u/12958292?v=3","gravatar_id":"","url":"https://api.github.com/users/amandamoran","html_url":"https://github.com/amandamoran","followers_url":"https://api.github.com/users/amandamoran/followers","following_url":"https://api.github.com/users/amandamoran/following{/other_user}","gists_url":"https://api.github.com/users/amandamoran/gists{/gist_id}","starred_url":"https://api.github.com/users/amandamoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandamoran/subscriptions","organizations_url":"https://api.github.com/users/amandamoran/orgs","repos_url":"https://api.github.com/users/amandamoran/repos","events_url":"https://api.github.com/users/amandamoran/events{/privacy}","received_events_url":"https://api.github.com/users/amandamoran/received_events","type":"User","site_admin":false},"body":"TRAFODION-1545 Adding Management nodes\nTRAFODION-1691 Smaller subscripts\nTrafodion-1681 need full HADOOP path for hdfs\nTrafodion-1689 DCS HA\nTrafodion-1756 kernel.pid_max persistent on reboot\nTrafodion-1694 kernel.pid_max full path\nTrafodion-1693 CLUSTERNAME being set\nTrafodion-1574 increasing maintainability of scripts\nTrafodion-1711 curl commands should accept http/https\nTrafodion-1478 Create /hbase/archive/data/default","created_at":"2016-01-20T23:56:42Z","updated_at":"2016-01-21T19:14:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67a276e586998e77542b4b35041fe8ca47154941","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/274/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/ee4c25397f647805c112ffdec55bd9c24a30a432","head":{"label":"amandamoran:installbugfixes","ref":"installbugfixes","sha":"ee4c25397f647805c112ffdec55bd9c24a30a432","user":{"login":"amandamoran","id":12958292,"avatar_url":"https://avatars.githubusercontent.com/u/12958292?v=3","gravatar_id":"","url":"https://api.github.com/users/amandamoran","html_url":"https://github.com/amandamoran","followers_url":"https://api.github.com/users/amandamoran/followers","following_url":"https://api.github.com/users/amandamoran/following{/other_user}","gists_url":"https://api.github.com/users/amandamoran/gists{/gist_id}","starred_url":"https://api.github.com/users/amandamoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandamoran/subscriptions","organizations_url":"https://api.github.com/users/amandamoran/orgs","repos_url":"https://api.github.com/users/amandamoran/repos","events_url":"https://api.github.com/users/amandamoran/events{/privacy}","received_events_url":"https://api.github.com/users/amandamoran/received_events","type":"User","site_admin":false},"repo":{"id":38718475,"name":"incubator-trafodion","full_name":"amandamoran/incubator-trafodion","owner":{"login":"amandamoran","id":12958292,"avatar_url":"https://avatars.githubusercontent.com/u/12958292?v=3","gravatar_id":"","url":"https://api.github.com/users/amandamoran","html_url":"https://github.com/amandamoran","followers_url":"https://api.github.com/users/amandamoran/followers","following_url":"https://api.github.com/users/amandamoran/following{/other_user}","gists_url":"https://api.github.com/users/amandamoran/gists{/gist_id}","starred_url":"https://api.github.com/users/amandamoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandamoran/subscriptions","organizations_url":"https://api.github.com/users/amandamoran/orgs","repos_url":"https://api.github.com/users/amandamoran/repos","events_url":"https://api.github.com/users/amandamoran/events{/privacy}","received_events_url":"https://api.github.com/users/amandamoran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amandamoran/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/amandamoran/incubator-trafodion","forks_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/amandamoran/incubator-trafodion/releases{/id}","created_at":"2015-07-07T22:35:07Z","updated_at":"2015-07-07T22:35:46Z","pushed_at":"2016-01-20T23:55:38Z","git_url":"git://github.com/amandamoran/incubator-trafodion.git","ssh_url":"git@github.com:amandamoran/incubator-trafodion.git","clone_url":"https://github.com/amandamoran/incubator-trafodion.git","svn_url":"https://github.com/amandamoran/incubator-trafodion","homepage":null,"size":65230,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e846a0f6ab850ecb588c6d64e49e9f399e75cfbf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","created_at":"2015-05-27T07:00:05Z","updated_at":"2016-01-11T17:50:32Z","pushed_at":"2016-01-21T18:45:25Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":65742,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":15,"forks":57,"open_issues":15,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/274"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/274"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/ee4c25397f647805c112ffdec55bd9c24a30a432"}}}}