{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/3857","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/3857/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/3857/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/3857/events","html_url":"https://github.com/dotnet/coreclr/issues/3857","id":142578789,"number":3857,"title":"IsEventSourceLoggingEnabled Missing on Linux ARM","user":{"login":"manu-silicon","id":13194660,"avatar_url":"https://avatars.githubusercontent.com/u/13194660?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-silicon","html_url":"https://github.com/manu-silicon","followers_url":"https://api.github.com/users/manu-silicon/followers","following_url":"https://api.github.com/users/manu-silicon/following{/other_user}","gists_url":"https://api.github.com/users/manu-silicon/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-silicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-silicon/subscriptions","organizations_url":"https://api.github.com/users/manu-silicon/orgs","repos_url":"https://api.github.com/users/manu-silicon/repos","events_url":"https://api.github.com/users/manu-silicon/events{/privacy}","received_events_url":"https://api.github.com/users/manu-silicon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/ARM","name":"ARM","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-22T08:18:08Z","updated_at":"2016-03-23T01:52:14Z","closed_at":null,"body":"I'm having an issue on Linux Arm where it cannot find an ID for method ```IsEventSourceLoggingEnabled``` at line 542 of ecall.cpp (https://github.com/dotnet/coreclr/blob/master/src/vm/ecall.cpp#L542)\r\n\r\nTurns out that FEATURE_EVENT_TRACE is disabled for Linux ARM by this PR #2935. Should this be reverted back to allow FEATURE_EVENT_TRACE for all platforms? Or should we change mscorlib to not call it when it is not defined?"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/200122324","html_url":"https://github.com/dotnet/coreclr/issues/3857#issuecomment-200122324","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/3857","id":200122324,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T01:52:14Z","updated_at":"2016-03-23T01:52:14Z","body":"We usually add those right next to the real ones. Or in this case - it may be best to just ifdef out the bodies of the real ones, like:\r\n\r\n```\r\nBOOL QCALLTYPE XplatEventSourceLogger::IsEventSourceLoggingEnabled()\r\n{\r\n    QCALL_CONTRACT;\r\n\r\n    BOOL retVal = FALSE;\r\n\r\n#if defined(FEATURE_EVENTSOURCE_XPLAT)\r\n    BEGIN_QCALL;\r\n    retVal = XplatEventLogger::IsEventLoggingEnabled();\r\n    END_QCALL;\r\n#endif\r\n    \r\n    return retVal;\r\n}\r\n```"}}