{"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/49891457","id":49891457,"diff_hunk":"@@ -341,10 +342,10 @@ check_status (Context * context)\n \t\t\t\t force_icon);\n \t\t\texit (1);\n \t\t}\n-\t\talter_icon (context, status_type);\n \t} else {\n \t\tstatus_type = check_status_over_dbus (context);\n \t}\n+    alter_icon (context, status_type);","path":"src/rhsm_icon/rhsm_icon.c","position":16,"original_position":16,"commit_id":"002a998df4d460c81bd10dba3ae8565d92d446b8","original_commit_id":"002a998df4d460c81bd10dba3ae8565d92d446b8","user":{"login":"vritant","id":2501280,"avatar_url":"https://avatars.githubusercontent.com/u/2501280?v=3","gravatar_id":"","url":"https://api.github.com/users/vritant","html_url":"https://github.com/vritant","followers_url":"https://api.github.com/users/vritant/followers","following_url":"https://api.github.com/users/vritant/following{/other_user}","gists_url":"https://api.github.com/users/vritant/gists{/gist_id}","starred_url":"https://api.github.com/users/vritant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vritant/subscriptions","organizations_url":"https://api.github.com/users/vritant/orgs","repos_url":"https://api.github.com/users/vritant/repos","events_url":"https://api.github.com/users/vritant/events{/privacy}","received_events_url":"https://api.github.com/users/vritant/received_events","type":"User","site_admin":false},"body":"indent needs fixing","created_at":"2016-01-15T19:04:20Z","updated_at":"2016-01-15T19:04:20Z","html_url":"https://github.com/candlepin/subscription-manager/pull/1373#discussion_r49891457","pull_request_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373","_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/49891457"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1373#discussion_r49891457"},"pull_request":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373","id":56199483,"html_url":"https://github.com/candlepin/subscription-manager/pull/1373","diff_url":"https://github.com/candlepin/subscription-manager/pull/1373.diff","patch_url":"https://github.com/candlepin/subscription-manager/pull/1373.patch","issue_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1373","number":1373,"state":"open","locked":false,"title":"1046132: rhsm_icon uses status from check_status","user":{"login":"alikins","id":15162,"avatar_url":"https://avatars.githubusercontent.com/u/15162?v=3","gravatar_id":"","url":"https://api.github.com/users/alikins","html_url":"https://github.com/alikins","followers_url":"https://api.github.com/users/alikins/followers","following_url":"https://api.github.com/users/alikins/following{/other_user}","gists_url":"https://api.github.com/users/alikins/gists{/gist_id}","starred_url":"https://api.github.com/users/alikins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikins/subscriptions","organizations_url":"https://api.github.com/users/alikins/orgs","repos_url":"https://api.github.com/users/alikins/repos","events_url":"https://api.github.com/users/alikins/events{/privacy}","received_events_url":"https://api.github.com/users/alikins/received_events","type":"User","site_admin":false},"body":"This changes rhsm_icon.c to use the entitlement\r\nstatus returned from it's call to 'check_status'\r\ndbus method for the intial_check and daily checks.\r\n\r\nPreviously, the status returned from 'check_status'\r\nwas ignored, instead being triggered by the\r\n'entitlement_status_changed' dbus signal. However,\r\nrhsm_d.py was prone to emitting this too often\r\nbecause of multiple bugs that are now fixed.\r\nSee commit 35aa7e7eba82f601504bb64ab56aebe6dee4e786.\r\n\r\nSince rhsm_icons display_icon knows how to handle\r\na RHSM_VALID state (ie, don't do anything), we can\r\npass any entitlement status to it, instead of waiting\r\nfor a entitlement_status_changed signal.\r\n\r\nThe 'check_status' dbus method now only emits a\r\nentitlement_status_changed signal if the current status\r\nis different than the last know status.","created_at":"2016-01-15T17:46:23Z","updated_at":"2016-01-15T19:04:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8534fab1cdf9a15221babfbf71f8ef187c0637ce","assignee":{"login":"vritant","id":2501280,"avatar_url":"https://avatars.githubusercontent.com/u/2501280?v=3","gravatar_id":"","url":"https://api.github.com/users/vritant","html_url":"https://github.com/vritant","followers_url":"https://api.github.com/users/vritant/followers","following_url":"https://api.github.com/users/vritant/following{/other_user}","gists_url":"https://api.github.com/users/vritant/gists{/gist_id}","starred_url":"https://api.github.com/users/vritant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vritant/subscriptions","organizations_url":"https://api.github.com/users/vritant/orgs","repos_url":"https://api.github.com/users/vritant/repos","events_url":"https://api.github.com/users/vritant/events{/privacy}","received_events_url":"https://api.github.com/users/vritant/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373/commits","review_comments_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373/comments","review_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1373/comments","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/002a998df4d460c81bd10dba3ae8565d92d446b8","head":{"label":"candlepin:alikins/1046132_rhsm_icon_alter","ref":"alikins/1046132_rhsm_icon_alter","sha":"002a998df4d460c81bd10dba3ae8565d92d446b8","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","created_at":"2012-05-17T16:13:30Z","updated_at":"2016-01-11T19:01:49Z","pushed_at":"2016-01-15T18:02:34Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"git@github.com:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":31390,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":8,"forks":28,"open_issues":8,"watchers":14,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"7f1106a8feb51bec6581fb9d60b6bf3bba5676f7","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","created_at":"2012-05-17T16:13:30Z","updated_at":"2016-01-11T19:01:49Z","pushed_at":"2016-01-15T18:02:34Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"git@github.com:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":31390,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":8,"forks":28,"open_issues":8,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1373"},"issue":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1373"},"comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1373/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1373/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/subscription-manager/statuses/002a998df4d460c81bd10dba3ae8565d92d446b8"}}}}