{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/63568430","id":63568430,"diff_hunk":"@@ -14,16 +14,44 @@ enum _DragState {\n   accepted,\n }\n \n+/// Signature for when a pointer has contacted the screen and might begin to move.\n typedef void GestureDragDownCallback(Point globalPosition);\n+\n+/// Signature for when a pointer has contacted the screen and has begun to move.\n typedef void GestureDragStartCallback(Point globalPosition);\n+\n+/// Signature for when a pointer that is in contact with the screen and moving\n+/// in a direction (e.g., vertically or horizontally) has moved in that\n+/// direction.\n typedef void GestureDragUpdateCallback(double delta);\n+\n+/// Signature for when a pointer that was previously in contact with the screen\n+/// and moving in a direction (e.g., vertically or horizontally) is no longer in\n+/// contact with the screen and was moving at a specific velocity when it\n+/// stopped contacting the screen.\n typedef void GestureDragEndCallback(Velocity velocity);\n+\n+/// Signature for when the pointer that previously triggered a\n+/// [GestureDragDownCallback] did not end up moving.","path":"packages/flutter/lib/src/gestures/drag.dart","position":22,"original_position":22,"commit_id":"b1d7f99713d463bb9dd222cff6735a1cc2c079a1","original_commit_id":"b1d7f99713d463bb9dd222cff6735a1cc2c079a1","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"No, we'll call GestureDragEndCallback in that case.  That's probably a bug.","created_at":"2016-05-17T17:38:17Z","updated_at":"2016-05-17T17:38:17Z","html_url":"https://github.com/flutter/flutter/pull/3966#discussion_r63568430","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/3966","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/63568430"},"html":{"href":"https://github.com/flutter/flutter/pull/3966#discussion_r63568430"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3966"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/3966","id":70387258,"html_url":"https://github.com/flutter/flutter/pull/3966","diff_url":"https://github.com/flutter/flutter/pull/3966.diff","patch_url":"https://github.com/flutter/flutter/pull/3966.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/3966","number":3966,"state":"open","locked":false,"title":"Add some docs to gestures.dart","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Also, add some missing docs to http.dart and widgets.dart.","created_at":"2016-05-17T16:21:56Z","updated_at":"2016-05-17T17:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89204e47854cc854a1e9bf300b3034dd6642348","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/3966/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/3966/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/3966/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/b1d7f99713d463bb9dd222cff6735a1cc2c079a1","head":{"label":"abarth:doc_gestures","ref":"doc_gestures","sha":"b1d7f99713d463bb9dd222cff6735a1cc2c079a1","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":45444193,"name":"flutter","full_name":"abarth/flutter","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/abarth/flutter","forks_url":"https://api.github.com/repos/abarth/flutter/forks","keys_url":"https://api.github.com/repos/abarth/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/flutter/teams","hooks_url":"https://api.github.com/repos/abarth/flutter/hooks","issue_events_url":"https://api.github.com/repos/abarth/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/flutter/events","assignees_url":"https://api.github.com/repos/abarth/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/flutter/tags","blobs_url":"https://api.github.com/repos/abarth/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/flutter/languages","stargazers_url":"https://api.github.com/repos/abarth/flutter/stargazers","contributors_url":"https://api.github.com/repos/abarth/flutter/contributors","subscribers_url":"https://api.github.com/repos/abarth/flutter/subscribers","subscription_url":"https://api.github.com/repos/abarth/flutter/subscription","commits_url":"https://api.github.com/repos/abarth/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/flutter/merges","archive_url":"https://api.github.com/repos/abarth/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/flutter/downloads","issues_url":"https://api.github.com/repos/abarth/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/flutter/labels{/name}","releases_url":"https://api.github.com/repos/abarth/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/abarth/flutter/deployments","created_at":"2015-11-03T05:34:45Z","updated_at":"2016-04-08T16:45:41Z","pushed_at":"2016-05-17T16:21:47Z","git_url":"git://github.com/abarth/flutter.git","ssh_url":"git@github.com:abarth/flutter.git","clone_url":"https://github.com/abarth/flutter.git","svn_url":"https://github.com/abarth/flutter","homepage":"http://flutter.io","size":17509,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"a6b8980d3e801b46b3cdfca15e4a54cb71d528c9","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-05-17T12:39:37Z","pushed_at":"2016-05-17T16:21:57Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":111380,"stargazers_count":2782,"watchers_count":2782,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"open_issues_count":930,"forks":291,"open_issues":930,"watchers":2782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3966"},"html":{"href":"https://github.com/flutter/flutter/pull/3966"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/3966"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/3966/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3966/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3966/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/b1d7f99713d463bb9dd222cff6735a1cc2c079a1"}}}}