{"action":"created","comment":{"url":"https://api.github.com/repos/rilmodem/ofono/pulls/comments/68008106","id":68008106,"diff_hunk":"@@ -943,7 +944,8 @@ static void ril_query_pin_retries(struct ofono_sim *sim,\n \t\t\tg_free(cbd);\n \t\t\tCALLBACK_WITH_FAILURE(cb, NULL, data);\n \t\t}\n-\t} else if (sd->vendor == OFONO_RIL_VENDOR_MTK) {\n+\t} else if (sd->vendor == OFONO_RIL_VENDOR_MTK ||\n+\t\t\tsd->vendor == OFONO_RIL_VENDOR_MTK2) {","path":"drivers/rilmodem/sim.c","position":14,"original_position":14,"commit_id":"f794526b13ca3bda1312675f5a0d35f291bb4c97","original_commit_id":"f794526b13ca3bda1312675f5a0d35f291bb4c97","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"body":"My testing has revealed that some quirk are needed for:\r\n\r\nOnly OFONO_RIL_VENDOR_MTK (like in g_ril_reply_parse_avail_ops())\r\nOnly OFONO_RIL_VENDOR_MTK2 (like in g_ril_unsol_parse_connected())\r\nBoth (most other quirks)\r\n\r\nSo we need both vendor tags.\r\n","created_at":"2016-06-22T07:48:22Z","updated_at":"2016-06-22T07:48:22Z","html_url":"https://github.com/rilmodem/ofono/pull/240#discussion_r68008106","pull_request_url":"https://api.github.com/repos/rilmodem/ofono/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/comments/68008106"},"html":{"href":"https://github.com/rilmodem/ofono/pull/240#discussion_r68008106"},"pull_request":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/rilmodem/ofono/pulls/240","id":74101938,"html_url":"https://github.com/rilmodem/ofono/pull/240","diff_url":"https://github.com/rilmodem/ofono/pull/240.diff","patch_url":"https://github.com/rilmodem/ofono/pull/240.patch","issue_url":"https://api.github.com/repos/rilmodem/ofono/issues/240","number":240,"state":"open","locked":false,"title":"Support for midori","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-16T15:31:11Z","updated_at":"2016-06-22T07:48:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"647b2b714e034721ce6c78e3e4fc74be7f49f2f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rilmodem/ofono/pulls/240/commits","review_comments_url":"https://api.github.com/repos/rilmodem/ofono/pulls/240/comments","review_comment_url":"https://api.github.com/repos/rilmodem/ofono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rilmodem/ofono/issues/240/comments","statuses_url":"https://api.github.com/repos/rilmodem/ofono/statuses/f794526b13ca3bda1312675f5a0d35f291bb4c97","head":{"label":"alfonsosanchezbeato:midori","ref":"midori","sha":"f794526b13ca3bda1312675f5a0d35f291bb4c97","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"repo":{"id":13247010,"name":"ofono","full_name":"alfonsosanchezbeato/ofono","owner":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfonsosanchezbeato/ofono","description":"","fork":true,"url":"https://api.github.com/repos/alfonsosanchezbeato/ofono","forks_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/forks","keys_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/teams","hooks_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/hooks","issue_events_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/issues/events{/number}","events_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/events","assignees_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/assignees{/user}","branches_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/branches{/branch}","tags_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/tags","blobs_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/statuses/{sha}","languages_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/languages","stargazers_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/stargazers","contributors_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/contributors","subscribers_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/subscribers","subscription_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/subscription","commits_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/contents/{+path}","compare_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/merges","archive_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/downloads","issues_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/issues{/number}","pulls_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/pulls{/number}","milestones_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/milestones{/number}","notifications_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/labels{/name}","releases_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/releases{/id}","deployments_url":"https://api.github.com/repos/alfonsosanchezbeato/ofono/deployments","created_at":"2013-10-01T15:00:02Z","updated_at":"2015-04-23T06:10:53Z","pushed_at":"2016-06-21T14:35:47Z","git_url":"git://github.com/alfonsosanchezbeato/ofono.git","ssh_url":"git@github.com:alfonsosanchezbeato/ofono.git","clone_url":"https://github.com/alfonsosanchezbeato/ofono.git","svn_url":"https://github.com/alfonsosanchezbeato/ofono","homepage":null,"size":21449,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rilmodem:master","ref":"master","sha":"201bec581df5e5015e00d6128b3e1a305003364d","user":{"login":"rilmodem","id":5394617,"avatar_url":"https://avatars.githubusercontent.com/u/5394617?v=3","gravatar_id":"","url":"https://api.github.com/users/rilmodem","html_url":"https://github.com/rilmodem","followers_url":"https://api.github.com/users/rilmodem/followers","following_url":"https://api.github.com/users/rilmodem/following{/other_user}","gists_url":"https://api.github.com/users/rilmodem/gists{/gist_id}","starred_url":"https://api.github.com/users/rilmodem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rilmodem/subscriptions","organizations_url":"https://api.github.com/users/rilmodem/orgs","repos_url":"https://api.github.com/users/rilmodem/repos","events_url":"https://api.github.com/users/rilmodem/events{/privacy}","received_events_url":"https://api.github.com/users/rilmodem/received_events","type":"Organization","site_admin":false},"repo":{"id":12710932,"name":"ofono","full_name":"rilmodem/ofono","owner":{"login":"rilmodem","id":5394617,"avatar_url":"https://avatars.githubusercontent.com/u/5394617?v=3","gravatar_id":"","url":"https://api.github.com/users/rilmodem","html_url":"https://github.com/rilmodem","followers_url":"https://api.github.com/users/rilmodem/followers","following_url":"https://api.github.com/users/rilmodem/following{/other_user}","gists_url":"https://api.github.com/users/rilmodem/gists{/gist_id}","starred_url":"https://api.github.com/users/rilmodem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rilmodem/subscriptions","organizations_url":"https://api.github.com/users/rilmodem/orgs","repos_url":"https://api.github.com/users/rilmodem/repos","events_url":"https://api.github.com/users/rilmodem/events{/privacy}","received_events_url":"https://api.github.com/users/rilmodem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rilmodem/ofono","description":"7f3955122af8b0349fb7d3f2db8abd754459d146","fork":false,"url":"https://api.github.com/repos/rilmodem/ofono","forks_url":"https://api.github.com/repos/rilmodem/ofono/forks","keys_url":"https://api.github.com/repos/rilmodem/ofono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rilmodem/ofono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rilmodem/ofono/teams","hooks_url":"https://api.github.com/repos/rilmodem/ofono/hooks","issue_events_url":"https://api.github.com/repos/rilmodem/ofono/issues/events{/number}","events_url":"https://api.github.com/repos/rilmodem/ofono/events","assignees_url":"https://api.github.com/repos/rilmodem/ofono/assignees{/user}","branches_url":"https://api.github.com/repos/rilmodem/ofono/branches{/branch}","tags_url":"https://api.github.com/repos/rilmodem/ofono/tags","blobs_url":"https://api.github.com/repos/rilmodem/ofono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rilmodem/ofono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rilmodem/ofono/git/refs{/sha}","trees_url":"https://api.github.com/repos/rilmodem/ofono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rilmodem/ofono/statuses/{sha}","languages_url":"https://api.github.com/repos/rilmodem/ofono/languages","stargazers_url":"https://api.github.com/repos/rilmodem/ofono/stargazers","contributors_url":"https://api.github.com/repos/rilmodem/ofono/contributors","subscribers_url":"https://api.github.com/repos/rilmodem/ofono/subscribers","subscription_url":"https://api.github.com/repos/rilmodem/ofono/subscription","commits_url":"https://api.github.com/repos/rilmodem/ofono/commits{/sha}","git_commits_url":"https://api.github.com/repos/rilmodem/ofono/git/commits{/sha}","comments_url":"https://api.github.com/repos/rilmodem/ofono/comments{/number}","issue_comment_url":"https://api.github.com/repos/rilmodem/ofono/issues/comments{/number}","contents_url":"https://api.github.com/repos/rilmodem/ofono/contents/{+path}","compare_url":"https://api.github.com/repos/rilmodem/ofono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rilmodem/ofono/merges","archive_url":"https://api.github.com/repos/rilmodem/ofono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rilmodem/ofono/downloads","issues_url":"https://api.github.com/repos/rilmodem/ofono/issues{/number}","pulls_url":"https://api.github.com/repos/rilmodem/ofono/pulls{/number}","milestones_url":"https://api.github.com/repos/rilmodem/ofono/milestones{/number}","notifications_url":"https://api.github.com/repos/rilmodem/ofono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rilmodem/ofono/labels{/name}","releases_url":"https://api.github.com/repos/rilmodem/ofono/releases{/id}","deployments_url":"https://api.github.com/repos/rilmodem/ofono/deployments","created_at":"2013-09-09T19:45:47Z","updated_at":"2016-03-06T00:46:19Z","pushed_at":"2016-06-20T17:13:30Z","git_url":"git://github.com/rilmodem/ofono.git","ssh_url":"git@github.com:rilmodem/ofono.git","clone_url":"https://github.com/rilmodem/ofono.git","svn_url":"https://github.com/rilmodem/ofono","homepage":"","size":22424,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":15,"forks":15,"open_issues":15,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/240"},"html":{"href":"https://github.com/rilmodem/ofono/pull/240"},"issue":{"href":"https://api.github.com/repos/rilmodem/ofono/issues/240"},"comments":{"href":"https://api.github.com/repos/rilmodem/ofono/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/rilmodem/ofono/statuses/f794526b13ca3bda1312675f5a0d35f291bb4c97"}}}}
{"actor":{"display_login":"alfonsosanchezbeato"}}