{"action":"created","issue":{"url":"https://api.github.com/repos/ensime/ensime-vim/issues/332","repository_url":"https://api.github.com/repos/ensime/ensime-vim","labels_url":"https://api.github.com/repos/ensime/ensime-vim/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/ensime/ensime-vim/issues/332/comments","events_url":"https://api.github.com/repos/ensime/ensime-vim/issues/332/events","html_url":"https://github.com/ensime/ensime-vim/pull/332","id":171151649,"number":332,"title":"Make StringResponse handler's roles more obvious","user":{"login":"ches","id":13277,"avatar_url":"https://avatars.githubusercontent.com/u/13277?v=3","gravatar_id":"","url":"https://api.github.com/users/ches","html_url":"https://github.com/ches","followers_url":"https://api.github.com/users/ches/followers","following_url":"https://api.github.com/users/ches/following{/other_user}","gists_url":"https://api.github.com/users/ches/gists{/gist_id}","starred_url":"https://api.github.com/users/ches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ches/subscriptions","organizations_url":"https://api.github.com/users/ches/orgs","repos_url":"https://api.github.com/users/ches/repos","events_url":"https://api.github.com/users/ches/events{/privacy}","received_events_url":"https://api.github.com/users/ches/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ensime/ensime-vim/labels/In%20progress","name":"In progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-15T11:14:06Z","updated_at":"2016-08-15T13:27:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ensime/ensime-vim/pulls/332","html_url":"https://github.com/ensime/ensime-vim/pull/332","diff_url":"https://github.com/ensime/ensime-vim/pull/332.diff","patch_url":"https://github.com/ensime/ensime-vim/pull/332.patch"},"body":"This is an incremental refactoring in response to #330 and the discussion that spawned it: https://github.com/ensime/ensime-vim/pull/328#discussion_r72899574\r\n\r\nThis does not attempt to solve some broader design issues discussed in #330, it’s just a small localized change to separate the logic for the very different types of requests that `StringResponse` can be returned for, so it's more obvious that this handler has these different roles. This is in part to help factor out the direct usage of the editor to finish #328. I've made these private functions for now, they're not really handler functions for discrete ENSIME server response message types like the rest of the formal `ProtocolHandler` interface. They will might eventually fit logically somewhere else.\r\n\r\nAs I've mentioned elsewhere, I don't really understand the purpose of the `:EnDocUri` command, it used to print the documentation URL in Vim's message area—which I don't see as useful—but even that is broken on current master (the command actually causes an exception). My guess is that the intent was that it could be useful as a *function* instead of command, allowing users to do something custom with the URL as a function result. As-is I don't yet see how to cleanly change it to work that way, it would have to be made synchronous. So with this change, I have un-documented the command but left some implementation in place with a TODO (and it no longer causes an exception, just basically a no-op). I could just go all the way and completely remove the command and that handling code right now, WDYT?"},"comment":{"url":"https://api.github.com/repos/ensime/ensime-vim/issues/comments/239801283","html_url":"https://github.com/ensime/ensime-vim/pull/332#issuecomment-239801283","issue_url":"https://api.github.com/repos/ensime/ensime-vim/issues/332","id":239801283,"user":{"login":"ches","id":13277,"avatar_url":"https://avatars.githubusercontent.com/u/13277?v=3","gravatar_id":"","url":"https://api.github.com/users/ches","html_url":"https://github.com/ches","followers_url":"https://api.github.com/users/ches/followers","following_url":"https://api.github.com/users/ches/following{/other_user}","gists_url":"https://api.github.com/users/ches/gists{/gist_id}","starred_url":"https://api.github.com/users/ches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ches/subscriptions","organizations_url":"https://api.github.com/users/ches/orgs","repos_url":"https://api.github.com/users/ches/repos","events_url":"https://api.github.com/users/ches/events{/privacy}","received_events_url":"https://api.github.com/users/ches/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T13:27:46Z","updated_at":"2016-08-15T13:27:46Z","body":"LGTM"}}
{"actor":{"display_login":"ches"}}