{"action":"created","issue":{"url":"https://api.github.com/repos/perfectapi/CKP/issues/104","repository_url":"https://api.github.com/repos/perfectapi/CKP","labels_url":"https://api.github.com/repos/perfectapi/CKP/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/perfectapi/CKP/issues/104/comments","events_url":"https://api.github.com/repos/perfectapi/CKP/issues/104/events","html_url":"https://github.com/perfectapi/CKP/issues/104","id":161346613,"number":104,"title":"Workaround to disable safari password autofill breaks CKP autofill","user":{"login":"thelollies","id":3683599,"avatar_url":"https://avatars.githubusercontent.com/u/3683599?v=3","gravatar_id":"","url":"https://api.github.com/users/thelollies","html_url":"https://github.com/thelollies","followers_url":"https://api.github.com/users/thelollies/followers","following_url":"https://api.github.com/users/thelollies/following{/other_user}","gists_url":"https://api.github.com/users/thelollies/gists{/gist_id}","starred_url":"https://api.github.com/users/thelollies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelollies/subscriptions","organizations_url":"https://api.github.com/users/thelollies/orgs","repos_url":"https://api.github.com/users/thelollies/repos","events_url":"https://api.github.com/users/thelollies/events{/privacy}","received_events_url":"https://api.github.com/users/thelollies/received_events","type":"User","site_admin":false},"labels":[{"id":118532499,"url":"https://api.github.com/repos/perfectapi/CKP/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-21T04:20:44Z","updated_at":"2016-11-30T02:53:02Z","closed_at":null,"body":"Firstly, thank you very much! I use this extension a lot and find it very useful.\n\nMy bank uses a workaround similar to this to prevent safari password autofill: http://stackoverflow.com/a/23016234/2086746\n\nThe variation they use is setting the background colour of the offending input to rgb( 0, 0, 0, 0 ), you can see it in action here: https://bank.westpac.co.nz/one/app.html#login (see the input with id \"fake-login-password\").\n\nWhen the autofill feature is used this extra hidden input field triggers this conditional: https://github.com/perfectapi/CKP/blob/0c4b2f172f3d1a0badff70f5e36d1dc562e0e444/keepass.js#L155 and the correctly-identified username and password fields are popped from `userPasswordPairs` since it thinks we are on a registration page.\n\nThere are a bunch of different ways this could be addressed (remove or add the option to disable the logic that checks if it is a registration page, try to detect fake password fields, etc) so I thought I'd open it up for discussion.\n"},"comment":{"url":"https://api.github.com/repos/perfectapi/CKP/issues/comments/263768378","html_url":"https://github.com/perfectapi/CKP/issues/104#issuecomment-263768378","issue_url":"https://api.github.com/repos/perfectapi/CKP/issues/104","id":263768378,"user":{"login":"DukeyToo","id":1268000,"avatar_url":"https://avatars.githubusercontent.com/u/1268000?v=3","gravatar_id":"","url":"https://api.github.com/users/DukeyToo","html_url":"https://github.com/DukeyToo","followers_url":"https://api.github.com/users/DukeyToo/followers","following_url":"https://api.github.com/users/DukeyToo/following{/other_user}","gists_url":"https://api.github.com/users/DukeyToo/gists{/gist_id}","starred_url":"https://api.github.com/users/DukeyToo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DukeyToo/subscriptions","organizations_url":"https://api.github.com/users/DukeyToo/orgs","repos_url":"https://api.github.com/users/DukeyToo/repos","events_url":"https://api.github.com/users/DukeyToo/events{/privacy}","received_events_url":"https://api.github.com/users/DukeyToo/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T02:53:02Z","updated_at":"2016-11-30T02:53:02Z","body":"Autofill is always going to have some scenarios that it doesn't support.  In my own usage, I also have a few, and I decided not to try to \"fix\" them, because it feels like a case of diminishing returns, and there is high risk of breaking some other scenario that already works.\r\n\r\nI do like your idea of adding options - that way, existing behavior could be preserved for those who want to keep it.  "}}
{"actor":{"display_login":"DukeyToo"}}