{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5699","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5699/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5699/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5699/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/5699","id":165772720,"number":5699,"title":"Map debug options in release mode","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Core%20GL","name":"Core GL","color":"b60205"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"207de5"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/macOS","name":"macOS","color":"333333"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/node","name":"node","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-15T12:05:16Z","updated_at":"2016-07-18T13:01:03Z","closed_at":null,"body":"We use map debug options mainly as a mechanism to inspect our rendering engine. This usually comes with additional overheads that potentially affects metrics like binary size and memory footprint - see #5555 as example. In light of this, I see two possibilities in which we could avoid exposing this in release mode:\r\n- Make all `MapDebugOptions` no-ops in release mode - this way we'd still have functions like `Map::setDebug` available in release mode to avoid any binary incompatibility, but their internal implementation would provoke no effects in the engine.\r\n- Do not expose `MapDebugOptions`, `Map::setDebug` and related public API functions in release mode - this adds extra complexity for platform-specific code that would also need to remove their related functions in release mode.\r\n\r\nI'm inclined to accept the former option due to its low complexity and maintenance - however I'd love to read your thoughts before proceeding with this.\r\n\r\n@mapbox/gl"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/233321471","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/5699#issuecomment-233321471","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5699","id":233321471,"user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T13:01:03Z","updated_at":"2016-07-18T13:01:03Z","body":"I believe we have general consensus to make both `overdraw` and `stencil clip` debug options no-ops in release mode. This is now being proposed in #5555."}}
{"actor":{"display_login":"brunoabinader"}}