{"action":"created","issue":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/1345","repository_url":"https://api.github.com/repos/NyxStudios/TShock","labels_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1345/labels{/name}","comments_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1345/comments","events_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1345/events","html_url":"https://github.com/NyxStudios/TShock/issues/1345","id":195995228,"number":1345,"title":"Fishing Quests","user":{"login":"Kirbyarm","id":2260600,"avatar_url":"https://avatars.githubusercontent.com/u/2260600?v=3","gravatar_id":"","url":"https://api.github.com/users/Kirbyarm","html_url":"https://github.com/Kirbyarm","followers_url":"https://api.github.com/users/Kirbyarm/followers","following_url":"https://api.github.com/users/Kirbyarm/following{/other_user}","gists_url":"https://api.github.com/users/Kirbyarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Kirbyarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kirbyarm/subscriptions","organizations_url":"https://api.github.com/users/Kirbyarm/orgs","repos_url":"https://api.github.com/users/Kirbyarm/repos","events_url":"https://api.github.com/users/Kirbyarm/events{/privacy}","received_events_url":"https://api.github.com/users/Kirbyarm/received_events","type":"User","site_admin":false},"labels":[{"id":179776198,"url":"https://api.github.com/repos/NyxStudios/TShock/labels/Needs%20Investigation","name":"Needs Investigation","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-16T07:11:11Z","updated_at":"2016-12-20T06:33:56Z","closed_at":null,"body":"This has been a major problem for TShock for about a year now. Fishing quests do not properly save or load to and from the database for server sided characters. Server sided characters and lockable chests are the primary reason I enjoy TShock, but it has the nasty side effect or ruining fishing by resetting everyone's quests to a seemingly random low number.\r\n\r\nQuests completed is a stat much like max health and max mana. It grants the angler hat, vest, pants, fuzzy carrot, and most importantly, the golden fishing rod (best rod in the game) at the 30th quest completed. But with this bug, requires not logging out of the server for 12 hours and successfully completing the quest every 24 minutes which is extremely inconvenient. Even if you did manage this, you'd be reset back to usually less than 10. The odds for you getting good prizes (like the three key required components for a Cell Phone, one of the best pre-hardmode items you can get in the game) increases dramatically after you've completed 50 and 100 quests... but if you're constantly mudstomped by the TShock bug you can never reliably get anywhere without resorting to cheating and spawning the prizes in for the players myself.\r\n\r\nIs this known and under investigation? Could anyone explain how (if at all) the TShock software saves and loads server sided fishing quests? (like does it only update the database every game day or something?). Any workaround I could inform my players of would be appreciated."},"comment":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/comments/268166864","html_url":"https://github.com/NyxStudios/TShock/issues/1345#issuecomment-268166864","issue_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1345","id":268166864,"user":{"login":"Kirbyarm","id":2260600,"avatar_url":"https://avatars.githubusercontent.com/u/2260600?v=3","gravatar_id":"","url":"https://api.github.com/users/Kirbyarm","html_url":"https://github.com/Kirbyarm","followers_url":"https://api.github.com/users/Kirbyarm/followers","following_url":"https://api.github.com/users/Kirbyarm/following{/other_user}","gists_url":"https://api.github.com/users/Kirbyarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Kirbyarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kirbyarm/subscriptions","organizations_url":"https://api.github.com/users/Kirbyarm/orgs","repos_url":"https://api.github.com/users/Kirbyarm/repos","events_url":"https://api.github.com/users/Kirbyarm/events{/privacy}","received_events_url":"https://api.github.com/users/Kirbyarm/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T06:33:56Z","updated_at":"2016-12-20T06:33:56Z","body":"Sort of. It doesn't seem to update the moment the quest is finished. It updates the database every time the database 'saves' which is whatever the auto-save interval is. If database shows 25 and you do one quest, it will show 26 on the next in-game morning at 4:30 AM.\r\n\r\nIt seems to save and track the number of completed quests accurately, the problem is loading from the database. When you join the TShock server or relog, it doesn't set the client's fishing quests number to what is in the database, it just ignores that and uses the client's player file. So TShock isn't setting the SSC quests number from the database."}}
{"actor":{"display_login":"Kirbyarm"}}