{"action":"created","comment":{"url":"https://api.github.com/repos/danpovey/pocolm/pulls/comments/74707285","id":74707285,"diff_hunk":"@@ -10,6 +10,15 @@ num_word=20000\n lm_dir=\"data/lm/\"\n arpa_dir=\"data/arpa/\"\n \n+max_memory='--max-memory=10G'\n+# If you do not want to set memory limitation for \"sort\", you can use\n+#max_memory=\n+# Choices for the max-memory can be:\n+# 1) integer + 'K', 'M', 'G', ... \n+# 2) integer + 'b', meaning using default unit byte and no multiplication\n+# 3) integer + '%', meaning a percentage of memory\n+# 4) integer, default unit is byte","path":"egs/swbd/run.sh","position":11,"original_position":11,"commit_id":"aa4fdf234ded24c172f6292c43e76dad480e8915","original_commit_id":"aa4fdf234ded24c172f6292c43e76dad480e8915","user":{"login":"keli78","id":13988170,"avatar_url":"https://avatars.githubusercontent.com/u/13988170?v=3","gravatar_id":"","url":"https://api.github.com/users/keli78","html_url":"https://github.com/keli78","followers_url":"https://api.github.com/users/keli78/followers","following_url":"https://api.github.com/users/keli78/following{/other_user}","gists_url":"https://api.github.com/users/keli78/gists{/gist_id}","starred_url":"https://api.github.com/users/keli78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keli78/subscriptions","organizations_url":"https://api.github.com/users/keli78/orgs","repos_url":"https://api.github.com/users/keli78/repos","events_url":"https://api.github.com/users/keli78/events{/privacy}","received_events_url":"https://api.github.com/users/keli78/received_events","type":"User","site_admin":false},"body":"Thanks for this reminder. I just modified it. Considering you have merged\nthe \"modify comments on unit for sort\" PR, my local branch is behind the\nremote one so I need to do a git pull.  I did \"git pull --rebase upstream\nmaster\" and then pushed my newest changes to the previous branch\nmax-memory. This is what you mean \"rebase your branch instead of merging\"\nright?\nKe\n\nOn Sun, Aug 14, 2016 at 2:20 PM, Daniel Povey <notifications@github.com>\nwrote:\n\n> In egs/swbd/run.sh\n> <https://github.com/danpovey/pocolm/pull/46#discussion_r74706263>:\n>\n> > @@ -10,6 +10,15 @@ num_word=20000\n> >  lm_dir=\"data/lm/\"\n> >  arpa_dir=\"data/arpa/\"\n> >\n> > +max_memory='--max-memory=10G'\n> > +# If you do not want to set memory limitation for \"sort\", you can use\n> > +#max_memory=\n> > +# Choices for the max-memory can be:\n> > +# 1) integer + 'K', 'M', 'G', ...\n> > +# 2) integer + 'b', meaning using default unit byte and no multiplication\n> > +# 3) integer + '%', meaning a percentage of memory\n> > +# 4) integer, default unit is byte\n>\n> Make sure that it's not just a question of the comments being wrong... I\n> assumed that the default units were bytes... I hope you didn't convert to\n> bytes when dividing by the num-jobs and forget to add the 'b' in the\n> option. Dan\n> … <#m_-6727304760913123093_>\n> On Sun, Aug 14, 2016 at 7:44 AM, Wang Jian ***@***.***> wrote: In\n> egs/swbd/run.sh <#46 (comment)\n> <https://github.com/danpovey/pocolm/pull/46#discussion_r74703004>>: > @@\n> -10,6 +10,15 @@ num_word=20000 > lm_dir=\"data/lm/\" > arpa_dir=\"data/arpa/\"\n> > > +max_memory='--max-memory=10G' > +# If you do not want to set memory\n> limitation for \"sort\", you can use > +#max_memory= > +# Choices for the\n> max-memory can be: > +# 1) integer + 'K', 'M', 'G', ... > +# 2) integer +\n> 'b', meaning using default unit byte and no multiplication > +# 3) integer\n> + '%', meaning a percentage of memory > +# 4) integer, default unit is byte\n> Hi @keli78 <https://github.com/keli78> <https://github.com/keli78>, I\n> read manual page of sort(1) just now, it says the default unit of\n> --buffer-size= is 'K' not 'b'. Please correct these lines of comment. — You\n> are receiving this because you modified the open/close state. Reply to this\n> email directly, view it on GitHub <https://github.com/danpovey/\n> pocolm/pull/46/files/aa4fdf234ded24c172f6292c43e76dad480e8915#r74703004>,\n> or mute the thread <https://github.com/notifications/unsubscribe-\n> auth/ADJVu-5hIwoMLhQiVhDqqZv8Isgm-c0cks5qfynWgaJpZM4JibxT> .\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/danpovey/pocolm/pull/46/files/aa4fdf234ded24c172f6292c43e76dad480e8915#r74706263>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ANVxSrBnn7GAyIk2SLvkYoMKoPufYhZXks5qf1xygaJpZM4JibxT>\n> .\n>\n\n\n\n-- \nKe Li\nDept. of Electrical and Computer Engineering\nJohns Hopkins University\nEmail: kli26@jhu.edu\n","created_at":"2016-08-14T19:41:04Z","updated_at":"2016-08-14T19:41:04Z","html_url":"https://github.com/danpovey/pocolm/pull/46#discussion_r74707285","pull_request_url":"https://api.github.com/repos/danpovey/pocolm/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/comments/74707285"},"html":{"href":"https://github.com/danpovey/pocolm/pull/46#discussion_r74707285"},"pull_request":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/danpovey/pocolm/pulls/46","id":81010739,"html_url":"https://github.com/danpovey/pocolm/pull/46","diff_url":"https://github.com/danpovey/pocolm/pull/46.diff","patch_url":"https://github.com/danpovey/pocolm/pull/46.patch","issue_url":"https://api.github.com/repos/danpovey/pocolm/issues/46","number":46,"state":"closed","locked":false,"title":"add max-memory option for 'sort'","user":{"login":"keli78","id":13988170,"avatar_url":"https://avatars.githubusercontent.com/u/13988170?v=3","gravatar_id":"","url":"https://api.github.com/users/keli78","html_url":"https://github.com/keli78","followers_url":"https://api.github.com/users/keli78/followers","following_url":"https://api.github.com/users/keli78/following{/other_user}","gists_url":"https://api.github.com/users/keli78/gists{/gist_id}","starred_url":"https://api.github.com/users/keli78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keli78/subscriptions","organizations_url":"https://api.github.com/users/keli78/orgs","repos_url":"https://api.github.com/users/keli78/repos","events_url":"https://api.github.com/users/keli78/events{/privacy}","received_events_url":"https://api.github.com/users/keli78/received_events","type":"User","site_admin":false},"body":"add memory limitation option for 'sort' in top-level interface train_lm.py and other scripts call 'sort'","created_at":"2016-08-11T18:54:29Z","updated_at":"2016-08-14T19:41:04Z","closed_at":"2016-08-14T04:40:37Z","merged_at":"2016-08-14T04:40:37Z","merge_commit_sha":"bbb29eebbb15fc821b98cbd08c50e0519a0212bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danpovey/pocolm/pulls/46/commits","review_comments_url":"https://api.github.com/repos/danpovey/pocolm/pulls/46/comments","review_comment_url":"https://api.github.com/repos/danpovey/pocolm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danpovey/pocolm/issues/46/comments","statuses_url":"https://api.github.com/repos/danpovey/pocolm/statuses/aa4fdf234ded24c172f6292c43e76dad480e8915","head":{"label":"keli78:max-memory","ref":"max-memory","sha":"aa4fdf234ded24c172f6292c43e76dad480e8915","user":{"login":"keli78","id":13988170,"avatar_url":"https://avatars.githubusercontent.com/u/13988170?v=3","gravatar_id":"","url":"https://api.github.com/users/keli78","html_url":"https://github.com/keli78","followers_url":"https://api.github.com/users/keli78/followers","following_url":"https://api.github.com/users/keli78/following{/other_user}","gists_url":"https://api.github.com/users/keli78/gists{/gist_id}","starred_url":"https://api.github.com/users/keli78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keli78/subscriptions","organizations_url":"https://api.github.com/users/keli78/orgs","repos_url":"https://api.github.com/users/keli78/repos","events_url":"https://api.github.com/users/keli78/events{/privacy}","received_events_url":"https://api.github.com/users/keli78/received_events","type":"User","site_admin":false},"repo":{"id":58991346,"name":"pocolm","full_name":"keli78/pocolm","owner":{"login":"keli78","id":13988170,"avatar_url":"https://avatars.githubusercontent.com/u/13988170?v=3","gravatar_id":"","url":"https://api.github.com/users/keli78","html_url":"https://github.com/keli78","followers_url":"https://api.github.com/users/keli78/followers","following_url":"https://api.github.com/users/keli78/following{/other_user}","gists_url":"https://api.github.com/users/keli78/gists{/gist_id}","starred_url":"https://api.github.com/users/keli78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keli78/subscriptions","organizations_url":"https://api.github.com/users/keli78/orgs","repos_url":"https://api.github.com/users/keli78/repos","events_url":"https://api.github.com/users/keli78/events{/privacy}","received_events_url":"https://api.github.com/users/keli78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keli78/pocolm","description":"Small language toolkit for creation, interpolation and pruning of ARPA language models","fork":true,"url":"https://api.github.com/repos/keli78/pocolm","forks_url":"https://api.github.com/repos/keli78/pocolm/forks","keys_url":"https://api.github.com/repos/keli78/pocolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keli78/pocolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keli78/pocolm/teams","hooks_url":"https://api.github.com/repos/keli78/pocolm/hooks","issue_events_url":"https://api.github.com/repos/keli78/pocolm/issues/events{/number}","events_url":"https://api.github.com/repos/keli78/pocolm/events","assignees_url":"https://api.github.com/repos/keli78/pocolm/assignees{/user}","branches_url":"https://api.github.com/repos/keli78/pocolm/branches{/branch}","tags_url":"https://api.github.com/repos/keli78/pocolm/tags","blobs_url":"https://api.github.com/repos/keli78/pocolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keli78/pocolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keli78/pocolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/keli78/pocolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keli78/pocolm/statuses/{sha}","languages_url":"https://api.github.com/repos/keli78/pocolm/languages","stargazers_url":"https://api.github.com/repos/keli78/pocolm/stargazers","contributors_url":"https://api.github.com/repos/keli78/pocolm/contributors","subscribers_url":"https://api.github.com/repos/keli78/pocolm/subscribers","subscription_url":"https://api.github.com/repos/keli78/pocolm/subscription","commits_url":"https://api.github.com/repos/keli78/pocolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/keli78/pocolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/keli78/pocolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/keli78/pocolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/keli78/pocolm/contents/{+path}","compare_url":"https://api.github.com/repos/keli78/pocolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keli78/pocolm/merges","archive_url":"https://api.github.com/repos/keli78/pocolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keli78/pocolm/downloads","issues_url":"https://api.github.com/repos/keli78/pocolm/issues{/number}","pulls_url":"https://api.github.com/repos/keli78/pocolm/pulls{/number}","milestones_url":"https://api.github.com/repos/keli78/pocolm/milestones{/number}","notifications_url":"https://api.github.com/repos/keli78/pocolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keli78/pocolm/labels{/name}","releases_url":"https://api.github.com/repos/keli78/pocolm/releases{/id}","deployments_url":"https://api.github.com/repos/keli78/pocolm/deployments","created_at":"2016-05-17T04:51:10Z","updated_at":"2016-05-17T04:51:11Z","pushed_at":"2016-08-14T19:29:30Z","git_url":"git://github.com/keli78/pocolm.git","ssh_url":"git@github.com:keli78/pocolm.git","clone_url":"https://github.com/keli78/pocolm.git","svn_url":"https://github.com/keli78/pocolm","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danpovey:master","ref":"master","sha":"c24642ade3a84d903912b086256a9b6941f19996","user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"repo":{"id":56359219,"name":"pocolm","full_name":"danpovey/pocolm","owner":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danpovey/pocolm","description":"Small language toolkit for creation, interpolation and pruning of ARPA language models","fork":false,"url":"https://api.github.com/repos/danpovey/pocolm","forks_url":"https://api.github.com/repos/danpovey/pocolm/forks","keys_url":"https://api.github.com/repos/danpovey/pocolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danpovey/pocolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danpovey/pocolm/teams","hooks_url":"https://api.github.com/repos/danpovey/pocolm/hooks","issue_events_url":"https://api.github.com/repos/danpovey/pocolm/issues/events{/number}","events_url":"https://api.github.com/repos/danpovey/pocolm/events","assignees_url":"https://api.github.com/repos/danpovey/pocolm/assignees{/user}","branches_url":"https://api.github.com/repos/danpovey/pocolm/branches{/branch}","tags_url":"https://api.github.com/repos/danpovey/pocolm/tags","blobs_url":"https://api.github.com/repos/danpovey/pocolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danpovey/pocolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danpovey/pocolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/danpovey/pocolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danpovey/pocolm/statuses/{sha}","languages_url":"https://api.github.com/repos/danpovey/pocolm/languages","stargazers_url":"https://api.github.com/repos/danpovey/pocolm/stargazers","contributors_url":"https://api.github.com/repos/danpovey/pocolm/contributors","subscribers_url":"https://api.github.com/repos/danpovey/pocolm/subscribers","subscription_url":"https://api.github.com/repos/danpovey/pocolm/subscription","commits_url":"https://api.github.com/repos/danpovey/pocolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/danpovey/pocolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/danpovey/pocolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/danpovey/pocolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/danpovey/pocolm/contents/{+path}","compare_url":"https://api.github.com/repos/danpovey/pocolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danpovey/pocolm/merges","archive_url":"https://api.github.com/repos/danpovey/pocolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danpovey/pocolm/downloads","issues_url":"https://api.github.com/repos/danpovey/pocolm/issues{/number}","pulls_url":"https://api.github.com/repos/danpovey/pocolm/pulls{/number}","milestones_url":"https://api.github.com/repos/danpovey/pocolm/milestones{/number}","notifications_url":"https://api.github.com/repos/danpovey/pocolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danpovey/pocolm/labels{/name}","releases_url":"https://api.github.com/repos/danpovey/pocolm/releases{/id}","deployments_url":"https://api.github.com/repos/danpovey/pocolm/deployments","created_at":"2016-04-16T01:24:14Z","updated_at":"2016-07-16T16:27:05Z","pushed_at":"2016-08-14T19:38:26Z","git_url":"git://github.com/danpovey/pocolm.git","ssh_url":"git@github.com:danpovey/pocolm.git","clone_url":"https://github.com/danpovey/pocolm.git","svn_url":"https://github.com/danpovey/pocolm","homepage":null,"size":501,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/46"},"html":{"href":"https://github.com/danpovey/pocolm/pull/46"},"issue":{"href":"https://api.github.com/repos/danpovey/pocolm/issues/46"},"comments":{"href":"https://api.github.com/repos/danpovey/pocolm/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danpovey/pocolm/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/danpovey/pocolm/statuses/aa4fdf234ded24c172f6292c43e76dad480e8915"}}}}
{"actor":{"display_login":"keli78"}}