{"action":"created","issue":{"url":"https://api.github.com/repos/plv8/plv8/issues/177","repository_url":"https://api.github.com/repos/plv8/plv8","labels_url":"https://api.github.com/repos/plv8/plv8/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/plv8/plv8/issues/177/comments","events_url":"https://api.github.com/repos/plv8/plv8/issues/177/events","html_url":"https://github.com/plv8/plv8/pull/177","id":150500250,"number":177,"title":"Use latest V8 5.1 branch head","user":{"login":"ruimarinho","id":288709,"avatar_url":"https://avatars.githubusercontent.com/u/288709?v=3","gravatar_id":"","url":"https://api.github.com/users/ruimarinho","html_url":"https://github.com/ruimarinho","followers_url":"https://api.github.com/users/ruimarinho/followers","following_url":"https://api.github.com/users/ruimarinho/following{/other_user}","gists_url":"https://api.github.com/users/ruimarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ruimarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruimarinho/subscriptions","organizations_url":"https://api.github.com/users/ruimarinho/orgs","repos_url":"https://api.github.com/users/ruimarinho/repos","events_url":"https://api.github.com/users/ruimarinho/events{/privacy}","received_events_url":"https://api.github.com/users/ruimarinho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-23T00:27:44Z","updated_at":"2016-04-23T01:03:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/plv8/plv8/pulls/177","html_url":"https://github.com/plv8/plv8/pull/177","diff_url":"https://github.com/plv8/plv8/pull/177.diff","patch_url":"https://github.com/plv8/plv8/pull/177.patch"},"body":"Deprecates https://github.com/plv8/plv8/pull/175.\r\n\r\nUpdate to the latest V8 5.1 branch head (5.0.71.34 also worked fine). \r\n\r\n*5.0.71.34*\r\n\r\n```\r\n❯ make installcheck\r\n\r\n/usr/local/Cellar/postgresql-9.4/9.4.7/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --psqldir='/usr/local/Cellar/postgresql-9.4/9.4.7/bin'    --dbname=contrib_regression init-extension plv8 plv8-errors inline json startup_pre startup varparam json_conv jsonb_conv window guc es6 arraybuffer composites currentresource dialect\r\n(using postmaster on Unix socket, default port)\r\n============== dropping database \"contrib_regression\" ==============\r\nDROP DATABASE\r\n============== creating database \"contrib_regression\" ==============\r\nCREATE DATABASE\r\nALTER DATABASE\r\n============== running regression test queries        ==============\r\ntest init-extension           ... ok\r\ntest plv8                     ... ok\r\ntest plv8-errors              ... ok\r\ntest inline                   ... ok\r\ntest json                     ... ok\r\ntest startup_pre              ... ok\r\ntest startup                  ... ok\r\ntest varparam                 ... ok\r\ntest json_conv                ... ok\r\ntest jsonb_conv               ... ok\r\ntest window                   ... ok\r\ntest guc                      ... ok\r\ntest es6                      ... ok\r\ntest arraybuffer              ... ok\r\ntest composites               ... ok\r\ntest currentresource          ... ok\r\ntest dialect                  ... ok\r\n\r\n======================\r\n All 17 tests passed.\r\n======================\r\n```\r\n\r\n*5.1.281.14*\r\n\r\n```\r\n❯ make installcheck\r\n\r\n/usr/local/Cellar/postgresql-9.4/9.4.7/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --psqldir='/usr/local/Cellar/postgresql-9.4/9.4.7/bin'    --dbname=contrib_regression init-extension plv8 plv8-errors inline json startup_pre startup varparam json_conv jsonb_conv window guc es6 arraybuffer composites currentresource dialect\r\n(using postmaster on Unix socket, default port)\r\n============== dropping database \"contrib_regression\" ==============\r\nNOTICE:  database \"contrib_regression\" does not exist, skipping\r\nDROP DATABASE\r\n============== creating database \"contrib_regression\" ==============\r\nCREATE DATABASE\r\nALTER DATABASE\r\n============== running regression test queries        ==============\r\ntest init-extension           ... ok\r\ntest plv8                     ... ok\r\ntest plv8-errors              ... ok\r\ntest inline                   ... ok\r\ntest json                     ... ok\r\ntest startup_pre              ... ok\r\ntest startup                  ... ok\r\ntest varparam                 ... ok\r\ntest json_conv                ... ok\r\ntest jsonb_conv               ... ok\r\ntest window                   ... ok\r\ntest guc                      ... ok\r\ntest es6                      ... ok\r\ntest arraybuffer              ... ok\r\ntest composites               ... ok\r\ntest currentresource          ... ok\r\ntest dialect                  ... ok\r\n\r\n======================\r\n All 17 tests passed.\r\n======================\r\n```\r\n\r\nAlso updated travis.yml to use known branch heads instead of the latest tag available."},"comment":{"url":"https://api.github.com/repos/plv8/plv8/issues/comments/213642346","html_url":"https://github.com/plv8/plv8/pull/177#issuecomment-213642346","issue_url":"https://api.github.com/repos/plv8/plv8/issues/177","id":213642346,"user":{"login":"ruimarinho","id":288709,"avatar_url":"https://avatars.githubusercontent.com/u/288709?v=3","gravatar_id":"","url":"https://api.github.com/users/ruimarinho","html_url":"https://github.com/ruimarinho","followers_url":"https://api.github.com/users/ruimarinho/followers","following_url":"https://api.github.com/users/ruimarinho/following{/other_user}","gists_url":"https://api.github.com/users/ruimarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ruimarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruimarinho/subscriptions","organizations_url":"https://api.github.com/users/ruimarinho/orgs","repos_url":"https://api.github.com/users/ruimarinho/repos","events_url":"https://api.github.com/users/ruimarinho/events{/privacy}","received_events_url":"https://api.github.com/users/ruimarinho/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T01:03:21Z","updated_at":"2016-04-23T01:03:21Z","body":"@JerrySievert looks like V8 5.1 changed the error string from `SyntaxError: Unexpected token ILLEGAL` to `SyntaxError: Unexpected token ILLEGAL` to `SyntaxError: Invalid or unexpected token`.\r\n\r\nTime to make expected sql files conditional?"}}