{"push_id":1211521158,"size":38,"distinct_size":11,"ref":"refs/heads/review","head":"1867342b99de365facdbe256c2bb1886e4dd8f27","before":"d6ff369d0f246b2b3222e990cb4f65ce59b8f1ef","commits":[{"sha":"6fe2eb2458b5e4b84f5aede6d3fdf3ae47c0cd02","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachHostSCSIDevice\n\nBased on recent review comment - rather than have a spate of goto failxxxx,\nchange to a boolean based model. Ensures that the original error can be\npreserved and cleanup is a bit more orderly if more objects are added.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/6fe2eb2458b5e4b84f5aede6d3fdf3ae47c0cd02"},{"sha":"a7f84cb1ee037c2ea6c803450eb692d8030b4227","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachVirtioDiskDevice\n\nBased on recent review comment - rather than have a spate of goto failxxxx,\nchange to a boolean based model. Ensures that the original error can be\npreserved and cleanup is a bit more orderly if more objects are added.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/a7f84cb1ee037c2ea6c803450eb692d8030b4227"},{"sha":"c3b5f22dec05389a8a164761976d4aa64d4c399f","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachSCSIDisk\n\nBased on recent review comment - rather than have a spate of goto failxxxx,\nchange to a boolean based model. Ensures that the original error can be\npreserved and cleanup is a bit more orderly if more objects are added.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/c3b5f22dec05389a8a164761976d4aa64d4c399f"},{"sha":"05bc30d2bba8e7074e5bd1888c082edb567e07d0","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachChrDevice\n\nBased on recent review comment - rather than have a spate of goto failxxxx,\nchange to a boolean based model. Ensures that the original error can be\npreserved and cleanup is a bit more orderly if more objects are added.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/05bc30d2bba8e7074e5bd1888c082edb567e07d0"},{"sha":"47208776be883ae8e55ea95a7673b47fe112c51f","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachRNGDevice\n\nBased on recent review comment - rather than have a spate of goto failxxxx,\nchange to a boolean based model. Ensures that the original error can be\npreserved and cleanup is a bit more orderly if more objects are added.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/47208776be883ae8e55ea95a7673b47fe112c51f"},{"sha":"99026fd0ad4fb962cc1c95c9a310ee7af79788ae","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter error path cleanup for qemuDomainAttachMemory\n\nA recent adjustment to qemuDomainAttachRNGDevice to properly cleanup\nthe props object after a qemuMonitorAddObject also would affect this\ncode. Alter the cleanup to be similar to RNG changes.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/99026fd0ad4fb962cc1c95c9a310ee7af79788ae"},{"sha":"8215aab0036e65da47a2646f85749e9f5ea5d252","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Move and rename qemuBufferEscapeComma\n\nMove to virqemu and rename to virQEMUBuildBufferEscapeComma. This can then\nbe shared by the storage driver when it builds the command line for qemuimg","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/8215aab0036e65da47a2646f85749e9f5ea5d252"},{"sha":"a8962f705d5b7973e322b81c38e46eb542cb1ad4","author":{"name":"Erik Skultety","email":"98031ce1a99dbd0d2aa0a4d790e6d42553acae27@redhat.com"},"message":"virt-admin: Output srv-threadpool-info data as unsigned int rather than signed\n\nInternally, all the data are represented as unsigned int, it is also documented\nin the header file that users should use our exported constants that also\nindicate that the data should be unsigned int. However, when polling for the\ncurrent server threadpool's configuration, virt-admin uses an incorrect\nformatting parameter '%d' for printf. Instead, virt-admin should use formatting\nparameter '%u'.\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1356769\n\nSigned-off-by: Erik Skultety <eskultet@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/a8962f705d5b7973e322b81c38e46eb542cb1ad4"},{"sha":"fee696b6e8f932c7160bc09c8c1d23383b87138a","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"util: Fix incorrect VIR_FREE in virConfGetValueStringList\n\nSince we VIR_ALLOC_N to *values, the VIR_FREE should be done likewise\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/fee696b6e8f932c7160bc09c8c1d23383b87138a"},{"sha":"dfb18b0afbb040a496ddce1f224176a97f8a5667","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"tools: Fix comparison in virLoginShellGetShellArgv\n\nCommit id '740e4d70' altered the logic to fetch the sysconf values and\nadded a new virConfGetValueStringList which returns -1 on failure, 0 if\nmissing, and 1 if the value was present.\n\nHowever, the caller only checked !shargv which caught Coverity's attention\nsince the following VIR_ALLOC_N(*shargv, 2) would be a NULL ptr deref\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/dfb18b0afbb040a496ddce1f224176a97f8a5667"},{"sha":"5ddaa7ef2d8fd78b95f4d6595f972c6462eaafd3","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"tests: Need to check return of virGetLastError\n\nCannot assume virGetLastError returns non-NULL value - modify the code to\nfetch err and check if err && err->code\n\nFound by Coverity\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/5ddaa7ef2d8fd78b95f4d6595f972c6462eaafd3"},{"sha":"7ca6cd7def2fbbd4308842cf4222fde7891d2987","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"conf: Need to check for glisten before accessing\n\nWhen formatting the graphics data for TYPE_SPICE, check if the glisten\nis NULL before blindly referencing\n\nFound by Coverity\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/7ca6cd7def2fbbd4308842cf4222fde7891d2987"},{"sha":"bd93ba64fdb899c2d581ab7506542f9663d21ffb","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"vsh: Properly initialize res\n\nThe 'res' variable was only being initialized to NULL in the\nif (!state) path; however, that path never used res and evenutally\nres is assigned one of two results based on a pair of if then else if\nconditions. If for some reason neither of those paths was taken and\nthe (!state) path wasn't taken, then 'res' would be indeterminate.\n\nFound by Coverity, probably a false positive based on code paths, but\nbetter safe than sorry for the future.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/bd93ba64fdb899c2d581ab7506542f9663d21ffb"},{"sha":"5e46d7d6b693c1e3c9197c182302ac7125a856d9","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"storage: Add support to create a luks volume\n\nPartially resolves:\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1301021\n\nIf the volume xml was looking to create a luks volume take the necessary\nsteps in order to make that happen.\n\nThe processing will be:\n 1. create a temporary file (virStorageBackendCreateQemuImgSecretPath)\n   1a. use the storage driver state dir path that uses the pool and\n       volume name as a base.\n\n 2. create a secret object (virStorageBackendCreateQemuImgSecretObject)\n   2a. use an alias combinding the volume name and \"_luks0\"\n   2b. add the file to the object\n\n 3. create/add luks options to the commandline (virQEMUBuildLuksOpts)\n   3a. at the very least a \"key-secret=%s\" using the secret object alias\n   3b. if found in the XML the various \"cipher\" and \"ivgen\" options\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/5e46d7d6b693c1e3c9197c182302ac7125a856d9"},{"sha":"fceeeda2115bcb86b992c4add38704a886c099c8","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Add secinfo for hotplug virtio disk\n\nCommit id 'a1344f70a' added AES secret processing for RBD when starting\nup a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare\nan AES secret could be added to the disk about to be hotplugged. If an AES\nsecret was added, then the hotplug code would need to generate the secret\nobject because qemuBuildDriveStr would add the \"password-secret=\" to the\nreturned 'driveStr' rather than the base64 encoded password.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/fceeeda2115bcb86b992c4add38704a886c099c8"},{"sha":"b7b3a51e8ab7c95b7ffab6b8d727338d71c37c55","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Alter the qemuDomainGetSecretAESAlias to add new arg\n\nSoon we will be adding luks encryption support. Since a volume could require\nboth a luks secret and a secret to give to the server to use of the device,\nalter the alias generation to create a slightly different alias so that\nwe don't have two objects with the same alias.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/b7b3a51e8ab7c95b7ffab6b8d727338d71c37c55"},{"sha":"da86c6c22674ccc147224afa2740e33d8cbdbf22","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Add luks support for domain disk\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021\n\nGenerate the luks command line using the AES secret key to encrypt the\nluks secret. A luks secret object will be in addition to a an AES secret.\n\nFor hotplug, check if the encinfo exists and if so, add the AES secret\nfor the passphrase for the secret object used to decrypt the device.\n\nModify/augment the fakeSecret* in qemuxml2argvtest in order to handle\nfind a uuid or a volume usage with a specific path prefix in the XML\n(corresponds to the already generated XML tests). Add error message\nwhen the 'usageID' is not 'mycluster_myname'. Commit id '1d632c39'\naltered the error message generation to rely on the errors from the\nsecret_driver (or it's faked replacement).\n\nAdd the .args output for adding the LUKS disk to the domain\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/da86c6c22674ccc147224afa2740e33d8cbdbf22"},{"sha":"cedd2ab28262db62976b351dbf2a0f8d9f88ca9e","author":{"name":"Cédric Bosdonnat","email":"a37af6b5c72cbfe05bb0466e63b2605bb9242c50@suse.com"},"message":"virt-aa-helper: better write denials handling\n\nBetter fix replacing c726af2d: introducing an 'R' permission to\nadd read rule, but no explicit deny write rule.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/cedd2ab28262db62976b351dbf2a0f8d9f88ca9e"},{"sha":"8ee6a99e7c2b31e7f3cdeabf59e211854da26f5d","author":{"name":"Cédric Bosdonnat","email":"a37af6b5c72cbfe05bb0466e63b2605bb9242c50@suse.com"},"message":"lxc: errors after the handshake won't be reported\n\nAny error happening after the hand shake in the lxc controller\nwill not result in a failure as errors are checked during the handshake.\nMove the handshake after the last possible error.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/8ee6a99e7c2b31e7f3cdeabf59e211854da26f5d"},{"sha":"ad9e72f5fa118d97abe60a0ea6e5dba195476fc7","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"hvsupport: use a regex instead of XML::XPath\n\nWhen generating the hvsupport.html.in file, we parse the -api.xml\nfiles generated by apibuild.py to know in which HTML file the API\nfunction is.\n\nDoing an XPath query for every single 'function' element in the\nfile is inefficient.\n\nSince the XML file is generated by another of our build scripts\n(apibuild.py, using Python's standard 'output.write' XML library),\njust find the function name->file mapping by a regex upfront.\n\nAlso add a note about this next to the line that generates it\nin apibuild.py and do not check if XML::XPath is installed in\nbootstrap since we no longer use it.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/ad9e72f5fa118d97abe60a0ea6e5dba195476fc7"}]}
{"actor":{"display_login":"nertpinx"}}