{"action":"created","issue":{"url":"https://api.github.com/repos/mawww/kakoune/issues/581","repository_url":"https://api.github.com/repos/mawww/kakoune","labels_url":"https://api.github.com/repos/mawww/kakoune/issues/581/labels{/name}","comments_url":"https://api.github.com/repos/mawww/kakoune/issues/581/comments","events_url":"https://api.github.com/repos/mawww/kakoune/issues/581/events","html_url":"https://github.com/mawww/kakoune/pull/581","id":131980223,"number":581,"title":"Update rust.kak to post-1.0 rust","user":{"login":"occivink","id":5473453,"avatar_url":"https://avatars.githubusercontent.com/u/5473453?v=3","gravatar_id":"","url":"https://api.github.com/users/occivink","html_url":"https://github.com/occivink","followers_url":"https://api.github.com/users/occivink/followers","following_url":"https://api.github.com/users/occivink/following{/other_user}","gists_url":"https://api.github.com/users/occivink/gists{/gist_id}","starred_url":"https://api.github.com/users/occivink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occivink/subscriptions","organizations_url":"https://api.github.com/users/occivink/orgs","repos_url":"https://api.github.com/users/occivink/repos","events_url":"https://api.github.com/users/occivink/events{/privacy}","received_events_url":"https://api.github.com/users/occivink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-07T16:03:49Z","updated_at":"2016-02-07T18:45:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mawww/kakoune/pulls/581","html_url":"https://github.com/mawww/kakoune/pull/581","diff_url":"https://github.com/mawww/kakoune/pull/581.diff","patch_url":"https://github.com/mawww/kakoune/pull/581.patch"},"body":"Hi,\r\nThe rust syntax highlighting was quite outdated and predated the 1.0 release so I've cleaned it up a bit.\r\nI've considered adding highlighters for basic types from the standard library (Option, Result, Vec...)\r\nbut it got a bit too colorful, and it seems like you don't usually highlight things related to standard library so I've left it out.\r\nThe number literals regex has one false negative that I know of, which are the float ending in '.' (so '1.' or '01_.') but I suppose it's acceptable. The word boundary matching makes this awkward to handle.\r\nI've removed a *lot* from the 'identifier' group, but it contained a lot of unrelated things (which were also not identifiers) and it didn't provide much value in my opinion.\r\nSince @alexherbo2 introduced this and @jkonecny12 also committed to it, I would like to have their input."},"comment":{"url":"https://api.github.com/repos/mawww/kakoune/issues/comments/181077088","html_url":"https://github.com/mawww/kakoune/pull/581#issuecomment-181077088","issue_url":"https://api.github.com/repos/mawww/kakoune/issues/581","id":181077088,"user":{"login":"FreeFull","id":1496908,"avatar_url":"https://avatars.githubusercontent.com/u/1496908?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeFull","html_url":"https://github.com/FreeFull","followers_url":"https://api.github.com/users/FreeFull/followers","following_url":"https://api.github.com/users/FreeFull/following{/other_user}","gists_url":"https://api.github.com/users/FreeFull/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeFull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeFull/subscriptions","organizations_url":"https://api.github.com/users/FreeFull/orgs","repos_url":"https://api.github.com/users/FreeFull/repos","events_url":"https://api.github.com/users/FreeFull/events{/privacy}","received_events_url":"https://api.github.com/users/FreeFull/received_events","type":"User","site_admin":false},"created_at":"2016-02-07T18:45:41Z","updated_at":"2016-02-07T18:45:41Z","body":"I haven't actually seen any Rust code that makes use of `1.` instead of `1.0`. I actually thought it wasn't even valid syntax until I tested it in the playpen just now. Judging by this, the limitation of the regex shouldn't prove to be much trouble in practice."}}