{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/93316187","pull_request_review_id":13841404,"id":93316187,"diff_hunk":"@@ -491,16 +496,31 @@ impl XMLHttpRequestMethods for XMLHttpRequest {\n             _ => data\n         };\n         // Step 4 (first half)\n-        let extracted = data.as_ref().map(|d| d.extract());\n+        let extracted_or_serialized = match data {\n+            Some(DocumentOrBodyInit::Document(ref doc)) => {\n+                let data = Vec::from(serialize_document(&doc).unwrap().as_ref());","path":"components/script/dom/xmlhttprequest.rs","position":55,"original_position":55,"commit_id":"f62ae44c1489fb11469f33145e765fc1ab46bd9d","original_commit_id":"f62ae44c1489fb11469f33145e765fc1ab46bd9d","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"body":"got it.","created_at":"2016-12-20T20:14:52Z","updated_at":"2016-12-20T20:14:52Z","html_url":"https://github.com/servo/servo/pull/14648#discussion_r93316187","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/14648","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/93316187"},"html":{"href":"https://github.com/servo/servo/pull/14648#discussion_r93316187"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/14648"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14648","id":98808214,"html_url":"https://github.com/servo/servo/pull/14648","diff_url":"https://github.com/servo/servo/pull/14648.diff","patch_url":"https://github.com/servo/servo/pull/14648.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/14648","number":14648,"state":"open","locked":false,"title":"Implemented XMLHttpRequest.send(Document)","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #9490 .\r\n\r\n<!-- Either: -->\r\nr? @KiChjang \r\n\r\n`XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output:\r\n```\r\n$ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm\r\nRunning 1 tests in web-platform-tests\r\n\r\nRan 1 tests finished in 0.0 seconds.\r\n  • 1 ran as expected. 1 tests skipped.\r\n```\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14648)\n<!-- Reviewable:end -->\n","created_at":"2016-12-20T19:15:12Z","updated_at":"2016-12-20T20:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59c4a55bd8b5a41307ebb70e46879ba833a6fab1","assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"assignees":[{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/14648/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/14648/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/14648/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/f62ae44c1489fb11469f33145e765fc1ab46bd9d","head":{"label":"cynicaldevil:xmlhttpreq-send","ref":"xmlhttpreq-send","sha":"f62ae44c1489fb11469f33145e765fc1ab46bd9d","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"repo":{"id":62301714,"name":"servo","full_name":"cynicaldevil/servo","owner":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cynicaldevil/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/cynicaldevil/servo","forks_url":"https://api.github.com/repos/cynicaldevil/servo/forks","keys_url":"https://api.github.com/repos/cynicaldevil/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cynicaldevil/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cynicaldevil/servo/teams","hooks_url":"https://api.github.com/repos/cynicaldevil/servo/hooks","issue_events_url":"https://api.github.com/repos/cynicaldevil/servo/issues/events{/number}","events_url":"https://api.github.com/repos/cynicaldevil/servo/events","assignees_url":"https://api.github.com/repos/cynicaldevil/servo/assignees{/user}","branches_url":"https://api.github.com/repos/cynicaldevil/servo/branches{/branch}","tags_url":"https://api.github.com/repos/cynicaldevil/servo/tags","blobs_url":"https://api.github.com/repos/cynicaldevil/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cynicaldevil/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cynicaldevil/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/cynicaldevil/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cynicaldevil/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/cynicaldevil/servo/languages","stargazers_url":"https://api.github.com/repos/cynicaldevil/servo/stargazers","contributors_url":"https://api.github.com/repos/cynicaldevil/servo/contributors","subscribers_url":"https://api.github.com/repos/cynicaldevil/servo/subscribers","subscription_url":"https://api.github.com/repos/cynicaldevil/servo/subscription","commits_url":"https://api.github.com/repos/cynicaldevil/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/cynicaldevil/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/cynicaldevil/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/cynicaldevil/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/cynicaldevil/servo/contents/{+path}","compare_url":"https://api.github.com/repos/cynicaldevil/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cynicaldevil/servo/merges","archive_url":"https://api.github.com/repos/cynicaldevil/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cynicaldevil/servo/downloads","issues_url":"https://api.github.com/repos/cynicaldevil/servo/issues{/number}","pulls_url":"https://api.github.com/repos/cynicaldevil/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/cynicaldevil/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/cynicaldevil/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cynicaldevil/servo/labels{/name}","releases_url":"https://api.github.com/repos/cynicaldevil/servo/releases{/id}","deployments_url":"https://api.github.com/repos/cynicaldevil/servo/deployments","created_at":"2016-06-30T10:19:15Z","updated_at":"2016-06-30T09:18:38Z","pushed_at":"2016-12-20T19:10:15Z","git_url":"git://github.com/cynicaldevil/servo.git","ssh_url":"git@github.com:cynicaldevil/servo.git","clone_url":"https://github.com/cynicaldevil/servo.git","svn_url":"https://github.com/cynicaldevil/servo","homepage":"https://servo.org/","size":223032,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"fd5733fc1e5cda952e8d68783d4053fe4ae66eb1","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-12-20T16:49:42Z","pushed_at":"2016-12-20T19:58:59Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":276273,"stargazers_count":8437,"watchers_count":8437,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1392,"mirror_url":null,"open_issues_count":1935,"forks":1392,"open_issues":1935,"watchers":8437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/14648"},"html":{"href":"https://github.com/servo/servo/pull/14648"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/14648"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/14648/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/14648/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/14648/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/f62ae44c1489fb11469f33145e765fc1ab46bd9d"}}}}
{"actor":{"display_login":"cynicaldevil"}}