{"action":"created","comment":{"url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments/54189037","id":54189037,"diff_hunk":"@@ -167,7 +169,11 @@\n         }\n \n         // Write an image of format <format> to STDOUT\n-        args.push(format + \":-\");\n+        if (format === \"jpg\" && useFlite && settings.useOptimalJPEG) {","path":"lib/convert.js","position":16,"original_position":16,"commit_id":"0bccd5fab866f2fa567d79e7505edb3a4b0c27ed","original_commit_id":"0bccd5fab866f2fa567d79e7505edb3a4b0c27ed","user":{"login":"pineapplespatula","id":1008531,"avatar_url":"https://avatars.githubusercontent.com/u/1008531?v=3","gravatar_id":"","url":"https://api.github.com/users/pineapplespatula","html_url":"https://github.com/pineapplespatula","followers_url":"https://api.github.com/users/pineapplespatula/followers","following_url":"https://api.github.com/users/pineapplespatula/following{/other_user}","gists_url":"https://api.github.com/users/pineapplespatula/gists{/gist_id}","starred_url":"https://api.github.com/users/pineapplespatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineapplespatula/subscriptions","organizations_url":"https://api.github.com/users/pineapplespatula/orgs","repos_url":"https://api.github.com/users/pineapplespatula/repos","events_url":"https://api.github.com/users/pineapplespatula/events{/privacy}","received_events_url":"https://api.github.com/users/pineapplespatula/received_events","type":"User","site_admin":false},"body":"currently Save for web just enabled optimal or not, do you think we would want \r\n\r\njpg:encode-fast or,\r\njpg:encode-precomputed\r\n\r\n( I assume, perhaps incorrectly that the other option jpg:encode-default is the same as jpeg:- )","created_at":"2016-02-26T00:33:24Z","updated_at":"2016-02-26T00:33:24Z","html_url":"https://github.com/adobe-photoshop/generator-core/pull/334#discussion_r54189037","pull_request_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments/54189037"},"html":{"href":"https://github.com/adobe-photoshop/generator-core/pull/334#discussion_r54189037"},"pull_request":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334","id":60762620,"html_url":"https://github.com/adobe-photoshop/generator-core/pull/334","diff_url":"https://github.com/adobe-photoshop/generator-core/pull/334.diff","patch_url":"https://github.com/adobe-photoshop/generator-core/pull/334.patch","issue_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/334","number":334,"state":"open","locked":false,"title":"add optimal encoding to jpg files","user":{"login":"pineapplespatula","id":1008531,"avatar_url":"https://avatars.githubusercontent.com/u/1008531?v=3","gravatar_id":"","url":"https://api.github.com/users/pineapplespatula","html_url":"https://github.com/pineapplespatula","followers_url":"https://api.github.com/users/pineapplespatula/followers","following_url":"https://api.github.com/users/pineapplespatula/following{/other_user}","gists_url":"https://api.github.com/users/pineapplespatula/gists{/gist_id}","starred_url":"https://api.github.com/users/pineapplespatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineapplespatula/subscriptions","organizations_url":"https://api.github.com/users/pineapplespatula/orgs","repos_url":"https://api.github.com/users/pineapplespatula/repos","events_url":"https://api.github.com/users/pineapplespatula/events{/privacy}","received_events_url":"https://api.github.com/users/pineapplespatula/received_events","type":"User","site_admin":false},"body":"requires https://github.com/adobe-photoshop/generator-assets/pull/396","created_at":"2016-02-25T22:56:53Z","updated_at":"2016-02-26T00:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a123eb2ee99b310950781e1ee4f406116976ee8","assignee":{"login":"pineapplespatula","id":1008531,"avatar_url":"https://avatars.githubusercontent.com/u/1008531?v=3","gravatar_id":"","url":"https://api.github.com/users/pineapplespatula","html_url":"https://github.com/pineapplespatula","followers_url":"https://api.github.com/users/pineapplespatula/followers","following_url":"https://api.github.com/users/pineapplespatula/following{/other_user}","gists_url":"https://api.github.com/users/pineapplespatula/gists{/gist_id}","starred_url":"https://api.github.com/users/pineapplespatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineapplespatula/subscriptions","organizations_url":"https://api.github.com/users/pineapplespatula/orgs","repos_url":"https://api.github.com/users/pineapplespatula/repos","events_url":"https://api.github.com/users/pineapplespatula/events{/privacy}","received_events_url":"https://api.github.com/users/pineapplespatula/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334/commits","review_comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334/comments","review_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/334/comments","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/0bccd5fab866f2fa567d79e7505edb3a4b0c27ed","head":{"label":"adobe-photoshop:jecohen/jpg-encoding","ref":"jecohen/jpg-encoding","sha":"0bccd5fab866f2fa567d79e7505edb3a4b0c27ed","user":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"repo":{"id":10320928,"name":"generator-core","full_name":"adobe-photoshop/generator-core","owner":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-photoshop/generator-core","description":"Core Node.js library for Adobe Photoshop CC's Generator extensibility layer","fork":false,"url":"https://api.github.com/repos/adobe-photoshop/generator-core","forks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/forks","keys_url":"https://api.github.com/repos/adobe-photoshop/generator-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-photoshop/generator-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-photoshop/generator-core/teams","hooks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/hooks","issue_events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/events","assignees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-photoshop/generator-core/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/tags","blobs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-photoshop/generator-core/languages","stargazers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/stargazers","contributors_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contributors","subscribers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscribers","subscription_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscription","commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-photoshop/generator-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-photoshop/generator-core/merges","archive_url":"https://api.github.com/repos/adobe-photoshop/generator-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-photoshop/generator-core/downloads","issues_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-photoshop/generator-core/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-photoshop/generator-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-photoshop/generator-core/labels{/name}","releases_url":"https://api.github.com/repos/adobe-photoshop/generator-core/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/deployments","created_at":"2013-05-27T19:10:52Z","updated_at":"2016-02-24T18:16:56Z","pushed_at":"2016-02-25T23:20:21Z","git_url":"git://github.com/adobe-photoshop/generator-core.git","ssh_url":"git@github.com:adobe-photoshop/generator-core.git","clone_url":"https://github.com/adobe-photoshop/generator-core.git","svn_url":"https://github.com/adobe-photoshop/generator-core","homepage":"","size":1098,"stargazers_count":453,"watchers_count":453,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":52,"forks":50,"open_issues":52,"watchers":453,"default_branch":"master"}},"base":{"label":"adobe-photoshop:master","ref":"master","sha":"14027cd8a93580e829435a709da4f06ca35b1993","user":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"repo":{"id":10320928,"name":"generator-core","full_name":"adobe-photoshop/generator-core","owner":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-photoshop/generator-core","description":"Core Node.js library for Adobe Photoshop CC's Generator extensibility layer","fork":false,"url":"https://api.github.com/repos/adobe-photoshop/generator-core","forks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/forks","keys_url":"https://api.github.com/repos/adobe-photoshop/generator-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-photoshop/generator-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-photoshop/generator-core/teams","hooks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/hooks","issue_events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/events","assignees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-photoshop/generator-core/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/tags","blobs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-photoshop/generator-core/languages","stargazers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/stargazers","contributors_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contributors","subscribers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscribers","subscription_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscription","commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-photoshop/generator-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-photoshop/generator-core/merges","archive_url":"https://api.github.com/repos/adobe-photoshop/generator-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-photoshop/generator-core/downloads","issues_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-photoshop/generator-core/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-photoshop/generator-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-photoshop/generator-core/labels{/name}","releases_url":"https://api.github.com/repos/adobe-photoshop/generator-core/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/deployments","created_at":"2013-05-27T19:10:52Z","updated_at":"2016-02-24T18:16:56Z","pushed_at":"2016-02-25T23:20:21Z","git_url":"git://github.com/adobe-photoshop/generator-core.git","ssh_url":"git@github.com:adobe-photoshop/generator-core.git","clone_url":"https://github.com/adobe-photoshop/generator-core.git","svn_url":"https://github.com/adobe-photoshop/generator-core","homepage":"","size":1098,"stargazers_count":453,"watchers_count":453,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":52,"forks":50,"open_issues":52,"watchers":453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334"},"html":{"href":"https://github.com/adobe-photoshop/generator-core/pull/334"},"issue":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/334"},"comments":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/0bccd5fab866f2fa567d79e7505edb3a4b0c27ed"}}}}