{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/HubFramework/issues/102","repository_url":"https://api.github.com/repos/spotify/HubFramework","labels_url":"https://api.github.com/repos/spotify/HubFramework/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/spotify/HubFramework/issues/102/comments","events_url":"https://api.github.com/repos/spotify/HubFramework/issues/102/events","html_url":"https://github.com/spotify/HubFramework/pull/102","id":185211005,"number":102,"title":"[WIP] Registering passing a feature model","user":{"login":"pepibumur","id":663605,"avatar_url":"https://avatars.githubusercontent.com/u/663605?v=3","gravatar_id":"","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spotify/HubFramework/labels/work%20in%20progress","name":"work in progress","color":"ffc664"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-25T19:27:24Z","updated_at":"2016-10-25T23:14:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/HubFramework/pulls/102","html_url":"https://github.com/spotify/HubFramework/pull/102","diff_url":"https://github.com/spotify/HubFramework/pull/102.diff","patch_url":"https://github.com/spotify/HubFramework/pull/102.patch"},"body":"### What?\r\nI started using the Framework and I noticed that the way features are registered is calling the method passing all the parameters and internally *(after some checks)* the feature is registered and the model `HUBFeatureRegistration` created. I have a few ideas that I'd like to discuss with you first and get your point of view regarding them:\r\n\r\n- The name `HUBFeatureRegistration` sounds like it's represents a registration in the registry. However it doesn't contain any registration information. How does it sound renaming it to just `HUBFeature`?\r\n- Then the `HUBFeatureRegistry` could include a method for registering these features:\r\n```objc\r\n- (void)register:(HUBFeature *)feature;\r\n```\r\n\r\nI've only added the extra method but I'll wait for your answer before continuing with these ideas.\r\n"},"comment":{"url":"https://api.github.com/repos/spotify/HubFramework/issues/comments/256206365","html_url":"https://github.com/spotify/HubFramework/pull/102#issuecomment-256206365","issue_url":"https://api.github.com/repos/spotify/HubFramework/issues/102","id":256206365,"user":{"login":"JohnSundell","id":2466701,"avatar_url":"https://avatars.githubusercontent.com/u/2466701?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnSundell","html_url":"https://github.com/JohnSundell","followers_url":"https://api.github.com/users/JohnSundell/followers","following_url":"https://api.github.com/users/JohnSundell/following{/other_user}","gists_url":"https://api.github.com/users/JohnSundell/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnSundell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnSundell/subscriptions","organizations_url":"https://api.github.com/users/JohnSundell/orgs","repos_url":"https://api.github.com/users/JohnSundell/repos","events_url":"https://api.github.com/users/JohnSundell/events{/privacy}","received_events_url":"https://api.github.com/users/JohnSundell/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T23:14:41Z","updated_at":"2016-10-25T23:14:41Z","body":"@pepibumur Hmmm what would be the benefit of creating the object and then passing it to a method vs just calling the method? Wouldn't that turn something which can be done in one line to something a bit more complex? I'm not opposed, just want to figure out if it will have some clear API benefits.\r\n\r\nRegarding the renaming of `HUBFeatureRegistration` into `HUBFeature` - all for that 👍 (although it's an internal object only - but always nice to have a clean house 😃)"}}
{"actor":{"display_login":"JohnSundell"}}