{"action":"created","issue":{"url":"https://api.github.com/repos/asteris-llc/converge/issues/527","repository_url":"https://api.github.com/repos/asteris-llc/converge","labels_url":"https://api.github.com/repos/asteris-llc/converge/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/asteris-llc/converge/issues/527/comments","events_url":"https://api.github.com/repos/asteris-llc/converge/issues/527/events","html_url":"https://github.com/asteris-llc/converge/pull/527","id":191380006,"number":527,"title":"Fix/disable docker solaris","user":{"login":"ryane","id":7346,"avatar_url":"https://avatars.githubusercontent.com/u/7346?v=3","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"labels":[{"id":379270644,"url":"https://api.github.com/repos/asteris-llc/converge/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/asteris-llc/converge/milestones/10","html_url":"https://github.com/asteris-llc/converge/milestones/0.5.0","labels_url":"https://api.github.com/repos/asteris-llc/converge/milestones/10/labels","id":2142043,"number":10,"title":"0.5.0","description":"","creator":{"login":"stevendborrelli","id":414702,"avatar_url":"https://avatars.githubusercontent.com/u/414702?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendborrelli","html_url":"https://github.com/stevendborrelli","followers_url":"https://api.github.com/users/stevendborrelli/followers","following_url":"https://api.github.com/users/stevendborrelli/following{/other_user}","gists_url":"https://api.github.com/users/stevendborrelli/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendborrelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendborrelli/subscriptions","organizations_url":"https://api.github.com/users/stevendborrelli/orgs","repos_url":"https://api.github.com/users/stevendborrelli/repos","events_url":"https://api.github.com/users/stevendborrelli/events{/privacy}","received_events_url":"https://api.github.com/users/stevendborrelli/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":13,"state":"open","created_at":"2016-11-17T15:24:31Z","updated_at":"2016-11-23T22:34:57Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-23T21:07:37Z","updated_at":"2016-11-23T22:57:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/asteris-llc/converge/pulls/527","html_url":"https://github.com/asteris-llc/converge/pull/527","diff_url":"https://github.com/asteris-llc/converge/pull/527.diff","patch_url":"https://github.com/asteris-llc/converge/pull/527.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/asteris-llc/converge/issues/comments/262650356","html_url":"https://github.com/asteris-llc/converge/pull/527#issuecomment-262650356","issue_url":"https://api.github.com/repos/asteris-llc/converge/issues/527","id":262650356,"user":{"login":"ryane","id":7346,"avatar_url":"https://avatars.githubusercontent.com/u/7346?v=3","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T22:57:37Z","updated_at":"2016-11-23T22:57:37Z","body":"thx, good idea, I added a comment to the hcl samples. \r\n\r\nBut, on the first suggestion, I'm not totally sure where to return an error. right now, the docker resources are not compiled into the solaris build at all so I think it should be like they don't exist. They are not registered in the registry. While I don't have a way to actually verify on solaris, I believe you should get an error like:\r\n\r\n```shell\r\n$ ./converge plan --local samples/dockerImage.hcl\r\n2016-11-23T17:49:39-05:00 |INFO| serving        addr=:47740 component=rpc\r\n2016-11-23T17:49:39-05:00 |WARN| skipping module verification   component=client\r\n2016-11-23T17:49:39-05:00 |ERROR| could not load        component=rpc error=could not resolve resources: 1 error(s) occurred:\r\n\r\n* root/docker.image.busybox: \"docker.image\" is not a valid resource type in \"docker.image.busybox\" location=samples/dockerImage.hcl runID=d8ff30e7-6a2d-471d-aa8e-f1e6506dee76\r\n2016-11-23T17:49:39-05:00 |FATAL| could not get responses       component=client error=error getting status response: rpc error: code = 2 desc = loading samples/dockerImage.hcl: could not resolve resources: 1 error(s) occurred:\r\n\r\n* root/docker.image.busybox: \"docker.image\" is not a valid resource type in \"docker.image.busybox\" file=samples/dockerImage.hcl\r\n```\r\n\r\nif you were to use `docker.image`, for example. Do we need more than this? I suppose we could maintain a map of unsupported resources by platform in the `load` package and return a more specific error."}}
{"actor":{"display_login":"ryane"}}