{"action":"created","issue":{"url":"https://api.github.com/repos/teusbenschop/bibledit/issues/138","repository_url":"https://api.github.com/repos/teusbenschop/bibledit","labels_url":"https://api.github.com/repos/teusbenschop/bibledit/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/teusbenschop/bibledit/issues/138/comments","events_url":"https://api.github.com/repos/teusbenschop/bibledit/issues/138/events","html_url":"https://github.com/teusbenschop/bibledit/pull/138","id":149981594,"number":138,"title":"Style resets","user":{"login":"alerque","id":173595,"avatar_url":"https://avatars.githubusercontent.com/u/173595?v=3","gravatar_id":"","url":"https://api.github.com/users/alerque","html_url":"https://github.com/alerque","followers_url":"https://api.github.com/users/alerque/followers","following_url":"https://api.github.com/users/alerque/following{/other_user}","gists_url":"https://api.github.com/users/alerque/gists{/gist_id}","starred_url":"https://api.github.com/users/alerque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alerque/subscriptions","organizations_url":"https://api.github.com/users/alerque/orgs","repos_url":"https://api.github.com/users/alerque/repos","events_url":"https://api.github.com/users/alerque/events{/privacy}","received_events_url":"https://api.github.com/users/alerque/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-04-21T06:42:05Z","updated_at":"2016-04-21T11:17:55Z","closed_at":"2016-04-21T10:17:29Z","pull_request":{"url":"https://api.github.com/repos/teusbenschop/bibledit/pulls/138","html_url":"https://github.com/teusbenschop/bibledit/pull/138","diff_url":"https://github.com/teusbenschop/bibledit/pull/138.diff","patch_url":"https://github.com/teusbenschop/bibledit/pull/138.patch"},"body":"Let me preface this with two comments:\r\n\r\n* I am not a graphic designer. I'm sure there are ways to make the interface look more visually appealing than these rules accomplish. The major purpose here was not to accomplish a facelift so much as to cleanup the _code_ so that it was easier to work on and design ideas could be implemented easier.\r\n* Any of these pieces can be applied piecemeal, if something in this set doesn't appeal to you let know and I'll bump that bit and rebase the branch so this merge can be clean.\r\n\r\nAs I started to work of a redesign for the menus, I discovered the overall CSS was pretty difficult to work with. The combination of element nesting and style cascading was so convoluted that adjusting values was pretty difficult. Sometimes a value was getting set at one level, tweaked at another, then reset again at a more specific level. Other places rules were just straight up conflicting or redundant. These changes don't eliminate all of these ambiguities, but they go a long way.\r\n\r\nAs mentioned in #135 there is an issue where style sheets from the unittests/tests directory are ending up in the production interface. This doesn't fix that, but it does cleanup the bloat of no-op styles so that when those are moved to the right place they will be closer to cleaned up.\r\n\r\nOne of the major things I was angling here was starting to separate the BE user interface elements from the application content. I personally found the totally monolithic combination of UI and content to be very confusing getting started and (although they can't articulate this) I think it's one of the underlying reasons my team has found it \"so confusing\".\r\n\r\nThe split is far from complete because the markup being generated for the most part makes no distinctions, but there are a few styles here to at least _start_ the process of separating UI from content.\r\n\r\n* Use sans fonts for UI elements.\r\n* Use serif fonts for Bible and resource content.\r\n* A highlight existed for the current focused verse in an editor, but add another kind of highlight such that all of the canvas areas where the user can expect to be able to edit when focused are highlighted vs. the rest of the interface that has fixed content. This is currently subtle enough it's likely to suffer the same fate as the verse highlighter in #133 where some LCDs and light conditions don't even register it, but as the markup generated by the app is cleaned up it should get easier and easier to make a deliberate distinction and a better visual design could be chosen."},"comment":{"url":"https://api.github.com/repos/teusbenschop/bibledit/issues/comments/212864777","html_url":"https://github.com/teusbenschop/bibledit/pull/138#issuecomment-212864777","issue_url":"https://api.github.com/repos/teusbenschop/bibledit/issues/138","id":212864777,"user":{"login":"alerque","id":173595,"avatar_url":"https://avatars.githubusercontent.com/u/173595?v=3","gravatar_id":"","url":"https://api.github.com/users/alerque","html_url":"https://github.com/alerque","followers_url":"https://api.github.com/users/alerque/followers","following_url":"https://api.github.com/users/alerque/following{/other_user}","gists_url":"https://api.github.com/users/alerque/gists{/gist_id}","starred_url":"https://api.github.com/users/alerque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alerque/subscriptions","organizations_url":"https://api.github.com/users/alerque/orgs","repos_url":"https://api.github.com/users/alerque/repos","events_url":"https://api.github.com/users/alerque/events{/privacy}","received_events_url":"https://api.github.com/users/alerque/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T11:17:55Z","updated_at":"2016-04-21T11:17:55Z","body":"I deleted the symlinks and now I don't have any inline styles at all and my Bibles look like they got opened in  notepad. How am I supposed to trigger styles/css.cpp to do whatever it needs to do, and where are the editor styles _supposed_ to be pulled from?"}}