{"action":"created","comment":{"url":"https://api.github.com/repos/miherlosev/vue/pulls/comments/92604919","pull_request_review_id":13122566,"id":92604919,"diff_hunk":"@@ -0,0 +1,44 @@\n+import { Select2Page } from '../page-models';\r\n+\r\n+fixture `Select2`\r\n+    .page('http://localhost:8080/examples/select2/');\r\n+\r\n+const select2Page = new Select2Page();\r\n+\r\n+test('select2', async t => {\r\n+    await t.expect(select2Page.select2.fallbackSelect.exists).ok()\r","path":"test/e2e/tests/select2.js","position":9,"original_position":9,"commit_id":"679707a0537810f4819b74935176644874f436c4","original_commit_id":"679707a0537810f4819b74935176644874f436c4","user":{"login":"helen-dikareva","id":12034551,"avatar_url":"https://avatars.githubusercontent.com/u/12034551?v=3","gravatar_id":"","url":"https://api.github.com/users/helen-dikareva","html_url":"https://github.com/helen-dikareva","followers_url":"https://api.github.com/users/helen-dikareva/followers","following_url":"https://api.github.com/users/helen-dikareva/following{/other_user}","gists_url":"https://api.github.com/users/helen-dikareva/gists{/gist_id}","starred_url":"https://api.github.com/users/helen-dikareva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helen-dikareva/subscriptions","organizations_url":"https://api.github.com/users/helen-dikareva/orgs","repos_url":"https://api.github.com/users/helen-dikareva/repos","events_url":"https://api.github.com/users/helen-dikareva/events{/privacy}","received_events_url":"https://api.github.com/users/helen-dikareva/received_events","type":"User","site_admin":false},"body":"the same for chaining","created_at":"2016-12-15T13:07:01Z","updated_at":"2016-12-15T13:13:12Z","html_url":"https://github.com/miherlosev/vue/pull/1#discussion_r92604919","pull_request_url":"https://api.github.com/repos/miherlosev/vue/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/comments/92604919"},"html":{"href":"https://github.com/miherlosev/vue/pull/1#discussion_r92604919"},"pull_request":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/miherlosev/vue/pulls/1","id":98145668,"html_url":"https://github.com/miherlosev/vue/pull/1","diff_url":"https://github.com/miherlosev/vue/pull/1.diff","patch_url":"https://github.com/miherlosev/vue/pull/1.patch","issue_url":"https://api.github.com/repos/miherlosev/vue/issues/1","number":1,"state":"open","locked":false,"title":"change e2e testing framework","user":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"body":"Hello\r\nI propose to change e2e framework from `nightwatch` to `testcafe`.\r\nIn this pull request I rewrote all e2e tests using `testcafe`.\r\n\r\nPros:\r\n- ES2016 syntax\r\n- no need an additional dependencies, configs and browser plugins\r\n- clean code (no 'waitForElementVisible', no waiting for page loads and `xhr` requests)\r\n- flexible selectors\r\n- easy setup\r\n- fast developer team response\r\n\r\nNote:\r\nCI for vuejs repository is broken - https://github.com/vuejs/vue/issues/4467.\r\nThen CI was fixed I propose to run tests on real browsers (Firefox and Chrome).\r\nhttps://circleci.com/docs/build-image-trusty/#browsers.\r\n\r\n@inikulin @AlexanderMoskovkin  @helen-dikareva ","created_at":"2016-12-15T12:57:35Z","updated_at":"2016-12-15T13:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1e37089de6dc58757e36c8b8c9d2986098b0d20","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miherlosev/vue/pulls/1/commits","review_comments_url":"https://api.github.com/repos/miherlosev/vue/pulls/1/comments","review_comment_url":"https://api.github.com/repos/miherlosev/vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miherlosev/vue/issues/1/comments","statuses_url":"https://api.github.com/repos/miherlosev/vue/statuses/679707a0537810f4819b74935176644874f436c4","head":{"label":"miherlosev:change_e2e_framework","ref":"change_e2e_framework","sha":"679707a0537810f4819b74935176644874f436c4","user":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"repo":{"id":76462297,"name":"vue","full_name":"miherlosev/vue","owner":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miherlosev/vue","description":"Simple yet powerful library for building modern web interfaces.","fork":true,"url":"https://api.github.com/repos/miherlosev/vue","forks_url":"https://api.github.com/repos/miherlosev/vue/forks","keys_url":"https://api.github.com/repos/miherlosev/vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miherlosev/vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miherlosev/vue/teams","hooks_url":"https://api.github.com/repos/miherlosev/vue/hooks","issue_events_url":"https://api.github.com/repos/miherlosev/vue/issues/events{/number}","events_url":"https://api.github.com/repos/miherlosev/vue/events","assignees_url":"https://api.github.com/repos/miherlosev/vue/assignees{/user}","branches_url":"https://api.github.com/repos/miherlosev/vue/branches{/branch}","tags_url":"https://api.github.com/repos/miherlosev/vue/tags","blobs_url":"https://api.github.com/repos/miherlosev/vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miherlosev/vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miherlosev/vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/miherlosev/vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miherlosev/vue/statuses/{sha}","languages_url":"https://api.github.com/repos/miherlosev/vue/languages","stargazers_url":"https://api.github.com/repos/miherlosev/vue/stargazers","contributors_url":"https://api.github.com/repos/miherlosev/vue/contributors","subscribers_url":"https://api.github.com/repos/miherlosev/vue/subscribers","subscription_url":"https://api.github.com/repos/miherlosev/vue/subscription","commits_url":"https://api.github.com/repos/miherlosev/vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/miherlosev/vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/miherlosev/vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/miherlosev/vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/miherlosev/vue/contents/{+path}","compare_url":"https://api.github.com/repos/miherlosev/vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miherlosev/vue/merges","archive_url":"https://api.github.com/repos/miherlosev/vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miherlosev/vue/downloads","issues_url":"https://api.github.com/repos/miherlosev/vue/issues{/number}","pulls_url":"https://api.github.com/repos/miherlosev/vue/pulls{/number}","milestones_url":"https://api.github.com/repos/miherlosev/vue/milestones{/number}","notifications_url":"https://api.github.com/repos/miherlosev/vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miherlosev/vue/labels{/name}","releases_url":"https://api.github.com/repos/miherlosev/vue/releases{/id}","deployments_url":"https://api.github.com/repos/miherlosev/vue/deployments","created_at":"2016-12-14T13:32:25Z","updated_at":"2016-12-14T13:32:32Z","pushed_at":"2016-12-15T12:57:36Z","git_url":"git://github.com/miherlosev/vue.git","ssh_url":"git@github.com:miherlosev/vue.git","clone_url":"https://github.com/miherlosev/vue.git","svn_url":"https://github.com/miherlosev/vue","homepage":"http://vuejs.org","size":15907,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"miherlosev:dev","ref":"dev","sha":"0fe431b490b90a412ade6e8c4b8065b1f4189b3b","user":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"repo":{"id":76462297,"name":"vue","full_name":"miherlosev/vue","owner":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miherlosev/vue","description":"Simple yet powerful library for building modern web interfaces.","fork":true,"url":"https://api.github.com/repos/miherlosev/vue","forks_url":"https://api.github.com/repos/miherlosev/vue/forks","keys_url":"https://api.github.com/repos/miherlosev/vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miherlosev/vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miherlosev/vue/teams","hooks_url":"https://api.github.com/repos/miherlosev/vue/hooks","issue_events_url":"https://api.github.com/repos/miherlosev/vue/issues/events{/number}","events_url":"https://api.github.com/repos/miherlosev/vue/events","assignees_url":"https://api.github.com/repos/miherlosev/vue/assignees{/user}","branches_url":"https://api.github.com/repos/miherlosev/vue/branches{/branch}","tags_url":"https://api.github.com/repos/miherlosev/vue/tags","blobs_url":"https://api.github.com/repos/miherlosev/vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miherlosev/vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miherlosev/vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/miherlosev/vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miherlosev/vue/statuses/{sha}","languages_url":"https://api.github.com/repos/miherlosev/vue/languages","stargazers_url":"https://api.github.com/repos/miherlosev/vue/stargazers","contributors_url":"https://api.github.com/repos/miherlosev/vue/contributors","subscribers_url":"https://api.github.com/repos/miherlosev/vue/subscribers","subscription_url":"https://api.github.com/repos/miherlosev/vue/subscription","commits_url":"https://api.github.com/repos/miherlosev/vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/miherlosev/vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/miherlosev/vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/miherlosev/vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/miherlosev/vue/contents/{+path}","compare_url":"https://api.github.com/repos/miherlosev/vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miherlosev/vue/merges","archive_url":"https://api.github.com/repos/miherlosev/vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miherlosev/vue/downloads","issues_url":"https://api.github.com/repos/miherlosev/vue/issues{/number}","pulls_url":"https://api.github.com/repos/miherlosev/vue/pulls{/number}","milestones_url":"https://api.github.com/repos/miherlosev/vue/milestones{/number}","notifications_url":"https://api.github.com/repos/miherlosev/vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miherlosev/vue/labels{/name}","releases_url":"https://api.github.com/repos/miherlosev/vue/releases{/id}","deployments_url":"https://api.github.com/repos/miherlosev/vue/deployments","created_at":"2016-12-14T13:32:25Z","updated_at":"2016-12-14T13:32:32Z","pushed_at":"2016-12-15T12:57:36Z","git_url":"git://github.com/miherlosev/vue.git","ssh_url":"git@github.com:miherlosev/vue.git","clone_url":"https://github.com/miherlosev/vue.git","svn_url":"https://github.com/miherlosev/vue","homepage":"http://vuejs.org","size":15907,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/1"},"html":{"href":"https://github.com/miherlosev/vue/pull/1"},"issue":{"href":"https://api.github.com/repos/miherlosev/vue/issues/1"},"comments":{"href":"https://api.github.com/repos/miherlosev/vue/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miherlosev/vue/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/miherlosev/vue/statuses/679707a0537810f4819b74935176644874f436c4"}}}}
{"actor":{"display_login":"helen-dikareva"}}