{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/76477843","id":76477843,"diff_hunk":"@@ -11130,6 +11156,9 @@ HRESULT Parser::ParseFunctionInBackground(ParseNodePtr pnodeFnc, ParseContext *p\n     pnodeFnc->sxFnc.pnodeBody = nullptr;\n     pnodeFnc->sxFnc.nestedCount = 0;\n \n+    // getting the parent node this way might be incorrect\n+    // todo check with Paul how to approach this\n+    ParseNodePtr pnodeParentFnc = m_currentNodeFunc;","path":"lib/Parser/Parse.cpp","position":114,"original_position":114,"commit_id":"93e414b7200296a3e04b0d4b0310044db241f4e6","original_commit_id":"93e414b7200296a3e04b0d4b0310044db241f4e6","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"body":"@pleath is there a way to get the parent function node in parallel parse?  Is parallel parse going to be maintained into the future? #1478 suggests it is not used and could be excluded from build. ","created_at":"2016-08-26T19:51:21Z","updated_at":"2016-08-26T19:51:21Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1497#discussion_r76477843","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/76477843"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1497#discussion_r76477843"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497","id":82943857,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1497","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1497.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1497.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1497","number":1497,"state":"open","locked":false,"title":"Fix incorrect parsing of yield/await in arrow functions","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"body":"The spec carries the Yield/Await parameter forward into the parameter\r\nlist grammar production for arrow functions specifically. We did not\r\nadhere to this and erroneously treated these as identifiers in arrow\r\nfunction parameter lists.\r\n\r\nFixes #333.  See it for more details.","created_at":"2016-08-26T19:48:25Z","updated_at":"2016-08-26T19:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f63ddd577fe9f8a407822de1cf166dd092d9d1a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1497/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/93e414b7200296a3e04b0d4b0310044db241f4e6","head":{"label":"ianwjhalliday:fix333","ref":"fix333","sha":"93e414b7200296a3e04b0d4b0310044db241f4e6","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"repo":{"id":49596782,"name":"ChakraCore","full_name":"ianwjhalliday/ChakraCore","owner":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianwjhalliday/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/ianwjhalliday/ChakraCore","forks_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/forks","keys_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/teams","hooks_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/events","assignees_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/tags","blobs_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/subscription","commits_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/merges","archive_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/downloads","issues_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/deployments","created_at":"2016-01-13T19:33:09Z","updated_at":"2016-01-13T22:53:14Z","pushed_at":"2016-08-26T19:45:54Z","git_url":"git://github.com/ianwjhalliday/ChakraCore.git","ssh_url":"git@github.com:ianwjhalliday/ChakraCore.git","clone_url":"https://github.com/ianwjhalliday/ChakraCore.git","svn_url":"https://github.com/ianwjhalliday/ChakraCore","homepage":null,"size":34081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cd950a704251df2afce6cd7a7c933df579ee7b0d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-08-26T11:22:47Z","pushed_at":"2016-08-26T19:48:25Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":48802,"stargazers_count":5617,"watchers_count":5617,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":616,"mirror_url":null,"open_issues_count":168,"forks":616,"open_issues":168,"watchers":5617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1497"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1497"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1497/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1497/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/93e414b7200296a3e04b0d4b0310044db241f4e6"}}}}
{"actor":{"display_login":"ianwjhalliday"}}