{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11589","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11589/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11589/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11589/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11589","id":180128235,"number":11589,"title":"Handle the case that a parameter group does not have label","user":{"login":"bzwei","id":7047579,"avatar_url":"https://avatars.githubusercontent.com/u/7047579?v=3","gravatar_id":"","url":"https://api.github.com/users/bzwei","html_url":"https://github.com/bzwei","followers_url":"https://api.github.com/users/bzwei/followers","following_url":"https://api.github.com/users/bzwei/following{/other_user}","gists_url":"https://api.github.com/users/bzwei/gists{/gist_id}","starred_url":"https://api.github.com/users/bzwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzwei/subscriptions","organizations_url":"https://api.github.com/users/bzwei/orgs","repos_url":"https://api.github.com/users/bzwei/repos","events_url":"https://api.github.com/users/bzwei/events{/privacy}","received_events_url":"https://api.github.com/users/bzwei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-29T18:37:11Z","updated_at":"2016-09-29T18:48:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11589","html_url":"https://github.com/ManageIQ/manageiq/pull/11589","diff_url":"https://github.com/ManageIQ/manageiq/pull/11589.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11589.patch"},"body":"According to the spec the heat template (HOT) parameter group should have a label and description. Our service dialog generation tool uses the label for a tab label.\r\n\r\nHere is the spec requirement:\r\n```\r\nparameter_groups:\r\n- label: <human-readable label of parameter group>\r\n  description: <description of the parameter group>\r\n  parameters:\r\n  - <param name>\r\n  - <param name>\r\n```\r\n\r\nHowever our customer has a template without label and description which causes the dialog generation failure.\r\n```\r\nparameter_groups:\r\n- parameters:\r\n  - key_name\r\n- parameters:\r\n  - flavor\r\n  - image\r\n```\r\nThe fix is to automatic create a label for non-labeled parameter group.\r\n\r\nIn order to test the fix we purposely deleted the label and description from the sample template.\r\n\r\nLinks [Optional]\r\n----------------\r\n\r\n* http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#parameter-groups-section\r\n* https://bugzilla.redhat.com/show_bug.cgi?id=1378976\r\n\r\nSteps for Testing/QA [Optional]\r\n-------------------------------\r\n\r\nUse a heat template that has parameter group but does not have label and description. You manually delete them like the our test sample."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/250556838","html_url":"https://github.com/ManageIQ/manageiq/pull/11589#issuecomment-250556838","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11589","id":250556838,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T18:48:45Z","updated_at":"2016-09-29T18:48:45Z","body":"<rubocop />Checked commit https://github.com/bzwei/manageiq/commit/833a3805c76d4b03886a538a1d9ba723f9a92df8 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n3 files checked, 0 offenses detected\nEverything looks good. :+1:\n"}}
{"actor":{"display_login":"miq-bot"}}