{"action":"closed","issue":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1277","repository_url":"https://api.github.com/repos/magic-lang/ooc-kean","labels_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1277/labels{/name}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1277/comments","events_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1277/events","html_url":"https://github.com/magic-lang/ooc-kean/issues/1277","id":129715125,"number":1277,"title":"Fix lingering gcc warnings from shared library","user":{"login":"marcusnaslund","id":14308896,"avatar_url":"https://avatars.githubusercontent.com/u/14308896?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusnaslund","html_url":"https://github.com/marcusnaslund","followers_url":"https://api.github.com/users/marcusnaslund/followers","following_url":"https://api.github.com/users/marcusnaslund/following{/other_user}","gists_url":"https://api.github.com/users/marcusnaslund/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusnaslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusnaslund/subscriptions","organizations_url":"https://api.github.com/users/marcusnaslund/orgs","repos_url":"https://api.github.com/users/marcusnaslund/repos","events_url":"https://api.github.com/users/marcusnaslund/events{/privacy}","received_events_url":"https://api.github.com/users/marcusnaslund/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/milestones/2","html_url":"https://github.com/magic-lang/ooc-kean/milestones/Later","labels_url":"https://api.github.com/repos/magic-lang/ooc-kean/milestones/2/labels","id":1323671,"number":2,"title":"Later","description":"Non-trivial things that need to be done eventually. ","creator":{"login":"davidhesselbom","id":4319680,"avatar_url":"https://avatars.githubusercontent.com/u/4319680?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhesselbom","html_url":"https://github.com/davidhesselbom","followers_url":"https://api.github.com/users/davidhesselbom/followers","following_url":"https://api.github.com/users/davidhesselbom/following{/other_user}","gists_url":"https://api.github.com/users/davidhesselbom/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhesselbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhesselbom/subscriptions","organizations_url":"https://api.github.com/users/davidhesselbom/orgs","repos_url":"https://api.github.com/users/davidhesselbom/repos","events_url":"https://api.github.com/users/davidhesselbom/events{/privacy}","received_events_url":"https://api.github.com/users/davidhesselbom/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":50,"state":"open","created_at":"2015-09-25T11:30:32Z","updated_at":"2016-02-16T14:29:07Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-01-29T09:37:53Z","updated_at":"2016-02-16T14:29:07Z","closed_at":"2016-02-16T14:29:07Z","body":"When building this repo as part of a shared library, `gcc` with `-Wall` provides the following output:\r\n\r\n```\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/io/native/ProcessUnix.ooc: In function ‘native_ProcessUnix__ProcessUnix_terminate_impl’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/io/native/ProcessUnix.ooc:25:9: warning: implicit declaration of function ‘kill’ [-Wimplicit-function-declaration]\r\n    kill(pid, SIGTERM)\r\n         ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/io/native/FileUnix.ooc: In function ‘io_native_FileUnix__FileUnix_createTempFile’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/io/native/FileUnix.ooc:333:5: warning: implicit declaration of function ‘mkstemp’ [-Wimplicit-function-declaration]\r\n    fd := mkstemp(pattern)\r\n     ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/io/native/FileUnix.ooc:334:5: warning: implicit declaration of function ‘fdopen’ [-Wimplicit-function-declaration]\r\n    result: FStream = fd >= 0 ? fdopen(fd, mode) : null\r\n     ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/io/native/FileUnix.ooc:334:98: warning: pointer/integer type mismatch in conditional expression [enabled by default]\r\n    result: FStream = fd >= 0 ? fdopen(fd, mode) : null\r\n                                                                                                  ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/IO.ooc: In function ‘IO__FStream_open_withFlags’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/IO.ooc:97:5: warning: implicit declaration of function ‘fdopen’ [-Wimplicit-function-declaration]\r\n   fd >= 0 ? fdopen(fd, mode) : null\r\n     ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/IO.ooc:97:84: warning: pointer/integer type mismatch in conditional expression [enabled by default]\r\n   fd >= 0 ? fdopen(fd, mode) : null\r\n                                                                                    ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/Time.ooc: In function ‘Time__Time_sleepMicro’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/Time.ooc:180:5: warning: implicit declaration of function ‘usleep’ [-Wimplicit-function-declaration]\r\n    usleep(duration)\r\n     ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/threading/native/ThreadUnix.ooc: In function ‘threading_native_ThreadUnix__ThreadUnix_alive_impl’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/threading/native/ThreadUnix.ooc:36:5: warning: implicit declaration of function ‘pthread_kill’ [-Wimplicit-function-declaration]\r\n    pthread_kill(pthread, 0) == 0\r\n     ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/os/Env.ooc: In function ‘os_Env__Env_set’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/os/Env.ooc:24:9: warning: implicit declaration of function ‘setenv’ [-Wimplicit-function-declaration]\r\n     result = setenv(key toCString(), value toCString(), overwrite)\r\n         ^\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/os/Env.ooc: In function ‘os_Env__Env_unset’:\r\n/home/mnaslund/versioned/ooc/ooc-kean/source/sdk/os/Env.ooc:37:5: warning: implicit declaration of function ‘unsetenv’ [-Wimplicit-function-declaration]\r\n    unsetenv(key toCString())\r\n```\r\n\r\nIn short form:\r\n\r\n- [ ] Implicit declaration of `kill`\r\n- [ ] Implicit declaration of `mkstemp`\r\n- [ ] Implicit declaration of `fdopen`\r\n- [x] Implicit declaration of `usleep`\r\n- [x] Implicit declaration of `pthread_kill`\r\n- [x] Implicit declaration of `setenv`\r\n- [x] Implicit declaration of `unsetenv`\r\n- [ ] Pointer/integer mismatch in `fd >= 0 ? fdopen(fd, mode) : null` (@sebastianbaginski you added this, can you fix it?)\r\n\r\nThis must be fixed eventually."}}