{"action":"created","issue":{"url":"https://api.github.com/repos/uber/tchannel-go/issues/231","repository_url":"https://api.github.com/repos/uber/tchannel-go","labels_url":"https://api.github.com/repos/uber/tchannel-go/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/231/comments","events_url":"https://api.github.com/repos/uber/tchannel-go/issues/231/events","html_url":"https://github.com/uber/tchannel-go/pull/231","id":135827142,"number":231,"title":"Unblock on close","user":{"login":"aravindvs","id":13004672,"avatar_url":"https://avatars.githubusercontent.com/u/13004672?v=3","gravatar_id":"","url":"https://api.github.com/users/aravindvs","html_url":"https://github.com/aravindvs","followers_url":"https://api.github.com/users/aravindvs/followers","following_url":"https://api.github.com/users/aravindvs/following{/other_user}","gists_url":"https://api.github.com/users/aravindvs/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindvs/subscriptions","organizations_url":"https://api.github.com/users/aravindvs/orgs","repos_url":"https://api.github.com/users/aravindvs/repos","events_url":"https://api.github.com/users/aravindvs/events{/privacy}","received_events_url":"https://api.github.com/users/aravindvs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-23T18:49:27Z","updated_at":"2016-02-24T16:09:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/231","html_url":"https://github.com/uber/tchannel-go/pull/231","diff_url":"https://github.com/uber/tchannel-go/pull/231.diff","patch_url":"https://github.com/uber/tchannel-go/pull/231.patch"},"body":"@prashantv  - Now we should be against dev..\r\n\r\nIf we get a connection error, we need to make sure all the exchanges are stopped completely that way we can unblock any application callers.\r\n\r\nThis patch adds an error channel on an message exchange and makes sure we send the appropriate error code on this channel if we see a connection error on both the inbound and the outbound side.\r\n\r\nAlso update the unit test to use a longer context timeout and with this change we can run this one cleanly with no issues  (@samarabbas) .\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/uber/tchannel-go/issues/comments/188325594","html_url":"https://github.com/uber/tchannel-go/pull/231#issuecomment-188325594","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/231","id":188325594,"user":{"login":"aravindvs","id":13004672,"avatar_url":"https://avatars.githubusercontent.com/u/13004672?v=3","gravatar_id":"","url":"https://api.github.com/users/aravindvs","html_url":"https://github.com/aravindvs","followers_url":"https://api.github.com/users/aravindvs/followers","following_url":"https://api.github.com/users/aravindvs/following{/other_user}","gists_url":"https://api.github.com/users/aravindvs/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindvs/subscriptions","organizations_url":"https://api.github.com/users/aravindvs/orgs","repos_url":"https://api.github.com/users/aravindvs/repos","events_url":"https://api.github.com/users/aravindvs/events{/privacy}","received_events_url":"https://api.github.com/users/aravindvs/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T16:09:42Z","updated_at":"2016-02-24T16:09:42Z","body":"@prashantv - if i make the error channel to be inside the connection object and update it during the connection close, then it probably will address all scenarios right?"}}