{"action":"opened","issue":{"url":"https://api.github.com/repos/cloudflare/cloudflare-go/issues/78","repository_url":"https://api.github.com/repos/cloudflare/cloudflare-go","labels_url":"https://api.github.com/repos/cloudflare/cloudflare-go/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/cloudflare-go/issues/78/comments","events_url":"https://api.github.com/repos/cloudflare/cloudflare-go/issues/78/events","html_url":"https://github.com/cloudflare/cloudflare-go/issues/78","id":157237195,"number":78,"title":"[breaking] Proposal: Make Response types private; expose Results only","user":{"login":"elithrar","id":18544,"avatar_url":"https://avatars.githubusercontent.com/u/18544?v=3","gravatar_id":"","url":"https://api.github.com/users/elithrar","html_url":"https://github.com/elithrar","followers_url":"https://api.github.com/users/elithrar/followers","following_url":"https://api.github.com/users/elithrar/following{/other_user}","gists_url":"https://api.github.com/users/elithrar/gists{/gist_id}","starred_url":"https://api.github.com/users/elithrar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elithrar/subscriptions","organizations_url":"https://api.github.com/users/elithrar/orgs","repos_url":"https://api.github.com/users/elithrar/repos","events_url":"https://api.github.com/users/elithrar/events{/privacy}","received_events_url":"https://api.github.com/users/elithrar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cloudflare/cloudflare-go/labels/breaking","name":"breaking","color":"eb6420"},{"url":"https://api.github.com/repos/cloudflare/cloudflare-go/labels/documentation","name":"documentation","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-27T15:52:23Z","updated_at":"2016-05-27T15:52:23Z","closed_at":null,"body":"Exposing `XXXResponse` types clutters the public API and offers minimal (if any) benefit to consumers of the package.\r\n\r\nDiscussion with @jamesog and @saljam internally leads to this proposal:\r\n\r\n* `XXXResponse` types should be made private\r\n* We should only expose `Response.Result` - which will be a `*DNSRecord` or `*PageRule`\r\n* We unwrap the errors from `Response.Errors` and return them.\r\n\r\nIn addition we should look to standardize on returning/using pointer types, but that could also be tackled in a separate PR/issue."}}
{"actor":{"display_login":"elithrar"}}