{"action":"closed","number":826,"pull_request":{"url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826","id":84616282,"html_url":"https://github.com/cerebris/jsonapi-resources/pull/826","diff_url":"https://github.com/cerebris/jsonapi-resources/pull/826.diff","patch_url":"https://github.com/cerebris/jsonapi-resources/pull/826.patch","issue_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/826","number":826,"state":"closed","locked":false,"title":"Don't call link_builder when custom link is provided","user":{"login":"knapo","id":63880,"avatar_url":"https://avatars.githubusercontent.com/u/63880?v=3","gravatar_id":"","url":"https://api.github.com/users/knapo","html_url":"https://github.com/knapo","followers_url":"https://api.github.com/users/knapo/followers","following_url":"https://api.github.com/users/knapo/following{/other_user}","gists_url":"https://api.github.com/users/knapo/gists{/gist_id}","starred_url":"https://api.github.com/users/knapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knapo/subscriptions","organizations_url":"https://api.github.com/users/knapo/orgs","repos_url":"https://api.github.com/users/knapo/repos","events_url":"https://api.github.com/users/knapo/events{/privacy}","received_events_url":"https://api.github.com/users/knapo/received_events","type":"User","site_admin":false},"body":"So I wan't to override `self` link using `custom_links` (make it nil since I don't need it for embedded relationship). However, for current implementation link builder is being called anyway and I need to define route which is never used, and it make the serialization slower as the route generation is not the fastest thing in rails.","created_at":"2016-09-09T09:00:59Z","updated_at":"2016-09-12T21:08:02Z","closed_at":"2016-09-12T21:08:02Z","merged_at":"2016-09-12T21:08:02Z","merge_commit_sha":"539051bab150973b6dc8fdee5d74ec4116b93c8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826/commits","review_comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826/comments","review_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/826/comments","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/cbce78d3abfa593ac91ed4756b906d4092f64724","head":{"label":"knapo:dont-call-link-builder-when-custom-self-is-present","ref":"dont-call-link-builder-when-custom-self-is-present","sha":"cbce78d3abfa593ac91ed4756b906d4092f64724","user":{"login":"knapo","id":63880,"avatar_url":"https://avatars.githubusercontent.com/u/63880?v=3","gravatar_id":"","url":"https://api.github.com/users/knapo","html_url":"https://github.com/knapo","followers_url":"https://api.github.com/users/knapo/followers","following_url":"https://api.github.com/users/knapo/following{/other_user}","gists_url":"https://api.github.com/users/knapo/gists{/gist_id}","starred_url":"https://api.github.com/users/knapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knapo/subscriptions","organizations_url":"https://api.github.com/users/knapo/orgs","repos_url":"https://api.github.com/users/knapo/repos","events_url":"https://api.github.com/users/knapo/events{/privacy}","received_events_url":"https://api.github.com/users/knapo/received_events","type":"User","site_admin":false},"repo":{"id":67783165,"name":"jsonapi-resources","full_name":"knapo/jsonapi-resources","owner":{"login":"knapo","id":63880,"avatar_url":"https://avatars.githubusercontent.com/u/63880?v=3","gravatar_id":"","url":"https://api.github.com/users/knapo","html_url":"https://github.com/knapo","followers_url":"https://api.github.com/users/knapo/followers","following_url":"https://api.github.com/users/knapo/following{/other_user}","gists_url":"https://api.github.com/users/knapo/gists{/gist_id}","starred_url":"https://api.github.com/users/knapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knapo/subscriptions","organizations_url":"https://api.github.com/users/knapo/orgs","repos_url":"https://api.github.com/users/knapo/repos","events_url":"https://api.github.com/users/knapo/events{/privacy}","received_events_url":"https://api.github.com/users/knapo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knapo/jsonapi-resources","description":"A resource-focused Rails library for developing JSON API compliant servers.","fork":true,"url":"https://api.github.com/repos/knapo/jsonapi-resources","forks_url":"https://api.github.com/repos/knapo/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/knapo/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knapo/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knapo/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/knapo/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/knapo/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/knapo/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/knapo/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/knapo/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/knapo/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/knapo/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knapo/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knapo/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/knapo/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knapo/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/knapo/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/knapo/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/knapo/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/knapo/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/knapo/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/knapo/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/knapo/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/knapo/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/knapo/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/knapo/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/knapo/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knapo/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/knapo/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knapo/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/knapo/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/knapo/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/knapo/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/knapo/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knapo/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/knapo/jsonapi-resources/releases{/id}","deployments_url":"https://api.github.com/repos/knapo/jsonapi-resources/deployments","created_at":"2016-09-09T08:55:40Z","updated_at":"2016-09-09T08:55:41Z","pushed_at":"2016-09-09T08:59:24Z","git_url":"git://github.com/knapo/jsonapi-resources.git","ssh_url":"git@github.com:knapo/jsonapi-resources.git","clone_url":"https://github.com/knapo/jsonapi-resources.git","svn_url":"https://github.com/knapo/jsonapi-resources","homepage":"","size":2356,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cerebris:master","ref":"master","sha":"3b1d57450661f9c8c89b5d257b724e075c0606a9","user":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"repo":{"id":18248068,"name":"jsonapi-resources","full_name":"cerebris/jsonapi-resources","owner":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerebris/jsonapi-resources","description":"A resource-focused Rails library for developing JSON API compliant servers.","fork":false,"url":"https://api.github.com/repos/cerebris/jsonapi-resources","forks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/cerebris/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerebris/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerebris/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/cerebris/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/cerebris/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/cerebris/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerebris/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/cerebris/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerebris/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/cerebris/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/cerebris/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerebris/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/cerebris/jsonapi-resources/releases{/id}","deployments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/deployments","created_at":"2014-03-29T18:45:23Z","updated_at":"2016-09-12T17:25:12Z","pushed_at":"2016-09-12T21:08:02Z","git_url":"git://github.com/cerebris/jsonapi-resources.git","ssh_url":"git@github.com:cerebris/jsonapi-resources.git","clone_url":"https://github.com/cerebris/jsonapi-resources.git","svn_url":"https://github.com/cerebris/jsonapi-resources","homepage":"","size":2816,"stargazers_count":1550,"watchers_count":1550,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":179,"forks":284,"open_issues":179,"watchers":1550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826"},"html":{"href":"https://github.com/cerebris/jsonapi-resources/pull/826"},"issue":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/826"},"comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/826/comments"},"review_comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826/comments"},"review_comment":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/826/commits"},"statuses":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/cbce78d3abfa593ac91ed4756b906d4092f64724"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lgebhardt","id":29154,"avatar_url":"https://avatars.githubusercontent.com/u/29154?v=3","gravatar_id":"","url":"https://api.github.com/users/lgebhardt","html_url":"https://github.com/lgebhardt","followers_url":"https://api.github.com/users/lgebhardt/followers","following_url":"https://api.github.com/users/lgebhardt/following{/other_user}","gists_url":"https://api.github.com/users/lgebhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/lgebhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgebhardt/subscriptions","organizations_url":"https://api.github.com/users/lgebhardt/orgs","repos_url":"https://api.github.com/users/lgebhardt/repos","events_url":"https://api.github.com/users/lgebhardt/events{/privacy}","received_events_url":"https://api.github.com/users/lgebhardt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"lgebhardt"}}