{"action":"created","comment":{"url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/comments/74541791","id":74541791,"diff_hunk":"@@ -145,6 +150,18 @@ error_t flash_manager_data(uint32_t addr, const uint8_t *data, uint32_t size)\n         // flush if necessary\n         if (addr >= current_write_block_addr + current_write_block_size) {\n             // Write out current buffer\n+#ifdef FLASH_PARTIAL_ERASE\n+            // Processing for low-speed devices of chip erasure.\n+            if ((current_write_block_addr % intf->erase_sector_size(current_write_block_addr)) == 0) {\n+                uint32_t wk_sector = current_write_block_addr / intf->erase_sector_size(current_write_block_addr);\n+                status = intf->erase_sector(wk_sector);\n+                flash_manager_printf(\"    intf->erase_sector(sector=0x%x) ret=%i\\r\\n\", wk_sector, status);\n+                if (ERROR_SUCCESS != status) {\n+                    state = STATE_ERROR;\n+                    return status;\n+                }\n+            }\n+#endif","path":"source/daplink/drag-n-drop/flash_manager.c","position":34,"original_position":34,"commit_id":"b6a53f244ca2fb9e9d523945db955b2511fa0e1b","original_commit_id":"b6a53f244ca2fb9e9d523945db955b2511fa0e1b","user":{"login":"c1728p9","id":2916772,"avatar_url":"https://avatars.githubusercontent.com/u/2916772?v=3","gravatar_id":"","url":"https://api.github.com/users/c1728p9","html_url":"https://github.com/c1728p9","followers_url":"https://api.github.com/users/c1728p9/followers","following_url":"https://api.github.com/users/c1728p9/following{/other_user}","gists_url":"https://api.github.com/users/c1728p9/gists{/gist_id}","starred_url":"https://api.github.com/users/c1728p9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c1728p9/subscriptions","organizations_url":"https://api.github.com/users/c1728p9/orgs","repos_url":"https://api.github.com/users/c1728p9/repos","events_url":"https://api.github.com/users/c1728p9/events{/privacy}","received_events_url":"https://api.github.com/users/c1728p9/received_events","type":"User","site_admin":false},"body":"Please remove the old comment ~193 which reads \"//TODO - future improvement - erase sector here\" since you are implementing this :).","created_at":"2016-08-12T05:02:00Z","updated_at":"2016-08-12T05:02:00Z","html_url":"https://github.com/mbedmicro/DAPLink/pull/132#discussion_r74541791","pull_request_url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/comments/74541791"},"html":{"href":"https://github.com/mbedmicro/DAPLink/pull/132#discussion_r74541791"},"pull_request":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132","id":79320097,"html_url":"https://github.com/mbedmicro/DAPLink/pull/132","diff_url":"https://github.com/mbedmicro/DAPLink/pull/132.diff","patch_url":"https://github.com/mbedmicro/DAPLink/pull/132.patch","issue_url":"https://api.github.com/repos/mbedmicro/DAPLink/issues/132","number":132,"state":"open","locked":false,"title":"Add target GR-PEACH","user":{"login":"d-kato","id":9261197,"avatar_url":"https://avatars.githubusercontent.com/u/9261197?v=3","gravatar_id":"","url":"https://api.github.com/users/d-kato","html_url":"https://github.com/d-kato","followers_url":"https://api.github.com/users/d-kato/followers","following_url":"https://api.github.com/users/d-kato/following{/other_user}","gists_url":"https://api.github.com/users/d-kato/gists{/gist_id}","starred_url":"https://api.github.com/users/d-kato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-kato/subscriptions","organizations_url":"https://api.github.com/users/d-kato/orgs","repos_url":"https://api.github.com/users/d-kato/repos","events_url":"https://api.github.com/users/d-kato/events{/privacy}","received_events_url":"https://api.github.com/users/d-kato/received_events","type":"User","site_admin":false},"body":"- Add the process for the Cortex-A\r\nIt branches in processing for Cortex-A by macro TARGET_MCU_CORTEX_A.\r\nA \"swd_host.c\" for Cortex-A is created as \"swd_host_ca.c\".\r\nThe binary inspection was made comparison in 3 bytes of head of the data because there was no NVIC in Cortex-A.\r\nComparative data can be set for each board by macro BINARY_DETECTION.\r\n\r\n- Add the partial erase processing for the chip erase is slow device.\r\nOur Flash will take more than 20 seconds to chip erase.\r\nTherefore, we have added the process of writing a program with partial erase.\r\nSelective erase becomes effective by macro FLASH_PARTIAL_ERASE.\r\n\r\n- Add target Renesas GR-PEACH\r\nA flash of rza1h is outside the chip, and the flash and port may be different from every board.\r\nSo it was made the following path.\r\n\"/source/target/renesas/rza1h/gr-peach/\"","created_at":"2016-07-29T07:53:24Z","updated_at":"2016-08-12T05:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bd50060072c9a519ccdb1f0fa82f20b7e12a6bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132/commits","review_comments_url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132/comments","review_comment_url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbedmicro/DAPLink/issues/132/comments","statuses_url":"https://api.github.com/repos/mbedmicro/DAPLink/statuses/b6a53f244ca2fb9e9d523945db955b2511fa0e1b","head":{"label":"d-kato:master","ref":"master","sha":"b6a53f244ca2fb9e9d523945db955b2511fa0e1b","user":{"login":"d-kato","id":9261197,"avatar_url":"https://avatars.githubusercontent.com/u/9261197?v=3","gravatar_id":"","url":"https://api.github.com/users/d-kato","html_url":"https://github.com/d-kato","followers_url":"https://api.github.com/users/d-kato/followers","following_url":"https://api.github.com/users/d-kato/following{/other_user}","gists_url":"https://api.github.com/users/d-kato/gists{/gist_id}","starred_url":"https://api.github.com/users/d-kato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-kato/subscriptions","organizations_url":"https://api.github.com/users/d-kato/orgs","repos_url":"https://api.github.com/users/d-kato/repos","events_url":"https://api.github.com/users/d-kato/events{/privacy}","received_events_url":"https://api.github.com/users/d-kato/received_events","type":"User","site_admin":false},"repo":{"id":64445324,"name":"DAPLink","full_name":"d-kato/DAPLink","owner":{"login":"d-kato","id":9261197,"avatar_url":"https://avatars.githubusercontent.com/u/9261197?v=3","gravatar_id":"","url":"https://api.github.com/users/d-kato","html_url":"https://github.com/d-kato","followers_url":"https://api.github.com/users/d-kato/followers","following_url":"https://api.github.com/users/d-kato/following{/other_user}","gists_url":"https://api.github.com/users/d-kato/gists{/gist_id}","starred_url":"https://api.github.com/users/d-kato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-kato/subscriptions","organizations_url":"https://api.github.com/users/d-kato/orgs","repos_url":"https://api.github.com/users/d-kato/repos","events_url":"https://api.github.com/users/d-kato/events{/privacy}","received_events_url":"https://api.github.com/users/d-kato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-kato/DAPLink","description":null,"fork":true,"url":"https://api.github.com/repos/d-kato/DAPLink","forks_url":"https://api.github.com/repos/d-kato/DAPLink/forks","keys_url":"https://api.github.com/repos/d-kato/DAPLink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-kato/DAPLink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-kato/DAPLink/teams","hooks_url":"https://api.github.com/repos/d-kato/DAPLink/hooks","issue_events_url":"https://api.github.com/repos/d-kato/DAPLink/issues/events{/number}","events_url":"https://api.github.com/repos/d-kato/DAPLink/events","assignees_url":"https://api.github.com/repos/d-kato/DAPLink/assignees{/user}","branches_url":"https://api.github.com/repos/d-kato/DAPLink/branches{/branch}","tags_url":"https://api.github.com/repos/d-kato/DAPLink/tags","blobs_url":"https://api.github.com/repos/d-kato/DAPLink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-kato/DAPLink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-kato/DAPLink/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-kato/DAPLink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-kato/DAPLink/statuses/{sha}","languages_url":"https://api.github.com/repos/d-kato/DAPLink/languages","stargazers_url":"https://api.github.com/repos/d-kato/DAPLink/stargazers","contributors_url":"https://api.github.com/repos/d-kato/DAPLink/contributors","subscribers_url":"https://api.github.com/repos/d-kato/DAPLink/subscribers","subscription_url":"https://api.github.com/repos/d-kato/DAPLink/subscription","commits_url":"https://api.github.com/repos/d-kato/DAPLink/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-kato/DAPLink/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-kato/DAPLink/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-kato/DAPLink/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-kato/DAPLink/contents/{+path}","compare_url":"https://api.github.com/repos/d-kato/DAPLink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-kato/DAPLink/merges","archive_url":"https://api.github.com/repos/d-kato/DAPLink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-kato/DAPLink/downloads","issues_url":"https://api.github.com/repos/d-kato/DAPLink/issues{/number}","pulls_url":"https://api.github.com/repos/d-kato/DAPLink/pulls{/number}","milestones_url":"https://api.github.com/repos/d-kato/DAPLink/milestones{/number}","notifications_url":"https://api.github.com/repos/d-kato/DAPLink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-kato/DAPLink/labels{/name}","releases_url":"https://api.github.com/repos/d-kato/DAPLink/releases{/id}","deployments_url":"https://api.github.com/repos/d-kato/DAPLink/deployments","created_at":"2016-07-29T02:53:11Z","updated_at":"2016-07-29T02:53:14Z","pushed_at":"2016-07-29T07:45:18Z","git_url":"git://github.com/d-kato/DAPLink.git","ssh_url":"git@github.com:d-kato/DAPLink.git","clone_url":"https://github.com/d-kato/DAPLink.git","svn_url":"https://github.com/d-kato/DAPLink","homepage":null,"size":10702,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbedmicro:master","ref":"master","sha":"06c1a6439442051f1d90c89279ced638eb708562","user":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":24571059,"name":"DAPLink","full_name":"mbedmicro/DAPLink","owner":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mbedmicro/DAPLink","description":"","fork":false,"url":"https://api.github.com/repos/mbedmicro/DAPLink","forks_url":"https://api.github.com/repos/mbedmicro/DAPLink/forks","keys_url":"https://api.github.com/repos/mbedmicro/DAPLink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbedmicro/DAPLink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbedmicro/DAPLink/teams","hooks_url":"https://api.github.com/repos/mbedmicro/DAPLink/hooks","issue_events_url":"https://api.github.com/repos/mbedmicro/DAPLink/issues/events{/number}","events_url":"https://api.github.com/repos/mbedmicro/DAPLink/events","assignees_url":"https://api.github.com/repos/mbedmicro/DAPLink/assignees{/user}","branches_url":"https://api.github.com/repos/mbedmicro/DAPLink/branches{/branch}","tags_url":"https://api.github.com/repos/mbedmicro/DAPLink/tags","blobs_url":"https://api.github.com/repos/mbedmicro/DAPLink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbedmicro/DAPLink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbedmicro/DAPLink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbedmicro/DAPLink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbedmicro/DAPLink/statuses/{sha}","languages_url":"https://api.github.com/repos/mbedmicro/DAPLink/languages","stargazers_url":"https://api.github.com/repos/mbedmicro/DAPLink/stargazers","contributors_url":"https://api.github.com/repos/mbedmicro/DAPLink/contributors","subscribers_url":"https://api.github.com/repos/mbedmicro/DAPLink/subscribers","subscription_url":"https://api.github.com/repos/mbedmicro/DAPLink/subscription","commits_url":"https://api.github.com/repos/mbedmicro/DAPLink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbedmicro/DAPLink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbedmicro/DAPLink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbedmicro/DAPLink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbedmicro/DAPLink/contents/{+path}","compare_url":"https://api.github.com/repos/mbedmicro/DAPLink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbedmicro/DAPLink/merges","archive_url":"https://api.github.com/repos/mbedmicro/DAPLink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbedmicro/DAPLink/downloads","issues_url":"https://api.github.com/repos/mbedmicro/DAPLink/issues{/number}","pulls_url":"https://api.github.com/repos/mbedmicro/DAPLink/pulls{/number}","milestones_url":"https://api.github.com/repos/mbedmicro/DAPLink/milestones{/number}","notifications_url":"https://api.github.com/repos/mbedmicro/DAPLink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbedmicro/DAPLink/labels{/name}","releases_url":"https://api.github.com/repos/mbedmicro/DAPLink/releases{/id}","deployments_url":"https://api.github.com/repos/mbedmicro/DAPLink/deployments","created_at":"2014-09-28T21:38:24Z","updated_at":"2016-08-09T07:59:53Z","pushed_at":"2016-08-12T04:24:33Z","git_url":"git://github.com/mbedmicro/DAPLink.git","ssh_url":"git@github.com:mbedmicro/DAPLink.git","clone_url":"https://github.com/mbedmicro/DAPLink.git","svn_url":"https://github.com/mbedmicro/DAPLink","homepage":null,"size":12525,"stargazers_count":16,"watchers_count":16,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":19,"forks":27,"open_issues":19,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132"},"html":{"href":"https://github.com/mbedmicro/DAPLink/pull/132"},"issue":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/issues/132"},"comments":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/mbedmicro/DAPLink/statuses/b6a53f244ca2fb9e9d523945db955b2511fa0e1b"}}}}
{"actor":{"display_login":"c1728p9"}}