{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/50517917","id":50517917,"diff_hunk":"@@ -77,6 +77,14 @@ rules:\n   ## Suggest using 'const' wherever possible\n   prefer-const: 2\n \n+  # Arrow Functions\n+  ## Enforce parens around arrow function arguments\n+  arrow-parens: [2, \"always\"]\n+  ## Require a space on each side of arrow operator\n+  arrow-spacing: [2, { \"before\": true, \"after\": true }]","path":".eslintrc","position":8,"original_position":8,"commit_id":"4df3cdf08f4b87ec3011c9dd97d11e289b749bfa","original_commit_id":"4df3cdf08f4b87ec3011c9dd97d11e289b749bfa","user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"body":"nit: no spaces inside braces.","created_at":"2016-01-22T09:44:02Z","updated_at":"2016-01-22T09:44:02Z","html_url":"https://github.com/nodejs/node/pull/4813#discussion_r50517917","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4813","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/50517917"},"html":{"href":"https://github.com/nodejs/node/pull/4813#discussion_r50517917"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4813"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4813","id":56848927,"html_url":"https://github.com/nodejs/node/pull/4813","diff_url":"https://github.com/nodejs/node/pull/4813.diff","patch_url":"https://github.com/nodejs/node/pull/4813.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4813","number":4813,"state":"open","locked":false,"title":"Add arrow function rules to eslint","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"This PR enforces the following linting rules:\r\n* arrow-parens - requires parens around arrow function arguments\r\n* arrow-spacing - ensures a space on each side of the =>\r\n* no-arrow-condition - prevents accidental use of => in cases\r\nwhere the user really intends to use <=\r\n\r\nThe only code that violated these rules existed in the `test` directory.\r\nR= @rvagg ","created_at":"2016-01-22T05:41:01Z","updated_at":"2016-01-22T09:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"680747ddf8e4ce9c8cdf29e779c00b38f12c0be2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4813/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4813/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4813/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4df3cdf08f4b87ec3011c9dd97d11e289b749bfa","head":{"label":"cjihrig:parens","ref":"parens","sha":"4df3cdf08f4b87ec3011c9dd97d11e289b749bfa","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"repo":{"id":40613511,"name":"node-1","full_name":"cjihrig/node-1","owner":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjihrig/node-1","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/cjihrig/node-1","forks_url":"https://api.github.com/repos/cjihrig/node-1/forks","keys_url":"https://api.github.com/repos/cjihrig/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjihrig/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjihrig/node-1/teams","hooks_url":"https://api.github.com/repos/cjihrig/node-1/hooks","issue_events_url":"https://api.github.com/repos/cjihrig/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/cjihrig/node-1/events","assignees_url":"https://api.github.com/repos/cjihrig/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/cjihrig/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/cjihrig/node-1/tags","blobs_url":"https://api.github.com/repos/cjihrig/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjihrig/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjihrig/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjihrig/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjihrig/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cjihrig/node-1/languages","stargazers_url":"https://api.github.com/repos/cjihrig/node-1/stargazers","contributors_url":"https://api.github.com/repos/cjihrig/node-1/contributors","subscribers_url":"https://api.github.com/repos/cjihrig/node-1/subscribers","subscription_url":"https://api.github.com/repos/cjihrig/node-1/subscription","commits_url":"https://api.github.com/repos/cjihrig/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjihrig/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjihrig/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjihrig/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjihrig/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/cjihrig/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjihrig/node-1/merges","archive_url":"https://api.github.com/repos/cjihrig/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjihrig/node-1/downloads","issues_url":"https://api.github.com/repos/cjihrig/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/cjihrig/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cjihrig/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cjihrig/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjihrig/node-1/labels{/name}","releases_url":"https://api.github.com/repos/cjihrig/node-1/releases{/id}","deployments_url":"https://api.github.com/repos/cjihrig/node-1/deployments","created_at":"2015-08-12T17:07:21Z","updated_at":"2015-08-12T17:07:25Z","pushed_at":"2016-01-22T05:38:56Z","git_url":"git://github.com/cjihrig/node-1.git","ssh_url":"git@github.com:cjihrig/node-1.git","clone_url":"https://github.com/cjihrig/node-1.git","svn_url":"https://github.com/cjihrig/node-1","homepage":"https://iojs.org","size":167173,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"db9e122182f7e605eba2eb2e9ddea0bf00bb572c","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-01-22T09:42:57Z","pushed_at":"2016-01-22T08:25:13Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":202221,"stargazers_count":19510,"watchers_count":19510,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2332,"mirror_url":null,"open_issues_count":684,"forks":2332,"open_issues":684,"watchers":19510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4813"},"html":{"href":"https://github.com/nodejs/node/pull/4813"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4813"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4813/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4813/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4813/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4df3cdf08f4b87ec3011c9dd97d11e289b749bfa"}}}}