{"action":"opened","number":2165,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165","id":73651235,"html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2165","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2165.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2165.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2165","number":2165,"state":"open","locked":false,"title":"resize turning circles automagically, make customization easier, fixes #1931","user":{"login":"matkoniecz","id":899988,"avatar_url":"https://avatars.githubusercontent.com/u/899988?v=3","gravatar_id":"","url":"https://api.github.com/users/matkoniecz","html_url":"https://github.com/matkoniecz","followers_url":"https://api.github.com/users/matkoniecz/followers","following_url":"https://api.github.com/users/matkoniecz/following{/other_user}","gists_url":"https://api.github.com/users/matkoniecz/gists{/gist_id}","starred_url":"https://api.github.com/users/matkoniecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkoniecz/subscriptions","organizations_url":"https://api.github.com/users/matkoniecz/orgs","repos_url":"https://api.github.com/users/matkoniecz/repos","events_url":"https://api.github.com/users/matkoniecz/events{/privacy}","received_events_url":"https://api.github.com/users/matkoniecz/received_events","type":"User","site_admin":false},"body":"- simplify code, old one was too complex and failed for small road widths\r\n- note that tracks are special and sizes are hardcoded\r\n- render turning circle on minor service from z18\r\n- fix too large casing for z16 tertiary turning circle\r\n\r\nold size of turning circle with casing:\r\n (road-size - 2 * casing-width) * 1.8 + 2 * casing-width\r\n\r\n what may be reduced to\r\n road-size * 1.8 - 1.6 * casing-width\r\n\r\nold size of turning circle without casing:\r\n (road-size - 2 * casing-width) * 1.8\r\n\r\n what may be reduced to\r\n road-size * 1.8 - 3.6 * casing-width\r\n\r\nThis worked poorly for cases of small road-size. New sizes are:\r\nfor full size, with casing:\r\n\r\n road-size * 1.6 + 2 * casing-width\r\n\r\ninner size, without casing:\r\n\r\n road-size * 1.6\r\n \r\nhttps://cloud.githubusercontent.com/assets/899988/16024603/25126fb8-31c3-11e6-82b3-3711742b85ef.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024604/2514a95e-31c3-11e6-8436-14b8686b54a4.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024607/251cbf72-31c3-11e6-8f26-e5f284c5ea6c.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024606/251cb5b8-31c3-11e6-85d7-e9fad4398848.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024605/251c9c68-31c3-11e6-9e3a-825e1566cdd0.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024608/251eb2a0-31c3-11e6-9425-6743cbf6c573.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024609/252dce98-31c3-11e6-9722-5f3d4f92f2d8.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024610/252edad6-31c3-11e6-8edf-69599c2a26c3.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024611/253a0848-31c3-11e6-8a8c-34c4eb3bdfce.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024612/253b13aa-31c3-11e6-9d6c-b2f2250506ec.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024614/253db45c-31c3-11e6-818c-036ce1a4a3ed.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024613/253d3bb2-31c3-11e6-8028-bbd708d0635c.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024616/25498818-31c3-11e6-8464-1590fe080780.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024615/25493eb2-31c3-11e6-8517-0f80fd1b59ef.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024617/2552ec78-31c3-11e6-9071-f0f815acb3b2.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024618/25563928-31c3-11e6-9628-8d2041a93a58.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024619/25594de8-31c3-11e6-8717-248011720524.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024620/255d7cd8-31c3-11e6-8e08-c035e83e90b5.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024621/25623796-31c3-11e6-81f4-46cb0bf56dd4.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024622/25647060-31c3-11e6-8cab-7164137ca0e1.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024623/256d9244-31c3-11e6-8bdc-cd5337fc0966.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024624/25702658-31c3-11e6-851a-189c5de762f9.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024625/2573d352-31c3-11e6-8160-c1eb588204d1.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024626/2576d2b4-31c3-11e6-8942-e25c3e0bd918.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024627/257d333e-31c3-11e6-8a84-fa92e38a6a8a.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024628/257ef818-31c3-11e6-8beb-7b4d5a6272ab.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024629/258643c0-31c3-11e6-8c61-64a2a14f5d03.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024630/258a862e-31c3-11e6-91e7-ba38a47c461b.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024631/258e617c-31c3-11e6-9ce4-3d1b15c8b88c.png\r\nhttps://cloud.githubusercontent.com/assets/899988/16024632/259318de-31c3-11e6-8a91-4f85ff3f5f7e.png\r\n\r\n","created_at":"2016-06-13T22:06:36Z","updated_at":"2016-06-13T22:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2165/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/58ad6cc94a9aace1612d6303912821ac6769ce9c","head":{"label":"matkoniecz:turning_circle","ref":"turning_circle","sha":"58ad6cc94a9aace1612d6303912821ac6769ce9c","user":{"login":"matkoniecz","id":899988,"avatar_url":"https://avatars.githubusercontent.com/u/899988?v=3","gravatar_id":"","url":"https://api.github.com/users/matkoniecz","html_url":"https://github.com/matkoniecz","followers_url":"https://api.github.com/users/matkoniecz/followers","following_url":"https://api.github.com/users/matkoniecz/following{/other_user}","gists_url":"https://api.github.com/users/matkoniecz/gists{/gist_id}","starred_url":"https://api.github.com/users/matkoniecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkoniecz/subscriptions","organizations_url":"https://api.github.com/users/matkoniecz/orgs","repos_url":"https://api.github.com/users/matkoniecz/repos","events_url":"https://api.github.com/users/matkoniecz/events{/privacy}","received_events_url":"https://api.github.com/users/matkoniecz/received_events","type":"User","site_admin":false},"repo":{"id":24539736,"name":"openstreetmap-carto","full_name":"matkoniecz/openstreetmap-carto","owner":{"login":"matkoniecz","id":899988,"avatar_url":"https://avatars.githubusercontent.com/u/899988?v=3","gravatar_id":"","url":"https://api.github.com/users/matkoniecz","html_url":"https://github.com/matkoniecz","followers_url":"https://api.github.com/users/matkoniecz/followers","following_url":"https://api.github.com/users/matkoniecz/following{/other_user}","gists_url":"https://api.github.com/users/matkoniecz/gists{/gist_id}","starred_url":"https://api.github.com/users/matkoniecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkoniecz/subscriptions","organizations_url":"https://api.github.com/users/matkoniecz/orgs","repos_url":"https://api.github.com/users/matkoniecz/repos","events_url":"https://api.github.com/users/matkoniecz/events{/privacy}","received_events_url":"https://api.github.com/users/matkoniecz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matkoniecz/openstreetmap-carto","description":"A project to re-implement the standard OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto","forks_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/matkoniecz/openstreetmap-carto/deployments","created_at":"2014-09-27T18:40:50Z","updated_at":"2016-01-16T17:29:25Z","pushed_at":"2016-06-13T21:52:38Z","git_url":"git://github.com/matkoniecz/openstreetmap-carto.git","ssh_url":"git@github.com:matkoniecz/openstreetmap-carto.git","clone_url":"https://github.com/matkoniecz/openstreetmap-carto.git","svn_url":"https://github.com/matkoniecz/openstreetmap-carto","homepage":null,"size":7077,"stargazers_count":1,"watchers_count":1,"language":"CartoCSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"a9d23245276830fbca6517fff5e6a2453ba1bb0a","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/deployments","created_at":"2012-11-15T16:06:16Z","updated_at":"2016-06-07T20:22:31Z","pushed_at":"2016-06-13T21:05:03Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":"","size":10616,"stargazers_count":426,"watchers_count":426,"language":"CartoCSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":226,"mirror_url":null,"open_issues_count":366,"forks":226,"open_issues":366,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/2165"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2165"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2165/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2165/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/58ad6cc94a9aace1612d6303912821ac6769ce9c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":114,"deletions":104,"changed_files":1}}
{"actor":{"display_login":"matkoniecz"}}