{"action":"created","comment":{"url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/comments/68637474","id":68637474,"diff_hunk":"@@ -10,5 +10,7 @@ Pod::Spec.new do |s|\n \n   s.source       = { :git => \"https://github.com/lelandrichardson/react-native-maps.git\" }\n   s.source_files  = \"ios/AirMaps/**/*.{h,m}\"\n+\n+  s.dependency 'React', '0.27.2'","path":"react-native-maps.podspec","position":5,"original_position":5,"commit_id":"82b71c6f7202658a78290845db8d09c06ba0e02d","original_commit_id":"82b71c6f7202658a78290845db8d09c06ba0e02d","user":{"login":"igrayson","id":6943580,"avatar_url":"https://avatars.githubusercontent.com/u/6943580?v=3","gravatar_id":"","url":"https://api.github.com/users/igrayson","html_url":"https://github.com/igrayson","followers_url":"https://api.github.com/users/igrayson/followers","following_url":"https://api.github.com/users/igrayson/following{/other_user}","gists_url":"https://api.github.com/users/igrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/igrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrayson/subscriptions","organizations_url":"https://api.github.com/users/igrayson/orgs","repos_url":"https://api.github.com/users/igrayson/repos","events_url":"https://api.github.com/users/igrayson/events{/privacy}","received_events_url":"https://api.github.com/users/igrayson/received_events","type":"User","site_admin":false},"body":"would `s.dependency 'React'` be sufficient?","created_at":"2016-06-27T19:10:43Z","updated_at":"2016-06-27T19:10:43Z","html_url":"https://github.com/lelandrichardson/react-native-maps/pull/308#discussion_r68637474","pull_request_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/comments/68637474"},"html":{"href":"https://github.com/lelandrichardson/react-native-maps/pull/308#discussion_r68637474"},"pull_request":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308","id":74490539,"html_url":"https://github.com/lelandrichardson/react-native-maps/pull/308","diff_url":"https://github.com/lelandrichardson/react-native-maps/pull/308.diff","patch_url":"https://github.com/lelandrichardson/react-native-maps/pull/308.patch","issue_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/308","number":308,"state":"open","locked":false,"title":"Getting to work on iOS with 0.27","user":{"login":"codenamev","id":109135,"avatar_url":"https://avatars.githubusercontent.com/u/109135?v=3","gravatar_id":"","url":"https://api.github.com/users/codenamev","html_url":"https://github.com/codenamev","followers_url":"https://api.github.com/users/codenamev/followers","following_url":"https://api.github.com/users/codenamev/following{/other_user}","gists_url":"https://api.github.com/users/codenamev/gists{/gist_id}","starred_url":"https://api.github.com/users/codenamev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenamev/subscriptions","organizations_url":"https://api.github.com/users/codenamev/orgs","repos_url":"https://api.github.com/users/codenamev/repos","events_url":"https://api.github.com/users/codenamev/events{/privacy}","received_events_url":"https://api.github.com/users/codenamev/received_events","type":"User","site_admin":false},"body":"Ok, so my last PR removed the React dependency as it's latest pod source references an outdated version of `0.14`.  In order to get this completely working I am doing the following in my project's `ios/Podfile`:\r\n\r\n```ruby\r\nsource 'https://github.com/CocoaPods/Specs.git'\r\nplatform :ios, '8.0'\r\nuse_frameworks!\r\n\r\nworkspace 'my-project.xcworkspace'\r\nproject 'my-project.xcodeproj'\r\n\r\ntarget 'my-project' do\r\n  # Depending on how your project is organized, your node_modules directory may be\r\n  # somewhere else; tell CocoaPods where you've installed react-native from npm\r\n  pod 'React', :path => '../node_modules/react-native'\r\n  pod 'React/Core', path: '../node_modules/react-native'\r\n  pod 'React/RCTGeolocation', :path => '../node_modules/react-native'\r\n  pod 'React/RCTImage', :path => '../node_modules/react-native'\r\n  pod 'React/RCTNetwork', :path => '../node_modules/react-native'\r\n  pod 'React/RCTText', :path => '../node_modules/react-native'\r\n  pod 'React/RCTWebSocket', :path => '../node_modules/react-native'\r\n  pod 'react-native-maps'\r\nend\r\n```\r\n\r\nI then add the `React.framework` to my Linked Libraries, and everything works.  I'm not sure if this is the best way to solve this, but thought I'd post this to start a discussion or help people in the interim.","created_at":"2016-06-20T18:31:36Z","updated_at":"2016-06-27T19:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d411f54aaa3e3f6a0cef7df821c67345158908","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308/commits","review_comments_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308/comments","review_comment_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/308/comments","statuses_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/statuses/82b71c6f7202658a78290845db8d09c06ba0e02d","head":{"label":"reenhanced:master","ref":"master","sha":"82b71c6f7202658a78290845db8d09c06ba0e02d","user":{"login":"reenhanced","id":30651,"avatar_url":"https://avatars.githubusercontent.com/u/30651?v=3","gravatar_id":"","url":"https://api.github.com/users/reenhanced","html_url":"https://github.com/reenhanced","followers_url":"https://api.github.com/users/reenhanced/followers","following_url":"https://api.github.com/users/reenhanced/following{/other_user}","gists_url":"https://api.github.com/users/reenhanced/gists{/gist_id}","starred_url":"https://api.github.com/users/reenhanced/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reenhanced/subscriptions","organizations_url":"https://api.github.com/users/reenhanced/orgs","repos_url":"https://api.github.com/users/reenhanced/repos","events_url":"https://api.github.com/users/reenhanced/events{/privacy}","received_events_url":"https://api.github.com/users/reenhanced/received_events","type":"Organization","site_admin":false},"repo":{"id":61300666,"name":"react-native-maps","full_name":"reenhanced/react-native-maps","owner":{"login":"reenhanced","id":30651,"avatar_url":"https://avatars.githubusercontent.com/u/30651?v=3","gravatar_id":"","url":"https://api.github.com/users/reenhanced","html_url":"https://github.com/reenhanced","followers_url":"https://api.github.com/users/reenhanced/followers","following_url":"https://api.github.com/users/reenhanced/following{/other_user}","gists_url":"https://api.github.com/users/reenhanced/gists{/gist_id}","starred_url":"https://api.github.com/users/reenhanced/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reenhanced/subscriptions","organizations_url":"https://api.github.com/users/reenhanced/orgs","repos_url":"https://api.github.com/users/reenhanced/repos","events_url":"https://api.github.com/users/reenhanced/events{/privacy}","received_events_url":"https://api.github.com/users/reenhanced/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reenhanced/react-native-maps","description":"React Native Mapview component for iOS + Android","fork":true,"url":"https://api.github.com/repos/reenhanced/react-native-maps","forks_url":"https://api.github.com/repos/reenhanced/react-native-maps/forks","keys_url":"https://api.github.com/repos/reenhanced/react-native-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reenhanced/react-native-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reenhanced/react-native-maps/teams","hooks_url":"https://api.github.com/repos/reenhanced/react-native-maps/hooks","issue_events_url":"https://api.github.com/repos/reenhanced/react-native-maps/issues/events{/number}","events_url":"https://api.github.com/repos/reenhanced/react-native-maps/events","assignees_url":"https://api.github.com/repos/reenhanced/react-native-maps/assignees{/user}","branches_url":"https://api.github.com/repos/reenhanced/react-native-maps/branches{/branch}","tags_url":"https://api.github.com/repos/reenhanced/react-native-maps/tags","blobs_url":"https://api.github.com/repos/reenhanced/react-native-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reenhanced/react-native-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reenhanced/react-native-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/reenhanced/react-native-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reenhanced/react-native-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/reenhanced/react-native-maps/languages","stargazers_url":"https://api.github.com/repos/reenhanced/react-native-maps/stargazers","contributors_url":"https://api.github.com/repos/reenhanced/react-native-maps/contributors","subscribers_url":"https://api.github.com/repos/reenhanced/react-native-maps/subscribers","subscription_url":"https://api.github.com/repos/reenhanced/react-native-maps/subscription","commits_url":"https://api.github.com/repos/reenhanced/react-native-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/reenhanced/react-native-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/reenhanced/react-native-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/reenhanced/react-native-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/reenhanced/react-native-maps/contents/{+path}","compare_url":"https://api.github.com/repos/reenhanced/react-native-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reenhanced/react-native-maps/merges","archive_url":"https://api.github.com/repos/reenhanced/react-native-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reenhanced/react-native-maps/downloads","issues_url":"https://api.github.com/repos/reenhanced/react-native-maps/issues{/number}","pulls_url":"https://api.github.com/repos/reenhanced/react-native-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/reenhanced/react-native-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/reenhanced/react-native-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reenhanced/react-native-maps/labels{/name}","releases_url":"https://api.github.com/repos/reenhanced/react-native-maps/releases{/id}","deployments_url":"https://api.github.com/repos/reenhanced/react-native-maps/deployments","created_at":"2016-06-16T14:28:28Z","updated_at":"2016-06-16T14:28:29Z","pushed_at":"2016-06-20T18:40:32Z","git_url":"git://github.com/reenhanced/react-native-maps.git","ssh_url":"git@github.com:reenhanced/react-native-maps.git","clone_url":"https://github.com/reenhanced/react-native-maps.git","svn_url":"https://github.com/reenhanced/react-native-maps","homepage":null,"size":481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lelandrichardson:master","ref":"master","sha":"ac147eae37628f49b2c0cbc074f2bf31bdc67bf7","user":{"login":"lelandrichardson","id":1885623,"avatar_url":"https://avatars.githubusercontent.com/u/1885623?v=3","gravatar_id":"","url":"https://api.github.com/users/lelandrichardson","html_url":"https://github.com/lelandrichardson","followers_url":"https://api.github.com/users/lelandrichardson/followers","following_url":"https://api.github.com/users/lelandrichardson/following{/other_user}","gists_url":"https://api.github.com/users/lelandrichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/lelandrichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelandrichardson/subscriptions","organizations_url":"https://api.github.com/users/lelandrichardson/orgs","repos_url":"https://api.github.com/users/lelandrichardson/repos","events_url":"https://api.github.com/users/lelandrichardson/events{/privacy}","received_events_url":"https://api.github.com/users/lelandrichardson/received_events","type":"User","site_admin":false},"repo":{"id":48764652,"name":"react-native-maps","full_name":"lelandrichardson/react-native-maps","owner":{"login":"lelandrichardson","id":1885623,"avatar_url":"https://avatars.githubusercontent.com/u/1885623?v=3","gravatar_id":"","url":"https://api.github.com/users/lelandrichardson","html_url":"https://github.com/lelandrichardson","followers_url":"https://api.github.com/users/lelandrichardson/followers","following_url":"https://api.github.com/users/lelandrichardson/following{/other_user}","gists_url":"https://api.github.com/users/lelandrichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/lelandrichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelandrichardson/subscriptions","organizations_url":"https://api.github.com/users/lelandrichardson/orgs","repos_url":"https://api.github.com/users/lelandrichardson/repos","events_url":"https://api.github.com/users/lelandrichardson/events{/privacy}","received_events_url":"https://api.github.com/users/lelandrichardson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lelandrichardson/react-native-maps","description":"React Native Mapview component for iOS + Android","fork":false,"url":"https://api.github.com/repos/lelandrichardson/react-native-maps","forks_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/forks","keys_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/teams","hooks_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/hooks","issue_events_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/events{/number}","events_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/events","assignees_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/assignees{/user}","branches_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/branches{/branch}","tags_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/tags","blobs_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/languages","stargazers_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/stargazers","contributors_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/contributors","subscribers_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/subscribers","subscription_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/subscription","commits_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/contents/{+path}","compare_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/merges","archive_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/downloads","issues_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues{/number}","pulls_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/labels{/name}","releases_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/releases{/id}","deployments_url":"https://api.github.com/repos/lelandrichardson/react-native-maps/deployments","created_at":"2015-12-29T19:54:20Z","updated_at":"2016-06-27T11:11:06Z","pushed_at":"2016-06-27T11:14:08Z","git_url":"git://github.com/lelandrichardson/react-native-maps.git","ssh_url":"git@github.com:lelandrichardson/react-native-maps.git","clone_url":"https://github.com/lelandrichardson/react-native-maps.git","svn_url":"https://github.com/lelandrichardson/react-native-maps","homepage":null,"size":747,"stargazers_count":1026,"watchers_count":1026,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":120,"forks":203,"open_issues":120,"watchers":1026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308"},"html":{"href":"https://github.com/lelandrichardson/react-native-maps/pull/308"},"issue":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/308"},"comments":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/lelandrichardson/react-native-maps/statuses/82b71c6f7202658a78290845db8d09c06ba0e02d"}}}}
{"actor":{"display_login":"igrayson"}}