{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/58946990","id":58946990,"diff_hunk":"@@ -104,13 +104,6 @@ CBlockTemplate* CreateNewBlock(const CScript& scriptPubKeyIn)\n     if (Params().MineBlocksOnDemand())\n         pblock->nVersion = GetArg(\"-blockversion\", pblock->nVersion);\n \n-    // Create coinbase tx\n-    CMutableTransaction txNew;\n-    txNew.vin.resize(1);\n-    txNew.vin[0].prevout.SetNull();\n-    txNew.vout.resize(1);\n-    txNew.vout[0].scriptPubKey = scriptPubKeyIn;\n-\n     // Add dummy coinbase tx as first transaction","path":"src/miner.cpp","position":11,"original_position":11,"commit_id":"20a4b30dc2e8814d68936d1fc7e58c235abd6566","original_commit_id":"11483859b56142b391d4fa89d84a25e51d073568","user":{"login":"nathan-at-least","id":4369700,"avatar_url":"https://avatars.githubusercontent.com/u/4369700?v=3","gravatar_id":"","url":"https://api.github.com/users/nathan-at-least","html_url":"https://github.com/nathan-at-least","followers_url":"https://api.github.com/users/nathan-at-least/followers","following_url":"https://api.github.com/users/nathan-at-least/following{/other_user}","gists_url":"https://api.github.com/users/nathan-at-least/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-at-least/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-at-least/subscriptions","organizations_url":"https://api.github.com/users/nathan-at-least/orgs","repos_url":"https://api.github.com/users/nathan-at-least/repos","events_url":"https://api.github.com/users/nathan-at-least/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-at-least/received_events","type":"User","site_admin":false},"body":"Why does the old code say:\r\n\r\n> CMutableTransaction txNew\r\n> …\r\n> pblock->vtx.push_back(CTransaction());\r\n\r\n-instead of:\r\n\r\n> CMutableTransaction txNew\r\n> …\r\n> pblock->vtx.push_back(txNew);\r\n\r\nAs this diff shows, ``txNew`` is not referenced until much later. Are those two different transactions?","created_at":"2016-04-07T21:19:27Z","updated_at":"2016-04-07T21:19:27Z","html_url":"https://github.com/zcash/zcash/pull/831#discussion_r58946990","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/831","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/58946990"},"html":{"href":"https://github.com/zcash/zcash/pull/831#discussion_r58946990"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/831"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/831","id":65354241,"html_url":"https://github.com/zcash/zcash/pull/831","diff_url":"https://github.com/zcash/zcash/pull/831.diff","patch_url":"https://github.com/zcash/zcash/pull/831.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/831","number":831,"state":"open","locked":false,"title":"Implement Founders' Reward","user":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars.githubusercontent.com/u/3794471?v=3","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"body":"Tests haven't been added or modified yet. (See #841)\r\n\r\nCloses #125","created_at":"2016-04-05T18:44:07Z","updated_at":"2016-04-07T21:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c114fc61cacbd2c2f1a80ef0a84927361b6a195","assignee":{"login":"nathan-at-least","id":4369700,"avatar_url":"https://avatars.githubusercontent.com/u/4369700?v=3","gravatar_id":"","url":"https://api.github.com/users/nathan-at-least","html_url":"https://github.com/nathan-at-least","followers_url":"https://api.github.com/users/nathan-at-least/followers","following_url":"https://api.github.com/users/nathan-at-least/following{/other_user}","gists_url":"https://api.github.com/users/nathan-at-least/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-at-least/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-at-least/subscriptions","organizations_url":"https://api.github.com/users/nathan-at-least/orgs","repos_url":"https://api.github.com/users/nathan-at-least/repos","events_url":"https://api.github.com/users/nathan-at-least/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-at-least/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/31","html_url":"https://github.com/zcash/zcash/milestones/PoW%20Release","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/31/labels","id":1672422,"number":31,"title":"PoW Release","description":"","creator":{"login":"nathan-at-least","id":4369700,"avatar_url":"https://avatars.githubusercontent.com/u/4369700?v=3","gravatar_id":"","url":"https://api.github.com/users/nathan-at-least","html_url":"https://github.com/nathan-at-least","followers_url":"https://api.github.com/users/nathan-at-least/followers","following_url":"https://api.github.com/users/nathan-at-least/following{/other_user}","gists_url":"https://api.github.com/users/nathan-at-least/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-at-least/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-at-least/subscriptions","organizations_url":"https://api.github.com/users/nathan-at-least/orgs","repos_url":"https://api.github.com/users/nathan-at-least/repos","events_url":"https://api.github.com/users/nathan-at-least/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-at-least/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2016-03-29T17:47:08Z","updated_at":"2016-04-05T22:52:37Z","due_on":"2016-04-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/831/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/831/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/831/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/20a4b30dc2e8814d68936d1fc7e58c235abd6566","head":{"label":"ebfull:foundersreward","ref":"foundersreward","sha":"20a4b30dc2e8814d68936d1fc7e58c235abd6566","user":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars.githubusercontent.com/u/3794471?v=3","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"repo":{"id":52047666,"name":"zcash","full_name":"ebfull/zcash","owner":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars.githubusercontent.com/u/3794471?v=3","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebfull/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/ebfull/zcash","forks_url":"https://api.github.com/repos/ebfull/zcash/forks","keys_url":"https://api.github.com/repos/ebfull/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebfull/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebfull/zcash/teams","hooks_url":"https://api.github.com/repos/ebfull/zcash/hooks","issue_events_url":"https://api.github.com/repos/ebfull/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/ebfull/zcash/events","assignees_url":"https://api.github.com/repos/ebfull/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/ebfull/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/ebfull/zcash/tags","blobs_url":"https://api.github.com/repos/ebfull/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebfull/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebfull/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebfull/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebfull/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/ebfull/zcash/languages","stargazers_url":"https://api.github.com/repos/ebfull/zcash/stargazers","contributors_url":"https://api.github.com/repos/ebfull/zcash/contributors","subscribers_url":"https://api.github.com/repos/ebfull/zcash/subscribers","subscription_url":"https://api.github.com/repos/ebfull/zcash/subscription","commits_url":"https://api.github.com/repos/ebfull/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebfull/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebfull/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebfull/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebfull/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/ebfull/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebfull/zcash/merges","archive_url":"https://api.github.com/repos/ebfull/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebfull/zcash/downloads","issues_url":"https://api.github.com/repos/ebfull/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/ebfull/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/ebfull/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/ebfull/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebfull/zcash/labels{/name}","releases_url":"https://api.github.com/repos/ebfull/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/ebfull/zcash/deployments","created_at":"2016-02-18T23:50:56Z","updated_at":"2016-02-18T23:50:59Z","pushed_at":"2016-04-07T21:12:13Z","git_url":"git://github.com/ebfull/zcash.git","ssh_url":"git@github.com:ebfull/zcash.git","clone_url":"https://github.com/ebfull/zcash.git","svn_url":"https://github.com/ebfull/zcash","homepage":"https://z.cash/","size":36379,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"zc.v0.11.2.latest"}},"base":{"label":"zcash:zc.v0.11.2.latest","ref":"zc.v0.11.2.latest","sha":"9b7606fb6e5e6cbbd5bb8a18d5470175606f0e85","user":{"login":"zcash","id":16122764,"avatar_url":"https://avatars.githubusercontent.com/u/16122764?v=3","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"avatar_url":"https://avatars.githubusercontent.com/u/16122764?v=3","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"zcash","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2016-04-07T21:19:01Z","pushed_at":"2016-04-07T21:12:14Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":41334,"stargazers_count":668,"watchers_count":668,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":297,"forks":63,"open_issues":297,"watchers":668,"default_branch":"zc.v0.11.2.z1"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/831"},"html":{"href":"https://github.com/zcash/zcash/pull/831"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/831"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/20a4b30dc2e8814d68936d1fc7e58c235abd6566"}}}}