{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/107","repository_url":"https://api.github.com/repos/vaadin/angular2-polymer","labels_url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/107/comments","events_url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/107/events","html_url":"https://github.com/vaadin/angular2-polymer/pull/107","id":190962777,"number":107,"title":"Add instructions to support Angular v.2.2.0","user":{"login":"samiheikki","id":8615573,"avatar_url":"https://avatars.githubusercontent.com/u/8615573?v=3","gravatar_id":"","url":"https://api.github.com/users/samiheikki","html_url":"https://github.com/samiheikki","followers_url":"https://api.github.com/users/samiheikki/followers","following_url":"https://api.github.com/users/samiheikki/following{/other_user}","gists_url":"https://api.github.com/users/samiheikki/gists{/gist_id}","starred_url":"https://api.github.com/users/samiheikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiheikki/subscriptions","organizations_url":"https://api.github.com/users/samiheikki/orgs","repos_url":"https://api.github.com/users/samiheikki/repos","events_url":"https://api.github.com/users/samiheikki/events{/privacy}","received_events_url":"https://api.github.com/users/samiheikki/received_events","type":"User","site_admin":false},"labels":[{"id":375536035,"url":"https://api.github.com/repos/vaadin/angular2-polymer/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-22T10:35:32Z","updated_at":"2016-11-22T14:30:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/angular2-polymer/pulls/107","html_url":"https://github.com/vaadin/angular2-polymer/pull/107","diff_url":"https://github.com/vaadin/angular2-polymer/pull/107.diff","patch_url":"https://github.com/vaadin/angular2-polymer/pull/107.patch"},"body":"Fixes #106\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/angular2-polymer/107)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/comments/262255022","html_url":"https://github.com/vaadin/angular2-polymer/pull/107#issuecomment-262255022","issue_url":"https://api.github.com/repos/vaadin/angular2-polymer/issues/107","id":262255022,"user":{"login":"platosha","id":247998,"avatar_url":"https://avatars.githubusercontent.com/u/247998?v=3","gravatar_id":"","url":"https://api.github.com/users/platosha","html_url":"https://github.com/platosha","followers_url":"https://api.github.com/users/platosha/followers","following_url":"https://api.github.com/users/platosha/following{/other_user}","gists_url":"https://api.github.com/users/platosha/gists{/gist_id}","starred_url":"https://api.github.com/users/platosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platosha/subscriptions","organizations_url":"https://api.github.com/users/platosha/orgs","repos_url":"https://api.github.com/users/platosha/repos","events_url":"https://api.github.com/users/platosha/events{/privacy}","received_events_url":"https://api.github.com/users/platosha/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T14:30:41Z","updated_at":"2016-11-22T14:30:41Z","body":"Please don’t forget to update the `angular2-polymer-quickstart` app as well.\n\n---\n\nReviewed 3 of 3 files at r1.\nReview status: all files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[docs/ng-cli-webpack.adoc, line 102 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBR0Egf-l2A8youI8o:-KXBR0Egf-l2A8youI8p:bmkgvnc) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/ng-cli-webpack.adoc#L102)):*\n> ```AsciiDoc\n>   <script src=\"assets/bower_components/webcomponentsjs/webcomponents.min.js\"></script>\n>   <script>\n>     // this script must run before Polymer is imported\n> ```\n\nMaybe try without this comment first?\n\n---\n\n*[docs/ng-cli-webpack.adoc, line 105 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBRAz7Pb9nb7rZVY0z:-KXBRAz7Pb9nb7rZVY1-:bjru3ik) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/ng-cli-webpack.adoc#L105)):*\n> ```AsciiDoc\n>     window.Polymer = {\n>       dom: 'shadow'\n>     }\n> ```\n\nAlthough not required, it would be nice to have a semicolon here.\n\n---\n\n*[docs/overview.adoc, line 33 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBR3hASAxXoDXlreo4:-KXBR3hASAxXoDXlreo5:bq3g697) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/overview.adoc#L33)):*\n> ```AsciiDoc\n> <script src=\"bower_components/webcomponentsjs/webcomponents.min.js\"></script>\n> <script>\n>   // this script must run before Polymer is imported\n> ```\n\nSame here ^^^.\n\n---\n\n*[docs/overview.adoc, line 36 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBRHMoMhKQTiJXv7Nm:-KXBRHMoMhKQTiJXv7Nn:b6ig5zv) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/overview.adoc#L36)):*\n> ```AsciiDoc\n>   window.Polymer = {\n>     dom: 'shadow'\n>   }\n> ```\n\nAlso semicolon here.\n\n---\n\n*[docs/tutorial/polymer.adoc, line 22 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBR6NSVHQO3hptPETt:-KXBR6NSVHQO3hptPETu:bq3g697) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/tutorial/polymer.adoc#L22)):*\n> ```AsciiDoc\n> \n>     <script>\n>       // this script must run before Polymer is imported\n> ```\n\nSame here ^^^.\n\n---\n\n*[docs/tutorial/polymer.adoc, line 25 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBRK1BgI6jFmrY63sY:-KXBRK1BgI6jFmrY63sZ:b6ig5zv) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/tutorial/polymer.adoc#L25)):*\n> ```AsciiDoc\n>       window.Polymer = {\n>         dom: 'shadow'\n>       }\n> ```\n\nAlso semicolon here.\n\n---\n\n*[docs/tutorial/polymer.adoc, line 80 at r1](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-KXBPShxXjtAy7WPnQqd:-KXBPShxXjtAy7WPnQqe:ba795f1) ([raw file](https://github.com/vaadin/angular2-polymer/blob/49822688ee35189dca29b24027f63dd728286886/docs/tutorial/polymer.adoc#L80)):*\nI feel like there should be a bit more information. Maybe:\n\n> By default, Polymer uses shady DOM, which is not compatible with Angular. We created the Polymer global settings object and set it to use shadow DOM instead.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/angular2-polymer/107#-:-KXBROr_ucjL7Djn2LTb:b-x5zs3h)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"platosha"}}