{"action":"created","issue":{"url":"https://api.github.com/repos/iLCSoft/Marlin/issues/1","repository_url":"https://api.github.com/repos/iLCSoft/Marlin","labels_url":"https://api.github.com/repos/iLCSoft/Marlin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/iLCSoft/Marlin/issues/1/comments","events_url":"https://api.github.com/repos/iLCSoft/Marlin/issues/1/events","html_url":"https://github.com/iLCSoft/Marlin/issues/1","id":179000235,"number":1,"title":"StdHepReader.cc not assigning generator status properly","user":{"login":"scipp-ilcadmin","id":16641954,"avatar_url":"https://avatars.githubusercontent.com/u/16641954?v=3","gravatar_id":"","url":"https://api.github.com/users/scipp-ilcadmin","html_url":"https://github.com/scipp-ilcadmin","followers_url":"https://api.github.com/users/scipp-ilcadmin/followers","following_url":"https://api.github.com/users/scipp-ilcadmin/following{/other_user}","gists_url":"https://api.github.com/users/scipp-ilcadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/scipp-ilcadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipp-ilcadmin/subscriptions","organizations_url":"https://api.github.com/users/scipp-ilcadmin/orgs","repos_url":"https://api.github.com/users/scipp-ilcadmin/repos","events_url":"https://api.github.com/users/scipp-ilcadmin/events{/privacy}","received_events_url":"https://api.github.com/users/scipp-ilcadmin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-24T00:37:07Z","updated_at":"2016-12-07T06:54:56Z","closed_at":null,"body":"Hello, \n\nWe have discovered that the driver responsible for converting a stdhep file to a collection of MCParticles within Marlin (StdHepReader.cc) is assigning a generator status of 1 (final state) to EVERY particle in the event. \n\nWhen we analyze the file at the stdhep level (using the StdhepEvent class in the LCSim framework), we see proper generator status assignment. However, after we ran this file through the StdHepReader which converts it to collections of MCParticles, we discovered that each particles had a generator status of 1 (using the getGeneratorStatus() function.) \n\nThis flawed driver can be found here: /cvmfs/ilc.desy.de/sw/x86_64_gcc44_sl6/v01-17-09/Marlin/v01-08/source/src/StdHepReader.cc\n\nI wanted to draw attention to this issue and point out that the LCStdHepReader found in the plcio workspace, works great and can be found here: https://stash.desy.de/projects/IL/repos/plcio/browse/source/utilities/LCStdHepReader.cc\n\nJane Shtalenkova\nyshtalen@ucsc.edu\n"},"comment":{"url":"https://api.github.com/repos/iLCSoft/Marlin/issues/comments/265370648","html_url":"https://github.com/iLCSoft/Marlin/issues/1#issuecomment-265370648","issue_url":"https://api.github.com/repos/iLCSoft/Marlin/issues/1","id":265370648,"user":{"login":"gaede","id":14929044,"avatar_url":"https://avatars.githubusercontent.com/u/14929044?v=3","gravatar_id":"","url":"https://api.github.com/users/gaede","html_url":"https://github.com/gaede","followers_url":"https://api.github.com/users/gaede/followers","following_url":"https://api.github.com/users/gaede/following{/other_user}","gists_url":"https://api.github.com/users/gaede/gists{/gist_id}","starred_url":"https://api.github.com/users/gaede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaede/subscriptions","organizations_url":"https://api.github.com/users/gaede/orgs","repos_url":"https://api.github.com/users/gaede/repos","events_url":"https://api.github.com/users/gaede/events{/privacy}","received_events_url":"https://api.github.com/users/gaede/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T06:54:56Z","updated_at":"2016-12-07T06:54:56Z","body":"I cannot reproduce or understand this problem. The StdHepReader processor does not set the generator status at all but rather uses the [LCStdHepReader.cc](https://github.com/iLCSoft/LCIO/blob/master/src/cpp/src/UTIL/LCStdHepRdr.cc) from LCIO ( which is the original implementation that has been ported to plcio).  Can you provide an example stdhep file where this problem occurs ?"}}
{"actor":{"display_login":"gaede"}}