{"action":"created","issue":{"url":"https://api.github.com/repos/caskdata/cdap/issues/6090","repository_url":"https://api.github.com/repos/caskdata/cdap","labels_url":"https://api.github.com/repos/caskdata/cdap/issues/6090/labels{/name}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6090/comments","events_url":"https://api.github.com/repos/caskdata/cdap/issues/6090/events","html_url":"https://github.com/caskdata/cdap/pull/6090","id":166097628,"number":6090,"title":"(CDAP-888) Added authorization for dataset instance REST APIs","user":{"login":"bdmogal","id":3895099,"avatar_url":"https://avatars.githubusercontent.com/u/3895099?v=3","gravatar_id":"","url":"https://api.github.com/users/bdmogal","html_url":"https://github.com/bdmogal","followers_url":"https://api.github.com/users/bdmogal/followers","following_url":"https://api.github.com/users/bdmogal/following{/other_user}","gists_url":"https://api.github.com/users/bdmogal/gists{/gist_id}","starred_url":"https://api.github.com/users/bdmogal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdmogal/subscriptions","organizations_url":"https://api.github.com/users/bdmogal/orgs","repos_url":"https://api.github.com/users/bdmogal/repos","events_url":"https://api.github.com/users/bdmogal/events{/privacy}","received_events_url":"https://api.github.com/users/bdmogal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/caskdata/cdap/labels/3.5","name":"3.5","color":"ff6600"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-18T13:49:02Z","updated_at":"2016-07-20T01:00:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6090","html_url":"https://github.com/caskdata/cdap/pull/6090","diff_url":"https://github.com/caskdata/cdap/pull/6090.diff","patch_url":"https://github.com/caskdata/cdap/pull/6090.patch"},"body":"- Refactored DatasetServiceTestBase to be able to run tests with authorization enabled as well. However, DatasetServiceTestBase still needs major improvements.\r\n- Refactored/updated AuthorizationTest\r\n\r\nJira: [CDAP-888](https://issues.cask.co/browse/CDAP-888)\r\nBuild: http://builds.cask.co/browse/CDAP-DUT4435"},"comment":{"url":"https://api.github.com/repos/caskdata/cdap/issues/comments/233810361","html_url":"https://github.com/caskdata/cdap/pull/6090#issuecomment-233810361","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6090","id":233810361,"user":{"login":"bdmogal","id":3895099,"avatar_url":"https://avatars.githubusercontent.com/u/3895099?v=3","gravatar_id":"","url":"https://api.github.com/users/bdmogal","html_url":"https://github.com/bdmogal","followers_url":"https://api.github.com/users/bdmogal/followers","following_url":"https://api.github.com/users/bdmogal/following{/other_user}","gists_url":"https://api.github.com/users/bdmogal/gists{/gist_id}","starred_url":"https://api.github.com/users/bdmogal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdmogal/subscriptions","organizations_url":"https://api.github.com/users/bdmogal/orgs","repos_url":"https://api.github.com/users/bdmogal/repos","events_url":"https://api.github.com/users/bdmogal/events{/privacy}","received_events_url":"https://api.github.com/users/bdmogal/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T01:00:02Z","updated_at":"2016-07-20T01:00:02Z","body":"@anwar6953 I have not tested that specific scenario, but currently the code grants all privileges only if dataset creation was successful. If the dataset already exists, we check if the type is compatible, else 'update' it, which will need some privileges, but not grant any privileges. Here is a code snippet from DatasetInstanceCreator, called in the application deployment pipeline:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/3895099/16971675/9b43e01c-4dda-11e6-8447-5af634d8f4a2.png)\r\n"}}
{"actor":{"display_login":"bdmogal"}}