{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19207","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19207/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19207/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19207/events","html_url":"https://github.com/kubernetes/kubernetes/pull/19207","id":124413046,"number":19207,"title":"Enabling DNS support in local-up-cluster.sh","user":{"login":"thibserot","id":386572,"avatar_url":"https://avatars.githubusercontent.com/u/386572?v=3","gravatar_id":"","url":"https://api.github.com/users/thibserot","html_url":"https://github.com/thibserot","followers_url":"https://api.github.com/users/thibserot/followers","following_url":"https://api.github.com/users/thibserot/following{/other_user}","gists_url":"https://api.github.com/users/thibserot/gists{/gist_id}","starred_url":"https://api.github.com/users/thibserot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibserot/subscriptions","organizations_url":"https://api.github.com/users/thibserot/orgs","repos_url":"https://api.github.com/users/thibserot/repos","events_url":"https://api.github.com/users/thibserot/events{/privacy}","received_events_url":"https://api.github.com/users/thibserot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20no","name":"cla: no","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/design","name":"kind/design","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/new-api","name":"kind/new-api","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900"}],"state":"open","locked":false,"assignee":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-12-30T23:20:54Z","updated_at":"2016-02-04T03:55:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19207","html_url":"https://github.com/kubernetes/kubernetes/pull/19207","diff_url":"https://github.com/kubernetes/kubernetes/pull/19207.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19207.patch"},"body":"This modification should enable the support for DNS when setting up the local cluster.\r\nIt is enabled by default (I don't see when we wouldn't want to have DNS resolution).\r\nVariables to control the setup (inspired from doc and cluster/ubuntu/deployAddons.sh):\r\nENABLE_CLUSTER_DNS=${KUBE_ENABLE_CLUSTER_DNS:-true}\r\nDNS_SERVER_IP=${KUBE_DNS_SERVER_IP:-10.0.0.10}\r\nDNS_DOMAIN=${KUBE_DNS_NAME:-\"cluster.local\"}\r\nDNS_REPLICAS=${KUBE_DNS_REPLICAS:-1}\r\nKUBECTL=${KUBECTL:-cluster/kubectl.sh}\r\n\r\n\r\n\r\nThere are two small issue remaining with this:\r\n- Not sure whether we need to run those commands before creating the kube-dns: (it seems to work without....)\r\n>        ${KUBECTL} config set-cluster local --server=http://127.0.0.1:8080 --insecure-skip-tls-verify=true\r\n>        ${KUBECTL} config set-context local --cluster=local\r\n>        ${KUBECTL} config use-context local\r\n\r\n\r\n* Cleanup of the cluster:\r\n  * `${KUBECTL} --namespace=kube-system delete service kube-dns` throw this error:\r\n`Error from server: client: etcd cluster is unavailable or misconfigured`\r\n  * `${KUBECTL} --namespace=kube-system delete rc kube-dns-v10` just hang\r\nThe drawback of not doing the cleanup is that you need to manually kill the etcd process if you want to restart local-up-cluster.sh\r\n\r\nOn top of this the PR includes:\r\n* Possibility to increase the timer to wait for the api_server. It's controlled via `WAIT_FOR_URL_API_SERVER`. default=10 (I've encountered cases where 10sec is not enough)\r\n* Possibility to not run the `while true loop` at the end if you want to start the cluster via a cron for example. It's controlled via `ENABLE_DAEMON`. default: false\r\n\r\nBoth options with their default are behaving as today\r\n\r\nThanks\r\nThibault"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/179609152","html_url":"https://github.com/kubernetes/kubernetes/pull/19207#issuecomment-179609152","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19207","id":179609152,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T03:55:27Z","updated_at":"2016-02-04T03:55:27Z","body":"PR needs rebase"}}