{"action":"created","issue":{"url":"https://api.github.com/repos/cake-build/cake/issues/1306","repository_url":"https://api.github.com/repos/cake-build/cake","labels_url":"https://api.github.com/repos/cake-build/cake/issues/1306/labels{/name}","comments_url":"https://api.github.com/repos/cake-build/cake/issues/1306/comments","events_url":"https://api.github.com/repos/cake-build/cake/issues/1306/events","html_url":"https://github.com/cake-build/cake/pull/1306","id":184390148,"number":1306,"title":"GH1166: refactor MethodAliasGenerator to support optional parameters","user":{"login":"kcamp","id":649593,"avatar_url":"https://avatars.githubusercontent.com/u/649593?v=3","gravatar_id":"","url":"https://api.github.com/users/kcamp","html_url":"https://github.com/kcamp","followers_url":"https://api.github.com/users/kcamp/followers","following_url":"https://api.github.com/users/kcamp/following{/other_user}","gists_url":"https://api.github.com/users/kcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/kcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcamp/subscriptions","organizations_url":"https://api.github.com/users/kcamp/orgs","repos_url":"https://api.github.com/users/kcamp/repos","events_url":"https://api.github.com/users/kcamp/events{/privacy}","received_events_url":"https://api.github.com/users/kcamp/received_events","type":"User","site_admin":false},"labels":[{"id":396836085,"url":"https://api.github.com/repos/cake-build/cake/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":298712749,"url":"https://api.github.com/repos/cake-build/cake/labels/Waiting%20for%20issuer%20feedback","name":"Waiting for issuer feedback","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-21T03:13:03Z","updated_at":"2016-11-01T12:14:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cake-build/cake/pulls/1306","html_url":"https://github.com/cake-build/cake/pull/1306","diff_url":"https://github.com/cake-build/cake/pull/1306.diff","patch_url":"https://github.com/cake-build/cake/pull/1306.patch"},"body":"@devlead \n\nHere is a PR for review to address GH-1166, refactoring the parameter concerns in the method alias tokenizer to support optional params.\n\nI have added a reasonable cover of tests to prove this out, but it is not exhaustive - it does not cover all numerics, etc., but it does cover what I would consider to be the trickier of cases concerning Nullable<T> and so forth.\n\nThere are probably a couple of places where the generated code could be cleaned up for brevity, but as a first pass, I opted to be explicit, particularly in light of the fact that this isn't code that needs to be readable/maintainable, and the emphasis should be on being explicit for the sake of operability.\n\nHappy to re-work or expand test-coverage as it might be deemed necessary.. I'm not saying \"don't merge\", but I think this addition warrants any extra attention we might want to give it.\n"},"comment":{"url":"https://api.github.com/repos/cake-build/cake/issues/comments/257551977","html_url":"https://github.com/cake-build/cake/pull/1306#issuecomment-257551977","issue_url":"https://api.github.com/repos/cake-build/cake/issues/1306","id":257551977,"user":{"login":"kcamp","id":649593,"avatar_url":"https://avatars.githubusercontent.com/u/649593?v=3","gravatar_id":"","url":"https://api.github.com/users/kcamp","html_url":"https://github.com/kcamp","followers_url":"https://api.github.com/users/kcamp/followers","following_url":"https://api.github.com/users/kcamp/following{/other_user}","gists_url":"https://api.github.com/users/kcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/kcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcamp/subscriptions","organizations_url":"https://api.github.com/users/kcamp/orgs","repos_url":"https://api.github.com/users/kcamp/repos","events_url":"https://api.github.com/users/kcamp/events{/privacy}","received_events_url":"https://api.github.com/users/kcamp/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T12:14:04Z","updated_at":"2016-11-01T12:14:04Z","body":"@gep13 to answer your question more directly..  i think we're close to having this working.  see my last comment  for more details.  If we can figure out the last remaining test failure and I can get it fixed up, it should meet requirements and be complete.  I don't know the timeframe you are thinking for 0.17.0, but if I can get a hand on the last remaining issue in Linux/Mono and get things cleaned up, I could potentially have the PR updated with the final bits today/tomorrow."}}
{"actor":{"display_login":"kcamp"}}