{"action":"created","comment":{"url":"https://api.github.com/repos/weecology/retriever/pulls/comments/92119222","pull_request_review_id":12627300,"id":92119222,"diff_hunk":"@@ -30,8 +30,12 @@ def add_dialect(table_dict, table):\n         # dialect related key-value pairs\n         # copied as is\n         if key == \"nulls\":\n-            table_dict[\n-                'cleanup'] = \"Cleanup(correct_invalid_value, nulls=\" + str(val) + \")\"\n+            try: \n+                table_dict[\n+                    'cleanup'] = \"Cleanup(correct_invalid_value, nulls=\" + int(val) + \")\"\n+            except: \n+                table_dict[\n+                    'cleanup'] = \"Cleanup(correct_invalid_value, nulls=\\\"\" + str(val) + \"\\\")\"\n \n         elif key == \"delimiter\":","path":"lib/compile.py","position":null,"original_position":13,"commit_id":"49c9be9e7c2141bf10b9c01c88e80b9b43027f1f","original_commit_id":"b8e322cc07868782ebdcf6d959407c9997ccb3e6","user":{"login":"zhangcandrew","id":15080652,"avatar_url":"https://avatars.githubusercontent.com/u/15080652?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangcandrew","html_url":"https://github.com/zhangcandrew","followers_url":"https://api.github.com/users/zhangcandrew/followers","following_url":"https://api.github.com/users/zhangcandrew/following{/other_user}","gists_url":"https://api.github.com/users/zhangcandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangcandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangcandrew/subscriptions","organizations_url":"https://api.github.com/users/zhangcandrew/orgs","repos_url":"https://api.github.com/users/zhangcandrew/repos","events_url":"https://api.github.com/users/zhangcandrew/events{/privacy}","received_events_url":"https://api.github.com/users/zhangcandrew/received_events","type":"User","site_admin":false},"body":"I looked into this and it seems like this isn't an easy fix, either test will have to be changed, or some other parts of how null values are handled, so for now I've set compile.py back to its original form, and I'll create an issue for this. ","created_at":"2016-12-13T08:39:15Z","updated_at":"2016-12-13T08:39:15Z","html_url":"https://github.com/weecology/retriever/pull/735#discussion_r92119222","pull_request_url":"https://api.github.com/repos/weecology/retriever/pulls/735","_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments/92119222"},"html":{"href":"https://github.com/weecology/retriever/pull/735#discussion_r92119222"},"pull_request":{"href":"https://api.github.com/repos/weecology/retriever/pulls/735"}}},"pull_request":{"url":"https://api.github.com/repos/weecology/retriever/pulls/735","id":97626179,"html_url":"https://github.com/weecology/retriever/pull/735","diff_url":"https://github.com/weecology/retriever/pull/735.diff","patch_url":"https://github.com/weecology/retriever/pull/735.patch","issue_url":"https://api.github.com/repos/weecology/retriever/issues/735","number":735,"state":"open","locked":false,"title":"New json changes","user":{"login":"zhangcandrew","id":15080652,"avatar_url":"https://avatars.githubusercontent.com/u/15080652?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangcandrew","html_url":"https://github.com/zhangcandrew","followers_url":"https://api.github.com/users/zhangcandrew/followers","following_url":"https://api.github.com/users/zhangcandrew/following{/other_user}","gists_url":"https://api.github.com/users/zhangcandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangcandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangcandrew/subscriptions","organizations_url":"https://api.github.com/users/zhangcandrew/orgs","repos_url":"https://api.github.com/users/zhangcandrew/repos","events_url":"https://api.github.com/users/zhangcandrew/events{/privacy}","received_events_url":"https://api.github.com/users/zhangcandrew/received_events","type":"User","site_admin":false},"body":"When we create a new json scripts, the version number is automatically added and\r\nset to 1.0 now, and all table urls are compiled and placed in the urls\r\ndictionary at the end of the scripts, just like in other normal scripts.\r\nNull values previously when inputted in the new_json function would\r\ncause an error during compilation if the null value was a string instead of an int. Null values can now handle both types. This was remedied in my changes to\r\ncompile.py","created_at":"2016-12-12T20:23:16Z","updated_at":"2016-12-13T08:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d2cb311b1f0657ac9ce54d9572b97e03eb5207","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/weecology/retriever/pulls/735/commits","review_comments_url":"https://api.github.com/repos/weecology/retriever/pulls/735/comments","review_comment_url":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weecology/retriever/issues/735/comments","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/49c9be9e7c2141bf10b9c01c88e80b9b43027f1f","head":{"label":"zhangcandrew:newJsonChanges","ref":"newJsonChanges","sha":"49c9be9e7c2141bf10b9c01c88e80b9b43027f1f","user":{"login":"zhangcandrew","id":15080652,"avatar_url":"https://avatars.githubusercontent.com/u/15080652?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangcandrew","html_url":"https://github.com/zhangcandrew","followers_url":"https://api.github.com/users/zhangcandrew/followers","following_url":"https://api.github.com/users/zhangcandrew/following{/other_user}","gists_url":"https://api.github.com/users/zhangcandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangcandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangcandrew/subscriptions","organizations_url":"https://api.github.com/users/zhangcandrew/orgs","repos_url":"https://api.github.com/users/zhangcandrew/repos","events_url":"https://api.github.com/users/zhangcandrew/events{/privacy}","received_events_url":"https://api.github.com/users/zhangcandrew/received_events","type":"User","site_admin":false},"repo":{"id":66673247,"name":"retriever","full_name":"zhangcandrew/retriever","owner":{"login":"zhangcandrew","id":15080652,"avatar_url":"https://avatars.githubusercontent.com/u/15080652?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangcandrew","html_url":"https://github.com/zhangcandrew","followers_url":"https://api.github.com/users/zhangcandrew/followers","following_url":"https://api.github.com/users/zhangcandrew/following{/other_user}","gists_url":"https://api.github.com/users/zhangcandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangcandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangcandrew/subscriptions","organizations_url":"https://api.github.com/users/zhangcandrew/orgs","repos_url":"https://api.github.com/users/zhangcandrew/repos","events_url":"https://api.github.com/users/zhangcandrew/events{/privacy}","received_events_url":"https://api.github.com/users/zhangcandrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhangcandrew/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":true,"url":"https://api.github.com/repos/zhangcandrew/retriever","forks_url":"https://api.github.com/repos/zhangcandrew/retriever/forks","keys_url":"https://api.github.com/repos/zhangcandrew/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhangcandrew/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhangcandrew/retriever/teams","hooks_url":"https://api.github.com/repos/zhangcandrew/retriever/hooks","issue_events_url":"https://api.github.com/repos/zhangcandrew/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/zhangcandrew/retriever/events","assignees_url":"https://api.github.com/repos/zhangcandrew/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/zhangcandrew/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/zhangcandrew/retriever/tags","blobs_url":"https://api.github.com/repos/zhangcandrew/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhangcandrew/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhangcandrew/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhangcandrew/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhangcandrew/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/zhangcandrew/retriever/languages","stargazers_url":"https://api.github.com/repos/zhangcandrew/retriever/stargazers","contributors_url":"https://api.github.com/repos/zhangcandrew/retriever/contributors","subscribers_url":"https://api.github.com/repos/zhangcandrew/retriever/subscribers","subscription_url":"https://api.github.com/repos/zhangcandrew/retriever/subscription","commits_url":"https://api.github.com/repos/zhangcandrew/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhangcandrew/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhangcandrew/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhangcandrew/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhangcandrew/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/zhangcandrew/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhangcandrew/retriever/merges","archive_url":"https://api.github.com/repos/zhangcandrew/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhangcandrew/retriever/downloads","issues_url":"https://api.github.com/repos/zhangcandrew/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/zhangcandrew/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/zhangcandrew/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/zhangcandrew/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhangcandrew/retriever/labels{/name}","releases_url":"https://api.github.com/repos/zhangcandrew/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/zhangcandrew/retriever/deployments","created_at":"2016-08-26T19:14:14Z","updated_at":"2016-10-24T19:21:19Z","pushed_at":"2016-12-13T08:37:35Z","git_url":"git://github.com/zhangcandrew/retriever.git","ssh_url":"git@github.com:zhangcandrew/retriever.git","clone_url":"https://github.com/zhangcandrew/retriever.git","svn_url":"https://github.com/zhangcandrew/retriever","homepage":"http://ecodataretriever.org","size":2909,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"weecology:master","ref":"master","sha":"e03695ce5d3fcd4a7b8b13aedf930f471d40b451","user":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"repo":{"id":1968190,"name":"retriever","full_name":"weecology/retriever","owner":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weecology/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":false,"url":"https://api.github.com/repos/weecology/retriever","forks_url":"https://api.github.com/repos/weecology/retriever/forks","keys_url":"https://api.github.com/repos/weecology/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weecology/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weecology/retriever/teams","hooks_url":"https://api.github.com/repos/weecology/retriever/hooks","issue_events_url":"https://api.github.com/repos/weecology/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/weecology/retriever/events","assignees_url":"https://api.github.com/repos/weecology/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/weecology/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/weecology/retriever/tags","blobs_url":"https://api.github.com/repos/weecology/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weecology/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weecology/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/weecology/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/weecology/retriever/languages","stargazers_url":"https://api.github.com/repos/weecology/retriever/stargazers","contributors_url":"https://api.github.com/repos/weecology/retriever/contributors","subscribers_url":"https://api.github.com/repos/weecology/retriever/subscribers","subscription_url":"https://api.github.com/repos/weecology/retriever/subscription","commits_url":"https://api.github.com/repos/weecology/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/weecology/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/weecology/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/weecology/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/weecology/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/weecology/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weecology/retriever/merges","archive_url":"https://api.github.com/repos/weecology/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weecology/retriever/downloads","issues_url":"https://api.github.com/repos/weecology/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/weecology/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/weecology/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/weecology/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weecology/retriever/labels{/name}","releases_url":"https://api.github.com/repos/weecology/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/weecology/retriever/deployments","created_at":"2011-06-28T19:01:15Z","updated_at":"2016-11-04T20:51:15Z","pushed_at":"2016-12-13T08:37:36Z","git_url":"git://github.com/weecology/retriever.git","ssh_url":"git@github.com:weecology/retriever.git","clone_url":"https://github.com/weecology/retriever.git","svn_url":"https://github.com/weecology/retriever","homepage":"http://data-retriever.org","size":48506,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":72,"forks":34,"open_issues":72,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/735"},"html":{"href":"https://github.com/weecology/retriever/pull/735"},"issue":{"href":"https://api.github.com/repos/weecology/retriever/issues/735"},"comments":{"href":"https://api.github.com/repos/weecology/retriever/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/weecology/retriever/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weecology/retriever/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/weecology/retriever/statuses/49c9be9e7c2141bf10b9c01c88e80b9b43027f1f"}}}}
{"actor":{"display_login":"zhangcandrew"}}