{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/82699262","pull_request_review_id":3588725,"id":82699262,"diff_hunk":"@@ -0,0 +1,37 @@\n+<?xml version=\"1.0\" ?>\n+\n+<!DOCTYPE module PUBLIC\n+    \"-//Puppy Crawl//DTD Check Configuration 1.2//EN\"\n+    \"http://www.puppycrawl.com/dtds/configuration_1_2.dtd\">\n+\n+<!--\n+  ~ Licensed to Metamarkets Group Inc. (Metamarkets) under one\n+  ~ or more contributor license agreements. See the NOTICE file\n+  ~ distributed with this work for additional information\n+  ~ regarding copyright ownership. Metamarkets licenses this file\n+  ~ to you under the Apache License, Version 2.0 (the\n+  ~ \"License\"); you may not use this file except in compliance\n+  ~ with the License. You may obtain a copy of the License at\n+  ~\n+  ~ http://www.apache.org/licenses/LICENSE-2.0\n+  ~\n+  ~ Unless required by applicable law or agreed to in writing,\n+  ~ software distributed under the License is distributed on an\n+  ~ \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+  ~ KIND, either express or implied. See the License for the\n+  ~ specific language governing permissions and limitations\n+  ~ under the License.\n+  -->\n+\n+<module name=\"Checker\">\n+  <module name=\"TreeWalker\">\n+    <!-- See http://checkstyle.sourceforge.net/checks.html for examples -->\n+\n+    <!--<module name=\"LineLength\">-->\n+      <!--<property name=\"max\" value=\"120\"/>-->\n+    <!--</module>-->\n+    <module name=\"AvoidStarImport\"/>\n+    <module name=\"RedundantImport\"/>\n+    <module name=\"NeedBraces\"/>\n+  </module>\n+</module>","path":"codestyle/checkstyle.xml","position":37,"original_position":37,"commit_id":"641c16b0b0014d78120b039ea2ea0457f517ab23","original_commit_id":"641c16b0b0014d78120b039ea2ea0457f517ab23","user":{"login":"logarithm","id":427623,"avatar_url":"https://avatars.githubusercontent.com/u/427623?v=3","gravatar_id":"","url":"https://api.github.com/users/logarithm","html_url":"https://github.com/logarithm","followers_url":"https://api.github.com/users/logarithm/followers","following_url":"https://api.github.com/users/logarithm/following{/other_user}","gists_url":"https://api.github.com/users/logarithm/gists{/gist_id}","starred_url":"https://api.github.com/users/logarithm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logarithm/subscriptions","organizations_url":"https://api.github.com/users/logarithm/orgs","repos_url":"https://api.github.com/users/logarithm/repos","events_url":"https://api.github.com/users/logarithm/events{/privacy}","received_events_url":"https://api.github.com/users/logarithm/received_events","type":"User","site_admin":false},"body":"Should it be a new line in the end of the file?","created_at":"2016-10-10T23:06:50Z","updated_at":"2016-10-10T23:07:52Z","html_url":"https://github.com/druid-io/druid/pull/3551#discussion_r82699262","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/3551","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/82699262"},"html":{"href":"https://github.com/druid-io/druid/pull/3551#discussion_r82699262"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3551"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3551","id":88360866,"html_url":"https://github.com/druid-io/druid/pull/3551","diff_url":"https://github.com/druid-io/druid/pull/3551.diff","patch_url":"https://github.com/druid-io/druid/pull/3551.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3551","number":3551,"state":"open","locked":false,"title":"Add Checkstyle framework","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"body":"Fixes #3533.\r\n\r\nThis PR just adds the Checkstyle framework without enforcing any rules yet; they are supposed to be added one-by-one in different PRs.\r\n\r\nCheckstyle's XML configs are placed in a directory named `codestyle` because there is an intention to move `druid_intellij_formatting.xml`, `eclipse_formatting.xml` and `eclipse.importorder` there eventually.","created_at":"2016-10-06T23:46:15Z","updated_at":"2016-10-10T23:07:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0eb2755c89e4b9d21e5c9502a52b2c3eb25c954","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/3551/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/3551/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3551/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/641c16b0b0014d78120b039ea2ea0457f517ab23","head":{"label":"leventov:checkstyle","ref":"checkstyle","sha":"641c16b0b0014d78120b039ea2ea0457f517ab23","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"repo":{"id":67235495,"name":"druid","full_name":"leventov/druid","owner":{"login":"leventov","id":609240,"avatar_url":"https://avatars.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leventov/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/leventov/druid","forks_url":"https://api.github.com/repos/leventov/druid/forks","keys_url":"https://api.github.com/repos/leventov/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leventov/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leventov/druid/teams","hooks_url":"https://api.github.com/repos/leventov/druid/hooks","issue_events_url":"https://api.github.com/repos/leventov/druid/issues/events{/number}","events_url":"https://api.github.com/repos/leventov/druid/events","assignees_url":"https://api.github.com/repos/leventov/druid/assignees{/user}","branches_url":"https://api.github.com/repos/leventov/druid/branches{/branch}","tags_url":"https://api.github.com/repos/leventov/druid/tags","blobs_url":"https://api.github.com/repos/leventov/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leventov/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leventov/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/leventov/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leventov/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/leventov/druid/languages","stargazers_url":"https://api.github.com/repos/leventov/druid/stargazers","contributors_url":"https://api.github.com/repos/leventov/druid/contributors","subscribers_url":"https://api.github.com/repos/leventov/druid/subscribers","subscription_url":"https://api.github.com/repos/leventov/druid/subscription","commits_url":"https://api.github.com/repos/leventov/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/leventov/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/leventov/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/leventov/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/leventov/druid/contents/{+path}","compare_url":"https://api.github.com/repos/leventov/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leventov/druid/merges","archive_url":"https://api.github.com/repos/leventov/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leventov/druid/downloads","issues_url":"https://api.github.com/repos/leventov/druid/issues{/number}","pulls_url":"https://api.github.com/repos/leventov/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/leventov/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/leventov/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leventov/druid/labels{/name}","releases_url":"https://api.github.com/repos/leventov/druid/releases{/id}","deployments_url":"https://api.github.com/repos/leventov/druid/deployments","created_at":"2016-09-02T15:48:17Z","updated_at":"2016-09-02T15:48:26Z","pushed_at":"2016-10-07T15:57:06Z","git_url":"git://github.com/leventov/druid.git","ssh_url":"git@github.com:leventov/druid.git","clone_url":"https://github.com/leventov/druid.git","svn_url":"https://github.com/leventov/druid","homepage":"http://druid.io","size":109877,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"76a60a007e056d6dc9a228d8cf1f20832225038c","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2016-10-10T12:25:50Z","pushed_at":"2016-10-10T19:28:07Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":157141,"stargazers_count":3785,"watchers_count":3785,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":890,"mirror_url":null,"open_issues_count":548,"forks":890,"open_issues":548,"watchers":3785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3551"},"html":{"href":"https://github.com/druid-io/druid/pull/3551"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/3551"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/3551/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3551/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3551/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/641c16b0b0014d78120b039ea2ea0457f517ab23"}}}}
{"actor":{"display_login":"logarithm"}}