{"action":"created","issue":{"url":"https://api.github.com/repos/googlefonts/fontbakery/issues/932","repository_url":"https://api.github.com/repos/googlefonts/fontbakery","labels_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/932/labels{/name}","comments_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/932/comments","events_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/932/events","html_url":"https://github.com/googlefonts/fontbakery/issues/932","id":170424769,"number":932,"title":"DC: TODO: checker for proper italic names in name table","user":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/googlefonts/fontbakery/labels/P0%20Urgent","name":"P0 Urgent","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"assignees":[{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/googlefonts/fontbakery/milestones/50","html_url":"https://github.com/googlefonts/fontbakery/milestones/0.1.0","labels_url":"https://api.github.com/repos/googlefonts/fontbakery/milestones/50/labels","id":1647142,"number":50,"title":"0.1.0","description":"","creator":{"login":"davelab6","id":261579,"avatar_url":"https://avatars.githubusercontent.com/u/261579?v=3","gravatar_id":"","url":"https://api.github.com/users/davelab6","html_url":"https://github.com/davelab6","followers_url":"https://api.github.com/users/davelab6/followers","following_url":"https://api.github.com/users/davelab6/following{/other_user}","gists_url":"https://api.github.com/users/davelab6/gists{/gist_id}","starred_url":"https://api.github.com/users/davelab6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelab6/subscriptions","organizations_url":"https://api.github.com/users/davelab6/orgs","repos_url":"https://api.github.com/users/davelab6/repos","events_url":"https://api.github.com/users/davelab6/events{/privacy}","received_events_url":"https://api.github.com/users/davelab6/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":81,"state":"open","created_at":"2016-03-16T03:52:51Z","updated_at":"2016-08-18T19:55:45Z","due_on":"2016-08-31T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-08-10T14:02:00Z","updated_at":"2016-08-18T20:48:07Z","closed_at":null,"body":"```\r\n    # ----------------------------------------------------\r\n    # TODO: checker for proper italic names in name table\r\n    # Dave Crossland said: THIS IS URGENT!\r\n```\r\n\r\nthis is probably tightly related to issue #930 and #931 \r\n\r\n(issue #924)\r\n"},"comment":{"url":"https://api.github.com/repos/googlefonts/fontbakery/issues/comments/240851755","html_url":"https://github.com/googlefonts/fontbakery/issues/932#issuecomment-240851755","issue_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/932","id":240851755,"user":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T20:48:07Z","updated_at":"2016-08-18T20:48:07Z","body":"@davelab6 I believe that the check called \"Assure valid format for the main entries in the name table.\" already takes care of validating the correctness of all name table strings. The italic name entries are a specific case of that.\r\n\r\nThe \"Assure valid format for the main entries in the name table.\" check starts at https://github.com/googlefonts/fontbakery/blob/7d284ab1777bc13bd48c500faacfa4f263c1a642/fontbakery-check-ttf.py#L971\r\n\r\nUnless I am missing something, there's nothing left to be done here other than deleting this TODO comment from the source code."}}
{"actor":{"display_login":"felipesanches"}}