{"action":"created","issue":{"url":"https://api.github.com/repos/iTXTech/Genisys/issues/1883","repository_url":"https://api.github.com/repos/iTXTech/Genisys","labels_url":"https://api.github.com/repos/iTXTech/Genisys/issues/1883/labels{/name}","comments_url":"https://api.github.com/repos/iTXTech/Genisys/issues/1883/comments","events_url":"https://api.github.com/repos/iTXTech/Genisys/issues/1883/events","html_url":"https://github.com/iTXTech/Genisys/pull/1883","id":175352675,"number":1883,"title":"Safer method for disabling log at runtime","user":{"login":"dktapps","id":14214667,"avatar_url":"https://avatars.githubusercontent.com/u/14214667?v=3","gravatar_id":"","url":"https://api.github.com/users/dktapps","html_url":"https://github.com/dktapps","followers_url":"https://api.github.com/users/dktapps/followers","following_url":"https://api.github.com/users/dktapps/following{/other_user}","gists_url":"https://api.github.com/users/dktapps/gists{/gist_id}","starred_url":"https://api.github.com/users/dktapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktapps/subscriptions","organizations_url":"https://api.github.com/users/dktapps/orgs","repos_url":"https://api.github.com/users/dktapps/repos","events_url":"https://api.github.com/users/dktapps/events{/privacy}","received_events_url":"https://api.github.com/users/dktapps/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-06T21:09:33Z","updated_at":"2016-09-07T14:43:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iTXTech/Genisys/pulls/1883","html_url":"https://github.com/iTXTech/Genisys/pull/1883","diff_url":"https://github.com/iTXTech/Genisys/pull/1883.diff","patch_url":"https://github.com/iTXTech/Genisys/pull/1883.patch"},"body":"### Description\r\nThis **may** fix the issue outlined in #1709. \r\n\r\n### Reason to modify\r\nPreviously, the logger writing to file is enabled by default, and will log a couple of lines before it is disabled. Now, I'm not 100% sure what's going on, but the `synchronized` combined with the fact that the logging to file will be unceremoniously broken off when the log is disabled by config led me to this.\r\n\r\nThis is a cleaner solution which only affects the actual file content writing. File write is also off by default, so it will only start when the config is loaded.\r\n\r\n### Tests & Reviews\r\n<!-- Uncomment based on the situation -->\r\nI have tested the code and it doesn't crash or cause any noticeable issues. However,  I cannot verify whether it fixes the aforementioned issue or not. Please test and review.\r\n\r\n<!-- Please review things below: -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/iTXTech/Genisys/issues/comments/245302982","html_url":"https://github.com/iTXTech/Genisys/pull/1883#issuecomment-245302982","issue_url":"https://api.github.com/repos/iTXTech/Genisys/issues/1883","id":245302982,"user":{"login":"ZedCee","id":20411465,"avatar_url":"https://avatars.githubusercontent.com/u/20411465?v=3","gravatar_id":"","url":"https://api.github.com/users/ZedCee","html_url":"https://github.com/ZedCee","followers_url":"https://api.github.com/users/ZedCee/followers","following_url":"https://api.github.com/users/ZedCee/following{/other_user}","gists_url":"https://api.github.com/users/ZedCee/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedCee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedCee/subscriptions","organizations_url":"https://api.github.com/users/ZedCee/orgs","repos_url":"https://api.github.com/users/ZedCee/repos","events_url":"https://api.github.com/users/ZedCee/events{/privacy}","received_events_url":"https://api.github.com/users/ZedCee/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T14:43:00Z","updated_at":"2016-09-07T14:43:00Z","body":"Does not appear to crash the server on start anymore.  Logs can mostly be disabled, albeit it still produces the empty `server.log`.  Of no consequence for size, but some may not like the clutter.\r\n\r\nTested +1"}}
{"actor":{"display_login":"ZedCee"}}