{"action":"created","issue":{"url":"https://api.github.com/repos/Sylius/Sylius/issues/3907","labels_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907/labels{/name}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907/comments","events_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907/events","html_url":"https://github.com/Sylius/Sylius/pull/3907","id":127212934,"number":3907,"title":"[Core] Shipment taxes","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Sylius/Sylius/labels/Awaiting%20Review","name":"Awaiting Review","color":"1abb9c"},{"url":"https://api.github.com/repos/Sylius/Sylius/labels/New%20Feature","name":"New Feature","color":"64CF1D"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Sylius/Sylius/milestones/4","html_url":"https://github.com/Sylius/Sylius/milestones/v0.17.0","labels_url":"https://api.github.com/repos/Sylius/Sylius/milestones/4/labels","id":1104562,"number":4,"title":"v0.17.0","description":"Version v0.17.0 of Sylius platform.","creator":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":11,"state":"open","created_at":"2015-05-11T11:10:11Z","updated_at":"2016-01-26T12:10:59Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-01-18T12:01:13Z","updated_at":"2016-01-26T12:11:06Z","closed_at":"2016-01-26T12:10:59Z","pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/3907","html_url":"https://github.com/Sylius/Sylius/pull/3907","diff_url":"https://github.com/Sylius/Sylius/pull/3907.diff","patch_url":"https://github.com/Sylius/Sylius/pull/3907.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nThis PR is based on https://github.com/Sylius/Sylius/pull/3868.\r\n\r\nHere there comes some next improvements with taxes ;) ``ShippingMethod`` becomes *taxable* so no we can apply some new taxes based on shipping fee. For now, taxes are applied on ``Order`` level. There are also two new services ``OrderUnitsTaxesApplicator`` and ``OrderShipmentTaxesApplicator`` (I think naming should be discussed), which are injected to main ``OrderTaxesApplicator``, to split taxes-application logic."},"comment":{"url":"https://api.github.com/repos/Sylius/Sylius/issues/comments/174975487","html_url":"https://github.com/Sylius/Sylius/pull/3907#issuecomment-174975487","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907","id":174975487,"user":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T12:11:06Z","updated_at":"2016-01-26T12:11:06Z","body":"Wooo, great work Mateusz! :+1: "}}