{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/comments/51503325","id":51503325,"diff_hunk":"@@ -220,7 +219,7 @@ function annotateElement(descriptor, behaviorsByName) {\n  * @param {Object} descriptor behavior descriptor\n  * @return {Object} descriptor passed in as param\n  */\n-function annotateBehavior(descriptor, behaviorsByName) {\n+export function annotateBehavior(descriptor:BehaviorDescriptor) {","path":"src/ast-utils/docs.ts","position":133,"original_position":133,"commit_id":"5dc55e11ecfdceeb135d691e5e32de2d8f0633bc","original_commit_id":"5dc55e11ecfdceeb135d691e5e32de2d8f0633bc","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-02-02T00:14:08Z","updated_at":"2016-02-02T00:14:08Z","html_url":"https://github.com/Polymer/hydrolysis/pull/209#discussion_r51503325","pull_request_url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/comments/51503325"},"html":{"href":"https://github.com/Polymer/hydrolysis/pull/209#discussion_r51503325"},"pull_request":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209","id":56986073,"html_url":"https://github.com/Polymer/hydrolysis/pull/209","diff_url":"https://github.com/Polymer/hydrolysis/pull/209.diff","patch_url":"https://github.com/Polymer/hydrolysis/pull/209.patch","issue_url":"https://api.github.com/repos/Polymer/hydrolysis/issues/209","number":209,"state":"open","locked":false,"title":"Convert hydrolysis to typescript","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"- typechecks cleanly with no warnings or errors and only a couple of places where I had to use `any` to opt out of type checking\r\n- added babel to the build as well so that we can use all ES2015 features + [async/await](https://jakearchibald.com/2014/es7-async-functions/)\r\n- made the minimal reasonable changes. e.g. converted class-patterned objects to ES2015 classes, left the rest alone\r\n  - That said, there was one function whose promise logic was so convoluted that I needed to convert it to async/await just so I could get it to type check.\r\n- Added type annotations for a few node modules and estree. Will upstream those, there's a package manager for type annotations. `npm run init` will install the ones we use.\r\n- Introduces one potentially backward-incompat change for node dependents. It seems like the semantics for exporting a default symbol in ES2015 are different than `module.exports = ...`\r\n  - so `new require('hydrolysis/loader/fs-resolver')` should become `new require('hydrolysis/loader/fs-resolver').FSResolver`\r\n  - `require('hydrolysis').FSResolver` and friends are unchanged, it's only when code is requiring stuff from `hydrolysis/...`, which strikes me as unlikely to break many people , as we re-export most symbols from the main `index.js`\r\n\r\nOpen questions:\r\n  - still looking for a good documentation generator for typescript. I poked around with typedoc briefly but it didn't work very well for me\r\n\r\n\r\nI'm excluding hydrolysis.js from this PR so that the diff isn't swamped, `npm build` still works fine, as does `npm test`.\r\n\r\n/cc @justinfagnani @azakus ","created_at":"2016-01-23T20:45:45Z","updated_at":"2016-02-02T00:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb74384409abdf6aeba663d480ac4560f7982e3d","assignee":{"login":"garlicnation","id":1105965,"avatar_url":"https://avatars.githubusercontent.com/u/1105965?v=3","gravatar_id":"","url":"https://api.github.com/users/garlicnation","html_url":"https://github.com/garlicnation","followers_url":"https://api.github.com/users/garlicnation/followers","following_url":"https://api.github.com/users/garlicnation/following{/other_user}","gists_url":"https://api.github.com/users/garlicnation/gists{/gist_id}","starred_url":"https://api.github.com/users/garlicnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garlicnation/subscriptions","organizations_url":"https://api.github.com/users/garlicnation/orgs","repos_url":"https://api.github.com/users/garlicnation/repos","events_url":"https://api.github.com/users/garlicnation/events{/privacy}","received_events_url":"https://api.github.com/users/garlicnation/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209/commits","review_comments_url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209/comments","review_comment_url":"https://api.github.com/repos/Polymer/hydrolysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/hydrolysis/issues/209/comments","statuses_url":"https://api.github.com/repos/Polymer/hydrolysis/statuses/5dc55e11ecfdceeb135d691e5e32de2d8f0633bc","head":{"label":"rictic:typescript-experiment","ref":"typescript-experiment","sha":"5dc55e11ecfdceeb135d691e5e32de2d8f0633bc","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"repo":{"id":46626358,"name":"hydrolysis","full_name":"rictic/hydrolysis","owner":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rictic/hydrolysis","description":"A utility for analyzing polymer elements.","fork":true,"url":"https://api.github.com/repos/rictic/hydrolysis","forks_url":"https://api.github.com/repos/rictic/hydrolysis/forks","keys_url":"https://api.github.com/repos/rictic/hydrolysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rictic/hydrolysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rictic/hydrolysis/teams","hooks_url":"https://api.github.com/repos/rictic/hydrolysis/hooks","issue_events_url":"https://api.github.com/repos/rictic/hydrolysis/issues/events{/number}","events_url":"https://api.github.com/repos/rictic/hydrolysis/events","assignees_url":"https://api.github.com/repos/rictic/hydrolysis/assignees{/user}","branches_url":"https://api.github.com/repos/rictic/hydrolysis/branches{/branch}","tags_url":"https://api.github.com/repos/rictic/hydrolysis/tags","blobs_url":"https://api.github.com/repos/rictic/hydrolysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rictic/hydrolysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rictic/hydrolysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/rictic/hydrolysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rictic/hydrolysis/statuses/{sha}","languages_url":"https://api.github.com/repos/rictic/hydrolysis/languages","stargazers_url":"https://api.github.com/repos/rictic/hydrolysis/stargazers","contributors_url":"https://api.github.com/repos/rictic/hydrolysis/contributors","subscribers_url":"https://api.github.com/repos/rictic/hydrolysis/subscribers","subscription_url":"https://api.github.com/repos/rictic/hydrolysis/subscription","commits_url":"https://api.github.com/repos/rictic/hydrolysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/rictic/hydrolysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/rictic/hydrolysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/rictic/hydrolysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/rictic/hydrolysis/contents/{+path}","compare_url":"https://api.github.com/repos/rictic/hydrolysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rictic/hydrolysis/merges","archive_url":"https://api.github.com/repos/rictic/hydrolysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rictic/hydrolysis/downloads","issues_url":"https://api.github.com/repos/rictic/hydrolysis/issues{/number}","pulls_url":"https://api.github.com/repos/rictic/hydrolysis/pulls{/number}","milestones_url":"https://api.github.com/repos/rictic/hydrolysis/milestones{/number}","notifications_url":"https://api.github.com/repos/rictic/hydrolysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rictic/hydrolysis/labels{/name}","releases_url":"https://api.github.com/repos/rictic/hydrolysis/releases{/id}","deployments_url":"https://api.github.com/repos/rictic/hydrolysis/deployments","created_at":"2015-11-21T17:47:11Z","updated_at":"2015-11-21T17:47:14Z","pushed_at":"2016-01-28T20:46:29Z","git_url":"git://github.com/rictic/hydrolysis.git","ssh_url":"git@github.com:rictic/hydrolysis.git","clone_url":"https://github.com/rictic/hydrolysis.git","svn_url":"https://github.com/rictic/hydrolysis","homepage":"","size":17411,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"f4ed55c4edd86bbd36bcb174c0ef1b6b5661b09e","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":30035812,"name":"hydrolysis","full_name":"Polymer/hydrolysis","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/hydrolysis","description":"A utility for analyzing polymer elements.","fork":false,"url":"https://api.github.com/repos/Polymer/hydrolysis","forks_url":"https://api.github.com/repos/Polymer/hydrolysis/forks","keys_url":"https://api.github.com/repos/Polymer/hydrolysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/hydrolysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/hydrolysis/teams","hooks_url":"https://api.github.com/repos/Polymer/hydrolysis/hooks","issue_events_url":"https://api.github.com/repos/Polymer/hydrolysis/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/hydrolysis/events","assignees_url":"https://api.github.com/repos/Polymer/hydrolysis/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/hydrolysis/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/hydrolysis/tags","blobs_url":"https://api.github.com/repos/Polymer/hydrolysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/hydrolysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/hydrolysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/hydrolysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/hydrolysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/hydrolysis/languages","stargazers_url":"https://api.github.com/repos/Polymer/hydrolysis/stargazers","contributors_url":"https://api.github.com/repos/Polymer/hydrolysis/contributors","subscribers_url":"https://api.github.com/repos/Polymer/hydrolysis/subscribers","subscription_url":"https://api.github.com/repos/Polymer/hydrolysis/subscription","commits_url":"https://api.github.com/repos/Polymer/hydrolysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/hydrolysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/hydrolysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/hydrolysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/hydrolysis/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/hydrolysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/hydrolysis/merges","archive_url":"https://api.github.com/repos/Polymer/hydrolysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/hydrolysis/downloads","issues_url":"https://api.github.com/repos/Polymer/hydrolysis/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/hydrolysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/hydrolysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/hydrolysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/hydrolysis/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/hydrolysis/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/hydrolysis/deployments","created_at":"2015-01-29T18:56:38Z","updated_at":"2016-02-01T06:33:29Z","pushed_at":"2016-01-29T21:31:09Z","git_url":"git://github.com/Polymer/hydrolysis.git","ssh_url":"git@github.com:Polymer/hydrolysis.git","clone_url":"https://github.com/Polymer/hydrolysis.git","svn_url":"https://github.com/Polymer/hydrolysis","homepage":"","size":20209,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":35,"forks":27,"open_issues":35,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209"},"html":{"href":"https://github.com/Polymer/hydrolysis/pull/209"},"issue":{"href":"https://api.github.com/repos/Polymer/hydrolysis/issues/209"},"comments":{"href":"https://api.github.com/repos/Polymer/hydrolysis/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/hydrolysis/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/hydrolysis/statuses/5dc55e11ecfdceeb135d691e5e32de2d8f0633bc"}}}}