{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/comments/69531016","id":69531016,"diff_hunk":"@@ -258,26 +345,75 @@ def ts_codec_extract_path_key_value(path, data, filter_table, depth)\n     end # branch, v iteration over hash passed down\n   end # ts_codec_extract_path_key_value\n \n+  private\n+  def decode_kv_table(table,evs)","path":"lib/logstash/codecs/telemetry.rb","position":181,"original_position":181,"commit_id":"9200242bf239d99f401119946b20850055a8373f","original_commit_id":"9200242bf239d99f401119946b20850055a8373f","user":{"login":"ccassar","id":6785238,"avatar_url":"https://avatars.githubusercontent.com/u/6785238?v=3","gravatar_id":"","url":"https://api.github.com/users/ccassar","html_url":"https://github.com/ccassar","followers_url":"https://api.github.com/users/ccassar/followers","following_url":"https://api.github.com/users/ccassar/following{/other_user}","gists_url":"https://api.github.com/users/ccassar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccassar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccassar/subscriptions","organizations_url":"https://api.github.com/users/ccassar/orgs","repos_url":"https://api.github.com/users/ccassar/repos","events_url":"https://api.github.com/users/ccassar/events{/privacy}","received_events_url":"https://api.github.com/users/ccassar/received_events","type":"User","site_admin":false},"body":"A more generous function name might work better here. E.g. produce_event_from_gpbkv_stream. A comment including an excerpt from the .proto might make it easier to follow too.","created_at":"2016-07-05T09:18:31Z","updated_at":"2016-07-05T09:18:31Z","html_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1#discussion_r69531016","pull_request_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/comments/69531016"},"html":{"href":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1#discussion_r69531016"},"pull_request":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1","id":74411639,"html_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1","diff_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1.diff","patch_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1.patch","issue_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/1","number":1,"state":"open","locked":false,"title":"telemetry plugin supports both json and gpb content transported over tcp","user":{"login":"ChenxiDu","id":19994643,"avatar_url":"https://avatars.githubusercontent.com/u/19994643?v=3","gravatar_id":"","url":"https://api.github.com/users/ChenxiDu","html_url":"https://github.com/ChenxiDu","followers_url":"https://api.github.com/users/ChenxiDu/followers","following_url":"https://api.github.com/users/ChenxiDu/following{/other_user}","gists_url":"https://api.github.com/users/ChenxiDu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenxiDu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenxiDu/subscriptions","organizations_url":"https://api.github.com/users/ChenxiDu/orgs","repos_url":"https://api.github.com/users/ChenxiDu/repos","events_url":"https://api.github.com/users/ChenxiDu/events{/privacy}","received_events_url":"https://api.github.com/users/ChenxiDu/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-20T09:15:11Z","updated_at":"2016-07-05T09:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51d38a58259e57757ca93f248a912c747bc19c79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/1/comments","statuses_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/statuses/9200242bf239d99f401119946b20850055a8373f","head":{"label":"ChenxiDu:master","ref":"master","sha":"9200242bf239d99f401119946b20850055a8373f","user":{"login":"ChenxiDu","id":19994643,"avatar_url":"https://avatars.githubusercontent.com/u/19994643?v=3","gravatar_id":"","url":"https://api.github.com/users/ChenxiDu","html_url":"https://github.com/ChenxiDu","followers_url":"https://api.github.com/users/ChenxiDu/followers","following_url":"https://api.github.com/users/ChenxiDu/following{/other_user}","gists_url":"https://api.github.com/users/ChenxiDu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenxiDu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenxiDu/subscriptions","organizations_url":"https://api.github.com/users/ChenxiDu/orgs","repos_url":"https://api.github.com/users/ChenxiDu/repos","events_url":"https://api.github.com/users/ChenxiDu/events{/privacy}","received_events_url":"https://api.github.com/users/ChenxiDu/received_events","type":"User","site_admin":false},"repo":{"id":61532968,"name":"logstash-codec-bigmuddy-network-telemetry","full_name":"ChenxiDu/logstash-codec-bigmuddy-network-telemetry","owner":{"login":"ChenxiDu","id":19994643,"avatar_url":"https://avatars.githubusercontent.com/u/19994643?v=3","gravatar_id":"","url":"https://api.github.com/users/ChenxiDu","html_url":"https://github.com/ChenxiDu","followers_url":"https://api.github.com/users/ChenxiDu/followers","following_url":"https://api.github.com/users/ChenxiDu/following{/other_user}","gists_url":"https://api.github.com/users/ChenxiDu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenxiDu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenxiDu/subscriptions","organizations_url":"https://api.github.com/users/ChenxiDu/orgs","repos_url":"https://api.github.com/users/ChenxiDu/repos","events_url":"https://api.github.com/users/ChenxiDu/events{/privacy}","received_events_url":"https://api.github.com/users/ChenxiDu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChenxiDu/logstash-codec-bigmuddy-network-telemetry","description":"Logstash codec used to receive compressed, JSON encoded network telemetry over TCP and produce logstash events.","fork":true,"url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry","forks_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/forks","keys_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/teams","hooks_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/hooks","issue_events_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/issues/events{/number}","events_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/events","assignees_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/assignees{/user}","branches_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/branches{/branch}","tags_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/tags","blobs_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/statuses/{sha}","languages_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/languages","stargazers_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/stargazers","contributors_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/contributors","subscribers_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/subscribers","subscription_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/subscription","commits_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/contents/{+path}","compare_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/merges","archive_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/downloads","issues_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/issues{/number}","pulls_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/pulls{/number}","milestones_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/milestones{/number}","notifications_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/labels{/name}","releases_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/releases{/id}","deployments_url":"https://api.github.com/repos/ChenxiDu/logstash-codec-bigmuddy-network-telemetry/deployments","created_at":"2016-06-20T09:09:18Z","updated_at":"2016-06-20T09:09:19Z","pushed_at":"2016-06-20T09:14:33Z","git_url":"git://github.com/ChenxiDu/logstash-codec-bigmuddy-network-telemetry.git","ssh_url":"git@github.com:ChenxiDu/logstash-codec-bigmuddy-network-telemetry.git","clone_url":"https://github.com/ChenxiDu/logstash-codec-bigmuddy-network-telemetry.git","svn_url":"https://github.com/ChenxiDu/logstash-codec-bigmuddy-network-telemetry","homepage":"","size":20,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cisco:master","ref":"master","sha":"92c9ac6f18433512cc46e8a42a2dacd9dfec18dd","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":46729182,"name":"logstash-codec-bigmuddy-network-telemetry","full_name":"cisco/logstash-codec-bigmuddy-network-telemetry","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry","description":"Logstash codec used to receive compressed, JSON encoded network telemetry over TCP and produce logstash events.","fork":false,"url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry","forks_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/forks","keys_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/teams","hooks_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/hooks","issue_events_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/events","assignees_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/tags","blobs_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/languages","stargazers_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/stargazers","contributors_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/contributors","subscribers_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/subscribers","subscription_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/subscription","commits_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/merges","archive_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/downloads","issues_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/labels{/name}","releases_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/deployments","created_at":"2015-11-23T15:26:25Z","updated_at":"2016-04-27T14:11:38Z","pushed_at":"2016-06-20T09:15:12Z","git_url":"git://github.com/cisco/logstash-codec-bigmuddy-network-telemetry.git","ssh_url":"git@github.com:cisco/logstash-codec-bigmuddy-network-telemetry.git","clone_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry.git","svn_url":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry","homepage":"","size":17,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1"},"html":{"href":"https://github.com/cisco/logstash-codec-bigmuddy-network-telemetry/pull/1"},"issue":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/1"},"comments":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/logstash-codec-bigmuddy-network-telemetry/statuses/9200242bf239d99f401119946b20850055a8373f"}}}}
{"actor":{"display_login":"ccassar"}}