{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/55865402","id":55865402,"diff_hunk":"@@ -303,6 +303,9 @@ type BuildStrategy struct {\n \n \t// CustomStrategy holds the parameters to the Custom build strategy\n \tCustomStrategy *CustomBuildStrategy `json:\"customStrategy,omitempty\" description:\"holds parameters to the Custom build strategy\"`\n+\n+\t// ExternalStrategy holds the parameters to the External build strategy\n+\tExternalStrategy *ExternalBuildStrategy `json:\"externalStrategy,omitempty\" description:\"holds parameters to the External build strategy\"`","path":"pkg/build/api/v1/types.go","position":6,"original_position":6,"commit_id":"6fbfeb6aa8c3bd24ffe6c5f992348b53fa800537","original_commit_id":"6fbfeb6aa8c3bd24ffe6c5f992348b53fa800537","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"@bparees so openshift itself does not know how the final pipeline looks like? i mean if jenkinsfile defines it, how we are going to visualize it in the console? i was expecting something like a linked build configurations (prev step/next step), where some build configs will be external and some local (regular docker/s2i/custom builds)...","created_at":"2016-03-11T18:10:28Z","updated_at":"2016-03-11T18:10:28Z","html_url":"https://github.com/openshift/origin/pull/7949#discussion_r55865402","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/7949","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/55865402"},"html":{"href":"https://github.com/openshift/origin/pull/7949#discussion_r55865402"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/7949"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7949","id":62559982,"html_url":"https://github.com/openshift/origin/pull/7949","diff_url":"https://github.com/openshift/origin/pull/7949.diff","patch_url":"https://github.com/openshift/origin/pull/7949.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/7949","number":7949,"state":"open","locked":false,"title":"[WIP] Add External build strategy","user":{"login":"jimmidyson","id":464659,"avatar_url":"https://avatars.githubusercontent.com/u/464659?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"body":"Ref: #6954\r\n\r\nThis just adds a simple External build strategy that indicates that builds will be handled by an external system, e.g. Jenkins. I expect that annotations on the build config will be used to configure anything required on the external job, e.g. path to Jenkinsfile in repo.\r\n\r\nI'm also working on a [Jenkins plugin](https://github.com/fabric8io/openshift-jenkins-sync-plugin) that watches build configs with this build strategy & creates/updates/deletes Jenkins jobs as required.\r\n\r\nLooking for feedback please.\r\n\r\n/cc @jstrachan @rawlingsj @bparees @smarterclayton @mfojtik ","created_at":"2016-03-11T15:39:02Z","updated_at":"2016-03-11T18:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efee1e6a1e2b82ffa63a8dc2550a4872eab9ab4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/7949/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/7949/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7949/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/6fbfeb6aa8c3bd24ffe6c5f992348b53fa800537","head":{"label":"jimmidyson:ci-build-strategy","ref":"ci-build-strategy","sha":"6fbfeb6aa8c3bd24ffe6c5f992348b53fa800537","user":{"login":"jimmidyson","id":464659,"avatar_url":"https://avatars.githubusercontent.com/u/464659?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"repo":{"id":24896481,"name":"origin","full_name":"jimmidyson/origin","owner":{"login":"jimmidyson","id":464659,"avatar_url":"https://avatars.githubusercontent.com/u/464659?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmidyson/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jimmidyson/origin","forks_url":"https://api.github.com/repos/jimmidyson/origin/forks","keys_url":"https://api.github.com/repos/jimmidyson/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmidyson/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmidyson/origin/teams","hooks_url":"https://api.github.com/repos/jimmidyson/origin/hooks","issue_events_url":"https://api.github.com/repos/jimmidyson/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jimmidyson/origin/events","assignees_url":"https://api.github.com/repos/jimmidyson/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jimmidyson/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jimmidyson/origin/tags","blobs_url":"https://api.github.com/repos/jimmidyson/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmidyson/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmidyson/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmidyson/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmidyson/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmidyson/origin/languages","stargazers_url":"https://api.github.com/repos/jimmidyson/origin/stargazers","contributors_url":"https://api.github.com/repos/jimmidyson/origin/contributors","subscribers_url":"https://api.github.com/repos/jimmidyson/origin/subscribers","subscription_url":"https://api.github.com/repos/jimmidyson/origin/subscription","commits_url":"https://api.github.com/repos/jimmidyson/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmidyson/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmidyson/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmidyson/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmidyson/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jimmidyson/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmidyson/origin/merges","archive_url":"https://api.github.com/repos/jimmidyson/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmidyson/origin/downloads","issues_url":"https://api.github.com/repos/jimmidyson/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jimmidyson/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmidyson/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmidyson/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmidyson/origin/labels{/name}","releases_url":"https://api.github.com/repos/jimmidyson/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jimmidyson/origin/deployments","created_at":"2014-10-07T15:17:49Z","updated_at":"2014-11-30T12:24:51Z","pushed_at":"2016-03-11T15:33:58Z","git_url":"git://github.com/jimmidyson/origin.git","ssh_url":"git@github.com:jimmidyson/origin.git","clone_url":"https://github.com/jimmidyson/origin.git","svn_url":"https://github.com/jimmidyson/origin","homepage":"https://openshift.github.io","size":234456,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b818f2617536535e951c01664ce855e0be30c14b","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-03-11T16:55:36Z","pushed_at":"2016-03-11T18:08:23Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":288168,"stargazers_count":1114,"watchers_count":1114,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":691,"mirror_url":null,"open_issues_count":930,"forks":691,"open_issues":930,"watchers":1114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/7949"},"html":{"href":"https://github.com/openshift/origin/pull/7949"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/7949"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/7949/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/7949/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/7949/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/6fbfeb6aa8c3bd24ffe6c5f992348b53fa800537"}}}}