{"action":"closed","number":6273,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6273","id":48630277,"html_url":"https://github.com/dotnet/roslyn/pull/6273","diff_url":"https://github.com/dotnet/roslyn/pull/6273.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6273.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6273","number":6273,"state":"closed","locked":false,"title":"Documentation file lookup in ms build workspace","user":{"login":"balajikris","id":4213867,"avatar_url":"https://avatars.githubusercontent.com/u/4213867?v=3","gravatar_id":"","url":"https://api.github.com/users/balajikris","html_url":"https://github.com/balajikris","followers_url":"https://api.github.com/users/balajikris/followers","following_url":"https://api.github.com/users/balajikris/following{/other_user}","gists_url":"https://api.github.com/users/balajikris/gists{/gist_id}","starred_url":"https://api.github.com/users/balajikris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajikris/subscriptions","organizations_url":"https://api.github.com/users/balajikris/orgs","repos_url":"https://api.github.com/users/balajikris/repos","events_url":"https://api.github.com/users/balajikris/events{/privacy}","received_events_url":"https://api.github.com/users/balajikris/received_events","type":"User","site_admin":false},"body":"Fixes one failure of many at #5668 \r\n\r\nMsbuildWorkspace did not have any logic to resolve documentation help files in localized builds. We were only looking beside the assembly and in loc builds this path didnt exist. The compiler's symbol.GetDocumentationCommentXml() would throw and catch an exception and silently fail. We now look for xml help files in subdirectories based on current culture.","created_at":"2015-10-23T21:07:30Z","updated_at":"2016-01-25T18:47:27Z","closed_at":"2016-01-25T18:47:27Z","merged_at":null,"merge_commit_sha":"37d4567a830e911100aca03ec89e5624ade852bc","assignee":{"login":"balajikris","id":4213867,"avatar_url":"https://avatars.githubusercontent.com/u/4213867?v=3","gravatar_id":"","url":"https://api.github.com/users/balajikris","html_url":"https://github.com/balajikris","followers_url":"https://api.github.com/users/balajikris/followers","following_url":"https://api.github.com/users/balajikris/following{/other_user}","gists_url":"https://api.github.com/users/balajikris/gists{/gist_id}","starred_url":"https://api.github.com/users/balajikris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajikris/subscriptions","organizations_url":"https://api.github.com/users/balajikris/orgs","repos_url":"https://api.github.com/users/balajikris/repos","events_url":"https://api.github.com/users/balajikris/events{/privacy}","received_events_url":"https://api.github.com/users/balajikris/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/4","html_url":"https://github.com/dotnet/roslyn/milestones/1.2","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/4/labels","id":937402,"number":4,"title":"1.2","description":"This is our 1.2 Milestone.\r\n\r\n<!---\r\n@huboard:{\"order\":2.0}\r\n-->\r\n","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":543,"closed_issues":389,"state":"open","created_at":"2015-01-15T20:48:55Z","updated_at":"2016-01-25T18:47:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6273/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6273/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6273/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/c6d089509c10e97567e6a294d7e17e89929cda3b","head":{"label":"balajikris:DocumentationFileLookupInMSBuildWorkspace","ref":"DocumentationFileLookupInMSBuildWorkspace","sha":"c6d089509c10e97567e6a294d7e17e89929cda3b","user":{"login":"balajikris","id":4213867,"avatar_url":"https://avatars.githubusercontent.com/u/4213867?v=3","gravatar_id":"","url":"https://api.github.com/users/balajikris","html_url":"https://github.com/balajikris","followers_url":"https://api.github.com/users/balajikris/followers","following_url":"https://api.github.com/users/balajikris/following{/other_user}","gists_url":"https://api.github.com/users/balajikris/gists{/gist_id}","starred_url":"https://api.github.com/users/balajikris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajikris/subscriptions","organizations_url":"https://api.github.com/users/balajikris/orgs","repos_url":"https://api.github.com/users/balajikris/repos","events_url":"https://api.github.com/users/balajikris/events{/privacy}","received_events_url":"https://api.github.com/users/balajikris/received_events","type":"User","site_admin":false},"repo":{"id":30552969,"name":"roslyn","full_name":"balajikris/roslyn","owner":{"login":"balajikris","id":4213867,"avatar_url":"https://avatars.githubusercontent.com/u/4213867?v=3","gravatar_id":"","url":"https://api.github.com/users/balajikris","html_url":"https://github.com/balajikris","followers_url":"https://api.github.com/users/balajikris/followers","following_url":"https://api.github.com/users/balajikris/following{/other_user}","gists_url":"https://api.github.com/users/balajikris/gists{/gist_id}","starred_url":"https://api.github.com/users/balajikris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajikris/subscriptions","organizations_url":"https://api.github.com/users/balajikris/orgs","repos_url":"https://api.github.com/users/balajikris/repos","events_url":"https://api.github.com/users/balajikris/events{/privacy}","received_events_url":"https://api.github.com/users/balajikris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balajikris/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/balajikris/roslyn","forks_url":"https://api.github.com/repos/balajikris/roslyn/forks","keys_url":"https://api.github.com/repos/balajikris/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balajikris/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balajikris/roslyn/teams","hooks_url":"https://api.github.com/repos/balajikris/roslyn/hooks","issue_events_url":"https://api.github.com/repos/balajikris/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/balajikris/roslyn/events","assignees_url":"https://api.github.com/repos/balajikris/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/balajikris/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/balajikris/roslyn/tags","blobs_url":"https://api.github.com/repos/balajikris/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balajikris/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balajikris/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/balajikris/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balajikris/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/balajikris/roslyn/languages","stargazers_url":"https://api.github.com/repos/balajikris/roslyn/stargazers","contributors_url":"https://api.github.com/repos/balajikris/roslyn/contributors","subscribers_url":"https://api.github.com/repos/balajikris/roslyn/subscribers","subscription_url":"https://api.github.com/repos/balajikris/roslyn/subscription","commits_url":"https://api.github.com/repos/balajikris/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/balajikris/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/balajikris/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/balajikris/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/balajikris/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/balajikris/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balajikris/roslyn/merges","archive_url":"https://api.github.com/repos/balajikris/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balajikris/roslyn/downloads","issues_url":"https://api.github.com/repos/balajikris/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/balajikris/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/balajikris/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/balajikris/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balajikris/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/balajikris/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/balajikris/roslyn/deployments","created_at":"2015-02-09T19:08:10Z","updated_at":"2015-05-08T19:50:21Z","pushed_at":"2016-01-20T08:29:20Z","git_url":"git://github.com/balajikris/roslyn.git","ssh_url":"git@github.com:balajikris/roslyn.git","clone_url":"https://github.com/balajikris/roslyn.git","svn_url":"https://github.com/balajikris/roslyn","homepage":"","size":119929,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5a97d296d3dedbe6cc7c580835da32adb3252d23","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-01-25T15:38:49Z","pushed_at":"2016-01-25T18:11:14Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":152520,"stargazers_count":4297,"watchers_count":4297,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1053,"mirror_url":null,"open_issues_count":1939,"forks":1053,"open_issues":1939,"watchers":4297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6273"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6273"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6273"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6273/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6273/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6273/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/c6d089509c10e97567e6a294d7e17e89929cda3b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":10,"commits":2,"additions":38,"deletions":5,"changed_files":2}}