{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/51674034","id":51674034,"diff_hunk":"@@ -24,12 +26,24 @@ type fluentd struct {\n }\n \n const (\n-\tname                             = \"fluentd\"\n-\tdefaultHostName                  = \"localhost\"\n-\tdefaultPort                      = 24224\n-\tdefaultTagPrefix                 = \"docker\"\n-\tdefaultIgnoreConnectErrorOnStart = false           // So that we do not break existing behaviour\n-\tdefaultBufferLimit               = 1 * 1024 * 1024 // 1M buffer by default\n+\tname = \"fluentd\"\n+\n+\tdefaultHost        = \"127.0.0.1\"\n+\tdefaultPort        = 24224\n+\tdefaultBufferLimit = 8 * 1024 * 1024","path":"daemon/logger/fluentd/fluentd.go","position":27,"original_position":27,"commit_id":"aad9d01a9fa5bb51b8f07370caa41c13d4280409","original_commit_id":"aad9d01a9fa5bb51b8f07370caa41c13d4280409","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"body":"It looks better to keep it as 1MB. Users can change it if they want.","created_at":"2016-02-03T03:18:13Z","updated_at":"2016-02-03T03:18:13Z","html_url":"https://github.com/docker/docker/pull/19439#discussion_r51674034","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/19439","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/51674034"},"html":{"href":"https://github.com/docker/docker/pull/19439#discussion_r51674034"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/19439"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/19439","id":56436028,"html_url":"https://github.com/docker/docker/pull/19439","diff_url":"https://github.com/docker/docker/pull/19439.diff","patch_url":"https://github.com/docker/docker/pull/19439.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/19439","number":19439,"state":"open","locked":false,"title":"fluentd logger: support all options besides Unix sockets","user":{"login":"pcarrier","id":8641,"avatar_url":"https://avatars.githubusercontent.com/u/8641?v=3","gravatar_id":"","url":"https://api.github.com/users/pcarrier","html_url":"https://github.com/pcarrier","followers_url":"https://api.github.com/users/pcarrier/followers","following_url":"https://api.github.com/users/pcarrier/following{/other_user}","gists_url":"https://api.github.com/users/pcarrier/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarrier/subscriptions","organizations_url":"https://api.github.com/users/pcarrier/orgs","repos_url":"https://api.github.com/users/pcarrier/repos","events_url":"https://api.github.com/users/pcarrier/events{/privacy}","received_events_url":"https://api.github.com/users/pcarrier/received_events","type":"User","site_admin":false},"body":"Mostly useful for docker/docker#19438.","created_at":"2016-01-19T08:44:53Z","updated_at":"2016-02-03T03:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe4418b30320ed1fbfcc7d7dfb02318c6420fe96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/19439/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/19439/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/19439/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/aad9d01a9fa5bb51b8f07370caa41c13d4280409","head":{"label":"pcarrier:pcarrier/19438-async-connections-to-fluentd","ref":"pcarrier/19438-async-connections-to-fluentd","sha":"aad9d01a9fa5bb51b8f07370caa41c13d4280409","user":{"login":"pcarrier","id":8641,"avatar_url":"https://avatars.githubusercontent.com/u/8641?v=3","gravatar_id":"","url":"https://api.github.com/users/pcarrier","html_url":"https://github.com/pcarrier","followers_url":"https://api.github.com/users/pcarrier/followers","following_url":"https://api.github.com/users/pcarrier/following{/other_user}","gists_url":"https://api.github.com/users/pcarrier/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarrier/subscriptions","organizations_url":"https://api.github.com/users/pcarrier/orgs","repos_url":"https://api.github.com/users/pcarrier/repos","events_url":"https://api.github.com/users/pcarrier/events{/privacy}","received_events_url":"https://api.github.com/users/pcarrier/received_events","type":"User","site_admin":false},"repo":{"id":49938356,"name":"docker","full_name":"pcarrier/docker","owner":{"login":"pcarrier","id":8641,"avatar_url":"https://avatars.githubusercontent.com/u/8641?v=3","gravatar_id":"","url":"https://api.github.com/users/pcarrier","html_url":"https://github.com/pcarrier","followers_url":"https://api.github.com/users/pcarrier/followers","following_url":"https://api.github.com/users/pcarrier/following{/other_user}","gists_url":"https://api.github.com/users/pcarrier/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarrier/subscriptions","organizations_url":"https://api.github.com/users/pcarrier/orgs","repos_url":"https://api.github.com/users/pcarrier/repos","events_url":"https://api.github.com/users/pcarrier/events{/privacy}","received_events_url":"https://api.github.com/users/pcarrier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcarrier/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/pcarrier/docker","forks_url":"https://api.github.com/repos/pcarrier/docker/forks","keys_url":"https://api.github.com/repos/pcarrier/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcarrier/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcarrier/docker/teams","hooks_url":"https://api.github.com/repos/pcarrier/docker/hooks","issue_events_url":"https://api.github.com/repos/pcarrier/docker/issues/events{/number}","events_url":"https://api.github.com/repos/pcarrier/docker/events","assignees_url":"https://api.github.com/repos/pcarrier/docker/assignees{/user}","branches_url":"https://api.github.com/repos/pcarrier/docker/branches{/branch}","tags_url":"https://api.github.com/repos/pcarrier/docker/tags","blobs_url":"https://api.github.com/repos/pcarrier/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcarrier/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcarrier/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcarrier/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcarrier/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/pcarrier/docker/languages","stargazers_url":"https://api.github.com/repos/pcarrier/docker/stargazers","contributors_url":"https://api.github.com/repos/pcarrier/docker/contributors","subscribers_url":"https://api.github.com/repos/pcarrier/docker/subscribers","subscription_url":"https://api.github.com/repos/pcarrier/docker/subscription","commits_url":"https://api.github.com/repos/pcarrier/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcarrier/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcarrier/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcarrier/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcarrier/docker/contents/{+path}","compare_url":"https://api.github.com/repos/pcarrier/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcarrier/docker/merges","archive_url":"https://api.github.com/repos/pcarrier/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcarrier/docker/downloads","issues_url":"https://api.github.com/repos/pcarrier/docker/issues{/number}","pulls_url":"https://api.github.com/repos/pcarrier/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/pcarrier/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/pcarrier/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcarrier/docker/labels{/name}","releases_url":"https://api.github.com/repos/pcarrier/docker/releases{/id}","deployments_url":"https://api.github.com/repos/pcarrier/docker/deployments","created_at":"2016-01-19T08:34:55Z","updated_at":"2016-01-19T08:35:05Z","pushed_at":"2016-01-30T00:07:59Z","git_url":"git://github.com/pcarrier/docker.git","ssh_url":"git@github.com:pcarrier/docker.git","clone_url":"https://github.com/pcarrier/docker.git","svn_url":"https://github.com/pcarrier/docker","homepage":"http://www.docker.com","size":80292,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"c006c0261159224675397162aa3a03d9adbb180b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-02-03T03:00:08Z","pushed_at":"2016-02-03T03:12:59Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":135487,"stargazers_count":28338,"watchers_count":28338,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7848,"mirror_url":null,"open_issues_count":1259,"forks":7848,"open_issues":1259,"watchers":28338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/19439"},"html":{"href":"https://github.com/docker/docker/pull/19439"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/19439"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/19439/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/19439/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/19439/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/aad9d01a9fa5bb51b8f07370caa41c13d4280409"}}}}