{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/87493726","pull_request_review_id":8105863,"id":87493726,"diff_hunk":"@@ -186,7 +190,10 @@ func New(config Config) (*Cluster, error) {\n \t\tif errors.Cause(c.err) == ErrSwarmLocked {\n \t\t\treturn c, nil\n \t\t}\n-\n+\t\tif errors.Cause(c.err).Error() == (x509.CertificateInvalidError{Reason: x509.Expired}).Error() {","path":"daemon/cluster/cluster.go","position":23,"original_position":23,"commit_id":"8159b367693b439976a90d2b1f24627d2cb2f442","original_commit_id":"8159b367693b439976a90d2b1f24627d2cb2f442","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"Why not convert to `CertificateInvalidError` and check that `cErr.Reason == x509.Expired`?\r\nSeems cleaner than the string comparison.","created_at":"2016-11-10T21:52:09Z","updated_at":"2016-11-10T21:52:09Z","html_url":"https://github.com/docker/docker/pull/28228#discussion_r87493726","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/28228","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/87493726"},"html":{"href":"https://github.com/docker/docker/pull/28228#discussion_r87493726"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/28228"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28228","id":93075823,"html_url":"https://github.com/docker/docker/pull/28228","diff_url":"https://github.com/docker/docker/pull/28228.diff","patch_url":"https://github.com/docker/docker/pull/28228.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/28228","number":28228,"state":"open","locked":false,"title":"Start daemon if certificates have been expired","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"body":"fixes #24132\r\n\r\ncc @aaronlehmann @diogomonica \r\n\r\nSigned-off-by: Tonis Tiigi <tonistiigi@gmail.com>","created_at":"2016-11-10T02:21:55Z","updated_at":"2016-11-10T21:52:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f38c5e5cade3dabf1d44bc881fda6a976c5a116a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":96,"closed_issues":720,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-10T21:51:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/28228/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/28228/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/28228/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/8159b367693b439976a90d2b1f24627d2cb2f442","head":{"label":"tonistiigi:swarm-cert-expired","ref":"swarm-cert-expired","sha":"8159b367693b439976a90d2b1f24627d2cb2f442","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"repo":{"id":19074395,"name":"docker","full_name":"tonistiigi/docker","owner":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonistiigi/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/tonistiigi/docker","forks_url":"https://api.github.com/repos/tonistiigi/docker/forks","keys_url":"https://api.github.com/repos/tonistiigi/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonistiigi/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonistiigi/docker/teams","hooks_url":"https://api.github.com/repos/tonistiigi/docker/hooks","issue_events_url":"https://api.github.com/repos/tonistiigi/docker/issues/events{/number}","events_url":"https://api.github.com/repos/tonistiigi/docker/events","assignees_url":"https://api.github.com/repos/tonistiigi/docker/assignees{/user}","branches_url":"https://api.github.com/repos/tonistiigi/docker/branches{/branch}","tags_url":"https://api.github.com/repos/tonistiigi/docker/tags","blobs_url":"https://api.github.com/repos/tonistiigi/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonistiigi/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonistiigi/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonistiigi/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonistiigi/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/tonistiigi/docker/languages","stargazers_url":"https://api.github.com/repos/tonistiigi/docker/stargazers","contributors_url":"https://api.github.com/repos/tonistiigi/docker/contributors","subscribers_url":"https://api.github.com/repos/tonistiigi/docker/subscribers","subscription_url":"https://api.github.com/repos/tonistiigi/docker/subscription","commits_url":"https://api.github.com/repos/tonistiigi/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonistiigi/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonistiigi/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonistiigi/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonistiigi/docker/contents/{+path}","compare_url":"https://api.github.com/repos/tonistiigi/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonistiigi/docker/merges","archive_url":"https://api.github.com/repos/tonistiigi/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonistiigi/docker/downloads","issues_url":"https://api.github.com/repos/tonistiigi/docker/issues{/number}","pulls_url":"https://api.github.com/repos/tonistiigi/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/tonistiigi/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/tonistiigi/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonistiigi/docker/labels{/name}","releases_url":"https://api.github.com/repos/tonistiigi/docker/releases{/id}","deployments_url":"https://api.github.com/repos/tonistiigi/docker/deployments","created_at":"2014-04-23T15:15:03Z","updated_at":"2014-07-24T21:22:45Z","pushed_at":"2016-11-10T19:22:51Z","git_url":"git://github.com/tonistiigi/docker.git","ssh_url":"git@github.com:tonistiigi/docker.git","clone_url":"https://github.com/tonistiigi/docker.git","svn_url":"https://github.com/tonistiigi/docker","homepage":"http://www.docker.io","size":110786,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"c13bf5ba51c4f6a1ba5e5c0da0d4f85d2d5b9116","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-10T21:29:35Z","pushed_at":"2016-11-10T21:50:34Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":221252,"stargazers_count":36735,"watchers_count":36735,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10860,"mirror_url":null,"open_issues_count":1861,"forks":10860,"open_issues":1861,"watchers":36735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/28228"},"html":{"href":"https://github.com/docker/docker/pull/28228"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/28228"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/28228/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/28228/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/28228/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/8159b367693b439976a90d2b1f24627d2cb2f442"}}}}
{"actor":{"display_login":"cpuguy83"}}