{"push_id":1451244660,"size":12,"distinct_size":1,"ref":"refs/heads/nm-1-2","head":"e4a9bcde823838553a1b6b4628684589bdd85d5b","before":"5d5367462d16869790c2110f6b623c182069f843","commits":[{"sha":"11b667bdc21ee6b045cd624b7d6f44e58b478ed6","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"shared: add also \"shared/nm-utils/nm-vpn-plugin-macros.h\"\n\nIt has the very similar purpose as \"nm-utils/nm-vpn-plugin-utils.[ch]\", except\nthat is is header-only.\n\n(cherry picked from commit af507cd0893f8140a5c62a176ba70f12b642a0fa)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/11b667bdc21ee6b045cd624b7d6f44e58b478ed6"},{"sha":"58c6c12f471137dbba5292d5436188bb76bda650","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: prefix logging messages with \"dhcp\"\n\n(cherry picked from commit 1c58ce0d748174b5b3a27dd077192b45fed2d0a4)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/58c6c12f471137dbba5292d5436188bb76bda650"},{"sha":"a2c39cddbfeca7ee4e5e2d09411368c855d5b037","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"shared: add NM_MIN()/NM_MAX() macros to replace glib's MIN()/MAX()\n\n(cherry picked from commit b2016fd2a52b82d45324526c965e7545d026cebe)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a2c39cddbfeca7ee4e5e2d09411368c855d5b037"},{"sha":"3c690e751f74a928b24f7a118e84e0d3f94d33c5","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"shared: add _NM_GET_PRIVATE() macro\n\n(cherry picked from commit 2cae9ba348ed6ea4d41ebd714d8c55f4d49feae9)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/3c690e751f74a928b24f7a118e84e0d3f94d33c5"},{"sha":"20406d1a1dd81c9092024d35dc3d5acc378e4638","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener: refactor type definition and embed private data in @self\n\n(cherry picked from commit 822f01a8fdb63831c887d5db9fb06eb840f53c88)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/20406d1a1dd81c9092024d35dc3d5acc378e4638"},{"sha":"b63ef470afb598bd152a4bb22e264439add9caf0","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener: add logging macros to nm-dhcp-listener.c\n\n(cherry picked from commit d37cd04fe059e9d99c7103f4e22a9a945f8d4d98)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/b63ef470afb598bd152a4bb22e264439add9caf0"},{"sha":"99ec04debd421f57d4087bcbd110e7c63051633e","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener/trivial: rename field to track connections in NMDhcpListener\n\nIt's not \"signal-handles\", as it currently tracks the registration ID of\ntype int. Rename it, it is effectively the list of connections that we\ntrack.\n\n(cherry picked from commit 2dd3a5245f91a7c25ae1a36a86638195500f00a8)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/99ec04debd421f57d4087bcbd110e7c63051633e"},{"sha":"602163346e8d6b5db366a8ce04c01c23b3802523","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-helper: refactor error handling\n\nDon't exit(1) from fatal_error() because that skips destroying\nlocal variables in main(). Just return regularly.\n\n(cherry picked from commit bb489163db36889a6fb80789e4e5b9dd8a15dbdd)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/602163346e8d6b5db366a8ce04c01c23b3802523"},{"sha":"704e5a7709efd86733337deeaf1534af41223b29","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-helper: refactor logging to use logging macros\n\n(cherry picked from commit cc89996c9e826c9c8d12d5fb7bc8a2a578209eb0)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/704e5a7709efd86733337deeaf1534af41223b29"},{"sha":"cb0d31229c50a22a06486da17ada1e0f54d59005","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: add new header \"nm-dhcp-helper-api.h\"\n\n(cherry picked from commit 7684b68c49812ed7b2ec493889fae04db066b665)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cb0d31229c50a22a06486da17ada1e0f54d59005"},{"sha":"d6ee12bd7c5dcfd87e085ce0fcc289fea89ec6f4","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: call synchronous Notify D-Bus method from nm-dhcp-helper\n\nA D-Bus signal is asynchronous and it can happen that nm-dhcp-helper\nemits the \"Event\" signal before the server is able to register a handler:\n\n   NM_DHCP_HELPER=/usr/libexec/nm-dhcp-helper\n   nmcli general logging level TRACE\n   for i in `seq 1 500`; do $NM_DHCP_HELPER & done\n   journalctl -u NetworkManager --since '1 min ago' | grep \"didn't have associated interface\" | wc -l\n    499\n\nAvoid that, by calling the synchronous D-Bus method \"Notify\".\n\nInterestingly, this race seem to exist since 2007.\n\nActually, we called g_dbus_connection_signal_subscribe() from inside\nGDBusServer:new-connection signal. So it is not clear how such a race\ncould exist. I was not able to reproduce it by putting a sleep\nbefore g_dbus_connection_signal_subscribe(). On the other hand, there\nis bug rh#1372854 and above reproducer which strongly indicates that\nevents can be lost under certain circumstances.\nNow we instead g_dbus_connection_register_object() from the\nnew-connection signal. According to my tests there was no more race\nas also backed by glib's documentation. Still, keep a simple retry-loop\nin nm-dhcp-helper just to be sure.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1372854\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1373276\n(cherry picked from commit 2856a658b38df88494187c811415a198a424e1f2)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d6ee12bd7c5dcfd87e085ce0fcc289fea89ec6f4"},{"sha":"e4a9bcde823838553a1b6b4628684589bdd85d5b","author":{"name":"Beniamino Galvani","email":"517b181d73f6c621ed1e08338a8189fe733e83b8@redhat.com"},"message":"dhcp: merge branch 'th/dhcp-helper-sync-notify-rh1372854'\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1372854\n(cherry picked from commit 42519abdbf6c9778a9f9421e704181b22d4df684)","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e4a9bcde823838553a1b6b4628684589bdd85d5b"}]}
{"actor":{"display_login":"lkundrak"}}