{"action":"created","issue":{"url":"https://api.github.com/repos/e107inc/e107/issues/1555","repository_url":"https://api.github.com/repos/e107inc/e107","labels_url":"https://api.github.com/repos/e107inc/e107/issues/1555/labels{/name}","comments_url":"https://api.github.com/repos/e107inc/e107/issues/1555/comments","events_url":"https://api.github.com/repos/e107inc/e107/issues/1555/events","html_url":"https://github.com/e107inc/e107/pull/1555","id":148931082,"number":1555,"title":"enhancement for better templating","user":{"login":"Jimmi08","id":5429548,"avatar_url":"https://avatars.githubusercontent.com/u/5429548?v=3","gravatar_id":"","url":"https://api.github.com/users/Jimmi08","html_url":"https://github.com/Jimmi08","followers_url":"https://api.github.com/users/Jimmi08/followers","following_url":"https://api.github.com/users/Jimmi08/following{/other_user}","gists_url":"https://api.github.com/users/Jimmi08/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimmi08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimmi08/subscriptions","organizations_url":"https://api.github.com/users/Jimmi08/orgs","repos_url":"https://api.github.com/users/Jimmi08/repos","events_url":"https://api.github.com/users/Jimmi08/events{/privacy}","received_events_url":"https://api.github.com/users/Jimmi08/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-17T08:40:18Z","updated_at":"2016-04-18T17:14:30Z","closed_at":"2016-04-17T19:09:12Z","pull_request":{"url":"https://api.github.com/repos/e107inc/e107/pulls/1555","html_url":"https://github.com/e107inc/e107/pull/1555","diff_url":"https://github.com/e107inc/e107/pull/1555.diff","patch_url":"https://github.com/e107inc/e107/pull/1555.patch"},"body":"example of use:\r\n`{LOGIN_TABLE_USERNAME: class=form-control input-lg}`"},"comment":{"url":"https://api.github.com/repos/e107inc/e107/issues/comments/211481284","html_url":"https://github.com/e107inc/e107/pull/1555#issuecomment-211481284","issue_url":"https://api.github.com/repos/e107inc/e107/issues/1555","id":211481284,"user":{"login":"CaMer0n","id":2825679,"avatar_url":"https://avatars.githubusercontent.com/u/2825679?v=3","gravatar_id":"","url":"https://api.github.com/users/CaMer0n","html_url":"https://github.com/CaMer0n","followers_url":"https://api.github.com/users/CaMer0n/followers","following_url":"https://api.github.com/users/CaMer0n/following{/other_user}","gists_url":"https://api.github.com/users/CaMer0n/gists{/gist_id}","starred_url":"https://api.github.com/users/CaMer0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaMer0n/subscriptions","organizations_url":"https://api.github.com/users/CaMer0n/orgs","repos_url":"https://api.github.com/users/CaMer0n/repos","events_url":"https://api.github.com/users/CaMer0n/events{/privacy}","received_events_url":"https://api.github.com/users/CaMer0n/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T17:14:30Z","updated_at":"2016-04-18T17:14:30Z","body":"Please take a look at this: \r\n```\r\n\r\n\tpublic static function scParams($parm)\r\n\t{\r\n\t\tif (!$parm) return array();\r\n\t\tif (!is_array($parm))\r\n\t\t{\r\n\t\t\t$parm = str_replace('\\&', '%%__amp__%%', $parm);\r\n\t\t\t$parm = str_replace('&amp;', '&', $parm); // clean when it comes from the DB\r\n\t\t\tparse_str($parm, $parm);\r\n\t\t\tforeach ($parm as $k => $v)\r\n\t\t\t{\r\n\t\t\t\t$parm[str_replace('%%__amp__%%', '&', $k)] = str_replace('%%__amp__%%', '\\&', $v);\r\n\t\t\t}\r\n\t\t}\r\n\r\n\t\treturn $parm;\r\n\t}\r\n\r\n```\r\nFrom your banner commit: \r\n```\r\nif(is_array($parm))\r\n{\r\n\t$parms = eHelper::scParams($parm);\r\n\t$campaign = $parms['campaign'];\t\r\n}\r\n```\r\n\r\nThere's no error, but it is unnecessary. Do you see what is wrong with this scenario? You're sending an array to a function that handles strings. "}}