{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/cachedout/barnacle/pulls/13","id":85658455,"html_url":"https://github.com/cachedout/barnacle/pull/13","diff_url":"https://github.com/cachedout/barnacle/pull/13.diff","patch_url":"https://github.com/cachedout/barnacle/pull/13.patch","issue_url":"https://api.github.com/repos/cachedout/barnacle/issues/13","number":13,"state":"closed","locked":false,"title":"add env variable to use salt from git checkout in testing","user":{"login":"Ch3LL","id":6886822,"avatar_url":"https://avatars.githubusercontent.com/u/6886822?v=3","gravatar_id":"","url":"https://api.github.com/users/Ch3LL","html_url":"https://github.com/Ch3LL","followers_url":"https://api.github.com/users/Ch3LL/followers","following_url":"https://api.github.com/users/Ch3LL/following{/other_user}","gists_url":"https://api.github.com/users/Ch3LL/gists{/gist_id}","starred_url":"https://api.github.com/users/Ch3LL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ch3LL/subscriptions","organizations_url":"https://api.github.com/users/Ch3LL/orgs","repos_url":"https://api.github.com/users/Ch3LL/repos","events_url":"https://api.github.com/users/Ch3LL/events{/privacy}","received_events_url":"https://api.github.com/users/Ch3LL/received_events","type":"User","site_admin":false},"body":"This will ensure that when working with these containers salt is run from /testing/ instead of from the package install. \r\n\r\nAt first I thought for sure we wanted to make this the default behavior but then i ran into a use case today when triaging. It was very nice to just have the package install 2016.3.3 already installed on the image so i could push my test case up to docker hub and salt was already installed and a user would not have to learn barnacle to work with the image or know that they needed to add their local git clone repo to /testing as a volume. So I see a couple of options here:\r\n\r\n1. continue with adding these env variables as the default and add an optional argument to remove these env variables on all the zshrc functions so they are removed on start of container\r\n2. do not make this the default and add an optional argument to add these env variables in the zshrc functions that is run at time of the container\r\n3. add an alias to the dockerfile that I can easily run to remove these env variables when interacting with the container so if i need to push this up during triage I can just quickly run that alias to remove env variables and reference the salt packaging.\r\n4. Just assume one would need to know these environment varilabes are set and they would need to manually remove them in container if not interacting with local git salt clone and document this\r\n\r\nThoughts? @cachedout @gtmanfred or @rallytime \r\n\r\n","created_at":"2016-09-17T00:53:21Z","updated_at":"2016-09-17T11:20:46Z","closed_at":"2016-09-17T11:20:46Z","merged_at":"2016-09-17T11:20:46Z","merge_commit_sha":"5652756dd5e87c9446ed739b39493795ac4305d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cachedout/barnacle/pulls/13/commits","review_comments_url":"https://api.github.com/repos/cachedout/barnacle/pulls/13/comments","review_comment_url":"https://api.github.com/repos/cachedout/barnacle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cachedout/barnacle/issues/13/comments","statuses_url":"https://api.github.com/repos/cachedout/barnacle/statuses/9995d316b9dd3f603590684457fa1b01acadc60a","head":{"label":"Ch3LL:add_dev_install_opt","ref":"add_dev_install_opt","sha":"9995d316b9dd3f603590684457fa1b01acadc60a","user":{"login":"Ch3LL","id":6886822,"avatar_url":"https://avatars.githubusercontent.com/u/6886822?v=3","gravatar_id":"","url":"https://api.github.com/users/Ch3LL","html_url":"https://github.com/Ch3LL","followers_url":"https://api.github.com/users/Ch3LL/followers","following_url":"https://api.github.com/users/Ch3LL/following{/other_user}","gists_url":"https://api.github.com/users/Ch3LL/gists{/gist_id}","starred_url":"https://api.github.com/users/Ch3LL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ch3LL/subscriptions","organizations_url":"https://api.github.com/users/Ch3LL/orgs","repos_url":"https://api.github.com/users/Ch3LL/repos","events_url":"https://api.github.com/users/Ch3LL/events{/privacy}","received_events_url":"https://api.github.com/users/Ch3LL/received_events","type":"User","site_admin":false},"repo":{"id":68216592,"name":"barnacle","full_name":"Ch3LL/barnacle","owner":{"login":"Ch3LL","id":6886822,"avatar_url":"https://avatars.githubusercontent.com/u/6886822?v=3","gravatar_id":"","url":"https://api.github.com/users/Ch3LL","html_url":"https://github.com/Ch3LL","followers_url":"https://api.github.com/users/Ch3LL/followers","following_url":"https://api.github.com/users/Ch3LL/following{/other_user}","gists_url":"https://api.github.com/users/Ch3LL/gists{/gist_id}","starred_url":"https://api.github.com/users/Ch3LL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ch3LL/subscriptions","organizations_url":"https://api.github.com/users/Ch3LL/orgs","repos_url":"https://api.github.com/users/Ch3LL/repos","events_url":"https://api.github.com/users/Ch3LL/events{/privacy}","received_events_url":"https://api.github.com/users/Ch3LL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ch3LL/barnacle","description":"Dockerfiles to easily create environments for developing and testing SaltStack on various platforms.","fork":true,"url":"https://api.github.com/repos/Ch3LL/barnacle","forks_url":"https://api.github.com/repos/Ch3LL/barnacle/forks","keys_url":"https://api.github.com/repos/Ch3LL/barnacle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ch3LL/barnacle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ch3LL/barnacle/teams","hooks_url":"https://api.github.com/repos/Ch3LL/barnacle/hooks","issue_events_url":"https://api.github.com/repos/Ch3LL/barnacle/issues/events{/number}","events_url":"https://api.github.com/repos/Ch3LL/barnacle/events","assignees_url":"https://api.github.com/repos/Ch3LL/barnacle/assignees{/user}","branches_url":"https://api.github.com/repos/Ch3LL/barnacle/branches{/branch}","tags_url":"https://api.github.com/repos/Ch3LL/barnacle/tags","blobs_url":"https://api.github.com/repos/Ch3LL/barnacle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ch3LL/barnacle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ch3LL/barnacle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ch3LL/barnacle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ch3LL/barnacle/statuses/{sha}","languages_url":"https://api.github.com/repos/Ch3LL/barnacle/languages","stargazers_url":"https://api.github.com/repos/Ch3LL/barnacle/stargazers","contributors_url":"https://api.github.com/repos/Ch3LL/barnacle/contributors","subscribers_url":"https://api.github.com/repos/Ch3LL/barnacle/subscribers","subscription_url":"https://api.github.com/repos/Ch3LL/barnacle/subscription","commits_url":"https://api.github.com/repos/Ch3LL/barnacle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ch3LL/barnacle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ch3LL/barnacle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ch3LL/barnacle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ch3LL/barnacle/contents/{+path}","compare_url":"https://api.github.com/repos/Ch3LL/barnacle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ch3LL/barnacle/merges","archive_url":"https://api.github.com/repos/Ch3LL/barnacle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ch3LL/barnacle/downloads","issues_url":"https://api.github.com/repos/Ch3LL/barnacle/issues{/number}","pulls_url":"https://api.github.com/repos/Ch3LL/barnacle/pulls{/number}","milestones_url":"https://api.github.com/repos/Ch3LL/barnacle/milestones{/number}","notifications_url":"https://api.github.com/repos/Ch3LL/barnacle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ch3LL/barnacle/labels{/name}","releases_url":"https://api.github.com/repos/Ch3LL/barnacle/releases{/id}","deployments_url":"https://api.github.com/repos/Ch3LL/barnacle/deployments","created_at":"2016-09-14T15:06:20Z","updated_at":"2016-09-14T15:06:21Z","pushed_at":"2016-09-17T00:39:37Z","git_url":"git://github.com/Ch3LL/barnacle.git","ssh_url":"git@github.com:Ch3LL/barnacle.git","clone_url":"https://github.com/Ch3LL/barnacle.git","svn_url":"https://github.com/Ch3LL/barnacle","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cachedout:master","ref":"master","sha":"c8a8ca7cd851b727341083021f39c2b31d0bf3ea","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"repo":{"id":68208066,"name":"barnacle","full_name":"cachedout/barnacle","owner":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cachedout/barnacle","description":"Dockerfiles to easily create environments for developing and testing SaltStack on various platforms.","fork":false,"url":"https://api.github.com/repos/cachedout/barnacle","forks_url":"https://api.github.com/repos/cachedout/barnacle/forks","keys_url":"https://api.github.com/repos/cachedout/barnacle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cachedout/barnacle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cachedout/barnacle/teams","hooks_url":"https://api.github.com/repos/cachedout/barnacle/hooks","issue_events_url":"https://api.github.com/repos/cachedout/barnacle/issues/events{/number}","events_url":"https://api.github.com/repos/cachedout/barnacle/events","assignees_url":"https://api.github.com/repos/cachedout/barnacle/assignees{/user}","branches_url":"https://api.github.com/repos/cachedout/barnacle/branches{/branch}","tags_url":"https://api.github.com/repos/cachedout/barnacle/tags","blobs_url":"https://api.github.com/repos/cachedout/barnacle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cachedout/barnacle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cachedout/barnacle/git/refs{/sha}","trees_url":"https://api.github.com/repos/cachedout/barnacle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cachedout/barnacle/statuses/{sha}","languages_url":"https://api.github.com/repos/cachedout/barnacle/languages","stargazers_url":"https://api.github.com/repos/cachedout/barnacle/stargazers","contributors_url":"https://api.github.com/repos/cachedout/barnacle/contributors","subscribers_url":"https://api.github.com/repos/cachedout/barnacle/subscribers","subscription_url":"https://api.github.com/repos/cachedout/barnacle/subscription","commits_url":"https://api.github.com/repos/cachedout/barnacle/commits{/sha}","git_commits_url":"https://api.github.com/repos/cachedout/barnacle/git/commits{/sha}","comments_url":"https://api.github.com/repos/cachedout/barnacle/comments{/number}","issue_comment_url":"https://api.github.com/repos/cachedout/barnacle/issues/comments{/number}","contents_url":"https://api.github.com/repos/cachedout/barnacle/contents/{+path}","compare_url":"https://api.github.com/repos/cachedout/barnacle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cachedout/barnacle/merges","archive_url":"https://api.github.com/repos/cachedout/barnacle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cachedout/barnacle/downloads","issues_url":"https://api.github.com/repos/cachedout/barnacle/issues{/number}","pulls_url":"https://api.github.com/repos/cachedout/barnacle/pulls{/number}","milestones_url":"https://api.github.com/repos/cachedout/barnacle/milestones{/number}","notifications_url":"https://api.github.com/repos/cachedout/barnacle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cachedout/barnacle/labels{/name}","releases_url":"https://api.github.com/repos/cachedout/barnacle/releases{/id}","deployments_url":"https://api.github.com/repos/cachedout/barnacle/deployments","created_at":"2016-09-14T13:19:08Z","updated_at":"2016-09-16T17:20:17Z","pushed_at":"2016-09-17T11:20:46Z","git_url":"git://github.com/cachedout/barnacle.git","ssh_url":"git@github.com:cachedout/barnacle.git","clone_url":"https://github.com/cachedout/barnacle.git","svn_url":"https://github.com/cachedout/barnacle","homepage":null,"size":32,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cachedout/barnacle/pulls/13"},"html":{"href":"https://github.com/cachedout/barnacle/pull/13"},"issue":{"href":"https://api.github.com/repos/cachedout/barnacle/issues/13"},"comments":{"href":"https://api.github.com/repos/cachedout/barnacle/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/cachedout/barnacle/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/cachedout/barnacle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cachedout/barnacle/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/cachedout/barnacle/statuses/9995d316b9dd3f603590684457fa1b01acadc60a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":30,"deletions":1,"changed_files":10}}
{"actor":{"display_login":"cachedout"}}