{"action":"created","comment":{"url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments/79432306","id":79432306,"diff_hunk":"@@ -157,13 +158,17 @@ function Stepper(opts) {\n       }\n     }\n \n+    this.pins = {};\n+\n+    if (pinArray.length & 0x01) {\n+      this.pins.enable = pinArray.pop();\n+    }\n+\n     if (opts.type === Stepper.TYPE.DRIVER) {\n-      this.pins = {\n-        step: this.pins[0],\n-        dir: this.pins[1]\n-      };\n+      this.pins.step = pinArray[0];\n+      this.pins.dir = pinArray[1];\n     } else {\n-      this.pins = new MotorPins(this.pins);\n+      this.pins = new MotorPins(pinArray);","path":"lib/stepper.js","position":31,"original_position":31,"commit_id":"21da9aa91f10efac7e69884bc920f96447f8679f","original_commit_id":"21da9aa91f10efac7e69884bc920f96447f8679f","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"Blah... `Stepper` is such a mess in the way it handles `this.pins` :(","created_at":"2016-09-19T16:34:01Z","updated_at":"2016-09-19T16:34:13Z","html_url":"https://github.com/rwaldron/johnny-five/pull/1225#discussion_r79432306","pull_request_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225","_links":{"self":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments/79432306"},"html":{"href":"https://github.com/rwaldron/johnny-five/pull/1225#discussion_r79432306"},"pull_request":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225"}}},"pull_request":{"url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225","id":85680255,"html_url":"https://github.com/rwaldron/johnny-five/pull/1225","diff_url":"https://github.com/rwaldron/johnny-five/pull/1225.diff","patch_url":"https://github.com/rwaldron/johnny-five/pull/1225.patch","issue_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/1225","number":1225,"state":"closed","locked":false,"title":"Add enable pin for stepper","user":{"login":"dtex","id":854911,"avatar_url":"https://avatars.githubusercontent.com/u/854911?v=3","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"body":"Will update the wiki when this lands.","created_at":"2016-09-17T17:11:22Z","updated_at":"2016-09-19T16:34:13Z","closed_at":"2016-09-19T16:03:14Z","merged_at":null,"merge_commit_sha":"a692c0dc554fdabe6db953a7b3441c8a4edbc2f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225/commits","review_comments_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225/comments","review_comment_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/1225/comments","statuses_url":"https://api.github.com/repos/rwaldron/johnny-five/statuses/21da9aa91f10efac7e69884bc920f96447f8679f","head":{"label":"dtex:stepper-enable-pin","ref":"stepper-enable-pin","sha":"21da9aa91f10efac7e69884bc920f96447f8679f","user":{"login":"dtex","id":854911,"avatar_url":"https://avatars.githubusercontent.com/u/854911?v=3","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"repo":{"id":44151463,"name":"johnny-five","full_name":"dtex/johnny-five","owner":{"login":"dtex","id":854911,"avatar_url":"https://avatars.githubusercontent.com/u/854911?v=3","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtex/johnny-five","description":"JavaScript Robotics and IoT programming framework, developed at Bocoup. Based on Arduino Firmata Protocol","fork":true,"url":"https://api.github.com/repos/dtex/johnny-five","forks_url":"https://api.github.com/repos/dtex/johnny-five/forks","keys_url":"https://api.github.com/repos/dtex/johnny-five/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtex/johnny-five/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtex/johnny-five/teams","hooks_url":"https://api.github.com/repos/dtex/johnny-five/hooks","issue_events_url":"https://api.github.com/repos/dtex/johnny-five/issues/events{/number}","events_url":"https://api.github.com/repos/dtex/johnny-five/events","assignees_url":"https://api.github.com/repos/dtex/johnny-five/assignees{/user}","branches_url":"https://api.github.com/repos/dtex/johnny-five/branches{/branch}","tags_url":"https://api.github.com/repos/dtex/johnny-five/tags","blobs_url":"https://api.github.com/repos/dtex/johnny-five/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtex/johnny-five/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtex/johnny-five/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtex/johnny-five/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtex/johnny-five/statuses/{sha}","languages_url":"https://api.github.com/repos/dtex/johnny-five/languages","stargazers_url":"https://api.github.com/repos/dtex/johnny-five/stargazers","contributors_url":"https://api.github.com/repos/dtex/johnny-five/contributors","subscribers_url":"https://api.github.com/repos/dtex/johnny-five/subscribers","subscription_url":"https://api.github.com/repos/dtex/johnny-five/subscription","commits_url":"https://api.github.com/repos/dtex/johnny-five/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtex/johnny-five/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtex/johnny-five/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtex/johnny-five/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtex/johnny-five/contents/{+path}","compare_url":"https://api.github.com/repos/dtex/johnny-five/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtex/johnny-five/merges","archive_url":"https://api.github.com/repos/dtex/johnny-five/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtex/johnny-five/downloads","issues_url":"https://api.github.com/repos/dtex/johnny-five/issues{/number}","pulls_url":"https://api.github.com/repos/dtex/johnny-five/pulls{/number}","milestones_url":"https://api.github.com/repos/dtex/johnny-five/milestones{/number}","notifications_url":"https://api.github.com/repos/dtex/johnny-five/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtex/johnny-five/labels{/name}","releases_url":"https://api.github.com/repos/dtex/johnny-five/releases{/id}","deployments_url":"https://api.github.com/repos/dtex/johnny-five/deployments","created_at":"2015-10-13T04:15:49Z","updated_at":"2016-01-12T04:30:47Z","pushed_at":"2016-09-17T17:06:43Z","git_url":"git://github.com/dtex/johnny-five.git","ssh_url":"git@github.com:dtex/johnny-five.git","clone_url":"https://github.com/dtex/johnny-five.git","svn_url":"https://github.com/dtex/johnny-five","homepage":"http://johnny-five.io","size":86532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwaldron:master","ref":"master","sha":"66b3a716b97d8bf52c5d231dd7412ecccff01b3c","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"repo":{"id":3880513,"name":"johnny-five","full_name":"rwaldron/johnny-five","owner":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaldron/johnny-five","description":"JavaScript Robotics and IoT programming framework, developed at Bocoup.","fork":false,"url":"https://api.github.com/repos/rwaldron/johnny-five","forks_url":"https://api.github.com/repos/rwaldron/johnny-five/forks","keys_url":"https://api.github.com/repos/rwaldron/johnny-five/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaldron/johnny-five/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaldron/johnny-five/teams","hooks_url":"https://api.github.com/repos/rwaldron/johnny-five/hooks","issue_events_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/events{/number}","events_url":"https://api.github.com/repos/rwaldron/johnny-five/events","assignees_url":"https://api.github.com/repos/rwaldron/johnny-five/assignees{/user}","branches_url":"https://api.github.com/repos/rwaldron/johnny-five/branches{/branch}","tags_url":"https://api.github.com/repos/rwaldron/johnny-five/tags","blobs_url":"https://api.github.com/repos/rwaldron/johnny-five/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaldron/johnny-five/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaldron/johnny-five/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaldron/johnny-five/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaldron/johnny-five/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaldron/johnny-five/languages","stargazers_url":"https://api.github.com/repos/rwaldron/johnny-five/stargazers","contributors_url":"https://api.github.com/repos/rwaldron/johnny-five/contributors","subscribers_url":"https://api.github.com/repos/rwaldron/johnny-five/subscribers","subscription_url":"https://api.github.com/repos/rwaldron/johnny-five/subscription","commits_url":"https://api.github.com/repos/rwaldron/johnny-five/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaldron/johnny-five/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaldron/johnny-five/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaldron/johnny-five/contents/{+path}","compare_url":"https://api.github.com/repos/rwaldron/johnny-five/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaldron/johnny-five/merges","archive_url":"https://api.github.com/repos/rwaldron/johnny-five/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaldron/johnny-five/downloads","issues_url":"https://api.github.com/repos/rwaldron/johnny-five/issues{/number}","pulls_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaldron/johnny-five/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaldron/johnny-five/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaldron/johnny-five/labels{/name}","releases_url":"https://api.github.com/repos/rwaldron/johnny-five/releases{/id}","deployments_url":"https://api.github.com/repos/rwaldron/johnny-five/deployments","created_at":"2012-03-30T20:09:52Z","updated_at":"2016-09-19T15:06:24Z","pushed_at":"2016-09-17T17:11:22Z","git_url":"git://github.com/rwaldron/johnny-five.git","ssh_url":"git@github.com:rwaldron/johnny-five.git","clone_url":"https://github.com/rwaldron/johnny-five.git","svn_url":"https://github.com/rwaldron/johnny-five","homepage":"http://johnny-five.io","size":91710,"stargazers_count":6783,"watchers_count":6783,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":957,"mirror_url":null,"open_issues_count":133,"forks":957,"open_issues":133,"watchers":6783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225"},"html":{"href":"https://github.com/rwaldron/johnny-five/pull/1225"},"issue":{"href":"https://api.github.com/repos/rwaldron/johnny-five/issues/1225"},"comments":{"href":"https://api.github.com/repos/rwaldron/johnny-five/issues/1225/comments"},"review_comments":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225/comments"},"review_comment":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/1225/commits"},"statuses":{"href":"https://api.github.com/repos/rwaldron/johnny-five/statuses/21da9aa91f10efac7e69884bc920f96447f8679f"}}}}
{"actor":{"display_login":"rwaldron"}}