{"push_id":1167803870,"size":487,"distinct_size":1,"ref":"refs/heads/qteditor","head":"a7aa89f1683f0bd45133bb497de872235bcbdf9d","before":"9d9db0d9d5d651ebb6b86a8743b528bcc06e8bd4","commits":[{"sha":"8bd61635dc14baf9a1ce72dba1efadb30bfe05bb","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Pump interface:\n\nThe pump gets the interfaces ExtractMaterialFromSource and InsertMaterialAtDrain that allow for overloading the pumping process","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/8bd61635dc14baf9a1ce72dba1efadb30bfe05bb"},{"sha":"f810f210bed1ac0cd73486c58f502af492da1593","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Library: Liquid Container\n\nAdded a new library for liquid containers that is based on the original barrel script.\n\nLibrary_LiquidContainer\n- Extracted the interface from the barrel. The function names and argument types are not final yet.\n- Fixed an inconsistency in the script: There were two ways of determining whether a barrel is suited\n   for a material. Either by name, or material index.\n- renamed argument names to \"liquid_name\" for liquids, \"amount\" for quantities, so that the code is more easily understandable\n- replaced comparison 'fill level > 0' with 'is not empty?'\n- moved storage variables to a local proplist, so that names do not clash\n- Ordered the methods by application and documented each section\n\nBarrel:\n- The original barrel functions delegate to Library_LiquidContainer-functions now, so that the original functionality is not disturbed. Obsolete functions are marked with \"TODO: deprecated\".\n- Moved barrel value change to the update function\n- Moved hit sound effect to separate function\n- Replaced uses of the magic number '3' with a runtime-overloadable call to GetBarrelIntakeY()\n- Replaced comparison 'fill level > 0' with 'is not empty?'\n\nMetalBarrel:\n- Adjusted the hit function. The difference between this and the normal barrel is the hit sound and material position. These should be constants or functions, instead of magic numbers\n- Moved hit sound effect to separate function\n- Removed the Hit()-function, because the hit sound is played in a separate function now\n- With this change the y-offset of the barrel checking for other liquids on a hit is now 3 instead of 7. This should be ok, because the barrels have the same dimensions, it seemed strange that they would have different offsets","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/f810f210bed1ac0cd73486c58f502af492da1593"},{"sha":"64f7b4152edef4b77270a8ffa7cc19b0aa8438e6","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Library: Liquid Container\n\nAdded unit test.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/64f7b4152edef4b77270a8ffa7cc19b0aa8438e6"},{"sha":"9ee44b39edeeb130b1ae999400ffaa9f710e4b58","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Removed old barrel functions\n\nReplaced old barrel functions with the liquid container library calls","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/9ee44b39edeeb130b1ae999400ffaa9f710e4b58"},{"sha":"dbf1f0326f9afc1ed8d99ec78896e631267aff13","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Barrel fill with liquid\n\nThe function had some crazy checks and delegation, now everything is in one function","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/dbf1f0326f9afc1ed8d99ec78896e631267aff13"},{"sha":"8c883937d42f27b40bb9e925e2d126ed4f27da15","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Renamed Set/GetLiquidName to Set/GetLiquidType","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/8c883937d42f27b40bb9e925e2d126ed4f27da15"},{"sha":"d9853d97585570a345088a178f6d5c25f4fa24e7","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Library: Liquid Container\n\nAdded inherited-call to Construction()","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/d9853d97585570a345088a178f6d5c25f4fa24e7"},{"sha":"11e7536b19d85d67b11efa6cc8eac98e16ce25fc","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Pump: Menu action constants\n\nReplaced the hardcoded strings in the pump interaction menu with constants.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/11e7536b19d85d67b11efa6cc8eac98e16ce25fc"},{"sha":"65bc68af3e4c237a2f6d607b4e839388767b38ce","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Library: Tank\n\nDrain and source pipes can be connected to the tank","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/65bc68af3e4c237a2f6d607b4e839388767b38ce"},{"sha":"016922fa2cbe1f613d94ee58820f5dc48b22eb4b","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Pimp, Pipe, SteamEngine\n\nNow it is possible to connect lines from a pump to the steam engine. This is achieved by the steam engine being a liquid tank. It did not seem good to allow connection from pumps to all liquid containers (i.e. barrels). A liquid tank is also a liquid container, they share the same interface, but it is also a structure.\n\nIt is not yet possible to fill the steam engine with any liquid though, because it is not defined what kind of liquid it accepts. This will be oil in the future. Furthermore, the behaviour when the pump adds incompatible liquid is not defined yet.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/016922fa2cbe1f613d94ee58820f5dc48b22eb4b"},{"sha":"affb034b8601a17ef7b57f3dd7a257a4eddedf6d","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Pump, pipe, better menu handling\n\nThe pipe can be connected from the interaction menu now, too. Expanded the disconnection logic, because more problems arise when the pipe can still be connected to other structures - it would be sufficient to remove the line, but that could be annoying:\n- if the pipe is connected to a container, then you can disconnect the pipe from that liquid tank and it will still be connected to the pump\n- if you disconnect the pipe from the pump, then it will disconnect from the liquid tank as well\n\nMaybe this is confusing to the user, we can still kick that out later again.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/affb034b8601a17ef7b57f3dd7a257a4eddedf6d"},{"sha":"788324c07752fee796afa1f86004e2c885f45b0f","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Connection in Liquid Tank\n\nThe liquid tank can connect and deconnect lines properly now","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/788324c07752fee796afa1f86004e2c885f45b0f"},{"sha":"74ae56b056f1a2d73c193d70f481672483f2b697","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Bugfix: Wrong menu entry in pump","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/74ae56b056f1a2d73c193d70f481672483f2b697"},{"sha":"910cf0011de81dd7f002f797aa7c35202a87e0ea","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Bugfix: Insert at wrong object","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/910cf0011de81dd7f002f797aa7c35202a87e0ea"},{"sha":"1ca0484f21316e81eadc7686310c091ba03a92e1","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Pump liquids to liquid containers\n\nThe pump can transfer liquids to and from liquid containers now. Changed the material storage from material index to material name now, because liquid containers may contain fantasy liquids, too. The pipe cannot output such imaginary liquids though, so only transfer between compatible containers is possible.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/1ca0484f21316e81eadc7686310c091ba03a92e1"},{"sha":"f5681434dc6be45173449e01aea67b324b9d0a53","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Pump interface names\n\nThe pump uses the same function names as the liquid tank now. This is a preparation for the consolidation of the two.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/f5681434dc6be45173449e01aea67b324b9d0a53"},{"sha":"0407ad71c43c81f64bebd88b38e0dbfc9227db94","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Analysis for refactoring","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/0407ad71c43c81f64bebd88b38e0dbfc9227db94"},{"sha":"f02dc7cd95da8d34937f50ee4bbaf03860575efc","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Replaced pump pipe variables with library function calls","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/f02dc7cd95da8d34937f50ee4bbaf03860575efc"},{"sha":"83785804919d8e95b8394fb5c460a1c6f51f6df1","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Refactoring: Replaced pump internal liquid storage with library function calls\n\nThe pump actually stores liquid until it can pump. This may not be desired, but it was like that before my changes already. This probably is better than having it drop excess material at the pump.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/83785804919d8e95b8394fb5c460a1c6f51f6df1"},{"sha":"1603f235140ae5098af4392601b427c93eb04148","author":{"name":"Mark","email":"f88cd9cb4b3c360938a5bc1c5e5c0d3f685e1228@hotmail.com"},"message":"Analysis: Pipe object\n\nThe pipe object is very convoluted at the moment. Worked out some requirements for the object and will implement many things in a clean way.","distinct":false,"url":"https://api.github.com/repos/openclonk/openclonk/commits/1603f235140ae5098af4392601b427c93eb04148"}]}
{"actor":{"display_login":"openclonk-mirror"}}