{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/73114826","id":73114826,"diff_hunk":"@@ -323,9 +323,14 @@ def post_cleanup_repos\n           false\n         )\n \n-        Crowbar::Repository.chef_data_bag_destroy(\n-          \"#{repository.data_bag_name}/#{repository.id}\"\n-        )\n+        begin\n+          Crowbar::Repository.chef_data_bag_destroy(\n+            \"#{repository.data_bag_name}/#{repository.id}\"\n+          )\n+        rescue Net::HTTPServerException","path":"crowbar_framework/app/controllers/installer/upgrades_controller.rb","position":11,"original_position":11,"commit_id":"db6351c698570548a21e2cf126f9b408be0b1e56","original_commit_id":"db6351c698570548a21e2cf126f9b408be0b1e56","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"we should, but we can't. first we have to catch all `Net::HTTPServerException` and then if `404` is not in the error response code, we have to raise an Exception again in the rescue block.\r\n\r\nI could change it, would that be fine with you? but then it would not be consistent anymore with all the other places where we handle databags, but we could make a follow up.","created_at":"2016-08-02T08:33:09Z","updated_at":"2016-08-02T08:33:09Z","html_url":"https://github.com/crowbar/crowbar-core/pull/581#discussion_r73114826","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/73114826"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/581#discussion_r73114826"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581","id":79560494,"html_url":"https://github.com/crowbar/crowbar-core/pull/581","diff_url":"https://github.com/crowbar/crowbar-core/pull/581.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/581.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/581","number":581,"state":"open","locked":false,"title":"don't fail on non existing databags","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-01T12:31:37Z","updated_at":"2016-08-02T08:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"227ab8fdaea00a0058f8b9681993b098ee234e8f","assignee":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/581/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/db6351c698570548a21e2cf126f9b408be0b1e56","head":{"label":"MaximilianMeister:cloud6repos","ref":"cloud6repos","sha":"db6351c698570548a21e2cf126f9b408be0b1e56","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":40901479,"name":"crowbar-core","full_name":"MaximilianMeister/crowbar-core","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/crowbar-core","forks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/deployments","created_at":"2015-08-17T14:29:21Z","updated_at":"2015-08-17T14:29:23Z","pushed_at":"2016-08-02T07:47:47Z","git_url":"git://github.com/MaximilianMeister/crowbar-core.git","ssh_url":"git@github.com:MaximilianMeister/crowbar-core.git","clone_url":"https://github.com/MaximilianMeister/crowbar-core.git","svn_url":"https://github.com/MaximilianMeister/crowbar-core","homepage":null,"size":106463,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"fa255501385a12e6d2a86e4cb132f3ff3d88c0fb","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-04-10T12:47:20Z","pushed_at":"2016-08-02T07:47:48Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":120966,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":39,"forks":31,"open_issues":39,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/581"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/581"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/db6351c698570548a21e2cf126f9b408be0b1e56"}}}}
{"actor":{"display_login":"MaximilianMeister"}}