{"action":"created","comment":{"url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/comments/85412419","pull_request_review_id":6131684,"id":85412419,"diff_hunk":"@@ -24,6 +24,7 @@\n           'revision'                      => '01',\n           'version'                       => '2.11.2',\n           'download_folder'               => '/srv',\n+          'md5sum'                        => '',","path":"spec/classes/package_spec.rb","position":null,"original_position":4,"commit_id":"5757d0e82450ccf7700ff90b059736155aa5bfe0","original_commit_id":"8f4cf3b3db967c7f57aa1d97af7df8dfc24d896d","user":{"login":"gbloquel","id":1573530,"avatar_url":"https://avatars.githubusercontent.com/u/1573530?v=3","gravatar_id":"","url":"https://api.github.com/users/gbloquel","html_url":"https://github.com/gbloquel","followers_url":"https://api.github.com/users/gbloquel/followers","following_url":"https://api.github.com/users/gbloquel/following{/other_user}","gists_url":"https://api.github.com/users/gbloquel/gists{/gist_id}","starred_url":"https://api.github.com/users/gbloquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbloquel/subscriptions","organizations_url":"https://api.github.com/users/gbloquel/orgs","repos_url":"https://api.github.com/users/gbloquel/repos","events_url":"https://api.github.com/users/gbloquel/events{/privacy}","received_events_url":"https://api.github.com/users/gbloquel/received_events","type":"User","site_admin":false},"body":"You are almost right.\r\n \r\nmd5sum can not be used with undef value, that will cause during test:\r\n```\r\nruby -c spec/classes/package_spec.rb\r\nspec/classes/package_spec.rb:27: syntax error, unexpected keyword_undef\r\n          'md5sum'                        => undef,\r\n                                                  ^\r\nspec/classes/package_spec.rb:115: syntax error, unexpected keyword_end, expecting '}'\r\nrake aborted!\r\nCommand failed with status (1): [ruby -c spec/classes/package_spec.rb...]\r\n ```\r\ncaused by undef can not be used in hash\r\nTo be tested unset ```md5sum``` is enough  and check if the ```source_hash``` is nil when ```wget::fetch``` is called.\r\n\r\nI add a commit with this.\r\n","created_at":"2016-10-27T19:44:22Z","updated_at":"2016-10-27T19:44:22Z","html_url":"https://github.com/hubspotdevops/puppet-nexus/pull/80#discussion_r85412419","pull_request_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/comments/85412419"},"html":{"href":"https://github.com/hubspotdevops/puppet-nexus/pull/80#discussion_r85412419"},"pull_request":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80","id":88733019,"html_url":"https://github.com/hubspotdevops/puppet-nexus/pull/80","diff_url":"https://github.com/hubspotdevops/puppet-nexus/pull/80.diff","patch_url":"https://github.com/hubspotdevops/puppet-nexus/pull/80.patch","issue_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/80","number":80,"state":"open","locked":false,"title":"FIX #51 possibility to add checksum","user":{"login":"gbloquel","id":1573530,"avatar_url":"https://avatars.githubusercontent.com/u/1573530?v=3","gravatar_id":"","url":"https://api.github.com/users/gbloquel","html_url":"https://github.com/gbloquel","followers_url":"https://api.github.com/users/gbloquel/followers","following_url":"https://api.github.com/users/gbloquel/following{/other_user}","gists_url":"https://api.github.com/users/gbloquel/gists{/gist_id}","starred_url":"https://api.github.com/users/gbloquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbloquel/subscriptions","organizations_url":"https://api.github.com/users/gbloquel/orgs","repos_url":"https://api.github.com/users/gbloquel/repos","events_url":"https://api.github.com/users/gbloquel/events{/privacy}","received_events_url":"https://api.github.com/users/gbloquel/received_events","type":"User","site_admin":false},"body":"New feature to set the checksum.\r\n\r\nTo use  you must use the optional parameter `md5sum`\r\nFor example\r\n```puppet\r\nclass{ '::nexus':\r\n        version               => '3.0.2',\r\n        revision              => '02',\r\n        download_site         => 'http://download.sonatype.com/nexus/3',\r\n        nexus_type            => 'unix',\r\n        md5sum                => '73425709c2c73f368655d32a2c757b24',\r\n        nexus_work_dir_manage => false,\r\n      }\r\n```","created_at":"2016-10-10T21:19:59Z","updated_at":"2016-10-27T19:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"894192220582589ebb98f0cff4dfc8ccaad3f8e4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80/commits","review_comments_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80/comments","review_comment_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/80/comments","statuses_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/statuses/5757d0e82450ccf7700ff90b059736155aa5bfe0","head":{"label":"gbloquel:feature/checksum","ref":"feature/checksum","sha":"5757d0e82450ccf7700ff90b059736155aa5bfe0","user":{"login":"gbloquel","id":1573530,"avatar_url":"https://avatars.githubusercontent.com/u/1573530?v=3","gravatar_id":"","url":"https://api.github.com/users/gbloquel","html_url":"https://github.com/gbloquel","followers_url":"https://api.github.com/users/gbloquel/followers","following_url":"https://api.github.com/users/gbloquel/following{/other_user}","gists_url":"https://api.github.com/users/gbloquel/gists{/gist_id}","starred_url":"https://api.github.com/users/gbloquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbloquel/subscriptions","organizations_url":"https://api.github.com/users/gbloquel/orgs","repos_url":"https://api.github.com/users/gbloquel/repos","events_url":"https://api.github.com/users/gbloquel/events{/privacy}","received_events_url":"https://api.github.com/users/gbloquel/received_events","type":"User","site_admin":false},"repo":{"id":64424704,"name":"puppet-nexus","full_name":"gbloquel/puppet-nexus","owner":{"login":"gbloquel","id":1573530,"avatar_url":"https://avatars.githubusercontent.com/u/1573530?v=3","gravatar_id":"","url":"https://api.github.com/users/gbloquel","html_url":"https://github.com/gbloquel","followers_url":"https://api.github.com/users/gbloquel/followers","following_url":"https://api.github.com/users/gbloquel/following{/other_user}","gists_url":"https://api.github.com/users/gbloquel/gists{/gist_id}","starred_url":"https://api.github.com/users/gbloquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbloquel/subscriptions","organizations_url":"https://api.github.com/users/gbloquel/orgs","repos_url":"https://api.github.com/users/gbloquel/repos","events_url":"https://api.github.com/users/gbloquel/events{/privacy}","received_events_url":"https://api.github.com/users/gbloquel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbloquel/puppet-nexus","description":"Puppet module for Sonatype Nexus","fork":true,"url":"https://api.github.com/repos/gbloquel/puppet-nexus","forks_url":"https://api.github.com/repos/gbloquel/puppet-nexus/forks","keys_url":"https://api.github.com/repos/gbloquel/puppet-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbloquel/puppet-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbloquel/puppet-nexus/teams","hooks_url":"https://api.github.com/repos/gbloquel/puppet-nexus/hooks","issue_events_url":"https://api.github.com/repos/gbloquel/puppet-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/gbloquel/puppet-nexus/events","assignees_url":"https://api.github.com/repos/gbloquel/puppet-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/gbloquel/puppet-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/gbloquel/puppet-nexus/tags","blobs_url":"https://api.github.com/repos/gbloquel/puppet-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbloquel/puppet-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbloquel/puppet-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbloquel/puppet-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbloquel/puppet-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/gbloquel/puppet-nexus/languages","stargazers_url":"https://api.github.com/repos/gbloquel/puppet-nexus/stargazers","contributors_url":"https://api.github.com/repos/gbloquel/puppet-nexus/contributors","subscribers_url":"https://api.github.com/repos/gbloquel/puppet-nexus/subscribers","subscription_url":"https://api.github.com/repos/gbloquel/puppet-nexus/subscription","commits_url":"https://api.github.com/repos/gbloquel/puppet-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbloquel/puppet-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbloquel/puppet-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbloquel/puppet-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbloquel/puppet-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/gbloquel/puppet-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbloquel/puppet-nexus/merges","archive_url":"https://api.github.com/repos/gbloquel/puppet-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbloquel/puppet-nexus/downloads","issues_url":"https://api.github.com/repos/gbloquel/puppet-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/gbloquel/puppet-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/gbloquel/puppet-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/gbloquel/puppet-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbloquel/puppet-nexus/labels{/name}","releases_url":"https://api.github.com/repos/gbloquel/puppet-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/gbloquel/puppet-nexus/deployments","created_at":"2016-07-28T20:04:58Z","updated_at":"2016-07-28T20:04:59Z","pushed_at":"2016-10-27T19:44:16Z","git_url":"git://github.com/gbloquel/puppet-nexus.git","ssh_url":"git@github.com:gbloquel/puppet-nexus.git","clone_url":"https://github.com/gbloquel/puppet-nexus.git","svn_url":"https://github.com/gbloquel/puppet-nexus","homepage":"","size":107,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hubspotdevops:master","ref":"master","sha":"e0080e77da3ee03f610b3a14734899b893e0eed4","user":{"login":"hubspotdevops","id":2530599,"avatar_url":"https://avatars.githubusercontent.com/u/2530599?v=3","gravatar_id":"","url":"https://api.github.com/users/hubspotdevops","html_url":"https://github.com/hubspotdevops","followers_url":"https://api.github.com/users/hubspotdevops/followers","following_url":"https://api.github.com/users/hubspotdevops/following{/other_user}","gists_url":"https://api.github.com/users/hubspotdevops/gists{/gist_id}","starred_url":"https://api.github.com/users/hubspotdevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hubspotdevops/subscriptions","organizations_url":"https://api.github.com/users/hubspotdevops/orgs","repos_url":"https://api.github.com/users/hubspotdevops/repos","events_url":"https://api.github.com/users/hubspotdevops/events{/privacy}","received_events_url":"https://api.github.com/users/hubspotdevops/received_events","type":"Organization","site_admin":false},"repo":{"id":12634315,"name":"puppet-nexus","full_name":"hubspotdevops/puppet-nexus","owner":{"login":"hubspotdevops","id":2530599,"avatar_url":"https://avatars.githubusercontent.com/u/2530599?v=3","gravatar_id":"","url":"https://api.github.com/users/hubspotdevops","html_url":"https://github.com/hubspotdevops","followers_url":"https://api.github.com/users/hubspotdevops/followers","following_url":"https://api.github.com/users/hubspotdevops/following{/other_user}","gists_url":"https://api.github.com/users/hubspotdevops/gists{/gist_id}","starred_url":"https://api.github.com/users/hubspotdevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hubspotdevops/subscriptions","organizations_url":"https://api.github.com/users/hubspotdevops/orgs","repos_url":"https://api.github.com/users/hubspotdevops/repos","events_url":"https://api.github.com/users/hubspotdevops/events{/privacy}","received_events_url":"https://api.github.com/users/hubspotdevops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hubspotdevops/puppet-nexus","description":"Puppet module for Sonatype Nexus","fork":false,"url":"https://api.github.com/repos/hubspotdevops/puppet-nexus","forks_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/forks","keys_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/teams","hooks_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/hooks","issue_events_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/events","assignees_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/tags","blobs_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/languages","stargazers_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/stargazers","contributors_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/contributors","subscribers_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/subscribers","subscription_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/subscription","commits_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/merges","archive_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/downloads","issues_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/labels{/name}","releases_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/hubspotdevops/puppet-nexus/deployments","created_at":"2013-09-06T02:42:48Z","updated_at":"2016-09-29T16:14:06Z","pushed_at":"2016-10-27T19:44:16Z","git_url":"git://github.com/hubspotdevops/puppet-nexus.git","ssh_url":"git@github.com:hubspotdevops/puppet-nexus.git","clone_url":"https://github.com/hubspotdevops/puppet-nexus.git","svn_url":"https://github.com/hubspotdevops/puppet-nexus","homepage":"","size":124,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":10,"forks":51,"open_issues":10,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80"},"html":{"href":"https://github.com/hubspotdevops/puppet-nexus/pull/80"},"issue":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/80"},"comments":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/hubspotdevops/puppet-nexus/statuses/5757d0e82450ccf7700ff90b059736155aa5bfe0"}}}}
{"actor":{"display_login":"gbloquel"}}