{"push_id":1019310814,"size":19,"distinct_size":10,"ref":"refs/heads/invalid_xml","head":"193f7cdb388f88436daf2bd6c45c2e98e76d209f","before":"8bf757fcb4be7ef477da0226c683c478a8e0a2c2","commits":[{"sha":"858bafebbf8ef644d8e1bb887a2caabfbdb8eab9","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildSmartcardCommandLine\n\nAdd new function to manage adding the smartcard device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nAlter the logic slightly to make !nsmartcards check first so that remainder\nof the code is less indented.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/858bafebbf8ef644d8e1bb887a2caabfbdb8eab9"},{"sha":"5ab86400bfeb2fb0d058186fd1d77b271ddc67c4","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildSerialCommandLine\n\nAdd new function to manage adding the serial device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nUsing const virDomainDef causes collateral damage in other called APIs\nwhich need to make the similar adjustment\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/5ab86400bfeb2fb0d058186fd1d77b271ddc67c4"},{"sha":"0e1e7ade29ccf58001edf6d2b6d424d75ab0bf63","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildParallelsCommandLine\n\nAdd new function to manage adding the parallels device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\nAlter logic slight to reduce indention level.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/0e1e7ade29ccf58001edf6d2b6d424d75ab0bf63"},{"sha":"3cdcc910a0c0ea987a220ea7414800bcc9120f5f","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildChannelsCommandLine\n\nAdd new function to manage adding the channel device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/3cdcc910a0c0ea987a220ea7414800bcc9120f5f"},{"sha":"e6944a529e9884340fc2b1d13a2f2b060e1d6f26","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildConsoleCommandLine\n\nAdd new function to manage adding the console device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/e6944a529e9884340fc2b1d13a2f2b060e1d6f26"},{"sha":"9de54baf26e9ed260825b38b322cc3cb20629e75","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Modify qemuBuildTPMCommandLine\n\nModify the argument order and types to match other similar helpers.\n\nAlso modify called functions to use the def->emulator instead of passing\ndef->emulator and def.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/9de54baf26e9ed260825b38b322cc3cb20629e75"},{"sha":"60b1ff52f53cf7ef9512d63e605740612f37d337","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildInputCommandLine\n\nAdd new function to manage adding the input device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nMake qemuBuildUSBInputDevStr static since only this module calls it.\n\nAlso the change to use const virDomainDef forces other changes.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/60b1ff52f53cf7ef9512d63e605740612f37d337"},{"sha":"95ca4fe2f272d1c751acd278cc1617fe2aa1b94b","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Introduce qemuBuildVideoCommandLine\n\nAdd new function to manage adding the video device options to the\ncommand line removing that task from the mainline qemuBuildCommandLine.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/95ca4fe2f272d1c751acd278cc1617fe2aa1b94b"},{"sha":"a25d4891c7f78ee31e1ddbb23dba6e1fd4fb5dbb","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Don't access uninitialized memory\n\nIn qemuConnectDomainXMLToNative() we set up the monitor, but we never\nmemset() it to zeros.  Thanks to the introduction of the logfile\nparameter of chardevs (and the logfile member of the struct), we started\nchecking whether that's non-NULL and that exposed this old error.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/a25d4891c7f78ee31e1ddbb23dba6e1fd4fb5dbb"},{"sha":"88756a09f2f3bcfb20b212dd7860be4d8b39490a","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"conf, virsh: Add new domain shutoff reason\n\nThis new reason means the domain is shutoff because parsing of the XML\nfailed while daemon was starting and from user's point of view, there's\nnothing else to do with it other than re-defining it.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/88756a09f2f3bcfb20b212dd7860be4d8b39490a"},{"sha":"8a8a8a54a732547a24908c283fd0ac8d059c8d03","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"virsh: Refactor the table output of the list command\n\nClean up some duplicate code so it is easier to add new parameters.  The\ntests need to be adjusted because after this patch there will be\nadditional spaces at the end of lines in the output of virsh list, but\nthis affects only the table output that is meant to be read by users.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/8a8a8a54a732547a24908c283fd0ac8d059c8d03"},{"sha":"308101ec7422edae7a77b229bd1f18bd2b8ab392","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"virsh: Add support for list -reason\n\nAdd new parameter for the list command, --reason.  This adds another\noptional column in the table output of listed domains.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/308101ec7422edae7a77b229bd1f18bd2b8ab392"},{"sha":"4726c14191802a339d32c5a948170be215bf979e","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Few whitespace cleanups\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/4726c14191802a339d32c5a948170be215bf979e"},{"sha":"69bcc886a4a4878443b0a714d2941625f64175c9","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"conf: Extract name-parsing into its own function\n\nCreate virDomainDefParseName that parses only the name from XML\ndefinition.  This will be used in future patches.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/69bcc886a4a4878443b0a714d2941625f64175c9"},{"sha":"31e2190d1a4b00eebf48a707247ebadaaeda0681","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"conf: Extract UUID parsing into its own function\n\nCreate virDomainDefParseUUID that parses only the UUID from XML\ndefinition.  This will be used in future patch(es).\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/31e2190d1a4b00eebf48a707247ebadaaeda0681"},{"sha":"258843f97eb2baca43df3c8158b91fb609146830","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"conf: Optionally keep domains with invalid XML, but don't allow starting them\n\nAdd new parameter to virDomainObjListLoadConfig() and\nvirDomainObjListLoadAllConfigs() that controls whether domains with\ninvalid XML (which could not be parsed) should be kept in order not to\nlose track of them.  For now, the parameter is set to false in all\ncallers.  Each driver can switch it to true when it is prepared to deal\nwith such domains.\n\nFor the domain object to be created add virDomainDefParseMinimal() that\nparses only name and UUID from the XML definition.  UUID must be\npresent, it will not be generated.  The purpose of this function is to\nbe used when all else fails, but we still want a domain object to work\nwith.\n\nAlso explicitly disable adding the invalid domain into the list of\nactive ones, as that would render our internal structures inconsistent.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/258843f97eb2baca43df3c8158b91fb609146830"},{"sha":"d79897233c76ba8b1f7a5aa3b0d0380e88a49aa4","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Don't lookup invalid domains unless specified otherwise\n\nChange qemuDomObjFromDomain() to qemuDomObjFromDomainInternal() with\nadditional parameter that controls how to deal with invalid domains.\nNew qemuDomObjFromDomain() then follows the safe path wo we don't have\nto change its callers from all APIs and qemuDomObjFromDomainInvalid() is\nadded as a new function that can be called from APIs that are prepared\nto handle invalid definitions as well.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/d79897233c76ba8b1f7a5aa3b0d0380e88a49aa4"},{"sha":"ddc0aad0a0d796d65e89dc667979aaf7ee39e9f7","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Prepare basic APIs to handle invalid defs\n\nIn order for the user to be able to fix broken domains function\nqemuDomainGetXMLDesc() needs to be able to lookup invalid domain\ndefinitions and handle them properly.  When redefined, function\nqemuDomainDefineXMLFlags() must clear the 'invalid XML' reason.  As a\nnice addition, qemuDomainGetState() can lookup such domains without any\nother change and that allows virsh not only to get their status, but\nalso to list them.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/ddc0aad0a0d796d65e89dc667979aaf7ee39e9f7"},{"sha":"193f7cdb388f88436daf2bd6c45c2e98e76d209f","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Load domains with invalid XML on start\n\nIf we load such domains, we don't need to handle invalid XML checking in\nqemuProcessStart, but we can move it to qemuDomainDefPostParse() or even\ninto the parsing functions if all goes well.  So the only thing we'll\nneed to worry about after this is XML parsing code that would error out\nfor running domains or non-qemu drivers.  The latter will be fixed in\nfollowing patches, hence making the active XML parsing the only\nproblematic part.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/193f7cdb388f88436daf2bd6c45c2e98e76d209f"}]}