{"action":"created","issue":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/994","repository_url":"https://api.github.com/repos/mlr-org/mlr","labels_url":"https://api.github.com/repos/mlr-org/mlr/issues/994/labels{/name}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/994/comments","events_url":"https://api.github.com/repos/mlr-org/mlr/issues/994/events","html_url":"https://github.com/mlr-org/mlr/issues/994","id":164522248,"number":994,"title":"plotPartialDependence does not check (and doc) which models can be drawn","user":{"login":"berndbischl","id":1225974,"avatar_url":"https://avatars.githubusercontent.com/u/1225974?v=3","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false},"assignees":[{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mlr-org/mlr/milestones/3","html_url":"https://github.com/mlr-org/mlr/milestones/v2.11","labels_url":"https://api.github.com/repos/mlr-org/mlr/milestones/3/labels","id":1320229,"number":3,"title":"v2.11","description":"","creator":{"login":"berndbischl","id":1225974,"avatar_url":"https://avatars.githubusercontent.com/u/1225974?v=3","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":23,"state":"open","created_at":"2015-09-23T12:15:41Z","updated_at":"2016-07-08T13:13:18Z","due_on":"2016-07-30T22:00:00Z","closed_at":null},"comments":3,"created_at":"2016-07-08T12:39:23Z","updated_at":"2016-07-08T15:28:08Z","closed_at":null,"body":"hi,\r\n\r\nthis is really a mini issue, but\r\n\r\na) \r\n\r\n```\r\nlrn = makeLearner(\"classif.rpart\")\r\nm = train(lrn, iris.task)\r\npd = generatePartialDependenceData(m, iris.task)\r\n```\r\n\r\nthis leads to an uninformative error of \r\nfunction argument must return a numeric vector with length equal to the number of target class levels.\r\n\r\nbut i guess it should tell me that my learner did not predict probs.\r\nyou should simply check the passed wrapped model.\r\n\r\nb)\r\nthe docs also seem to be quite generic. can we please add a few sentences to describe what is drawn? and for what models? like: estimated probs for positive class, what for multiclass, the we dont support it for bla....\r\n"},"comment":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/comments/231390531","html_url":"https://github.com/mlr-org/mlr/issues/994#issuecomment-231390531","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/994","id":231390531,"user":{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T15:28:08Z","updated_at":"2016-07-08T15:28:08Z","body":"I added a more informative error message.\r\n\r\nI was looking at the docs for the output and I am not sure what is vague. Under the 'data' part of \"object members\" it says that you get a columns for predictions, 1 for regression and survival, and a column with a predicted probability for each class. I guess  the only thing omitted is that for binary classification the predict method drops the negative class by default. But that is already documented there."}}
{"actor":{"display_login":"zmjones"}}