{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/84974961","pull_request_review_id":5712046,"id":84974961,"diff_hunk":"@@ -235,7 +311,7 @@ bool GenerateAddOne(\n \n // Test PGGenericFuncGenerator with 1 arguments\n TEST_F(CodegenPGFuncGeneratorTest, PGGenericFuncGeneratorOneArgTest) {\n-  using AddOneFn = int32_t (*) (Datum);\n+  using AddOneFn = Datum (*) (Datum);","path":"src/backend/codegen/tests/codegen_pg_func_generator_unittest.cc","position":157,"original_position":157,"commit_id":"56a7ccd08f66335f35994ec235507d19ddeca4df","original_commit_id":"56a7ccd08f66335f35994ec235507d19ddeca4df","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"body":"I still like to keep PGFunc to return values based on its class template return type.","created_at":"2016-10-25T18:53:34Z","updated_at":"2016-10-25T18:53:58Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1239#discussion_r84974961","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/84974961"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1239#discussion_r84974961"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239","id":90291064,"html_url":"https://github.com/greenplum-db/gpdb/pull/1239","diff_url":"https://github.com/greenplum-db/gpdb/pull/1239.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1239.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1239","number":1239,"state":"open","locked":false,"title":"Support null attributes in codegen expression evaluation framework","user":{"login":"armenatzoglou","id":9626616,"avatar_url":"https://avatars.githubusercontent.com/u/9626616?v=3","gravatar_id":"","url":"https://api.github.com/users/armenatzoglou","html_url":"https://github.com/armenatzoglou","followers_url":"https://api.github.com/users/armenatzoglou/followers","following_url":"https://api.github.com/users/armenatzoglou/following{/other_user}","gists_url":"https://api.github.com/users/armenatzoglou/gists{/gist_id}","starred_url":"https://api.github.com/users/armenatzoglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armenatzoglou/subscriptions","organizations_url":"https://api.github.com/users/armenatzoglou/orgs","repos_url":"https://api.github.com/users/armenatzoglou/repos","events_url":"https://api.github.com/users/armenatzoglou/events{/privacy}","received_events_url":"https://api.github.com/users/armenatzoglou/received_events","type":"User","site_admin":false},"body":"Enhancing PGFuncGeneratorInterface, PGIRBuilderFuncGenerator, and PGGenericFuncGenerator with\r\nattributes and checks that record and examine if a built-in function is strict or not and\r\ngenerate code accordingly. \r\n\r\nIn particular, each class that implements PGFuncGeneratorInterface has an is_strict member. When it generates code for the built-in function, it examines if the function is strict and creates arguments' nullity check blocks respectively. Also, caller passes a populated llvm_arguments_isNull vector (i.e., llvm_arguments_isNull[0] is true if arg0 is null) as argument to PGFuncGeneratorInfo so that arguments' nullity checks can be implemented.    \r\n\r\nMoreover, we have enhanced int4, int8, date, and float8 icg tests, and codegen's unittests with nullity check tests.\r\n\r\nAuthors: Nikos Armenatzoglou, Nikhil Kak, and Jimmy Yih","created_at":"2016-10-20T22:13:16Z","updated_at":"2016-10-25T18:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc93ffacf5e0dc32c212df64686ec9bf303f88b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1239/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/56a7ccd08f66335f35994ec235507d19ddeca4df","head":{"label":"armenatzoglou:codegen_expr_framework_nulls_132266253","ref":"codegen_expr_framework_nulls_132266253","sha":"56a7ccd08f66335f35994ec235507d19ddeca4df","user":{"login":"armenatzoglou","id":9626616,"avatar_url":"https://avatars.githubusercontent.com/u/9626616?v=3","gravatar_id":"","url":"https://api.github.com/users/armenatzoglou","html_url":"https://github.com/armenatzoglou","followers_url":"https://api.github.com/users/armenatzoglou/followers","following_url":"https://api.github.com/users/armenatzoglou/following{/other_user}","gists_url":"https://api.github.com/users/armenatzoglou/gists{/gist_id}","starred_url":"https://api.github.com/users/armenatzoglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armenatzoglou/subscriptions","organizations_url":"https://api.github.com/users/armenatzoglou/orgs","repos_url":"https://api.github.com/users/armenatzoglou/repos","events_url":"https://api.github.com/users/armenatzoglou/events{/privacy}","received_events_url":"https://api.github.com/users/armenatzoglou/received_events","type":"User","site_admin":false},"repo":{"id":46088373,"name":"gpdb","full_name":"armenatzoglou/gpdb","owner":{"login":"armenatzoglou","id":9626616,"avatar_url":"https://avatars.githubusercontent.com/u/9626616?v=3","gravatar_id":"","url":"https://api.github.com/users/armenatzoglou","html_url":"https://github.com/armenatzoglou","followers_url":"https://api.github.com/users/armenatzoglou/followers","following_url":"https://api.github.com/users/armenatzoglou/following{/other_user}","gists_url":"https://api.github.com/users/armenatzoglou/gists{/gist_id}","starred_url":"https://api.github.com/users/armenatzoglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armenatzoglou/subscriptions","organizations_url":"https://api.github.com/users/armenatzoglou/orgs","repos_url":"https://api.github.com/users/armenatzoglou/repos","events_url":"https://api.github.com/users/armenatzoglou/events{/privacy}","received_events_url":"https://api.github.com/users/armenatzoglou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/armenatzoglou/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/armenatzoglou/gpdb","forks_url":"https://api.github.com/repos/armenatzoglou/gpdb/forks","keys_url":"https://api.github.com/repos/armenatzoglou/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armenatzoglou/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armenatzoglou/gpdb/teams","hooks_url":"https://api.github.com/repos/armenatzoglou/gpdb/hooks","issue_events_url":"https://api.github.com/repos/armenatzoglou/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/armenatzoglou/gpdb/events","assignees_url":"https://api.github.com/repos/armenatzoglou/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/armenatzoglou/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/armenatzoglou/gpdb/tags","blobs_url":"https://api.github.com/repos/armenatzoglou/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armenatzoglou/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armenatzoglou/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/armenatzoglou/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armenatzoglou/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/armenatzoglou/gpdb/languages","stargazers_url":"https://api.github.com/repos/armenatzoglou/gpdb/stargazers","contributors_url":"https://api.github.com/repos/armenatzoglou/gpdb/contributors","subscribers_url":"https://api.github.com/repos/armenatzoglou/gpdb/subscribers","subscription_url":"https://api.github.com/repos/armenatzoglou/gpdb/subscription","commits_url":"https://api.github.com/repos/armenatzoglou/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/armenatzoglou/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/armenatzoglou/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/armenatzoglou/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/armenatzoglou/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/armenatzoglou/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armenatzoglou/gpdb/merges","archive_url":"https://api.github.com/repos/armenatzoglou/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armenatzoglou/gpdb/downloads","issues_url":"https://api.github.com/repos/armenatzoglou/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/armenatzoglou/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/armenatzoglou/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/armenatzoglou/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armenatzoglou/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/armenatzoglou/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/armenatzoglou/gpdb/deployments","created_at":"2015-11-12T23:55:27Z","updated_at":"2016-03-24T20:22:54Z","pushed_at":"2016-10-22T17:38:11Z","git_url":"git://github.com/armenatzoglou/gpdb.git","ssh_url":"git@github.com:armenatzoglou/gpdb.git","clone_url":"https://github.com/armenatzoglou/gpdb.git","svn_url":"https://github.com/armenatzoglou/gpdb","homepage":"http://greenplum.org","size":179767,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"ddcfb863c2da8710b4be0e0e842086ca477fc6ca","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-10-24T02:22:50Z","pushed_at":"2016-10-25T10:09:24Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":230582,"stargazers_count":1652,"watchers_count":1652,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":111,"forks":471,"open_issues":111,"watchers":1652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1239"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1239"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1239/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1239/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/56a7ccd08f66335f35994ec235507d19ddeca4df"}}}}
{"actor":{"display_login":"karthijrk"}}