{"action":"closed","number":1789,"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789","id":52310380,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1789","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1789.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1789.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1789","number":1789,"state":"closed","locked":false,"title":"Reworked RVM configuration for Ruby","user":{"login":"mwpastore","id":8540936,"avatar_url":"https://avatars.githubusercontent.com/u/8540936?v=3","gravatar_id":"","url":"https://api.github.com/users/mwpastore","html_url":"https://github.com/mwpastore","followers_url":"https://api.github.com/users/mwpastore/followers","following_url":"https://api.github.com/users/mwpastore/following{/other_user}","gists_url":"https://api.github.com/users/mwpastore/gists{/gist_id}","starred_url":"https://api.github.com/users/mwpastore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwpastore/subscriptions","organizations_url":"https://api.github.com/users/mwpastore/orgs","repos_url":"https://api.github.com/users/mwpastore/repos","events_url":"https://api.github.com/users/mwpastore/events{/privacy}","received_events_url":"https://api.github.com/users/mwpastore/received_events","type":"User","site_admin":false},"body":"RVM [stable] typically only has one \"[known](https://github.com/rvm/rvm/blob/stable/config/known)\" minor version for each major version, e.g. Ruby 2.1.5 for 2.1 and 2.2.1 for 2.2, JRuby 1.7.19 for JRuby 1.7, etc. In light of this, the way the Ruby languages are configured in FrameworkBenchmarks today is somewhat obtuse. A lot of the tests are broken at install time because they depend on a version of Ruby that is not available in RVM [stable]! \r\n\r\nTo address this problem, I've renamed and slightly modified the language setup scripts for Ruby to point to the current versions in RVM [stable] and establish environment variables for the test setup scripts to reference (after invoking `fw_depends`). This system seems to work well and will be much easier to keep up-to-date with RVM as they turn out new stable releases. (There is a little bit of a crisis at the moment because the maintainer of RVM is essentially AWOL and hasn't merged into the stable branch since March, but this will hopefully soon be resolved.)\r\n\r\nI've also taken this opportunity to reorganize the way JRuby depends on Java. Each setup script for a JRuby-based test was requiring (via `fw_depends`) a jruby and a jdk. I moved the dependency on java out of the test setup script and into the jruby language setup script. I think this makes much more sense but I'm interested to know if the team agrees. Allowing different combinations of the same JRuby and Java versions makes the benchmarks less comparable and adds a complexity to FrameworkBenchmarks that should be the responsibility of the JRuby team (i.e. figuring out how JRuby should interoperate with Java). \r\n\r\nFinally, I noticed that Bundler was being used inconsistently and in some cases incorrectly by the various Ruby test setup scripts. I've modified them to consistently install Gems locally, four ways simultaneously, and added `.gitignore` rules to exclude `.bundler` and `vendor/bundle` per standard Ruby project practices. Please let me know if you have any questions or corrections.\r\n\r\nThank you!\r\n\r\nHousekeeping: This replaces and obsoletes PR #1788. (I swear I'll get the hang of this eventually...)","created_at":"2015-12-01T20:22:05Z","updated_at":"2016-01-18T16:58:59Z","closed_at":"2016-01-18T16:58:59Z","merged_at":"2016-01-18T16:58:59Z","merge_commit_sha":"aacfe7e839acfe848a61373d40c92a29f8f304b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1789/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/8ec537e306bf5339274d987ce6d998ddc5e637ae","head":{"label":"mwpastore:reorganize-ruby-versions-rebased","ref":"reorganize-ruby-versions-rebased","sha":"8ec537e306bf5339274d987ce6d998ddc5e637ae","user":{"login":"mwpastore","id":8540936,"avatar_url":"https://avatars.githubusercontent.com/u/8540936?v=3","gravatar_id":"","url":"https://api.github.com/users/mwpastore","html_url":"https://github.com/mwpastore","followers_url":"https://api.github.com/users/mwpastore/followers","following_url":"https://api.github.com/users/mwpastore/following{/other_user}","gists_url":"https://api.github.com/users/mwpastore/gists{/gist_id}","starred_url":"https://api.github.com/users/mwpastore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwpastore/subscriptions","organizations_url":"https://api.github.com/users/mwpastore/orgs","repos_url":"https://api.github.com/users/mwpastore/repos","events_url":"https://api.github.com/users/mwpastore/events{/privacy}","received_events_url":"https://api.github.com/users/mwpastore/received_events","type":"User","site_admin":false},"repo":{"id":46996931,"name":"FrameworkBenchmarks","full_name":"mwpastore/FrameworkBenchmarks","owner":{"login":"mwpastore","id":8540936,"avatar_url":"https://avatars.githubusercontent.com/u/8540936?v=3","gravatar_id":"","url":"https://api.github.com/users/mwpastore","html_url":"https://github.com/mwpastore","followers_url":"https://api.github.com/users/mwpastore/followers","following_url":"https://api.github.com/users/mwpastore/following{/other_user}","gists_url":"https://api.github.com/users/mwpastore/gists{/gist_id}","starred_url":"https://api.github.com/users/mwpastore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwpastore/subscriptions","organizations_url":"https://api.github.com/users/mwpastore/orgs","repos_url":"https://api.github.com/users/mwpastore/repos","events_url":"https://api.github.com/users/mwpastore/events{/privacy}","received_events_url":"https://api.github.com/users/mwpastore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwpastore/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":true,"url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/mwpastore/FrameworkBenchmarks/releases{/id}","created_at":"2015-11-27T19:49:01Z","updated_at":"2015-11-27T19:49:14Z","pushed_at":"2015-12-15T19:52:40Z","git_url":"git://github.com/mwpastore/FrameworkBenchmarks.git","ssh_url":"git@github.com:mwpastore/FrameworkBenchmarks.git","clone_url":"https://github.com/mwpastore/FrameworkBenchmarks.git","svn_url":"https://github.com/mwpastore/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":140671,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TechEmpower:master","ref":"master","sha":"c948188e6df9cff4f460453585f44ffab78ad5b2","user":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars.githubusercontent.com/u/3910062?v=3","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"repo":{"id":8957264,"name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars.githubusercontent.com/u/3910062?v=3","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","created_at":"2013-03-22T17:33:54Z","updated_at":"2016-01-18T12:27:49Z","pushed_at":"2016-01-18T16:58:58Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"git@github.com:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":266815,"stargazers_count":2021,"watchers_count":2021,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":701,"mirror_url":null,"open_issues_count":154,"forks":701,"open_issues":154,"watchers":2021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1789"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1789"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1789/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1789/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/8ec537e306bf5339274d987ce6d998ddc5e637ae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"msmith-techempower","id":4983416,"avatar_url":"https://avatars.githubusercontent.com/u/4983416?v=3","gravatar_id":"","url":"https://api.github.com/users/msmith-techempower","html_url":"https://github.com/msmith-techempower","followers_url":"https://api.github.com/users/msmith-techempower/followers","following_url":"https://api.github.com/users/msmith-techempower/following{/other_user}","gists_url":"https://api.github.com/users/msmith-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/msmith-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmith-techempower/subscriptions","organizations_url":"https://api.github.com/users/msmith-techempower/orgs","repos_url":"https://api.github.com/users/msmith-techempower/repos","events_url":"https://api.github.com/users/msmith-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/msmith-techempower/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":1,"additions":261,"deletions":244,"changed_files":53}}