{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/5330","labels_url":"https://api.github.com/repos/facebook/react-native/issues/5330/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5330/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/5330/events","html_url":"https://github.com/facebook/react-native/pull/5330","id":126825018,"number":5330,"title":"[Android] ScrollEnabled proptype implementation on ScrollView","user":{"login":"jthestupidkid","id":8704533,"avatar_url":"https://avatars.githubusercontent.com/u/8704533?v=3","gravatar_id":"","url":"https://api.github.com/users/jthestupidkid","html_url":"https://github.com/jthestupidkid","followers_url":"https://api.github.com/users/jthestupidkid/followers","following_url":"https://api.github.com/users/jthestupidkid/following{/other_user}","gists_url":"https://api.github.com/users/jthestupidkid/gists{/gist_id}","starred_url":"https://api.github.com/users/jthestupidkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthestupidkid/subscriptions","organizations_url":"https://api.github.com/users/jthestupidkid/orgs","repos_url":"https://api.github.com/users/jthestupidkid/repos","events_url":"https://api.github.com/users/jthestupidkid/events{/privacy}","received_events_url":"https://api.github.com/users/jthestupidkid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-15T07:59:55Z","updated_at":"2016-01-15T15:17:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5330","html_url":"https://github.com/facebook/react-native/pull/5330","diff_url":"https://github.com/facebook/react-native/pull/5330.diff","patch_url":"https://github.com/facebook/react-native/pull/5330.patch"},"body":"On `ReactScrollView.java` \r\nadded property on line 30,\r\n\r\n```\r\n...\r\nprivate boolean mScrollEnabled;\r\n...\r\n```\r\n\r\nmodified if-statement on line 68,\r\n\r\n```\r\n...\r\npublic boolean onInterceptTouchEvent(MotionEvent ev) {\r\n    if (super.onInterceptTouchEvent(ev) && mScrollEnabled) {\r\n...\r\n```\r\n\r\nand modified line 85,\r\n\r\n```\r\n....\r\nif (mScrollEnabled) {\r\n  return super.onTouchEvent(ev);\r\n}\r\n  return false;\r\n...\r\n```\r\n\r\nOn `ReactScrollViewManager.java`\r\nadded on line 86,\r\n\r\n```\r\n...\r\n@ReactProp(name = \"scrollEnabled\")\r\npublic void setScrollEnabled(ReactScrollView view, boolean value) {\r\n  view.setScrollEnabled(value);\r\n}\r\n...\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/171988665","html_url":"https://github.com/facebook/react-native/pull/5330#issuecomment-171988665","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5330","id":171988665,"user":{"login":"dmmiller","id":4934258,"avatar_url":"https://avatars.githubusercontent.com/u/4934258?v=3","gravatar_id":"","url":"https://api.github.com/users/dmmiller","html_url":"https://github.com/dmmiller","followers_url":"https://api.github.com/users/dmmiller/followers","following_url":"https://api.github.com/users/dmmiller/following{/other_user}","gists_url":"https://api.github.com/users/dmmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmiller/subscriptions","organizations_url":"https://api.github.com/users/dmmiller/orgs","repos_url":"https://api.github.com/users/dmmiller/repos","events_url":"https://api.github.com/users/dmmiller/events{/privacy}","received_events_url":"https://api.github.com/users/dmmiller/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T15:17:20Z","updated_at":"2016-01-15T15:17:20Z","body":"Can you also give some indication of what testing you did?"}}