{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/594","repository_url":"https://api.github.com/repos/ethereum/webthree-umbrella","labels_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/594/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/594/comments","events_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/594/events","html_url":"https://github.com/ethereum/webthree-umbrella/issues/594","id":160847375,"number":594,"title":"Ubuntu - Clang unknown argument: '-fstack-protector-strong'","user":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/webthree-umbrella/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-17T09:26:35Z","updated_at":"2016-06-17T09:38:13Z","closed_at":null,"body":"It appears that our `-fstack-protector-strong` and `-fstack-protector` compiler settings for Clang aren't quite right.\r\n\r\n@gcolvin is hitting this right now for Clang on Ubuntu Trusty.\r\n\r\nThe code in question is at https://github.com/ethereum/webthree-helpers/blob/aaee8042b6e6d40143c6d1887f331c0e5a415f6c/cmake/EthCompilerSettings.cmake#L92\r\n\r\nFor the GCC branch, we are only using these settings for GCC 4.9+, but we are using these settings unconditionally for Clang at the time of writing, both for AppleClang on OS X and for Clang on other platforms.\r\n\r\nLooks like we probably need some conditionals for Clang too, and we need to determine exactly what those should be.   I imagine that this setting was only added in later versions of Clang, so we need some \"if Clang version >= xxx\" conditional here too.    Greg will be suffering because he is way back on Trusty.\r\n\r\nLooks like Trusty has Clang-3.4 (http://packages.ubuntu.com/trusty/clang), and Xenial has Clang-3.8 (http://packages.ubuntu.com/xenial/clang).\r\n\r\nSome relevant URLs elsewhere on this topic:\r\n- https://github.com/travitch/whole-program-llvm/issues/15\r\n- https://github.com/rubinius/rubinius/issues/3001"},"comment":{"url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/comments/226725878","html_url":"https://github.com/ethereum/webthree-umbrella/issues/594#issuecomment-226725878","issue_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/594","id":226725878,"user":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T09:38:13Z","updated_at":"2016-06-17T09:38:13Z","body":"Here is the commit where `-fstack-protector-strong` was added, on 10th February 2014, which was after Clang-3.4 release on 2nd Jan 2014 and before Clang-3.4.1 release on 7th May 2014.\r\n\r\nhttp://reviews.llvm.org/rL201120"}}
{"actor":{"display_login":"bobsummerwill"}}