{"action":"created","comment":{"url":"https://api.github.com/repos/ethcore/parity-ui/pulls/comments/71572090","id":71572090,"diff_hunk":"@@ -15,33 +15,80 @@ export default handleActions({\n     };\n   },\n \n-  'add confirmedTransaction' (state, action) {\n-    const pending = state.pending.filter(tx => tx.id !== action.payload.id);\n+  'start confirmTransaction' (state, action) {\n+    const pending = state.pending.map(p => {\n+      if (p.id === action.payload.id) {\n+        p.isSending = true;\n+      }\n+      return p;\n+    });\n+    return {\n+      ...state,\n+      pending\n+    };\n+  },\n \n+  'success confirmTransaction' (state, action) {\n+    const { id, txHash } = action.payload;\n+    const confirmed = Object.assign({},\n+      state.pending.find(p => p.id === id),\n+      { txHash }, { status: 'confirmed' }\n+    );\n     return {\n       ...state,\n-      pending,\n-      finished: [action.payload].concat(state.finished)\n+      pending: state.pending.filter(tx => tx.id !== action.payload.id),\n+      finished: [confirmed].concat(state.finished)\n     };\n   },\n \n-  'add errorTransaction' (state, action) {\n-    const pending = state.pending.filter(tx => tx.id !== action.payload.id);\n+  'error confirmTransaction' (state, action) {\n+    const pending = state.pending.map(p => {\n+      if (p.id === action.payload.id) {\n+        p.isSending = false;\n+      }\n+      return p;\n+    });\n+    return {\n+      ...state,\n+      pending\n+    };\n+  },\n \n+  'start rejectTransaction' (state, action) {\n+    const pending = state.pending.map(p => {","path":"signer/web/src/reducers/transactions.js","position":50,"original_position":50,"commit_id":"51d4ddc9c48214ae780373043798fdee2570e251","original_commit_id":"51d4ddc9c48214ae780373043798fdee2570e251","user":{"login":"tomusdrw","id":581548,"avatar_url":"https://avatars.githubusercontent.com/u/581548?v=3","gravatar_id":"","url":"https://api.github.com/users/tomusdrw","html_url":"https://github.com/tomusdrw","followers_url":"https://api.github.com/users/tomusdrw/followers","following_url":"https://api.github.com/users/tomusdrw/following{/other_user}","gists_url":"https://api.github.com/users/tomusdrw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomusdrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomusdrw/subscriptions","organizations_url":"https://api.github.com/users/tomusdrw/orgs","repos_url":"https://api.github.com/users/tomusdrw/repos","events_url":"https://api.github.com/users/tomusdrw/events{/privacy}","received_events_url":"https://api.github.com/users/tomusdrw/received_events","type":"User","site_admin":false},"body":"Maybe it would be better to store transactions in a `Map/Object` instead of an array?","created_at":"2016-07-20T17:42:39Z","updated_at":"2016-07-20T17:42:39Z","html_url":"https://github.com/ethcore/parity-ui/pull/84#discussion_r71572090","pull_request_url":"https://api.github.com/repos/ethcore/parity-ui/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/comments/71572090"},"html":{"href":"https://github.com/ethcore/parity-ui/pull/84#discussion_r71572090"},"pull_request":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/ethcore/parity-ui/pulls/84","id":78186396,"html_url":"https://github.com/ethcore/parity-ui/pull/84","diff_url":"https://github.com/ethcore/parity-ui/pull/84.diff","patch_url":"https://github.com/ethcore/parity-ui/pull/84.patch","issue_url":"https://api.github.com/repos/ethcore/parity-ui/issues/84","number":84,"state":"open","locked":false,"title":"Broken ws","user":{"login":"goldylucks","id":6963212,"avatar_url":"https://avatars.githubusercontent.com/u/6963212?v=3","gravatar_id":"","url":"https://api.github.com/users/goldylucks","html_url":"https://github.com/goldylucks","followers_url":"https://api.github.com/users/goldylucks/followers","following_url":"https://api.github.com/users/goldylucks/following{/other_user}","gists_url":"https://api.github.com/users/goldylucks/gists{/gist_id}","starred_url":"https://api.github.com/users/goldylucks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldylucks/subscriptions","organizations_url":"https://api.github.com/users/goldylucks/orgs","repos_url":"https://api.github.com/users/goldylucks/repos","events_url":"https://api.github.com/users/goldylucks/events{/privacy}","received_events_url":"https://api.github.com/users/goldylucks/received_events","type":"User","site_admin":false},"body":" - contains #79\r\n - resolves #76, #75, #65 \r\n - fixes broken WS responses introduced in ethcore/parity#1665","created_at":"2016-07-20T17:24:35Z","updated_at":"2016-07-20T17:42:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f9804877dac57dbfe56a5833af11e7d11197da6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethcore/parity-ui/pulls/84/commits","review_comments_url":"https://api.github.com/repos/ethcore/parity-ui/pulls/84/comments","review_comment_url":"https://api.github.com/repos/ethcore/parity-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethcore/parity-ui/issues/84/comments","statuses_url":"https://api.github.com/repos/ethcore/parity-ui/statuses/51d4ddc9c48214ae780373043798fdee2570e251","head":{"label":"ethcore:broken-ws","ref":"broken-ws","sha":"51d4ddc9c48214ae780373043798fdee2570e251","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61940007,"name":"parity-ui","full_name":"ethcore/parity-ui","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity-ui","description":"Repository for all of Parity UI issues and perhaps code.","fork":false,"url":"https://api.github.com/repos/ethcore/parity-ui","forks_url":"https://api.github.com/repos/ethcore/parity-ui/forks","keys_url":"https://api.github.com/repos/ethcore/parity-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity-ui/teams","hooks_url":"https://api.github.com/repos/ethcore/parity-ui/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity-ui/events","assignees_url":"https://api.github.com/repos/ethcore/parity-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity-ui/tags","blobs_url":"https://api.github.com/repos/ethcore/parity-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity-ui/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity-ui/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity-ui/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity-ui/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity-ui/subscription","commits_url":"https://api.github.com/repos/ethcore/parity-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity-ui/merges","archive_url":"https://api.github.com/repos/ethcore/parity-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity-ui/downloads","issues_url":"https://api.github.com/repos/ethcore/parity-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity-ui/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity-ui/deployments","created_at":"2016-06-25T11:20:54Z","updated_at":"2016-07-14T11:56:48Z","pushed_at":"2016-07-20T17:24:35Z","git_url":"git://github.com/ethcore/parity-ui.git","ssh_url":"git@github.com:ethcore/parity-ui.git","clone_url":"https://github.com/ethcore/parity-ui.git","svn_url":"https://github.com/ethcore/parity-ui","homepage":null,"size":8832,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":31,"forks":3,"open_issues":31,"watchers":3,"default_branch":"master"}},"base":{"label":"ethcore:master","ref":"master","sha":"a3cac6568fbfeba2d4faf4a423aec69e2d46a80b","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61940007,"name":"parity-ui","full_name":"ethcore/parity-ui","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity-ui","description":"Repository for all of Parity UI issues and perhaps code.","fork":false,"url":"https://api.github.com/repos/ethcore/parity-ui","forks_url":"https://api.github.com/repos/ethcore/parity-ui/forks","keys_url":"https://api.github.com/repos/ethcore/parity-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity-ui/teams","hooks_url":"https://api.github.com/repos/ethcore/parity-ui/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity-ui/events","assignees_url":"https://api.github.com/repos/ethcore/parity-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity-ui/tags","blobs_url":"https://api.github.com/repos/ethcore/parity-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity-ui/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity-ui/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity-ui/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity-ui/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity-ui/subscription","commits_url":"https://api.github.com/repos/ethcore/parity-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity-ui/merges","archive_url":"https://api.github.com/repos/ethcore/parity-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity-ui/downloads","issues_url":"https://api.github.com/repos/ethcore/parity-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity-ui/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity-ui/deployments","created_at":"2016-06-25T11:20:54Z","updated_at":"2016-07-14T11:56:48Z","pushed_at":"2016-07-20T17:24:35Z","git_url":"git://github.com/ethcore/parity-ui.git","ssh_url":"git@github.com:ethcore/parity-ui.git","clone_url":"https://github.com/ethcore/parity-ui.git","svn_url":"https://github.com/ethcore/parity-ui","homepage":null,"size":8832,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":31,"forks":3,"open_issues":31,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/84"},"html":{"href":"https://github.com/ethcore/parity-ui/pull/84"},"issue":{"href":"https://api.github.com/repos/ethcore/parity-ui/issues/84"},"comments":{"href":"https://api.github.com/repos/ethcore/parity-ui/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethcore/parity-ui/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/ethcore/parity-ui/statuses/51d4ddc9c48214ae780373043798fdee2570e251"}}}}
{"actor":{"display_login":"tomusdrw"}}