{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/92006057","pull_request_review_id":12515483,"id":92006057,"diff_hunk":"@@ -5127,9 +5127,34 @@ in\n     inherit (stdenvAdapters) overrideCC;\n   };\n \n-  llvmPackages_37 = callPackage ../development/compilers/llvm/3.7 {\n-    inherit (stdenvAdapters) overrideCC;\n-  };\n+  llvmPackages_37 =\n+    let\n+\n+      libarchiveBoot = callPackage ../development/libraries/libarchive { xarSupport = false; };\n+\n+      libxml2Boot = callPackage ../development/libraries/libxml2 { pythonSupport = false; };\n+\n+      cmakeBoot = callPackage ../development/tools/build-managers/cmake {\n+        libarchive = libarchiveBoot;\n+        wantPS = stdenv.isDarwin;\n+        inherit (darwin) ps;\n+      };\n+\n+      # This is used to bootstrap clang, don't use this as a runtime dependency.\n+      python27Boot = callPackage ../development/interpreters/python/cpython/2.7/boot.nix {\n+        self = python27Boot;\n+        inherit (darwin) CF configd;\n+      };\n+\n+      llvmPackages = callPackage ../development/compilers/llvm/3.7 {\n+        cmake = cmakeBoot;\n+        libxml2 = libxml2Boot;\n+        python2 = python27Boot;","path":"pkgs/top-level/all-packages.nix","position":29,"original_position":29,"commit_id":"a472338e2983d7f2df0b9c25c0a740beda58aa04","original_commit_id":"a472338e2983d7f2df0b9c25c0a740beda58aa04","user":{"login":"FRidh","id":2129135,"avatar_url":"https://avatars.githubusercontent.com/u/2129135?v=3","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"body":"maybe use this only on Darwin","created_at":"2016-12-12T18:17:41Z","updated_at":"2016-12-12T18:17:41Z","html_url":"https://github.com/NixOS/nixpkgs/pull/21078#discussion_r92006057","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/92006057"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/21078#discussion_r92006057"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078","id":97465900,"html_url":"https://github.com/NixOS/nixpkgs/pull/21078","diff_url":"https://github.com/NixOS/nixpkgs/pull/21078.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/21078.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21078","number":21078,"state":"open","locked":false,"title":"darwin.stdenv: use minimal python to bootstrap clang","user":{"login":"LnL7","id":689294,"avatar_url":"https://avatars.githubusercontent.com/u/689294?v=3","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nBy using a minimal version of python in the stdenv we can remove a bunch of dependencies like `db`, `readline` and `sqlite`.\r\n\r\nI'm testing a branch [WIP](https://github.com/LnL7/nixpkgs/commits/lnl7-wip) with #21078, #21099 and #21101.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n```diff\r\n+bootstrap-python-2.7.12.drv\r\n+bzip2-1.0.6.0.1.drv\r\n-bzip2-1.0.6.0.1.drv\r\n-clang-5.3.patch\r\n+cmake-3.6.2.drv\r\n-cmake-3.6.2.drv\r\n-curl-7.51.0.drv\r\n-curl-7.51.0.tar.bz2.drv\r\n-db-5.3.28.drv\r\n-db-5.3.28.tar.gz.drv\r\n-e0ec3471cb09.drv\r\n-gdbm-1.12.drv\r\n-gdbm-1.12.drv\r\n-gdbm-1.12.tar.gz.drv\r\n-hook.drv\r\n+libarchive-3.2.2.drv\r\n-libarchive-3.2.2.drv\r\n-libssh2-1.7.0.drv\r\n-libssh2-1.7.0.tar.gz.drv\r\n-libxml2-2.9.4.drv\r\n-link-against-ncurses.patch\r\n+lzo-2.09.drv\r\n-lzo-2.09.drv\r\n-no-arch_only-6.3.patch\r\n-openssl-1.0.2j.drv\r\n-openssl-1.0.2j.drv\r\n-openssl-1.0.2j.tar.gz.drv\r\n+pkg-config-0.29.drv\r\n-pkg-config-0.29.drv\r\n-properly-detect-curses.patch\r\n-python-2.7-distutils-C++.patch\r\n-python-2.7.12.drv\r\n-python-2.7.12.drv\r\n-readline-6.3.tar.gz.drv\r\n-readline-6.3p08.drv\r\n-readline-6.3p08.drv\r\n-readline63-001.drv\r\n-readline63-002.drv\r\n-readline63-003.drv\r\n-readline63-004.drv\r\n-readline63-005.drv\r\n-readline63-006.drv\r\n-readline63-007.drv\r\n-readline63-008.drv\r\n-setup-hook.sh\r\n-sqlite-3.15.0.drv\r\n-sqlite-autoconf-3150000.tar.gz.drv\r\n-use-etc-ssl-certs.patch\r\n```","created_at":"2016-12-11T17:33:11Z","updated_at":"2016-12-12T18:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7028a59052e511df5b3fd1a1867d04aa3ea4ab4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21078/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a472338e2983d7f2df0b9c25c0a740beda58aa04","head":{"label":"LnL7:darwin-stdenv-python","ref":"darwin-stdenv-python","sha":"a472338e2983d7f2df0b9c25c0a740beda58aa04","user":{"login":"LnL7","id":689294,"avatar_url":"https://avatars.githubusercontent.com/u/689294?v=3","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false},"repo":{"id":33931833,"name":"nixpkgs","full_name":"LnL7/nixpkgs","owner":{"login":"LnL7","id":689294,"avatar_url":"https://avatars.githubusercontent.com/u/689294?v=3","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LnL7/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/LnL7/nixpkgs","forks_url":"https://api.github.com/repos/LnL7/nixpkgs/forks","keys_url":"https://api.github.com/repos/LnL7/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LnL7/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LnL7/nixpkgs/teams","hooks_url":"https://api.github.com/repos/LnL7/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/LnL7/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/LnL7/nixpkgs/events","assignees_url":"https://api.github.com/repos/LnL7/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/LnL7/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/LnL7/nixpkgs/tags","blobs_url":"https://api.github.com/repos/LnL7/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LnL7/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LnL7/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/LnL7/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LnL7/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/LnL7/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/LnL7/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/LnL7/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/LnL7/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/LnL7/nixpkgs/subscription","commits_url":"https://api.github.com/repos/LnL7/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/LnL7/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/LnL7/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/LnL7/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/LnL7/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/LnL7/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LnL7/nixpkgs/merges","archive_url":"https://api.github.com/repos/LnL7/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LnL7/nixpkgs/downloads","issues_url":"https://api.github.com/repos/LnL7/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/LnL7/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/LnL7/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/LnL7/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LnL7/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/LnL7/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/LnL7/nixpkgs/deployments","created_at":"2015-04-14T13:00:30Z","updated_at":"2016-01-20T22:18:25Z","pushed_at":"2016-12-12T15:20:27Z","git_url":"git://github.com/LnL7/nixpkgs.git","ssh_url":"git@github.com:LnL7/nixpkgs.git","clone_url":"https://github.com/LnL7/nixpkgs.git","svn_url":"https://github.com/LnL7/nixpkgs","homepage":null,"size":365375,"stargazers_count":1,"watchers_count":1,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"09fecd18b2ebf7d309478b90965110b1f02f4650","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-12-12T18:12:00Z","pushed_at":"2016-12-12T18:09:14Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":661166,"stargazers_count":1419,"watchers_count":1419,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1753,"mirror_url":null,"open_issues_count":1692,"forks":1753,"open_issues":1692,"watchers":1419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/21078"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/21078"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/21078/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21078/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a472338e2983d7f2df0b9c25c0a740beda58aa04"}}}}
{"actor":{"display_login":"FRidh"}}