{"action":"created","comment":{"url":"https://api.github.com/repos/joshcough/Scrabble/pulls/comments/61138402","id":61138402,"diff_hunk":"@@ -42,9 +42,13 @@ createMove' :: Validator -- ^\n createMove' validate b (Rack rack) wp dict = if valid then go else errMsg where\n   errMsg        = Left \"error: rack missing input letters\"\n   rackLetters   = fmap letter rack\n-  valid         = containsAll (toString putLetters) (toString rackLetters)\n+  valid         = containsAllWithBlanks (toString putLetters) (toString rackLetters)\n+  blanksUsed    = countBlanksUsed (toString putLetters) (toString rackLetters)","path":"src/Scrabble/Move/Move.hs","position":15,"original_position":15,"commit_id":"722c502e5d13d59eb3a482da69f6d622d146e611","original_commit_id":"722c502e5d13d59eb3a482da69f6d622d146e611","user":{"login":"nicklawls","id":5252770,"avatar_url":"https://avatars.githubusercontent.com/u/5252770?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklawls","html_url":"https://github.com/nicklawls","followers_url":"https://api.github.com/users/nicklawls/followers","following_url":"https://api.github.com/users/nicklawls/following{/other_user}","gists_url":"https://api.github.com/users/nicklawls/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklawls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklawls/subscriptions","organizations_url":"https://api.github.com/users/nicklawls/orgs","repos_url":"https://api.github.com/users/nicklawls/repos","events_url":"https://api.github.com/users/nicklawls/events{/privacy}","received_events_url":"https://api.github.com/users/nicklawls/received_events","type":"User","site_admin":false},"body":"I'll still change them since it will look way better. I'm more just curious if my mental model of laziness is correct","created_at":"2016-04-26T18:24:25Z","updated_at":"2016-04-26T18:24:25Z","html_url":"https://github.com/joshcough/Scrabble/pull/10#discussion_r61138402","pull_request_url":"https://api.github.com/repos/joshcough/Scrabble/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/comments/61138402"},"html":{"href":"https://github.com/joshcough/Scrabble/pull/10#discussion_r61138402"},"pull_request":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/joshcough/Scrabble/pulls/10","id":67432626,"html_url":"https://github.com/joshcough/Scrabble/pull/10","diff_url":"https://github.com/joshcough/Scrabble/pull/10.diff","patch_url":"https://github.com/joshcough/Scrabble/pull/10.patch","issue_url":"https://api.github.com/repos/joshcough/Scrabble/issues/10","number":10,"state":"open","locked":false,"title":"Fix validation of moves with blank tiles","user":{"login":"nicklawls","id":5252770,"avatar_url":"https://avatars.githubusercontent.com/u/5252770?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklawls","html_url":"https://github.com/nicklawls","followers_url":"https://api.github.com/users/nicklawls/followers","following_url":"https://api.github.com/users/nicklawls/following{/other_user}","gists_url":"https://api.github.com/users/nicklawls/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklawls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklawls/subscriptions","organizations_url":"https://api.github.com/users/nicklawls/orgs","repos_url":"https://api.github.com/users/nicklawls/repos","events_url":"https://api.github.com/users/nicklawls/events{/privacy}","received_events_url":"https://api.github.com/users/nicklawls/received_events","type":"User","site_admin":false},"body":"In order to properly account for blank tiles, I replaced the `containsAll` funtion from Scrabble.Search with a version that after failing to match the letter in the wordput with one in the rack, checks for a blank tile in the rack, and if present deletes it and continues the search. This also involves a change to how you compute the `rackRemainder`, and I used a similar technique as in `containsAll` to count the number of blank tiles that get used up in order to produce a valid move. I added tests that address 4 cases: No blank tiles, one blank tile, one of two blank tiles being used, and all two blank tiles being used.","created_at":"2016-04-21T22:28:01Z","updated_at":"2016-04-26T18:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f97d3c22d7b601f09e7adebfe8b4b1adbf429a85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joshcough/Scrabble/pulls/10/commits","review_comments_url":"https://api.github.com/repos/joshcough/Scrabble/pulls/10/comments","review_comment_url":"https://api.github.com/repos/joshcough/Scrabble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joshcough/Scrabble/issues/10/comments","statuses_url":"https://api.github.com/repos/joshcough/Scrabble/statuses/722c502e5d13d59eb3a482da69f6d622d146e611","head":{"label":"nicklawls:blank-tile-validate","ref":"blank-tile-validate","sha":"722c502e5d13d59eb3a482da69f6d622d146e611","user":{"login":"nicklawls","id":5252770,"avatar_url":"https://avatars.githubusercontent.com/u/5252770?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklawls","html_url":"https://github.com/nicklawls","followers_url":"https://api.github.com/users/nicklawls/followers","following_url":"https://api.github.com/users/nicklawls/following{/other_user}","gists_url":"https://api.github.com/users/nicklawls/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklawls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklawls/subscriptions","organizations_url":"https://api.github.com/users/nicklawls/orgs","repos_url":"https://api.github.com/users/nicklawls/repos","events_url":"https://api.github.com/users/nicklawls/events{/privacy}","received_events_url":"https://api.github.com/users/nicklawls/received_events","type":"User","site_admin":false},"repo":{"id":51492056,"name":"Scrabble","full_name":"nicklawls/Scrabble","owner":{"login":"nicklawls","id":5252770,"avatar_url":"https://avatars.githubusercontent.com/u/5252770?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklawls","html_url":"https://github.com/nicklawls","followers_url":"https://api.github.com/users/nicklawls/followers","following_url":"https://api.github.com/users/nicklawls/following{/other_user}","gists_url":"https://api.github.com/users/nicklawls/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklawls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklawls/subscriptions","organizations_url":"https://api.github.com/users/nicklawls/orgs","repos_url":"https://api.github.com/users/nicklawls/repos","events_url":"https://api.github.com/users/nicklawls/events{/privacy}","received_events_url":"https://api.github.com/users/nicklawls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicklawls/Scrabble","description":"A Haskell implementation of Scrabble.","fork":true,"url":"https://api.github.com/repos/nicklawls/Scrabble","forks_url":"https://api.github.com/repos/nicklawls/Scrabble/forks","keys_url":"https://api.github.com/repos/nicklawls/Scrabble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicklawls/Scrabble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicklawls/Scrabble/teams","hooks_url":"https://api.github.com/repos/nicklawls/Scrabble/hooks","issue_events_url":"https://api.github.com/repos/nicklawls/Scrabble/issues/events{/number}","events_url":"https://api.github.com/repos/nicklawls/Scrabble/events","assignees_url":"https://api.github.com/repos/nicklawls/Scrabble/assignees{/user}","branches_url":"https://api.github.com/repos/nicklawls/Scrabble/branches{/branch}","tags_url":"https://api.github.com/repos/nicklawls/Scrabble/tags","blobs_url":"https://api.github.com/repos/nicklawls/Scrabble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicklawls/Scrabble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicklawls/Scrabble/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicklawls/Scrabble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicklawls/Scrabble/statuses/{sha}","languages_url":"https://api.github.com/repos/nicklawls/Scrabble/languages","stargazers_url":"https://api.github.com/repos/nicklawls/Scrabble/stargazers","contributors_url":"https://api.github.com/repos/nicklawls/Scrabble/contributors","subscribers_url":"https://api.github.com/repos/nicklawls/Scrabble/subscribers","subscription_url":"https://api.github.com/repos/nicklawls/Scrabble/subscription","commits_url":"https://api.github.com/repos/nicklawls/Scrabble/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicklawls/Scrabble/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicklawls/Scrabble/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicklawls/Scrabble/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicklawls/Scrabble/contents/{+path}","compare_url":"https://api.github.com/repos/nicklawls/Scrabble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicklawls/Scrabble/merges","archive_url":"https://api.github.com/repos/nicklawls/Scrabble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicklawls/Scrabble/downloads","issues_url":"https://api.github.com/repos/nicklawls/Scrabble/issues{/number}","pulls_url":"https://api.github.com/repos/nicklawls/Scrabble/pulls{/number}","milestones_url":"https://api.github.com/repos/nicklawls/Scrabble/milestones{/number}","notifications_url":"https://api.github.com/repos/nicklawls/Scrabble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicklawls/Scrabble/labels{/name}","releases_url":"https://api.github.com/repos/nicklawls/Scrabble/releases{/id}","deployments_url":"https://api.github.com/repos/nicklawls/Scrabble/deployments","created_at":"2016-02-11T03:37:14Z","updated_at":"2016-02-11T03:37:14Z","pushed_at":"2016-04-21T22:22:04Z","git_url":"git://github.com/nicklawls/Scrabble.git","ssh_url":"git@github.com:nicklawls/Scrabble.git","clone_url":"https://github.com/nicklawls/Scrabble.git","svn_url":"https://github.com/nicklawls/Scrabble","homepage":"","size":906,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joshcough:master","ref":"master","sha":"094cbe4a38223132f58ae44de0b0fcbd599bbb72","user":{"login":"joshcough","id":37799,"avatar_url":"https://avatars.githubusercontent.com/u/37799?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcough","html_url":"https://github.com/joshcough","followers_url":"https://api.github.com/users/joshcough/followers","following_url":"https://api.github.com/users/joshcough/following{/other_user}","gists_url":"https://api.github.com/users/joshcough/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcough/subscriptions","organizations_url":"https://api.github.com/users/joshcough/orgs","repos_url":"https://api.github.com/users/joshcough/repos","events_url":"https://api.github.com/users/joshcough/events{/privacy}","received_events_url":"https://api.github.com/users/joshcough/received_events","type":"User","site_admin":false},"repo":{"id":41979375,"name":"Scrabble","full_name":"joshcough/Scrabble","owner":{"login":"joshcough","id":37799,"avatar_url":"https://avatars.githubusercontent.com/u/37799?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcough","html_url":"https://github.com/joshcough","followers_url":"https://api.github.com/users/joshcough/followers","following_url":"https://api.github.com/users/joshcough/following{/other_user}","gists_url":"https://api.github.com/users/joshcough/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcough/subscriptions","organizations_url":"https://api.github.com/users/joshcough/orgs","repos_url":"https://api.github.com/users/joshcough/repos","events_url":"https://api.github.com/users/joshcough/events{/privacy}","received_events_url":"https://api.github.com/users/joshcough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshcough/Scrabble","description":"A Haskell implementation of Scrabble.","fork":false,"url":"https://api.github.com/repos/joshcough/Scrabble","forks_url":"https://api.github.com/repos/joshcough/Scrabble/forks","keys_url":"https://api.github.com/repos/joshcough/Scrabble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshcough/Scrabble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshcough/Scrabble/teams","hooks_url":"https://api.github.com/repos/joshcough/Scrabble/hooks","issue_events_url":"https://api.github.com/repos/joshcough/Scrabble/issues/events{/number}","events_url":"https://api.github.com/repos/joshcough/Scrabble/events","assignees_url":"https://api.github.com/repos/joshcough/Scrabble/assignees{/user}","branches_url":"https://api.github.com/repos/joshcough/Scrabble/branches{/branch}","tags_url":"https://api.github.com/repos/joshcough/Scrabble/tags","blobs_url":"https://api.github.com/repos/joshcough/Scrabble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshcough/Scrabble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshcough/Scrabble/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshcough/Scrabble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshcough/Scrabble/statuses/{sha}","languages_url":"https://api.github.com/repos/joshcough/Scrabble/languages","stargazers_url":"https://api.github.com/repos/joshcough/Scrabble/stargazers","contributors_url":"https://api.github.com/repos/joshcough/Scrabble/contributors","subscribers_url":"https://api.github.com/repos/joshcough/Scrabble/subscribers","subscription_url":"https://api.github.com/repos/joshcough/Scrabble/subscription","commits_url":"https://api.github.com/repos/joshcough/Scrabble/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshcough/Scrabble/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshcough/Scrabble/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshcough/Scrabble/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshcough/Scrabble/contents/{+path}","compare_url":"https://api.github.com/repos/joshcough/Scrabble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshcough/Scrabble/merges","archive_url":"https://api.github.com/repos/joshcough/Scrabble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshcough/Scrabble/downloads","issues_url":"https://api.github.com/repos/joshcough/Scrabble/issues{/number}","pulls_url":"https://api.github.com/repos/joshcough/Scrabble/pulls{/number}","milestones_url":"https://api.github.com/repos/joshcough/Scrabble/milestones{/number}","notifications_url":"https://api.github.com/repos/joshcough/Scrabble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshcough/Scrabble/labels{/name}","releases_url":"https://api.github.com/repos/joshcough/Scrabble/releases{/id}","deployments_url":"https://api.github.com/repos/joshcough/Scrabble/deployments","created_at":"2015-09-05T23:20:54Z","updated_at":"2016-04-26T17:58:14Z","pushed_at":"2016-04-21T22:28:01Z","git_url":"git://github.com/joshcough/Scrabble.git","ssh_url":"git@github.com:joshcough/Scrabble.git","clone_url":"https://github.com/joshcough/Scrabble.git","svn_url":"https://github.com/joshcough/Scrabble","homepage":"","size":903,"stargazers_count":2,"watchers_count":2,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/10"},"html":{"href":"https://github.com/joshcough/Scrabble/pull/10"},"issue":{"href":"https://api.github.com/repos/joshcough/Scrabble/issues/10"},"comments":{"href":"https://api.github.com/repos/joshcough/Scrabble/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joshcough/Scrabble/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/joshcough/Scrabble/statuses/722c502e5d13d59eb3a482da69f6d622d146e611"}}}}