{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf-ui/pulls/comments/83929448","pull_request_review_id":4740380,"id":83929448,"diff_hunk":"@@ -21,15 +21,15 @@\n \n         <AD description=\"Set the subject line template.\"\n             name=\"Subject\" id=\"subjectTemplate\" required=\"true\" type=\"String\"\n-            default=\"[%[workspaceId]] workspace query notice\"/>\n+            default=\"[%[attribute=id]] workspace query notice\"/>\n \n         <AD description=\"Set the body template.\"\n             name=\"Body\" id=\"bodyTemplate\" required=\"true\" type=\"String\"\n-            default=\"The workspace '%[workspaceId]' contains up to %[hitCount] query hits.\"/>\n+            default=\"The workspace '%[attribute=id]' contains up to %[hitCount] query hits.\"/>","path":"catalog/ui/catalog-ui-search/src/main/resources/OSGI-INF/metatype/org.codice.ddf.catalog.ui.email.xml","position":10,"original_position":10,"commit_id":"cb3c2fbf58598c1bcc76123ece45a1e1009990d3","original_commit_id":"cb3c2fbf58598c1bcc76123ece45a1e1009990d3","user":{"login":"lcrosenbu","id":16792154,"avatar_url":"https://avatars.githubusercontent.com/u/16792154?v=3","gravatar_id":"","url":"https://api.github.com/users/lcrosenbu","html_url":"https://github.com/lcrosenbu","followers_url":"https://api.github.com/users/lcrosenbu/followers","following_url":"https://api.github.com/users/lcrosenbu/following{/other_user}","gists_url":"https://api.github.com/users/lcrosenbu/gists{/gist_id}","starred_url":"https://api.github.com/users/lcrosenbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcrosenbu/subscriptions","organizations_url":"https://api.github.com/users/lcrosenbu/orgs","repos_url":"https://api.github.com/users/lcrosenbu/repos","events_url":"https://api.github.com/users/lcrosenbu/events{/privacy}","received_events_url":"https://api.github.com/users/lcrosenbu/received_events","type":"User","site_admin":false},"body":"Recommend replacing `query hits` with `search results`. ","created_at":"2016-10-18T19:14:59Z","updated_at":"2016-10-18T19:15:53Z","html_url":"https://github.com/codice/ddf-ui/pull/26#discussion_r83929448","pull_request_url":"https://api.github.com/repos/codice/ddf-ui/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/comments/83929448"},"html":{"href":"https://github.com/codice/ddf-ui/pull/26#discussion_r83929448"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf-ui/pulls/26","id":89650282,"html_url":"https://github.com/codice/ddf-ui/pull/26","diff_url":"https://github.com/codice/ddf-ui/pull/26.diff","patch_url":"https://github.com/codice/ddf-ui/pull/26.patch","issue_url":"https://api.github.com/repos/codice/ddf-ui/issues/26","number":26,"state":"open","locked":false,"title":"Refactored Email Notification configuration and scheduler","user":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThis PR fixes email notification scheduling and configuration update\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@lcrosenbu @glenhein \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@andrewkfiedler\r\n@jlcsmith \r\n#### How should this be tested?\r\nBuild and Install DDF, configure admin to use a valid email, configure email notification and query monitor, create a workspace with standing queries and subscribe to it, and observe emails are being sent out at the proper interval.\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n","created_at":"2016-10-17T15:48:56Z","updated_at":"2016-10-18T19:15:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa283e09d7b92769e451f17440e04c3e841e104","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf-ui/pulls/26/commits","review_comments_url":"https://api.github.com/repos/codice/ddf-ui/pulls/26/comments","review_comment_url":"https://api.github.com/repos/codice/ddf-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf-ui/issues/26/comments","statuses_url":"https://api.github.com/repos/codice/ddf-ui/statuses/cb3c2fbf58598c1bcc76123ece45a1e1009990d3","head":{"label":"bdeining:emailNotifRefactor","ref":"emailNotifRefactor","sha":"cb3c2fbf58598c1bcc76123ece45a1e1009990d3","user":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"repo":{"id":65045472,"name":"ddf-ui","full_name":"bdeining/ddf-ui","owner":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdeining/ddf-ui","description":null,"fork":true,"url":"https://api.github.com/repos/bdeining/ddf-ui","forks_url":"https://api.github.com/repos/bdeining/ddf-ui/forks","keys_url":"https://api.github.com/repos/bdeining/ddf-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdeining/ddf-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdeining/ddf-ui/teams","hooks_url":"https://api.github.com/repos/bdeining/ddf-ui/hooks","issue_events_url":"https://api.github.com/repos/bdeining/ddf-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bdeining/ddf-ui/events","assignees_url":"https://api.github.com/repos/bdeining/ddf-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bdeining/ddf-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bdeining/ddf-ui/tags","blobs_url":"https://api.github.com/repos/bdeining/ddf-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdeining/ddf-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdeining/ddf-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdeining/ddf-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdeining/ddf-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bdeining/ddf-ui/languages","stargazers_url":"https://api.github.com/repos/bdeining/ddf-ui/stargazers","contributors_url":"https://api.github.com/repos/bdeining/ddf-ui/contributors","subscribers_url":"https://api.github.com/repos/bdeining/ddf-ui/subscribers","subscription_url":"https://api.github.com/repos/bdeining/ddf-ui/subscription","commits_url":"https://api.github.com/repos/bdeining/ddf-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdeining/ddf-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdeining/ddf-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdeining/ddf-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdeining/ddf-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bdeining/ddf-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdeining/ddf-ui/merges","archive_url":"https://api.github.com/repos/bdeining/ddf-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdeining/ddf-ui/downloads","issues_url":"https://api.github.com/repos/bdeining/ddf-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bdeining/ddf-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bdeining/ddf-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bdeining/ddf-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdeining/ddf-ui/labels{/name}","releases_url":"https://api.github.com/repos/bdeining/ddf-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bdeining/ddf-ui/deployments","created_at":"2016-08-05T19:59:51Z","updated_at":"2016-08-05T20:00:08Z","pushed_at":"2016-10-17T20:04:34Z","git_url":"git://github.com/bdeining/ddf-ui.git","ssh_url":"git@github.com:bdeining/ddf-ui.git","clone_url":"https://github.com/bdeining/ddf-ui.git","svn_url":"https://github.com/bdeining/ddf-ui","homepage":null,"size":143407,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"e0c51795ec3d7143fbab2d20173343da02b1f7f3","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":51777832,"name":"ddf-ui","full_name":"codice/ddf-ui","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf-ui","description":null,"fork":false,"url":"https://api.github.com/repos/codice/ddf-ui","forks_url":"https://api.github.com/repos/codice/ddf-ui/forks","keys_url":"https://api.github.com/repos/codice/ddf-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf-ui/teams","hooks_url":"https://api.github.com/repos/codice/ddf-ui/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf-ui/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf-ui/events","assignees_url":"https://api.github.com/repos/codice/ddf-ui/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf-ui/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf-ui/tags","blobs_url":"https://api.github.com/repos/codice/ddf-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf-ui/languages","stargazers_url":"https://api.github.com/repos/codice/ddf-ui/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf-ui/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf-ui/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf-ui/subscription","commits_url":"https://api.github.com/repos/codice/ddf-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf-ui/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf-ui/merges","archive_url":"https://api.github.com/repos/codice/ddf-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf-ui/downloads","issues_url":"https://api.github.com/repos/codice/ddf-ui/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf-ui/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf-ui/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf-ui/deployments","created_at":"2016-02-15T18:56:11Z","updated_at":"2016-08-01T02:55:30Z","pushed_at":"2016-10-17T20:38:56Z","git_url":"git://github.com/codice/ddf-ui.git","ssh_url":"git@github.com:codice/ddf-ui.git","clone_url":"https://github.com/codice/ddf-ui.git","svn_url":"https://github.com/codice/ddf-ui","homepage":null,"size":143646,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/26"},"html":{"href":"https://github.com/codice/ddf-ui/pull/26"},"issue":{"href":"https://api.github.com/repos/codice/ddf-ui/issues/26"},"comments":{"href":"https://api.github.com/repos/codice/ddf-ui/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf-ui/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf-ui/statuses/cb3c2fbf58598c1bcc76123ece45a1e1009990d3"}}}}
{"actor":{"display_login":"lcrosenbu"}}