{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6044","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6044/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6044/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6044/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6044","id":148144356,"number":6044,"title":"sql: add check constraint ","user":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-04-13T18:29:08Z","updated_at":"2016-04-15T14:20:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6044","html_url":"https://github.com/cockroachdb/cockroach/pull/6044","diff_url":"https://github.com/cockroachdb/cockroach/pull/6044.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6044.patch"},"body":"This is forked and fixed from https://github.com/cockroachdb/cockroach/pull/5010\r\n\r\nThis partly fixes #2474 As I commented in the source code, there are still more TODOs such as more corner case checking, table constraint, update hook etc. But I think this is a good start as to see if I'm in the right direction. :)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6044)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/210480184","html_url":"https://github.com/cockroachdb/cockroach/pull/6044#issuecomment-210480184","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6044","id":210480184,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T14:20:01Z","updated_at":"2016-04-15T14:20:01Z","body":"@seiflotfy Do you mind squashing the commits as well? Multi-commit PRs are ok, but each commit should be a good state (tests pass, etc) and not the side-effect of the development/code-review process."}}