{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/ctdean/backtick/pulls/28","id":87819449,"html_url":"https://github.com/ctdean/backtick/pull/28","diff_url":"https://github.com/ctdean/backtick/pull/28.diff","patch_url":"https://github.com/ctdean/backtick/pull/28.patch","issue_url":"https://api.github.com/repos/ctdean/backtick/issues/28","number":28,"state":"closed","locked":false,"title":"Fix function unquote in core macros","user":{"login":"jimbru","id":198095,"avatar_url":"https://avatars.githubusercontent.com/u/198095?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbru","html_url":"https://github.com/jimbru","followers_url":"https://api.github.com/users/jimbru/followers","following_url":"https://api.github.com/users/jimbru/following{/other_user}","gists_url":"https://api.github.com/users/jimbru/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbru/subscriptions","organizations_url":"https://api.github.com/users/jimbru/orgs","repos_url":"https://api.github.com/users/jimbru/repos","events_url":"https://api.github.com/users/jimbru/events{/privacy}","received_events_url":"https://api.github.com/users/jimbru/received_events","type":"User","site_admin":false},"body":"A function name was not being passed correctly in the core macros\r\n`define-recurring` and `define-cron`. Previously macroexpansion generated code\r\nlike this:\r\n\r\n```\r\nuser=> (macroexpand '(bt/define-recurring testf 999 [] (println \">>> this is it\")))\r\n(do\r\n (clojure.core/defn testf [] (println \">>> this is it\"))\r\n  (backtick.registry/register \"user/testf\" testf)\r\n  (#<Fn@70a5db0d backtick.core/schedule_recurring> 999 testf))\r\n```\r\n\r\nNotice that crazy `#<Fn@xxxxxxxx` object? Inexplicably this seems to have been\r\nfunctioning correctly, but in the interests of readable code, and safety, this\r\ncommit fixes it so the correct function _symbol_ is generated there instead.\r\n\r\nAdditionally unit test coverage has been added for these macros, and a more\r\ninformative error message has been added for when the database URL is unset.","created_at":"2016-10-04T01:12:44Z","updated_at":"2016-10-12T18:17:55Z","closed_at":"2016-10-12T18:17:55Z","merged_at":"2016-10-12T18:17:55Z","merge_commit_sha":"1498f0787bd5a447b48e4c98205f4fc938db6fd6","assignee":{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false},"assignees":[{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ctdean/backtick/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ctdean/backtick/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ctdean/backtick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ctdean/backtick/issues/28/comments","statuses_url":"https://api.github.com/repos/ctdean/backtick/statuses/5cdb19883b599476ed44b1b81cd2c091b4cf8a6b","head":{"label":"ctdean:x_macros","ref":"x_macros","sha":"5cdb19883b599476ed44b1b81cd2c091b4cf8a6b","user":{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false},"repo":{"id":46517092,"name":"backtick","full_name":"ctdean/backtick","owner":{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctdean/backtick","description":"A background job processor using Clojure and Postgres","fork":false,"url":"https://api.github.com/repos/ctdean/backtick","forks_url":"https://api.github.com/repos/ctdean/backtick/forks","keys_url":"https://api.github.com/repos/ctdean/backtick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctdean/backtick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctdean/backtick/teams","hooks_url":"https://api.github.com/repos/ctdean/backtick/hooks","issue_events_url":"https://api.github.com/repos/ctdean/backtick/issues/events{/number}","events_url":"https://api.github.com/repos/ctdean/backtick/events","assignees_url":"https://api.github.com/repos/ctdean/backtick/assignees{/user}","branches_url":"https://api.github.com/repos/ctdean/backtick/branches{/branch}","tags_url":"https://api.github.com/repos/ctdean/backtick/tags","blobs_url":"https://api.github.com/repos/ctdean/backtick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctdean/backtick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctdean/backtick/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctdean/backtick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctdean/backtick/statuses/{sha}","languages_url":"https://api.github.com/repos/ctdean/backtick/languages","stargazers_url":"https://api.github.com/repos/ctdean/backtick/stargazers","contributors_url":"https://api.github.com/repos/ctdean/backtick/contributors","subscribers_url":"https://api.github.com/repos/ctdean/backtick/subscribers","subscription_url":"https://api.github.com/repos/ctdean/backtick/subscription","commits_url":"https://api.github.com/repos/ctdean/backtick/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctdean/backtick/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctdean/backtick/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctdean/backtick/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctdean/backtick/contents/{+path}","compare_url":"https://api.github.com/repos/ctdean/backtick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctdean/backtick/merges","archive_url":"https://api.github.com/repos/ctdean/backtick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctdean/backtick/downloads","issues_url":"https://api.github.com/repos/ctdean/backtick/issues{/number}","pulls_url":"https://api.github.com/repos/ctdean/backtick/pulls{/number}","milestones_url":"https://api.github.com/repos/ctdean/backtick/milestones{/number}","notifications_url":"https://api.github.com/repos/ctdean/backtick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctdean/backtick/labels{/name}","releases_url":"https://api.github.com/repos/ctdean/backtick/releases{/id}","deployments_url":"https://api.github.com/repos/ctdean/backtick/deployments","created_at":"2015-11-19T20:03:01Z","updated_at":"2016-07-10T23:47:40Z","pushed_at":"2016-10-12T18:17:56Z","git_url":"git://github.com/ctdean/backtick.git","ssh_url":"git@github.com:ctdean/backtick.git","clone_url":"https://github.com/ctdean/backtick.git","svn_url":"https://github.com/ctdean/backtick","homepage":null,"size":95,"stargazers_count":3,"watchers_count":3,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"ctdean:master","ref":"master","sha":"10b4114dad5dee9347690fdb00bbfce5f231a581","user":{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false},"repo":{"id":46517092,"name":"backtick","full_name":"ctdean/backtick","owner":{"login":"ctdean","id":46933,"avatar_url":"https://avatars.githubusercontent.com/u/46933?v=3","gravatar_id":"","url":"https://api.github.com/users/ctdean","html_url":"https://github.com/ctdean","followers_url":"https://api.github.com/users/ctdean/followers","following_url":"https://api.github.com/users/ctdean/following{/other_user}","gists_url":"https://api.github.com/users/ctdean/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdean/subscriptions","organizations_url":"https://api.github.com/users/ctdean/orgs","repos_url":"https://api.github.com/users/ctdean/repos","events_url":"https://api.github.com/users/ctdean/events{/privacy}","received_events_url":"https://api.github.com/users/ctdean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctdean/backtick","description":"A background job processor using Clojure and Postgres","fork":false,"url":"https://api.github.com/repos/ctdean/backtick","forks_url":"https://api.github.com/repos/ctdean/backtick/forks","keys_url":"https://api.github.com/repos/ctdean/backtick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctdean/backtick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctdean/backtick/teams","hooks_url":"https://api.github.com/repos/ctdean/backtick/hooks","issue_events_url":"https://api.github.com/repos/ctdean/backtick/issues/events{/number}","events_url":"https://api.github.com/repos/ctdean/backtick/events","assignees_url":"https://api.github.com/repos/ctdean/backtick/assignees{/user}","branches_url":"https://api.github.com/repos/ctdean/backtick/branches{/branch}","tags_url":"https://api.github.com/repos/ctdean/backtick/tags","blobs_url":"https://api.github.com/repos/ctdean/backtick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctdean/backtick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctdean/backtick/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctdean/backtick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctdean/backtick/statuses/{sha}","languages_url":"https://api.github.com/repos/ctdean/backtick/languages","stargazers_url":"https://api.github.com/repos/ctdean/backtick/stargazers","contributors_url":"https://api.github.com/repos/ctdean/backtick/contributors","subscribers_url":"https://api.github.com/repos/ctdean/backtick/subscribers","subscription_url":"https://api.github.com/repos/ctdean/backtick/subscription","commits_url":"https://api.github.com/repos/ctdean/backtick/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctdean/backtick/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctdean/backtick/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctdean/backtick/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctdean/backtick/contents/{+path}","compare_url":"https://api.github.com/repos/ctdean/backtick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctdean/backtick/merges","archive_url":"https://api.github.com/repos/ctdean/backtick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctdean/backtick/downloads","issues_url":"https://api.github.com/repos/ctdean/backtick/issues{/number}","pulls_url":"https://api.github.com/repos/ctdean/backtick/pulls{/number}","milestones_url":"https://api.github.com/repos/ctdean/backtick/milestones{/number}","notifications_url":"https://api.github.com/repos/ctdean/backtick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctdean/backtick/labels{/name}","releases_url":"https://api.github.com/repos/ctdean/backtick/releases{/id}","deployments_url":"https://api.github.com/repos/ctdean/backtick/deployments","created_at":"2015-11-19T20:03:01Z","updated_at":"2016-07-10T23:47:40Z","pushed_at":"2016-10-12T18:17:56Z","git_url":"git://github.com/ctdean/backtick.git","ssh_url":"git@github.com:ctdean/backtick.git","clone_url":"https://github.com/ctdean/backtick.git","svn_url":"https://github.com/ctdean/backtick","homepage":null,"size":95,"stargazers_count":3,"watchers_count":3,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ctdean/backtick/pulls/28"},"html":{"href":"https://github.com/ctdean/backtick/pull/28"},"issue":{"href":"https://api.github.com/repos/ctdean/backtick/issues/28"},"comments":{"href":"https://api.github.com/repos/ctdean/backtick/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ctdean/backtick/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ctdean/backtick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ctdean/backtick/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ctdean/backtick/statuses/5cdb19883b599476ed44b1b81cd2c091b4cf8a6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jimbru","id":198095,"avatar_url":"https://avatars.githubusercontent.com/u/198095?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbru","html_url":"https://github.com/jimbru","followers_url":"https://api.github.com/users/jimbru/followers","following_url":"https://api.github.com/users/jimbru/following{/other_user}","gists_url":"https://api.github.com/users/jimbru/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbru/subscriptions","organizations_url":"https://api.github.com/users/jimbru/orgs","repos_url":"https://api.github.com/users/jimbru/repos","events_url":"https://api.github.com/users/jimbru/events{/privacy}","received_events_url":"https://api.github.com/users/jimbru/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":58,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"jimbru"}}