{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/50017465","id":50017465,"diff_hunk":"@@ -163,11 +180,12 @@ testsuite:\n \tmake coverage-report\n \n # Generates a coverage report from the existing coverage files\n-# It assumes that some covrage reports already exists, otherwise it will fail\n .PHONY: coverage-report\n coverage-report:\n-\tpython ../scripts/aggregate_coverage.py -o ./${COVERAGE_DIR}/full.cov ./${COVERAGE_DIR}\n+\tpython ${ES_BEATS}/scripts/aggregate_coverage.py -o ./${COVERAGE_DIR}/full.cov ./${COVERAGE_DIR}\n \tgo tool cover -html=./${COVERAGE_DIR}/full.cov -o ${COVERAGE_DIR}/full.html\n+\ttest ! -s ./${COVERAGE_DIR}/unit.cov   || go tool cover -html=./${COVERAGE_DIR}/unit.cov   -o ${COVERAGE_DIR}/unit.html\n+\ttest ! -s ./${COVERAGE_DIR}/system.cov || go tool cover -html=./${COVERAGE_DIR}/system.cov -o ${COVERAGE_DIR}/system.html","path":"libbeat/scripts/Makefile","position":77,"original_position":77,"commit_id":"20c03e005b58b268ae17c1eb4f59d8e6a98fe85e","original_commit_id":"20c03e005b58b268ae17c1eb4f59d8e6a98fe85e","user":{"login":"cyrilleverrier","id":16701739,"avatar_url":"https://avatars.githubusercontent.com/u/16701739?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilleverrier","html_url":"https://github.com/cyrilleverrier","followers_url":"https://api.github.com/users/cyrilleverrier/followers","following_url":"https://api.github.com/users/cyrilleverrier/following{/other_user}","gists_url":"https://api.github.com/users/cyrilleverrier/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilleverrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilleverrier/subscriptions","organizations_url":"https://api.github.com/users/cyrilleverrier/orgs","repos_url":"https://api.github.com/users/cyrilleverrier/repos","events_url":"https://api.github.com/users/cyrilleverrier/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilleverrier/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2016-01-18T16:25:20Z","updated_at":"2016-01-18T16:25:20Z","html_url":"https://github.com/elastic/beats/pull/721#discussion_r50017465","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/721","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/50017465"},"html":{"href":"https://github.com/elastic/beats/pull/721#discussion_r50017465"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/721"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/721","id":56028395,"html_url":"https://github.com/elastic/beats/pull/721","diff_url":"https://github.com/elastic/beats/pull/721.diff","patch_url":"https://github.com/elastic/beats/pull/721.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/721","number":721,"state":"open","locked":false,"title":"make libbeat/scripts/Makefile importable by community beats","user":{"login":"cyrilleverrier","id":16701739,"avatar_url":"https://avatars.githubusercontent.com/u/16701739?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilleverrier","html_url":"https://github.com/cyrilleverrier","followers_url":"https://api.github.com/users/cyrilleverrier/followers","following_url":"https://api.github.com/users/cyrilleverrier/following{/other_user}","gists_url":"https://api.github.com/users/cyrilleverrier/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilleverrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilleverrier/subscriptions","organizations_url":"https://api.github.com/users/cyrilleverrier/orgs","repos_url":"https://api.github.com/users/cyrilleverrier/repos","events_url":"https://api.github.com/users/cyrilleverrier/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilleverrier/received_events","type":"User","site_admin":false},"body":"1. Expose GOPACKAGES variable, used by unit/system-tests rules\r\n\t- The default value is ${BEAT_DIR}/${BEATNAME}/...\r\n\t- It can be overriden in the comunity beat's Makefile to skip the tests in the vendor packages:\r\n\t\tBEATNAME=mybeat\r\n\t\tPREFIX?=.\r\n\t\tES_BEATS=$(GOPATH)/src/github.com/elastic/beats\r\n\t\tBEAT_DIR=github.com/mybeat\r\n\t\tGOPACKAGES=$(shell go list ${BEAT_DIR}/... | grep -v /vendor/)\r\n\t\tinclude $(ES_BEATS)/libbeat/scripts/Makefile\r\n\r\n2. Generate html reports fron coverage files (*.cov) in the Makefile rules:\r\n\t- unit-tests\r\n\t- integration-tests","created_at":"2016-01-14T12:23:00Z","updated_at":"2016-01-18T16:25:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa578d75a8764f8a727b40e7861b88d6c05d5039","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/721/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/721/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/721/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/20c03e005b58b268ae17c1eb4f59d8e6a98fe85e","head":{"label":"cyrilleverrier:makefile-test-coverage","ref":"makefile-test-coverage","sha":"20c03e005b58b268ae17c1eb4f59d8e6a98fe85e","user":{"login":"cyrilleverrier","id":16701739,"avatar_url":"https://avatars.githubusercontent.com/u/16701739?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilleverrier","html_url":"https://github.com/cyrilleverrier","followers_url":"https://api.github.com/users/cyrilleverrier/followers","following_url":"https://api.github.com/users/cyrilleverrier/following{/other_user}","gists_url":"https://api.github.com/users/cyrilleverrier/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilleverrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilleverrier/subscriptions","organizations_url":"https://api.github.com/users/cyrilleverrier/orgs","repos_url":"https://api.github.com/users/cyrilleverrier/repos","events_url":"https://api.github.com/users/cyrilleverrier/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilleverrier/received_events","type":"User","site_admin":false},"repo":{"id":49642039,"name":"beats","full_name":"cyrilleverrier/beats","owner":{"login":"cyrilleverrier","id":16701739,"avatar_url":"https://avatars.githubusercontent.com/u/16701739?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilleverrier","html_url":"https://github.com/cyrilleverrier","followers_url":"https://api.github.com/users/cyrilleverrier/followers","following_url":"https://api.github.com/users/cyrilleverrier/following{/other_user}","gists_url":"https://api.github.com/users/cyrilleverrier/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilleverrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilleverrier/subscriptions","organizations_url":"https://api.github.com/users/cyrilleverrier/orgs","repos_url":"https://api.github.com/users/cyrilleverrier/repos","events_url":"https://api.github.com/users/cyrilleverrier/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilleverrier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrilleverrier/beats","description":"Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/cyrilleverrier/beats","forks_url":"https://api.github.com/repos/cyrilleverrier/beats/forks","keys_url":"https://api.github.com/repos/cyrilleverrier/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrilleverrier/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrilleverrier/beats/teams","hooks_url":"https://api.github.com/repos/cyrilleverrier/beats/hooks","issue_events_url":"https://api.github.com/repos/cyrilleverrier/beats/issues/events{/number}","events_url":"https://api.github.com/repos/cyrilleverrier/beats/events","assignees_url":"https://api.github.com/repos/cyrilleverrier/beats/assignees{/user}","branches_url":"https://api.github.com/repos/cyrilleverrier/beats/branches{/branch}","tags_url":"https://api.github.com/repos/cyrilleverrier/beats/tags","blobs_url":"https://api.github.com/repos/cyrilleverrier/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrilleverrier/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrilleverrier/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrilleverrier/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrilleverrier/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrilleverrier/beats/languages","stargazers_url":"https://api.github.com/repos/cyrilleverrier/beats/stargazers","contributors_url":"https://api.github.com/repos/cyrilleverrier/beats/contributors","subscribers_url":"https://api.github.com/repos/cyrilleverrier/beats/subscribers","subscription_url":"https://api.github.com/repos/cyrilleverrier/beats/subscription","commits_url":"https://api.github.com/repos/cyrilleverrier/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrilleverrier/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrilleverrier/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrilleverrier/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrilleverrier/beats/contents/{+path}","compare_url":"https://api.github.com/repos/cyrilleverrier/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrilleverrier/beats/merges","archive_url":"https://api.github.com/repos/cyrilleverrier/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrilleverrier/beats/downloads","issues_url":"https://api.github.com/repos/cyrilleverrier/beats/issues{/number}","pulls_url":"https://api.github.com/repos/cyrilleverrier/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrilleverrier/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrilleverrier/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrilleverrier/beats/labels{/name}","releases_url":"https://api.github.com/repos/cyrilleverrier/beats/releases{/id}","created_at":"2016-01-14T11:02:01Z","updated_at":"2016-01-14T11:02:03Z","pushed_at":"2016-01-18T15:56:47Z","git_url":"git://github.com/cyrilleverrier/beats.git","ssh_url":"git@github.com:cyrilleverrier/beats.git","clone_url":"https://github.com/cyrilleverrier/beats.git","svn_url":"https://github.com/cyrilleverrier/beats","homepage":"https://www.elastic.co/products/beats","size":24089,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"02a5f4828c9517eea09709b4164b2d986e913b6f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":"Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","created_at":"2014-02-05T19:01:02Z","updated_at":"2016-01-18T15:49:15Z","pushed_at":"2016-01-18T16:19:19Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":26261,"stargazers_count":2272,"watchers_count":2272,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"open_issues_count":164,"forks":276,"open_issues":164,"watchers":2272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/721"},"html":{"href":"https://github.com/elastic/beats/pull/721"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/721"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/20c03e005b58b268ae17c1eb4f59d8e6a98fe85e"}}}}