{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments/87122165","pull_request_review_id":7746747,"id":87122165,"diff_hunk":"@@ -102,21 +102,14 @@ public void initialize(SortParameters sortParameters) {\n     }\n     this.executorService = Executors.newFixedThreadPool(iterators.length);\n \n-    // First prepare the data for sort.\n-    Iterator<CarbonRowBatch>[] sortPrepIterators = new Iterator[iterators.length];\n-    for (int i = 0; i < sortPrepIterators.length; i++) {\n-      sortPrepIterators[i] = new SortPreparatorIterator(iterators[i], inputDataFields);\n-    }\n-\n-    for (int i = 0; i < sortDataRows.length; i++) {\n-      executorService\n-          .submit(new SortIteratorThread(sortPrepIterators[i], sortDataRows[i], sortParameters));\n-    }\n-\n     try {\n+      for (int i = 0; i < sortDataRows.length; i++) {\n+        executorService\n+            .submit(new SortIteratorThread(iterators[i], sortDataRows[i], sortParameters));","path":"processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java","position":31,"original_position":31,"commit_id":"16713cfc28f69735369a4465b1e1a644deb4b0cb","original_commit_id":"16713cfc28f69735369a4465b1e1a644deb4b0cb","user":{"login":"jackylk","id":6500698,"avatar_url":"https://avatars.githubusercontent.com/u/6500698?v=3","gravatar_id":"","url":"https://api.github.com/users/jackylk","html_url":"https://github.com/jackylk","followers_url":"https://api.github.com/users/jackylk/followers","following_url":"https://api.github.com/users/jackylk/following{/other_user}","gists_url":"https://api.github.com/users/jackylk/gists{/gist_id}","starred_url":"https://api.github.com/users/jackylk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackylk/subscriptions","organizations_url":"https://api.github.com/users/jackylk/orgs","repos_url":"https://api.github.com/users/jackylk/repos","events_url":"https://api.github.com/users/jackylk/events{/privacy}","received_events_url":"https://api.github.com/users/jackylk/received_events","type":"User","site_admin":false},"body":"should not break the line at function call, move `submit` to previous line and bread at parameters","created_at":"2016-11-09T01:48:19Z","updated_at":"2016-11-09T01:48:19Z","html_url":"https://github.com/apache/incubator-carbondata/pull/263#discussion_r87122165","pull_request_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments/87122165"},"html":{"href":"https://github.com/apache/incubator-carbondata/pull/263#discussion_r87122165"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263","id":91193430,"html_url":"https://github.com/apache/incubator-carbondata/pull/263","diff_url":"https://github.com/apache/incubator-carbondata/pull/263.diff","patch_url":"https://github.com/apache/incubator-carbondata/pull/263.patch","issue_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/263","number":263,"state":"open","locked":false,"title":"[CARBONDATA-2] Data load integration of all steps for removing kettle","user":{"login":"ravipesala","id":8134086,"avatar_url":"https://avatars.githubusercontent.com/u/8134086?v=3","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"body":"This PR integrates all data load steps to the main flow. \nStill DataWriterStep need to be integrated.And testing is pending.\n","created_at":"2016-10-27T12:46:44Z","updated_at":"2016-11-09T01:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0abbe6f18656141ac5f67a8cab42a5ad08c5cbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/263/comments","statuses_url":"https://api.github.com/repos/apache/incubator-carbondata/statuses/16713cfc28f69735369a4465b1e1a644deb4b0cb","head":{"label":"ravipesala:data-load-integration","ref":"data-load-integration","sha":"16713cfc28f69735369a4465b1e1a644deb4b0cb","user":{"login":"ravipesala","id":8134086,"avatar_url":"https://avatars.githubusercontent.com/u/8134086?v=3","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"repo":{"id":62142167,"name":"incubator-carbondata","full_name":"ravipesala/incubator-carbondata","owner":{"login":"ravipesala","id":8134086,"avatar_url":"https://avatars.githubusercontent.com/u/8134086?v=3","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravipesala/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":true,"url":"https://api.github.com/repos/ravipesala/incubator-carbondata","forks_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/deployments","created_at":"2016-06-28T13:16:56Z","updated_at":"2016-06-29T11:42:51Z","pushed_at":"2016-11-08T06:14:41Z","git_url":"git://github.com/ravipesala/incubator-carbondata.git","ssh_url":"git@github.com:ravipesala/incubator-carbondata.git","clone_url":"https://github.com/ravipesala/incubator-carbondata.git","svn_url":"https://github.com/ravipesala/incubator-carbondata","homepage":null,"size":38671,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8efab652ea1a48697f861cbc896abd50305937c2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"incubator-carbondata","full_name":"apache/incubator-carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-carbondata","forks_url":"https://api.github.com/repos/apache/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/apache/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/apache/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/apache/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/apache/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/apache/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/apache/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/apache/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2016-11-08T02:15:47Z","pushed_at":"2016-11-08T11:55:44Z","git_url":"git://github.com/apache/incubator-carbondata.git","ssh_url":"git@github.com:apache/incubator-carbondata.git","clone_url":"https://github.com/apache/incubator-carbondata.git","svn_url":"https://github.com/apache/incubator-carbondata","homepage":null,"size":40858,"stargazers_count":147,"watchers_count":147,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":"git://git.apache.org/incubator-carbondata.git","open_issues_count":45,"forks":144,"open_issues":45,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263"},"html":{"href":"https://github.com/apache/incubator-carbondata/pull/263"},"issue":{"href":"https://api.github.com/repos/apache/incubator-carbondata/issues/263"},"comments":{"href":"https://api.github.com/repos/apache/incubator-carbondata/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-carbondata/statuses/16713cfc28f69735369a4465b1e1a644deb4b0cb"}}}}
{"actor":{"display_login":"jackylk"}}