{"push_id":960036963,"size":4,"distinct_size":4,"ref":"refs/heads/rework-local-transaction-found-la-no-transaction-result","head":"4d525895aefe68aac0d9b85ff1a3aae713e9bda4","before":"9c79e8756dd57eebd29825df2f411e86cc557eb3","commits":[{"sha":"1dc18ad5c24eb2f731c7050f6cb7436a570b0506","author":{"email":"997b4ad147cdcc78b7eb8e20beba2a883e064b84@h-lame.com","name":"Murray Steele"},"message":"Change the \"found the LA but have no service link\" page\n\nUsing the prototype[1] as a guide we make this page a little more friendly\nand less like an error condition.  We've also tweaked the controller and\nviews a bit to make use of the new local authority presenter which allows us\nto not care which url the la has as long as there is one.","distinct":true,"url":"https://api.github.com/repos/alphagov/frontend/commits/1dc18ad5c24eb2f731c7050f6cb7436a570b0506"},{"sha":"b91453c5ac0c3b721977c24534eee6ba3db2f31f","author":{"email":"997b4ad147cdcc78b7eb8e20beba2a883e064b84@h-lame.com","name":"Murray Steele"},"message":"Tidy up the logic for local_transactions view\n\nThe logic is a little unclear, particularly around what objects will be\navailable in which branches, so I've put in more elses to connect things.\nI think a better solution would be to render different views for the\ndifferent result types, but this'll do for now.","distinct":true,"url":"https://api.github.com/repos/alphagov/frontend/commits/b91453c5ac0c3b721977c24534eee6ba3db2f31f"},{"sha":"579ec3d4c6ce39f76a677613456c24e12d369312","author":{"email":"997b4ad147cdcc78b7eb8e20beba2a883e064b84@h-lame.com","name":"Murray Steele"},"message":"Improve page for LA with no service link and no url\n\nThis is an extreme edgecase, but we should cover it because it might\nhappen if there is a gap between creating a new LA and importing the\ncontact details for it.  Previously when there was no contact_url we\npretended it was the \"no matching la for your postcode\" case - but\nby this point we've already redirected to the /service/authority-slug\nurl so an eagle-eyed user might spot our lie.  Instead of continuing\nwith this we tell the user what council they're in, apologise for not\nhaving a link and point them at the local council finder on directgov.","distinct":true,"url":"https://api.github.com/repos/alphagov/frontend/commits/579ec3d4c6ce39f76a677613456c24e12d369312"},{"sha":"4d525895aefe68aac0d9b85ff1a3aae713e9bda4","author":{"email":"997b4ad147cdcc78b7eb8e20beba2a883e064b84@h-lame.com","name":"Murray Steele"},"message":"Don't use definite article in front of LA names\n\nFor most it doesn't sound correct (e.g. \"the Sunderland City Council\")\nand for those where it does (e.g. \"the Royal Borough of Greenwich\") it\nstill sounds ok without and in one case the name already includes it (\"The\nHighland Council\").\n\nWhere we said \"We've matched this postcode to the <council>\" we now say\n\"We've matched this postcode to <council>\".  However, where we said \"Search\nthe <council> website for this service\" we leave the definite article in\nbecause it's the website we're talking about.\n\nThis causes a complication because that text is part of a translation file\nand we are limited in what logic we can perform.  We check if the la name\nstarts with a the in the LocationError and use a different translation that\nexcludes it for those councils whose names already include it.","distinct":true,"url":"https://api.github.com/repos/alphagov/frontend/commits/4d525895aefe68aac0d9b85ff1a3aae713e9bda4"}]}