{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/86296801","pull_request_review_id":6960539,"id":86296801,"diff_hunk":"@@ -205,5 +217,182 @@ public static void WriteConnectionCloseError(this DiagnosticListener @this, Guid\n                     });\n             }\n         }\n+\n+        public static Guid WriteTransactionCommitBefore(this DiagnosticListener @this, IsolationLevel isolationLevel, SqlConnection connection, [CallerMemberName] string operation = \"\")\n+        {\n+            if (@this.IsEnabled(SqlBeforeCommitTransaction))\n+            {\n+                Guid operationId = Guid.NewGuid();\n+\n+                @this.Write(\n+                    SqlBeforeCommitTransaction,\n+                    new\n+                    {\n+                        OperationId = operationId,\n+                        Operation = operation,\n+                        IsolationLevel = isolationLevel,\n+                        Connection = connection,\n+                        Timestamp = Stopwatch.GetTimestamp()\n+                    });\n+\n+                return operationId;\n+            }\n+            else\n+                return Guid.Empty;\n+        }\n+\n+        public static void WriteTransactionCommitAfter(this DiagnosticListener @this, Guid operationId, IsolationLevel isolationLevel, SqlConnection connection, [CallerMemberName] string operation = \"\")","path":"src/System.Data.SqlClient/src/System/Data/SqlClient/SqlClientDiagnosticListenerExtensions.cs","position":47,"original_position":47,"commit_id":"38645ef3b8ec4105cf6414ab70e98a4b10629aca","original_commit_id":"38645ef3b8ec4105cf6414ab70e98a4b10629aca","user":{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},"body":"@saurabh500 Same as above, it is consistent with the naming of a different method: WriteConnectionOpenAfter","created_at":"2016-11-03T07:58:44Z","updated_at":"2016-11-03T07:58:44Z","html_url":"https://github.com/dotnet/corefx/pull/13212#discussion_r86296801","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/13212","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/86296801"},"html":{"href":"https://github.com/dotnet/corefx/pull/13212#discussion_r86296801"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/13212"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/13212","id":91796463,"html_url":"https://github.com/dotnet/corefx/pull/13212","diff_url":"https://github.com/dotnet/corefx/pull/13212.diff","patch_url":"https://github.com/dotnet/corefx/pull/13212.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/13212","number":13212,"state":"open","locked":false,"title":"Enhance SqlClientDiagnosticListener to support SqlTransaction","user":{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/dotnet/corefx/issues/13034.\r\n\r\ncc @karelz @saurabh500 ","created_at":"2016-11-01T14:48:09Z","updated_at":"2016-11-03T07:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e93b3a305d162e548f6af35d810d1b2813e9960","assignee":{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},"assignees":[{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars.githubusercontent.com/u/1623701?v=3","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/13212/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/13212/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/13212/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/38645ef3b8ec4105cf6414ab70e98a4b10629aca","head":{"label":"fitzchak:master","ref":"master","sha":"38645ef3b8ec4105cf6414ab70e98a4b10629aca","user":{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},"repo":{"id":72545540,"name":"corefx","full_name":"fitzchak/corefx","owner":{"login":"fitzchak","id":629734,"avatar_url":"https://avatars.githubusercontent.com/u/629734?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzchak","html_url":"https://github.com/fitzchak","followers_url":"https://api.github.com/users/fitzchak/followers","following_url":"https://api.github.com/users/fitzchak/following{/other_user}","gists_url":"https://api.github.com/users/fitzchak/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzchak/subscriptions","organizations_url":"https://api.github.com/users/fitzchak/orgs","repos_url":"https://api.github.com/users/fitzchak/repos","events_url":"https://api.github.com/users/fitzchak/events{/privacy}","received_events_url":"https://api.github.com/users/fitzchak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fitzchak/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/fitzchak/corefx","forks_url":"https://api.github.com/repos/fitzchak/corefx/forks","keys_url":"https://api.github.com/repos/fitzchak/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fitzchak/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fitzchak/corefx/teams","hooks_url":"https://api.github.com/repos/fitzchak/corefx/hooks","issue_events_url":"https://api.github.com/repos/fitzchak/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/fitzchak/corefx/events","assignees_url":"https://api.github.com/repos/fitzchak/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/fitzchak/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/fitzchak/corefx/tags","blobs_url":"https://api.github.com/repos/fitzchak/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fitzchak/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fitzchak/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/fitzchak/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fitzchak/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/fitzchak/corefx/languages","stargazers_url":"https://api.github.com/repos/fitzchak/corefx/stargazers","contributors_url":"https://api.github.com/repos/fitzchak/corefx/contributors","subscribers_url":"https://api.github.com/repos/fitzchak/corefx/subscribers","subscription_url":"https://api.github.com/repos/fitzchak/corefx/subscription","commits_url":"https://api.github.com/repos/fitzchak/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/fitzchak/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/fitzchak/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/fitzchak/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/fitzchak/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/fitzchak/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fitzchak/corefx/merges","archive_url":"https://api.github.com/repos/fitzchak/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fitzchak/corefx/downloads","issues_url":"https://api.github.com/repos/fitzchak/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/fitzchak/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/fitzchak/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/fitzchak/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fitzchak/corefx/labels{/name}","releases_url":"https://api.github.com/repos/fitzchak/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/fitzchak/corefx/deployments","created_at":"2016-11-01T14:45:31Z","updated_at":"2016-11-01T14:46:01Z","pushed_at":"2016-11-02T08:40:12Z","git_url":"git://github.com/fitzchak/corefx.git","ssh_url":"git@github.com:fitzchak/corefx.git","clone_url":"https://github.com/fitzchak/corefx.git","svn_url":"https://github.com/fitzchak/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":114379,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f8a950e5ab23f22a16aaad75156080a0db48e9f4","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-11-03T06:50:08Z","pushed_at":"2016-11-03T03:29:57Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":159098,"stargazers_count":10734,"watchers_count":10734,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2711,"mirror_url":null,"open_issues_count":1449,"forks":2711,"open_issues":1449,"watchers":10734,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/13212"},"html":{"href":"https://github.com/dotnet/corefx/pull/13212"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/13212"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/13212/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/13212/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/13212/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/38645ef3b8ec4105cf6414ab70e98a4b10629aca"}}}}
{"actor":{"display_login":"fitzchak"}}