{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/65722498","id":65722498,"diff_hunk":"@@ -113,6 +113,12 @@ mono_error_set_invalid_operation (MonoError *error, const char *msg_format, ...)\n void\n mono_error_set_exception_instance (MonoError *error, MonoException *exc);\n \n+void\n+mono_error_set_invalid_program (MonoError *oerror);","path":"mono/utils/mono-error-internals.h","position":5,"original_position":5,"commit_id":"f66895b1192814ffa65bd85958f7c8ac7309cbd7","original_commit_id":"f66895b1192814ffa65bd85958f7c8ac7309cbd7","user":{"login":"alexanderkyte","id":700530,"avatar_url":"https://avatars.githubusercontent.com/u/700530?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderkyte","html_url":"https://github.com/alexanderkyte","followers_url":"https://api.github.com/users/alexanderkyte/followers","following_url":"https://api.github.com/users/alexanderkyte/following{/other_user}","gists_url":"https://api.github.com/users/alexanderkyte/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderkyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderkyte/subscriptions","organizations_url":"https://api.github.com/users/alexanderkyte/orgs","repos_url":"https://api.github.com/users/alexanderkyte/repos","events_url":"https://api.github.com/users/alexanderkyte/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderkyte/received_events","type":"User","site_admin":false},"body":"I'll add the message argument, but in the single place where we set this exception, the message is NULL. Should we change this?\r\n\r\nhttps://github.com/mono/mono/blob/master/mono/metadata/class.c#L6690","created_at":"2016-06-03T15:04:11Z","updated_at":"2016-06-03T15:04:11Z","html_url":"https://github.com/mono/mono/pull/3082#discussion_r65722498","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/3082","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/65722498"},"html":{"href":"https://github.com/mono/mono/pull/3082#discussion_r65722498"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/3082"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3082","id":72088956,"html_url":"https://github.com/mono/mono/pull/3082","diff_url":"https://github.com/mono/mono/pull/3082.diff","patch_url":"https://github.com/mono/mono/pull/3082.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/3082","number":3082,"state":"open","locked":false,"title":"[runtime] Set klass-error-based MonoError state without allocating","user":{"login":"alexanderkyte","id":700530,"avatar_url":"https://avatars.githubusercontent.com/u/700530?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderkyte","html_url":"https://github.com/alexanderkyte","followers_url":"https://api.github.com/users/alexanderkyte/followers","following_url":"https://api.github.com/users/alexanderkyte/following{/other_user}","gists_url":"https://api.github.com/users/alexanderkyte/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderkyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderkyte/subscriptions","organizations_url":"https://api.github.com/users/alexanderkyte/orgs","repos_url":"https://api.github.com/users/alexanderkyte/repos","events_url":"https://api.github.com/users/alexanderkyte/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderkyte/received_events","type":"User","site_admin":false},"body":"We were seeing an issue where attempts to create the MonoClass for an\r\nexception in a no-exec context was causing failure. No-exec will forbid\r\nthe constructor call. Our solution was to realize that there was no\r\nneed to allocate an exception, as MonoError could already encode the\r\nerrors.","created_at":"2016-05-31T21:29:12Z","updated_at":"2016-06-03T15:04:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2af828203f18ee606b3336c274e0a994269320c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/3082/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/3082/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/3082/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/f66895b1192814ffa65bd85958f7c8ac7309cbd7","head":{"label":"alexanderkyte:no_alloc_klass_error","ref":"no_alloc_klass_error","sha":"f66895b1192814ffa65bd85958f7c8ac7309cbd7","user":{"login":"alexanderkyte","id":700530,"avatar_url":"https://avatars.githubusercontent.com/u/700530?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderkyte","html_url":"https://github.com/alexanderkyte","followers_url":"https://api.github.com/users/alexanderkyte/followers","following_url":"https://api.github.com/users/alexanderkyte/following{/other_user}","gists_url":"https://api.github.com/users/alexanderkyte/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderkyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderkyte/subscriptions","organizations_url":"https://api.github.com/users/alexanderkyte/orgs","repos_url":"https://api.github.com/users/alexanderkyte/repos","events_url":"https://api.github.com/users/alexanderkyte/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderkyte/received_events","type":"User","site_admin":false},"repo":{"id":30037802,"name":"mono","full_name":"alexanderkyte/mono","owner":{"login":"alexanderkyte","id":700530,"avatar_url":"https://avatars.githubusercontent.com/u/700530?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderkyte","html_url":"https://github.com/alexanderkyte","followers_url":"https://api.github.com/users/alexanderkyte/followers","following_url":"https://api.github.com/users/alexanderkyte/following{/other_user}","gists_url":"https://api.github.com/users/alexanderkyte/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderkyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderkyte/subscriptions","organizations_url":"https://api.github.com/users/alexanderkyte/orgs","repos_url":"https://api.github.com/users/alexanderkyte/repos","events_url":"https://api.github.com/users/alexanderkyte/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderkyte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexanderkyte/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/alexanderkyte/mono","forks_url":"https://api.github.com/repos/alexanderkyte/mono/forks","keys_url":"https://api.github.com/repos/alexanderkyte/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexanderkyte/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexanderkyte/mono/teams","hooks_url":"https://api.github.com/repos/alexanderkyte/mono/hooks","issue_events_url":"https://api.github.com/repos/alexanderkyte/mono/issues/events{/number}","events_url":"https://api.github.com/repos/alexanderkyte/mono/events","assignees_url":"https://api.github.com/repos/alexanderkyte/mono/assignees{/user}","branches_url":"https://api.github.com/repos/alexanderkyte/mono/branches{/branch}","tags_url":"https://api.github.com/repos/alexanderkyte/mono/tags","blobs_url":"https://api.github.com/repos/alexanderkyte/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexanderkyte/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexanderkyte/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexanderkyte/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexanderkyte/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/alexanderkyte/mono/languages","stargazers_url":"https://api.github.com/repos/alexanderkyte/mono/stargazers","contributors_url":"https://api.github.com/repos/alexanderkyte/mono/contributors","subscribers_url":"https://api.github.com/repos/alexanderkyte/mono/subscribers","subscription_url":"https://api.github.com/repos/alexanderkyte/mono/subscription","commits_url":"https://api.github.com/repos/alexanderkyte/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexanderkyte/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexanderkyte/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexanderkyte/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexanderkyte/mono/contents/{+path}","compare_url":"https://api.github.com/repos/alexanderkyte/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexanderkyte/mono/merges","archive_url":"https://api.github.com/repos/alexanderkyte/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexanderkyte/mono/downloads","issues_url":"https://api.github.com/repos/alexanderkyte/mono/issues{/number}","pulls_url":"https://api.github.com/repos/alexanderkyte/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/alexanderkyte/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/alexanderkyte/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexanderkyte/mono/labels{/name}","releases_url":"https://api.github.com/repos/alexanderkyte/mono/releases{/id}","deployments_url":"https://api.github.com/repos/alexanderkyte/mono/deployments","created_at":"2015-01-29T19:43:22Z","updated_at":"2016-03-23T17:14:15Z","pushed_at":"2016-06-03T00:11:45Z","git_url":"git://github.com/alexanderkyte/mono.git","ssh_url":"git@github.com:alexanderkyte/mono.git","clone_url":"https://github.com/alexanderkyte/mono.git","svn_url":"https://github.com/alexanderkyte/mono","homepage":"http://www.mono-project.com/","size":416055,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"ed75412ec17f31d81a0e896517c095aef2fc2c11","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-06-03T03:27:22Z","pushed_at":"2016-06-03T14:56:13Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":501122,"stargazers_count":4657,"watchers_count":4657,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2219,"mirror_url":null,"open_issues_count":114,"forks":2219,"open_issues":114,"watchers":4657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/3082"},"html":{"href":"https://github.com/mono/mono/pull/3082"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/3082"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/3082/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/3082/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/3082/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/f66895b1192814ffa65bd85958f7c8ac7309cbd7"}}}}
{"actor":{"display_login":"alexanderkyte"}}