{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/68751240","id":68751240,"diff_hunk":"@@ -295,19 +323,24 @@ def blob_log(image, min_sigma=1, max_sigma=50, num_sigma=10, threshold=.2,\n     # computing gaussian laplace\n     # s**2 provides scale invariance\n     gl_images = [-gaussian_laplace(image, s) * s ** 2 for s in sigma_list]\n-    image_cube = np.dstack(gl_images)\n+\n+    # Replace by image_cube = np.stack(hessian_images, axis=-1)\n+    # When we upgrade minimal requirements to NumPy 1.10\n+    sl = (slice(None),) * image.ndim + (np.newaxis,)\n+    arrays = [np.asanyarray(arr) for arr in gl_images]\n+    extended_arrays = [arr[sl] for arr in arrays]\n+    image_cube = np.concatenate(extended_arrays, axis=-1)","path":"skimage/feature/blob.py","position":330,"original_position":270,"commit_id":"0228772de6f55a053f350665dd3128b1a0193b98","original_commit_id":"0da7406ee3689f117694ac95c61a8f79d91abc2e","user":{"login":"jni","id":492549,"avatar_url":"https://avatars.githubusercontent.com/u/492549?v=3","gravatar_id":"","url":"https://api.github.com/users/jni","html_url":"https://github.com/jni","followers_url":"https://api.github.com/users/jni/followers","following_url":"https://api.github.com/users/jni/following{/other_user}","gists_url":"https://api.github.com/users/jni/gists{/gist_id}","starred_url":"https://api.github.com/users/jni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni/subscriptions","organizations_url":"https://api.github.com/users/jni/orgs","repos_url":"https://api.github.com/users/jni/repos","events_url":"https://api.github.com/users/jni/events{/privacy}","received_events_url":"https://api.github.com/users/jni/received_events","type":"User","site_admin":false},"body":"Actually I just saw that these arrays are just used internally, so restacking wouldn't change the API... So I still think you should update. It's an antipattern to stack in this order in NumPy, so it's best if we avoid it in our own code! I think it simplifies the code a bit, too, to stack along first axis.\r\n\r\nPlus you get to close the [issue](https://github.com/scikit-image/scikit-image/issues/2173) I just opened. =P","created_at":"2016-06-28T13:02:28Z","updated_at":"2016-06-28T13:02:28Z","html_url":"https://github.com/scikit-image/scikit-image/pull/2114#discussion_r68751240","pull_request_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114","_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/68751240"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/2114#discussion_r68751240"},"pull_request":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114","id":71805542,"html_url":"https://github.com/scikit-image/scikit-image/pull/2114","diff_url":"https://github.com/scikit-image/scikit-image/pull/2114.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/2114.patch","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2114","number":2114,"state":"open","locked":false,"title":"[ENH] Ported feature.blob_dog and feature.blob_log for 3D images","user":{"login":"emmanuelle","id":263366,"avatar_url":"https://avatars.githubusercontent.com/u/263366?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"body":"It was a low-hanging fruit to adapt ``feature.blob_dog`` and ``feature.blob_log`` to be 3-D compatible, so I did it. Docstrings are a bit clumsier as a result, suggestions for improvements are welcome.\r\n","created_at":"2016-05-28T16:11:08Z","updated_at":"2016-06-28T13:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db20f37fe91d892ca47f40ca0185edae2d4dd5f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114/commits","review_comments_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114/comments","review_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2114/comments","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/0228772de6f55a053f350665dd3128b1a0193b98","head":{"label":"emmanuelle:blob","ref":"blob","sha":"0228772de6f55a053f350665dd3128b1a0193b98","user":{"login":"emmanuelle","id":263366,"avatar_url":"https://avatars.githubusercontent.com/u/263366?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"repo":{"id":2240207,"name":"scikit-image","full_name":"emmanuelle/scikit-image","owner":{"login":"emmanuelle","id":263366,"avatar_url":"https://avatars.githubusercontent.com/u/263366?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emmanuelle/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":true,"url":"https://api.github.com/repos/emmanuelle/scikit-image","forks_url":"https://api.github.com/repos/emmanuelle/scikit-image/forks","keys_url":"https://api.github.com/repos/emmanuelle/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmanuelle/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmanuelle/scikit-image/teams","hooks_url":"https://api.github.com/repos/emmanuelle/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/emmanuelle/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/emmanuelle/scikit-image/events","assignees_url":"https://api.github.com/repos/emmanuelle/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/emmanuelle/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/emmanuelle/scikit-image/tags","blobs_url":"https://api.github.com/repos/emmanuelle/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmanuelle/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmanuelle/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmanuelle/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmanuelle/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/emmanuelle/scikit-image/languages","stargazers_url":"https://api.github.com/repos/emmanuelle/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/emmanuelle/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/emmanuelle/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/emmanuelle/scikit-image/subscription","commits_url":"https://api.github.com/repos/emmanuelle/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmanuelle/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmanuelle/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmanuelle/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/emmanuelle/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/emmanuelle/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmanuelle/scikit-image/merges","archive_url":"https://api.github.com/repos/emmanuelle/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmanuelle/scikit-image/downloads","issues_url":"https://api.github.com/repos/emmanuelle/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/emmanuelle/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/emmanuelle/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/emmanuelle/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmanuelle/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/emmanuelle/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/emmanuelle/scikit-image/deployments","created_at":"2011-08-20T18:53:27Z","updated_at":"2016-03-07T19:23:24Z","pushed_at":"2016-06-26T08:50:19Z","git_url":"git://github.com/emmanuelle/scikit-image.git","ssh_url":"git@github.com:emmanuelle/scikit-image.git","clone_url":"https://github.com/emmanuelle/scikit-image.git","svn_url":"https://github.com/emmanuelle/scikit-image","homepage":"http://stefanv.github.com/scikits.image/","size":41422,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scikit-image:master","ref":"master","sha":"b0921c53d542161db6e3048e55f36e0f5391a6ea","user":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"repo":{"id":2014929,"name":"scikit-image","full_name":"scikit-image/scikit-image","owner":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-image/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":false,"url":"https://api.github.com/repos/scikit-image/scikit-image","forks_url":"https://api.github.com/repos/scikit-image/scikit-image/forks","keys_url":"https://api.github.com/repos/scikit-image/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-image/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-image/scikit-image/teams","hooks_url":"https://api.github.com/repos/scikit-image/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-image/scikit-image/events","assignees_url":"https://api.github.com/repos/scikit-image/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-image/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-image/scikit-image/tags","blobs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-image/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-image/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-image/scikit-image/languages","stargazers_url":"https://api.github.com/repos/scikit-image/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/scikit-image/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/scikit-image/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/scikit-image/scikit-image/subscription","commits_url":"https://api.github.com/repos/scikit-image/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-image/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-image/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-image/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-image/scikit-image/merges","archive_url":"https://api.github.com/repos/scikit-image/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-image/scikit-image/downloads","issues_url":"https://api.github.com/repos/scikit-image/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-image/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/scikit-image/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-image/scikit-image/deployments","created_at":"2011-07-07T22:07:20Z","updated_at":"2016-06-28T10:31:13Z","pushed_at":"2016-06-27T19:18:12Z","git_url":"git://github.com/scikit-image/scikit-image.git","ssh_url":"git@github.com:scikit-image/scikit-image.git","clone_url":"https://github.com/scikit-image/scikit-image.git","svn_url":"https://github.com/scikit-image/scikit-image","homepage":"http://scikit-image.org","size":74988,"stargazers_count":1138,"watchers_count":1138,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":576,"mirror_url":null,"open_issues_count":278,"forks":576,"open_issues":278,"watchers":1138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/2114"},"issue":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2114"},"comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2114/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2114/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-image/scikit-image/statuses/0228772de6f55a053f350665dd3128b1a0193b98"}}}}
{"actor":{"display_login":"jni"}}