{"action":"created","comment":{"url":"https://api.github.com/repos/senecajs/seneca/pulls/comments/69894592","id":69894592,"diff_hunk":"@@ -0,0 +1,764 @@\n+/* Copyright (c) 2013-2015 Richard Rodger, MIT License */\n+'use strict'\n+\n+var Util = require('util')\n+var _ = require('lodash')\n+var Patrun = require('patrun')\n+var Jsonic = require('jsonic')\n+var Eraro = require('eraro')\n+var Common = require('./common')\n+var Legacy = require('./legacy')\n+\n+// Shortcuts\n+var arrayify = Function.prototype.apply.bind(Array.prototype.slice)","path":"lib/legacy-logging.js","position":13,"original_position":13,"commit_id":"210dccce397d2cf6e3030266a46844a64afeb1ba","original_commit_id":"210dccce397d2cf6e3030266a46844a64afeb1ba","user":{"login":"mcdonnelldean","id":3625961,"avatar_url":"https://avatars.githubusercontent.com/u/3625961?v=3","gravatar_id":"","url":"https://api.github.com/users/mcdonnelldean","html_url":"https://github.com/mcdonnelldean","followers_url":"https://api.github.com/users/mcdonnelldean/followers","following_url":"https://api.github.com/users/mcdonnelldean/following{/other_user}","gists_url":"https://api.github.com/users/mcdonnelldean/gists{/gist_id}","starred_url":"https://api.github.com/users/mcdonnelldean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcdonnelldean/subscriptions","organizations_url":"https://api.github.com/users/mcdonnelldean/orgs","repos_url":"https://api.github.com/users/mcdonnelldean/repos","events_url":"https://api.github.com/users/mcdonnelldean/events{/privacy}","received_events_url":"https://api.github.com/users/mcdonnelldean/received_events","type":"User","site_admin":false},"body":"Already in common.js","created_at":"2016-07-07T12:05:52Z","updated_at":"2016-07-07T12:05:52Z","html_url":"https://github.com/senecajs/seneca/pull/443#discussion_r69894592","pull_request_url":"https://api.github.com/repos/senecajs/seneca/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/comments/69894592"},"html":{"href":"https://github.com/senecajs/seneca/pull/443#discussion_r69894592"},"pull_request":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/senecajs/seneca/pulls/443","id":76582407,"html_url":"https://github.com/senecajs/seneca/pull/443","diff_url":"https://github.com/senecajs/seneca/pull/443.diff","patch_url":"https://github.com/senecajs/seneca/pull/443.patch","issue_url":"https://api.github.com/repos/senecajs/seneca/issues/443","number":443,"state":"open","locked":false,"title":"new logging system; initial implementation","user":{"login":"rjrodger","id":138608,"avatar_url":"https://avatars.githubusercontent.com/u/138608?v=3","gravatar_id":"","url":"https://api.github.com/users/rjrodger","html_url":"https://github.com/rjrodger","followers_url":"https://api.github.com/users/rjrodger/followers","following_url":"https://api.github.com/users/rjrodger/following{/other_user}","gists_url":"https://api.github.com/users/rjrodger/gists{/gist_id}","starred_url":"https://api.github.com/users/rjrodger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjrodger/subscriptions","organizations_url":"https://api.github.com/users/rjrodger/orgs","repos_url":"https://api.github.com/users/rjrodger/repos","events_url":"https://api.github.com/users/rjrodger/events{/privacy}","received_events_url":"https://api.github.com/users/rjrodger/received_events","type":"User","site_admin":false},"body":"Log entries are now just plain JS objects, and logging plugins handle any further processing.\r\nThe built-in logging plugin just prints JSON lines, and provides very simple filtering.\r\nlib/legacy-logging.js is transitional and will be moved to a plugin: seneca-legacy-logger - this is the default for the rest of 2.x, and will be available via option legacy.logging = true in 3.x. Removed as builtin from 4.x.\r\nAn example a custom logging plugin: https://github.com/rjrodger/seneca-demo-logger\r\nas used by https://github.com/senecajs/ramanujan\r\nNote: as logging plugins need to work very early, the logger should be defined via the preload mechanism\r\n\r\n/cc @mcdonnelldean @mcollina @geek @pelger\r\n","created_at":"2016-07-07T11:54:06Z","updated_at":"2016-07-07T12:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c05b19a50a9cc97c192800c5cb281db12adcc56f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/senecajs/seneca/pulls/443/commits","review_comments_url":"https://api.github.com/repos/senecajs/seneca/pulls/443/comments","review_comment_url":"https://api.github.com/repos/senecajs/seneca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/senecajs/seneca/issues/443/comments","statuses_url":"https://api.github.com/repos/senecajs/seneca/statuses/210dccce397d2cf6e3030266a46844a64afeb1ba","head":{"label":"rjrodger:master","ref":"master","sha":"210dccce397d2cf6e3030266a46844a64afeb1ba","user":{"login":"rjrodger","id":138608,"avatar_url":"https://avatars.githubusercontent.com/u/138608?v=3","gravatar_id":"","url":"https://api.github.com/users/rjrodger","html_url":"https://github.com/rjrodger","followers_url":"https://api.github.com/users/rjrodger/followers","following_url":"https://api.github.com/users/rjrodger/following{/other_user}","gists_url":"https://api.github.com/users/rjrodger/gists{/gist_id}","starred_url":"https://api.github.com/users/rjrodger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjrodger/subscriptions","organizations_url":"https://api.github.com/users/rjrodger/orgs","repos_url":"https://api.github.com/users/rjrodger/repos","events_url":"https://api.github.com/users/rjrodger/events{/privacy}","received_events_url":"https://api.github.com/users/rjrodger/received_events","type":"User","site_admin":false},"repo":{"id":58328381,"name":"seneca","full_name":"rjrodger/seneca","owner":{"login":"rjrodger","id":138608,"avatar_url":"https://avatars.githubusercontent.com/u/138608?v=3","gravatar_id":"","url":"https://api.github.com/users/rjrodger","html_url":"https://github.com/rjrodger","followers_url":"https://api.github.com/users/rjrodger/followers","following_url":"https://api.github.com/users/rjrodger/following{/other_user}","gists_url":"https://api.github.com/users/rjrodger/gists{/gist_id}","starred_url":"https://api.github.com/users/rjrodger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjrodger/subscriptions","organizations_url":"https://api.github.com/users/rjrodger/orgs","repos_url":"https://api.github.com/users/rjrodger/repos","events_url":"https://api.github.com/users/rjrodger/events{/privacy}","received_events_url":"https://api.github.com/users/rjrodger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjrodger/seneca","description":"A microservices toolkit for Node.js.","fork":true,"url":"https://api.github.com/repos/rjrodger/seneca","forks_url":"https://api.github.com/repos/rjrodger/seneca/forks","keys_url":"https://api.github.com/repos/rjrodger/seneca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjrodger/seneca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjrodger/seneca/teams","hooks_url":"https://api.github.com/repos/rjrodger/seneca/hooks","issue_events_url":"https://api.github.com/repos/rjrodger/seneca/issues/events{/number}","events_url":"https://api.github.com/repos/rjrodger/seneca/events","assignees_url":"https://api.github.com/repos/rjrodger/seneca/assignees{/user}","branches_url":"https://api.github.com/repos/rjrodger/seneca/branches{/branch}","tags_url":"https://api.github.com/repos/rjrodger/seneca/tags","blobs_url":"https://api.github.com/repos/rjrodger/seneca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjrodger/seneca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjrodger/seneca/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjrodger/seneca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjrodger/seneca/statuses/{sha}","languages_url":"https://api.github.com/repos/rjrodger/seneca/languages","stargazers_url":"https://api.github.com/repos/rjrodger/seneca/stargazers","contributors_url":"https://api.github.com/repos/rjrodger/seneca/contributors","subscribers_url":"https://api.github.com/repos/rjrodger/seneca/subscribers","subscription_url":"https://api.github.com/repos/rjrodger/seneca/subscription","commits_url":"https://api.github.com/repos/rjrodger/seneca/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjrodger/seneca/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjrodger/seneca/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjrodger/seneca/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjrodger/seneca/contents/{+path}","compare_url":"https://api.github.com/repos/rjrodger/seneca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjrodger/seneca/merges","archive_url":"https://api.github.com/repos/rjrodger/seneca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjrodger/seneca/downloads","issues_url":"https://api.github.com/repos/rjrodger/seneca/issues{/number}","pulls_url":"https://api.github.com/repos/rjrodger/seneca/pulls{/number}","milestones_url":"https://api.github.com/repos/rjrodger/seneca/milestones{/number}","notifications_url":"https://api.github.com/repos/rjrodger/seneca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjrodger/seneca/labels{/name}","releases_url":"https://api.github.com/repos/rjrodger/seneca/releases{/id}","deployments_url":"https://api.github.com/repos/rjrodger/seneca/deployments","created_at":"2016-05-08T19:47:44Z","updated_at":"2016-05-14T15:27:34Z","pushed_at":"2016-07-07T11:38:29Z","git_url":"git://github.com/rjrodger/seneca.git","ssh_url":"git@github.com:rjrodger/seneca.git","clone_url":"https://github.com/rjrodger/seneca.git","svn_url":"https://github.com/rjrodger/seneca","homepage":"http://senecajs.org","size":4156,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"senecajs:master","ref":"master","sha":"1ed20c0a4df38f58455690158344aac46442bd8d","user":{"login":"senecajs","id":10085488,"avatar_url":"https://avatars.githubusercontent.com/u/10085488?v=3","gravatar_id":"","url":"https://api.github.com/users/senecajs","html_url":"https://github.com/senecajs","followers_url":"https://api.github.com/users/senecajs/followers","following_url":"https://api.github.com/users/senecajs/following{/other_user}","gists_url":"https://api.github.com/users/senecajs/gists{/gist_id}","starred_url":"https://api.github.com/users/senecajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senecajs/subscriptions","organizations_url":"https://api.github.com/users/senecajs/orgs","repos_url":"https://api.github.com/users/senecajs/repos","events_url":"https://api.github.com/users/senecajs/events{/privacy}","received_events_url":"https://api.github.com/users/senecajs/received_events","type":"Organization","site_admin":false},"repo":{"id":1012745,"name":"seneca","full_name":"senecajs/seneca","owner":{"login":"senecajs","id":10085488,"avatar_url":"https://avatars.githubusercontent.com/u/10085488?v=3","gravatar_id":"","url":"https://api.github.com/users/senecajs","html_url":"https://github.com/senecajs","followers_url":"https://api.github.com/users/senecajs/followers","following_url":"https://api.github.com/users/senecajs/following{/other_user}","gists_url":"https://api.github.com/users/senecajs/gists{/gist_id}","starred_url":"https://api.github.com/users/senecajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senecajs/subscriptions","organizations_url":"https://api.github.com/users/senecajs/orgs","repos_url":"https://api.github.com/users/senecajs/repos","events_url":"https://api.github.com/users/senecajs/events{/privacy}","received_events_url":"https://api.github.com/users/senecajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/senecajs/seneca","description":"A microservices toolkit for Node.js.","fork":false,"url":"https://api.github.com/repos/senecajs/seneca","forks_url":"https://api.github.com/repos/senecajs/seneca/forks","keys_url":"https://api.github.com/repos/senecajs/seneca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senecajs/seneca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senecajs/seneca/teams","hooks_url":"https://api.github.com/repos/senecajs/seneca/hooks","issue_events_url":"https://api.github.com/repos/senecajs/seneca/issues/events{/number}","events_url":"https://api.github.com/repos/senecajs/seneca/events","assignees_url":"https://api.github.com/repos/senecajs/seneca/assignees{/user}","branches_url":"https://api.github.com/repos/senecajs/seneca/branches{/branch}","tags_url":"https://api.github.com/repos/senecajs/seneca/tags","blobs_url":"https://api.github.com/repos/senecajs/seneca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senecajs/seneca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senecajs/seneca/git/refs{/sha}","trees_url":"https://api.github.com/repos/senecajs/seneca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senecajs/seneca/statuses/{sha}","languages_url":"https://api.github.com/repos/senecajs/seneca/languages","stargazers_url":"https://api.github.com/repos/senecajs/seneca/stargazers","contributors_url":"https://api.github.com/repos/senecajs/seneca/contributors","subscribers_url":"https://api.github.com/repos/senecajs/seneca/subscribers","subscription_url":"https://api.github.com/repos/senecajs/seneca/subscription","commits_url":"https://api.github.com/repos/senecajs/seneca/commits{/sha}","git_commits_url":"https://api.github.com/repos/senecajs/seneca/git/commits{/sha}","comments_url":"https://api.github.com/repos/senecajs/seneca/comments{/number}","issue_comment_url":"https://api.github.com/repos/senecajs/seneca/issues/comments{/number}","contents_url":"https://api.github.com/repos/senecajs/seneca/contents/{+path}","compare_url":"https://api.github.com/repos/senecajs/seneca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senecajs/seneca/merges","archive_url":"https://api.github.com/repos/senecajs/seneca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senecajs/seneca/downloads","issues_url":"https://api.github.com/repos/senecajs/seneca/issues{/number}","pulls_url":"https://api.github.com/repos/senecajs/seneca/pulls{/number}","milestones_url":"https://api.github.com/repos/senecajs/seneca/milestones{/number}","notifications_url":"https://api.github.com/repos/senecajs/seneca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senecajs/seneca/labels{/name}","releases_url":"https://api.github.com/repos/senecajs/seneca/releases{/id}","deployments_url":"https://api.github.com/repos/senecajs/seneca/deployments","created_at":"2010-10-21T17:09:05Z","updated_at":"2016-07-07T10:24:23Z","pushed_at":"2016-07-07T11:54:06Z","git_url":"git://github.com/senecajs/seneca.git","ssh_url":"git@github.com:senecajs/seneca.git","clone_url":"https://github.com/senecajs/seneca.git","svn_url":"https://github.com/senecajs/seneca","homepage":"http://senecajs.org","size":6405,"stargazers_count":1414,"watchers_count":1414,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":32,"forks":148,"open_issues":32,"watchers":1414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/443"},"html":{"href":"https://github.com/senecajs/seneca/pull/443"},"issue":{"href":"https://api.github.com/repos/senecajs/seneca/issues/443"},"comments":{"href":"https://api.github.com/repos/senecajs/seneca/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/senecajs/seneca/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/senecajs/seneca/statuses/210dccce397d2cf6e3030266a46844a64afeb1ba"}}}}
{"actor":{"display_login":"mcdonnelldean"}}