{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments/86030520","pull_request_review_id":6708881,"id":86030520,"diff_hunk":"@@ -488,18 +498,32 @@ def SyncPrebuiltCMake(name, src_dir, git_repo):\n       raise\n \n \n+def SyncTarball(out_dir, name, version, url, tar):\n+  if os.path.isdir(out_dir):\n+    print '%s directory already exists' % name\n+    return\n+  print 'Downloading %s %s from %s' % (name, version, url)\n+  f = urllib2.urlopen(url)\n+  print 'URL: %s' % f.geturl()\n+  print 'Info: %s' % f.info()\n+  with open(tar, 'wb') as out:\n+    out.write(f.read())\n+  proc.check_call(['tar', '-xvf', tar], cwd=WORK_DIR)\n+  assert os.path.isdir(out_dir), 'Untar should produce %s' % out_dir\n+\n+\n def SyncOCaml(name, src_dir, git_repo):\n-  if os.path.isdir(src_dir):\n-    print 'OCaml directory already exists'\n-  else:\n-    print 'Downloading OCaml %s from %s' % (OCAML_VERSION, OCAML_URL)\n-    f = urllib2.urlopen(OCAML_URL)\n-    print 'URL: %s' % f.geturl()\n-    print 'Info: %s' % f.info()\n-    with open(OCAML_TAR, 'wb') as out:\n-      out.write(f.read())\n-    proc.check_call(['tar', '-xvf', OCAML_TAR], cwd=WORK_DIR)\n-    assert os.path.isdir(OCAML_DIR), 'Untar should produce %s' % OCAML_DIR\n+  return SyncTarball(src_dir, 'OCaml', OCAML_VERSION, OCAML_URL, OCAML_TAR)\n+\n+\n+def SyncPrebuiltNodeJS(name, src_dir, git_repo):\n+  extension = {'darwin': 'gz', 'linux2': 'xz'}[sys.platform]\n+  out_dir = os.path.join(WORK_DIR, NODE_BASE_NAME + NodePlatformName())\n+  tarball = NODE_BASE_NAME + NodePlatformName() + '.tar.' + extension\n+  print tarball","path":"src/build.py","position":65,"original_position":65,"commit_id":"ce5f75396e2c96ca1203731e971ef6bd90d628a2","original_commit_id":"ce5f75396e2c96ca1203731e971ef6bd90d628a2","user":{"login":"jgravelle-google","id":20847303,"avatar_url":"https://avatars.githubusercontent.com/u/20847303?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravelle-google","html_url":"https://github.com/jgravelle-google","followers_url":"https://api.github.com/users/jgravelle-google/followers","following_url":"https://api.github.com/users/jgravelle-google/following{/other_user}","gists_url":"https://api.github.com/users/jgravelle-google/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravelle-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravelle-google/subscriptions","organizations_url":"https://api.github.com/users/jgravelle-google/orgs","repos_url":"https://api.github.com/users/jgravelle-google/repos","events_url":"https://api.github.com/users/jgravelle-google/events{/privacy}","received_events_url":"https://api.github.com/users/jgravelle-google/received_events","type":"User","site_admin":false},"body":"Debug print? Might be useful with more context than just a filename","created_at":"2016-11-01T21:34:33Z","updated_at":"2016-11-01T21:38:52Z","html_url":"https://github.com/WebAssembly/waterfall/pull/141#discussion_r86030520","pull_request_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments/86030520"},"html":{"href":"https://github.com/WebAssembly/waterfall/pull/141#discussion_r86030520"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141","id":91865332,"html_url":"https://github.com/WebAssembly/waterfall/pull/141","diff_url":"https://github.com/WebAssembly/waterfall/pull/141.diff","patch_url":"https://github.com/WebAssembly/waterfall/pull/141.patch","issue_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/141","number":141,"state":"open","locked":false,"title":"Use prebuilt binary node.js","user":{"login":"dschuff","id":1122856,"avatar_url":"https://avatars.githubusercontent.com/u/1122856?v=3","gravatar_id":"","url":"https://api.github.com/users/dschuff","html_url":"https://github.com/dschuff","followers_url":"https://api.github.com/users/dschuff/followers","following_url":"https://api.github.com/users/dschuff/following{/other_user}","gists_url":"https://api.github.com/users/dschuff/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuff/subscriptions","organizations_url":"https://api.github.com/users/dschuff/orgs","repos_url":"https://api.github.com/users/dschuff/repos","events_url":"https://api.github.com/users/dschuff/events{/privacy}","received_events_url":"https://api.github.com/users/dschuff/received_events","type":"User","site_admin":false},"body":"Node.js isn't part of the base image for our buildbots, so it disappears whenever they get swapped or wiped. Use a prebuilt from nodejs.org (mirrored locally) instead. Keep the config file's fallback to /usr/bin/node in case someone ends up using that config file. Also use node as the compiler engine, as that more closely reflects what users are likely to do.","created_at":"2016-11-01T21:17:36Z","updated_at":"2016-11-01T21:38:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78b7490c9d33d38f33c56dcf34923d66ba9f250d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/141/comments","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/ce5f75396e2c96ca1203731e971ef6bd90d628a2","head":{"label":"WebAssembly:binary-node","ref":"binary-node","sha":"ce5f75396e2c96ca1203731e971ef6bd90d628a2","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":49115003,"name":"waterfall","full_name":"WebAssembly/waterfall","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/waterfall","description":"Build and test bots","fork":false,"url":"https://api.github.com/repos/WebAssembly/waterfall","forks_url":"https://api.github.com/repos/WebAssembly/waterfall/forks","keys_url":"https://api.github.com/repos/WebAssembly/waterfall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/waterfall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/waterfall/teams","hooks_url":"https://api.github.com/repos/WebAssembly/waterfall/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/waterfall/events","assignees_url":"https://api.github.com/repos/WebAssembly/waterfall/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/waterfall/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/waterfall/tags","blobs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/waterfall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/waterfall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/waterfall/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/waterfall/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/waterfall/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/waterfall/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/waterfall/subscription","commits_url":"https://api.github.com/repos/WebAssembly/waterfall/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/waterfall/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/waterfall/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/waterfall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/waterfall/merges","archive_url":"https://api.github.com/repos/WebAssembly/waterfall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/waterfall/downloads","issues_url":"https://api.github.com/repos/WebAssembly/waterfall/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/waterfall/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/waterfall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/waterfall/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/waterfall/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/waterfall/deployments","created_at":"2016-01-06T05:37:09Z","updated_at":"2016-10-22T22:47:55Z","pushed_at":"2016-11-01T21:18:31Z","git_url":"git://github.com/WebAssembly/waterfall.git","ssh_url":"git@github.com:WebAssembly/waterfall.git","clone_url":"https://github.com/WebAssembly/waterfall.git","svn_url":"https://github.com/WebAssembly/waterfall","homepage":null,"size":482,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":8,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"a3a79d0a370041c2ef2bf9be31dab47e0f1a8a0c","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":49115003,"name":"waterfall","full_name":"WebAssembly/waterfall","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/waterfall","description":"Build and test bots","fork":false,"url":"https://api.github.com/repos/WebAssembly/waterfall","forks_url":"https://api.github.com/repos/WebAssembly/waterfall/forks","keys_url":"https://api.github.com/repos/WebAssembly/waterfall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/waterfall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/waterfall/teams","hooks_url":"https://api.github.com/repos/WebAssembly/waterfall/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/waterfall/events","assignees_url":"https://api.github.com/repos/WebAssembly/waterfall/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/waterfall/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/waterfall/tags","blobs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/waterfall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/waterfall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/waterfall/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/waterfall/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/waterfall/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/waterfall/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/waterfall/subscription","commits_url":"https://api.github.com/repos/WebAssembly/waterfall/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/waterfall/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/waterfall/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/waterfall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/waterfall/merges","archive_url":"https://api.github.com/repos/WebAssembly/waterfall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/waterfall/downloads","issues_url":"https://api.github.com/repos/WebAssembly/waterfall/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/waterfall/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/waterfall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/waterfall/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/waterfall/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/waterfall/deployments","created_at":"2016-01-06T05:37:09Z","updated_at":"2016-10-22T22:47:55Z","pushed_at":"2016-11-01T21:18:31Z","git_url":"git://github.com/WebAssembly/waterfall.git","ssh_url":"git@github.com:WebAssembly/waterfall.git","clone_url":"https://github.com/WebAssembly/waterfall.git","svn_url":"https://github.com/WebAssembly/waterfall","homepage":null,"size":482,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141"},"html":{"href":"https://github.com/WebAssembly/waterfall/pull/141"},"issue":{"href":"https://api.github.com/repos/WebAssembly/waterfall/issues/141"},"comments":{"href":"https://api.github.com/repos/WebAssembly/waterfall/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/waterfall/statuses/ce5f75396e2c96ca1203731e971ef6bd90d628a2"}}}}
{"actor":{"display_login":"jgravelle-google"}}