{"action":"created","comment":{"url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/comments/70394829","id":70394829,"diff_hunk":"@@ -86,4 +89,75 @@ protected void generateJWTResponse(ChannelHandlerContext ctx, HashMap<String, St\n         ctx.writeAndFlush(result).addListener(ChannelFutureListener.CLOSE);\n     }\n \n+    /**\n+     * This is what happens when the proxy needs to work as a normal proxy.\n+     * We could also direct IDP traffic this way instead of the the apache.http.HttpClient, but then we would need\n+     * SSL set up.\n+     *\n+     * @param ctx\n+     * @param securityConfig\n+     * @param httpRequest\n+     * @param proxyCookie\n+     */\n+\n+    public Channel generateProxyResponse(ChannelHandlerContext ctx, HttpRequest httpRequest,\n+                                         SecurityConfig securityConfig, ProxyCookie proxyCookie) {\n+\n+        int connect_timeout_millis = 15000;","path":"proxy-proxy/src/main/java/no/difi/idporten/oidc/proxy/proxy/ResponseGenerator.java","position":57,"original_position":57,"commit_id":"93acfdb0329fa98835d0cf159d5240a3930764ff","original_commit_id":"93acfdb0329fa98835d0cf159d5240a3930764ff","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: ['15000' is a magic number.](https://www.codacy.com/app/klakegg/dc16-oidc-proxy/file/2964242367/issues/source?bid=3400779&fileBranchId=3423607#l106)","created_at":"2016-07-12T08:15:56Z","updated_at":"2016-07-12T08:15:56Z","html_url":"https://github.com/difi/dc16-oidc-proxy/pull/69#discussion_r70394829","pull_request_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/comments/70394829"},"html":{"href":"https://github.com/difi/dc16-oidc-proxy/pull/69#discussion_r70394829"},"pull_request":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69","id":76946765,"html_url":"https://github.com/difi/dc16-oidc-proxy/pull/69","diff_url":"https://github.com/difi/dc16-oidc-proxy/pull/69.diff","patch_url":"https://github.com/difi/dc16-oidc-proxy/pull/69.patch","issue_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/69","number":69,"state":"open","locked":false,"title":"Expose userdata","user":{"login":"didrikpa","id":6780986,"avatar_url":"https://avatars.githubusercontent.com/u/6780986?v=3","gravatar_id":"","url":"https://api.github.com/users/didrikpa","html_url":"https://github.com/didrikpa","followers_url":"https://api.github.com/users/didrikpa/followers","following_url":"https://api.github.com/users/didrikpa/following{/other_user}","gists_url":"https://api.github.com/users/didrikpa/gists{/gist_id}","starred_url":"https://api.github.com/users/didrikpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didrikpa/subscriptions","organizations_url":"https://api.github.com/users/didrikpa/orgs","repos_url":"https://api.github.com/users/didrikpa/repos","events_url":"https://api.github.com/users/didrikpa/events{/privacy}","received_events_url":"https://api.github.com/users/didrikpa/received_events","type":"User","site_admin":false},"body":"Proxy is now working on secured area, and exposes userdata to the service. Moved bootstrapoutboundchannel into ResponseGenerator and renamed into generateProxyResponse.","created_at":"2016-07-11T12:41:41Z","updated_at":"2016-07-12T08:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b20e70ef2a6ce06a7da200cd4eab79657c8799a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69/commits","review_comments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69/comments","review_comment_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/69/comments","statuses_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/statuses/93acfdb0329fa98835d0cf159d5240a3930764ff","head":{"label":"difi:expose-userdata","ref":"expose-userdata","sha":"93acfdb0329fa98835d0cf159d5240a3930764ff","user":{"login":"difi","id":226592,"avatar_url":"https://avatars.githubusercontent.com/u/226592?v=3","gravatar_id":"","url":"https://api.github.com/users/difi","html_url":"https://github.com/difi","followers_url":"https://api.github.com/users/difi/followers","following_url":"https://api.github.com/users/difi/following{/other_user}","gists_url":"https://api.github.com/users/difi/gists{/gist_id}","starred_url":"https://api.github.com/users/difi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/difi/subscriptions","organizations_url":"https://api.github.com/users/difi/orgs","repos_url":"https://api.github.com/users/difi/repos","events_url":"https://api.github.com/users/difi/events{/privacy}","received_events_url":"https://api.github.com/users/difi/received_events","type":"Organization","site_admin":false},"repo":{"id":60424566,"name":"dc16-oidc-proxy","full_name":"difi/dc16-oidc-proxy","owner":{"login":"difi","id":226592,"avatar_url":"https://avatars.githubusercontent.com/u/226592?v=3","gravatar_id":"","url":"https://api.github.com/users/difi","html_url":"https://github.com/difi","followers_url":"https://api.github.com/users/difi/followers","following_url":"https://api.github.com/users/difi/following{/other_user}","gists_url":"https://api.github.com/users/difi/gists{/gist_id}","starred_url":"https://api.github.com/users/difi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/difi/subscriptions","organizations_url":"https://api.github.com/users/difi/orgs","repos_url":"https://api.github.com/users/difi/repos","events_url":"https://api.github.com/users/difi/events{/privacy}","received_events_url":"https://api.github.com/users/difi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/difi/dc16-oidc-proxy","description":"DifiCamp 2016 Open ID Connect Proxy project","fork":false,"url":"https://api.github.com/repos/difi/dc16-oidc-proxy","forks_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/forks","keys_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/teams","hooks_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/hooks","issue_events_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/events","assignees_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/tags","blobs_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/languages","stargazers_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/stargazers","contributors_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/contributors","subscribers_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/subscribers","subscription_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/subscription","commits_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/merges","archive_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/downloads","issues_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/labels{/name}","releases_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/deployments","created_at":"2016-06-04T18:30:42Z","updated_at":"2016-06-16T05:47:46Z","pushed_at":"2016-07-12T08:14:33Z","git_url":"git://github.com/difi/dc16-oidc-proxy.git","ssh_url":"git@github.com:difi/dc16-oidc-proxy.git","clone_url":"https://github.com/difi/dc16-oidc-proxy.git","svn_url":"https://github.com/difi/dc16-oidc-proxy","homepage":null,"size":450,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"difi:master","ref":"master","sha":"0c6d5efe017f68ba91960adb32a1c2591e6c8437","user":{"login":"difi","id":226592,"avatar_url":"https://avatars.githubusercontent.com/u/226592?v=3","gravatar_id":"","url":"https://api.github.com/users/difi","html_url":"https://github.com/difi","followers_url":"https://api.github.com/users/difi/followers","following_url":"https://api.github.com/users/difi/following{/other_user}","gists_url":"https://api.github.com/users/difi/gists{/gist_id}","starred_url":"https://api.github.com/users/difi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/difi/subscriptions","organizations_url":"https://api.github.com/users/difi/orgs","repos_url":"https://api.github.com/users/difi/repos","events_url":"https://api.github.com/users/difi/events{/privacy}","received_events_url":"https://api.github.com/users/difi/received_events","type":"Organization","site_admin":false},"repo":{"id":60424566,"name":"dc16-oidc-proxy","full_name":"difi/dc16-oidc-proxy","owner":{"login":"difi","id":226592,"avatar_url":"https://avatars.githubusercontent.com/u/226592?v=3","gravatar_id":"","url":"https://api.github.com/users/difi","html_url":"https://github.com/difi","followers_url":"https://api.github.com/users/difi/followers","following_url":"https://api.github.com/users/difi/following{/other_user}","gists_url":"https://api.github.com/users/difi/gists{/gist_id}","starred_url":"https://api.github.com/users/difi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/difi/subscriptions","organizations_url":"https://api.github.com/users/difi/orgs","repos_url":"https://api.github.com/users/difi/repos","events_url":"https://api.github.com/users/difi/events{/privacy}","received_events_url":"https://api.github.com/users/difi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/difi/dc16-oidc-proxy","description":"DifiCamp 2016 Open ID Connect Proxy project","fork":false,"url":"https://api.github.com/repos/difi/dc16-oidc-proxy","forks_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/forks","keys_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/teams","hooks_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/hooks","issue_events_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/events","assignees_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/tags","blobs_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/languages","stargazers_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/stargazers","contributors_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/contributors","subscribers_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/subscribers","subscription_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/subscription","commits_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/merges","archive_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/downloads","issues_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/labels{/name}","releases_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/difi/dc16-oidc-proxy/deployments","created_at":"2016-06-04T18:30:42Z","updated_at":"2016-06-16T05:47:46Z","pushed_at":"2016-07-12T08:14:33Z","git_url":"git://github.com/difi/dc16-oidc-proxy.git","ssh_url":"git@github.com:difi/dc16-oidc-proxy.git","clone_url":"https://github.com/difi/dc16-oidc-proxy.git","svn_url":"https://github.com/difi/dc16-oidc-proxy","homepage":null,"size":450,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69"},"html":{"href":"https://github.com/difi/dc16-oidc-proxy/pull/69"},"issue":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/69"},"comments":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/difi/dc16-oidc-proxy/statuses/93acfdb0329fa98835d0cf159d5240a3930764ff"}}}}
{"actor":{"display_login":"codacy-bot"}}