{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36","id":59849888,"html_url":"https://github.com/spacetelescope/gwcs/pull/36","diff_url":"https://github.com/spacetelescope/gwcs/pull/36.diff","patch_url":"https://github.com/spacetelescope/gwcs/pull/36.patch","issue_url":"https://api.github.com/repos/spacetelescope/gwcs/issues/36","number":36,"state":"closed","locked":false,"title":"add domain attribute","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"This adds a `WCS.domain` attribute. \r\nThis is not entirely new as it was a working assumption for a while that models have a domain defined in `Model.meta`. The definition of `domain` is in its [schema](https://github.com/spacetelescope/asdf-standard/blob/master/schemas/stsci.edu/asdf/transform/domain-1.0.0.yaml).\r\nThis PR defines the `domain` attribute at the level of the WCS object. It also adds a `step` key of the domain which defaults to 1.\r\n\r\n`gwcs.domain` corresponds to `astropy.wcs._naxis1/2` but is more general because it defines a step along the axis and the start of the axis is not assumed to be 1.\r\n\r\nSome of its use cases are computing footprints, or evaluating transforms which have limited range of validity. This raises the question of what should the return value of the `WCS` be outside the domain. Any suggestions?\r\n\r\nOf course this is very similar to the [bounding_box](http://astropy.readthedocs.org/en/latest/api/astropy.modeling.Model.html#astropy.modeling.Model.bounding_box) of models and eventually the two should be merged.\r\n\r\nAdditionally `step` should be added to the domain schema.\r\n\r\n\r\n ","created_at":"2016-02-18T19:27:34Z","updated_at":"2016-02-29T20:47:43Z","closed_at":"2016-02-29T20:47:43Z","merged_at":"2016-02-29T20:47:43Z","merge_commit_sha":"26f59a661bca8f69c5f81a576473fd7a5f104e8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/gwcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/gwcs/issues/36/comments","statuses_url":"https://api.github.com/repos/spacetelescope/gwcs/statuses/0cd5ddf1532a66d85ddd83b728d57d8fca1ee322","head":{"label":"nden:domain-wcs","ref":"domain-wcs","sha":"0cd5ddf1532a66d85ddd83b728d57d8fca1ee322","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"repo":{"id":29211892,"name":"gwcs","full_name":"nden/gwcs","owner":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nden/gwcs","description":"Generalized World Coordinate System","fork":true,"url":"https://api.github.com/repos/nden/gwcs","forks_url":"https://api.github.com/repos/nden/gwcs/forks","keys_url":"https://api.github.com/repos/nden/gwcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nden/gwcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nden/gwcs/teams","hooks_url":"https://api.github.com/repos/nden/gwcs/hooks","issue_events_url":"https://api.github.com/repos/nden/gwcs/issues/events{/number}","events_url":"https://api.github.com/repos/nden/gwcs/events","assignees_url":"https://api.github.com/repos/nden/gwcs/assignees{/user}","branches_url":"https://api.github.com/repos/nden/gwcs/branches{/branch}","tags_url":"https://api.github.com/repos/nden/gwcs/tags","blobs_url":"https://api.github.com/repos/nden/gwcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nden/gwcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nden/gwcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nden/gwcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nden/gwcs/statuses/{sha}","languages_url":"https://api.github.com/repos/nden/gwcs/languages","stargazers_url":"https://api.github.com/repos/nden/gwcs/stargazers","contributors_url":"https://api.github.com/repos/nden/gwcs/contributors","subscribers_url":"https://api.github.com/repos/nden/gwcs/subscribers","subscription_url":"https://api.github.com/repos/nden/gwcs/subscription","commits_url":"https://api.github.com/repos/nden/gwcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nden/gwcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nden/gwcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nden/gwcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nden/gwcs/contents/{+path}","compare_url":"https://api.github.com/repos/nden/gwcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nden/gwcs/merges","archive_url":"https://api.github.com/repos/nden/gwcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nden/gwcs/downloads","issues_url":"https://api.github.com/repos/nden/gwcs/issues{/number}","pulls_url":"https://api.github.com/repos/nden/gwcs/pulls{/number}","milestones_url":"https://api.github.com/repos/nden/gwcs/milestones{/number}","notifications_url":"https://api.github.com/repos/nden/gwcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nden/gwcs/labels{/name}","releases_url":"https://api.github.com/repos/nden/gwcs/releases{/id}","deployments_url":"https://api.github.com/repos/nden/gwcs/deployments","created_at":"2015-01-13T21:22:54Z","updated_at":"2015-03-16T21:15:28Z","pushed_at":"2016-02-18T20:31:34Z","git_url":"git://github.com/nden/gwcs.git","ssh_url":"git@github.com:nden/gwcs.git","clone_url":"https://github.com/nden/gwcs.git","svn_url":"https://github.com/nden/gwcs","homepage":"http://gwcs.readthedocs.org/en/latest/","size":273,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"8fe881723beae9b28cba688b6f167bd70e899fe3","user":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars.githubusercontent.com/u/2751928?v=3","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":29208937,"name":"gwcs","full_name":"spacetelescope/gwcs","owner":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars.githubusercontent.com/u/2751928?v=3","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spacetelescope/gwcs","description":"Generalized World Coordinate System: provides tools for managing the WCS in a general way","fork":false,"url":"https://api.github.com/repos/spacetelescope/gwcs","forks_url":"https://api.github.com/repos/spacetelescope/gwcs/forks","keys_url":"https://api.github.com/repos/spacetelescope/gwcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/gwcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/gwcs/teams","hooks_url":"https://api.github.com/repos/spacetelescope/gwcs/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/gwcs/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/gwcs/events","assignees_url":"https://api.github.com/repos/spacetelescope/gwcs/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/gwcs/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/gwcs/tags","blobs_url":"https://api.github.com/repos/spacetelescope/gwcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/gwcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/gwcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/gwcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/gwcs/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/gwcs/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/gwcs/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/gwcs/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/gwcs/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/gwcs/subscription","commits_url":"https://api.github.com/repos/spacetelescope/gwcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/gwcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/gwcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/gwcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/gwcs/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/gwcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/gwcs/merges","archive_url":"https://api.github.com/repos/spacetelescope/gwcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/gwcs/downloads","issues_url":"https://api.github.com/repos/spacetelescope/gwcs/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/gwcs/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/gwcs/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/gwcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/gwcs/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/gwcs/releases{/id}","deployments_url":"https://api.github.com/repos/spacetelescope/gwcs/deployments","created_at":"2015-01-13T20:16:16Z","updated_at":"2016-01-22T11:13:56Z","pushed_at":"2016-02-29T20:47:42Z","git_url":"git://github.com/spacetelescope/gwcs.git","ssh_url":"git@github.com:spacetelescope/gwcs.git","clone_url":"https://github.com/spacetelescope/gwcs.git","svn_url":"https://github.com/spacetelescope/gwcs","homepage":"http://gwcs.readthedocs.org/en/latest/","size":289,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36"},"html":{"href":"https://github.com/spacetelescope/gwcs/pull/36"},"issue":{"href":"https://api.github.com/repos/spacetelescope/gwcs/issues/36"},"comments":{"href":"https://api.github.com/repos/spacetelescope/gwcs/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/gwcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/gwcs/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/gwcs/statuses/0cd5ddf1532a66d85ddd83b728d57d8fca1ee322"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":5,"additions":132,"deletions":36,"changed_files":6}}