{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/3013","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/3013/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/3013/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/3013/events","html_url":"https://github.com/serverless/serverless/pull/3013","id":197311959,"number":3013,"title":"update plugin document","user":{"login":"horike37","id":1301012,"avatar_url":"https://avatars.githubusercontent.com/u/1301012?v=3","gravatar_id":"","url":"https://api.github.com/users/horike37","html_url":"https://github.com/horike37","followers_url":"https://api.github.com/users/horike37/followers","following_url":"https://api.github.com/users/horike37/following{/other_user}","gists_url":"https://api.github.com/users/horike37/gists{/gist_id}","starred_url":"https://api.github.com/users/horike37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horike37/subscriptions","organizations_url":"https://api.github.com/users/horike37/orgs","repos_url":"https://api.github.com/users/horike37/repos","events_url":"https://api.github.com/users/horike37/events{/privacy}","received_events_url":"https://api.github.com/users/horike37/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T04:36:20Z","updated_at":"2016-12-23T06:35:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/3013","html_url":"https://github.com/serverless/serverless/pull/3013","diff_url":"https://github.com/serverless/serverless/pull/3013.diff","patch_url":"https://github.com/serverless/serverless/pull/3013.patch"},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\nUpdate  the plugin document.\r\n\r\n\r\nI think that instead of specifying a direct proviver name, we are using the `getProvider` function, but is I correct?\r\nhttps://github.com/serverless/serverless/commit/df7692ac809ead5febe1f59645ad9c3c901dcd3a\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* AWS CLI commands - To list AWS resources and show that the correct config is in place\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [x] Write documentation\r\n- [ ] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config/commands/resources\r\n- [x] Enable [\"Allow edits from maintainers\"](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for this PR\r\n- [x] Change ready for review message below\r\n\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO\r\n"},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/268946901","html_url":"https://github.com/serverless/serverless/pull/3013#issuecomment-268946901","issue_url":"https://api.github.com/repos/serverless/serverless/issues/3013","id":268946901,"user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T06:35:34Z","updated_at":"2016-12-23T06:35:34Z","body":"That's absolutely correct! Nice catch @horike37 👍 and thanks for the PR!"}}
{"actor":{"display_login":"pmuens"}}