{"action":"created","issue":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/2542","repository_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map","labels_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/2542/labels{/name}","comments_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/2542/comments","events_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/2542/events","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/2542","id":168251083,"number":2542,"title":"Readd async to Google Maps JS load","user":{"login":"leftmostcat","id":20660,"avatar_url":"https://avatars.githubusercontent.com/u/20660?v=3","gravatar_id":"","url":"https://api.github.com/users/leftmostcat","html_url":"https://github.com/leftmostcat","followers_url":"https://api.github.com/users/leftmostcat/followers","following_url":"https://api.github.com/users/leftmostcat/following{/other_user}","gists_url":"https://api.github.com/users/leftmostcat/gists{/gist_id}","starred_url":"https://api.github.com/users/leftmostcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftmostcat/subscriptions","organizations_url":"https://api.github.com/users/leftmostcat/orgs","repos_url":"https://api.github.com/users/leftmostcat/repos","events_url":"https://api.github.com/users/leftmostcat/events{/privacy}","received_events_url":"https://api.github.com/users/leftmostcat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-29T05:01:33Z","updated_at":"2016-07-29T13:53:16Z","closed_at":"2016-07-29T13:53:16Z","pull_request":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/pulls/2542","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/2542","diff_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/2542.diff","patch_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/2542.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis sets the &lt;script&gt; tag for the Google Maps JS API to load asynchronously.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nWithout the async attribute, there are a variety of timing issues with map loading which may prevent the map from being properly created, scanned locations from appearing, or markers (e.g., Pokémon) from showing. The following issues all appear to be related to this problem:\r\n\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/1905\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/1907\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2046\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2110\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2121\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2151\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2161\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2190\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/2202\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nThis has been tested in Firefox for Linux and OSX and Chrome for OSX. Additionally, it has been tested in Chrome for iOS and Android, Firefox for Android, and Safari on iOS. The map has been heavily used over the course of two or three days with this change to verify that it resolves previously-seen timing problems.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly."},"comment":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/comments/236186049","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/2542#issuecomment-236186049","issue_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/2542","id":236186049,"user":{"login":"invisiblek","id":328840,"avatar_url":"https://avatars.githubusercontent.com/u/328840?v=3","gravatar_id":"","url":"https://api.github.com/users/invisiblek","html_url":"https://github.com/invisiblek","followers_url":"https://api.github.com/users/invisiblek/followers","following_url":"https://api.github.com/users/invisiblek/following{/other_user}","gists_url":"https://api.github.com/users/invisiblek/gists{/gist_id}","starred_url":"https://api.github.com/users/invisiblek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invisiblek/subscriptions","organizations_url":"https://api.github.com/users/invisiblek/orgs","repos_url":"https://api.github.com/users/invisiblek/repos","events_url":"https://api.github.com/users/invisiblek/events{/privacy}","received_events_url":"https://api.github.com/users/invisiblek/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T13:53:15Z","updated_at":"2016-07-29T13:53:15Z","body":"We're not going back to this. Removing this made my map load consistently and I haven't had the issue since."}}
{"actor":{"display_login":"invisiblek"}}