{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/scrooge/pulls/comments/62708274","id":62708274,"diff_hunk":"@@ -14,3 +14,6 @@ addSbtPlugin(\"net.virtual-void\" % \"sbt-dependency-graph\" % \"0.8.2\")\n addSbtPlugin(\"org.scoverage\" % \"sbt-coveralls\" % \"1.0.0\")\n addSbtPlugin(\"org.scoverage\" % \"sbt-scoverage\" % \"1.2.0\")\n addSbtPlugin(\"pl.project13.scala\" % \"sbt-jmh\" % \"0.2.2\")\n+\n+libraryDependencies += \"org.scala-sbt\" % \"scripted-plugin\" % sbtVersion.value","path":"project/plugins.sbt","position":5,"original_position":5,"commit_id":"d5aa29c7197ccdbcbc944026b8c7c295fbaf893f","original_commit_id":"d5aa29c7197ccdbcbc944026b8c7c295fbaf893f","user":{"login":"kevinoliver","id":347229,"avatar_url":"https://avatars.githubusercontent.com/u/347229?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinoliver","html_url":"https://github.com/kevinoliver","followers_url":"https://api.github.com/users/kevinoliver/followers","following_url":"https://api.github.com/users/kevinoliver/following{/other_user}","gists_url":"https://api.github.com/users/kevinoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinoliver/subscriptions","organizations_url":"https://api.github.com/users/kevinoliver/orgs","repos_url":"https://api.github.com/users/kevinoliver/repos","events_url":"https://api.github.com/users/kevinoliver/events{/privacy}","received_events_url":"https://api.github.com/users/kevinoliver/received_events","type":"User","site_admin":false},"body":"i see. ok lets leave them bundled.","created_at":"2016-05-10T16:47:29Z","updated_at":"2016-05-10T16:47:30Z","html_url":"https://github.com/twitter/scrooge/pull/234#discussion_r62708274","pull_request_url":"https://api.github.com/repos/twitter/scrooge/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/comments/62708274"},"html":{"href":"https://github.com/twitter/scrooge/pull/234#discussion_r62708274"},"pull_request":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/scrooge/pulls/234","id":69246868,"html_url":"https://github.com/twitter/scrooge/pull/234","diff_url":"https://github.com/twitter/scrooge/pull/234.diff","patch_url":"https://github.com/twitter/scrooge/pull/234.patch","issue_url":"https://api.github.com/repos/twitter/scrooge/issues/234","number":234,"state":"open","locked":false,"title":"modify thrift output folder to prevent clashing with other plugins","user":{"login":"joprice","id":2175555,"avatar_url":"https://avatars.githubusercontent.com/u/2175555?v=3","gravatar_id":"","url":"https://api.github.com/users/joprice","html_url":"https://github.com/joprice","followers_url":"https://api.github.com/users/joprice/followers","following_url":"https://api.github.com/users/joprice/following{/other_user}","gists_url":"https://api.github.com/users/joprice/gists{/gist_id}","starred_url":"https://api.github.com/users/joprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joprice/subscriptions","organizations_url":"https://api.github.com/users/joprice/orgs","repos_url":"https://api.github.com/users/joprice/repos","events_url":"https://api.github.com/users/joprice/events{/privacy}","received_events_url":"https://api.github.com/users/joprice/received_events","type":"User","site_admin":false},"body":"The current default for `scroogeThriftOutputFolder` causes compilation errors when used alongside other sbt plugins that generate source, the most common being sbt-buildinfo. This solves it by generating the code in a subfolder of the generated sources folder. This also adds scripted setup to test the sbt plugin. The test can be run with `scrooge-sbt-plugin/scripted`.","created_at":"2016-05-07T16:55:50Z","updated_at":"2016-05-10T16:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6170787efb41d6b7255a7530852038f30ec09df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/scrooge/pulls/234/commits","review_comments_url":"https://api.github.com/repos/twitter/scrooge/pulls/234/comments","review_comment_url":"https://api.github.com/repos/twitter/scrooge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/scrooge/issues/234/comments","statuses_url":"https://api.github.com/repos/twitter/scrooge/statuses/d5aa29c7197ccdbcbc944026b8c7c295fbaf893f","head":{"label":"joprice:defaultOutputFolder","ref":"defaultOutputFolder","sha":"d5aa29c7197ccdbcbc944026b8c7c295fbaf893f","user":{"login":"joprice","id":2175555,"avatar_url":"https://avatars.githubusercontent.com/u/2175555?v=3","gravatar_id":"","url":"https://api.github.com/users/joprice","html_url":"https://github.com/joprice","followers_url":"https://api.github.com/users/joprice/followers","following_url":"https://api.github.com/users/joprice/following{/other_user}","gists_url":"https://api.github.com/users/joprice/gists{/gist_id}","starred_url":"https://api.github.com/users/joprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joprice/subscriptions","organizations_url":"https://api.github.com/users/joprice/orgs","repos_url":"https://api.github.com/users/joprice/repos","events_url":"https://api.github.com/users/joprice/events{/privacy}","received_events_url":"https://api.github.com/users/joprice/received_events","type":"User","site_admin":false},"repo":{"id":58272650,"name":"scrooge","full_name":"joprice/scrooge","owner":{"login":"joprice","id":2175555,"avatar_url":"https://avatars.githubusercontent.com/u/2175555?v=3","gravatar_id":"","url":"https://api.github.com/users/joprice","html_url":"https://github.com/joprice","followers_url":"https://api.github.com/users/joprice/followers","following_url":"https://api.github.com/users/joprice/following{/other_user}","gists_url":"https://api.github.com/users/joprice/gists{/gist_id}","starred_url":"https://api.github.com/users/joprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joprice/subscriptions","organizations_url":"https://api.github.com/users/joprice/orgs","repos_url":"https://api.github.com/users/joprice/repos","events_url":"https://api.github.com/users/joprice/events{/privacy}","received_events_url":"https://api.github.com/users/joprice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joprice/scrooge","description":"A Thrift parser/generator","fork":true,"url":"https://api.github.com/repos/joprice/scrooge","forks_url":"https://api.github.com/repos/joprice/scrooge/forks","keys_url":"https://api.github.com/repos/joprice/scrooge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joprice/scrooge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joprice/scrooge/teams","hooks_url":"https://api.github.com/repos/joprice/scrooge/hooks","issue_events_url":"https://api.github.com/repos/joprice/scrooge/issues/events{/number}","events_url":"https://api.github.com/repos/joprice/scrooge/events","assignees_url":"https://api.github.com/repos/joprice/scrooge/assignees{/user}","branches_url":"https://api.github.com/repos/joprice/scrooge/branches{/branch}","tags_url":"https://api.github.com/repos/joprice/scrooge/tags","blobs_url":"https://api.github.com/repos/joprice/scrooge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joprice/scrooge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joprice/scrooge/git/refs{/sha}","trees_url":"https://api.github.com/repos/joprice/scrooge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joprice/scrooge/statuses/{sha}","languages_url":"https://api.github.com/repos/joprice/scrooge/languages","stargazers_url":"https://api.github.com/repos/joprice/scrooge/stargazers","contributors_url":"https://api.github.com/repos/joprice/scrooge/contributors","subscribers_url":"https://api.github.com/repos/joprice/scrooge/subscribers","subscription_url":"https://api.github.com/repos/joprice/scrooge/subscription","commits_url":"https://api.github.com/repos/joprice/scrooge/commits{/sha}","git_commits_url":"https://api.github.com/repos/joprice/scrooge/git/commits{/sha}","comments_url":"https://api.github.com/repos/joprice/scrooge/comments{/number}","issue_comment_url":"https://api.github.com/repos/joprice/scrooge/issues/comments{/number}","contents_url":"https://api.github.com/repos/joprice/scrooge/contents/{+path}","compare_url":"https://api.github.com/repos/joprice/scrooge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joprice/scrooge/merges","archive_url":"https://api.github.com/repos/joprice/scrooge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joprice/scrooge/downloads","issues_url":"https://api.github.com/repos/joprice/scrooge/issues{/number}","pulls_url":"https://api.github.com/repos/joprice/scrooge/pulls{/number}","milestones_url":"https://api.github.com/repos/joprice/scrooge/milestones{/number}","notifications_url":"https://api.github.com/repos/joprice/scrooge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joprice/scrooge/labels{/name}","releases_url":"https://api.github.com/repos/joprice/scrooge/releases{/id}","deployments_url":"https://api.github.com/repos/joprice/scrooge/deployments","created_at":"2016-05-07T15:46:08Z","updated_at":"2016-05-07T15:46:11Z","pushed_at":"2016-05-07T16:54:39Z","git_url":"git://github.com/joprice/scrooge.git","ssh_url":"git@github.com:joprice/scrooge.git","clone_url":"https://github.com/joprice/scrooge.git","svn_url":"https://github.com/joprice/scrooge","homepage":"http://twitter.github.io/scrooge/","size":16804,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"82087341d3e80f1b6c26ee5ad8ce224341e473b5","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":2249288,"name":"scrooge","full_name":"twitter/scrooge","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scrooge","description":"A Thrift parser/generator","fork":false,"url":"https://api.github.com/repos/twitter/scrooge","forks_url":"https://api.github.com/repos/twitter/scrooge/forks","keys_url":"https://api.github.com/repos/twitter/scrooge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scrooge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scrooge/teams","hooks_url":"https://api.github.com/repos/twitter/scrooge/hooks","issue_events_url":"https://api.github.com/repos/twitter/scrooge/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scrooge/events","assignees_url":"https://api.github.com/repos/twitter/scrooge/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scrooge/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scrooge/tags","blobs_url":"https://api.github.com/repos/twitter/scrooge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scrooge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scrooge/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scrooge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scrooge/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scrooge/languages","stargazers_url":"https://api.github.com/repos/twitter/scrooge/stargazers","contributors_url":"https://api.github.com/repos/twitter/scrooge/contributors","subscribers_url":"https://api.github.com/repos/twitter/scrooge/subscribers","subscription_url":"https://api.github.com/repos/twitter/scrooge/subscription","commits_url":"https://api.github.com/repos/twitter/scrooge/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scrooge/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scrooge/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scrooge/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scrooge/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scrooge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scrooge/merges","archive_url":"https://api.github.com/repos/twitter/scrooge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scrooge/downloads","issues_url":"https://api.github.com/repos/twitter/scrooge/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scrooge/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scrooge/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scrooge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scrooge/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scrooge/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/scrooge/deployments","created_at":"2011-08-22T15:17:18Z","updated_at":"2016-05-08T15:07:18Z","pushed_at":"2016-05-09T20:01:48Z","git_url":"git://github.com/twitter/scrooge.git","ssh_url":"git@github.com:twitter/scrooge.git","clone_url":"https://github.com/twitter/scrooge.git","svn_url":"https://github.com/twitter/scrooge","homepage":"http://twitter.github.io/scrooge/","size":18708,"stargazers_count":471,"watchers_count":471,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":158,"mirror_url":null,"open_issues_count":63,"forks":158,"open_issues":63,"watchers":471,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/234"},"html":{"href":"https://github.com/twitter/scrooge/pull/234"},"issue":{"href":"https://api.github.com/repos/twitter/scrooge/issues/234"},"comments":{"href":"https://api.github.com/repos/twitter/scrooge/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/scrooge/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/scrooge/statuses/d5aa29c7197ccdbcbc944026b8c7c295fbaf893f"}}}}