{"action":"closed","number":10176,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10176","id":87332628,"html_url":"https://github.com/facebook/react-native/pull/10176","diff_url":"https://github.com/facebook/react-native/pull/10176.diff","patch_url":"https://github.com/facebook/react-native/pull/10176.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10176","number":10176,"state":"closed","locked":false,"title":"[Docs] Updates Swift @objc export for recent Swift versions","user":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"body":"As of Swift 3, [Swift converts Objective-C API names based on parameters](https://github.com/apple/swift-evolution/blob/master/proposals/0005-objective-c-name-translation.md), so the docs should explicitly declare what the Objective-C API is (because it's also used in the JavaScript side too).\r\n\r\nAn alternative to this would be to update the Objective-C and JavaScript calls to be `addEventWithName:location:date:` / `addEventWithName()` based on the default Swift API, but I think the approach in the PR is most correct here.","created_at":"2016-09-29T15:09:10Z","updated_at":"2016-10-11T14:44:21Z","closed_at":"2016-10-11T14:44:21Z","merged_at":null,"merge_commit_sha":"e49fb9debfc0d29350cf4cdef09520972254b04c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/10176/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/10176/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10176/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/e84088c699e383e60d6dac09459edbae283c987b","head":{"label":"notjosh:patch-2","ref":"patch-2","sha":"e84088c699e383e60d6dac09459edbae283c987b","user":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"repo":{"id":68303461,"name":"react-native","full_name":"notjosh/react-native","owner":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/notjosh/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/notjosh/react-native","forks_url":"https://api.github.com/repos/notjosh/react-native/forks","keys_url":"https://api.github.com/repos/notjosh/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/notjosh/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/notjosh/react-native/teams","hooks_url":"https://api.github.com/repos/notjosh/react-native/hooks","issue_events_url":"https://api.github.com/repos/notjosh/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/notjosh/react-native/events","assignees_url":"https://api.github.com/repos/notjosh/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/notjosh/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/notjosh/react-native/tags","blobs_url":"https://api.github.com/repos/notjosh/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/notjosh/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/notjosh/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/notjosh/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/notjosh/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/notjosh/react-native/languages","stargazers_url":"https://api.github.com/repos/notjosh/react-native/stargazers","contributors_url":"https://api.github.com/repos/notjosh/react-native/contributors","subscribers_url":"https://api.github.com/repos/notjosh/react-native/subscribers","subscription_url":"https://api.github.com/repos/notjosh/react-native/subscription","commits_url":"https://api.github.com/repos/notjosh/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/notjosh/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/notjosh/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/notjosh/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/notjosh/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/notjosh/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/notjosh/react-native/merges","archive_url":"https://api.github.com/repos/notjosh/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/notjosh/react-native/downloads","issues_url":"https://api.github.com/repos/notjosh/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/notjosh/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/notjosh/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/notjosh/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/notjosh/react-native/labels{/name}","releases_url":"https://api.github.com/repos/notjosh/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/notjosh/react-native/deployments","created_at":"2016-09-15T14:53:47Z","updated_at":"2016-09-15T14:53:57Z","pushed_at":"2016-10-11T12:11:39Z","git_url":"git://github.com/notjosh/react-native.git","ssh_url":"git@github.com:notjosh/react-native.git","clone_url":"https://github.com/notjosh/react-native.git","svn_url":"https://github.com/notjosh/react-native","homepage":"http://facebook.github.io/react-native/","size":89589,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"08e715bc9c8346764b8bf025869ee4412de1ff43","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-10-11T14:28:18Z","pushed_at":"2016-10-11T14:43:53Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":136507,"stargazers_count":38752,"watchers_count":38752,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8663,"mirror_url":null,"open_issues_count":1374,"forks":8663,"open_issues":1374,"watchers":38752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10176"},"html":{"href":"https://github.com/facebook/react-native/pull/10176"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/10176"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/10176/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10176/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10176/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/e84088c699e383e60d6dac09459edbae283c987b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"facebook-github-bot"}}