{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/1246","repository_url":"https://api.github.com/repos/octokit/octokit.net","labels_url":"https://api.github.com/repos/octokit/octokit.net/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1246/comments","events_url":"https://api.github.com/repos/octokit/octokit.net/issues/1246/events","html_url":"https://github.com/octokit/octokit.net/pull/1246","id":146228032,"number":1246,"title":"Add check of client constructor test class name","user":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2016-04-06T08:10:54Z","updated_at":"2016-04-11T14:21:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1246","html_url":"https://github.com/octokit/octokit.net/pull/1246","diff_url":"https://github.com/octokit/octokit.net/pull/1246.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1246.patch"},"body":"Refer #1231\r\n\r\nIn order to provide uniform name for constructors test classes, I've created new convention test checks  \r\nthat each client test class must contain a nested TheCtor class.\r\n\r\n- [x] Add new convention test.\r\n- [x] Fix all red tests (Rename/Add needed tests classes)\r\n- [x] Remove unused usings in modified classes.\r\n- [x] Find way to detect tests assembly in proper way.\r\n- [x] Each test class TheCtor should have method EnsuresNonNullArguments that test a client constructor against null arguments.\r\n- [x] All unused \"using\" directives in modified classes were removed in order to get code more robust.\r\n\r\nReady to any discussion about implementation of convention test ClientConstructorTests.cs, especially about GetTestConstructorsClasses method. \r\n\r\n/cc @shiftkey, @ryangribble "},"comment":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/comments/208370721","html_url":"https://github.com/octokit/octokit.net/pull/1246#issuecomment-208370721","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1246","id":208370721,"user":{"login":"devkhan","id":8049092,"avatar_url":"https://avatars.githubusercontent.com/u/8049092?v=3","gravatar_id":"","url":"https://api.github.com/users/devkhan","html_url":"https://github.com/devkhan","followers_url":"https://api.github.com/users/devkhan/followers","following_url":"https://api.github.com/users/devkhan/following{/other_user}","gists_url":"https://api.github.com/users/devkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/devkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devkhan/subscriptions","organizations_url":"https://api.github.com/users/devkhan/orgs","repos_url":"https://api.github.com/users/devkhan/repos","events_url":"https://api.github.com/users/devkhan/events{/privacy}","received_events_url":"https://api.github.com/users/devkhan/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T14:21:05Z","updated_at":"2016-04-11T14:21:05Z","body":"> There were some errors after rebase (not about merge, but about push), so I searched errors over internet and tried to fix that.\r\n\r\nThat maybe because you need to `--force` a push after a rebase (as you have effectively changed the history)."}}