{"action":"created","issue":{"url":"https://api.github.com/repos/switch-model/switch/issues/25","repository_url":"https://api.github.com/repos/switch-model/switch","labels_url":"https://api.github.com/repos/switch-model/switch/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/switch-model/switch/issues/25/comments","events_url":"https://api.github.com/repos/switch-model/switch/issues/25/events","html_url":"https://github.com/switch-model/switch/pull/25","id":160104511,"number":25,"title":"Make the handling of empty .tab files a bit stricter","user":{"login":"mseaborn","id":85055,"avatar_url":"https://avatars.githubusercontent.com/u/85055?v=3","gravatar_id":"","url":"https://api.github.com/users/mseaborn","html_url":"https://github.com/mseaborn","followers_url":"https://api.github.com/users/mseaborn/followers","following_url":"https://api.github.com/users/mseaborn/following{/other_user}","gists_url":"https://api.github.com/users/mseaborn/gists{/gist_id}","starred_url":"https://api.github.com/users/mseaborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseaborn/subscriptions","organizations_url":"https://api.github.com/users/mseaborn/orgs","repos_url":"https://api.github.com/users/mseaborn/repos","events_url":"https://api.github.com/users/mseaborn/events{/privacy}","received_events_url":"https://api.github.com/users/mseaborn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"josiahjohnston","id":1594604,"avatar_url":"https://avatars.githubusercontent.com/u/1594604?v=3","gravatar_id":"","url":"https://api.github.com/users/josiahjohnston","html_url":"https://github.com/josiahjohnston","followers_url":"https://api.github.com/users/josiahjohnston/followers","following_url":"https://api.github.com/users/josiahjohnston/following{/other_user}","gists_url":"https://api.github.com/users/josiahjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/josiahjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josiahjohnston/subscriptions","organizations_url":"https://api.github.com/users/josiahjohnston/orgs","repos_url":"https://api.github.com/users/josiahjohnston/repos","events_url":"https://api.github.com/users/josiahjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/josiahjohnston/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-06-14T06:10:44Z","updated_at":"2016-06-21T18:34:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/switch-model/switch/pulls/25","html_url":"https://github.com/switch-model/switch/pull/25","diff_url":"https://github.com/switch-model/switch/pull/25.diff","patch_url":"https://github.com/switch-model/switch/pull/25.patch"},"body":"Previously, if the first or second lines were empty, the whole of the\r\nfile was skipped (for files loaded with optional=True), even if more\r\nlines were present.\r\n\r\nInstead, only skip the file if it contains 0 or 1 lines.  Validate the\r\nheadings if they are present."},"comment":{"url":"https://api.github.com/repos/switch-model/switch/issues/comments/227531045","html_url":"https://github.com/switch-model/switch/pull/25#issuecomment-227531045","issue_url":"https://api.github.com/repos/switch-model/switch/issues/25","id":227531045,"user":{"login":"mseaborn","id":85055,"avatar_url":"https://avatars.githubusercontent.com/u/85055?v=3","gravatar_id":"","url":"https://api.github.com/users/mseaborn","html_url":"https://github.com/mseaborn","followers_url":"https://api.github.com/users/mseaborn/followers","following_url":"https://api.github.com/users/mseaborn/following{/other_user}","gists_url":"https://api.github.com/users/mseaborn/gists{/gist_id}","starred_url":"https://api.github.com/users/mseaborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseaborn/subscriptions","organizations_url":"https://api.github.com/users/mseaborn/orgs","repos_url":"https://api.github.com/users/mseaborn/repos","events_url":"https://api.github.com/users/mseaborn/events{/privacy}","received_events_url":"https://api.github.com/users/mseaborn/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T18:34:48Z","updated_at":"2016-06-21T18:34:48Z","body":"On 21 June 2016 at 11:13, Josiah Johnston <notifications@github.com> wrote:\n\n> Can you change the commit message?\n>\n> It seems like the file would also be skipped if it contained numerous\n> empty lines, or if it starts with blank lines before the headers or data\n> starts (which seems like appropriate behavior).\n>\nThat's not the case, actually.  With this change, the file won't be skipped\nif it contains numerous empty lines or if the headings line isn't the first\nline.\n\nOr did you mean 'should' rather than 'would'?\n\nArguably the code should skip past any empty lines (and lines containing\nonly whitespace) when doing this check, to match more closely\nhow pyomo/core/plugins/data/text.py processes the .tab files, since that\nalso skips empty lines.  I am planning to change it to match pyomo's\ntext.py, but in a separate follow-on change because it makes the code more\ncomplex.  Is that OK?\n\nCheers,\nMark\n"}}
{"actor":{"display_login":"mseaborn"}}