{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/64495224","id":64495224,"diff_hunk":"@@ -0,0 +1,686 @@\n+//\n+//  SFLoggerTests.m","path":"libs/SalesforceSDKCore/SalesforceSDKCore/SFLoggerTests.m","position":2,"original_position":2,"commit_id":"805fd7645e7ecbe1ea7bb4afbe9cdd33a7c6b286","original_commit_id":"805fd7645e7ecbe1ea7bb4afbe9cdd33a7c6b286","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars.githubusercontent.com/u/1820287?v=3","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"Change copyright to ```Mobile SDK``` copyright. You can copy it from one of the other files.","created_at":"2016-05-24T23:51:31Z","updated_at":"2016-05-24T23:51:31Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557#discussion_r64495224","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/64495224"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557#discussion_r64495224"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557","id":71309909,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1557","number":1557,"state":"open","locked":false,"title":"Added improved logging support and unit tests","user":{"login":"MikeNachbaur","id":609618,"avatar_url":"https://avatars.githubusercontent.com/u/609618?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeNachbaur","html_url":"https://github.com/MikeNachbaur","followers_url":"https://api.github.com/users/MikeNachbaur/followers","following_url":"https://api.github.com/users/MikeNachbaur/following{/other_user}","gists_url":"https://api.github.com/users/MikeNachbaur/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeNachbaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeNachbaur/subscriptions","organizations_url":"https://api.github.com/users/MikeNachbaur/orgs","repos_url":"https://api.github.com/users/MikeNachbaur/repos","events_url":"https://api.github.com/users/MikeNachbaur/events{/privacy}","received_events_url":"https://api.github.com/users/MikeNachbaur/received_events","type":"User","site_admin":false},"body":"This is meant to be able to use a centralized logging facility for multiple consumers of a shared Mobile SDK.  The idea is that different areas can include their own logging statements against a unique identifier, and log levels can be set to different thresholds for different areas.  For example, the log level could be cranked up for SmartStore, while other areas can be kept low.\r\n\r\nFurthermore, since these identifiers are defined by opaque strings as opposed to enums, these can be extended by multiple consumers, including the app developer themselves.  And by using a reverse-DNS naming convention, you can set the log level for multiple identifiers based on a common prefix.\r\n\r\n- Introduce the concept of a \"Logging Identifier\" to scope log statements, and set different log levels, for different areas of logic\r\n- Begin migrating to logging macros to take advantage of CocoaLumberjack's performance capabilities (e.g. levels & flag bit masks)\r\n- Replace and deprecate `context` methods, since they weren't useful\r\n- Begin migrating methods over to instances methods, instead of class methods, to improve testability\r\n- Update to a newer CocoaLumberjack allowing us to store our own private instance of DDLog, to prevent polluting the user's own instance\r\n- Improve testability and support dependency injection on the DDLog instance\r\n- Make logger types configurable\r\n- Utilize a SFLogIdentifier private class, internally, to provide future expansion support for making per-functional-area logging configuration possible.\r\n\r\nThis pull request is meant to open a discussion, and to add further enhancements as needed.  In particular I would like to hear about the methods I've marked as deprecated, as well as the handling of assertions.","created_at":"2016-05-24T23:35:00Z","updated_at":"2016-05-24T23:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebd69163da89998786420fb75694231fa4e0e016","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1557/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/805fd7645e7ecbe1ea7bb4afbe9cdd33a7c6b286","head":{"label":"MikeNachbaur:Logging","ref":"Logging","sha":"805fd7645e7ecbe1ea7bb4afbe9cdd33a7c6b286","user":{"login":"MikeNachbaur","id":609618,"avatar_url":"https://avatars.githubusercontent.com/u/609618?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeNachbaur","html_url":"https://github.com/MikeNachbaur","followers_url":"https://api.github.com/users/MikeNachbaur/followers","following_url":"https://api.github.com/users/MikeNachbaur/following{/other_user}","gists_url":"https://api.github.com/users/MikeNachbaur/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeNachbaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeNachbaur/subscriptions","organizations_url":"https://api.github.com/users/MikeNachbaur/orgs","repos_url":"https://api.github.com/users/MikeNachbaur/repos","events_url":"https://api.github.com/users/MikeNachbaur/events{/privacy}","received_events_url":"https://api.github.com/users/MikeNachbaur/received_events","type":"User","site_admin":false},"repo":{"id":43698803,"name":"SalesforceMobileSDK-iOS","full_name":"MikeNachbaur/SalesforceMobileSDK-iOS","owner":{"login":"MikeNachbaur","id":609618,"avatar_url":"https://avatars.githubusercontent.com/u/609618?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeNachbaur","html_url":"https://github.com/MikeNachbaur","followers_url":"https://api.github.com/users/MikeNachbaur/followers","following_url":"https://api.github.com/users/MikeNachbaur/following{/other_user}","gists_url":"https://api.github.com/users/MikeNachbaur/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeNachbaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeNachbaur/subscriptions","organizations_url":"https://api.github.com/users/MikeNachbaur/orgs","repos_url":"https://api.github.com/users/MikeNachbaur/repos","events_url":"https://api.github.com/users/MikeNachbaur/events{/privacy}","received_events_url":"https://api.github.com/users/MikeNachbaur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikeNachbaur/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/MikeNachbaur/SalesforceMobileSDK-iOS/deployments","created_at":"2015-10-05T16:39:49Z","updated_at":"2015-10-05T16:40:01Z","pushed_at":"2016-05-24T23:26:40Z","git_url":"git://github.com/MikeNachbaur/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:MikeNachbaur/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/MikeNachbaur/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/MikeNachbaur/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":312195,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:unstable","ref":"unstable","sha":"ad7aa2b9fafd59d429952422153a1087da7b9038","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2016-05-21T10:30:53Z","pushed_at":"2016-05-24T23:43:43Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":328807,"stargazers_count":327,"watchers_count":327,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"open_issues_count":24,"forks":240,"open_issues":24,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1557"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1557"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/805fd7645e7ecbe1ea7bb4afbe9cdd33a7c6b286"}}}}
{"actor":{"display_login":"bhariharan"}}