{"action":"created","comment":{"url":"https://api.github.com/repos/shoopio/shoop/pulls/comments/58037848","id":58037848,"diff_hunk":"@@ -171,6 +173,10 @@ class PlaceholderExtension(_PlaceholderManagingExtension):\n     * The body of this block is actually discarded; only the inner `column`, `row` and `plugin`\n       directives have any meaning.  (A parser-time `Layout` object is created and populated during parsing\n       of this block.)\n+    * An optional `global` parameter can be used to specify that the configuration for this placeholder\n+      should be \"global\" across different views (although currently that only applies to placeholders within\n+      the same template, i.e, if you defined the same global placeholder in different templates they will\n+      not share configuration, but an included or base template that is rendered by different views will.","path":"shoop/xtheme/parsing.py","position":43,"original_position":43,"commit_id":"f3f9844678ab64449f05b2a678978568f6f5185e","original_commit_id":"f3f9844678ab64449f05b2a678978568f6f5185e","user":{"login":"suutari-ai","id":3531281,"avatar_url":"https://avatars.githubusercontent.com/u/3531281?v=3","gravatar_id":"","url":"https://api.github.com/users/suutari-ai","html_url":"https://github.com/suutari-ai","followers_url":"https://api.github.com/users/suutari-ai/followers","following_url":"https://api.github.com/users/suutari-ai/following{/other_user}","gists_url":"https://api.github.com/users/suutari-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/suutari-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suutari-ai/subscriptions","organizations_url":"https://api.github.com/users/suutari-ai/orgs","repos_url":"https://api.github.com/users/suutari-ai/repos","events_url":"https://api.github.com/users/suutari-ai/events{/privacy}","received_events_url":"https://api.github.com/users/suutari-ai/received_events","type":"User","site_admin":false},"body":"Another point: Docstrings are rendered by Sphinx in our API documentation and should be valid ReST. The backticks are used incorrectly here (in your added parts and in the parts above it). Singly backticked items are references to a class, function, module etc. and Sphinx tries to make them links, but for things that are not references to any Python object, you should use doubly backticked text. For example:\r\n```rst\r\n...optional ``global`` parameter...\r\n...inner ``column``, ``row`` and ``plugin`` directives...\r\n...A parser-time `~shoop.xtheme.layout.Layout` object... (Note: Sphinx will render that as single\r\n                                                          word \"Layout\" which will be a link to\r\n                                                          documentation of  shoop.xtheme.layout.Layout)\r\n... see also `LayoutPartExtension` ... (objects in same module are usually resolved\r\n                                        automatically by Sphinx and don't need the full module path)\r\n```\r\n\r\nYou should check how the documentation renders out by building the HTML documentation as instructed in our README: https://github.com/shoopio/shoop/#documentation (Generated documentation for this should appear to: `doc/_build/html/api/shoop.xtheme.html` under your Shoop checkout)","created_at":"2016-03-31T11:22:39Z","updated_at":"2016-03-31T11:22:39Z","html_url":"https://github.com/shoopio/shoop/pull/399#discussion_r58037848","pull_request_url":"https://api.github.com/repos/shoopio/shoop/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/comments/58037848"},"html":{"href":"https://github.com/shoopio/shoop/pull/399#discussion_r58037848"},"pull_request":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/shoopio/shoop/pulls/399","id":64706686,"html_url":"https://github.com/shoopio/shoop/pull/399","diff_url":"https://github.com/shoopio/shoop/pull/399.diff","patch_url":"https://github.com/shoopio/shoop/pull/399.patch","issue_url":"https://api.github.com/repos/shoopio/shoop/issues/399","number":399,"state":"open","locked":false,"title":"Xtheme: Enable global placeholder type (SHOOP-2219)","user":{"login":"shawnadelic","id":5107464,"avatar_url":"https://avatars.githubusercontent.com/u/5107464?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnadelic","html_url":"https://github.com/shawnadelic","followers_url":"https://api.github.com/users/shawnadelic/followers","following_url":"https://api.github.com/users/shawnadelic/following{/other_user}","gists_url":"https://api.github.com/users/shawnadelic/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnadelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnadelic/subscriptions","organizations_url":"https://api.github.com/users/shawnadelic/orgs","repos_url":"https://api.github.com/users/shawnadelic/repos","events_url":"https://api.github.com/users/shawnadelic/events{/privacy}","received_events_url":"https://api.github.com/users/shawnadelic/received_events","type":"User","site_admin":false},"body":"Enable a ``global`` parameter for Xtheme placeholders which would store\r\na site-wite placeholder configuration.\r\n\r\nThis is done by overriding the placeholder's view name as\r\n``_XthemeGlobalView`` and should work as expected when editing,\r\nrendering, etc.\r\n\r\nCurrently, this only applies to global placeholders that are within the\r\nsame template (but might be included in other templates), so if two\r\nplaceholders are marked as ``global`` but are not in the same template\r\nthey will not share the same settings.\r\n\r\nRefs SHOOP-2219","created_at":"2016-03-30T22:18:32Z","updated_at":"2016-03-31T11:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c677949121a63b3267565d37788aaa4e149f3e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shoopio/shoop/pulls/399/commits","review_comments_url":"https://api.github.com/repos/shoopio/shoop/pulls/399/comments","review_comment_url":"https://api.github.com/repos/shoopio/shoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shoopio/shoop/issues/399/comments","statuses_url":"https://api.github.com/repos/shoopio/shoop/statuses/f3f9844678ab64449f05b2a678978568f6f5185e","head":{"label":"shawnadelic:global_placeholder","ref":"global_placeholder","sha":"f3f9844678ab64449f05b2a678978568f6f5185e","user":{"login":"shawnadelic","id":5107464,"avatar_url":"https://avatars.githubusercontent.com/u/5107464?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnadelic","html_url":"https://github.com/shawnadelic","followers_url":"https://api.github.com/users/shawnadelic/followers","following_url":"https://api.github.com/users/shawnadelic/following{/other_user}","gists_url":"https://api.github.com/users/shawnadelic/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnadelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnadelic/subscriptions","organizations_url":"https://api.github.com/users/shawnadelic/orgs","repos_url":"https://api.github.com/users/shawnadelic/repos","events_url":"https://api.github.com/users/shawnadelic/events{/privacy}","received_events_url":"https://api.github.com/users/shawnadelic/received_events","type":"User","site_admin":false},"repo":{"id":49606244,"name":"shoop","full_name":"shawnadelic/shoop","owner":{"login":"shawnadelic","id":5107464,"avatar_url":"https://avatars.githubusercontent.com/u/5107464?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnadelic","html_url":"https://github.com/shawnadelic","followers_url":"https://api.github.com/users/shawnadelic/followers","following_url":"https://api.github.com/users/shawnadelic/following{/other_user}","gists_url":"https://api.github.com/users/shawnadelic/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnadelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnadelic/subscriptions","organizations_url":"https://api.github.com/users/shawnadelic/orgs","repos_url":"https://api.github.com/users/shawnadelic/repos","events_url":"https://api.github.com/users/shawnadelic/events{/privacy}","received_events_url":"https://api.github.com/users/shawnadelic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shawnadelic/shoop","description":"E-Commerce Platform","fork":true,"url":"https://api.github.com/repos/shawnadelic/shoop","forks_url":"https://api.github.com/repos/shawnadelic/shoop/forks","keys_url":"https://api.github.com/repos/shawnadelic/shoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shawnadelic/shoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shawnadelic/shoop/teams","hooks_url":"https://api.github.com/repos/shawnadelic/shoop/hooks","issue_events_url":"https://api.github.com/repos/shawnadelic/shoop/issues/events{/number}","events_url":"https://api.github.com/repos/shawnadelic/shoop/events","assignees_url":"https://api.github.com/repos/shawnadelic/shoop/assignees{/user}","branches_url":"https://api.github.com/repos/shawnadelic/shoop/branches{/branch}","tags_url":"https://api.github.com/repos/shawnadelic/shoop/tags","blobs_url":"https://api.github.com/repos/shawnadelic/shoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shawnadelic/shoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shawnadelic/shoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/shawnadelic/shoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shawnadelic/shoop/statuses/{sha}","languages_url":"https://api.github.com/repos/shawnadelic/shoop/languages","stargazers_url":"https://api.github.com/repos/shawnadelic/shoop/stargazers","contributors_url":"https://api.github.com/repos/shawnadelic/shoop/contributors","subscribers_url":"https://api.github.com/repos/shawnadelic/shoop/subscribers","subscription_url":"https://api.github.com/repos/shawnadelic/shoop/subscription","commits_url":"https://api.github.com/repos/shawnadelic/shoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/shawnadelic/shoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/shawnadelic/shoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/shawnadelic/shoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/shawnadelic/shoop/contents/{+path}","compare_url":"https://api.github.com/repos/shawnadelic/shoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shawnadelic/shoop/merges","archive_url":"https://api.github.com/repos/shawnadelic/shoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shawnadelic/shoop/downloads","issues_url":"https://api.github.com/repos/shawnadelic/shoop/issues{/number}","pulls_url":"https://api.github.com/repos/shawnadelic/shoop/pulls{/number}","milestones_url":"https://api.github.com/repos/shawnadelic/shoop/milestones{/number}","notifications_url":"https://api.github.com/repos/shawnadelic/shoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shawnadelic/shoop/labels{/name}","releases_url":"https://api.github.com/repos/shawnadelic/shoop/releases{/id}","deployments_url":"https://api.github.com/repos/shawnadelic/shoop/deployments","created_at":"2016-01-13T22:27:05Z","updated_at":"2016-01-13T22:27:07Z","pushed_at":"2016-03-31T00:38:32Z","git_url":"git://github.com/shawnadelic/shoop.git","ssh_url":"git@github.com:shawnadelic/shoop.git","clone_url":"https://github.com/shawnadelic/shoop.git","svn_url":"https://github.com/shawnadelic/shoop","homepage":"https://shoop.io","size":5683,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shoopio:master","ref":"master","sha":"9e7cfb624eeeeef885f704e9d408a55df2bca21d","user":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"repo":{"id":36803364,"name":"shoop","full_name":"shoopio/shoop","owner":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoopio/shoop","description":"E-Commerce Platform","fork":false,"url":"https://api.github.com/repos/shoopio/shoop","forks_url":"https://api.github.com/repos/shoopio/shoop/forks","keys_url":"https://api.github.com/repos/shoopio/shoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoopio/shoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoopio/shoop/teams","hooks_url":"https://api.github.com/repos/shoopio/shoop/hooks","issue_events_url":"https://api.github.com/repos/shoopio/shoop/issues/events{/number}","events_url":"https://api.github.com/repos/shoopio/shoop/events","assignees_url":"https://api.github.com/repos/shoopio/shoop/assignees{/user}","branches_url":"https://api.github.com/repos/shoopio/shoop/branches{/branch}","tags_url":"https://api.github.com/repos/shoopio/shoop/tags","blobs_url":"https://api.github.com/repos/shoopio/shoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoopio/shoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoopio/shoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoopio/shoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoopio/shoop/statuses/{sha}","languages_url":"https://api.github.com/repos/shoopio/shoop/languages","stargazers_url":"https://api.github.com/repos/shoopio/shoop/stargazers","contributors_url":"https://api.github.com/repos/shoopio/shoop/contributors","subscribers_url":"https://api.github.com/repos/shoopio/shoop/subscribers","subscription_url":"https://api.github.com/repos/shoopio/shoop/subscription","commits_url":"https://api.github.com/repos/shoopio/shoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoopio/shoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoopio/shoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoopio/shoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoopio/shoop/contents/{+path}","compare_url":"https://api.github.com/repos/shoopio/shoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoopio/shoop/merges","archive_url":"https://api.github.com/repos/shoopio/shoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoopio/shoop/downloads","issues_url":"https://api.github.com/repos/shoopio/shoop/issues{/number}","pulls_url":"https://api.github.com/repos/shoopio/shoop/pulls{/number}","milestones_url":"https://api.github.com/repos/shoopio/shoop/milestones{/number}","notifications_url":"https://api.github.com/repos/shoopio/shoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoopio/shoop/labels{/name}","releases_url":"https://api.github.com/repos/shoopio/shoop/releases{/id}","deployments_url":"https://api.github.com/repos/shoopio/shoop/deployments","created_at":"2015-06-03T12:53:21Z","updated_at":"2016-03-29T20:11:40Z","pushed_at":"2016-03-31T01:02:32Z","git_url":"git://github.com/shoopio/shoop.git","ssh_url":"git@github.com:shoopio/shoop.git","clone_url":"https://github.com/shoopio/shoop.git","svn_url":"https://github.com/shoopio/shoop","homepage":"https://shoop.io","size":8360,"stargazers_count":315,"watchers_count":315,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":19,"forks":123,"open_issues":19,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/399"},"html":{"href":"https://github.com/shoopio/shoop/pull/399"},"issue":{"href":"https://api.github.com/repos/shoopio/shoop/issues/399"},"comments":{"href":"https://api.github.com/repos/shoopio/shoop/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/shoopio/shoop/statuses/f3f9844678ab64449f05b2a678978568f6f5185e"}}}}