{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-hawq/issues/454","repository_url":"https://api.github.com/repos/apache/incubator-hawq","labels_url":"https://api.github.com/repos/apache/incubator-hawq/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-hawq/issues/454/comments","events_url":"https://api.github.com/repos/apache/incubator-hawq/issues/454/events","html_url":"https://github.com/apache/incubator-hawq/pull/454","id":141093162,"number":454,"title":"HAWQ-544. Fixed assertion failure in AdvanceMemoryAccountingGeneration","user":{"login":"gcaragea","id":11969373,"avatar_url":"https://avatars.githubusercontent.com/u/11969373?v=3","gravatar_id":"","url":"https://api.github.com/users/gcaragea","html_url":"https://github.com/gcaragea","followers_url":"https://api.github.com/users/gcaragea/followers","following_url":"https://api.github.com/users/gcaragea/following{/other_user}","gists_url":"https://api.github.com/users/gcaragea/gists{/gist_id}","starred_url":"https://api.github.com/users/gcaragea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcaragea/subscriptions","organizations_url":"https://api.github.com/users/gcaragea/orgs","repos_url":"https://api.github.com/users/gcaragea/repos","events_url":"https://api.github.com/users/gcaragea/events{/privacy}","received_events_url":"https://api.github.com/users/gcaragea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-15T20:46:23Z","updated_at":"2016-03-16T05:26:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-hawq/pulls/454","html_url":"https://github.com/apache/incubator-hawq/pull/454","diff_url":"https://github.com/apache/incubator-hawq/pull/454.diff","patch_url":"https://github.com/apache/incubator-hawq/pull/454.patch"},"body":"Fixed assertion failure in AdvanceMemoryAccountingGeneration when we have a generation overflow\r\n\r\nIn function AdvanceMemoryAccountingGeneration, we first assign \"RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, MemoryAccountingPeakBalance);\", then we call elog if there is a generation overflow. Then we assert \"Assert(RolloverMemoryAccount->peak >= MemoryAccountingPeakBalance);\".\r\n\r\nIf elog allocates additional memory, then this causes the assertion to fail.\r\n\r\n\r\nSigned-off-by: George Caragea <caragea.work@gmail.com>"},"comment":{"url":"https://api.github.com/repos/apache/incubator-hawq/issues/comments/197159124","html_url":"https://github.com/apache/incubator-hawq/pull/454#issuecomment-197159124","issue_url":"https://api.github.com/repos/apache/incubator-hawq/issues/454","id":197159124,"user":{"login":"ictmalili","id":11565431,"avatar_url":"https://avatars.githubusercontent.com/u/11565431?v=3","gravatar_id":"","url":"https://api.github.com/users/ictmalili","html_url":"https://github.com/ictmalili","followers_url":"https://api.github.com/users/ictmalili/followers","following_url":"https://api.github.com/users/ictmalili/following{/other_user}","gists_url":"https://api.github.com/users/ictmalili/gists{/gist_id}","starred_url":"https://api.github.com/users/ictmalili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ictmalili/subscriptions","organizations_url":"https://api.github.com/users/ictmalili/orgs","repos_url":"https://api.github.com/users/ictmalili/repos","events_url":"https://api.github.com/users/ictmalili/events{/privacy}","received_events_url":"https://api.github.com/users/ictmalili/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T05:26:29Z","updated_at":"2016-03-16T05:26:29Z","body":"@gcaragea  Does this function HandleMemoryAccountingGenerationOverflow(TopMemoryContext) consumes memory? If not, I think the modification is good to me. Thanks."}}