{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/936","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/936/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/936/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/936/events","html_url":"https://github.com/publiclab/plots2/pull/936","id":186343702,"number":936,"title":"Move i18n library to bower dependencies (fix #771)","user":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars.githubusercontent.com/u/13121330?v=3","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"labels":[{"id":189438562,"url":"https://api.github.com/repos/publiclab/plots2/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2016-10-31T17:20:29Z","updated_at":"2016-11-04T03:32:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/936","html_url":"https://github.com/publiclab/plots2/pull/936","diff_url":"https://github.com/publiclab/plots2/pull/936.diff","patch_url":"https://github.com/publiclab/plots2/pull/936.patch"},"body":"Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!\r\n\r\n* [x] all tests pass -- `rake test:all`\r\n* [x] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)\r\n* [x] pull request is descriptively named with #number reference back to original issue\r\n* [ ] if possible, multiple commits squashed if they're smaller changes\r\n* [ ] reviewed/confirmed/tested by another contributor or maintainer\r\n* [ ] `schema.rb.example` has been updated if any database migrations were added\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.\r\n\r\nThanks!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/258337207","html_url":"https://github.com/publiclab/plots2/pull/936#issuecomment-258337207","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/936","id":258337207,"user":{"login":"jywarren","id":24359,"avatar_url":"https://avatars.githubusercontent.com/u/24359?v=3","gravatar_id":"","url":"https://api.github.com/users/jywarren","html_url":"https://github.com/jywarren","followers_url":"https://api.github.com/users/jywarren/followers","following_url":"https://api.github.com/users/jywarren/following{/other_user}","gists_url":"https://api.github.com/users/jywarren/gists{/gist_id}","starred_url":"https://api.github.com/users/jywarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jywarren/subscriptions","organizations_url":"https://api.github.com/users/jywarren/orgs","repos_url":"https://api.github.com/users/jywarren/repos","events_url":"https://api.github.com/users/jywarren/events{/privacy}","received_events_url":"https://api.github.com/users/jywarren/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T03:32:55Z","updated_at":"2016-11-04T03:32:55Z","body":"Hi, yes, I do mean a javascript test, thanks! Yes, you can add it to\nplots2_spec.js, that works fine. Super!\n\nOn Nov 3, 2016 11:27 PM, \"Ujjwal Sharma\" <notifications@github.com> wrote:\n\n> @jywarren <https://github.com/jywarren> Tried testing it manually, worked\n> perfectly (I don't know German that well, but it did translate the page)\n> [image: screenshot from 2016-11-04 08 36 45]\n> <https://cloud.githubusercontent.com/assets/13121330/19993222/053a1d54-a26a-11e6-819a-5e3324e25251.png>\n>\n> Also, you mentioned something about adding an integration test:\n>\n> expect(I18n.t('js.dashboard.selected_updates')).toBe('Selected updates')\n>\n> Rails has a test for i18n, but looking at it, it looks like a JavaScript\n> test.\n>\n> The spec/javascripts/ directory has three subdirectories, fixtures/,\n> helpers/ and support/ are the three tests outside the integration tests?\n> Do I make a new spec, or do I add this test to plots2_spec.js?\n>\n> Thanks\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/publiclab/plots2/pull/936#issuecomment-258336619>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AABfJ-9S-yrxHozvbQfWn11-PYzhIwLRks5q6qYNgaJpZM4KlRaD>\n> .\n>\n"}}
{"actor":{"display_login":"jywarren"}}