{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/6136","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/6136/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/6136/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/6136/events","html_url":"https://github.com/Microsoft/vscode/pull/6136","id":153266041,"number":6136,"title":"Improve Open in Terminal in Mac","user":{"login":"sijad","id":7693001,"avatar_url":"https://avatars.githubusercontent.com/u/7693001?v=3","gravatar_id":"","url":"https://api.github.com/users/sijad","html_url":"https://github.com/sijad","followers_url":"https://api.github.com/users/sijad/followers","following_url":"https://api.github.com/users/sijad/following{/other_user}","gists_url":"https://api.github.com/users/sijad/gists{/gist_id}","starred_url":"https://api.github.com/users/sijad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijad/subscriptions","organizations_url":"https://api.github.com/users/sijad/orgs","repos_url":"https://api.github.com/users/sijad/repos","events_url":"https://api.github.com/users/sijad/events{/privacy}","received_events_url":"https://api.github.com/users/sijad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/vscode/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/17","html_url":"https://github.com/Microsoft/vscode/milestones/May%202016","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/17/labels","id":1716950,"number":17,"title":"May 2016","description":"","creator":{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars.githubusercontent.com/u/1931590?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"open_issues":105,"closed_issues":120,"state":"open","created_at":"2016-04-19T13:15:12Z","updated_at":"2016-05-17T16:29:35Z","due_on":"2016-05-28T22:00:00Z","closed_at":null},"comments":5,"created_at":"2016-05-05T16:11:37Z","updated_at":"2016-05-17T19:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/6136","html_url":"https://github.com/Microsoft/vscode/pull/6136","diff_url":"https://github.com/Microsoft/vscode/pull/6136.diff","patch_url":"https://github.com/Microsoft/vscode/pull/6136.patch"},"body":"This also fixes #391 \r\n\r\nTested in `Mac OS X 10.11.4 (15E65)`\r\nWith `Terminal Version 2.6.1 (361.1)` and `iTerm2 Build 2.1.4`\r\n\r\n`DEFAULT_TERMINAL_MAC` also can be set as `terminal.app` or even `terminal` but I can't test if that works with older version of `open` command in previous Mac OS"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/219827837","html_url":"https://github.com/Microsoft/vscode/pull/6136#issuecomment-219827837","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/6136","id":219827837,"user":{"login":"weinand","id":1898161,"avatar_url":"https://avatars.githubusercontent.com/u/1898161?v=3","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T19:30:40Z","updated_at":"2016-05-17T19:30:40Z","body":"@sijad thanks for the PR. \r\n\r\nCould you please provide some details about your improvements to 'Open in Terminal' on OS X.\r\n\r\nI quickly reviewed the code and noticed that you have removed the AppleScripts that try to reuse the same terminal if it is not already running a command. Without that functionality, every 'Open in Terminal' creates a new Terminal window which quickly clutter the desktop."}}