{"action":"created","issue":{"url":"https://api.github.com/repos/SciTools/iris/issues/2235","repository_url":"https://api.github.com/repos/SciTools/iris","labels_url":"https://api.github.com/repos/SciTools/iris/issues/2235/labels{/name}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/2235/comments","events_url":"https://api.github.com/repos/SciTools/iris/issues/2235/events","html_url":"https://github.com/SciTools/iris/pull/2235","id":187001045,"number":2235,"title":"Handling depth_below_land_surface, ensemble at NCMRWF ","user":{"login":"arulalant","id":1246493,"avatar_url":"https://avatars.githubusercontent.com/u/1246493?v=3","gravatar_id":"","url":"https://api.github.com/users/arulalant","html_url":"https://github.com/arulalant","followers_url":"https://api.github.com/users/arulalant/followers","following_url":"https://api.github.com/users/arulalant/following{/other_user}","gists_url":"https://api.github.com/users/arulalant/gists{/gist_id}","starred_url":"https://api.github.com/users/arulalant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arulalant/subscriptions","organizations_url":"https://api.github.com/users/arulalant/orgs","repos_url":"https://api.github.com/users/arulalant/repos","events_url":"https://api.github.com/users/arulalant/events{/privacy}","received_events_url":"https://api.github.com/users/arulalant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-03T08:34:42Z","updated_at":"2016-11-10T16:04:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/2235","html_url":"https://github.com/SciTools/iris/pull/2235","diff_url":"https://github.com/SciTools/iris/pull/2235.diff","patch_url":"https://github.com/SciTools/iris/pull/2235.patch"},"body":"Hai @marqh ,\r\n\r\nThis is Arulalan.T from NCMRWF. I made few files changes which are essentials to handle axis like depth_below_land_surface, ensembles, and other important process type codes while loading/writing cubes from/into grib2 files. \r\n\r\nI tested this changes in conda installation. You may merge these changes in the master branch, which may be needed for other operational centres.\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/SciTools/iris/issues/comments/259729716","html_url":"https://github.com/SciTools/iris/pull/2235#issuecomment-259729716","issue_url":"https://api.github.com/repos/SciTools/iris/issues/2235","id":259729716,"user":{"login":"marqh","id":1557321,"avatar_url":"https://avatars.githubusercontent.com/u/1557321?v=3","gravatar_id":"","url":"https://api.github.com/users/marqh","html_url":"https://github.com/marqh","followers_url":"https://api.github.com/users/marqh/followers","following_url":"https://api.github.com/users/marqh/following{/other_user}","gists_url":"https://api.github.com/users/marqh/gists{/gist_id}","starred_url":"https://api.github.com/users/marqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marqh/subscriptions","organizations_url":"https://api.github.com/users/marqh/orgs","repos_url":"https://api.github.com/users/marqh/repos","events_url":"https://api.github.com/users/marqh/events{/privacy}","received_events_url":"https://api.github.com/users/marqh/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T16:04:01Z","updated_at":"2016-11-10T16:04:01Z","body":"Hello @arulalant \r\n\r\nmany thanks for these updates.  I see that you are providing numerous pieces of functionality.\r\n\r\nWe have recently broken out the GRIB Iris interface into its own module\r\nhttps://github.com/scitools/iris-grib\r\n\r\nat Iris v1.11 the Iris internal GRIB interface is being deprecated and all development is taking place in iris-grib\r\n\r\ndo you have iris_grib available?\r\niris 1.10 will use iris_grib if it is available.  you can install both of these from the scitools channel, using conda, if that is helpful.\r\n\r\n\r\nI have looked at your changes and it looks like some of the functionality is already available in iris_grib, including PDT1 and PDT11 loading\r\n\r\nThe thing which jumps out as not included is the new fixed surfaces in lib/iris/fileformats/grib/_load_convert.py \r\n\r\nit would be great to see a pull request against iris_grib for these.  are you happy to raise this?\r\n\r\nthe round changes and identifier changes in _save_rules require some more thought.  We would not adopt these changes as the only behaviour, the missing value behaviour needs to be maintained.  These would need to be handled by metadata switches or elsewhere\r\n\r\nPlease may you consider putting these onto a separate pull request on iris_grib, so we can discuss them further?\r\n\r\nThe load_rules are deprecated and do not appear in iris_grib, so these changes should not be required, I think\r\n\r\nplease let me know of any questions around this (i have covered many topics) \r\nwe can follow up on all of these and more as soon as is convenient for you\r\n\r\nthank you\r\nmark"}}
{"actor":{"display_login":"marqh"}}