{"action":"closed","number":284,"pull_request":{"url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284","id":83001798,"html_url":"https://github.com/aspnet/JavaScriptServices/pull/284","diff_url":"https://github.com/aspnet/JavaScriptServices/pull/284.diff","patch_url":"https://github.com/aspnet/JavaScriptServices/pull/284.patch","issue_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/284","number":284,"state":"closed","locked":false,"title":"Make the Webpack Dependency in the aspnet-webpack NPM Package a Peer Dependency","user":{"login":"thoughtentity","id":208549,"avatar_url":"https://avatars.githubusercontent.com/u/208549?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtentity","html_url":"https://github.com/thoughtentity","followers_url":"https://api.github.com/users/thoughtentity/followers","following_url":"https://api.github.com/users/thoughtentity/following{/other_user}","gists_url":"https://api.github.com/users/thoughtentity/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtentity/subscriptions","organizations_url":"https://api.github.com/users/thoughtentity/orgs","repos_url":"https://api.github.com/users/thoughtentity/repos","events_url":"https://api.github.com/users/thoughtentity/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtentity/received_events","type":"User","site_admin":false},"body":"## Make the Webpack Dependency in the aspnet-webpack NPM Package a Peer Dependency\r\n\r\n### Proposed Changes\r\nThis pull request changes the `package.json` file in the `aspnet-webpack` npm package by moving the webpack dependency from `devDependencies` to `peerDependencies`. This makes the Webpack dependency soft and allows the `webpack-dev-middleware` in `aspnet-webpack` to pickup the Webpack version being used by the user further up the dependency chain. The pull request also adds `tsd` to `devDependencies` to allow the `aspnet-webpack`'s npm prepublish script to run without a global tsd install.\r\n\r\n> [**package.json**] Add `webpack` to `peerDependencies`\r\n\r\n```json\r\n{\r\n    \"peerDependencies\": {\r\n        \"webpack\": \"^1.13.2\" \r\n    }\r\n}\r\n```\r\n\r\n> [**package.json**] Add `tsd` to `devDependencies`\r\n\r\n```json\r\n{\r\n    \"devDependencies\": {\r\n        \"tsd\": \"0.6.5\"\r\n    }\r\n}\r\n```\r\n\r\n### Related Issues\r\nThis pull request fixes #283","created_at":"2016-08-27T23:53:00Z","updated_at":"2016-09-09T10:47:06Z","closed_at":"2016-09-09T10:47:06Z","merged_at":null,"merge_commit_sha":"4935a9c021517ea593277fd23ee5a5a8fca96d86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284/commits","review_comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284/comments","review_comment_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/284/comments","statuses_url":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/4eabd5602d35223083a0a8c4e4ed70bd504ccb6e","head":{"label":"thoughtentity:feature/webpack-peer-dependency","ref":"feature/webpack-peer-dependency","sha":"4eabd5602d35223083a0a8c4e4ed70bd504ccb6e","user":{"login":"thoughtentity","id":208549,"avatar_url":"https://avatars.githubusercontent.com/u/208549?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtentity","html_url":"https://github.com/thoughtentity","followers_url":"https://api.github.com/users/thoughtentity/followers","following_url":"https://api.github.com/users/thoughtentity/following{/other_user}","gists_url":"https://api.github.com/users/thoughtentity/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtentity/subscriptions","organizations_url":"https://api.github.com/users/thoughtentity/orgs","repos_url":"https://api.github.com/users/thoughtentity/repos","events_url":"https://api.github.com/users/thoughtentity/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtentity/received_events","type":"User","site_admin":false},"repo":{"id":66707118,"name":"JavaScriptServices","full_name":"thoughtentity/JavaScriptServices","owner":{"login":"thoughtentity","id":208549,"avatar_url":"https://avatars.githubusercontent.com/u/208549?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtentity","html_url":"https://github.com/thoughtentity","followers_url":"https://api.github.com/users/thoughtentity/followers","following_url":"https://api.github.com/users/thoughtentity/following{/other_user}","gists_url":"https://api.github.com/users/thoughtentity/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtentity/subscriptions","organizations_url":"https://api.github.com/users/thoughtentity/orgs","repos_url":"https://api.github.com/users/thoughtentity/repos","events_url":"https://api.github.com/users/thoughtentity/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtentity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thoughtentity/JavaScriptServices","description":"Microsoft ASP.NET Core JavaScript Services","fork":true,"url":"https://api.github.com/repos/thoughtentity/JavaScriptServices","forks_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/forks","keys_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/teams","hooks_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/hooks","issue_events_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/events","assignees_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/tags","blobs_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/languages","stargazers_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/stargazers","contributors_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/contributors","subscribers_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/subscribers","subscription_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/subscription","commits_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/merges","archive_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/downloads","issues_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/labels{/name}","releases_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtentity/JavaScriptServices/deployments","created_at":"2016-08-27T09:37:44Z","updated_at":"2016-08-28T04:10:35Z","pushed_at":"2016-08-27T11:20:17Z","git_url":"git://github.com/thoughtentity/JavaScriptServices.git","ssh_url":"git@github.com:thoughtentity/JavaScriptServices.git","clone_url":"https://github.com/thoughtentity/JavaScriptServices.git","svn_url":"https://github.com/thoughtentity/JavaScriptServices","homepage":"","size":3819,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"eed4d8c2119fc75aea95b7b45bb2cbefa0e5277a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":45365298,"name":"JavaScriptServices","full_name":"aspnet/JavaScriptServices","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/JavaScriptServices","description":"Microsoft ASP.NET Core JavaScript Services","fork":false,"url":"https://api.github.com/repos/aspnet/JavaScriptServices","forks_url":"https://api.github.com/repos/aspnet/JavaScriptServices/forks","keys_url":"https://api.github.com/repos/aspnet/JavaScriptServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/JavaScriptServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/JavaScriptServices/teams","hooks_url":"https://api.github.com/repos/aspnet/JavaScriptServices/hooks","issue_events_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/JavaScriptServices/events","assignees_url":"https://api.github.com/repos/aspnet/JavaScriptServices/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/JavaScriptServices/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/JavaScriptServices/tags","blobs_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/JavaScriptServices/languages","stargazers_url":"https://api.github.com/repos/aspnet/JavaScriptServices/stargazers","contributors_url":"https://api.github.com/repos/aspnet/JavaScriptServices/contributors","subscribers_url":"https://api.github.com/repos/aspnet/JavaScriptServices/subscribers","subscription_url":"https://api.github.com/repos/aspnet/JavaScriptServices/subscription","commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/JavaScriptServices/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/JavaScriptServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/JavaScriptServices/merges","archive_url":"https://api.github.com/repos/aspnet/JavaScriptServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/JavaScriptServices/downloads","issues_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/JavaScriptServices/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/JavaScriptServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/JavaScriptServices/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/JavaScriptServices/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/deployments","created_at":"2015-11-02T01:24:11Z","updated_at":"2016-09-08T23:19:09Z","pushed_at":"2016-09-09T10:38:14Z","git_url":"git://github.com/aspnet/JavaScriptServices.git","ssh_url":"git@github.com:aspnet/JavaScriptServices.git","clone_url":"https://github.com/aspnet/JavaScriptServices.git","svn_url":"https://github.com/aspnet/JavaScriptServices","homepage":"","size":4783,"stargazers_count":857,"watchers_count":857,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":24,"forks":134,"open_issues":24,"watchers":857,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284"},"html":{"href":"https://github.com/aspnet/JavaScriptServices/pull/284"},"issue":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/284"},"comments":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/4eabd5602d35223083a0a8c4e4ed70bd504ccb6e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"SteveSandersonMS"}}