{"action":"opened","number":408,"pull_request":{"url":"https://api.github.com/repos/PecanProject/bety/pulls/408","id":68584553,"html_url":"https://github.com/PecanProject/bety/pull/408","diff_url":"https://github.com/PecanProject/bety/pull/408.diff","patch_url":"https://github.com/PecanProject/bety/pull/408.patch","issue_url":"https://api.github.com/repos/PecanProject/bety/issues/408","number":408,"state":"open","locked":false,"title":"Robkooper cluster pecan 629 modified","user":{"login":"gsrohde","id":1706896,"avatar_url":"https://avatars.githubusercontent.com/u/1706896?v=3","gravatar_id":"","url":"https://api.github.com/users/gsrohde","html_url":"https://github.com/gsrohde","followers_url":"https://api.github.com/users/gsrohde/followers","following_url":"https://api.github.com/users/gsrohde/following{/other_user}","gists_url":"https://api.github.com/users/gsrohde/gists{/gist_id}","starred_url":"https://api.github.com/users/gsrohde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsrohde/subscriptions","organizations_url":"https://api.github.com/users/gsrohde/orgs","repos_url":"https://api.github.com/users/gsrohde/repos","events_url":"https://api.github.com/users/gsrohde/events{/privacy}","received_events_url":"https://api.github.com/users/gsrohde/received_events","type":"User","site_admin":false},"body":"Comments on pull request\r\n\r\n* `Cluster#to_s` returned `hostname`, which throws a method missing error.  I made it return `name`.\r\n* I made several changes to the migration.\r\n * I added three foreign-key constraints.\r\n * I made \"everybody\" non null.\r\n * I gave all timestamp column a default of utc_now() and these defaults are now used by the insert statements.\r\n* Changes to the AuthenticatedSystem module:\r\n * I removed references to ClustersSitesController.  These controllers don't exist and so this list items have no effect.\r\n * I added \"ClustersController.ALL\" to the admin_requirement list.  This isn't really necessary since you added the fallback to level 1 if the controller action is not found in any list, but I think the fallback option shouldn't be used except as a stopgap to programming neglect.\r\n * I modified the Clusters index view template so that the \"New Cluster\" buttons is centered to be consistent with other pages.\r\n * I added some RSpec tests having to do with authorization to do various things with clusters.\r\n\r\n\r\nQuestions\r\n\r\n* Are you really wanting to start the sequences at (1e9 * n) and not (1e9 * n) + 1?\r\n* I assume that you have reasons unrelated to clusters for adding methods #hostid, #host_start, and #host_end to Machines.  But since we have #hostid, I used it in the migration in the two setval calls to avoid repeating code.  But if there's some reason not to, change it back.","created_at":"2016-05-02T16:36:34Z","updated_at":"2016-05-02T16:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PecanProject/bety/pulls/408/commits","review_comments_url":"https://api.github.com/repos/PecanProject/bety/pulls/408/comments","review_comment_url":"https://api.github.com/repos/PecanProject/bety/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PecanProject/bety/issues/408/comments","statuses_url":"https://api.github.com/repos/PecanProject/bety/statuses/281f5aac5ad2a47fd0a0157fd6e0decb5baf2f3a","head":{"label":"PecanProject:robkooper-cluster-pecan-629-modified","ref":"robkooper-cluster-pecan-629-modified","sha":"281f5aac5ad2a47fd0a0157fd6e0decb5baf2f3a","user":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6855801,"name":"bety","full_name":"PecanProject/bety","owner":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/bety","description":"Web-interface to the Biofuel Ecophysiological Traits and Yields Database (the de-facto PEcAn database)","fork":false,"url":"https://api.github.com/repos/PecanProject/bety","forks_url":"https://api.github.com/repos/PecanProject/bety/forks","keys_url":"https://api.github.com/repos/PecanProject/bety/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/bety/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/bety/teams","hooks_url":"https://api.github.com/repos/PecanProject/bety/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/bety/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/bety/events","assignees_url":"https://api.github.com/repos/PecanProject/bety/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/bety/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/bety/tags","blobs_url":"https://api.github.com/repos/PecanProject/bety/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/bety/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/bety/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/bety/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/bety/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/bety/languages","stargazers_url":"https://api.github.com/repos/PecanProject/bety/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/bety/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/bety/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/bety/subscription","commits_url":"https://api.github.com/repos/PecanProject/bety/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/bety/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/bety/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/bety/issues/comments{/number}","contents_url":"https://api.github.com/repos/PecanProject/bety/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/bety/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/bety/merges","archive_url":"https://api.github.com/repos/PecanProject/bety/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/bety/downloads","issues_url":"https://api.github.com/repos/PecanProject/bety/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/bety/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/bety/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/bety/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/bety/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/bety/releases{/id}","deployments_url":"https://api.github.com/repos/PecanProject/bety/deployments","created_at":"2012-11-25T21:09:46Z","updated_at":"2016-02-15T20:37:03Z","pushed_at":"2016-05-02T16:32:52Z","git_url":"git://github.com/PecanProject/bety.git","ssh_url":"git@github.com:PecanProject/bety.git","clone_url":"https://github.com/PecanProject/bety.git","svn_url":"https://github.com/PecanProject/bety","homepage":"www.betydb.org","size":47579,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":121,"forks":18,"open_issues":121,"watchers":6,"default_branch":"master"}},"base":{"label":"PecanProject:robkooper-cluster-pecan-629","ref":"robkooper-cluster-pecan-629","sha":"cafdfc77b1047deae83f65f91241b250626b86a2","user":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6855801,"name":"bety","full_name":"PecanProject/bety","owner":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/bety","description":"Web-interface to the Biofuel Ecophysiological Traits and Yields Database (the de-facto PEcAn database)","fork":false,"url":"https://api.github.com/repos/PecanProject/bety","forks_url":"https://api.github.com/repos/PecanProject/bety/forks","keys_url":"https://api.github.com/repos/PecanProject/bety/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/bety/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/bety/teams","hooks_url":"https://api.github.com/repos/PecanProject/bety/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/bety/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/bety/events","assignees_url":"https://api.github.com/repos/PecanProject/bety/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/bety/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/bety/tags","blobs_url":"https://api.github.com/repos/PecanProject/bety/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/bety/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/bety/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/bety/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/bety/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/bety/languages","stargazers_url":"https://api.github.com/repos/PecanProject/bety/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/bety/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/bety/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/bety/subscription","commits_url":"https://api.github.com/repos/PecanProject/bety/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/bety/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/bety/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/bety/issues/comments{/number}","contents_url":"https://api.github.com/repos/PecanProject/bety/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/bety/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/bety/merges","archive_url":"https://api.github.com/repos/PecanProject/bety/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/bety/downloads","issues_url":"https://api.github.com/repos/PecanProject/bety/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/bety/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/bety/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/bety/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/bety/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/bety/releases{/id}","deployments_url":"https://api.github.com/repos/PecanProject/bety/deployments","created_at":"2012-11-25T21:09:46Z","updated_at":"2016-02-15T20:37:03Z","pushed_at":"2016-05-02T16:32:52Z","git_url":"git://github.com/PecanProject/bety.git","ssh_url":"git@github.com:PecanProject/bety.git","clone_url":"https://github.com/PecanProject/bety.git","svn_url":"https://github.com/PecanProject/bety","homepage":"www.betydb.org","size":47579,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":121,"forks":18,"open_issues":121,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PecanProject/bety/pulls/408"},"html":{"href":"https://github.com/PecanProject/bety/pull/408"},"issue":{"href":"https://api.github.com/repos/PecanProject/bety/issues/408"},"comments":{"href":"https://api.github.com/repos/PecanProject/bety/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/PecanProject/bety/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/PecanProject/bety/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PecanProject/bety/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/PecanProject/bety/statuses/281f5aac5ad2a47fd0a0157fd6e0decb5baf2f3a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":233,"deletions":12,"changed_files":8}}