{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33","id":61051506,"html_url":"https://github.com/jonathanKingston/ember-cli-eslint/pull/33","diff_url":"https://github.com/jonathanKingston/ember-cli-eslint/pull/33.diff","patch_url":"https://github.com/jonathanKingston/ember-cli-eslint/pull/33.patch","issue_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/33","number":33,"state":"closed","locked":false,"title":"Update to ember & ember-cli 2.3","user":{"login":"BrianSipple","id":5483853,"avatar_url":"https://avatars.githubusercontent.com/u/5483853?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"body":"This is a somewhat larger PR than #32 -- for using an updated version of eslint-config-ember -- but it arose out of my dabbling on that branch. With tests failing locally and in CI when I was trying to address #20 and #28, I figured I’d take a shot at updating to `ember-cli @ 2.3` and its related set of dependencies. (Documentation on Ember CLI releases can be found [here](https://github.com/ember-cli/ember-cli/releases).)\r\n\r\nGetting the tests themselves to pass ESLint required a few extensions to eslint-config-ember — which highlights the other effort underway to improve those defaults — but my idea here is that solidifying the structure of ember-cli-eslint will help both projects grow together.","created_at":"2016-02-29T09:48:33Z","updated_at":"2016-02-29T20:00:15Z","closed_at":"2016-02-29T20:00:15Z","merged_at":"2016-02-29T20:00:15Z","merge_commit_sha":"b23693b85881724019101ff8ff19ac8a6bb954b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33/commits","review_comments_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33/comments","review_comment_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/33/comments","statuses_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/statuses/e7dd7a4f529b454e6abf8b2ad84dec550ce7ce65","head":{"label":"BrianSipple:update-dependencies-and-ember-cli","ref":"update-dependencies-and-ember-cli","sha":"e7dd7a4f529b454e6abf8b2ad84dec550ce7ce65","user":{"login":"BrianSipple","id":5483853,"avatar_url":"https://avatars.githubusercontent.com/u/5483853?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"repo":{"id":52641932,"name":"ember-cli-eslint","full_name":"BrianSipple/ember-cli-eslint","owner":{"login":"BrianSipple","id":5483853,"avatar_url":"https://avatars.githubusercontent.com/u/5483853?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrianSipple/ember-cli-eslint","description":"ember-cli-eslint package for linting ember-cli with ESLint","fork":true,"url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint","forks_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/BrianSipple/ember-cli-eslint/deployments","created_at":"2016-02-27T00:34:48Z","updated_at":"2016-02-27T00:34:49Z","pushed_at":"2016-02-29T09:38:17Z","git_url":"git://github.com/BrianSipple/ember-cli-eslint.git","ssh_url":"git@github.com:BrianSipple/ember-cli-eslint.git","clone_url":"https://github.com/BrianSipple/ember-cli-eslint.git","svn_url":"https://github.com/BrianSipple/ember-cli-eslint","homepage":"","size":63,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jonathanKingston:master","ref":"master","sha":"2b5c5c5d9e6bfe2b038353b1d1dd57e7c2005c10","user":{"login":"jonathanKingston","id":338988,"avatar_url":"https://avatars.githubusercontent.com/u/338988?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanKingston","html_url":"https://github.com/jonathanKingston","followers_url":"https://api.github.com/users/jonathanKingston/followers","following_url":"https://api.github.com/users/jonathanKingston/following{/other_user}","gists_url":"https://api.github.com/users/jonathanKingston/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanKingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanKingston/subscriptions","organizations_url":"https://api.github.com/users/jonathanKingston/orgs","repos_url":"https://api.github.com/users/jonathanKingston/repos","events_url":"https://api.github.com/users/jonathanKingston/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanKingston/received_events","type":"User","site_admin":false},"repo":{"id":30788414,"name":"ember-cli-eslint","full_name":"jonathanKingston/ember-cli-eslint","owner":{"login":"jonathanKingston","id":338988,"avatar_url":"https://avatars.githubusercontent.com/u/338988?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanKingston","html_url":"https://github.com/jonathanKingston","followers_url":"https://api.github.com/users/jonathanKingston/followers","following_url":"https://api.github.com/users/jonathanKingston/following{/other_user}","gists_url":"https://api.github.com/users/jonathanKingston/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanKingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanKingston/subscriptions","organizations_url":"https://api.github.com/users/jonathanKingston/orgs","repos_url":"https://api.github.com/users/jonathanKingston/repos","events_url":"https://api.github.com/users/jonathanKingston/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanKingston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathanKingston/ember-cli-eslint","description":"ember-cli-eslint package for linting ember-cli with ESLint","fork":false,"url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint","forks_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/deployments","created_at":"2015-02-14T05:45:40Z","updated_at":"2016-02-28T23:33:09Z","pushed_at":"2016-02-29T20:00:14Z","git_url":"git://github.com/jonathanKingston/ember-cli-eslint.git","ssh_url":"git@github.com:jonathanKingston/ember-cli-eslint.git","clone_url":"https://github.com/jonathanKingston/ember-cli-eslint.git","svn_url":"https://github.com/jonathanKingston/ember-cli-eslint","homepage":"","size":69,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":14,"forks":12,"open_issues":14,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33"},"html":{"href":"https://github.com/jonathanKingston/ember-cli-eslint/pull/33"},"issue":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/33"},"comments":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/jonathanKingston/ember-cli-eslint/statuses/e7dd7a4f529b454e6abf8b2ad84dec550ce7ce65"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jonathanKingston","id":338988,"avatar_url":"https://avatars.githubusercontent.com/u/338988?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanKingston","html_url":"https://github.com/jonathanKingston","followers_url":"https://api.github.com/users/jonathanKingston/followers","following_url":"https://api.github.com/users/jonathanKingston/following{/other_user}","gists_url":"https://api.github.com/users/jonathanKingston/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanKingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanKingston/subscriptions","organizations_url":"https://api.github.com/users/jonathanKingston/orgs","repos_url":"https://api.github.com/users/jonathanKingston/repos","events_url":"https://api.github.com/users/jonathanKingston/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanKingston/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":215,"deletions":130,"changed_files":27}}