{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/60675436","id":60675436,"diff_hunk":"@@ -197,6 +197,24 @@ class Verifier {\n   bool spin_;\n };\n \n+class ServerBuilderSyncPluginDisabler : public ServerBuilderOption {\n+ public:\n+  void UpdateArguments(ChannelArguments* arg) GRPC_OVERRIDE {}\n+\n+  void UpdatePlugins(\n+      std::map<grpc::string, std::unique_ptr<ServerBuilderPlugin> >*\n+          plugins) GRPC_OVERRIDE {\n+    auto plugin = plugins->begin();\n+    while (plugin != plugins->end()) {\n+      if ((*plugin).second->has_synchronous_methods()) {\n+        plugins->erase(plugin++);","path":"test/cpp/end2end/async_end2end_test.cc","position":14,"original_position":14,"commit_id":"f2ecddd8006a32fad9a28eaf290739f51a45461b","original_commit_id":"f2ecddd8006a32fad9a28eaf290739f51a45461b","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"body":"The iterator will not be invalidated. erase will clear element pointed by `plugin`, while `plugin` becomes `plugin + 1`.","created_at":"2016-04-22T00:19:59Z","updated_at":"2016-04-22T00:19:59Z","html_url":"https://github.com/grpc/grpc/pull/6172#discussion_r60675436","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/6172","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/60675436"},"html":{"href":"https://github.com/grpc/grpc/pull/6172#discussion_r60675436"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6172"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/6172","id":66398582,"html_url":"https://github.com/grpc/grpc/pull/6172","diff_url":"https://github.com/grpc/grpc/pull/6172.diff","patch_url":"https://github.com/grpc/grpc/pull/6172.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/6172","number":6172,"state":"open","locked":false,"title":"Server builder plugin and server reflection","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"body":"Design doc: https://docs.google.com/a/google.com/document/d/1s0yAfMu53KAqCkrONvcbSwoivnHSdp6ybHk0ksK_QfY/edit?usp=sharing","created_at":"2016-04-13T21:57:16Z","updated_at":"2016-04-22T00:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d82ce7d30c29e5ba40f8edf39e002b93221fad4e","assignee":{"login":"yang-g","id":10122250,"avatar_url":"https://avatars.githubusercontent.com/u/10122250?v=3","gravatar_id":"","url":"https://api.github.com/users/yang-g","html_url":"https://github.com/yang-g","followers_url":"https://api.github.com/users/yang-g/followers","following_url":"https://api.github.com/users/yang-g/following{/other_user}","gists_url":"https://api.github.com/users/yang-g/gists{/gist_id}","starred_url":"https://api.github.com/users/yang-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang-g/subscriptions","organizations_url":"https://api.github.com/users/yang-g/orgs","repos_url":"https://api.github.com/users/yang-g/repos","events_url":"https://api.github.com/users/yang-g/events{/privacy}","received_events_url":"https://api.github.com/users/yang-g/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/6172/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/6172/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/6172/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/f2ecddd8006a32fad9a28eaf290739f51a45461b","head":{"label":"y-zeng:Server_reflection_DescriptorDatabse_implemetation","ref":"Server_reflection_DescriptorDatabse_implemetation","sha":"f2ecddd8006a32fad9a28eaf290739f51a45461b","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"repo":{"id":52568937,"name":"grpc","full_name":"y-zeng/grpc","owner":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/y-zeng/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/y-zeng/grpc","forks_url":"https://api.github.com/repos/y-zeng/grpc/forks","keys_url":"https://api.github.com/repos/y-zeng/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-zeng/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-zeng/grpc/teams","hooks_url":"https://api.github.com/repos/y-zeng/grpc/hooks","issue_events_url":"https://api.github.com/repos/y-zeng/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/y-zeng/grpc/events","assignees_url":"https://api.github.com/repos/y-zeng/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/y-zeng/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/y-zeng/grpc/tags","blobs_url":"https://api.github.com/repos/y-zeng/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-zeng/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-zeng/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-zeng/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-zeng/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/y-zeng/grpc/languages","stargazers_url":"https://api.github.com/repos/y-zeng/grpc/stargazers","contributors_url":"https://api.github.com/repos/y-zeng/grpc/contributors","subscribers_url":"https://api.github.com/repos/y-zeng/grpc/subscribers","subscription_url":"https://api.github.com/repos/y-zeng/grpc/subscription","commits_url":"https://api.github.com/repos/y-zeng/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-zeng/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-zeng/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-zeng/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-zeng/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/y-zeng/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-zeng/grpc/merges","archive_url":"https://api.github.com/repos/y-zeng/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-zeng/grpc/downloads","issues_url":"https://api.github.com/repos/y-zeng/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/y-zeng/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/y-zeng/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/y-zeng/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-zeng/grpc/labels{/name}","releases_url":"https://api.github.com/repos/y-zeng/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/y-zeng/grpc/deployments","created_at":"2016-02-26T01:16:00Z","updated_at":"2016-02-26T01:16:07Z","pushed_at":"2016-04-19T21:13:17Z","git_url":"git://github.com/y-zeng/grpc.git","ssh_url":"git@github.com:y-zeng/grpc.git","clone_url":"https://github.com/y-zeng/grpc.git","svn_url":"https://github.com/y-zeng/grpc","homepage":"","size":69108,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"8302c51049aca7559d4b702b1a6f949d76f2229d","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-04-21T23:47:54Z","pushed_at":"2016-04-22T00:07:47Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":183642,"stargazers_count":4771,"watchers_count":4771,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":850,"mirror_url":null,"open_issues_count":730,"forks":850,"open_issues":730,"watchers":4771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6172"},"html":{"href":"https://github.com/grpc/grpc/pull/6172"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/6172"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/6172/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6172/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6172/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/f2ecddd8006a32fad9a28eaf290739f51a45461b"}}}}