{"action":"created","comment":{"url":"https://api.github.com/repos/graalvm/truffle/pulls/comments/50688315","id":50688315,"diff_hunk":"@@ -0,0 +1,64 @@\n+/*\n+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.\n+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.\n+ *\n+ * This code is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU General Public License version 2 only, as\n+ * published by the Free Software Foundation.  Oracle designates this\n+ * particular file as subject to the \"Classpath\" exception as provided\n+ * by Oracle in the LICENSE file that accompanied this code.\n+ *\n+ * This code is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License\n+ * version 2 for more details (a copy is included in the LICENSE file that\n+ * accompanied this code).\n+ *\n+ * You should have received a copy of the GNU General Public License version\n+ * 2 along with this work; if not, write to the Free Software Foundation,\n+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n+ *\n+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA\n+ * or visit www.oracle.com if you need additional information or have any\n+ * questions.\n+ */\n+package com.oracle.truffle.api.interop;\n+\n+/**\n+ * An exception thrown if a {@link TruffleObject} does not support a {@link Message}.\n+ */\n+public final class UnsupportedMessageException extends InteropException {","path":"truffle/com.oracle.truffle.api.interop/src/com/oracle/truffle/api/interop/UnsupportedMessageException.java","position":30,"original_position":30,"commit_id":"67013f837f7e0f1c999a967b2ef5019ed7c6437e","original_commit_id":"67013f837f7e0f1c999a967b2ef5019ed7c6437e","user":{"login":"jtulach","id":1842422,"avatar_url":"https://avatars.githubusercontent.com/u/1842422?v=3","gravatar_id":"","url":"https://api.github.com/users/jtulach","html_url":"https://github.com/jtulach","followers_url":"https://api.github.com/users/jtulach/followers","following_url":"https://api.github.com/users/jtulach/following{/other_user}","gists_url":"https://api.github.com/users/jtulach/gists{/gist_id}","starred_url":"https://api.github.com/users/jtulach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtulach/subscriptions","organizations_url":"https://api.github.com/users/jtulach/orgs","repos_url":"https://api.github.com/users/jtulach/repos","events_url":"https://api.github.com/users/jtulach/events{/privacy}","received_events_url":"https://api.github.com/users/jtulach/received_events","type":"User","site_admin":false},"body":"So far the implementation throws IllegalArgumentException in case of unsupported message (especially when a Factory or Factory10 methods return null). You should probably update these places to throw this exception, right?","created_at":"2016-01-25T12:37:36Z","updated_at":"2016-01-25T12:37:36Z","html_url":"https://github.com/graalvm/truffle/pull/12#discussion_r50688315","pull_request_url":"https://api.github.com/repos/graalvm/truffle/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/comments/50688315"},"html":{"href":"https://github.com/graalvm/truffle/pull/12#discussion_r50688315"},"pull_request":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/graalvm/truffle/pulls/12","id":57056799,"html_url":"https://github.com/graalvm/truffle/pull/12","diff_url":"https://github.com/graalvm/truffle/pull/12.diff","patch_url":"https://github.com/graalvm/truffle/pull/12.patch","issue_url":"https://api.github.com/repos/graalvm/truffle/issues/12","number":12,"state":"open","locked":false,"title":"Interop: annotation processor to generate classes for message resolution","user":{"login":"grimmerm","id":9483985,"avatar_url":"https://avatars.githubusercontent.com/u/9483985?v=3","gravatar_id":"","url":"https://api.github.com/users/grimmerm","html_url":"https://github.com/grimmerm","followers_url":"https://api.github.com/users/grimmerm/followers","following_url":"https://api.github.com/users/grimmerm/following{/other_user}","gists_url":"https://api.github.com/users/grimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/grimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimmerm/subscriptions","organizations_url":"https://api.github.com/users/grimmerm/orgs","repos_url":"https://api.github.com/users/grimmerm/repos","events_url":"https://api.github.com/users/grimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/grimmerm/received_events","type":"User","site_admin":false},"body":"There is a need to simplify interop API to:\r\n- make it more type-safe\r\n- encourage exception handling\r\n- make its use less verbose\r\n","created_at":"2016-01-25T11:08:25Z","updated_at":"2016-01-25T12:37:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e5ee4759f54657608708165a878e72f22768dfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graalvm/truffle/pulls/12/commits","review_comments_url":"https://api.github.com/repos/graalvm/truffle/pulls/12/comments","review_comment_url":"https://api.github.com/repos/graalvm/truffle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graalvm/truffle/issues/12/comments","statuses_url":"https://api.github.com/repos/graalvm/truffle/statuses/67013f837f7e0f1c999a967b2ef5019ed7c6437e","head":{"label":"graalvm:interop/annotation-processor-to-generate-classes-for-message-resolution","ref":"interop/annotation-processor-to-generate-classes-for-message-resolution","sha":"67013f837f7e0f1c999a967b2ef5019ed7c6437e","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":49662222,"name":"truffle","full_name":"graalvm/truffle","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/truffle","description":"The Truffle Language Implementation Framework","fork":false,"url":"https://api.github.com/repos/graalvm/truffle","forks_url":"https://api.github.com/repos/graalvm/truffle/forks","keys_url":"https://api.github.com/repos/graalvm/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/truffle/teams","hooks_url":"https://api.github.com/repos/graalvm/truffle/hooks","issue_events_url":"https://api.github.com/repos/graalvm/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/truffle/events","assignees_url":"https://api.github.com/repos/graalvm/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/truffle/tags","blobs_url":"https://api.github.com/repos/graalvm/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/truffle/languages","stargazers_url":"https://api.github.com/repos/graalvm/truffle/stargazers","contributors_url":"https://api.github.com/repos/graalvm/truffle/contributors","subscribers_url":"https://api.github.com/repos/graalvm/truffle/subscribers","subscription_url":"https://api.github.com/repos/graalvm/truffle/subscription","commits_url":"https://api.github.com/repos/graalvm/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/truffle/merges","archive_url":"https://api.github.com/repos/graalvm/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/truffle/downloads","issues_url":"https://api.github.com/repos/graalvm/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/truffle/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/truffle/deployments","created_at":"2016-01-14T17:11:35Z","updated_at":"2016-01-21T11:16:19Z","pushed_at":"2016-01-25T12:28:35Z","git_url":"git://github.com/graalvm/truffle.git","ssh_url":"git@github.com:graalvm/truffle.git","clone_url":"https://github.com/graalvm/truffle.git","svn_url":"https://github.com/graalvm/truffle","homepage":"","size":23961,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":11,"default_branch":"master"}},"base":{"label":"graalvm:master","ref":"master","sha":"2c316d1b5691871b7a8ec3b8dce751bc00e0262e","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":49662222,"name":"truffle","full_name":"graalvm/truffle","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/truffle","description":"The Truffle Language Implementation Framework","fork":false,"url":"https://api.github.com/repos/graalvm/truffle","forks_url":"https://api.github.com/repos/graalvm/truffle/forks","keys_url":"https://api.github.com/repos/graalvm/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/truffle/teams","hooks_url":"https://api.github.com/repos/graalvm/truffle/hooks","issue_events_url":"https://api.github.com/repos/graalvm/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/truffle/events","assignees_url":"https://api.github.com/repos/graalvm/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/truffle/tags","blobs_url":"https://api.github.com/repos/graalvm/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/truffle/languages","stargazers_url":"https://api.github.com/repos/graalvm/truffle/stargazers","contributors_url":"https://api.github.com/repos/graalvm/truffle/contributors","subscribers_url":"https://api.github.com/repos/graalvm/truffle/subscribers","subscription_url":"https://api.github.com/repos/graalvm/truffle/subscription","commits_url":"https://api.github.com/repos/graalvm/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/truffle/merges","archive_url":"https://api.github.com/repos/graalvm/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/truffle/downloads","issues_url":"https://api.github.com/repos/graalvm/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/truffle/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/truffle/deployments","created_at":"2016-01-14T17:11:35Z","updated_at":"2016-01-21T11:16:19Z","pushed_at":"2016-01-25T12:28:35Z","git_url":"git://github.com/graalvm/truffle.git","ssh_url":"git@github.com:graalvm/truffle.git","clone_url":"https://github.com/graalvm/truffle.git","svn_url":"https://github.com/graalvm/truffle","homepage":"","size":23961,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/12"},"html":{"href":"https://github.com/graalvm/truffle/pull/12"},"issue":{"href":"https://api.github.com/repos/graalvm/truffle/issues/12"},"comments":{"href":"https://api.github.com/repos/graalvm/truffle/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/graalvm/truffle/statuses/67013f837f7e0f1c999a967b2ef5019ed7c6437e"}}}}