{"action":"created","comment":{"url":"https://api.github.com/repos/edgurgel/verk_web/pulls/comments/92676642","pull_request_review_id":13196728,"id":92676642,"diff_hunk":"@@ -1,33 +1,24 @@\n defmodule VerkWeb.RoomChannel do\n   use Phoenix.Channel\n+  alias VerkWeb.TrackingJobsHandler\n \n-  @doc \"\"\"\n-  Authorize socket to subscribe and broadcast events on this channel & topic\n-\n-  Possible Return Values\n-\n-  `{:ok, socket}` to authorize subscription for channel for requested topic\n-\n-  `:ignore` to deny subscription/broadcast on this channel\n-  for the requested topic\n-  \"\"\"\n+  @doc false\n   def join(\"rooms:jobs\", _, socket) do\n-    Process.flag(:trap_exit, true)\n-    send self, :stats\n-\n+    :ok = GenEvent.add_mon_handler(Verk.EventManager, {TrackingJobsHandler, self}, self)","path":"web/channels/room_channel.ex","position":20,"original_position":20,"commit_id":"e398bd2fe77315375b768601ca82c9e358a33be2","original_commit_id":"e398bd2fe77315375b768601ca82c9e358a33be2","user":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"body":"Yes we still need Verk to be running but at least the only thing that will fail is the room channel code. So it should not break any application. And Verk Web is dependent on Verk anyway (for example to show running jobs, inspect a job etc)","created_at":"2016-12-15T19:02:11Z","updated_at":"2016-12-15T19:02:11Z","html_url":"https://github.com/edgurgel/verk_web/pull/41#discussion_r92676642","pull_request_url":"https://api.github.com/repos/edgurgel/verk_web/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/comments/92676642"},"html":{"href":"https://github.com/edgurgel/verk_web/pull/41#discussion_r92676642"},"pull_request":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/edgurgel/verk_web/pulls/41","id":98114556,"html_url":"https://github.com/edgurgel/verk_web/pull/41","diff_url":"https://github.com/edgurgel/verk_web/pull/41.diff","patch_url":"https://github.com/edgurgel/verk_web/pull/41.patch","issue_url":"https://api.github.com/repos/edgurgel/verk_web/issues/41","number":41,"state":"open","locked":false,"title":"Rework TrackingJobsHandler to be per channel socket","user":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"body":"It fixes #40 \r\n\r\ncc/ @keyan @alissonsales \r\n\r\nIt won't be as efficient as having 1 handler and 1 broadcast but it should do the job till we find a better solution 👍 ","created_at":"2016-12-15T09:33:21Z","updated_at":"2016-12-15T19:02:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53bf3ec55b165e2f4e27c5834b2822b2b9748cca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edgurgel/verk_web/pulls/41/commits","review_comments_url":"https://api.github.com/repos/edgurgel/verk_web/pulls/41/comments","review_comment_url":"https://api.github.com/repos/edgurgel/verk_web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgurgel/verk_web/issues/41/comments","statuses_url":"https://api.github.com/repos/edgurgel/verk_web/statuses/e398bd2fe77315375b768601ca82c9e358a33be2","head":{"label":"edgurgel:fix-tracking-jobs-handler","ref":"fix-tracking-jobs-handler","sha":"e398bd2fe77315375b768601ca82c9e358a33be2","user":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"repo":{"id":49468199,"name":"verk_web","full_name":"edgurgel/verk_web","owner":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgurgel/verk_web","description":"Verk Dashboard powered by Phoenix","fork":false,"url":"https://api.github.com/repos/edgurgel/verk_web","forks_url":"https://api.github.com/repos/edgurgel/verk_web/forks","keys_url":"https://api.github.com/repos/edgurgel/verk_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgurgel/verk_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgurgel/verk_web/teams","hooks_url":"https://api.github.com/repos/edgurgel/verk_web/hooks","issue_events_url":"https://api.github.com/repos/edgurgel/verk_web/issues/events{/number}","events_url":"https://api.github.com/repos/edgurgel/verk_web/events","assignees_url":"https://api.github.com/repos/edgurgel/verk_web/assignees{/user}","branches_url":"https://api.github.com/repos/edgurgel/verk_web/branches{/branch}","tags_url":"https://api.github.com/repos/edgurgel/verk_web/tags","blobs_url":"https://api.github.com/repos/edgurgel/verk_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgurgel/verk_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgurgel/verk_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgurgel/verk_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgurgel/verk_web/statuses/{sha}","languages_url":"https://api.github.com/repos/edgurgel/verk_web/languages","stargazers_url":"https://api.github.com/repos/edgurgel/verk_web/stargazers","contributors_url":"https://api.github.com/repos/edgurgel/verk_web/contributors","subscribers_url":"https://api.github.com/repos/edgurgel/verk_web/subscribers","subscription_url":"https://api.github.com/repos/edgurgel/verk_web/subscription","commits_url":"https://api.github.com/repos/edgurgel/verk_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgurgel/verk_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgurgel/verk_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgurgel/verk_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgurgel/verk_web/contents/{+path}","compare_url":"https://api.github.com/repos/edgurgel/verk_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgurgel/verk_web/merges","archive_url":"https://api.github.com/repos/edgurgel/verk_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgurgel/verk_web/downloads","issues_url":"https://api.github.com/repos/edgurgel/verk_web/issues{/number}","pulls_url":"https://api.github.com/repos/edgurgel/verk_web/pulls{/number}","milestones_url":"https://api.github.com/repos/edgurgel/verk_web/milestones{/number}","notifications_url":"https://api.github.com/repos/edgurgel/verk_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgurgel/verk_web/labels{/name}","releases_url":"https://api.github.com/repos/edgurgel/verk_web/releases{/id}","deployments_url":"https://api.github.com/repos/edgurgel/verk_web/deployments","created_at":"2016-01-12T02:09:49Z","updated_at":"2016-12-14T00:23:13Z","pushed_at":"2016-12-15T09:33:21Z","git_url":"git://github.com/edgurgel/verk_web.git","ssh_url":"git@github.com:edgurgel/verk_web.git","clone_url":"https://github.com/edgurgel/verk_web.git","svn_url":"https://github.com/edgurgel/verk_web","homepage":"https://hex.pm/packages/verk_web","size":1260,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":22,"default_branch":"master"}},"base":{"label":"edgurgel:master","ref":"master","sha":"d7994a10ae89029ad3733817079d870959fdf360","user":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"repo":{"id":49468199,"name":"verk_web","full_name":"edgurgel/verk_web","owner":{"login":"edgurgel","id":30873,"avatar_url":"https://avatars.githubusercontent.com/u/30873?v=3","gravatar_id":"","url":"https://api.github.com/users/edgurgel","html_url":"https://github.com/edgurgel","followers_url":"https://api.github.com/users/edgurgel/followers","following_url":"https://api.github.com/users/edgurgel/following{/other_user}","gists_url":"https://api.github.com/users/edgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgurgel/subscriptions","organizations_url":"https://api.github.com/users/edgurgel/orgs","repos_url":"https://api.github.com/users/edgurgel/repos","events_url":"https://api.github.com/users/edgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/edgurgel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgurgel/verk_web","description":"Verk Dashboard powered by Phoenix","fork":false,"url":"https://api.github.com/repos/edgurgel/verk_web","forks_url":"https://api.github.com/repos/edgurgel/verk_web/forks","keys_url":"https://api.github.com/repos/edgurgel/verk_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgurgel/verk_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgurgel/verk_web/teams","hooks_url":"https://api.github.com/repos/edgurgel/verk_web/hooks","issue_events_url":"https://api.github.com/repos/edgurgel/verk_web/issues/events{/number}","events_url":"https://api.github.com/repos/edgurgel/verk_web/events","assignees_url":"https://api.github.com/repos/edgurgel/verk_web/assignees{/user}","branches_url":"https://api.github.com/repos/edgurgel/verk_web/branches{/branch}","tags_url":"https://api.github.com/repos/edgurgel/verk_web/tags","blobs_url":"https://api.github.com/repos/edgurgel/verk_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgurgel/verk_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgurgel/verk_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgurgel/verk_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgurgel/verk_web/statuses/{sha}","languages_url":"https://api.github.com/repos/edgurgel/verk_web/languages","stargazers_url":"https://api.github.com/repos/edgurgel/verk_web/stargazers","contributors_url":"https://api.github.com/repos/edgurgel/verk_web/contributors","subscribers_url":"https://api.github.com/repos/edgurgel/verk_web/subscribers","subscription_url":"https://api.github.com/repos/edgurgel/verk_web/subscription","commits_url":"https://api.github.com/repos/edgurgel/verk_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgurgel/verk_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgurgel/verk_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgurgel/verk_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgurgel/verk_web/contents/{+path}","compare_url":"https://api.github.com/repos/edgurgel/verk_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgurgel/verk_web/merges","archive_url":"https://api.github.com/repos/edgurgel/verk_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgurgel/verk_web/downloads","issues_url":"https://api.github.com/repos/edgurgel/verk_web/issues{/number}","pulls_url":"https://api.github.com/repos/edgurgel/verk_web/pulls{/number}","milestones_url":"https://api.github.com/repos/edgurgel/verk_web/milestones{/number}","notifications_url":"https://api.github.com/repos/edgurgel/verk_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgurgel/verk_web/labels{/name}","releases_url":"https://api.github.com/repos/edgurgel/verk_web/releases{/id}","deployments_url":"https://api.github.com/repos/edgurgel/verk_web/deployments","created_at":"2016-01-12T02:09:49Z","updated_at":"2016-12-14T00:23:13Z","pushed_at":"2016-12-15T09:33:21Z","git_url":"git://github.com/edgurgel/verk_web.git","ssh_url":"git@github.com:edgurgel/verk_web.git","clone_url":"https://github.com/edgurgel/verk_web.git","svn_url":"https://github.com/edgurgel/verk_web","homepage":"https://hex.pm/packages/verk_web","size":1260,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/41"},"html":{"href":"https://github.com/edgurgel/verk_web/pull/41"},"issue":{"href":"https://api.github.com/repos/edgurgel/verk_web/issues/41"},"comments":{"href":"https://api.github.com/repos/edgurgel/verk_web/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgurgel/verk_web/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/edgurgel/verk_web/statuses/e398bd2fe77315375b768601ca82c9e358a33be2"}}}}
{"actor":{"display_login":"edgurgel"}}