{"action":"created","issue":{"url":"https://api.github.com/repos/droolsjbpm/drools/issues/801","repository_url":"https://api.github.com/repos/droolsjbpm/drools","labels_url":"https://api.github.com/repos/droolsjbpm/drools/issues/801/labels{/name}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/issues/801/comments","events_url":"https://api.github.com/repos/droolsjbpm/drools/issues/801/events","html_url":"https://github.com/droolsjbpm/drools/pull/801","id":157713132,"number":801,"title":"[RHBRMS-2463] logical delete expired events","user":{"login":"mariofusco","id":372781,"avatar_url":"https://avatars.githubusercontent.com/u/372781?v=3","gravatar_id":"","url":"https://api.github.com/users/mariofusco","html_url":"https://github.com/mariofusco","followers_url":"https://api.github.com/users/mariofusco/followers","following_url":"https://api.github.com/users/mariofusco/following{/other_user}","gists_url":"https://api.github.com/users/mariofusco/gists{/gist_id}","starred_url":"https://api.github.com/users/mariofusco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariofusco/subscriptions","organizations_url":"https://api.github.com/users/mariofusco/orgs","repos_url":"https://api.github.com/users/mariofusco/repos","events_url":"https://api.github.com/users/mariofusco/events{/privacy}","received_events_url":"https://api.github.com/users/mariofusco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"etirelli","id":457009,"avatar_url":"https://avatars.githubusercontent.com/u/457009?v=3","gravatar_id":"","url":"https://api.github.com/users/etirelli","html_url":"https://github.com/etirelli","followers_url":"https://api.github.com/users/etirelli/followers","following_url":"https://api.github.com/users/etirelli/following{/other_user}","gists_url":"https://api.github.com/users/etirelli/gists{/gist_id}","starred_url":"https://api.github.com/users/etirelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etirelli/subscriptions","organizations_url":"https://api.github.com/users/etirelli/orgs","repos_url":"https://api.github.com/users/etirelli/repos","events_url":"https://api.github.com/users/etirelli/events{/privacy}","received_events_url":"https://api.github.com/users/etirelli/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-31T16:21:58Z","updated_at":"2016-06-03T17:04:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/801","html_url":"https://github.com/droolsjbpm/drools/pull/801","diff_url":"https://github.com/droolsjbpm/drools/pull/801.diff","patch_url":"https://github.com/droolsjbpm/drools/pull/801.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/droolsjbpm/drools/issues/comments/223635631","html_url":"https://github.com/droolsjbpm/drools/pull/801#issuecomment-223635631","issue_url":"https://api.github.com/repos/droolsjbpm/drools/issues/801","id":223635631,"user":{"login":"mariofusco","id":372781,"avatar_url":"https://avatars.githubusercontent.com/u/372781?v=3","gravatar_id":"","url":"https://api.github.com/users/mariofusco","html_url":"https://github.com/mariofusco","followers_url":"https://api.github.com/users/mariofusco/followers","following_url":"https://api.github.com/users/mariofusco/following{/other_user}","gists_url":"https://api.github.com/users/mariofusco/gists{/gist_id}","starred_url":"https://api.github.com/users/mariofusco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariofusco/subscriptions","organizations_url":"https://api.github.com/users/mariofusco/orgs","repos_url":"https://api.github.com/users/mariofusco/repos","events_url":"https://api.github.com/users/mariofusco/events{/privacy}","received_events_url":"https://api.github.com/users/mariofusco/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T17:04:51Z","updated_at":"2016-06-03T17:04:51Z","body":"@mdproctor @etirelli I found that checking for Tuple/FactHandle expiration when evaluating constraints is useless because I'm removing the RightTuples when the event is expired. Additionally I'm now retracting the FactHandle when the handle is expired and has no further pending activations https://github.com/droolsjbpm/drools/pull/801/commits/7b16ef233dacef1a031aaa54f5f622ea62f5e368#diff-5ef9b9f27ecdca2968a52455f8557919R1124\r\n\r\nThis change also fixes the original test case reported by https://issues.jboss.org/browse/DROOLS-311 so I also unignored it https://github.com/droolsjbpm/drools/pull/801/commits/7b16ef233dacef1a031aaa54f5f622ea62f5e368#diff-b3ff35a827e4a0ba8b48149df4892eaaL2963 I think this covers the not/exists scenario as asked by Edson. Also the accumulate is already covered by other tests in CepEspTest.\r\n\r\nI added another test trying to break this fix as suggested by Mark but I couldn't find any use case that doesn't work with this. Please let me know if I'm missing something here or if you think that there is some other test case that could potentially break what I've done."}}
{"actor":{"display_login":"mariofusco"}}