{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/66619359","id":66619359,"diff_hunk":"@@ -126,7 +125,7 @@ public TaskRepositoryInitializer taskRepositoryInitializerForDefaultDB(DataSourc\n \t\t@Bean\n \t\t@ConditionalOnMissingBean\n \t\tpublic TaskDefinitionRepository taskDefinitionRepository(DataSource dataSource, Server server) throws Exception {","path":"spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/config/features/TaskConfiguration.java","position":21,"original_position":21,"commit_id":"f16a9c0364536ace9c52244252d0d9f301f21da8","original_commit_id":"f16a9c0364536ace9c52244252d0d9f301f21da8","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"or if this is intentional, because this bean requires that the `Server` has been instantiated already, that intention would be clearer via `@DependsOn`... and that would make it less likely that someone deletes it at some point ;)","created_at":"2016-06-10T14:12:44Z","updated_at":"2016-06-10T14:12:44Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674#discussion_r66619359","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/66619359"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674#discussion_r66619359"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674","id":73370314,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/674","number":674,"state":"open","locked":false,"title":"Remove TaskDefinitionRepositoryFactoryBean","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":" - Use `RdbmsTaskDefinitionFactory` directly\r\n\r\nThis resolves #673","created_at":"2016-06-10T13:05:29Z","updated_at":"2016-06-10T14:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a315c49c8a9303f21f11428aeced8348d73e98","assignee":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/674/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f16a9c0364536ace9c52244252d0d9f301f21da8","head":{"label":"ilayaperumalg:remove-task-repository-factory-bean","ref":"remove-task-repository-factory-bean","sha":"f16a9c0364536ace9c52244252d0d9f301f21da8","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":40140476,"name":"spring-cloud-dataflow","full_name":"ilayaperumalg/spring-cloud-dataflow","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow","description":"","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/deployments","created_at":"2015-08-03T18:13:31Z","updated_at":"2016-03-08T08:24:30Z","pushed_at":"2016-06-10T13:05:18Z","git_url":"git://github.com/ilayaperumalg/spring-cloud-dataflow.git","ssh_url":"git@github.com:ilayaperumalg/spring-cloud-dataflow.git","clone_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow.git","svn_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow","homepage":null,"size":3951,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"baa8f3e0755af15b6e6d157a138c364928d69bee","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for data microservices, including both stream and task processing","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/deployments","created_at":"2015-07-21T20:56:11Z","updated_at":"2016-06-07T06:33:56Z","pushed_at":"2016-06-10T14:09:54Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":5733,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":123,"forks":62,"open_issues":123,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/674"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/674"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f16a9c0364536ace9c52244252d0d9f301f21da8"}}}}
{"actor":{"display_login":"markfisher"}}