{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/turbograft/pulls/comments/75737909","id":75737909,"diff_hunk":"@@ -8,6 +8,22 @@ class LegacyPagesFullPageRefreshTest < ActionDispatch::IntegrationTest\n     visit \"/legacy_pages/1\"\n   end\n \n+  def wait_until_page_has(content)\n+    finished_navigation = false\n+    while !finished_navigation","path":"test/browser/legacy_full_page_refresh_test.rb","position":6,"original_position":6,"commit_id":"9c7b03bc7fe1fdd8b25232af0d6b17d32bc526e9","original_commit_id":"e6c1fcdd992e94cbb305e51a4673679527704e0d","user":{"login":"GoodForOneFare","id":673655,"avatar_url":"https://avatars.githubusercontent.com/u/673655?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodForOneFare","html_url":"https://github.com/GoodForOneFare","followers_url":"https://api.github.com/users/GoodForOneFare/followers","following_url":"https://api.github.com/users/GoodForOneFare/following{/other_user}","gists_url":"https://api.github.com/users/GoodForOneFare/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodForOneFare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodForOneFare/subscriptions","organizations_url":"https://api.github.com/users/GoodForOneFare/orgs","repos_url":"https://api.github.com/users/GoodForOneFare/repos","events_url":"https://api.github.com/users/GoodForOneFare/events{/privacy}","received_events_url":"https://api.github.com/users/GoodForOneFare/received_events","type":"User","site_admin":false},"body":"Did you try using `Capybara:DSL`? Something like `expect(page).to have_content content` should work","created_at":"2016-08-22T19:01:47Z","updated_at":"2016-08-22T19:01:47Z","html_url":"https://github.com/Shopify/turbograft/pull/123#discussion_r75737909","pull_request_url":"https://api.github.com/repos/Shopify/turbograft/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/comments/75737909"},"html":{"href":"https://github.com/Shopify/turbograft/pull/123#discussion_r75737909"},"pull_request":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/turbograft/pulls/123","id":80870142,"html_url":"https://github.com/Shopify/turbograft/pull/123","diff_url":"https://github.com/Shopify/turbograft/pull/123.diff","patch_url":"https://github.com/Shopify/turbograft/pull/123.patch","issue_url":"https://api.github.com/repos/Shopify/turbograft/issues/123","number":123,"state":"open","locked":false,"title":"Update <head> with new assets on page navigation instead of full page refresh","user":{"login":"justinthec","id":2578036,"avatar_url":"https://avatars.githubusercontent.com/u/2578036?v=3","gravatar_id":"","url":"https://api.github.com/users/justinthec","html_url":"https://github.com/justinthec","followers_url":"https://api.github.com/users/justinthec/followers","following_url":"https://api.github.com/users/justinthec/following{/other_user}","gists_url":"https://api.github.com/users/justinthec/gists{/gist_id}","starred_url":"https://api.github.com/users/justinthec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinthec/subscriptions","organizations_url":"https://api.github.com/users/justinthec/orgs","repos_url":"https://api.github.com/users/justinthec/repos","events_url":"https://api.github.com/users/justinthec/events{/privacy}","received_events_url":"https://api.github.com/users/justinthec/received_events","type":"User","site_admin":false},"body":">Put a PR up anyway\r\n![image](https://cloud.githubusercontent.com/assets/2578036/17571704/4a94edfe-5f1f-11e6-82fe-4531928ff8f9.png)\r\n\r\n@darrenhebner @TheMallen @Shopify/tnt \r\n\r\n@GoodForOneFare @edward \r\n\r\n~~**Note:** JS tests are order dependant due to the DOM being shared and not cleaned up between tests however clearing the body causes more assertion errors. We will continue to look into properly fixing this order dependency issue but for now, we've moved our new tests to a location where it does not cause conflicts.~~\r\n\r\n","created_at":"2016-08-10T21:23:11Z","updated_at":"2016-08-22T19:01:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f16e01a21aec201f592249b4bf0de4af804874","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/turbograft/pulls/123/commits","review_comments_url":"https://api.github.com/repos/Shopify/turbograft/pulls/123/comments","review_comment_url":"https://api.github.com/repos/Shopify/turbograft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/turbograft/issues/123/comments","statuses_url":"https://api.github.com/repos/Shopify/turbograft/statuses/9c7b03bc7fe1fdd8b25232af0d6b17d32bc526e9","head":{"label":"Shopify:delay-navigation-for-defer","ref":"delay-navigation-for-defer","sha":"9c7b03bc7fe1fdd8b25232af0d6b17d32bc526e9","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":23920094,"name":"turbograft","full_name":"Shopify/turbograft","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/turbograft","description":"Hard fork of turbolinks, adding partial page replacement strategies, and utilities.","fork":false,"url":"https://api.github.com/repos/Shopify/turbograft","forks_url":"https://api.github.com/repos/Shopify/turbograft/forks","keys_url":"https://api.github.com/repos/Shopify/turbograft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/turbograft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/turbograft/teams","hooks_url":"https://api.github.com/repos/Shopify/turbograft/hooks","issue_events_url":"https://api.github.com/repos/Shopify/turbograft/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/turbograft/events","assignees_url":"https://api.github.com/repos/Shopify/turbograft/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/turbograft/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/turbograft/tags","blobs_url":"https://api.github.com/repos/Shopify/turbograft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/turbograft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/turbograft/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/turbograft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/turbograft/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/turbograft/languages","stargazers_url":"https://api.github.com/repos/Shopify/turbograft/stargazers","contributors_url":"https://api.github.com/repos/Shopify/turbograft/contributors","subscribers_url":"https://api.github.com/repos/Shopify/turbograft/subscribers","subscription_url":"https://api.github.com/repos/Shopify/turbograft/subscription","commits_url":"https://api.github.com/repos/Shopify/turbograft/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/turbograft/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/turbograft/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/turbograft/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/turbograft/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/turbograft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/turbograft/merges","archive_url":"https://api.github.com/repos/Shopify/turbograft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/turbograft/downloads","issues_url":"https://api.github.com/repos/Shopify/turbograft/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/turbograft/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/turbograft/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/turbograft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/turbograft/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/turbograft/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/turbograft/deployments","created_at":"2014-09-11T13:47:46Z","updated_at":"2016-07-27T23:50:04Z","pushed_at":"2016-08-22T18:24:41Z","git_url":"git://github.com/Shopify/turbograft.git","ssh_url":"git@github.com:Shopify/turbograft.git","clone_url":"https://github.com/Shopify/turbograft.git","svn_url":"https://github.com/Shopify/turbograft","homepage":"","size":594,"stargazers_count":151,"watchers_count":151,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":25,"forks":14,"open_issues":25,"watchers":151,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"bf5bc64e02e7ecb0bacb263a410aec8e09bbbd88","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":23920094,"name":"turbograft","full_name":"Shopify/turbograft","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/turbograft","description":"Hard fork of turbolinks, adding partial page replacement strategies, and utilities.","fork":false,"url":"https://api.github.com/repos/Shopify/turbograft","forks_url":"https://api.github.com/repos/Shopify/turbograft/forks","keys_url":"https://api.github.com/repos/Shopify/turbograft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/turbograft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/turbograft/teams","hooks_url":"https://api.github.com/repos/Shopify/turbograft/hooks","issue_events_url":"https://api.github.com/repos/Shopify/turbograft/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/turbograft/events","assignees_url":"https://api.github.com/repos/Shopify/turbograft/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/turbograft/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/turbograft/tags","blobs_url":"https://api.github.com/repos/Shopify/turbograft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/turbograft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/turbograft/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/turbograft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/turbograft/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/turbograft/languages","stargazers_url":"https://api.github.com/repos/Shopify/turbograft/stargazers","contributors_url":"https://api.github.com/repos/Shopify/turbograft/contributors","subscribers_url":"https://api.github.com/repos/Shopify/turbograft/subscribers","subscription_url":"https://api.github.com/repos/Shopify/turbograft/subscription","commits_url":"https://api.github.com/repos/Shopify/turbograft/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/turbograft/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/turbograft/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/turbograft/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/turbograft/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/turbograft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/turbograft/merges","archive_url":"https://api.github.com/repos/Shopify/turbograft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/turbograft/downloads","issues_url":"https://api.github.com/repos/Shopify/turbograft/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/turbograft/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/turbograft/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/turbograft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/turbograft/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/turbograft/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/turbograft/deployments","created_at":"2014-09-11T13:47:46Z","updated_at":"2016-07-27T23:50:04Z","pushed_at":"2016-08-22T18:24:41Z","git_url":"git://github.com/Shopify/turbograft.git","ssh_url":"git@github.com:Shopify/turbograft.git","clone_url":"https://github.com/Shopify/turbograft.git","svn_url":"https://github.com/Shopify/turbograft","homepage":"","size":594,"stargazers_count":151,"watchers_count":151,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":25,"forks":14,"open_issues":25,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/123"},"html":{"href":"https://github.com/Shopify/turbograft/pull/123"},"issue":{"href":"https://api.github.com/repos/Shopify/turbograft/issues/123"},"comments":{"href":"https://api.github.com/repos/Shopify/turbograft/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/turbograft/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/turbograft/statuses/9c7b03bc7fe1fdd8b25232af0d6b17d32bc526e9"}}}}
{"actor":{"display_login":"GoodForOneFare"}}