{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/74341194","id":74341194,"diff_hunk":"@@ -253,6 +253,9 @@ def __init__(self, filepath_or_buffer, index=None, encoding='ISO-8859-1',\n \n         self._read_header()\n \n+    def close(self):\n+        self.filepath_or_buffer.close()","path":"pandas/io/sas/sas_xport.py","position":5,"original_position":5,"commit_id":"3fa7d25a00372a1312cd8fad0a82082e997f51a4","original_commit_id":"3fa7d25a00372a1312cd8fad0a82082e997f51a4","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"is this always a filehandle-like?","created_at":"2016-08-10T22:14:01Z","updated_at":"2016-08-10T22:14:01Z","html_url":"https://github.com/pydata/pandas/pull/13940#discussion_r74341194","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/13940","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/74341194"},"html":{"href":"https://github.com/pydata/pandas/pull/13940#discussion_r74341194"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13940"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13940","id":80527208,"html_url":"https://github.com/pydata/pandas/pull/13940","diff_url":"https://github.com/pydata/pandas/pull/13940.diff","patch_url":"https://github.com/pydata/pandas/pull/13940.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13940","number":13940,"state":"open","locked":false,"title":"BUG: properly close files opened by parsers","user":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"body":" - [x] closes #13932 \r\n - [x] tests passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n\r\nAddresses all ~~most~~ of the `ResourceWarning`s from #13932. There were three tests that opened files but did not close them. The rest were due to parsers (`CParserWrapper` and `PythonParser`) opening files or streams but never closing them. There was one case &mdash; the `mmap` one &mdash; that was tricky because there was a file handle going into it and immediately reaching a refcount of zero.\r\n\r\nI am at a loss about writing new tests for this. Is it even possible?","created_at":"2016-08-08T21:42:25Z","updated_at":"2016-08-10T22:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3818b85b5f39ff1c9e01f62356fecd0f2335a2a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/13940/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/13940/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13940/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/3fa7d25a00372a1312cd8fad0a82082e997f51a4","head":{"label":"agraboso:fix-13932","ref":"fix-13932","sha":"3fa7d25a00372a1312cd8fad0a82082e997f51a4","user":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"repo":{"id":62963161,"name":"pandas","full_name":"agraboso/pandas","owner":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agraboso/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/agraboso/pandas","forks_url":"https://api.github.com/repos/agraboso/pandas/forks","keys_url":"https://api.github.com/repos/agraboso/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agraboso/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agraboso/pandas/teams","hooks_url":"https://api.github.com/repos/agraboso/pandas/hooks","issue_events_url":"https://api.github.com/repos/agraboso/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/agraboso/pandas/events","assignees_url":"https://api.github.com/repos/agraboso/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/agraboso/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/agraboso/pandas/tags","blobs_url":"https://api.github.com/repos/agraboso/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agraboso/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agraboso/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/agraboso/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agraboso/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/agraboso/pandas/languages","stargazers_url":"https://api.github.com/repos/agraboso/pandas/stargazers","contributors_url":"https://api.github.com/repos/agraboso/pandas/contributors","subscribers_url":"https://api.github.com/repos/agraboso/pandas/subscribers","subscription_url":"https://api.github.com/repos/agraboso/pandas/subscription","commits_url":"https://api.github.com/repos/agraboso/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/agraboso/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/agraboso/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/agraboso/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/agraboso/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/agraboso/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agraboso/pandas/merges","archive_url":"https://api.github.com/repos/agraboso/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agraboso/pandas/downloads","issues_url":"https://api.github.com/repos/agraboso/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/agraboso/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/agraboso/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/agraboso/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agraboso/pandas/labels{/name}","releases_url":"https://api.github.com/repos/agraboso/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/agraboso/pandas/deployments","created_at":"2016-07-09T18:22:37Z","updated_at":"2016-07-09T18:22:43Z","pushed_at":"2016-08-10T21:23:44Z","git_url":"git://github.com/agraboso/pandas.git","ssh_url":"git@github.com:agraboso/pandas.git","clone_url":"https://github.com/agraboso/pandas.git","svn_url":"https://github.com/agraboso/pandas","homepage":"http://pandas.pydata.org","size":79699,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"5df9123e09168e130af0e73ba335d82f5c1a8d46","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-08-10T08:46:30Z","pushed_at":"2016-08-10T22:12:37Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":149907,"stargazers_count":6818,"watchers_count":6818,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2811,"mirror_url":null,"open_issues_count":1820,"forks":2811,"open_issues":1820,"watchers":6818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13940"},"html":{"href":"https://github.com/pydata/pandas/pull/13940"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/13940"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/13940/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13940/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13940/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/3fa7d25a00372a1312cd8fad0a82082e997f51a4"}}}}
{"actor":{"display_login":"jreback"}}