{"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/80610889","pull_request_review_id":1657468,"id":80610889,"diff_hunk":"@@ -17,16 +17,23 @@\n  */\n package org.bdgenomics.adam.rdd\n \n-import org.apache.spark.Partitioner\n import org.apache.spark.SparkContext._\n+import org.apache.spark.{ Partitioner, SparkContext }\n import org.apache.spark.rdd.RDD\n import org.bdgenomics.adam.models.ReferenceRegion._\n import org.bdgenomics.adam.models.{ SequenceDictionary, ReferenceRegion }\n import scala.collection.mutable.ListBuffer\n-import scala.math._\n import scala.reflect.ClassTag\n \n-private[rdd] case class ShuffleRegionJoin(sd: SequenceDictionary, partitionSize: Long) extends RegionJoin {\n+sealed trait ShuffleRegionJoin[T, U, RT, RU] extends RegionJoin[T, U, RT, RU] {\n+\n+  val sd: SequenceDictionary\n+  val partitionSize: Long\n+  @transient val sc: SparkContext\n+\n+  // Create the set of bins across the genome for parallel processing\n+  protected val seqLengths = Map(sd.records.toSeq.map(rec => (rec.name, rec.length)): _*)","path":"adam-core/src/main/scala/org/bdgenomics/adam/rdd/ShuffleRegionJoin.scala","position":22,"original_position":22,"commit_id":"a24e852c50b9e49525d38c2b1e6accd07446c9c1","original_commit_id":"f8019d655d51497c2bf6d19568a5c2c5e51fa635","user":{"login":"fnothaft","id":3752466,"avatar_url":"https://avatars.githubusercontent.com/u/3752466?v=3","gravatar_id":"","url":"https://api.github.com/users/fnothaft","html_url":"https://github.com/fnothaft","followers_url":"https://api.github.com/users/fnothaft/followers","following_url":"https://api.github.com/users/fnothaft/following{/other_user}","gists_url":"https://api.github.com/users/fnothaft/gists{/gist_id}","starred_url":"https://api.github.com/users/fnothaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnothaft/subscriptions","organizations_url":"https://api.github.com/users/fnothaft/orgs","repos_url":"https://api.github.com/users/fnothaft/repos","events_url":"https://api.github.com/users/fnothaft/events{/privacy}","received_events_url":"https://api.github.com/users/fnothaft/received_events","type":"User","site_admin":false},"body":"Just pushed rebased commits with this fixed. Thanks for catching @akmorrow13.","created_at":"2016-09-27T02:27:19Z","updated_at":"2016-09-27T02:27:19Z","html_url":"https://github.com/bigdatagenomics/adam/pull/1109#discussion_r80610889","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/80610889"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1109#discussion_r80610889"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109","id":80847432,"html_url":"https://github.com/bigdatagenomics/adam/pull/1109","diff_url":"https://github.com/bigdatagenomics/adam/pull/1109.diff","patch_url":"https://github.com/bigdatagenomics/adam/pull/1109.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1109","number":1109,"state":"open","locked":false,"title":"Add outer joins","user":{"login":"fnothaft","id":3752466,"avatar_url":"https://avatars.githubusercontent.com/u/3752466?v=3","gravatar_id":"","url":"https://api.github.com/users/fnothaft","html_url":"https://github.com/fnothaft","followers_url":"https://api.github.com/users/fnothaft/followers","following_url":"https://api.github.com/users/fnothaft/following{/other_user}","gists_url":"https://api.github.com/users/fnothaft/gists{/gist_id}","starred_url":"https://api.github.com/users/fnothaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnothaft/subscriptions","organizations_url":"https://api.github.com/users/fnothaft/orgs","repos_url":"https://api.github.com/users/fnothaft/repos","events_url":"https://api.github.com/users/fnothaft/events{/privacy}","received_events_url":"https://api.github.com/users/fnothaft/received_events","type":"User","site_admin":false},"body":"Resolves #1098. Still a WIP; needs tests, as well as more documentation.","created_at":"2016-08-10T18:53:16Z","updated_at":"2016-09-27T02:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482c7781f0307267de8f209cddc82815a5ea0c06","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1109/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/a24e852c50b9e49525d38c2b1e6accd07446c9c1","head":{"label":"fnothaft:issues/1098-outer-joins","ref":"issues/1098-outer-joins","sha":"a24e852c50b9e49525d38c2b1e6accd07446c9c1","user":{"login":"fnothaft","id":3752466,"avatar_url":"https://avatars.githubusercontent.com/u/3752466?v=3","gravatar_id":"","url":"https://api.github.com/users/fnothaft","html_url":"https://github.com/fnothaft","followers_url":"https://api.github.com/users/fnothaft/followers","following_url":"https://api.github.com/users/fnothaft/following{/other_user}","gists_url":"https://api.github.com/users/fnothaft/gists{/gist_id}","starred_url":"https://api.github.com/users/fnothaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnothaft/subscriptions","organizations_url":"https://api.github.com/users/fnothaft/orgs","repos_url":"https://api.github.com/users/fnothaft/repos","events_url":"https://api.github.com/users/fnothaft/events{/privacy}","received_events_url":"https://api.github.com/users/fnothaft/received_events","type":"User","site_admin":false},"repo":{"id":16842658,"name":"adam","full_name":"fnothaft/adam","owner":{"login":"fnothaft","id":3752466,"avatar_url":"https://avatars.githubusercontent.com/u/3752466?v=3","gravatar_id":"","url":"https://api.github.com/users/fnothaft","html_url":"https://github.com/fnothaft","followers_url":"https://api.github.com/users/fnothaft/followers","following_url":"https://api.github.com/users/fnothaft/following{/other_user}","gists_url":"https://api.github.com/users/fnothaft/gists{/gist_id}","starred_url":"https://api.github.com/users/fnothaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnothaft/subscriptions","organizations_url":"https://api.github.com/users/fnothaft/orgs","repos_url":"https://api.github.com/users/fnothaft/repos","events_url":"https://api.github.com/users/fnothaft/events{/privacy}","received_events_url":"https://api.github.com/users/fnothaft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fnothaft/adam","description":"A genomics processing engine and specialized file format built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/fnothaft/adam","forks_url":"https://api.github.com/repos/fnothaft/adam/forks","keys_url":"https://api.github.com/repos/fnothaft/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnothaft/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnothaft/adam/teams","hooks_url":"https://api.github.com/repos/fnothaft/adam/hooks","issue_events_url":"https://api.github.com/repos/fnothaft/adam/issues/events{/number}","events_url":"https://api.github.com/repos/fnothaft/adam/events","assignees_url":"https://api.github.com/repos/fnothaft/adam/assignees{/user}","branches_url":"https://api.github.com/repos/fnothaft/adam/branches{/branch}","tags_url":"https://api.github.com/repos/fnothaft/adam/tags","blobs_url":"https://api.github.com/repos/fnothaft/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnothaft/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnothaft/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnothaft/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnothaft/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/fnothaft/adam/languages","stargazers_url":"https://api.github.com/repos/fnothaft/adam/stargazers","contributors_url":"https://api.github.com/repos/fnothaft/adam/contributors","subscribers_url":"https://api.github.com/repos/fnothaft/adam/subscribers","subscription_url":"https://api.github.com/repos/fnothaft/adam/subscription","commits_url":"https://api.github.com/repos/fnothaft/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnothaft/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnothaft/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnothaft/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnothaft/adam/contents/{+path}","compare_url":"https://api.github.com/repos/fnothaft/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnothaft/adam/merges","archive_url":"https://api.github.com/repos/fnothaft/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnothaft/adam/downloads","issues_url":"https://api.github.com/repos/fnothaft/adam/issues{/number}","pulls_url":"https://api.github.com/repos/fnothaft/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/fnothaft/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/fnothaft/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnothaft/adam/labels{/name}","releases_url":"https://api.github.com/repos/fnothaft/adam/releases{/id}","deployments_url":"https://api.github.com/repos/fnothaft/adam/deployments","created_at":"2014-02-14T16:25:30Z","updated_at":"2014-06-24T16:52:53Z","pushed_at":"2016-09-27T02:26:48Z","git_url":"git://github.com/fnothaft/adam.git","ssh_url":"git@github.com:fnothaft/adam.git","clone_url":"https://github.com/fnothaft/adam.git","svn_url":"https://github.com/fnothaft/adam","homepage":"","size":6216,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"54371cbd83bfa64e3085ad4b05417ef0d1637c6c","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":14541530,"name":"adam","full_name":"bigdatagenomics/adam","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/adam","forks_url":"https://api.github.com/repos/bigdatagenomics/adam/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/adam/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/adam/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/adam/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/adam/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/adam/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/adam/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/adam/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/adam/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/adam/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/adam/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/adam/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/adam/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/adam/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/adam/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/adam/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/adam/releases{/id}","deployments_url":"https://api.github.com/repos/bigdatagenomics/adam/deployments","created_at":"2013-11-19T23:47:57Z","updated_at":"2016-09-26T16:42:52Z","pushed_at":"2016-09-27T02:26:49Z","git_url":"git://github.com/bigdatagenomics/adam.git","ssh_url":"git@github.com:bigdatagenomics/adam.git","clone_url":"https://github.com/bigdatagenomics/adam.git","svn_url":"https://github.com/bigdatagenomics/adam","homepage":"http://bdgenomics.org/","size":54016,"stargazers_count":520,"watchers_count":520,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":86,"forks":191,"open_issues":86,"watchers":520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1109"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1109"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/adam/statuses/a24e852c50b9e49525d38c2b1e6accd07446c9c1"}}}}
{"actor":{"display_login":"fnothaft"}}