{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/5100","repository_url":"https://api.github.com/repos/aspnet/Mvc","labels_url":"https://api.github.com/repos/aspnet/Mvc/issues/5100/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/5100/comments","events_url":"https://api.github.com/repos/aspnet/Mvc/issues/5100/events","html_url":"https://github.com/aspnet/Mvc/pull/5100","id":168660390,"number":5100,"title":"Make sure we don't try to add the same key multiple times","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet/Mvc/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-01T14:32:36Z","updated_at":"2016-08-01T14:59:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/5100","html_url":"https://github.com/aspnet/Mvc/pull/5100","diff_url":"https://github.com/aspnet/Mvc/pull/5100.diff","patch_url":"https://github.com/aspnet/Mvc/pull/5100.patch"},"body":"We hit an issue where multiple `MvcCoreRouteOptionsSetup` were being run because of several registrations in the service collection. See issues below.\r\n\r\nIdeally, this shouldn't happen, but it did, because of another bug (or an ill-defined contract in MS.Ext.DI). This ensures that the configuration is idempotent :sparkles: \r\n\r\nhttps://github.com/structuremap/StructureMap.Microsoft.DependencyInjection/issues/11\r\nhttps://github.com/structuremap/StructureMap.Microsoft.DependencyInjection/issues/12"},"comment":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/236606379","html_url":"https://github.com/aspnet/Mvc/pull/5100#issuecomment-236606379","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/5100","id":236606379,"user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T14:59:55Z","updated_at":"2016-08-01T14:59:55Z","body":"@khellang - this isn't really the right approach there are a bunch of \"options setup\" classes in MVC that **MUST** be run once. This is why we created (and use) `TryAddEnumerable` https://github.com/aspnet/Mvc/blob/52a7c112e8c0369b4b1626d750fb3d5b43db65bd/src/Microsoft.AspNetCore.Mvc.Core/DependencyInjection/MvcCoreServiceCollectionExtensions.cs#L128\r\n\r\nDo you know why/how `MvcCoreRouteOptionsSetup` is getting registered twice?"}}
{"actor":{"display_login":"rynowak"}}