{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/72376126","id":72376126,"diff_hunk":"@@ -28,7 +29,8 @@ private static void CollectDependencies(IDictionary<string, LibraryExport> expor\n             foreach (var dependency in dependencies)\n             {\n                 var export = exports[dependency.Name];\n-                if (export.Library.Identity.Version.Equals(dependency.VersionRange.MinVersion))\n+                if (export.Library.Identity.Version.Equals(dependency.VersionRange.MinVersion) \n+                    && !exclusionList.Contains(dependency.Name))","path":"src/Microsoft.DotNet.ProjectModel/ProjectModelPlatformExtensions.cs","position":14,"original_position":14,"commit_id":"b6080bfa42943ccd1dcfe5715018e5710200c924","original_commit_id":"b6080bfa42943ccd1dcfe5715018e5710200c924","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"HashSet.Add returns a bool:\r\ntrue if the element is added to the HashSet<T> object; false if the element is already present.\r\n\r\nSo you shouldn't have to check Contains before Add.  You can just call \"Add\".  And if Add returns 'true', then walk the dependencies.","created_at":"2016-07-27T03:35:49Z","updated_at":"2016-07-27T03:35:49Z","html_url":"https://github.com/dotnet/cli/pull/3942#discussion_r72376126","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/3942","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/72376126"},"html":{"href":"https://github.com/dotnet/cli/pull/3942#discussion_r72376126"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3942"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/3942","id":78926066,"html_url":"https://github.com/dotnet/cli/pull/3942","diff_url":"https://github.com/dotnet/cli/pull/3942.diff","patch_url":"https://github.com/dotnet/cli/pull/3942.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/3942","number":3942,"state":"open","locked":false,"title":"Performance Fixes ","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"body":"Fixed Conflicts/Refactored/Fixed bugs from @pakrym:\r\nhttps://github.com/dotnet/cli/issues/3839\r\nhttps://github.com/dotnet/cli/issues/3840\r\n\r\nAdded Tests for https://github.com/dotnet/cli/issues/3839\r\n\r\nLast commit fixes https://github.com/dotnet/cli/issues/3841\r\nGetTypeBuildExclusion list optimized by enforcing a single visit of each node in the dependency graph, using an iterative rather than recursive graph walk, and replacing the set difference operations with a graph subset search. \r\n\r\nPerformance increased by `.4s` on my macbook. \r\nAlso optimized GetPlatformExclusionList graph walk by enforcing single node visit. \r\n\r\nPerformance Data OLD:\r\n```\r\nPerformance Summary:\r\n[100.00% 2.392s] Thread 1\r\n  [99.97% 99.97% 2.392s] Program:Main\r\n    [00.28% 00.28% 0.006s] Program:ConfigureDotNetForFirstTimeUse\r\n    [09.62% 09.62% 0.230s] Program:ResolveRootContexts\r\n      [03.27% 33.99% 0.078s] Program:Loading project.json /Users/brthor/code/test/new/project.json\r\n      [06.28% 65.22% 0.150s] Program:Waiting for project contexts to finish loading\r\n    [00.13% 00.13% 0.003s] Program:Collect graph\r\n    [88.87% 88.90% 2.126s] ProjectBuilder:Build new\r\n      [01.43% 01.61% 0.034s] ProjectBuilder:HasSourceFiles new\r\n      [02.21% 02.48% 0.052s] ProjectBuilder:NeedsRebuilding new\r\n      [81.96% 92.22% 1.961s] ProjectBuilder:RunCompile new\r\n        [19.86% 24.23% 0.475s] ProjectModelPlatformExtensions:GetTypeBuildExclusionList\r\n          [19.84% 99.90% 0.474s] ProjectModelPlatformExtensions:GetTypeBuildExclusionList-marknonbuild\r\n        [47.61% 58.09% 1.139s] Command:Execute dotnet /Users/brthor/code/cli/artifacts/osx.10.11-x64/stage2/sdk/1.0.0-featantares-003217/csc.dll -noconfig @/Users/brthor/code/test/new/obj/Debug/netcoreapp1.0/dotnet-compile-csc.rsp\r\n      [01.51% 01.69% 0.036s] ProjectModelPlatformExtensions:platform exclusion\r\n```\r\n\r\nNEW \r\n\r\n```\r\nPerformance Summary:\r\n[100.00% 1.891s] Thread 1\r\n  [99.85% 99.85% 1.888s] Program:Main\r\n    [00.40% 00.40% 0.007s] Program:ConfigureDotNetForFirstTimeUse\r\n    [11.20% 11.22% 0.211s] Program:ResolveRootContexts\r\n      [03.78% 33.78% 0.071s] Program:Loading project.json /Users/brthor/code/test/new/project.json\r\n      [07.33% 65.47% 0.138s] Program:Waiting for project contexts to finish loading\r\n    [00.15% 00.15% 0.002s] Program:Collect graph\r\n    [86.56% 86.69% 1.637s] ProjectBuilder:Build new\r\n      [01.81% 02.09% 0.034s] ProjectBuilder:HasSourceFiles new\r\n      [03.07% 03.54% 0.057s] ProjectBuilder:NeedsRebuilding new\r\n      [79.10% 91.38% 1.495s] ProjectBuilder:RunCompile new\r\n        [60.08% 75.96% 1.136s] Command:Execute dotnet /Users/brthor/code/cli/artifacts/osx.10.11-x64/stage2/sdk/1.0.0-featantares-003217/csc.dll -noconfig @/Users/brthor/code/test/new/obj/Debug/netcoreapp1.0/dotnet-compile-csc.rsp\r\n```\r\n\r\n/cc @pakrym @anurse @eerhardt @piotrpMSFT ","created_at":"2016-07-26T21:09:15Z","updated_at":"2016-07-27T03:35:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ce7134167cd48706dbafd5ba08dec555dcb9bde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/3942/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/3942/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/3942/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/b6080bfa42943ccd1dcfe5715018e5710200c924","head":{"label":"brthor:brthor/ant-fixes","ref":"brthor/ant-fixes","sha":"b6080bfa42943ccd1dcfe5715018e5710200c924","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"repo":{"id":46514660,"name":"cli","full_name":"brthor/cli","owner":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brthor/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/brthor/cli","forks_url":"https://api.github.com/repos/brthor/cli/forks","keys_url":"https://api.github.com/repos/brthor/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brthor/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brthor/cli/teams","hooks_url":"https://api.github.com/repos/brthor/cli/hooks","issue_events_url":"https://api.github.com/repos/brthor/cli/issues/events{/number}","events_url":"https://api.github.com/repos/brthor/cli/events","assignees_url":"https://api.github.com/repos/brthor/cli/assignees{/user}","branches_url":"https://api.github.com/repos/brthor/cli/branches{/branch}","tags_url":"https://api.github.com/repos/brthor/cli/tags","blobs_url":"https://api.github.com/repos/brthor/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brthor/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brthor/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brthor/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brthor/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brthor/cli/languages","stargazers_url":"https://api.github.com/repos/brthor/cli/stargazers","contributors_url":"https://api.github.com/repos/brthor/cli/contributors","subscribers_url":"https://api.github.com/repos/brthor/cli/subscribers","subscription_url":"https://api.github.com/repos/brthor/cli/subscription","commits_url":"https://api.github.com/repos/brthor/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brthor/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brthor/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brthor/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brthor/cli/contents/{+path}","compare_url":"https://api.github.com/repos/brthor/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brthor/cli/merges","archive_url":"https://api.github.com/repos/brthor/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brthor/cli/downloads","issues_url":"https://api.github.com/repos/brthor/cli/issues{/number}","pulls_url":"https://api.github.com/repos/brthor/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brthor/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brthor/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brthor/cli/labels{/name}","releases_url":"https://api.github.com/repos/brthor/cli/releases{/id}","deployments_url":"https://api.github.com/repos/brthor/cli/deployments","created_at":"2015-11-19T19:17:23Z","updated_at":"2016-06-01T22:27:26Z","pushed_at":"2016-07-26T23:46:09Z","git_url":"git://github.com/brthor/cli.git","ssh_url":"git@github.com:brthor/cli.git","clone_url":"https://github.com/brthor/cli.git","svn_url":"https://github.com/brthor/cli","homepage":"http://dotnet.github.io/","size":103463,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:feature/antares","ref":"feature/antares","sha":"f66cee263a4d3e3fb790ca8b72c7defff1f1a2af","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-07-26T20:52:31Z","pushed_at":"2016-07-27T03:27:36Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":118512,"stargazers_count":1321,"watchers_count":1321,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":860,"forks":317,"open_issues":860,"watchers":1321,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3942"},"html":{"href":"https://github.com/dotnet/cli/pull/3942"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/3942"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/3942/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3942/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3942/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/b6080bfa42943ccd1dcfe5715018e5710200c924"}}}}
{"actor":{"display_login":"eerhardt"}}