{"action":"created","issue":{"url":"https://api.github.com/repos/merbanan/rtl_433/issues/264","labels_url":"https://api.github.com/repos/merbanan/rtl_433/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/merbanan/rtl_433/issues/264/comments","events_url":"https://api.github.com/repos/merbanan/rtl_433/issues/264/events","html_url":"https://github.com/merbanan/rtl_433/pull/264","id":127098980,"number":264,"title":"Fix abs() call on unsigned int","user":{"login":"zuckschwerdt","id":12833,"avatar_url":"https://avatars.githubusercontent.com/u/12833?v=3","gravatar_id":"","url":"https://api.github.com/users/zuckschwerdt","html_url":"https://github.com/zuckschwerdt","followers_url":"https://api.github.com/users/zuckschwerdt/followers","following_url":"https://api.github.com/users/zuckschwerdt/following{/other_user}","gists_url":"https://api.github.com/users/zuckschwerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/zuckschwerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuckschwerdt/subscriptions","organizations_url":"https://api.github.com/users/zuckschwerdt/orgs","repos_url":"https://api.github.com/users/zuckschwerdt/repos","events_url":"https://api.github.com/users/zuckschwerdt/events{/privacy}","received_events_url":"https://api.github.com/users/zuckschwerdt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-17T14:45:41Z","updated_at":"2016-01-17T18:22:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/merbanan/rtl_433/pulls/264","html_url":"https://github.com/merbanan/rtl_433/pull/264","diff_url":"https://github.com/merbanan/rtl_433/pull/264.diff","patch_url":"https://github.com/merbanan/rtl_433/pull/264.patch"},"body":"Calling `abs()` on `unsigned int` is implementation (compiler) specific. As far as I can see the current code gets the intended result, but by chance only. `abs()` seems to convert unsigned values with set high bit to negative values and then removes the sign. Let's make the intention explicit and sound."},"comment":{"url":"https://api.github.com/repos/merbanan/rtl_433/issues/comments/172360860","html_url":"https://github.com/merbanan/rtl_433/pull/264#issuecomment-172360860","issue_url":"https://api.github.com/repos/merbanan/rtl_433/issues/264","id":172360860,"user":{"login":"merbanan","id":124883,"avatar_url":"https://avatars.githubusercontent.com/u/124883?v=3","gravatar_id":"","url":"https://api.github.com/users/merbanan","html_url":"https://github.com/merbanan","followers_url":"https://api.github.com/users/merbanan/followers","following_url":"https://api.github.com/users/merbanan/following{/other_user}","gists_url":"https://api.github.com/users/merbanan/gists{/gist_id}","starred_url":"https://api.github.com/users/merbanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merbanan/subscriptions","organizations_url":"https://api.github.com/users/merbanan/orgs","repos_url":"https://api.github.com/users/merbanan/repos","events_url":"https://api.github.com/users/merbanan/events{/privacy}","received_events_url":"https://api.github.com/users/merbanan/received_events","type":"User","site_admin":false},"created_at":"2016-01-17T18:22:58Z","updated_at":"2016-01-17T18:22:58Z","body":"Imo just changing the pulses and device struct members to int should remove the need for this wrapper, does it not ?"}}