{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/81234302","pull_request_review_id":2230333,"id":81234302,"diff_hunk":"@@ -22,15 +23,26 @@ class ClientEntity implements ClientEntityInterface\n      * @param $client_id","path":"app/Auth/Entities/ClientEntity.php","position":9,"original_position":9,"commit_id":"86776f57479e5d5f5d564b2ff36ee07f77a9190f","original_commit_id":"86776f57479e5d5f5d564b2ff36ee07f77a9190f","user":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"body":"add newb @param here!","created_at":"2016-09-29T21:04:19Z","updated_at":"2016-09-29T21:04:19Z","html_url":"https://github.com/DoSomething/northstar/pull/447#discussion_r81234302","pull_request_url":"https://api.github.com/repos/DoSomething/northstar/pulls/447","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/81234302"},"html":{"href":"https://github.com/DoSomething/northstar/pull/447#discussion_r81234302"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/447"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/447","id":87387057,"html_url":"https://github.com/DoSomething/northstar/pull/447","diff_url":"https://github.com/DoSomething/northstar/pull/447.diff","patch_url":"https://github.com/DoSomething/northstar/pull/447.patch","issue_url":"https://api.github.com/repos/DoSomething/northstar/issues/447","number":447,"state":"open","locked":false,"title":"Login tweaks","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nThis PR includes some improvements to the login flow & general tidiness:\r\n\r\n📄 Adds missing `Client` fields to the class's docblock for syntax highlighting goodness.\r\n\r\n🔒 Checks authentication for the `/authorize` endpoint via the guard. This allows us to redirect to the login page after we have already figured out the client information for the request.\r\n\r\n💻 Adds the human-readable client name to the `ClientEntity`, and adds a `ClientEntity::fromModel` static method that creates a new entity from the corresponding Eloquent model.\r\n\r\n🎨 Makes the `.-centered` container fixed-width (just like our modals are), since otherwise the container seemed either a bit too big or a bit too small at either extreme.\r\n\r\n🎨 Adds the destination (by default, client name but can be customized with `?destination=...`) to the heading \"Log in to continue to ___\" when making authorization requests:\r\n\r\n![screen shot 2016-09-29 at 4 23 40 pm](https://cloud.githubusercontent.com/assets/583202/18970893/1a39ecea-8661-11e6-9cd6-507217bd205e.png)\r\n\r\n#### How should this be reviewed?\r\n👀\r\n\r\n#### Checklist\r\n- [x] Documentation added for changed endpoints.\r\n- [ ] Tests added for new features/bug fixes.\r\n\r\n---\r\nFor review: @weerd @angaither ","created_at":"2016-09-29T20:24:54Z","updated_at":"2016-09-29T21:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3341fcd378b3341d59ceef2d6b40dc543dbeaf86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/northstar/pulls/447/commits","review_comments_url":"https://api.github.com/repos/DoSomething/northstar/pulls/447/comments","review_comment_url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/northstar/issues/447/comments","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/86776f57479e5d5f5d564b2ff36ee07f77a9190f","head":{"label":"DFurnes:login-tweaks","ref":"login-tweaks","sha":"86776f57479e5d5f5d564b2ff36ee07f77a9190f","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"repo":{"id":34683157,"name":"northstar","full_name":"DFurnes/northstar","owner":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DFurnes/northstar","description":"DoSomething.org User API.","fork":true,"url":"https://api.github.com/repos/DFurnes/northstar","forks_url":"https://api.github.com/repos/DFurnes/northstar/forks","keys_url":"https://api.github.com/repos/DFurnes/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFurnes/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFurnes/northstar/teams","hooks_url":"https://api.github.com/repos/DFurnes/northstar/hooks","issue_events_url":"https://api.github.com/repos/DFurnes/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DFurnes/northstar/events","assignees_url":"https://api.github.com/repos/DFurnes/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DFurnes/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DFurnes/northstar/tags","blobs_url":"https://api.github.com/repos/DFurnes/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFurnes/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFurnes/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFurnes/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFurnes/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DFurnes/northstar/languages","stargazers_url":"https://api.github.com/repos/DFurnes/northstar/stargazers","contributors_url":"https://api.github.com/repos/DFurnes/northstar/contributors","subscribers_url":"https://api.github.com/repos/DFurnes/northstar/subscribers","subscription_url":"https://api.github.com/repos/DFurnes/northstar/subscription","commits_url":"https://api.github.com/repos/DFurnes/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFurnes/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFurnes/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFurnes/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFurnes/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DFurnes/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFurnes/northstar/merges","archive_url":"https://api.github.com/repos/DFurnes/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFurnes/northstar/downloads","issues_url":"https://api.github.com/repos/DFurnes/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DFurnes/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DFurnes/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DFurnes/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFurnes/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DFurnes/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DFurnes/northstar/deployments","created_at":"2015-04-27T18:18:39Z","updated_at":"2016-01-11T20:03:02Z","pushed_at":"2016-09-29T20:35:01Z","git_url":"git://github.com/DFurnes/northstar.git","ssh_url":"git@github.com:DFurnes/northstar.git","clone_url":"https://github.com/DFurnes/northstar.git","svn_url":"https://github.com/DFurnes/northstar","homepage":null,"size":1285,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"6202dc1c7a311d4dae4b63351d6f3cfb87978349","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":26884886,"name":"northstar","full_name":"DoSomething/northstar","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/northstar","description":":sparkles: The DoSomething.org user & identity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/northstar","forks_url":"https://api.github.com/repos/DoSomething/northstar/forks","keys_url":"https://api.github.com/repos/DoSomething/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/northstar/teams","hooks_url":"https://api.github.com/repos/DoSomething/northstar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/northstar/events","assignees_url":"https://api.github.com/repos/DoSomething/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/northstar/tags","blobs_url":"https://api.github.com/repos/DoSomething/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/northstar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/northstar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/northstar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/northstar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/northstar/subscription","commits_url":"https://api.github.com/repos/DoSomething/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/northstar/merges","archive_url":"https://api.github.com/repos/DoSomething/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/northstar/downloads","issues_url":"https://api.github.com/repos/DoSomething/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/northstar/deployments","created_at":"2014-11-19T22:33:42Z","updated_at":"2016-09-29T13:45:48Z","pushed_at":"2016-09-29T20:35:02Z","git_url":"git://github.com/DoSomething/northstar.git","ssh_url":"git@github.com:DoSomething/northstar.git","clone_url":"https://github.com/DoSomething/northstar.git","svn_url":"https://github.com/DoSomething/northstar","homepage":"https://northstar.dosomething.org","size":1331,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/447"},"html":{"href":"https://github.com/DoSomething/northstar/pull/447"},"issue":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/447"},"comments":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/northstar/statuses/86776f57479e5d5f5d564b2ff36ee07f77a9190f"}}}}
{"actor":{"display_login":"angaither"}}