{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/51960872","id":51960872,"diff_hunk":"@@ -558,6 +558,47 @@ pure function calc_rn(n,uvw) result(rn)\n   end function calc_rn\n \n !===============================================================================\n+! EXPAND_HARMONIC expands a given series of harmonics","path":"src/math.F90","position":4,"original_position":4,"commit_id":"989569ac5e4adb3eb8ea989768c87d5e3e1943fd","original_commit_id":"989569ac5e4adb3eb8ea989768c87d5e3e1943fd","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"body":"Replace that `harmonics` with `spherical harmonics`, just to be clear","created_at":"2016-02-05T00:29:48Z","updated_at":"2016-02-05T00:29:48Z","html_url":"https://github.com/mit-crpg/openmc/pull/494#discussion_r51960872","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/51960872"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/494#discussion_r51960872"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/494","id":50069684,"html_url":"https://github.com/mit-crpg/openmc/pull/494","diff_url":"https://github.com/mit-crpg/openmc/pull/494.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/494.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494","number":494,"state":"open","locked":false,"title":"Addition of MultiGroup Capability","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"body":"As discussed in #336, this PR contains the Multi-group capability.  The list below contains remaining work before this can be considered ready for merge.  \r\n\r\nOverall, I have a decent balance between not touching CE mode, but getting MG close to as fast as when I had it in its own standalone form.  I did this with usage of: extended types, procedure pointers, and a sprinkling of if (run_CE) here and there.\r\n\r\nRight now the only actual issue I am aware of is that CMFD does not work when feedback is enabled; however the CMFD solution is correct when it is not.  My hunch is that this is due to CMFD, which is left living in energy space (vice group space), has some term not being communicated properly back to energy space from the group space.  I haven't been able to find that yet, however.\r\n\r\nI have a question for you guys regarding testing: would you prefer there be specific MG tests in its own sub-directory within /tests/, that there be test_mg_* tests for everything that possibly  could have been touched by this new capability, or that the test harness be taught how to run both a CE and MG problem so we test both modes concurrently?  How were you thinking about attacking this for photon transport @paulromano?  \r\n\r\n- [x] Get CMFD Running (see discussion)\r\n- [x] General optimizations/cleanup (open to ideas for efficiency)\r\n- [x] Add example C5G7 problems\r\n- [x] Add User's Guide Documentation\r\n- [x] Add testing (see discussion)\r\n- [x] Add RelaxNG schema\r\n- [x] Update Python for general API\r\n\r\nReserved for future PRs:\r\n- Support HDF5 cross section files\r\n- Update Methods Documentation\r\n- Update MGXS Module of Python API to support types needed to have CE mode create MG mode data.\r\n","created_at":"2015-11-08T20:50:21Z","updated_at":"2016-02-05T00:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"444b68daf0c8ddb23000911579b5308c8e57f7a9","assignee":null,"milestone":{"url":"https://api.github.com/repos/mit-crpg/openmc/milestones/14","html_url":"https://github.com/mit-crpg/openmc/milestones/v0.8","labels_url":"https://api.github.com/repos/mit-crpg/openmc/milestones/14/labels","id":1241750,"number":14,"title":"v0.8","description":"","creator":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":16,"state":"open","created_at":"2015-08-05T10:39:23Z","updated_at":"2016-02-01T12:45:31Z","due_on":"2016-04-30T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/494/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/494/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/989569ac5e4adb3eb8ea989768c87d5e3e1943fd","head":{"label":"nelsonag:mg","ref":"mg","sha":"989569ac5e4adb3eb8ea989768c87d5e3e1943fd","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"repo":{"id":18528596,"name":"openmc","full_name":"nelsonag/openmc","owner":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelsonag/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/nelsonag/openmc","forks_url":"https://api.github.com/repos/nelsonag/openmc/forks","keys_url":"https://api.github.com/repos/nelsonag/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelsonag/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelsonag/openmc/teams","hooks_url":"https://api.github.com/repos/nelsonag/openmc/hooks","issue_events_url":"https://api.github.com/repos/nelsonag/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/nelsonag/openmc/events","assignees_url":"https://api.github.com/repos/nelsonag/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/nelsonag/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/nelsonag/openmc/tags","blobs_url":"https://api.github.com/repos/nelsonag/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelsonag/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelsonag/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelsonag/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelsonag/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/nelsonag/openmc/languages","stargazers_url":"https://api.github.com/repos/nelsonag/openmc/stargazers","contributors_url":"https://api.github.com/repos/nelsonag/openmc/contributors","subscribers_url":"https://api.github.com/repos/nelsonag/openmc/subscribers","subscription_url":"https://api.github.com/repos/nelsonag/openmc/subscription","commits_url":"https://api.github.com/repos/nelsonag/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelsonag/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelsonag/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelsonag/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelsonag/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/nelsonag/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelsonag/openmc/merges","archive_url":"https://api.github.com/repos/nelsonag/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelsonag/openmc/downloads","issues_url":"https://api.github.com/repos/nelsonag/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/nelsonag/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/nelsonag/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/nelsonag/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelsonag/openmc/labels{/name}","releases_url":"https://api.github.com/repos/nelsonag/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/nelsonag/openmc/deployments","created_at":"2014-04-07T18:40:04Z","updated_at":"2016-01-16T18:49:13Z","pushed_at":"2016-02-03T18:25:53Z","git_url":"git://github.com/nelsonag/openmc.git","ssh_url":"git@github.com:nelsonag/openmc.git","clone_url":"https://github.com/nelsonag/openmc.git","svn_url":"https://github.com/nelsonag/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":26880,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"6efefcac947d40c213c664e85951a5d1ef535988","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/openmc/deployments","created_at":"2011-07-21T00:33:27Z","updated_at":"2016-01-25T01:17:33Z","pushed_at":"2016-02-04T16:15:42Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":42204,"stargazers_count":69,"watchers_count":69,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"open_issues_count":50,"forks":88,"open_issues":50,"watchers":69,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/494"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/494"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/494"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/989569ac5e4adb3eb8ea989768c87d5e3e1943fd"}}}}