{"action":"created","issue":{"url":"https://api.github.com/repos/ueberauth/guardian/issues/121","repository_url":"https://api.github.com/repos/ueberauth/guardian","labels_url":"https://api.github.com/repos/ueberauth/guardian/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/ueberauth/guardian/issues/121/comments","events_url":"https://api.github.com/repos/ueberauth/guardian/issues/121/events","html_url":"https://github.com/ueberauth/guardian/pull/121","id":138325795,"number":121,"title":"fix do_refresh! revoke! call","user":{"login":"ReyesK","id":2047932,"avatar_url":"https://avatars.githubusercontent.com/u/2047932?v=3","gravatar_id":"","url":"https://api.github.com/users/ReyesK","html_url":"https://github.com/ReyesK","followers_url":"https://api.github.com/users/ReyesK/followers","following_url":"https://api.github.com/users/ReyesK/following{/other_user}","gists_url":"https://api.github.com/users/ReyesK/gists{/gist_id}","starred_url":"https://api.github.com/users/ReyesK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReyesK/subscriptions","organizations_url":"https://api.github.com/users/ReyesK/orgs","repos_url":"https://api.github.com/users/ReyesK/repos","events_url":"https://api.github.com/users/ReyesK/events{/privacy}","received_events_url":"https://api.github.com/users/ReyesK/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ueberauth/guardian/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-03T23:12:52Z","updated_at":"2016-03-03T23:24:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ueberauth/guardian/pulls/121","html_url":"https://github.com/ueberauth/guardian/pull/121","diff_url":"https://github.com/ueberauth/guardian/pull/121.diff","patch_url":"https://github.com/ueberauth/guardian/pull/121.patch"},"body":"I'm new to elixir, but from what I can see. when refresh was implemented the revoke! function had two signatures. \r\n`revoke!(jwt)` and `revoke!(jwt, claims)`\r\nat this point, do_refresh! was calling `revoke!\\2` and all is well.\r\n(reference: https://github.com/ueberauth/guardian/commit/018233d669b0b8b8d6aa481502f8a65930c0abe5)\r\n\r\nwhen the commit \"Allow using custom secrets to encode / decode tokens\" came in the revoke signatures changed to \r\n`revoke!(jwt, params \\\\ %{})` and `revoke!(jwt, claims, _params)`\r\nhowever the call to revoke! in do_refresh! did not change.\r\n(reference: https://github.com/ueberauth/guardian/commit/c2fb7154950d371ea7f71a4d3dbe38228baa1c27)\r\n\r\nThis is leading to do_refresh! calling revoke hooks with the claims from the newly refreshed jwt instead of the claims passed into do_refresh!"},"comment":{"url":"https://api.github.com/repos/ueberauth/guardian/issues/comments/192017719","html_url":"https://github.com/ueberauth/guardian/pull/121#issuecomment-192017719","issue_url":"https://api.github.com/repos/ueberauth/guardian/issues/121","id":192017719,"user":{"login":"hassox","id":104,"avatar_url":"https://avatars.githubusercontent.com/u/104?v=3","gravatar_id":"","url":"https://api.github.com/users/hassox","html_url":"https://github.com/hassox","followers_url":"https://api.github.com/users/hassox/followers","following_url":"https://api.github.com/users/hassox/following{/other_user}","gists_url":"https://api.github.com/users/hassox/gists{/gist_id}","starred_url":"https://api.github.com/users/hassox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassox/subscriptions","organizations_url":"https://api.github.com/users/hassox/orgs","repos_url":"https://api.github.com/users/hassox/repos","events_url":"https://api.github.com/users/hassox/events{/privacy}","received_events_url":"https://api.github.com/users/hassox/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T23:24:49Z","updated_at":"2016-03-03T23:24:49Z","body":"Thanks for the report!"}}