{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/798","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/798/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/798/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/798/events","html_url":"https://github.com/GoogleChrome/lighthouse/issues/798","id":184042541,"number":798,"title":"Do not inherit from Driver, abstract Driver from establishing connection.","user":{"login":"pavelfeldman","id":883973,"avatar_url":"https://avatars.githubusercontent.com/u/883973?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelfeldman","html_url":"https://github.com/pavelfeldman","followers_url":"https://api.github.com/users/pavelfeldman/followers","following_url":"https://api.github.com/users/pavelfeldman/following{/other_user}","gists_url":"https://api.github.com/users/pavelfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelfeldman/subscriptions","organizations_url":"https://api.github.com/users/pavelfeldman/orgs","repos_url":"https://api.github.com/users/pavelfeldman/repos","events_url":"https://api.github.com/users/pavelfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/pavelfeldman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-19T18:44:17Z","updated_at":"2016-10-24T23:09:54Z","closed_at":"2016-10-24T23:09:54Z","body":"It is better to parametrize Driver with the client-provided connection that would implement following interface:\r\n\r\n```\r\nConnection {\r\n  sendCommand(command, params): Promise\r\n  on(eventName, cb) for eventName == 'notification' and 'closed'\r\n}\r\n```\r\n\r\nit also would make sense to pass established connection into the gatherer and runner in order to abstract them from the connection specifics. Neither runner not gatherer should be able to either disconnect or re-established connection.\r\n\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/255891606","html_url":"https://github.com/GoogleChrome/lighthouse/issues/798#issuecomment-255891606","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/798","id":255891606,"user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T23:09:53Z","updated_at":"2016-10-24T23:09:53Z","body":"fixed by #800 "}}
{"actor":{"display_login":"brendankenny"}}