{"action":"created","comment":{"url":"https://api.github.com/repos/Neilpang/le/pulls/comments/49934907","id":49934907,"diff_hunk":"@@ -279,6 +279,9 @@ _initpath() {\n   if [ -z \"$CA_CERT_PATH\" ] ; then\n     CA_CERT_PATH=\"$WORKING_DIR/$domain/ca.cer\"\n   fi\n+  if [ -z \"$CERT_CHAIN_PATH\" ] ; then","path":"le.sh","position":4,"original_position":4,"commit_id":"2578e495a88d4868caadeb258f3f3cf9fd28df26","original_commit_id":"b1942aa8e18afaa3f3a96f3dda33d6a312845afb","user":{"login":"samueltardieu","id":44656,"avatar_url":"https://avatars.githubusercontent.com/u/44656?v=3","gravatar_id":"","url":"https://api.github.com/users/samueltardieu","html_url":"https://github.com/samueltardieu","followers_url":"https://api.github.com/users/samueltardieu/followers","following_url":"https://api.github.com/users/samueltardieu/following{/other_user}","gists_url":"https://api.github.com/users/samueltardieu/gists{/gist_id}","starred_url":"https://api.github.com/users/samueltardieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueltardieu/subscriptions","organizations_url":"https://api.github.com/users/samueltardieu/orgs","repos_url":"https://api.github.com/users/samueltardieu/repos","events_url":"https://api.github.com/users/samueltardieu/events{/privacy}","received_events_url":"https://api.github.com/users/samueltardieu/received_events","type":"User","site_admin":false},"body":"Well, going this way, why not just concatenate the files externally to this script? For example, my reload command is a script which concatenates both files to make a full cert chain then restarts my servers. I'm not sure this is worth the added complexity when this can be automated already using the reload command argument.","created_at":"2016-01-16T17:53:54Z","updated_at":"2016-01-16T17:53:54Z","html_url":"https://github.com/Neilpang/le/pull/26#discussion_r49934907","pull_request_url":"https://api.github.com/repos/Neilpang/le/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/Neilpang/le/pulls/comments/49934907"},"html":{"href":"https://github.com/Neilpang/le/pull/26#discussion_r49934907"},"pull_request":{"href":"https://api.github.com/repos/Neilpang/le/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Neilpang/le/pulls/26","id":56258486,"html_url":"https://github.com/Neilpang/le/pull/26","diff_url":"https://github.com/Neilpang/le/pull/26.diff","patch_url":"https://github.com/Neilpang/le/pull/26.patch","issue_url":"https://api.github.com/repos/Neilpang/le/issues/26","number":26,"state":"open","locked":false,"title":"Adding full chain to LE","user":{"login":"lucasRolff","id":1076243,"avatar_url":"https://avatars.githubusercontent.com/u/1076243?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasRolff","html_url":"https://github.com/lucasRolff","followers_url":"https://api.github.com/users/lucasRolff/followers","following_url":"https://api.github.com/users/lucasRolff/following{/other_user}","gists_url":"https://api.github.com/users/lucasRolff/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasRolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasRolff/subscriptions","organizations_url":"https://api.github.com/users/lucasRolff/orgs","repos_url":"https://api.github.com/users/lucasRolff/repos","events_url":"https://api.github.com/users/lucasRolff/events{/privacy}","received_events_url":"https://api.github.com/users/lucasRolff/received_events","type":"User","site_admin":false},"body":"- Added functionality to create a fullchain cert file, I didn't add it as a 'RealPath' option, because it would either have to be in the last argument, or we would shift other arguments, which would not be backward compatible.\r\n\r\n@Neilpang I don't know if you require more places for this to be changed, I think I covered the most.\r\n\r\nCode is tested, and it actually creates the fullchain.pem file as well!","created_at":"2016-01-16T17:38:24Z","updated_at":"2016-01-16T17:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c341e6292d5f5d5becc98ce7b6079ced8c6e6505","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Neilpang/le/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Neilpang/le/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Neilpang/le/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neilpang/le/issues/26/comments","statuses_url":"https://api.github.com/repos/Neilpang/le/statuses/2578e495a88d4868caadeb258f3f3cf9fd28df26","head":{"label":"lucasRolff:add_fullchain","ref":"add_fullchain","sha":"2578e495a88d4868caadeb258f3f3cf9fd28df26","user":{"login":"lucasRolff","id":1076243,"avatar_url":"https://avatars.githubusercontent.com/u/1076243?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasRolff","html_url":"https://github.com/lucasRolff","followers_url":"https://api.github.com/users/lucasRolff/followers","following_url":"https://api.github.com/users/lucasRolff/following{/other_user}","gists_url":"https://api.github.com/users/lucasRolff/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasRolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasRolff/subscriptions","organizations_url":"https://api.github.com/users/lucasRolff/orgs","repos_url":"https://api.github.com/users/lucasRolff/repos","events_url":"https://api.github.com/users/lucasRolff/events{/privacy}","received_events_url":"https://api.github.com/users/lucasRolff/received_events","type":"User","site_admin":false},"repo":{"id":49514988,"name":"le","full_name":"lucasRolff/le","owner":{"login":"lucasRolff","id":1076243,"avatar_url":"https://avatars.githubusercontent.com/u/1076243?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasRolff","html_url":"https://github.com/lucasRolff","followers_url":"https://api.github.com/users/lucasRolff/followers","following_url":"https://api.github.com/users/lucasRolff/following{/other_user}","gists_url":"https://api.github.com/users/lucasRolff/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasRolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasRolff/subscriptions","organizations_url":"https://api.github.com/users/lucasRolff/orgs","repos_url":"https://api.github.com/users/lucasRolff/repos","events_url":"https://api.github.com/users/lucasRolff/events{/privacy}","received_events_url":"https://api.github.com/users/lucasRolff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasRolff/le","description":"Simplest shell script for LetsEncrypt free Certificate client","fork":true,"url":"https://api.github.com/repos/lucasRolff/le","forks_url":"https://api.github.com/repos/lucasRolff/le/forks","keys_url":"https://api.github.com/repos/lucasRolff/le/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasRolff/le/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasRolff/le/teams","hooks_url":"https://api.github.com/repos/lucasRolff/le/hooks","issue_events_url":"https://api.github.com/repos/lucasRolff/le/issues/events{/number}","events_url":"https://api.github.com/repos/lucasRolff/le/events","assignees_url":"https://api.github.com/repos/lucasRolff/le/assignees{/user}","branches_url":"https://api.github.com/repos/lucasRolff/le/branches{/branch}","tags_url":"https://api.github.com/repos/lucasRolff/le/tags","blobs_url":"https://api.github.com/repos/lucasRolff/le/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasRolff/le/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasRolff/le/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasRolff/le/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasRolff/le/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasRolff/le/languages","stargazers_url":"https://api.github.com/repos/lucasRolff/le/stargazers","contributors_url":"https://api.github.com/repos/lucasRolff/le/contributors","subscribers_url":"https://api.github.com/repos/lucasRolff/le/subscribers","subscription_url":"https://api.github.com/repos/lucasRolff/le/subscription","commits_url":"https://api.github.com/repos/lucasRolff/le/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasRolff/le/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasRolff/le/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasRolff/le/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasRolff/le/contents/{+path}","compare_url":"https://api.github.com/repos/lucasRolff/le/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasRolff/le/merges","archive_url":"https://api.github.com/repos/lucasRolff/le/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasRolff/le/downloads","issues_url":"https://api.github.com/repos/lucasRolff/le/issues{/number}","pulls_url":"https://api.github.com/repos/lucasRolff/le/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasRolff/le/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasRolff/le/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasRolff/le/labels{/name}","releases_url":"https://api.github.com/repos/lucasRolff/le/releases{/id}","created_at":"2016-01-12T16:55:26Z","updated_at":"2016-01-12T16:55:27Z","pushed_at":"2016-01-16T17:47:12Z","git_url":"git://github.com/lucasRolff/le.git","ssh_url":"git@github.com:lucasRolff/le.git","clone_url":"https://github.com/lucasRolff/le.git","svn_url":"https://github.com/lucasRolff/le","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Neilpang:master","ref":"master","sha":"2bd7774b8f9e362acdd244d5dba7c693a4a595c7","user":{"login":"Neilpang","id":8305679,"avatar_url":"https://avatars.githubusercontent.com/u/8305679?v=3","gravatar_id":"","url":"https://api.github.com/users/Neilpang","html_url":"https://github.com/Neilpang","followers_url":"https://api.github.com/users/Neilpang/followers","following_url":"https://api.github.com/users/Neilpang/following{/other_user}","gists_url":"https://api.github.com/users/Neilpang/gists{/gist_id}","starred_url":"https://api.github.com/users/Neilpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neilpang/subscriptions","organizations_url":"https://api.github.com/users/Neilpang/orgs","repos_url":"https://api.github.com/users/Neilpang/repos","events_url":"https://api.github.com/users/Neilpang/events{/privacy}","received_events_url":"https://api.github.com/users/Neilpang/received_events","type":"User","site_admin":false},"repo":{"id":48610662,"name":"le","full_name":"Neilpang/le","owner":{"login":"Neilpang","id":8305679,"avatar_url":"https://avatars.githubusercontent.com/u/8305679?v=3","gravatar_id":"","url":"https://api.github.com/users/Neilpang","html_url":"https://github.com/Neilpang","followers_url":"https://api.github.com/users/Neilpang/followers","following_url":"https://api.github.com/users/Neilpang/following{/other_user}","gists_url":"https://api.github.com/users/Neilpang/gists{/gist_id}","starred_url":"https://api.github.com/users/Neilpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neilpang/subscriptions","organizations_url":"https://api.github.com/users/Neilpang/orgs","repos_url":"https://api.github.com/users/Neilpang/repos","events_url":"https://api.github.com/users/Neilpang/events{/privacy}","received_events_url":"https://api.github.com/users/Neilpang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neilpang/le","description":"Simplest shell script for LetsEncrypt free Certificate client","fork":false,"url":"https://api.github.com/repos/Neilpang/le","forks_url":"https://api.github.com/repos/Neilpang/le/forks","keys_url":"https://api.github.com/repos/Neilpang/le/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neilpang/le/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neilpang/le/teams","hooks_url":"https://api.github.com/repos/Neilpang/le/hooks","issue_events_url":"https://api.github.com/repos/Neilpang/le/issues/events{/number}","events_url":"https://api.github.com/repos/Neilpang/le/events","assignees_url":"https://api.github.com/repos/Neilpang/le/assignees{/user}","branches_url":"https://api.github.com/repos/Neilpang/le/branches{/branch}","tags_url":"https://api.github.com/repos/Neilpang/le/tags","blobs_url":"https://api.github.com/repos/Neilpang/le/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neilpang/le/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neilpang/le/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neilpang/le/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neilpang/le/statuses/{sha}","languages_url":"https://api.github.com/repos/Neilpang/le/languages","stargazers_url":"https://api.github.com/repos/Neilpang/le/stargazers","contributors_url":"https://api.github.com/repos/Neilpang/le/contributors","subscribers_url":"https://api.github.com/repos/Neilpang/le/subscribers","subscription_url":"https://api.github.com/repos/Neilpang/le/subscription","commits_url":"https://api.github.com/repos/Neilpang/le/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neilpang/le/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neilpang/le/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neilpang/le/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neilpang/le/contents/{+path}","compare_url":"https://api.github.com/repos/Neilpang/le/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neilpang/le/merges","archive_url":"https://api.github.com/repos/Neilpang/le/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neilpang/le/downloads","issues_url":"https://api.github.com/repos/Neilpang/le/issues{/number}","pulls_url":"https://api.github.com/repos/Neilpang/le/pulls{/number}","milestones_url":"https://api.github.com/repos/Neilpang/le/milestones{/number}","notifications_url":"https://api.github.com/repos/Neilpang/le/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neilpang/le/labels{/name}","releases_url":"https://api.github.com/repos/Neilpang/le/releases{/id}","created_at":"2015-12-26T12:56:33Z","updated_at":"2016-01-16T12:38:06Z","pushed_at":"2016-01-16T17:47:12Z","git_url":"git://github.com/Neilpang/le.git","ssh_url":"git@github.com:Neilpang/le.git","clone_url":"https://github.com/Neilpang/le.git","svn_url":"https://github.com/Neilpang/le","homepage":null,"size":57,"stargazers_count":279,"watchers_count":279,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neilpang/le/pulls/26"},"html":{"href":"https://github.com/Neilpang/le/pull/26"},"issue":{"href":"https://api.github.com/repos/Neilpang/le/issues/26"},"comments":{"href":"https://api.github.com/repos/Neilpang/le/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Neilpang/le/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Neilpang/le/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neilpang/le/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Neilpang/le/statuses/2578e495a88d4868caadeb258f3f3cf9fd28df26"}}}}