{"action":"created","comment":{"url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/comments/91807806","pull_request_review_id":12321404,"id":91807806,"diff_hunk":"@@ -0,0 +1,51 @@\n+#pragma once\n+\n+#include <sys/mman.h>\n+#include <sys/stat.h> \n+#include <fcntl.h>\n+#include <unistd.h>\n+#include <vector>\n+\n+using namespace std;\n+\n+\n+class StreamBuffer {\n+    private:\n+        char *data = 0;","path":"src/stream_buffer.hpp","position":14,"original_position":14,"commit_id":"680c53ad7f7307cb0bb7476711eb03f62f0c0b2e","original_commit_id":"680c53ad7f7307cb0bb7476711eb03f62f0c0b2e","user":{"login":"shi-adroll","id":21319673,"avatar_url":"https://avatars.githubusercontent.com/u/21319673?v=3","gravatar_id":"","url":"https://api.github.com/users/shi-adroll","html_url":"https://github.com/shi-adroll","followers_url":"https://api.github.com/users/shi-adroll/followers","following_url":"https://api.github.com/users/shi-adroll/following{/other_user}","gists_url":"https://api.github.com/users/shi-adroll/gists{/gist_id}","starred_url":"https://api.github.com/users/shi-adroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shi-adroll/subscriptions","organizations_url":"https://api.github.com/users/shi-adroll/orgs","repos_url":"https://api.github.com/users/shi-adroll/repos","events_url":"https://api.github.com/users/shi-adroll/events{/privacy}","received_events_url":"https://api.github.com/users/shi-adroll/received_events","type":"User","site_admin":false},"body":"We dont need to initialize here. Use the initializer list in the constructor. See: https://github.com/vladkluev/lazy-msgunpacker/blob/master/src/indexer.hpp#L32","created_at":"2016-12-09T22:25:42Z","updated_at":"2016-12-09T22:25:42Z","html_url":"https://github.com/vladkluev/lazy-msgunpacker/pull/10#discussion_r91807806","pull_request_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/comments/91807806"},"html":{"href":"https://github.com/vladkluev/lazy-msgunpacker/pull/10#discussion_r91807806"},"pull_request":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10","id":97389779,"html_url":"https://github.com/vladkluev/lazy-msgunpacker/pull/10","diff_url":"https://github.com/vladkluev/lazy-msgunpacker/pull/10.diff","patch_url":"https://github.com/vladkluev/lazy-msgunpacker/pull/10.patch","issue_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/10","number":10,"state":"open","locked":false,"title":"Add stream buffer to reduce I/O calls","user":{"login":"rcjmurillo","id":430501,"avatar_url":"https://avatars.githubusercontent.com/u/430501?v=3","gravatar_id":"","url":"https://api.github.com/users/rcjmurillo","html_url":"https://github.com/rcjmurillo","followers_url":"https://api.github.com/users/rcjmurillo/followers","following_url":"https://api.github.com/users/rcjmurillo/following{/other_user}","gists_url":"https://api.github.com/users/rcjmurillo/gists{/gist_id}","starred_url":"https://api.github.com/users/rcjmurillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcjmurillo/subscriptions","organizations_url":"https://api.github.com/users/rcjmurillo/orgs","repos_url":"https://api.github.com/users/rcjmurillo/repos","events_url":"https://api.github.com/users/rcjmurillo/events{/privacy}","received_events_url":"https://api.github.com/users/rcjmurillo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-09T22:13:36Z","updated_at":"2016-12-09T22:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df19bb5e0a1f7755ee13773ac9246e0733db603a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10/commits","review_comments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10/comments","review_comment_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/10/comments","statuses_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/statuses/680c53ad7f7307cb0bb7476711eb03f62f0c0b2e","head":{"label":"vladkluev:stream-buffer","ref":"stream-buffer","sha":"680c53ad7f7307cb0bb7476711eb03f62f0c0b2e","user":{"login":"vladkluev","id":3169433,"avatar_url":"https://avatars.githubusercontent.com/u/3169433?v=3","gravatar_id":"","url":"https://api.github.com/users/vladkluev","html_url":"https://github.com/vladkluev","followers_url":"https://api.github.com/users/vladkluev/followers","following_url":"https://api.github.com/users/vladkluev/following{/other_user}","gists_url":"https://api.github.com/users/vladkluev/gists{/gist_id}","starred_url":"https://api.github.com/users/vladkluev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladkluev/subscriptions","organizations_url":"https://api.github.com/users/vladkluev/orgs","repos_url":"https://api.github.com/users/vladkluev/repos","events_url":"https://api.github.com/users/vladkluev/events{/privacy}","received_events_url":"https://api.github.com/users/vladkluev/received_events","type":"User","site_admin":false},"repo":{"id":75666974,"name":"lazy-msgunpacker","full_name":"vladkluev/lazy-msgunpacker","owner":{"login":"vladkluev","id":3169433,"avatar_url":"https://avatars.githubusercontent.com/u/3169433?v=3","gravatar_id":"","url":"https://api.github.com/users/vladkluev","html_url":"https://github.com/vladkluev","followers_url":"https://api.github.com/users/vladkluev/followers","following_url":"https://api.github.com/users/vladkluev/following{/other_user}","gists_url":"https://api.github.com/users/vladkluev/gists{/gist_id}","starred_url":"https://api.github.com/users/vladkluev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladkluev/subscriptions","organizations_url":"https://api.github.com/users/vladkluev/orgs","repos_url":"https://api.github.com/users/vladkluev/repos","events_url":"https://api.github.com/users/vladkluev/events{/privacy}","received_events_url":"https://api.github.com/users/vladkluev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladkluev/lazy-msgunpacker","description":"Unpacking REALLY large msgpack messages with minimal memory footprint","fork":false,"url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker","forks_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/forks","keys_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/teams","hooks_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/hooks","issue_events_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/events{/number}","events_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/events","assignees_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/assignees{/user}","branches_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/branches{/branch}","tags_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/tags","blobs_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/languages","stargazers_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/stargazers","contributors_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/contributors","subscribers_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/subscribers","subscription_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/subscription","commits_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/contents/{+path}","compare_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/merges","archive_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/downloads","issues_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues{/number}","pulls_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/labels{/name}","releases_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/releases{/id}","deployments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/deployments","created_at":"2016-12-05T21:16:35Z","updated_at":"2016-12-06T19:14:12Z","pushed_at":"2016-12-09T22:22:37Z","git_url":"git://github.com/vladkluev/lazy-msgunpacker.git","ssh_url":"git@github.com:vladkluev/lazy-msgunpacker.git","clone_url":"https://github.com/vladkluev/lazy-msgunpacker.git","svn_url":"https://github.com/vladkluev/lazy-msgunpacker","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vladkluev:master","ref":"master","sha":"e26cfd1290e85f5987f58109d5e81d6b5d94c4c8","user":{"login":"vladkluev","id":3169433,"avatar_url":"https://avatars.githubusercontent.com/u/3169433?v=3","gravatar_id":"","url":"https://api.github.com/users/vladkluev","html_url":"https://github.com/vladkluev","followers_url":"https://api.github.com/users/vladkluev/followers","following_url":"https://api.github.com/users/vladkluev/following{/other_user}","gists_url":"https://api.github.com/users/vladkluev/gists{/gist_id}","starred_url":"https://api.github.com/users/vladkluev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladkluev/subscriptions","organizations_url":"https://api.github.com/users/vladkluev/orgs","repos_url":"https://api.github.com/users/vladkluev/repos","events_url":"https://api.github.com/users/vladkluev/events{/privacy}","received_events_url":"https://api.github.com/users/vladkluev/received_events","type":"User","site_admin":false},"repo":{"id":75666974,"name":"lazy-msgunpacker","full_name":"vladkluev/lazy-msgunpacker","owner":{"login":"vladkluev","id":3169433,"avatar_url":"https://avatars.githubusercontent.com/u/3169433?v=3","gravatar_id":"","url":"https://api.github.com/users/vladkluev","html_url":"https://github.com/vladkluev","followers_url":"https://api.github.com/users/vladkluev/followers","following_url":"https://api.github.com/users/vladkluev/following{/other_user}","gists_url":"https://api.github.com/users/vladkluev/gists{/gist_id}","starred_url":"https://api.github.com/users/vladkluev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladkluev/subscriptions","organizations_url":"https://api.github.com/users/vladkluev/orgs","repos_url":"https://api.github.com/users/vladkluev/repos","events_url":"https://api.github.com/users/vladkluev/events{/privacy}","received_events_url":"https://api.github.com/users/vladkluev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladkluev/lazy-msgunpacker","description":"Unpacking REALLY large msgpack messages with minimal memory footprint","fork":false,"url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker","forks_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/forks","keys_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/teams","hooks_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/hooks","issue_events_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/events{/number}","events_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/events","assignees_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/assignees{/user}","branches_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/branches{/branch}","tags_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/tags","blobs_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/languages","stargazers_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/stargazers","contributors_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/contributors","subscribers_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/subscribers","subscription_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/subscription","commits_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/contents/{+path}","compare_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/merges","archive_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/downloads","issues_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues{/number}","pulls_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/labels{/name}","releases_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/releases{/id}","deployments_url":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/deployments","created_at":"2016-12-05T21:16:35Z","updated_at":"2016-12-06T19:14:12Z","pushed_at":"2016-12-09T22:22:37Z","git_url":"git://github.com/vladkluev/lazy-msgunpacker.git","ssh_url":"git@github.com:vladkluev/lazy-msgunpacker.git","clone_url":"https://github.com/vladkluev/lazy-msgunpacker.git","svn_url":"https://github.com/vladkluev/lazy-msgunpacker","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10"},"html":{"href":"https://github.com/vladkluev/lazy-msgunpacker/pull/10"},"issue":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/10"},"comments":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/vladkluev/lazy-msgunpacker/statuses/680c53ad7f7307cb0bb7476711eb03f62f0c0b2e"}}}}
{"actor":{"display_login":"shi-adroll"}}