{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/88528290","pull_request_review_id":9100029,"id":88528290,"diff_hunk":"@@ -2122,7 +2128,6 @@ def build_tests(tests, base_source_paths, build_path, target, toolchain_name,\n \n     Returns a tuple of the build result (True or False) followed by the test\n     build data structure\"\"\"\n-","path":"tools/test_api.py","position":17,"original_position":17,"commit_id":"05140dcf57bee64bfa38c78a00d5430486e50a8d","original_commit_id":"05140dcf57bee64bfa38c78a00d5430486e50a8d","user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"body":"¯\\_(ツ)_/¯","created_at":"2016-11-17T19:31:37Z","updated_at":"2016-11-17T19:31:37Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/3274#discussion_r88528290","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/88528290"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3274#discussion_r88528290"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274","id":94077739,"html_url":"https://github.com/ARMmbed/mbed-os/pull/3274","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3274.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3274.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3274","number":3274,"state":"open","locked":false,"title":"Passing toolchain path info to subprocesses","user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"body":"## Description\r\nSince the toolchain path info lives as a global variable, its not\r\npropagating to the subprocesses that are created to compile the tests in\r\nparallel. This change manually passes these global variables and then\r\nreassigns them.\r\n\r\nThis seems to only be an issue with the IAR compiler, however I haven't thoroughly tested every environemnt and every compiler.\r\n\r\n\r\n## Status\r\n**READY**\r\n\r\n\r\n## Migrations\r\nIf this PR changes any APIs or behaviors, give a short description of what *API users* should do when this PR is merged.\r\n\r\nNO\r\n\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [x]  Review by @theotherjimmy \r\n\r\n## Steps to test or reproduce\r\nOn a machine with the IAR compiler in the system PATH (`iccarm.exe`), run `mbed test --compile -m K64F -t IAR`. It will complete the library build but fail to build any tests.\r\n\r\nSwitch to these changes and the same command should complete successfully.\r\n\r\n@maclobdell This may explain some of the issues you were seeing","created_at":"2016-11-17T00:11:37Z","updated_at":"2016-11-17T19:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d3a93554bb09c9d613a12893ccca14e57e03a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3274/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/05140dcf57bee64bfa38c78a00d5430486e50a8d","head":{"label":"bridadan:fix-path-detection-test-building","ref":"fix-path-detection-test-building","sha":"05140dcf57bee64bfa38c78a00d5430486e50a8d","user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"repo":{"id":31221716,"name":"mbed","full_name":"bridadan/mbed","owner":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bridadan/mbed","description":"mbed libraries and tools","fork":true,"url":"https://api.github.com/repos/bridadan/mbed","forks_url":"https://api.github.com/repos/bridadan/mbed/forks","keys_url":"https://api.github.com/repos/bridadan/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bridadan/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bridadan/mbed/teams","hooks_url":"https://api.github.com/repos/bridadan/mbed/hooks","issue_events_url":"https://api.github.com/repos/bridadan/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/bridadan/mbed/events","assignees_url":"https://api.github.com/repos/bridadan/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/bridadan/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/bridadan/mbed/tags","blobs_url":"https://api.github.com/repos/bridadan/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bridadan/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bridadan/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/bridadan/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bridadan/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/bridadan/mbed/languages","stargazers_url":"https://api.github.com/repos/bridadan/mbed/stargazers","contributors_url":"https://api.github.com/repos/bridadan/mbed/contributors","subscribers_url":"https://api.github.com/repos/bridadan/mbed/subscribers","subscription_url":"https://api.github.com/repos/bridadan/mbed/subscription","commits_url":"https://api.github.com/repos/bridadan/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/bridadan/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/bridadan/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/bridadan/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/bridadan/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/bridadan/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bridadan/mbed/merges","archive_url":"https://api.github.com/repos/bridadan/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bridadan/mbed/downloads","issues_url":"https://api.github.com/repos/bridadan/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/bridadan/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/bridadan/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/bridadan/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bridadan/mbed/labels{/name}","releases_url":"https://api.github.com/repos/bridadan/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/bridadan/mbed/deployments","created_at":"2015-02-23T18:09:54Z","updated_at":"2016-02-22T21:41:48Z","pushed_at":"2016-11-16T23:59:33Z","git_url":"git://github.com/bridadan/mbed.git","ssh_url":"git@github.com:bridadan/mbed.git","clone_url":"https://github.com/bridadan/mbed.git","svn_url":"https://github.com/bridadan/mbed","homepage":null,"size":95453,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"aeabcc947294f2a6cbe1e808c030779c7c460f10","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-11-17T17:37:21Z","pushed_at":"2016-11-17T18:40:56Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":121017,"stargazers_count":817,"watchers_count":817,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":801,"mirror_url":null,"open_issues_count":407,"forks":801,"open_issues":407,"watchers":817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3274"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3274"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3274/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3274/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/05140dcf57bee64bfa38c78a00d5430486e50a8d"}}}}
{"actor":{"display_login":"theotherjimmy"}}