{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/71257863","id":71257863,"diff_hunk":"@@ -336,6 +337,7 @@ func (response *InboundCallResponse) SendSystemError(err error) error {\n \t// Fail all future attempts to read fragments\n \tresponse.state = reqResWriterComplete\n \tresponse.systemError = true\n+\tresponse.errorType = GetSystemErrorMetricKey(err)","path":"inbound.go","position":12,"original_position":12,"commit_id":"dd204ed15a57a5161399053ed96943d845c3e0ab","original_commit_id":"dd204ed15a57a5161399053ed96943d845c3e0ab","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":"this is not the only way a response may fail. This is only if the caller specifically wants to return an error.\r\n\r\nhowever, there's errors that happen on the connection (e.g. timeout, cancellation, network failures) which would not go through this path.\r\n\r\nWe should unit test to make sure that the above scenarios work (timeout and network failure are the ones we tend to care about).","created_at":"2016-07-19T01:00:25Z","updated_at":"2016-07-19T01:00:25Z","html_url":"https://github.com/uber/tchannel-go/pull/448#discussion_r71257863","pull_request_url":"https://api.github.com/repos/uber/tchannel-go/pulls/448","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/71257863"},"html":{"href":"https://github.com/uber/tchannel-go/pull/448#discussion_r71257863"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/448"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/448","id":77902640,"html_url":"https://github.com/uber/tchannel-go/pull/448","diff_url":"https://github.com/uber/tchannel-go/pull/448.diff","patch_url":"https://github.com/uber/tchannel-go/pull/448.patch","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/448","number":448,"state":"open","locked":false,"title":"Emit system error as per metrics document","user":{"login":"liweiqing","id":17131859,"avatar_url":"https://avatars.githubusercontent.com/u/17131859?v=3","gravatar_id":"","url":"https://api.github.com/users/liweiqing","html_url":"https://github.com/liweiqing","followers_url":"https://api.github.com/users/liweiqing/followers","following_url":"https://api.github.com/users/liweiqing/following{/other_user}","gists_url":"https://api.github.com/users/liweiqing/gists{/gist_id}","starred_url":"https://api.github.com/users/liweiqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liweiqing/subscriptions","organizations_url":"https://api.github.com/users/liweiqing/orgs","repos_url":"https://api.github.com/users/liweiqing/repos","events_url":"https://api.github.com/users/liweiqing/events{/privacy}","received_events_url":"https://api.github.com/users/liweiqing/received_events","type":"User","site_admin":false},"body":"Emit system error as per metrics document.","created_at":"2016-07-19T00:49:47Z","updated_at":"2016-07-19T01:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"827ed1dd3faf7ecd639b1bc566e6ad0afb69f927","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-go/pulls/448/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-go/pulls/448/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/448/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/dd204ed15a57a5161399053ed96943d845c3e0ab","head":{"label":"uber:systemErrorMetrics","ref":"systemErrorMetrics","sha":"dd204ed15a57a5161399053ed96943d845c3e0ab","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"Go implementation of a multiplexing and framing protocol for RPC calls","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/tchannel-go/deployments","created_at":"2015-09-18T18:28:15Z","updated_at":"2016-07-15T12:09:24Z","pushed_at":"2016-07-19T00:53:19Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":"http://uber.github.io/tchannel/","size":2722,"stargazers_count":128,"watchers_count":128,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":32,"forks":17,"open_issues":32,"watchers":128,"default_branch":"dev"}},"base":{"label":"uber:dev","ref":"dev","sha":"369c90df7a80a0e732b83121771f1b930aa1e0bd","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"Go implementation of a multiplexing and framing protocol for RPC calls","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/tchannel-go/deployments","created_at":"2015-09-18T18:28:15Z","updated_at":"2016-07-15T12:09:24Z","pushed_at":"2016-07-19T00:53:19Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":"http://uber.github.io/tchannel/","size":2722,"stargazers_count":128,"watchers_count":128,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":32,"forks":17,"open_issues":32,"watchers":128,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/448"},"html":{"href":"https://github.com/uber/tchannel-go/pull/448"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/448"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-go/statuses/dd204ed15a57a5161399053ed96943d845c3e0ab"}}}}
{"actor":{"display_login":"prashantv"}}