{"action":"created","issue":{"url":"https://api.github.com/repos/weavejester/cljfmt/issues/80","repository_url":"https://api.github.com/repos/weavejester/cljfmt","labels_url":"https://api.github.com/repos/weavejester/cljfmt/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/weavejester/cljfmt/issues/80/comments","events_url":"https://api.github.com/repos/weavejester/cljfmt/issues/80/events","html_url":"https://github.com/weavejester/cljfmt/pull/80","id":177409900,"number":80,"title":"Don't add whitespace after reader conditionals","user":{"login":"jetmind","id":849266,"avatar_url":"https://avatars.githubusercontent.com/u/849266?v=3","gravatar_id":"","url":"https://api.github.com/users/jetmind","html_url":"https://github.com/jetmind","followers_url":"https://api.github.com/users/jetmind/followers","following_url":"https://api.github.com/users/jetmind/following{/other_user}","gists_url":"https://api.github.com/users/jetmind/gists{/gist_id}","starred_url":"https://api.github.com/users/jetmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetmind/subscriptions","organizations_url":"https://api.github.com/users/jetmind/orgs","repos_url":"https://api.github.com/users/jetmind/repos","events_url":"https://api.github.com/users/jetmind/events{/privacy}","received_events_url":"https://api.github.com/users/jetmind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-16T12:06:46Z","updated_at":"2016-09-16T12:35:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weavejester/cljfmt/pulls/80","html_url":"https://github.com/weavejester/cljfmt/pull/80","diff_url":"https://github.com/weavejester/cljfmt/pull/80.diff","patch_url":"https://github.com/weavejester/cljfmt/pull/80.patch"},"body":"This updates `rewrite-clj` & `rewrite-cljs` to newest versions and restricts missing whitespace check for reader conditionals."},"comment":{"url":"https://api.github.com/repos/weavejester/cljfmt/issues/comments/247589458","html_url":"https://github.com/weavejester/cljfmt/pull/80#issuecomment-247589458","issue_url":"https://api.github.com/repos/weavejester/cljfmt/issues/80","id":247589458,"user":{"login":"jetmind","id":849266,"avatar_url":"https://avatars.githubusercontent.com/u/849266?v=3","gravatar_id":"","url":"https://api.github.com/users/jetmind","html_url":"https://github.com/jetmind","followers_url":"https://api.github.com/users/jetmind/followers","following_url":"https://api.github.com/users/jetmind/following{/other_user}","gists_url":"https://api.github.com/users/jetmind/gists{/gist_id}","starred_url":"https://api.github.com/users/jetmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetmind/subscriptions","organizations_url":"https://api.github.com/users/jetmind/orgs","repos_url":"https://api.github.com/users/jetmind/repos","events_url":"https://api.github.com/users/jetmind/events{/privacy}","received_events_url":"https://api.github.com/users/jetmind/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T12:35:05Z","updated_at":"2016-09-16T12:35:05Z","body":"Added a test. The test fails on master as following:\r\n\r\n```\r\nFAIL in (missing-whitespace-reader-conditionals) (core_test.cljc:162)\r\nexpected: (= (reformat-string \"#?(:cljs(bar 1) :clj(foo 2))\") \"#?(:cljs (bar 1) :clj (foo 2))\")\r\n  actual: (not (= \"#? (:cljs (bar 1) :clj (foo 2))\" \"#?(:cljs (bar 1) :clj (foo 2))\"))\r\n\r\nFAIL in (missing-whitespace-reader-conditionals) (core_test.cljc:164)\r\nexpected: (= (reformat-string \"#?@(:cljs[foo bar] :clj[baz quux])\") \"#?@(:cljs [foo bar] :clj [baz quux])\")\r\n  actual: (not (= \"#? @(:cljs [foo bar] :clj [baz quux])\" \"#?@(:cljs [foo bar] :clj [baz quux])\"))\r\n```\r\n\r\nYou can see that it adds unneeded whitespace between `#?` and following form or between `#?` and `@` for splicing version of conditional. I hope this clarifies why this check is needed."}}
{"actor":{"display_login":"jetmind"}}