{"action":"closed","number":2405,"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405","id":65421686,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/2405","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/2405.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/2405.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2405","number":2405,"state":"closed","locked":false,"title":"[SP-2639] Backport of PDI-14950 - Spoon does not pass instanceName parameter to MSSQL Server JDBC connection string (6.1 Suite)","user":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"body":"-  Validating extra parameter value before appending it's key to url.\r\n- Tests written\r\n- Checking whether the underlying database for two DatabaseInterface's is the same depending on the class hierarchy (if check by pluginId fails).\r\n\r\n@brosander , could you review it please?\r\nIt is a **backport** for this PR's: https://github.com/pentaho/pentaho-kettle/pull/2311, https://github.com/pentaho/pentaho-kettle/pull/2342,  https://github.com/pentaho/pentaho-kettle/pull/2355","created_at":"2016-04-06T07:33:20Z","updated_at":"2016-04-06T08:48:05Z","closed_at":"2016-04-06T08:48:05Z","merged_at":"2016-04-06T08:48:05Z","merge_commit_sha":"d886bcced709c1d117ccbb082a06bf986b4b3540","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2405/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/7feee4351c3d7ccddd70a52b9af67689c72298b3","head":{"label":"IvanNikolaychuk:SP-2639","ref":"SP-2639","sha":"7feee4351c3d7ccddd70a52b9af67689c72298b3","user":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"repo":{"id":43285015,"name":"pentaho-kettle","full_name":"IvanNikolaychuk/pentaho-kettle","owner":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IvanNikolaychuk/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle","forks_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/deployments","created_at":"2015-09-28T06:57:59Z","updated_at":"2015-09-28T06:58:46Z","pushed_at":"2016-04-06T07:58:46Z","git_url":"git://github.com/IvanNikolaychuk/pentaho-kettle.git","ssh_url":"git@github.com:IvanNikolaychuk/pentaho-kettle.git","clone_url":"https://github.com/IvanNikolaychuk/pentaho-kettle.git","svn_url":"https://github.com/IvanNikolaychuk/pentaho-kettle","homepage":null,"size":500026,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:6.1","ref":"6.1","sha":"0ff8fa7993b982493b7a2f71bbebd912b89b06fa","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/deployments","created_at":"2013-10-08T18:27:11Z","updated_at":"2016-04-05T18:11:33Z","pushed_at":"2016-04-06T08:48:06Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":504745,"stargazers_count":517,"watchers_count":517,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"open_issues_count":45,"forks":601,"open_issues":45,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/2405"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2405"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2405/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2405/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/7feee4351c3d7ccddd70a52b9af67689c72298b3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pamval","id":347476,"avatar_url":"https://avatars.githubusercontent.com/u/347476?v=3","gravatar_id":"","url":"https://api.github.com/users/pamval","html_url":"https://github.com/pamval","followers_url":"https://api.github.com/users/pamval/followers","following_url":"https://api.github.com/users/pamval/following{/other_user}","gists_url":"https://api.github.com/users/pamval/gists{/gist_id}","starred_url":"https://api.github.com/users/pamval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamval/subscriptions","organizations_url":"https://api.github.com/users/pamval/orgs","repos_url":"https://api.github.com/users/pamval/repos","events_url":"https://api.github.com/users/pamval/events{/privacy}","received_events_url":"https://api.github.com/users/pamval/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":338,"deletions":46,"changed_files":3}}