{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/6248","repository_url":"https://api.github.com/repos/coreos/etcd","labels_url":"https://api.github.com/repos/coreos/etcd/issues/6248/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6248/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/6248/events","html_url":"https://github.com/coreos/etcd/pull/6248","id":172613664,"number":6248,"title":"mvcc: only write txn should update index","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-23T05:12:17Z","updated_at":"2016-08-23T05:54:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6248","html_url":"https://github.com/coreos/etcd/pull/6248","diff_url":"https://github.com/coreos/etcd/pull/6248.diff","patch_url":"https://github.com/coreos/etcd/pull/6248.patch"},"body":"What can happen before:\r\n\r\na. etcdserver.updateIndex(100) in applyEntryNormal.\r\nb. mvcc.range -> saveIndex(100) [range can happen concurrently with applyAll]\r\n\r\n---- (etcd can die right here) ----\r\n\r\nc. mvcc.put -> saveIndex(100) foo -> bar\r\n\r\nif etcd does not die after b, when we restart etcd we can see foo = bar\r\n\r\nif etcd dies after b, when we restart etcd we will not see foo = bar. that is because after the restart, the consistent index is 100. etcd will skip apply mvcc.put at c.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/241634065","html_url":"https://github.com/coreos/etcd/pull/6248#issuecomment-241634065","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6248","id":241634065,"user":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T05:54:43Z","updated_at":"2016-08-23T05:54:43Z","body":"lgtm\r\n\r\nmight be worth checking the new consistent index is greater than the last saved consistent index?"}}
{"actor":{"display_login":"heyitsanthony"}}