{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments/69055076","id":69055076,"diff_hunk":"@@ -228,50 +408,49 @@ def _pixelCoordsFromRaDec(ra, dec, obs_metadata=None, epoch=None,\n     and the second row is the y pixel coordinate\n     \"\"\"\n \n+    are_arrays, \\\n+    chipNameList = _validate_inputs_and_chipname([ra, dec], ['ra', 'dec'],\n+                                                 'pixelCoordsFromRaDec',\n+                                                 chipName)\n+\n     if epoch is None:\n         raise RuntimeError(\"You need to pass an epoch into pixelCoordsFromRaDec\")\n \n     if obs_metadata is None:\n         raise RuntimeError(\"You need to pass an ObservationMetaData into pixelCoordsFromRaDec\")\n \n     if obs_metadata.mjd is None:\n-        raise RuntimeError(\"You need to pass an ObservationMetaData with an mjd into \" \\\n-                           + \"pixelCoordsFromRaDec\")\n+        raise RuntimeError(\"You need to pass an ObservationMetaData with an mjd into \"\n+                           \"pixelCoordsFromRaDec\")\n \n     if obs_metadata.rotSkyPos is None:\n-        raise RuntimeError(\"You need to pass an ObservationMetaData with a rotSkyPos into \" \\\n-                           + \"pixelCoordsFromRaDec\")\n-\n-    if not isinstance(ra, numpy.ndarray) or not isinstance(dec, numpy.ndarray):\n-        raise RuntimeError(\"You need to pass numpy arrays of RA and Dec to pixelCoordsFromRaDec\")\n-\n-    if len(ra) != len(dec):\n-        raise RuntimeError(\"You passed %d RA and %d Dec coordinates \" % (len(ra), len(dec)) +\n-                           \"to pixelCoordsFromRaDec\")\n-\n-    if chipNames is not None:\n-        if len(ra) != len(chipNames):\n-            raise RuntimeError(\"You passed %d points but %d chipNames to pixelCoordsFromRaDec\" %\n-                               (len(ra), len(chipNames)))\n+        raise RuntimeError(\"You need to pass an ObservationMetaData with a rotSkyPos into \"\n+                           \"pixelCoordsFromRaDec\")\n \n     xPupil, yPupil = _pupilCoordsFromRaDec(ra, dec, obs_metadata=obs_metadata, epoch=epoch)\n-    return pixelCoordsFromPupilCoords(xPupil, yPupil, chipNames=chipNames, camera=camera,\n+    return pixelCoordsFromPupilCoords(xPupil, yPupil, chipName=chipNameList, camera=camera,\n                                       includeDistortion=includeDistortion)\n \n \n-def pixelCoordsFromPupilCoords(xPupil, yPupil, chipNames=None,\n+def pixelCoordsFromPupilCoords(xPupil, yPupil, chipName=None,\n                                camera=None, includeDistortion=True):\n     \"\"\"\n     Get the pixel positions (or nan if not on a chip) for objects based\n     on their pupil coordinates.\n \n-    @param [in] xPupil a numpy array containing x pupil coordinates in radians\n+    @param [in] xPupil is thex pupil coordinates in radians.","path":"python/lsst/sims/coordUtils/CameraUtils.py","position":499,"original_position":499,"commit_id":"3ebe3863fac7d74a40e88e26daefee5c31b27f7b","original_commit_id":"3ebe3863fac7d74a40e88e26daefee5c31b27f7b","user":{"login":"jbkalmbach","id":4755090,"avatar_url":"https://avatars.githubusercontent.com/u/4755090?v=3","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false},"body":"typo \"the x\"","created_at":"2016-06-30T01:05:41Z","updated_at":"2016-06-30T01:05:41Z","html_url":"https://github.com/lsst/sims_coordUtils/pull/11#discussion_r69055076","pull_request_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments/69055076"},"html":{"href":"https://github.com/lsst/sims_coordUtils/pull/11#discussion_r69055076"},"pull_request":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11","id":70613091,"html_url":"https://github.com/lsst/sims_coordUtils/pull/11","diff_url":"https://github.com/lsst/sims_coordUtils/pull/11.diff","patch_url":"https://github.com/lsst/sims_coordUtils/pull/11.patch","issue_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/11","number":11,"state":"open","locked":false,"title":"Feature/sim 1983/wavefront sensor methods","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"This pull request incorporates the methods I drew up for the camera team to find the coordinates of the corners of specific chips into sims_coordUtils.  I took the opportunity to clean up a few things about the sims_coordUtils and sims_utils API.  Namely: there were several coordinate transformation methods that could only accept numpy arrays as inputs.  They could not accept single floats.  I fixed those methods so that they can accept either numpy arrays or floats.  I also standardized the names of args in the methods defined in sims_coordUtils/CameraUtils.py.\r\n\r\nLike any good pull request, this had implications beyond sims_coordUtils.  There are pull requests in\r\nsims_utils\r\nsims_coordUtils\r\nsims_catUtils\r\nand sims_GalSimInterface\r\nall of which must be built together.","created_at":"2016-05-18T22:57:26Z","updated_at":"2016-06-30T01:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95b066d40d693c8d32f6d24166ddf71365fb5a83","assignee":{"login":"jbkalmbach","id":4755090,"avatar_url":"https://avatars.githubusercontent.com/u/4755090?v=3","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbkalmbach","id":4755090,"avatar_url":"https://avatars.githubusercontent.com/u/4755090?v=3","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/11/comments","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/3ebe3863fac7d74a40e88e26daefee5c31b27f7b","head":{"label":"lsst:feature/SIM-1983/wavefront_sensor_methods","ref":"feature/SIM-1983/wavefront_sensor_methods","sha":"3ebe3863fac7d74a40e88e26daefee5c31b27f7b","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_coordUtils/deployments","created_at":"2015-04-27T13:28:33Z","updated_at":"2016-01-15T21:56:06Z","pushed_at":"2016-06-27T16:02:26Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":536,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"3ce4a30483889d98566a13398908421b4bb4ddbc","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_coordUtils/deployments","created_at":"2015-04-27T13:28:33Z","updated_at":"2016-01-15T21:56:06Z","pushed_at":"2016-06-27T16:02:26Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":536,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11"},"html":{"href":"https://github.com/lsst/sims_coordUtils/pull/11"},"issue":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/11"},"comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/3ebe3863fac7d74a40e88e26daefee5c31b27f7b"}}}}
{"actor":{"display_login":"jbkalmbach"}}