{"action":"opened","issue":{"url":"https://api.github.com/repos/rockdaboot/wget2/issues/109","repository_url":"https://api.github.com/repos/rockdaboot/wget2","labels_url":"https://api.github.com/repos/rockdaboot/wget2/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/rockdaboot/wget2/issues/109/comments","events_url":"https://api.github.com/repos/rockdaboot/wget2/issues/109/events","html_url":"https://github.com/rockdaboot/wget2/issues/109","id":179285448,"number":109,"title":"+ symbol in Path gets replaced with ' '","user":{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rockdaboot/wget2/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/rockdaboot/wget2/labels/discussion","name":"discussion","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rockdaboot/wget2/milestones/1","html_url":"https://github.com/rockdaboot/wget2/milestones/Initial%20Public%20Release%20v1.0.0","labels_url":"https://api.github.com/repos/rockdaboot/wget2/milestones/1/labels","id":1360020,"number":1,"title":"Initial Public Release v1.0.0","description":"This milestone is a list of things we should achieve before going for the first public release of Wget2. \r\n\r\nThe most critical issues should be filed under this. Things that cause Wget2 to crash, or not work as expected. And issues where Wget2 should, but doesn't work as a drop in replacement for Wget.","creator":{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":30,"state":"open","created_at":"2015-10-16T18:33:42Z","updated_at":"2016-09-26T17:11:49Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-09-26T17:11:49Z","updated_at":"2016-09-26T17:11:49Z","closed_at":null,"body":"Example URI: https://launchpad.net/libmetalink/trunk/libmetalink-0.1.3/+download/libmetalink-0.1.3.tar.bz2\r\n\r\nIn iri.c (wgte_iri_unescape_inline):\r\n```\r\n\t\t} else if (*s == '+') {\r\n\t\t\t*d++ = ' ';\r\n\t\t\ts++;\r\n\t\t\tret = src;\r\n\t\t\tcontinue;\r\n\t\t}\r\n```\r\n\r\nThis fragment is looking for the '+' character and replacing it with a space (' '). As you can see, this would cause a problem in the above URI where there is a + character in the path component. \r\n\r\nIs this check even necessary? From a cursory reading of RFC 3986, I see that the '+' character may occur in the scheme, but even then I see no mention anywhere of replacing it with a space.\r\n\r\nAll tests continue to pass after I removed the check locally. If this is required, can you please add some tests for it?"}}
{"actor":{"display_login":"darnir"}}