{"push_id":1321922325,"size":2,"distinct_size":1,"ref":"refs/heads/allow-property-named-ref","head":"8416911cd0405e75bb125460d8a93727181adcb8","before":"910a88f78805285e0bda11fe9594a0f2a88fc0d7","commits":[{"sha":"db0429d347eb7c4cd143e5992b6ca430c76536ab","author":{"name":"Iain Beeston","email":"14093fac96e1762937355439094e0f7ccf520c9f@gmail.com"},"message":"Removed rubinius from the build matrix\n\nSeems to have stopped working on travis?","distinct":false,"url":"https://api.github.com/repos/iainbeeston/json-schema/commits/db0429d347eb7c4cd143e5992b6ca430c76536ab"},{"sha":"8416911cd0405e75bb125460d8a93727181adcb8","author":{"name":"Iain Beeston","email":"14093fac96e1762937355439094e0f7ccf520c9f@gmail.com"},"message":"Made it possible to have a property named \"$ref\"\n\nFor a few weeks we've had a test from the json-schema common test suite\nfailing on master. The test was checking that it was possible to\nvalidate a property named \"$ref\" (and that it wasn't reserved or\ninterpreted as a json-reference).\n\nThe problem was that whenever we had a property name that has special\nmeaning in json-schema (ie. one that matches the keys of the\nSchema::Validator#attributes hash), we'd skip a level in the schema\nobject while validating, which would cause errors. To fix the problem\nI've made sure we always descend one level at a time (see\nattributes/additionalproperties.rb line 17).\n\nFixing this caused new tests to fail, in test/extends_nested_test.rb. It\nturns out that these tests were depending on the old incorrect\nbehaviour.\n\nWhat's more, the same tests were using an incorrect form of the extends\nproperty. According to the json-schema spec, extends should take a\njson-schema, or an array of json-schemas. However, these tests were\npassing a string to extends. It seems that although this is incorrect,\nwe had code in attributes/extends.rb which would automatically correct\nthis incorrect syntax (ie. from {\"extends\": \"foo.json\"} to {\"extends:\n{\"$ref\": \"foo.json\"}}). I've removed that workaround, as well as\ncorrecting the tests.\n\nFixes #357","distinct":true,"url":"https://api.github.com/repos/iainbeeston/json-schema/commits/8416911cd0405e75bb125460d8a93727181adcb8"}]}
{"actor":{"display_login":"iainbeeston"}}