{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/comments/81000080","pull_request_review_id":2013348,"id":81000080,"diff_hunk":"@@ -118,5 +126,103 @@ private void EnsureMvcInitialized()\n             _populateMethodDelegate = (Action<IServiceCollection, string>) populateMethod\n                 ?.CreateDelegate(typeof(Action<IServiceCollection, string>));\n         }\n+\n+        private IEnumerable<TagHelperDescriptor> GetFakeDescriptors(IEnumerable<TagHelperDescriptor> vcthDescriptors)\n+        {\n+            var fakeDescriptors = new List<TagHelperDescriptor>();\n+            foreach (var descriptor in vcthDescriptors)\n+            {\n+                var fakeType = typeof(ViewComponentTagHelperDesignTimeType).FullName;\n+                var fakeDescriptor = new TagHelperDescriptor(descriptor);\n+                fakeDescriptor.TypeName = fakeType;\n+\n+                var fakeAttributes = new List<TagHelperAttributeDescriptor>();\n+                fakeDescriptor.Attributes = fakeAttributes;\n+\n+                var fakeHelperType = typeof(ViewComponentTagHelperDesignTimeHelperType).FullName;\n+                var fakeHelperDescriptor = new TagHelperDescriptor(descriptor);\n+                fakeHelperDescriptor.TypeName = fakeHelperType;\n+\n+                var fakeHelperAttributes = new List<TagHelperAttributeDescriptor>();\n+                fakeHelperDescriptor.Attributes = fakeHelperAttributes;\n+\n+                foreach (var attribute in descriptor.Attributes)\n+                {\n+                    var summary = $\"{attribute.TypeName}: {descriptor.TypeName}.{attribute.PropertyName}\";\n+                    var fakeVariableName = $\"__obj\";","path":"src/Microsoft.AspNetCore.Razor.Design/Internal/AssemblyTagHelperDescriptorResolver.cs","position":60,"original_position":60,"commit_id":"498d57faa7d9552d4f1f2a03a9cb86db160ec171","original_commit_id":"498d57faa7d9552d4f1f2a03a9cb86db160ec171","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"const string fakeVariableName = \"__obj\";","created_at":"2016-09-28T19:38:41Z","updated_at":"2016-09-28T19:38:41Z","html_url":"https://github.com/aspnet/RazorTooling/pull/99#discussion_r81000080","pull_request_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/comments/81000080"},"html":{"href":"https://github.com/aspnet/RazorTooling/pull/99#discussion_r81000080"},"pull_request":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99","id":87185519,"html_url":"https://github.com/aspnet/RazorTooling/pull/99","diff_url":"https://github.com/aspnet/RazorTooling/pull/99.diff","patch_url":"https://github.com/aspnet/RazorTooling/pull/99.patch","issue_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/99","number":99,"state":"open","locked":false,"title":"Fully support ViewComponentTagHelpers in design time","user":{"login":"ajaybhargavb","id":1579269,"avatar_url":"https://avatars.githubusercontent.com/u/1579269?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaybhargavb","html_url":"https://github.com/ajaybhargavb","followers_url":"https://api.github.com/users/ajaybhargavb/followers","following_url":"https://api.github.com/users/ajaybhargavb/following{/other_user}","gists_url":"https://api.github.com/users/ajaybhargavb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaybhargavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaybhargavb/subscriptions","organizations_url":"https://api.github.com/users/ajaybhargavb/orgs","repos_url":"https://api.github.com/users/ajaybhargavb/repos","events_url":"https://api.github.com/users/ajaybhargavb/events{/privacy}","received_events_url":"https://api.github.com/users/ajaybhargavb/received_events","type":"User","site_admin":false},"body":"This change works around the need to update Visual Studio to make ViewComponent tag helpers work.\r\nThis is a temporary change that will be removed once Visual Studio is updated with latest packages.\r\n\r\n@NTaylorMullen @pranavkm @Eilon @DamianEdwards ","created_at":"2016-09-28T19:35:01Z","updated_at":"2016-09-28T19:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd43811ae498310ff8f64f19cd505c67c3b82d15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99/commits","review_comments_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99/comments","review_comment_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/99/comments","statuses_url":"https://api.github.com/repos/aspnet/RazorTooling/statuses/498d57faa7d9552d4f1f2a03a9cb86db160ec171","head":{"label":"aspnet:ajbaaska/vcth-hack","ref":"ajbaaska/vcth-hack","sha":"498d57faa7d9552d4f1f2a03a9cb86db160ec171","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29367003,"name":"RazorTooling","full_name":"aspnet/RazorTooling","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/RazorTooling","description":"Razor tooling","fork":false,"url":"https://api.github.com/repos/aspnet/RazorTooling","forks_url":"https://api.github.com/repos/aspnet/RazorTooling/forks","keys_url":"https://api.github.com/repos/aspnet/RazorTooling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/RazorTooling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/RazorTooling/teams","hooks_url":"https://api.github.com/repos/aspnet/RazorTooling/hooks","issue_events_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/RazorTooling/events","assignees_url":"https://api.github.com/repos/aspnet/RazorTooling/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/RazorTooling/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/RazorTooling/tags","blobs_url":"https://api.github.com/repos/aspnet/RazorTooling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/RazorTooling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/RazorTooling/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/RazorTooling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/RazorTooling/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/RazorTooling/languages","stargazers_url":"https://api.github.com/repos/aspnet/RazorTooling/stargazers","contributors_url":"https://api.github.com/repos/aspnet/RazorTooling/contributors","subscribers_url":"https://api.github.com/repos/aspnet/RazorTooling/subscribers","subscription_url":"https://api.github.com/repos/aspnet/RazorTooling/subscription","commits_url":"https://api.github.com/repos/aspnet/RazorTooling/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/RazorTooling/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/RazorTooling/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/RazorTooling/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/RazorTooling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/RazorTooling/merges","archive_url":"https://api.github.com/repos/aspnet/RazorTooling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/RazorTooling/downloads","issues_url":"https://api.github.com/repos/aspnet/RazorTooling/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/RazorTooling/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/RazorTooling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/RazorTooling/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/RazorTooling/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/RazorTooling/deployments","created_at":"2015-01-16T20:44:05Z","updated_at":"2016-09-21T18:25:54Z","pushed_at":"2016-09-28T19:35:01Z","git_url":"git://github.com/aspnet/RazorTooling.git","ssh_url":"git@github.com:aspnet/RazorTooling.git","clone_url":"https://github.com/aspnet/RazorTooling.git","svn_url":"https://github.com/aspnet/RazorTooling","homepage":"","size":301,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":14,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"24a9c542c4af119f1e1ffd2b1cde603515b58429","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29367003,"name":"RazorTooling","full_name":"aspnet/RazorTooling","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/RazorTooling","description":"Razor tooling","fork":false,"url":"https://api.github.com/repos/aspnet/RazorTooling","forks_url":"https://api.github.com/repos/aspnet/RazorTooling/forks","keys_url":"https://api.github.com/repos/aspnet/RazorTooling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/RazorTooling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/RazorTooling/teams","hooks_url":"https://api.github.com/repos/aspnet/RazorTooling/hooks","issue_events_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/RazorTooling/events","assignees_url":"https://api.github.com/repos/aspnet/RazorTooling/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/RazorTooling/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/RazorTooling/tags","blobs_url":"https://api.github.com/repos/aspnet/RazorTooling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/RazorTooling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/RazorTooling/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/RazorTooling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/RazorTooling/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/RazorTooling/languages","stargazers_url":"https://api.github.com/repos/aspnet/RazorTooling/stargazers","contributors_url":"https://api.github.com/repos/aspnet/RazorTooling/contributors","subscribers_url":"https://api.github.com/repos/aspnet/RazorTooling/subscribers","subscription_url":"https://api.github.com/repos/aspnet/RazorTooling/subscription","commits_url":"https://api.github.com/repos/aspnet/RazorTooling/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/RazorTooling/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/RazorTooling/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/RazorTooling/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/RazorTooling/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/RazorTooling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/RazorTooling/merges","archive_url":"https://api.github.com/repos/aspnet/RazorTooling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/RazorTooling/downloads","issues_url":"https://api.github.com/repos/aspnet/RazorTooling/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/RazorTooling/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/RazorTooling/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/RazorTooling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/RazorTooling/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/RazorTooling/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/RazorTooling/deployments","created_at":"2015-01-16T20:44:05Z","updated_at":"2016-09-21T18:25:54Z","pushed_at":"2016-09-28T19:35:01Z","git_url":"git://github.com/aspnet/RazorTooling.git","ssh_url":"git@github.com:aspnet/RazorTooling.git","clone_url":"https://github.com/aspnet/RazorTooling.git","svn_url":"https://github.com/aspnet/RazorTooling","homepage":"","size":301,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":14,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99"},"html":{"href":"https://github.com/aspnet/RazorTooling/pull/99"},"issue":{"href":"https://api.github.com/repos/aspnet/RazorTooling/issues/99"},"comments":{"href":"https://api.github.com/repos/aspnet/RazorTooling/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/RazorTooling/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/RazorTooling/statuses/498d57faa7d9552d4f1f2a03a9cb86db160ec171"}}}}
{"actor":{"display_login":"NTaylorMullen"}}