{"action":"created","comment":{"url":"https://api.github.com/repos/tdryer/hangups/pulls/comments/54363010","id":54363010,"diff_hunk":"@@ -903,6 +903,12 @@ def main():\n                   help='keybinding for alternate up key')\n     key_group.add('--key-down', default='j',\n                   help='keybinding for alternate down key')\n+    notification_group = parser.add_argument_group('Notifications')\n+    notification_group.add('-n', '--disable-notifications',\n+                           action='store_true',\n+                           help='disable desktop notifications')\n+    notification_group.add('-t', '--notification-type', default='full',\n+                           help='choose notification type (full or discreet)')","path":"hangups/ui/__main__.py","position":70,"original_position":70,"commit_id":"9a4359e52c3c8e4e185e18f5f7e6290134846316","original_commit_id":"9a4359e52c3c8e4e185e18f5f7e6290134846316","user":{"login":"tdryer","id":857374,"avatar_url":"https://avatars.githubusercontent.com/u/857374?v=3","gravatar_id":"","url":"https://api.github.com/users/tdryer","html_url":"https://github.com/tdryer","followers_url":"https://api.github.com/users/tdryer/followers","following_url":"https://api.github.com/users/tdryer/following{/other_user}","gists_url":"https://api.github.com/users/tdryer/gists{/gist_id}","starred_url":"https://api.github.com/users/tdryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdryer/subscriptions","organizations_url":"https://api.github.com/users/tdryer/orgs","repos_url":"https://api.github.com/users/tdryer/repos","events_url":"https://api.github.com/users/tdryer/events{/privacy}","received_events_url":"https://api.github.com/users/tdryer/received_events","type":"User","site_admin":false},"body":"This could just be a `store_true` argument called `--discreet-notifications`.","created_at":"2016-02-29T01:51:28Z","updated_at":"2016-02-29T01:51:28Z","html_url":"https://github.com/tdryer/hangups/pull/214#discussion_r54363010","pull_request_url":"https://api.github.com/repos/tdryer/hangups/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/comments/54363010"},"html":{"href":"https://github.com/tdryer/hangups/pull/214#discussion_r54363010"},"pull_request":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/tdryer/hangups/pulls/214","id":59978163,"html_url":"https://github.com/tdryer/hangups/pull/214","diff_url":"https://github.com/tdryer/hangups/pull/214.diff","patch_url":"https://github.com/tdryer/hangups/pull/214.patch","issue_url":"https://api.github.com/repos/tdryer/hangups/issues/214","number":214,"state":"open","locked":false,"title":"Added a new discreet notifier.","user":{"login":"StuntsPT","id":1201571,"avatar_url":"https://avatars.githubusercontent.com/u/1201571?v=3","gravatar_id":"","url":"https://api.github.com/users/StuntsPT","html_url":"https://github.com/StuntsPT","followers_url":"https://api.github.com/users/StuntsPT/followers","following_url":"https://api.github.com/users/StuntsPT/following{/other_user}","gists_url":"https://api.github.com/users/StuntsPT/gists{/gist_id}","starred_url":"https://api.github.com/users/StuntsPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuntsPT/subscriptions","organizations_url":"https://api.github.com/users/StuntsPT/orgs","repos_url":"https://api.github.com/users/StuntsPT/repos","events_url":"https://api.github.com/users/StuntsPT/events{/privacy}","received_events_url":"https://api.github.com/users/StuntsPT/received_events","type":"User","site_admin":false},"body":"I have implemented a new \"discreet notifier\" method of displaying notifications.\r\nUsing the \"-D\" argument, hangups will notify the user that person \"X\" sent a message, but will not display it's contents. I'm also inclined to remove the name of the user who sent it, but first I'd like your feedback.\r\nI feel it is adding a lot of \"pollution\" to a very clean codebase. Is there a a better way to pass the \"discreet_notifier\" argument?\r\n\r\nThanks for considering.","created_at":"2016-02-19T17:10:53Z","updated_at":"2016-02-29T01:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76aabf4e81808d20a199054caf61dd95f0db5ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tdryer/hangups/pulls/214/commits","review_comments_url":"https://api.github.com/repos/tdryer/hangups/pulls/214/comments","review_comment_url":"https://api.github.com/repos/tdryer/hangups/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tdryer/hangups/issues/214/comments","statuses_url":"https://api.github.com/repos/tdryer/hangups/statuses/9a4359e52c3c8e4e185e18f5f7e6290134846316","head":{"label":"StuntsPT:master","ref":"master","sha":"9a4359e52c3c8e4e185e18f5f7e6290134846316","user":{"login":"StuntsPT","id":1201571,"avatar_url":"https://avatars.githubusercontent.com/u/1201571?v=3","gravatar_id":"","url":"https://api.github.com/users/StuntsPT","html_url":"https://github.com/StuntsPT","followers_url":"https://api.github.com/users/StuntsPT/followers","following_url":"https://api.github.com/users/StuntsPT/following{/other_user}","gists_url":"https://api.github.com/users/StuntsPT/gists{/gist_id}","starred_url":"https://api.github.com/users/StuntsPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuntsPT/subscriptions","organizations_url":"https://api.github.com/users/StuntsPT/orgs","repos_url":"https://api.github.com/users/StuntsPT/repos","events_url":"https://api.github.com/users/StuntsPT/events{/privacy}","received_events_url":"https://api.github.com/users/StuntsPT/received_events","type":"User","site_admin":false},"repo":{"id":36492893,"name":"hangups","full_name":"StuntsPT/hangups","owner":{"login":"StuntsPT","id":1201571,"avatar_url":"https://avatars.githubusercontent.com/u/1201571?v=3","gravatar_id":"","url":"https://api.github.com/users/StuntsPT","html_url":"https://github.com/StuntsPT","followers_url":"https://api.github.com/users/StuntsPT/followers","following_url":"https://api.github.com/users/StuntsPT/following{/other_user}","gists_url":"https://api.github.com/users/StuntsPT/gists{/gist_id}","starred_url":"https://api.github.com/users/StuntsPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuntsPT/subscriptions","organizations_url":"https://api.github.com/users/StuntsPT/orgs","repos_url":"https://api.github.com/users/StuntsPT/repos","events_url":"https://api.github.com/users/StuntsPT/events{/privacy}","received_events_url":"https://api.github.com/users/StuntsPT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StuntsPT/hangups","description":"the first third-party instant messaging client for Google Hangouts","fork":true,"url":"https://api.github.com/repos/StuntsPT/hangups","forks_url":"https://api.github.com/repos/StuntsPT/hangups/forks","keys_url":"https://api.github.com/repos/StuntsPT/hangups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StuntsPT/hangups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StuntsPT/hangups/teams","hooks_url":"https://api.github.com/repos/StuntsPT/hangups/hooks","issue_events_url":"https://api.github.com/repos/StuntsPT/hangups/issues/events{/number}","events_url":"https://api.github.com/repos/StuntsPT/hangups/events","assignees_url":"https://api.github.com/repos/StuntsPT/hangups/assignees{/user}","branches_url":"https://api.github.com/repos/StuntsPT/hangups/branches{/branch}","tags_url":"https://api.github.com/repos/StuntsPT/hangups/tags","blobs_url":"https://api.github.com/repos/StuntsPT/hangups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StuntsPT/hangups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StuntsPT/hangups/git/refs{/sha}","trees_url":"https://api.github.com/repos/StuntsPT/hangups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StuntsPT/hangups/statuses/{sha}","languages_url":"https://api.github.com/repos/StuntsPT/hangups/languages","stargazers_url":"https://api.github.com/repos/StuntsPT/hangups/stargazers","contributors_url":"https://api.github.com/repos/StuntsPT/hangups/contributors","subscribers_url":"https://api.github.com/repos/StuntsPT/hangups/subscribers","subscription_url":"https://api.github.com/repos/StuntsPT/hangups/subscription","commits_url":"https://api.github.com/repos/StuntsPT/hangups/commits{/sha}","git_commits_url":"https://api.github.com/repos/StuntsPT/hangups/git/commits{/sha}","comments_url":"https://api.github.com/repos/StuntsPT/hangups/comments{/number}","issue_comment_url":"https://api.github.com/repos/StuntsPT/hangups/issues/comments{/number}","contents_url":"https://api.github.com/repos/StuntsPT/hangups/contents/{+path}","compare_url":"https://api.github.com/repos/StuntsPT/hangups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StuntsPT/hangups/merges","archive_url":"https://api.github.com/repos/StuntsPT/hangups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StuntsPT/hangups/downloads","issues_url":"https://api.github.com/repos/StuntsPT/hangups/issues{/number}","pulls_url":"https://api.github.com/repos/StuntsPT/hangups/pulls{/number}","milestones_url":"https://api.github.com/repos/StuntsPT/hangups/milestones{/number}","notifications_url":"https://api.github.com/repos/StuntsPT/hangups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StuntsPT/hangups/labels{/name}","releases_url":"https://api.github.com/repos/StuntsPT/hangups/releases{/id}","deployments_url":"https://api.github.com/repos/StuntsPT/hangups/deployments","created_at":"2015-05-29T08:56:26Z","updated_at":"2016-02-19T15:52:09Z","pushed_at":"2016-02-29T00:05:40Z","git_url":"git://github.com/StuntsPT/hangups.git","ssh_url":"git@github.com:StuntsPT/hangups.git","clone_url":"https://github.com/StuntsPT/hangups.git","svn_url":"https://github.com/StuntsPT/hangups","homepage":"","size":1366,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tdryer:master","ref":"master","sha":"d09cdefcab17ffa84314e9a3b5bb6f016bb0c6d3","user":{"login":"tdryer","id":857374,"avatar_url":"https://avatars.githubusercontent.com/u/857374?v=3","gravatar_id":"","url":"https://api.github.com/users/tdryer","html_url":"https://github.com/tdryer","followers_url":"https://api.github.com/users/tdryer/followers","following_url":"https://api.github.com/users/tdryer/following{/other_user}","gists_url":"https://api.github.com/users/tdryer/gists{/gist_id}","starred_url":"https://api.github.com/users/tdryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdryer/subscriptions","organizations_url":"https://api.github.com/users/tdryer/orgs","repos_url":"https://api.github.com/users/tdryer/repos","events_url":"https://api.github.com/users/tdryer/events{/privacy}","received_events_url":"https://api.github.com/users/tdryer/received_events","type":"User","site_admin":false},"repo":{"id":19361153,"name":"hangups","full_name":"tdryer/hangups","owner":{"login":"tdryer","id":857374,"avatar_url":"https://avatars.githubusercontent.com/u/857374?v=3","gravatar_id":"","url":"https://api.github.com/users/tdryer","html_url":"https://github.com/tdryer","followers_url":"https://api.github.com/users/tdryer/followers","following_url":"https://api.github.com/users/tdryer/following{/other_user}","gists_url":"https://api.github.com/users/tdryer/gists{/gist_id}","starred_url":"https://api.github.com/users/tdryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdryer/subscriptions","organizations_url":"https://api.github.com/users/tdryer/orgs","repos_url":"https://api.github.com/users/tdryer/repos","events_url":"https://api.github.com/users/tdryer/events{/privacy}","received_events_url":"https://api.github.com/users/tdryer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdryer/hangups","description":"the first third-party instant messaging client for Google Hangouts","fork":false,"url":"https://api.github.com/repos/tdryer/hangups","forks_url":"https://api.github.com/repos/tdryer/hangups/forks","keys_url":"https://api.github.com/repos/tdryer/hangups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdryer/hangups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdryer/hangups/teams","hooks_url":"https://api.github.com/repos/tdryer/hangups/hooks","issue_events_url":"https://api.github.com/repos/tdryer/hangups/issues/events{/number}","events_url":"https://api.github.com/repos/tdryer/hangups/events","assignees_url":"https://api.github.com/repos/tdryer/hangups/assignees{/user}","branches_url":"https://api.github.com/repos/tdryer/hangups/branches{/branch}","tags_url":"https://api.github.com/repos/tdryer/hangups/tags","blobs_url":"https://api.github.com/repos/tdryer/hangups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdryer/hangups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdryer/hangups/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdryer/hangups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdryer/hangups/statuses/{sha}","languages_url":"https://api.github.com/repos/tdryer/hangups/languages","stargazers_url":"https://api.github.com/repos/tdryer/hangups/stargazers","contributors_url":"https://api.github.com/repos/tdryer/hangups/contributors","subscribers_url":"https://api.github.com/repos/tdryer/hangups/subscribers","subscription_url":"https://api.github.com/repos/tdryer/hangups/subscription","commits_url":"https://api.github.com/repos/tdryer/hangups/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdryer/hangups/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdryer/hangups/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdryer/hangups/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdryer/hangups/contents/{+path}","compare_url":"https://api.github.com/repos/tdryer/hangups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdryer/hangups/merges","archive_url":"https://api.github.com/repos/tdryer/hangups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdryer/hangups/downloads","issues_url":"https://api.github.com/repos/tdryer/hangups/issues{/number}","pulls_url":"https://api.github.com/repos/tdryer/hangups/pulls{/number}","milestones_url":"https://api.github.com/repos/tdryer/hangups/milestones{/number}","notifications_url":"https://api.github.com/repos/tdryer/hangups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdryer/hangups/labels{/name}","releases_url":"https://api.github.com/repos/tdryer/hangups/releases{/id}","deployments_url":"https://api.github.com/repos/tdryer/hangups/deployments","created_at":"2014-05-01T23:48:24Z","updated_at":"2016-02-28T00:00:53Z","pushed_at":"2016-02-29T00:05:41Z","git_url":"git://github.com/tdryer/hangups.git","ssh_url":"git@github.com:tdryer/hangups.git","clone_url":"https://github.com/tdryer/hangups.git","svn_url":"https://github.com/tdryer/hangups","homepage":"","size":1647,"stargazers_count":920,"watchers_count":920,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":59,"forks":101,"open_issues":59,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/214"},"html":{"href":"https://github.com/tdryer/hangups/pull/214"},"issue":{"href":"https://api.github.com/repos/tdryer/hangups/issues/214"},"comments":{"href":"https://api.github.com/repos/tdryer/hangups/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tdryer/hangups/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/tdryer/hangups/statuses/9a4359e52c3c8e4e185e18f5f7e6290134846316"}}}}