{"action":"created","issue":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/973","repository_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/973/labels{/name}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/973/comments","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/973/events","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/973","id":192095555,"number":973,"title":"fix(prices): update price list module to 2.x standards","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"labels":[{"id":331223378,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/bug%20fix","name":"bug fix","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-28T19:28:39Z","updated_at":"2016-11-29T17:49:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/973","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/973","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/973.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/973.patch"},"body":"This commit fixes the price list client, giving it Notify for error\r\nhandling, ui select for inventory items, and loading buttons. \r\nIt also implements the client-side validation logic for price lists.\r\n\r\nImportantly, this refuses to submit a negative number for the\r\nprice of an inventory item (though percentages can still be\r\nnegative).\r\n \r\nPartially address #930.  Closes #955. Closes #967.\r\n\r\n---\r\nThank you for contributing!\r\n\r\nBefore submitting this pull request, please verify that you have:\r\n - [x] Run your code through JSHint.  [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md).\r\n - [x] Run integration tests.\r\n - [x] Run end-to-end tests.\r\n - [x] Accurately described the changes your are making in this pull request.\r\n\r\nFor a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against.\r\n\r\nEnsuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!"},"comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments/263644768","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/973#issuecomment-263644768","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/973","id":263644768,"user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T17:49:50Z","updated_at":"2016-11-29T17:49:50Z","body":"@mbayopanda, since @sfount is not feeling well, can you do a review of this?"}}
{"actor":{"display_login":"jniles"}}