{"action":"created","comment":{"url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/comments/88829817","pull_request_review_id":9390067,"id":88829817,"diff_hunk":"@@ -52,27 +71,48 @@ def enable_ipmi(handle, priv=CommIpmiLanConsts.PRIV_ADMIN, key='0'*40):\n                          '\"{1}\"'.format(handle.ip, key))\n \n     # Create enabled IPMI object\n-    ipmi_mo = CommIpmiLan(parent_mo_or_dn=\"sys/svc-ext\",\n-                          admin_state=\"enabled\", priv=priv, key=key)\n+    ipmi_mo = _get_ipmi_obj(handle, server_id)","path":"imcsdk/apis/admin/ipmi.py","position":54,"original_position":54,"commit_id":"03e598614cfc484f63a38a8f170ca5a2a95f121a","original_commit_id":"03e598614cfc484f63a38a8f170ca5a2a95f121a","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"body":"```\r\nipmi_mo = _get_ipmi_obj(handle, server_id)\r\n ```\r\nshould become\r\n```\r\nipmi_mo = CommIpmiLan(parent_mo_or_dn=self._get_ipmi_parent_dn(<server_id>))\r\n```","created_at":"2016-11-21T05:01:24Z","updated_at":"2016-11-21T05:13:17Z","html_url":"https://github.com/CiscoUcs/imcsdk/pull/52#discussion_r88829817","pull_request_url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/comments/88829817"},"html":{"href":"https://github.com/CiscoUcs/imcsdk/pull/52#discussion_r88829817"},"pull_request":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52","id":94521893,"html_url":"https://github.com/CiscoUcs/imcsdk/pull/52","diff_url":"https://github.com/CiscoUcs/imcsdk/pull/52.diff","patch_url":"https://github.com/CiscoUcs/imcsdk/pull/52.patch","issue_url":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/52","number":52,"state":"open","locked":false,"title":"misc fixes in ipmi and snmp functionality","user":{"login":"waghswapnil","id":9150740,"avatar_url":"https://avatars.githubusercontent.com/u/9150740?v=3","gravatar_id":"","url":"https://api.github.com/users/waghswapnil","html_url":"https://github.com/waghswapnil","followers_url":"https://api.github.com/users/waghswapnil/followers","following_url":"https://api.github.com/users/waghswapnil/following{/other_user}","gists_url":"https://api.github.com/users/waghswapnil/gists{/gist_id}","starred_url":"https://api.github.com/users/waghswapnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waghswapnil/subscriptions","organizations_url":"https://api.github.com/users/waghswapnil/orgs","repos_url":"https://api.github.com/users/waghswapnil/repos","events_url":"https://api.github.com/users/waghswapnil/events{/privacy}","received_events_url":"https://api.github.com/users/waghswapnil/received_events","type":"User","site_admin":false},"body":"- fixed ipmi apis for classic and modular platforms\r\n- unit-test for ipmi apis\r\n- minor fixes in snmp apis\r\n\r\nSigned-off-by: Swapnil Wagh <waghswapnil@gmail.com>","created_at":"2016-11-20T15:42:59Z","updated_at":"2016-11-21T05:13:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21835b6bc4d88303d05d04e0c9a549919ff801e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52/commits","review_comments_url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52/comments","review_comment_url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/52/comments","statuses_url":"https://api.github.com/repos/CiscoUcs/imcsdk/statuses/03e598614cfc484f63a38a8f170ca5a2a95f121a","head":{"label":"waghswapnil:misc_fixes","ref":"misc_fixes","sha":"03e598614cfc484f63a38a8f170ca5a2a95f121a","user":{"login":"waghswapnil","id":9150740,"avatar_url":"https://avatars.githubusercontent.com/u/9150740?v=3","gravatar_id":"","url":"https://api.github.com/users/waghswapnil","html_url":"https://github.com/waghswapnil","followers_url":"https://api.github.com/users/waghswapnil/followers","following_url":"https://api.github.com/users/waghswapnil/following{/other_user}","gists_url":"https://api.github.com/users/waghswapnil/gists{/gist_id}","starred_url":"https://api.github.com/users/waghswapnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waghswapnil/subscriptions","organizations_url":"https://api.github.com/users/waghswapnil/orgs","repos_url":"https://api.github.com/users/waghswapnil/repos","events_url":"https://api.github.com/users/waghswapnil/events{/privacy}","received_events_url":"https://api.github.com/users/waghswapnil/received_events","type":"User","site_admin":false},"repo":{"id":66561056,"name":"imcsdk","full_name":"waghswapnil/imcsdk","owner":{"login":"waghswapnil","id":9150740,"avatar_url":"https://avatars.githubusercontent.com/u/9150740?v=3","gravatar_id":"","url":"https://api.github.com/users/waghswapnil","html_url":"https://github.com/waghswapnil","followers_url":"https://api.github.com/users/waghswapnil/followers","following_url":"https://api.github.com/users/waghswapnil/following{/other_user}","gists_url":"https://api.github.com/users/waghswapnil/gists{/gist_id}","starred_url":"https://api.github.com/users/waghswapnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waghswapnil/subscriptions","organizations_url":"https://api.github.com/users/waghswapnil/orgs","repos_url":"https://api.github.com/users/waghswapnil/repos","events_url":"https://api.github.com/users/waghswapnil/events{/privacy}","received_events_url":"https://api.github.com/users/waghswapnil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waghswapnil/imcsdk","description":"Python SDK for Cisco IMC","fork":true,"url":"https://api.github.com/repos/waghswapnil/imcsdk","forks_url":"https://api.github.com/repos/waghswapnil/imcsdk/forks","keys_url":"https://api.github.com/repos/waghswapnil/imcsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waghswapnil/imcsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waghswapnil/imcsdk/teams","hooks_url":"https://api.github.com/repos/waghswapnil/imcsdk/hooks","issue_events_url":"https://api.github.com/repos/waghswapnil/imcsdk/issues/events{/number}","events_url":"https://api.github.com/repos/waghswapnil/imcsdk/events","assignees_url":"https://api.github.com/repos/waghswapnil/imcsdk/assignees{/user}","branches_url":"https://api.github.com/repos/waghswapnil/imcsdk/branches{/branch}","tags_url":"https://api.github.com/repos/waghswapnil/imcsdk/tags","blobs_url":"https://api.github.com/repos/waghswapnil/imcsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waghswapnil/imcsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waghswapnil/imcsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/waghswapnil/imcsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waghswapnil/imcsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/waghswapnil/imcsdk/languages","stargazers_url":"https://api.github.com/repos/waghswapnil/imcsdk/stargazers","contributors_url":"https://api.github.com/repos/waghswapnil/imcsdk/contributors","subscribers_url":"https://api.github.com/repos/waghswapnil/imcsdk/subscribers","subscription_url":"https://api.github.com/repos/waghswapnil/imcsdk/subscription","commits_url":"https://api.github.com/repos/waghswapnil/imcsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/waghswapnil/imcsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/waghswapnil/imcsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/waghswapnil/imcsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/waghswapnil/imcsdk/contents/{+path}","compare_url":"https://api.github.com/repos/waghswapnil/imcsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waghswapnil/imcsdk/merges","archive_url":"https://api.github.com/repos/waghswapnil/imcsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waghswapnil/imcsdk/downloads","issues_url":"https://api.github.com/repos/waghswapnil/imcsdk/issues{/number}","pulls_url":"https://api.github.com/repos/waghswapnil/imcsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/waghswapnil/imcsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/waghswapnil/imcsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waghswapnil/imcsdk/labels{/name}","releases_url":"https://api.github.com/repos/waghswapnil/imcsdk/releases{/id}","deployments_url":"https://api.github.com/repos/waghswapnil/imcsdk/deployments","created_at":"2016-08-25T13:39:51Z","updated_at":"2016-08-25T13:39:53Z","pushed_at":"2016-11-20T19:11:01Z","git_url":"git://github.com/waghswapnil/imcsdk.git","ssh_url":"git@github.com:waghswapnil/imcsdk.git","clone_url":"https://github.com/waghswapnil/imcsdk.git","svn_url":"https://github.com/waghswapnil/imcsdk","homepage":null,"size":634,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CiscoUcs:master","ref":"master","sha":"687324d3dcdf4bf1b855a5e83c0f4e618451143c","user":{"login":"CiscoUcs","id":7289148,"avatar_url":"https://avatars.githubusercontent.com/u/7289148?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoUcs","html_url":"https://github.com/CiscoUcs","followers_url":"https://api.github.com/users/CiscoUcs/followers","following_url":"https://api.github.com/users/CiscoUcs/following{/other_user}","gists_url":"https://api.github.com/users/CiscoUcs/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoUcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoUcs/subscriptions","organizations_url":"https://api.github.com/users/CiscoUcs/orgs","repos_url":"https://api.github.com/users/CiscoUcs/repos","events_url":"https://api.github.com/users/CiscoUcs/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoUcs/received_events","type":"Organization","site_admin":false},"repo":{"id":58990697,"name":"imcsdk","full_name":"CiscoUcs/imcsdk","owner":{"login":"CiscoUcs","id":7289148,"avatar_url":"https://avatars.githubusercontent.com/u/7289148?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoUcs","html_url":"https://github.com/CiscoUcs","followers_url":"https://api.github.com/users/CiscoUcs/followers","following_url":"https://api.github.com/users/CiscoUcs/following{/other_user}","gists_url":"https://api.github.com/users/CiscoUcs/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoUcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoUcs/subscriptions","organizations_url":"https://api.github.com/users/CiscoUcs/orgs","repos_url":"https://api.github.com/users/CiscoUcs/repos","events_url":"https://api.github.com/users/CiscoUcs/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoUcs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CiscoUcs/imcsdk","description":"Python SDK for Cisco IMC","fork":false,"url":"https://api.github.com/repos/CiscoUcs/imcsdk","forks_url":"https://api.github.com/repos/CiscoUcs/imcsdk/forks","keys_url":"https://api.github.com/repos/CiscoUcs/imcsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CiscoUcs/imcsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CiscoUcs/imcsdk/teams","hooks_url":"https://api.github.com/repos/CiscoUcs/imcsdk/hooks","issue_events_url":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/events{/number}","events_url":"https://api.github.com/repos/CiscoUcs/imcsdk/events","assignees_url":"https://api.github.com/repos/CiscoUcs/imcsdk/assignees{/user}","branches_url":"https://api.github.com/repos/CiscoUcs/imcsdk/branches{/branch}","tags_url":"https://api.github.com/repos/CiscoUcs/imcsdk/tags","blobs_url":"https://api.github.com/repos/CiscoUcs/imcsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CiscoUcs/imcsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CiscoUcs/imcsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/CiscoUcs/imcsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CiscoUcs/imcsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/CiscoUcs/imcsdk/languages","stargazers_url":"https://api.github.com/repos/CiscoUcs/imcsdk/stargazers","contributors_url":"https://api.github.com/repos/CiscoUcs/imcsdk/contributors","subscribers_url":"https://api.github.com/repos/CiscoUcs/imcsdk/subscribers","subscription_url":"https://api.github.com/repos/CiscoUcs/imcsdk/subscription","commits_url":"https://api.github.com/repos/CiscoUcs/imcsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/CiscoUcs/imcsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/CiscoUcs/imcsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/CiscoUcs/imcsdk/contents/{+path}","compare_url":"https://api.github.com/repos/CiscoUcs/imcsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CiscoUcs/imcsdk/merges","archive_url":"https://api.github.com/repos/CiscoUcs/imcsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CiscoUcs/imcsdk/downloads","issues_url":"https://api.github.com/repos/CiscoUcs/imcsdk/issues{/number}","pulls_url":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/CiscoUcs/imcsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/CiscoUcs/imcsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CiscoUcs/imcsdk/labels{/name}","releases_url":"https://api.github.com/repos/CiscoUcs/imcsdk/releases{/id}","deployments_url":"https://api.github.com/repos/CiscoUcs/imcsdk/deployments","created_at":"2016-05-17T04:35:26Z","updated_at":"2016-11-08T23:01:33Z","pushed_at":"2016-11-20T19:11:01Z","git_url":"git://github.com/CiscoUcs/imcsdk.git","ssh_url":"git@github.com:CiscoUcs/imcsdk.git","clone_url":"https://github.com/CiscoUcs/imcsdk.git","svn_url":"https://github.com/CiscoUcs/imcsdk","homepage":null,"size":668,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52"},"html":{"href":"https://github.com/CiscoUcs/imcsdk/pull/52"},"issue":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/52"},"comments":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/CiscoUcs/imcsdk/statuses/03e598614cfc484f63a38a8f170ca5a2a95f121a"}}}}
{"actor":{"display_login":"vvb"}}