{"action":"closed","number":10833,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/10833","id":82349585,"html_url":"https://github.com/Microsoft/vscode/pull/10833","diff_url":"https://github.com/Microsoft/vscode/pull/10833.diff","patch_url":"https://github.com/Microsoft/vscode/pull/10833.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/10833","number":10833,"state":"closed","locked":false,"title":"Fix sending message to terminated worker","user":{"login":"paveldk","id":1455045,"avatar_url":"https://avatars.githubusercontent.com/u/1455045?v=3","gravatar_id":"","url":"https://api.github.com/users/paveldk","html_url":"https://github.com/paveldk","followers_url":"https://api.github.com/users/paveldk/followers","following_url":"https://api.github.com/users/paveldk/following{/other_user}","gists_url":"https://api.github.com/users/paveldk/gists{/gist_id}","starred_url":"https://api.github.com/users/paveldk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveldk/subscriptions","organizations_url":"https://api.github.com/users/paveldk/orgs","repos_url":"https://api.github.com/users/paveldk/repos","events_url":"https://api.github.com/users/paveldk/events{/privacy}","received_events_url":"https://api.github.com/users/paveldk/received_events","type":"User","site_admin":false},"body":"The problem appears if you create multiple editors/models and then change the typescript compilation settings. This will dispose (terminate) the worker as first action. then it will dispose all existing models which will try to send messages for \"acceptRemovedModel\" to the worker(s) but as they are already terminated this will result in error.\r\n\r\nI'm not sure if it is a better if the worker is terminated to reject the postMessage request immediately since this will again result in error.","created_at":"2016-08-23T11:45:10Z","updated_at":"2016-08-29T21:23:46Z","closed_at":"2016-08-29T21:23:46Z","merged_at":"2016-08-29T21:23:46Z","merge_commit_sha":"f954045a99f1cde356c968e91747318fe42dcd32","assignee":{"login":"alexandrudima","id":5047891,"avatar_url":"https://avatars.githubusercontent.com/u/5047891?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexandrudima","id":5047891,"avatar_url":"https://avatars.githubusercontent.com/u/5047891?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/23","html_url":"https://github.com/Microsoft/vscode/milestones/August%202016","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/23/labels","id":1854621,"number":23,"title":"August 2016","description":"","creator":{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars.githubusercontent.com/u/1931590?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":334,"state":"open","created_at":"2016-06-29T08:56:21Z","updated_at":"2016-08-29T21:23:46Z","due_on":"2016-09-02T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Microsoft/vscode/pulls/10833/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode/pulls/10833/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/10833/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/b24186629f1828ca9fa3d0da3c23c205dcebf851","head":{"label":"paveldk:pkolev/fix-terminated-worker","ref":"pkolev/fix-terminated-worker","sha":"b24186629f1828ca9fa3d0da3c23c205dcebf851","user":{"login":"paveldk","id":1455045,"avatar_url":"https://avatars.githubusercontent.com/u/1455045?v=3","gravatar_id":"","url":"https://api.github.com/users/paveldk","html_url":"https://github.com/paveldk","followers_url":"https://api.github.com/users/paveldk/followers","following_url":"https://api.github.com/users/paveldk/following{/other_user}","gists_url":"https://api.github.com/users/paveldk/gists{/gist_id}","starred_url":"https://api.github.com/users/paveldk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveldk/subscriptions","organizations_url":"https://api.github.com/users/paveldk/orgs","repos_url":"https://api.github.com/users/paveldk/repos","events_url":"https://api.github.com/users/paveldk/events{/privacy}","received_events_url":"https://api.github.com/users/paveldk/received_events","type":"User","site_admin":false},"repo":{"id":66360901,"name":"vscode","full_name":"paveldk/vscode","owner":{"login":"paveldk","id":1455045,"avatar_url":"https://avatars.githubusercontent.com/u/1455045?v=3","gravatar_id":"","url":"https://api.github.com/users/paveldk","html_url":"https://github.com/paveldk","followers_url":"https://api.github.com/users/paveldk/followers","following_url":"https://api.github.com/users/paveldk/following{/other_user}","gists_url":"https://api.github.com/users/paveldk/gists{/gist_id}","starred_url":"https://api.github.com/users/paveldk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveldk/subscriptions","organizations_url":"https://api.github.com/users/paveldk/orgs","repos_url":"https://api.github.com/users/paveldk/repos","events_url":"https://api.github.com/users/paveldk/events{/privacy}","received_events_url":"https://api.github.com/users/paveldk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paveldk/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/paveldk/vscode","forks_url":"https://api.github.com/repos/paveldk/vscode/forks","keys_url":"https://api.github.com/repos/paveldk/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paveldk/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paveldk/vscode/teams","hooks_url":"https://api.github.com/repos/paveldk/vscode/hooks","issue_events_url":"https://api.github.com/repos/paveldk/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/paveldk/vscode/events","assignees_url":"https://api.github.com/repos/paveldk/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/paveldk/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/paveldk/vscode/tags","blobs_url":"https://api.github.com/repos/paveldk/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paveldk/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paveldk/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/paveldk/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paveldk/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/paveldk/vscode/languages","stargazers_url":"https://api.github.com/repos/paveldk/vscode/stargazers","contributors_url":"https://api.github.com/repos/paveldk/vscode/contributors","subscribers_url":"https://api.github.com/repos/paveldk/vscode/subscribers","subscription_url":"https://api.github.com/repos/paveldk/vscode/subscription","commits_url":"https://api.github.com/repos/paveldk/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/paveldk/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/paveldk/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/paveldk/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/paveldk/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/paveldk/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paveldk/vscode/merges","archive_url":"https://api.github.com/repos/paveldk/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paveldk/vscode/downloads","issues_url":"https://api.github.com/repos/paveldk/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/paveldk/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/paveldk/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/paveldk/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paveldk/vscode/labels{/name}","releases_url":"https://api.github.com/repos/paveldk/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/paveldk/vscode/deployments","created_at":"2016-08-23T11:24:58Z","updated_at":"2016-08-23T11:25:08Z","pushed_at":"2016-08-23T13:28:54Z","git_url":"git://github.com/paveldk/vscode.git","ssh_url":"git@github.com:paveldk/vscode.git","clone_url":"https://github.com/paveldk/vscode.git","svn_url":"https://github.com/paveldk/vscode","homepage":"http://code.visualstudio.com","size":38348,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"20b12fc217eed131d5ef1e8a1e1e80ba2c17d4db","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41881900,"name":"vscode","full_name":"Microsoft/vscode","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode","description":"Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode","forks_url":"https://api.github.com/repos/Microsoft/vscode/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode/deployments","created_at":"2015-09-03T20:23:38Z","updated_at":"2016-08-29T20:46:24Z","pushed_at":"2016-08-29T21:23:46Z","git_url":"git://github.com/Microsoft/vscode.git","ssh_url":"git@github.com:Microsoft/vscode.git","clone_url":"https://github.com/Microsoft/vscode.git","svn_url":"https://github.com/Microsoft/vscode","homepage":"http://code.visualstudio.com","size":50567,"stargazers_count":17051,"watchers_count":17051,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2337,"mirror_url":null,"open_issues_count":2288,"forks":2337,"open_issues":2288,"watchers":17051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/10833"},"html":{"href":"https://github.com/Microsoft/vscode/pull/10833"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/10833"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/10833/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/10833/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/10833/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode/statuses/b24186629f1828ca9fa3d0da3c23c205dcebf851"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexandrudima","id":5047891,"avatar_url":"https://avatars.githubusercontent.com/u/5047891?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"alexandrudima"}}