{"action":"created","issue":{"url":"https://api.github.com/repos/typings/typings/issues/151","repository_url":"https://api.github.com/repos/typings/typings","labels_url":"https://api.github.com/repos/typings/typings/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/typings/typings/issues/151/comments","events_url":"https://api.github.com/repos/typings/typings/issues/151/events","html_url":"https://github.com/typings/typings/issues/151","id":130558101,"number":151,"title":"Remove `browser.d.ts`","user":{"login":"basarat","id":874898,"avatar_url":"https://avatars.githubusercontent.com/u/874898?v=3","gravatar_id":"","url":"https://api.github.com/users/basarat","html_url":"https://github.com/basarat","followers_url":"https://api.github.com/users/basarat/followers","following_url":"https://api.github.com/users/basarat/following{/other_user}","gists_url":"https://api.github.com/users/basarat/gists{/gist_id}","starred_url":"https://api.github.com/users/basarat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basarat/subscriptions","organizations_url":"https://api.github.com/users/basarat/orgs","repos_url":"https://api.github.com/users/basarat/repos","events_url":"https://api.github.com/users/basarat/events{/privacy}","received_events_url":"https://api.github.com/users/basarat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/typings/typings/labels/discussion","name":"discussion","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/typings/typings/milestones/2","html_url":"https://github.com/typings/typings/milestones/Major%20Release","labels_url":"https://api.github.com/repos/typings/typings/milestones/2/labels","id":1588913,"number":2,"title":"Major Release","description":"","creator":{"login":"blakeembrey","id":1088987,"avatar_url":"https://avatars.githubusercontent.com/u/1088987?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeembrey","html_url":"https://github.com/blakeembrey","followers_url":"https://api.github.com/users/blakeembrey/followers","following_url":"https://api.github.com/users/blakeembrey/following{/other_user}","gists_url":"https://api.github.com/users/blakeembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeembrey/subscriptions","organizations_url":"https://api.github.com/users/blakeembrey/orgs","repos_url":"https://api.github.com/users/blakeembrey/repos","events_url":"https://api.github.com/users/blakeembrey/events{/privacy}","received_events_url":"https://api.github.com/users/blakeembrey/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":2,"state":"open","created_at":"2016-02-17T16:51:31Z","updated_at":"2016-03-31T03:44:57Z","due_on":null,"closed_at":null},"comments":103,"created_at":"2016-02-02T03:11:44Z","updated_at":"2016-05-04T22:16:10Z","closed_at":null,"body":"Would like to discuss if we truly need `browser.d.ts` and `main.d.ts`. Would like to table the desire to remove `browser.d.ts` at least for the time being. \r\n\r\nWith the default tsconfig, Something like `{}`: \r\n\r\n* The user will get a lot of *duplicate identifier* errors. \r\n* The user needs to go ahead and do one of the following:\r\n  * `exclude: [\"typings/browser\", \"typings/browser.d.ts\"]` < not intutive to a newbie\r\n  * OR `exclude: [\"typings/main\", \"typings/main.d.ts\"]` < not intutive to a newbie\r\n\r\n\r\n# General issues\r\n* Everytime there is a typings install it will overwrite `browser.d.ts` / `main.d.ts` anyways and that puts them back in step one. \r\n* It is unclear how the user would organize his codebase to effectively use `main` and `browser` side-by-side. And for the user that does manage that they can probably generate the `browser.d.ts` and `main.d.ts` *themselves*. \r\n\r\nI just had a colleague go through and start a new TypeScript project and they struggled till I was brought in :rose: "},"comment":{"url":"https://api.github.com/repos/typings/typings/issues/comments/217020300","html_url":"https://github.com/typings/typings/issues/151#issuecomment-217020300","issue_url":"https://api.github.com/repos/typings/typings/issues/151","id":217020300,"user":{"login":"phestermcs","id":4985028,"avatar_url":"https://avatars.githubusercontent.com/u/4985028?v=3","gravatar_id":"","url":"https://api.github.com/users/phestermcs","html_url":"https://github.com/phestermcs","followers_url":"https://api.github.com/users/phestermcs/followers","following_url":"https://api.github.com/users/phestermcs/following{/other_user}","gists_url":"https://api.github.com/users/phestermcs/gists{/gist_id}","starred_url":"https://api.github.com/users/phestermcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phestermcs/subscriptions","organizations_url":"https://api.github.com/users/phestermcs/orgs","repos_url":"https://api.github.com/users/phestermcs/repos","events_url":"https://api.github.com/users/phestermcs/events{/privacy}","received_events_url":"https://api.github.com/users/phestermcs/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T22:16:09Z","updated_at":"2016-05-04T22:16:09Z","body":"So. In Travis the tests failed on Node 0.10 and 0.12, but all tests passed for for later Node version.\r\nIn AppVeyor, all tests passed.\r\n\r\nI did test all the commands, including uninstall. But you're saying that if the typing isn't there on uninstall the user should be told that?\r\n\r\nTo confirm changes to PR:\r\n\r\n1. Change \"resolution\" to \"out\".\r\n2. The default will be to create just the 'main' out if \"resolution\" is not configured, but with identical stucture as today\r\n3. I'll remove the 'both' option\r\n4. Ensure uninstall warns user if trying to uninstall a noexistent typings\r\n\r\nyes?"}}