{"push_id":1412072957,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"c507c59b6a166a85a262673fe7f1d4a3020bd599","before":"3eae4e0711924721db49b4e3b840282ca987a80c","commits":[{"sha":"c507c59b6a166a85a262673fe7f1d4a3020bd599","author":{"name":"Khalid Huseynov","email":"ad9a9dccddcba9ad5c45c29105c0c401b8efd351@gmail.com"},"message":"[ZEPPELIN-1657] Private/public mode for user note creation/import\n\n### What is this PR for?\nIn multi-user environment when users create a notebook normally they would expect that notebook be listed only in their list/workbench. Currently Zeppelin creates/imports notes as public by default. There should be at least a way to pass through configuration to make this behaviour private be default. Should discuss whether it's public or private by default.\n\n### What type of PR is it?\nImprovement\n\n### Todos\n* [x] - set permissions on create/import\n* [x] - test\n* [x] - review, feedback, decide whether public/private by default\n* [x] - pass through env. config\n\n### What is the Jira issue?\n[ZEPPELIN-1657](https://issues.apache.org/jira/browse/ZEPPELIN-1657)\n\n### How should this be tested?\n1. set `zeppelin.notebook.public` property as false in `zeppelin-site.xml`\n2. login as user1 and create noteA, note should appear in your list of notes\n3. logout and login as user2, shouldn't be able to see noteA\n\n### Screenshots (if appropriate)\nTBD\n\n### Questions:\n* Does the licenses files need update? no\n* Is there breaking changes for older versions? no\n* Does this needs documentation? maybe\n\nAuthor: Khalid Huseynov <khalidhnv@gmail.com>\n\nCloses #1625 from khalidhuseynov/feat/public-note-create and squashes the following commits:\n\n010c262 [Khalid Huseynov] fix test: set state back\nfc91b2f [Khalid Huseynov] add description to install config\nf862ae1 [Khalid Huseynov] fix InterpreterFactory test\n876b798 [Khalid Huseynov] fix vfs testSave npe\n1a945e8 [Khalid Huseynov] add test\n496b80c [Khalid Huseynov] read env var from conf file directly\n28abffa [Khalid Huseynov] set permissions on note create and import\n44297a4 [Khalid Huseynov] set new note permissions\n9732409 [Khalid Huseynov] add variable to ZeppelinConfiguration\n4062af0 [Khalid Huseynov] add var to env.sh\nb7f28b3 [Khalid Huseynov] add property to site.xml","distinct":true,"url":"https://api.github.com/repos/apache/zeppelin/commits/c507c59b6a166a85a262673fe7f1d4a3020bd599"}]}
{"actor":{"display_login":"asfgit"}}