{"action":"closed","number":183,"pull_request":{"url":"https://api.github.com/repos/po-devs/po-web/pulls/183","id":83224733,"html_url":"https://github.com/po-devs/po-web/pull/183","diff_url":"https://github.com/po-devs/po-web/pull/183.diff","patch_url":"https://github.com/po-devs/po-web/pull/183.patch","issue_url":"https://api.github.com/repos/po-devs/po-web/issues/183","number":183,"state":"closed","locked":false,"title":"clean up the build scripts, enforce a bit of eslint, update dependencies","user":{"login":"Sulcata","id":2075087,"avatar_url":"https://avatars.githubusercontent.com/u/2075087?v=3","gravatar_id":"","url":"https://api.github.com/users/Sulcata","html_url":"https://github.com/Sulcata","followers_url":"https://api.github.com/users/Sulcata/followers","following_url":"https://api.github.com/users/Sulcata/following{/other_user}","gists_url":"https://api.github.com/users/Sulcata/gists{/gist_id}","starred_url":"https://api.github.com/users/Sulcata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sulcata/subscriptions","organizations_url":"https://api.github.com/users/Sulcata/orgs","repos_url":"https://api.github.com/users/Sulcata/repos","events_url":"https://api.github.com/users/Sulcata/events{/privacy}","received_events_url":"https://api.github.com/users/Sulcata/received_events","type":"User","site_admin":false},"body":"* Cleaned up the build scripts and got rid of unnecessary clutter. For whatever reason we weren't using load-grunt-tasks before.\r\n\r\n* Updated the dependency versions.\r\n\r\n* Added ESLlint\r\nA large chunk of the rules I enabled for ESLint are purely stylistic and can be changed if people dislike them (is anyone even working on this?). It would be good to just run with a set style though.\r\n\r\nThere were quite a few errors that I had to stuff by turning certain rules off in a lower down .eslintrc file in app/assets/javascript. We should really turn most of these files into modules and add a browserify step so we can get proper linting of typos along with cleaning up the global namespace, but that's a much larger task for a much farther day. I'll open up an issue or two.\r\n\r\nalso, i was pleasantly surprised to only find two nested ternaries :]","created_at":"2016-08-30T08:00:15Z","updated_at":"2016-08-31T01:35:00Z","closed_at":"2016-08-31T01:35:00Z","merged_at":null,"merge_commit_sha":"09946982aa20ddf2aa0c25c79badbd4404a80845","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/po-devs/po-web/pulls/183/commits","review_comments_url":"https://api.github.com/repos/po-devs/po-web/pulls/183/comments","review_comment_url":"https://api.github.com/repos/po-devs/po-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/po-devs/po-web/issues/183/comments","statuses_url":"https://api.github.com/repos/po-devs/po-web/statuses/c0d4b8dec120c0e8440c47eb431a678a907494b9","head":{"label":"Sulcata:master","ref":"master","sha":"c0d4b8dec120c0e8440c47eb431a678a907494b9","user":{"login":"Sulcata","id":2075087,"avatar_url":"https://avatars.githubusercontent.com/u/2075087?v=3","gravatar_id":"","url":"https://api.github.com/users/Sulcata","html_url":"https://github.com/Sulcata","followers_url":"https://api.github.com/users/Sulcata/followers","following_url":"https://api.github.com/users/Sulcata/following{/other_user}","gists_url":"https://api.github.com/users/Sulcata/gists{/gist_id}","starred_url":"https://api.github.com/users/Sulcata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sulcata/subscriptions","organizations_url":"https://api.github.com/users/Sulcata/orgs","repos_url":"https://api.github.com/users/Sulcata/repos","events_url":"https://api.github.com/users/Sulcata/events{/privacy}","received_events_url":"https://api.github.com/users/Sulcata/received_events","type":"User","site_admin":false},"repo":{"id":66894313,"name":"po-web","full_name":"Sulcata/po-web","owner":{"login":"Sulcata","id":2075087,"avatar_url":"https://avatars.githubusercontent.com/u/2075087?v=3","gravatar_id":"","url":"https://api.github.com/users/Sulcata","html_url":"https://github.com/Sulcata","followers_url":"https://api.github.com/users/Sulcata/followers","following_url":"https://api.github.com/users/Sulcata/following{/other_user}","gists_url":"https://api.github.com/users/Sulcata/gists{/gist_id}","starred_url":"https://api.github.com/users/Sulcata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sulcata/subscriptions","organizations_url":"https://api.github.com/users/Sulcata/orgs","repos_url":"https://api.github.com/users/Sulcata/repos","events_url":"https://api.github.com/users/Sulcata/events{/privacy}","received_events_url":"https://api.github.com/users/Sulcata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sulcata/po-web","description":"Pokemon Online webclient","fork":true,"url":"https://api.github.com/repos/Sulcata/po-web","forks_url":"https://api.github.com/repos/Sulcata/po-web/forks","keys_url":"https://api.github.com/repos/Sulcata/po-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sulcata/po-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sulcata/po-web/teams","hooks_url":"https://api.github.com/repos/Sulcata/po-web/hooks","issue_events_url":"https://api.github.com/repos/Sulcata/po-web/issues/events{/number}","events_url":"https://api.github.com/repos/Sulcata/po-web/events","assignees_url":"https://api.github.com/repos/Sulcata/po-web/assignees{/user}","branches_url":"https://api.github.com/repos/Sulcata/po-web/branches{/branch}","tags_url":"https://api.github.com/repos/Sulcata/po-web/tags","blobs_url":"https://api.github.com/repos/Sulcata/po-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sulcata/po-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sulcata/po-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sulcata/po-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sulcata/po-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Sulcata/po-web/languages","stargazers_url":"https://api.github.com/repos/Sulcata/po-web/stargazers","contributors_url":"https://api.github.com/repos/Sulcata/po-web/contributors","subscribers_url":"https://api.github.com/repos/Sulcata/po-web/subscribers","subscription_url":"https://api.github.com/repos/Sulcata/po-web/subscription","commits_url":"https://api.github.com/repos/Sulcata/po-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sulcata/po-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sulcata/po-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sulcata/po-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sulcata/po-web/contents/{+path}","compare_url":"https://api.github.com/repos/Sulcata/po-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sulcata/po-web/merges","archive_url":"https://api.github.com/repos/Sulcata/po-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sulcata/po-web/downloads","issues_url":"https://api.github.com/repos/Sulcata/po-web/issues{/number}","pulls_url":"https://api.github.com/repos/Sulcata/po-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Sulcata/po-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Sulcata/po-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sulcata/po-web/labels{/name}","releases_url":"https://api.github.com/repos/Sulcata/po-web/releases{/id}","deployments_url":"https://api.github.com/repos/Sulcata/po-web/deployments","created_at":"2016-08-30T01:18:39Z","updated_at":"2016-08-30T01:18:40Z","pushed_at":"2016-08-31T01:31:58Z","git_url":"git://github.com/Sulcata/po-web.git","ssh_url":"git@github.com:Sulcata/po-web.git","clone_url":"https://github.com/Sulcata/po-web.git","svn_url":"https://github.com/Sulcata/po-web","homepage":null,"size":28355,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"po-devs:master","ref":"master","sha":"c5651d178307df88eca17b7978562653d7cbf10d","user":{"login":"po-devs","id":3062336,"avatar_url":"https://avatars.githubusercontent.com/u/3062336?v=3","gravatar_id":"","url":"https://api.github.com/users/po-devs","html_url":"https://github.com/po-devs","followers_url":"https://api.github.com/users/po-devs/followers","following_url":"https://api.github.com/users/po-devs/following{/other_user}","gists_url":"https://api.github.com/users/po-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/po-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/po-devs/subscriptions","organizations_url":"https://api.github.com/users/po-devs/orgs","repos_url":"https://api.github.com/users/po-devs/repos","events_url":"https://api.github.com/users/po-devs/events{/privacy}","received_events_url":"https://api.github.com/users/po-devs/received_events","type":"Organization","site_admin":false},"repo":{"id":42894069,"name":"po-web","full_name":"po-devs/po-web","owner":{"login":"po-devs","id":3062336,"avatar_url":"https://avatars.githubusercontent.com/u/3062336?v=3","gravatar_id":"","url":"https://api.github.com/users/po-devs","html_url":"https://github.com/po-devs","followers_url":"https://api.github.com/users/po-devs/followers","following_url":"https://api.github.com/users/po-devs/following{/other_user}","gists_url":"https://api.github.com/users/po-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/po-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/po-devs/subscriptions","organizations_url":"https://api.github.com/users/po-devs/orgs","repos_url":"https://api.github.com/users/po-devs/repos","events_url":"https://api.github.com/users/po-devs/events{/privacy}","received_events_url":"https://api.github.com/users/po-devs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/po-devs/po-web","description":"Pokemon Online webclient","fork":false,"url":"https://api.github.com/repos/po-devs/po-web","forks_url":"https://api.github.com/repos/po-devs/po-web/forks","keys_url":"https://api.github.com/repos/po-devs/po-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/po-devs/po-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/po-devs/po-web/teams","hooks_url":"https://api.github.com/repos/po-devs/po-web/hooks","issue_events_url":"https://api.github.com/repos/po-devs/po-web/issues/events{/number}","events_url":"https://api.github.com/repos/po-devs/po-web/events","assignees_url":"https://api.github.com/repos/po-devs/po-web/assignees{/user}","branches_url":"https://api.github.com/repos/po-devs/po-web/branches{/branch}","tags_url":"https://api.github.com/repos/po-devs/po-web/tags","blobs_url":"https://api.github.com/repos/po-devs/po-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/po-devs/po-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/po-devs/po-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/po-devs/po-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/po-devs/po-web/statuses/{sha}","languages_url":"https://api.github.com/repos/po-devs/po-web/languages","stargazers_url":"https://api.github.com/repos/po-devs/po-web/stargazers","contributors_url":"https://api.github.com/repos/po-devs/po-web/contributors","subscribers_url":"https://api.github.com/repos/po-devs/po-web/subscribers","subscription_url":"https://api.github.com/repos/po-devs/po-web/subscription","commits_url":"https://api.github.com/repos/po-devs/po-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/po-devs/po-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/po-devs/po-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/po-devs/po-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/po-devs/po-web/contents/{+path}","compare_url":"https://api.github.com/repos/po-devs/po-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/po-devs/po-web/merges","archive_url":"https://api.github.com/repos/po-devs/po-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/po-devs/po-web/downloads","issues_url":"https://api.github.com/repos/po-devs/po-web/issues{/number}","pulls_url":"https://api.github.com/repos/po-devs/po-web/pulls{/number}","milestones_url":"https://api.github.com/repos/po-devs/po-web/milestones{/number}","notifications_url":"https://api.github.com/repos/po-devs/po-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/po-devs/po-web/labels{/name}","releases_url":"https://api.github.com/repos/po-devs/po-web/releases{/id}","deployments_url":"https://api.github.com/repos/po-devs/po-web/deployments","created_at":"2015-09-21T21:16:01Z","updated_at":"2016-08-10T04:29:19Z","pushed_at":"2016-08-31T01:31:59Z","git_url":"git://github.com/po-devs/po-web.git","ssh_url":"git@github.com:po-devs/po-web.git","clone_url":"https://github.com/po-devs/po-web.git","svn_url":"https://github.com/po-devs/po-web","homepage":null,"size":28402,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":40,"forks":16,"open_issues":40,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/po-devs/po-web/pulls/183"},"html":{"href":"https://github.com/po-devs/po-web/pull/183"},"issue":{"href":"https://api.github.com/repos/po-devs/po-web/issues/183"},"comments":{"href":"https://api.github.com/repos/po-devs/po-web/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/po-devs/po-web/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/po-devs/po-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/po-devs/po-web/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/po-devs/po-web/statuses/c0d4b8dec120c0e8440c47eb431a678a907494b9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":12,"review_comments":0,"commits":1,"additions":1908,"deletions":1496,"changed_files":35}}
{"actor":{"display_login":"Sulcata"}}