{"action":"created","issue":{"url":"https://api.github.com/repos/purescript/purescript/issues/2271","repository_url":"https://api.github.com/repos/purescript/purescript","labels_url":"https://api.github.com/repos/purescript/purescript/issues/2271/labels{/name}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/2271/comments","events_url":"https://api.github.com/repos/purescript/purescript/issues/2271/events","html_url":"https://github.com/purescript/purescript/pull/2271","id":169860334,"number":2271,"title":"Improved error messages for record subsumption","user":{"login":"FrigoEU","id":4463490,"avatar_url":"https://avatars.githubusercontent.com/u/4463490?v=3","gravatar_id":"","url":"https://api.github.com/users/FrigoEU","html_url":"https://github.com/FrigoEU","followers_url":"https://api.github.com/users/FrigoEU/followers","following_url":"https://api.github.com/users/FrigoEU/following{/other_user}","gists_url":"https://api.github.com/users/FrigoEU/gists{/gist_id}","starred_url":"https://api.github.com/users/FrigoEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrigoEU/subscriptions","organizations_url":"https://api.github.com/users/FrigoEU/orgs","repos_url":"https://api.github.com/users/FrigoEU/repos","events_url":"https://api.github.com/users/FrigoEU/events{/privacy}","received_events_url":"https://api.github.com/users/FrigoEU/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-08T07:37:33Z","updated_at":"2016-08-12T11:03:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/2271","html_url":"https://github.com/purescript/purescript/pull/2271","diff_url":"https://github.com/purescript/purescript/pull/2271.diff","patch_url":"https://github.com/purescript/purescript/pull/2271.patch"},"body":"Trying to get to know the typechecker better so I looked for the easiest bug I could find: #1896 . It's my first PR to the compiler, so if I missed anything please let me know.\r\n\r\nOne question I do have is about tests: Since the bug depends on sorting of keys in the records, I had to go through a few iterations to get it right and to wrap my head around the full problem. I have/had testcases that were failing for all those iterations. I'm not sure if I should be adding these. Feels a bit stupid to add 5+ files with always a tiny variation of a case."},"comment":{"url":"https://api.github.com/repos/purescript/purescript/issues/comments/239419415","html_url":"https://github.com/purescript/purescript/pull/2271#issuecomment-239419415","issue_url":"https://api.github.com/repos/purescript/purescript/issues/2271","id":239419415,"user":{"login":"FrigoEU","id":4463490,"avatar_url":"https://avatars.githubusercontent.com/u/4463490?v=3","gravatar_id":"","url":"https://api.github.com/users/FrigoEU","html_url":"https://github.com/FrigoEU","followers_url":"https://api.github.com/users/FrigoEU/followers","following_url":"https://api.github.com/users/FrigoEU/following{/other_user}","gists_url":"https://api.github.com/users/FrigoEU/gists{/gist_id}","starred_url":"https://api.github.com/users/FrigoEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrigoEU/subscriptions","organizations_url":"https://api.github.com/users/FrigoEU/orgs","repos_url":"https://api.github.com/users/FrigoEU/repos","events_url":"https://api.github.com/users/FrigoEU/events{/privacy}","received_events_url":"https://api.github.com/users/FrigoEU/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T11:03:36Z","updated_at":"2016-08-12T11:03:36Z","body":"Ok, second try :). I pulled it out of the iteration and just check missing properties once, at the start. It should be much more efficient. \r\n\r\nI took the minusBy from Data.List.Ordered. I wasn't sure if I should just copy it, or if I should add it to the dependency, but for such a small function I didn't want to bother."}}
{"actor":{"display_login":"FrigoEU"}}