{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/comments/91103757","pull_request_review_id":11613561,"id":91103757,"diff_hunk":"@@ -44,7 +44,12 @@ def call(env)\n           )\n \n           # Configure the Docker daemon\n-          sudo(@env[:machine], \"SSH_USER='#{ssh_user}' #{home}/configure_docker.sh\", :timeout=>60*30)\n+          if @options[:skip_volume_group]","path":"lib/vagrant-openshift/action/install_docker.rb","position":5,"original_position":5,"commit_id":"b794e4f9d10454c8131285f24a8da17e723d9db4","original_commit_id":"b794e4f9d10454c8131285f24a8da17e723d9db4","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"Ah, yeah we may have been running without `nounset`. Ok. I'll let this languish just a bit then, probably get it done late Friday since we'll have to reconfigure all the Jenkins jobs to use the flag.","created_at":"2016-12-06T15:41:59Z","updated_at":"2016-12-06T15:41:59Z","html_url":"https://github.com/openshift/vagrant-openshift/pull/524#discussion_r91103757","pull_request_url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/comments/91103757"},"html":{"href":"https://github.com/openshift/vagrant-openshift/pull/524#discussion_r91103757"},"pull_request":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524","id":96725602,"html_url":"https://github.com/openshift/vagrant-openshift/pull/524","diff_url":"https://github.com/openshift/vagrant-openshift/pull/524.diff","patch_url":"https://github.com/openshift/vagrant-openshift/pull/524.patch","issue_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/524","number":524,"state":"open","locked":false,"title":"Added an option to skip Docker volume group setup","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"In the generic case where a user is creating an environment using this\r\ntool, they may or may not want to use volume groups for Docker storage.\r\nWe should allow them to choose, but keep the current behavior as the\r\ndefault. When we are trying to use volume groups but cannot find the\r\ngroup to use, we should also fail loudly and clearly.\r\n\r\nSigned-off-by: Steve Kuznetsov <skuznets@redhat.com>","created_at":"2016-12-06T13:41:24Z","updated_at":"2016-12-06T15:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"270c8a20f5001686c479673a85dce8c530307e6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524/commits","review_comments_url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524/comments","review_comment_url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/524/comments","statuses_url":"https://api.github.com/repos/openshift/vagrant-openshift/statuses/b794e4f9d10454c8131285f24a8da17e723d9db4","head":{"label":"stevekuznetsov:skuznets/volume-groups","ref":"skuznets/volume-groups","sha":"b794e4f9d10454c8131285f24a8da17e723d9db4","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"repo":{"id":40658550,"name":"vagrant-openshift","full_name":"stevekuznetsov/vagrant-openshift","owner":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevekuznetsov/vagrant-openshift","description":"vagrant-openshift","fork":true,"url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift","forks_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/forks","keys_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/teams","hooks_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/hooks","issue_events_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/events","assignees_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/tags","blobs_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/languages","stargazers_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/stargazers","contributors_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/contributors","subscribers_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/subscribers","subscription_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/subscription","commits_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/merges","archive_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/downloads","issues_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/labels{/name}","releases_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/stevekuznetsov/vagrant-openshift/deployments","created_at":"2015-08-13T12:51:32Z","updated_at":"2016-01-12T13:55:32Z","pushed_at":"2016-12-06T13:40:59Z","git_url":"git://github.com/stevekuznetsov/vagrant-openshift.git","ssh_url":"git@github.com:stevekuznetsov/vagrant-openshift.git","clone_url":"https://github.com/stevekuznetsov/vagrant-openshift.git","svn_url":"https://github.com/stevekuznetsov/vagrant-openshift","homepage":null,"size":1028,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b54d3ebfc06cca5b18cd672872fd826a81794463","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":12317077,"name":"vagrant-openshift","full_name":"openshift/vagrant-openshift","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/vagrant-openshift","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/vagrant-openshift","forks_url":"https://api.github.com/repos/openshift/vagrant-openshift/forks","keys_url":"https://api.github.com/repos/openshift/vagrant-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/vagrant-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/vagrant-openshift/teams","hooks_url":"https://api.github.com/repos/openshift/vagrant-openshift/hooks","issue_events_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/vagrant-openshift/events","assignees_url":"https://api.github.com/repos/openshift/vagrant-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/vagrant-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/vagrant-openshift/tags","blobs_url":"https://api.github.com/repos/openshift/vagrant-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/vagrant-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/vagrant-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/vagrant-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/vagrant-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/vagrant-openshift/languages","stargazers_url":"https://api.github.com/repos/openshift/vagrant-openshift/stargazers","contributors_url":"https://api.github.com/repos/openshift/vagrant-openshift/contributors","subscribers_url":"https://api.github.com/repos/openshift/vagrant-openshift/subscribers","subscription_url":"https://api.github.com/repos/openshift/vagrant-openshift/subscription","commits_url":"https://api.github.com/repos/openshift/vagrant-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/vagrant-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/vagrant-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/vagrant-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/vagrant-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/vagrant-openshift/merges","archive_url":"https://api.github.com/repos/openshift/vagrant-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/vagrant-openshift/downloads","issues_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/vagrant-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/vagrant-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/vagrant-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/vagrant-openshift/labels{/name}","releases_url":"https://api.github.com/repos/openshift/vagrant-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/vagrant-openshift/deployments","created_at":"2013-08-23T07:19:59Z","updated_at":"2016-11-24T23:43:09Z","pushed_at":"2016-12-06T13:41:25Z","git_url":"git://github.com/openshift/vagrant-openshift.git","ssh_url":"git@github.com:openshift/vagrant-openshift.git","clone_url":"https://github.com/openshift/vagrant-openshift.git","svn_url":"https://github.com/openshift/vagrant-openshift","homepage":"","size":1419,"stargazers_count":77,"watchers_count":77,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":11,"forks":120,"open_issues":11,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524"},"html":{"href":"https://github.com/openshift/vagrant-openshift/pull/524"},"issue":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/issues/524"},"comments":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/vagrant-openshift/statuses/b794e4f9d10454c8131285f24a8da17e723d9db4"}}}}
{"actor":{"display_login":"stevekuznetsov"}}