{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/91798921","pull_request_review_id":12172991,"id":91798921,"diff_hunk":"@@ -17,111 +17,142 @@\n package quasar.physical.couchbase\n \n import quasar.Predef._\n-import quasar.DataCodec.Precise.NAKey\n-\n-import monocle.macros.Lenses\n-import monocle.Prism\n-import scalaz._, Scalaz._\n-\n-sealed trait N1QL\n-\n-// TODO: Intentionally limited for the moment\n-\n-object N1QL {\n-\n-  final case class PartialQueryString(v: String) extends N1QL\n-\n-  final case class Read(v: String) extends N1QL\n-\n-  // TODO: N1QL instead of String\n-  @Lenses final case class Select(\n-    value: Boolean,\n-    resultExprs: NonEmptyList[String],\n-    keyspace: Option[N1QL],\n-    keyspaceAlias: Option[String],\n-    let: Option[Map[String, String]],\n-    filter: Option[String],\n-    groupBy: Option[String],\n-    unnest: Option[(String, String)],\n-    orderBy: Option[String]\n-  ) extends N1QL {\n-    def n1ql: N1QL = this\n+import quasar.{Data => QData}\n+import quasar.common.SortDir\n+\n+import scalaz._, NonEmptyList.nels, OneAnd.oneAnd\n+\n+sealed trait N1QL[A]\n+\n+@SuppressWarnings(Array(\"org.wartremover.warts.Overloading\"))","path":"couchbase/src/main/scala/quasar/physical/couchbase/N1QL.scala","position":40,"original_position":40,"commit_id":"a739f19d3b6de9438a8b189316999c4bf932ae37","original_commit_id":"a739f19d3b6de9438a8b189316999c4bf932ae37","user":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"body":"This needs a comment as to why/what is being overloaded","created_at":"2016-12-09T21:29:37Z","updated_at":"2016-12-09T21:29:37Z","html_url":"https://github.com/quasar-analytics/quasar/pull/1770#discussion_r91798921","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/91798921"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1770#discussion_r91798921"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770","id":97239307,"html_url":"https://github.com/quasar-analytics/quasar/pull/1770","diff_url":"https://github.com/quasar-analytics/quasar/pull/1770.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1770.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1770","number":1770,"state":"open","locked":false,"title":"Get your N1QL fix","user":{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"body":"@sellout There are easily a few matryoshka-isms available that I've missed. Please let me know if/where you see those opportunities.","created_at":"2016-12-09T02:11:28Z","updated_at":"2016-12-09T22:01:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb120c7d9999a0274264c949afc6bad16414e57f","assignee":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"assignees":[{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1770/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/a739f19d3b6de9438a8b189316999c4bf932ae37","head":{"label":"drostron:wip/cb-get-your-n1ql-fix","ref":"wip/cb-get-your-n1ql-fix","sha":"a739f19d3b6de9438a8b189316999c4bf932ae37","user":{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"repo":{"id":42130881,"name":"quasar","full_name":"drostron/quasar","owner":{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drostron/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":true,"url":"https://api.github.com/repos/drostron/quasar","forks_url":"https://api.github.com/repos/drostron/quasar/forks","keys_url":"https://api.github.com/repos/drostron/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drostron/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drostron/quasar/teams","hooks_url":"https://api.github.com/repos/drostron/quasar/hooks","issue_events_url":"https://api.github.com/repos/drostron/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/drostron/quasar/events","assignees_url":"https://api.github.com/repos/drostron/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/drostron/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/drostron/quasar/tags","blobs_url":"https://api.github.com/repos/drostron/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drostron/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drostron/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/drostron/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drostron/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/drostron/quasar/languages","stargazers_url":"https://api.github.com/repos/drostron/quasar/stargazers","contributors_url":"https://api.github.com/repos/drostron/quasar/contributors","subscribers_url":"https://api.github.com/repos/drostron/quasar/subscribers","subscription_url":"https://api.github.com/repos/drostron/quasar/subscription","commits_url":"https://api.github.com/repos/drostron/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/drostron/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/drostron/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/drostron/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/drostron/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/drostron/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drostron/quasar/merges","archive_url":"https://api.github.com/repos/drostron/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drostron/quasar/downloads","issues_url":"https://api.github.com/repos/drostron/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/drostron/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/drostron/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/drostron/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drostron/quasar/labels{/name}","releases_url":"https://api.github.com/repos/drostron/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/drostron/quasar/deployments","created_at":"2015-09-08T18:22:25Z","updated_at":"2016-02-11T05:19:43Z","pushed_at":"2016-12-09T02:57:22Z","git_url":"git://github.com/drostron/quasar.git","ssh_url":"git@github.com:drostron/quasar.git","clone_url":"https://github.com/drostron/quasar.git","svn_url":"https://github.com/drostron/quasar","homepage":"","size":17496,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"7030a311f9a359d4b7be65fa18a7cc373d53ffeb","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2016-12-09T16:42:40Z","pushed_at":"2016-12-09T21:58:56Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":20757,"stargazers_count":367,"watchers_count":367,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":152,"forks":57,"open_issues":152,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1770"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1770"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1770/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1770/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/a739f19d3b6de9438a8b189316999c4bf932ae37"}}}}
{"actor":{"display_login":"sellout"}}