{"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/vhelin/wla-dx/pulls/82","id":56894828,"html_url":"https://github.com/vhelin/wla-dx/pull/82","diff_url":"https://github.com/vhelin/wla-dx/pull/82.diff","patch_url":"https://github.com/vhelin/wla-dx/pull/82.patch","issue_url":"https://api.github.com/repos/vhelin/wla-dx/issues/82","number":82,"state":"open","locked":false,"title":"Implement \"namespaces\" for sections","user":{"login":"Drenn1","id":3671681,"avatar_url":"https://avatars.githubusercontent.com/u/3671681?v=3","gravatar_id":"","url":"https://api.github.com/users/Drenn1","html_url":"https://github.com/Drenn1","followers_url":"https://api.github.com/users/Drenn1/followers","following_url":"https://api.github.com/users/Drenn1/following{/other_user}","gists_url":"https://api.github.com/users/Drenn1/gists{/gist_id}","starred_url":"https://api.github.com/users/Drenn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drenn1/subscriptions","organizations_url":"https://api.github.com/users/Drenn1/orgs","repos_url":"https://api.github.com/users/Drenn1/repos","events_url":"https://api.github.com/users/Drenn1/events{/privacy}","received_events_url":"https://api.github.com/users/Drenn1/received_events","type":"User","site_admin":false},"body":"This is an implementation for issue #81. Though I changed the name to \"namespaces\" since that's basically what it is. This isn't necessarily complete but I'm hoping to discuss it a bit. It works like this:\r\n\r\n```\r\n.SECTION \"Bank 15\" NAMESPACE \"bank15\"\r\n\r\nsomeFunction1:\r\n    ; some code\r\n\r\nsomeFunction2:\r\n    call someFunction1 ; Works\r\n\r\n.ENDS\r\n\r\n...\r\n\r\n; Later\r\nsomeFunction3:\r\n    call someFunction1 ; Compile error\r\n    call bank15.someFunction1 ; Works\r\n```\r\n\r\nI included an example for debugging purposes.\r\n\r\nSome notes / things I'd like to discuss:\r\n- A .using directive could be appropriate.\r\n- I haven't tested libraries yet.\r\n- The linker will probably get confused if you define labels like \"identifier.name\" when a label \"name\" already exists in a section with namespace \"identifier\". Or something like that.\r\n- Currently .define's inside sections don't have this behaviour, they go into the \"global\" namespace. I think they should probably be treated the same as labels instead, I just wanted to see what people think first.\r\n- Should ramsections, enums, etc have namespaces? Would it be better to have a separate \".NAMESPACE\" directive?\r\n- I see why you were talking about refactoring now!","created_at":"2016-01-22T14:38:00Z","updated_at":"2016-01-22T14:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vhelin/wla-dx/pulls/82/commits","review_comments_url":"https://api.github.com/repos/vhelin/wla-dx/pulls/82/comments","review_comment_url":"https://api.github.com/repos/vhelin/wla-dx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vhelin/wla-dx/issues/82/comments","statuses_url":"https://api.github.com/repos/vhelin/wla-dx/statuses/752a015f641700b915843f19ef88d691d389e277","head":{"label":"Drenn1:master","ref":"master","sha":"752a015f641700b915843f19ef88d691d389e277","user":{"login":"Drenn1","id":3671681,"avatar_url":"https://avatars.githubusercontent.com/u/3671681?v=3","gravatar_id":"","url":"https://api.github.com/users/Drenn1","html_url":"https://github.com/Drenn1","followers_url":"https://api.github.com/users/Drenn1/followers","following_url":"https://api.github.com/users/Drenn1/following{/other_user}","gists_url":"https://api.github.com/users/Drenn1/gists{/gist_id}","starred_url":"https://api.github.com/users/Drenn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drenn1/subscriptions","organizations_url":"https://api.github.com/users/Drenn1/orgs","repos_url":"https://api.github.com/users/Drenn1/repos","events_url":"https://api.github.com/users/Drenn1/events{/privacy}","received_events_url":"https://api.github.com/users/Drenn1/received_events","type":"User","site_admin":false},"repo":{"id":50163533,"name":"wla-dx","full_name":"Drenn1/wla-dx","owner":{"login":"Drenn1","id":3671681,"avatar_url":"https://avatars.githubusercontent.com/u/3671681?v=3","gravatar_id":"","url":"https://api.github.com/users/Drenn1","html_url":"https://github.com/Drenn1","followers_url":"https://api.github.com/users/Drenn1/followers","following_url":"https://api.github.com/users/Drenn1/following{/other_user}","gists_url":"https://api.github.com/users/Drenn1/gists{/gist_id}","starred_url":"https://api.github.com/users/Drenn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drenn1/subscriptions","organizations_url":"https://api.github.com/users/Drenn1/orgs","repos_url":"https://api.github.com/users/Drenn1/repos","events_url":"https://api.github.com/users/Drenn1/events{/privacy}","received_events_url":"https://api.github.com/users/Drenn1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Drenn1/wla-dx","description":"WLA DX - Yet Another GB-Z80/Z80/6502/65C02/6510/65816/HUC6280/SPC-700 Multi Platform Cross Assembler Package","fork":true,"url":"https://api.github.com/repos/Drenn1/wla-dx","forks_url":"https://api.github.com/repos/Drenn1/wla-dx/forks","keys_url":"https://api.github.com/repos/Drenn1/wla-dx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Drenn1/wla-dx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Drenn1/wla-dx/teams","hooks_url":"https://api.github.com/repos/Drenn1/wla-dx/hooks","issue_events_url":"https://api.github.com/repos/Drenn1/wla-dx/issues/events{/number}","events_url":"https://api.github.com/repos/Drenn1/wla-dx/events","assignees_url":"https://api.github.com/repos/Drenn1/wla-dx/assignees{/user}","branches_url":"https://api.github.com/repos/Drenn1/wla-dx/branches{/branch}","tags_url":"https://api.github.com/repos/Drenn1/wla-dx/tags","blobs_url":"https://api.github.com/repos/Drenn1/wla-dx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Drenn1/wla-dx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Drenn1/wla-dx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Drenn1/wla-dx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Drenn1/wla-dx/statuses/{sha}","languages_url":"https://api.github.com/repos/Drenn1/wla-dx/languages","stargazers_url":"https://api.github.com/repos/Drenn1/wla-dx/stargazers","contributors_url":"https://api.github.com/repos/Drenn1/wla-dx/contributors","subscribers_url":"https://api.github.com/repos/Drenn1/wla-dx/subscribers","subscription_url":"https://api.github.com/repos/Drenn1/wla-dx/subscription","commits_url":"https://api.github.com/repos/Drenn1/wla-dx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Drenn1/wla-dx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Drenn1/wla-dx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Drenn1/wla-dx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Drenn1/wla-dx/contents/{+path}","compare_url":"https://api.github.com/repos/Drenn1/wla-dx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Drenn1/wla-dx/merges","archive_url":"https://api.github.com/repos/Drenn1/wla-dx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Drenn1/wla-dx/downloads","issues_url":"https://api.github.com/repos/Drenn1/wla-dx/issues{/number}","pulls_url":"https://api.github.com/repos/Drenn1/wla-dx/pulls{/number}","milestones_url":"https://api.github.com/repos/Drenn1/wla-dx/milestones{/number}","notifications_url":"https://api.github.com/repos/Drenn1/wla-dx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Drenn1/wla-dx/labels{/name}","releases_url":"https://api.github.com/repos/Drenn1/wla-dx/releases{/id}","deployments_url":"https://api.github.com/repos/Drenn1/wla-dx/deployments","created_at":"2016-01-22T06:51:12Z","updated_at":"2016-01-22T06:51:14Z","pushed_at":"2016-01-22T07:16:27Z","git_url":"git://github.com/Drenn1/wla-dx.git","ssh_url":"git@github.com:Drenn1/wla-dx.git","clone_url":"https://github.com/Drenn1/wla-dx.git","svn_url":"https://github.com/Drenn1/wla-dx","homepage":null,"size":615,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vhelin:master","ref":"master","sha":"84a1a42ab0d367138258614a2b621f35fc5f0c79","user":{"login":"vhelin","id":6417746,"avatar_url":"https://avatars.githubusercontent.com/u/6417746?v=3","gravatar_id":"","url":"https://api.github.com/users/vhelin","html_url":"https://github.com/vhelin","followers_url":"https://api.github.com/users/vhelin/followers","following_url":"https://api.github.com/users/vhelin/following{/other_user}","gists_url":"https://api.github.com/users/vhelin/gists{/gist_id}","starred_url":"https://api.github.com/users/vhelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhelin/subscriptions","organizations_url":"https://api.github.com/users/vhelin/orgs","repos_url":"https://api.github.com/users/vhelin/repos","events_url":"https://api.github.com/users/vhelin/events{/privacy}","received_events_url":"https://api.github.com/users/vhelin/received_events","type":"User","site_admin":false},"repo":{"id":15962445,"name":"wla-dx","full_name":"vhelin/wla-dx","owner":{"login":"vhelin","id":6417746,"avatar_url":"https://avatars.githubusercontent.com/u/6417746?v=3","gravatar_id":"","url":"https://api.github.com/users/vhelin","html_url":"https://github.com/vhelin","followers_url":"https://api.github.com/users/vhelin/followers","following_url":"https://api.github.com/users/vhelin/following{/other_user}","gists_url":"https://api.github.com/users/vhelin/gists{/gist_id}","starred_url":"https://api.github.com/users/vhelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhelin/subscriptions","organizations_url":"https://api.github.com/users/vhelin/orgs","repos_url":"https://api.github.com/users/vhelin/repos","events_url":"https://api.github.com/users/vhelin/events{/privacy}","received_events_url":"https://api.github.com/users/vhelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vhelin/wla-dx","description":"WLA DX - Yet Another GB-Z80/Z80/6502/65C02/6510/65816/HUC6280/SPC-700 Multi Platform Cross Assembler Package","fork":false,"url":"https://api.github.com/repos/vhelin/wla-dx","forks_url":"https://api.github.com/repos/vhelin/wla-dx/forks","keys_url":"https://api.github.com/repos/vhelin/wla-dx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vhelin/wla-dx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vhelin/wla-dx/teams","hooks_url":"https://api.github.com/repos/vhelin/wla-dx/hooks","issue_events_url":"https://api.github.com/repos/vhelin/wla-dx/issues/events{/number}","events_url":"https://api.github.com/repos/vhelin/wla-dx/events","assignees_url":"https://api.github.com/repos/vhelin/wla-dx/assignees{/user}","branches_url":"https://api.github.com/repos/vhelin/wla-dx/branches{/branch}","tags_url":"https://api.github.com/repos/vhelin/wla-dx/tags","blobs_url":"https://api.github.com/repos/vhelin/wla-dx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vhelin/wla-dx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vhelin/wla-dx/git/refs{/sha}","trees_url":"https://api.github.com/repos/vhelin/wla-dx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vhelin/wla-dx/statuses/{sha}","languages_url":"https://api.github.com/repos/vhelin/wla-dx/languages","stargazers_url":"https://api.github.com/repos/vhelin/wla-dx/stargazers","contributors_url":"https://api.github.com/repos/vhelin/wla-dx/contributors","subscribers_url":"https://api.github.com/repos/vhelin/wla-dx/subscribers","subscription_url":"https://api.github.com/repos/vhelin/wla-dx/subscription","commits_url":"https://api.github.com/repos/vhelin/wla-dx/commits{/sha}","git_commits_url":"https://api.github.com/repos/vhelin/wla-dx/git/commits{/sha}","comments_url":"https://api.github.com/repos/vhelin/wla-dx/comments{/number}","issue_comment_url":"https://api.github.com/repos/vhelin/wla-dx/issues/comments{/number}","contents_url":"https://api.github.com/repos/vhelin/wla-dx/contents/{+path}","compare_url":"https://api.github.com/repos/vhelin/wla-dx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vhelin/wla-dx/merges","archive_url":"https://api.github.com/repos/vhelin/wla-dx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vhelin/wla-dx/downloads","issues_url":"https://api.github.com/repos/vhelin/wla-dx/issues{/number}","pulls_url":"https://api.github.com/repos/vhelin/wla-dx/pulls{/number}","milestones_url":"https://api.github.com/repos/vhelin/wla-dx/milestones{/number}","notifications_url":"https://api.github.com/repos/vhelin/wla-dx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vhelin/wla-dx/labels{/name}","releases_url":"https://api.github.com/repos/vhelin/wla-dx/releases{/id}","deployments_url":"https://api.github.com/repos/vhelin/wla-dx/deployments","created_at":"2014-01-16T08:39:58Z","updated_at":"2016-01-05T11:24:45Z","pushed_at":"2016-01-22T14:38:01Z","git_url":"git://github.com/vhelin/wla-dx.git","ssh_url":"git@github.com:vhelin/wla-dx.git","clone_url":"https://github.com/vhelin/wla-dx.git","svn_url":"https://github.com/vhelin/wla-dx","homepage":null,"size":712,"stargazers_count":80,"watchers_count":80,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":44,"forks":19,"open_issues":44,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vhelin/wla-dx/pulls/82"},"html":{"href":"https://github.com/vhelin/wla-dx/pull/82"},"issue":{"href":"https://api.github.com/repos/vhelin/wla-dx/issues/82"},"comments":{"href":"https://api.github.com/repos/vhelin/wla-dx/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/vhelin/wla-dx/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/vhelin/wla-dx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vhelin/wla-dx/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/vhelin/wla-dx/statuses/752a015f641700b915843f19ef88d691d389e277"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":827,"deletions":305,"changed_files":21}}