{"action":"created","issue":{"url":"https://api.github.com/repos/hadley/ggplot2/issues/1679","repository_url":"https://api.github.com/repos/hadley/ggplot2","labels_url":"https://api.github.com/repos/hadley/ggplot2/issues/1679/labels{/name}","comments_url":"https://api.github.com/repos/hadley/ggplot2/issues/1679/comments","events_url":"https://api.github.com/repos/hadley/ggplot2/issues/1679/events","html_url":"https://github.com/hadley/ggplot2/pull/1679","id":167390016,"number":1679,"title":"Various fixes to themes","user":{"login":"jiho","id":18445,"avatar_url":"https://avatars.githubusercontent.com/u/18445?v=3","gravatar_id":"","url":"https://api.github.com/users/jiho","html_url":"https://github.com/jiho","followers_url":"https://api.github.com/users/jiho/followers","following_url":"https://api.github.com/users/jiho/following{/other_user}","gists_url":"https://api.github.com/users/jiho/gists{/gist_id}","starred_url":"https://api.github.com/users/jiho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiho/subscriptions","organizations_url":"https://api.github.com/users/jiho/orgs","repos_url":"https://api.github.com/users/jiho/repos","events_url":"https://api.github.com/users/jiho/events{/privacy}","received_events_url":"https://api.github.com/users/jiho/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hadley/ggplot2/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-25T15:09:12Z","updated_at":"2016-08-23T16:14:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hadley/ggplot2/pulls/1679","html_url":"https://github.com/hadley/ggplot2/pull/1679","diff_url":"https://github.com/hadley/ggplot2/pull/1679.diff","patch_url":"https://github.com/hadley/ggplot2/pull/1679.patch"},"body":"Make both the code and the visual aspect of all theme more homogeneous. The general idea was to take theme_grey as the reference for all changes (and since it changed slightly in the previous update of ggplot2, the other themes needed some love too!).\r\n\r\nI tried to divide the PR in small standalone commits (too lazy for several pull requests ;-) ). I'll update them as needed so that the show PR can be merged. I also added the rationale for various choices as comments in the code.\r\n\r\nSome fixes were clearly needed (default size, etc.). Visually, I think theme_bw in particular needed a review. For the others, the changes are quite subtle."},"comment":{"url":"https://api.github.com/repos/hadley/ggplot2/issues/comments/241787734","html_url":"https://github.com/hadley/ggplot2/pull/1679#issuecomment-241787734","issue_url":"https://api.github.com/repos/hadley/ggplot2/issues/1679","id":241787734,"user":{"login":"jiho","id":18445,"avatar_url":"https://avatars.githubusercontent.com/u/18445?v=3","gravatar_id":"","url":"https://api.github.com/users/jiho","html_url":"https://github.com/jiho","followers_url":"https://api.github.com/users/jiho/followers","following_url":"https://api.github.com/users/jiho/following{/other_user}","gists_url":"https://api.github.com/users/jiho/gists{/gist_id}","starred_url":"https://api.github.com/users/jiho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiho/subscriptions","organizations_url":"https://api.github.com/users/jiho/orgs","repos_url":"https://api.github.com/users/jiho/repos","events_url":"https://api.github.com/users/jiho/events{/privacy}","received_events_url":"https://api.github.com/users/jiho/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T16:14:14Z","updated_at":"2016-08-23T16:14:14Z","body":"I've rebased. I'm not sure what that failing check means..."}}
{"actor":{"display_login":"jiho"}}