{"action":"closed","number":16078,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16078","id":95851522,"html_url":"https://github.com/apache/spark/pull/16078","diff_url":"https://github.com/apache/spark/pull/16078.diff","patch_url":"https://github.com/apache/spark/pull/16078.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16078","number":16078,"state":"closed","locked":false,"title":"[SPARK-18471][MLLIB] Fix huge vectors of zero send in closure in L-BFGS","user":{"login":"AnthonyTruchet","id":2217235,"avatar_url":"https://avatars.githubusercontent.com/u/2217235?v=3","gravatar_id":"","url":"https://api.github.com/users/AnthonyTruchet","html_url":"https://github.com/AnthonyTruchet","followers_url":"https://api.github.com/users/AnthonyTruchet/followers","following_url":"https://api.github.com/users/AnthonyTruchet/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyTruchet/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyTruchet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyTruchet/subscriptions","organizations_url":"https://api.github.com/users/AnthonyTruchet/orgs","repos_url":"https://api.github.com/users/AnthonyTruchet/repos","events_url":"https://api.github.com/users/AnthonyTruchet/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyTruchet/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nIntroduced util TreeAggregatorWithZeroGenerator and used it to avoid \r\nsending huge zero vector in L-BFGS or similar aggregation.\r\n\r\n## How was this patch tested?\r\n\r\nRun custom L-BGFS using this aggregator instead of treeAggregate with significantly increased performance and stability.\r\n","created_at":"2016-11-30T09:03:46Z","updated_at":"2016-11-30T10:14:14Z","closed_at":"2016-11-30T10:14:14Z","merged_at":null,"merge_commit_sha":"f80121d7311f3bd251b09abe9691f3245118f98b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16078/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16078/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16078/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/b4333a3b89362952e900acd7824e5d40500e3b9f","head":{"label":"criteo-forks:ENG-17719-wrapper","ref":"ENG-17719-wrapper","sha":"b4333a3b89362952e900acd7824e5d40500e3b9f","user":{"login":"criteo-forks","id":9960514,"avatar_url":"https://avatars.githubusercontent.com/u/9960514?v=3","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":63715517,"name":"spark","full_name":"criteo-forks/spark","owner":{"login":"criteo-forks","id":9960514,"avatar_url":"https://avatars.githubusercontent.com/u/9960514?v=3","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-forks/spark","description":"Mirror of Apache Spark forked from Apache","fork":true,"url":"https://api.github.com/repos/criteo-forks/spark","forks_url":"https://api.github.com/repos/criteo-forks/spark/forks","keys_url":"https://api.github.com/repos/criteo-forks/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-forks/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-forks/spark/teams","hooks_url":"https://api.github.com/repos/criteo-forks/spark/hooks","issue_events_url":"https://api.github.com/repos/criteo-forks/spark/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-forks/spark/events","assignees_url":"https://api.github.com/repos/criteo-forks/spark/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-forks/spark/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-forks/spark/tags","blobs_url":"https://api.github.com/repos/criteo-forks/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-forks/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-forks/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-forks/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-forks/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-forks/spark/languages","stargazers_url":"https://api.github.com/repos/criteo-forks/spark/stargazers","contributors_url":"https://api.github.com/repos/criteo-forks/spark/contributors","subscribers_url":"https://api.github.com/repos/criteo-forks/spark/subscribers","subscription_url":"https://api.github.com/repos/criteo-forks/spark/subscription","commits_url":"https://api.github.com/repos/criteo-forks/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-forks/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-forks/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-forks/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/criteo-forks/spark/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-forks/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-forks/spark/merges","archive_url":"https://api.github.com/repos/criteo-forks/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-forks/spark/downloads","issues_url":"https://api.github.com/repos/criteo-forks/spark/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-forks/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-forks/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-forks/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-forks/spark/labels{/name}","releases_url":"https://api.github.com/repos/criteo-forks/spark/releases{/id}","deployments_url":"https://api.github.com/repos/criteo-forks/spark/deployments","created_at":"2016-07-19T17:47:09Z","updated_at":"2016-11-18T10:17:19Z","pushed_at":"2016-11-30T10:10:39Z","git_url":"git://github.com/criteo-forks/spark.git","ssh_url":"git@github.com:criteo-forks/spark.git","clone_url":"https://github.com/criteo-forks/spark.git","svn_url":"https://github.com/criteo-forks/spark","homepage":"","size":251925,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"criteo-1.6"}},"base":{"label":"apache:master","ref":"master","sha":"56c82edabd62db9e936bb9afcf300faf8ef39362","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-11-30T07:54:38Z","pushed_at":"2016-11-30T10:05:11Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":617005,"stargazers_count":10905,"watchers_count":10905,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10184,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":445,"forks":10184,"open_issues":445,"watchers":10905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16078"},"html":{"href":"https://github.com/apache/spark/pull/16078"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16078"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16078/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16078/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16078/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/b4333a3b89362952e900acd7824e5d40500e3b9f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":85,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"AnthonyTruchet"}}