{"action":"created","issue":{"url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1543","repository_url":"https://api.github.com/repos/kduske/TrenchBroom","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1543/labels{/name}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1543/comments","events_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1543/events","html_url":"https://github.com/kduske/TrenchBroom/pull/1543","id":194930877,"number":1543,"title":"BrushFaceSnapshot: save face boundary plane instead of BrushFace*","user":{"login":"ericwa","id":239161,"avatar_url":"https://avatars.githubusercontent.com/u/239161?v=3","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-12T09:52:04Z","updated_at":"2016-12-12T18:30:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1543","html_url":"https://github.com/kduske/TrenchBroom/pull/1543","diff_url":"https://github.com/kduske/TrenchBroom/pull/1543.diff","patch_url":"https://github.com/kduske/TrenchBroom/pull/1543.patch"},"body":"- Also, change TexCoordSystemSnapshot::restore() to take the TexCoordSystem* to restore the snapshot into.\r\n\r\nWork in progress fix for https://github.com/kduske/TrenchBroom/issues/1511 .\r\nArgh, and I already found a way to break this.. \r\n1. rotate the starting brush by 15 degrees about the Z axis\r\n2. reset the face attributes\r\n3. move the brush\r\n4. undo\r\n5. undo -> will fail at the `ensure(false, \"couldn't find face\");`\r\n\r\nI'm surprised it's breaking in this way, because it means there is some floating-point error persisting when you move a brush, then undo the move.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kduske/TrenchBroom/issues/comments/266511312","html_url":"https://github.com/kduske/TrenchBroom/pull/1543#issuecomment-266511312","issue_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1543","id":266511312,"user":{"login":"ericwa","id":239161,"avatar_url":"https://avatars.githubusercontent.com/u/239161?v=3","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T18:30:33Z","updated_at":"2016-12-12T18:30:33Z","body":"OK, added a test that will crash without the BrushFaceSnapshot rewrite.\r\nI'm satisfied with this now."}}
{"actor":{"display_login":"ericwa"}}