{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/52939501","id":52939501,"diff_hunk":"@@ -1,10 +1,13 @@\n # Filter/search/expression methods included in application.rb\n+require_relative '../../helpers/miq_expression/filter_subst'","path":"app/controllers/application_controller/filter.rb","position":2,"original_position":2,"commit_id":"96845b3e2395e0e5ba9844c8075a092e61286ed2","original_commit_id":"96845b3e2395e0e5ba9844c8075a092e61286ed2","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Based on that it *really* feels like it belongs in MiqExpression directly.","created_at":"2016-02-15T20:13:41Z","updated_at":"2016-02-15T20:13:41Z","html_url":"https://github.com/ManageIQ/manageiq/pull/6654#discussion_r52939501","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/52939501"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6654#discussion_r52939501"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654","id":59249992,"html_url":"https://github.com/ManageIQ/manageiq/pull/6654","diff_url":"https://github.com/ManageIQ/manageiq/pull/6654.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/6654.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6654","number":6654,"state":"open","locked":false,"title":"Extract Expression Substitution code","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"body":"Extracted substitution code from UI specific code so that\r\nit can be used in other parts of the application. We would like\r\nto use expressions with substitutions as Automate Method.","created_at":"2016-02-13T00:21:51Z","updated_at":"2016-02-15T20:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c48c891b60c9df704fdc7c78714edc5bbb4e6f5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6654/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/96845b3e2395e0e5ba9844c8075a092e61286ed2","head":{"label":"mkanoor:extract_expresssion_subst","ref":"extract_expresssion_subst","sha":"96845b3e2395e0e5ba9844c8075a092e61286ed2","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"repo":{"id":20886443,"name":"manageiq","full_name":"mkanoor/manageiq","owner":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkanoor/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/mkanoor/manageiq","forks_url":"https://api.github.com/repos/mkanoor/manageiq/forks","keys_url":"https://api.github.com/repos/mkanoor/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkanoor/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkanoor/manageiq/teams","hooks_url":"https://api.github.com/repos/mkanoor/manageiq/hooks","issue_events_url":"https://api.github.com/repos/mkanoor/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/mkanoor/manageiq/events","assignees_url":"https://api.github.com/repos/mkanoor/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/mkanoor/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/mkanoor/manageiq/tags","blobs_url":"https://api.github.com/repos/mkanoor/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkanoor/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkanoor/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkanoor/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkanoor/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/mkanoor/manageiq/languages","stargazers_url":"https://api.github.com/repos/mkanoor/manageiq/stargazers","contributors_url":"https://api.github.com/repos/mkanoor/manageiq/contributors","subscribers_url":"https://api.github.com/repos/mkanoor/manageiq/subscribers","subscription_url":"https://api.github.com/repos/mkanoor/manageiq/subscription","commits_url":"https://api.github.com/repos/mkanoor/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkanoor/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkanoor/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkanoor/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkanoor/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/mkanoor/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkanoor/manageiq/merges","archive_url":"https://api.github.com/repos/mkanoor/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkanoor/manageiq/downloads","issues_url":"https://api.github.com/repos/mkanoor/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/mkanoor/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/mkanoor/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/mkanoor/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkanoor/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/mkanoor/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/mkanoor/manageiq/deployments","created_at":"2014-06-16T13:48:03Z","updated_at":"2016-01-11T16:28:23Z","pushed_at":"2016-02-15T18:42:42Z","git_url":"git://github.com/mkanoor/manageiq.git","ssh_url":"git@github.com:mkanoor/manageiq.git","clone_url":"https://github.com/mkanoor/manageiq.git","svn_url":"https://github.com/mkanoor/manageiq","homepage":null,"size":105028,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"b6217acedb7f7bb65b63e8426e778af3ca59743d","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-02-15T15:43:52Z","pushed_at":"2016-02-15T20:12:56Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":141357,"stargazers_count":216,"watchers_count":216,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":521,"forks":230,"open_issues":521,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6654"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6654"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6654/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6654/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/96845b3e2395e0e5ba9844c8075a092e61286ed2"}}}}