{"action":"created","comment":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/61305610","id":61305610,"diff_hunk":"@@ -546,6 +548,24 @@ static int populate_mr_tables(void)\n     return 0;\n }\n \n+static inline int atomicvalid_rtncheck(int ret, int atomic_size, long atomicwarn,\n+                                    char strOP[], char strDT[]) {\n+\n+    if(ret != 0 || atomic_size == 0) {\n+        fprintf(stderr, \"%s OFI detected no support for atomic '%s'\"\n+               \"on type '%s'\\n\", (atomicwarn ? \"Warning\" : \"Error\"),\n+                strOP, strDT);","path":"src/transport_ofi.c","position":63,"original_position":67,"commit_id":"55f6d8dc8dc294955ee5009f494b24bc0cc37f78","original_commit_id":"55f6d8dc8dc294955ee5009f494b24bc0cc37f78","user":{"login":"kseager","id":1675997,"avatar_url":"https://avatars.githubusercontent.com/u/1675997?v=3","gravatar_id":"","url":"https://api.github.com/users/kseager","html_url":"https://github.com/kseager","followers_url":"https://api.github.com/users/kseager/followers","following_url":"https://api.github.com/users/kseager/following{/other_user}","gists_url":"https://api.github.com/users/kseager/gists{/gist_id}","starred_url":"https://api.github.com/users/kseager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseager/subscriptions","organizations_url":"https://api.github.com/users/kseager/orgs","repos_url":"https://api.github.com/users/kseager/repos","events_url":"https://api.github.com/users/kseager/events{/privacy}","received_events_url":"https://api.github.com/users/kseager/received_events","type":"User","site_admin":false},"body":"this function just passes forward the predetermined ret value, if it comes in success it will return success ","created_at":"2016-04-27T17:55:41Z","updated_at":"2016-04-27T17:55:41Z","html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169#discussion_r61305610","pull_request_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/61305610"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169#discussion_r61305610"},"pull_request":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169","id":67576526,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169","diff_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169.diff","patch_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169.patch","issue_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/169","number":169,"state":"open","locked":false,"title":"OFI: added SMA_OFI_ATOMIC_CHECKS_WARN","user":{"login":"kseager","id":1675997,"avatar_url":"https://avatars.githubusercontent.com/u/1675997?v=3","gravatar_id":"","url":"https://api.github.com/users/kseager","html_url":"https://github.com/kseager","followers_url":"https://api.github.com/users/kseager/followers","following_url":"https://api.github.com/users/kseager/following{/other_user}","gists_url":"https://api.github.com/users/kseager/gists{/gist_id}","starred_url":"https://api.github.com/users/kseager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseager/subscriptions","organizations_url":"https://api.github.com/users/kseager/orgs","repos_url":"https://api.github.com/users/kseager/repos","events_url":"https://api.github.com/users/kseager/events{/privacy}","received_events_url":"https://api.github.com/users/kseager/received_events","type":"User","site_admin":false},"body":"+environment variable option for enabling atomic limitation warnings vs. errors\r\n+small clean-up of atomic valid output message\r\n+initial atomic size check uses FI_SUM instead of FI_MAX since sum is more portable\r\n\r\nSigned-off-by: kseager <kayla.seager@intel.com>","created_at":"2016-04-22T21:36:39Z","updated_at":"2016-04-27T17:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64c58f675a5ac69096ef628ae1eab7d3458a1812","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169/commits","review_comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169/comments","review_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/169/comments","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/55f6d8dc8dc294955ee5009f494b24bc0cc37f78","head":{"label":"kseager:atomic_warn","ref":"atomic_warn","sha":"55f6d8dc8dc294955ee5009f494b24bc0cc37f78","user":{"login":"kseager","id":1675997,"avatar_url":"https://avatars.githubusercontent.com/u/1675997?v=3","gravatar_id":"","url":"https://api.github.com/users/kseager","html_url":"https://github.com/kseager","followers_url":"https://api.github.com/users/kseager/followers","following_url":"https://api.github.com/users/kseager/following{/other_user}","gists_url":"https://api.github.com/users/kseager/gists{/gist_id}","starred_url":"https://api.github.com/users/kseager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseager/subscriptions","organizations_url":"https://api.github.com/users/kseager/orgs","repos_url":"https://api.github.com/users/kseager/repos","events_url":"https://api.github.com/users/kseager/events{/privacy}","received_events_url":"https://api.github.com/users/kseager/received_events","type":"User","site_admin":false},"repo":{"id":42545546,"name":"sandia-shmem","full_name":"kseager/sandia-shmem","owner":{"login":"kseager","id":1675997,"avatar_url":"https://avatars.githubusercontent.com/u/1675997?v=3","gravatar_id":"","url":"https://api.github.com/users/kseager","html_url":"https://github.com/kseager","followers_url":"https://api.github.com/users/kseager/followers","following_url":"https://api.github.com/users/kseager/following{/other_user}","gists_url":"https://api.github.com/users/kseager/gists{/gist_id}","starred_url":"https://api.github.com/users/kseager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseager/subscriptions","organizations_url":"https://api.github.com/users/kseager/orgs","repos_url":"https://api.github.com/users/kseager/repos","events_url":"https://api.github.com/users/kseager/events{/privacy}","received_events_url":"https://api.github.com/users/kseager/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kseager/sandia-shmem","description":"Sandia SHMEM is an implementation of the OpenSHMEM Standard over multiple Networking APIs, including Portals4. Sandia SHMEM is designed to be a low-overhead implementation of the SHMEM standard which takes advantage of the many features of the advanced networking APIs, including the Portals 4 specification. ","fork":true,"url":"https://api.github.com/repos/kseager/sandia-shmem","forks_url":"https://api.github.com/repos/kseager/sandia-shmem/forks","keys_url":"https://api.github.com/repos/kseager/sandia-shmem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kseager/sandia-shmem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kseager/sandia-shmem/teams","hooks_url":"https://api.github.com/repos/kseager/sandia-shmem/hooks","issue_events_url":"https://api.github.com/repos/kseager/sandia-shmem/issues/events{/number}","events_url":"https://api.github.com/repos/kseager/sandia-shmem/events","assignees_url":"https://api.github.com/repos/kseager/sandia-shmem/assignees{/user}","branches_url":"https://api.github.com/repos/kseager/sandia-shmem/branches{/branch}","tags_url":"https://api.github.com/repos/kseager/sandia-shmem/tags","blobs_url":"https://api.github.com/repos/kseager/sandia-shmem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kseager/sandia-shmem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kseager/sandia-shmem/git/refs{/sha}","trees_url":"https://api.github.com/repos/kseager/sandia-shmem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kseager/sandia-shmem/statuses/{sha}","languages_url":"https://api.github.com/repos/kseager/sandia-shmem/languages","stargazers_url":"https://api.github.com/repos/kseager/sandia-shmem/stargazers","contributors_url":"https://api.github.com/repos/kseager/sandia-shmem/contributors","subscribers_url":"https://api.github.com/repos/kseager/sandia-shmem/subscribers","subscription_url":"https://api.github.com/repos/kseager/sandia-shmem/subscription","commits_url":"https://api.github.com/repos/kseager/sandia-shmem/commits{/sha}","git_commits_url":"https://api.github.com/repos/kseager/sandia-shmem/git/commits{/sha}","comments_url":"https://api.github.com/repos/kseager/sandia-shmem/comments{/number}","issue_comment_url":"https://api.github.com/repos/kseager/sandia-shmem/issues/comments{/number}","contents_url":"https://api.github.com/repos/kseager/sandia-shmem/contents/{+path}","compare_url":"https://api.github.com/repos/kseager/sandia-shmem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kseager/sandia-shmem/merges","archive_url":"https://api.github.com/repos/kseager/sandia-shmem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kseager/sandia-shmem/downloads","issues_url":"https://api.github.com/repos/kseager/sandia-shmem/issues{/number}","pulls_url":"https://api.github.com/repos/kseager/sandia-shmem/pulls{/number}","milestones_url":"https://api.github.com/repos/kseager/sandia-shmem/milestones{/number}","notifications_url":"https://api.github.com/repos/kseager/sandia-shmem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kseager/sandia-shmem/labels{/name}","releases_url":"https://api.github.com/repos/kseager/sandia-shmem/releases{/id}","deployments_url":"https://api.github.com/repos/kseager/sandia-shmem/deployments","created_at":"2015-09-15T20:45:46Z","updated_at":"2016-01-11T22:49:00Z","pushed_at":"2016-04-27T00:18:45Z","git_url":"git://github.com/kseager/sandia-shmem.git","ssh_url":"git@github.com:kseager/sandia-shmem.git","clone_url":"https://github.com/kseager/sandia-shmem.git","svn_url":"https://github.com/kseager/sandia-shmem","homepage":"http://www.cs.sandia.gov/Portals/portals4.html","size":1392,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sandia-OpenSHMEM:master","ref":"master","sha":"ff0cb55943e819da0043ab7f26bd82f2105fe5c3","user":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars.githubusercontent.com/u/16339082?v=3","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"repo":{"id":42528680,"name":"SOS","full_name":"Sandia-OpenSHMEM/SOS","owner":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars.githubusercontent.com/u/16339082?v=3","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS","description":"Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4 and the Open Fabric Interface (OFI).  Please click on the Wiki tab for help with building and using SOS.","fork":false,"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS","forks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/forks","keys_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/teams","hooks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/hooks","issue_events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/events{/number}","events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/events","assignees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/assignees{/user}","branches_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/branches{/branch}","tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/tags","blobs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/languages","stargazers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/stargazers","contributors_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contributors","subscribers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscribers","subscription_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscription","commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contents/{+path}","compare_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/merges","archive_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/downloads","issues_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues{/number}","pulls_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/labels{/name}","releases_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/releases{/id}","deployments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/deployments","created_at":"2015-09-15T15:34:37Z","updated_at":"2016-04-18T21:42:14Z","pushed_at":"2016-04-27T17:44:46Z","git_url":"git://github.com/Sandia-OpenSHMEM/SOS.git","ssh_url":"git@github.com:Sandia-OpenSHMEM/SOS.git","clone_url":"https://github.com/Sandia-OpenSHMEM/SOS.git","svn_url":"https://github.com/Sandia-OpenSHMEM/SOS","homepage":"","size":1497,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":39,"forks":11,"open_issues":39,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/169"},"issue":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/169"},"comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/55f6d8dc8dc294955ee5009f494b24bc0cc37f78"}}}}