{"action":"created","issue":{"url":"https://api.github.com/repos/quattor/ncm-ncd/issues/69","repository_url":"https://api.github.com/repos/quattor/ncm-ncd","labels_url":"https://api.github.com/repos/quattor/ncm-ncd/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/quattor/ncm-ncd/issues/69/comments","events_url":"https://api.github.com/repos/quattor/ncm-ncd/issues/69/events","html_url":"https://github.com/quattor/ncm-ncd/issues/69","id":164904208,"number":69,"title":"ncm-ncd 16.6.0-rc3: cannot acquire ncm-ncd lock during upgrade","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"assignees":[{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/quattor/ncm-ncd/milestones/12","html_url":"https://github.com/quattor/ncm-ncd/milestones/16.6","labels_url":"https://api.github.com/repos/quattor/ncm-ncd/milestones/12/labels","id":1147844,"number":12,"title":"16.6","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2015-06-03T16:16:54Z","updated_at":"2016-07-11T18:35:20Z","due_on":"2016-06-30T07:00:00Z","closed_at":null},"comments":8,"created_at":"2016-07-11T18:34:39Z","updated_at":"2016-07-18T14:05:01Z","closed_at":null,"body":"During Quattor client upgrade through `ncm-cdispd`, `ncd-ncd` is run 3 times: this is due to `ncm-cdispd` service restart during upgrade of `ncm-cdispd` and `cdp-listend`. Second and third `ncm-ncd` instances are blocked by `ncm-ncd` lock, until the previous instance has completed.\r\n\r\nIt seems that the new `CAF::Lock` in 16.6.0-rc3 causes the third instance to exit before running with the message:\r\n```\r\n2016/07/11-20:16:41 [ERROR] cannot acquire lock after 10 tries: /var/lock/quattor/ncm-ncd\r\n```\r\n\r\nI don't think this was the case before (it was just waiting until the process whose pid was in the lock file had exited). It should not be a problem (in fact only one restart of `ncm-cdispd` is normally enough) but if for some reasons `ncm-ncd` takes longer to complete, there is may the risk that it will not be restarted (while the running one will be terminated at the end of `ncm-ncd` run), leaving the system unmanaged.\r\n\r\nIs it possible to confirm that this is not a problem or to ensure a longer (infinite?) wait?\r\n\r\nProbably a side effect of #64. May be good to fix it or revert #64 before releasing 16.6.0-rc3, even if not strictly speaking a showstopper...\r\n\r\nWould be good to look at this issue before releasing [16.6.0-rc3](https://github.com/quattor/release/issues/250), even if not strictly speaking a showstopper..."},"comment":{"url":"https://api.github.com/repos/quattor/ncm-ncd/issues/comments/233337956","html_url":"https://github.com/quattor/ncm-ncd/issues/69#issuecomment-233337956","issue_url":"https://api.github.com/repos/quattor/ncm-ncd/issues/69","id":233337956,"user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T14:05:01Z","updated_at":"2016-07-18T14:05:01Z","body":"Any plan to do something for this potential problem or do we say that we live with it for the time being and postpone to a later release?"}}
{"actor":{"display_login":"jouvin"}}