{"action":"opened","issue":{"url":"https://api.github.com/repos/UoB-HPC/GPU-STREAM/issues/18","repository_url":"https://api.github.com/repos/UoB-HPC/GPU-STREAM","labels_url":"https://api.github.com/repos/UoB-HPC/GPU-STREAM/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/UoB-HPC/GPU-STREAM/issues/18/comments","events_url":"https://api.github.com/repos/UoB-HPC/GPU-STREAM/issues/18/events","html_url":"https://github.com/UoB-HPC/GPU-STREAM/issues/18","id":191833199,"number":18,"title":"enable OpenMP 4.5 for compilers besides Cray","user":{"login":"jeffhammond","id":406118,"avatar_url":"https://avatars.githubusercontent.com/u/406118?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffhammond","html_url":"https://github.com/jeffhammond","followers_url":"https://api.github.com/users/jeffhammond/followers","following_url":"https://api.github.com/users/jeffhammond/following{/other_user}","gists_url":"https://api.github.com/users/jeffhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffhammond/subscriptions","organizations_url":"https://api.github.com/users/jeffhammond/orgs","repos_url":"https://api.github.com/users/jeffhammond/repos","events_url":"https://api.github.com/users/jeffhammond/events{/privacy}","received_events_url":"https://api.github.com/users/jeffhammond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-26T23:50:14Z","updated_at":"2016-11-26T23:50:14Z","closed_at":null,"body":"I'm not a CMake guru but this project should test for OpenMP 4.5 compiler support generically rather than just associate this implementation with the Cray toolchain.\r\n\r\nhttp://www.openmp.org/resources/openmp-compilers/ has the full list, but at least GCC 6.1+ and Intel 17+ support OpenMP 4.5 and I just confirmed that GCC 6.2.0 can correctly run `gpu-stream-omp45`.\r\n\r\n```\r\n$ git diff\r\ndiff --git a/CMakeLists.txt b/CMakeLists.txt\r\nindex efee733..574fcc3 100644\r\n--- a/CMakeLists.txt\r\n+++ b/CMakeLists.txt\r\n@@ -118,12 +118,12 @@ endif ()\r\n #-------------------------------------------------------------------------------\r\n # OpenMP 4.5\r\n #-------------------------------------------------------------------------------\r\n-if (\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \"Cray\")\r\n-  if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.5)\r\n+#if (\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \"Cray\")\r\n+#  if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.5)\r\n     add_executable(gpu-stream-omp45 main.cpp OMP45Stream.cpp)\r\n     target_compile_definitions(gpu-stream-omp45 PUBLIC OMP45)\r\n-  endif ()\r\n-endif ()\r\n+#  endif ()\r\n+#endif ()\r\n```"}}
{"actor":{"display_login":"jeffhammond"}}