{"action":"created","comment":{"url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/comments/49719562","id":49719562,"diff_hunk":"@@ -1,77 +1,78 @@\n <?xml version=\"1.0\"?>\n-<project xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\" xmlns=\"http://maven.apache.org/POM/4.0.0\"\n-    xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">\n-  <modelVersion>4.0.0</modelVersion>\n-  <parent>\n-    <groupId>eu.seaclouds-project.monitor</groupId>\n-    <artifactId>monitor</artifactId>\n-    <version>0.8.0-SNAPSHOT</version>\n-  </parent>\n-  <artifactId>monitoring-dam-generator-service</artifactId>\n-  <name>monitoring-dam-generator-service</name>\n-  <url>http://maven.apache.org</url>\n-  <properties>\n-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\n-    <main.class>eu.seaclouds.monitor.monitoringdamgeneratorservice.ServiceLauncher</main.class>\n-  </properties>\n-  <dependencies>\n+<project\n+\txsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\"\n+\txmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">\n+\t<modelVersion>4.0.0</modelVersion>\n+\t<parent>\n+\t\t<groupId>eu.seaclouds-project.monitor</groupId>\n+\t\t<artifactId>monitor</artifactId>\n+\t\t<version>0.8.0-SNAPSHOT</version>\n+\t</parent>\n+\t<artifactId>monitoring-dam-generator-service</artifactId>\n+\t<name>monitoring-dam-generator-service</name>\n+\t<url>http://maven.apache.org</url>\n+\t<properties>\n+\t\t<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\n+\t\t<main.class>eu.seaclouds.monitor.monitoringdamgeneratorservice.ServiceLauncher</main.class>","path":"monitor/monitoring-dam-generator-service/pom.xml","position":32,"original_position":32,"commit_id":"e54b046d6e8d36b4f8a8f551de97698ee66f5690","original_commit_id":"e54b046d6e8d36b4f8a8f551de97698ee66f5690","user":{"login":"MicheleGuerriero","id":6441967,"avatar_url":"https://avatars.githubusercontent.com/u/6441967?v=3","gravatar_id":"","url":"https://api.github.com/users/MicheleGuerriero","html_url":"https://github.com/MicheleGuerriero","followers_url":"https://api.github.com/users/MicheleGuerriero/followers","following_url":"https://api.github.com/users/MicheleGuerriero/following{/other_user}","gists_url":"https://api.github.com/users/MicheleGuerriero/gists{/gist_id}","starred_url":"https://api.github.com/users/MicheleGuerriero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicheleGuerriero/subscriptions","organizations_url":"https://api.github.com/users/MicheleGuerriero/orgs","repos_url":"https://api.github.com/users/MicheleGuerriero/repos","events_url":"https://api.github.com/users/MicheleGuerriero/events{/privacy}","received_events_url":"https://api.github.com/users/MicheleGuerriero/received_events","type":"User","site_admin":false},"body":"Do you mean the main.class tag? It is simply recalled in the maven-shade plugin to point to the right main. The class eu.seaclouds.monitor.monitoringdamgeneratorservice.ServiceLauncher is the application starter.","created_at":"2016-01-14T12:23:57Z","updated_at":"2016-01-14T12:23:57Z","html_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206#discussion_r49719562","pull_request_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/comments/49719562"},"html":{"href":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206#discussion_r49719562"},"pull_request":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206","id":55632126,"html_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206","diff_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206.diff","patch_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206.patch","issue_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/206","number":206,"state":"open","locked":false,"title":"monitoring-dam-generator minor fixes plus InfluxDB integration at design time for metric visualization.","user":{"login":"MicheleGuerriero","id":6441967,"avatar_url":"https://avatars.githubusercontent.com/u/6441967?v=3","gravatar_id":"","url":"https://api.github.com/users/MicheleGuerriero","html_url":"https://github.com/MicheleGuerriero","followers_url":"https://api.github.com/users/MicheleGuerriero/followers","following_url":"https://api.github.com/users/MicheleGuerriero/following{/other_user}","gists_url":"https://api.github.com/users/MicheleGuerriero/gists{/gist_id}","starred_url":"https://api.github.com/users/MicheleGuerriero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicheleGuerriero/subscriptions","organizations_url":"https://api.github.com/users/MicheleGuerriero/orgs","repos_url":"https://api.github.com/users/MicheleGuerriero/repos","events_url":"https://api.github.com/users/MicheleGuerriero/events{/privacy}","received_events_url":"https://api.github.com/users/MicheleGuerriero/received_events","type":"User","site_admin":false},"body":"This PR apply some fixes to the monitoring-dam-generator-core and also wants to add design time support for InfluxDB, in oder to have it properly configured for the metric visualization at runtime.\r\n\r\nIn particular the PR carries the following additions:\r\n\r\n1) env->shell.env in the data collectors node template, according to the provided [specification](https://docs.google.com/document/d/1Z9RdaWn54IomgI-jCiw-tdutsCdDoHfk67PNUASOFmY/edit?disco=AAAAAjfm8b4)\r\n\r\n2) env vars from List<Map> to Map in the data collectors node template according to the provided [specification](https://docs.google.com/document/d/1Z9RdaWn54IomgI-jCiw-tdutsCdDoHfk67PNUASOFmY/edit?disco=AAAAAjfm8b4)\r\n\r\n3) now the DataCollector node type is also inserted by the monitoring-dam-generator in the output ADP.\r\n\r\n4) added data collectors \"start.sh\" scripts in the resources folder.\r\n\r\n5) monitoring-dam-generator-core modified to support the integration with InfluxDB. In particular the data collector node template is configured with information about InfluxDB IP and port.\r\n\r\n6) planner-core and planner service modified to manage infomation about InfluxDB endpoint and pass them to the monitoring-dam-generator-core. In particular InfluxDB IP and port are taken from the config.yaml file of planner-service.\r\n\r\n7) monitoring-dam-generator-service modified to configure its core with InfluxDB endpoint information.\r\n(this point is just for maintenance since this component is not used anymore). \r\n\r\n@szenzaro and @kiuby88 can you please review this PR? In particular I think point 1), 2), 3) and 4) could be addressed by @kiuby88 while 6) and 7) by @szenzaro since they focus on the Planner. Thanks in advance.\r\n","created_at":"2016-01-11T15:01:46Z","updated_at":"2016-01-14T12:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b527b63323aaa5896cea73c6bc185832cbb6dd6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206/commits","review_comments_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206/comments","review_comment_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/206/comments","statuses_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/statuses/e54b046d6e8d36b4f8a8f551de97698ee66f5690","head":{"label":"MicheleGuerriero:fix/monitor-gen-fixes-plus-influxdb","ref":"fix/monitor-gen-fixes-plus-influxdb","sha":"e54b046d6e8d36b4f8a8f551de97698ee66f5690","user":{"login":"MicheleGuerriero","id":6441967,"avatar_url":"https://avatars.githubusercontent.com/u/6441967?v=3","gravatar_id":"","url":"https://api.github.com/users/MicheleGuerriero","html_url":"https://github.com/MicheleGuerriero","followers_url":"https://api.github.com/users/MicheleGuerriero/followers","following_url":"https://api.github.com/users/MicheleGuerriero/following{/other_user}","gists_url":"https://api.github.com/users/MicheleGuerriero/gists{/gist_id}","starred_url":"https://api.github.com/users/MicheleGuerriero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicheleGuerriero/subscriptions","organizations_url":"https://api.github.com/users/MicheleGuerriero/orgs","repos_url":"https://api.github.com/users/MicheleGuerriero/repos","events_url":"https://api.github.com/users/MicheleGuerriero/events{/privacy}","received_events_url":"https://api.github.com/users/MicheleGuerriero/received_events","type":"User","site_admin":false},"repo":{"id":47929545,"name":"SeaCloudsPlatform","full_name":"MicheleGuerriero/SeaCloudsPlatform","owner":{"login":"MicheleGuerriero","id":6441967,"avatar_url":"https://avatars.githubusercontent.com/u/6441967?v=3","gravatar_id":"","url":"https://api.github.com/users/MicheleGuerriero","html_url":"https://github.com/MicheleGuerriero","followers_url":"https://api.github.com/users/MicheleGuerriero/followers","following_url":"https://api.github.com/users/MicheleGuerriero/following{/other_user}","gists_url":"https://api.github.com/users/MicheleGuerriero/gists{/gist_id}","starred_url":"https://api.github.com/users/MicheleGuerriero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicheleGuerriero/subscriptions","organizations_url":"https://api.github.com/users/MicheleGuerriero/orgs","repos_url":"https://api.github.com/users/MicheleGuerriero/repos","events_url":"https://api.github.com/users/MicheleGuerriero/events{/privacy}","received_events_url":"https://api.github.com/users/MicheleGuerriero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MicheleGuerriero/SeaCloudsPlatform","description":"Seamless adaptive multi-cloud management of service-based applications","fork":true,"url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform","forks_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/forks","keys_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/teams","hooks_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/hooks","issue_events_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/issues/events{/number}","events_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/events","assignees_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/assignees{/user}","branches_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/branches{/branch}","tags_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/tags","blobs_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/statuses/{sha}","languages_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/languages","stargazers_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/stargazers","contributors_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/contributors","subscribers_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/subscribers","subscription_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/subscription","commits_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/contents/{+path}","compare_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/merges","archive_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/downloads","issues_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/issues{/number}","pulls_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/pulls{/number}","milestones_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/milestones{/number}","notifications_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/labels{/name}","releases_url":"https://api.github.com/repos/MicheleGuerriero/SeaCloudsPlatform/releases{/id}","created_at":"2015-12-13T17:43:15Z","updated_at":"2015-12-13T17:43:17Z","pushed_at":"2016-01-11T14:54:26Z","git_url":"git://github.com/MicheleGuerriero/SeaCloudsPlatform.git","ssh_url":"git@github.com:MicheleGuerriero/SeaCloudsPlatform.git","clone_url":"https://github.com/MicheleGuerriero/SeaCloudsPlatform.git","svn_url":"https://github.com/MicheleGuerriero/SeaCloudsPlatform","homepage":"http://www.seaclouds-project.eu/","size":61148,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeaCloudsEU:master","ref":"master","sha":"cd49a2b738586121e8706f101f817945a743a746","user":{"login":"SeaCloudsEU","id":6222853,"avatar_url":"https://avatars.githubusercontent.com/u/6222853?v=3","gravatar_id":"","url":"https://api.github.com/users/SeaCloudsEU","html_url":"https://github.com/SeaCloudsEU","followers_url":"https://api.github.com/users/SeaCloudsEU/followers","following_url":"https://api.github.com/users/SeaCloudsEU/following{/other_user}","gists_url":"https://api.github.com/users/SeaCloudsEU/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaCloudsEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaCloudsEU/subscriptions","organizations_url":"https://api.github.com/users/SeaCloudsEU/orgs","repos_url":"https://api.github.com/users/SeaCloudsEU/repos","events_url":"https://api.github.com/users/SeaCloudsEU/events{/privacy}","received_events_url":"https://api.github.com/users/SeaCloudsEU/received_events","type":"Organization","site_admin":false},"repo":{"id":15312233,"name":"SeaCloudsPlatform","full_name":"SeaCloudsEU/SeaCloudsPlatform","owner":{"login":"SeaCloudsEU","id":6222853,"avatar_url":"https://avatars.githubusercontent.com/u/6222853?v=3","gravatar_id":"","url":"https://api.github.com/users/SeaCloudsEU","html_url":"https://github.com/SeaCloudsEU","followers_url":"https://api.github.com/users/SeaCloudsEU/followers","following_url":"https://api.github.com/users/SeaCloudsEU/following{/other_user}","gists_url":"https://api.github.com/users/SeaCloudsEU/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaCloudsEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaCloudsEU/subscriptions","organizations_url":"https://api.github.com/users/SeaCloudsEU/orgs","repos_url":"https://api.github.com/users/SeaCloudsEU/repos","events_url":"https://api.github.com/users/SeaCloudsEU/events{/privacy}","received_events_url":"https://api.github.com/users/SeaCloudsEU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform","description":"Seamless adaptive multi-cloud management of service-based applications","fork":false,"url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform","forks_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/forks","keys_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/teams","hooks_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/hooks","issue_events_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/events{/number}","events_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/events","assignees_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/assignees{/user}","branches_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/branches{/branch}","tags_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/tags","blobs_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/statuses/{sha}","languages_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/languages","stargazers_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/stargazers","contributors_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/contributors","subscribers_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/subscribers","subscription_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/subscription","commits_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/contents/{+path}","compare_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/merges","archive_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/downloads","issues_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues{/number}","pulls_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls{/number}","milestones_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/milestones{/number}","notifications_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/labels{/name}","releases_url":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/releases{/id}","created_at":"2013-12-19T13:23:54Z","updated_at":"2016-01-12T11:31:27Z","pushed_at":"2016-01-12T16:47:46Z","git_url":"git://github.com/SeaCloudsEU/SeaCloudsPlatform.git","ssh_url":"git@github.com:SeaCloudsEU/SeaCloudsPlatform.git","clone_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform.git","svn_url":"https://github.com/SeaCloudsEU/SeaCloudsPlatform","homepage":"http://www.seaclouds-project.eu/","size":128870,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":21,"forks":16,"open_issues":21,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206"},"html":{"href":"https://github.com/SeaCloudsEU/SeaCloudsPlatform/pull/206"},"issue":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/206"},"comments":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/SeaCloudsEU/SeaCloudsPlatform/statuses/e54b046d6e8d36b4f8a8f551de97698ee66f5690"}}}}