{"action":"created","comment":{"url":"https://api.github.com/repos/typesupply/compositor/pulls/comments/50097949","id":50097949,"diff_hunk":"@@ -6,6 +6,17 @@\n from compositor.error import CompositorError\n \n \n+def _nameToString(nameRecord):\n+    encoding = nameRecord.getEncoding()\n+    try:\n+        # python 3\n+        ret = nameRecord.string.decode(encoding)","path":"Lib/compositor/font.py","position":8,"original_position":8,"commit_id":"60bcc55ab3615c07c5f97132b1b580f54fb5ef0b","original_commit_id":"60bcc55ab3615c07c5f97132b1b580f54fb5ef0b","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"yes, that should do the trick as well.","created_at":"2016-01-19T10:50:14Z","updated_at":"2016-01-19T10:50:14Z","html_url":"https://github.com/typesupply/compositor/pull/10#discussion_r50097949","pull_request_url":"https://api.github.com/repos/typesupply/compositor/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/comments/50097949"},"html":{"href":"https://github.com/typesupply/compositor/pull/10#discussion_r50097949"},"pull_request":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/typesupply/compositor/pulls/10","id":56448121,"html_url":"https://github.com/typesupply/compositor/pull/10","diff_url":"https://github.com/typesupply/compositor/pull/10.diff","patch_url":"https://github.com/typesupply/compositor/pull/10.patch","issue_url":"https://api.github.com/repos/typesupply/compositor/issues/10","number":10,"state":"open","locked":false,"title":"more py23 fixes","user":{"login":"adrientetar","id":1250894,"avatar_url":"https://avatars.githubusercontent.com/u/1250894?v=3","gravatar_id":"","url":"https://api.github.com/users/adrientetar","html_url":"https://github.com/adrientetar","followers_url":"https://api.github.com/users/adrientetar/followers","following_url":"https://api.github.com/users/adrientetar/following{/other_user}","gists_url":"https://api.github.com/users/adrientetar/gists{/gist_id}","starred_url":"https://api.github.com/users/adrientetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrientetar/subscriptions","organizations_url":"https://api.github.com/users/adrientetar/orgs","repos_url":"https://api.github.com/users/adrientetar/repos","events_url":"https://api.github.com/users/adrientetar/events{/privacy}","received_events_url":"https://api.github.com/users/adrientetar/received_events","type":"User","site_admin":false},"body":"@typesupply I haven't tested `_nameToString` on Python 2, maybe best to test it before merging. Anyhow, it should should be more robust than the current decoding code.","created_at":"2016-01-19T10:40:19Z","updated_at":"2016-01-19T10:50:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2835566b9851b820ddb69e87535b99bbb121224","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesupply/compositor/pulls/10/commits","review_comments_url":"https://api.github.com/repos/typesupply/compositor/pulls/10/comments","review_comment_url":"https://api.github.com/repos/typesupply/compositor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesupply/compositor/issues/10/comments","statuses_url":"https://api.github.com/repos/typesupply/compositor/statuses/60bcc55ab3615c07c5f97132b1b580f54fb5ef0b","head":{"label":"trufont:py23","ref":"py23","sha":"60bcc55ab3615c07c5f97132b1b580f54fb5ef0b","user":{"login":"trufont","id":15032310,"avatar_url":"https://avatars.githubusercontent.com/u/15032310?v=3","gravatar_id":"","url":"https://api.github.com/users/trufont","html_url":"https://github.com/trufont","followers_url":"https://api.github.com/users/trufont/followers","following_url":"https://api.github.com/users/trufont/following{/other_user}","gists_url":"https://api.github.com/users/trufont/gists{/gist_id}","starred_url":"https://api.github.com/users/trufont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufont/subscriptions","organizations_url":"https://api.github.com/users/trufont/orgs","repos_url":"https://api.github.com/users/trufont/repos","events_url":"https://api.github.com/users/trufont/events{/privacy}","received_events_url":"https://api.github.com/users/trufont/received_events","type":"Organization","site_admin":false},"repo":{"id":49944583,"name":"compositor","full_name":"trufont/compositor","owner":{"login":"trufont","id":15032310,"avatar_url":"https://avatars.githubusercontent.com/u/15032310?v=3","gravatar_id":"","url":"https://api.github.com/users/trufont","html_url":"https://github.com/trufont","followers_url":"https://api.github.com/users/trufont/followers","following_url":"https://api.github.com/users/trufont/following{/other_user}","gists_url":"https://api.github.com/users/trufont/gists{/gist_id}","starred_url":"https://api.github.com/users/trufont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufont/subscriptions","organizations_url":"https://api.github.com/users/trufont/orgs","repos_url":"https://api.github.com/users/trufont/repos","events_url":"https://api.github.com/users/trufont/events{/privacy}","received_events_url":"https://api.github.com/users/trufont/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufont/compositor","description":"A basic OpenType GSUB and GPOS layout engine.","fork":true,"url":"https://api.github.com/repos/trufont/compositor","forks_url":"https://api.github.com/repos/trufont/compositor/forks","keys_url":"https://api.github.com/repos/trufont/compositor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufont/compositor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufont/compositor/teams","hooks_url":"https://api.github.com/repos/trufont/compositor/hooks","issue_events_url":"https://api.github.com/repos/trufont/compositor/issues/events{/number}","events_url":"https://api.github.com/repos/trufont/compositor/events","assignees_url":"https://api.github.com/repos/trufont/compositor/assignees{/user}","branches_url":"https://api.github.com/repos/trufont/compositor/branches{/branch}","tags_url":"https://api.github.com/repos/trufont/compositor/tags","blobs_url":"https://api.github.com/repos/trufont/compositor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufont/compositor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufont/compositor/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufont/compositor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufont/compositor/statuses/{sha}","languages_url":"https://api.github.com/repos/trufont/compositor/languages","stargazers_url":"https://api.github.com/repos/trufont/compositor/stargazers","contributors_url":"https://api.github.com/repos/trufont/compositor/contributors","subscribers_url":"https://api.github.com/repos/trufont/compositor/subscribers","subscription_url":"https://api.github.com/repos/trufont/compositor/subscription","commits_url":"https://api.github.com/repos/trufont/compositor/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufont/compositor/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufont/compositor/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufont/compositor/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufont/compositor/contents/{+path}","compare_url":"https://api.github.com/repos/trufont/compositor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufont/compositor/merges","archive_url":"https://api.github.com/repos/trufont/compositor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufont/compositor/downloads","issues_url":"https://api.github.com/repos/trufont/compositor/issues{/number}","pulls_url":"https://api.github.com/repos/trufont/compositor/pulls{/number}","milestones_url":"https://api.github.com/repos/trufont/compositor/milestones{/number}","notifications_url":"https://api.github.com/repos/trufont/compositor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufont/compositor/labels{/name}","releases_url":"https://api.github.com/repos/trufont/compositor/releases{/id}","created_at":"2016-01-19T10:18:38Z","updated_at":"2016-01-19T10:18:39Z","pushed_at":"2016-01-19T10:33:06Z","git_url":"git://github.com/trufont/compositor.git","ssh_url":"git@github.com:trufont/compositor.git","clone_url":"https://github.com/trufont/compositor.git","svn_url":"https://github.com/trufont/compositor","homepage":null,"size":327,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesupply:master","ref":"master","sha":"9b567af3a7c1abbd0eb472676c8c6e3588ad758b","user":{"login":"typesupply","id":4992934,"avatar_url":"https://avatars.githubusercontent.com/u/4992934?v=3","gravatar_id":"","url":"https://api.github.com/users/typesupply","html_url":"https://github.com/typesupply","followers_url":"https://api.github.com/users/typesupply/followers","following_url":"https://api.github.com/users/typesupply/following{/other_user}","gists_url":"https://api.github.com/users/typesupply/gists{/gist_id}","starred_url":"https://api.github.com/users/typesupply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesupply/subscriptions","organizations_url":"https://api.github.com/users/typesupply/orgs","repos_url":"https://api.github.com/users/typesupply/repos","events_url":"https://api.github.com/users/typesupply/events{/privacy}","received_events_url":"https://api.github.com/users/typesupply/received_events","type":"User","site_admin":false},"repo":{"id":11504592,"name":"compositor","full_name":"typesupply/compositor","owner":{"login":"typesupply","id":4992934,"avatar_url":"https://avatars.githubusercontent.com/u/4992934?v=3","gravatar_id":"","url":"https://api.github.com/users/typesupply","html_url":"https://github.com/typesupply","followers_url":"https://api.github.com/users/typesupply/followers","following_url":"https://api.github.com/users/typesupply/following{/other_user}","gists_url":"https://api.github.com/users/typesupply/gists{/gist_id}","starred_url":"https://api.github.com/users/typesupply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesupply/subscriptions","organizations_url":"https://api.github.com/users/typesupply/orgs","repos_url":"https://api.github.com/users/typesupply/repos","events_url":"https://api.github.com/users/typesupply/events{/privacy}","received_events_url":"https://api.github.com/users/typesupply/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/typesupply/compositor","description":"A basic OpenType GSUB and GPOS layout engine.","fork":false,"url":"https://api.github.com/repos/typesupply/compositor","forks_url":"https://api.github.com/repos/typesupply/compositor/forks","keys_url":"https://api.github.com/repos/typesupply/compositor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesupply/compositor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesupply/compositor/teams","hooks_url":"https://api.github.com/repos/typesupply/compositor/hooks","issue_events_url":"https://api.github.com/repos/typesupply/compositor/issues/events{/number}","events_url":"https://api.github.com/repos/typesupply/compositor/events","assignees_url":"https://api.github.com/repos/typesupply/compositor/assignees{/user}","branches_url":"https://api.github.com/repos/typesupply/compositor/branches{/branch}","tags_url":"https://api.github.com/repos/typesupply/compositor/tags","blobs_url":"https://api.github.com/repos/typesupply/compositor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesupply/compositor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesupply/compositor/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesupply/compositor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesupply/compositor/statuses/{sha}","languages_url":"https://api.github.com/repos/typesupply/compositor/languages","stargazers_url":"https://api.github.com/repos/typesupply/compositor/stargazers","contributors_url":"https://api.github.com/repos/typesupply/compositor/contributors","subscribers_url":"https://api.github.com/repos/typesupply/compositor/subscribers","subscription_url":"https://api.github.com/repos/typesupply/compositor/subscription","commits_url":"https://api.github.com/repos/typesupply/compositor/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesupply/compositor/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesupply/compositor/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesupply/compositor/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesupply/compositor/contents/{+path}","compare_url":"https://api.github.com/repos/typesupply/compositor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesupply/compositor/merges","archive_url":"https://api.github.com/repos/typesupply/compositor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesupply/compositor/downloads","issues_url":"https://api.github.com/repos/typesupply/compositor/issues{/number}","pulls_url":"https://api.github.com/repos/typesupply/compositor/pulls{/number}","milestones_url":"https://api.github.com/repos/typesupply/compositor/milestones{/number}","notifications_url":"https://api.github.com/repos/typesupply/compositor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesupply/compositor/labels{/name}","releases_url":"https://api.github.com/repos/typesupply/compositor/releases{/id}","created_at":"2013-07-18T14:16:17Z","updated_at":"2016-01-17T03:49:20Z","pushed_at":"2016-01-19T10:40:21Z","git_url":"git://github.com/typesupply/compositor.git","ssh_url":"git@github.com:typesupply/compositor.git","clone_url":"https://github.com/typesupply/compositor.git","svn_url":"https://github.com/typesupply/compositor","homepage":null,"size":344,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/10"},"html":{"href":"https://github.com/typesupply/compositor/pull/10"},"issue":{"href":"https://api.github.com/repos/typesupply/compositor/issues/10"},"comments":{"href":"https://api.github.com/repos/typesupply/compositor/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesupply/compositor/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/typesupply/compositor/statuses/60bcc55ab3615c07c5f97132b1b580f54fb5ef0b"}}}}