{"action":"created","issue":{"url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/251","repository_url":"https://api.github.com/repos/ruby-grape/grape-entity","labels_url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/251/comments","events_url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/251/events","html_url":"https://github.com/ruby-grape/grape-entity/pull/251","id":191676589,"number":251,"title":"Avoid noise when code runs with Ruby warnings","user":{"login":"cpetschnig","id":48502,"avatar_url":"https://avatars.githubusercontent.com/u/48502?v=3","gravatar_id":"","url":"https://api.github.com/users/cpetschnig","html_url":"https://github.com/cpetschnig","followers_url":"https://api.github.com/users/cpetschnig/followers","following_url":"https://api.github.com/users/cpetschnig/following{/other_user}","gists_url":"https://api.github.com/users/cpetschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/cpetschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpetschnig/subscriptions","organizations_url":"https://api.github.com/users/cpetschnig/orgs","repos_url":"https://api.github.com/users/cpetschnig/repos","events_url":"https://api.github.com/users/cpetschnig/events{/privacy}","received_events_url":"https://api.github.com/users/cpetschnig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-25T11:00:24Z","updated_at":"2016-11-25T11:01:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ruby-grape/grape-entity/pulls/251","html_url":"https://github.com/ruby-grape/grape-entity/pull/251","diff_url":"https://github.com/ruby-grape/grape-entity/pull/251.diff","patch_url":"https://github.com/ruby-grape/grape-entity/pull/251.patch"},"body":"New versions of RSpec have warnings turned on by default:\r\n\r\n    # This setting enables warnings. It's recommended, but in some cases may\r\n    # be too noisy due to issues in dependencies.\r\n    config.warnings = true\r\n\r\nI believe these warnings are helpful in general to write better code. However, Grape Entity is very noisy. I get more than 10 lines of warnings for one single test where Grape Entity is involved.\r\n\r\nI hope you agree. Some of my changes could also be solved differently for sure. I am happy to discuss and change those cases. I also turned warnings on in the test suite."},"comment":{"url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/comments/262932958","html_url":"https://github.com/ruby-grape/grape-entity/pull/251#issuecomment-262932958","issue_url":"https://api.github.com/repos/ruby-grape/grape-entity/issues/251","id":262932958,"user":{"login":"grape-bot","id":20649811,"avatar_url":"https://avatars.githubusercontent.com/u/20649811?v=3","gravatar_id":"","url":"https://api.github.com/users/grape-bot","html_url":"https://github.com/grape-bot","followers_url":"https://api.github.com/users/grape-bot/followers","following_url":"https://api.github.com/users/grape-bot/following{/other_user}","gists_url":"https://api.github.com/users/grape-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/grape-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grape-bot/subscriptions","organizations_url":"https://api.github.com/users/grape-bot/orgs","repos_url":"https://api.github.com/users/grape-bot/repos","events_url":"https://api.github.com/users/grape-bot/events{/privacy}","received_events_url":"https://api.github.com/users/grape-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T11:01:54Z","updated_at":"2016-11-25T11:01:54Z","body":"<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Error\">\n          2 Errors\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td data-sticky=\"false\">One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.</td>\n    </tr>\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td data-sticky=\"false\">Please put back the <code>* Your contribution here.</code> line into CHANGELOG.md.</td>\n    </tr>\n  </tbody>\n</table>\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          1 Warning\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">Unless you’re refactoring existing code, please update CHANGELOG.md.</td>\n    </tr>\n  </tbody>\n</table>\n\nHere's an example of a CHANGELOG.md entry:\n\n```markdown\n* [#251](https://github.com/ruby-grape/grape-entity/pull/251): Avoid noise when code runs with Ruby warnings - [@cpetschnig](https://github.com/cpetschnig).\n```\n\n\n```markdown\n* Your contrbution here.\n```\n\n\n```markdown\n* Your contrbution here.\n```\n\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">danger</a>\n</p>\n"}}
{"actor":{"display_login":"grape-bot"}}