{"action":"created","issue":{"url":"https://api.github.com/repos/vincenthz/hs-tls/issues/173","repository_url":"https://api.github.com/repos/vincenthz/hs-tls","labels_url":"https://api.github.com/repos/vincenthz/hs-tls/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/vincenthz/hs-tls/issues/173/comments","events_url":"https://api.github.com/repos/vincenthz/hs-tls/issues/173/events","html_url":"https://github.com/vincenthz/hs-tls/pull/173","id":196606341,"number":173,"title":"add CONTRIBUTING","user":{"login":"vincenthz","id":174631,"avatar_url":"https://avatars.githubusercontent.com/u/174631?v=3","gravatar_id":"","url":"https://api.github.com/users/vincenthz","html_url":"https://github.com/vincenthz","followers_url":"https://api.github.com/users/vincenthz/followers","following_url":"https://api.github.com/users/vincenthz/following{/other_user}","gists_url":"https://api.github.com/users/vincenthz/gists{/gist_id}","starred_url":"https://api.github.com/users/vincenthz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincenthz/subscriptions","organizations_url":"https://api.github.com/users/vincenthz/orgs","repos_url":"https://api.github.com/users/vincenthz/repos","events_url":"https://api.github.com/users/vincenthz/events{/privacy}","received_events_url":"https://api.github.com/users/vincenthz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-20T07:43:05Z","updated_at":"2016-12-21T03:11:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vincenthz/hs-tls/pulls/173","html_url":"https://github.com/vincenthz/hs-tls/pull/173","diff_url":"https://github.com/vincenthz/hs-tls/pull/173.diff","patch_url":"https://github.com/vincenthz/hs-tls/pull/173.patch"},"body":"I've made a small guide to make sure we agree on how to maintain tls, and that we don't step on each other toes. @kazu-yamamoto @vdukhovni @ocheron please review and propose improvements/etc.."},"comment":{"url":"https://api.github.com/repos/vincenthz/hs-tls/issues/comments/268423625","html_url":"https://github.com/vincenthz/hs-tls/pull/173#issuecomment-268423625","issue_url":"https://api.github.com/repos/vincenthz/hs-tls/issues/173","id":268423625,"user":{"login":"vdukhovni","id":1107986,"avatar_url":"https://avatars.githubusercontent.com/u/1107986?v=3","gravatar_id":"","url":"https://api.github.com/users/vdukhovni","html_url":"https://github.com/vdukhovni","followers_url":"https://api.github.com/users/vdukhovni/followers","following_url":"https://api.github.com/users/vdukhovni/following{/other_user}","gists_url":"https://api.github.com/users/vdukhovni/gists{/gist_id}","starred_url":"https://api.github.com/users/vdukhovni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdukhovni/subscriptions","organizations_url":"https://api.github.com/users/vdukhovni/orgs","repos_url":"https://api.github.com/users/vdukhovni/repos","events_url":"https://api.github.com/users/vdukhovni/events{/privacy}","received_events_url":"https://api.github.com/users/vdukhovni/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T03:11:09Z","updated_at":"2016-12-21T03:11:09Z","body":"We should decide who/when merges reviewed code.  It is probably best to generally wait for a second review for most changes, and even give that second review a few days to cool down...\r\n\r\nI also prefer to avoid non-fast-forward merges, and would prefer too see PRs rebased, if necessary, prior to merging, so that the history is linear. This leaves the question of whether the final push is done by the reviewer, or the author.  The author may be best positioned to do any required rebase, but if that's non-trivial, it may need a final sign-off.\r\n\r\nI don't know whether Github supports configuring the repo to block non-ff pushes, but that may be an option to consider.  If we do that, then the final reviewer can do the (necessarily fast-forward) merge."}}
{"actor":{"display_login":"vdukhovni"}}