{"action":"created","issue":{"url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/104","repository_url":"https://api.github.com/repos/MIT-LCP/mimic-code","labels_url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/104/comments","events_url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/104/events","html_url":"https://github.com/MIT-LCP/mimic-code/pull/104","id":163526330,"number":104,"title":"Changed ventdurations from a table to a materialized view","user":{"login":"jeblundell","id":3390146,"avatar_url":"https://avatars.githubusercontent.com/u/3390146?v=3","gravatar_id":"","url":"https://api.github.com/users/jeblundell","html_url":"https://github.com/jeblundell","followers_url":"https://api.github.com/users/jeblundell/followers","following_url":"https://api.github.com/users/jeblundell/following{/other_user}","gists_url":"https://api.github.com/users/jeblundell/gists{/gist_id}","starred_url":"https://api.github.com/users/jeblundell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeblundell/subscriptions","organizations_url":"https://api.github.com/users/jeblundell/orgs","repos_url":"https://api.github.com/users/jeblundell/repos","events_url":"https://api.github.com/users/jeblundell/events{/privacy}","received_events_url":"https://api.github.com/users/jeblundell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-02T16:44:13Z","updated_at":"2016-07-06T14:14:07Z","closed_at":"2016-07-06T14:14:02Z","pull_request":{"url":"https://api.github.com/repos/MIT-LCP/mimic-code/pulls/104","html_url":"https://github.com/MIT-LCP/mimic-code/pull/104","diff_url":"https://github.com/MIT-LCP/mimic-code/pull/104.diff","patch_url":"https://github.com/MIT-LCP/mimic-code/pull/104.patch"},"body":"I've updated ventdurations to be a materialized view rather than a table, in fitting with everything else. Unless there was a reason it was a table instead?\r\n\r\nI've not adhered to styling guides purely in the interests of minimal-modification of the code: happy to make it clearer/tidier if that's wanted though. I've run a join between the view and the original table and as far as I can tell they are identical."},"comment":{"url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/comments/230784226","html_url":"https://github.com/MIT-LCP/mimic-code/pull/104#issuecomment-230784226","issue_url":"https://api.github.com/repos/MIT-LCP/mimic-code/issues/104","id":230784226,"user":{"login":"alistairewj","id":1282676,"avatar_url":"https://avatars.githubusercontent.com/u/1282676?v=3","gravatar_id":"","url":"https://api.github.com/users/alistairewj","html_url":"https://github.com/alistairewj","followers_url":"https://api.github.com/users/alistairewj/followers","following_url":"https://api.github.com/users/alistairewj/following{/other_user}","gists_url":"https://api.github.com/users/alistairewj/gists{/gist_id}","starred_url":"https://api.github.com/users/alistairewj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alistairewj/subscriptions","organizations_url":"https://api.github.com/users/alistairewj/orgs","repos_url":"https://api.github.com/users/alistairewj/repos","events_url":"https://api.github.com/users/alistairewj/events{/privacy}","received_events_url":"https://api.github.com/users/alistairewj/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T14:14:07Z","updated_at":"2016-07-06T14:14:07Z","body":"Yep, I think a materialized view is nicer because it maintains the relationship to the dependent tables. For example if the way GCS is calculated is changed and then the severity score views which depend on it are automatically dropped. Doesn't affect this table as much though since it's derived directly from the raw data, but it's nice to be consistent.\r\n\r\nAlso I noticed you changed `with` to inline queries - which would make it easier to adapt to MySQL. Did you just do that for style?\r\n\r\nThanks for the improvement!"}}
{"actor":{"display_login":"alistairewj"}}