{"action":"opened","number":12991,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/12991","id":65050219,"html_url":"https://github.com/laravel/framework/pull/12991","diff_url":"https://github.com/laravel/framework/pull/12991.diff","patch_url":"https://github.com/laravel/framework/pull/12991.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/12991","number":12991,"state":"open","locked":false,"title":"[5.2] Reverse a breaking addition in Route.php","user":{"login":"themsaid","id":4332182,"avatar_url":"https://avatars.githubusercontent.com/u/4332182?v=3","gravatar_id":"","url":"https://api.github.com/users/themsaid","html_url":"https://github.com/themsaid","followers_url":"https://api.github.com/users/themsaid/followers","following_url":"https://api.github.com/users/themsaid/following{/other_user}","gists_url":"https://api.github.com/users/themsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/themsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themsaid/subscriptions","organizations_url":"https://api.github.com/users/themsaid/orgs","repos_url":"https://api.github.com/users/themsaid/repos","events_url":"https://api.github.com/users/themsaid/events{/privacy}","received_events_url":"https://api.github.com/users/themsaid/received_events","type":"User","site_admin":false},"body":"In an earlier PR https://github.com/laravel/framework/pull/12899, controller routes were included in the `Route:middleware()` method output by calling `ControllerDispatcher`, this had two effects:\r\n\r\n1. All routes registered inside the middleware's constructor will be executed twice, once from `ControllerDispatcher::callWithinStack()` when the controller is actually being dispatched and another in `Router::runRouteWithinStack()` while the Router is dispatching the request to the route.\r\n2. All code inside the controller constructor will be executed while the `ControllerDispatcher` is instantiating the controller, some of this code is considered protected by a middleware registered in `routes.php`.\r\n\r\nFor example a code inside the controller constructor that logs a user's presence inside the dashboard area, this code will be executed although the controller is protected under the `auth` controller for example, or `auth.type.admin`\r\n\r\nAlso calls to `Request::user()` && `Auth::user()` will return null if the user is not logged in, although the developer added the `auth` middleware to this controller inside the routes file, this will call a PHP error when Controller dispatches is called instead of executing the `auth` middleware and redirect the user to the log in screen.\r\n\r\n---\r\n\r\nTerminable middlewares are useful, however I say we keep the old behaviour of firing them only when registered otherwhere than the controller for 5.2 in order not to break things.\r\n\r\nAnd I suggest in 5.3 we remove the `Controller::middleware()` method and make people use a static method for example that we can run from outside to collect the middlewares without executing the constructor code.\r\n\r\nAnd since we will be already collecting controller middlewares data before firing the controller actions, we won't need to read the controller routes from inside the controller itself.","created_at":"2016-04-02T21:10:38Z","updated_at":"2016-04-02T21:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/12991/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/12991/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/12991/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/ab4bad7d2caf5535e6d3e65ce5937e4495853528","head":{"label":"themsaid:reverse-terminiable-middleware-pr","ref":"reverse-terminiable-middleware-pr","sha":"ab4bad7d2caf5535e6d3e65ce5937e4495853528","user":{"login":"themsaid","id":4332182,"avatar_url":"https://avatars.githubusercontent.com/u/4332182?v=3","gravatar_id":"","url":"https://api.github.com/users/themsaid","html_url":"https://github.com/themsaid","followers_url":"https://api.github.com/users/themsaid/followers","following_url":"https://api.github.com/users/themsaid/following{/other_user}","gists_url":"https://api.github.com/users/themsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/themsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themsaid/subscriptions","organizations_url":"https://api.github.com/users/themsaid/orgs","repos_url":"https://api.github.com/users/themsaid/repos","events_url":"https://api.github.com/users/themsaid/events{/privacy}","received_events_url":"https://api.github.com/users/themsaid/received_events","type":"User","site_admin":false},"repo":{"id":49608612,"name":"framework","full_name":"themsaid/framework","owner":{"login":"themsaid","id":4332182,"avatar_url":"https://avatars.githubusercontent.com/u/4332182?v=3","gravatar_id":"","url":"https://api.github.com/users/themsaid","html_url":"https://github.com/themsaid","followers_url":"https://api.github.com/users/themsaid/followers","following_url":"https://api.github.com/users/themsaid/following{/other_user}","gists_url":"https://api.github.com/users/themsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/themsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themsaid/subscriptions","organizations_url":"https://api.github.com/users/themsaid/orgs","repos_url":"https://api.github.com/users/themsaid/repos","events_url":"https://api.github.com/users/themsaid/events{/privacy}","received_events_url":"https://api.github.com/users/themsaid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/themsaid/framework","description":"","fork":true,"url":"https://api.github.com/repos/themsaid/framework","forks_url":"https://api.github.com/repos/themsaid/framework/forks","keys_url":"https://api.github.com/repos/themsaid/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/themsaid/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/themsaid/framework/teams","hooks_url":"https://api.github.com/repos/themsaid/framework/hooks","issue_events_url":"https://api.github.com/repos/themsaid/framework/issues/events{/number}","events_url":"https://api.github.com/repos/themsaid/framework/events","assignees_url":"https://api.github.com/repos/themsaid/framework/assignees{/user}","branches_url":"https://api.github.com/repos/themsaid/framework/branches{/branch}","tags_url":"https://api.github.com/repos/themsaid/framework/tags","blobs_url":"https://api.github.com/repos/themsaid/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/themsaid/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/themsaid/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/themsaid/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/themsaid/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/themsaid/framework/languages","stargazers_url":"https://api.github.com/repos/themsaid/framework/stargazers","contributors_url":"https://api.github.com/repos/themsaid/framework/contributors","subscribers_url":"https://api.github.com/repos/themsaid/framework/subscribers","subscription_url":"https://api.github.com/repos/themsaid/framework/subscription","commits_url":"https://api.github.com/repos/themsaid/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/themsaid/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/themsaid/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/themsaid/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/themsaid/framework/contents/{+path}","compare_url":"https://api.github.com/repos/themsaid/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/themsaid/framework/merges","archive_url":"https://api.github.com/repos/themsaid/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/themsaid/framework/downloads","issues_url":"https://api.github.com/repos/themsaid/framework/issues{/number}","pulls_url":"https://api.github.com/repos/themsaid/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/themsaid/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/themsaid/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/themsaid/framework/labels{/name}","releases_url":"https://api.github.com/repos/themsaid/framework/releases{/id}","deployments_url":"https://api.github.com/repos/themsaid/framework/deployments","created_at":"2016-01-13T23:19:06Z","updated_at":"2016-01-13T23:19:10Z","pushed_at":"2016-04-02T20:44:21Z","git_url":"git://github.com/themsaid/framework.git","ssh_url":"git@github.com:themsaid/framework.git","clone_url":"https://github.com/themsaid/framework.git","svn_url":"https://github.com/themsaid/framework","homepage":"http://laravel.com","size":22388,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:5.2","ref":"5.2","sha":"024f1f78168553814876f6ade86ddf9f86c5297a","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-04-02T16:48:41Z","pushed_at":"2016-04-02T20:09:55Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":36502,"stargazers_count":5046,"watchers_count":5046,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2923,"mirror_url":null,"open_issues_count":116,"forks":2923,"open_issues":116,"watchers":5046,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/12991"},"html":{"href":"https://github.com/laravel/framework/pull/12991"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/12991"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/12991/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/12991/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/12991/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/ab4bad7d2caf5535e6d3e65ce5937e4495853528"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":9,"changed_files":1}}