{"action":"created","comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/53648092","id":53648092,"diff_hunk":"@@ -15,15 +15,22 @@ public class GlobalizationConfiguration\n         /// <summary>\r\n         /// Initializes a new instance of the <see cref=\"GlobalizationConfiguration\"/> class\r\n         /// </summary>\r\n-        /// <param name=\"supportedCultureNames\"></param>\r\n-        public GlobalizationConfiguration(IEnumerable<string> supportedCultureNames)\r\n+        /// <param name=\"supportedCultureNames\">An array of supported cultures</param>\r\n+        /// <param name=\"defaultCulture\">The default culture of the application</param>\r","path":"src/Nancy/GlobalizationConfiguration.cs","position":7,"original_position":7,"commit_id":"35c85e75032bf9f817431a3ad4c44a983da7ecaa","original_commit_id":"f7d7d0f0d42bd9800449ea696fdd3871d40010d7","user":{"login":"thecodejunkie","id":50543,"avatar_url":"https://avatars.githubusercontent.com/u/50543?v=3","gravatar_id":"","url":"https://api.github.com/users/thecodejunkie","html_url":"https://github.com/thecodejunkie","followers_url":"https://api.github.com/users/thecodejunkie/followers","following_url":"https://api.github.com/users/thecodejunkie/following{/other_user}","gists_url":"https://api.github.com/users/thecodejunkie/gists{/gist_id}","starred_url":"https://api.github.com/users/thecodejunkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecodejunkie/subscriptions","organizations_url":"https://api.github.com/users/thecodejunkie/orgs","repos_url":"https://api.github.com/users/thecodejunkie/repos","events_url":"https://api.github.com/users/thecodejunkie/events{/privacy}","received_events_url":"https://api.github.com/users/thecodejunkie/received_events","type":"User","site_admin":false},"body":"I think we need to point out that the culture you provide here, needs to exist in the `supportedCultureNames` collection and handle it appropriately when it does not. Maybe we need to introduce a general purpose `ConfigurationException` for these types of things?","created_at":"2016-02-22T16:15:20Z","updated_at":"2016-02-22T16:15:21Z","html_url":"https://github.com/NancyFx/Nancy/pull/2290#discussion_r53648092","pull_request_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290","_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/53648092"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2290#discussion_r53648092"},"pull_request":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290"}}},"pull_request":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290","id":60005464,"html_url":"https://github.com/NancyFx/Nancy/pull/2290","diff_url":"https://github.com/NancyFx/Nancy/pull/2290.diff","patch_url":"https://github.com/NancyFx/Nancy/pull/2290.patch","issue_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2290","number":2290,"state":"open","locked":false,"title":"Don't use Thread.CurrentThread.CurrentCulture for coreclr","user":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"body":"Thread.CurrentThread.CurrentCulture does not exist for CoreCLR. \r\n\r\nLooking at how Microsoft [do it](https://github.com/aspnet/Localization/blob/dev/src/Microsoft.AspNetCore.Localization/RequestLocalizationMiddleware.cs#L129-L135) I've made the containing changes.","created_at":"2016-02-19T20:50:02Z","updated_at":"2016-02-22T16:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d30b2398e74ae86f8efb15ac6c7514230e27ab6","assignee":null,"milestone":{"url":"https://api.github.com/repos/NancyFx/Nancy/milestones/46","html_url":"https://github.com/NancyFx/Nancy/milestones/coreclr","labels_url":"https://api.github.com/repos/NancyFx/Nancy/milestones/46/labels","id":1555265,"number":46,"title":"coreclr","description":"","creator":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":22,"state":"open","created_at":"2016-02-01T10:48:25Z","updated_at":"2016-02-22T13:28:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290/commits","review_comments_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290/comments","review_comment_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2290/comments","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/35c85e75032bf9f817431a3ad4c44a983da7ecaa","head":{"label":"jchannon:threadculture","ref":"threadculture","sha":"35c85e75032bf9f817431a3ad4c44a983da7ecaa","user":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"repo":{"id":4134555,"name":"Nancy","full_name":"jchannon/Nancy","owner":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jchannon/Nancy","description":"Nancy is a lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":true,"url":"https://api.github.com/repos/jchannon/Nancy","forks_url":"https://api.github.com/repos/jchannon/Nancy/forks","keys_url":"https://api.github.com/repos/jchannon/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jchannon/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jchannon/Nancy/teams","hooks_url":"https://api.github.com/repos/jchannon/Nancy/hooks","issue_events_url":"https://api.github.com/repos/jchannon/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/jchannon/Nancy/events","assignees_url":"https://api.github.com/repos/jchannon/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/jchannon/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/jchannon/Nancy/tags","blobs_url":"https://api.github.com/repos/jchannon/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jchannon/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jchannon/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jchannon/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jchannon/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/jchannon/Nancy/languages","stargazers_url":"https://api.github.com/repos/jchannon/Nancy/stargazers","contributors_url":"https://api.github.com/repos/jchannon/Nancy/contributors","subscribers_url":"https://api.github.com/repos/jchannon/Nancy/subscribers","subscription_url":"https://api.github.com/repos/jchannon/Nancy/subscription","commits_url":"https://api.github.com/repos/jchannon/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jchannon/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jchannon/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jchannon/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jchannon/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/jchannon/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jchannon/Nancy/merges","archive_url":"https://api.github.com/repos/jchannon/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jchannon/Nancy/downloads","issues_url":"https://api.github.com/repos/jchannon/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/jchannon/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/jchannon/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/jchannon/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jchannon/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/jchannon/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/jchannon/Nancy/deployments","created_at":"2012-04-25T08:48:08Z","updated_at":"2015-06-09T16:28:50Z","pushed_at":"2016-02-22T16:10:52Z","git_url":"git://github.com/jchannon/Nancy.git","ssh_url":"git@github.com:jchannon/Nancy.git","clone_url":"https://github.com/jchannon/Nancy.git","svn_url":"https://github.com/jchannon/Nancy","homepage":"http://nancyfx.org","size":43885,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NancyFx:coreclr","ref":"coreclr","sha":"54671dee354a98cf64dc90e7540a9de5c1657055","user":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"repo":{"id":738250,"name":"Nancy","full_name":"NancyFx/Nancy","owner":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NancyFx/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":false,"url":"https://api.github.com/repos/NancyFx/Nancy","forks_url":"https://api.github.com/repos/NancyFx/Nancy/forks","keys_url":"https://api.github.com/repos/NancyFx/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NancyFx/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NancyFx/Nancy/teams","hooks_url":"https://api.github.com/repos/NancyFx/Nancy/hooks","issue_events_url":"https://api.github.com/repos/NancyFx/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/NancyFx/Nancy/events","assignees_url":"https://api.github.com/repos/NancyFx/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/NancyFx/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/NancyFx/Nancy/tags","blobs_url":"https://api.github.com/repos/NancyFx/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NancyFx/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NancyFx/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/NancyFx/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/NancyFx/Nancy/languages","stargazers_url":"https://api.github.com/repos/NancyFx/Nancy/stargazers","contributors_url":"https://api.github.com/repos/NancyFx/Nancy/contributors","subscribers_url":"https://api.github.com/repos/NancyFx/Nancy/subscribers","subscription_url":"https://api.github.com/repos/NancyFx/Nancy/subscription","commits_url":"https://api.github.com/repos/NancyFx/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/NancyFx/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/NancyFx/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/NancyFx/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/NancyFx/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NancyFx/Nancy/merges","archive_url":"https://api.github.com/repos/NancyFx/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NancyFx/Nancy/downloads","issues_url":"https://api.github.com/repos/NancyFx/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/NancyFx/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/NancyFx/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/NancyFx/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NancyFx/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/NancyFx/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/NancyFx/Nancy/deployments","created_at":"2010-06-24T19:35:22Z","updated_at":"2016-02-22T13:15:21Z","pushed_at":"2016-02-22T16:10:54Z","git_url":"git://github.com/NancyFx/Nancy.git","ssh_url":"git@github.com:NancyFx/Nancy.git","clone_url":"https://github.com/NancyFx/Nancy.git","svn_url":"https://github.com/NancyFx/Nancy","homepage":"http://nancyfx.org","size":63542,"stargazers_count":3767,"watchers_count":3767,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":990,"mirror_url":null,"open_issues_count":132,"forks":990,"open_issues":132,"watchers":3767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2290"},"issue":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2290"},"comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2290/comments"},"review_comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290/comments"},"review_comment":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2290/commits"},"statuses":{"href":"https://api.github.com/repos/NancyFx/Nancy/statuses/35c85e75032bf9f817431a3ad4c44a983da7ecaa"}}}}