{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/74892301","id":74892301,"diff_hunk":"@@ -209,6 +209,11 @@ public void run()\n   {\n     mLogger.d(\"ctor()\");\n \n+    // TODO consider refactoring.\n+    // Actually we shouldn't initialize Framework here,\n+    // to allow app components to retrieve location updates without all heavy framework's stuff initialized.\n+    // For now this is necessary to connect mModeChangeListener below.\n+    MwmApplication.get().initNativeCore();","path":"android/src/com/mapswithme/maps/location/LocationHelper.java","position":8,"original_position":8,"commit_id":"78ec1539010b4c83cfbe6e3ef966f25e656e25ca","original_commit_id":"78ec1539010b4c83cfbe6e3ef966f25e656e25ca","user":{"login":"ygorshenin","id":454567,"avatar_url":"https://avatars.githubusercontent.com/u/454567?v=3","gravatar_id":"","url":"https://api.github.com/users/ygorshenin","html_url":"https://github.com/ygorshenin","followers_url":"https://api.github.com/users/ygorshenin/followers","following_url":"https://api.github.com/users/ygorshenin/following{/other_user}","gists_url":"https://api.github.com/users/ygorshenin/gists{/gist_id}","starred_url":"https://api.github.com/users/ygorshenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygorshenin/subscriptions","organizations_url":"https://api.github.com/users/ygorshenin/orgs","repos_url":"https://api.github.com/users/ygorshenin/repos","events_url":"https://api.github.com/users/ygorshenin/events{/privacy}","received_events_url":"https://api.github.com/users/ygorshenin/received_events","type":"User","site_admin":false},"body":"And why not to just skip nativeSetListener if framework is not initialized?","created_at":"2016-08-16T08:11:10Z","updated_at":"2016-08-16T08:11:10Z","html_url":"https://github.com/mapsme/omim/pull/4064#discussion_r74892301","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/4064","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/74892301"},"html":{"href":"https://github.com/mapsme/omim/pull/4064#discussion_r74892301"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4064"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/4064","id":81418061,"html_url":"https://github.com/mapsme/omim/pull/4064","diff_url":"https://github.com/mapsme/omim/pull/4064.diff","patch_url":"https://github.com/mapsme/omim/pull/4064.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/4064","number":4064,"state":"open","locked":false,"title":"[android] Fixed crash.","user":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-08-16T05:54:35Z","updated_at":"2016-08-16T08:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/4064/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/4064/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/4064/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/78ec1539010b4c83cfbe6e3ef966f25e656e25ca","head":{"label":"yunikkk:crashfix-location-no-framework","ref":"crashfix-location-no-framework","sha":"78ec1539010b4c83cfbe6e3ef966f25e656e25ca","user":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"repo":{"id":44106681,"name":"omim","full_name":"yunikkk/omim","owner":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yunikkk/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/yunikkk/omim","forks_url":"https://api.github.com/repos/yunikkk/omim/forks","keys_url":"https://api.github.com/repos/yunikkk/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yunikkk/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yunikkk/omim/teams","hooks_url":"https://api.github.com/repos/yunikkk/omim/hooks","issue_events_url":"https://api.github.com/repos/yunikkk/omim/issues/events{/number}","events_url":"https://api.github.com/repos/yunikkk/omim/events","assignees_url":"https://api.github.com/repos/yunikkk/omim/assignees{/user}","branches_url":"https://api.github.com/repos/yunikkk/omim/branches{/branch}","tags_url":"https://api.github.com/repos/yunikkk/omim/tags","blobs_url":"https://api.github.com/repos/yunikkk/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yunikkk/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yunikkk/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/yunikkk/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yunikkk/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/yunikkk/omim/languages","stargazers_url":"https://api.github.com/repos/yunikkk/omim/stargazers","contributors_url":"https://api.github.com/repos/yunikkk/omim/contributors","subscribers_url":"https://api.github.com/repos/yunikkk/omim/subscribers","subscription_url":"https://api.github.com/repos/yunikkk/omim/subscription","commits_url":"https://api.github.com/repos/yunikkk/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/yunikkk/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/yunikkk/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/yunikkk/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/yunikkk/omim/contents/{+path}","compare_url":"https://api.github.com/repos/yunikkk/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yunikkk/omim/merges","archive_url":"https://api.github.com/repos/yunikkk/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yunikkk/omim/downloads","issues_url":"https://api.github.com/repos/yunikkk/omim/issues{/number}","pulls_url":"https://api.github.com/repos/yunikkk/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/yunikkk/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/yunikkk/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yunikkk/omim/labels{/name}","releases_url":"https://api.github.com/repos/yunikkk/omim/releases{/id}","deployments_url":"https://api.github.com/repos/yunikkk/omim/deployments","created_at":"2015-10-12T12:41:54Z","updated_at":"2016-02-05T12:51:47Z","pushed_at":"2016-08-16T05:59:09Z","git_url":"git://github.com/yunikkk/omim.git","ssh_url":"git@github.com:yunikkk/omim.git","clone_url":"https://github.com/yunikkk/omim.git","svn_url":"https://github.com/yunikkk/omim","homepage":null,"size":2610503,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:release-63","ref":"release-63","sha":"b0d26ededd8b00dab11c2645659420dc06b042e4","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-08-16T06:59:07Z","pushed_at":"2016-08-16T08:08:56Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2715234,"stargazers_count":1917,"watchers_count":1917,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":237,"forks":331,"open_issues":237,"watchers":1917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4064"},"html":{"href":"https://github.com/mapsme/omim/pull/4064"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/4064"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/4064/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4064/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4064/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/78ec1539010b4c83cfbe6e3ef966f25e656e25ca"}}}}
{"actor":{"display_login":"ygorshenin"}}