{"action":"opened","number":632,"pull_request":{"url":"https://api.github.com/repos/schmittjoh/serializer/pulls/632","id":82667285,"html_url":"https://github.com/schmittjoh/serializer/pull/632","diff_url":"https://github.com/schmittjoh/serializer/pull/632.diff","patch_url":"https://github.com/schmittjoh/serializer/pull/632.patch","issue_url":"https://api.github.com/repos/schmittjoh/serializer/issues/632","number":632,"state":"open","locked":false,"title":"MaxDepth is handled incorrectly with Collections","user":{"login":"voda","id":290157,"avatar_url":"https://avatars.githubusercontent.com/u/290157?v=3","gravatar_id":"","url":"https://api.github.com/users/voda","html_url":"https://github.com/voda","followers_url":"https://api.github.com/users/voda/followers","following_url":"https://api.github.com/users/voda/following{/other_user}","gists_url":"https://api.github.com/users/voda/gists{/gist_id}","starred_url":"https://api.github.com/users/voda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voda/subscriptions","organizations_url":"https://api.github.com/users/voda/orgs","repos_url":"https://api.github.com/users/voda/repos","events_url":"https://api.github.com/users/voda/events{/privacy}","received_events_url":"https://api.github.com/users/voda/received_events","type":"User","site_admin":false},"body":"This is an updated version of PR #423 with included tests. Original description:\r\n\r\nThis fixes handling collections for the purpose of depth calculations. Since arrays are not counted as a depth level, neither should Collections.\r\nThe other side effect of this change is that @MaxDepth on an entity inside a collection will be handled correctly as well (before, each Collection contributed +1 to depth, but did not leave PropertyMetadata, therefore was not subtracted when calculating relative depth).","created_at":"2016-08-25T07:08:00Z","updated_at":"2016-08-25T07:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/schmittjoh/serializer/pulls/632/commits","review_comments_url":"https://api.github.com/repos/schmittjoh/serializer/pulls/632/comments","review_comment_url":"https://api.github.com/repos/schmittjoh/serializer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/schmittjoh/serializer/issues/632/comments","statuses_url":"https://api.github.com/repos/schmittjoh/serializer/statuses/65e484624c0aa7fd840a5a7d9a739d3020091734","head":{"label":"voda:collection-max-depth","ref":"collection-max-depth","sha":"65e484624c0aa7fd840a5a7d9a739d3020091734","user":{"login":"voda","id":290157,"avatar_url":"https://avatars.githubusercontent.com/u/290157?v=3","gravatar_id":"","url":"https://api.github.com/users/voda","html_url":"https://github.com/voda","followers_url":"https://api.github.com/users/voda/followers","following_url":"https://api.github.com/users/voda/following{/other_user}","gists_url":"https://api.github.com/users/voda/gists{/gist_id}","starred_url":"https://api.github.com/users/voda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voda/subscriptions","organizations_url":"https://api.github.com/users/voda/orgs","repos_url":"https://api.github.com/users/voda/repos","events_url":"https://api.github.com/users/voda/events{/privacy}","received_events_url":"https://api.github.com/users/voda/received_events","type":"User","site_admin":false},"repo":{"id":51992441,"name":"serializer","full_name":"voda/serializer","owner":{"login":"voda","id":290157,"avatar_url":"https://avatars.githubusercontent.com/u/290157?v=3","gravatar_id":"","url":"https://api.github.com/users/voda","html_url":"https://github.com/voda","followers_url":"https://api.github.com/users/voda/followers","following_url":"https://api.github.com/users/voda/following{/other_user}","gists_url":"https://api.github.com/users/voda/gists{/gist_id}","starred_url":"https://api.github.com/users/voda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voda/subscriptions","organizations_url":"https://api.github.com/users/voda/orgs","repos_url":"https://api.github.com/users/voda/repos","events_url":"https://api.github.com/users/voda/events{/privacy}","received_events_url":"https://api.github.com/users/voda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/voda/serializer","description":"Library for (de-)serializing data of any complexity (supports XML, JSON, YAML)","fork":true,"url":"https://api.github.com/repos/voda/serializer","forks_url":"https://api.github.com/repos/voda/serializer/forks","keys_url":"https://api.github.com/repos/voda/serializer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voda/serializer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voda/serializer/teams","hooks_url":"https://api.github.com/repos/voda/serializer/hooks","issue_events_url":"https://api.github.com/repos/voda/serializer/issues/events{/number}","events_url":"https://api.github.com/repos/voda/serializer/events","assignees_url":"https://api.github.com/repos/voda/serializer/assignees{/user}","branches_url":"https://api.github.com/repos/voda/serializer/branches{/branch}","tags_url":"https://api.github.com/repos/voda/serializer/tags","blobs_url":"https://api.github.com/repos/voda/serializer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voda/serializer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voda/serializer/git/refs{/sha}","trees_url":"https://api.github.com/repos/voda/serializer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voda/serializer/statuses/{sha}","languages_url":"https://api.github.com/repos/voda/serializer/languages","stargazers_url":"https://api.github.com/repos/voda/serializer/stargazers","contributors_url":"https://api.github.com/repos/voda/serializer/contributors","subscribers_url":"https://api.github.com/repos/voda/serializer/subscribers","subscription_url":"https://api.github.com/repos/voda/serializer/subscription","commits_url":"https://api.github.com/repos/voda/serializer/commits{/sha}","git_commits_url":"https://api.github.com/repos/voda/serializer/git/commits{/sha}","comments_url":"https://api.github.com/repos/voda/serializer/comments{/number}","issue_comment_url":"https://api.github.com/repos/voda/serializer/issues/comments{/number}","contents_url":"https://api.github.com/repos/voda/serializer/contents/{+path}","compare_url":"https://api.github.com/repos/voda/serializer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voda/serializer/merges","archive_url":"https://api.github.com/repos/voda/serializer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voda/serializer/downloads","issues_url":"https://api.github.com/repos/voda/serializer/issues{/number}","pulls_url":"https://api.github.com/repos/voda/serializer/pulls{/number}","milestones_url":"https://api.github.com/repos/voda/serializer/milestones{/number}","notifications_url":"https://api.github.com/repos/voda/serializer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voda/serializer/labels{/name}","releases_url":"https://api.github.com/repos/voda/serializer/releases{/id}","deployments_url":"https://api.github.com/repos/voda/serializer/deployments","created_at":"2016-02-18T08:33:19Z","updated_at":"2016-02-18T08:33:21Z","pushed_at":"2016-08-25T07:05:31Z","git_url":"git://github.com/voda/serializer.git","ssh_url":"git@github.com:voda/serializer.git","clone_url":"https://github.com/voda/serializer.git","svn_url":"https://github.com/voda/serializer","homepage":"http://jmsyst.com/libs/serializer","size":1702,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"schmittjoh:master","ref":"master","sha":"705d0b4633b9c44e6253aa18306b3972282cd3a3","user":{"login":"schmittjoh","id":197017,"avatar_url":"https://avatars.githubusercontent.com/u/197017?v=3","gravatar_id":"","url":"https://api.github.com/users/schmittjoh","html_url":"https://github.com/schmittjoh","followers_url":"https://api.github.com/users/schmittjoh/followers","following_url":"https://api.github.com/users/schmittjoh/following{/other_user}","gists_url":"https://api.github.com/users/schmittjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/schmittjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmittjoh/subscriptions","organizations_url":"https://api.github.com/users/schmittjoh/orgs","repos_url":"https://api.github.com/users/schmittjoh/repos","events_url":"https://api.github.com/users/schmittjoh/events{/privacy}","received_events_url":"https://api.github.com/users/schmittjoh/received_events","type":"User","site_admin":false},"repo":{"id":6954048,"name":"serializer","full_name":"schmittjoh/serializer","owner":{"login":"schmittjoh","id":197017,"avatar_url":"https://avatars.githubusercontent.com/u/197017?v=3","gravatar_id":"","url":"https://api.github.com/users/schmittjoh","html_url":"https://github.com/schmittjoh","followers_url":"https://api.github.com/users/schmittjoh/followers","following_url":"https://api.github.com/users/schmittjoh/following{/other_user}","gists_url":"https://api.github.com/users/schmittjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/schmittjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmittjoh/subscriptions","organizations_url":"https://api.github.com/users/schmittjoh/orgs","repos_url":"https://api.github.com/users/schmittjoh/repos","events_url":"https://api.github.com/users/schmittjoh/events{/privacy}","received_events_url":"https://api.github.com/users/schmittjoh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmittjoh/serializer","description":"Library for (de-)serializing data of any complexity (supports XML, JSON, YAML)","fork":false,"url":"https://api.github.com/repos/schmittjoh/serializer","forks_url":"https://api.github.com/repos/schmittjoh/serializer/forks","keys_url":"https://api.github.com/repos/schmittjoh/serializer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmittjoh/serializer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmittjoh/serializer/teams","hooks_url":"https://api.github.com/repos/schmittjoh/serializer/hooks","issue_events_url":"https://api.github.com/repos/schmittjoh/serializer/issues/events{/number}","events_url":"https://api.github.com/repos/schmittjoh/serializer/events","assignees_url":"https://api.github.com/repos/schmittjoh/serializer/assignees{/user}","branches_url":"https://api.github.com/repos/schmittjoh/serializer/branches{/branch}","tags_url":"https://api.github.com/repos/schmittjoh/serializer/tags","blobs_url":"https://api.github.com/repos/schmittjoh/serializer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmittjoh/serializer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmittjoh/serializer/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmittjoh/serializer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmittjoh/serializer/statuses/{sha}","languages_url":"https://api.github.com/repos/schmittjoh/serializer/languages","stargazers_url":"https://api.github.com/repos/schmittjoh/serializer/stargazers","contributors_url":"https://api.github.com/repos/schmittjoh/serializer/contributors","subscribers_url":"https://api.github.com/repos/schmittjoh/serializer/subscribers","subscription_url":"https://api.github.com/repos/schmittjoh/serializer/subscription","commits_url":"https://api.github.com/repos/schmittjoh/serializer/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmittjoh/serializer/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmittjoh/serializer/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmittjoh/serializer/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmittjoh/serializer/contents/{+path}","compare_url":"https://api.github.com/repos/schmittjoh/serializer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmittjoh/serializer/merges","archive_url":"https://api.github.com/repos/schmittjoh/serializer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmittjoh/serializer/downloads","issues_url":"https://api.github.com/repos/schmittjoh/serializer/issues{/number}","pulls_url":"https://api.github.com/repos/schmittjoh/serializer/pulls{/number}","milestones_url":"https://api.github.com/repos/schmittjoh/serializer/milestones{/number}","notifications_url":"https://api.github.com/repos/schmittjoh/serializer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmittjoh/serializer/labels{/name}","releases_url":"https://api.github.com/repos/schmittjoh/serializer/releases{/id}","deployments_url":"https://api.github.com/repos/schmittjoh/serializer/deployments","created_at":"2012-12-01T12:46:39Z","updated_at":"2016-08-25T06:59:19Z","pushed_at":"2016-08-25T07:08:01Z","git_url":"git://github.com/schmittjoh/serializer.git","ssh_url":"git@github.com:schmittjoh/serializer.git","clone_url":"https://github.com/schmittjoh/serializer.git","svn_url":"https://github.com/schmittjoh/serializer","homepage":"http://jmsyst.com/libs/serializer","size":3330,"stargazers_count":511,"watchers_count":511,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":395,"mirror_url":null,"open_issues_count":255,"forks":395,"open_issues":255,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/schmittjoh/serializer/pulls/632"},"html":{"href":"https://github.com/schmittjoh/serializer/pull/632"},"issue":{"href":"https://api.github.com/repos/schmittjoh/serializer/issues/632"},"comments":{"href":"https://api.github.com/repos/schmittjoh/serializer/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/schmittjoh/serializer/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/schmittjoh/serializer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/schmittjoh/serializer/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/schmittjoh/serializer/statuses/65e484624c0aa7fd840a5a7d9a739d3020091734"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":104,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"voda"}}