{"action":"created","issue":{"url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/1","repository_url":"https://api.github.com/repos/wcjr/zxcvbn-api","labels_url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/1/comments","events_url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/1/events","html_url":"https://github.com/wcjr/zxcvbn-api/issues/1","id":179328213,"number":1,"title":"Enhancements","user":{"login":"tracker1","id":444316,"avatar_url":"https://avatars.githubusercontent.com/u/444316?v=3","gravatar_id":"","url":"https://api.github.com/users/tracker1","html_url":"https://github.com/tracker1","followers_url":"https://api.github.com/users/tracker1/followers","following_url":"https://api.github.com/users/tracker1/following{/other_user}","gists_url":"https://api.github.com/users/tracker1/gists{/gist_id}","starred_url":"https://api.github.com/users/tracker1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracker1/subscriptions","organizations_url":"https://api.github.com/users/tracker1/orgs","repos_url":"https://api.github.com/users/tracker1/repos","events_url":"https://api.github.com/users/tracker1/events{/privacy}","received_events_url":"https://api.github.com/users/tracker1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-26T20:25:03Z","updated_at":"2016-09-28T17:04:29Z","closed_at":null,"body":"If the intent is to really turn this into a backing service, should probably add the following.\r\n\r\n* Add CORS support (cross origin)\r\n* Size limit for body parser (5kb should be way more than enough), will prevent some flooding/injection attacks\r\n* Add error handler to return JSON, good for all API interfaces to return errors in the common format used by the API itself.  Errors should return an object, with a single error property, with at least a code (corresponding to http status code, and message, containing error text, and optionally other error properties).\r\n\r\n```\r\n{ // single object response, with single property of \"error\"\r\n  error: {\r\n    code: 400 //invalid input, or 5xx for other errors\r\n    ,message: error.message // original or custom error message\r\n    ,...error // other properties from error, message is part of inheritance and doesn't serialize\r\n  }\r\n}\r\n```\r\n\r\nPossible value-adds:\r\n\r\n* Wrap zxcvbn request processing into a [pool](https://www.npmjs.com/package/generic-pool) limited to PROCESSOR_COUNT instances, so that you can avert some flooding scenarios.\r\n* Add [xdomain](https://github.com/jpillora/xdomain) proxy.html so that xdomain can be used with old IE in order to use the service."},"comment":{"url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/comments/250230760","html_url":"https://github.com/wcjr/zxcvbn-api/issues/1#issuecomment-250230760","issue_url":"https://api.github.com/repos/wcjr/zxcvbn-api/issues/1","id":250230760,"user":{"login":"wcjr","id":4412848,"avatar_url":"https://avatars.githubusercontent.com/u/4412848?v=3","gravatar_id":"","url":"https://api.github.com/users/wcjr","html_url":"https://github.com/wcjr","followers_url":"https://api.github.com/users/wcjr/followers","following_url":"https://api.github.com/users/wcjr/following{/other_user}","gists_url":"https://api.github.com/users/wcjr/gists{/gist_id}","starred_url":"https://api.github.com/users/wcjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcjr/subscriptions","organizations_url":"https://api.github.com/users/wcjr/orgs","repos_url":"https://api.github.com/users/wcjr/repos","events_url":"https://api.github.com/users/wcjr/events{/privacy}","received_events_url":"https://api.github.com/users/wcjr/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T17:04:29Z","updated_at":"2016-09-28T17:04:29Z","body":"I really appreciate that, I'm definitely open to making it more valuable for others if a need develops."}}
{"actor":{"display_login":"wcjr"}}