{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11776","repository_url":"https://api.github.com/repos/dimagi/commcare-hq","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11776/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11776/comments","events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11776/events","html_url":"https://github.com/dimagi/commcare-hq/pull/11776","id":156979521,"number":11776,"title":"E-mail if isEmailable, not isExportAll","user":{"login":"kaapstorm","id":708421,"avatar_url":"https://avatars.githubusercontent.com/u/708421?v=3","gravatar_id":"","url":"https://api.github.com/users/kaapstorm","html_url":"https://github.com/kaapstorm","followers_url":"https://api.github.com/users/kaapstorm/followers","following_url":"https://api.github.com/users/kaapstorm/following{/other_user}","gists_url":"https://api.github.com/users/kaapstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaapstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaapstorm/subscriptions","organizations_url":"https://api.github.com/users/kaapstorm/orgs","repos_url":"https://api.github.com/users/kaapstorm/repos","events_url":"https://api.github.com/users/kaapstorm/events{/privacy}","received_events_url":"https://api.github.com/users/kaapstorm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dimagi/commcare-hq/labels/No%20lint%20errors","name":"No lint errors","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-05-26T13:08:00Z","updated_at":"2016-07-05T09:13:12Z","closed_at":"2016-06-21T16:59:25Z","pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11776","html_url":"https://github.com/dimagi/commcare-hq/pull/11776","diff_url":"https://github.com/dimagi/commcare-hq/pull/11776.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/11776.patch"},"body":"Seems like a mistake ... BUT this change would mean that custom reports marked `emailable = False` but `exportable_all = True` will no longer be e-mailable, and users might be accustomed to the current behavior. \r\n\r\nAffects the following reports:\r\n  * [SMSBillablesInterface](https://github.com/dimagi/commcare-hq/blob/7150cddae3179e46069112b1fcb4f537e2142cd5/corehq/apps/smsbillables/interface.py#L31-L31)\r\n  * [SMSGatewayFeeCriteriaInterface](https://github.com/dimagi/commcare-hq/blob/7150cddae3179e46069112b1fcb4f537e2142cd5/corehq/apps/smsbillables/interface.py#L195-L195)\r\n  * [ChildMCHRegister](https://github.com/dimagi/commcare-hq/blob/dedf2496c5e264b78a6a4acaa6c186184cd3159d/custom/bihar/reports/mch_reports.py#L306-L306)\r\n  * [MotherMCHRegister](https://github.com/dimagi/commcare-hq/blob/dedf2496c5e264b78a6a4acaa6c186184cd3159d/custom/bihar/reports/mch_reports.py#L122-L122)\r\n  * [McctProjectReview](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L173-L173)\r\n  * [McctClientApprovalPage](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L279-L279)\r\n  * [McctClientPaymentPage](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L310-L310)\r\n  * [McctRejectedClientPage](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L317-L317)\r\n  * [McctPaidClientsPage](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L461-L461)\r\n  * [McctClientLogPage](https://github.com/dimagi/commcare-hq/blob/fe0ae64358c8a3eece3ab1b164f03b715d11c327/custom/m4change/reports/mcct_project_review.py#L383-L383)\r\n\r\n@snopoke @dannyroberts cc @nickpell \r\n"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments/230426985","html_url":"https://github.com/dimagi/commcare-hq/pull/11776#issuecomment-230426985","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11776","id":230426985,"user":{"login":"sravfeyn","id":829142,"avatar_url":"https://avatars.githubusercontent.com/u/829142?v=3","gravatar_id":"","url":"https://api.github.com/users/sravfeyn","html_url":"https://github.com/sravfeyn","followers_url":"https://api.github.com/users/sravfeyn/followers","following_url":"https://api.github.com/users/sravfeyn/following{/other_user}","gists_url":"https://api.github.com/users/sravfeyn/gists{/gist_id}","starred_url":"https://api.github.com/users/sravfeyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravfeyn/subscriptions","organizations_url":"https://api.github.com/users/sravfeyn/orgs","repos_url":"https://api.github.com/users/sravfeyn/repos","events_url":"https://api.github.com/users/sravfeyn/events{/privacy}","received_events_url":"https://api.github.com/users/sravfeyn/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T09:13:12Z","updated_at":"2016-07-05T09:13:12Z","body":"@kaapstorm \r\nI think this is breaking bunch of things and there seems to be a minor mistake in the assumptions made. I could gather following definitions by reviewing various exports code.\r\n`emailable` - exposes an `Email Report` button on the reports UI bar. This emails the report, not necessarily an excel report.\r\n`exportable` - exposes an 'Export to Excel` button intended to do quick excel export download of the report (not emailed report)\r\n`exportable_all` - this makes `Export to Excel` behaviour an asynchronous task that emails the excel file of all rows (without filters) to the email-address of the WebUser who clicks the button. \r\n\r\nWondering what the intention of this PR is. This PR changed the JS side behaviour of `Export to Excel` but the underlying view is not updated to reflect the same and so `Export to Excel` button is now [not functional](http://manage.dimagi.com/default.asp?231457#1177403) for Reports which have `exportable=True` and `emailable=False`. We should revert this ([PR](https://github.com/dimagi/commcare-hq/pull/12322)) unless there is another bug that we should address. Either way I think we need to look at this more closely"}}
{"actor":{"display_login":"sravfeyn"}}