{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40","id":94527291,"html_url":"https://github.com/weppos/publicsuffix-go/pull/40","diff_url":"https://github.com/weppos/publicsuffix-go/pull/40.diff","patch_url":"https://github.com/weppos/publicsuffix-go/pull/40.patch","issue_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/40","number":40,"state":"closed","locked":false,"title":"Switch the lib to A-labels by default","user":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"body":"Implements the changes described in #31.\r\n\r\nThe internal representation is now expected to be ASCII. The library will also automatically converts parsed lists from Unicode to ASCII, unless the developers knows the input being ASCII (in this case it's possible to disable the conversion to save processing time).\r\n\r\n/cc @jsha @patf @cpu I used the data you provided as test cases, and I should have covered all the needs. Do you mind to review?\r\n\r\nIt should be safe to run the test suite for letsencrypt/boulder#2278 around this branch. Once confirmed, I'll merge this branch to master and release.\r\n","created_at":"2016-11-20T18:33:25Z","updated_at":"2016-11-21T18:19:46Z","closed_at":"2016-11-21T18:19:45Z","merged_at":"2016-11-21T18:19:45Z","merge_commit_sha":"a0d04ffcdbd23477e74e0be938bfc2bab2b986d6","assignee":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"assignees":[{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40/commits","review_comments_url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40/comments","review_comment_url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/40/comments","statuses_url":"https://api.github.com/repos/weppos/publicsuffix-go/statuses/0445958f73b69a0501f7bce8f70529c8ecc8f336","head":{"label":"weppos:idna","ref":"idna","sha":"0445958f73b69a0501f7bce8f70529c8ecc8f336","user":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"repo":{"id":53618789,"name":"publicsuffix-go","full_name":"weppos/publicsuffix-go","owner":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weppos/publicsuffix-go","description":"Domain name parser for Go based on the Public Suffix List.","fork":false,"url":"https://api.github.com/repos/weppos/publicsuffix-go","forks_url":"https://api.github.com/repos/weppos/publicsuffix-go/forks","keys_url":"https://api.github.com/repos/weppos/publicsuffix-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weppos/publicsuffix-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weppos/publicsuffix-go/teams","hooks_url":"https://api.github.com/repos/weppos/publicsuffix-go/hooks","issue_events_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/events{/number}","events_url":"https://api.github.com/repos/weppos/publicsuffix-go/events","assignees_url":"https://api.github.com/repos/weppos/publicsuffix-go/assignees{/user}","branches_url":"https://api.github.com/repos/weppos/publicsuffix-go/branches{/branch}","tags_url":"https://api.github.com/repos/weppos/publicsuffix-go/tags","blobs_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weppos/publicsuffix-go/statuses/{sha}","languages_url":"https://api.github.com/repos/weppos/publicsuffix-go/languages","stargazers_url":"https://api.github.com/repos/weppos/publicsuffix-go/stargazers","contributors_url":"https://api.github.com/repos/weppos/publicsuffix-go/contributors","subscribers_url":"https://api.github.com/repos/weppos/publicsuffix-go/subscribers","subscription_url":"https://api.github.com/repos/weppos/publicsuffix-go/subscription","commits_url":"https://api.github.com/repos/weppos/publicsuffix-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/weppos/publicsuffix-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/weppos/publicsuffix-go/contents/{+path}","compare_url":"https://api.github.com/repos/weppos/publicsuffix-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weppos/publicsuffix-go/merges","archive_url":"https://api.github.com/repos/weppos/publicsuffix-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weppos/publicsuffix-go/downloads","issues_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues{/number}","pulls_url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls{/number}","milestones_url":"https://api.github.com/repos/weppos/publicsuffix-go/milestones{/number}","notifications_url":"https://api.github.com/repos/weppos/publicsuffix-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weppos/publicsuffix-go/labels{/name}","releases_url":"https://api.github.com/repos/weppos/publicsuffix-go/releases{/id}","deployments_url":"https://api.github.com/repos/weppos/publicsuffix-go/deployments","created_at":"2016-03-10T21:36:33Z","updated_at":"2016-11-05T14:51:19Z","pushed_at":"2016-11-21T18:19:45Z","git_url":"git://github.com/weppos/publicsuffix-go.git","ssh_url":"git@github.com:weppos/publicsuffix-go.git","clone_url":"https://github.com/weppos/publicsuffix-go.git","svn_url":"https://github.com/weppos/publicsuffix-go","homepage":"","size":393,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"weppos:master","ref":"master","sha":"ff9c714515f6ae7064b3638ea3bfe7bda164762b","user":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"repo":{"id":53618789,"name":"publicsuffix-go","full_name":"weppos/publicsuffix-go","owner":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weppos/publicsuffix-go","description":"Domain name parser for Go based on the Public Suffix List.","fork":false,"url":"https://api.github.com/repos/weppos/publicsuffix-go","forks_url":"https://api.github.com/repos/weppos/publicsuffix-go/forks","keys_url":"https://api.github.com/repos/weppos/publicsuffix-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weppos/publicsuffix-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weppos/publicsuffix-go/teams","hooks_url":"https://api.github.com/repos/weppos/publicsuffix-go/hooks","issue_events_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/events{/number}","events_url":"https://api.github.com/repos/weppos/publicsuffix-go/events","assignees_url":"https://api.github.com/repos/weppos/publicsuffix-go/assignees{/user}","branches_url":"https://api.github.com/repos/weppos/publicsuffix-go/branches{/branch}","tags_url":"https://api.github.com/repos/weppos/publicsuffix-go/tags","blobs_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weppos/publicsuffix-go/statuses/{sha}","languages_url":"https://api.github.com/repos/weppos/publicsuffix-go/languages","stargazers_url":"https://api.github.com/repos/weppos/publicsuffix-go/stargazers","contributors_url":"https://api.github.com/repos/weppos/publicsuffix-go/contributors","subscribers_url":"https://api.github.com/repos/weppos/publicsuffix-go/subscribers","subscription_url":"https://api.github.com/repos/weppos/publicsuffix-go/subscription","commits_url":"https://api.github.com/repos/weppos/publicsuffix-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/weppos/publicsuffix-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/weppos/publicsuffix-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/weppos/publicsuffix-go/contents/{+path}","compare_url":"https://api.github.com/repos/weppos/publicsuffix-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weppos/publicsuffix-go/merges","archive_url":"https://api.github.com/repos/weppos/publicsuffix-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weppos/publicsuffix-go/downloads","issues_url":"https://api.github.com/repos/weppos/publicsuffix-go/issues{/number}","pulls_url":"https://api.github.com/repos/weppos/publicsuffix-go/pulls{/number}","milestones_url":"https://api.github.com/repos/weppos/publicsuffix-go/milestones{/number}","notifications_url":"https://api.github.com/repos/weppos/publicsuffix-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weppos/publicsuffix-go/labels{/name}","releases_url":"https://api.github.com/repos/weppos/publicsuffix-go/releases{/id}","deployments_url":"https://api.github.com/repos/weppos/publicsuffix-go/deployments","created_at":"2016-03-10T21:36:33Z","updated_at":"2016-11-05T14:51:19Z","pushed_at":"2016-11-21T18:19:45Z","git_url":"git://github.com/weppos/publicsuffix-go.git","ssh_url":"git@github.com:weppos/publicsuffix-go.git","clone_url":"https://github.com/weppos/publicsuffix-go.git","svn_url":"https://github.com/weppos/publicsuffix-go","homepage":"","size":393,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40"},"html":{"href":"https://github.com/weppos/publicsuffix-go/pull/40"},"issue":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/issues/40"},"comments":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/weppos/publicsuffix-go/statuses/0445958f73b69a0501f7bce8f70529c8ecc8f336"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":11,"additions":730,"deletions":491,"changed_files":11}}
{"actor":{"display_login":"weppos"}}