{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/58618579","id":58618579,"diff_hunk":"@@ -292,11 +357,53 @@ case class AlterTableSetFileFormat(\n     genericFormat: Option[String])(sql: String)\n   extends NativeDDLCommand(sql) with Logging\n \n+/**\n+ * A command that sets the location of a table or a partition.\n+ *\n+ * For normal tables, this just sets the location URI in the table/partition's storage format.\n+ * For datasource tables, this sets a \"path\" parameter in the table/partition's serde properties.\n+ *\n+ * The syntax of this command is:\n+ * {{{\n+ *    ALTER TABLE table_name [PARTITION partition_spec] SET LOCATION \"loc\";\n+ * }}}\n+ */\n case class AlterTableSetLocation(\n     tableName: TableIdentifier,\n     partitionSpec: Option[TablePartitionSpec],\n-    location: String)(sql: String)\n-  extends NativeDDLCommand(sql) with Logging\n+    location: String)\n+  extends RunnableCommand {\n+\n+  override def run(sqlContext: SQLContext): Seq[Row] = {\n+    val catalog = sqlContext.sessionState.catalog\n+    val table = catalog.getTable(tableName)\n+    partitionSpec match {\n+      case Some(spec) =>\n+        // Partition spec is specified, so we set the location only for this partition\n+        val part = catalog.getPartition(tableName, spec)\n+        val newPart =\n+          if (DDLUtils.isDatasourceTable(table)) {\n+            part.copy(storage = part.storage.copy(\n+              serdeProperties = part.storage.serdeProperties ++ Map(\"path\" -> location)))\n+          } else {\n+            part.copy(storage = part.storage.copy(locationUri = Some(location)))\n+          }\n+        catalog.alterPartitions(tableName, Seq(newPart))\n+      case None =>\n+        // No partition spec is specified, so we set the location for the table itself\n+        val newTable =\n+          if (DDLUtils.isDatasourceTable(table)) {\n+            table.withNewStorage(\n+              serdeProperties = table.storage.serdeProperties ++ Map(\"path\" -> location))","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala","position":235,"original_position":235,"commit_id":"79c86aa5d31596efe3023886ef04e9b5db6b9a33","original_commit_id":"79c86aa5d31596efe3023886ef04e9b5db6b9a33","user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"body":"`Map(\"path\" -> location)` will overwrite the existing entry in serdeProperties, right?","created_at":"2016-04-05T21:40:15Z","updated_at":"2016-04-05T21:40:15Z","html_url":"https://github.com/apache/spark/pull/12121#discussion_r58618579","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12121","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/58618579"},"html":{"href":"https://github.com/apache/spark/pull/12121#discussion_r58618579"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12121"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12121","id":65017972,"html_url":"https://github.com/apache/spark/pull/12121","diff_url":"https://github.com/apache/spark/pull/12121.diff","patch_url":"https://github.com/apache/spark/pull/12121.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12121","number":12121,"state":"open","locked":false,"title":"[SPARK-14129][SPARK-14128][SQL] Alter table DDL commands","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nIn Spark 2.0, we want to handle the most common `ALTER TABLE` commands ourselves instead of passing the entire query text to Hive. This is done using the new `SessionCatalog` API introduced recently.\r\n\r\nThe commands supported in this patch include:\r\n```\r\nALTER TABLE ... RENAME TO ...\r\nALTER TABLE ... SET TBLPROPERTIES ...\r\nALTER TABLE ... UNSET TBLPROPERTIES ...\r\nALTER TABLE ... SET LOCATION ...\r\nALTER TABLE ... SET SERDE ...\r\n```\r\nThe commands we explicitly do not support are:\r\n```\r\nALTER TABLE ... CLUSTERED BY ...\r\nALTER TABLE ... SKEWED BY ...\r\nALTER TABLE ... NOT CLUSTERED\r\nALTER TABLE ... NOT SORTED\r\nALTER TABLE ... NOT SKEWED\r\nALTER TABLE ... NOT STORED AS DIRECTORIES\r\n```\r\nFor these we throw exceptions complaining that they are not supported.\r\n\r\n## How was this patch tested?\r\n\r\n`DDLSuite`\r\n","created_at":"2016-04-01T23:24:24Z","updated_at":"2016-04-05T21:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78fcfea587f3a456b0d8a0873c6e8bf1559bddca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12121/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12121/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12121/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/79c86aa5d31596efe3023886ef04e9b5db6b9a33","head":{"label":"andrewor14:alter-table-ddl","ref":"alter-table-ddl","sha":"79c86aa5d31596efe3023886ef04e9b5db6b9a33","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"repo":{"id":17231517,"name":"spark","full_name":"andrewor14/spark","owner":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewor14/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/andrewor14/spark","forks_url":"https://api.github.com/repos/andrewor14/spark/forks","keys_url":"https://api.github.com/repos/andrewor14/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewor14/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewor14/spark/teams","hooks_url":"https://api.github.com/repos/andrewor14/spark/hooks","issue_events_url":"https://api.github.com/repos/andrewor14/spark/issues/events{/number}","events_url":"https://api.github.com/repos/andrewor14/spark/events","assignees_url":"https://api.github.com/repos/andrewor14/spark/assignees{/user}","branches_url":"https://api.github.com/repos/andrewor14/spark/branches{/branch}","tags_url":"https://api.github.com/repos/andrewor14/spark/tags","blobs_url":"https://api.github.com/repos/andrewor14/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewor14/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewor14/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewor14/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewor14/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewor14/spark/languages","stargazers_url":"https://api.github.com/repos/andrewor14/spark/stargazers","contributors_url":"https://api.github.com/repos/andrewor14/spark/contributors","subscribers_url":"https://api.github.com/repos/andrewor14/spark/subscribers","subscription_url":"https://api.github.com/repos/andrewor14/spark/subscription","commits_url":"https://api.github.com/repos/andrewor14/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewor14/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewor14/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewor14/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewor14/spark/contents/{+path}","compare_url":"https://api.github.com/repos/andrewor14/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewor14/spark/merges","archive_url":"https://api.github.com/repos/andrewor14/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewor14/spark/downloads","issues_url":"https://api.github.com/repos/andrewor14/spark/issues{/number}","pulls_url":"https://api.github.com/repos/andrewor14/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewor14/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewor14/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewor14/spark/labels{/name}","releases_url":"https://api.github.com/repos/andrewor14/spark/releases{/id}","deployments_url":"https://api.github.com/repos/andrewor14/spark/deployments","created_at":"2014-02-27T00:52:37Z","updated_at":"2015-05-08T06:53:12Z","pushed_at":"2016-04-05T19:38:46Z","git_url":"git://github.com/andrewor14/spark.git","ssh_url":"git@github.com:andrewor14/spark.git","clone_url":"https://github.com/andrewor14/spark.git","svn_url":"https://github.com/andrewor14/spark","homepage":null,"size":165041,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"72544d6f2a72b9e44e0a32de1fb379e3342be5c3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-04-05T21:18:44Z","pushed_at":"2016-04-05T20:31:18Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":452334,"stargazers_count":8025,"watchers_count":8025,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7424,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":424,"forks":7424,"open_issues":424,"watchers":8025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12121"},"html":{"href":"https://github.com/apache/spark/pull/12121"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12121"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12121/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12121/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12121/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/79c86aa5d31596efe3023886ef04e9b5db6b9a33"}}}}