{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/62521015","id":62521015,"diff_hunk":"@@ -116,9 +116,11 @@ def previous_event_frame(events_by_sid,\n     next_date_frame\n     \"\"\"\n     sids = list(events_by_sid)\n+    populate_value = None if field_dtype == categorical_dtype else \\","path":"zipline/pipeline/loaders/utils.py","position":13,"original_position":13,"commit_id":"623e9406e81769fffe5f63b3375e9eecc46e8dcd","original_commit_id":"623e9406e81769fffe5f63b3375e9eecc46e8dcd","user":{"login":"mtydykov","id":5226409,"avatar_url":"https://avatars.githubusercontent.com/u/5226409?v=3","gravatar_id":"","url":"https://api.github.com/users/mtydykov","html_url":"https://github.com/mtydykov","followers_url":"https://api.github.com/users/mtydykov/followers","following_url":"https://api.github.com/users/mtydykov/following{/other_user}","gists_url":"https://api.github.com/users/mtydykov/gists{/gist_id}","starred_url":"https://api.github.com/users/mtydykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtydykov/subscriptions","organizations_url":"https://api.github.com/users/mtydykov/orgs","repos_url":"https://api.github.com/users/mtydykov/repos","events_url":"https://api.github.com/users/mtydykov/events{/privacy}","received_events_url":"https://api.github.com/users/mtydykov/received_events","type":"User","site_admin":false},"body":"Basically, we were using the `missing_value` of columns before in order to populate the array with default values; we can't do this with categoricals because the current design is such that they don't have a default missing value, so we have to explicitly check if the field is a categorical, and if so, here we can just use `None` as the missing value.","created_at":"2016-05-09T15:39:33Z","updated_at":"2016-05-09T15:39:33Z","html_url":"https://github.com/quantopian/zipline/pull/1185#discussion_r62521015","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/1185","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/62521015"},"html":{"href":"https://github.com/quantopian/zipline/pull/1185#discussion_r62521015"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1185"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/1185","id":69055176,"html_url":"https://github.com/quantopian/zipline/pull/1185","diff_url":"https://github.com/quantopian/zipline/pull/1185.diff","patch_url":"https://github.com/quantopian/zipline/pull/1185.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/1185","number":1185,"state":"open","locked":false,"title":"Redesign buyback auth","user":{"login":"mtydykov","id":5226409,"avatar_url":"https://avatars.githubusercontent.com/u/5226409?v=3","gravatar_id":"","url":"https://api.github.com/users/mtydykov","html_url":"https://github.com/mtydykov","followers_url":"https://api.github.com/users/mtydykov/followers","following_url":"https://api.github.com/users/mtydykov/following{/other_user}","gists_url":"https://api.github.com/users/mtydykov/gists{/gist_id}","starred_url":"https://api.github.com/users/mtydykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtydykov/subscriptions","organizations_url":"https://api.github.com/users/mtydykov/orgs","repos_url":"https://api.github.com/users/mtydykov/repos","events_url":"https://api.github.com/users/mtydykov/events{/privacy}","received_events_url":"https://api.github.com/users/mtydykov/received_events","type":"User","site_admin":false},"body":"Replaces Cash/Share buyback auth custom datasets with a single BuybackAuthorizations dataset and modifies tests accordingly.","created_at":"2016-05-05T19:16:29Z","updated_at":"2016-05-09T15:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92d05ae6f3f827ec59510f12224fd3505cf61e32","assignee":{"login":"kglowinski","id":7389388,"avatar_url":"https://avatars.githubusercontent.com/u/7389388?v=3","gravatar_id":"","url":"https://api.github.com/users/kglowinski","html_url":"https://github.com/kglowinski","followers_url":"https://api.github.com/users/kglowinski/followers","following_url":"https://api.github.com/users/kglowinski/following{/other_user}","gists_url":"https://api.github.com/users/kglowinski/gists{/gist_id}","starred_url":"https://api.github.com/users/kglowinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kglowinski/subscriptions","organizations_url":"https://api.github.com/users/kglowinski/orgs","repos_url":"https://api.github.com/users/kglowinski/repos","events_url":"https://api.github.com/users/kglowinski/events{/privacy}","received_events_url":"https://api.github.com/users/kglowinski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/1185/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/1185/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/1185/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/623e9406e81769fffe5f63b3375e9eecc46e8dcd","head":{"label":"quantopian:redesign-buyback-auth","ref":"redesign-buyback-auth","sha":"623e9406e81769fffe5f63b3375e9eecc46e8dcd","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-05-09T08:05:30Z","pushed_at":"2016-05-09T14:19:22Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":43790,"stargazers_count":3174,"watchers_count":3174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":957,"mirror_url":null,"open_issues_count":145,"forks":957,"open_issues":145,"watchers":3174,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"69972992c09c23a1e3412a46b5ba06738b535bd6","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-05-09T08:05:30Z","pushed_at":"2016-05-09T14:19:22Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":43790,"stargazers_count":3174,"watchers_count":3174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":957,"mirror_url":null,"open_issues_count":145,"forks":957,"open_issues":145,"watchers":3174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1185"},"html":{"href":"https://github.com/quantopian/zipline/pull/1185"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1185"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1185/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1185/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1185/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/623e9406e81769fffe5f63b3375e9eecc46e8dcd"}}}}