{"action":"created","issue":{"url":"https://api.github.com/repos/graspit-simulator/graspit/issues/30","repository_url":"https://api.github.com/repos/graspit-simulator/graspit","labels_url":"https://api.github.com/repos/graspit-simulator/graspit/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/graspit-simulator/graspit/issues/30/comments","events_url":"https://api.github.com/repos/graspit-simulator/graspit/issues/30/events","html_url":"https://github.com/graspit-simulator/graspit/pull/30","id":146754384,"number":30,"title":"Tactile","user":{"login":"jvarley","id":1675542,"avatar_url":"https://avatars.githubusercontent.com/u/1675542?v=3","gravatar_id":"","url":"https://api.github.com/users/jvarley","html_url":"https://github.com/jvarley","followers_url":"https://api.github.com/users/jvarley/followers","following_url":"https://api.github.com/users/jvarley/following{/other_user}","gists_url":"https://api.github.com/users/jvarley/gists{/gist_id}","starred_url":"https://api.github.com/users/jvarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvarley/subscriptions","organizations_url":"https://api.github.com/users/jvarley/orgs","repos_url":"https://api.github.com/users/jvarley/repos","events_url":"https://api.github.com/users/jvarley/events{/privacy}","received_events_url":"https://api.github.com/users/jvarley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-07T21:59:01Z","updated_at":"2016-06-16T21:06:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graspit-simulator/graspit/pulls/30","html_url":"https://github.com/graspit-simulator/graspit/pull/30","diff_url":"https://github.com/graspit-simulator/graspit/pull/30.diff","patch_url":"https://github.com/graspit-simulator/graspit/pull/30.patch"},"body":"This is not ready to be pulled in.  I thought I would put this here so others can see it/contribute. I did not write most of it."},"comment":{"url":"https://api.github.com/repos/graspit-simulator/graspit/issues/comments/226613824","html_url":"https://github.com/graspit-simulator/graspit/pull/30#issuecomment-226613824","issue_url":"https://api.github.com/repos/graspit-simulator/graspit/issues/30","id":226613824,"user":{"login":"mateiciocarlie","id":2230382,"avatar_url":"https://avatars.githubusercontent.com/u/2230382?v=3","gravatar_id":"","url":"https://api.github.com/users/mateiciocarlie","html_url":"https://github.com/mateiciocarlie","followers_url":"https://api.github.com/users/mateiciocarlie/followers","following_url":"https://api.github.com/users/mateiciocarlie/following{/other_user}","gists_url":"https://api.github.com/users/mateiciocarlie/gists{/gist_id}","starred_url":"https://api.github.com/users/mateiciocarlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateiciocarlie/subscriptions","organizations_url":"https://api.github.com/users/mateiciocarlie/orgs","repos_url":"https://api.github.com/users/mateiciocarlie/repos","events_url":"https://api.github.com/users/mateiciocarlie/events{/privacy}","received_events_url":"https://api.github.com/users/mateiciocarlie/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T21:06:05Z","updated_at":"2016-06-16T21:06:05Z","body":"This is now much much easier to parse, but that does highlight some issues...\r\n\r\nThe additions in here do not adhere to the style conventions. Member variables are not marked (lowercase m before the name in the rest of the codebase). There is no doxygen-style documentation - in the rest of the codebase (as much as we could) all variables and functions are documented, and classes have fairly extensive design explanations in the documentation. The new classes here have none of that. That makes it very hard to understand various issues, including why we need a new type of Link, what are the new variables added to the Contact class, what are the changes made to the soft contact fitting, etc. Changes to the Link hierarchy or the Contact class are fundamental enough that they should be well documented, and we should be sure of the necessity. \r\n\r\nThis is change goes deep enough that I would really like the style and documentation to be there, which will also make it a lot easier to understand what is going on."}}
{"actor":{"display_login":"mateiciocarlie"}}