{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/60632593","id":60632593,"diff_hunk":"@@ -24,7 +22,7 @@ module.exports = class ServicesList extends List {\n \n     if (filters) {\n       if (filters.ids) {\n-        services = _.filter(services, function (service) {\n+        services = services.filter(function (service) {\n           return this.ids.indexOf(service.id) !== -1;\n         }, {ids: filters.ids});","path":"src/js/structs/ServicesList.js","position":13,"original_position":13,"commit_id":"4f165d990aff3e8ab56321ab52f352422324d7c4","original_commit_id":"358849c9c2bc8586d2d8c1f0f775b99313ab0523","user":{"login":"daiyiwhale","id":1589186,"avatar_url":"https://avatars.githubusercontent.com/u/1589186?v=3","gravatar_id":"","url":"https://api.github.com/users/daiyiwhale","html_url":"https://github.com/daiyiwhale","followers_url":"https://api.github.com/users/daiyiwhale/followers","following_url":"https://api.github.com/users/daiyiwhale/following{/other_user}","gists_url":"https://api.github.com/users/daiyiwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/daiyiwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daiyiwhale/subscriptions","organizations_url":"https://api.github.com/users/daiyiwhale/orgs","repos_url":"https://api.github.com/users/daiyiwhale/repos","events_url":"https://api.github.com/users/daiyiwhale/events{/privacy}","received_events_url":"https://api.github.com/users/daiyiwhale/received_events","type":"User","site_admin":false},"body":"oh hm, why was it necessary to make `{ids: filters.ids}` the context? can we call `filters.ids` directly (`filters.ids.indexOf(service.id) !== -1`)?","created_at":"2016-04-21T18:32:19Z","updated_at":"2016-04-21T18:32:19Z","html_url":"https://github.com/dcos/dcos-ui/pull/7#discussion_r60632593","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/60632593"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/7#discussion_r60632593"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/7","id":66942186,"html_url":"https://github.com/dcos/dcos-ui/pull/7","diff_url":"https://github.com/dcos/dcos-ui/pull/7.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/7.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/7","number":7,"state":"open","locked":false,"title":"Remove Underscore [1 of 2]","user":{"login":"daiyiwhale","id":1589186,"avatar_url":"https://avatars.githubusercontent.com/u/1589186?v=3","gravatar_id":"","url":"https://api.github.com/users/daiyiwhale","html_url":"https://github.com/daiyiwhale","followers_url":"https://api.github.com/users/daiyiwhale/followers","following_url":"https://api.github.com/users/daiyiwhale/following{/other_user}","gists_url":"https://api.github.com/users/daiyiwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/daiyiwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daiyiwhale/subscriptions","organizations_url":"https://api.github.com/users/daiyiwhale/orgs","repos_url":"https://api.github.com/users/daiyiwhale/repos","events_url":"https://api.github.com/users/daiyiwhale/events{/privacy}","received_events_url":"https://api.github.com/users/daiyiwhale/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-19T00:10:23Z","updated_at":"2016-04-21T18:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ee111e987ff815d3fd279a1839897a31bd55c76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/7/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/7/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/7/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/4f165d990aff3e8ab56321ab52f352422324d7c4","head":{"label":"dcos:feature/DCOS-5886-underscore","ref":"feature/DCOS-5886-underscore","sha":"4f165d990aff3e8ab56321ab52f352422324d7c4","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-04-21T13:58:04Z","pushed_at":"2016-04-21T18:24:10Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":11249,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":17,"forks":5,"open_issues":17,"watchers":47,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"fb17574224ef1974a6928a93cfcc8c6c4c05ebcb","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-04-21T13:58:04Z","pushed_at":"2016-04-21T18:24:10Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":11249,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":17,"forks":5,"open_issues":17,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/7"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/7"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/7"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/4f165d990aff3e8ab56321ab52f352422324d7c4"}}}}