{"action":"created","issue":{"url":"https://api.github.com/repos/j-e-k/poketrainer/issues/496","repository_url":"https://api.github.com/repos/j-e-k/poketrainer","labels_url":"https://api.github.com/repos/j-e-k/poketrainer/issues/496/labels{/name}","comments_url":"https://api.github.com/repos/j-e-k/poketrainer/issues/496/comments","events_url":"https://api.github.com/repos/j-e-k/poketrainer/issues/496/events","html_url":"https://github.com/j-e-k/poketrainer/pull/496","id":170554961,"number":496,"title":"consistently use \"new-style\" classes","user":{"login":"infinitewarp","id":1472326,"avatar_url":"https://avatars.githubusercontent.com/u/1472326?v=3","gravatar_id":"","url":"https://api.github.com/users/infinitewarp","html_url":"https://github.com/infinitewarp","followers_url":"https://api.github.com/users/infinitewarp/followers","following_url":"https://api.github.com/users/infinitewarp/following{/other_user}","gists_url":"https://api.github.com/users/infinitewarp/gists{/gist_id}","starred_url":"https://api.github.com/users/infinitewarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinitewarp/subscriptions","organizations_url":"https://api.github.com/users/infinitewarp/orgs","repos_url":"https://api.github.com/users/infinitewarp/repos","events_url":"https://api.github.com/users/infinitewarp/events{/privacy}","received_events_url":"https://api.github.com/users/infinitewarp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-11T01:34:27Z","updated_at":"2016-08-11T22:25:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/j-e-k/poketrainer/pulls/496","html_url":"https://github.com/j-e-k/poketrainer/pull/496","diff_url":"https://github.com/j-e-k/poketrainer/pull/496.diff","patch_url":"https://github.com/j-e-k/poketrainer/pull/496.patch"},"body":"I'm kind of surprised we have such an odd mix of old-style and new-style Python classes.\r\n\r\n(I hesitate to say \"new-style\" since they've been the norm for ages. 😛)\r\n\r\nThere only immediate benefit to the switch is than consistency across the code (some classes already extend `object` or an ancestor of it) and Python versions (Python 3 *always* uses new-style classes). Using new-style classes could enable us to do some funky metaclass programming, even though that's probably not likely here.\r\n\r\nAny objections?"},"comment":{"url":"https://api.github.com/repos/j-e-k/poketrainer/issues/comments/239312280","html_url":"https://github.com/j-e-k/poketrainer/pull/496#issuecomment-239312280","issue_url":"https://api.github.com/repos/j-e-k/poketrainer/issues/496","id":239312280,"user":{"login":"rirze","id":3255334,"avatar_url":"https://avatars.githubusercontent.com/u/3255334?v=3","gravatar_id":"","url":"https://api.github.com/users/rirze","html_url":"https://github.com/rirze","followers_url":"https://api.github.com/users/rirze/followers","following_url":"https://api.github.com/users/rirze/following{/other_user}","gists_url":"https://api.github.com/users/rirze/gists{/gist_id}","starred_url":"https://api.github.com/users/rirze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rirze/subscriptions","organizations_url":"https://api.github.com/users/rirze/orgs","repos_url":"https://api.github.com/users/rirze/repos","events_url":"https://api.github.com/users/rirze/events{/privacy}","received_events_url":"https://api.github.com/users/rirze/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T22:25:56Z","updated_at":"2016-08-11T22:25:56Z","body":"Is there anything holding back this PR? I personally, am for this change and would like to see the convention used in the code :)"}}
{"actor":{"display_login":"rirze"}}