{"action":"created","issue":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1488","repository_url":"https://api.github.com/repos/moneyadviceservice/frontend","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1488/labels{/name}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1488/comments","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1488/events","html_url":"https://github.com/moneyadviceservice/frontend/pull/1488","id":166073360,"number":1488,"title":"7440 - Null image ALT attributes","user":{"login":"johnplayer1982","id":13165846,"avatar_url":"https://avatars.githubusercontent.com/u/13165846?v=3","gravatar_id":"","url":"https://api.github.com/users/johnplayer1982","html_url":"https://github.com/johnplayer1982","followers_url":"https://api.github.com/users/johnplayer1982/followers","following_url":"https://api.github.com/users/johnplayer1982/following{/other_user}","gists_url":"https://api.github.com/users/johnplayer1982/gists{/gist_id}","starred_url":"https://api.github.com/users/johnplayer1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnplayer1982/subscriptions","organizations_url":"https://api.github.com/users/johnplayer1982/orgs","repos_url":"https://api.github.com/users/johnplayer1982/repos","events_url":"https://api.github.com/users/johnplayer1982/events{/privacy}","received_events_url":"https://api.github.com/users/johnplayer1982/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-18T11:31:17Z","updated_at":"2016-07-18T12:19:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1488","html_url":"https://github.com/moneyadviceservice/frontend/pull/1488","diff_url":"https://github.com/moneyadviceservice/frontend/pull/1488.diff","patch_url":"https://github.com/moneyadviceservice/frontend/pull/1488.patch"},"body":"## The issue\r\n\r\nThe DAC report highlights that images on the following page contain descriptive alt attributes:\r\nhttps://www.moneyadviceservice.org.uk/en/pensions-and-retirement/pension-savings-timeline\r\nhere https://www.moneyadviceservice.org.uk/en/pensions-and-retirement\r\n\r\nHowever due to accessibility requirements it is necessary to have a null alt attribute.\r\n\r\n## The solution\r\n\r\nThe solution was to remove the alt attributes for the images from the yaml files (en|cy) and update the rails image_tag helper to use a null alt attribute like so:\r\n\r\n```\r\n<%= image_tag \"retirement_concepts/in-retirement@2x.png\", alt: '' %>\r\n```\r\nWhich results in the output:\r\n```\r\n<img alt=\"\" src=\"/assets/retirement_concepts/in-retirement@2x.png\">\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/moneyadviceservice/frontend/1488)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments/233313038","html_url":"https://github.com/moneyadviceservice/frontend/pull/1488#issuecomment-233313038","issue_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1488","id":233313038,"user":{"login":"slaywell","id":14920201,"avatar_url":"https://avatars.githubusercontent.com/u/14920201?v=3","gravatar_id":"","url":"https://api.github.com/users/slaywell","html_url":"https://github.com/slaywell","followers_url":"https://api.github.com/users/slaywell/followers","following_url":"https://api.github.com/users/slaywell/following{/other_user}","gists_url":"https://api.github.com/users/slaywell/gists{/gist_id}","starred_url":"https://api.github.com/users/slaywell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaywell/subscriptions","organizations_url":"https://api.github.com/users/slaywell/orgs","repos_url":"https://api.github.com/users/slaywell/repos","events_url":"https://api.github.com/users/slaywell/events{/privacy}","received_events_url":"https://api.github.com/users/slaywell/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T12:19:57Z","updated_at":"2016-07-18T12:19:57Z","body":"👍 Checked locally, looks good!"}}
{"actor":{"display_login":"slaywell"}}