{"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48","id":66186171,"html_url":"https://github.com/Utopia1138/Design-Patterns-Training/pull/48","diff_url":"https://github.com/Utopia1138/Design-Patterns-Training/pull/48.diff","patch_url":"https://github.com/Utopia1138/Design-Patterns-Training/pull/48.patch","issue_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/48","number":48,"state":"open","locked":false,"title":"axp - Chapter 3 - The Template Method Pattern","user":{"login":"a-panayotopoulos","id":9415893,"avatar_url":"https://avatars.githubusercontent.com/u/9415893?v=3","gravatar_id":"","url":"https://api.github.com/users/a-panayotopoulos","html_url":"https://github.com/a-panayotopoulos","followers_url":"https://api.github.com/users/a-panayotopoulos/followers","following_url":"https://api.github.com/users/a-panayotopoulos/following{/other_user}","gists_url":"https://api.github.com/users/a-panayotopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/a-panayotopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-panayotopoulos/subscriptions","organizations_url":"https://api.github.com/users/a-panayotopoulos/orgs","repos_url":"https://api.github.com/users/a-panayotopoulos/repos","events_url":"https://api.github.com/users/a-panayotopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/a-panayotopoulos/received_events","type":"User","site_admin":false},"body":"I had what seemed at the time to be a wonderful idea to write the main DPG processing loop as a template method `processTransaction`, with different acquirers implementing their own validation, message-building, and response generation sub-methods. In practice, I got bogged down in details (notably, XML processing).\r\n\r\nBy the time I actually got round to implementing acquirers, I realised that the entire architecture of this solution seemed a bit poorly designed. So all I've really got is a \"no-op acquirer\" which just accepts everything. Nevertheless, it is an example of a template method pattern, even if it doesn't really make much sense in practice.","created_at":"2016-04-12T16:18:04Z","updated_at":"2016-04-12T16:18:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48/commits","review_comments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48/comments","review_comment_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/48/comments","statuses_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/statuses/2e4fd849cb570c070b651608d9d60b686c337d3a","head":{"label":"Utopia1138:axp_chapter08","ref":"axp_chapter08","sha":"2e4fd849cb570c070b651608d9d60b686c337d3a","user":{"login":"Utopia1138","id":2646781,"avatar_url":"https://avatars.githubusercontent.com/u/2646781?v=3","gravatar_id":"","url":"https://api.github.com/users/Utopia1138","html_url":"https://github.com/Utopia1138","followers_url":"https://api.github.com/users/Utopia1138/followers","following_url":"https://api.github.com/users/Utopia1138/following{/other_user}","gists_url":"https://api.github.com/users/Utopia1138/gists{/gist_id}","starred_url":"https://api.github.com/users/Utopia1138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utopia1138/subscriptions","organizations_url":"https://api.github.com/users/Utopia1138/orgs","repos_url":"https://api.github.com/users/Utopia1138/repos","events_url":"https://api.github.com/users/Utopia1138/events{/privacy}","received_events_url":"https://api.github.com/users/Utopia1138/received_events","type":"User","site_admin":false},"repo":{"id":45832227,"name":"Design-Patterns-Training","full_name":"Utopia1138/Design-Patterns-Training","owner":{"login":"Utopia1138","id":2646781,"avatar_url":"https://avatars.githubusercontent.com/u/2646781?v=3","gravatar_id":"","url":"https://api.github.com/users/Utopia1138","html_url":"https://github.com/Utopia1138","followers_url":"https://api.github.com/users/Utopia1138/followers","following_url":"https://api.github.com/users/Utopia1138/following{/other_user}","gists_url":"https://api.github.com/users/Utopia1138/gists{/gist_id}","starred_url":"https://api.github.com/users/Utopia1138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utopia1138/subscriptions","organizations_url":"https://api.github.com/users/Utopia1138/orgs","repos_url":"https://api.github.com/users/Utopia1138/repos","events_url":"https://api.github.com/users/Utopia1138/events{/privacy}","received_events_url":"https://api.github.com/users/Utopia1138/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Utopia1138/Design-Patterns-Training","description":"Training group for the Head First Design Patterns book","fork":false,"url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training","forks_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/forks","keys_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/teams","hooks_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/hooks","issue_events_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/events{/number}","events_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/events","assignees_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/assignees{/user}","branches_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/branches{/branch}","tags_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/tags","blobs_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/refs{/sha}","trees_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/statuses/{sha}","languages_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/languages","stargazers_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/stargazers","contributors_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/contributors","subscribers_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/subscribers","subscription_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/subscription","commits_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/commits{/sha}","git_commits_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/commits{/sha}","comments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/comments{/number}","issue_comment_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/comments{/number}","contents_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/contents/{+path}","compare_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/merges","archive_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/downloads","issues_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues{/number}","pulls_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls{/number}","milestones_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/milestones{/number}","notifications_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/labels{/name}","releases_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/releases{/id}","deployments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/deployments","created_at":"2015-11-09T10:50:44Z","updated_at":"2016-02-10T16:27:45Z","pushed_at":"2016-04-12T16:18:04Z","git_url":"git://github.com/Utopia1138/Design-Patterns-Training.git","ssh_url":"git@github.com:Utopia1138/Design-Patterns-Training.git","clone_url":"https://github.com/Utopia1138/Design-Patterns-Training.git","svn_url":"https://github.com/Utopia1138/Design-Patterns-Training","homepage":null,"size":4291,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Utopia1138:master","ref":"master","sha":"19012cb23a51eab3ba2a0342825f0ebf7f69f108","user":{"login":"Utopia1138","id":2646781,"avatar_url":"https://avatars.githubusercontent.com/u/2646781?v=3","gravatar_id":"","url":"https://api.github.com/users/Utopia1138","html_url":"https://github.com/Utopia1138","followers_url":"https://api.github.com/users/Utopia1138/followers","following_url":"https://api.github.com/users/Utopia1138/following{/other_user}","gists_url":"https://api.github.com/users/Utopia1138/gists{/gist_id}","starred_url":"https://api.github.com/users/Utopia1138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utopia1138/subscriptions","organizations_url":"https://api.github.com/users/Utopia1138/orgs","repos_url":"https://api.github.com/users/Utopia1138/repos","events_url":"https://api.github.com/users/Utopia1138/events{/privacy}","received_events_url":"https://api.github.com/users/Utopia1138/received_events","type":"User","site_admin":false},"repo":{"id":45832227,"name":"Design-Patterns-Training","full_name":"Utopia1138/Design-Patterns-Training","owner":{"login":"Utopia1138","id":2646781,"avatar_url":"https://avatars.githubusercontent.com/u/2646781?v=3","gravatar_id":"","url":"https://api.github.com/users/Utopia1138","html_url":"https://github.com/Utopia1138","followers_url":"https://api.github.com/users/Utopia1138/followers","following_url":"https://api.github.com/users/Utopia1138/following{/other_user}","gists_url":"https://api.github.com/users/Utopia1138/gists{/gist_id}","starred_url":"https://api.github.com/users/Utopia1138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utopia1138/subscriptions","organizations_url":"https://api.github.com/users/Utopia1138/orgs","repos_url":"https://api.github.com/users/Utopia1138/repos","events_url":"https://api.github.com/users/Utopia1138/events{/privacy}","received_events_url":"https://api.github.com/users/Utopia1138/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Utopia1138/Design-Patterns-Training","description":"Training group for the Head First Design Patterns book","fork":false,"url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training","forks_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/forks","keys_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/teams","hooks_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/hooks","issue_events_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/events{/number}","events_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/events","assignees_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/assignees{/user}","branches_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/branches{/branch}","tags_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/tags","blobs_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/refs{/sha}","trees_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/statuses/{sha}","languages_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/languages","stargazers_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/stargazers","contributors_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/contributors","subscribers_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/subscribers","subscription_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/subscription","commits_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/commits{/sha}","git_commits_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/git/commits{/sha}","comments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/comments{/number}","issue_comment_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/comments{/number}","contents_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/contents/{+path}","compare_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/merges","archive_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/downloads","issues_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues{/number}","pulls_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls{/number}","milestones_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/milestones{/number}","notifications_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/labels{/name}","releases_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/releases{/id}","deployments_url":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/deployments","created_at":"2015-11-09T10:50:44Z","updated_at":"2016-02-10T16:27:45Z","pushed_at":"2016-04-12T16:18:04Z","git_url":"git://github.com/Utopia1138/Design-Patterns-Training.git","ssh_url":"git@github.com:Utopia1138/Design-Patterns-Training.git","clone_url":"https://github.com/Utopia1138/Design-Patterns-Training.git","svn_url":"https://github.com/Utopia1138/Design-Patterns-Training","homepage":null,"size":4291,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48"},"html":{"href":"https://github.com/Utopia1138/Design-Patterns-Training/pull/48"},"issue":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/48"},"comments":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/Utopia1138/Design-Patterns-Training/statuses/2e4fd849cb570c070b651608d9d60b686c337d3a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":345,"deletions":0,"changed_files":6}}