{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-templates/pulls/comments/61749387","id":61749387,"diff_hunk":"@@ -672,6 +630,48 @@\n           </execution>\n         </executions>\n       </plugin>\n+            <plugin>","path":"pom.xml","position":56,"original_position":56,"commit_id":"43600dc266a854df335240af38544b0fb6907ec7","original_commit_id":"43600dc266a854df335240af38544b0fb6907ec7","user":{"login":"sparhami","id":1410321,"avatar_url":"https://avatars.githubusercontent.com/u/1410321?v=3","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"body":"Indentation off here.\r\n\r\nAlso - did the order of these need to change? Makes the diff larger and harder to read.","created_at":"2016-05-02T14:55:48Z","updated_at":"2016-05-02T14:55:48Z","html_url":"https://github.com/google/closure-templates/pull/86#discussion_r61749387","pull_request_url":"https://api.github.com/repos/google/closure-templates/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/google/closure-templates/pulls/comments/61749387"},"html":{"href":"https://github.com/google/closure-templates/pull/86#discussion_r61749387"},"pull_request":{"href":"https://api.github.com/repos/google/closure-templates/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-templates/pulls/86","id":64104231,"html_url":"https://github.com/google/closure-templates/pull/86","diff_url":"https://github.com/google/closure-templates/pull/86.diff","patch_url":"https://github.com/google/closure-templates/pull/86.patch","issue_url":"https://api.github.com/repos/google/closure-templates/issues/86","number":86,"state":"open","locked":false,"title":"fix the build","user":{"login":"jmhodges","id":598,"avatar_url":"https://avatars.githubusercontent.com/u/598?v=3","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"body":"mvn install fails locally and in travis with this, but it gets the build closer.  I'll need the closure team's help to figure out the rest.\r\n\r\nAfter the changes discussed below, we get down to the Enforcer plugin isn't able to find files in target/examples directory and there are suspicious looking Soy errors in the test logs.\r\n\r\nI'm at a loss.\r\n\r\nWhat's been done so far:\r\n\r\n  * bump the .travis.yml JVM to JDK8 closure-template's pom.xml requires JDK8 (see the \"1.8\" in it).\r\n    Unfortunately, OpenJDK 8 is not supported on TravisCI yet, so we have to switch to the Oracle JDK.\r\n\r\n  * fix #46, the maven-compiler-plugin bug, by bumping to a working version of maven-compiler-plugin.\r\n\r\nThe build failures on this PR are the bug left to be fixed before the build goes green.","created_at":"2016-03-24T21:49:23Z","updated_at":"2016-05-02T14:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"452f360a2a301e72ce3f063fe781467c31a17ccd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-templates/pulls/86/commits","review_comments_url":"https://api.github.com/repos/google/closure-templates/pulls/86/comments","review_comment_url":"https://api.github.com/repos/google/closure-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-templates/issues/86/comments","statuses_url":"https://api.github.com/repos/google/closure-templates/statuses/43600dc266a854df335240af38544b0fb6907ec7","head":{"label":"jmhodges:fix_build","ref":"fix_build","sha":"43600dc266a854df335240af38544b0fb6907ec7","user":{"login":"jmhodges","id":598,"avatar_url":"https://avatars.githubusercontent.com/u/598?v=3","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"repo":{"id":38975440,"name":"closure-templates","full_name":"jmhodges/closure-templates","owner":{"login":"jmhodges","id":598,"avatar_url":"https://avatars.githubusercontent.com/u/598?v=3","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmhodges/closure-templates","description":"A client- and server-side templating system that helps you dynamically build reusable HTML and UI elements","fork":true,"url":"https://api.github.com/repos/jmhodges/closure-templates","forks_url":"https://api.github.com/repos/jmhodges/closure-templates/forks","keys_url":"https://api.github.com/repos/jmhodges/closure-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmhodges/closure-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmhodges/closure-templates/teams","hooks_url":"https://api.github.com/repos/jmhodges/closure-templates/hooks","issue_events_url":"https://api.github.com/repos/jmhodges/closure-templates/issues/events{/number}","events_url":"https://api.github.com/repos/jmhodges/closure-templates/events","assignees_url":"https://api.github.com/repos/jmhodges/closure-templates/assignees{/user}","branches_url":"https://api.github.com/repos/jmhodges/closure-templates/branches{/branch}","tags_url":"https://api.github.com/repos/jmhodges/closure-templates/tags","blobs_url":"https://api.github.com/repos/jmhodges/closure-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmhodges/closure-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmhodges/closure-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmhodges/closure-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmhodges/closure-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/jmhodges/closure-templates/languages","stargazers_url":"https://api.github.com/repos/jmhodges/closure-templates/stargazers","contributors_url":"https://api.github.com/repos/jmhodges/closure-templates/contributors","subscribers_url":"https://api.github.com/repos/jmhodges/closure-templates/subscribers","subscription_url":"https://api.github.com/repos/jmhodges/closure-templates/subscription","commits_url":"https://api.github.com/repos/jmhodges/closure-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmhodges/closure-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmhodges/closure-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmhodges/closure-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmhodges/closure-templates/contents/{+path}","compare_url":"https://api.github.com/repos/jmhodges/closure-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmhodges/closure-templates/merges","archive_url":"https://api.github.com/repos/jmhodges/closure-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmhodges/closure-templates/downloads","issues_url":"https://api.github.com/repos/jmhodges/closure-templates/issues{/number}","pulls_url":"https://api.github.com/repos/jmhodges/closure-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/jmhodges/closure-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/jmhodges/closure-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmhodges/closure-templates/labels{/name}","releases_url":"https://api.github.com/repos/jmhodges/closure-templates/releases{/id}","deployments_url":"https://api.github.com/repos/jmhodges/closure-templates/deployments","created_at":"2015-07-12T19:45:46Z","updated_at":"2015-07-12T19:45:49Z","pushed_at":"2016-03-24T22:04:06Z","git_url":"git://github.com/jmhodges/closure-templates.git","ssh_url":"git@github.com:jmhodges/closure-templates.git","clone_url":"https://github.com/jmhodges/closure-templates.git","svn_url":"https://github.com/jmhodges/closure-templates","homepage":"","size":48042,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d2fbc7041ae7ee603d70a023369e2b99959e1a47","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845068,"name":"closure-templates","full_name":"google/closure-templates","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-templates","description":"A client- and server-side templating system that helps you dynamically build reusable HTML and UI elements","fork":false,"url":"https://api.github.com/repos/google/closure-templates","forks_url":"https://api.github.com/repos/google/closure-templates/forks","keys_url":"https://api.github.com/repos/google/closure-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-templates/teams","hooks_url":"https://api.github.com/repos/google/closure-templates/hooks","issue_events_url":"https://api.github.com/repos/google/closure-templates/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-templates/events","assignees_url":"https://api.github.com/repos/google/closure-templates/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-templates/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-templates/tags","blobs_url":"https://api.github.com/repos/google/closure-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-templates/languages","stargazers_url":"https://api.github.com/repos/google/closure-templates/stargazers","contributors_url":"https://api.github.com/repos/google/closure-templates/contributors","subscribers_url":"https://api.github.com/repos/google/closure-templates/subscribers","subscription_url":"https://api.github.com/repos/google/closure-templates/subscription","commits_url":"https://api.github.com/repos/google/closure-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-templates/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-templates/merges","archive_url":"https://api.github.com/repos/google/closure-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-templates/downloads","issues_url":"https://api.github.com/repos/google/closure-templates/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-templates/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-templates/releases{/id}","deployments_url":"https://api.github.com/repos/google/closure-templates/deployments","created_at":"2014-04-16T15:31:58Z","updated_at":"2016-04-29T15:50:59Z","pushed_at":"2016-04-14T11:46:18Z","git_url":"git://github.com/google/closure-templates.git","ssh_url":"git@github.com:google/closure-templates.git","clone_url":"https://github.com/google/closure-templates.git","svn_url":"https://github.com/google/closure-templates","homepage":"","size":50151,"stargazers_count":233,"watchers_count":233,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":56,"forks":70,"open_issues":56,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-templates/pulls/86"},"html":{"href":"https://github.com/google/closure-templates/pull/86"},"issue":{"href":"https://api.github.com/repos/google/closure-templates/issues/86"},"comments":{"href":"https://api.github.com/repos/google/closure-templates/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-templates/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-templates/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-templates/statuses/43600dc266a854df335240af38544b0fb6907ec7"}}}}