{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/48908039","id":48908039,"diff_hunk":"@@ -123,11 +133,12 @@ def main():\n     module = AnsibleModule(\n         argument_spec=dict(\n             vg=dict(required=True),\n-            lv=dict(required=True),\n+            lv=dict(type='str'),","path":"system/lvol.py","position":29,"original_position":29,"commit_id":"f8166184bf4a0a2417a47b45c8d7c35b2b852ce2","original_commit_id":"f8166184bf4a0a2417a47b45c8d7c35b2b852ce2","user":{"login":"mscherer","id":230335,"avatar_url":"https://avatars.githubusercontent.com/u/230335?v=3","gravatar_id":"","url":"https://api.github.com/users/mscherer","html_url":"https://github.com/mscherer","followers_url":"https://api.github.com/users/mscherer/followers","following_url":"https://api.github.com/users/mscherer/following{/other_user}","gists_url":"https://api.github.com/users/mscherer/gists{/gist_id}","starred_url":"https://api.github.com/users/mscherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscherer/subscriptions","organizations_url":"https://api.github.com/users/mscherer/orgs","repos_url":"https://api.github.com/users/mscherer/repos","events_url":"https://api.github.com/users/mscherer/events{/privacy}","received_events_url":"https://api.github.com/users/mscherer/received_events","type":"User","site_admin":false},"body":"If the argument is no longer required, the doc (line 39) should be changed too.","created_at":"2016-01-05T22:54:35Z","updated_at":"2016-01-05T22:54:35Z","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1422#discussion_r48908039","pull_request_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/48908039"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/1422#discussion_r48908039"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422","id":54529871,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/1422","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/1422.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/1422.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1422","number":1422,"state":"open","locked":false,"title":"add a functionality to lvol module, to create thin pool / volume on Linux LVM","user":{"login":"KlabKatsumi","id":3508844,"avatar_url":"https://avatars.githubusercontent.com/u/3508844?v=3","gravatar_id":"","url":"https://api.github.com/users/KlabKatsumi","html_url":"https://github.com/KlabKatsumi","followers_url":"https://api.github.com/users/KlabKatsumi/followers","following_url":"https://api.github.com/users/KlabKatsumi/following{/other_user}","gists_url":"https://api.github.com/users/KlabKatsumi/gists{/gist_id}","starred_url":"https://api.github.com/users/KlabKatsumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlabKatsumi/subscriptions","organizations_url":"https://api.github.com/users/KlabKatsumi/orgs","repos_url":"https://api.github.com/users/KlabKatsumi/repos","events_url":"https://api.github.com/users/KlabKatsumi/events{/privacy}","received_events_url":"https://api.github.com/users/KlabKatsumi/received_events","type":"User","site_admin":false},"body":"On Linux's LVM, thin provisioned volume is supported.\r\n\r\nThis PR add functionality to create thin pool / volume on Linux's LVM to lvol module.\r\n\r\nLinux LVM's thin provisioning volume operation is described here:\r\nhttps://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Logical_Volume_Manager_Administration/thinly_provisioned_volume_creation.html\r\n\r\n===================================================================\r\n\r\nadd `thinpool' parameter.\r\nchange `lv' parameter to not required.\r\n\r\nTo create thin poll, specify `thinpool'(, `vg' and `size') parameter and omit `lv' parameter.\r\nIt will create thin pool, nameed by `thinpool' parameter.\r\n\r\nTo create thin volume, specify both `thinpool' and `lv' parameter (also `vg' and `size' paramter is need).\r\nIt will create thin volume on `thinpool' pool, named by `lv' parameter.\r\n\r\nThin volume and pool can delete whith 'state=absent' parameter.\r\nThin volume is resizable like normal volume.\r\nThin pool can extend, but not reduce. This limitation is in Linux's LVM.\r\n\r\n=============================================================================","created_at":"2015-12-24T06:21:40Z","updated_at":"2016-01-05T22:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada09aff0b9b7b117e966f1db057ffa2081c934e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1422/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/f8166184bf4a0a2417a47b45c8d7c35b2b852ce2","head":{"label":"KlabKatsumi:lvol_functionality_to_create_thin_volume","ref":"lvol_functionality_to_create_thin_volume","sha":"f8166184bf4a0a2417a47b45c8d7c35b2b852ce2","user":{"login":"KlabKatsumi","id":3508844,"avatar_url":"https://avatars.githubusercontent.com/u/3508844?v=3","gravatar_id":"","url":"https://api.github.com/users/KlabKatsumi","html_url":"https://github.com/KlabKatsumi","followers_url":"https://api.github.com/users/KlabKatsumi/followers","following_url":"https://api.github.com/users/KlabKatsumi/following{/other_user}","gists_url":"https://api.github.com/users/KlabKatsumi/gists{/gist_id}","starred_url":"https://api.github.com/users/KlabKatsumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlabKatsumi/subscriptions","organizations_url":"https://api.github.com/users/KlabKatsumi/orgs","repos_url":"https://api.github.com/users/KlabKatsumi/repos","events_url":"https://api.github.com/users/KlabKatsumi/events{/privacy}","received_events_url":"https://api.github.com/users/KlabKatsumi/received_events","type":"User","site_admin":false},"repo":{"id":48426897,"name":"ansible-modules-extras","full_name":"KlabKatsumi/ansible-modules-extras","owner":{"login":"KlabKatsumi","id":3508844,"avatar_url":"https://avatars.githubusercontent.com/u/3508844?v=3","gravatar_id":"","url":"https://api.github.com/users/KlabKatsumi","html_url":"https://github.com/KlabKatsumi","followers_url":"https://api.github.com/users/KlabKatsumi/followers","following_url":"https://api.github.com/users/KlabKatsumi/following{/other_user}","gists_url":"https://api.github.com/users/KlabKatsumi/gists{/gist_id}","starred_url":"https://api.github.com/users/KlabKatsumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlabKatsumi/subscriptions","organizations_url":"https://api.github.com/users/KlabKatsumi/orgs","repos_url":"https://api.github.com/users/KlabKatsumi/repos","events_url":"https://api.github.com/users/KlabKatsumi/events{/privacy}","received_events_url":"https://api.github.com/users/KlabKatsumi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KlabKatsumi/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras","forks_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/KlabKatsumi/ansible-modules-extras/releases{/id}","created_at":"2015-12-22T10:54:06Z","updated_at":"2015-12-22T10:54:08Z","pushed_at":"2015-12-24T06:13:18Z","git_url":"git://github.com/KlabKatsumi/ansible-modules-extras.git","ssh_url":"git@github.com:KlabKatsumi/ansible-modules-extras.git","clone_url":"https://github.com/KlabKatsumi/ansible-modules-extras.git","svn_url":"https://github.com/KlabKatsumi/ansible-modules-extras","homepage":"","size":8144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"19e496c69c22fc7ec1e3c8306b363a812b85d386","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","created_at":"2014-09-25T20:28:42Z","updated_at":"2016-01-03T23:06:03Z","pushed_at":"2016-01-05T21:50:08Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":10445,"stargazers_count":426,"watchers_count":426,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":884,"mirror_url":null,"open_issues_count":397,"forks":884,"open_issues":397,"watchers":426,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/1422"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1422"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1422/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1422/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/f8166184bf4a0a2417a47b45c8d7c35b2b852ce2"}}}}