{"action":"created","comment":{"url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/comments/63545728","id":63545728,"diff_hunk":"@@ -48,54 +50,60 @@ using namespace NsSmartDeviceLink::NsJSONHandler::Formatters;\n TEST(CFormatterJsonBaseTest, JSonStringValueToSmartObj_ExpectSuccessful) {\n   // Arrange value\n   std::string string_val(\"test_string\");\n-  Json::Value json_value(string_val);  // Json value from string\n+  utils::json::JsonValue json_value(string_val);\n   SmartObject object;\n   // Convert json to smart object\n-  CFormatterJsonBase::jsonValueToObj(json_value, object);\n+  utils::json::JsonValueRef json_value_ref = json_value;\n+ \n+  CFormatterJsonBase::jsonValueToObj(json_value_ref, object);\n   // Check conversion was successful\n   EXPECT_EQ(string_val, object.asString());\n }\n \n TEST(CFormatterJsonBaseTest, JSonDoubleValueToSmartObj_ExpectSuccessful) {\n   // Arrange value\n   double dval = 3.512;\n-  Json::Value json_value(dval);  // Json value from double\n+  utils::json::JsonValue json_value(dval);\n   SmartObject object;\n   // Convert json to smart object\n-  CFormatterJsonBase::jsonValueToObj(json_value, object);\n+  utils::json::JsonValueRef json_value_ref = json_value;\n+  CFormatterJsonBase::jsonValueToObj(json_value_ref, object);\n   // Check conversion was successful\n   EXPECT_DOUBLE_EQ(dval, object.asDouble());\n }\n \n TEST(CFormatterJsonBaseTest, JSonMinIntValueToSmartObj_ExpectSuccessful) {\n   // Arrange value\n   Json::Int ival = Json::Value::minInt;\n-  Json::Value json_value(ival);  // Json value from possible minimum signed int\n+  utils::json::JsonValue json_value(static_cast<long long int>(ival));","path":"src/components/formatters/test/CFormatterJsonBase_test.cc","position":48,"original_position":48,"commit_id":"c325fa0c1995cac87efc057ffa8b321123766db7","original_commit_id":"c325fa0c1995cac87efc057ffa8b321123766db7","user":{"login":"OHerasym","id":3297812,"avatar_url":"https://avatars.githubusercontent.com/u/3297812?v=3","gravatar_id":"","url":"https://api.github.com/users/OHerasym","html_url":"https://github.com/OHerasym","followers_url":"https://api.github.com/users/OHerasym/followers","following_url":"https://api.github.com/users/OHerasym/following{/other_user}","gists_url":"https://api.github.com/users/OHerasym/gists{/gist_id}","starred_url":"https://api.github.com/users/OHerasym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHerasym/subscriptions","organizations_url":"https://api.github.com/users/OHerasym/orgs","repos_url":"https://api.github.com/users/OHerasym/repos","events_url":"https://api.github.com/users/OHerasym/events{/privacy}","received_events_url":"https://api.github.com/users/OHerasym/received_events","type":"User","site_admin":false},"body":"@dev-gh , in this case will be ambiguous function call. Tried uint64_t / int64_t","created_at":"2016-05-17T15:33:46Z","updated_at":"2016-05-17T15:33:46Z","html_url":"https://github.com/anosach-luxoft/sdl_core/pull/17#discussion_r63545728","pull_request_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/comments/63545728"},"html":{"href":"https://github.com/anosach-luxoft/sdl_core/pull/17#discussion_r63545728"},"pull_request":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17","id":70209848,"html_url":"https://github.com/anosach-luxoft/sdl_core/pull/17","diff_url":"https://github.com/anosach-luxoft/sdl_core/pull/17.diff","patch_url":"https://github.com/anosach-luxoft/sdl_core/pull/17.patch","issue_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/17","number":17,"state":"open","locked":false,"title":"Sdl winport merge to develop with tests (part1)","user":{"login":"OHerasym","id":3297812,"avatar_url":"https://avatars.githubusercontent.com/u/3297812?v=3","gravatar_id":"","url":"https://api.github.com/users/OHerasym","html_url":"https://github.com/OHerasym","followers_url":"https://api.github.com/users/OHerasym/followers","following_url":"https://api.github.com/users/OHerasym/following{/other_user}","gists_url":"https://api.github.com/users/OHerasym/gists{/gist_id}","starred_url":"https://api.github.com/users/OHerasym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHerasym/subscriptions","organizations_url":"https://api.github.com/users/OHerasym/orgs","repos_url":"https://api.github.com/users/OHerasym/repos","events_url":"https://api.github.com/users/OHerasym/events{/privacy}","received_events_url":"https://api.github.com/users/OHerasym/received_events","type":"User","site_admin":false},"body":"Fix windows build gmock\r\nFix utils unit tests\r\nFix application manager unit tests\r\nFix formatters unit tests","created_at":"2016-05-16T15:05:20Z","updated_at":"2016-05-17T15:33:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c108f18bd2e310cef1441e4d0cc3a37bc0cf31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17/commits","review_comments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17/comments","review_comment_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/17/comments","statuses_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/statuses/c325fa0c1995cac87efc057ffa8b321123766db7","head":{"label":"OHerasym:sdl_winport_merge_to_develop_with_tests_q","ref":"sdl_winport_merge_to_develop_with_tests_q","sha":"c325fa0c1995cac87efc057ffa8b321123766db7","user":{"login":"OHerasym","id":3297812,"avatar_url":"https://avatars.githubusercontent.com/u/3297812?v=3","gravatar_id":"","url":"https://api.github.com/users/OHerasym","html_url":"https://github.com/OHerasym","followers_url":"https://api.github.com/users/OHerasym/followers","following_url":"https://api.github.com/users/OHerasym/following{/other_user}","gists_url":"https://api.github.com/users/OHerasym/gists{/gist_id}","starred_url":"https://api.github.com/users/OHerasym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHerasym/subscriptions","organizations_url":"https://api.github.com/users/OHerasym/orgs","repos_url":"https://api.github.com/users/OHerasym/repos","events_url":"https://api.github.com/users/OHerasym/events{/privacy}","received_events_url":"https://api.github.com/users/OHerasym/received_events","type":"User","site_admin":false},"repo":{"id":54541867,"name":"sdl_core","full_name":"OHerasym/sdl_core","owner":{"login":"OHerasym","id":3297812,"avatar_url":"https://avatars.githubusercontent.com/u/3297812?v=3","gravatar_id":"","url":"https://api.github.com/users/OHerasym","html_url":"https://github.com/OHerasym","followers_url":"https://api.github.com/users/OHerasym/followers","following_url":"https://api.github.com/users/OHerasym/following{/other_user}","gists_url":"https://api.github.com/users/OHerasym/gists{/gist_id}","starred_url":"https://api.github.com/users/OHerasym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHerasym/subscriptions","organizations_url":"https://api.github.com/users/OHerasym/orgs","repos_url":"https://api.github.com/users/OHerasym/repos","events_url":"https://api.github.com/users/OHerasym/events{/privacy}","received_events_url":"https://api.github.com/users/OHerasym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OHerasym/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/OHerasym/sdl_core","forks_url":"https://api.github.com/repos/OHerasym/sdl_core/forks","keys_url":"https://api.github.com/repos/OHerasym/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OHerasym/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OHerasym/sdl_core/teams","hooks_url":"https://api.github.com/repos/OHerasym/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/OHerasym/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/OHerasym/sdl_core/events","assignees_url":"https://api.github.com/repos/OHerasym/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/OHerasym/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/OHerasym/sdl_core/tags","blobs_url":"https://api.github.com/repos/OHerasym/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OHerasym/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OHerasym/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OHerasym/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OHerasym/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/OHerasym/sdl_core/languages","stargazers_url":"https://api.github.com/repos/OHerasym/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/OHerasym/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/OHerasym/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/OHerasym/sdl_core/subscription","commits_url":"https://api.github.com/repos/OHerasym/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OHerasym/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OHerasym/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OHerasym/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OHerasym/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/OHerasym/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OHerasym/sdl_core/merges","archive_url":"https://api.github.com/repos/OHerasym/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OHerasym/sdl_core/downloads","issues_url":"https://api.github.com/repos/OHerasym/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/OHerasym/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/OHerasym/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/OHerasym/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OHerasym/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/OHerasym/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/OHerasym/sdl_core/deployments","created_at":"2016-03-23T08:09:56Z","updated_at":"2016-03-23T08:10:04Z","pushed_at":"2016-05-17T14:52:40Z","git_url":"git://github.com/OHerasym/sdl_core.git","ssh_url":"git@github.com:OHerasym/sdl_core.git","clone_url":"https://github.com/OHerasym/sdl_core.git","svn_url":"https://github.com/OHerasym/sdl_core","homepage":"","size":171862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anosach-luxoft:feature/stable-backmerge-build","ref":"feature/stable-backmerge-build","sha":"81fde1c230901735d4c1d6e5e466220c20a5dfe1","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"repo":{"id":54954583,"name":"sdl_core","full_name":"anosach-luxoft/sdl_core","owner":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anosach-luxoft/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/anosach-luxoft/sdl_core","forks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/forks","keys_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/teams","hooks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/events","assignees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/tags","blobs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/languages","stargazers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/subscription","commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/merges","archive_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/downloads","issues_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core/deployments","created_at":"2016-03-29T07:20:11Z","updated_at":"2016-03-29T07:20:19Z","pushed_at":"2016-05-17T14:56:41Z","git_url":"git://github.com/anosach-luxoft/sdl_core.git","ssh_url":"git@github.com:anosach-luxoft/sdl_core.git","clone_url":"https://github.com/anosach-luxoft/sdl_core.git","svn_url":"https://github.com/anosach-luxoft/sdl_core","homepage":"","size":171786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17"},"html":{"href":"https://github.com/anosach-luxoft/sdl_core/pull/17"},"issue":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/17"},"comments":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/anosach-luxoft/sdl_core/statuses/c325fa0c1995cac87efc057ffa8b321123766db7"}}}}