{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/67321218","id":67321218,"diff_hunk":"@@ -430,6 +430,14 @@ def test_replace(self):\n         result = values.str.replace(\"(?<=\\w),(?=\\w)\", \", \", flags=re.UNICODE)\n         tm.assert_series_equal(result, exp)\n \n+        # Cases for 13438\n+        with self.assertRaises(ValueError):\n+            values = Series(['a', 'b', None])\n+            values.str.replace('a', None)\n+        with self.assertRaises(ValueError):","path":"pandas/tests/test_strings.py","position":8,"original_position":8,"commit_id":"8f2ad765c025225f45e3a725edb2b92167eebc3b","original_commit_id":"8f2ad765c025225f45e3a725edb2b92167eebc3b","user":{"login":"sinhrks","id":1696302,"avatar_url":"https://avatars.githubusercontent.com/u/1696302?v=3","gravatar_id":"","url":"https://api.github.com/users/sinhrks","html_url":"https://github.com/sinhrks","followers_url":"https://api.github.com/users/sinhrks/followers","following_url":"https://api.github.com/users/sinhrks/following{/other_user}","gists_url":"https://api.github.com/users/sinhrks/gists{/gist_id}","starred_url":"https://api.github.com/users/sinhrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinhrks/subscriptions","organizations_url":"https://api.github.com/users/sinhrks/orgs","repos_url":"https://api.github.com/users/sinhrks/repos","events_url":"https://api.github.com/users/sinhrks/events{/privacy}","received_events_url":"https://api.github.com/users/sinhrks/received_events","type":"User","site_admin":false},"body":"can u add tests with other invalid, like numeric.","created_at":"2016-06-16T10:22:30Z","updated_at":"2016-06-16T10:22:30Z","html_url":"https://github.com/pydata/pandas/pull/13460#discussion_r67321218","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/13460","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/67321218"},"html":{"href":"https://github.com/pydata/pandas/pull/13460#discussion_r67321218"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13460"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13460","id":74048405,"html_url":"https://github.com/pydata/pandas/pull/13460","diff_url":"https://github.com/pydata/pandas/pull/13460.diff","patch_url":"https://github.com/pydata/pandas/pull/13460.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13460","number":13460,"state":"open","locked":false,"title":"BUG: Fix for .str.replace with invalid input","user":{"login":"priyankjain","id":4019056,"avatar_url":"https://avatars.githubusercontent.com/u/4019056?v=3","gravatar_id":"","url":"https://api.github.com/users/priyankjain","html_url":"https://github.com/priyankjain","followers_url":"https://api.github.com/users/priyankjain/followers","following_url":"https://api.github.com/users/priyankjain/following{/other_user}","gists_url":"https://api.github.com/users/priyankjain/gists{/gist_id}","starred_url":"https://api.github.com/users/priyankjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyankjain/subscriptions","organizations_url":"https://api.github.com/users/priyankjain/orgs","repos_url":"https://api.github.com/users/priyankjain/repos","events_url":"https://api.github.com/users/priyankjain/events{/privacy}","received_events_url":"https://api.github.com/users/priyankjain/received_events","type":"User","site_admin":false},"body":" - [x] closes #13438\r\n - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n\r\n.str.replace now raises ValueError when replacement string is None","created_at":"2016-06-16T09:26:20Z","updated_at":"2016-06-16T10:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd369f4e8f8b62339d2718d3155c06295a43b43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/13460/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/13460/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13460/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/8f2ad765c025225f45e3a725edb2b92167eebc3b","head":{"label":"priyankjain:13438","ref":"13438","sha":"8f2ad765c025225f45e3a725edb2b92167eebc3b","user":{"login":"priyankjain","id":4019056,"avatar_url":"https://avatars.githubusercontent.com/u/4019056?v=3","gravatar_id":"","url":"https://api.github.com/users/priyankjain","html_url":"https://github.com/priyankjain","followers_url":"https://api.github.com/users/priyankjain/followers","following_url":"https://api.github.com/users/priyankjain/following{/other_user}","gists_url":"https://api.github.com/users/priyankjain/gists{/gist_id}","starred_url":"https://api.github.com/users/priyankjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyankjain/subscriptions","organizations_url":"https://api.github.com/users/priyankjain/orgs","repos_url":"https://api.github.com/users/priyankjain/repos","events_url":"https://api.github.com/users/priyankjain/events{/privacy}","received_events_url":"https://api.github.com/users/priyankjain/received_events","type":"User","site_admin":false},"repo":{"id":60608303,"name":"pandas","full_name":"priyankjain/pandas","owner":{"login":"priyankjain","id":4019056,"avatar_url":"https://avatars.githubusercontent.com/u/4019056?v=3","gravatar_id":"","url":"https://api.github.com/users/priyankjain","html_url":"https://github.com/priyankjain","followers_url":"https://api.github.com/users/priyankjain/followers","following_url":"https://api.github.com/users/priyankjain/following{/other_user}","gists_url":"https://api.github.com/users/priyankjain/gists{/gist_id}","starred_url":"https://api.github.com/users/priyankjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyankjain/subscriptions","organizations_url":"https://api.github.com/users/priyankjain/orgs","repos_url":"https://api.github.com/users/priyankjain/repos","events_url":"https://api.github.com/users/priyankjain/events{/privacy}","received_events_url":"https://api.github.com/users/priyankjain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priyankjain/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/priyankjain/pandas","forks_url":"https://api.github.com/repos/priyankjain/pandas/forks","keys_url":"https://api.github.com/repos/priyankjain/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priyankjain/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priyankjain/pandas/teams","hooks_url":"https://api.github.com/repos/priyankjain/pandas/hooks","issue_events_url":"https://api.github.com/repos/priyankjain/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/priyankjain/pandas/events","assignees_url":"https://api.github.com/repos/priyankjain/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/priyankjain/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/priyankjain/pandas/tags","blobs_url":"https://api.github.com/repos/priyankjain/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priyankjain/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priyankjain/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/priyankjain/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priyankjain/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/priyankjain/pandas/languages","stargazers_url":"https://api.github.com/repos/priyankjain/pandas/stargazers","contributors_url":"https://api.github.com/repos/priyankjain/pandas/contributors","subscribers_url":"https://api.github.com/repos/priyankjain/pandas/subscribers","subscription_url":"https://api.github.com/repos/priyankjain/pandas/subscription","commits_url":"https://api.github.com/repos/priyankjain/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/priyankjain/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/priyankjain/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/priyankjain/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/priyankjain/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/priyankjain/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priyankjain/pandas/merges","archive_url":"https://api.github.com/repos/priyankjain/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priyankjain/pandas/downloads","issues_url":"https://api.github.com/repos/priyankjain/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/priyankjain/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/priyankjain/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/priyankjain/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priyankjain/pandas/labels{/name}","releases_url":"https://api.github.com/repos/priyankjain/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/priyankjain/pandas/deployments","created_at":"2016-06-07T11:33:50Z","updated_at":"2016-06-07T11:33:56Z","pushed_at":"2016-06-16T09:27:33Z","git_url":"git://github.com/priyankjain/pandas.git","ssh_url":"git@github.com:priyankjain/pandas.git","clone_url":"https://github.com/priyankjain/pandas.git","svn_url":"https://github.com/priyankjain/pandas","homepage":"http://pandas.pydata.org","size":80871,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"f7528866e07048f051f46f621ca76947730c7d32","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-06-15T16:45:03Z","pushed_at":"2016-06-16T09:27:34Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":149885,"stargazers_count":6459,"watchers_count":6459,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2662,"mirror_url":null,"open_issues_count":1787,"forks":2662,"open_issues":1787,"watchers":6459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13460"},"html":{"href":"https://github.com/pydata/pandas/pull/13460"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/13460"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/13460/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13460/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13460/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/8f2ad765c025225f45e3a725edb2b92167eebc3b"}}}}
{"actor":{"display_login":"sinhrks"}}