{"action":"created","comment":{"url":"https://api.github.com/repos/DlangScience/mir/pulls/comments/59725617","id":59725617,"diff_hunk":"@@ -1686,12 +1686,12 @@ template IotaSlice(size_t N)\n \n // undocumented\n // zero cost variant of `std.range.iota`\n-struct IotaMap()\n+private struct IotaMap()","path":"source/mir/ndslice/selection.d","position":63,"original_position":63,"commit_id":"5599748ffa41849159834ff4600b66b629faa229","original_commit_id":"5599748ffa41849159834ff4600b66b629faa229","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"public method without documentation should be set to private or protected","created_at":"2016-04-14T14:21:52Z","updated_at":"2016-04-14T14:21:52Z","html_url":"https://github.com/DlangScience/mir/pull/88#discussion_r59725617","pull_request_url":"https://api.github.com/repos/DlangScience/mir/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/comments/59725617"},"html":{"href":"https://github.com/DlangScience/mir/pull/88#discussion_r59725617"},"pull_request":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/DlangScience/mir/pulls/88","id":66431740,"html_url":"https://github.com/DlangScience/mir/pull/88","diff_url":"https://github.com/DlangScience/mir/pull/88.diff","patch_url":"https://github.com/DlangScience/mir/pull/88.patch","issue_url":"https://api.github.com/repos/DlangScience/mir/issues/88","number":88,"state":"open","locked":false,"title":"add linting via dscanner","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"I think we should try putting the linting off to a real bot.\r\nThis PR adds a execution of [dscanner](https://github.com/Hackerpilot/Dscanner).\r\n\r\nWe probably want to play with this for a while, maybe disable some checks or fix the codebase until we set the `--enforce` flag, which will exit the CI with an error.\r\nCurrently it outputs many messages, see e.g. [here](https://travis-ci.org/wilzbach/mir/jobs/122970079)\r\n\r\nOther\r\n- It is only run on travis subbuild - hence the version check (I reused it for the s3 check)\r\n- As there is no binary release of dscanner, I created `releases.dlang.io` (a s3 bucket to which I will upload such release) - this speeds up the build! Otherwise there is still dub fetch & dub run.","created_at":"2016-04-14T05:45:19Z","updated_at":"2016-04-14T14:21:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a99e2a654b57ee1ce1f33067e637dbc31c2bcb4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DlangScience/mir/pulls/88/commits","review_comments_url":"https://api.github.com/repos/DlangScience/mir/pulls/88/comments","review_comment_url":"https://api.github.com/repos/DlangScience/mir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DlangScience/mir/issues/88/comments","statuses_url":"https://api.github.com/repos/DlangScience/mir/statuses/5599748ffa41849159834ff4600b66b629faa229","head":{"label":"wilzbach:dscanner","ref":"dscanner","sha":"5599748ffa41849159834ff4600b66b629faa229","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"repo":{"id":53214767,"name":"mir","full_name":"wilzbach/mir","owner":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilzbach/mir","description":"Generic Numeric Library","fork":true,"url":"https://api.github.com/repos/wilzbach/mir","forks_url":"https://api.github.com/repos/wilzbach/mir/forks","keys_url":"https://api.github.com/repos/wilzbach/mir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilzbach/mir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilzbach/mir/teams","hooks_url":"https://api.github.com/repos/wilzbach/mir/hooks","issue_events_url":"https://api.github.com/repos/wilzbach/mir/issues/events{/number}","events_url":"https://api.github.com/repos/wilzbach/mir/events","assignees_url":"https://api.github.com/repos/wilzbach/mir/assignees{/user}","branches_url":"https://api.github.com/repos/wilzbach/mir/branches{/branch}","tags_url":"https://api.github.com/repos/wilzbach/mir/tags","blobs_url":"https://api.github.com/repos/wilzbach/mir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilzbach/mir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilzbach/mir/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilzbach/mir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilzbach/mir/statuses/{sha}","languages_url":"https://api.github.com/repos/wilzbach/mir/languages","stargazers_url":"https://api.github.com/repos/wilzbach/mir/stargazers","contributors_url":"https://api.github.com/repos/wilzbach/mir/contributors","subscribers_url":"https://api.github.com/repos/wilzbach/mir/subscribers","subscription_url":"https://api.github.com/repos/wilzbach/mir/subscription","commits_url":"https://api.github.com/repos/wilzbach/mir/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilzbach/mir/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilzbach/mir/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilzbach/mir/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilzbach/mir/contents/{+path}","compare_url":"https://api.github.com/repos/wilzbach/mir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilzbach/mir/merges","archive_url":"https://api.github.com/repos/wilzbach/mir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilzbach/mir/downloads","issues_url":"https://api.github.com/repos/wilzbach/mir/issues{/number}","pulls_url":"https://api.github.com/repos/wilzbach/mir/pulls{/number}","milestones_url":"https://api.github.com/repos/wilzbach/mir/milestones{/number}","notifications_url":"https://api.github.com/repos/wilzbach/mir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilzbach/mir/labels{/name}","releases_url":"https://api.github.com/repos/wilzbach/mir/releases{/id}","deployments_url":"https://api.github.com/repos/wilzbach/mir/deployments","created_at":"2016-03-05T17:50:27Z","updated_at":"2016-04-07T18:31:16Z","pushed_at":"2016-04-14T14:04:47Z","git_url":"git://github.com/wilzbach/mir.git","ssh_url":"git@github.com:wilzbach/mir.git","clone_url":"https://github.com/wilzbach/mir.git","svn_url":"https://github.com/wilzbach/mir","homepage":"","size":318,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DlangScience:master","ref":"master","sha":"cf218645bfb5b146100384b193cc95ccf30c0fc7","user":{"login":"DlangScience","id":12515762,"avatar_url":"https://avatars.githubusercontent.com/u/12515762?v=3","gravatar_id":"","url":"https://api.github.com/users/DlangScience","html_url":"https://github.com/DlangScience","followers_url":"https://api.github.com/users/DlangScience/followers","following_url":"https://api.github.com/users/DlangScience/following{/other_user}","gists_url":"https://api.github.com/users/DlangScience/gists{/gist_id}","starred_url":"https://api.github.com/users/DlangScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DlangScience/subscriptions","organizations_url":"https://api.github.com/users/DlangScience/orgs","repos_url":"https://api.github.com/users/DlangScience/repos","events_url":"https://api.github.com/users/DlangScience/events{/privacy}","received_events_url":"https://api.github.com/users/DlangScience/received_events","type":"Organization","site_admin":false},"repo":{"id":37379986,"name":"mir","full_name":"DlangScience/mir","owner":{"login":"DlangScience","id":12515762,"avatar_url":"https://avatars.githubusercontent.com/u/12515762?v=3","gravatar_id":"","url":"https://api.github.com/users/DlangScience","html_url":"https://github.com/DlangScience","followers_url":"https://api.github.com/users/DlangScience/followers","following_url":"https://api.github.com/users/DlangScience/following{/other_user}","gists_url":"https://api.github.com/users/DlangScience/gists{/gist_id}","starred_url":"https://api.github.com/users/DlangScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DlangScience/subscriptions","organizations_url":"https://api.github.com/users/DlangScience/orgs","repos_url":"https://api.github.com/users/DlangScience/repos","events_url":"https://api.github.com/users/DlangScience/events{/privacy}","received_events_url":"https://api.github.com/users/DlangScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DlangScience/mir","description":"Generic Numeric Library","fork":false,"url":"https://api.github.com/repos/DlangScience/mir","forks_url":"https://api.github.com/repos/DlangScience/mir/forks","keys_url":"https://api.github.com/repos/DlangScience/mir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DlangScience/mir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DlangScience/mir/teams","hooks_url":"https://api.github.com/repos/DlangScience/mir/hooks","issue_events_url":"https://api.github.com/repos/DlangScience/mir/issues/events{/number}","events_url":"https://api.github.com/repos/DlangScience/mir/events","assignees_url":"https://api.github.com/repos/DlangScience/mir/assignees{/user}","branches_url":"https://api.github.com/repos/DlangScience/mir/branches{/branch}","tags_url":"https://api.github.com/repos/DlangScience/mir/tags","blobs_url":"https://api.github.com/repos/DlangScience/mir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DlangScience/mir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DlangScience/mir/git/refs{/sha}","trees_url":"https://api.github.com/repos/DlangScience/mir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DlangScience/mir/statuses/{sha}","languages_url":"https://api.github.com/repos/DlangScience/mir/languages","stargazers_url":"https://api.github.com/repos/DlangScience/mir/stargazers","contributors_url":"https://api.github.com/repos/DlangScience/mir/contributors","subscribers_url":"https://api.github.com/repos/DlangScience/mir/subscribers","subscription_url":"https://api.github.com/repos/DlangScience/mir/subscription","commits_url":"https://api.github.com/repos/DlangScience/mir/commits{/sha}","git_commits_url":"https://api.github.com/repos/DlangScience/mir/git/commits{/sha}","comments_url":"https://api.github.com/repos/DlangScience/mir/comments{/number}","issue_comment_url":"https://api.github.com/repos/DlangScience/mir/issues/comments{/number}","contents_url":"https://api.github.com/repos/DlangScience/mir/contents/{+path}","compare_url":"https://api.github.com/repos/DlangScience/mir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DlangScience/mir/merges","archive_url":"https://api.github.com/repos/DlangScience/mir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DlangScience/mir/downloads","issues_url":"https://api.github.com/repos/DlangScience/mir/issues{/number}","pulls_url":"https://api.github.com/repos/DlangScience/mir/pulls{/number}","milestones_url":"https://api.github.com/repos/DlangScience/mir/milestones{/number}","notifications_url":"https://api.github.com/repos/DlangScience/mir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DlangScience/mir/labels{/name}","releases_url":"https://api.github.com/repos/DlangScience/mir/releases{/id}","deployments_url":"https://api.github.com/repos/DlangScience/mir/deployments","created_at":"2015-06-13T16:59:39Z","updated_at":"2016-04-12T12:13:15Z","pushed_at":"2016-04-14T14:04:47Z","git_url":"git://github.com/DlangScience/mir.git","ssh_url":"git@github.com:DlangScience/mir.git","clone_url":"https://github.com/DlangScience/mir.git","svn_url":"https://github.com/DlangScience/mir","homepage":"http://mir.dlang.io","size":323,"stargazers_count":18,"watchers_count":18,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/88"},"html":{"href":"https://github.com/DlangScience/mir/pull/88"},"issue":{"href":"https://api.github.com/repos/DlangScience/mir/issues/88"},"comments":{"href":"https://api.github.com/repos/DlangScience/mir/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DlangScience/mir/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/DlangScience/mir/statuses/5599748ffa41849159834ff4600b66b629faa229"}}}}