{"action":"created","comment":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/71188777","id":71188777,"diff_hunk":"@@ -653,6 +653,38 @@ ruleTester.run('jsx-closing-bracket-location', rule, {\n     }]\n   }, {\n     code: [\n+      'const Button = function(props) {',\n+      '  return (',\n+      '    <Button',\n+      '      size={size}',\n+      '      onClick={onClick}',\n+      '                                    >',\n+      '      Button Text',\n+      '    </Button>',\n+      '  );',\n+      '};'\n+    ].join('\\n'),\n+    output: [\n+      'const Button = function(props) {',\n+      '  return (',\n+      '    <Button',\n+      '      size={size}',\n+      '      onClick={onClick}',\n+      '      >',\n+      '      Button Text',\n+      '    </Button>',\n+      '  );',\n+      '};'\n+    ].join('\\n'),\n+    options: ['props-aligned'],","path":"tests/lib/rules/jsx-closing-bracket-location.js","position":27,"original_position":27,"commit_id":"bf562dbe88969aa6ff0fad168fdd43d4a463b8fe","original_commit_id":"aa94a5f4dc6119ea8fa4adcab80cbd46a108ec05","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"body":"I added a similar test for line-aligned and tag-aligned","created_at":"2016-07-18T17:16:32Z","updated_at":"2016-07-18T17:16:32Z","html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/684#discussion_r71188777","pull_request_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684","_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/71188777"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/684#discussion_r71188777"},"pull_request":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684","id":77689925,"html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/684","diff_url":"https://github.com/yannickcr/eslint-plugin-react/pull/684.diff","patch_url":"https://github.com/yannickcr/eslint-plugin-react/pull/684.patch","issue_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/684","number":684,"state":"open","locked":false,"title":"Repair `--fix` for props-aligned in jsx-closing-bracket-location","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"body":"Use the correctColumn attribute that is populated above.\r\n\r\nI don't quite understand the error, but running with `--fix` I would still get errors that look like\r\n\r\n\"  247:37  error  The closing bracket must be aligned with the last prop (expected column 9)   react/jsx-closing-bracket-location\"\r\n\r\nBut with this change, `--fix` does the right thing.","created_at":"2016-07-15T23:03:10Z","updated_at":"2016-07-18T17:16:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beb6650a1be0624ffd036eba6a02f55fd863154f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684/commits","review_comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684/comments","review_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/684/comments","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/bf562dbe88969aa6ff0fad168fdd43d4a463b8fe","head":{"label":"pfhayes:propsaligned","ref":"propsaligned","sha":"bf562dbe88969aa6ff0fad168fdd43d4a463b8fe","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"repo":{"id":63378927,"name":"eslint-plugin-react","full_name":"pfhayes/eslint-plugin-react","owner":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?v=3","gravatar_id":"","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfhayes/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":true,"url":"https://api.github.com/repos/pfhayes/eslint-plugin-react","forks_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/pfhayes/eslint-plugin-react/deployments","created_at":"2016-07-15T00:32:37Z","updated_at":"2016-07-15T00:32:38Z","pushed_at":"2016-07-18T17:16:17Z","git_url":"git://github.com/pfhayes/eslint-plugin-react.git","ssh_url":"git@github.com:pfhayes/eslint-plugin-react.git","clone_url":"https://github.com/pfhayes/eslint-plugin-react.git","svn_url":"https://github.com/pfhayes/eslint-plugin-react","homepage":null,"size":1011,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yannickcr:master","ref":"master","sha":"ae5a43be347c4e71d58b4d9912332b2e54dfaaf6","user":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"repo":{"id":28061676,"name":"eslint-plugin-react","full_name":"yannickcr/eslint-plugin-react","owner":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannickcr/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":false,"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react","forks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/deployments","created_at":"2014-12-15T23:44:14Z","updated_at":"2016-07-18T14:55:13Z","pushed_at":"2016-07-18T17:16:18Z","git_url":"git://github.com/yannickcr/eslint-plugin-react.git","ssh_url":"git@github.com:yannickcr/eslint-plugin-react.git","clone_url":"https://github.com/yannickcr/eslint-plugin-react.git","svn_url":"https://github.com/yannickcr/eslint-plugin-react","homepage":null,"size":1204,"stargazers_count":1510,"watchers_count":1510,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":135,"forks":247,"open_issues":135,"watchers":1510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/684"},"issue":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/684"},"comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/bf562dbe88969aa6ff0fad168fdd43d4a463b8fe"}}}}
{"actor":{"display_login":"pfhayes"}}