{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/7931","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/7931/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7931/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/7931/events","html_url":"https://github.com/openshift/origin/pull/7931","id":139961599,"number":7931,"title":"Handle env vars that use valueFrom","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/component/web","name":"component/web","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/11","html_url":"https://github.com/openshift/origin/milestones/1.2.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/11/labels","id":1502487,"number":11,"title":"1.2.0","description":"","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":98,"state":"open","created_at":"2016-01-12T16:06:32Z","updated_at":"2016-03-16T07:25:08Z","due_on":"2016-03-17T04:00:00Z","closed_at":null},"comments":28,"created_at":"2016-03-10T17:41:52Z","updated_at":"2016-03-16T12:59:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7931","html_url":"https://github.com/openshift/origin/pull/7931","diff_url":"https://github.com/openshift/origin/pull/7931.diff","patch_url":"https://github.com/openshift/origin/pull/7931.patch"},"body":"When env vars have speciefied `valueFrom` instead of the `value` we need to render them as well in your `environments` directive.\r\nAdding two proposed solutions that I've liked the most, but still not 100% sure about the solution. Think is that in case of the `configMapKeyRef` & `secretKeyRef` there could be more then 'key' and 'name' based on the https://github.com/kubernetes/kubernetes/blob/b45bf88105159cdbdd112e899bcb073e2b1ae573/pkg/api/types.go#L2048-L2050 so I didnt wanted to have a separate column for each field. On the other hand I wanted to stay by the table concept since the default original envVars are using it.\r\n![screenshot-11](https://cloud.githubusercontent.com/assets/1668218/13678486/561cd842-e6ef-11e5-94aa-321cc7376c6a.png)\r\n![screenshot-12](https://cloud.githubusercontent.com/assets/1668218/13678489/57d35f94-e6ef-11e5-8a27-498540c50e1e.png)\r\nThe code is not in the the best shape so for now please skip the code review.\r\n\r\n@jwforres @spadgett @ajacobs21e thoughts?\r\n\r\ncloses https://github.com/openshift/origin/issues/7886"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/197310851","html_url":"https://github.com/openshift/origin/pull/7931#issuecomment-197310851","issue_url":"https://api.github.com/repos/openshift/origin/issues/7931","id":197310851,"user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T12:59:35Z","updated_at":"2016-03-16T12:59:35Z","body":":+1:  LGTM"}}