{"action":"created","comment":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/52108941","id":52108941,"diff_hunk":"@@ -521,26 +521,42 @@\n #define ORGAN_ASSISTED   4096\n #define ORGAN_ADV_ROBOT  4096\n \n-\n-// Admin permissions. Please don't edit these values without speaking to Errorage first. ~Carn\n-#define R_BUILDMODE     1\n-#define R_ADMIN         2\n-#define R_BAN           4\n-#define R_FUN           8\n-#define R_SERVER        16\n-#define R_DEBUG         32\n-#define R_POSSESS       64\n-#define R_PERMISSIONS   128\n-#define R_STEALTH       256\n-#define R_REJUVINATE    512\n-#define R_VAREDIT       1024\n-#define R_SOUNDS        2048\n-#define R_SPAWN         4096\n-#define R_MOD           8192\n-#define R_DEV        \t16384 //needed a number in between 16k and 32k, so 16384+2048\n-#define R_CCIAA\t\t\t32768 //CAN'T BE ABOVE 65535 OR BORKS, stupid bitmasks -Ryan784\n-\n-#define R_MAXPERMISSION 32768 // This holds the maximum value for a permission. It is used in iteration, so keep it updated.\n+// Admin permissions. Slowly moving away from bitflags!\n+#define R_BUILDMODE     \"build_mode\"\n+#define R_ADMIN         \"admin\"\n+#define R_BAN           \"ban\"\n+#define R_FUN           \"fun\"\n+#define R_SERVER        \"server\"\n+#define R_DEBUG         \"debug\"\n+#define R_POSSESS       \"possess\"\n+#define R_PERMISSIONS   \"permissions\"\n+#define R_STEALTH       \"stealth\"\n+#define R_REJUVINATE    \"rejuvinate\"\n+#define R_VAREDIT       \"varedit\"\n+#define R_SOUNDS        \"sounds\"\n+#define R_SPAWN         \"spawn\"\n+#define R_MOD           \"moderator\"\n+#define R_DEV        \t\t\"developer\"\n+#define R_CCIAA\t\t\t\t\t\"duty_officer\" //gotta love strings","path":"code/setup.dm","position":40,"original_position":40,"commit_id":"99d269a406d698a79a7983725223d686a234c82d","original_commit_id":"99d269a406d698a79a7983725223d686a234c82d","user":{"login":"skull132","id":6318408,"avatar_url":"https://avatars.githubusercontent.com/u/6318408?v=3","gravatar_id":"","url":"https://api.github.com/users/skull132","html_url":"https://github.com/skull132","followers_url":"https://api.github.com/users/skull132/followers","following_url":"https://api.github.com/users/skull132/following{/other_user}","gists_url":"https://api.github.com/users/skull132/gists{/gist_id}","starred_url":"https://api.github.com/users/skull132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skull132/subscriptions","organizations_url":"https://api.github.com/users/skull132/orgs","repos_url":"https://api.github.com/users/skull132/repos","events_url":"https://api.github.com/users/skull132/events{/privacy}","received_events_url":"https://api.github.com/users/skull132/received_events","type":"User","site_admin":false},"body":"Small clerical error, I guess. Duty officers are going to be renamed to CCIAA, so might as well have the text string called \"cciaa\" instead of \"duty_officer\".","created_at":"2016-02-06T23:14:38Z","updated_at":"2016-02-06T23:14:38Z","html_url":"https://github.com/Aurorastation/Aurora.3/pull/69#discussion_r52108941","pull_request_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/52108941"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/69#discussion_r52108941"},"pull_request":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69","id":58532398,"html_url":"https://github.com/Aurorastation/Aurora.3/pull/69","diff_url":"https://github.com/Aurorastation/Aurora.3/pull/69.diff","patch_url":"https://github.com/Aurorastation/Aurora.3/pull/69.patch","issue_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/69","number":69,"state":"open","locked":false,"title":"Admin Permssions Overhaul, WIP","user":{"login":"Ryan784","id":9023656,"avatar_url":"https://avatars.githubusercontent.com/u/9023656?v=3","gravatar_id":"","url":"https://api.github.com/users/Ryan784","html_url":"https://github.com/Ryan784","followers_url":"https://api.github.com/users/Ryan784/followers","following_url":"https://api.github.com/users/Ryan784/following{/other_user}","gists_url":"https://api.github.com/users/Ryan784/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryan784/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryan784/subscriptions","organizations_url":"https://api.github.com/users/Ryan784/orgs","repos_url":"https://api.github.com/users/Ryan784/repos","events_url":"https://api.github.com/users/Ryan784/events{/privacy}","received_events_url":"https://api.github.com/users/Ryan784/received_events","type":"User","site_admin":false},"body":"Still a work in progress. Specific attention needed in check_rights() as well as all instances of:\r\n\r\nfor(var/client/C in admins)\r\nif((R_ADMIN|R_MOD) & C.holder.rights)\r\n\r\nWill continue updates tomorrow.","created_at":"2016-02-06T22:35:05Z","updated_at":"2016-02-06T23:14:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a00cde32bdde6527b4666de64df08fa9e3a61fe6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69/commits","review_comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69/comments","review_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/69/comments","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/99d269a406d698a79a7983725223d686a234c82d","head":{"label":"Ryan784:Permissions-rewrite","ref":"Permissions-rewrite","sha":"99d269a406d698a79a7983725223d686a234c82d","user":{"login":"Ryan784","id":9023656,"avatar_url":"https://avatars.githubusercontent.com/u/9023656?v=3","gravatar_id":"","url":"https://api.github.com/users/Ryan784","html_url":"https://github.com/Ryan784","followers_url":"https://api.github.com/users/Ryan784/followers","following_url":"https://api.github.com/users/Ryan784/following{/other_user}","gists_url":"https://api.github.com/users/Ryan784/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryan784/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryan784/subscriptions","organizations_url":"https://api.github.com/users/Ryan784/orgs","repos_url":"https://api.github.com/users/Ryan784/repos","events_url":"https://api.github.com/users/Ryan784/events{/privacy}","received_events_url":"https://api.github.com/users/Ryan784/received_events","type":"User","site_admin":false},"repo":{"id":51219498,"name":"Aurora.3","full_name":"Ryan784/Aurora.3","owner":{"login":"Ryan784","id":9023656,"avatar_url":"https://avatars.githubusercontent.com/u/9023656?v=3","gravatar_id":"","url":"https://api.github.com/users/Ryan784","html_url":"https://github.com/Ryan784","followers_url":"https://api.github.com/users/Ryan784/followers","following_url":"https://api.github.com/users/Ryan784/following{/other_user}","gists_url":"https://api.github.com/users/Ryan784/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryan784/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryan784/subscriptions","organizations_url":"https://api.github.com/users/Ryan784/orgs","repos_url":"https://api.github.com/users/Ryan784/repos","events_url":"https://api.github.com/users/Ryan784/events{/privacy}","received_events_url":"https://api.github.com/users/Ryan784/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ryan784/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Ryan784/Aurora.3","forks_url":"https://api.github.com/repos/Ryan784/Aurora.3/forks","keys_url":"https://api.github.com/repos/Ryan784/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ryan784/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ryan784/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Ryan784/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Ryan784/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Ryan784/Aurora.3/events","assignees_url":"https://api.github.com/repos/Ryan784/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Ryan784/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Ryan784/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Ryan784/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ryan784/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ryan784/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ryan784/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ryan784/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Ryan784/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Ryan784/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Ryan784/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Ryan784/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Ryan784/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Ryan784/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ryan784/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ryan784/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ryan784/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ryan784/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Ryan784/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ryan784/Aurora.3/merges","archive_url":"https://api.github.com/repos/Ryan784/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ryan784/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Ryan784/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Ryan784/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Ryan784/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Ryan784/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ryan784/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Ryan784/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Ryan784/Aurora.3/deployments","created_at":"2016-02-06T20:09:11Z","updated_at":"2016-02-06T20:09:21Z","pushed_at":"2016-02-06T22:34:00Z","git_url":"git://github.com/Ryan784/Aurora.3.git","ssh_url":"git@github.com:Ryan784/Aurora.3.git","clone_url":"https://github.com/Ryan784/Aurora.3.git","svn_url":"https://github.com/Ryan784/Aurora.3","homepage":"http://aurorastation.org/","size":532296,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aurorastation:development","ref":"development","sha":"b2d84c914c37f21e55b9e626bf104ee81e496c9e","user":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"repo":{"id":42579199,"name":"Aurora.3","full_name":"Aurorastation/Aurora.3","owner":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aurorastation/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Aurorastation/Aurora.3","forks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/forks","keys_url":"https://api.github.com/repos/Aurorastation/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurorastation/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurorastation/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/events","assignees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Aurorastation/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurorastation/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Aurorastation/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurorastation/Aurora.3/merges","archive_url":"https://api.github.com/repos/Aurorastation/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurorastation/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurorastation/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurorastation/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurorastation/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Aurorastation/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/deployments","created_at":"2015-09-16T09:56:37Z","updated_at":"2016-02-04T22:21:01Z","pushed_at":"2016-02-06T22:35:06Z","git_url":"git://github.com/Aurorastation/Aurora.3.git","ssh_url":"git@github.com:Aurorastation/Aurora.3.git","clone_url":"https://github.com/Aurorastation/Aurora.3.git","svn_url":"https://github.com/Aurorastation/Aurora.3","homepage":"http://aurorastation.org/","size":532468,"stargazers_count":2,"watchers_count":2,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/69"},"issue":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/69"},"comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/99d269a406d698a79a7983725223d686a234c82d"}}}}