{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/moovida/jgrasstools/pulls/25","id":65772942,"html_url":"https://github.com/moovida/jgrasstools/pull/25","diff_url":"https://github.com/moovida/jgrasstools/pull/25.diff","patch_url":"https://github.com/moovida/jgrasstools/pull/25.patch","issue_url":"https://api.github.com/repos/moovida/jgrasstools/issues/25","number":25,"state":"closed","locked":false,"title":"multiple code improvements: squid:S00115, squid:S1118, squid:S2147, squid:S2293, squid:S1488, squid:S1192, squid:CommentedOutCodeLine","user":{"login":"georgekankava","id":16732352,"avatar_url":"https://avatars.githubusercontent.com/u/16732352?v=3","gravatar_id":"","url":"https://api.github.com/users/georgekankava","html_url":"https://github.com/georgekankava","followers_url":"https://api.github.com/users/georgekankava/followers","following_url":"https://api.github.com/users/georgekankava/following{/other_user}","gists_url":"https://api.github.com/users/georgekankava/gists{/gist_id}","starred_url":"https://api.github.com/users/georgekankava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgekankava/subscriptions","organizations_url":"https://api.github.com/users/georgekankava/orgs","repos_url":"https://api.github.com/users/georgekankava/repos","events_url":"https://api.github.com/users/georgekankava/events{/privacy}","received_events_url":"https://api.github.com/users/georgekankava/received_events","type":"User","site_admin":false},"body":"This pull request is focused on resolving occurrences of Sonar rules\r\nsquid:S00115 - Constant names should comply with a naming convention.\r\nsquid:S1118 - Utility classes should not have public constructors.\r\nsquid:S2147 - Catches should be combined.\r\nsquid:S2293 - The diamond operator (\"<>\") should be used.\r\nsquid:S1488 - Local Variables should not be declared and then immediately returned or thrown.\r\nsquid:S1192 - String literals should not be duplicated.\r\nsquid:CommentedOutCodeLine - Sections of code should not be \"commented out\".\r\nYou can find more information about the issue here:\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S00115\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S1118\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S2147\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S2293\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S1488\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:S1192\r\nhttps://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine\r\nPlease let me know if you have any questions.\r\nGeorge Kankava","created_at":"2016-04-08T11:31:22Z","updated_at":"2016-04-08T11:38:38Z","closed_at":"2016-04-08T11:38:38Z","merged_at":"2016-04-08T11:38:38Z","merge_commit_sha":"b053167245fe4dc275017be4ecb90c219b3544a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moovida/jgrasstools/pulls/25/commits","review_comments_url":"https://api.github.com/repos/moovida/jgrasstools/pulls/25/comments","review_comment_url":"https://api.github.com/repos/moovida/jgrasstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moovida/jgrasstools/issues/25/comments","statuses_url":"https://api.github.com/repos/moovida/jgrasstools/statuses/fd91b51315f2f133585b5cccda778b8c43b3133a","head":{"label":"DevFactory:release/multiple-code-improvements-fix-7","ref":"release/multiple-code-improvements-fix-7","sha":"fd91b51315f2f133585b5cccda778b8c43b3133a","user":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"repo":{"id":54382647,"name":"jgrasstools","full_name":"DevFactory/jgrasstools","owner":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevFactory/jgrasstools","description":"uDig's geospatial toolbox (but not only)","fork":true,"url":"https://api.github.com/repos/DevFactory/jgrasstools","forks_url":"https://api.github.com/repos/DevFactory/jgrasstools/forks","keys_url":"https://api.github.com/repos/DevFactory/jgrasstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevFactory/jgrasstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevFactory/jgrasstools/teams","hooks_url":"https://api.github.com/repos/DevFactory/jgrasstools/hooks","issue_events_url":"https://api.github.com/repos/DevFactory/jgrasstools/issues/events{/number}","events_url":"https://api.github.com/repos/DevFactory/jgrasstools/events","assignees_url":"https://api.github.com/repos/DevFactory/jgrasstools/assignees{/user}","branches_url":"https://api.github.com/repos/DevFactory/jgrasstools/branches{/branch}","tags_url":"https://api.github.com/repos/DevFactory/jgrasstools/tags","blobs_url":"https://api.github.com/repos/DevFactory/jgrasstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevFactory/jgrasstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevFactory/jgrasstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevFactory/jgrasstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevFactory/jgrasstools/statuses/{sha}","languages_url":"https://api.github.com/repos/DevFactory/jgrasstools/languages","stargazers_url":"https://api.github.com/repos/DevFactory/jgrasstools/stargazers","contributors_url":"https://api.github.com/repos/DevFactory/jgrasstools/contributors","subscribers_url":"https://api.github.com/repos/DevFactory/jgrasstools/subscribers","subscription_url":"https://api.github.com/repos/DevFactory/jgrasstools/subscription","commits_url":"https://api.github.com/repos/DevFactory/jgrasstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevFactory/jgrasstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevFactory/jgrasstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevFactory/jgrasstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevFactory/jgrasstools/contents/{+path}","compare_url":"https://api.github.com/repos/DevFactory/jgrasstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevFactory/jgrasstools/merges","archive_url":"https://api.github.com/repos/DevFactory/jgrasstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevFactory/jgrasstools/downloads","issues_url":"https://api.github.com/repos/DevFactory/jgrasstools/issues{/number}","pulls_url":"https://api.github.com/repos/DevFactory/jgrasstools/pulls{/number}","milestones_url":"https://api.github.com/repos/DevFactory/jgrasstools/milestones{/number}","notifications_url":"https://api.github.com/repos/DevFactory/jgrasstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevFactory/jgrasstools/labels{/name}","releases_url":"https://api.github.com/repos/DevFactory/jgrasstools/releases{/id}","deployments_url":"https://api.github.com/repos/DevFactory/jgrasstools/deployments","created_at":"2016-03-21T11:16:39Z","updated_at":"2016-03-21T11:16:45Z","pushed_at":"2016-04-08T11:10:46Z","git_url":"git://github.com/DevFactory/jgrasstools.git","ssh_url":"git@github.com:DevFactory/jgrasstools.git","clone_url":"https://github.com/DevFactory/jgrasstools.git","svn_url":"https://github.com/DevFactory/jgrasstools","homepage":null,"size":41561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moovida:master","ref":"master","sha":"0ddcccf7f70e4640bf089ec81d4fdcc086e38cff","user":{"login":"moovida","id":390250,"avatar_url":"https://avatars.githubusercontent.com/u/390250?v=3","gravatar_id":"","url":"https://api.github.com/users/moovida","html_url":"https://github.com/moovida","followers_url":"https://api.github.com/users/moovida/followers","following_url":"https://api.github.com/users/moovida/following{/other_user}","gists_url":"https://api.github.com/users/moovida/gists{/gist_id}","starred_url":"https://api.github.com/users/moovida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovida/subscriptions","organizations_url":"https://api.github.com/users/moovida/orgs","repos_url":"https://api.github.com/users/moovida/repos","events_url":"https://api.github.com/users/moovida/events{/privacy}","received_events_url":"https://api.github.com/users/moovida/received_events","type":"User","site_admin":false},"repo":{"id":16166156,"name":"jgrasstools","full_name":"moovida/jgrasstools","owner":{"login":"moovida","id":390250,"avatar_url":"https://avatars.githubusercontent.com/u/390250?v=3","gravatar_id":"","url":"https://api.github.com/users/moovida","html_url":"https://github.com/moovida","followers_url":"https://api.github.com/users/moovida/followers","following_url":"https://api.github.com/users/moovida/following{/other_user}","gists_url":"https://api.github.com/users/moovida/gists{/gist_id}","starred_url":"https://api.github.com/users/moovida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovida/subscriptions","organizations_url":"https://api.github.com/users/moovida/orgs","repos_url":"https://api.github.com/users/moovida/repos","events_url":"https://api.github.com/users/moovida/events{/privacy}","received_events_url":"https://api.github.com/users/moovida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moovida/jgrasstools","description":"uDig's geospatial toolbox (but not only)","fork":false,"url":"https://api.github.com/repos/moovida/jgrasstools","forks_url":"https://api.github.com/repos/moovida/jgrasstools/forks","keys_url":"https://api.github.com/repos/moovida/jgrasstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moovida/jgrasstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moovida/jgrasstools/teams","hooks_url":"https://api.github.com/repos/moovida/jgrasstools/hooks","issue_events_url":"https://api.github.com/repos/moovida/jgrasstools/issues/events{/number}","events_url":"https://api.github.com/repos/moovida/jgrasstools/events","assignees_url":"https://api.github.com/repos/moovida/jgrasstools/assignees{/user}","branches_url":"https://api.github.com/repos/moovida/jgrasstools/branches{/branch}","tags_url":"https://api.github.com/repos/moovida/jgrasstools/tags","blobs_url":"https://api.github.com/repos/moovida/jgrasstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moovida/jgrasstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moovida/jgrasstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/moovida/jgrasstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moovida/jgrasstools/statuses/{sha}","languages_url":"https://api.github.com/repos/moovida/jgrasstools/languages","stargazers_url":"https://api.github.com/repos/moovida/jgrasstools/stargazers","contributors_url":"https://api.github.com/repos/moovida/jgrasstools/contributors","subscribers_url":"https://api.github.com/repos/moovida/jgrasstools/subscribers","subscription_url":"https://api.github.com/repos/moovida/jgrasstools/subscription","commits_url":"https://api.github.com/repos/moovida/jgrasstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/moovida/jgrasstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/moovida/jgrasstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/moovida/jgrasstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/moovida/jgrasstools/contents/{+path}","compare_url":"https://api.github.com/repos/moovida/jgrasstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moovida/jgrasstools/merges","archive_url":"https://api.github.com/repos/moovida/jgrasstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moovida/jgrasstools/downloads","issues_url":"https://api.github.com/repos/moovida/jgrasstools/issues{/number}","pulls_url":"https://api.github.com/repos/moovida/jgrasstools/pulls{/number}","milestones_url":"https://api.github.com/repos/moovida/jgrasstools/milestones{/number}","notifications_url":"https://api.github.com/repos/moovida/jgrasstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moovida/jgrasstools/labels{/name}","releases_url":"https://api.github.com/repos/moovida/jgrasstools/releases{/id}","deployments_url":"https://api.github.com/repos/moovida/jgrasstools/deployments","created_at":"2014-01-23T08:03:52Z","updated_at":"2016-03-15T10:43:11Z","pushed_at":"2016-04-08T11:38:38Z","git_url":"git://github.com/moovida/jgrasstools.git","ssh_url":"git@github.com:moovida/jgrasstools.git","clone_url":"https://github.com/moovida/jgrasstools.git","svn_url":"https://github.com/moovida/jgrasstools","homepage":null,"size":42467,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moovida/jgrasstools/pulls/25"},"html":{"href":"https://github.com/moovida/jgrasstools/pull/25"},"issue":{"href":"https://api.github.com/repos/moovida/jgrasstools/issues/25"},"comments":{"href":"https://api.github.com/repos/moovida/jgrasstools/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/moovida/jgrasstools/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/moovida/jgrasstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moovida/jgrasstools/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/moovida/jgrasstools/statuses/fd91b51315f2f133585b5cccda778b8c43b3133a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"moovida","id":390250,"avatar_url":"https://avatars.githubusercontent.com/u/390250?v=3","gravatar_id":"","url":"https://api.github.com/users/moovida","html_url":"https://github.com/moovida","followers_url":"https://api.github.com/users/moovida/followers","following_url":"https://api.github.com/users/moovida/following{/other_user}","gists_url":"https://api.github.com/users/moovida/gists{/gist_id}","starred_url":"https://api.github.com/users/moovida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovida/subscriptions","organizations_url":"https://api.github.com/users/moovida/orgs","repos_url":"https://api.github.com/users/moovida/repos","events_url":"https://api.github.com/users/moovida/events{/privacy}","received_events_url":"https://api.github.com/users/moovida/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":407,"deletions":411,"changed_files":32}}