{"action":"created","comment":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/50860827","id":50860827,"diff_hunk":"@@ -863,7 +864,8 @@ void IEEE1588Port::processEvent(Event e)\n \t\t\t (pow ((double)2, getAnnounceInterval()) * 1000000000.0));\n \t\tbreak;\n \tcase FAULT_DETECTED:\n-\t\tXPTPD_INFO(\"Received FAULT_DETECTED event\");\n+        XPTPD_INFO(\"Received FAULT_DETECTED event\");\n+        setAsCapable(false);","path":"daemons/gptp/common/ieee1588port.cpp","position":29,"original_position":29,"commit_id":"2991c69ec86a4bfbb62f13e47a1388ed51b37167","original_commit_id":"2991c69ec86a4bfbb62f13e47a1388ed51b37167","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"body":"Ok, same problem as above. I have spaces instead of tabs on my vim. I rolled it back and kept these two lines as tabs.","created_at":"2016-01-26T16:41:14Z","updated_at":"2016-01-26T16:41:14Z","html_url":"https://github.com/AVnu/Open-AVB/pull/342#discussion_r50860827","pull_request_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/50860827"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/342#discussion_r50860827"},"pull_request":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342","id":57097445,"html_url":"https://github.com/AVnu/Open-AVB/pull/342","diff_url":"https://github.com/AVnu/Open-AVB/pull/342.diff","patch_url":"https://github.com/AVnu/Open-AVB/pull/342.patch","issue_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/342","number":342,"state":"open","locked":false,"title":"Issue #134 fix","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"body":"This patch fixes Issue #134 \r\n\r\nThe clause 9.2 from 802.1AS-2011 states that the \"time base indicator should change its value if and only if there is a phase or frequency change\". \r\n\r\nThis patch addresses this problem by incrementing the TBI every time there is a change of ptp master. Also, the values lastGmPhaseChange and lastGmFreqChange were not being updated correctly.\r\n\r\nTo do that  i did:\r\n- Created two FollowUpTLV instances inside the IEEE15588Clock class; One of them is updated every time the FollowUp::processMessage method is called (fup_status) and the second one update its value everytime the TBI needs to be changed (fup_info) with the instantaneous content of fup_status. \r\n- Before sending out our FUP messages, the function that prepares the packet gets the information from fup_status and put inside the packet.\r\n\r\nThis issue was validated using the IOL Tools on the specific tests that exercises this part of the standard. ","created_at":"2016-01-25T16:50:33Z","updated_at":"2016-01-26T16:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90db63d65a66112bfa38cdd39b55f49717c2905c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342/commits","review_comments_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342/comments","review_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/342/comments","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/2991c69ec86a4bfbb62f13e47a1388ed51b37167","head":{"label":"davidcemin:task-gptpv3","ref":"task-gptpv3","sha":"2991c69ec86a4bfbb62f13e47a1388ed51b37167","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"repo":{"id":44438338,"name":"Open-AVB","full_name":"davidcemin/Open-AVB","owner":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidcemin/Open-AVB","description":"Open AVB - an AVnu sponsored repository for Audio/Video Bridging technology","fork":true,"url":"https://api.github.com/repos/davidcemin/Open-AVB","forks_url":"https://api.github.com/repos/davidcemin/Open-AVB/forks","keys_url":"https://api.github.com/repos/davidcemin/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcemin/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcemin/Open-AVB/teams","hooks_url":"https://api.github.com/repos/davidcemin/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/davidcemin/Open-AVB/events","assignees_url":"https://api.github.com/repos/davidcemin/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/davidcemin/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/davidcemin/Open-AVB/tags","blobs_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcemin/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcemin/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/davidcemin/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/davidcemin/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/davidcemin/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/davidcemin/Open-AVB/subscription","commits_url":"https://api.github.com/repos/davidcemin/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcemin/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidcemin/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/davidcemin/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcemin/Open-AVB/merges","archive_url":"https://api.github.com/repos/davidcemin/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcemin/Open-AVB/downloads","issues_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/davidcemin/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcemin/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcemin/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcemin/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/davidcemin/Open-AVB/releases{/id}","deployments_url":"https://api.github.com/repos/davidcemin/Open-AVB/deployments","created_at":"2015-10-17T13:35:57Z","updated_at":"2015-10-17T13:35:59Z","pushed_at":"2016-01-25T17:00:46Z","git_url":"git://github.com/davidcemin/Open-AVB.git","ssh_url":"git@github.com:davidcemin/Open-AVB.git","clone_url":"https://github.com/davidcemin/Open-AVB.git","svn_url":"https://github.com/davidcemin/Open-AVB","homepage":"","size":12185,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AVnu:feature-gptp-next","ref":"feature-gptp-next","sha":"5911ec4f61f90a8b0bdd088268decd94201a38c6","user":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"repo":{"id":5693778,"name":"Open-AVB","full_name":"AVnu/Open-AVB","owner":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AVnu/Open-AVB","description":"Open AVB - an AVnu sponsored repository for Audio/Video Bridging technology","fork":false,"url":"https://api.github.com/repos/AVnu/Open-AVB","forks_url":"https://api.github.com/repos/AVnu/Open-AVB/forks","keys_url":"https://api.github.com/repos/AVnu/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVnu/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVnu/Open-AVB/teams","hooks_url":"https://api.github.com/repos/AVnu/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/AVnu/Open-AVB/events","assignees_url":"https://api.github.com/repos/AVnu/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/AVnu/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/AVnu/Open-AVB/tags","blobs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVnu/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVnu/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/AVnu/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/AVnu/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/AVnu/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/AVnu/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/AVnu/Open-AVB/subscription","commits_url":"https://api.github.com/repos/AVnu/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVnu/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVnu/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/AVnu/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVnu/Open-AVB/merges","archive_url":"https://api.github.com/repos/AVnu/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVnu/Open-AVB/downloads","issues_url":"https://api.github.com/repos/AVnu/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/AVnu/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/AVnu/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVnu/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/AVnu/Open-AVB/releases{/id}","deployments_url":"https://api.github.com/repos/AVnu/Open-AVB/deployments","created_at":"2012-09-05T21:19:39Z","updated_at":"2016-01-21T21:20:16Z","pushed_at":"2016-01-26T16:27:39Z","git_url":"git://github.com/AVnu/Open-AVB.git","ssh_url":"git@github.com:AVnu/Open-AVB.git","clone_url":"https://github.com/AVnu/Open-AVB.git","svn_url":"https://github.com/AVnu/Open-AVB","homepage":"","size":13250,"stargazers_count":78,"watchers_count":78,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"open_issues_count":85,"forks":83,"open_issues":85,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/342"},"issue":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/342"},"comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/AVnu/Open-AVB/statuses/2991c69ec86a4bfbb62f13e47a1388ed51b37167"}}}}