{"action":"closed","number":3126,"pull_request":{"url":"https://api.github.com/repos/libretro/RetroArch/pulls/3126","id":74347235,"html_url":"https://github.com/libretro/RetroArch/pull/3126","diff_url":"https://github.com/libretro/RetroArch/pull/3126.diff","patch_url":"https://github.com/libretro/RetroArch/pull/3126.patch","issue_url":"https://api.github.com/repos/libretro/RetroArch/issues/3126","number":3126,"state":"closed","locked":false,"title":"Fix overlap of source and destination buffers in snprintf call","user":{"login":"nikola-kocic","id":1047924,"avatar_url":"https://avatars.githubusercontent.com/u/1047924?v=3","gravatar_id":"","url":"https://api.github.com/users/nikola-kocic","html_url":"https://github.com/nikola-kocic","followers_url":"https://api.github.com/users/nikola-kocic/followers","following_url":"https://api.github.com/users/nikola-kocic/following{/other_user}","gists_url":"https://api.github.com/users/nikola-kocic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikola-kocic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikola-kocic/subscriptions","organizations_url":"https://api.github.com/users/nikola-kocic/orgs","repos_url":"https://api.github.com/users/nikola-kocic/repos","events_url":"https://api.github.com/users/nikola-kocic/events{/privacy}","received_events_url":"https://api.github.com/users/nikola-kocic/received_events","type":"User","site_admin":false},"body":"command_event_save_state was failing on my machine because of undefined behavior of snprintf function when source and destination buffers overlap.\r\n\r\nhttp://linux.die.net/man/3/snprintf:\r\n> C99 and POSIX.1-2001 specify that the results are undefined if a call to sprintf(), snprintf(), vsprintf(), or vsnprintf() would cause copying to take place between objects that overlap (e.g., if the target string array and one of the supplied input arguments refer to the same buffer). See NOTES. \r\n\r\nPR #3098 reworks this part of the code, but until it's merged, this should be fixed.","created_at":"2016-06-18T21:00:58Z","updated_at":"2016-06-18T21:14:08Z","closed_at":"2016-06-18T21:14:07Z","merged_at":"2016-06-18T21:14:07Z","merge_commit_sha":"d0697236f0ba173f2156a4dec96b26419ce0d6bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libretro/RetroArch/pulls/3126/commits","review_comments_url":"https://api.github.com/repos/libretro/RetroArch/pulls/3126/comments","review_comment_url":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/RetroArch/issues/3126/comments","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/ebfb7652b0f5e36dbf6aa046dec0bcd1f900e807","head":{"label":"nikola-kocic:fix-snprintf-overlap","ref":"fix-snprintf-overlap","sha":"ebfb7652b0f5e36dbf6aa046dec0bcd1f900e807","user":{"login":"nikola-kocic","id":1047924,"avatar_url":"https://avatars.githubusercontent.com/u/1047924?v=3","gravatar_id":"","url":"https://api.github.com/users/nikola-kocic","html_url":"https://github.com/nikola-kocic","followers_url":"https://api.github.com/users/nikola-kocic/followers","following_url":"https://api.github.com/users/nikola-kocic/following{/other_user}","gists_url":"https://api.github.com/users/nikola-kocic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikola-kocic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikola-kocic/subscriptions","organizations_url":"https://api.github.com/users/nikola-kocic/orgs","repos_url":"https://api.github.com/users/nikola-kocic/repos","events_url":"https://api.github.com/users/nikola-kocic/events{/privacy}","received_events_url":"https://api.github.com/users/nikola-kocic/received_events","type":"User","site_admin":false},"repo":{"id":61452153,"name":"RetroArch","full_name":"nikola-kocic/RetroArch","owner":{"login":"nikola-kocic","id":1047924,"avatar_url":"https://avatars.githubusercontent.com/u/1047924?v=3","gravatar_id":"","url":"https://api.github.com/users/nikola-kocic","html_url":"https://github.com/nikola-kocic","followers_url":"https://api.github.com/users/nikola-kocic/followers","following_url":"https://api.github.com/users/nikola-kocic/following{/other_user}","gists_url":"https://api.github.com/users/nikola-kocic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikola-kocic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikola-kocic/subscriptions","organizations_url":"https://api.github.com/users/nikola-kocic/orgs","repos_url":"https://api.github.com/users/nikola-kocic/repos","events_url":"https://api.github.com/users/nikola-kocic/events{/privacy}","received_events_url":"https://api.github.com/users/nikola-kocic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikola-kocic/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API.","fork":true,"url":"https://api.github.com/repos/nikola-kocic/RetroArch","forks_url":"https://api.github.com/repos/nikola-kocic/RetroArch/forks","keys_url":"https://api.github.com/repos/nikola-kocic/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikola-kocic/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikola-kocic/RetroArch/teams","hooks_url":"https://api.github.com/repos/nikola-kocic/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/nikola-kocic/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/nikola-kocic/RetroArch/events","assignees_url":"https://api.github.com/repos/nikola-kocic/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/nikola-kocic/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/nikola-kocic/RetroArch/tags","blobs_url":"https://api.github.com/repos/nikola-kocic/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikola-kocic/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikola-kocic/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikola-kocic/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikola-kocic/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/nikola-kocic/RetroArch/languages","stargazers_url":"https://api.github.com/repos/nikola-kocic/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/nikola-kocic/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/nikola-kocic/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/nikola-kocic/RetroArch/subscription","commits_url":"https://api.github.com/repos/nikola-kocic/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikola-kocic/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikola-kocic/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikola-kocic/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikola-kocic/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/nikola-kocic/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikola-kocic/RetroArch/merges","archive_url":"https://api.github.com/repos/nikola-kocic/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikola-kocic/RetroArch/downloads","issues_url":"https://api.github.com/repos/nikola-kocic/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/nikola-kocic/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/nikola-kocic/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/nikola-kocic/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikola-kocic/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/nikola-kocic/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/nikola-kocic/RetroArch/deployments","created_at":"2016-06-18T20:54:17Z","updated_at":"2016-06-18T20:54:24Z","pushed_at":"2016-06-18T20:54:53Z","git_url":"git://github.com/nikola-kocic/RetroArch.git","ssh_url":"git@github.com:nikola-kocic/RetroArch.git","clone_url":"https://github.com/nikola-kocic/RetroArch.git","svn_url":"https://github.com/nikola-kocic/RetroArch","homepage":"http://www.libretro.com","size":106689,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"b510b2fe269af6440e55323803b3019bd8c40b7c","user":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":689344,"name":"RetroArch","full_name":"libretro/RetroArch","owner":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libretro/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API.","fork":false,"url":"https://api.github.com/repos/libretro/RetroArch","forks_url":"https://api.github.com/repos/libretro/RetroArch/forks","keys_url":"https://api.github.com/repos/libretro/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/RetroArch/teams","hooks_url":"https://api.github.com/repos/libretro/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/libretro/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/RetroArch/events","assignees_url":"https://api.github.com/repos/libretro/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/RetroArch/tags","blobs_url":"https://api.github.com/repos/libretro/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/RetroArch/languages","stargazers_url":"https://api.github.com/repos/libretro/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/libretro/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/libretro/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/libretro/RetroArch/subscription","commits_url":"https://api.github.com/repos/libretro/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/RetroArch/merges","archive_url":"https://api.github.com/repos/libretro/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/RetroArch/downloads","issues_url":"https://api.github.com/repos/libretro/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/libretro/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/RetroArch/deployments","created_at":"2010-05-27T14:47:40Z","updated_at":"2016-06-18T19:16:51Z","pushed_at":"2016-06-18T21:14:07Z","git_url":"git://github.com/libretro/RetroArch.git","ssh_url":"git@github.com:libretro/RetroArch.git","clone_url":"https://github.com/libretro/RetroArch.git","svn_url":"https://github.com/libretro/RetroArch","homepage":"http://www.libretro.com","size":121349,"stargazers_count":1144,"watchers_count":1144,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"open_issues_count":243,"forks":362,"open_issues":243,"watchers":1144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3126"},"html":{"href":"https://github.com/libretro/RetroArch/pull/3126"},"issue":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/3126"},"comments":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/3126/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3126/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3126/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/RetroArch/statuses/ebfb7652b0f5e36dbf6aa046dec0bcd1f900e807"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"twinaphex","id":1075274,"avatar_url":"https://avatars.githubusercontent.com/u/1075274?v=3","gravatar_id":"","url":"https://api.github.com/users/twinaphex","html_url":"https://github.com/twinaphex","followers_url":"https://api.github.com/users/twinaphex/followers","following_url":"https://api.github.com/users/twinaphex/following{/other_user}","gists_url":"https://api.github.com/users/twinaphex/gists{/gist_id}","starred_url":"https://api.github.com/users/twinaphex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinaphex/subscriptions","organizations_url":"https://api.github.com/users/twinaphex/orgs","repos_url":"https://api.github.com/users/twinaphex/repos","events_url":"https://api.github.com/users/twinaphex/events{/privacy}","received_events_url":"https://api.github.com/users/twinaphex/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"twinaphex"}}