{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/75216952","id":75216952,"diff_hunk":"@@ -1249,7 +1255,7 @@ func (c *linuxContainer) orderNamespacePaths(namespaces map[configs.NamespaceTyp\n \t\t\tif strings.ContainsRune(p, ',') {\n \t\t\t\treturn nil, newSystemError(fmt.Errorf(\"invalid path %s\", p))\n \t\t\t}\n-\t\t\tpaths = append(paths, p)\n+\t\t\tpaths = append(paths, fmt.Sprintf(\"%s:%s\", configs.NsName(nsType), p))","path":"libcontainer/container_linux.go","position":32,"original_position":32,"commit_id":"642c0418abafb541cd8030fbc7a1d06a86fd6bf2","original_commit_id":"642c0418abafb541cd8030fbc7a1d06a86fd6bf2","user":{"login":"dqminh","id":62707,"avatar_url":"https://avatars.githubusercontent.com/u/62707?v=3","gravatar_id":"","url":"https://api.github.com/users/dqminh","html_url":"https://github.com/dqminh","followers_url":"https://api.github.com/users/dqminh/followers","following_url":"https://api.github.com/users/dqminh/following{/other_user}","gists_url":"https://api.github.com/users/dqminh/gists{/gist_id}","starred_url":"https://api.github.com/users/dqminh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dqminh/subscriptions","organizations_url":"https://api.github.com/users/dqminh/orgs","repos_url":"https://api.github.com/users/dqminh/repos","events_url":"https://api.github.com/users/dqminh/events{/privacy}","received_events_url":"https://api.github.com/users/dqminh/received_events","type":"User","site_admin":false},"body":"i'm still not sure if setting namespace type here is necessary. Seems like something we do with no gain since the namespace type is already \"known\" (implicitly) ( and result in more code )","created_at":"2016-08-17T22:09:43Z","updated_at":"2016-08-17T22:09:43Z","html_url":"https://github.com/opencontainers/runc/pull/977#discussion_r75216952","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/977","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/75216952"},"html":{"href":"https://github.com/opencontainers/runc/pull/977#discussion_r75216952"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/977"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/977","id":80441557,"html_url":"https://github.com/opencontainers/runc/pull/977","diff_url":"https://github.com/opencontainers/runc/pull/977.diff","patch_url":"https://github.com/opencontainers/runc/pull/977.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/977","number":977,"state":"open","locked":false,"title":"nsenter: guarantee correct user namespace ordering","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"body":"Depending on your SELinux setup, the order in which you join namespaces\r\ncan be important. In general, user namespaces should *always* be joined\r\nand unshared first because then the other namespaces are correctly\r\npinned and you have the right priviliges within them. This also is very\r\nuseful for rootless containers, as well as older kernels that had\r\nessentially broken unshare(2) and clone(2) implementations.\r\n\r\nThis also includes huge refactorings in how we spawn processes for\r\ncomplicated reasons that I don't want to get into because it will make\r\nme spiral into a cloud of rage. The reasoning is in the giant comment in\r\nclone_parent. Have fun.\r\n\r\nIn addition, because we now create multiple children with CLONE_PARENT,\r\nwe cannot wait for them to SIGCHLD us in the case of a death. Thus, we\r\nhave to resort to having a child kindly send us their exit code before\r\nthey die. Hopefully this all works okay, but at this point there's not\r\nmuch more than we can do.\r\n\r\n`TODO`:\r\n* [x] Tag each namespace we want to join, to avoid future bugs.\r\n* [x] Guarantee correct namespace ordering.\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>\r\n\r\n~~This is based on #950.~~ Base has been merged.","created_at":"2016-08-08T12:21:42Z","updated_at":"2016-08-17T22:09:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c248b10d7da96701621f88d925db1f31b87d5f25","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opencontainers/runc/milestones/4","html_url":"https://github.com/opencontainers/runc/milestones/1.0.0","labels_url":"https://api.github.com/repos/opencontainers/runc/milestones/4/labels","id":1756705,"number":4,"title":"1.0.0","description":"Final milestone for the runc 1.0.0 Release","creator":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":14,"state":"open","created_at":"2016-05-09T23:22:52Z","updated_at":"2016-08-16T23:00:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/977/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/977/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/977/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/642c0418abafb541cd8030fbc7a1d06a86fd6bf2","head":{"label":"cyphar:nsenter-userns-ordering","ref":"nsenter-userns-ordering","sha":"642c0418abafb541cd8030fbc7a1d06a86fd6bf2","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"repo":{"id":38178794,"name":"runc","full_name":"cyphar/runc","owner":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyphar/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/cyphar/runc","forks_url":"https://api.github.com/repos/cyphar/runc/forks","keys_url":"https://api.github.com/repos/cyphar/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphar/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphar/runc/teams","hooks_url":"https://api.github.com/repos/cyphar/runc/hooks","issue_events_url":"https://api.github.com/repos/cyphar/runc/issues/events{/number}","events_url":"https://api.github.com/repos/cyphar/runc/events","assignees_url":"https://api.github.com/repos/cyphar/runc/assignees{/user}","branches_url":"https://api.github.com/repos/cyphar/runc/branches{/branch}","tags_url":"https://api.github.com/repos/cyphar/runc/tags","blobs_url":"https://api.github.com/repos/cyphar/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphar/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphar/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphar/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphar/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphar/runc/languages","stargazers_url":"https://api.github.com/repos/cyphar/runc/stargazers","contributors_url":"https://api.github.com/repos/cyphar/runc/contributors","subscribers_url":"https://api.github.com/repos/cyphar/runc/subscribers","subscription_url":"https://api.github.com/repos/cyphar/runc/subscription","commits_url":"https://api.github.com/repos/cyphar/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphar/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphar/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphar/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphar/runc/contents/{+path}","compare_url":"https://api.github.com/repos/cyphar/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphar/runc/merges","archive_url":"https://api.github.com/repos/cyphar/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphar/runc/downloads","issues_url":"https://api.github.com/repos/cyphar/runc/issues{/number}","pulls_url":"https://api.github.com/repos/cyphar/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphar/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphar/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphar/runc/labels{/name}","releases_url":"https://api.github.com/repos/cyphar/runc/releases{/id}","deployments_url":"https://api.github.com/repos/cyphar/runc/deployments","created_at":"2015-06-27T23:14:24Z","updated_at":"2016-07-27T22:09:51Z","pushed_at":"2016-08-17T12:05:06Z","git_url":"git://github.com/cyphar/runc.git","ssh_url":"git@github.com:cyphar/runc.git","clone_url":"https://github.com/cyphar/runc.git","svn_url":"https://github.com/cyphar/runc","homepage":"","size":3589,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"aee3f6ff5a43709354e30b012bd4f7db3fa2ef9d","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-08-17T14:55:47Z","pushed_at":"2016-08-17T18:54:34Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":5939,"stargazers_count":3023,"watchers_count":3023,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"open_issues_count":90,"forks":423,"open_issues":90,"watchers":3023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/977"},"html":{"href":"https://github.com/opencontainers/runc/pull/977"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/977"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/977/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/977/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/977/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/642c0418abafb541cd8030fbc7a1d06a86fd6bf2"}}}}
{"actor":{"display_login":"dqminh"}}