{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/860","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/860/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/860/comments","events_url":"https://api.github.com/repos/google/googletest/issues/860/events","html_url":"https://github.com/google/googletest/issues/860","id":173809578,"number":860,"title":"suppress msvc warning : 4275 non dll-interface class 'x' used as base for dll-interface class 'y' ","user":{"login":"jmecosta","id":1041352,"avatar_url":"https://avatars.githubusercontent.com/u/1041352?v=3","gravatar_id":"","url":"https://api.github.com/users/jmecosta","html_url":"https://github.com/jmecosta","followers_url":"https://api.github.com/users/jmecosta/followers","following_url":"https://api.github.com/users/jmecosta/following{/other_user}","gists_url":"https://api.github.com/users/jmecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmecosta/subscriptions","organizations_url":"https://api.github.com/users/jmecosta/orgs","repos_url":"https://api.github.com/users/jmecosta/repos","events_url":"https://api.github.com/users/jmecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jmecosta/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-29T16:02:45Z","updated_at":"2016-08-30T14:18:45Z","closed_at":"2016-08-30T14:17:56Z","body":"Hi \r\n\r\nI am getting some warnings as errors as below.\r\n\r\n1>d:\\prod\\structures\\packages\\gtestmock.1.8.0-alpha003\\build\\native\\include\\googletest\\gtest/internal/gtest-internal.h(148): error C2220: warning treated as error - no 'object' file generated (test\\tool_read_line_test.cpp)\r\n1>d:\\prod\\structures\\packages\\gtestmock.1.8.0-alpha003\\build\\native\\include\\googletest\\gtest/internal/gtest-internal.h(148): warning C4275: non dll-interface class 'std::runtime_error' used as base for dll-interface class 'testing::internal::GoogleTestFailureException' (test\\tool_read_line_test.cpp)\r\n1>          C:\\Program Files (x86)\\Microsoft Visual Studio 12.0\\VC\\include\\stdexcept(166) : see declaration of 'std::runtime_error'\r\n1>          d:\\prod\\structures\\packages\\gtestmock.1.8.0-alpha003\\build\\native\\include\\googletest\\gtest/internal/gtest-internal.h(148) : see declaration of 'testing::internal::GoogleTestFailureException'\r\n\r\nThis is for a shared dll with visual studio 2013, with runtime dll MultiThreadedDLL. Is there some flag i need to pass to Cmake now to cmake that will handle this.\r\n\r\nThanks in advance.\r\n\r\nbr \r\n\r\njorge costa"},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/243454253","html_url":"https://github.com/google/googletest/issues/860#issuecomment-243454253","issue_url":"https://api.github.com/repos/google/googletest/issues/860","id":243454253,"user":{"login":"jmecosta","id":1041352,"avatar_url":"https://avatars.githubusercontent.com/u/1041352?v=3","gravatar_id":"","url":"https://api.github.com/users/jmecosta","html_url":"https://github.com/jmecosta","followers_url":"https://api.github.com/users/jmecosta/followers","following_url":"https://api.github.com/users/jmecosta/following{/other_user}","gists_url":"https://api.github.com/users/jmecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmecosta/subscriptions","organizations_url":"https://api.github.com/users/jmecosta/orgs","repos_url":"https://api.github.com/users/jmecosta/repos","events_url":"https://api.github.com/users/jmecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jmecosta/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T14:18:45Z","updated_at":"2016-08-30T14:18:45Z","body":"@KindDragon thanks for the help. I will reopen this if find anything else with #862"}}
{"actor":{"display_login":"jmecosta"}}