{"action":"created","comment":{"url":"https://api.github.com/repos/fog/fog-google/pulls/comments/65929419","id":65929419,"diff_hunk":"@@ -27,9 +27,39 @@ def destroy(_async = true)\n           data = service.delete_instance_group(name, zone_name)\n         end\n \n+        def add_instances(instances)\n+          requires :identity, :zone\n+\n+          service.add_instance_group_instances(\n+            identity, zone_name, format_instance_list(instances)\n+          )\n+        end\n+\n+        def remove_instances(instances)\n+          requires :identity, :zone\n+\n+          service.remove_instance_group_instances(\n+            identity, zone_name, format_instance_list(instances)\n+          )\n+        end\n+\n+        def list_instances\n+          requires :identity, :zone\n+\n+          data = service.list_instance_group_instances(identity, zone_name).body\n+          data[\"items\"]\n+        end\n+\n         def zone_name\n           zone.nil? ? nil : zone.split(\"/\")[-1]\n         end\n+\n+        private\n+\n+        def format_instance_list(instance_list)","path":"lib/fog/compute/google/models/instance_group.rb","position":50,"original_position":33,"commit_id":"d77ac8a7b4f1bacc17018388eb88cdb3a140da76","original_commit_id":"e7cf56f0dc77ae89d986ee1481057c99ccaaa160","user":{"login":"Temikus","id":2083229,"avatar_url":"https://avatars.githubusercontent.com/u/2083229?v=3","gravatar_id":"","url":"https://api.github.com/users/Temikus","html_url":"https://github.com/Temikus","followers_url":"https://api.github.com/users/Temikus/followers","following_url":"https://api.github.com/users/Temikus/following{/other_user}","gists_url":"https://api.github.com/users/Temikus/gists{/gist_id}","starred_url":"https://api.github.com/users/Temikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temikus/subscriptions","organizations_url":"https://api.github.com/users/Temikus/orgs","repos_url":"https://api.github.com/users/Temikus/repos","events_url":"https://api.github.com/users/Temikus/events{/privacy}","received_events_url":"https://api.github.com/users/Temikus/received_events","type":"User","site_admin":false},"body":"@plribeiro3000 Thx! I'll think about abstracting it away when working on #134. So far we don't have many models accepting collections models as input as far as I've seen.","created_at":"2016-06-06T17:13:11Z","updated_at":"2016-06-06T17:13:11Z","html_url":"https://github.com/fog/fog-google/pull/133#discussion_r65929419","pull_request_url":"https://api.github.com/repos/fog/fog-google/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/fog/fog-google/pulls/comments/65929419"},"html":{"href":"https://github.com/fog/fog-google/pull/133#discussion_r65929419"},"pull_request":{"href":"https://api.github.com/repos/fog/fog-google/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/fog/fog-google/pulls/133","id":72199516,"html_url":"https://github.com/fog/fog-google/pull/133","diff_url":"https://github.com/fog/fog-google/pull/133.diff","patch_url":"https://github.com/fog/fog-google/pull/133.patch","issue_url":"https://api.github.com/repos/fog/fog-google/issues/133","number":133,"state":"open","locked":false,"title":"Fixing some instance_group issues","user":{"login":"Temikus","id":2083229,"avatar_url":"https://avatars.githubusercontent.com/u/2083229?v=3","gravatar_id":"","url":"https://api.github.com/users/Temikus","html_url":"https://github.com/Temikus","followers_url":"https://api.github.com/users/Temikus/followers","following_url":"https://api.github.com/users/Temikus/following{/other_user}","gists_url":"https://api.github.com/users/Temikus/gists{/gist_id}","starred_url":"https://api.github.com/users/Temikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temikus/subscriptions","organizations_url":"https://api.github.com/users/Temikus/orgs","repos_url":"https://api.github.com/users/Temikus/repos","events_url":"https://api.github.com/users/Temikus/events{/privacy}","received_events_url":"https://api.github.com/users/Temikus/received_events","type":"User","site_admin":false},"body":"- Moving methods to the correct model\r\n- Cleaned up requests\r\n- Renaming get_instances to be coherent with GCE API\r\n- Refactoring InstanceGroup methods to support multiple instances\t\r\n\r\nFixing #115, #132\r\n\r\n@plribeiro3000 PTAL, please, if possible make sure I'm symantically correct, since this is public-facing API (see #132) ","created_at":"2016-06-01T15:16:00Z","updated_at":"2016-06-06T17:13:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da4800482a4629a05e4bdf5fe9dc78ec0f02259","assignee":{"login":"plribeiro3000","id":672952,"avatar_url":"https://avatars.githubusercontent.com/u/672952?v=3","gravatar_id":"","url":"https://api.github.com/users/plribeiro3000","html_url":"https://github.com/plribeiro3000","followers_url":"https://api.github.com/users/plribeiro3000/followers","following_url":"https://api.github.com/users/plribeiro3000/following{/other_user}","gists_url":"https://api.github.com/users/plribeiro3000/gists{/gist_id}","starred_url":"https://api.github.com/users/plribeiro3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plribeiro3000/subscriptions","organizations_url":"https://api.github.com/users/plribeiro3000/orgs","repos_url":"https://api.github.com/users/plribeiro3000/repos","events_url":"https://api.github.com/users/plribeiro3000/events{/privacy}","received_events_url":"https://api.github.com/users/plribeiro3000/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/fog/fog-google/pulls/133/commits","review_comments_url":"https://api.github.com/repos/fog/fog-google/pulls/133/comments","review_comment_url":"https://api.github.com/repos/fog/fog-google/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fog/fog-google/issues/133/comments","statuses_url":"https://api.github.com/repos/fog/fog-google/statuses/d77ac8a7b4f1bacc17018388eb88cdb3a140da76","head":{"label":"Temikus:instgroups","ref":"instgroups","sha":"d77ac8a7b4f1bacc17018388eb88cdb3a140da76","user":{"login":"Temikus","id":2083229,"avatar_url":"https://avatars.githubusercontent.com/u/2083229?v=3","gravatar_id":"","url":"https://api.github.com/users/Temikus","html_url":"https://github.com/Temikus","followers_url":"https://api.github.com/users/Temikus/followers","following_url":"https://api.github.com/users/Temikus/following{/other_user}","gists_url":"https://api.github.com/users/Temikus/gists{/gist_id}","starred_url":"https://api.github.com/users/Temikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temikus/subscriptions","organizations_url":"https://api.github.com/users/Temikus/orgs","repos_url":"https://api.github.com/users/Temikus/repos","events_url":"https://api.github.com/users/Temikus/events{/privacy}","received_events_url":"https://api.github.com/users/Temikus/received_events","type":"User","site_admin":false},"repo":{"id":34577134,"name":"fog-google","full_name":"Temikus/fog-google","owner":{"login":"Temikus","id":2083229,"avatar_url":"https://avatars.githubusercontent.com/u/2083229?v=3","gravatar_id":"","url":"https://api.github.com/users/Temikus","html_url":"https://github.com/Temikus","followers_url":"https://api.github.com/users/Temikus/followers","following_url":"https://api.github.com/users/Temikus/following{/other_user}","gists_url":"https://api.github.com/users/Temikus/gists{/gist_id}","starred_url":"https://api.github.com/users/Temikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temikus/subscriptions","organizations_url":"https://api.github.com/users/Temikus/orgs","repos_url":"https://api.github.com/users/Temikus/repos","events_url":"https://api.github.com/users/Temikus/events{/privacy}","received_events_url":"https://api.github.com/users/Temikus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Temikus/fog-google","description":"","fork":true,"url":"https://api.github.com/repos/Temikus/fog-google","forks_url":"https://api.github.com/repos/Temikus/fog-google/forks","keys_url":"https://api.github.com/repos/Temikus/fog-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Temikus/fog-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Temikus/fog-google/teams","hooks_url":"https://api.github.com/repos/Temikus/fog-google/hooks","issue_events_url":"https://api.github.com/repos/Temikus/fog-google/issues/events{/number}","events_url":"https://api.github.com/repos/Temikus/fog-google/events","assignees_url":"https://api.github.com/repos/Temikus/fog-google/assignees{/user}","branches_url":"https://api.github.com/repos/Temikus/fog-google/branches{/branch}","tags_url":"https://api.github.com/repos/Temikus/fog-google/tags","blobs_url":"https://api.github.com/repos/Temikus/fog-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Temikus/fog-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Temikus/fog-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/Temikus/fog-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Temikus/fog-google/statuses/{sha}","languages_url":"https://api.github.com/repos/Temikus/fog-google/languages","stargazers_url":"https://api.github.com/repos/Temikus/fog-google/stargazers","contributors_url":"https://api.github.com/repos/Temikus/fog-google/contributors","subscribers_url":"https://api.github.com/repos/Temikus/fog-google/subscribers","subscription_url":"https://api.github.com/repos/Temikus/fog-google/subscription","commits_url":"https://api.github.com/repos/Temikus/fog-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/Temikus/fog-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/Temikus/fog-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/Temikus/fog-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/Temikus/fog-google/contents/{+path}","compare_url":"https://api.github.com/repos/Temikus/fog-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Temikus/fog-google/merges","archive_url":"https://api.github.com/repos/Temikus/fog-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Temikus/fog-google/downloads","issues_url":"https://api.github.com/repos/Temikus/fog-google/issues{/number}","pulls_url":"https://api.github.com/repos/Temikus/fog-google/pulls{/number}","milestones_url":"https://api.github.com/repos/Temikus/fog-google/milestones{/number}","notifications_url":"https://api.github.com/repos/Temikus/fog-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Temikus/fog-google/labels{/name}","releases_url":"https://api.github.com/repos/Temikus/fog-google/releases{/id}","deployments_url":"https://api.github.com/repos/Temikus/fog-google/deployments","created_at":"2015-04-25T16:56:08Z","updated_at":"2016-02-27T19:21:57Z","pushed_at":"2016-06-06T13:36:56Z","git_url":"git://github.com/Temikus/fog-google.git","ssh_url":"git@github.com:Temikus/fog-google.git","clone_url":"https://github.com/Temikus/fog-google.git","svn_url":"https://github.com/Temikus/fog-google","homepage":null,"size":695,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fog:master","ref":"master","sha":"12173a3dfd3808e80bd0d0adb278c51c9539600c","user":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"repo":{"id":29195078,"name":"fog-google","full_name":"fog/fog-google","owner":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fog/fog-google","description":"Fog for Google Cloud Platform","fork":false,"url":"https://api.github.com/repos/fog/fog-google","forks_url":"https://api.github.com/repos/fog/fog-google/forks","keys_url":"https://api.github.com/repos/fog/fog-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fog/fog-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fog/fog-google/teams","hooks_url":"https://api.github.com/repos/fog/fog-google/hooks","issue_events_url":"https://api.github.com/repos/fog/fog-google/issues/events{/number}","events_url":"https://api.github.com/repos/fog/fog-google/events","assignees_url":"https://api.github.com/repos/fog/fog-google/assignees{/user}","branches_url":"https://api.github.com/repos/fog/fog-google/branches{/branch}","tags_url":"https://api.github.com/repos/fog/fog-google/tags","blobs_url":"https://api.github.com/repos/fog/fog-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fog/fog-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fog/fog-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/fog/fog-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fog/fog-google/statuses/{sha}","languages_url":"https://api.github.com/repos/fog/fog-google/languages","stargazers_url":"https://api.github.com/repos/fog/fog-google/stargazers","contributors_url":"https://api.github.com/repos/fog/fog-google/contributors","subscribers_url":"https://api.github.com/repos/fog/fog-google/subscribers","subscription_url":"https://api.github.com/repos/fog/fog-google/subscription","commits_url":"https://api.github.com/repos/fog/fog-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/fog/fog-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/fog/fog-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/fog/fog-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/fog/fog-google/contents/{+path}","compare_url":"https://api.github.com/repos/fog/fog-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fog/fog-google/merges","archive_url":"https://api.github.com/repos/fog/fog-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fog/fog-google/downloads","issues_url":"https://api.github.com/repos/fog/fog-google/issues{/number}","pulls_url":"https://api.github.com/repos/fog/fog-google/pulls{/number}","milestones_url":"https://api.github.com/repos/fog/fog-google/milestones{/number}","notifications_url":"https://api.github.com/repos/fog/fog-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fog/fog-google/labels{/name}","releases_url":"https://api.github.com/repos/fog/fog-google/releases{/id}","deployments_url":"https://api.github.com/repos/fog/fog-google/deployments","created_at":"2015-01-13T15:02:24Z","updated_at":"2016-05-31T13:38:12Z","pushed_at":"2016-06-06T13:36:57Z","git_url":"git://github.com/fog/fog-google.git","ssh_url":"git@github.com:fog/fog-google.git","clone_url":"https://github.com/fog/fog-google.git","svn_url":"https://github.com/fog/fog-google","homepage":"","size":768,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":28,"forks":33,"open_issues":28,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fog/fog-google/pulls/133"},"html":{"href":"https://github.com/fog/fog-google/pull/133"},"issue":{"href":"https://api.github.com/repos/fog/fog-google/issues/133"},"comments":{"href":"https://api.github.com/repos/fog/fog-google/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/fog/fog-google/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/fog/fog-google/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fog/fog-google/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/fog/fog-google/statuses/d77ac8a7b4f1bacc17018388eb88cdb3a140da76"}}}}
{"actor":{"display_login":"Temikus"}}