{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2859","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2859/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2859/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2859/events","html_url":"https://github.com/openshift/openshift-ansible/pull/2859","id":191564293,"number":2859,"title":"Cleanup ovs file and restart docker on every upgrade.","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"labels":[{"id":484442518,"url":"https://api.github.com/repos/openshift/openshift-ansible/labels/backport/3.4","name":"backport/3.4","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-11-24T16:57:29Z","updated_at":"2016-11-30T15:30:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2859","html_url":"https://github.com/openshift/openshift-ansible/pull/2859","diff_url":"https://github.com/openshift/openshift-ansible/pull/2859.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2859.patch"},"body":"In 3.3 one of our services lays down a systemd drop-in for configuring\r\nDocker networking to use lbr0. In 3.4, this has been changed but the\r\nfile must be cleaned up manually by us.\r\n\r\nHowever, after removing the file docker requires a restart. This had big\r\nimplications particularly in containerized environments where upgrade is\r\na very fragile series of upgrading and service restarts.\r\n\r\nTo avoid double docker restarts, and thus double service restarts in\r\ncontainerized environments, this change does the following:\r\n\r\n- Skip restart during docker upgrade, if it is required. We will restart\r\n  on our own later.\r\n- Skip containerized service restarts when we upgrade the services\r\n  themselves.\r\n- Clean shutdown of all containerized services.\r\n- Restart Docker. (always, previously this only happened if it needed an\r\n  upgrade)\r\n- Ensure all containerized services are restarted.\r\n- Restart rpm node services. (always)\r\n- Mark node schedulable again.\r\n\r\nAt the end of this process, docker0 should be back on the system.\r\n\r\nBug: https://bugzilla.redhat.com/show_bug.cgi?id=1395069"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/263902864","html_url":"https://github.com/openshift/openshift-ansible/pull/2859#issuecomment-263902864","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2859","id":263902864,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T15:30:16Z","updated_at":"2016-11-30T15:30:16Z","body":"5c24cf417b08e0b427435d1bd5d27a4b03467092 - State: success - All Test Contexts: \"aos-ci-jenkins/OS_3.3_NOT_containerized, aos-ci-jenkins/OS_3.3_NOT_containerized_e2e_tests\" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.3,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-545/5c24cf417b08e0b427435d1bd5d27a4b03467092.txt"}}
{"actor":{"display_login":"openshift-bot"}}