{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/56093100","id":56093100,"diff_hunk":"@@ -233,6 +234,22 @@ def actual_test_processes(parallel):\n         return parallel\n \n \n+class ActionSelenium(argparse.Action):\n+    \"\"\"\n+    Validate the comma-separated list of requested browsers.\n+    \"\"\"\n+    def __call__(self, parser, namespace, values, option_string=None):\n+        browsers = values.split(',')\n+        for browser in browsers:\n+            try:\n+                # Attempt to create class instance to see if everything is fine.\n+                import_string('selenium.webdriver.%s.webdriver.WebDriver' % browser)\n+            except ImportError:\n+                msg = \"Selenium specifications not valid or corresponding WebDriver not installed: %s\" % browser","path":"tests/runtests.py","position":37,"original_position":37,"commit_id":"fe5d26beee2d0ab100553fe576147957dec4cd7e","original_commit_id":"fe5d26beee2d0ab100553fe576147957dec4cd7e","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"`\"Selenium browser specification '%s' is not valid.\"`","created_at":"2016-03-14T23:21:23Z","updated_at":"2016-03-14T23:21:23Z","html_url":"https://github.com/django/django/pull/6272#discussion_r56093100","pull_request_url":"https://api.github.com/repos/django/django/pulls/6272","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/56093100"},"html":{"href":"https://github.com/django/django/pull/6272#discussion_r56093100"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/6272"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/6272","id":62608803,"html_url":"https://github.com/django/django/pull/6272","diff_url":"https://github.com/django/django/pull/6272.diff","patch_url":"https://github.com/django/django/pull/6272.patch","issue_url":"https://api.github.com/repos/django/django/issues/6272","number":6272,"state":"open","locked":false,"title":"Fixed #25364 -- Added generic way to test on all browsers supported by selenium.","user":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"body":"Now browser names should be passed as an argument to the --selenium flag to\r\nrun selenium tests via ./tests/runtests.py\r\n\r\nThanks Tim Graham, Simon Charette and Moritz Sichert for review and discussion.","created_at":"2016-03-11T21:59:03Z","updated_at":"2016-03-14T23:21:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"804ed72e51425abd79bf23097cb124379b735d31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/6272/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/6272/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/6272/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/fe5d26beee2d0ab100553fe576147957dec4cd7e","head":{"label":"charettes:ticket-25364","ref":"ticket-25364","sha":"fe5d26beee2d0ab100553fe576147957dec4cd7e","user":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"repo":{"id":4164938,"name":"django","full_name":"charettes/django","owner":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charettes/django","description":"The Web framework for perfectionists with deadlines. Now on GitHub.","fork":true,"url":"https://api.github.com/repos/charettes/django","forks_url":"https://api.github.com/repos/charettes/django/forks","keys_url":"https://api.github.com/repos/charettes/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charettes/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charettes/django/teams","hooks_url":"https://api.github.com/repos/charettes/django/hooks","issue_events_url":"https://api.github.com/repos/charettes/django/issues/events{/number}","events_url":"https://api.github.com/repos/charettes/django/events","assignees_url":"https://api.github.com/repos/charettes/django/assignees{/user}","branches_url":"https://api.github.com/repos/charettes/django/branches{/branch}","tags_url":"https://api.github.com/repos/charettes/django/tags","blobs_url":"https://api.github.com/repos/charettes/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charettes/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charettes/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/charettes/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charettes/django/statuses/{sha}","languages_url":"https://api.github.com/repos/charettes/django/languages","stargazers_url":"https://api.github.com/repos/charettes/django/stargazers","contributors_url":"https://api.github.com/repos/charettes/django/contributors","subscribers_url":"https://api.github.com/repos/charettes/django/subscribers","subscription_url":"https://api.github.com/repos/charettes/django/subscription","commits_url":"https://api.github.com/repos/charettes/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/charettes/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/charettes/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/charettes/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/charettes/django/contents/{+path}","compare_url":"https://api.github.com/repos/charettes/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charettes/django/merges","archive_url":"https://api.github.com/repos/charettes/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charettes/django/downloads","issues_url":"https://api.github.com/repos/charettes/django/issues{/number}","pulls_url":"https://api.github.com/repos/charettes/django/pulls{/number}","milestones_url":"https://api.github.com/repos/charettes/django/milestones{/number}","notifications_url":"https://api.github.com/repos/charettes/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charettes/django/labels{/name}","releases_url":"https://api.github.com/repos/charettes/django/releases{/id}","deployments_url":"https://api.github.com/repos/charettes/django/deployments","created_at":"2012-04-28T04:23:16Z","updated_at":"2015-03-10T00:44:54Z","pushed_at":"2016-03-14T21:40:52Z","git_url":"git://github.com/charettes/django.git","ssh_url":"git@github.com:charettes/django.git","clone_url":"https://github.com/charettes/django.git","svn_url":"https://github.com/charettes/django","homepage":"http://www.djangoproject.com/","size":129769,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"204e00c0c57c34528157a739389b6935e4af2f36","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-03-14T20:32:31Z","pushed_at":"2016-03-14T23:01:11Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":183623,"stargazers_count":18488,"watchers_count":18488,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7504,"mirror_url":null,"open_issues_count":77,"forks":7504,"open_issues":77,"watchers":18488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/6272"},"html":{"href":"https://github.com/django/django/pull/6272"},"issue":{"href":"https://api.github.com/repos/django/django/issues/6272"},"comments":{"href":"https://api.github.com/repos/django/django/issues/6272/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/6272/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/6272/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/fe5d26beee2d0ab100553fe576147957dec4cd7e"}}}}