{"action":"created","comment":{"url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments/59971973","id":59971973,"diff_hunk":"@@ -27,6 +27,7 @@\n from kingpin.actors.aws import base\n from kingpin.actors import exceptions\n from kingpin.constants import REQUIRED\n+from kingpin.constants import STATE","path":"kingpin/actors/aws/iam.py","position":4,"original_position":4,"commit_id":"dda7b839bcd98596dd46631c8c28b31a96b8380a","original_commit_id":"dbdb7cc47eda73a9f8fb15c725a6114f5fd11d0b","user":{"login":"diranged","id":768067,"avatar_url":"https://avatars.githubusercontent.com/u/768067?v=3","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"body":"I have a thought on how to re-factor this so its more generic, and easier for other actors to use in the future. We can chat on Monday about it. Until then, ignore this code.","created_at":"2016-04-16T18:39:29Z","updated_at":"2016-04-16T18:39:29Z","html_url":"https://github.com/Nextdoor/kingpin/pull/332#discussion_r59971973","pull_request_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments/59971973"},"html":{"href":"https://github.com/Nextdoor/kingpin/pull/332#discussion_r59971973"},"pull_request":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332","id":66690942,"html_url":"https://github.com/Nextdoor/kingpin/pull/332","diff_url":"https://github.com/Nextdoor/kingpin/pull/332.diff","patch_url":"https://github.com/Nextdoor/kingpin/pull/332.patch","issue_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/332","number":332,"state":"open","locked":false,"title":"Allow the Boto library to do its business and find credentials on its own","user":{"login":"diranged","id":768067,"avatar_url":"https://avatars.githubusercontent.com/u/768067?v=3","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"body":"With all of the various ways that AWS creds can be generated, we should\r\njust let the Boto library do its thing and find them. We can mock out\r\nthe appropriate places we need to in the unit tests without interfering\r\nwith the rest of the boto library logic.","created_at":"2016-04-15T19:14:25Z","updated_at":"2016-04-16T18:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2bc27746e0ace7644bfd2d680493f702c679280","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332/commits","review_comments_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332/comments","review_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/332/comments","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/dda7b839bcd98596dd46631c8c28b31a96b8380a","head":{"label":"Nextdoor:iam","ref":"iam","sha":"dda7b839bcd98596dd46631c8c28b31a96b8380a","user":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"repo":{"id":22902460,"name":"kingpin","full_name":"Nextdoor/kingpin","owner":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nextdoor/kingpin","description":"Deployment Automation Engine","fork":false,"url":"https://api.github.com/repos/Nextdoor/kingpin","forks_url":"https://api.github.com/repos/Nextdoor/kingpin/forks","keys_url":"https://api.github.com/repos/Nextdoor/kingpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nextdoor/kingpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nextdoor/kingpin/teams","hooks_url":"https://api.github.com/repos/Nextdoor/kingpin/hooks","issue_events_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/events{/number}","events_url":"https://api.github.com/repos/Nextdoor/kingpin/events","assignees_url":"https://api.github.com/repos/Nextdoor/kingpin/assignees{/user}","branches_url":"https://api.github.com/repos/Nextdoor/kingpin/branches{/branch}","tags_url":"https://api.github.com/repos/Nextdoor/kingpin/tags","blobs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nextdoor/kingpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nextdoor/kingpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/{sha}","languages_url":"https://api.github.com/repos/Nextdoor/kingpin/languages","stargazers_url":"https://api.github.com/repos/Nextdoor/kingpin/stargazers","contributors_url":"https://api.github.com/repos/Nextdoor/kingpin/contributors","subscribers_url":"https://api.github.com/repos/Nextdoor/kingpin/subscribers","subscription_url":"https://api.github.com/repos/Nextdoor/kingpin/subscription","commits_url":"https://api.github.com/repos/Nextdoor/kingpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nextdoor/kingpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nextdoor/kingpin/contents/{+path}","compare_url":"https://api.github.com/repos/Nextdoor/kingpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nextdoor/kingpin/merges","archive_url":"https://api.github.com/repos/Nextdoor/kingpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nextdoor/kingpin/downloads","issues_url":"https://api.github.com/repos/Nextdoor/kingpin/issues{/number}","pulls_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls{/number}","milestones_url":"https://api.github.com/repos/Nextdoor/kingpin/milestones{/number}","notifications_url":"https://api.github.com/repos/Nextdoor/kingpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nextdoor/kingpin/labels{/name}","releases_url":"https://api.github.com/repos/Nextdoor/kingpin/releases{/id}","deployments_url":"https://api.github.com/repos/Nextdoor/kingpin/deployments","created_at":"2014-08-13T04:23:40Z","updated_at":"2016-02-12T22:36:22Z","pushed_at":"2016-04-16T18:37:42Z","git_url":"git://github.com/Nextdoor/kingpin.git","ssh_url":"git@github.com:Nextdoor/kingpin.git","clone_url":"https://github.com/Nextdoor/kingpin.git","svn_url":"https://github.com/Nextdoor/kingpin","homepage":"","size":1058,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":28,"forks":4,"open_issues":28,"watchers":7,"default_branch":"master"}},"base":{"label":"Nextdoor:master","ref":"master","sha":"c1d4750a0c615d1d1aeee87220dc241b10e4c324","user":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"repo":{"id":22902460,"name":"kingpin","full_name":"Nextdoor/kingpin","owner":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nextdoor/kingpin","description":"Deployment Automation Engine","fork":false,"url":"https://api.github.com/repos/Nextdoor/kingpin","forks_url":"https://api.github.com/repos/Nextdoor/kingpin/forks","keys_url":"https://api.github.com/repos/Nextdoor/kingpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nextdoor/kingpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nextdoor/kingpin/teams","hooks_url":"https://api.github.com/repos/Nextdoor/kingpin/hooks","issue_events_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/events{/number}","events_url":"https://api.github.com/repos/Nextdoor/kingpin/events","assignees_url":"https://api.github.com/repos/Nextdoor/kingpin/assignees{/user}","branches_url":"https://api.github.com/repos/Nextdoor/kingpin/branches{/branch}","tags_url":"https://api.github.com/repos/Nextdoor/kingpin/tags","blobs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nextdoor/kingpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nextdoor/kingpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/{sha}","languages_url":"https://api.github.com/repos/Nextdoor/kingpin/languages","stargazers_url":"https://api.github.com/repos/Nextdoor/kingpin/stargazers","contributors_url":"https://api.github.com/repos/Nextdoor/kingpin/contributors","subscribers_url":"https://api.github.com/repos/Nextdoor/kingpin/subscribers","subscription_url":"https://api.github.com/repos/Nextdoor/kingpin/subscription","commits_url":"https://api.github.com/repos/Nextdoor/kingpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nextdoor/kingpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nextdoor/kingpin/contents/{+path}","compare_url":"https://api.github.com/repos/Nextdoor/kingpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nextdoor/kingpin/merges","archive_url":"https://api.github.com/repos/Nextdoor/kingpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nextdoor/kingpin/downloads","issues_url":"https://api.github.com/repos/Nextdoor/kingpin/issues{/number}","pulls_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls{/number}","milestones_url":"https://api.github.com/repos/Nextdoor/kingpin/milestones{/number}","notifications_url":"https://api.github.com/repos/Nextdoor/kingpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nextdoor/kingpin/labels{/name}","releases_url":"https://api.github.com/repos/Nextdoor/kingpin/releases{/id}","deployments_url":"https://api.github.com/repos/Nextdoor/kingpin/deployments","created_at":"2014-08-13T04:23:40Z","updated_at":"2016-02-12T22:36:22Z","pushed_at":"2016-04-16T18:37:42Z","git_url":"git://github.com/Nextdoor/kingpin.git","ssh_url":"git@github.com:Nextdoor/kingpin.git","clone_url":"https://github.com/Nextdoor/kingpin.git","svn_url":"https://github.com/Nextdoor/kingpin","homepage":"","size":1058,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":28,"forks":4,"open_issues":28,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332"},"html":{"href":"https://github.com/Nextdoor/kingpin/pull/332"},"issue":{"href":"https://api.github.com/repos/Nextdoor/kingpin/issues/332"},"comments":{"href":"https://api.github.com/repos/Nextdoor/kingpin/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/Nextdoor/kingpin/statuses/dda7b839bcd98596dd46631c8c28b31a96b8380a"}}}}