{"action":"created","comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments/71917047","id":71917047,"diff_hunk":"@@ -74,12 +74,13 @@ http: [port: 8888],\n url: [host: \"example.com\"],\n root: \".\",\n cache_static_manifest: \"priv/static/manifest.json\",\n-server: true\n+server: true,\n+version: Mix.Project.config[:version]\n ```\n \n When we run `mix phoenix.server` to start our application, the `server` parameter is automatically set to true. When we're creating a release, however, we need to configure this manually. If we get through this release guide, and we aren't seeing any pages coming from our server, this is a likely culprit.\n \n-When generating a release and performing a hot upgrade, the static assets being served will not be the newest version without setting the root to `.`.  If you do not set root to `.` you will be forced to perform a restart so that the correct static assets are served, effectively changing the hot upgrade to a rolling restart.\n+When generating a release and performing a hot upgrade, the static assets being served will not be the newest version without setting the root to `.` and setting the endpoint version.  If you do not set root or version you will be forced to perform a restart so that the correct static assets are served, effectively changing the hot upgrade to a rolling restart.","path":"deployment/I_exrm_releases.md","position":21,"original_position":21,"commit_id":"f23464334e4e1eb54a55fe4f690bf2b8bf0f2eb0","original_commit_id":"f23464334e4e1eb54a55fe4f690bf2b8bf0f2eb0","user":{"login":"Gazler","id":477511,"avatar_url":"https://avatars.githubusercontent.com/u/477511?v=3","gravatar_id":"","url":"https://api.github.com/users/Gazler","html_url":"https://github.com/Gazler","followers_url":"https://api.github.com/users/Gazler/followers","following_url":"https://api.github.com/users/Gazler/following{/other_user}","gists_url":"https://api.github.com/users/Gazler/gists{/gist_id}","starred_url":"https://api.github.com/users/Gazler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gazler/subscriptions","organizations_url":"https://api.github.com/users/Gazler/orgs","repos_url":"https://api.github.com/users/Gazler/repos","events_url":"https://api.github.com/users/Gazler/events{/privacy}","received_events_url":"https://api.github.com/users/Gazler/received_events","type":"User","site_admin":false},"body":"How about:\r\n\r\n >  If `root` or `version` are not set then we will be forced...\r\n\r\nInstead of \r\n\r\n >  If you do not set root or version you will be forced...","created_at":"2016-07-22T17:43:14Z","updated_at":"2016-07-22T17:43:14Z","html_url":"https://github.com/phoenixframework/phoenix_guides/pull/528#discussion_r71917047","pull_request_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments/71917047"},"html":{"href":"https://github.com/phoenixframework/phoenix_guides/pull/528#discussion_r71917047"},"pull_request":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528","id":75313480,"html_url":"https://github.com/phoenixframework/phoenix_guides/pull/528","diff_url":"https://github.com/phoenixframework/phoenix_guides/pull/528.diff","patch_url":"https://github.com/phoenixframework/phoenix_guides/pull/528.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/528","number":528,"state":"open","locked":false,"title":"Add Endpoint.version for hot upgrades","user":{"login":"orikremer","id":1181527,"avatar_url":"https://avatars.githubusercontent.com/u/1181527?v=3","gravatar_id":"","url":"https://api.github.com/users/orikremer","html_url":"https://github.com/orikremer","followers_url":"https://api.github.com/users/orikremer/followers","following_url":"https://api.github.com/users/orikremer/following{/other_user}","gists_url":"https://api.github.com/users/orikremer/gists{/gist_id}","starred_url":"https://api.github.com/users/orikremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orikremer/subscriptions","organizations_url":"https://api.github.com/users/orikremer/orgs","repos_url":"https://api.github.com/users/orikremer/repos","events_url":"https://api.github.com/users/orikremer/events{/privacy}","received_events_url":"https://api.github.com/users/orikremer/received_events","type":"User","site_admin":false},"body":"As per https://github.com/bitwalker/exrm/issues/206,\r\nsetting the Endpoint.version will trigger code_change during hot upgrade\r\nwhich will in turn reload the asset manifest.","created_at":"2016-06-27T13:45:22Z","updated_at":"2016-07-22T17:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0c1a86860f26a3ab4b332c8a1955cfd3b4d01c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/528/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/f23464334e4e1eb54a55fe4f690bf2b8bf0f2eb0","head":{"label":"orikremer:endpoint_version","ref":"endpoint_version","sha":"f23464334e4e1eb54a55fe4f690bf2b8bf0f2eb0","user":{"login":"orikremer","id":1181527,"avatar_url":"https://avatars.githubusercontent.com/u/1181527?v=3","gravatar_id":"","url":"https://api.github.com/users/orikremer","html_url":"https://github.com/orikremer","followers_url":"https://api.github.com/users/orikremer/followers","following_url":"https://api.github.com/users/orikremer/following{/other_user}","gists_url":"https://api.github.com/users/orikremer/gists{/gist_id}","starred_url":"https://api.github.com/users/orikremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orikremer/subscriptions","organizations_url":"https://api.github.com/users/orikremer/orgs","repos_url":"https://api.github.com/users/orikremer/repos","events_url":"https://api.github.com/users/orikremer/events{/privacy}","received_events_url":"https://api.github.com/users/orikremer/received_events","type":"User","site_admin":false},"repo":{"id":61987153,"name":"phoenix_guides","full_name":"orikremer/phoenix_guides","owner":{"login":"orikremer","id":1181527,"avatar_url":"https://avatars.githubusercontent.com/u/1181527?v=3","gravatar_id":"","url":"https://api.github.com/users/orikremer","html_url":"https://github.com/orikremer","followers_url":"https://api.github.com/users/orikremer/followers","following_url":"https://api.github.com/users/orikremer/following{/other_user}","gists_url":"https://api.github.com/users/orikremer/gists{/gist_id}","starred_url":"https://api.github.com/users/orikremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orikremer/subscriptions","organizations_url":"https://api.github.com/users/orikremer/orgs","repos_url":"https://api.github.com/users/orikremer/repos","events_url":"https://api.github.com/users/orikremer/events{/privacy}","received_events_url":"https://api.github.com/users/orikremer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orikremer/phoenix_guides","description":"User guides for the Phoenix web development framework.","fork":true,"url":"https://api.github.com/repos/orikremer/phoenix_guides","forks_url":"https://api.github.com/repos/orikremer/phoenix_guides/forks","keys_url":"https://api.github.com/repos/orikremer/phoenix_guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orikremer/phoenix_guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orikremer/phoenix_guides/teams","hooks_url":"https://api.github.com/repos/orikremer/phoenix_guides/hooks","issue_events_url":"https://api.github.com/repos/orikremer/phoenix_guides/issues/events{/number}","events_url":"https://api.github.com/repos/orikremer/phoenix_guides/events","assignees_url":"https://api.github.com/repos/orikremer/phoenix_guides/assignees{/user}","branches_url":"https://api.github.com/repos/orikremer/phoenix_guides/branches{/branch}","tags_url":"https://api.github.com/repos/orikremer/phoenix_guides/tags","blobs_url":"https://api.github.com/repos/orikremer/phoenix_guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orikremer/phoenix_guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orikremer/phoenix_guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/orikremer/phoenix_guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orikremer/phoenix_guides/statuses/{sha}","languages_url":"https://api.github.com/repos/orikremer/phoenix_guides/languages","stargazers_url":"https://api.github.com/repos/orikremer/phoenix_guides/stargazers","contributors_url":"https://api.github.com/repos/orikremer/phoenix_guides/contributors","subscribers_url":"https://api.github.com/repos/orikremer/phoenix_guides/subscribers","subscription_url":"https://api.github.com/repos/orikremer/phoenix_guides/subscription","commits_url":"https://api.github.com/repos/orikremer/phoenix_guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/orikremer/phoenix_guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/orikremer/phoenix_guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/orikremer/phoenix_guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/orikremer/phoenix_guides/contents/{+path}","compare_url":"https://api.github.com/repos/orikremer/phoenix_guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orikremer/phoenix_guides/merges","archive_url":"https://api.github.com/repos/orikremer/phoenix_guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orikremer/phoenix_guides/downloads","issues_url":"https://api.github.com/repos/orikremer/phoenix_guides/issues{/number}","pulls_url":"https://api.github.com/repos/orikremer/phoenix_guides/pulls{/number}","milestones_url":"https://api.github.com/repos/orikremer/phoenix_guides/milestones{/number}","notifications_url":"https://api.github.com/repos/orikremer/phoenix_guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orikremer/phoenix_guides/labels{/name}","releases_url":"https://api.github.com/repos/orikremer/phoenix_guides/releases{/id}","deployments_url":"https://api.github.com/repos/orikremer/phoenix_guides/deployments","created_at":"2016-06-26T12:00:58Z","updated_at":"2016-06-26T12:00:59Z","pushed_at":"2016-07-13T15:57:54Z","git_url":"git://github.com/orikremer/phoenix_guides.git","ssh_url":"git@github.com:orikremer/phoenix_guides.git","clone_url":"https://github.com/orikremer/phoenix_guides.git","svn_url":"https://github.com/orikremer/phoenix_guides","homepage":null,"size":1784,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"cfd3b98337bb948fcad1baa3effeb926154b0eae","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":22436876,"name":"phoenix_guides","full_name":"phoenixframework/phoenix_guides","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix_guides","description":"User guides for the Phoenix web development framework.","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix_guides","forks_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/releases{/id}","deployments_url":"https://api.github.com/repos/phoenixframework/phoenix_guides/deployments","created_at":"2014-07-30T17:00:36Z","updated_at":"2016-07-21T15:38:55Z","pushed_at":"2016-07-22T17:27:26Z","git_url":"git://github.com/phoenixframework/phoenix_guides.git","ssh_url":"git@github.com:phoenixframework/phoenix_guides.git","clone_url":"https://github.com/phoenixframework/phoenix_guides.git","svn_url":"https://github.com/phoenixframework/phoenix_guides","homepage":null,"size":1941,"stargazers_count":366,"watchers_count":366,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":34,"forks":207,"open_issues":34,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528"},"html":{"href":"https://github.com/phoenixframework/phoenix_guides/pull/528"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/528"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix_guides/statuses/f23464334e4e1eb54a55fe4f690bf2b8bf0f2eb0"}}}}
{"actor":{"display_login":"Gazler"}}