{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/6998","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/6998/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/6998/comments","events_url":"https://api.github.com/repos/electron/electron/issues/6998/events","html_url":"https://github.com/electron/electron/pull/6998","id":173495720,"number":6998,"title":"Don't serialize external values over IPC","user":{"login":"kevinsawicki","id":671378,"avatar_url":"https://avatars.githubusercontent.com/u/671378?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsawicki","html_url":"https://github.com/kevinsawicki","followers_url":"https://api.github.com/users/kevinsawicki/followers","following_url":"https://api.github.com/users/kevinsawicki/following{/other_user}","gists_url":"https://api.github.com/users/kevinsawicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsawicki/subscriptions","organizations_url":"https://api.github.com/users/kevinsawicki/orgs","repos_url":"https://api.github.com/users/kevinsawicki/repos","events_url":"https://api.github.com/users/kevinsawicki/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsawicki/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-26T16:46:28Z","updated_at":"2016-08-31T11:45:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/6998","html_url":"https://github.com/electron/electron/pull/6998","diff_url":"https://github.com/electron/electron/pull/6998.diff","patch_url":"https://github.com/electron/electron/pull/6998.patch"},"body":"While looking into the crash in #6992 introduced via #6776, I came across https://chromium.googlesource.com/chromium/src/+/0af364dd5cac55192409e88cbb47cb8ce4209683 which states:\r\n\r\n> Don't serialize any DOM objects in V8ValueConverter, it can be extremely slow.\r\nThere have been several attempts to implement this in the past, but none have\r\nactually stuck for various reasons. This patch uses the same technique that\r\nBlink has for structured cloning.\r\n\r\nIt looks like removing the `HasRealNamedCallbackProperty` to get this working initially in #6776 has caused certain objects, specifically the `http.ClientRequest` object in Node to now cause crashes when serialized over IPC.\r\n\r\nThis pull requests adds a `InternalFieldCount` check that prevents the crash but also removes support for DOM objects over IPC.\r\n\r\nI'm not sure if there is another way to fix this to keep DOM objects working but prevent the crashes since the stack trace for the current crash is pretty deep in v8: https://cs.chromium.org/chromium/src/v8/src/objects.cc?l=2981"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/243739514","html_url":"https://github.com/electron/electron/pull/6998#issuecomment-243739514","issue_url":"https://api.github.com/repos/electron/electron/issues/6998","id":243739514,"user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"created_at":"2016-08-31T11:45:22Z","updated_at":"2016-08-31T11:45:22Z","body":"👍 "}}
{"actor":{"display_login":"zcbenz"}}