{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/67194395","id":67194395,"diff_hunk":"@@ -14,20 +14,20 @@ class Clazz { // comment\n \n ~nil\n         console.log(\"test\");\n-~nil                         [consecutive blank lines are disallowed]\n+~nil [consecutive blank lines are disallowed]\n \n     }\n \n \n ~nil\n }\n-~nil  [consecutive blank lines are disallowed]\n+~nil [consecutive blank lines are disallowed]\n \n //Begin whitespace\n // The next two lines of \"code\" contain only tabs or spaces, they are also considered \"blank\" lines\n-~nil                         [consecutive blank lines are disallowed]\n         \n         \n+~ [consecutive blank lines are disallowed]","path":"test/rules/no-consecutive-blank-lines/test.ts.lint","position":null,"original_position":29,"commit_id":"d94a233c7916fd9ff3199cede06c990cb3bb89d6","original_commit_id":"d94a233c7916fd9ff3199cede06c990cb3bb89d6","user":{"login":"chrismbarr","id":463685,"avatar_url":"https://avatars.githubusercontent.com/u/463685?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismbarr","html_url":"https://github.com/chrismbarr","followers_url":"https://api.github.com/users/chrismbarr/followers","following_url":"https://api.github.com/users/chrismbarr/following{/other_user}","gists_url":"https://api.github.com/users/chrismbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismbarr/subscriptions","organizations_url":"https://api.github.com/users/chrismbarr/orgs","repos_url":"https://api.github.com/users/chrismbarr/repos","events_url":"https://api.github.com/users/chrismbarr/events{/privacy}","received_events_url":"https://api.github.com/users/chrismbarr/received_events","type":"User","site_admin":false},"body":"Alright, as long as it works I guess.  I've worked a bit with the microsoft-tslint-conrib repo and I find their test files _much_ easier to read and understand.  They can either write TS code as string inputs or refer to real pass/fail files.  Then they just compare the test result objects which contain the rule failure, with a line/char position.\r\n\r\n[Here's an example of that with string input](https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/tests/NoBannedTermsTests.ts#L16-L27)\r\nAnd [here's an example test](https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/tests/NoOctalLiteralTests.ts#L37-L147) that refers to [a real TS file](https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/test-data/NoOctalLiteralTestInput.ts)","created_at":"2016-06-15T16:16:11Z","updated_at":"2016-06-15T16:16:11Z","html_url":"https://github.com/palantir/tslint/pull/1304#discussion_r67194395","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/1304","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/67194395"},"html":{"href":"https://github.com/palantir/tslint/pull/1304#discussion_r67194395"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/1304"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/1304","id":73210049,"html_url":"https://github.com/palantir/tslint/pull/1304","diff_url":"https://github.com/palantir/tslint/pull/1304.diff","patch_url":"https://github.com/palantir/tslint/pull/1304.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/1304","number":1304,"state":"closed","locked":false,"title":"Fix for no-consecutive-blank-lines to also see whitespace","user":{"login":"chrismbarr","id":463685,"avatar_url":"https://avatars.githubusercontent.com/u/463685?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismbarr","html_url":"https://github.com/chrismbarr","followers_url":"https://api.github.com/users/chrismbarr/followers","following_url":"https://api.github.com/users/chrismbarr/following{/other_user}","gists_url":"https://api.github.com/users/chrismbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismbarr/subscriptions","organizations_url":"https://api.github.com/users/chrismbarr/orgs","repos_url":"https://api.github.com/users/chrismbarr/repos","events_url":"https://api.github.com/users/chrismbarr/events{/privacy}","received_events_url":"https://api.github.com/users/chrismbarr/received_events","type":"User","site_admin":false},"body":"Related: #1249\r\n\r\nNow this rule will consider lines that only contain whitespace as \"blank\" lines.\r\n\r\nNOTE: Currently the tests for this rule fail, but it's because I'm not fully understanding the test file syntax.  All the failures appear to be reported correctly, except for that it reports some extra failures that I can't figure out.  It seems to report an incorrect failure at the beginning for every failure that exists afterwards. Any help here would be appreciated!  Below is a screenshot of the console output.  Note the debug output at the beginning.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/463685/15930441/f44d3976-2e20-11e6-8512-0355fcfbca11.png)\r\n","created_at":"2016-06-09T13:05:38Z","updated_at":"2016-06-15T16:16:11Z","closed_at":"2016-06-15T15:47:59Z","merged_at":"2016-06-15T15:47:59Z","merge_commit_sha":"b428e00efe6d0e9f89a07e9cb3be333ab6b046d9","assignee":{"login":"JKillian","id":1400151,"avatar_url":"https://avatars.githubusercontent.com/u/1400151?v=3","gravatar_id":"","url":"https://api.github.com/users/JKillian","html_url":"https://github.com/JKillian","followers_url":"https://api.github.com/users/JKillian/followers","following_url":"https://api.github.com/users/JKillian/following{/other_user}","gists_url":"https://api.github.com/users/JKillian/gists{/gist_id}","starred_url":"https://api.github.com/users/JKillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKillian/subscriptions","organizations_url":"https://api.github.com/users/JKillian/orgs","repos_url":"https://api.github.com/users/JKillian/repos","events_url":"https://api.github.com/users/JKillian/events{/privacy}","received_events_url":"https://api.github.com/users/JKillian/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/1304/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/1304/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/1304/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/d94a233c7916fd9ff3199cede06c990cb3bb89d6","head":{"label":"chrismbarr:fix-consecutive-blank-lines-to-trim-whitespace","ref":"fix-consecutive-blank-lines-to-trim-whitespace","sha":"d94a233c7916fd9ff3199cede06c990cb3bb89d6","user":{"login":"chrismbarr","id":463685,"avatar_url":"https://avatars.githubusercontent.com/u/463685?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismbarr","html_url":"https://github.com/chrismbarr","followers_url":"https://api.github.com/users/chrismbarr/followers","following_url":"https://api.github.com/users/chrismbarr/following{/other_user}","gists_url":"https://api.github.com/users/chrismbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismbarr/subscriptions","organizations_url":"https://api.github.com/users/chrismbarr/orgs","repos_url":"https://api.github.com/users/chrismbarr/repos","events_url":"https://api.github.com/users/chrismbarr/events{/privacy}","received_events_url":"https://api.github.com/users/chrismbarr/received_events","type":"User","site_admin":false},"repo":{"id":54889340,"name":"tslint","full_name":"chrismbarr/tslint","owner":{"login":"chrismbarr","id":463685,"avatar_url":"https://avatars.githubusercontent.com/u/463685?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismbarr","html_url":"https://github.com/chrismbarr","followers_url":"https://api.github.com/users/chrismbarr/followers","following_url":"https://api.github.com/users/chrismbarr/following{/other_user}","gists_url":"https://api.github.com/users/chrismbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismbarr/subscriptions","organizations_url":"https://api.github.com/users/chrismbarr/orgs","repos_url":"https://api.github.com/users/chrismbarr/repos","events_url":"https://api.github.com/users/chrismbarr/events{/privacy}","received_events_url":"https://api.github.com/users/chrismbarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrismbarr/tslint","description":"An extensible linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/chrismbarr/tslint","forks_url":"https://api.github.com/repos/chrismbarr/tslint/forks","keys_url":"https://api.github.com/repos/chrismbarr/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrismbarr/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrismbarr/tslint/teams","hooks_url":"https://api.github.com/repos/chrismbarr/tslint/hooks","issue_events_url":"https://api.github.com/repos/chrismbarr/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/chrismbarr/tslint/events","assignees_url":"https://api.github.com/repos/chrismbarr/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/chrismbarr/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/chrismbarr/tslint/tags","blobs_url":"https://api.github.com/repos/chrismbarr/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrismbarr/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrismbarr/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrismbarr/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrismbarr/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/chrismbarr/tslint/languages","stargazers_url":"https://api.github.com/repos/chrismbarr/tslint/stargazers","contributors_url":"https://api.github.com/repos/chrismbarr/tslint/contributors","subscribers_url":"https://api.github.com/repos/chrismbarr/tslint/subscribers","subscription_url":"https://api.github.com/repos/chrismbarr/tslint/subscription","commits_url":"https://api.github.com/repos/chrismbarr/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrismbarr/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrismbarr/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrismbarr/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrismbarr/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/chrismbarr/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrismbarr/tslint/merges","archive_url":"https://api.github.com/repos/chrismbarr/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrismbarr/tslint/downloads","issues_url":"https://api.github.com/repos/chrismbarr/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/chrismbarr/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/chrismbarr/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/chrismbarr/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrismbarr/tslint/labels{/name}","releases_url":"https://api.github.com/repos/chrismbarr/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/chrismbarr/tslint/deployments","created_at":"2016-03-28T12:01:13Z","updated_at":"2016-03-28T12:01:15Z","pushed_at":"2016-06-15T11:32:36Z","git_url":"git://github.com/chrismbarr/tslint.git","ssh_url":"git@github.com:chrismbarr/tslint.git","clone_url":"https://github.com/chrismbarr/tslint.git","svn_url":"https://github.com/chrismbarr/tslint","homepage":"http://palantir.github.io/tslint/","size":9714,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"6c3dc5daf289886e77b1b3a158a2441e6e02831d","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":"An extensible linter for the TypeScript language.","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2016-06-15T09:08:26Z","pushed_at":"2016-06-15T15:59:35Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":11034,"stargazers_count":808,"watchers_count":808,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":215,"mirror_url":null,"open_issues_count":214,"forks":215,"open_issues":214,"watchers":808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/1304"},"html":{"href":"https://github.com/palantir/tslint/pull/1304"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/1304"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/1304/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/1304/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/1304/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/d94a233c7916fd9ff3199cede06c990cb3bb89d6"}}}}
{"actor":{"display_login":"chrismbarr"}}