{"action":"created","issue":{"url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/88","repository_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit","labels_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/88/comments","events_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/88/events","html_url":"https://github.com/OvercastNetwork/SportBukkit/issues/88","id":35607707,"number":88,"title":"playEffect is broken","user":{"login":"socram8888","id":515068,"avatar_url":"https://avatars.githubusercontent.com/u/515068?v=3","gravatar_id":"","url":"https://api.github.com/users/socram8888","html_url":"https://github.com/socram8888","followers_url":"https://api.github.com/users/socram8888/followers","following_url":"https://api.github.com/users/socram8888/following{/other_user}","gists_url":"https://api.github.com/users/socram8888/gists{/gist_id}","starred_url":"https://api.github.com/users/socram8888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socram8888/subscriptions","organizations_url":"https://api.github.com/users/socram8888/orgs","repos_url":"https://api.github.com/users/socram8888/repos","events_url":"https://api.github.com/users/socram8888/events{/privacy}","received_events_url":"https://api.github.com/users/socram8888/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-06-12T17:55:14Z","updated_at":"2016-02-08T18:16:27Z","closed_at":null,"body":"Somehow, the following code works correctly on Bukkit, and not on SportBukkit:\r\n```java\r\nworld.playEffect(entity.getLocation(), org.bukkit.Effect.SMOKE, 1);\r\n```\r\nThe effect should have a different direction based on the last parameter. SportBukkit is ignoring it.\r\n\r\nI've also notified some useless code whose purpose I don't understand:\r\n```java\r\n            StringBuilder particleFullName = new StringBuilder();\r\n            particleFullName.append(effect.getName());\r\n\r\n            if (effect.getData() != null && (effect.getData().equals(Material.class) || effect.getData().equals(MaterialData.class))) {\r\n                particleFullName.append('_').append(id);\r\n            }\r\n\r\n            if (effect.getData() != null && effect.getData().equals(MaterialData.class)) {\r\n                particleFullName.append('_').append(data);\r\n            }\r\n\r\n            packet = new PacketPlayOutWorldParticles(effect.getName(), (float)location.getX(), (float)location.getY(), (float)location.getZ(), offsetX, offsetY, offsetZ, particleCount, radius);\r\n        }\r\n```\r\nWhat is the purpouse of particleFullName? Is it something from an older version which is not needed anymore, or is the PacketPlayOutWorldParticles call incorrect and you've forgot to pass the particleFullName parameter?"},"comment":{"url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/comments/181507236","html_url":"https://github.com/OvercastNetwork/SportBukkit/issues/88#issuecomment-181507236","issue_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/88","id":181507236,"user":{"login":"jedediah","id":35292,"avatar_url":"https://avatars.githubusercontent.com/u/35292?v=3","gravatar_id":"","url":"https://api.github.com/users/jedediah","html_url":"https://github.com/jedediah","followers_url":"https://api.github.com/users/jedediah/followers","following_url":"https://api.github.com/users/jedediah/following{/other_user}","gists_url":"https://api.github.com/users/jedediah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedediah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedediah/subscriptions","organizations_url":"https://api.github.com/users/jedediah/orgs","repos_url":"https://api.github.com/users/jedediah/repos","events_url":"https://api.github.com/users/jedediah/events{/privacy}","received_events_url":"https://api.github.com/users/jedediah/received_events","type":"User","site_admin":false},"created_at":"2016-02-08T18:16:27Z","updated_at":"2016-02-08T18:16:27Z","body":"I have no clue what's wrong with the particle code, but I probably won't touch it until after 1.9, at the earliest. An upstream fix would be ideal, since that seems to be where the problem is."}}