{"action":"opened","number":482,"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482","id":55063690,"html_url":"https://github.com/igniterealtime/Openfire/pull/482","diff_url":"https://github.com/igniterealtime/Openfire/pull/482.diff","patch_url":"https://github.com/igniterealtime/Openfire/pull/482.patch","issue_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/482","number":482,"state":"open","locked":false,"title":"solve the memory leak problems which is caused by add LocalMUCRoom ob…","user":{"login":"VicoWu","id":5207388,"avatar_url":"https://avatars.githubusercontent.com/u/5207388?v=3","gravatar_id":"","url":"https://api.github.com/users/VicoWu","html_url":"https://github.com/VicoWu","followers_url":"https://api.github.com/users/VicoWu/followers","following_url":"https://api.github.com/users/VicoWu/following{/other_user}","gists_url":"https://api.github.com/users/VicoWu/gists{/gist_id}","starred_url":"https://api.github.com/users/VicoWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicoWu/subscriptions","organizations_url":"https://api.github.com/users/VicoWu/orgs","repos_url":"https://api.github.com/users/VicoWu/repos","events_url":"https://api.github.com/users/VicoWu/events{/privacy}","received_events_url":"https://api.github.com/users/VicoWu/received_events","type":"User","site_admin":false},"body":"LocalMUCRoom implements interface GroupEventListener and was add to listeners of GroupEventListener when constructed. But it is never removed from the listeners. According to the result of experiment, I do find that after a long time run ,openfire will consume a lot of memory.After analysed \r\nby MAT Tools, I find out that most of memory is consumed by the LocalMUCRoom object.Even user leave the room , it still cannot be reclaimed by GC.This will lead the result that each packet of workgroup will be broadcasted to all rooms in listeners. So, it should be removed from listeners when LocalMUCRoom is removed.\r\nexperiments has been done after I modified the code.Memory leak disappeared and GC can remove LocalMUCRoom objects which are destroyed.","created_at":"2016-01-05T08:00:45Z","updated_at":"2016-01-05T08:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482/commits","review_comments_url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482/comments","review_comment_url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/482/comments","statuses_url":"https://api.github.com/repos/igniterealtime/Openfire/statuses/b366b1d759e544506e47f98e5efaa59e8068be9b","head":{"label":"VicoWu:master","ref":"master","sha":"b366b1d759e544506e47f98e5efaa59e8068be9b","user":{"login":"VicoWu","id":5207388,"avatar_url":"https://avatars.githubusercontent.com/u/5207388?v=3","gravatar_id":"","url":"https://api.github.com/users/VicoWu","html_url":"https://github.com/VicoWu","followers_url":"https://api.github.com/users/VicoWu/followers","following_url":"https://api.github.com/users/VicoWu/following{/other_user}","gists_url":"https://api.github.com/users/VicoWu/gists{/gist_id}","starred_url":"https://api.github.com/users/VicoWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicoWu/subscriptions","organizations_url":"https://api.github.com/users/VicoWu/orgs","repos_url":"https://api.github.com/users/VicoWu/repos","events_url":"https://api.github.com/users/VicoWu/events{/privacy}","received_events_url":"https://api.github.com/users/VicoWu/received_events","type":"User","site_admin":false},"repo":{"id":48669338,"name":"Openfire","full_name":"VicoWu/Openfire","owner":{"login":"VicoWu","id":5207388,"avatar_url":"https://avatars.githubusercontent.com/u/5207388?v=3","gravatar_id":"","url":"https://api.github.com/users/VicoWu","html_url":"https://github.com/VicoWu","followers_url":"https://api.github.com/users/VicoWu/followers","following_url":"https://api.github.com/users/VicoWu/following{/other_user}","gists_url":"https://api.github.com/users/VicoWu/gists{/gist_id}","starred_url":"https://api.github.com/users/VicoWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicoWu/subscriptions","organizations_url":"https://api.github.com/users/VicoWu/orgs","repos_url":"https://api.github.com/users/VicoWu/repos","events_url":"https://api.github.com/users/VicoWu/events{/privacy}","received_events_url":"https://api.github.com/users/VicoWu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VicoWu/Openfire","description":"A XMPP server licensed under the Open Source Apache License.","fork":true,"url":"https://api.github.com/repos/VicoWu/Openfire","forks_url":"https://api.github.com/repos/VicoWu/Openfire/forks","keys_url":"https://api.github.com/repos/VicoWu/Openfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VicoWu/Openfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VicoWu/Openfire/teams","hooks_url":"https://api.github.com/repos/VicoWu/Openfire/hooks","issue_events_url":"https://api.github.com/repos/VicoWu/Openfire/issues/events{/number}","events_url":"https://api.github.com/repos/VicoWu/Openfire/events","assignees_url":"https://api.github.com/repos/VicoWu/Openfire/assignees{/user}","branches_url":"https://api.github.com/repos/VicoWu/Openfire/branches{/branch}","tags_url":"https://api.github.com/repos/VicoWu/Openfire/tags","blobs_url":"https://api.github.com/repos/VicoWu/Openfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VicoWu/Openfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VicoWu/Openfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/VicoWu/Openfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VicoWu/Openfire/statuses/{sha}","languages_url":"https://api.github.com/repos/VicoWu/Openfire/languages","stargazers_url":"https://api.github.com/repos/VicoWu/Openfire/stargazers","contributors_url":"https://api.github.com/repos/VicoWu/Openfire/contributors","subscribers_url":"https://api.github.com/repos/VicoWu/Openfire/subscribers","subscription_url":"https://api.github.com/repos/VicoWu/Openfire/subscription","commits_url":"https://api.github.com/repos/VicoWu/Openfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/VicoWu/Openfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/VicoWu/Openfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/VicoWu/Openfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/VicoWu/Openfire/contents/{+path}","compare_url":"https://api.github.com/repos/VicoWu/Openfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VicoWu/Openfire/merges","archive_url":"https://api.github.com/repos/VicoWu/Openfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VicoWu/Openfire/downloads","issues_url":"https://api.github.com/repos/VicoWu/Openfire/issues{/number}","pulls_url":"https://api.github.com/repos/VicoWu/Openfire/pulls{/number}","milestones_url":"https://api.github.com/repos/VicoWu/Openfire/milestones{/number}","notifications_url":"https://api.github.com/repos/VicoWu/Openfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VicoWu/Openfire/labels{/name}","releases_url":"https://api.github.com/repos/VicoWu/Openfire/releases{/id}","created_at":"2015-12-28T02:20:12Z","updated_at":"2015-12-28T02:20:21Z","pushed_at":"2016-01-05T07:51:30Z","git_url":"git://github.com/VicoWu/Openfire.git","ssh_url":"git@github.com:VicoWu/Openfire.git","clone_url":"https://github.com/VicoWu/Openfire.git","svn_url":"https://github.com/VicoWu/Openfire","homepage":null,"size":765503,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"igniterealtime:master","ref":"master","sha":"c58efa583a4e52fd43bf8affa672634d809c14a3","user":{"login":"igniterealtime","id":5991032,"avatar_url":"https://avatars.githubusercontent.com/u/5991032?v=3","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"repo":{"id":18511687,"name":"Openfire","full_name":"igniterealtime/Openfire","owner":{"login":"igniterealtime","id":5991032,"avatar_url":"https://avatars.githubusercontent.com/u/5991032?v=3","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igniterealtime/Openfire","description":"A XMPP server licensed under the Open Source Apache License.","fork":false,"url":"https://api.github.com/repos/igniterealtime/Openfire","forks_url":"https://api.github.com/repos/igniterealtime/Openfire/forks","keys_url":"https://api.github.com/repos/igniterealtime/Openfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igniterealtime/Openfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igniterealtime/Openfire/teams","hooks_url":"https://api.github.com/repos/igniterealtime/Openfire/hooks","issue_events_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/events{/number}","events_url":"https://api.github.com/repos/igniterealtime/Openfire/events","assignees_url":"https://api.github.com/repos/igniterealtime/Openfire/assignees{/user}","branches_url":"https://api.github.com/repos/igniterealtime/Openfire/branches{/branch}","tags_url":"https://api.github.com/repos/igniterealtime/Openfire/tags","blobs_url":"https://api.github.com/repos/igniterealtime/Openfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igniterealtime/Openfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igniterealtime/Openfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/igniterealtime/Openfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igniterealtime/Openfire/statuses/{sha}","languages_url":"https://api.github.com/repos/igniterealtime/Openfire/languages","stargazers_url":"https://api.github.com/repos/igniterealtime/Openfire/stargazers","contributors_url":"https://api.github.com/repos/igniterealtime/Openfire/contributors","subscribers_url":"https://api.github.com/repos/igniterealtime/Openfire/subscribers","subscription_url":"https://api.github.com/repos/igniterealtime/Openfire/subscription","commits_url":"https://api.github.com/repos/igniterealtime/Openfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/igniterealtime/Openfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/igniterealtime/Openfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/igniterealtime/Openfire/contents/{+path}","compare_url":"https://api.github.com/repos/igniterealtime/Openfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igniterealtime/Openfire/merges","archive_url":"https://api.github.com/repos/igniterealtime/Openfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igniterealtime/Openfire/downloads","issues_url":"https://api.github.com/repos/igniterealtime/Openfire/issues{/number}","pulls_url":"https://api.github.com/repos/igniterealtime/Openfire/pulls{/number}","milestones_url":"https://api.github.com/repos/igniterealtime/Openfire/milestones{/number}","notifications_url":"https://api.github.com/repos/igniterealtime/Openfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igniterealtime/Openfire/labels{/name}","releases_url":"https://api.github.com/repos/igniterealtime/Openfire/releases{/id}","created_at":"2014-04-07T09:12:33Z","updated_at":"2016-01-05T01:20:51Z","pushed_at":"2016-01-05T08:00:46Z","git_url":"git://github.com/igniterealtime/Openfire.git","ssh_url":"git@github.com:igniterealtime/Openfire.git","clone_url":"https://github.com/igniterealtime/Openfire.git","svn_url":"https://github.com/igniterealtime/Openfire","homepage":null,"size":797237,"stargazers_count":651,"watchers_count":651,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":476,"mirror_url":null,"open_issues_count":10,"forks":476,"open_issues":10,"watchers":651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482"},"html":{"href":"https://github.com/igniterealtime/Openfire/pull/482"},"issue":{"href":"https://api.github.com/repos/igniterealtime/Openfire/issues/482"},"comments":{"href":"https://api.github.com/repos/igniterealtime/Openfire/issues/482/comments"},"review_comments":{"href":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482/comments"},"review_comment":{"href":"https://api.github.com/repos/igniterealtime/Openfire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igniterealtime/Openfire/pulls/482/commits"},"statuses":{"href":"https://api.github.com/repos/igniterealtime/Openfire/statuses/b366b1d759e544506e47f98e5efaa59e8068be9b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}