{"action":"closed","number":3127,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/3127","id":91483872,"html_url":"https://github.com/minio/minio/pull/3127","diff_url":"https://github.com/minio/minio/pull/3127.diff","patch_url":"https://github.com/minio/minio/pull/3127.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/3127","number":3127,"state":"closed","locked":false,"title":"Logging: errorIf fatalIf print in the format [file.go:82:funcName()]","user":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"body":"previous output:\r\n```\r\nkrishna@escape:~$ minio server export\r\nFATA[0000] Port unavailable 9000                         cause=listen tcp :9000: bind: address already in use location=serverMain [/home/krishna/gocodeserver-main.go:400]\r\n```\r\n\r\nnew output:\r\n```\r\nkrishna@escape:~$ minio server export\r\nFATA[0000] Port unavailable 9000                         cause=listen tcp :9000: bind: address already in use location=[server-main.go:400:serverMain()]\r\nkrishna@escape:~$ \r\n```\r\n## Description\r\nfuncFromPC() removed, instead callerLocation() which is simpler is used.\r\n\r\nfuncFromPC's shortFile and:\r\n```\r\n-       if shortFile {\r\n-               fn = strings.Replace(file, path.Join(filepath.ToSlash(GOPATH)+\"/src/github.com/minio/minio/cmd/\")+\"/\", \"\", -1)\r\n-               name = strings.Replace(runtime.FuncForPC(pc).Name(), \"github.com/minio/minio/cmd.\", \"\", -1)\r\n-       } else {\r\n-               fn = strings.Replace(file, path.Join(filepath.ToSlash(GOPATH)+\"/src/\")+\"/\", \"\", -1)\r\n-               name = strings.Replace(runtime.FuncForPC(pc).Name(), \"github.com/minio/minio/cmd.\", \"\", -1)\r\n-       }\r\n\r\n```\r\n\r\nthis is no longer useful as all the files are in the cmd package now. So just `filename.go` without any path info should be used.\r\n\r\n\r\n## Motivation and Context\r\nContext: https://github.com/minio/minio/issues/3125\r\n\r\n## How Has This Been Tested?\r\nmanual testing, unit tests.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2016-10-29T09:10:44Z","updated_at":"2016-10-29T09:34:16Z","closed_at":"2016-10-29T09:34:16Z","merged_at":"2016-10-29T09:34:16Z","merge_commit_sha":"0b3282ac9fb6bee6958899bd1924541dc03e955a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/3127/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/3127/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/3127/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/990c59e170e3325ebd8058859aaab4018ec00205","head":{"label":"krishnasrinivas:errorif-fatailif","ref":"errorif-fatailif","sha":"990c59e170e3325ebd8058859aaab4018ec00205","user":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"repo":{"id":39705039,"name":"minio","full_name":"krishnasrinivas/minio","owner":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnasrinivas/minio","description":"Minio Cloud Storage Server","fork":true,"url":"https://api.github.com/repos/krishnasrinivas/minio","forks_url":"https://api.github.com/repos/krishnasrinivas/minio/forks","keys_url":"https://api.github.com/repos/krishnasrinivas/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnasrinivas/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnasrinivas/minio/teams","hooks_url":"https://api.github.com/repos/krishnasrinivas/minio/hooks","issue_events_url":"https://api.github.com/repos/krishnasrinivas/minio/issues/events{/number}","events_url":"https://api.github.com/repos/krishnasrinivas/minio/events","assignees_url":"https://api.github.com/repos/krishnasrinivas/minio/assignees{/user}","branches_url":"https://api.github.com/repos/krishnasrinivas/minio/branches{/branch}","tags_url":"https://api.github.com/repos/krishnasrinivas/minio/tags","blobs_url":"https://api.github.com/repos/krishnasrinivas/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnasrinivas/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnasrinivas/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnasrinivas/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnasrinivas/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnasrinivas/minio/languages","stargazers_url":"https://api.github.com/repos/krishnasrinivas/minio/stargazers","contributors_url":"https://api.github.com/repos/krishnasrinivas/minio/contributors","subscribers_url":"https://api.github.com/repos/krishnasrinivas/minio/subscribers","subscription_url":"https://api.github.com/repos/krishnasrinivas/minio/subscription","commits_url":"https://api.github.com/repos/krishnasrinivas/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnasrinivas/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnasrinivas/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnasrinivas/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/krishnasrinivas/minio/contents/{+path}","compare_url":"https://api.github.com/repos/krishnasrinivas/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnasrinivas/minio/merges","archive_url":"https://api.github.com/repos/krishnasrinivas/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnasrinivas/minio/downloads","issues_url":"https://api.github.com/repos/krishnasrinivas/minio/issues{/number}","pulls_url":"https://api.github.com/repos/krishnasrinivas/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnasrinivas/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnasrinivas/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnasrinivas/minio/labels{/name}","releases_url":"https://api.github.com/repos/krishnasrinivas/minio/releases{/id}","deployments_url":"https://api.github.com/repos/krishnasrinivas/minio/deployments","created_at":"2015-07-25T22:31:14Z","updated_at":"2016-04-18T03:52:13Z","pushed_at":"2016-10-29T09:15:02Z","git_url":"git://github.com/krishnasrinivas/minio.git","ssh_url":"git@github.com:krishnasrinivas/minio.git","clone_url":"https://github.com/krishnasrinivas/minio.git","svn_url":"https://github.com/krishnasrinivas/minio","homepage":"https://minio.io/#minio-server","size":18640,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"79b98b5c25a8424412e79c7889720f745e8687a8","user":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an Amazon S3 compatible object storage server.","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2016-10-28T21:23:23Z","pushed_at":"2016-10-29T09:34:16Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io","size":19424,"stargazers_count":4394,"watchers_count":4394,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"open_issues_count":78,"forks":274,"open_issues":78,"watchers":4394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/3127"},"html":{"href":"https://github.com/minio/minio/pull/3127"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/3127"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/3127/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/3127/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/3127/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/990c59e170e3325ebd8058859aaab4018ec00205"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":15,"deletions":91,"changed_files":5}}
{"actor":{"display_login":"harshavardhana"}}