{"action":"created","issue":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/355","repository_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk","labels_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/355/labels{/name}","comments_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/355/comments","events_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/355/events","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/355","id":156244196,"number":355,"title":"[WebCL] Include what you use.","user":{"login":"hujiajie","id":1270848,"avatar_url":"https://avatars.githubusercontent.com/u/1270848?v=3","gravatar_id":"","url":"https://api.github.com/users/hujiajie","html_url":"https://github.com/hujiajie","followers_url":"https://api.github.com/users/hujiajie/followers","following_url":"https://api.github.com/users/hujiajie/following{/other_user}","gists_url":"https://api.github.com/users/hujiajie/gists{/gist_id}","starred_url":"https://api.github.com/users/hujiajie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hujiajie/subscriptions","organizations_url":"https://api.github.com/users/hujiajie/orgs","repos_url":"https://api.github.com/users/hujiajie/repos","events_url":"https://api.github.com/users/hujiajie/events{/privacy}","received_events_url":"https://api.github.com/users/hujiajie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-05-23T10:04:15Z","updated_at":"2016-08-09T10:34:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/pulls/355","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/355","diff_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/355.diff","patch_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/355.patch"},"body":"The patch set aims to fix most (if not all) style issues to follow the principle of including what you use. The implementation of some non-trivial methods / ctors / dtors are moved from .h to .cpp so that the principle can be well followed. A self-contained header should include the necessary headers so that we can simply use it in other files without worrying about its dependencies. On the other hand, a header file should only include what is really needed and use forward declarations for external symbols if possible. This will not only help in faster compilation and fewer recompilation, but also avoid circular header inclusion which can actually cause compilation errors that are hard to diagnose in some cases. Also, if a header file is needed, then it should be included *explicitly*, instead of depending on the fact that it is *implicitly* included by some other random files which are subject to change in the future."},"comment":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/comments/238515836","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/355#issuecomment-238515836","issue_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/355","id":238515836,"user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T10:34:44Z","updated_at":"2016-08-09T10:34:44Z","body":"master is now on M52. Are there any plans to continue work on this PR or can it be discarded?"}}
{"actor":{"display_login":"rakuco"}}