{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/82065489","pull_request_review_id":2999211,"id":82065489,"diff_hunk":"@@ -563,6 +563,64 @@ var Builtins = map[string][]Builtin{\n \n \t// Timestamp/Date functions.\n \n+\t\"strftime\": {\n+\t\tBuiltin{\n+\t\t\tTypes:      ArgTypes{TypeTimestamp, TypeString},\n+\t\t\tReturnType: TypeString,\n+\t\t\tfn: func(_ *EvalContext, args DTuple) (Datum, error) {\n+\t\t\t\tfromTime := args[0].(*DTimestamp).Time\n+\t\t\t\tformat := string(*args[1].(*DString))\n+\t\t\t\tt, err := timeutil.Strftime(fromTime, format)\n+\t\t\t\tif err != nil {\n+\t\t\t\t\treturn nil, err\n+\t\t\t\t}\n+\t\t\t\treturn NewDString(t), nil\n+\t\t\t},\n+\t\t},\n+\t\tBuiltin{\n+\t\t\tTypes:      ArgTypes{TypeDate, TypeString},\n+\t\t\tReturnType: TypeString,\n+\t\t\tfn: func(_ *EvalContext, args DTuple) (Datum, error) {\n+\t\t\t\tfromTime := time.Unix(int64(*args[0].(*DDate))*secondsInDay, 0).UTC()\n+\t\t\t\tformat := string(*args[1].(*DString))\n+\t\t\t\tt, err := timeutil.Strftime(fromTime, format)\n+\t\t\t\tif err != nil {\n+\t\t\t\t\treturn nil, err\n+\t\t\t\t}\n+\t\t\t\treturn NewDString(t), nil\n+\t\t\t},\n+\t\t},\n+\t\tBuiltin{\n+\t\t\tTypes:      ArgTypes{TypeTimestampTZ, TypeString},\n+\t\t\tReturnType: TypeString,\n+\t\t\tfn: func(_ *EvalContext, args DTuple) (Datum, error) {\n+\t\t\t\tfromTime := args[0].(*DTimestampTZ).Time\n+\t\t\t\tformat := string(*args[1].(*DString))\n+\t\t\t\tt, err := timeutil.Strftime(fromTime, format)\n+\t\t\t\tif err != nil {\n+\t\t\t\t\treturn nil, err\n+\t\t\t\t}\n+\t\t\t\treturn NewDString(t), nil\n+\t\t\t},\n+\t\t},\n+\t},\n+\n+\t\"strptime\": {\n+\t\tBuiltin{\n+\t\t\tTypes:      ArgTypes{TypeString, TypeString},\n+\t\t\tReturnType: TypeTimestamp,","path":"sql/parser/builtins.go","position":49,"original_position":49,"commit_id":"27ee422724e93869195783a5e479e61724a10a06","original_commit_id":"27ee422724e93869195783a5e479e61724a10a06","user":{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"body":"how about `TypeTimestampTZ` here?","created_at":"2016-10-05T20:40:45Z","updated_at":"2016-10-05T20:40:45Z","html_url":"https://github.com/cockroachdb/cockroach/pull/9762#discussion_r82065489","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/82065489"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/9762#discussion_r82065489"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762","id":88136292,"html_url":"https://github.com/cockroachdb/cockroach/pull/9762","diff_url":"https://github.com/cockroachdb/cockroach/pull/9762.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/9762.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9762","number":9762,"state":"open","locked":false,"title":"sql: implement strptime/strftime.","user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/9762)\n<!-- Reviewable:end -->\n","created_at":"2016-10-05T18:58:08Z","updated_at":"2016-10-05T20:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1faf2c8f8568809efdbb36e001f3380d465e0f0","assignee":{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"assignees":[{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9762/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/27ee422724e93869195783a5e479e61724a10a06","head":{"label":"knz:sql-time-functions","ref":"sql-time-functions","sha":"27ee422724e93869195783a5e479e61724a10a06","user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"repo":{"id":49441405,"name":"cockroach","full_name":"knz/cockroach","owner":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knz/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/knz/cockroach","forks_url":"https://api.github.com/repos/knz/cockroach/forks","keys_url":"https://api.github.com/repos/knz/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knz/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knz/cockroach/teams","hooks_url":"https://api.github.com/repos/knz/cockroach/hooks","issue_events_url":"https://api.github.com/repos/knz/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/knz/cockroach/events","assignees_url":"https://api.github.com/repos/knz/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/knz/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/knz/cockroach/tags","blobs_url":"https://api.github.com/repos/knz/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knz/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knz/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/knz/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knz/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/knz/cockroach/languages","stargazers_url":"https://api.github.com/repos/knz/cockroach/stargazers","contributors_url":"https://api.github.com/repos/knz/cockroach/contributors","subscribers_url":"https://api.github.com/repos/knz/cockroach/subscribers","subscription_url":"https://api.github.com/repos/knz/cockroach/subscription","commits_url":"https://api.github.com/repos/knz/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/knz/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/knz/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/knz/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/knz/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/knz/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knz/cockroach/merges","archive_url":"https://api.github.com/repos/knz/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knz/cockroach/downloads","issues_url":"https://api.github.com/repos/knz/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/knz/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/knz/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/knz/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knz/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/knz/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/knz/cockroach/deployments","created_at":"2016-01-11T17:11:07Z","updated_at":"2016-07-17T22:35:02Z","pushed_at":"2016-10-05T19:33:57Z","git_url":"git://github.com/knz/cockroach.git","ssh_url":"git@github.com:knz/cockroach.git","clone_url":"https://github.com/knz/cockroach.git","svn_url":"https://github.com/knz/cockroach","homepage":"http://www.cockroachlabs.com","size":198468,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"5f288d0e7bdede9f568f1a2ccd334bd6a04dadc2","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-10-05T13:11:24Z","pushed_at":"2016-10-05T20:23:44Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":361515,"stargazers_count":7665,"watchers_count":7665,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":763,"mirror_url":null,"open_issues_count":714,"forks":763,"open_issues":714,"watchers":7665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/9762"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/9762"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/9762/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9762/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/27ee422724e93869195783a5e479e61724a10a06"}}}}
{"actor":{"display_login":"dt"}}