{"action":"opened","number":131,"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131","id":88332921,"html_url":"https://github.com/F5Networks/f5-openstack-lbaasv1/pull/131","diff_url":"https://github.com/F5Networks/f5-openstack-lbaasv1/pull/131.diff","patch_url":"https://github.com/F5Networks/f5-openstack-lbaasv1/pull/131.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/131","number":131,"state":"open","locked":false,"title":"added config item f5_http_rps_throttle and a proper HTTP rps iRule","user":{"login":"jgruber","id":1444377,"avatar_url":"https://avatars.githubusercontent.com/u/1444377?v=3","gravatar_id":"","url":"https://api.github.com/users/jgruber","html_url":"https://github.com/jgruber","followers_url":"https://api.github.com/users/jgruber/followers","following_url":"https://api.github.com/users/jgruber/following{/other_user}","gists_url":"https://api.github.com/users/jgruber/gists{/gist_id}","starred_url":"https://api.github.com/users/jgruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgruber/subscriptions","organizations_url":"https://api.github.com/users/jgruber/orgs","repos_url":"https://api.github.com/users/jgruber/repos","events_url":"https://api.github.com/users/jgruber/events{/privacy}","received_events_url":"https://api.github.com/users/jgruber/received_events","type":"User","site_admin":false},"body":"@<reviewer_id>\r\n#### What issues does this address?\r\nFixes #127 \r\nWIP #127 \r\n...\r\n\r\n#### What's this change do?\r\nCreates a agent config entry to toggle if VIP connection limit should be an L4 connection limit or an L7 HTTP rps limit for HTTP VIPs. By default the VIP will stick to current tested L4 connection limits. \r\n\r\nIf the agent config set the f5_http_rps_throttle setting to True, a new iRule is used to implement the HTTP rps throttle.  The new iRule was tested on 11.x and 12.x and is CMP friendly. The old iRule did not work. It never engaged a throttle limit.\r\n\r\n#### Where should the reviewer start?\r\nCreate an LBaaSv1 Pool and VIP.with no changes to the agent config. On the VIP set the protocol to HTTP and connection_limit attribute > 1. Confirm the BIG-IP virtual server connection limit attribute tracks the VIP connect_limit attribue.\r\n\r\nCreate and LBaaSv1 Pool and VIP with the f5_http_rps_throttle = True set in the agent config. On the VIP set the protocol to HTTP connection_limit attribute > 1. Confirm that the agent created the HTTP throttle iRule in the client folder and the iRule was associated with the BIG-IP virtual server created for the VIP.\r\n\r\n#### Any background context?\r\nThe only iRule did not work as intended.","created_at":"2016-10-06T20:15:28Z","updated_at":"2016-10-06T20:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/131/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/statuses/0f2696561d5c35ab65fdeb029e81b33d73862bc5","head":{"label":"jgruber:issue-127","ref":"issue-127","sha":"0f2696561d5c35ab65fdeb029e81b33d73862bc5","user":{"login":"jgruber","id":1444377,"avatar_url":"https://avatars.githubusercontent.com/u/1444377?v=3","gravatar_id":"","url":"https://api.github.com/users/jgruber","html_url":"https://github.com/jgruber","followers_url":"https://api.github.com/users/jgruber/followers","following_url":"https://api.github.com/users/jgruber/following{/other_user}","gists_url":"https://api.github.com/users/jgruber/gists{/gist_id}","starred_url":"https://api.github.com/users/jgruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgruber/subscriptions","organizations_url":"https://api.github.com/users/jgruber/orgs","repos_url":"https://api.github.com/users/jgruber/repos","events_url":"https://api.github.com/users/jgruber/events{/privacy}","received_events_url":"https://api.github.com/users/jgruber/received_events","type":"User","site_admin":false},"repo":{"id":69527340,"name":"f5-openstack-lbaasv1","full_name":"jgruber/f5-openstack-lbaasv1","owner":{"login":"jgruber","id":1444377,"avatar_url":"https://avatars.githubusercontent.com/u/1444377?v=3","gravatar_id":"","url":"https://api.github.com/users/jgruber","html_url":"https://github.com/jgruber","followers_url":"https://api.github.com/users/jgruber/followers","following_url":"https://api.github.com/users/jgruber/following{/other_user}","gists_url":"https://api.github.com/users/jgruber/gists{/gist_id}","starred_url":"https://api.github.com/users/jgruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgruber/subscriptions","organizations_url":"https://api.github.com/users/jgruber/orgs","repos_url":"https://api.github.com/users/jgruber/repos","events_url":"https://api.github.com/users/jgruber/events{/privacy}","received_events_url":"https://api.github.com/users/jgruber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgruber/f5-openstack-lbaasv1","description":"OpenStack Neutron LBaaSv1 plugin and agent to control F5® BIG-IP® devices","fork":true,"url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1","forks_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/forks","keys_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/teams","hooks_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/hooks","issue_events_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/issues/events{/number}","events_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/events","assignees_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/assignees{/user}","branches_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/branches{/branch}","tags_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/tags","blobs_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/statuses/{sha}","languages_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/languages","stargazers_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/stargazers","contributors_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/contributors","subscribers_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/subscribers","subscription_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/subscription","commits_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/contents/{+path}","compare_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/merges","archive_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/downloads","issues_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/issues{/number}","pulls_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/pulls{/number}","milestones_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/milestones{/number}","notifications_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/labels{/name}","releases_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/releases{/id}","deployments_url":"https://api.github.com/repos/jgruber/f5-openstack-lbaasv1/deployments","created_at":"2016-09-29T03:32:21Z","updated_at":"2016-09-29T03:32:22Z","pushed_at":"2016-09-29T04:46:20Z","git_url":"git://github.com/jgruber/f5-openstack-lbaasv1.git","ssh_url":"git@github.com:jgruber/f5-openstack-lbaasv1.git","clone_url":"https://github.com/jgruber/f5-openstack-lbaasv1.git","svn_url":"https://github.com/jgruber/f5-openstack-lbaasv1","homepage":"http://f5-openstack-lbaasv1.rtfd.org/en/","size":13054,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:1.0","ref":"1.0","sha":"380df294a4cae6ddc548838eb52b30382620d082","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":49971166,"name":"f5-openstack-lbaasv1","full_name":"F5Networks/f5-openstack-lbaasv1","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-openstack-lbaasv1","description":"OpenStack Neutron LBaaSv1 plugin and agent to control F5® BIG-IP® devices","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1","forks_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/deployments","created_at":"2016-01-19T17:47:26Z","updated_at":"2016-10-05T12:42:10Z","pushed_at":"2016-10-06T20:15:28Z","git_url":"git://github.com/F5Networks/f5-openstack-lbaasv1.git","ssh_url":"git@github.com:F5Networks/f5-openstack-lbaasv1.git","clone_url":"https://github.com/F5Networks/f5-openstack-lbaasv1.git","svn_url":"https://github.com/F5Networks/f5-openstack-lbaasv1","homepage":"http://f5-openstack-lbaasv1.rtfd.org/en/","size":13183,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":23,"forks":9,"open_issues":23,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131"},"html":{"href":"https://github.com/F5Networks/f5-openstack-lbaasv1/pull/131"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/131"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-lbaasv1/statuses/0f2696561d5c35ab65fdeb029e81b33d73862bc5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":31,"changed_files":3}}
{"actor":{"display_login":"jgruber"}}