{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Security/issues/905","repository_url":"https://api.github.com/repos/aspnet/Security","labels_url":"https://api.github.com/repos/aspnet/Security/issues/905/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Security/issues/905/comments","events_url":"https://api.github.com/repos/aspnet/Security/issues/905/events","html_url":"https://github.com/aspnet/Security/pull/905","id":166438305,"number":905,"title":"Handle  the remote authentication failure gracefully","user":{"login":"troydai","id":1329240,"avatar_url":"https://avatars.githubusercontent.com/u/1329240?v=3","gravatar_id":"","url":"https://api.github.com/users/troydai","html_url":"https://github.com/troydai","followers_url":"https://api.github.com/users/troydai/followers","following_url":"https://api.github.com/users/troydai/following{/other_user}","gists_url":"https://api.github.com/users/troydai/gists{/gist_id}","starred_url":"https://api.github.com/users/troydai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troydai/subscriptions","organizations_url":"https://api.github.com/users/troydai/orgs","repos_url":"https://api.github.com/users/troydai/repos","events_url":"https://api.github.com/users/troydai/events{/privacy}","received_events_url":"https://api.github.com/users/troydai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet/Security/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-19T21:19:20Z","updated_at":"2016-07-26T05:58:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/Security/pulls/905","html_url":"https://github.com/aspnet/Security/pull/905","diff_url":"https://github.com/aspnet/Security/pull/905.diff","patch_url":"https://github.com/aspnet/Security/pull/905.patch"},"body":"Address issue #53 \r\n\r\nError message now:\r\n![image](https://cloud.githubusercontent.com/assets/1329240/16966868/5c65a62e-4dbb-11e6-8d3b-ef17069e7f58.png)\r\n\r\nThe `GoogleHandler` throws when the response from back channel is out of 2XX range. The exception neither provides sufficient information for user to correct the error or is handled gracefully in `OAuthHandler`\r\n\r\nThe PR contains two commit. The first one is purely for refactoring and readability improvement. For the actual logic change you can focus on the [second commit](https://github.com/aspnet/Security/commit/967c7cdeb6838368ac775a526b84abd164dd6fae)"},"comment":{"url":"https://api.github.com/repos/aspnet/Security/issues/comments/235170456","html_url":"https://github.com/aspnet/Security/pull/905#issuecomment-235170456","issue_url":"https://api.github.com/repos/aspnet/Security/issues/905","id":235170456,"user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T05:58:10Z","updated_at":"2016-07-26T05:58:10Z","body":"Looks good overall, I would suggest adding a test or two to ensure that various exceptions (caught/uncaught) do the right thing now against the base class (both with the built in middlewares and a custom derived one)"}}
{"actor":{"display_login":"HaoK"}}