{"action":"created","issue":{"url":"https://api.github.com/repos/jOOQ/jOOL/issues/251","repository_url":"https://api.github.com/repos/jOOQ/jOOL","labels_url":"https://api.github.com/repos/jOOQ/jOOL/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/jOOQ/jOOL/issues/251/comments","events_url":"https://api.github.com/repos/jOOQ/jOOL/issues/251/events","html_url":"https://github.com/jOOQ/jOOL/pull/251","id":172416009,"number":251,"title":"Unchecked.objIntConsumer doesn't throw IllegalStateException as it should","user":{"login":"Xaerxess","id":121382,"avatar_url":"https://avatars.githubusercontent.com/u/121382?v=3","gravatar_id":"","url":"https://api.github.com/users/Xaerxess","html_url":"https://github.com/Xaerxess","followers_url":"https://api.github.com/users/Xaerxess/followers","following_url":"https://api.github.com/users/Xaerxess/following{/other_user}","gists_url":"https://api.github.com/users/Xaerxess/gists{/gist_id}","starred_url":"https://api.github.com/users/Xaerxess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xaerxess/subscriptions","organizations_url":"https://api.github.com/users/Xaerxess/orgs","repos_url":"https://api.github.com/users/Xaerxess/repos","events_url":"https://api.github.com/users/Xaerxess/events{/privacy}","received_events_url":"https://api.github.com/users/Xaerxess/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jOOQ/jOOL/labels/P:%20Medium","name":"P: Medium","color":"ffaaaa"},{"url":"https://api.github.com/repos/jOOQ/jOOL/labels/T:%20Enhancement","name":"T: Enhancement","color":"cccccc"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jOOQ/jOOL/milestones/10","html_url":"https://github.com/jOOQ/jOOL/milestones/Version%200.9.12","labels_url":"https://api.github.com/repos/jOOQ/jOOL/milestones/10/labels","id":1550798,"number":10,"title":"Version 0.9.12","description":"","creator":{"login":"lukaseder","id":734593,"avatar_url":"https://avatars.githubusercontent.com/u/734593?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaseder","html_url":"https://github.com/lukaseder","followers_url":"https://api.github.com/users/lukaseder/followers","following_url":"https://api.github.com/users/lukaseder/following{/other_user}","gists_url":"https://api.github.com/users/lukaseder/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaseder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaseder/subscriptions","organizations_url":"https://api.github.com/users/lukaseder/orgs","repos_url":"https://api.github.com/users/lukaseder/repos","events_url":"https://api.github.com/users/lukaseder/events{/privacy}","received_events_url":"https://api.github.com/users/lukaseder/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":22,"state":"open","created_at":"2016-01-29T08:37:16Z","updated_at":"2016-08-22T13:47:26Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-08-22T10:16:11Z","updated_at":"2016-08-22T13:48:33Z","closed_at":"2016-08-22T13:47:26Z","pull_request":{"url":"https://api.github.com/repos/jOOQ/jOOL/pulls/251","html_url":"https://github.com/jOOQ/jOOL/pull/251","diff_url":"https://github.com/jOOQ/jOOL/pull/251.diff","patch_url":"https://github.com/jOOQ/jOOL/pull/251.patch"},"body":"I added missing `IllegalStateException` in `Unchecked.objIntConsumer` (I guess it wasn't auto-generated). It wasn't caught by tests - unfortunately they use ISE as expected exception, so in order to add test for this case refactoring is needed. Did you consider using parametrized tests to cover all variants of methods (not only in `Unchecked`)?\r\n\r\nTwo other minor changes:\r\n - removed redundant `final`,\r\n - used method reference - I wonder if you fancy those, because I don't see many method references in the code."},"comment":{"url":"https://api.github.com/repos/jOOQ/jOOL/issues/comments/241417741","html_url":"https://github.com/jOOQ/jOOL/pull/251#issuecomment-241417741","issue_url":"https://api.github.com/repos/jOOQ/jOOL/issues/251","id":241417741,"user":{"login":"lukaseder","id":734593,"avatar_url":"https://avatars.githubusercontent.com/u/734593?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaseder","html_url":"https://github.com/lukaseder","followers_url":"https://api.github.com/users/lukaseder/followers","following_url":"https://api.github.com/users/lukaseder/following{/other_user}","gists_url":"https://api.github.com/users/lukaseder/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaseder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaseder/subscriptions","organizations_url":"https://api.github.com/users/lukaseder/orgs","repos_url":"https://api.github.com/users/lukaseder/repos","events_url":"https://api.github.com/users/lukaseder/events{/privacy}","received_events_url":"https://api.github.com/users/lukaseder/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T13:48:33Z","updated_at":"2016-08-22T13:48:33Z","body":"Thank you very much for your contribution. I agree with the first two commits, will revert the removal of `final`, though. While it is redunant, I just like as many methods being final as possible. Who knows if we open up `Unchecked` in the future.\r\n\r\nParameterised tests are a good idea. Fancy another PR? :)"}}
{"actor":{"display_login":"lukaseder"}}