{"action":"created","comment":{"url":"https://api.github.com/repos/madou/armory-react/pulls/comments/86277843","pull_request_review_id":6943183,"id":86277843,"diff_hunk":"@@ -283,8 +283,8 @@ class Character extends Component {\n                         onChange={this.hide}\n                         label={\n                           showPublic\n-                            ? `${T.translate('character.shown')}`","path":"src/features/Character/index.js","position":22,"original_position":22,"commit_id":"63fd5420706021b115f187d30b089c605787d9ba","original_commit_id":"63fd5420706021b115f187d30b089c605787d9ba","user":{"login":"madou","id":6801309,"avatar_url":"https://avatars.githubusercontent.com/u/6801309?v=3","gravatar_id":"","url":"https://api.github.com/users/madou","html_url":"https://github.com/madou","followers_url":"https://api.github.com/users/madou/followers","following_url":"https://api.github.com/users/madou/following{/other_user}","gists_url":"https://api.github.com/users/madou/gists{/gist_id}","starred_url":"https://api.github.com/users/madou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madou/subscriptions","organizations_url":"https://api.github.com/users/madou/orgs","repos_url":"https://api.github.com/users/madou/repos","events_url":"https://api.github.com/users/madou/events{/privacy}","received_events_url":"https://api.github.com/users/madou/received_events","type":"User","site_admin":false},"body":"Nice catch","created_at":"2016-11-03T02:04:09Z","updated_at":"2016-11-03T02:10:56Z","html_url":"https://github.com/madou/armory-react/pull/102#discussion_r86277843","pull_request_url":"https://api.github.com/repos/madou/armory-react/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/madou/armory-react/pulls/comments/86277843"},"html":{"href":"https://github.com/madou/armory-react/pull/102#discussion_r86277843"},"pull_request":{"href":"https://api.github.com/repos/madou/armory-react/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/madou/armory-react/pulls/102","id":91938918,"html_url":"https://github.com/madou/armory-react/pull/102","diff_url":"https://github.com/madou/armory-react/pull/102.diff","patch_url":"https://github.com/madou/armory-react/pull/102.patch","issue_url":"https://api.github.com/repos/madou/armory-react/issues/102","number":102,"state":"open","locked":false,"title":"Missing i18n - Improvements - Bugfix","user":{"login":"Strean1337","id":1157471,"avatar_url":"https://avatars.githubusercontent.com/u/1157471?v=3","gravatar_id":"","url":"https://api.github.com/users/Strean1337","html_url":"https://github.com/Strean1337","followers_url":"https://api.github.com/users/Strean1337/followers","following_url":"https://api.github.com/users/Strean1337/following{/other_user}","gists_url":"https://api.github.com/users/Strean1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Strean1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Strean1337/subscriptions","organizations_url":"https://api.github.com/users/Strean1337/orgs","repos_url":"https://api.github.com/users/Strean1337/repos","events_url":"https://api.github.com/users/Strean1337/events{/privacy}","received_events_url":"https://api.github.com/users/Strean1337/received_events","type":"User","site_admin":false},"body":"- import the i18n lib in several files\r\n- fixed some wrong keys\r\n- added a lot of missing i18n keys\r\n\r\n@madou you need to test this, before merge.\r\n\r\nI tried to get the local dev environment running but it doesn't work :( (i work on a mac)\r\n\r\nI added a lot of missing i18n keys to several files - i just added the en and de locales correct but the other language files (es, fr) just contains the english translations because i can't translate that correct and english is always understandable (i hope so :D)\r\n\r\nI have some questions:\r\n\r\nWhere can i find the strings for the normal classes like: Elementalist, Warrior ...? Or did you get these strings thru the rest api directly from the server? Then you need to update the calls, that we get these strings in other languages ^^\r\n\r\nThe same for the Item Types: (Exotic, Legendary...) (Heavy Armor, Light Armor...)\r\n\r\nthe same for Human, Sylvari...\r\n\r\nBest regards dude :)","created_at":"2016-11-02T09:59:09Z","updated_at":"2016-11-03T02:10:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"575df314108185dac896d0b16206a0f105f8b6f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/madou/armory-react/pulls/102/commits","review_comments_url":"https://api.github.com/repos/madou/armory-react/pulls/102/comments","review_comment_url":"https://api.github.com/repos/madou/armory-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/madou/armory-react/issues/102/comments","statuses_url":"https://api.github.com/repos/madou/armory-react/statuses/63fd5420706021b115f187d30b089c605787d9ba","head":{"label":"Strean1337:feature/missing_18n","ref":"feature/missing_18n","sha":"63fd5420706021b115f187d30b089c605787d9ba","user":{"login":"Strean1337","id":1157471,"avatar_url":"https://avatars.githubusercontent.com/u/1157471?v=3","gravatar_id":"","url":"https://api.github.com/users/Strean1337","html_url":"https://github.com/Strean1337","followers_url":"https://api.github.com/users/Strean1337/followers","following_url":"https://api.github.com/users/Strean1337/following{/other_user}","gists_url":"https://api.github.com/users/Strean1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Strean1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Strean1337/subscriptions","organizations_url":"https://api.github.com/users/Strean1337/orgs","repos_url":"https://api.github.com/users/Strean1337/repos","events_url":"https://api.github.com/users/Strean1337/events{/privacy}","received_events_url":"https://api.github.com/users/Strean1337/received_events","type":"User","site_admin":false},"repo":{"id":72458252,"name":"armory-react","full_name":"Strean1337/armory-react","owner":{"login":"Strean1337","id":1157471,"avatar_url":"https://avatars.githubusercontent.com/u/1157471?v=3","gravatar_id":"","url":"https://api.github.com/users/Strean1337","html_url":"https://github.com/Strean1337","followers_url":"https://api.github.com/users/Strean1337/followers","following_url":"https://api.github.com/users/Strean1337/following{/other_user}","gists_url":"https://api.github.com/users/Strean1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Strean1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Strean1337/subscriptions","organizations_url":"https://api.github.com/users/Strean1337/orgs","repos_url":"https://api.github.com/users/Strean1337/repos","events_url":"https://api.github.com/users/Strean1337/events{/privacy}","received_events_url":"https://api.github.com/users/Strean1337/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Strean1337/armory-react","description":"Guild Wars 2 Armory | https://gw2armory.com","fork":true,"url":"https://api.github.com/repos/Strean1337/armory-react","forks_url":"https://api.github.com/repos/Strean1337/armory-react/forks","keys_url":"https://api.github.com/repos/Strean1337/armory-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Strean1337/armory-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Strean1337/armory-react/teams","hooks_url":"https://api.github.com/repos/Strean1337/armory-react/hooks","issue_events_url":"https://api.github.com/repos/Strean1337/armory-react/issues/events{/number}","events_url":"https://api.github.com/repos/Strean1337/armory-react/events","assignees_url":"https://api.github.com/repos/Strean1337/armory-react/assignees{/user}","branches_url":"https://api.github.com/repos/Strean1337/armory-react/branches{/branch}","tags_url":"https://api.github.com/repos/Strean1337/armory-react/tags","blobs_url":"https://api.github.com/repos/Strean1337/armory-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Strean1337/armory-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Strean1337/armory-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Strean1337/armory-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Strean1337/armory-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Strean1337/armory-react/languages","stargazers_url":"https://api.github.com/repos/Strean1337/armory-react/stargazers","contributors_url":"https://api.github.com/repos/Strean1337/armory-react/contributors","subscribers_url":"https://api.github.com/repos/Strean1337/armory-react/subscribers","subscription_url":"https://api.github.com/repos/Strean1337/armory-react/subscription","commits_url":"https://api.github.com/repos/Strean1337/armory-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Strean1337/armory-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Strean1337/armory-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Strean1337/armory-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Strean1337/armory-react/contents/{+path}","compare_url":"https://api.github.com/repos/Strean1337/armory-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Strean1337/armory-react/merges","archive_url":"https://api.github.com/repos/Strean1337/armory-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Strean1337/armory-react/downloads","issues_url":"https://api.github.com/repos/Strean1337/armory-react/issues{/number}","pulls_url":"https://api.github.com/repos/Strean1337/armory-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Strean1337/armory-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Strean1337/armory-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Strean1337/armory-react/labels{/name}","releases_url":"https://api.github.com/repos/Strean1337/armory-react/releases{/id}","deployments_url":"https://api.github.com/repos/Strean1337/armory-react/deployments","created_at":"2016-10-31T16:59:11Z","updated_at":"2016-10-31T16:59:12Z","pushed_at":"2016-11-02T10:01:39Z","git_url":"git://github.com/Strean1337/armory-react.git","ssh_url":"git@github.com:Strean1337/armory-react.git","clone_url":"https://github.com/Strean1337/armory-react.git","svn_url":"https://github.com/Strean1337/armory-react","homepage":"https://gw2armory.com","size":19178,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"madou:master","ref":"master","sha":"ca52dd057419434fa03d789e6f7cdcbff6ef92df","user":{"login":"madou","id":6801309,"avatar_url":"https://avatars.githubusercontent.com/u/6801309?v=3","gravatar_id":"","url":"https://api.github.com/users/madou","html_url":"https://github.com/madou","followers_url":"https://api.github.com/users/madou/followers","following_url":"https://api.github.com/users/madou/following{/other_user}","gists_url":"https://api.github.com/users/madou/gists{/gist_id}","starred_url":"https://api.github.com/users/madou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madou/subscriptions","organizations_url":"https://api.github.com/users/madou/orgs","repos_url":"https://api.github.com/users/madou/repos","events_url":"https://api.github.com/users/madou/events{/privacy}","received_events_url":"https://api.github.com/users/madou/received_events","type":"User","site_admin":false},"repo":{"id":64588179,"name":"armory-react","full_name":"madou/armory-react","owner":{"login":"madou","id":6801309,"avatar_url":"https://avatars.githubusercontent.com/u/6801309?v=3","gravatar_id":"","url":"https://api.github.com/users/madou","html_url":"https://github.com/madou","followers_url":"https://api.github.com/users/madou/followers","following_url":"https://api.github.com/users/madou/following{/other_user}","gists_url":"https://api.github.com/users/madou/gists{/gist_id}","starred_url":"https://api.github.com/users/madou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madou/subscriptions","organizations_url":"https://api.github.com/users/madou/orgs","repos_url":"https://api.github.com/users/madou/repos","events_url":"https://api.github.com/users/madou/events{/privacy}","received_events_url":"https://api.github.com/users/madou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madou/armory-react","description":"Guild Wars 2 Armory | https://gw2armory.com","fork":false,"url":"https://api.github.com/repos/madou/armory-react","forks_url":"https://api.github.com/repos/madou/armory-react/forks","keys_url":"https://api.github.com/repos/madou/armory-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madou/armory-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madou/armory-react/teams","hooks_url":"https://api.github.com/repos/madou/armory-react/hooks","issue_events_url":"https://api.github.com/repos/madou/armory-react/issues/events{/number}","events_url":"https://api.github.com/repos/madou/armory-react/events","assignees_url":"https://api.github.com/repos/madou/armory-react/assignees{/user}","branches_url":"https://api.github.com/repos/madou/armory-react/branches{/branch}","tags_url":"https://api.github.com/repos/madou/armory-react/tags","blobs_url":"https://api.github.com/repos/madou/armory-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madou/armory-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madou/armory-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/madou/armory-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madou/armory-react/statuses/{sha}","languages_url":"https://api.github.com/repos/madou/armory-react/languages","stargazers_url":"https://api.github.com/repos/madou/armory-react/stargazers","contributors_url":"https://api.github.com/repos/madou/armory-react/contributors","subscribers_url":"https://api.github.com/repos/madou/armory-react/subscribers","subscription_url":"https://api.github.com/repos/madou/armory-react/subscription","commits_url":"https://api.github.com/repos/madou/armory-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/madou/armory-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/madou/armory-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/madou/armory-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/madou/armory-react/contents/{+path}","compare_url":"https://api.github.com/repos/madou/armory-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madou/armory-react/merges","archive_url":"https://api.github.com/repos/madou/armory-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madou/armory-react/downloads","issues_url":"https://api.github.com/repos/madou/armory-react/issues{/number}","pulls_url":"https://api.github.com/repos/madou/armory-react/pulls{/number}","milestones_url":"https://api.github.com/repos/madou/armory-react/milestones{/number}","notifications_url":"https://api.github.com/repos/madou/armory-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madou/armory-react/labels{/name}","releases_url":"https://api.github.com/repos/madou/armory-react/releases{/id}","deployments_url":"https://api.github.com/repos/madou/armory-react/deployments","created_at":"2016-07-31T10:10:57Z","updated_at":"2016-10-27T14:00:45Z","pushed_at":"2016-11-02T22:09:20Z","git_url":"git://github.com/madou/armory-react.git","ssh_url":"git@github.com:madou/armory-react.git","clone_url":"https://github.com/madou/armory-react.git","svn_url":"https://github.com/madou/armory-react","homepage":"https://gw2armory.com","size":19189,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":48,"forks":6,"open_issues":48,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/madou/armory-react/pulls/102"},"html":{"href":"https://github.com/madou/armory-react/pull/102"},"issue":{"href":"https://api.github.com/repos/madou/armory-react/issues/102"},"comments":{"href":"https://api.github.com/repos/madou/armory-react/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/madou/armory-react/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/madou/armory-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/madou/armory-react/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/madou/armory-react/statuses/63fd5420706021b115f187d30b089c605787d9ba"}}}}
{"actor":{"display_login":"madou"}}