{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1","id":61616036,"html_url":"https://github.com/srilakshmidj/mcelog/pull/1","diff_url":"https://github.com/srilakshmidj/mcelog/pull/1.diff","patch_url":"https://github.com/srilakshmidj/mcelog/pull/1.patch","issue_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/1","number":1,"state":"closed","locked":false,"title":"Fix processing the child signals in non-daemon mode","user":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"body":"In the non-daemon mode, when the child processes exit the SIGCHLD\r\nis being read off the queue, but the child handler is not called,\r\nand the num_children is not decremented. This leads to the process\r\nhanging in trigger_wait() function in an infinite loop waiting for\r\nSIGCHLD signals that never arrive - (sigwait(&mask, &sig)).\r\n\r\nThis behaviour was discovered when the mcelog tried to process an\r\nunknown error on a machine, and created child processes. The parent\r\nprocess never exited. Since mcelog was run by a cron task every x\r\nminutes, numerous hung-mcelog processes accumulated whenever it hit\r\nthe unknown-error-trigger.\r\n\r\nSample error lines:\r\nmcelog: Running trigger `unknown-error-trigger'\r\nmcelog: Running trigger `unknown-error-trigger'\r\nmcelog: CPU 5 on socket 0 received unknown error\r\nmcelog: CPU 5 on socket 0 received unknown error\r\n\r\nThe fix is to call waitpid() to reap the exit status of all terminating\r\nchildren, calling finish_child() for each. This fix has been tested\r\non the machine the issue was discovered on.\r\n\r\nSigned-off-by: Tim Bingham <tbingham@akamai.com>\r\nSigned-off-by: Sri Jayaramappa <sjayaram@akamai.com>","created_at":"2016-03-03T20:00:41Z","updated_at":"2016-03-03T20:24:06Z","closed_at":"2016-03-03T20:24:06Z","merged_at":"2016-03-03T20:24:06Z","merge_commit_sha":"c731da0ed16ea43f4fad2272a3f4b551554e620a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1/commits","review_comments_url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1/comments","review_comment_url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/1/comments","statuses_url":"https://api.github.com/repos/srilakshmidj/mcelog/statuses/b6134b7558f27f67d0c5945c3ec0ae5694ffc284","head":{"label":"srilakshmidj:srilakshmidj-patch-1","ref":"srilakshmidj-patch-1","sha":"b6134b7558f27f67d0c5945c3ec0ae5694ffc284","user":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"repo":{"id":53075873,"name":"mcelog","full_name":"srilakshmidj/mcelog","owner":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srilakshmidj/mcelog","description":"Linux kernel machine check handling middleware","fork":true,"url":"https://api.github.com/repos/srilakshmidj/mcelog","forks_url":"https://api.github.com/repos/srilakshmidj/mcelog/forks","keys_url":"https://api.github.com/repos/srilakshmidj/mcelog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srilakshmidj/mcelog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srilakshmidj/mcelog/teams","hooks_url":"https://api.github.com/repos/srilakshmidj/mcelog/hooks","issue_events_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/events{/number}","events_url":"https://api.github.com/repos/srilakshmidj/mcelog/events","assignees_url":"https://api.github.com/repos/srilakshmidj/mcelog/assignees{/user}","branches_url":"https://api.github.com/repos/srilakshmidj/mcelog/branches{/branch}","tags_url":"https://api.github.com/repos/srilakshmidj/mcelog/tags","blobs_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/refs{/sha}","trees_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srilakshmidj/mcelog/statuses/{sha}","languages_url":"https://api.github.com/repos/srilakshmidj/mcelog/languages","stargazers_url":"https://api.github.com/repos/srilakshmidj/mcelog/stargazers","contributors_url":"https://api.github.com/repos/srilakshmidj/mcelog/contributors","subscribers_url":"https://api.github.com/repos/srilakshmidj/mcelog/subscribers","subscription_url":"https://api.github.com/repos/srilakshmidj/mcelog/subscription","commits_url":"https://api.github.com/repos/srilakshmidj/mcelog/commits{/sha}","git_commits_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/commits{/sha}","comments_url":"https://api.github.com/repos/srilakshmidj/mcelog/comments{/number}","issue_comment_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/comments{/number}","contents_url":"https://api.github.com/repos/srilakshmidj/mcelog/contents/{+path}","compare_url":"https://api.github.com/repos/srilakshmidj/mcelog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srilakshmidj/mcelog/merges","archive_url":"https://api.github.com/repos/srilakshmidj/mcelog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srilakshmidj/mcelog/downloads","issues_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues{/number}","pulls_url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls{/number}","milestones_url":"https://api.github.com/repos/srilakshmidj/mcelog/milestones{/number}","notifications_url":"https://api.github.com/repos/srilakshmidj/mcelog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srilakshmidj/mcelog/labels{/name}","releases_url":"https://api.github.com/repos/srilakshmidj/mcelog/releases{/id}","deployments_url":"https://api.github.com/repos/srilakshmidj/mcelog/deployments","created_at":"2016-03-03T19:09:04Z","updated_at":"2016-03-03T19:09:06Z","pushed_at":"2016-03-03T20:24:06Z","git_url":"git://github.com/srilakshmidj/mcelog.git","ssh_url":"git@github.com:srilakshmidj/mcelog.git","clone_url":"https://github.com/srilakshmidj/mcelog.git","svn_url":"https://github.com/srilakshmidj/mcelog","homepage":"http://www.mcelog.org","size":732,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"srilakshmidj:master","ref":"master","sha":"b4ec9cb2b4e0dd6246d663bff0b7483dd96e8c10","user":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"repo":{"id":53075873,"name":"mcelog","full_name":"srilakshmidj/mcelog","owner":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srilakshmidj/mcelog","description":"Linux kernel machine check handling middleware","fork":true,"url":"https://api.github.com/repos/srilakshmidj/mcelog","forks_url":"https://api.github.com/repos/srilakshmidj/mcelog/forks","keys_url":"https://api.github.com/repos/srilakshmidj/mcelog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srilakshmidj/mcelog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srilakshmidj/mcelog/teams","hooks_url":"https://api.github.com/repos/srilakshmidj/mcelog/hooks","issue_events_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/events{/number}","events_url":"https://api.github.com/repos/srilakshmidj/mcelog/events","assignees_url":"https://api.github.com/repos/srilakshmidj/mcelog/assignees{/user}","branches_url":"https://api.github.com/repos/srilakshmidj/mcelog/branches{/branch}","tags_url":"https://api.github.com/repos/srilakshmidj/mcelog/tags","blobs_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/refs{/sha}","trees_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srilakshmidj/mcelog/statuses/{sha}","languages_url":"https://api.github.com/repos/srilakshmidj/mcelog/languages","stargazers_url":"https://api.github.com/repos/srilakshmidj/mcelog/stargazers","contributors_url":"https://api.github.com/repos/srilakshmidj/mcelog/contributors","subscribers_url":"https://api.github.com/repos/srilakshmidj/mcelog/subscribers","subscription_url":"https://api.github.com/repos/srilakshmidj/mcelog/subscription","commits_url":"https://api.github.com/repos/srilakshmidj/mcelog/commits{/sha}","git_commits_url":"https://api.github.com/repos/srilakshmidj/mcelog/git/commits{/sha}","comments_url":"https://api.github.com/repos/srilakshmidj/mcelog/comments{/number}","issue_comment_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues/comments{/number}","contents_url":"https://api.github.com/repos/srilakshmidj/mcelog/contents/{+path}","compare_url":"https://api.github.com/repos/srilakshmidj/mcelog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srilakshmidj/mcelog/merges","archive_url":"https://api.github.com/repos/srilakshmidj/mcelog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srilakshmidj/mcelog/downloads","issues_url":"https://api.github.com/repos/srilakshmidj/mcelog/issues{/number}","pulls_url":"https://api.github.com/repos/srilakshmidj/mcelog/pulls{/number}","milestones_url":"https://api.github.com/repos/srilakshmidj/mcelog/milestones{/number}","notifications_url":"https://api.github.com/repos/srilakshmidj/mcelog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srilakshmidj/mcelog/labels{/name}","releases_url":"https://api.github.com/repos/srilakshmidj/mcelog/releases{/id}","deployments_url":"https://api.github.com/repos/srilakshmidj/mcelog/deployments","created_at":"2016-03-03T19:09:04Z","updated_at":"2016-03-03T19:09:06Z","pushed_at":"2016-03-03T20:24:06Z","git_url":"git://github.com/srilakshmidj/mcelog.git","ssh_url":"git@github.com:srilakshmidj/mcelog.git","clone_url":"https://github.com/srilakshmidj/mcelog.git","svn_url":"https://github.com/srilakshmidj/mcelog","homepage":"http://www.mcelog.org","size":732,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1"},"html":{"href":"https://github.com/srilakshmidj/mcelog/pull/1"},"issue":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/issues/1"},"comments":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/srilakshmidj/mcelog/statuses/b6134b7558f27f67d0c5945c3ec0ae5694ffc284"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"srilakshmidj","id":17622701,"avatar_url":"https://avatars.githubusercontent.com/u/17622701?v=3","gravatar_id":"","url":"https://api.github.com/users/srilakshmidj","html_url":"https://github.com/srilakshmidj","followers_url":"https://api.github.com/users/srilakshmidj/followers","following_url":"https://api.github.com/users/srilakshmidj/following{/other_user}","gists_url":"https://api.github.com/users/srilakshmidj/gists{/gist_id}","starred_url":"https://api.github.com/users/srilakshmidj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilakshmidj/subscriptions","organizations_url":"https://api.github.com/users/srilakshmidj/orgs","repos_url":"https://api.github.com/users/srilakshmidj/repos","events_url":"https://api.github.com/users/srilakshmidj/events{/privacy}","received_events_url":"https://api.github.com/users/srilakshmidj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":8,"changed_files":1}}