{"action":"created","issue":{"url":"https://api.github.com/repos/drewr/postal/issues/71","repository_url":"https://api.github.com/repos/drewr/postal","labels_url":"https://api.github.com/repos/drewr/postal/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/drewr/postal/issues/71/comments","events_url":"https://api.github.com/repos/drewr/postal/issues/71/events","html_url":"https://github.com/drewr/postal/pull/71","id":138554526,"number":71,"title":"Convert keywords to both mail.smtp. and mail.smtps. properties","user":{"login":"charles-dyfis-net","id":22370,"avatar_url":"https://avatars.githubusercontent.com/u/22370?v=3","gravatar_id":"","url":"https://api.github.com/users/charles-dyfis-net","html_url":"https://github.com/charles-dyfis-net","followers_url":"https://api.github.com/users/charles-dyfis-net/followers","following_url":"https://api.github.com/users/charles-dyfis-net/following{/other_user}","gists_url":"https://api.github.com/users/charles-dyfis-net/gists{/gist_id}","starred_url":"https://api.github.com/users/charles-dyfis-net/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charles-dyfis-net/subscriptions","organizations_url":"https://api.github.com/users/charles-dyfis-net/orgs","repos_url":"https://api.github.com/users/charles-dyfis-net/repos","events_url":"https://api.github.com/users/charles-dyfis-net/events{/privacy}","received_events_url":"https://api.github.com/users/charles-dyfis-net/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-04T18:52:03Z","updated_at":"2016-03-04T18:52:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/drewr/postal/pulls/71","html_url":"https://github.com/drewr/postal/pull/71","diff_url":"https://github.com/drewr/postal/pull/71.diff","patch_url":"https://github.com/drewr/postal/pull/71.patch"},"body":"Per (the docs)[https://javamail.java.net/nonav/docs/api/com/sun/mail/smtp/package-summary.html]:\r\n\r\n> Note that if you're using the \"smtps\" protocol to access SMTP over SSL, all\r\n> the properties would be named \"mail.smtps.*\".\r\n\r\nAt present, we always set only `mail.smtp` properties from keywords.\r\n\r\nGranted, we could try to determine the protocol from inspecting the properties passed, but always setting properties for both possibilities is the more robust approach, precluding any possibility of making the determination wrongly."},"comment":{"url":"https://api.github.com/repos/drewr/postal/issues/comments/192407629","html_url":"https://github.com/drewr/postal/pull/71#issuecomment-192407629","issue_url":"https://api.github.com/repos/drewr/postal/issues/71","id":192407629,"user":{"login":"charles-dyfis-net","id":22370,"avatar_url":"https://avatars.githubusercontent.com/u/22370?v=3","gravatar_id":"","url":"https://api.github.com/users/charles-dyfis-net","html_url":"https://github.com/charles-dyfis-net","followers_url":"https://api.github.com/users/charles-dyfis-net/followers","following_url":"https://api.github.com/users/charles-dyfis-net/following{/other_user}","gists_url":"https://api.github.com/users/charles-dyfis-net/gists{/gist_id}","starred_url":"https://api.github.com/users/charles-dyfis-net/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charles-dyfis-net/subscriptions","organizations_url":"https://api.github.com/users/charles-dyfis-net/orgs","repos_url":"https://api.github.com/users/charles-dyfis-net/repos","events_url":"https://api.github.com/users/charles-dyfis-net/events{/privacy}","received_events_url":"https://api.github.com/users/charles-dyfis-net/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T18:52:12Z","updated_at":"2016-03-04T18:52:12Z","body":"@drewr, if you have a chance to weigh in on whether I've gone the right approach here with duplicating rather than inferring, I'd appreciate the feedback."}}