{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1","id":63513260,"html_url":"https://github.com/Jackalope-Gaming/8L-Train-Project/pull/1","diff_url":"https://github.com/Jackalope-Gaming/8L-Train-Project/pull/1.diff","patch_url":"https://github.com/Jackalope-Gaming/8L-Train-Project/pull/1.patch","issue_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/1","number":1,"state":"closed","locked":false,"title":"Eliminate redundancy, clean up code","user":{"login":"d3phoenix","id":11343812,"avatar_url":"https://avatars.githubusercontent.com/u/11343812?v=3","gravatar_id":"","url":"https://api.github.com/users/d3phoenix","html_url":"https://github.com/d3phoenix","followers_url":"https://api.github.com/users/d3phoenix/followers","following_url":"https://api.github.com/users/d3phoenix/following{/other_user}","gists_url":"https://api.github.com/users/d3phoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/d3phoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3phoenix/subscriptions","organizations_url":"https://api.github.com/users/d3phoenix/orgs","repos_url":"https://api.github.com/users/d3phoenix/repos","events_url":"https://api.github.com/users/d3phoenix/events{/privacy}","received_events_url":"https://api.github.com/users/d3phoenix/received_events","type":"User","site_admin":false},"body":"This removes redundant code and makes adding additional supported mods much easier for 8L in the future. Supported wagons and locos are defined first, then they are looped through, and all needed attributes are applied. Conditional blocks within the loops can override some values if necessary.","created_at":"2016-03-21T00:35:15Z","updated_at":"2016-03-21T15:20:57Z","closed_at":"2016-03-21T15:20:57Z","merged_at":"2016-03-21T15:20:57Z","merge_commit_sha":"dc1c1d0486fdfc650df0651f615418c07222e9ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/1/comments","statuses_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/statuses/7d270bb88478eadedc18fa4937386bceca4e7dca","head":{"label":"d3phoenix:patch-1","ref":"patch-1","sha":"7d270bb88478eadedc18fa4937386bceca4e7dca","user":{"login":"d3phoenix","id":11343812,"avatar_url":"https://avatars.githubusercontent.com/u/11343812?v=3","gravatar_id":"","url":"https://api.github.com/users/d3phoenix","html_url":"https://github.com/d3phoenix","followers_url":"https://api.github.com/users/d3phoenix/followers","following_url":"https://api.github.com/users/d3phoenix/following{/other_user}","gists_url":"https://api.github.com/users/d3phoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/d3phoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3phoenix/subscriptions","organizations_url":"https://api.github.com/users/d3phoenix/orgs","repos_url":"https://api.github.com/users/d3phoenix/repos","events_url":"https://api.github.com/users/d3phoenix/events{/privacy}","received_events_url":"https://api.github.com/users/d3phoenix/received_events","type":"User","site_admin":false},"repo":{"id":54348228,"name":"8L-Train-Project","full_name":"d3phoenix/8L-Train-Project","owner":{"login":"d3phoenix","id":11343812,"avatar_url":"https://avatars.githubusercontent.com/u/11343812?v=3","gravatar_id":"","url":"https://api.github.com/users/d3phoenix","html_url":"https://github.com/d3phoenix","followers_url":"https://api.github.com/users/d3phoenix/followers","following_url":"https://api.github.com/users/d3phoenix/following{/other_user}","gists_url":"https://api.github.com/users/d3phoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/d3phoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3phoenix/subscriptions","organizations_url":"https://api.github.com/users/d3phoenix/orgs","repos_url":"https://api.github.com/users/d3phoenix/repos","events_url":"https://api.github.com/users/d3phoenix/events{/privacy}","received_events_url":"https://api.github.com/users/d3phoenix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3phoenix/8L-Train-Project","description":"This is a Factorio mod that changes train locomotives and wagons to be exactly 8 units long.","fork":true,"url":"https://api.github.com/repos/d3phoenix/8L-Train-Project","forks_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/forks","keys_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/teams","hooks_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/hooks","issue_events_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/issues/events{/number}","events_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/events","assignees_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/assignees{/user}","branches_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/branches{/branch}","tags_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/tags","blobs_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/languages","stargazers_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/stargazers","contributors_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/contributors","subscribers_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/subscribers","subscription_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/subscription","commits_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/contents/{+path}","compare_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/merges","archive_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/downloads","issues_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/issues{/number}","pulls_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/labels{/name}","releases_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/releases{/id}","deployments_url":"https://api.github.com/repos/d3phoenix/8L-Train-Project/deployments","created_at":"2016-03-21T00:29:15Z","updated_at":"2016-03-21T00:29:16Z","pushed_at":"2016-03-21T02:09:23Z","git_url":"git://github.com/d3phoenix/8L-Train-Project.git","ssh_url":"git@github.com:d3phoenix/8L-Train-Project.git","clone_url":"https://github.com/d3phoenix/8L-Train-Project.git","svn_url":"https://github.com/d3phoenix/8L-Train-Project","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jackalope-Gaming:master","ref":"master","sha":"ef6a8d1109a869d6a1aa4ab880d6d9f64995ce81","user":{"login":"Jackalope-Gaming","id":17949121,"avatar_url":"https://avatars.githubusercontent.com/u/17949121?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackalope-Gaming","html_url":"https://github.com/Jackalope-Gaming","followers_url":"https://api.github.com/users/Jackalope-Gaming/followers","following_url":"https://api.github.com/users/Jackalope-Gaming/following{/other_user}","gists_url":"https://api.github.com/users/Jackalope-Gaming/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackalope-Gaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackalope-Gaming/subscriptions","organizations_url":"https://api.github.com/users/Jackalope-Gaming/orgs","repos_url":"https://api.github.com/users/Jackalope-Gaming/repos","events_url":"https://api.github.com/users/Jackalope-Gaming/events{/privacy}","received_events_url":"https://api.github.com/users/Jackalope-Gaming/received_events","type":"User","site_admin":false},"repo":{"id":54270406,"name":"8L-Train-Project","full_name":"Jackalope-Gaming/8L-Train-Project","owner":{"login":"Jackalope-Gaming","id":17949121,"avatar_url":"https://avatars.githubusercontent.com/u/17949121?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackalope-Gaming","html_url":"https://github.com/Jackalope-Gaming","followers_url":"https://api.github.com/users/Jackalope-Gaming/followers","following_url":"https://api.github.com/users/Jackalope-Gaming/following{/other_user}","gists_url":"https://api.github.com/users/Jackalope-Gaming/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackalope-Gaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackalope-Gaming/subscriptions","organizations_url":"https://api.github.com/users/Jackalope-Gaming/orgs","repos_url":"https://api.github.com/users/Jackalope-Gaming/repos","events_url":"https://api.github.com/users/Jackalope-Gaming/events{/privacy}","received_events_url":"https://api.github.com/users/Jackalope-Gaming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jackalope-Gaming/8L-Train-Project","description":"This is a Factorio mod that changes train locomotives and wagons to be exactly 8 units long.","fork":false,"url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project","forks_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/forks","keys_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/teams","hooks_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/hooks","issue_events_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/events{/number}","events_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/events","assignees_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/assignees{/user}","branches_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/branches{/branch}","tags_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/tags","blobs_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/languages","stargazers_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/stargazers","contributors_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/contributors","subscribers_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/subscribers","subscription_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/subscription","commits_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/contents/{+path}","compare_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/merges","archive_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/downloads","issues_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues{/number}","pulls_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/labels{/name}","releases_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/releases{/id}","deployments_url":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/deployments","created_at":"2016-03-19T14:35:54Z","updated_at":"2016-03-19T16:31:53Z","pushed_at":"2016-03-21T15:20:57Z","git_url":"git://github.com/Jackalope-Gaming/8L-Train-Project.git","ssh_url":"git@github.com:Jackalope-Gaming/8L-Train-Project.git","clone_url":"https://github.com/Jackalope-Gaming/8L-Train-Project.git","svn_url":"https://github.com/Jackalope-Gaming/8L-Train-Project","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1"},"html":{"href":"https://github.com/Jackalope-Gaming/8L-Train-Project/pull/1"},"issue":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/1"},"comments":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Jackalope-Gaming/8L-Train-Project/statuses/7d270bb88478eadedc18fa4937386bceca4e7dca"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Jackalope-Gaming","id":17949121,"avatar_url":"https://avatars.githubusercontent.com/u/17949121?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackalope-Gaming","html_url":"https://github.com/Jackalope-Gaming","followers_url":"https://api.github.com/users/Jackalope-Gaming/followers","following_url":"https://api.github.com/users/Jackalope-Gaming/following{/other_user}","gists_url":"https://api.github.com/users/Jackalope-Gaming/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackalope-Gaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackalope-Gaming/subscriptions","organizations_url":"https://api.github.com/users/Jackalope-Gaming/orgs","repos_url":"https://api.github.com/users/Jackalope-Gaming/repos","events_url":"https://api.github.com/users/Jackalope-Gaming/events{/privacy}","received_events_url":"https://api.github.com/users/Jackalope-Gaming/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":67,"deletions":98,"changed_files":1}}