{"action":"created","issue":{"url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/8","repository_url":"https://api.github.com/repos/sidewalklabs/s2sphere","labels_url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/8/comments","events_url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/8/events","html_url":"https://github.com/sidewalklabs/s2sphere/pull/8","id":152607054,"number":8,"title":"linting with flake8","user":{"login":"svenkreiss","id":2775078,"avatar_url":"https://avatars.githubusercontent.com/u/2775078?v=3","gravatar_id":"","url":"https://api.github.com/users/svenkreiss","html_url":"https://github.com/svenkreiss","followers_url":"https://api.github.com/users/svenkreiss/followers","following_url":"https://api.github.com/users/svenkreiss/following{/other_user}","gists_url":"https://api.github.com/users/svenkreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/svenkreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenkreiss/subscriptions","organizations_url":"https://api.github.com/users/svenkreiss/orgs","repos_url":"https://api.github.com/users/svenkreiss/repos","events_url":"https://api.github.com/users/svenkreiss/events{/privacy}","received_events_url":"https://api.github.com/users/svenkreiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-05-02T17:59:42Z","updated_at":"2016-05-02T19:29:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sidewalklabs/s2sphere/pulls/8","html_url":"https://github.com/sidewalklabs/s2sphere/pull/8","diff_url":"https://github.com/sidewalklabs/s2sphere/pull/8.diff","patch_url":"https://github.com/sidewalklabs/s2sphere/pull/8.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sidewalklabs/s2sphere/8)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/comments/216337074","html_url":"https://github.com/sidewalklabs/s2sphere/pull/8#issuecomment-216337074","issue_url":"https://api.github.com/repos/sidewalklabs/s2sphere/issues/8","id":216337074,"user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T19:29:58Z","updated_at":"2016-05-02T19:29:58Z","body":"\n\n\n\nReview status: 0 of 10 files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[.travis.yml, line 56 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmwdJRT6J_ACmLfViP:-KGmwdJRT6J_ACmLfViQ:-7303062) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/.travis.yml#L56)):*\nWhat is hacking and why do we need it? (I don't see it referenced anywhere.)\n\n---\n\n*[circle.yml, line 3 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmufIITh5kmpow-0Pi:-KGmufIITh5kmpow-0Pj:-1202880782) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/circle.yml#L3)):*\nCreate a `test.sh` script? These lines are getting a little long.\n\nAlternatively, you can create a [YAML variable][1].\n\n[1]: https://en.wikipedia.org/wiki/YAML#Repeated_nodes\n\n---\n\n*[setup.cfg, line 2 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmv4vPjYfbun_A1IbA:-KGmv4vPjYfbun_A1IbB:261133562) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/setup.cfg#L2)):*\nDoes this file support comments? If so, please document what this code is and why we want to ignore it.\n\n---\n\n*[s2sphere/__init__.py, line 2 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmvQ3kmGzLzlMk37jz:-KGmvQ3kmGzLzlMk37k-:1733415424) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/s2sphere/__init__.py#L2)):*\nWhat is `noqa`? How about a comment.\n\n---\n\n*[s2sphere/sphere.py, line 14 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmvc6X8uDKtaXEz6nN:-KGmvc6X8uDKtaXEz6nO:-1562240697) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/s2sphere/sphere.py#L14)):*\nIs this coming directly from `s2angle.h`?\n\n---\n\n*[tests/sphere_test.py, line 1508 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmw8IYVHR5USzugcn7:-KGmw8IYVHR5USzugcn8:1594991985) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/tests/sphere_test.py#L1508)):*\nthese don't fit on one line?\n\n---\n\n*[tests/sphere_test.py, line 1812 \\[r1\\]](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8#-KGmwNLuCN-27n6pXwal:-KGmwNLuCN-27n6pXwam:1599495814) ([raw file](https://github.com/sidewalklabs/s2sphere/blob/42f7edd0610b297912cf5178cd02a20d9bc03e1e/tests/sphere_test.py#L1812)):*\nIf this var is unused, it would be better to replace it with:\n\n```python\ncell0tr.get_rect_bound()\n```\n\nso that the code still gets execute (it could still break the test if it threw an exception, for example).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/sidewalklabs/s2sphere/8)*\n<!-- Sent from Reviewable.io -->\n"}}