{"action":"closed","number":133,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133","id":88258106,"html_url":"https://github.com/logstash-plugins/logstash-input-kafka/pull/133","diff_url":"https://github.com/logstash-plugins/logstash-input-kafka/pull/133.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-kafka/pull/133.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/133","number":133,"state":"closed","locked":false,"title":"Add optional client parameter: ssl_key_password (kafka >= 0.9)","user":{"login":"r0qs","id":457348,"avatar_url":"https://avatars.githubusercontent.com/u/457348?v=3","gravatar_id":"","url":"https://api.github.com/users/r0qs","html_url":"https://github.com/r0qs","followers_url":"https://api.github.com/users/r0qs/followers","following_url":"https://api.github.com/users/r0qs/following{/other_user}","gists_url":"https://api.github.com/users/r0qs/gists{/gist_id}","starred_url":"https://api.github.com/users/r0qs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0qs/subscriptions","organizations_url":"https://api.github.com/users/r0qs/orgs","repos_url":"https://api.github.com/users/r0qs/repos","events_url":"https://api.github.com/users/r0qs/events{/privacy}","received_events_url":"https://api.github.com/users/r0qs/received_events","type":"User","site_admin":false},"body":"Hello, since kafka version 0.9 the consumer configuration for two-way authentication has the parameter: [ssl.key.password](http://kafka.apache.org/documentation.html#newconsumerconfigs), that cause an weird error if not defined, even if your private key in the key store don't needs password, what is my case.\n\nSo to solve my problem, I pass an empty password to kafka consumer configuration doing the following in the plugin:\n\n``` ruby\nconfig :ssl_key_password, :validate => :password\n...\nprops.put(\"ssl.key.password\", ssl_key_password.value) unless ssl_key_password.nil?\n```\n\nand:\n\n```\nkafka {\n      ...\n      ssl => true\n      ssl_truststore_location => \"/var/private/ssl/logstash.truststore.jks\"\n      ssl_truststore_password => \"someOtherPassword\"\n      ssl_key_password => \"\"\n      ssl_keystore_location => \"/var/private/ssl/logstash.keystore.jks\"\n      ssl_keystore_password => \"somePassword\"\n      ...\n   }\n```\n\nIn case this be useful for someone, I open this PR to allow two-way ssl configuration with private key password in key store.\n","created_at":"2016-10-06T13:07:12Z","updated_at":"2016-11-16T20:13:31Z","closed_at":"2016-11-16T20:13:31Z","merged_at":null,"merge_commit_sha":"ff0f9214749e7e7a3eb08d2b88fbfadbf5e93e03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/133/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/statuses/f0c4f7691978eed2061566fcfdc6f96f10802d82","head":{"label":"r0qs:kafka-ssl-key-password","ref":"kafka-ssl-key-password","sha":"f0c4f7691978eed2061566fcfdc6f96f10802d82","user":{"login":"r0qs","id":457348,"avatar_url":"https://avatars.githubusercontent.com/u/457348?v=3","gravatar_id":"","url":"https://api.github.com/users/r0qs","html_url":"https://github.com/r0qs","followers_url":"https://api.github.com/users/r0qs/followers","following_url":"https://api.github.com/users/r0qs/following{/other_user}","gists_url":"https://api.github.com/users/r0qs/gists{/gist_id}","starred_url":"https://api.github.com/users/r0qs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0qs/subscriptions","organizations_url":"https://api.github.com/users/r0qs/orgs","repos_url":"https://api.github.com/users/r0qs/repos","events_url":"https://api.github.com/users/r0qs/events{/privacy}","received_events_url":"https://api.github.com/users/r0qs/received_events","type":"User","site_admin":false},"repo":{"id":70071417,"name":"logstash-input-kafka","full_name":"r0qs/logstash-input-kafka","owner":{"login":"r0qs","id":457348,"avatar_url":"https://avatars.githubusercontent.com/u/457348?v=3","gravatar_id":"","url":"https://api.github.com/users/r0qs","html_url":"https://github.com/r0qs","followers_url":"https://api.github.com/users/r0qs/followers","following_url":"https://api.github.com/users/r0qs/following{/other_user}","gists_url":"https://api.github.com/users/r0qs/gists{/gist_id}","starred_url":"https://api.github.com/users/r0qs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0qs/subscriptions","organizations_url":"https://api.github.com/users/r0qs/orgs","repos_url":"https://api.github.com/users/r0qs/repos","events_url":"https://api.github.com/users/r0qs/events{/privacy}","received_events_url":"https://api.github.com/users/r0qs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r0qs/logstash-input-kafka","description":"Kafka input for Logstash","fork":true,"url":"https://api.github.com/repos/r0qs/logstash-input-kafka","forks_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/forks","keys_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/teams","hooks_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/hooks","issue_events_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/events","assignees_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/tags","blobs_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/languages","stargazers_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/stargazers","contributors_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/contributors","subscribers_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/subscribers","subscription_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/subscription","commits_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/merges","archive_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/downloads","issues_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/labels{/name}","releases_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/r0qs/logstash-input-kafka/deployments","created_at":"2016-10-05T15:04:22Z","updated_at":"2016-10-05T15:04:23Z","pushed_at":"2016-10-27T14:11:31Z","git_url":"git://github.com/r0qs/logstash-input-kafka.git","ssh_url":"git@github.com:r0qs/logstash-input-kafka.git","clone_url":"https://github.com/r0qs/logstash-input-kafka.git","svn_url":"https://github.com/r0qs/logstash-input-kafka","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"a3def4fb3ad1446b00a4c0bd8bd63cdd6da37d51","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":24112073,"name":"logstash-input-kafka","full_name":"logstash-plugins/logstash-input-kafka","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-kafka","description":"Kafka input for Logstash","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/deployments","created_at":"2014-09-16T18:26:43Z","updated_at":"2016-11-10T15:44:17Z","pushed_at":"2016-11-16T20:13:08Z","git_url":"git://github.com/logstash-plugins/logstash-input-kafka.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-kafka.git","clone_url":"https://github.com/logstash-plugins/logstash-input-kafka.git","svn_url":"https://github.com/logstash-plugins/logstash-input-kafka","homepage":null,"size":271,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":38,"forks":32,"open_issues":38,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-kafka/pull/133"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/133"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-kafka/statuses/f0c4f7691978eed2061566fcfdc6f96f10802d82"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"suyograo"}}