{"action":"opened","number":1224,"pull_request":{"url":"https://api.github.com/repos/spark/firmware/pulls/1224","id":99832742,"html_url":"https://github.com/spark/firmware/pull/1224","diff_url":"https://github.com/spark/firmware/pull/1224.diff","patch_url":"https://github.com/spark/firmware/pull/1224.patch","issue_url":"https://api.github.com/repos/spark/firmware/issues/1224","number":1224,"state":"open","locked":false,"title":"Move Keyboard and Mouse object instantiation into a function to reduce user-part binary size","user":{"login":"avtolstoy","id":388478,"avatar_url":"https://avatars.githubusercontent.com/u/388478?v=3","gravatar_id":"","url":"https://api.github.com/users/avtolstoy","html_url":"https://github.com/avtolstoy","followers_url":"https://api.github.com/users/avtolstoy/followers","following_url":"https://api.github.com/users/avtolstoy/following{/other_user}","gists_url":"https://api.github.com/users/avtolstoy/gists{/gist_id}","starred_url":"https://api.github.com/users/avtolstoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avtolstoy/subscriptions","organizations_url":"https://api.github.com/users/avtolstoy/orgs","repos_url":"https://api.github.com/users/avtolstoy/repos","events_url":"https://api.github.com/users/avtolstoy/events{/privacy}","received_events_url":"https://api.github.com/users/avtolstoy/received_events","type":"User","site_admin":false},"body":"Allows the compiler to garbage collect USBKeyboard and USBMouse implementations if they are not used in user code, saving flash space.\r\n\r\n```\r\narm-none-eabi-gcc (GNU Tools for ARM Embedded Processors) 4.9.3 20141119 (release) [ARM/embedded-4_9-branch revision 218278]\r\n\r\nElectron, 0.6.1-rc.1, app/blank:\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n   5564\t      8\t   1640\t   7212\t   1c2c\t../../../build/target/user-part/platform-10-m/blank.elf\r\n\r\nElectron, this PR, app/blank:\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n   4684\t      8\t   1572\t   6264\t   1878\t../../../build/target/user-part/platform-10-m/blank.elf\r\n\r\nElectron, this PR, app/blank + Mouse.begin() and Keyboard.begin():\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n   5676\t      8\t   1652\t   7336\t   1ca8\t../../../build/target/user-part/platform-10-m/blank.elf\r\n\r\n```\r\n\r\n---\r\n\r\nDoneness:\r\n\r\n- [X] Contributor has signed CLA\r\n- [X] Problem and Solution clearly stated\r\n- [ ] Code peer reviewed\r\n- [ ] API tests compiled\r\n- [ ] Run unit/integration/application tests on device\r\n- [ ] Add documentation\r\n- [ ] Add to CHANGELOG.md after merging (add links to docs and issues)","created_at":"2017-01-01T23:08:03Z","updated_at":"2017-01-01T23:08:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/spark/firmware/milestones/28","html_url":"https://github.com/spark/firmware/milestone/28","labels_url":"https://api.github.com/repos/spark/firmware/milestones/28/labels","id":2164610,"number":28,"title":"0.6.1","description":null,"creator":{"login":"technobly","id":2249224,"avatar_url":"https://avatars.githubusercontent.com/u/2249224?v=3","gravatar_id":"","url":"https://api.github.com/users/technobly","html_url":"https://github.com/technobly","followers_url":"https://api.github.com/users/technobly/followers","following_url":"https://api.github.com/users/technobly/following{/other_user}","gists_url":"https://api.github.com/users/technobly/gists{/gist_id}","starred_url":"https://api.github.com/users/technobly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technobly/subscriptions","organizations_url":"https://api.github.com/users/technobly/orgs","repos_url":"https://api.github.com/users/technobly/repos","events_url":"https://api.github.com/users/technobly/events{/privacy}","received_events_url":"https://api.github.com/users/technobly/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":65,"state":"open","created_at":"2016-11-29T19:39:17Z","updated_at":"2017-01-01T23:08:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spark/firmware/pulls/1224/commits","review_comments_url":"https://api.github.com/repos/spark/firmware/pulls/1224/comments","review_comment_url":"https://api.github.com/repos/spark/firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spark/firmware/issues/1224/comments","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/caf62c32f40eeb3bd92a4badeb2433317911bea7","head":{"label":"spark:feature/usb-user-part-size-optimizations","ref":"feature/usb-user-part-size-optimizations","sha":"caf62c32f40eeb3bd92a4badeb2433317911bea7","user":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"repo":{"id":8720130,"name":"firmware","full_name":"spark/firmware","owner":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark/firmware","description":"Firmware for Particle Devices","fork":false,"url":"https://api.github.com/repos/spark/firmware","forks_url":"https://api.github.com/repos/spark/firmware/forks","keys_url":"https://api.github.com/repos/spark/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark/firmware/teams","hooks_url":"https://api.github.com/repos/spark/firmware/hooks","issue_events_url":"https://api.github.com/repos/spark/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/spark/firmware/events","assignees_url":"https://api.github.com/repos/spark/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/spark/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/spark/firmware/tags","blobs_url":"https://api.github.com/repos/spark/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/spark/firmware/languages","stargazers_url":"https://api.github.com/repos/spark/firmware/stargazers","contributors_url":"https://api.github.com/repos/spark/firmware/contributors","subscribers_url":"https://api.github.com/repos/spark/firmware/subscribers","subscription_url":"https://api.github.com/repos/spark/firmware/subscription","commits_url":"https://api.github.com/repos/spark/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/spark/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark/firmware/merges","archive_url":"https://api.github.com/repos/spark/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark/firmware/downloads","issues_url":"https://api.github.com/repos/spark/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/spark/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/spark/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/spark/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark/firmware/labels{/name}","releases_url":"https://api.github.com/repos/spark/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/spark/firmware/deployments","created_at":"2013-03-12T04:42:33Z","updated_at":"2016-12-30T19:50:49Z","pushed_at":"2017-01-01T22:57:55Z","git_url":"git://github.com/spark/firmware.git","ssh_url":"git@github.com:spark/firmware.git","clone_url":"https://github.com/spark/firmware.git","svn_url":"https://github.com/spark/firmware","homepage":"https://www.particle.io/","size":108473,"stargazers_count":553,"watchers_count":553,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":366,"mirror_url":null,"open_issues_count":127,"forks":366,"open_issues":127,"watchers":553,"default_branch":"develop"}},"base":{"label":"spark:develop","ref":"develop","sha":"b57dffcfc99d0308c4a2da33b187aed19e969f91","user":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"repo":{"id":8720130,"name":"firmware","full_name":"spark/firmware","owner":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark/firmware","description":"Firmware for Particle Devices","fork":false,"url":"https://api.github.com/repos/spark/firmware","forks_url":"https://api.github.com/repos/spark/firmware/forks","keys_url":"https://api.github.com/repos/spark/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark/firmware/teams","hooks_url":"https://api.github.com/repos/spark/firmware/hooks","issue_events_url":"https://api.github.com/repos/spark/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/spark/firmware/events","assignees_url":"https://api.github.com/repos/spark/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/spark/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/spark/firmware/tags","blobs_url":"https://api.github.com/repos/spark/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/spark/firmware/languages","stargazers_url":"https://api.github.com/repos/spark/firmware/stargazers","contributors_url":"https://api.github.com/repos/spark/firmware/contributors","subscribers_url":"https://api.github.com/repos/spark/firmware/subscribers","subscription_url":"https://api.github.com/repos/spark/firmware/subscription","commits_url":"https://api.github.com/repos/spark/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/spark/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark/firmware/merges","archive_url":"https://api.github.com/repos/spark/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark/firmware/downloads","issues_url":"https://api.github.com/repos/spark/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/spark/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/spark/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/spark/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark/firmware/labels{/name}","releases_url":"https://api.github.com/repos/spark/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/spark/firmware/deployments","created_at":"2013-03-12T04:42:33Z","updated_at":"2016-12-30T19:50:49Z","pushed_at":"2017-01-01T22:57:55Z","git_url":"git://github.com/spark/firmware.git","ssh_url":"git@github.com:spark/firmware.git","clone_url":"https://github.com/spark/firmware.git","svn_url":"https://github.com/spark/firmware","homepage":"https://www.particle.io/","size":108473,"stargazers_count":553,"watchers_count":553,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":366,"mirror_url":null,"open_issues_count":127,"forks":366,"open_issues":127,"watchers":553,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spark/firmware/pulls/1224"},"html":{"href":"https://github.com/spark/firmware/pull/1224"},"issue":{"href":"https://api.github.com/repos/spark/firmware/issues/1224"},"comments":{"href":"https://api.github.com/repos/spark/firmware/issues/1224/comments"},"review_comments":{"href":"https://api.github.com/repos/spark/firmware/pulls/1224/comments"},"review_comment":{"href":"https://api.github.com/repos/spark/firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spark/firmware/pulls/1224/commits"},"statuses":{"href":"https://api.github.com/repos/spark/firmware/statuses/caf62c32f40eeb3bd92a4badeb2433317911bea7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"avtolstoy"}}