{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15419","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15419/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15419/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15419/events","html_url":"https://github.com/cms-sw/cmssw/pull/15419","id":170482865,"number":15419,"title":"Realistic phase1 hf reco retry","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":1223,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-08-19T09:27:18Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-08-10T18:14:51Z","updated_at":"2016-08-19T16:38:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15419","html_url":"https://github.com/cms-sw/cmssw/pull/15419","diff_url":"https://github.com/cms-sw/cmssw/pull/15419.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15419.patch"},"body":"The content of this PR is the same as the PR #15324 but with merge conflicts fixed. Below are the original comments which came with PR #15324:\r\n\r\nImplementation of the \"HFFlexibleTimeCheck\" Phase 1 HF reconstruction algorithm with associated database classes. Some refactoring of the existing code to eliminate duplication.\r\n\r\nThis pull request has been discussed at\r\nhttps://indico.cern.ch/event/559519/contributions/2257746/attachments/1317838/1975047/notes.pdf\r\n\r\nI would appreciate quick approval. There are some changes in DataFormats needed for subsequent developments.\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/241068423","html_url":"https://github.com/cms-sw/cmssw/pull/15419#issuecomment-241068423","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15419","id":241068423,"user":{"login":"franzoni","id":4729828,"avatar_url":"https://avatars.githubusercontent.com/u/4729828?v=3","gravatar_id":"","url":"https://api.github.com/users/franzoni","html_url":"https://github.com/franzoni","followers_url":"https://api.github.com/users/franzoni/followers","following_url":"https://api.github.com/users/franzoni/following{/other_user}","gists_url":"https://api.github.com/users/franzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/franzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franzoni/subscriptions","organizations_url":"https://api.github.com/users/franzoni/orgs","repos_url":"https://api.github.com/users/franzoni/repos","events_url":"https://api.github.com/users/franzoni/events{/privacy}","received_events_url":"https://api.github.com/users/franzoni/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T16:38:06Z","updated_at":"2016-08-19T16:38:06Z","body":"+1\r\n\r\n@igv4321 \r\nwith reference to https://github.com/cms-sw/cmssw/pull/15324#issuecomment-238220674\r\nthe only class in CondFormats/HcalObjects which is associated to a record is defined in HFPhase1PMTParams.h . \r\nAll other files in that package are not 'HcalObjects' , even though many of them are predisposed for serializations (BOOST_CLASS_EXPORT_KEY) - unless you're planning to match them to a record in the future ?\r\ncheers @franzoni @mmusich \r\n  "}}
{"actor":{"display_login":"franzoni"}}