{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/67439737","id":67439737,"diff_hunk":"@@ -170,6 +173,22 @@ class ExecutionFramework\n \t{\n \t\treturn encodeArgs(u256(0x20), u256(_arg.size()), _arg);\n \t}\n+\tstatic u256 fixed(rational const& _value, int _fixedBits)\n+\t{\n+\t\trational maxValue = (_value < 0) ? \t\t\n+\t\t\trational(bigint(1) << 255, 1):\n+\t\t\trational((bigint(1) << 256) - 1, 1);\n+\t\tunsigned convertingBits = 0;\n+\t\trational value = _value;\n+\t\twhile (value * 0x100 <= maxValue && value.denominator() != 1 && convertingBits < 256)\n+\t\t{\n+\t\t\tvalue *= 0x100;\n+\t\t\tconvertingBits += 8;\n+\t\t}\n+\t\trational finalValue = _value * (bigint(1) << convertingBits);\n+\t\tfinalValue *= boost::multiprecision::pow(bigint(10), (_fixedBits/32));","path":"test/libsolidity/solidityExecutionFramework.h","position":34,"original_position":34,"commit_id":"bbe3db0d973742d9e944e1f690ccb875b23b232e","original_commit_id":"bbe3db0d973742d9e944e1f690ccb875b23b232e","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `bigint(2)`?","created_at":"2016-06-16T23:07:40Z","updated_at":"2016-06-16T23:07:40Z","html_url":"https://github.com/ethereum/solidity/pull/619#discussion_r67439737","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/619","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/67439737"},"html":{"href":"https://github.com/ethereum/solidity/pull/619#discussion_r67439737"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/619","id":72050231,"html_url":"https://github.com/ethereum/solidity/pull/619","diff_url":"https://github.com/ethereum/solidity/pull/619.diff","patch_url":"https://github.com/ethereum/solidity/pull/619.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/619","number":619,"state":"open","locked":false,"title":"Fixed Point Type","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"body":"For now I have merely created a few tests. I am still trying to figure out how we can easily go about encoding this for simple testing. Any pointers are useful. ","created_at":"2016-05-31T16:56:42Z","updated_at":"2016-06-16T23:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d2d41ac4c94c9c115c9d090633c575f2c06e258","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/619/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/619/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/619/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/bbe3db0d973742d9e944e1f690ccb875b23b232e","head":{"label":"VoR0220:fixedDataType","ref":"fixedDataType","sha":"bbe3db0d973742d9e944e1f690ccb875b23b232e","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"repo":{"id":47712924,"name":"solidity","full_name":"VoR0220/solidity","owner":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VoR0220/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":true,"url":"https://api.github.com/repos/VoR0220/solidity","forks_url":"https://api.github.com/repos/VoR0220/solidity/forks","keys_url":"https://api.github.com/repos/VoR0220/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoR0220/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoR0220/solidity/teams","hooks_url":"https://api.github.com/repos/VoR0220/solidity/hooks","issue_events_url":"https://api.github.com/repos/VoR0220/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/VoR0220/solidity/events","assignees_url":"https://api.github.com/repos/VoR0220/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/VoR0220/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/VoR0220/solidity/tags","blobs_url":"https://api.github.com/repos/VoR0220/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoR0220/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoR0220/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoR0220/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoR0220/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/VoR0220/solidity/languages","stargazers_url":"https://api.github.com/repos/VoR0220/solidity/stargazers","contributors_url":"https://api.github.com/repos/VoR0220/solidity/contributors","subscribers_url":"https://api.github.com/repos/VoR0220/solidity/subscribers","subscription_url":"https://api.github.com/repos/VoR0220/solidity/subscription","commits_url":"https://api.github.com/repos/VoR0220/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoR0220/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoR0220/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoR0220/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoR0220/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/VoR0220/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoR0220/solidity/merges","archive_url":"https://api.github.com/repos/VoR0220/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoR0220/solidity/downloads","issues_url":"https://api.github.com/repos/VoR0220/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/VoR0220/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/VoR0220/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/VoR0220/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoR0220/solidity/labels{/name}","releases_url":"https://api.github.com/repos/VoR0220/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/VoR0220/solidity/deployments","created_at":"2015-12-09T19:11:37Z","updated_at":"2016-01-11T03:36:48Z","pushed_at":"2016-06-16T06:49:32Z","git_url":"git://github.com/VoR0220/solidity.git","ssh_url":"git@github.com:VoR0220/solidity.git","clone_url":"https://github.com/VoR0220/solidity.git","svn_url":"https://github.com/VoR0220/solidity","homepage":"","size":8196,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"371690f027aa681ac6c290e383aded5d38ae75ba","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2016-06-16T17:48:51Z","pushed_at":"2016-06-16T22:47:56Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":10706,"stargazers_count":243,"watchers_count":243,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":124,"forks":122,"open_issues":124,"watchers":243,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/619"},"html":{"href":"https://github.com/ethereum/solidity/pull/619"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/619"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/bbe3db0d973742d9e944e1f690ccb875b23b232e"}}}}
{"actor":{"display_login":"chriseth"}}