{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/59401298","id":59401298,"diff_hunk":"@@ -28,50 +28,50 @@\n class TargetedMovementGeneratorBase\n {\n     public:\n-        TargetedMovementGeneratorBase(Unit* target) { i_target.link(target, this); }\n-        void stopFollowing() { }\n+        TargetedMovementGeneratorBase(Unit* target) { m_target.link(target, this); }\n+        void StopFollowing() { }\n     protected:\n-        FollowerReference i_target;\n+        FollowerReference m_target;\n };\n \n template<class T, typename D>\n class TargetedMovementGeneratorMedium : public MovementGeneratorMedium< T, D >, public TargetedMovementGeneratorBase\n {\n-    protected:\n-        TargetedMovementGeneratorMedium(Unit* target, float offset, float angle) :\n-            TargetedMovementGeneratorBase(target), i_path(NULL),\n-            i_recheckDistance(0), i_offset(offset), i_angle(angle),\n-            i_recalculateTravel(false), i_targetReached(false)\n-        {\n-        }\n-        ~TargetedMovementGeneratorMedium() { delete i_path; }\n-\n     public:\n+        TargetedMovementGeneratorMedium(Unit* target, float offset, float angle) : TargetedMovementGeneratorBase(target),\n+            m_path(nullptr), m_recheckDistance(0), m_offset(offset), m_angle(angle), m_recalculateTravel(false), m_targetReached(false), m_interrupt(false) { }\n+\n+        ~TargetedMovementGeneratorMedium();\n+\n         bool DoUpdate(T*, uint32);\n-        Unit* GetTarget() const { return i_target.getTarget(); }\n+        Unit* GetTarget() const { return m_target.getTarget(); }\n+        void DoInterrupt(T*);\n \n-        void unitSpeedChanged() override { i_recalculateTravel = true; }\n-        bool IsReachable() const { return (i_path) ? (i_path->GetPathType() & PATHFIND_NORMAL) : true; }\n+        void UnitSpeedChanged() override { m_recalculateTravel = true; }\n+        void UnitMovementInterrupted(Unit* unit) override { DoInterrupt(static_cast<T*>(unit)); }\n+\n+        virtual void ClearUnitStateMove(T*) { }\n+        virtual void AddUnitStateMove(T*) { }\n+\n+        bool IsReachable() const { return (m_path) ? (m_path->GetPathType() & PATHFIND_NORMAL) : true; }\n     protected:\n-        void _setTargetLocation(T* owner, bool updateDestination);\n-\n-        PathGenerator* i_path;","path":"src/server/game/Movement/MovementGenerators/TargetedMovementGenerator.h","position":48,"original_position":48,"commit_id":"be304ee892112b91c7b6f82838cc2dd6b9eff28b","original_commit_id":"be304ee892112b91c7b6f82838cc2dd6b9eff28b","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"body":"isn't that these fields start with i_* prefix because they are protected and not private ?","created_at":"2016-04-12T15:52:30Z","updated_at":"2016-04-12T15:52:30Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/16941#discussion_r59401298","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/59401298"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16941#discussion_r59401298"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941","id":66083893,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/16941","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/16941.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/16941.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16941","number":16941,"state":"open","locked":false,"title":"[WIP] Core/Movement: Fix MovementGenerators","user":{"login":"ccrs","id":4329612,"avatar_url":"https://avatars.githubusercontent.com/u/4329612?v=3","gravatar_id":"","url":"https://api.github.com/users/ccrs","html_url":"https://github.com/ccrs","followers_url":"https://api.github.com/users/ccrs/followers","following_url":"https://api.github.com/users/ccrs/following{/other_user}","gists_url":"https://api.github.com/users/ccrs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrs/subscriptions","organizations_url":"https://api.github.com/users/ccrs/orgs","repos_url":"https://api.github.com/users/ccrs/repos","events_url":"https://api.github.com/users/ccrs/events{/privacy}","received_events_url":"https://api.github.com/users/ccrs/received_events","type":"User","site_admin":false},"body":"**Changes proposed**:\r\n\r\nCheck every MovementGenerator to fix any problem related such as #16681\r\n\r\n**Target branch(es)**: 335/6x\r\n\r\n**Known issues and TODO list**: \r\n\r\n- [ ] PointMovementGenerator: creature->GetFormation()->LeaderMoveTo\r\n- [ ] EffectMovementGenerator: restore previous movement","created_at":"2016-04-12T00:26:46Z","updated_at":"2016-04-12T15:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07ca750bf93aeb6b4a4a98f46c314ce13fb8c287","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16941/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/be304ee892112b91c7b6f82838cc2dd6b9eff28b","head":{"label":"ccrs:movementgenerators","ref":"movementgenerators","sha":"be304ee892112b91c7b6f82838cc2dd6b9eff28b","user":{"login":"ccrs","id":4329612,"avatar_url":"https://avatars.githubusercontent.com/u/4329612?v=3","gravatar_id":"","url":"https://api.github.com/users/ccrs","html_url":"https://github.com/ccrs","followers_url":"https://api.github.com/users/ccrs/followers","following_url":"https://api.github.com/users/ccrs/following{/other_user}","gists_url":"https://api.github.com/users/ccrs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrs/subscriptions","organizations_url":"https://api.github.com/users/ccrs/orgs","repos_url":"https://api.github.com/users/ccrs/repos","events_url":"https://api.github.com/users/ccrs/events{/privacy}","received_events_url":"https://api.github.com/users/ccrs/received_events","type":"User","site_admin":false},"repo":{"id":36703439,"name":"TrinityCore","full_name":"ccrs/TrinityCore","owner":{"login":"ccrs","id":4329612,"avatar_url":"https://avatars.githubusercontent.com/u/4329612?v=3","gravatar_id":"","url":"https://api.github.com/users/ccrs","html_url":"https://github.com/ccrs","followers_url":"https://api.github.com/users/ccrs/followers","following_url":"https://api.github.com/users/ccrs/following{/other_user}","gists_url":"https://api.github.com/users/ccrs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrs/subscriptions","organizations_url":"https://api.github.com/users/ccrs/orgs","repos_url":"https://api.github.com/users/ccrs/repos","events_url":"https://api.github.com/users/ccrs/events{/privacy}","received_events_url":"https://api.github.com/users/ccrs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccrs/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/ccrs/TrinityCore","forks_url":"https://api.github.com/repos/ccrs/TrinityCore/forks","keys_url":"https://api.github.com/repos/ccrs/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccrs/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccrs/TrinityCore/teams","hooks_url":"https://api.github.com/repos/ccrs/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/ccrs/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/ccrs/TrinityCore/events","assignees_url":"https://api.github.com/repos/ccrs/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/ccrs/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/ccrs/TrinityCore/tags","blobs_url":"https://api.github.com/repos/ccrs/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccrs/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccrs/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccrs/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccrs/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ccrs/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/ccrs/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/ccrs/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/ccrs/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/ccrs/TrinityCore/subscription","commits_url":"https://api.github.com/repos/ccrs/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccrs/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccrs/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccrs/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccrs/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/ccrs/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccrs/TrinityCore/merges","archive_url":"https://api.github.com/repos/ccrs/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccrs/TrinityCore/downloads","issues_url":"https://api.github.com/repos/ccrs/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/ccrs/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ccrs/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ccrs/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccrs/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/ccrs/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/ccrs/TrinityCore/deployments","created_at":"2015-06-02T02:45:58Z","updated_at":"2016-04-11T19:39:52Z","pushed_at":"2016-04-12T15:01:50Z","git_url":"git://github.com/ccrs/TrinityCore.git","ssh_url":"git@github.com:ccrs/TrinityCore.git","clone_url":"https://github.com/ccrs/TrinityCore.git","svn_url":"https://github.com/ccrs/TrinityCore","homepage":"http://www.trinitycore.org","size":375418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"e82a934387b03a0a70e4d402eb5729c24728a698","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-04-12T14:58:26Z","pushed_at":"2016-04-12T15:01:51Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":770700,"stargazers_count":3286,"watchers_count":3286,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3363,"mirror_url":null,"open_issues_count":1411,"forks":3363,"open_issues":1411,"watchers":3286,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16941"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16941"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16941/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16941/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/be304ee892112b91c7b6f82838cc2dd6b9eff28b"}}}}