{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/77439393","id":77439393,"diff_hunk":"@@ -1627,8 +1663,18 @@ static void anop(RAnal *a, RAnalOp *op, ut64 addr, const ut8 *buf, int len, csh\n \t\t{\n \t\top->type = R_ANAL_OP_TYPE_MOV;\n \t\top->ptr = UT64_MAX;\n+\n+\t\top->src[0] = r_anal_value_new ();\n+\t\top->src[0]->reg = r_reg_new ();\n+\t\top->dst = r_anal_value_new ();\n+\n+\t\tparse_reg_name_mov(op->src[0]->reg, &gop.handle, insn, 1);","path":"libr/anal/p/anal_x86_cs.c","position":52,"original_position":52,"commit_id":"0aed0b17ecd8c838f6671a9ef45da67b3638fc04","original_commit_id":"0aed0b17ecd8c838f6671a9ef45da67b3638fc04","user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"body":"add space before (","created_at":"2016-09-03T16:52:59Z","updated_at":"2016-09-03T16:52:59Z","html_url":"https://github.com/radare/radare2/pull/5660#discussion_r77439393","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/5660","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/77439393"},"html":{"href":"https://github.com/radare/radare2/pull/5660#discussion_r77439393"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/5660"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/5660","id":83423697,"html_url":"https://github.com/radare/radare2/pull/5660","diff_url":"https://github.com/radare/radare2/pull/5660.diff","patch_url":"https://github.com/radare/radare2/pull/5660.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/5660","number":5660,"state":"open","locked":false,"title":"r_core_anal_fcn fix","user":{"login":"VPaulV","id":5863225,"avatar_url":"https://avatars.githubusercontent.com/u/5863225?v=3","gravatar_id":"","url":"https://api.github.com/users/VPaulV","html_url":"https://github.com/VPaulV","followers_url":"https://api.github.com/users/VPaulV/followers","following_url":"https://api.github.com/users/VPaulV/following{/other_user}","gists_url":"https://api.github.com/users/VPaulV/gists{/gist_id}","starred_url":"https://api.github.com/users/VPaulV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPaulV/subscriptions","organizations_url":"https://api.github.com/users/VPaulV/orgs","repos_url":"https://api.github.com/users/VPaulV/repos","events_url":"https://api.github.com/users/VPaulV/events{/privacy}","received_events_url":"https://api.github.com/users/VPaulV/received_events","type":"User","site_admin":false},"body":"If an analysed address belongs to some function we simply skip all further analysis.\r\n\r\nTheoretically this fix should significantly decrease number of false positives, also it solves this issue - https://github.com/radare/radare2/issues/4783.","created_at":"2016-08-31T10:07:41Z","updated_at":"2016-09-03T16:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2200d0a313bafce9207b88e08e9455f82f8f4386","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/5660/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/5660/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/5660/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/0aed0b17ecd8c838f6671a9ef45da67b3638fc04","head":{"label":"VPaulV:patch-1","ref":"patch-1","sha":"0aed0b17ecd8c838f6671a9ef45da67b3638fc04","user":{"login":"VPaulV","id":5863225,"avatar_url":"https://avatars.githubusercontent.com/u/5863225?v=3","gravatar_id":"","url":"https://api.github.com/users/VPaulV","html_url":"https://github.com/VPaulV","followers_url":"https://api.github.com/users/VPaulV/followers","following_url":"https://api.github.com/users/VPaulV/following{/other_user}","gists_url":"https://api.github.com/users/VPaulV/gists{/gist_id}","starred_url":"https://api.github.com/users/VPaulV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPaulV/subscriptions","organizations_url":"https://api.github.com/users/VPaulV/orgs","repos_url":"https://api.github.com/users/VPaulV/repos","events_url":"https://api.github.com/users/VPaulV/events{/privacy}","received_events_url":"https://api.github.com/users/VPaulV/received_events","type":"User","site_admin":false},"repo":{"id":65403440,"name":"radare2","full_name":"VPaulV/radare2","owner":{"login":"VPaulV","id":5863225,"avatar_url":"https://avatars.githubusercontent.com/u/5863225?v=3","gravatar_id":"","url":"https://api.github.com/users/VPaulV","html_url":"https://github.com/VPaulV","followers_url":"https://api.github.com/users/VPaulV/followers","following_url":"https://api.github.com/users/VPaulV/following{/other_user}","gists_url":"https://api.github.com/users/VPaulV/gists{/gist_id}","starred_url":"https://api.github.com/users/VPaulV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPaulV/subscriptions","organizations_url":"https://api.github.com/users/VPaulV/orgs","repos_url":"https://api.github.com/users/VPaulV/repos","events_url":"https://api.github.com/users/VPaulV/events{/privacy}","received_events_url":"https://api.github.com/users/VPaulV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VPaulV/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/VPaulV/radare2","forks_url":"https://api.github.com/repos/VPaulV/radare2/forks","keys_url":"https://api.github.com/repos/VPaulV/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VPaulV/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VPaulV/radare2/teams","hooks_url":"https://api.github.com/repos/VPaulV/radare2/hooks","issue_events_url":"https://api.github.com/repos/VPaulV/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/VPaulV/radare2/events","assignees_url":"https://api.github.com/repos/VPaulV/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/VPaulV/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/VPaulV/radare2/tags","blobs_url":"https://api.github.com/repos/VPaulV/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VPaulV/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VPaulV/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/VPaulV/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VPaulV/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/VPaulV/radare2/languages","stargazers_url":"https://api.github.com/repos/VPaulV/radare2/stargazers","contributors_url":"https://api.github.com/repos/VPaulV/radare2/contributors","subscribers_url":"https://api.github.com/repos/VPaulV/radare2/subscribers","subscription_url":"https://api.github.com/repos/VPaulV/radare2/subscription","commits_url":"https://api.github.com/repos/VPaulV/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/VPaulV/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/VPaulV/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/VPaulV/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/VPaulV/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/VPaulV/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VPaulV/radare2/merges","archive_url":"https://api.github.com/repos/VPaulV/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VPaulV/radare2/downloads","issues_url":"https://api.github.com/repos/VPaulV/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/VPaulV/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/VPaulV/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/VPaulV/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VPaulV/radare2/labels{/name}","releases_url":"https://api.github.com/repos/VPaulV/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/VPaulV/radare2/deployments","created_at":"2016-08-10T17:39:14Z","updated_at":"2016-08-10T17:39:30Z","pushed_at":"2016-09-02T13:57:12Z","git_url":"git://github.com/VPaulV/radare2.git","ssh_url":"git@github.com:VPaulV/radare2.git","clone_url":"https://github.com/VPaulV/radare2.git","svn_url":"https://github.com/VPaulV/radare2","homepage":"http://www.radare.org/","size":61834,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"0db81708011ca83fbf134e6b3f9115fb9c35dbc3","user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2016-09-03T15:08:02Z","pushed_at":"2016-09-03T16:49:53Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":80004,"stargazers_count":3149,"watchers_count":3149,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":712,"mirror_url":null,"open_issues_count":799,"forks":712,"open_issues":799,"watchers":3149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/5660"},"html":{"href":"https://github.com/radare/radare2/pull/5660"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/5660"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/5660/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/5660/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/5660/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/0aed0b17ecd8c838f6671a9ef45da67b3638fc04"}}}}
{"actor":{"display_login":"radare"}}