{"action":"created","issue":{"url":"https://api.github.com/repos/filamentgroup/select-css/issues/13","repository_url":"https://api.github.com/repos/filamentgroup/select-css","labels_url":"https://api.github.com/repos/filamentgroup/select-css/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/filamentgroup/select-css/issues/13/comments","events_url":"https://api.github.com/repos/filamentgroup/select-css/issues/13/events","html_url":"https://github.com/filamentgroup/select-css/issues/13","id":136545705,"number":13,"title":"Update to the latest code","user":{"login":"toddparker","id":359929,"avatar_url":"https://avatars.githubusercontent.com/u/359929?v=3","gravatar_id":"","url":"https://api.github.com/users/toddparker","html_url":"https://github.com/toddparker","followers_url":"https://api.github.com/users/toddparker/followers","following_url":"https://api.github.com/users/toddparker/following{/other_user}","gists_url":"https://api.github.com/users/toddparker/gists{/gist_id}","starred_url":"https://api.github.com/users/toddparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddparker/subscriptions","organizations_url":"https://api.github.com/users/toddparker/orgs","repos_url":"https://api.github.com/users/toddparker/repos","events_url":"https://api.github.com/users/toddparker/events{/privacy}","received_events_url":"https://api.github.com/users/toddparker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/filamentgroup/select-css/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"zachleat","id":39355,"avatar_url":"https://avatars.githubusercontent.com/u/39355?v=3","gravatar_id":"","url":"https://api.github.com/users/zachleat","html_url":"https://github.com/zachleat","followers_url":"https://api.github.com/users/zachleat/followers","following_url":"https://api.github.com/users/zachleat/following{/other_user}","gists_url":"https://api.github.com/users/zachleat/gists{/gist_id}","starred_url":"https://api.github.com/users/zachleat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachleat/subscriptions","organizations_url":"https://api.github.com/users/zachleat/orgs","repos_url":"https://api.github.com/users/zachleat/repos","events_url":"https://api.github.com/users/zachleat/events{/privacy}","received_events_url":"https://api.github.com/users/zachleat/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-02-25T23:31:50Z","updated_at":"2016-02-26T03:45:16Z","closed_at":null,"body":"### Latest version:\r\nhttp://jsbin.com/horebic/\r\n\r\n### What's new:\r\n* Wraps the display of the custom arrow and `appearance: none` behind `@supports`\r\n* Moves all hacks into an optional section\r\n* Leverages FF 35 support for `-moz-appearance`\r\n* Ensures that IE 8/9 doesn't show the custom arrow and native select arrow (old bug)\r\n* IE 10/11 has a custom arrow since we can hide the native arrow via hackiness\r\n* Removes the Opera hack for double arrows since we now shield the styles via `@support`\r\n\r\n\r\n\r\n### Bug: Removing the FF hacks shows a double arrow in v4-35\r\nFor FF, if I remove our hack to make it look good in versions 4-35, it looks like it's still showing the custom arrow even though it's `display: none` and visibility is tucked behind `@supports`. I had to add this to hide the arrow - why would older FF be passing `@supports ( -moz-appearance: none )` to show the arrow?\r\n\r\nFor now, I've added this rule inside `@supports`, then display it inside the old FF hack so we can delete the FF hacks and the native arrow will show up. Can we get rid of this?\r\n\r\n```\r\n    /* Show only the native arrow */\r\n    @-moz-document url-prefix() { \r\n      .custom-select::after {\r\n        display:none;\r\n      }\r\n    }\r\n```\r\n\r\n### I've confirmed I can remove the IE hacks and it falls back nicely to the native arrow with custom button styling\r\n\r\nTODO:\r\n* Separate out demo styles from core select styles\r\n* Break out backcompat for IE and FF - TODO: make sure we fallback to a native select arrow if these aren't in play\r\n* Final testing\r\n* Upstream into formcore\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/filamentgroup/select-css/issues/comments/189099217","html_url":"https://github.com/filamentgroup/select-css/issues/13#issuecomment-189099217","issue_url":"https://api.github.com/repos/filamentgroup/select-css/issues/13","id":189099217,"user":{"login":"toddparker","id":359929,"avatar_url":"https://avatars.githubusercontent.com/u/359929?v=3","gravatar_id":"","url":"https://api.github.com/users/toddparker","html_url":"https://github.com/toddparker","followers_url":"https://api.github.com/users/toddparker/followers","following_url":"https://api.github.com/users/toddparker/following{/other_user}","gists_url":"https://api.github.com/users/toddparker/gists{/gist_id}","starred_url":"https://api.github.com/users/toddparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddparker/subscriptions","organizations_url":"https://api.github.com/users/toddparker/orgs","repos_url":"https://api.github.com/users/toddparker/repos","events_url":"https://api.github.com/users/toddparker/events{/privacy}","received_events_url":"https://api.github.com/users/toddparker/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T03:45:16Z","updated_at":"2016-02-26T03:45:16Z","body":"@karlcow - thanks for that suggested fix, good idea. If you open the jsbin and delete the FF hacks at the end AND the little temp fix style I included above (it's in the @support block), the custom  arrow will appear in FF 34 and lower but it shouldn't (you see both the native and custom arrow). The goal is to only show the custom arrow if -moz-appearance is supported and it's odd that it's picking up this rule when it's not supported."}}