{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2153","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2153/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2153/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2153/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2153","id":157241446,"number":2153,"title":"Make TextIntroduction's has_rule funtional","user":{"login":"Scotchester","id":1044670,"avatar_url":"https://avatars.githubusercontent.com/u/1044670?v=3","gravatar_id":"","url":"https://api.github.com/users/Scotchester","html_url":"https://github.com/Scotchester","followers_url":"https://api.github.com/users/Scotchester/followers","following_url":"https://api.github.com/users/Scotchester/following{/other_user}","gists_url":"https://api.github.com/users/Scotchester/gists{/gist_id}","starred_url":"https://api.github.com/users/Scotchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scotchester/subscriptions","organizations_url":"https://api.github.com/users/Scotchester/orgs","repos_url":"https://api.github.com/users/Scotchester/repos","events_url":"https://api.github.com/users/Scotchester/events{/privacy}","received_events_url":"https://api.github.com/users/Scotchester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-27T16:14:11Z","updated_at":"2016-05-27T16:25:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2153","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2153","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2153.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2153.patch"},"body":"The \"Has rule\" option in the Text Introduction module wasn't actually doing anything. This PR fixes that.\r\n\r\n## Additions\r\n\r\n- Documentation of `has_rule` option to Text Introduction template\r\n\r\n## Changes\r\n\r\n- Updates the `render_block` macro to add `.block__padded-bottom.block__border-bottom` to the `div` if it finds a truthy `has_rule` option in the block it's rendering.\r\n- Updates several template files to use `render_block` in all cases where they should be.\r\n- Standardizes `import` rules at the top of the file. _(Let me know if this was a bad idea.)_\r\n\r\n## Testing\r\n\r\nVerifying bug:\r\n1. Check the \"Has rule\" option in a Text Introduction module in any Wagtail page.\r\n2. Preview the page and see that no rule is added below the module.\r\n\r\nVerifying fix:\r\n1. Pull branch.\r\n2. In your local Wagtail, \r\n3. Publish the page and view the result. It now has a rule at the bottom!\r\n4. For extra credit, create each one of the page types modified in this PR (browse basic, browse filterable, landing, learn) with Text Introduction modules and test all of them.\r\n\r\n## Review\r\n\r\n- @kurtw \r\n- @sebworks \r\n- @jimmynotjim \r\n- @KimberlyMunoz \r\n- @anselmbradford \r\n\r\n## Todos\r\n\r\n- Out of scope of this PR, but @kurtw mentioned that the other module-related logic in these page templates could maybe be further simplified?\r\n\r\n## Checklist\r\n\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/222191365","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2153#issuecomment-222191365","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2153","id":222191365,"user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T16:25:20Z","updated_at":"2016-05-27T16:25:20Z","body":"Tested locally and 👍 "}}
{"actor":{"display_login":"jimmynotjim"}}