{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/20641","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/20641/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/20641/comments","events_url":"https://api.github.com/repos/docker/docker/issues/20641/events","html_url":"https://github.com/docker/docker/pull/20641","id":135934878,"number":20641,"title":"Revert fsnotify changes","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-24T02:41:25Z","updated_at":"2016-02-24T04:02:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20641","html_url":"https://github.com/docker/docker/pull/20641","diff_url":"https://github.com/docker/docker/pull/20641.diff","patch_url":"https://github.com/docker/docker/pull/20641.patch"},"body":"Reverts changes to remove fsnotify from json log reader.\r\nThis caused a slowdown that made TestLogsFollowSlowStdoutConsumer fail on ARM 100% of the time.\r\n\r\n```\r\nbenchmark                               old ns/op     new ns/op     delta\r\nBenchmarkJSONFileLogger-8               53205         53077         -0.24%\r\nBenchmarkJSONFileLoggerWithReader-8     93100         56483         -39.33%\r\n\r\nbenchmark                               old MB/s     new MB/s     speedup\r\nBenchmarkJSONFileLogger-8               68.23        68.39        1.00x\r\nBenchmarkJSONFileLoggerWithReader-8     20.30        33.46        1.65x\r\n\r\nbenchmark                               old allocs     new allocs     delta\r\nBenchmarkJSONFileLogger-8               30             30             +0.00%\r\nBenchmarkJSONFileLoggerWithReader-8     193            128            -33.68%\r\n\r\nbenchmark                               old bytes     new bytes     delta\r\nBenchmarkJSONFileLogger-8               960           960           +0.00%\r\nBenchmarkJSONFileLoggerWithReader-8     5753          3857          -32.96%\r\n```"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/188053428","html_url":"https://github.com/docker/docker/pull/20641#issuecomment-188053428","issue_url":"https://api.github.com/repos/docker/docker/issues/20641","id":188053428,"user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T04:02:13Z","updated_at":"2016-02-24T04:02:13Z","body":"I ran arm tests on your PR and they failed."}}