{"action":"closed","number":957,"pull_request":{"url":"https://api.github.com/repos/skatejs/skatejs/pulls/957","id":96519250,"html_url":"https://github.com/skatejs/skatejs/pull/957","diff_url":"https://github.com/skatejs/skatejs/pull/957.diff","patch_url":"https://github.com/skatejs/skatejs/pull/957.patch","issue_url":"https://api.github.com/repos/skatejs/skatejs/issues/957","number":957,"state":"closed","locked":false,"title":"#957 - class PropDefinition holds prop name and normalized prop options","user":{"login":"andreawyss","id":4635265,"avatar_url":"https://avatars.githubusercontent.com/u/4635265?v=3","gravatar_id":"","url":"https://api.github.com/users/andreawyss","html_url":"https://github.com/andreawyss","followers_url":"https://api.github.com/users/andreawyss/followers","following_url":"https://api.github.com/users/andreawyss/following{/other_user}","gists_url":"https://api.github.com/users/andreawyss/gists{/gist_id}","starred_url":"https://api.github.com/users/andreawyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreawyss/subscriptions","organizations_url":"https://api.github.com/users/andreawyss/orgs","repos_url":"https://api.github.com/users/andreawyss/repos","events_url":"https://api.github.com/users/andreawyss/events{/privacy}","received_events_url":"https://api.github.com/users/andreawyss/received_events","type":"User","site_admin":false},"body":"With the new internal class 'PropDefinition' I have simplified a few functions.\r\n\r\n@treshugart @Hotell @bradleyayers this PR is now ready for you to review.\r\nBesides a pure refactor there is a small change in how NaN works for a prop.number().\r\nSetting the prop to NaN will maintain the NaN value and serialize attribute to 'NaN' which deserializes back to NaN.\r\nThis should be a small breaking change that will not affect most common usecases.\r\nI had to only change one test and use Object.is for testing equality of NaN equal NaN.\r\n\r\nThere was also a bit of inconsistency in the code where empty was sometimes normalized to undefined and in other places to null. Now everywhere empty is normalized to null. This didn't affect any tests.\r\nThis should also be transparent to most users since each build-in prop had a default that was preventing them to be empty and the default value of the 'default' option was null also.\r\nboolean --> false\r\nnumber --> 0\r\nstring --> ''\r\narray --> []","created_at":"2016-12-05T12:23:32Z","updated_at":"2016-12-05T22:38:59Z","closed_at":"2016-12-05T22:38:59Z","merged_at":"2016-12-05T22:38:59Z","merge_commit_sha":"39375e33649d0d72855f7253d5fb871b0316a38d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/skatejs/skatejs/pulls/957/commits","review_comments_url":"https://api.github.com/repos/skatejs/skatejs/pulls/957/comments","review_comment_url":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/957/comments","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/c729aef266aaf9921d3a5c612bbd6681746fe75f","head":{"label":"skatejs:prop-definition","ref":"prop-definition","sha":"c729aef266aaf9921d3a5c612bbd6681746fe75f","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"SkateJS is a web component library designed to give you an augmentation of the web component specs focusing on a functional rendering pipeline, clean property / attribute semantics and a small footprint.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","deployments_url":"https://api.github.com/repos/skatejs/skatejs/deployments","created_at":"2014-02-01T00:32:47Z","updated_at":"2016-12-05T15:15:25Z","pushed_at":"2016-12-05T22:38:59Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"http://skate.js.org","size":6059,"stargazers_count":1799,"watchers_count":1799,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":43,"forks":75,"open_issues":43,"watchers":1799,"default_branch":"master"}},"base":{"label":"skatejs:master","ref":"master","sha":"8c5f5cb37d25775b7d096ca48269cba5467ebac9","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"SkateJS is a web component library designed to give you an augmentation of the web component specs focusing on a functional rendering pipeline, clean property / attribute semantics and a small footprint.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","deployments_url":"https://api.github.com/repos/skatejs/skatejs/deployments","created_at":"2014-02-01T00:32:47Z","updated_at":"2016-12-05T15:15:25Z","pushed_at":"2016-12-05T22:38:59Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"http://skate.js.org","size":6059,"stargazers_count":1799,"watchers_count":1799,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":43,"forks":75,"open_issues":43,"watchers":1799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/957"},"html":{"href":"https://github.com/skatejs/skatejs/pull/957"},"issue":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/957"},"comments":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/skatejs/skatejs/statuses/c729aef266aaf9921d3a5c612bbd6681746fe75f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andreawyss","id":4635265,"avatar_url":"https://avatars.githubusercontent.com/u/4635265?v=3","gravatar_id":"","url":"https://api.github.com/users/andreawyss","html_url":"https://github.com/andreawyss","followers_url":"https://api.github.com/users/andreawyss/followers","following_url":"https://api.github.com/users/andreawyss/following{/other_user}","gists_url":"https://api.github.com/users/andreawyss/gists{/gist_id}","starred_url":"https://api.github.com/users/andreawyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreawyss/subscriptions","organizations_url":"https://api.github.com/users/andreawyss/orgs","repos_url":"https://api.github.com/users/andreawyss/repos","events_url":"https://api.github.com/users/andreawyss/events{/privacy}","received_events_url":"https://api.github.com/users/andreawyss/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":19,"additions":229,"deletions":142,"changed_files":13}}
{"actor":{"display_login":"andreawyss"}}