{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/1349","repository_url":"https://api.github.com/repos/Microsoft/msbuild","labels_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1349/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1349/comments","events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1349/events","html_url":"https://github.com/Microsoft/msbuild/pull/1349","id":189560778,"number":1349,"title":"Guard against null ref when a Glob exclude fails to match any files","user":{"login":"hippiehunter","id":624627,"avatar_url":"https://avatars.githubusercontent.com/u/624627?v=3","gravatar_id":"","url":"https://api.github.com/users/hippiehunter","html_url":"https://github.com/hippiehunter","followers_url":"https://api.github.com/users/hippiehunter/followers","following_url":"https://api.github.com/users/hippiehunter/following{/other_user}","gists_url":"https://api.github.com/users/hippiehunter/gists{/gist_id}","starred_url":"https://api.github.com/users/hippiehunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippiehunter/subscriptions","organizations_url":"https://api.github.com/users/hippiehunter/orgs","repos_url":"https://api.github.com/users/hippiehunter/repos","events_url":"https://api.github.com/users/hippiehunter/events{/privacy}","received_events_url":"https://api.github.com/users/hippiehunter/received_events","type":"User","site_admin":false},"labels":[{"id":201571835,"url":"https://api.github.com/repos/Microsoft/msbuild/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-16T01:56:10Z","updated_at":"2016-11-19T00:37:57Z","closed_at":"2016-11-19T00:37:43Z","pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1349","html_url":"https://github.com/Microsoft/msbuild/pull/1349","diff_url":"https://github.com/Microsoft/msbuild/pull/1349.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/1349.patch"},"body":"[test.txt](https://github.com/Microsoft/msbuild/files/593579/test.txt)\r\n\r\nI've included a sample project file that would cause a null ref in src/Shared/FileMatcher.cs. I looked around inside GetFilesRecursiveStep to see if Files should have just been set to an empty array, but it didn't appear to match stylistically with the surrounding code so I just put the guard in GetFilesRecursive."},"comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments/261677981","html_url":"https://github.com/Microsoft/msbuild/pull/1349#issuecomment-261677981","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1349","id":261677981,"user":{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T00:37:57Z","updated_at":"2016-11-19T00:37:57Z","body":"Thanks, @hippiehunter!"}}
{"actor":{"display_login":"rainersigwald"}}