{"action":"created","comment":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/comments/88206197","pull_request_review_id":8785348,"id":88206197,"diff_hunk":"@@ -29,10 +29,10 @@ module.exports = (repo) => {\n         expect(Buffer.isBuffer(node.data)).to.be.true.mark()\n         expect(node.size).to.be.above(0).mark()\n \n-        util.serialize(node, (err, serialized) => {\n+        DAGNode._serialize(node, (err, serialized) => {","path":"test/dag-node-test.js","position":null,"original_position":5,"commit_id":"98d06b013ffbb7217d04999acfe197be0347df13","original_commit_id":"4e7d47f89cb4c685229dfd7f932d9fc4494cc056","user":{"login":"haadcode","id":7499694,"avatar_url":"https://avatars.githubusercontent.com/u/7499694?v=3","gravatar_id":"","url":"https://api.github.com/users/haadcode","html_url":"https://github.com/haadcode","followers_url":"https://api.github.com/users/haadcode/followers","following_url":"https://api.github.com/users/haadcode/following{/other_user}","gists_url":"https://api.github.com/users/haadcode/gists{/gist_id}","starred_url":"https://api.github.com/users/haadcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haadcode/subscriptions","organizations_url":"https://api.github.com/users/haadcode/orgs","repos_url":"https://api.github.com/users/haadcode/repos","events_url":"https://api.github.com/users/haadcode/events{/privacy}","received_events_url":"https://api.github.com/users/haadcode/received_events","type":"User","site_admin":false},"body":"Take that back, I understand what you mean with the comment. However, the util API doesn't make sense to me. Why would they need to be namespaced under utils instead of haing them on the top level? Ie.\r\n```javascript\r\nconst DAGNode = require('dag-node')\r\nconst node = DAGNode.create(...)\r\nDAGNode.serialize(node, ...)\r\nDAGNode.deserialize(node, ...)\r\n// etc.\r\n```\r\n","created_at":"2016-11-16T10:18:14Z","updated_at":"2016-11-16T10:18:14Z","html_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7#discussion_r88206197","pull_request_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/comments/88206197"},"html":{"href":"https://github.com/ipld/js-ipld-dag-pb/pull/7#discussion_r88206197"},"pull_request":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7","id":93586366,"html_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7","diff_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7.diff","patch_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7.patch","issue_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7","number":7,"state":"open","locked":false,"title":"Refactor feat/immutable PR","user":{"login":"haadcode","id":7499694,"avatar_url":"https://avatars.githubusercontent.com/u/7499694?v=3","gravatar_id":"","url":"https://api.github.com/users/haadcode","html_url":"https://github.com/haadcode","followers_url":"https://api.github.com/users/haadcode/followers","following_url":"https://api.github.com/users/haadcode/following{/other_user}","gists_url":"https://api.github.com/users/haadcode/gists{/gist_id}","starred_url":"https://api.github.com/users/haadcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haadcode/subscriptions","organizations_url":"https://api.github.com/users/haadcode/orgs","repos_url":"https://api.github.com/users/haadcode/repos","events_url":"https://api.github.com/users/haadcode/events{/privacy}","received_events_url":"https://api.github.com/users/haadcode/received_events","type":"User","site_admin":false},"body":"Refactored https://github.com/ipld/js-ipld-dag-pb/pull/6","created_at":"2016-11-14T15:24:51Z","updated_at":"2016-11-16T10:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ced63954f20acca710331ae2f825b387699ef7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7/comments","statuses_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/statuses/98d06b013ffbb7217d04999acfe197be0347df13","head":{"label":"ipld:feat/immutable-haad","ref":"feat/immutable-haad","sha":"98d06b013ffbb7217d04999acfe197be0347df13","user":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"repo":{"id":69641599,"name":"js-ipld-dag-pb","full_name":"ipld/js-ipld-dag-pb","owner":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipld/js-ipld-dag-pb","description":"JavaScript Implementation of the MerkleDAG Nodes with Protobuf.","fork":false,"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb","forks_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/forks","keys_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/teams","hooks_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/hooks","issue_events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/events{/number}","events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/events","assignees_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/assignees{/user}","branches_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/branches{/branch}","tags_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/tags","blobs_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/statuses/{sha}","languages_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/languages","stargazers_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/stargazers","contributors_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/contributors","subscribers_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/subscribers","subscription_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/subscription","commits_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/contents/{+path}","compare_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/merges","archive_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/downloads","issues_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues{/number}","pulls_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls{/number}","milestones_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/milestones{/number}","notifications_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/labels{/name}","releases_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/releases{/id}","deployments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/deployments","created_at":"2016-09-30T06:51:36Z","updated_at":"2016-11-16T02:16:03Z","pushed_at":"2016-11-16T09:53:50Z","git_url":"git://github.com/ipld/js-ipld-dag-pb.git","ssh_url":"git@github.com:ipld/js-ipld-dag-pb.git","clone_url":"https://github.com/ipld/js-ipld-dag-pb.git","svn_url":"https://github.com/ipld/js-ipld-dag-pb","homepage":null,"size":86538,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"ipld:feat/immutable","ref":"feat/immutable","sha":"4bdb48bd80a2d5a459204f08f69f4e4e4649e027","user":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"repo":{"id":69641599,"name":"js-ipld-dag-pb","full_name":"ipld/js-ipld-dag-pb","owner":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipld/js-ipld-dag-pb","description":"JavaScript Implementation of the MerkleDAG Nodes with Protobuf.","fork":false,"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb","forks_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/forks","keys_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/teams","hooks_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/hooks","issue_events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/events{/number}","events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/events","assignees_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/assignees{/user}","branches_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/branches{/branch}","tags_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/tags","blobs_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/statuses/{sha}","languages_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/languages","stargazers_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/stargazers","contributors_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/contributors","subscribers_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/subscribers","subscription_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/subscription","commits_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/contents/{+path}","compare_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/merges","archive_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/downloads","issues_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues{/number}","pulls_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls{/number}","milestones_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/milestones{/number}","notifications_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/labels{/name}","releases_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/releases{/id}","deployments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/deployments","created_at":"2016-09-30T06:51:36Z","updated_at":"2016-11-16T02:16:03Z","pushed_at":"2016-11-16T09:53:50Z","git_url":"git://github.com/ipld/js-ipld-dag-pb.git","ssh_url":"git@github.com:ipld/js-ipld-dag-pb.git","clone_url":"https://github.com/ipld/js-ipld-dag-pb.git","svn_url":"https://github.com/ipld/js-ipld-dag-pb","homepage":null,"size":86538,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7"},"html":{"href":"https://github.com/ipld/js-ipld-dag-pb/pull/7"},"issue":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7"},"comments":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ipld/js-ipld-dag-pb/statuses/98d06b013ffbb7217d04999acfe197be0347df13"}}}}
{"actor":{"display_login":"haadcode"}}