{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/4259","repository_url":"https://api.github.com/repos/Homebrew/homebrew-core","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/4259/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/4259/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/4259/events","html_url":"https://github.com/Homebrew/homebrew-core/pull/4259","id":173569044,"number":4259,"title":"Install gdk-pixbuf `loaders.cache` file to proper location","user":{"login":"staticfloat","id":130920,"avatar_url":"https://avatars.githubusercontent.com/u/130920?v=3","gravatar_id":"","url":"https://api.github.com/users/staticfloat","html_url":"https://github.com/staticfloat","followers_url":"https://api.github.com/users/staticfloat/followers","following_url":"https://api.github.com/users/staticfloat/following{/other_user}","gists_url":"https://api.github.com/users/staticfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/staticfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staticfloat/subscriptions","organizations_url":"https://api.github.com/users/staticfloat/orgs","repos_url":"https://api.github.com/users/staticfloat/repos","events_url":"https://api.github.com/users/staticfloat/events{/privacy}","received_events_url":"https://api.github.com/users/staticfloat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-27T00:53:28Z","updated_at":"2016-08-31T04:14:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/4259","html_url":"https://github.com/Homebrew/homebrew-core/pull/4259","diff_url":"https://github.com/Homebrew/homebrew-core/pull/4259.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/4259.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --new-formula <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\n`brew audit --new-formula` gives the following errors:\r\n\r\n```\r\n$ brew audit --new-formula ./gdk-pixbuf.rb\r\ngdk-pixbuf:\r\n  * Use the `ln` Ruby method instead of `system \"ln\"`\r\n  * Formulae are required to declare all linked dependencies.\r\n    Please add all linked dependencies to the formula with:\r\n      depends_on \"gettext\" => :linked\r\nError: 2 problems in 1 formula\r\n```\r\n\r\n* I am not using the `ln` ruby method because I didn't know how to make it overwrite existing files (which it must if you run `postinstall` twice, or if you have previously installed `gdk-pixbuf` through Homebrew).  I saw [this comment](https://github.com/Homebrew/brew/blob/f4fb655aaa907e8ec642469ae21ca03e6cef2e21/Library/Homebrew/cmd/linkapps.rb#L44-L46) in the Homebrew codebase and decided to follow suit.\r\n\r\n* I was previously told not to add the `\"gettext\" -> :linked` dependency, so I am holding off on that for now.\r\n\r\nThe rationale behind this change is explored in detail in [this thread](https://github.com/Homebrew/homebrew-core/pull/3279), but I'll quote the most relevant parts here:\r\n\r\n> as it stands right now, in a \"normal\" /usr/local Homebrew installation, the loaders.cache file is not a symlink to the currently-installed gdk-pixbuf keg, it is a normal file. This (theoretically) doesn't allow for things like quick switching from version to version through unlinking different kegs of the same formula, just plain doesn't work properly on non-/usr/local Homebrew installations, and in general breaks Homebrew encapsulation.\r\n\r\n> On a non-/usr/local Homebrew installation, the environment variables are defined properly and the loaders.cache file is created in the proper place, but no symlink is created because post_install is invoked after link."},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments/243653853","html_url":"https://github.com/Homebrew/homebrew-core/pull/4259#issuecomment-243653853","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/4259","id":243653853,"user":{"login":"dunn","id":985416,"avatar_url":"https://avatars.githubusercontent.com/u/985416?v=3","gravatar_id":"","url":"https://api.github.com/users/dunn","html_url":"https://github.com/dunn","followers_url":"https://api.github.com/users/dunn/followers","following_url":"https://api.github.com/users/dunn/following{/other_user}","gists_url":"https://api.github.com/users/dunn/gists{/gist_id}","starred_url":"https://api.github.com/users/dunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunn/subscriptions","organizations_url":"https://api.github.com/users/dunn/orgs","repos_url":"https://api.github.com/users/dunn/repos","events_url":"https://api.github.com/users/dunn/events{/privacy}","received_events_url":"https://api.github.com/users/dunn/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T04:14:40Z","updated_at":"2016-08-31T04:14:40Z","body":"> I am not using the ln ruby method because I didn't know how to make it overwrite existing files\r\n\r\nYou can use `ln_sf`; see http://ruby-doc.org/stdlib-2.3.1/libdoc/fileutils/rdoc/FileUtils.html#method-c-ln_sf"}}
{"actor":{"display_login":"dunn"}}