{"action":"created","issue":{"url":"https://api.github.com/repos/ufz/ogs/issues/1238","repository_url":"https://api.github.com/repos/ufz/ogs","labels_url":"https://api.github.com/repos/ufz/ogs/issues/1238/labels{/name}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1238/comments","events_url":"https://api.github.com/repos/ufz/ogs/issues/1238/events","html_url":"https://github.com/ufz/ogs/pull/1238","id":158328231,"number":1238,"title":"Mesh partitioning tool","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ufz/ogs/labels/please%20review","name":"please review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-03T09:35:37Z","updated_at":"2016-06-07T08:35:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1238","html_url":"https://github.com/ufz/ogs/pull/1238","diff_url":"https://github.com/ufz/ogs/pull/1238.diff","patch_url":"https://github.com/ufz/ogs/pull/1238.patch"},"body":"Added the mesh partitioning tool as a utility of ogs6.\r\nUsage: \r\n* partmesh --help\r\n* partmesh -1 [or ogs2metis] -i foo.vtu [or foo] // to convert mesh data to metis input data\r\n* partmesh -n 3 -i foo.vtu[or foo]\r\n\r\nWith a cmake option of UTILS_PARTMESH_BUILD_WITH_METIS, the source code of metis can be compiled into the executable file. \r\n\r\n**Issues**: \r\n1 The source code of metis (url = https://github.com/envinf/metis.git)  is added as a submodule. The question is where to host metis.git for ogs6. That's why this submodule has not been added into SubmoduleStepup.cmake yet.\r\n2. is Apache License Version 2.0 of metis OK for ogs6?"},"comment":{"url":"https://api.github.com/repos/ufz/ogs/issues/comments/224215536","html_url":"https://github.com/ufz/ogs/pull/1238#issuecomment-224215536","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1238","id":224215536,"user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T08:35:54Z","updated_at":"2016-06-07T08:35:54Z","body":"I could not follow the code after the line 180 or so. I recommend to split the very long loop over the partitions into several smaller standalone routines, which fit into a screen.\r\nThere are also those  \"if ascii then A else B\" conditionals in several places which are difficult to follow; extracting this parts into own routines would greatly help the understanding.\r\nIt seems to me there are multiple global variables used through the code. Their state is very difficult to follow. Introducing smaller scopes would help."}}
{"actor":{"display_login":"endJunction"}}