{"action":"created","comment":{"url":"https://api.github.com/repos/acquia/acquia_lift/pulls/comments/69736499","id":69736499,"diff_hunk":"@@ -102,50 +95,37 @@ private function buildCredentialForm() {\n     $form['account_name'] = [\n       '#type' => 'textfield',\n       '#title' => t('Account Name'),\n+      '#description' => t('Your Lift subscription\\'s account name.'),\n       '#default_value' => $credential_settings['account_name'],\n       '#required' => TRUE,\n     ];\n     $form['customer_site'] = [\n       '#type' => 'textfield',\n       '#title' => t('Customer Site'),\n+      '#description' => t('Current site\\'s site name. WARNING: different sites must use different value here, even between a staging and a production of the same site.'),\n       '#default_value' => $credential_settings['customer_site'],\n-    ];\n-    $form['api_url'] = [\n-      '#type' => 'textfield',\n-      '#title' => t('API URL'),\n-      '#default_value' => $credential_settings['api_url'],\n-      '#required' => TRUE,\n-    ];\n-    $form['access_key'] = [\n-      '#type' => 'textfield',\n-      '#title' => t('API Access Key'),\n-      '#default_value' => $credential_settings['access_key'],\n-      '#required' => TRUE,\n-    ];\n-    $form['secret_key'] = [\n-      '#type' => 'password',\n-      '#title' => t('API Secret Key'),\n-      '#default_value' => $credential_settings['secret_key'],\n-      '#required' => empty($credential_settings['secret_key']),\n-      '#description' => !empty($credential_settings['secret_key']) ? t('Only necessary if updating') : '',\n-    ];\n-    $form['js_path'] = [\n-      '#type' => 'textfield',\n-      '#title' => t('JavaScript Path'),\n-      '#default_value' => $credential_settings['js_path'],\n       '#required' => TRUE,\n     ];\n     $form['assets_url'] = [\n       '#type' => 'textfield',\n       '#title' => t('Assets URL'),\n-      '#default_value' => $credential_settings['assets_url'],\n+      '#field_prefix' => 'https://',","path":"src/Form/AdminSettingsForm.php","position":74,"original_position":74,"commit_id":"f807ced5826894bd3220cbe7c2ff001d44886bc0","original_commit_id":"f807ced5826894bd3220cbe7c2ff001d44886bc0","user":{"login":"ynx","id":1379691,"avatar_url":"https://avatars.githubusercontent.com/u/1379691?v=3","gravatar_id":"","url":"https://api.github.com/users/ynx","html_url":"https://github.com/ynx","followers_url":"https://api.github.com/users/ynx/followers","following_url":"https://api.github.com/users/ynx/following{/other_user}","gists_url":"https://api.github.com/users/ynx/gists{/gist_id}","starred_url":"https://api.github.com/users/ynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynx/subscriptions","organizations_url":"https://api.github.com/users/ynx/orgs","repos_url":"https://api.github.com/users/ynx/repos","events_url":"https://api.github.com/users/ynx/events{/privacy}","received_events_url":"https://api.github.com/users/ynx/received_events","type":"User","site_admin":false},"body":"Yes it trims and converts, cowboy style. =P\r\n\r\nI would consider those mechanisms just precautions, and wouldn't expect them to catch a lot mistakes. This is because in the current process, we [generate](https://backlog.acquia.com/browse/CSO-3578?focusedCommentId=637294&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-637294) and customers receive all credential info. I wouldn't really worry about a customer going off-course from simple instructions.","created_at":"2016-07-06T14:07:13Z","updated_at":"2016-07-06T14:07:13Z","html_url":"https://github.com/acquia/acquia_lift/pull/232#discussion_r69736499","pull_request_url":"https://api.github.com/repos/acquia/acquia_lift/pulls/232","_links":{"self":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/comments/69736499"},"html":{"href":"https://github.com/acquia/acquia_lift/pull/232#discussion_r69736499"},"pull_request":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/232"}}},"pull_request":{"url":"https://api.github.com/repos/acquia/acquia_lift/pulls/232","id":75728711,"html_url":"https://github.com/acquia/acquia_lift/pull/232","diff_url":"https://github.com/acquia/acquia_lift/pull/232.diff","patch_url":"https://github.com/acquia/acquia_lift/pull/232.patch","issue_url":"https://api.github.com/repos/acquia/acquia_lift/issues/232","number":232,"state":"open","locked":false,"title":"Lex 726","user":{"login":"ynx","id":1379691,"avatar_url":"https://avatars.githubusercontent.com/u/1379691?v=3","gravatar_id":"","url":"https://api.github.com/users/ynx","html_url":"https://github.com/ynx","followers_url":"https://api.github.com/users/ynx/followers","following_url":"https://api.github.com/users/ynx/following{/other_user}","gists_url":"https://api.github.com/users/ynx/gists{/gist_id}","starred_url":"https://api.github.com/users/ynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynx/subscriptions","organizations_url":"https://api.github.com/users/ynx/orgs","repos_url":"https://api.github.com/users/ynx/repos","events_url":"https://api.github.com/users/ynx/events{/privacy}","received_events_url":"https://api.github.com/users/ynx/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-29T21:56:32Z","updated_at":"2016-07-06T14:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44895203bf49cda70c74805429506c630bac73c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/acquia/acquia_lift/pulls/232/commits","review_comments_url":"https://api.github.com/repos/acquia/acquia_lift/pulls/232/comments","review_comment_url":"https://api.github.com/repos/acquia/acquia_lift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/acquia_lift/issues/232/comments","statuses_url":"https://api.github.com/repos/acquia/acquia_lift/statuses/f807ced5826894bd3220cbe7c2ff001d44886bc0","head":{"label":"acquia:LEX-726","ref":"LEX-726","sha":"f807ced5826894bd3220cbe7c2ff001d44886bc0","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":17344049,"name":"acquia_lift","full_name":"acquia/acquia_lift","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/acquia_lift","description":"Mirror of the drupal.org repository for Acquia Lift module","fork":false,"url":"https://api.github.com/repos/acquia/acquia_lift","forks_url":"https://api.github.com/repos/acquia/acquia_lift/forks","keys_url":"https://api.github.com/repos/acquia/acquia_lift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/acquia_lift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/acquia_lift/teams","hooks_url":"https://api.github.com/repos/acquia/acquia_lift/hooks","issue_events_url":"https://api.github.com/repos/acquia/acquia_lift/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/acquia_lift/events","assignees_url":"https://api.github.com/repos/acquia/acquia_lift/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/acquia_lift/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/acquia_lift/tags","blobs_url":"https://api.github.com/repos/acquia/acquia_lift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/acquia_lift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/acquia_lift/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/acquia_lift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/acquia_lift/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/acquia_lift/languages","stargazers_url":"https://api.github.com/repos/acquia/acquia_lift/stargazers","contributors_url":"https://api.github.com/repos/acquia/acquia_lift/contributors","subscribers_url":"https://api.github.com/repos/acquia/acquia_lift/subscribers","subscription_url":"https://api.github.com/repos/acquia/acquia_lift/subscription","commits_url":"https://api.github.com/repos/acquia/acquia_lift/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/acquia_lift/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/acquia_lift/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/acquia_lift/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/acquia_lift/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/acquia_lift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/acquia_lift/merges","archive_url":"https://api.github.com/repos/acquia/acquia_lift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/acquia_lift/downloads","issues_url":"https://api.github.com/repos/acquia/acquia_lift/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/acquia_lift/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/acquia_lift/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/acquia_lift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/acquia_lift/labels{/name}","releases_url":"https://api.github.com/repos/acquia/acquia_lift/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/acquia_lift/deployments","created_at":"2014-03-02T18:42:14Z","updated_at":"2014-08-25T15:09:47Z","pushed_at":"2016-07-06T03:34:45Z","git_url":"git://github.com/acquia/acquia_lift.git","ssh_url":"git@github.com:acquia/acquia_lift.git","clone_url":"https://github.com/acquia/acquia_lift.git","svn_url":"https://github.com/acquia/acquia_lift","homepage":"","size":7814,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"acquia:8.x-3.x","ref":"8.x-3.x","sha":"7491b9f55786f0f4bf85049d01b435a4b35cf5e6","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":17344049,"name":"acquia_lift","full_name":"acquia/acquia_lift","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/acquia_lift","description":"Mirror of the drupal.org repository for Acquia Lift module","fork":false,"url":"https://api.github.com/repos/acquia/acquia_lift","forks_url":"https://api.github.com/repos/acquia/acquia_lift/forks","keys_url":"https://api.github.com/repos/acquia/acquia_lift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/acquia_lift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/acquia_lift/teams","hooks_url":"https://api.github.com/repos/acquia/acquia_lift/hooks","issue_events_url":"https://api.github.com/repos/acquia/acquia_lift/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/acquia_lift/events","assignees_url":"https://api.github.com/repos/acquia/acquia_lift/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/acquia_lift/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/acquia_lift/tags","blobs_url":"https://api.github.com/repos/acquia/acquia_lift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/acquia_lift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/acquia_lift/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/acquia_lift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/acquia_lift/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/acquia_lift/languages","stargazers_url":"https://api.github.com/repos/acquia/acquia_lift/stargazers","contributors_url":"https://api.github.com/repos/acquia/acquia_lift/contributors","subscribers_url":"https://api.github.com/repos/acquia/acquia_lift/subscribers","subscription_url":"https://api.github.com/repos/acquia/acquia_lift/subscription","commits_url":"https://api.github.com/repos/acquia/acquia_lift/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/acquia_lift/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/acquia_lift/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/acquia_lift/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/acquia_lift/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/acquia_lift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/acquia_lift/merges","archive_url":"https://api.github.com/repos/acquia/acquia_lift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/acquia_lift/downloads","issues_url":"https://api.github.com/repos/acquia/acquia_lift/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/acquia_lift/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/acquia_lift/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/acquia_lift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/acquia_lift/labels{/name}","releases_url":"https://api.github.com/repos/acquia/acquia_lift/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/acquia_lift/deployments","created_at":"2014-03-02T18:42:14Z","updated_at":"2014-08-25T15:09:47Z","pushed_at":"2016-07-06T03:34:45Z","git_url":"git://github.com/acquia/acquia_lift.git","ssh_url":"git@github.com:acquia/acquia_lift.git","clone_url":"https://github.com/acquia/acquia_lift.git","svn_url":"https://github.com/acquia/acquia_lift","homepage":"","size":7814,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/232"},"html":{"href":"https://github.com/acquia/acquia_lift/pull/232"},"issue":{"href":"https://api.github.com/repos/acquia/acquia_lift/issues/232"},"comments":{"href":"https://api.github.com/repos/acquia/acquia_lift/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/acquia_lift/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/acquia_lift/statuses/f807ced5826894bd3220cbe7c2ff001d44886bc0"}}}}
{"actor":{"display_login":"ynx"}}