{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/457","repository_url":"https://api.github.com/repos/KhronosGroup/glslang","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/457/comments","events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/457/events","html_url":"https://github.com/KhronosGroup/glslang/issues/457","id":170890394,"number":457,"title":"SPV Remapper: requires automated tests","user":{"login":"steve-lunarg","id":19352957,"avatar_url":"https://avatars.githubusercontent.com/u/19352957?v=3","gravatar_id":"","url":"https://api.github.com/users/steve-lunarg","html_url":"https://github.com/steve-lunarg","followers_url":"https://api.github.com/users/steve-lunarg/followers","following_url":"https://api.github.com/users/steve-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/steve-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/steve-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steve-lunarg/subscriptions","organizations_url":"https://api.github.com/users/steve-lunarg/orgs","repos_url":"https://api.github.com/users/steve-lunarg/repos","events_url":"https://api.github.com/users/steve-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/steve-lunarg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/KhronosGroup/glslang/labels/Infrastructure","name":"Infrastructure","color":"006b75"},{"url":"https://api.github.com/repos/KhronosGroup/glslang/labels/SPIR-V","name":"SPIR-V","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-12T14:57:54Z","updated_at":"2016-08-15T23:29:25Z","closed_at":null,"body":"\r\nTo log the issue: the SPV remapper's testing has been non-public. It needs tests that are part of whichever project it lives in, both for basic correctness, and efficacy of compression improvement across a collection of shaders with partial commonality and different ID mappings.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments/239959649","html_url":"https://github.com/KhronosGroup/glslang/issues/457#issuecomment-239959649","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/457","id":239959649,"user":{"login":"steve-lunarg","id":19352957,"avatar_url":"https://avatars.githubusercontent.com/u/19352957?v=3","gravatar_id":"","url":"https://api.github.com/users/steve-lunarg","html_url":"https://github.com/steve-lunarg","followers_url":"https://api.github.com/users/steve-lunarg/followers","following_url":"https://api.github.com/users/steve-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/steve-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/steve-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steve-lunarg/subscriptions","organizations_url":"https://api.github.com/users/steve-lunarg/orgs","repos_url":"https://api.github.com/users/steve-lunarg/repos","events_url":"https://api.github.com/users/steve-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/steve-lunarg/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T23:29:24Z","updated_at":"2016-08-15T23:29:24Z","body":"I've been thinking more about the disassembler and validator.  I can start with SPIR-V generated from canned GLSL shaders for instance, remap them, and compare the spirv-dis --raw-id --no-color post-remap version to a golden one.\r\n\r\nIn the past the idea of ID mapping invariant comparison has come up, though it's probably somewhat more involved to create that.  Anyway, I'm feeling like the remapper needs some TLC, and I plan to spend time on it soon.  Also, I have a fix coming for the defect @dneto0 found in my other fix."}}
{"actor":{"display_login":"steve-lunarg"}}