{"action":"closed","number":956,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/956","id":82840886,"html_url":"https://github.com/Microsoft/msbuild/pull/956","diff_url":"https://github.com/Microsoft/msbuild/pull/956.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/956.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/956","number":956,"state":"closed","locked":false,"title":"Remove unnecessary if statements","user":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"body":"Similar to #950.\r\n\r\nAll these `if`-checks have nearly identical checks just before, making these unnecessary as the result won't be different.","created_at":"2016-08-26T07:02:44Z","updated_at":"2016-08-29T15:34:37Z","closed_at":"2016-08-29T15:34:37Z","merged_at":"2016-08-29T15:34:37Z","merge_commit_sha":"84717187fdeac5693747d78b845e314b5034f4ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/956/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/956/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/956/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/7b9c61ff0456f317f07470f1d124735a4f736508","head":{"label":"BBosman:if2","ref":"if2","sha":"7b9c61ff0456f317f07470f1d124735a4f736508","user":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"repo":{"id":66562055,"name":"msbuild","full_name":"BBosman/msbuild","owner":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BBosman/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/BBosman/msbuild","forks_url":"https://api.github.com/repos/BBosman/msbuild/forks","keys_url":"https://api.github.com/repos/BBosman/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBosman/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBosman/msbuild/teams","hooks_url":"https://api.github.com/repos/BBosman/msbuild/hooks","issue_events_url":"https://api.github.com/repos/BBosman/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/BBosman/msbuild/events","assignees_url":"https://api.github.com/repos/BBosman/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/BBosman/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/BBosman/msbuild/tags","blobs_url":"https://api.github.com/repos/BBosman/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBosman/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBosman/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBosman/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBosman/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/BBosman/msbuild/languages","stargazers_url":"https://api.github.com/repos/BBosman/msbuild/stargazers","contributors_url":"https://api.github.com/repos/BBosman/msbuild/contributors","subscribers_url":"https://api.github.com/repos/BBosman/msbuild/subscribers","subscription_url":"https://api.github.com/repos/BBosman/msbuild/subscription","commits_url":"https://api.github.com/repos/BBosman/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBosman/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBosman/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBosman/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBosman/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/BBosman/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBosman/msbuild/merges","archive_url":"https://api.github.com/repos/BBosman/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBosman/msbuild/downloads","issues_url":"https://api.github.com/repos/BBosman/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/BBosman/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/BBosman/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/BBosman/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBosman/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/BBosman/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/BBosman/msbuild/deployments","created_at":"2016-08-25T13:52:50Z","updated_at":"2016-08-25T13:52:56Z","pushed_at":"2016-08-27T07:40:31Z","git_url":"git://github.com/BBosman/msbuild.git","ssh_url":"git@github.com:BBosman/msbuild.git","clone_url":"https://github.com/BBosman/msbuild.git","svn_url":"https://github.com/BBosman/msbuild","homepage":null,"size":12636,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"dfb4e1ef057d521f9a7202490549288cb4ad52ab","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2016-08-29T14:47:02Z","pushed_at":"2016-08-29T15:34:37Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":15514,"stargazers_count":2700,"watchers_count":2700,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"open_issues_count":291,"forks":537,"open_issues":291,"watchers":2700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/956"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/956"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/956"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/956/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/956/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/956/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/7b9c61ff0456f317f07470f1d124735a4f736508"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":1,"additions":6,"deletions":13,"changed_files":4}}
{"actor":{"display_login":"rainersigwald"}}