{"action":"created","comment":{"url":"https://api.github.com/repos/dashpay/dash/pulls/comments/80628090","pull_request_review_id":1672612,"id":80628090,"diff_hunk":"@@ -165,6 +167,13 @@ bool parseBitcoinURI(const QUrl &uri, SendCoinsRecipient *out)\n             rv.label = i->second;\n             fShouldReturnFalse = false;\n         }\n+        if (i->first == \"IS\")\n+        {\n+            if(i->second.compare(QString(\"1\")) == 0)\n+                rv.fUseInstantSend = true;","path":"src/qt/guiutil.cpp","position":16,"original_position":16,"commit_id":"373ebcbb569b96ed0196ff78470866c1edaabaea","original_commit_id":"373ebcbb569b96ed0196ff78470866c1edaabaea","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"body":"Wouldn't simple `rv.fUseInstantSend = i->second == \"1\";` be enough here?","created_at":"2016-09-27T06:40:03Z","updated_at":"2016-09-27T06:41:57Z","html_url":"https://github.com/dashpay/dash/pull/1042#discussion_r80628090","pull_request_url":"https://api.github.com/repos/dashpay/dash/pulls/1042","_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments/80628090"},"html":{"href":"https://github.com/dashpay/dash/pull/1042#discussion_r80628090"},"pull_request":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1042"}}},"pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/1042","id":86788745,"html_url":"https://github.com/dashpay/dash/pull/1042","diff_url":"https://github.com/dashpay/dash/pull/1042.diff","patch_url":"https://github.com/dashpay/dash/pull/1042.patch","issue_url":"https://api.github.com/repos/dashpay/dash/issues/1042","number":1042,"state":"open","locked":false,"title":"[UI] Add Instantsend parameter to QR-code","user":{"login":"crowning-","id":10080039,"avatar_url":"https://avatars.githubusercontent.com/u/10080039?v=3","gravatar_id":"","url":"https://api.github.com/users/crowning-","html_url":"https://github.com/crowning-","followers_url":"https://api.github.com/users/crowning-/followers","following_url":"https://api.github.com/users/crowning-/following{/other_user}","gists_url":"https://api.github.com/users/crowning-/gists{/gist_id}","starred_url":"https://api.github.com/users/crowning-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowning-/subscriptions","organizations_url":"https://api.github.com/users/crowning-/orgs","repos_url":"https://api.github.com/users/crowning-/repos","events_url":"https://api.github.com/users/crowning-/events{/privacy}","received_events_url":"https://api.github.com/users/crowning-/received_events","type":"User","site_admin":false},"body":"solarminer and afreer asked for an Instantsend tag when the QR-code for a payment request is generated so that clients reading the code are able to automatically switch to Instantsend when requested.\r\n\r\nWe came to the following consensus:\r\n\r\n1. to keep the resulting URI short the tag is `IS=1` when Instantsend is requested. When not the tag is omitted.\r\n2. whether `IS=1` is added to the QR-code or not depends on the Instantsend settings of the payment requester (the checkbox on the Send page).\r\n3. I've appended it so clients which might assume some order of the existing tags won't break.\r\n\r\nLooks like this:\r\n![qr_is](https://cloud.githubusercontent.com/assets/10080039/18845685/f1a6365c-8422-11e6-80f8-46ffc32242f0.jpg)\r\n\r\n\r\nTests with _real_ mobile clients highly appreciated.","created_at":"2016-09-26T17:56:01Z","updated_at":"2016-09-27T06:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42e6f57545d2ac4f2ca114bfb6b77fe0fe685111","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashpay/dash/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/dashpay/dash/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/1042/comments","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/373ebcbb569b96ed0196ff78470866c1edaabaea","head":{"label":"crowning-:IS_QR_Code","ref":"IS_QR_Code","sha":"373ebcbb569b96ed0196ff78470866c1edaabaea","user":{"login":"crowning-","id":10080039,"avatar_url":"https://avatars.githubusercontent.com/u/10080039?v=3","gravatar_id":"","url":"https://api.github.com/users/crowning-","html_url":"https://github.com/crowning-","followers_url":"https://api.github.com/users/crowning-/followers","following_url":"https://api.github.com/users/crowning-/following{/other_user}","gists_url":"https://api.github.com/users/crowning-/gists{/gist_id}","starred_url":"https://api.github.com/users/crowning-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowning-/subscriptions","organizations_url":"https://api.github.com/users/crowning-/orgs","repos_url":"https://api.github.com/users/crowning-/repos","events_url":"https://api.github.com/users/crowning-/events{/privacy}","received_events_url":"https://api.github.com/users/crowning-/received_events","type":"User","site_admin":false},"repo":{"id":32418448,"name":"dash","full_name":"crowning-/dash","owner":{"login":"crowning-","id":10080039,"avatar_url":"https://avatars.githubusercontent.com/u/10080039?v=3","gravatar_id":"","url":"https://api.github.com/users/crowning-","html_url":"https://github.com/crowning-","followers_url":"https://api.github.com/users/crowning-/followers","following_url":"https://api.github.com/users/crowning-/following{/other_user}","gists_url":"https://api.github.com/users/crowning-/gists{/gist_id}","starred_url":"https://api.github.com/users/crowning-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowning-/subscriptions","organizations_url":"https://api.github.com/users/crowning-/orgs","repos_url":"https://api.github.com/users/crowning-/repos","events_url":"https://api.github.com/users/crowning-/events{/privacy}","received_events_url":"https://api.github.com/users/crowning-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crowning-/dash","description":"Dash Source Tree","fork":true,"url":"https://api.github.com/repos/crowning-/dash","forks_url":"https://api.github.com/repos/crowning-/dash/forks","keys_url":"https://api.github.com/repos/crowning-/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowning-/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowning-/dash/teams","hooks_url":"https://api.github.com/repos/crowning-/dash/hooks","issue_events_url":"https://api.github.com/repos/crowning-/dash/issues/events{/number}","events_url":"https://api.github.com/repos/crowning-/dash/events","assignees_url":"https://api.github.com/repos/crowning-/dash/assignees{/user}","branches_url":"https://api.github.com/repos/crowning-/dash/branches{/branch}","tags_url":"https://api.github.com/repos/crowning-/dash/tags","blobs_url":"https://api.github.com/repos/crowning-/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowning-/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowning-/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowning-/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowning-/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/crowning-/dash/languages","stargazers_url":"https://api.github.com/repos/crowning-/dash/stargazers","contributors_url":"https://api.github.com/repos/crowning-/dash/contributors","subscribers_url":"https://api.github.com/repos/crowning-/dash/subscribers","subscription_url":"https://api.github.com/repos/crowning-/dash/subscription","commits_url":"https://api.github.com/repos/crowning-/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowning-/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowning-/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowning-/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowning-/dash/contents/{+path}","compare_url":"https://api.github.com/repos/crowning-/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowning-/dash/merges","archive_url":"https://api.github.com/repos/crowning-/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowning-/dash/downloads","issues_url":"https://api.github.com/repos/crowning-/dash/issues{/number}","pulls_url":"https://api.github.com/repos/crowning-/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/crowning-/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/crowning-/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowning-/dash/labels{/name}","releases_url":"https://api.github.com/repos/crowning-/dash/releases{/id}","deployments_url":"https://api.github.com/repos/crowning-/dash/deployments","created_at":"2015-03-17T20:28:30Z","updated_at":"2016-01-11T20:42:32Z","pushed_at":"2016-09-27T06:08:49Z","git_url":"git://github.com/crowning-/dash.git","ssh_url":"git@github.com:crowning-/dash.git","clone_url":"https://github.com/crowning-/dash.git","svn_url":"https://github.com/crowning-/dash","homepage":"http://www.dashpay.io","size":102646,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dashpay:v0.12.1.x","ref":"v0.12.1.x","sha":"b9bd11610daa590b93a7ecc6d5308ec39bb6ba7c","user":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":19352450,"name":"dash","full_name":"dashpay/dash","owner":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashpay/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/dashpay/dash","forks_url":"https://api.github.com/repos/dashpay/dash/forks","keys_url":"https://api.github.com/repos/dashpay/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dash/teams","hooks_url":"https://api.github.com/repos/dashpay/dash/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dash/events","assignees_url":"https://api.github.com/repos/dashpay/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dash/tags","blobs_url":"https://api.github.com/repos/dashpay/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dash/languages","stargazers_url":"https://api.github.com/repos/dashpay/dash/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dash/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dash/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dash/subscription","commits_url":"https://api.github.com/repos/dashpay/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dash/merges","archive_url":"https://api.github.com/repos/dashpay/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dash/downloads","issues_url":"https://api.github.com/repos/dashpay/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dash/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dash/deployments","created_at":"2014-05-01T17:45:34Z","updated_at":"2016-09-19T09:44:46Z","pushed_at":"2016-09-27T06:08:49Z","git_url":"git://github.com/dashpay/dash.git","ssh_url":"git@github.com:dashpay/dash.git","clone_url":"https://github.com/dashpay/dash.git","svn_url":"https://github.com/dashpay/dash","homepage":"https://www.dash.org","size":117458,"stargazers_count":319,"watchers_count":319,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":40,"forks":175,"open_issues":40,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1042"},"html":{"href":"https://github.com/dashpay/dash/pull/1042"},"issue":{"href":"https://api.github.com/repos/dashpay/dash/issues/1042"},"comments":{"href":"https://api.github.com/repos/dashpay/dash/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/dashpay/dash/statuses/373ebcbb569b96ed0196ff78470866c1edaabaea"}}}}
{"actor":{"display_login":"UdjinM6"}}