{"action":"created","comment":{"url":"https://api.github.com/repos/plone/plone.dexterity/pulls/comments/49996700","id":49996700,"diff_hunk":"@@ -233,7 +234,7 @@ def __getattr__(self, name):\n         \"\"\"Fall back on parent for certain things, even if we're aq_base'd.\n         This makes propertysheet access work.\n         \"\"\"\n-        if hasattr(self.__parent__.aq_base, name):\n+        if hasattr(aq_base(self.__parent__), name):","path":"plone/dexterity/filerepresentation.py","position":31,"original_position":31,"commit_id":"5c46f6a1697607031e6862614e04d97e02bcb55a","original_commit_id":"5c46f6a1697607031e6862614e04d97e02bcb55a","user":{"login":"gforcada","id":1155680,"avatar_url":"https://avatars.githubusercontent.com/u/1155680?v=3","gravatar_id":"","url":"https://api.github.com/users/gforcada","html_url":"https://github.com/gforcada","followers_url":"https://api.github.com/users/gforcada/followers","following_url":"https://api.github.com/users/gforcada/following{/other_user}","gists_url":"https://api.github.com/users/gforcada/gists{/gist_id}","starred_url":"https://api.github.com/users/gforcada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforcada/subscriptions","organizations_url":"https://api.github.com/users/gforcada/orgs","repos_url":"https://api.github.com/users/gforcada/repos","events_url":"https://api.github.com/users/gforcada/events{/privacy}","received_events_url":"https://api.github.com/users/gforcada/received_events","type":"User","site_admin":false},"body":"@jensens any specific reason to leave the hasattr instead of changing it to a getattr?","created_at":"2016-01-18T13:11:42Z","updated_at":"2016-01-18T13:11:42Z","html_url":"https://github.com/plone/plone.dexterity/pull/46#discussion_r49996700","pull_request_url":"https://api.github.com/repos/plone/plone.dexterity/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/comments/49996700"},"html":{"href":"https://github.com/plone/plone.dexterity/pull/46#discussion_r49996700"},"pull_request":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/plone/plone.dexterity/pulls/46","id":56317777,"html_url":"https://github.com/plone/plone.dexterity/pull/46","diff_url":"https://github.com/plone/plone.dexterity/pull/46.diff","patch_url":"https://github.com/plone/plone.dexterity/pull/46.patch","issue_url":"https://api.github.com/repos/plone/plone.dexterity/issues/46","number":46,"state":"closed","locked":false,"title":"fix: duplicate aq_base w/o using Aqcuistion API resulted in an AttributeError…","user":{"login":"jensens","id":157140,"avatar_url":"https://avatars.githubusercontent.com/u/157140?v=3","gravatar_id":"","url":"https://api.github.com/users/jensens","html_url":"https://github.com/jensens","followers_url":"https://api.github.com/users/jensens/followers","following_url":"https://api.github.com/users/jensens/following{/other_user}","gists_url":"https://api.github.com/users/jensens/gists{/gist_id}","starred_url":"https://api.github.com/users/jensens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensens/subscriptions","organizations_url":"https://api.github.com/users/jensens/orgs","repos_url":"https://api.github.com/users/jensens/repos","events_url":"https://api.github.com/users/jensens/events{/privacy}","received_events_url":"https://api.github.com/users/jensens/received_events","type":"User","site_admin":false},"body":"… that was masqued in the calling hasattr and resulted in wrong conclusion.\r\n\r\nThis fixes problems arising in plone/buildout.coredev#158","created_at":"2016-01-18T09:24:05Z","updated_at":"2016-01-18T13:11:42Z","closed_at":"2016-01-18T10:42:18Z","merged_at":"2016-01-18T10:42:18Z","merge_commit_sha":"bb807fc3619fae02c5c9724fd5fed0c93aca7e31","assignee":null,"milestone":{"url":"https://api.github.com/repos/plone/plone.dexterity/milestones/3","html_url":"https://github.com/plone/plone.dexterity/milestones/Plone%205.0.x","labels_url":"https://api.github.com/repos/plone/plone.dexterity/milestones/3/labels","id":1360417,"number":3,"title":"Plone 5.0.x","description":null,"creator":{"login":"jensens","id":157140,"avatar_url":"https://avatars.githubusercontent.com/u/157140?v=3","gravatar_id":"","url":"https://api.github.com/users/jensens","html_url":"https://github.com/jensens","followers_url":"https://api.github.com/users/jensens/followers","following_url":"https://api.github.com/users/jensens/following{/other_user}","gists_url":"https://api.github.com/users/jensens/gists{/gist_id}","starred_url":"https://api.github.com/users/jensens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensens/subscriptions","organizations_url":"https://api.github.com/users/jensens/orgs","repos_url":"https://api.github.com/users/jensens/repos","events_url":"https://api.github.com/users/jensens/events{/privacy}","received_events_url":"https://api.github.com/users/jensens/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2015-10-16T23:27:30Z","updated_at":"2016-01-18T10:42:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/plone/plone.dexterity/pulls/46/commits","review_comments_url":"https://api.github.com/repos/plone/plone.dexterity/pulls/46/comments","review_comment_url":"https://api.github.com/repos/plone/plone.dexterity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/plone.dexterity/issues/46/comments","statuses_url":"https://api.github.com/repos/plone/plone.dexterity/statuses/5c46f6a1697607031e6862614e04d97e02bcb55a","head":{"label":"plone:jensens-fix-aq","ref":"jensens-fix-aq","sha":"5c46f6a1697607031e6862614e04d97e02bcb55a","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2419254,"name":"plone.dexterity","full_name":"plone/plone.dexterity","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.dexterity","description":"Base framework for building content types, both through-the-web and as filesystem code for Zope (CMF/Plone)","fork":false,"url":"https://api.github.com/repos/plone/plone.dexterity","forks_url":"https://api.github.com/repos/plone/plone.dexterity/forks","keys_url":"https://api.github.com/repos/plone/plone.dexterity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.dexterity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.dexterity/teams","hooks_url":"https://api.github.com/repos/plone/plone.dexterity/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.dexterity/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.dexterity/events","assignees_url":"https://api.github.com/repos/plone/plone.dexterity/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.dexterity/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.dexterity/tags","blobs_url":"https://api.github.com/repos/plone/plone.dexterity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.dexterity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.dexterity/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.dexterity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.dexterity/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.dexterity/languages","stargazers_url":"https://api.github.com/repos/plone/plone.dexterity/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.dexterity/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.dexterity/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.dexterity/subscription","commits_url":"https://api.github.com/repos/plone/plone.dexterity/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.dexterity/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.dexterity/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.dexterity/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.dexterity/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.dexterity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.dexterity/merges","archive_url":"https://api.github.com/repos/plone/plone.dexterity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.dexterity/downloads","issues_url":"https://api.github.com/repos/plone/plone.dexterity/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.dexterity/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.dexterity/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.dexterity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.dexterity/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.dexterity/releases{/id}","created_at":"2011-09-20T00:04:05Z","updated_at":"2015-06-26T08:09:27Z","pushed_at":"2016-01-18T13:09:58Z","git_url":"git://github.com/plone/plone.dexterity.git","ssh_url":"git@github.com:plone/plone.dexterity.git","clone_url":"https://github.com/plone/plone.dexterity.git","svn_url":"https://github.com/plone/plone.dexterity","homepage":"https://pypi.python.org/pypi/plone.dexterity","size":1246,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":17,"default_branch":"master"}},"base":{"label":"plone:master","ref":"master","sha":"51018308ce6df95a415e4f412d836dde076ed131","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2419254,"name":"plone.dexterity","full_name":"plone/plone.dexterity","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.dexterity","description":"Base framework for building content types, both through-the-web and as filesystem code for Zope (CMF/Plone)","fork":false,"url":"https://api.github.com/repos/plone/plone.dexterity","forks_url":"https://api.github.com/repos/plone/plone.dexterity/forks","keys_url":"https://api.github.com/repos/plone/plone.dexterity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.dexterity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.dexterity/teams","hooks_url":"https://api.github.com/repos/plone/plone.dexterity/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.dexterity/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.dexterity/events","assignees_url":"https://api.github.com/repos/plone/plone.dexterity/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.dexterity/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.dexterity/tags","blobs_url":"https://api.github.com/repos/plone/plone.dexterity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.dexterity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.dexterity/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.dexterity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.dexterity/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.dexterity/languages","stargazers_url":"https://api.github.com/repos/plone/plone.dexterity/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.dexterity/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.dexterity/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.dexterity/subscription","commits_url":"https://api.github.com/repos/plone/plone.dexterity/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.dexterity/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.dexterity/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.dexterity/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.dexterity/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.dexterity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.dexterity/merges","archive_url":"https://api.github.com/repos/plone/plone.dexterity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.dexterity/downloads","issues_url":"https://api.github.com/repos/plone/plone.dexterity/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.dexterity/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.dexterity/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.dexterity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.dexterity/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.dexterity/releases{/id}","created_at":"2011-09-20T00:04:05Z","updated_at":"2015-06-26T08:09:27Z","pushed_at":"2016-01-18T13:09:58Z","git_url":"git://github.com/plone/plone.dexterity.git","ssh_url":"git@github.com:plone/plone.dexterity.git","clone_url":"https://github.com/plone/plone.dexterity.git","svn_url":"https://github.com/plone/plone.dexterity","homepage":"https://pypi.python.org/pypi/plone.dexterity","size":1246,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/46"},"html":{"href":"https://github.com/plone/plone.dexterity/pull/46"},"issue":{"href":"https://api.github.com/repos/plone/plone.dexterity/issues/46"},"comments":{"href":"https://api.github.com/repos/plone/plone.dexterity/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/plone.dexterity/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/plone/plone.dexterity/statuses/5c46f6a1697607031e6862614e04d97e02bcb55a"}}}}