{"push_id":1111949107,"size":1,"distinct_size":1,"ref":"refs/heads/branch-2.5","head":"99f5a62fb9ce0509ea7cff0b945a71f9978eade5","before":"4a0643d807dcf6aba889ccf49eaadfecaae9590f","commits":[{"sha":"99f5a62fb9ce0509ea7cff0b945a71f9978eade5","author":{"email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org","name":"Ben Pfaff"},"message":"ofproto-dpif-xlate: Always generate wildcards.\n\nUntil now, the flow translation code has tried to avoid constructing a\nset of wildcards during translation in the cases where it can, because\nwildcards are large and somewhat expensive.  However, this has problems\nthat we hadn't previously realized.  Specifically, the generated actions\ncan depend on the constructed wildcards, to decide which bits of a field\nneed to be set in a masked set_field action.  This means that in practice\ntranslation needs to always construct the wildcards.\n\n(It might be possible to avoid masked set_field when we're not constructing\nwildcards, but this would mean that we'd generate different actions\ndepending on whether wildcards were being constructed, which seems rather\nconfusing at best.  Also, the cases in which we don't need wildcards anyway\nare fairly obscure, meaning that the benefits of avoiding them in those\ncases are minimal and that it's going to be hard to get test coverage.  The\nlatter is probably why we didn't notice this until now.)\n\nReported-by: William Tu <u9012063@gmail.com>\nReported-at: http://openvswitch.org/pipermail/dev/2016-April/069219.html\nSigned-off-by: Ben Pfaff <blp@ovn.org>\nAcked-by: Ryan Moats <rmoats@us.ibm.com>\nTested-by: William Tu <u9012063@gmail.com>","distinct":true,"url":"https://api.github.com/repos/openvswitch/ovs/commits/99f5a62fb9ce0509ea7cff0b945a71f9978eade5"}]}