{"action":"created","issue":{"url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/87","repository_url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki","labels_url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/87/comments","events_url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/87/events","html_url":"https://github.com/Neftas/supplementary-buttons-anki/issues/87","id":182840682,"number":87,"title":"Use pygments classes instead of inline css","user":{"login":"badlydrawnrob","id":1176875,"avatar_url":"https://avatars.githubusercontent.com/u/1176875?v=3","gravatar_id":"","url":"https://api.github.com/users/badlydrawnrob","html_url":"https://github.com/badlydrawnrob","followers_url":"https://api.github.com/users/badlydrawnrob/followers","following_url":"https://api.github.com/users/badlydrawnrob/following{/other_user}","gists_url":"https://api.github.com/users/badlydrawnrob/gists{/gist_id}","starred_url":"https://api.github.com/users/badlydrawnrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badlydrawnrob/subscriptions","organizations_url":"https://api.github.com/users/badlydrawnrob/orgs","repos_url":"https://api.github.com/users/badlydrawnrob/repos","events_url":"https://api.github.com/users/badlydrawnrob/events{/privacy}","received_events_url":"https://api.github.com/users/badlydrawnrob/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"Neftas","id":8035319,"avatar_url":"https://avatars.githubusercontent.com/u/8035319?v=3","gravatar_id":"","url":"https://api.github.com/users/Neftas","html_url":"https://github.com/Neftas","followers_url":"https://api.github.com/users/Neftas/followers","following_url":"https://api.github.com/users/Neftas/following{/other_user}","gists_url":"https://api.github.com/users/Neftas/gists{/gist_id}","starred_url":"https://api.github.com/users/Neftas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neftas/subscriptions","organizations_url":"https://api.github.com/users/Neftas/orgs","repos_url":"https://api.github.com/users/Neftas/repos","events_url":"https://api.github.com/users/Neftas/events{/privacy}","received_events_url":"https://api.github.com/users/Neftas/received_events","type":"User","site_admin":false},"assignees":[{"login":"Neftas","id":8035319,"avatar_url":"https://avatars.githubusercontent.com/u/8035319?v=3","gravatar_id":"","url":"https://api.github.com/users/Neftas","html_url":"https://github.com/Neftas","followers_url":"https://api.github.com/users/Neftas/followers","following_url":"https://api.github.com/users/Neftas/following{/other_user}","gists_url":"https://api.github.com/users/Neftas/gists{/gist_id}","starred_url":"https://api.github.com/users/Neftas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neftas/subscriptions","organizations_url":"https://api.github.com/users/Neftas/orgs","repos_url":"https://api.github.com/users/Neftas/repos","events_url":"https://api.github.com/users/Neftas/events{/privacy}","received_events_url":"https://api.github.com/users/Neftas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-13T16:40:59Z","updated_at":"2016-10-13T22:32:02Z","closed_at":null,"body":"So [digging into your code](https://github.com/Neftas/supplementary-buttons-anki/search?utf8=%E2%9C%93&q=noclasses), it seems like you've modified the [Code highlighting](https://github.com/waylan/Python-Markdown/blob/master/markdown/extensions/codehilite.py) plugin to [output inline styles](https://github.com/Neftas/supplementary-buttons-anki/issues/55#issuecomment-253556975), rather than using the [default Pygments css classes](http://pygments.org/docs/quickstart/#example). E.g:\r\n\r\n```\r\n<span style=\"color: #204a87; font-weight: bold\">while</span>\r\n```\r\ninstead of ...\r\n\r\n```\r\n<span class=\"k\">while</span>\r\n```\r\n\r\nPersonally, I think this is bad practice as it makes it difficult (or impossible) to modify the theme manually (or locks us into this plugin).\r\n\r\nI'd like to see an option to use Pygments as it was intended, as unless I'm missing something this isn't possible right now. I'm not a good enough Python developer to modify the plugin to do this myself either!\r\n\r\nIt's a shame, as it's an otherwise great feature."},"comment":{"url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/comments/253657944","html_url":"https://github.com/Neftas/supplementary-buttons-anki/issues/87#issuecomment-253657944","issue_url":"https://api.github.com/repos/Neftas/supplementary-buttons-anki/issues/87","id":253657944,"user":{"login":"badlydrawnrob","id":1176875,"avatar_url":"https://avatars.githubusercontent.com/u/1176875?v=3","gravatar_id":"","url":"https://api.github.com/users/badlydrawnrob","html_url":"https://github.com/badlydrawnrob","followers_url":"https://api.github.com/users/badlydrawnrob/followers","following_url":"https://api.github.com/users/badlydrawnrob/following{/other_user}","gists_url":"https://api.github.com/users/badlydrawnrob/gists{/gist_id}","starred_url":"https://api.github.com/users/badlydrawnrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badlydrawnrob/subscriptions","organizations_url":"https://api.github.com/users/badlydrawnrob/orgs","repos_url":"https://api.github.com/users/badlydrawnrob/repos","events_url":"https://api.github.com/users/badlydrawnrob/events{/privacy}","received_events_url":"https://api.github.com/users/badlydrawnrob/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T22:32:02Z","updated_at":"2016-10-13T22:32:02Z","body":"So to summise, a big **yes!** for `noclasses=True` and `noclasses=False` preferences. Also, just to be pedantic, should there be a `<code>` tag within `<pre>`?"}}
{"actor":{"display_login":"badlydrawnrob"}}