{"action":"created","issue":{"url":"https://api.github.com/repos/neomake/neomake/issues/572","repository_url":"https://api.github.com/repos/neomake/neomake","labels_url":"https://api.github.com/repos/neomake/neomake/issues/572/labels{/name}","comments_url":"https://api.github.com/repos/neomake/neomake/issues/572/comments","events_url":"https://api.github.com/repos/neomake/neomake/issues/572/events","html_url":"https://github.com/neomake/neomake/issues/572","id":174639413,"number":572,"title":"Fix auto-selection of enabled makers for multi-filetype","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-01T22:19:48Z","updated_at":"2016-09-05T10:54:40Z","closed_at":null,"body":"With a filetype like `vader.vim` or `javascript.jsx` the makers that are returned by [neomake#GetEnabledMakers](https://github.com/neomake/neomake/blob/914609831b904f84f296826c2ad8f99d4bc7ce23/autoload/neomake.vim#L295) are only those that are present in all filetypes..\r\n\r\nThis causes issues like #272 and #492.\r\n\r\n(I've just seen that there is a undocumented `SupersetOf` hook in makers, where e.g. `jsx` says \"javascript\" (https://github.com/neomake/neomake/blob/914609831b904f84f296826c2ad8f99d4bc7ce23/autoload/neomake/makers/ft/jsx.vim#L3-L5).\r\nIt seems to only be used for sorting the filetypes though (https://github.com/neomake/neomake/blob/914609831b904f84f296826c2ad8f99d4bc7ce23/autoload/neomake/utils.vim#L163-L175), and I think that is over-engineered: the order should be defined by the user (given the order in the `&ft`) - another issue.)\r\n\r\nI could imagine the following fixes: \r\n1. just use all makers from all mentioned filetypes, and not the union of it.  Where would that fail?\r\n\r\n2. ignore empty lists of (auto-detected only?) makers.  For `vader.vim` that would just use the ones from `vim`.  For `javascript.jsx` it would still use the union - but e.g. in the case of `eslint` that _should_ have worked before already.  Maybe we can make use of the `SupersetOf` here?\r\n\r\nbtw: there is no way to configure enabled makers for `foo.bar` explicitly currently, since you cannot specify `g:neomake_foo.bar_enabled_makers` (because of the dot in there)."},"comment":{"url":"https://api.github.com/repos/neomake/neomake/issues/comments/244719008","html_url":"https://github.com/neomake/neomake/issues/572#issuecomment-244719008","issue_url":"https://api.github.com/repos/neomake/neomake/issues/572","id":244719008,"user":{"login":"jamesoff","id":5112771,"avatar_url":"https://avatars.githubusercontent.com/u/5112771?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesoff","html_url":"https://github.com/jamesoff","followers_url":"https://api.github.com/users/jamesoff/followers","following_url":"https://api.github.com/users/jamesoff/following{/other_user}","gists_url":"https://api.github.com/users/jamesoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesoff/subscriptions","organizations_url":"https://api.github.com/users/jamesoff/orgs","repos_url":"https://api.github.com/users/jamesoff/repos","events_url":"https://api.github.com/users/jamesoff/events{/privacy}","received_events_url":"https://api.github.com/users/jamesoff/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T10:54:40Z","updated_at":"2016-09-05T10:54:40Z","body":"From the brief look I've had at this, removing the filter() call on the list of enabled makers seems to give me the result I need, but I agree that there may be cases where we don't want all of the makers to run - not that I can think of any right now.\r\n\r\nI believe that's how Syntactic does it."}}
{"actor":{"display_login":"jamesoff"}}