{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/13124","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/13124/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/13124/comments","events_url":"https://api.github.com/repos/atom/atom/issues/13124/events","html_url":"https://github.com/atom/atom/pull/13124","id":186593676,"number":13124,"title":"Preserve specificity when transforming atom-text-editor::shadow","user":{"login":"nathansobo","id":1789,"avatar_url":"https://avatars.githubusercontent.com/u/1789?v=3","gravatar_id":"","url":"https://api.github.com/users/nathansobo","html_url":"https://github.com/nathansobo","followers_url":"https://api.github.com/users/nathansobo/followers","following_url":"https://api.github.com/users/nathansobo/following{/other_user}","gists_url":"https://api.github.com/users/nathansobo/gists{/gist_id}","starred_url":"https://api.github.com/users/nathansobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathansobo/subscriptions","organizations_url":"https://api.github.com/users/nathansobo/orgs","repos_url":"https://api.github.com/users/nathansobo/repos","events_url":"https://api.github.com/users/nathansobo/events{/privacy}","received_events_url":"https://api.github.com/users/nathansobo/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-01T17:24:58Z","updated_at":"2016-11-02T05:53:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/13124","html_url":"https://github.com/atom/atom/pull/13124","diff_url":"https://github.com/atom/atom/pull/13124.diff","patch_url":"https://github.com/atom/atom/pull/13124.patch"},"body":"Simply replace ::shadow with .editor to preserve the specificity of the transformed rule. This isn't beautiful, but it's the only way to guarantee that the styling transition is smooth enough to justify not bumping the major.\r\n\r\nIt would be great if some people that had styling regressions due to specificity could give this build a spin and see if things would have been okay if we transformed this way.\r\n\r\n/cc @as-cii @atom/maintainers @abe33 "},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/257779096","html_url":"https://github.com/atom/atom/pull/13124#issuecomment-257779096","issue_url":"https://api.github.com/repos/atom/atom/issues/13124","id":257779096,"user":{"login":"simurai","id":378023,"avatar_url":"https://avatars.githubusercontent.com/u/378023?v=3","gravatar_id":"","url":"https://api.github.com/users/simurai","html_url":"https://github.com/simurai","followers_url":"https://api.github.com/users/simurai/followers","following_url":"https://api.github.com/users/simurai/following{/other_user}","gists_url":"https://api.github.com/users/simurai/gists{/gist_id}","starred_url":"https://api.github.com/users/simurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simurai/subscriptions","organizations_url":"https://api.github.com/users/simurai/orgs","repos_url":"https://api.github.com/users/simurai/repos","events_url":"https://api.github.com/users/simurai/events{/privacy}","received_events_url":"https://api.github.com/users/simurai/received_events","type":"User","site_admin":true},"created_at":"2016-11-02T05:53:42Z","updated_at":"2016-11-02T05:53:42Z","body":"So far I only know that `red-wavy-underline` would've been affected by this issue. I think in the meantime @lee-dohm fixed it already.\r\n\r\nWhen testing with version [0.3.0](https://github.com/lee-dohm/red-wavy-underline/tree/v0.3.0) (that has the `::shadow` selector), it doesn't seem to work initially. Only when making a random change to the [red-wavy-underline.less](https://github.com/lee-dohm/red-wavy-underline/blob/v0.3.0/styles/red-wavy-underline.less) file. I guess the reason is that live-reload runs through the transformation, but not on initial load?"}}
{"actor":{"display_login":"simurai"}}