{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/82838394","pull_request_review_id":3717249,"id":82838394,"diff_hunk":"@@ -970,96 +970,79 @@ static BOOL xf_gdi_surface_update_frame(xfContext* xfc, UINT16 tx, UINT16 ty,\n \treturn ret;\n }\n \n+static BOOL xf_gdi_update_screen(xfContext* xfc,\n+                                 const SURFACE_BITS_COMMAND* cmd,\n+                                 const BYTE* pSrcData)\n+{\n+\tBOOL ret;\n+\tXImage* image;\n+\n+\tif (!xfc || !pSrcData)\n+\t\treturn FALSE;\n+\n+\tXSetFunction(xfc->display, xfc->gc, GXcopy);\n+\tXSetFillStyle(xfc->display, xfc->gc, FillSolid);\n+\timage = XCreateImage(xfc->display, xfc->visual, xfc->depth, ZPixmap, 0,\n+\t                     (char*) pSrcData, cmd->width, cmd->height, xfc->scanline_pad, 0);\n+\tXPutImage(xfc->display, xfc->primary, xfc->gc, image, 0, 0,\n+\t          cmd->destLeft, cmd->destTop, cmd->width, cmd->height);\n+\tXFree(image);\n+\tret = xf_gdi_surface_update_frame(xfc, cmd->destLeft, cmd->destTop, cmd->width,\n+\t                                  cmd->height);\n+\tXSetClipMask(xfc->display, xfc->gc, None);\n+\treturn ret;\n+}\n+\n static BOOL xf_gdi_surface_bits(rdpContext* context,\n                                 const SURFACE_BITS_COMMAND* cmd)\n {\n-\tXImage* image;\n \tBYTE* pSrcData;\n-\tBYTE* pDstData;\n \txfContext* xfc = (xfContext*) context;\n-\tBOOL ret = TRUE;\n+\tBOOL ret = FALSE;\n \trdpGdi* gdi = context->gdi;\n-\tREGION16 invalidRegion;\n \txf_lock_x11(xfc, FALSE);\n \n \tswitch (cmd->codecID)\n \t{\n \t\tcase RDP_CODEC_ID_REMOTEFX:\n \t\t\tif (!rfx_process_message(context->codecs->rfx, cmd->bitmapData,\n-\t\t\t                         PIXEL_FORMAT_XRGB32, cmd->bitmapDataLength,\n+\t\t\t                         PIXEL_FORMAT_BGRX32, cmd->bitmapDataLength,\n \t\t\t                         cmd->destLeft, cmd->destTop,","path":"client/X11/xf_gdi.c","position":null,"original_position":46,"commit_id":"8286fa4b9696ebb097151ca43c4d8bef68aaa283","original_commit_id":"404ae7d83c59de69a6b988e0e9fc561dbda6d6ae","user":{"login":"realjiangms","id":4299660,"avatar_url":"https://avatars.githubusercontent.com/u/4299660?v=3","gravatar_id":"","url":"https://api.github.com/users/realjiangms","html_url":"https://github.com/realjiangms","followers_url":"https://api.github.com/users/realjiangms/followers","following_url":"https://api.github.com/users/realjiangms/following{/other_user}","gists_url":"https://api.github.com/users/realjiangms/gists{/gist_id}","starred_url":"https://api.github.com/users/realjiangms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realjiangms/subscriptions","organizations_url":"https://api.github.com/users/realjiangms/orgs","repos_url":"https://api.github.com/users/realjiangms/repos","events_url":"https://api.github.com/users/realjiangms/events{/privacy}","received_events_url":"https://api.github.com/users/realjiangms/received_events","type":"User","site_admin":false},"body":"This line should be 0,0. \r\nOr the bitmap will actually be pasted at cmd->destLeft*2, cmd->destTop*2","created_at":"2016-10-11T16:53:29Z","updated_at":"2016-10-11T16:53:29Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3545#discussion_r82838394","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/82838394"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3545#discussion_r82838394"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545","id":88824191,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/3545","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/3545.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/3545.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3545","number":3545,"state":"open","locked":false,"title":"Fixed Windows 7 RFX issues.","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"body":"Fixes #3543 \r\n\r\n* Windows 7 RFX decoding in software GDI used wrong offsets and size.\r\n* X11 decoder used uninitialized region, unified screen update.","created_at":"2016-10-11T12:36:04Z","updated_at":"2016-10-11T16:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf09144d1b1ff3be59ce34d111bfbb35645eb9dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3545/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/8286fa4b9696ebb097151ca43c4d8bef68aaa283","head":{"label":"akallabeth:legacy_rfx_fixes","ref":"legacy_rfx_fixes","sha":"8286fa4b9696ebb097151ca43c4d8bef68aaa283","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"repo":{"id":11418147,"name":"FreeRDP","full_name":"akallabeth/FreeRDP","owner":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akallabeth/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/akallabeth/FreeRDP","forks_url":"https://api.github.com/repos/akallabeth/FreeRDP/forks","keys_url":"https://api.github.com/repos/akallabeth/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akallabeth/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akallabeth/FreeRDP/teams","hooks_url":"https://api.github.com/repos/akallabeth/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/akallabeth/FreeRDP/events","assignees_url":"https://api.github.com/repos/akallabeth/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/akallabeth/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/tags","blobs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akallabeth/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/akallabeth/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/akallabeth/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/akallabeth/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscription","commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/akallabeth/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/akallabeth/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/akallabeth/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akallabeth/FreeRDP/merges","archive_url":"https://api.github.com/repos/akallabeth/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akallabeth/FreeRDP/downloads","issues_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/akallabeth/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/akallabeth/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/akallabeth/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akallabeth/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/akallabeth/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/akallabeth/FreeRDP/deployments","created_at":"2013-07-15T08:16:31Z","updated_at":"2015-01-26T06:50:05Z","pushed_at":"2016-10-11T16:50:21Z","git_url":"git://github.com/akallabeth/FreeRDP.git","ssh_url":"git@github.com:akallabeth/FreeRDP.git","clone_url":"https://github.com/akallabeth/FreeRDP.git","svn_url":"https://github.com/akallabeth/FreeRDP","homepage":"http://www.freerdp.com/","size":33349,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"1d03fd32a328c3800a3bfaa4fec2ea1c7c01241d","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/deployments","created_at":"2011-06-30T19:14:15Z","updated_at":"2016-10-11T11:35:16Z","pushed_at":"2016-10-11T16:50:21Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":37578,"stargazers_count":1480,"watchers_count":1480,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":866,"mirror_url":null,"open_issues_count":691,"forks":866,"open_issues":691,"watchers":1480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3545"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3545"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3545/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3545/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/8286fa4b9696ebb097151ca43c4d8bef68aaa283"}}}}
{"actor":{"display_login":"realjiangms"}}