{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments/58679734","id":58679734,"diff_hunk":"@@ -269,14 +269,20 @@\n   if ! ($app_type in ['procfile', 'rack', 'bare']) {\n     fail 'Invalid argument $app_type to govuk::app! Must be one of \"procfile\", \"rack\", or \"bare\"'\n   }\n-  if ($app_type in ['procfile', 'rack']) and ($port == 'NOTSET') {\n+\n+  if ($app_type in ['procfile', 'rack']) and ($port == 0) {","path":"modules/govuk/manifests/app.pp","position":15,"original_position":15,"commit_id":"17d55b2780433cd9c90c8c497e7262984c096652","original_commit_id":"17d55b2780433cd9c90c8c497e7262984c096652","user":{"login":"mattbostock","id":4348848,"avatar_url":"https://avatars.githubusercontent.com/u/4348848?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbostock","html_url":"https://github.com/mattbostock","followers_url":"https://api.github.com/users/mattbostock/followers","following_url":"https://api.github.com/users/mattbostock/following{/other_user}","gists_url":"https://api.github.com/users/mattbostock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbostock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbostock/subscriptions","organizations_url":"https://api.github.com/users/mattbostock/orgs","repos_url":"https://api.github.com/users/mattbostock/repos","events_url":"https://api.github.com/users/mattbostock/events{/privacy}","received_events_url":"https://api.github.com/users/mattbostock/received_events","type":"User","site_admin":false},"body":"Just realised that this conditional is redundant as any ports outside of 1025-65535 will be caught by `validate_integer` below.","created_at":"2016-04-06T09:55:37Z","updated_at":"2016-04-06T09:55:37Z","html_url":"https://github.com/alphagov/govuk-puppet/pull/4127#discussion_r58679734","pull_request_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments/58679734"},"html":{"href":"https://github.com/alphagov/govuk-puppet/pull/4127#discussion_r58679734"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127","id":60186654,"html_url":"https://github.com/alphagov/govuk-puppet/pull/4127","diff_url":"https://github.com/alphagov/govuk-puppet/pull/4127.diff","patch_url":"https://github.com/alphagov/govuk-puppet/pull/4127.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/4127","number":4127,"state":"closed","locked":false,"title":"Make port use an integer value, not implicit string conversion","user":{"login":"deanwilson","id":48871,"avatar_url":"https://avatars.githubusercontent.com/u/48871?v=3","gravatar_id":"","url":"https://api.github.com/users/deanwilson","html_url":"https://github.com/deanwilson","followers_url":"https://api.github.com/users/deanwilson/followers","following_url":"https://api.github.com/users/deanwilson/following{/other_user}","gists_url":"https://api.github.com/users/deanwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/deanwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanwilson/subscriptions","organizations_url":"https://api.github.com/users/deanwilson/orgs","repos_url":"https://api.github.com/users/deanwilson/repos","events_url":"https://api.github.com/users/deanwilson/events{/privacy}","received_events_url":"https://api.github.com/users/deanwilson/received_events","type":"User","site_admin":false},"body":"This is an early step to support future/parser puppet 4. Our rspec\r\ntests currently specify (correctly) that port is an int. Our manifest\r\nshould reflect that choice of type.\r\n\r\nWe also shouldn't be running our apps on priviledged ports so we set\r\nthe lowest allowed port to be 1025.\r\n\r\nThis will require apps using strings to be converted over to ints\r\nwhen we start to run puppet 4. Those will be done in a seperate PR.","created_at":"2016-02-22T15:07:49Z","updated_at":"2016-04-06T09:55:37Z","closed_at":"2016-04-06T09:21:56Z","merged_at":"2016-04-06T09:21:56Z","merge_commit_sha":"a6b9a434eace6d1c3493267e2c79f9192f5db9ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/4127/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/17d55b2780433cd9c90c8c497e7262984c096652","head":{"label":"alphagov:app_port_integer","ref":"app_port_integer","sha":"17d55b2780433cd9c90c8c497e7262984c096652","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2016-03-26T11:38:45Z","pushed_at":"2016-04-06T09:45:52Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk","size":21836,"stargazers_count":29,"watchers_count":29,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":29,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"48e360080fbe463e7e601977637bd28b0149e99c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2016-03-26T11:38:45Z","pushed_at":"2016-04-06T09:45:52Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk","size":21836,"stargazers_count":29,"watchers_count":29,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127"},"html":{"href":"https://github.com/alphagov/govuk-puppet/pull/4127"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/4127"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/4127/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/4127/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/17d55b2780433cd9c90c8c497e7262984c096652"}}}}