{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/57837189","id":57837189,"diff_hunk":"@@ -3317,6 +3342,17 @@ const char *npc_parse_duplicate(const char *w1, const char *w2, const char *w3,\n \t\t\tif (retval) *retval = EXIT_FAILURE;\n \t\t\treturn end;// next line, try to continue\n \t\t}\n+\n+\t\t// Using 'npc->viewisid' to checks if given 'dir_name' is an interger or constant. [Cretino]\n+\t\tif (!npc->viewisid(dir_name)) {\n+\t\t\tif (!script->get_constant(dir_name, &dir)) {\n+\t\t\t\tShowError(\"npc_parse_duplicate: Invalid facing constant '%s' in file '%s', line '%d'.\\n\", dir_name, filepath, strline(buffer,start-buffer));\n+\t\t\t\tif (retval) *retval = EXIT_FAILURE;","path":"src/map/npc.c","position":104,"original_position":104,"commit_id":"62b17812729cfc240c6a010fbcc83171ac2015aa","original_commit_id":"62b17812729cfc240c6a010fbcc83171ac2015aa","user":{"login":"dastgir","id":2889931,"avatar_url":"https://avatars.githubusercontent.com/u/2889931?v=3","gravatar_id":"","url":"https://api.github.com/users/dastgir","html_url":"https://github.com/dastgir","followers_url":"https://api.github.com/users/dastgir/followers","following_url":"https://api.github.com/users/dastgir/following{/other_user}","gists_url":"https://api.github.com/users/dastgir/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgir/subscriptions","organizations_url":"https://api.github.com/users/dastgir/orgs","repos_url":"https://api.github.com/users/dastgir/repos","events_url":"https://api.github.com/users/dastgir/events{/privacy}","received_events_url":"https://api.github.com/users/dastgir/received_events","type":"User","site_admin":false},"body":"try to split in different lines\r\n```c\r\nif (retval)\r\n    *retval = EXIT_FAILURE;\r\n```\r\n\r\n","created_at":"2016-03-30T05:00:16Z","updated_at":"2016-03-30T05:00:16Z","html_url":"https://github.com/HerculesWS/Hercules/pull/1228#discussion_r57837189","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/57837189"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1228#discussion_r57837189"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228","id":64413239,"html_url":"https://github.com/HerculesWS/Hercules/pull/1228","diff_url":"https://github.com/HerculesWS/Hercules/pull/1228.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1228.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1228","number":1228,"state":"open","locked":false,"title":"Update parse of NPCs, now we can use 'directions constants'.","user":{"login":"Cretino","id":1497605,"avatar_url":"https://avatars.githubusercontent.com/u/1497605?v=3","gravatar_id":"","url":"https://api.github.com/users/Cretino","html_url":"https://github.com/Cretino","followers_url":"https://api.github.com/users/Cretino/followers","following_url":"https://api.github.com/users/Cretino/following{/other_user}","gists_url":"https://api.github.com/users/Cretino/gists{/gist_id}","starred_url":"https://api.github.com/users/Cretino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cretino/subscriptions","organizations_url":"https://api.github.com/users/Cretino/orgs","repos_url":"https://api.github.com/users/Cretino/repos","events_url":"https://api.github.com/users/Cretino/events{/privacy}","received_events_url":"https://api.github.com/users/Cretino/received_events","type":"User","site_admin":false},"body":"eg:\r\nprontera,155,168,DIR_WEST\tscript\tTesting#1\t4W_F_KAFRA2,{}\r\n\r\nOld way still working. :)\r\n\r\nSigned-off-by: Cretino <yuri-lolz@hotmail.com>","created_at":"2016-03-29T04:48:20Z","updated_at":"2016-03-30T05:00:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"862260abc921be2418d6164b42d803c0b628e90d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1228/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/62b17812729cfc240c6a010fbcc83171ac2015aa","head":{"label":"Cretino:npc_direction","ref":"npc_direction","sha":"62b17812729cfc240c6a010fbcc83171ac2015aa","user":{"login":"Cretino","id":1497605,"avatar_url":"https://avatars.githubusercontent.com/u/1497605?v=3","gravatar_id":"","url":"https://api.github.com/users/Cretino","html_url":"https://github.com/Cretino","followers_url":"https://api.github.com/users/Cretino/followers","following_url":"https://api.github.com/users/Cretino/following{/other_user}","gists_url":"https://api.github.com/users/Cretino/gists{/gist_id}","starred_url":"https://api.github.com/users/Cretino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cretino/subscriptions","organizations_url":"https://api.github.com/users/Cretino/orgs","repos_url":"https://api.github.com/users/Cretino/repos","events_url":"https://api.github.com/users/Cretino/events{/privacy}","received_events_url":"https://api.github.com/users/Cretino/received_events","type":"User","site_admin":false},"repo":{"id":54930749,"name":"Hercules","full_name":"Cretino/Hercules","owner":{"login":"Cretino","id":1497605,"avatar_url":"https://avatars.githubusercontent.com/u/1497605?v=3","gravatar_id":"","url":"https://api.github.com/users/Cretino","html_url":"https://github.com/Cretino","followers_url":"https://api.github.com/users/Cretino/followers","following_url":"https://api.github.com/users/Cretino/following{/other_user}","gists_url":"https://api.github.com/users/Cretino/gists{/gist_id}","starred_url":"https://api.github.com/users/Cretino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cretino/subscriptions","organizations_url":"https://api.github.com/users/Cretino/orgs","repos_url":"https://api.github.com/users/Cretino/repos","events_url":"https://api.github.com/users/Cretino/events{/privacy}","received_events_url":"https://api.github.com/users/Cretino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cretino/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/Cretino/Hercules","forks_url":"https://api.github.com/repos/Cretino/Hercules/forks","keys_url":"https://api.github.com/repos/Cretino/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cretino/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cretino/Hercules/teams","hooks_url":"https://api.github.com/repos/Cretino/Hercules/hooks","issue_events_url":"https://api.github.com/repos/Cretino/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/Cretino/Hercules/events","assignees_url":"https://api.github.com/repos/Cretino/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/Cretino/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/Cretino/Hercules/tags","blobs_url":"https://api.github.com/repos/Cretino/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cretino/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cretino/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cretino/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cretino/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/Cretino/Hercules/languages","stargazers_url":"https://api.github.com/repos/Cretino/Hercules/stargazers","contributors_url":"https://api.github.com/repos/Cretino/Hercules/contributors","subscribers_url":"https://api.github.com/repos/Cretino/Hercules/subscribers","subscription_url":"https://api.github.com/repos/Cretino/Hercules/subscription","commits_url":"https://api.github.com/repos/Cretino/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cretino/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cretino/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cretino/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cretino/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/Cretino/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cretino/Hercules/merges","archive_url":"https://api.github.com/repos/Cretino/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cretino/Hercules/downloads","issues_url":"https://api.github.com/repos/Cretino/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/Cretino/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/Cretino/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/Cretino/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cretino/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/Cretino/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/Cretino/Hercules/deployments","created_at":"2016-03-28T23:27:55Z","updated_at":"2016-03-28T23:28:03Z","pushed_at":"2016-03-29T15:38:33Z","git_url":"git://github.com/Cretino/Hercules.git","ssh_url":"git@github.com:Cretino/Hercules.git","clone_url":"https://github.com/Cretino/Hercules.git","svn_url":"https://github.com/Cretino/Hercules","homepage":"http://herc.ws","size":130518,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"11610a6011a9b543160e8d926b0f065d45fd9919","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2016-03-29T08:12:46Z","pushed_at":"2016-03-30T03:13:45Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":151912,"stargazers_count":265,"watchers_count":265,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":306,"forks":393,"open_issues":306,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1228"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1228"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1228/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1228/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/62b17812729cfc240c6a010fbcc83171ac2015aa"}}}}