{"action":"created","comment":{"url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments/67112535","id":67112535,"diff_hunk":"@@ -0,0 +1,30 @@\n+package com.actian.spark_vector.sql\n+\n+import java.util.concurrent.atomic.AtomicLong\n+import org.apache.spark.sql.DataFrame\n+\n+sealed trait SparkSqlTable {\n+  def tableName: String\n+  def quotedName = sparkQuote(tableName)","path":"src/main/scala/com/actian/spark_vector/sql/SparkSqlTable.scala","position":8,"original_position":8,"commit_id":"548757daaa15b571174ff073dcffb58d325588d0","original_commit_id":"548757daaa15b571174ff073dcffb58d325588d0","user":{"login":"cbarca","id":1218881,"avatar_url":"https://avatars.githubusercontent.com/u/1218881?v=3","gravatar_id":"","url":"https://api.github.com/users/cbarca","html_url":"https://github.com/cbarca","followers_url":"https://api.github.com/users/cbarca/followers","following_url":"https://api.github.com/users/cbarca/following{/other_user}","gists_url":"https://api.github.com/users/cbarca/gists{/gist_id}","starred_url":"https://api.github.com/users/cbarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbarca/subscriptions","organizations_url":"https://api.github.com/users/cbarca/orgs","repos_url":"https://api.github.com/users/cbarca/repos","events_url":"https://api.github.com/users/cbarca/events{/privacy}","received_events_url":"https://api.github.com/users/cbarca/received_events","type":"User","site_admin":false},"body":"return type\r\n\r\n(sbt scalastyle will tell you that too for public methods, which usually get into docs)","created_at":"2016-06-15T07:33:08Z","updated_at":"2016-06-15T07:33:08Z","html_url":"https://github.com/ActianCorp/spark-vector/pull/55#discussion_r67112535","pull_request_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments/67112535"},"html":{"href":"https://github.com/ActianCorp/spark-vector/pull/55#discussion_r67112535"},"pull_request":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55","id":73604943,"html_url":"https://github.com/ActianCorp/spark-vector/pull/55","diff_url":"https://github.com/ActianCorp/spark-vector/pull/55.diff","patch_url":"https://github.com/ActianCorp/spark-vector/pull/55.patch","issue_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/55","number":55,"state":"open","locked":false,"title":"scan no cols","user":{"login":"adrian-ionescu","id":16205848,"avatar_url":"https://avatars.githubusercontent.com/u/16205848?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-ionescu","html_url":"https://github.com/adrian-ionescu","followers_url":"https://api.github.com/users/adrian-ionescu/followers","following_url":"https://api.github.com/users/adrian-ionescu/following{/other_user}","gists_url":"https://api.github.com/users/adrian-ionescu/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-ionescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-ionescu/subscriptions","organizations_url":"https://api.github.com/users/adrian-ionescu/orgs","repos_url":"https://api.github.com/users/adrian-ionescu/repos","events_url":"https://api.github.com/users/adrian-ionescu/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-ionescu/received_events","type":"User","site_admin":false},"body":"This change addresses two issues:\r\n\r\n1) The provider was unable to handle \"scan\" requests for which the column list was empty.\r\n- The problem was that the constructed SparkSql query looked something like \"select  from table\".\r\n- Fixed by performing a \"select count(*) from table\", using the result to create an RDD of Row.empty, registering that as a temp_table_no_cols, and finally executing a \"select * from temp_table_no_cols\".\r\n\r\n2) Temp tables registered with the sqlContext were never dropped.\r\n- The problem was that we simply never called sqlContext.dropTable()\r\n- Fixed by implementing a TempTable class with a .close() method, so that we can treat instances of it as managed resources (in the Scala ARM sense).","created_at":"2016-06-13T16:30:37Z","updated_at":"2016-06-15T07:33:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffdc26d24f69b957746c4d09f5af463204a6187d","assignee":{"login":"and-costea","id":15726328,"avatar_url":"https://avatars.githubusercontent.com/u/15726328?v=3","gravatar_id":"","url":"https://api.github.com/users/and-costea","html_url":"https://github.com/and-costea","followers_url":"https://api.github.com/users/and-costea/followers","following_url":"https://api.github.com/users/and-costea/following{/other_user}","gists_url":"https://api.github.com/users/and-costea/gists{/gist_id}","starred_url":"https://api.github.com/users/and-costea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/and-costea/subscriptions","organizations_url":"https://api.github.com/users/and-costea/orgs","repos_url":"https://api.github.com/users/and-costea/repos","events_url":"https://api.github.com/users/and-costea/events{/privacy}","received_events_url":"https://api.github.com/users/and-costea/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55/commits","review_comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55/comments","review_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/55/comments","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/548757daaa15b571174ff073dcffb58d325588d0","head":{"label":"ActianCorp:scan-no-cols","ref":"scan-no-cols","sha":"548757daaa15b571174ff073dcffb58d325588d0","user":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":51449838,"name":"spark-vector","full_name":"ActianCorp/spark-vector","owner":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ActianCorp/spark-vector","description":"Repository for the Spark-Vector connector","fork":false,"url":"https://api.github.com/repos/ActianCorp/spark-vector","forks_url":"https://api.github.com/repos/ActianCorp/spark-vector/forks","keys_url":"https://api.github.com/repos/ActianCorp/spark-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ActianCorp/spark-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ActianCorp/spark-vector/teams","hooks_url":"https://api.github.com/repos/ActianCorp/spark-vector/hooks","issue_events_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/events{/number}","events_url":"https://api.github.com/repos/ActianCorp/spark-vector/events","assignees_url":"https://api.github.com/repos/ActianCorp/spark-vector/assignees{/user}","branches_url":"https://api.github.com/repos/ActianCorp/spark-vector/branches{/branch}","tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/tags","blobs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/ActianCorp/spark-vector/languages","stargazers_url":"https://api.github.com/repos/ActianCorp/spark-vector/stargazers","contributors_url":"https://api.github.com/repos/ActianCorp/spark-vector/contributors","subscribers_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscribers","subscription_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscription","commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/ActianCorp/spark-vector/contents/{+path}","compare_url":"https://api.github.com/repos/ActianCorp/spark-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ActianCorp/spark-vector/merges","archive_url":"https://api.github.com/repos/ActianCorp/spark-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ActianCorp/spark-vector/downloads","issues_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues{/number}","pulls_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/ActianCorp/spark-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/ActianCorp/spark-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ActianCorp/spark-vector/labels{/name}","releases_url":"https://api.github.com/repos/ActianCorp/spark-vector/releases{/id}","deployments_url":"https://api.github.com/repos/ActianCorp/spark-vector/deployments","created_at":"2016-02-10T15:30:30Z","updated_at":"2016-05-09T20:51:48Z","pushed_at":"2016-06-14T17:52:49Z","git_url":"git://github.com/ActianCorp/spark-vector.git","ssh_url":"git@github.com:ActianCorp/spark-vector.git","clone_url":"https://github.com/ActianCorp/spark-vector.git","svn_url":"https://github.com/ActianCorp/spark-vector","homepage":null,"size":1627,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"ActianCorp:master","ref":"master","sha":"30105498c5296790b628cb8a1f7a1c8fd238b936","user":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":51449838,"name":"spark-vector","full_name":"ActianCorp/spark-vector","owner":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ActianCorp/spark-vector","description":"Repository for the Spark-Vector connector","fork":false,"url":"https://api.github.com/repos/ActianCorp/spark-vector","forks_url":"https://api.github.com/repos/ActianCorp/spark-vector/forks","keys_url":"https://api.github.com/repos/ActianCorp/spark-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ActianCorp/spark-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ActianCorp/spark-vector/teams","hooks_url":"https://api.github.com/repos/ActianCorp/spark-vector/hooks","issue_events_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/events{/number}","events_url":"https://api.github.com/repos/ActianCorp/spark-vector/events","assignees_url":"https://api.github.com/repos/ActianCorp/spark-vector/assignees{/user}","branches_url":"https://api.github.com/repos/ActianCorp/spark-vector/branches{/branch}","tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/tags","blobs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/ActianCorp/spark-vector/languages","stargazers_url":"https://api.github.com/repos/ActianCorp/spark-vector/stargazers","contributors_url":"https://api.github.com/repos/ActianCorp/spark-vector/contributors","subscribers_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscribers","subscription_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscription","commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/ActianCorp/spark-vector/contents/{+path}","compare_url":"https://api.github.com/repos/ActianCorp/spark-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ActianCorp/spark-vector/merges","archive_url":"https://api.github.com/repos/ActianCorp/spark-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ActianCorp/spark-vector/downloads","issues_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues{/number}","pulls_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/ActianCorp/spark-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/ActianCorp/spark-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ActianCorp/spark-vector/labels{/name}","releases_url":"https://api.github.com/repos/ActianCorp/spark-vector/releases{/id}","deployments_url":"https://api.github.com/repos/ActianCorp/spark-vector/deployments","created_at":"2016-02-10T15:30:30Z","updated_at":"2016-05-09T20:51:48Z","pushed_at":"2016-06-14T17:52:49Z","git_url":"git://github.com/ActianCorp/spark-vector.git","ssh_url":"git@github.com:ActianCorp/spark-vector.git","clone_url":"https://github.com/ActianCorp/spark-vector.git","svn_url":"https://github.com/ActianCorp/spark-vector","homepage":null,"size":1627,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55"},"html":{"href":"https://github.com/ActianCorp/spark-vector/pull/55"},"issue":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/issues/55"},"comments":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/548757daaa15b571174ff073dcffb58d325588d0"}}}}
{"actor":{"display_login":"cbarca"}}