{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/71341562","id":71341562,"diff_hunk":"@@ -99,7 +99,7 @@ func NewTemplatePlugin(cfg TemplatePluginConfig) (*TemplatePlugin, error) {\n \tglobalFuncs := template.FuncMap{","path":"pkg/router/template/plugin.go","position":1,"original_position":1,"commit_id":"3893c95d162e35353312816dc8aefc76041094f1","original_commit_id":"3893c95d162e35353312816dc8aefc76041094f1","user":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars.githubusercontent.com/u/10033853?v=3","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"body":"We need to doc what these do... can we at least put a one-line comment on them to summarize usage?","created_at":"2016-07-19T13:49:18Z","updated_at":"2016-07-19T13:49:18Z","html_url":"https://github.com/openshift/origin/pull/9671#discussion_r71341562","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/9671","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/71341562"},"html":{"href":"https://github.com/openshift/origin/pull/9671#discussion_r71341562"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/9671"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9671","id":75986786,"html_url":"https://github.com/openshift/origin/pull/9671","diff_url":"https://github.com/openshift/origin/pull/9671.diff","patch_url":"https://github.com/openshift/origin/pull/9671.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/9671","number":9671,"state":"open","locked":false,"title":"allow for configurable server side timeouts on routes","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"body":"using annotations configure a route to have it's own server side timeout\r\n\r\n--beginning of route.yaml\r\napiVersion: v1\r\nkind: Route\r\nmetadata:\r\n  annotations:\r\n    hello-again.timeout: 5s\r\n  creationTimestamp: 2016-06-20T22:43:44Z\r\n  name: hello-again\r\n  namespace: default\r\n  resourceVersion: \"461544\"\r\n  selfLink: /oapi/v1/namespaces/default/routes/hello-again\r\n  uid: 717b8a38-3738-11e6-8b7f-525400d6577c\r\n...\r\n\r\nmatching against [routename].timeout: [time] is what creates the timeout","created_at":"2016-07-01T14:18:38Z","updated_at":"2016-07-19T13:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b13a40888116dedd107756c8780f436d3681f1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/9671/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/9671/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9671/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3893c95d162e35353312816dc8aefc76041094f1","head":{"label":"JacobTanenbaum:RouterTimeouts","ref":"RouterTimeouts","sha":"3893c95d162e35353312816dc8aefc76041094f1","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"repo":{"id":55235618,"name":"origin","full_name":"JacobTanenbaum/origin","owner":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacobTanenbaum/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":true,"url":"https://api.github.com/repos/JacobTanenbaum/origin","forks_url":"https://api.github.com/repos/JacobTanenbaum/origin/forks","keys_url":"https://api.github.com/repos/JacobTanenbaum/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacobTanenbaum/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacobTanenbaum/origin/teams","hooks_url":"https://api.github.com/repos/JacobTanenbaum/origin/hooks","issue_events_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/events{/number}","events_url":"https://api.github.com/repos/JacobTanenbaum/origin/events","assignees_url":"https://api.github.com/repos/JacobTanenbaum/origin/assignees{/user}","branches_url":"https://api.github.com/repos/JacobTanenbaum/origin/branches{/branch}","tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/tags","blobs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacobTanenbaum/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/JacobTanenbaum/origin/languages","stargazers_url":"https://api.github.com/repos/JacobTanenbaum/origin/stargazers","contributors_url":"https://api.github.com/repos/JacobTanenbaum/origin/contributors","subscribers_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscribers","subscription_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscription","commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacobTanenbaum/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacobTanenbaum/origin/contents/{+path}","compare_url":"https://api.github.com/repos/JacobTanenbaum/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacobTanenbaum/origin/merges","archive_url":"https://api.github.com/repos/JacobTanenbaum/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacobTanenbaum/origin/downloads","issues_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues{/number}","pulls_url":"https://api.github.com/repos/JacobTanenbaum/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/JacobTanenbaum/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/JacobTanenbaum/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacobTanenbaum/origin/labels{/name}","releases_url":"https://api.github.com/repos/JacobTanenbaum/origin/releases{/id}","deployments_url":"https://api.github.com/repos/JacobTanenbaum/origin/deployments","created_at":"2016-04-01T13:46:55Z","updated_at":"2016-04-01T13:47:03Z","pushed_at":"2016-07-19T13:42:27Z","git_url":"git://github.com/JacobTanenbaum/origin.git","ssh_url":"git@github.com:JacobTanenbaum/origin.git","clone_url":"https://github.com/JacobTanenbaum/origin.git","svn_url":"https://github.com/JacobTanenbaum/origin","homepage":"http://www.openshift.org","size":297543,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"50f1f6ebb58ac817623d1ee4fa310751e5b1e6de","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-07-19T13:48:13Z","pushed_at":"2016-07-19T13:42:28Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":546065,"stargazers_count":1493,"watchers_count":1493,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":888,"mirror_url":null,"open_issues_count":1086,"forks":888,"open_issues":1086,"watchers":1493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/9671"},"html":{"href":"https://github.com/openshift/origin/pull/9671"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/9671"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/9671/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/9671/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/9671/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3893c95d162e35353312816dc8aefc76041094f1"}}}}
{"actor":{"display_login":"knobunc"}}