{"action":"opened","number":25723,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25723","id":81339734,"html_url":"https://github.com/docker/docker/pull/25723","diff_url":"https://github.com/docker/docker/pull/25723.diff","patch_url":"https://github.com/docker/docker/pull/25723.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/25723","number":25723,"state":"open","locked":false,"title":"When handling plugin exit, lookup plugins only during daemon shutdown.","user":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars.githubusercontent.com/u/14184178?v=3","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\nThe main intent of handling plugin exit is for graceful shutdown\r\nof plugins during daemon shutdown. So avoid plugin lookup during\r\nplugin exits caused by other reasons (eg. force remove)\r\n\r\n**- How I did it**\r\nBy avoiding plugin lookup for cases other than daemon shutdown.\r\n\r\n**- How to verify it**\r\nBefore this change, `docker plugin remove --force` caused errors in daemon logs.\r\nDEBU[0450] plugin state changed 3a510f2a39b3805bebb55f20f3bbd92971a9405b0a4bc94b45050a213324bd40 libcontainerd.StateInfo{CommonStateInfo:libcontainerd.CommonStateInfo{State:\"exit\", Pid:0x0, ExitCode:0x89, ProcessID:\"\"}, OOMKilled:false}\r\nERRO[0450] libcontainerd: backend.StateChanged(): plugin \"3a510f2a39b3805bebb55f20f3bbd92971a9405b0a4bc94b45050a213324bd40\" not found\r\n\r\nAfter this change, there are no errors.  \r\n\r\nSigned-off-by: Anusha Ragunathan <anusha@docker.com>","created_at":"2016-08-15T16:49:32Z","updated_at":"2016-08-15T16:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/25723/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/25723/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/25723/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/3d432b4c549235f123238928593fa0f8b46ccf4e","head":{"label":"anusha-ragunathan:plugin-force-rm","ref":"plugin-force-rm","sha":"3d432b4c549235f123238928593fa0f8b46ccf4e","user":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars.githubusercontent.com/u/14184178?v=3","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"repo":{"id":42128270,"name":"docker","full_name":"anusha-ragunathan/docker","owner":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars.githubusercontent.com/u/14184178?v=3","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anusha-ragunathan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/anusha-ragunathan/docker","forks_url":"https://api.github.com/repos/anusha-ragunathan/docker/forks","keys_url":"https://api.github.com/repos/anusha-ragunathan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anusha-ragunathan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anusha-ragunathan/docker/teams","hooks_url":"https://api.github.com/repos/anusha-ragunathan/docker/hooks","issue_events_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/anusha-ragunathan/docker/events","assignees_url":"https://api.github.com/repos/anusha-ragunathan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/anusha-ragunathan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/anusha-ragunathan/docker/tags","blobs_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anusha-ragunathan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/anusha-ragunathan/docker/languages","stargazers_url":"https://api.github.com/repos/anusha-ragunathan/docker/stargazers","contributors_url":"https://api.github.com/repos/anusha-ragunathan/docker/contributors","subscribers_url":"https://api.github.com/repos/anusha-ragunathan/docker/subscribers","subscription_url":"https://api.github.com/repos/anusha-ragunathan/docker/subscription","commits_url":"https://api.github.com/repos/anusha-ragunathan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/anusha-ragunathan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/anusha-ragunathan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/anusha-ragunathan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anusha-ragunathan/docker/merges","archive_url":"https://api.github.com/repos/anusha-ragunathan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anusha-ragunathan/docker/downloads","issues_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/anusha-ragunathan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/anusha-ragunathan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/anusha-ragunathan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anusha-ragunathan/docker/labels{/name}","releases_url":"https://api.github.com/repos/anusha-ragunathan/docker/releases{/id}","deployments_url":"https://api.github.com/repos/anusha-ragunathan/docker/deployments","created_at":"2015-09-08T17:34:24Z","updated_at":"2015-09-08T17:34:32Z","pushed_at":"2016-08-15T16:45:42Z","git_url":"git://github.com/anusha-ragunathan/docker.git","ssh_url":"git@github.com:anusha-ragunathan/docker.git","clone_url":"https://github.com/anusha-ragunathan/docker.git","svn_url":"https://github.com/anusha-ragunathan/docker","homepage":"http://www.docker.com","size":96640,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"0f838cc5230c12f073095bf537ec896e95d1f631","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-08-15T15:54:09Z","pushed_at":"2016-08-15T16:49:33Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":205382,"stargazers_count":34028,"watchers_count":34028,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9935,"mirror_url":null,"open_issues_count":2121,"forks":9935,"open_issues":2121,"watchers":34028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/25723"},"html":{"href":"https://github.com/docker/docker/pull/25723"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/25723"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/25723/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/25723/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/25723/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/3d432b4c549235f123238928593fa0f8b46ccf4e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"anusha-ragunathan"}}