{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/234","repository_url":"https://api.github.com/repos/theforeman/foreman_discovery","labels_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/234/comments","events_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/234/events","html_url":"https://github.com/theforeman/foreman_discovery/pull/234","id":119188023,"number":234,"title":"Fixes #12391 - introduced foreman_discovery fact parser","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman_discovery/labels/Needs%20testing","name":"Needs testing","color":"207de5"},{"url":"https://api.github.com/repos/theforeman/foreman_discovery/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-27T12:24:18Z","updated_at":"2016-02-03T08:55:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/234","html_url":"https://github.com/theforeman/foreman_discovery/pull/234","diff_url":"https://github.com/theforeman/foreman_discovery/pull/234.diff","patch_url":"https://github.com/theforeman/foreman_discovery/pull/234.patch"},"body":"We were incorrectly overwriting ignore_puppet_facts_for_provisioning setting,\nthis caused to turn off this ignore globally when discovery was installed\ncausing troubles to regular fact parsing.\n\nThis patch introduces proper fact parser that is only used in discovery\ncontext, which is saner and safer. Monkey patching no more!"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/comments/179101342","html_url":"https://github.com/theforeman/foreman_discovery/pull/234#issuecomment-179101342","issue_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/234","id":179101342,"user":{"login":"brandonweeks","id":15869,"avatar_url":"https://avatars.githubusercontent.com/u/15869?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonweeks","html_url":"https://github.com/brandonweeks","followers_url":"https://api.github.com/users/brandonweeks/followers","following_url":"https://api.github.com/users/brandonweeks/following{/other_user}","gists_url":"https://api.github.com/users/brandonweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonweeks/subscriptions","organizations_url":"https://api.github.com/users/brandonweeks/orgs","repos_url":"https://api.github.com/users/brandonweeks/repos","events_url":"https://api.github.com/users/brandonweeks/events{/privacy}","received_events_url":"https://api.github.com/users/brandonweeks/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T08:55:54Z","updated_at":"2016-02-03T08:55:54Z","body":":+1: \r\n\r\nThe bug this fixes is rather unfortunate and pervasive, merging sooner than later would be good. :)"}}