{"action":"opened","number":637,"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637","id":97489557,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/637","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/637.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/637.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/637","number":637,"state":"open","locked":false,"title":"[Core] Account for TranslationX/Y when laying out children into bounding region","user":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nIn the below bug description, the user is having an issue when a `ViewCell` is scrolled off the screen, its `View` loses `TranslationX`. The change I made fixes this issue; however, I'm not 100% sure about the change as the layouting system is still a black box to me.\r\n\r\nThe sample code should demonstrate the solution. You can also give `PosX` a starting value so the cells are initially laid out with a non-zero `TranslationX`.\r\n\r\nNote that this is a change in Core, and I do not know how to unit test it.\r\n\r\n### Bugs Fixed ###\r\n\r\n- https://bugzilla.xamarin.com/show_bug.cgi?id=44690\r\n\r\n### PR Checklist ###\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n","created_at":"2016-12-12T03:24:21Z","updated_at":"2016-12-12T03:24:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/637/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/f1dab0f1df00e782fa48f47d4c8b1faf362d958f","head":{"label":"adrianknight89:alignment","ref":"alignment","sha":"f1dab0f1df00e782fa48f47d4c8b1faf362d958f","user":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"repo":{"id":67881694,"name":"Xamarin.Forms","full_name":"adrianknight89/Xamarin.Forms","owner":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrianknight89/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms","forks_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/deployments","created_at":"2016-09-10T16:25:42Z","updated_at":"2016-09-10T16:25:46Z","pushed_at":"2016-12-12T03:17:20Z","git_url":"git://github.com/adrianknight89/Xamarin.Forms.git","ssh_url":"git@github.com:adrianknight89/Xamarin.Forms.git","clone_url":"https://github.com/adrianknight89/Xamarin.Forms.git","svn_url":"https://github.com/adrianknight89/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":16275,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"899e2bd591bf33cf99c1db95666f1313ff80565b","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-12-11T22:19:36Z","pushed_at":"2016-12-12T03:24:21Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":30676,"stargazers_count":1053,"watchers_count":1053,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":91,"forks":390,"open_issues":91,"watchers":1053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/637"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/637"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/f1dab0f1df00e782fa48f47d4c8b1faf362d958f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":106,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"adrianknight89"}}