{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/comments/66776387","id":66776387,"diff_hunk":"@@ -28,9 +32,10 @@\n \n   <dependencies>\n     <dependency>\n-      <groupId>org.bouncycastle</groupId>\n-      <artifactId>bcpkix-jdk15on</artifactId>\n-      <version>1.54</version>\n+       <groupId>org.jenkins-ci.plugins</groupId>\n+       <artifactId>bouncycastle-api</artifactId>","path":"pom.xml","position":8,"original_position":19,"commit_id":"a655fcd878003a9c5ff24731fe5ab62348eeaca6","original_commit_id":"92a1ff453403d2eb5973c64d83da1a0b1b6575ea","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"Seems it also bumps the JDK dependency. Most likely it's fine","created_at":"2016-06-13T11:26:36Z","updated_at":"2016-06-13T11:26:36Z","html_url":"https://github.com/jenkinsci/instance-identity-module/pull/6#discussion_r66776387","pull_request_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/comments/66776387"},"html":{"href":"https://github.com/jenkinsci/instance-identity-module/pull/6#discussion_r66776387"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6","id":73551420,"html_url":"https://github.com/jenkinsci/instance-identity-module/pull/6","diff_url":"https://github.com/jenkinsci/instance-identity-module/pull/6.diff","patch_url":"https://github.com/jenkinsci/instance-identity-module/pull/6.patch","issue_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/6","number":6,"state":"open","locked":false,"title":"JENKINS-35489 - Remove Bouncy Castle dependency from instance identity module","user":{"login":"alvarolobato","id":17157380,"avatar_url":"https://avatars.githubusercontent.com/u/17157380?v=3","gravatar_id":"","url":"https://api.github.com/users/alvarolobato","html_url":"https://github.com/alvarolobato","followers_url":"https://api.github.com/users/alvarolobato/followers","following_url":"https://api.github.com/users/alvarolobato/following{/other_user}","gists_url":"https://api.github.com/users/alvarolobato/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarolobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarolobato/subscriptions","organizations_url":"https://api.github.com/users/alvarolobato/orgs","repos_url":"https://api.github.com/users/alvarolobato/repos","events_url":"https://api.github.com/users/alvarolobato/events{/privacy}","received_events_url":"https://api.github.com/users/alvarolobato/received_events","type":"User","site_admin":false},"body":"[JENKINS-35489](https://issues.jenkins-ci.org/browse/JENKINS-35489)\r\nDependency to multiple Bouncy Castle versions from jenkins core and plugins is causing problems due to the binary incompatibility between versions, the different supported algorithms, etc.\r\n\r\nPlugins should be migrated to use a common API and BC version in order to avoid these problems and the dependency from BC should be removed from the core.\r\n\r\nThis PR removes that dependency from the core by migrating the instance identity key from PCKS1 encoding to PCKS8 which is natively supported by the JDK.\r\n\r\nAfter this PR, instance identity module will be able to read any instance identity key encoded in PCKS1 or PCKS8 and will always write it in PCKS8 format.\r\n\r\nsee [bouncycastle-api plugin](https://github.com/jenkinsci/bouncycastle-api/blob/master/README.md)\r\n\r\n@reviewbybees esp: @stephenc ","created_at":"2016-06-13T10:12:18Z","updated_at":"2016-06-13T11:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34a90dd97c296e5833185cff981d527b5f17acfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/6/comments","statuses_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/statuses/a655fcd878003a9c5ff24731fe5ab62348eeaca6","head":{"label":"alvarolobato:master","ref":"master","sha":"a655fcd878003a9c5ff24731fe5ab62348eeaca6","user":{"login":"alvarolobato","id":17157380,"avatar_url":"https://avatars.githubusercontent.com/u/17157380?v=3","gravatar_id":"","url":"https://api.github.com/users/alvarolobato","html_url":"https://github.com/alvarolobato","followers_url":"https://api.github.com/users/alvarolobato/followers","following_url":"https://api.github.com/users/alvarolobato/following{/other_user}","gists_url":"https://api.github.com/users/alvarolobato/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarolobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarolobato/subscriptions","organizations_url":"https://api.github.com/users/alvarolobato/orgs","repos_url":"https://api.github.com/users/alvarolobato/repos","events_url":"https://api.github.com/users/alvarolobato/events{/privacy}","received_events_url":"https://api.github.com/users/alvarolobato/received_events","type":"User","site_admin":false},"repo":{"id":60761208,"name":"instance-identity-module","full_name":"alvarolobato/instance-identity-module","owner":{"login":"alvarolobato","id":17157380,"avatar_url":"https://avatars.githubusercontent.com/u/17157380?v=3","gravatar_id":"","url":"https://api.github.com/users/alvarolobato","html_url":"https://github.com/alvarolobato","followers_url":"https://api.github.com/users/alvarolobato/followers","following_url":"https://api.github.com/users/alvarolobato/following{/other_user}","gists_url":"https://api.github.com/users/alvarolobato/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarolobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarolobato/subscriptions","organizations_url":"https://api.github.com/users/alvarolobato/orgs","repos_url":"https://api.github.com/users/alvarolobato/repos","events_url":"https://api.github.com/users/alvarolobato/events{/privacy}","received_events_url":"https://api.github.com/users/alvarolobato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alvarolobato/instance-identity-module","description":"","fork":true,"url":"https://api.github.com/repos/alvarolobato/instance-identity-module","forks_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/forks","keys_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/teams","hooks_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/hooks","issue_events_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/issues/events{/number}","events_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/events","assignees_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/assignees{/user}","branches_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/branches{/branch}","tags_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/tags","blobs_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/statuses/{sha}","languages_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/languages","stargazers_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/stargazers","contributors_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/contributors","subscribers_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/subscribers","subscription_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/subscription","commits_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/contents/{+path}","compare_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/merges","archive_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/downloads","issues_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/issues{/number}","pulls_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/pulls{/number}","milestones_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/milestones{/number}","notifications_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/labels{/name}","releases_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/releases{/id}","deployments_url":"https://api.github.com/repos/alvarolobato/instance-identity-module/deployments","created_at":"2016-06-09T08:49:05Z","updated_at":"2016-06-09T08:49:05Z","pushed_at":"2016-06-13T11:22:32Z","git_url":"git://github.com/alvarolobato/instance-identity-module.git","ssh_url":"git@github.com:alvarolobato/instance-identity-module.git","clone_url":"https://github.com/alvarolobato/instance-identity-module.git","svn_url":"https://github.com/alvarolobato/instance-identity-module","homepage":"http://jenkins-ci.org/","size":64,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"5cf8e76a560b42cd2d33a294434b53811232ef7b","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1498444,"name":"instance-identity-module","full_name":"jenkinsci/instance-identity-module","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/instance-identity-module","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/instance-identity-module","forks_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/forks","keys_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/teams","hooks_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/events","assignees_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/tags","blobs_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/subscription","commits_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/merges","archive_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/downloads","issues_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/instance-identity-module/deployments","created_at":"2011-03-18T23:25:39Z","updated_at":"2015-07-16T10:42:32Z","pushed_at":"2016-06-13T11:22:33Z","git_url":"git://github.com/jenkinsci/instance-identity-module.git","ssh_url":"git@github.com:jenkinsci/instance-identity-module.git","clone_url":"https://github.com/jenkinsci/instance-identity-module.git","svn_url":"https://github.com/jenkinsci/instance-identity-module","homepage":"http://jenkins-ci.org/","size":48,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6"},"html":{"href":"https://github.com/jenkinsci/instance-identity-module/pull/6"},"issue":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/6"},"comments":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/instance-identity-module/statuses/a655fcd878003a9c5ff24731fe5ab62348eeaca6"}}}}
{"actor":{"display_login":"oleg-nenashev"}}