{"action":"created","issue":{"url":"https://api.github.com/repos/spark/firmware/issues/1184","repository_url":"https://api.github.com/repos/spark/firmware","labels_url":"https://api.github.com/repos/spark/firmware/issues/1184/labels{/name}","comments_url":"https://api.github.com/repos/spark/firmware/issues/1184/comments","events_url":"https://api.github.com/repos/spark/firmware/issues/1184/events","html_url":"https://github.com/spark/firmware/pull/1184","id":191873468,"number":1184,"title":"Move cellular HAL to system-part3","user":{"login":"sergeuz","id":770094,"avatar_url":"https://avatars.githubusercontent.com/u/770094?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeuz","html_url":"https://github.com/sergeuz","followers_url":"https://api.github.com/users/sergeuz/followers","following_url":"https://api.github.com/users/sergeuz/following{/other_user}","gists_url":"https://api.github.com/users/sergeuz/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeuz/subscriptions","organizations_url":"https://api.github.com/users/sergeuz/orgs","repos_url":"https://api.github.com/users/sergeuz/repos","events_url":"https://api.github.com/users/sergeuz/events{/privacy}","received_events_url":"https://api.github.com/users/sergeuz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false},"assignees":[{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spark/firmware/milestones/21","html_url":"https://github.com/spark/firmware/milestones/0.7.x","labels_url":"https://api.github.com/repos/spark/firmware/milestones/21/labels","id":1719802,"number":21,"title":"0.7.x","description":"Tentative:  address long standing issues in the backlog","creator":{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":14,"state":"open","created_at":"2016-04-20T05:33:15Z","updated_at":"2016-11-27T17:29:13Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-27T17:29:13Z","updated_at":"2016-11-28T09:31:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spark/firmware/pulls/1184","html_url":"https://github.com/spark/firmware/pull/1184","diff_url":"https://github.com/spark/firmware/pull/1184.diff","patch_url":"https://github.com/spark/firmware/pull/1184.patch"},"body":"This PR moves cellular HAL and its direct dependencies from part2 to part3 on Electron. On my system (gcc 5.3.1) this allows to reduce part2 by ~18K:\r\n\r\nBefore applying this patch (with debugging enabled):\r\n```\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n  13724\t    304\t   1460\t  15488\t   3c80\t../../../build/target/system-part1/platform-10-m/system-part1.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 127348\t    192\t    448\t 127988\t  1f3f4\t../../../build/target/system-part2/platform-10-m/system-part2.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 125828\t   2496\t   3768\t 132092\t  203fc\t../../../build/target/system-part3/platform-10-m/system-part3.elf\r\n```\r\n\r\nAfter:\r\n```\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n  37260\t    320\t   2140\t  39720\t   9b28\t../../../build/target/system-part1/platform-10-m/system-part1.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 127348\t    192\t    448\t 127988\t  1f3f4\t../../../build/target/system-part2/platform-10-m/system-part2.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 107108\t   2496\t   3272\t 112876\t  1b8ec\t../../../build/target/system-part3/platform-10-m/system-part3.elf\r\n```\r\n\r\nP.S. Don't get confused by the file names :)\r\n\r\n---\r\n\r\nDoneness:\r\n\r\n- [X] Contributor has signed CLA\r\n- [X] Problem and Solution clearly stated\r\n- [ ] Code peer reviewed\r\n- [ ] API tests compiled\r\n- [ ] Run unit/integration/application tests on device\r\n- [ ] Add documentation\r\n- [ ] Add to CHANGELOG.md after merging (add links to docs and issues)\r\n"},"comment":{"url":"https://api.github.com/repos/spark/firmware/issues/comments/263223445","html_url":"https://github.com/spark/firmware/pull/1184#issuecomment-263223445","issue_url":"https://api.github.com/repos/spark/firmware/issues/1184","id":263223445,"user":{"login":"sergeuz","id":770094,"avatar_url":"https://avatars.githubusercontent.com/u/770094?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeuz","html_url":"https://github.com/sergeuz","followers_url":"https://api.github.com/users/sergeuz/followers","following_url":"https://api.github.com/users/sergeuz/following{/other_user}","gists_url":"https://api.github.com/users/sergeuz/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeuz/subscriptions","organizations_url":"https://api.github.com/users/sergeuz/orgs","repos_url":"https://api.github.com/users/sergeuz/repos","events_url":"https://api.github.com/users/sergeuz/events{/privacy}","received_events_url":"https://api.github.com/users/sergeuz/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T09:31:36Z","updated_at":"2016-11-28T09:31:36Z","body":"I think that's something from libc that now happens to be in both part2 and part3. I'll check if there are any suspicious symbols though."}}
{"actor":{"display_login":"sergeuz"}}