{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/aochagavia/rocket/pulls/36","id":97440564,"html_url":"https://github.com/aochagavia/rocket/pull/36","diff_url":"https://github.com/aochagavia/rocket/pull/36.diff","patch_url":"https://github.com/aochagavia/rocket/pull/36.patch","issue_url":"https://api.github.com/repos/aochagavia/rocket/issues/36","number":36,"state":"open","locked":false,"title":"Expand glob import","user":{"login":"johnthagen","id":10340167,"avatar_url":"https://avatars.githubusercontent.com/u/10340167?v=3","gravatar_id":"","url":"https://api.github.com/users/johnthagen","html_url":"https://github.com/johnthagen","followers_url":"https://api.github.com/users/johnthagen/followers","following_url":"https://api.github.com/users/johnthagen/following{/other_user}","gists_url":"https://api.github.com/users/johnthagen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnthagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnthagen/subscriptions","organizations_url":"https://api.github.com/users/johnthagen/orgs","repos_url":"https://api.github.com/users/johnthagen/repos","events_url":"https://api.github.com/users/johnthagen/events{/privacy}","received_events_url":"https://api.github.com/users/johnthagen/received_events","type":"User","site_admin":false},"body":"When using `rocket` as an example, I think avoiding glob inputs and being more explicit helps.","created_at":"2016-12-10T22:36:18Z","updated_at":"2016-12-10T22:36:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aochagavia/rocket/pulls/36/commits","review_comments_url":"https://api.github.com/repos/aochagavia/rocket/pulls/36/comments","review_comment_url":"https://api.github.com/repos/aochagavia/rocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aochagavia/rocket/issues/36/comments","statuses_url":"https://api.github.com/repos/aochagavia/rocket/statuses/f03ec98b8a71e6074bfce0c4ae9e72cfcea1a0bf","head":{"label":"johnthagen:expand-import","ref":"expand-import","sha":"f03ec98b8a71e6074bfce0c4ae9e72cfcea1a0bf","user":{"login":"johnthagen","id":10340167,"avatar_url":"https://avatars.githubusercontent.com/u/10340167?v=3","gravatar_id":"","url":"https://api.github.com/users/johnthagen","html_url":"https://github.com/johnthagen","followers_url":"https://api.github.com/users/johnthagen/followers","following_url":"https://api.github.com/users/johnthagen/following{/other_user}","gists_url":"https://api.github.com/users/johnthagen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnthagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnthagen/subscriptions","organizations_url":"https://api.github.com/users/johnthagen/orgs","repos_url":"https://api.github.com/users/johnthagen/repos","events_url":"https://api.github.com/users/johnthagen/events{/privacy}","received_events_url":"https://api.github.com/users/johnthagen/received_events","type":"User","site_admin":false},"repo":{"id":76117361,"name":"rocket","full_name":"johnthagen/rocket","owner":{"login":"johnthagen","id":10340167,"avatar_url":"https://avatars.githubusercontent.com/u/10340167?v=3","gravatar_id":"","url":"https://api.github.com/users/johnthagen","html_url":"https://github.com/johnthagen","followers_url":"https://api.github.com/users/johnthagen/followers","following_url":"https://api.github.com/users/johnthagen/following{/other_user}","gists_url":"https://api.github.com/users/johnthagen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnthagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnthagen/subscriptions","organizations_url":"https://api.github.com/users/johnthagen/orgs","repos_url":"https://api.github.com/users/johnthagen/repos","events_url":"https://api.github.com/users/johnthagen/events{/privacy}","received_events_url":"https://api.github.com/users/johnthagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnthagen/rocket","description":"A toy game in Rust, using Piston","fork":true,"url":"https://api.github.com/repos/johnthagen/rocket","forks_url":"https://api.github.com/repos/johnthagen/rocket/forks","keys_url":"https://api.github.com/repos/johnthagen/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnthagen/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnthagen/rocket/teams","hooks_url":"https://api.github.com/repos/johnthagen/rocket/hooks","issue_events_url":"https://api.github.com/repos/johnthagen/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/johnthagen/rocket/events","assignees_url":"https://api.github.com/repos/johnthagen/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/johnthagen/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/johnthagen/rocket/tags","blobs_url":"https://api.github.com/repos/johnthagen/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnthagen/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnthagen/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnthagen/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnthagen/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/johnthagen/rocket/languages","stargazers_url":"https://api.github.com/repos/johnthagen/rocket/stargazers","contributors_url":"https://api.github.com/repos/johnthagen/rocket/contributors","subscribers_url":"https://api.github.com/repos/johnthagen/rocket/subscribers","subscription_url":"https://api.github.com/repos/johnthagen/rocket/subscription","commits_url":"https://api.github.com/repos/johnthagen/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnthagen/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnthagen/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnthagen/rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnthagen/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/johnthagen/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnthagen/rocket/merges","archive_url":"https://api.github.com/repos/johnthagen/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnthagen/rocket/downloads","issues_url":"https://api.github.com/repos/johnthagen/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/johnthagen/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/johnthagen/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/johnthagen/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnthagen/rocket/labels{/name}","releases_url":"https://api.github.com/repos/johnthagen/rocket/releases{/id}","deployments_url":"https://api.github.com/repos/johnthagen/rocket/deployments","created_at":"2016-12-10T14:27:26Z","updated_at":"2016-12-10T14:27:27Z","pushed_at":"2016-12-10T22:35:04Z","git_url":"git://github.com/johnthagen/rocket.git","ssh_url":"git@github.com:johnthagen/rocket.git","clone_url":"https://github.com/johnthagen/rocket.git","svn_url":"https://github.com/johnthagen/rocket","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aochagavia:master","ref":"master","sha":"7ac66999ce46e598393c4f837341e53483d0edb5","user":{"login":"aochagavia","id":5196584,"avatar_url":"https://avatars.githubusercontent.com/u/5196584?v=3","gravatar_id":"","url":"https://api.github.com/users/aochagavia","html_url":"https://github.com/aochagavia","followers_url":"https://api.github.com/users/aochagavia/followers","following_url":"https://api.github.com/users/aochagavia/following{/other_user}","gists_url":"https://api.github.com/users/aochagavia/gists{/gist_id}","starred_url":"https://api.github.com/users/aochagavia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aochagavia/subscriptions","organizations_url":"https://api.github.com/users/aochagavia/orgs","repos_url":"https://api.github.com/users/aochagavia/repos","events_url":"https://api.github.com/users/aochagavia/events{/privacy}","received_events_url":"https://api.github.com/users/aochagavia/received_events","type":"User","site_admin":false},"repo":{"id":38901627,"name":"rocket","full_name":"aochagavia/rocket","owner":{"login":"aochagavia","id":5196584,"avatar_url":"https://avatars.githubusercontent.com/u/5196584?v=3","gravatar_id":"","url":"https://api.github.com/users/aochagavia","html_url":"https://github.com/aochagavia","followers_url":"https://api.github.com/users/aochagavia/followers","following_url":"https://api.github.com/users/aochagavia/following{/other_user}","gists_url":"https://api.github.com/users/aochagavia/gists{/gist_id}","starred_url":"https://api.github.com/users/aochagavia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aochagavia/subscriptions","organizations_url":"https://api.github.com/users/aochagavia/orgs","repos_url":"https://api.github.com/users/aochagavia/repos","events_url":"https://api.github.com/users/aochagavia/events{/privacy}","received_events_url":"https://api.github.com/users/aochagavia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aochagavia/rocket","description":"A toy game in Rust, using Piston","fork":false,"url":"https://api.github.com/repos/aochagavia/rocket","forks_url":"https://api.github.com/repos/aochagavia/rocket/forks","keys_url":"https://api.github.com/repos/aochagavia/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aochagavia/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aochagavia/rocket/teams","hooks_url":"https://api.github.com/repos/aochagavia/rocket/hooks","issue_events_url":"https://api.github.com/repos/aochagavia/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/aochagavia/rocket/events","assignees_url":"https://api.github.com/repos/aochagavia/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/aochagavia/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/aochagavia/rocket/tags","blobs_url":"https://api.github.com/repos/aochagavia/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aochagavia/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aochagavia/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/aochagavia/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aochagavia/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/aochagavia/rocket/languages","stargazers_url":"https://api.github.com/repos/aochagavia/rocket/stargazers","contributors_url":"https://api.github.com/repos/aochagavia/rocket/contributors","subscribers_url":"https://api.github.com/repos/aochagavia/rocket/subscribers","subscription_url":"https://api.github.com/repos/aochagavia/rocket/subscription","commits_url":"https://api.github.com/repos/aochagavia/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/aochagavia/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/aochagavia/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/aochagavia/rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/aochagavia/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/aochagavia/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aochagavia/rocket/merges","archive_url":"https://api.github.com/repos/aochagavia/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aochagavia/rocket/downloads","issues_url":"https://api.github.com/repos/aochagavia/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/aochagavia/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/aochagavia/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/aochagavia/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aochagavia/rocket/labels{/name}","releases_url":"https://api.github.com/repos/aochagavia/rocket/releases{/id}","deployments_url":"https://api.github.com/repos/aochagavia/rocket/deployments","created_at":"2015-07-10T20:53:09Z","updated_at":"2016-11-29T10:54:45Z","pushed_at":"2016-12-10T21:57:32Z","git_url":"git://github.com/aochagavia/rocket.git","ssh_url":"git@github.com:aochagavia/rocket.git","clone_url":"https://github.com/aochagavia/rocket.git","svn_url":"https://github.com/aochagavia/rocket","homepage":null,"size":193,"stargazers_count":125,"watchers_count":125,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aochagavia/rocket/pulls/36"},"html":{"href":"https://github.com/aochagavia/rocket/pull/36"},"issue":{"href":"https://api.github.com/repos/aochagavia/rocket/issues/36"},"comments":{"href":"https://api.github.com/repos/aochagavia/rocket/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/aochagavia/rocket/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/aochagavia/rocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aochagavia/rocket/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/aochagavia/rocket/statuses/f03ec98b8a71e6074bfce0c4ae9e72cfcea1a0bf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"johnthagen"}}