{"action":"closed","number":231,"pull_request":{"url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231","id":83939628,"html_url":"https://github.com/rmosolgo/graphql-ruby/pull/231","diff_url":"https://github.com/rmosolgo/graphql-ruby/pull/231.diff","patch_url":"https://github.com/rmosolgo/graphql-ruby/pull/231.patch","issue_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/231","number":231,"state":"closed","locked":false,"title":"Implement Node value equality","user":{"login":"josh","id":137,"avatar_url":"https://avatars.githubusercontent.com/u/137?v=3","gravatar_id":"","url":"https://api.github.com/users/josh","html_url":"https://github.com/josh","followers_url":"https://api.github.com/users/josh/followers","following_url":"https://api.github.com/users/josh/following{/other_user}","gists_url":"https://api.github.com/users/josh/gists{/gist_id}","starred_url":"https://api.github.com/users/josh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh/subscriptions","organizations_url":"https://api.github.com/users/josh/orgs","repos_url":"https://api.github.com/users/josh/repos","events_url":"https://api.github.com/users/josh/events{/privacy}","received_events_url":"https://api.github.com/users/josh/received_events","type":"User","site_admin":true},"body":"In Ruby, `Object#equal?` is true reference equality while `Object#eql?` exists for *value* equality.\r\n\r\nThis implements a deep value equality check for any `AbstractNode`. This allows you to compare the results from `GraphQL.parse` to see if they produce an identical AST.\r\n\r\n`Object#eql?` is also used for `Set#include?` checks, so this allows for:\r\n\r\n``` ruby\r\nvalidated_documents = Set.new\r\n\r\ndoc = GraphQL.parse(str)\r\n\r\n# check if we already validated this AST, otherwise we can skip\r\nif !validated_documents.include?(doc)\r\n  validate_document!(doc)\r\n  validated_documents << doc\r\nend\r\n```","created_at":"2016-09-05T00:56:43Z","updated_at":"2016-09-08T13:22:43Z","closed_at":"2016-09-08T13:22:43Z","merged_at":"2016-09-08T13:22:43Z","merge_commit_sha":"4c4b7d37a18e61861d472049d01686400678aba6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231/commits","review_comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231/comments","review_comment_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/231/comments","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/ad3b671a0afc624cfc05399be36a687963c40ad5","head":{"label":"josh:document-eql","ref":"document-eql","sha":"ad3b671a0afc624cfc05399be36a687963c40ad5","user":{"login":"josh","id":137,"avatar_url":"https://avatars.githubusercontent.com/u/137?v=3","gravatar_id":"","url":"https://api.github.com/users/josh","html_url":"https://github.com/josh","followers_url":"https://api.github.com/users/josh/followers","following_url":"https://api.github.com/users/josh/following{/other_user}","gists_url":"https://api.github.com/users/josh/gists{/gist_id}","starred_url":"https://api.github.com/users/josh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh/subscriptions","organizations_url":"https://api.github.com/users/josh/orgs","repos_url":"https://api.github.com/users/josh/repos","events_url":"https://api.github.com/users/josh/events{/privacy}","received_events_url":"https://api.github.com/users/josh/received_events","type":"User","site_admin":true},"repo":{"id":58682488,"name":"graphql-ruby","full_name":"josh/graphql-ruby","owner":{"login":"josh","id":137,"avatar_url":"https://avatars.githubusercontent.com/u/137?v=3","gravatar_id":"","url":"https://api.github.com/users/josh","html_url":"https://github.com/josh","followers_url":"https://api.github.com/users/josh/followers","following_url":"https://api.github.com/users/josh/following{/other_user}","gists_url":"https://api.github.com/users/josh/gists{/gist_id}","starred_url":"https://api.github.com/users/josh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh/subscriptions","organizations_url":"https://api.github.com/users/josh/orgs","repos_url":"https://api.github.com/users/josh/repos","events_url":"https://api.github.com/users/josh/events{/privacy}","received_events_url":"https://api.github.com/users/josh/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/josh/graphql-ruby","description":"Ruby implementation of Facebook's GraphQL ","fork":true,"url":"https://api.github.com/repos/josh/graphql-ruby","forks_url":"https://api.github.com/repos/josh/graphql-ruby/forks","keys_url":"https://api.github.com/repos/josh/graphql-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josh/graphql-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josh/graphql-ruby/teams","hooks_url":"https://api.github.com/repos/josh/graphql-ruby/hooks","issue_events_url":"https://api.github.com/repos/josh/graphql-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/josh/graphql-ruby/events","assignees_url":"https://api.github.com/repos/josh/graphql-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/josh/graphql-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/josh/graphql-ruby/tags","blobs_url":"https://api.github.com/repos/josh/graphql-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josh/graphql-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josh/graphql-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/josh/graphql-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josh/graphql-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/josh/graphql-ruby/languages","stargazers_url":"https://api.github.com/repos/josh/graphql-ruby/stargazers","contributors_url":"https://api.github.com/repos/josh/graphql-ruby/contributors","subscribers_url":"https://api.github.com/repos/josh/graphql-ruby/subscribers","subscription_url":"https://api.github.com/repos/josh/graphql-ruby/subscription","commits_url":"https://api.github.com/repos/josh/graphql-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/josh/graphql-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/josh/graphql-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/josh/graphql-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/josh/graphql-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/josh/graphql-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josh/graphql-ruby/merges","archive_url":"https://api.github.com/repos/josh/graphql-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josh/graphql-ruby/downloads","issues_url":"https://api.github.com/repos/josh/graphql-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/josh/graphql-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/josh/graphql-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/josh/graphql-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josh/graphql-ruby/labels{/name}","releases_url":"https://api.github.com/repos/josh/graphql-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/josh/graphql-ruby/deployments","created_at":"2016-05-12T22:50:09Z","updated_at":"2016-05-12T22:50:10Z","pushed_at":"2016-09-08T05:55:37Z","git_url":"git://github.com/josh/graphql-ruby.git","ssh_url":"git@github.com:josh/graphql-ruby.git","clone_url":"https://github.com/josh/graphql-ruby.git","svn_url":"https://github.com/josh/graphql-ruby","homepage":"","size":1758,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rmosolgo:master","ref":"master","sha":"d18a6109339cc45bea5ade77a68f7afd113ab4df","user":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"repo":{"id":30337170,"name":"graphql-ruby","full_name":"rmosolgo/graphql-ruby","owner":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmosolgo/graphql-ruby","description":"Ruby implementation of Facebook's GraphQL ","fork":false,"url":"https://api.github.com/repos/rmosolgo/graphql-ruby","forks_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/forks","keys_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/teams","hooks_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/hooks","issue_events_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/events","assignees_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/tags","blobs_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/languages","stargazers_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/stargazers","contributors_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/contributors","subscribers_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/subscribers","subscription_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/subscription","commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/merges","archive_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/downloads","issues_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/deployments","created_at":"2015-02-05T04:11:22Z","updated_at":"2016-09-08T12:41:12Z","pushed_at":"2016-09-08T13:22:44Z","git_url":"git://github.com/rmosolgo/graphql-ruby.git","ssh_url":"git@github.com:rmosolgo/graphql-ruby.git","clone_url":"https://github.com/rmosolgo/graphql-ruby.git","svn_url":"https://github.com/rmosolgo/graphql-ruby","homepage":"","size":1973,"stargazers_count":806,"watchers_count":806,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":17,"forks":78,"open_issues":17,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231"},"html":{"href":"https://github.com/rmosolgo/graphql-ruby/pull/231"},"issue":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/231"},"comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/ad3b671a0afc624cfc05399be36a687963c40ad5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"comments":6,"review_comments":5,"commits":5,"additions":152,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"rmosolgo"}}