{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/5388","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/5388/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/5388/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/5388/events","html_url":"https://github.com/PX4/Firmware/pull/5388","id":173340340,"number":5388,"title":"WIP: Fix FMU MC failsafe on RC loss","user":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-26T00:11:04Z","updated_at":"2016-08-26T23:00:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/5388","html_url":"https://github.com/PX4/Firmware/pull/5388","diff_url":"https://github.com/PX4/Firmware/pull/5388.diff","patch_url":"https://github.com/PX4/Firmware/pull/5388.patch"},"body":"This fixes some problems with RC loss failsafe when in manual modes on fmu-v4, but may break other things since it's not clear to me how it was intended to work.\r\n\r\nIt appears that failsafe would never be entered if in manual mode with a GPS connected. \r\nAlso, px4fmu quit running the output mixer when RC was lost."},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/242871954","html_url":"https://github.com/PX4/Firmware/pull/5388#issuecomment-242871954","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/5388","id":242871954,"user":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T23:00:46Z","updated_at":"2016-08-26T23:00:46Z","body":"The remaining open question on this fix is how to repair the commander logic which sets flags.gps_failure. Since this is never set if there is no GPS module (one known problem case), there is currently no way to configure RC loss to cause motor shutdown (termination). My proposed fix works, but precludes a controlled descent on RC loss. Of course at this point (line 2703 of commander.cpp) we're already in termination state, not land or descend... "}}
{"actor":{"display_login":"kd0aij"}}