{"action":"closed","number":1480,"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1480","id":39165417,"html_url":"https://github.com/sunpy/sunpy/pull/1480","diff_url":"https://github.com/sunpy/sunpy/pull/1480.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1480.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1480","number":1480,"state":"closed","locked":false,"title":"Spectral cubes and full EIS compatibility","user":{"login":"mateoi","id":5617690,"avatar_url":"https://avatars.githubusercontent.com/u/5617690?v=3","gravatar_id":"","url":"https://api.github.com/users/mateoi","html_url":"https://github.com/mateoi","followers_url":"https://api.github.com/users/mateoi/followers","following_url":"https://api.github.com/users/mateoi/following{/other_user}","gists_url":"https://api.github.com/users/mateoi/gists{/gist_id}","starred_url":"https://api.github.com/users/mateoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateoi/subscriptions","organizations_url":"https://api.github.com/users/mateoi/orgs","repos_url":"https://api.github.com/users/mateoi/repos","events_url":"https://api.github.com/users/mateoi/events{/privacy}","received_events_url":"https://api.github.com/users/mateoi/received_events","type":"User","site_admin":false},"body":"This pull request will add full EIS compatibility and a new object: spectral cubes. These are different from regular cubes because they are a 2D array of spectra with useful functions to go with it - such as gaussian fitting, intensity and velocity maps, and other goodies.\r\nThe Spectrum class is also overhauled - it is now a subclass of astropy's NDDataArray, not numpy's NDArray. The spectral axis can now be by wavelength or frequency and can be shifted. It now uses quantities instead of floats, while not breaking (i.e. tests pass) Callisto or Spectrogram (these had minor tweaks). It can also fit a simple or composite gaussian function.","created_at":"2015-07-03T10:51:13Z","updated_at":"2016-02-08T17:46:13Z","closed_at":"2016-02-08T17:46:13Z","merged_at":null,"merge_commit_sha":"013a23a96220996a1b3d5234d446dc99aa71b4a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1480/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1480/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1480/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/514ad12e1f602bcee8ef166f636fae62689b9a1f","head":{"label":"mateoi:spectral_cubes","ref":"spectral_cubes","sha":"514ad12e1f602bcee8ef166f636fae62689b9a1f","user":{"login":"mateoi","id":5617690,"avatar_url":"https://avatars.githubusercontent.com/u/5617690?v=3","gravatar_id":"","url":"https://api.github.com/users/mateoi","html_url":"https://github.com/mateoi","followers_url":"https://api.github.com/users/mateoi/followers","following_url":"https://api.github.com/users/mateoi/following{/other_user}","gists_url":"https://api.github.com/users/mateoi/gists{/gist_id}","starred_url":"https://api.github.com/users/mateoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateoi/subscriptions","organizations_url":"https://api.github.com/users/mateoi/orgs","repos_url":"https://api.github.com/users/mateoi/repos","events_url":"https://api.github.com/users/mateoi/events{/privacy}","received_events_url":"https://api.github.com/users/mateoi/received_events","type":"User","site_admin":false},"repo":{"id":19815803,"name":"sunpy","full_name":"mateoi/sunpy","owner":{"login":"mateoi","id":5617690,"avatar_url":"https://avatars.githubusercontent.com/u/5617690?v=3","gravatar_id":"","url":"https://api.github.com/users/mateoi","html_url":"https://github.com/mateoi","followers_url":"https://api.github.com/users/mateoi/followers","following_url":"https://api.github.com/users/mateoi/following{/other_user}","gists_url":"https://api.github.com/users/mateoi/gists{/gist_id}","starred_url":"https://api.github.com/users/mateoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateoi/subscriptions","organizations_url":"https://api.github.com/users/mateoi/orgs","repos_url":"https://api.github.com/users/mateoi/repos","events_url":"https://api.github.com/users/mateoi/events{/privacy}","received_events_url":"https://api.github.com/users/mateoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mateoi/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/mateoi/sunpy","forks_url":"https://api.github.com/repos/mateoi/sunpy/forks","keys_url":"https://api.github.com/repos/mateoi/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mateoi/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mateoi/sunpy/teams","hooks_url":"https://api.github.com/repos/mateoi/sunpy/hooks","issue_events_url":"https://api.github.com/repos/mateoi/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/mateoi/sunpy/events","assignees_url":"https://api.github.com/repos/mateoi/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/mateoi/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/mateoi/sunpy/tags","blobs_url":"https://api.github.com/repos/mateoi/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mateoi/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mateoi/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mateoi/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mateoi/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mateoi/sunpy/languages","stargazers_url":"https://api.github.com/repos/mateoi/sunpy/stargazers","contributors_url":"https://api.github.com/repos/mateoi/sunpy/contributors","subscribers_url":"https://api.github.com/repos/mateoi/sunpy/subscribers","subscription_url":"https://api.github.com/repos/mateoi/sunpy/subscription","commits_url":"https://api.github.com/repos/mateoi/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mateoi/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mateoi/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mateoi/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mateoi/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/mateoi/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mateoi/sunpy/merges","archive_url":"https://api.github.com/repos/mateoi/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mateoi/sunpy/downloads","issues_url":"https://api.github.com/repos/mateoi/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/mateoi/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mateoi/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mateoi/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mateoi/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/mateoi/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/mateoi/sunpy/deployments","created_at":"2014-05-15T10:47:53Z","updated_at":"2014-06-25T22:44:27Z","pushed_at":"2015-07-28T08:51:14Z","git_url":"git://github.com/mateoi/sunpy.git","ssh_url":"git@github.com:mateoi/sunpy.git","clone_url":"https://github.com/mateoi/sunpy.git","svn_url":"https://github.com/mateoi/sunpy","homepage":"http://www.sunpy.org","size":36824,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"fe7db2b0fbb91762802a23dc6bc19a28690123f7","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for Solar Physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/sunpy/sunpy/deployments","created_at":"2011-08-06T15:34:08Z","updated_at":"2016-02-05T14:54:15Z","pushed_at":"2016-02-08T17:27:30Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":139880,"stargazers_count":212,"watchers_count":212,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":236,"forks":144,"open_issues":236,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1480"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1480"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1480"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1480/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1480/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1480/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/514ad12e1f602bcee8ef166f636fae62689b9a1f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":4,"commits":109,"additions":2674,"deletions":109,"changed_files":24}}