{"action":"closed","number":1293,"pull_request":{"url":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293","id":56948379,"html_url":"https://github.com/OfficeDev/PnP/pull/1293","diff_url":"https://github.com/OfficeDev/PnP/pull/1293.diff","patch_url":"https://github.com/OfficeDev/PnP/pull/1293.patch","issue_url":"https://api.github.com/repos/OfficeDev/PnP/issues/1293","number":1293,"state":"closed","locked":false,"title":"Userprofile sample bugfix","user":{"login":"svarukala","id":2417337,"avatar_url":"https://avatars.githubusercontent.com/u/2417337?v=3","gravatar_id":"","url":"https://api.github.com/users/svarukala","html_url":"https://github.com/svarukala","followers_url":"https://api.github.com/users/svarukala/followers","following_url":"https://api.github.com/users/svarukala/following{/other_user}","gists_url":"https://api.github.com/users/svarukala/gists{/gist_id}","starred_url":"https://api.github.com/users/svarukala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svarukala/subscriptions","organizations_url":"https://api.github.com/users/svarukala/orgs","repos_url":"https://api.github.com/users/svarukala/repos","events_url":"https://api.github.com/users/svarukala/events{/privacy}","received_events_url":"https://api.github.com/users/svarukala/received_events","type":"User","site_admin":false},"body":"The do-while loop incorrectly misses the last batch of users. The condition I added checks for the last batch of users and adds it to the list. Otherwise, the pagedCollection.MorePagesAvailable fails in the while condition and the loop misses the last batch of users. \r\n\r\nUpdate: changed the if condition check.","created_at":"2016-01-22T22:08:21Z","updated_at":"2016-01-22T22:08:47Z","closed_at":"2016-01-22T22:08:47Z","merged_at":null,"merge_commit_sha":"a222a9702d0ba9e83ca3469545b652878c846bc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/PnP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/PnP/issues/1293/comments","statuses_url":"https://api.github.com/repos/OfficeDev/PnP/statuses/f4ed3ccba61d25833fc18fbca7165b17b44e376d","head":{"label":"svarukala:userprofile-sample-bugfix","ref":"userprofile-sample-bugfix","sha":"f4ed3ccba61d25833fc18fbca7165b17b44e376d","user":{"login":"svarukala","id":2417337,"avatar_url":"https://avatars.githubusercontent.com/u/2417337?v=3","gravatar_id":"","url":"https://api.github.com/users/svarukala","html_url":"https://github.com/svarukala","followers_url":"https://api.github.com/users/svarukala/followers","following_url":"https://api.github.com/users/svarukala/following{/other_user}","gists_url":"https://api.github.com/users/svarukala/gists{/gist_id}","starred_url":"https://api.github.com/users/svarukala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svarukala/subscriptions","organizations_url":"https://api.github.com/users/svarukala/orgs","repos_url":"https://api.github.com/users/svarukala/repos","events_url":"https://api.github.com/users/svarukala/events{/privacy}","received_events_url":"https://api.github.com/users/svarukala/received_events","type":"User","site_admin":false},"repo":{"id":50205439,"name":"PnP","full_name":"svarukala/PnP","owner":{"login":"svarukala","id":2417337,"avatar_url":"https://avatars.githubusercontent.com/u/2417337?v=3","gravatar_id":"","url":"https://api.github.com/users/svarukala","html_url":"https://github.com/svarukala","followers_url":"https://api.github.com/users/svarukala/followers","following_url":"https://api.github.com/users/svarukala/following{/other_user}","gists_url":"https://api.github.com/users/svarukala/gists{/gist_id}","starred_url":"https://api.github.com/users/svarukala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svarukala/subscriptions","organizations_url":"https://api.github.com/users/svarukala/orgs","repos_url":"https://api.github.com/users/svarukala/repos","events_url":"https://api.github.com/users/svarukala/events{/privacy}","received_events_url":"https://api.github.com/users/svarukala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svarukala/PnP","description":"Office365 Developer Patterns and Practices","fork":true,"url":"https://api.github.com/repos/svarukala/PnP","forks_url":"https://api.github.com/repos/svarukala/PnP/forks","keys_url":"https://api.github.com/repos/svarukala/PnP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svarukala/PnP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svarukala/PnP/teams","hooks_url":"https://api.github.com/repos/svarukala/PnP/hooks","issue_events_url":"https://api.github.com/repos/svarukala/PnP/issues/events{/number}","events_url":"https://api.github.com/repos/svarukala/PnP/events","assignees_url":"https://api.github.com/repos/svarukala/PnP/assignees{/user}","branches_url":"https://api.github.com/repos/svarukala/PnP/branches{/branch}","tags_url":"https://api.github.com/repos/svarukala/PnP/tags","blobs_url":"https://api.github.com/repos/svarukala/PnP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svarukala/PnP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svarukala/PnP/git/refs{/sha}","trees_url":"https://api.github.com/repos/svarukala/PnP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svarukala/PnP/statuses/{sha}","languages_url":"https://api.github.com/repos/svarukala/PnP/languages","stargazers_url":"https://api.github.com/repos/svarukala/PnP/stargazers","contributors_url":"https://api.github.com/repos/svarukala/PnP/contributors","subscribers_url":"https://api.github.com/repos/svarukala/PnP/subscribers","subscription_url":"https://api.github.com/repos/svarukala/PnP/subscription","commits_url":"https://api.github.com/repos/svarukala/PnP/commits{/sha}","git_commits_url":"https://api.github.com/repos/svarukala/PnP/git/commits{/sha}","comments_url":"https://api.github.com/repos/svarukala/PnP/comments{/number}","issue_comment_url":"https://api.github.com/repos/svarukala/PnP/issues/comments{/number}","contents_url":"https://api.github.com/repos/svarukala/PnP/contents/{+path}","compare_url":"https://api.github.com/repos/svarukala/PnP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svarukala/PnP/merges","archive_url":"https://api.github.com/repos/svarukala/PnP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svarukala/PnP/downloads","issues_url":"https://api.github.com/repos/svarukala/PnP/issues{/number}","pulls_url":"https://api.github.com/repos/svarukala/PnP/pulls{/number}","milestones_url":"https://api.github.com/repos/svarukala/PnP/milestones{/number}","notifications_url":"https://api.github.com/repos/svarukala/PnP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svarukala/PnP/labels{/name}","releases_url":"https://api.github.com/repos/svarukala/PnP/releases{/id}","deployments_url":"https://api.github.com/repos/svarukala/PnP/deployments","created_at":"2016-01-22T20:21:39Z","updated_at":"2016-01-22T20:21:45Z","pushed_at":"2016-01-22T22:07:26Z","git_url":"git://github.com/svarukala/PnP.git","ssh_url":"git@github.com:svarukala/PnP.git","clone_url":"https://github.com/svarukala/PnP.git","svn_url":"https://github.com/svarukala/PnP","homepage":"","size":156118,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"82a7a9327106c6f8b9db1649731287d4470d8246","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":22300924,"name":"PnP","full_name":"OfficeDev/PnP","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/PnP","description":"Office365 Developer Patterns and Practices","fork":false,"url":"https://api.github.com/repos/OfficeDev/PnP","forks_url":"https://api.github.com/repos/OfficeDev/PnP/forks","keys_url":"https://api.github.com/repos/OfficeDev/PnP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/PnP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/PnP/teams","hooks_url":"https://api.github.com/repos/OfficeDev/PnP/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/PnP/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/PnP/events","assignees_url":"https://api.github.com/repos/OfficeDev/PnP/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/PnP/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/PnP/tags","blobs_url":"https://api.github.com/repos/OfficeDev/PnP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/PnP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/PnP/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/PnP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/PnP/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/PnP/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/PnP/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/PnP/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/PnP/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/PnP/subscription","commits_url":"https://api.github.com/repos/OfficeDev/PnP/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/PnP/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/PnP/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/PnP/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/PnP/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/PnP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/PnP/merges","archive_url":"https://api.github.com/repos/OfficeDev/PnP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/PnP/downloads","issues_url":"https://api.github.com/repos/OfficeDev/PnP/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/PnP/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/PnP/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/PnP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/PnP/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/PnP/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/PnP/deployments","created_at":"2014-07-27T02:08:15Z","updated_at":"2016-01-22T10:06:58Z","pushed_at":"2016-01-22T22:08:21Z","git_url":"git://github.com/OfficeDev/PnP.git","ssh_url":"git@github.com:OfficeDev/PnP.git","clone_url":"https://github.com/OfficeDev/PnP.git","svn_url":"https://github.com/OfficeDev/PnP","homepage":"","size":161857,"stargazers_count":703,"watchers_count":703,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1247,"mirror_url":null,"open_issues_count":53,"forks":1247,"open_issues":53,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293"},"html":{"href":"https://github.com/OfficeDev/PnP/pull/1293"},"issue":{"href":"https://api.github.com/repos/OfficeDev/PnP/issues/1293"},"comments":{"href":"https://api.github.com/repos/OfficeDev/PnP/issues/1293/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/PnP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/PnP/pulls/1293/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/PnP/statuses/f4ed3ccba61d25833fc18fbca7165b17b44e376d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":37,"additions":37132,"deletions":56,"changed_files":135}}