{"action":"created","issue":{"url":"https://api.github.com/repos/google/blockly/issues/552","repository_url":"https://api.github.com/repos/google/blockly","labels_url":"https://api.github.com/repos/google/blockly/issues/552/labels{/name}","comments_url":"https://api.github.com/repos/google/blockly/issues/552/comments","events_url":"https://api.github.com/repos/google/blockly/issues/552/events","html_url":"https://github.com/google/blockly/pull/552","id":171475611,"number":552,"title":"Blockly Factory: Generate Category Xml","user":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-08-16T17:43:42Z","updated_at":"2016-08-17T20:40:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/552","html_url":"https://github.com/google/blockly/pull/552","diff_url":"https://github.com/google/blockly/pull/552.diff","patch_url":"https://github.com/google/blockly/pull/552.patch"},"body":"In order to allow users to add custom blocks to their toolbox and workspace configurations within Workspace Factory, we generate the xml for those categories.\r\n\r\n- can generate category xml from Block Library (BlockExporterTools)\r\n- can generate category xml from imported block definitions (Workspace Factory Generator)\r\n- added helper functions for category xml generation to FactoryUtils\r\n- can get Block Library category xml through BlockExporterController\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/blockly/552)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/google/blockly/issues/comments/240540773","html_url":"https://github.com/google/blockly/pull/552#issuecomment-240540773","issue_url":"https://api.github.com/repos/google/blockly/issues/552","id":240540773,"user":{"login":"vicng","id":13488389,"avatar_url":"https://avatars.githubusercontent.com/u/13488389?v=3","gravatar_id":"","url":"https://api.github.com/users/vicng","html_url":"https://github.com/vicng","followers_url":"https://api.github.com/users/vicng/followers","following_url":"https://api.github.com/users/vicng/following{/other_user}","gists_url":"https://api.github.com/users/vicng/gists{/gist_id}","starred_url":"https://api.github.com/users/vicng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicng/subscriptions","organizations_url":"https://api.github.com/users/vicng/orgs","repos_url":"https://api.github.com/users/vicng/repos","events_url":"https://api.github.com/users/vicng/events{/privacy}","received_events_url":"https://api.github.com/users/vicng/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T20:40:31Z","updated_at":"2016-08-17T20:40:31Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> after minor changes\n\n---\n\nReview status: 0 of 4 files reviewed at latest revision, 14 unresolved discussions.\n\n---\n\n*[demos/blocklyfactory/block_exporter_tools.js, line 197 \\[r3\\]](https://reviewable.io:443/reviews/google/blockly/552#-KPOVyJ1pqx3o5a26GWw:-KPPDkRf0fYtJ2VKwUwH:b-wx1i1j) ([raw file](https://github.com/google/blockly/blob/999c64dea883467d3cd2d8289a5b8dcf6f1688b7/demos/blocklyfactory/block_exporter_tools.js#L197)):*\n<details><summary><i>Previously, quachtina96 wrote…</i></summary>\n> Done.\n</details>\nMissing commit?\n\n---\n\n*[demos/blocklyfactory/factory_utils.js, line 829 \\[r2\\]](https://reviewable.io:443/reviews/google/blockly/552#-KPKcb_Ho2ROc6SAz6nG:-KPPAqmeIWS9E1r9r69N:biw3azh) ([raw file](https://github.com/google/blockly/blob/cf39a3efa9d44c1e7976c85080caf37819848a1c/demos/blocklyfactory/factory_utils.js#L829)):*\n<details><summary><i>Previously, quachtina96 wrote…</i></summary>\n> blockDefsString is multiple JSON object string representations concatenated.\n> The native JSON.parse() function expects the whole string to be valid JSON.\n</details>\nUpdate the method comment to explain what the expected input is and maybe give an example.\n\n---\n\n*[demos/blocklyfactory/factory_utils.js, line 759 \\[r3\\]](https://reviewable.io:443/reviews/google/blockly/552#-KPPAHskz-9twOu2oo_h:-KPPAHskz-9twOu2oo_i:beodpkz) ([raw file](https://github.com/google/blockly/blob/999c64dea883467d3cd2d8289a5b8dcf6f1688b7/demos/blocklyfactory/factory_utils.js#L759)):*\n> ```JavaScript\n>  */\n> FactoryUtils.generateCategoryXml =\n>     function(blocks, categoryName) {\n> ```\n\nNit: I think this can be moved back to the previous line.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/google/blockly/552#-:-KPPDgMTrmt0MBJt9017:b-861mez)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"vicng"}}