{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11","id":83685528,"html_url":"https://github.com/mehrdadrad/mylg/pull/11","diff_url":"https://github.com/mehrdadrad/mylg/pull/11.diff","patch_url":"https://github.com/mehrdadrad/mylg/pull/11.patch","issue_url":"https://api.github.com/repos/mehrdadrad/mylg/issues/11","number":11,"state":"open","locked":false,"title":"Fixes for tests","user":{"login":"gummiboll","id":1127811,"avatar_url":"https://avatars.githubusercontent.com/u/1127811?v=3","gravatar_id":"","url":"https://api.github.com/users/gummiboll","html_url":"https://github.com/gummiboll","followers_url":"https://api.github.com/users/gummiboll/followers","following_url":"https://api.github.com/users/gummiboll/following{/other_user}","gists_url":"https://api.github.com/users/gummiboll/gists{/gist_id}","starred_url":"https://api.github.com/users/gummiboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gummiboll/subscriptions","organizations_url":"https://api.github.com/users/gummiboll/orgs","repos_url":"https://api.github.com/users/gummiboll/repos","events_url":"https://api.github.com/users/gummiboll/events{/privacy}","received_events_url":"https://api.github.com/users/gummiboll/received_events","type":"User","site_admin":false},"body":"This PR fixes some broken tests, some intendation in .travis.yaml and makes travis run tests on all packages and not just main. Removed cover from tests since it [doesn't support](https://github.com/golang/go/issues/6909) multiple packages out of the box but it seems better to run tests on all packages than getting a empty coverage report that isn't used anyways(?)\r\n\r\nThere are some [potential](https://github.com/h12w/gosweep) [fixes](https://github.com/modocache/gover) for generating reports from all packages but not sure if you want to implement them.\r\n\r\nPS. Didn't check for err from cli.ReadDefaultConfig() since its already tested in cli/config_test","created_at":"2016-09-01T18:45:01Z","updated_at":"2016-09-01T18:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11/commits","review_comments_url":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11/comments","review_comment_url":"https://api.github.com/repos/mehrdadrad/mylg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mehrdadrad/mylg/issues/11/comments","statuses_url":"https://api.github.com/repos/mehrdadrad/mylg/statuses/16463ef47b98b959f66f4ba6a687ec8bcceb4d90","head":{"label":"gummiboll:test-fix","ref":"test-fix","sha":"16463ef47b98b959f66f4ba6a687ec8bcceb4d90","user":{"login":"gummiboll","id":1127811,"avatar_url":"https://avatars.githubusercontent.com/u/1127811?v=3","gravatar_id":"","url":"https://api.github.com/users/gummiboll","html_url":"https://github.com/gummiboll","followers_url":"https://api.github.com/users/gummiboll/followers","following_url":"https://api.github.com/users/gummiboll/following{/other_user}","gists_url":"https://api.github.com/users/gummiboll/gists{/gist_id}","starred_url":"https://api.github.com/users/gummiboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gummiboll/subscriptions","organizations_url":"https://api.github.com/users/gummiboll/orgs","repos_url":"https://api.github.com/users/gummiboll/repos","events_url":"https://api.github.com/users/gummiboll/events{/privacy}","received_events_url":"https://api.github.com/users/gummiboll/received_events","type":"User","site_admin":false},"repo":{"id":66643471,"name":"mylg","full_name":"gummiboll/mylg","owner":{"login":"gummiboll","id":1127811,"avatar_url":"https://avatars.githubusercontent.com/u/1127811?v=3","gravatar_id":"","url":"https://api.github.com/users/gummiboll","html_url":"https://github.com/gummiboll","followers_url":"https://api.github.com/users/gummiboll/followers","following_url":"https://api.github.com/users/gummiboll/following{/other_user}","gists_url":"https://api.github.com/users/gummiboll/gists{/gist_id}","starred_url":"https://api.github.com/users/gummiboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gummiboll/subscriptions","organizations_url":"https://api.github.com/users/gummiboll/orgs","repos_url":"https://api.github.com/users/gummiboll/repos","events_url":"https://api.github.com/users/gummiboll/events{/privacy}","received_events_url":"https://api.github.com/users/gummiboll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gummiboll/mylg","description":"Network Diagnostic Tool","fork":true,"url":"https://api.github.com/repos/gummiboll/mylg","forks_url":"https://api.github.com/repos/gummiboll/mylg/forks","keys_url":"https://api.github.com/repos/gummiboll/mylg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gummiboll/mylg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gummiboll/mylg/teams","hooks_url":"https://api.github.com/repos/gummiboll/mylg/hooks","issue_events_url":"https://api.github.com/repos/gummiboll/mylg/issues/events{/number}","events_url":"https://api.github.com/repos/gummiboll/mylg/events","assignees_url":"https://api.github.com/repos/gummiboll/mylg/assignees{/user}","branches_url":"https://api.github.com/repos/gummiboll/mylg/branches{/branch}","tags_url":"https://api.github.com/repos/gummiboll/mylg/tags","blobs_url":"https://api.github.com/repos/gummiboll/mylg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gummiboll/mylg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gummiboll/mylg/git/refs{/sha}","trees_url":"https://api.github.com/repos/gummiboll/mylg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gummiboll/mylg/statuses/{sha}","languages_url":"https://api.github.com/repos/gummiboll/mylg/languages","stargazers_url":"https://api.github.com/repos/gummiboll/mylg/stargazers","contributors_url":"https://api.github.com/repos/gummiboll/mylg/contributors","subscribers_url":"https://api.github.com/repos/gummiboll/mylg/subscribers","subscription_url":"https://api.github.com/repos/gummiboll/mylg/subscription","commits_url":"https://api.github.com/repos/gummiboll/mylg/commits{/sha}","git_commits_url":"https://api.github.com/repos/gummiboll/mylg/git/commits{/sha}","comments_url":"https://api.github.com/repos/gummiboll/mylg/comments{/number}","issue_comment_url":"https://api.github.com/repos/gummiboll/mylg/issues/comments{/number}","contents_url":"https://api.github.com/repos/gummiboll/mylg/contents/{+path}","compare_url":"https://api.github.com/repos/gummiboll/mylg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gummiboll/mylg/merges","archive_url":"https://api.github.com/repos/gummiboll/mylg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gummiboll/mylg/downloads","issues_url":"https://api.github.com/repos/gummiboll/mylg/issues{/number}","pulls_url":"https://api.github.com/repos/gummiboll/mylg/pulls{/number}","milestones_url":"https://api.github.com/repos/gummiboll/mylg/milestones{/number}","notifications_url":"https://api.github.com/repos/gummiboll/mylg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gummiboll/mylg/labels{/name}","releases_url":"https://api.github.com/repos/gummiboll/mylg/releases{/id}","deployments_url":"https://api.github.com/repos/gummiboll/mylg/deployments","created_at":"2016-08-26T11:45:39Z","updated_at":"2016-08-26T11:45:41Z","pushed_at":"2016-09-01T18:32:35Z","git_url":"git://github.com/gummiboll/mylg.git","ssh_url":"git@github.com:gummiboll/mylg.git","clone_url":"https://github.com/gummiboll/mylg.git","svn_url":"https://github.com/gummiboll/mylg","homepage":"http://mylg.io","size":843,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mehrdadrad:master","ref":"master","sha":"8566e8414352c995a8775ee9139ee9afc3b726dd","user":{"login":"mehrdadrad","id":13306113,"avatar_url":"https://avatars.githubusercontent.com/u/13306113?v=3","gravatar_id":"","url":"https://api.github.com/users/mehrdadrad","html_url":"https://github.com/mehrdadrad","followers_url":"https://api.github.com/users/mehrdadrad/followers","following_url":"https://api.github.com/users/mehrdadrad/following{/other_user}","gists_url":"https://api.github.com/users/mehrdadrad/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdadrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdadrad/subscriptions","organizations_url":"https://api.github.com/users/mehrdadrad/orgs","repos_url":"https://api.github.com/users/mehrdadrad/repos","events_url":"https://api.github.com/users/mehrdadrad/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdadrad/received_events","type":"User","site_admin":false},"repo":{"id":61661892,"name":"mylg","full_name":"mehrdadrad/mylg","owner":{"login":"mehrdadrad","id":13306113,"avatar_url":"https://avatars.githubusercontent.com/u/13306113?v=3","gravatar_id":"","url":"https://api.github.com/users/mehrdadrad","html_url":"https://github.com/mehrdadrad","followers_url":"https://api.github.com/users/mehrdadrad/followers","following_url":"https://api.github.com/users/mehrdadrad/following{/other_user}","gists_url":"https://api.github.com/users/mehrdadrad/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdadrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdadrad/subscriptions","organizations_url":"https://api.github.com/users/mehrdadrad/orgs","repos_url":"https://api.github.com/users/mehrdadrad/repos","events_url":"https://api.github.com/users/mehrdadrad/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdadrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mehrdadrad/mylg","description":"Network Diagnostic Tool","fork":false,"url":"https://api.github.com/repos/mehrdadrad/mylg","forks_url":"https://api.github.com/repos/mehrdadrad/mylg/forks","keys_url":"https://api.github.com/repos/mehrdadrad/mylg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mehrdadrad/mylg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mehrdadrad/mylg/teams","hooks_url":"https://api.github.com/repos/mehrdadrad/mylg/hooks","issue_events_url":"https://api.github.com/repos/mehrdadrad/mylg/issues/events{/number}","events_url":"https://api.github.com/repos/mehrdadrad/mylg/events","assignees_url":"https://api.github.com/repos/mehrdadrad/mylg/assignees{/user}","branches_url":"https://api.github.com/repos/mehrdadrad/mylg/branches{/branch}","tags_url":"https://api.github.com/repos/mehrdadrad/mylg/tags","blobs_url":"https://api.github.com/repos/mehrdadrad/mylg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mehrdadrad/mylg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mehrdadrad/mylg/git/refs{/sha}","trees_url":"https://api.github.com/repos/mehrdadrad/mylg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mehrdadrad/mylg/statuses/{sha}","languages_url":"https://api.github.com/repos/mehrdadrad/mylg/languages","stargazers_url":"https://api.github.com/repos/mehrdadrad/mylg/stargazers","contributors_url":"https://api.github.com/repos/mehrdadrad/mylg/contributors","subscribers_url":"https://api.github.com/repos/mehrdadrad/mylg/subscribers","subscription_url":"https://api.github.com/repos/mehrdadrad/mylg/subscription","commits_url":"https://api.github.com/repos/mehrdadrad/mylg/commits{/sha}","git_commits_url":"https://api.github.com/repos/mehrdadrad/mylg/git/commits{/sha}","comments_url":"https://api.github.com/repos/mehrdadrad/mylg/comments{/number}","issue_comment_url":"https://api.github.com/repos/mehrdadrad/mylg/issues/comments{/number}","contents_url":"https://api.github.com/repos/mehrdadrad/mylg/contents/{+path}","compare_url":"https://api.github.com/repos/mehrdadrad/mylg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mehrdadrad/mylg/merges","archive_url":"https://api.github.com/repos/mehrdadrad/mylg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mehrdadrad/mylg/downloads","issues_url":"https://api.github.com/repos/mehrdadrad/mylg/issues{/number}","pulls_url":"https://api.github.com/repos/mehrdadrad/mylg/pulls{/number}","milestones_url":"https://api.github.com/repos/mehrdadrad/mylg/milestones{/number}","notifications_url":"https://api.github.com/repos/mehrdadrad/mylg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mehrdadrad/mylg/labels{/name}","releases_url":"https://api.github.com/repos/mehrdadrad/mylg/releases{/id}","deployments_url":"https://api.github.com/repos/mehrdadrad/mylg/deployments","created_at":"2016-06-21T19:39:58Z","updated_at":"2016-09-01T13:50:30Z","pushed_at":"2016-08-31T20:57:55Z","git_url":"git://github.com/mehrdadrad/mylg.git","ssh_url":"git@github.com:mehrdadrad/mylg.git","clone_url":"https://github.com/mehrdadrad/mylg.git","svn_url":"https://github.com/mehrdadrad/mylg","homepage":"http://mylg.io","size":1022,"stargazers_count":758,"watchers_count":758,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":1,"forks":27,"open_issues":1,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11"},"html":{"href":"https://github.com/mehrdadrad/mylg/pull/11"},"issue":{"href":"https://api.github.com/repos/mehrdadrad/mylg/issues/11"},"comments":{"href":"https://api.github.com/repos/mehrdadrad/mylg/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/mehrdadrad/mylg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mehrdadrad/mylg/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/mehrdadrad/mylg/statuses/16463ef47b98b959f66f4ba6a687ec8bcceb4d90"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":14,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"gummiboll"}}