{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/15153","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/15153/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/15153/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/15153/events","html_url":"https://github.com/guardian/frontend/pull/15153","id":192332862,"number":15153,"title":"Caption competition","user":{"login":"zeftilldeath","id":14570016,"avatar_url":"https://avatars.githubusercontent.com/u/14570016?v=3","gravatar_id":"","url":"https://api.github.com/users/zeftilldeath","html_url":"https://github.com/zeftilldeath","followers_url":"https://api.github.com/users/zeftilldeath/followers","following_url":"https://api.github.com/users/zeftilldeath/following{/other_user}","gists_url":"https://api.github.com/users/zeftilldeath/gists{/gist_id}","starred_url":"https://api.github.com/users/zeftilldeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeftilldeath/subscriptions","organizations_url":"https://api.github.com/users/zeftilldeath/orgs","repos_url":"https://api.github.com/users/zeftilldeath/repos","events_url":"https://api.github.com/users/zeftilldeath/events{/privacy}","received_events_url":"https://api.github.com/users/zeftilldeath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-29T16:37:22Z","updated_at":"2016-11-29T17:00:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/15153","html_url":"https://github.com/guardian/frontend/pull/15153","diff_url":"https://github.com/guardian/frontend/pull/15153.diff","patch_url":"https://github.com/guardian/frontend/pull/15153.patch"},"body":"## What does this change?\r\nTo indicate a caption we have used a camera icon/video icon or no icon. @paperboyo once correctly pointed out how odd it is that we use a camera icon to signify an illustration credit or copyright. Instead I have standardised them all with a universal '_i_' icon. Understood as meaning information. \r\n\r\n## What is the value of this and can you measure success?\r\nLike the majority of my PRs the value is immeasurable.\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNah. But we should update the apps icon too. \r\n\r\n## Screenshots\r\n\r\nClose up:\r\n![screen shot 2016-11-29 at 14 03 03](https://cloud.githubusercontent.com/assets/14570016/20718531/f0d496dc-b650-11e6-9945-889ef8dd4788.png)\r\n\r\nHeader test variants:\r\n![screen shot 2016-11-29 at 15 11 13](https://cloud.githubusercontent.com/assets/14570016/20718532/f0d67ccc-b650-11e6-9a80-0489f5925f0f.png)\r\n\r\nNormal usage:\r\n![screen shot 2016-11-29 at 15 17 28](https://cloud.githubusercontent.com/assets/14570016/20718534/f0d82a2c-b650-11e6-889c-c5269c6e6cd0.png)\r\n\r\nMedia tone:\r\n![screen shot 2016-11-29 at 16 20 49](https://cloud.githubusercontent.com/assets/14570016/20718533/f0d70002-b650-11e6-9f22-3f0b25b78e6c.png)\r\n\r\nHosted content:\r\n![screen shot 2016-11-29 at 16 25 59](https://cloud.githubusercontent.com/assets/14570016/20718603/33caa56c-b651-11e6-879f-d6ee9fa45f0f.png)\r\n\r\nVideo caption:\r\n![screen shot 2016-11-29 at 16 31 19](https://cloud.githubusercontent.com/assets/14570016/20718642/49181f6c-b651-11e6-820e-7ba2a0de665d.png)\r\n\r\n\r\n## Request for comment\r\n@gtrufitt I bet you'd love to look at this. Have I forgotten anywhere?"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/263630613","html_url":"https://github.com/guardian/frontend/pull/15153#issuecomment-263630613","issue_url":"https://api.github.com/repos/guardian/frontend/issues/15153","id":263630613,"user":{"login":"zeftilldeath","id":14570016,"avatar_url":"https://avatars.githubusercontent.com/u/14570016?v=3","gravatar_id":"","url":"https://api.github.com/users/zeftilldeath","html_url":"https://github.com/zeftilldeath","followers_url":"https://api.github.com/users/zeftilldeath/followers","following_url":"https://api.github.com/users/zeftilldeath/following{/other_user}","gists_url":"https://api.github.com/users/zeftilldeath/gists{/gist_id}","starred_url":"https://api.github.com/users/zeftilldeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeftilldeath/subscriptions","organizations_url":"https://api.github.com/users/zeftilldeath/orgs","repos_url":"https://api.github.com/users/zeftilldeath/repos","events_url":"https://api.github.com/users/zeftilldeath/events{/privacy}","received_events_url":"https://api.github.com/users/zeftilldeath/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T17:00:51Z","updated_at":"2016-11-29T17:00:51Z","body":"@paperboyo Going to swap the lightbox example to italic. And yeah it's DE5.\r\n\r\nCurrently, video caption do not have an icon at all. With regards to legibility, I'd rather have an _arguably_ legible icon than one that makes no sense but it clear. \r\n\r\nYep Apps will need to follow suit if this goes out. "}}
{"actor":{"display_login":"zeftilldeath"}}