{"action":"created","issue":{"url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/524","repository_url":"https://api.github.com/repos/vitalets/angular-xeditable","labels_url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/524/labels{/name}","comments_url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/524/comments","events_url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/524/events","html_url":"https://github.com/vitalets/angular-xeditable/issues/524","id":173236773,"number":524,"title":"is jquery an extra dependency?","user":{"login":"spanevin","id":1267310,"avatar_url":"https://avatars.githubusercontent.com/u/1267310?v=3","gravatar_id":"","url":"https://api.github.com/users/spanevin","html_url":"https://github.com/spanevin","followers_url":"https://api.github.com/users/spanevin/followers","following_url":"https://api.github.com/users/spanevin/following{/other_user}","gists_url":"https://api.github.com/users/spanevin/gists{/gist_id}","starred_url":"https://api.github.com/users/spanevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spanevin/subscriptions","organizations_url":"https://api.github.com/users/spanevin/orgs","repos_url":"https://api.github.com/users/spanevin/repos","events_url":"https://api.github.com/users/spanevin/events{/privacy}","received_events_url":"https://api.github.com/users/spanevin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-25T15:35:26Z","updated_at":"2016-08-26T06:26:18Z","closed_at":null,"body":"https://vitalets.github.io/angular-xeditable/ says that it does not depend on anything except angularjs itself. But...\r\nhttps://github.com/vitalets/angular-xeditable/blob/master/package.json\r\n\r\n22   \"dependencies\": { \r\n23     \"angular\": \"~1.x\", \r\n24     \"bootstrap\": \"^3.1.1\", \r\n25     \"jquery\": \"^1.11.1\", \r\n26     \"moment\": \"^2.5.0\" \r\n27   }, \r\n\r\nDo we really need all this stuff? Why it doesn't correspond to main site description? It would be great if jquery and other stuff is removed or is made optional."},"comment":{"url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/comments/242640793","html_url":"https://github.com/vitalets/angular-xeditable/issues/524#issuecomment-242640793","issue_url":"https://api.github.com/repos/vitalets/angular-xeditable/issues/524","id":242640793,"user":{"login":"spanevin","id":1267310,"avatar_url":"https://avatars.githubusercontent.com/u/1267310?v=3","gravatar_id":"","url":"https://api.github.com/users/spanevin","html_url":"https://github.com/spanevin","followers_url":"https://api.github.com/users/spanevin/followers","following_url":"https://api.github.com/users/spanevin/following{/other_user}","gists_url":"https://api.github.com/users/spanevin/gists{/gist_id}","starred_url":"https://api.github.com/users/spanevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spanevin/subscriptions","organizations_url":"https://api.github.com/users/spanevin/orgs","repos_url":"https://api.github.com/users/spanevin/repos","events_url":"https://api.github.com/users/spanevin/events{/privacy}","received_events_url":"https://api.github.com/users/spanevin/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T06:26:18Z","updated_at":"2016-08-26T06:26:18Z","body":"I removed angular and moment from dependencies, killed these packages and did recompilation. Result scripts are the same as before. So, I don't see any reason of pulling these packages along with angular-xeditable package. Please remove these dependencies from package.json, dependencies section. I believe that bootstrap can be removed too.\r\nActually I see optionalDependencies section in the package.json, shouldn't it be declared here? According to project home page, the only required dependency is angular, and there are some optional, like angular-ui bootstrap and ui-select. Nothing is said about jquery and moment at all."}}
{"actor":{"display_login":"spanevin"}}