{"push_id":1154269600,"size":9,"distinct_size":0,"ref":"refs/heads/jk/ident","head":"dbe5da586b47efe0d3323dc461cf20b74c492fea","before":"9fb119999bc2e350b93dc13b5366db34a21be255","commits":[{"sha":"d2554c7207896136ad2033776efd29578592a3fb","author":{"name":"Jeff King","email":"7e57302763bea699aee296fb53304dc616ab92d5@peff.net"},"message":"test-lib: add in-shell \"env\" replacement\n\nThe one-shot environment variable syntax:\n\n  FOO=BAR some-program\n\nis unportable when some-program is actually a shell\nfunction, like test_must_fail (on some shells FOO remains\nset after the function returns, and on others it does not).\n\nWe sometimes get around this by using env, like:\n\n  test_must_fail env FOO=BAR some-program\n\nBut that only works because test_must_fail's arguments are\nthemselves a command which can be run. You can't run:\n\n  env FOO=BAR test_must_fail some-program\n\nbecause env does not know about our shell functions. So\nthere is no equivalent for test_commit, for example, and one\nmust resort to:\n\n  (\n    FOO=BAR\n    export FOO\n    test_commit\n  )\n\nwhich is a bit verbose.  Let's add a version of \"env\" that\nworks _inside_ the shell, by creating a subshell, exporting\nvariables from its argument list, and running the command.\n\nIts use is demonstrated on a currently-unportable case in\nt4014.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/d2554c7207896136ad2033776efd29578592a3fb"},{"sha":"e256eec79d375649ecda7cc21b527386898794a4","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"t5500 & t7403: lose bash-ism \"local\"\n\nIn t5500::check_prot_host_port_path(), diagport is not a variable\nused elsewhere and the function is not recursively called so this\ncan simply lose the \"local\", which may not be supported by shell\n(besides, the function liberally clobbers other variables without\nmaking them \"local\").\n\nt7403::reset_submodule_urls() overrides the \"root\" variable used\nin the test framework for no good reason; its use is not about\ntemporarily relocating where the test repositories are created.\nThis assignment can be made not to clobber the variable by moving\nthem into the subshells it already uses.  Its value is always\n$TRASH_DIRECTORY, so we could use it instead there, and this\nfunction that is called only once and its two subshells may not be\nnecessary (instead, the caller can use \"git -C $there config\" and\nset a value that is derived from $TRASH_DIRECTORY), but this is a\nminimum fix that is needed to lose \"local\".\n\nHelped-by: John Keeping <john@keeping.me.uk>\nHelped-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/e256eec79d375649ecda7cc21b527386898794a4"},{"sha":"fe17fc0006927246c5905ef9352e7e89a3c5814b","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"t2300: run git-sh-setup in an environment that better mimics the real life\n\nWhen we run scripted Porcelains, \"git\" potty has set up the $PATH by\nprepending $GIT_EXEC_PATH, the path given by \"git --exec-path=$there\n$cmd\", etc. already.  Because of this, scripted Porcelains can\ndot-source shell script library like git-sh-setup with simple dot\nwithout specifying any path.\n\nt2300 however dot-sources git-sh-setup without adjusting $PATH like\nthe real \"git\" potty does.  This has not been a problem so far, but\nonce git-sh-setup wants to rely on the $PATH adjustment, just like\nany scripted Porcelains already do, it would become one.  It cannot\nfor example dot-source another shell library without specifying the\nfull path to it by prefixing $(git --exec-path).\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/fe17fc0006927246c5905ef9352e7e89a3c5814b"},{"sha":"5580b271af518bae30148edfd42cc8459d8da384","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"diff: disable compaction heuristic for now\n\nhttp://lkml.kernel.org/g/20160610075043.GA13411@sigill.intra.peff.net\nreports that a change to add a new \"function\" with common ending\nwith the existing one at the end of the file is shown like this:\n\n    def foo\n      do_foo_stuff()\n\n   +  common_ending()\n   +end\n   +\n   +def bar\n   +  do_bar_stuff()\n   +\n      common_ending()\n    end\n\nwhen the new heuristic is in use.  In reality, the change is to add\nthe blank line before \"def bar\" and everything below, which is what\nthe code without the new heuristic shows.\n\nDisable the heuristics by default, and resurrect the documentation\nfor the option and the configuration variables, while clearly\nmarking the feature as still experimental.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/5580b271af518bae30148edfd42cc8459d8da384"},{"sha":"8ffc9d26e41f1ce23acbaee0f14419d99677b5f9","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"Merge branch 'jc/t2300-setup'\n\nA test fix.\n\n* jc/t2300-setup:\n  t2300: run git-sh-setup in an environment that better mimics the real life","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/8ffc9d26e41f1ce23acbaee0f14419d99677b5f9"},{"sha":"45c0c21eb96ce45f05ffbe8600adf6ac65086415","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"Merge branch 'jk/shell-portability'\n\ntest fixes.\n\n* jk/shell-portability:\n  t5500 & t7403: lose bash-ism \"local\"\n  test-lib: add in-shell \"env\" replacement","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/45c0c21eb96ce45f05ffbe8600adf6ac65086415"},{"sha":"e5f767554404592cf65e7c49b3594b195a324031","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"Merge branch 'jk/diff-compact-heuristic'\n\nIt turns out that the earlier effort to update the heuristics may\nwant to use a bit more time to mature.  Turn it off by default.\n\n* jk/diff-compact-heuristic:\n  diff: disable compaction heuristic for now","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/e5f767554404592cf65e7c49b3594b195a324031"},{"sha":"a28705da929ad746abcb34270947f738549d3246","author":{"name":"Junio C Hamano","email":"3228067b6039a0d99bddaf967dafdecd5cc61600@pobox.com"},"message":"Hopefully the final last-minute update before 2.9 final\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/a28705da929ad746abcb34270947f738549d3246"},{"sha":"dbe5da586b47efe0d3323dc461cf20b74c492fea","author":{"name":"Jeff King","email":"7e57302763bea699aee296fb53304dc616ab92d5@peff.net"},"message":"commit: give a hint when a commit message has been abandoned\n\nIf we launch an editor for the user to create a commit\nmessage, they may put significant work into doing so.\nTypically we try to check common mistakes that could cause\nthe commit to fail early, so that we die before the user\ngoes to the trouble.\n\nWe may still experience some errors afterwards, though; in\nthis case, the user is given no hint that their commit\nmessage has been saved. Let's tell them where it is.\n\nSigned-off-by: Jeff King <peff@peff.net>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/dbe5da586b47efe0d3323dc461cf20b74c492fea"}]}
{"actor":{"display_login":"peff"}}