{"action":"closed","number":1072,"pull_request":{"url":"https://api.github.com/repos/pimcore/pimcore/pulls/1072","id":95021851,"html_url":"https://github.com/pimcore/pimcore/pull/1072","diff_url":"https://github.com/pimcore/pimcore/pull/1072.diff","patch_url":"https://github.com/pimcore/pimcore/pull/1072.patch","issue_url":"https://api.github.com/repos/pimcore/pimcore/issues/1072","number":1072,"state":"closed","locked":false,"title":"Removed unnecessary if-condition in Frontend Router","user":{"login":"d-gerken","id":19686822,"avatar_url":"https://avatars.githubusercontent.com/u/19686822?v=3","gravatar_id":"","url":"https://api.github.com/users/d-gerken","html_url":"https://github.com/d-gerken","followers_url":"https://api.github.com/users/d-gerken/followers","following_url":"https://api.github.com/users/d-gerken/following{/other_user}","gists_url":"https://api.github.com/users/d-gerken/gists{/gist_id}","starred_url":"https://api.github.com/users/d-gerken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-gerken/subscriptions","organizations_url":"https://api.github.com/users/d-gerken/orgs","repos_url":"https://api.github.com/users/d-gerken/repos","events_url":"https://api.github.com/users/d-gerken/events{/privacy}","received_events_url":"https://api.github.com/users/d-gerken/received_events","type":"User","site_admin":false},"body":"## Changes in this pull request  \r\n- Removed a not needed if condition in Frontend Router\r\n\r\n## Additional info  \r\nIn Line 94 $matchFound is set to false and until line 148 it can't be set to another value. checkForRedirect will be always executed. So the if condition is not necessarily.\r\n","created_at":"2016-11-23T15:13:58Z","updated_at":"2016-11-23T15:21:24Z","closed_at":"2016-11-23T15:21:24Z","merged_at":"2016-11-23T15:21:24Z","merge_commit_sha":"ec324ad60bee3d8d0e20eac61d7dc0607e200a57","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pimcore/pimcore/pulls/1072/commits","review_comments_url":"https://api.github.com/repos/pimcore/pimcore/pulls/1072/comments","review_comment_url":"https://api.github.com/repos/pimcore/pimcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pimcore/pimcore/issues/1072/comments","statuses_url":"https://api.github.com/repos/pimcore/pimcore/statuses/7ba56eb4bf6cc1153a2c2202f8604d1854d23355","head":{"label":"d-gerken:feature/optimization","ref":"feature/optimization","sha":"7ba56eb4bf6cc1153a2c2202f8604d1854d23355","user":{"login":"d-gerken","id":19686822,"avatar_url":"https://avatars.githubusercontent.com/u/19686822?v=3","gravatar_id":"","url":"https://api.github.com/users/d-gerken","html_url":"https://github.com/d-gerken","followers_url":"https://api.github.com/users/d-gerken/followers","following_url":"https://api.github.com/users/d-gerken/following{/other_user}","gists_url":"https://api.github.com/users/d-gerken/gists{/gist_id}","starred_url":"https://api.github.com/users/d-gerken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-gerken/subscriptions","organizations_url":"https://api.github.com/users/d-gerken/orgs","repos_url":"https://api.github.com/users/d-gerken/repos","events_url":"https://api.github.com/users/d-gerken/events{/privacy}","received_events_url":"https://api.github.com/users/d-gerken/received_events","type":"User","site_admin":false},"repo":{"id":74586755,"name":"pimcore","full_name":"d-gerken/pimcore","owner":{"login":"d-gerken","id":19686822,"avatar_url":"https://avatars.githubusercontent.com/u/19686822?v=3","gravatar_id":"","url":"https://api.github.com/users/d-gerken","html_url":"https://github.com/d-gerken","followers_url":"https://api.github.com/users/d-gerken/followers","following_url":"https://api.github.com/users/d-gerken/following{/other_user}","gists_url":"https://api.github.com/users/d-gerken/gists{/gist_id}","starred_url":"https://api.github.com/users/d-gerken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-gerken/subscriptions","organizations_url":"https://api.github.com/users/d-gerken/orgs","repos_url":"https://api.github.com/users/d-gerken/repos","events_url":"https://api.github.com/users/d-gerken/events{/privacy}","received_events_url":"https://api.github.com/users/d-gerken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-gerken/pimcore","description":"Content & Product Management Framework (CMS/PIM/E-Commerce)","fork":true,"url":"https://api.github.com/repos/d-gerken/pimcore","forks_url":"https://api.github.com/repos/d-gerken/pimcore/forks","keys_url":"https://api.github.com/repos/d-gerken/pimcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-gerken/pimcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-gerken/pimcore/teams","hooks_url":"https://api.github.com/repos/d-gerken/pimcore/hooks","issue_events_url":"https://api.github.com/repos/d-gerken/pimcore/issues/events{/number}","events_url":"https://api.github.com/repos/d-gerken/pimcore/events","assignees_url":"https://api.github.com/repos/d-gerken/pimcore/assignees{/user}","branches_url":"https://api.github.com/repos/d-gerken/pimcore/branches{/branch}","tags_url":"https://api.github.com/repos/d-gerken/pimcore/tags","blobs_url":"https://api.github.com/repos/d-gerken/pimcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-gerken/pimcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-gerken/pimcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-gerken/pimcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-gerken/pimcore/statuses/{sha}","languages_url":"https://api.github.com/repos/d-gerken/pimcore/languages","stargazers_url":"https://api.github.com/repos/d-gerken/pimcore/stargazers","contributors_url":"https://api.github.com/repos/d-gerken/pimcore/contributors","subscribers_url":"https://api.github.com/repos/d-gerken/pimcore/subscribers","subscription_url":"https://api.github.com/repos/d-gerken/pimcore/subscription","commits_url":"https://api.github.com/repos/d-gerken/pimcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-gerken/pimcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-gerken/pimcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-gerken/pimcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-gerken/pimcore/contents/{+path}","compare_url":"https://api.github.com/repos/d-gerken/pimcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-gerken/pimcore/merges","archive_url":"https://api.github.com/repos/d-gerken/pimcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-gerken/pimcore/downloads","issues_url":"https://api.github.com/repos/d-gerken/pimcore/issues{/number}","pulls_url":"https://api.github.com/repos/d-gerken/pimcore/pulls{/number}","milestones_url":"https://api.github.com/repos/d-gerken/pimcore/milestones{/number}","notifications_url":"https://api.github.com/repos/d-gerken/pimcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-gerken/pimcore/labels{/name}","releases_url":"https://api.github.com/repos/d-gerken/pimcore/releases{/id}","deployments_url":"https://api.github.com/repos/d-gerken/pimcore/deployments","created_at":"2016-11-23T14:56:38Z","updated_at":"2016-11-23T14:56:50Z","pushed_at":"2016-11-23T15:06:08Z","git_url":"git://github.com/d-gerken/pimcore.git","ssh_url":"git@github.com:d-gerken/pimcore.git","clone_url":"https://github.com/d-gerken/pimcore.git","svn_url":"https://github.com/d-gerken/pimcore","homepage":"http://www.pimcore.org/","size":332402,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pimcore:master","ref":"master","sha":"63f56f2bfce971dd1adc27a5b692bf62d9069f0e","user":{"login":"pimcore","id":686745,"avatar_url":"https://avatars.githubusercontent.com/u/686745?v=3","gravatar_id":"","url":"https://api.github.com/users/pimcore","html_url":"https://github.com/pimcore","followers_url":"https://api.github.com/users/pimcore/followers","following_url":"https://api.github.com/users/pimcore/following{/other_user}","gists_url":"https://api.github.com/users/pimcore/gists{/gist_id}","starred_url":"https://api.github.com/users/pimcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimcore/subscriptions","organizations_url":"https://api.github.com/users/pimcore/orgs","repos_url":"https://api.github.com/users/pimcore/repos","events_url":"https://api.github.com/users/pimcore/events{/privacy}","received_events_url":"https://api.github.com/users/pimcore/received_events","type":"Organization","site_admin":false},"repo":{"id":2686502,"name":"pimcore","full_name":"pimcore/pimcore","owner":{"login":"pimcore","id":686745,"avatar_url":"https://avatars.githubusercontent.com/u/686745?v=3","gravatar_id":"","url":"https://api.github.com/users/pimcore","html_url":"https://github.com/pimcore","followers_url":"https://api.github.com/users/pimcore/followers","following_url":"https://api.github.com/users/pimcore/following{/other_user}","gists_url":"https://api.github.com/users/pimcore/gists{/gist_id}","starred_url":"https://api.github.com/users/pimcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimcore/subscriptions","organizations_url":"https://api.github.com/users/pimcore/orgs","repos_url":"https://api.github.com/users/pimcore/repos","events_url":"https://api.github.com/users/pimcore/events{/privacy}","received_events_url":"https://api.github.com/users/pimcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pimcore/pimcore","description":"Content & Product Management Framework (CMS/PIM/E-Commerce)","fork":false,"url":"https://api.github.com/repos/pimcore/pimcore","forks_url":"https://api.github.com/repos/pimcore/pimcore/forks","keys_url":"https://api.github.com/repos/pimcore/pimcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pimcore/pimcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pimcore/pimcore/teams","hooks_url":"https://api.github.com/repos/pimcore/pimcore/hooks","issue_events_url":"https://api.github.com/repos/pimcore/pimcore/issues/events{/number}","events_url":"https://api.github.com/repos/pimcore/pimcore/events","assignees_url":"https://api.github.com/repos/pimcore/pimcore/assignees{/user}","branches_url":"https://api.github.com/repos/pimcore/pimcore/branches{/branch}","tags_url":"https://api.github.com/repos/pimcore/pimcore/tags","blobs_url":"https://api.github.com/repos/pimcore/pimcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pimcore/pimcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pimcore/pimcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/pimcore/pimcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pimcore/pimcore/statuses/{sha}","languages_url":"https://api.github.com/repos/pimcore/pimcore/languages","stargazers_url":"https://api.github.com/repos/pimcore/pimcore/stargazers","contributors_url":"https://api.github.com/repos/pimcore/pimcore/contributors","subscribers_url":"https://api.github.com/repos/pimcore/pimcore/subscribers","subscription_url":"https://api.github.com/repos/pimcore/pimcore/subscription","commits_url":"https://api.github.com/repos/pimcore/pimcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/pimcore/pimcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/pimcore/pimcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/pimcore/pimcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/pimcore/pimcore/contents/{+path}","compare_url":"https://api.github.com/repos/pimcore/pimcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pimcore/pimcore/merges","archive_url":"https://api.github.com/repos/pimcore/pimcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pimcore/pimcore/downloads","issues_url":"https://api.github.com/repos/pimcore/pimcore/issues{/number}","pulls_url":"https://api.github.com/repos/pimcore/pimcore/pulls{/number}","milestones_url":"https://api.github.com/repos/pimcore/pimcore/milestones{/number}","notifications_url":"https://api.github.com/repos/pimcore/pimcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pimcore/pimcore/labels{/name}","releases_url":"https://api.github.com/repos/pimcore/pimcore/releases{/id}","deployments_url":"https://api.github.com/repos/pimcore/pimcore/deployments","created_at":"2011-11-01T09:16:14Z","updated_at":"2016-11-22T09:38:37Z","pushed_at":"2016-11-23T15:21:24Z","git_url":"git://github.com/pimcore/pimcore.git","ssh_url":"git@github.com:pimcore/pimcore.git","clone_url":"https://github.com/pimcore/pimcore.git","svn_url":"https://github.com/pimcore/pimcore","homepage":"http://www.pimcore.org/","size":332402,"stargazers_count":600,"watchers_count":600,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":320,"mirror_url":null,"open_issues_count":101,"forks":320,"open_issues":101,"watchers":600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pimcore/pimcore/pulls/1072"},"html":{"href":"https://github.com/pimcore/pimcore/pull/1072"},"issue":{"href":"https://api.github.com/repos/pimcore/pimcore/issues/1072"},"comments":{"href":"https://api.github.com/repos/pimcore/pimcore/issues/1072/comments"},"review_comments":{"href":"https://api.github.com/repos/pimcore/pimcore/pulls/1072/comments"},"review_comment":{"href":"https://api.github.com/repos/pimcore/pimcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pimcore/pimcore/pulls/1072/commits"},"statuses":{"href":"https://api.github.com/repos/pimcore/pimcore/statuses/7ba56eb4bf6cc1153a2c2202f8604d1854d23355"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brusch","id":142037,"avatar_url":"https://avatars.githubusercontent.com/u/142037?v=3","gravatar_id":"","url":"https://api.github.com/users/brusch","html_url":"https://github.com/brusch","followers_url":"https://api.github.com/users/brusch/followers","following_url":"https://api.github.com/users/brusch/following{/other_user}","gists_url":"https://api.github.com/users/brusch/gists{/gist_id}","starred_url":"https://api.github.com/users/brusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brusch/subscriptions","organizations_url":"https://api.github.com/users/brusch/orgs","repos_url":"https://api.github.com/users/brusch/repos","events_url":"https://api.github.com/users/brusch/events{/privacy}","received_events_url":"https://api.github.com/users/brusch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"brusch"}}