{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27020","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27020/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27020/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27020/events","html_url":"https://github.com/kubernetes/kubernetes/pull/27020","id":159059998,"number":27020,"title":"Rename **/manager.go for better logging","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/logging","name":"area/logging","color":"fef2c0"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":182,"closed_issues":530,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-08T21:10:08Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"comments":7,"created_at":"2016-06-08T01:24:10Z","updated_at":"2016-06-08T21:14:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27020","html_url":"https://github.com/kubernetes/kubernetes/pull/27020","diff_url":"https://github.com/kubernetes/kubernetes/pull/27020.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27020.patch"},"body":"Rename `pkg/kubelet/*/manager.go` to `pkg/kubelet/*/*_manager.go`.\r\n\r\n**Justification:** Our current logging library, [glog](https://github.com/golang/glog), logs the filename where the log was generated, but not the full path. Ex:\r\n```\r\nI0608 00:28:25.116905    2847 manager.go:1024] Started watching for new ooms in manager\r\n```\r\nWe have too many files named `manager.go`, which makes it difficult to identify log messages originating from them:\r\n```console\r\n$ find . -name \"manager.go\"\r\n./pkg/kubelet/status/manager.go\r\n./pkg/kubelet/dockertools/manager.go\r\n./pkg/kubelet/eviction/manager.go\r\n./pkg/kubelet/pod/manager.go\r\n./pkg/kubelet/prober/manager.go\r\n./vendor/github.com/vmware/govmomi/session/manager.go\r\n./vendor/github.com/google/cadvisor/manager/manager.go\r\n./vendor/github.com/coreos/go-oidc/key/manager.go\r\n```\r\n\r\n/cc @kubernetes/sig-node This change will probably invoke rebase hell, but now seems like a reasonable time for it (with less churn leading up to release)."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/224730069","html_url":"https://github.com/kubernetes/kubernetes/pull/27020#issuecomment-224730069","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27020","id":224730069,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T21:14:22Z","updated_at":"2016-06-08T21:14:22Z","body":"PR changed after LGTM, removing LGTM."}}
{"actor":{"display_login":"k8s-merge-robot"}}