{"action":"created","issue":{"url":"https://api.github.com/repos/cuberite/cuberite/issues/2986","repository_url":"https://api.github.com/repos/cuberite/cuberite","labels_url":"https://api.github.com/repos/cuberite/cuberite/issues/2986/labels{/name}","comments_url":"https://api.github.com/repos/cuberite/cuberite/issues/2986/comments","events_url":"https://api.github.com/repos/cuberite/cuberite/issues/2986/events","html_url":"https://github.com/cuberite/cuberite/pull/2986","id":131995075,"number":2986,"title":"[Queue approach] Fix entity destruction in unticking chunks","user":{"login":"LogicParrot","id":5030488,"avatar_url":"https://avatars.githubusercontent.com/u/5030488?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicParrot","html_url":"https://github.com/LogicParrot","followers_url":"https://api.github.com/users/LogicParrot/followers","following_url":"https://api.github.com/users/LogicParrot/following{/other_user}","gists_url":"https://api.github.com/users/LogicParrot/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicParrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicParrot/subscriptions","organizations_url":"https://api.github.com/users/LogicParrot/orgs","repos_url":"https://api.github.com/users/LogicParrot/repos","events_url":"https://api.github.com/users/LogicParrot/events{/privacy}","received_events_url":"https://api.github.com/users/LogicParrot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cuberite/cuberite/milestones/20","html_url":"https://github.com/cuberite/cuberite/milestones/Stable%20world%20travel","labels_url":"https://api.github.com/repos/cuberite/cuberite/milestones/20/labels","id":1557646,"number":20,"title":"Stable world travel","description":"World travel should never crash","creator":{"login":"LogicParrot","id":5030488,"avatar_url":"https://avatars.githubusercontent.com/u/5030488?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicParrot","html_url":"https://github.com/LogicParrot","followers_url":"https://api.github.com/users/LogicParrot/followers","following_url":"https://api.github.com/users/LogicParrot/following{/other_user}","gists_url":"https://api.github.com/users/LogicParrot/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicParrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicParrot/subscriptions","organizations_url":"https://api.github.com/users/LogicParrot/orgs","repos_url":"https://api.github.com/users/LogicParrot/repos","events_url":"https://api.github.com/users/LogicParrot/events{/privacy}","received_events_url":"https://api.github.com/users/LogicParrot/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2016-02-02T09:10:22Z","updated_at":"2016-02-11T13:41:54Z","due_on":null,"closed_at":null},"comments":36,"created_at":"2016-02-07T18:25:48Z","updated_at":"2016-02-13T15:02:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/2986","html_url":"https://github.com/cuberite/cuberite/pull/2986","diff_url":"https://github.com/cuberite/cuberite/pull/2986.diff","patch_url":"https://github.com/cuberite/cuberite/pull/2986.patch"},"body":"Closes #2731\r\nCloses #2973\r\n\r\n@tigerw Is that the vision you had in mind?"},"comment":{"url":"https://api.github.com/repos/cuberite/cuberite/issues/comments/183683812","html_url":"https://github.com/cuberite/cuberite/pull/2986#issuecomment-183683812","issue_url":"https://api.github.com/repos/cuberite/cuberite/issues/2986","id":183683812,"user":{"login":"LogicParrot","id":5030488,"avatar_url":"https://avatars.githubusercontent.com/u/5030488?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicParrot","html_url":"https://github.com/LogicParrot","followers_url":"https://api.github.com/users/LogicParrot/followers","following_url":"https://api.github.com/users/LogicParrot/following{/other_user}","gists_url":"https://api.github.com/users/LogicParrot/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicParrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicParrot/subscriptions","organizations_url":"https://api.github.com/users/LogicParrot/orgs","repos_url":"https://api.github.com/users/LogicParrot/repos","events_url":"https://api.github.com/users/LogicParrot/events{/privacy}","received_events_url":"https://api.github.com/users/LogicParrot/received_events","type":"User","site_admin":false},"created_at":"2016-02-13T15:02:28Z","updated_at":"2016-02-13T15:02:28Z","body":"@tigerw Okay.\r\n\r\n> Why does anything need to distinguish between these states?\r\n\r\nActually, we do NOT need to distinguish between teleportation and destruction, and this is why I made this change.\r\n\r\nFor instance, cChunk previously had this: \r\n```\r\nfor each entity\r\n  if not IsDestroyed() then tick\r\n```\r\n\r\nThe problem here is that teleporting entities will get ticked. So I replaced it with\r\n\r\n```\r\nfor each entity\r\n  if IsTicking() then tick\r\n```\r\n\r\n`IsTicking()` plays the role of the previous `!IsDestroyed()`, but now it returns a false for teleporting entities too, not just dying ones. In other words, I eliminated distinguishing between the two states."}}