{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/185","repository_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/185/comments","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/185/events","html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/185","id":191270235,"number":185,"title":"initial draft of keepalive closing","user":{"login":"yschimke","id":231923,"avatar_url":"https://avatars.githubusercontent.com/u/231923?v=3","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-23T13:28:06Z","updated_at":"2016-11-23T13:32:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/185","html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/185","diff_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/185.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/185.patch"},"body":"An initial cut.  I'd be happy to land this with a test and probably a flag for actually closing.\r\n\r\n- should closing be optional behaviour?\r\n- should the acceptable delay be customisable, as opposed to each keepalive period?\r\n- do we need keepalive data to be definable?\r\n- should we check this on clients?\r\n- should server close \r\n- if so, shoudl we use the keepalive time in the setup frame\r\n\r\nTodo\r\n\r\n- Unit tests"},"comment":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/comments/262513127","html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/185#issuecomment-262513127","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/185","id":262513127,"user":{"login":"yschimke","id":231923,"avatar_url":"https://avatars.githubusercontent.com/u/231923?v=3","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T13:32:13Z","updated_at":"2016-11-23T13:32:13Z","body":"cc @lehecka @lexs "}}
{"actor":{"display_login":"yschimke"}}