{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/comments/84879216","pull_request_review_id":5627561,"id":84879216,"diff_hunk":"@@ -1,17 +1,71 @@\n import chai from 'chai'\n import {startQuestionnaire} from '../helpers'\n \n+import PizzaToppingsPage from '../pages/surveys/checkbox_other/0/pizza-toppings.page'\n+import PizzaBasesPage from '../pages/surveys/checkbox_other/0/pizza-bases.page'\n+import CheckboxOtherSummaryPage from '../pages/surveys/checkbox_other/0/checkbox-other-summary.page'\n+\n const expect = chai.expect\n \n describe('Multiple choice \"other\" option', function() {\n \n-  before(function() {\n-    startQuestionnaire('0_checkbox_other.json')\n-  })\n-\n   it('Given an \"other\" option is available, when the user clicks the \"other\" option the other input should be visible', function() {\n+    startQuestionnaire('0_checkbox_other.json')\n     browser.click('[data-qa=\"has-other-option\"]')\n     expect(browser.isVisible('[data-qa=\"other-option\"]')).to.be.true\n   })\n \n+  it('Given a non-mandatory checkbox answer, when the user does not select an option, \"No answer provided\" should be displayed on the summary screen', function() {\n+\n+     // Given\n+     startQuestionnaire('0_checkbox_other.json')\n+\n+     // When\n+     PizzaToppingsPage.submit();\n+     expect(PizzaBasesPage.isVisible()).to.be.true\n+     PizzaBasesPage.setPizzaBase('thin');","path":"tests/functional/spec/multiple-choice-other.spec.js","position":30,"original_position":30,"commit_id":"62f29612e26f38ac27040f0414e05f8d13a10fd7","original_commit_id":"62f29612e26f38ac27040f0414e05f8d13a10fd7","user":{"login":"benjefferies","id":15050019,"avatar_url":"https://avatars.githubusercontent.com/u/15050019?v=3","gravatar_id":"","url":"https://api.github.com/users/benjefferies","html_url":"https://github.com/benjefferies","followers_url":"https://api.github.com/users/benjefferies/followers","following_url":"https://api.github.com/users/benjefferies/following{/other_user}","gists_url":"https://api.github.com/users/benjefferies/gists{/gist_id}","starred_url":"https://api.github.com/users/benjefferies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjefferies/subscriptions","organizations_url":"https://api.github.com/users/benjefferies/orgs","repos_url":"https://api.github.com/users/benjefferies/repos","events_url":"https://api.github.com/users/benjefferies/events{/privacy}","received_events_url":"https://api.github.com/users/benjefferies/received_events","type":"User","site_admin":false},"body":"You could chain submit().setPizzaBase('thin').submit()","created_at":"2016-10-25T11:12:50Z","updated_at":"2016-10-25T11:36:00Z","html_url":"https://github.com/ONSdigital/eq-survey-runner/pull/521#discussion_r84879216","pull_request_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/comments/84879216"},"html":{"href":"https://github.com/ONSdigital/eq-survey-runner/pull/521#discussion_r84879216"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521","id":90640552,"html_url":"https://github.com/ONSdigital/eq-survey-runner/pull/521","diff_url":"https://github.com/ONSdigital/eq-survey-runner/pull/521.diff","patch_url":"https://github.com/ONSdigital/eq-survey-runner/pull/521.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/521","number":521,"state":"open","locked":false,"title":"Fix issue #514 checkbox with no answer blank on summary.","user":{"login":"samiwel","id":4097796,"avatar_url":"https://avatars.githubusercontent.com/u/4097796?v=3","gravatar_id":"","url":"https://api.github.com/users/samiwel","html_url":"https://github.com/samiwel","followers_url":"https://api.github.com/users/samiwel/followers","following_url":"https://api.github.com/users/samiwel/following{/other_user}","gists_url":"https://api.github.com/users/samiwel/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwel/subscriptions","organizations_url":"https://api.github.com/users/samiwel/orgs","repos_url":"https://api.github.com/users/samiwel/repos","events_url":"https://api.github.com/users/samiwel/events{/privacy}","received_events_url":"https://api.github.com/users/samiwel/received_events","type":"User","site_admin":false},"body":"### What is the context of this PR?\r\nFixes #514 \r\nCorrected logic which sets the other value on the widget.\r\nFixed issue in the Jinja template where a check was being made to see if the answer was None.\r\nAlso added some unit tests around this functionality and a few selenium tests to cover the various scenarios for selecting the \"Other\" option on the checkbox question.\r\n\r\n### How to review \r\nStart 0_checkbox_other.json\r\nDon't select any answers to the checkbox question (first question)\r\nNavigate to the summary screen and observe that the answer is \"No answer provided\".\r\n\r\n","created_at":"2016-10-24T15:52:09Z","updated_at":"2016-10-25T11:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"448a6ab5f21fa9e385b59fea346daeef0a2c24ae","assignee":{"login":"ajmaddaford","id":1754822,"avatar_url":"https://avatars.githubusercontent.com/u/1754822?v=3","gravatar_id":"","url":"https://api.github.com/users/ajmaddaford","html_url":"https://github.com/ajmaddaford","followers_url":"https://api.github.com/users/ajmaddaford/followers","following_url":"https://api.github.com/users/ajmaddaford/following{/other_user}","gists_url":"https://api.github.com/users/ajmaddaford/gists{/gist_id}","starred_url":"https://api.github.com/users/ajmaddaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajmaddaford/subscriptions","organizations_url":"https://api.github.com/users/ajmaddaford/orgs","repos_url":"https://api.github.com/users/ajmaddaford/repos","events_url":"https://api.github.com/users/ajmaddaford/events{/privacy}","received_events_url":"https://api.github.com/users/ajmaddaford/received_events","type":"User","site_admin":false},"assignees":[{"login":"ajmaddaford","id":1754822,"avatar_url":"https://avatars.githubusercontent.com/u/1754822?v=3","gravatar_id":"","url":"https://api.github.com/users/ajmaddaford","html_url":"https://github.com/ajmaddaford","followers_url":"https://api.github.com/users/ajmaddaford/followers","following_url":"https://api.github.com/users/ajmaddaford/following{/other_user}","gists_url":"https://api.github.com/users/ajmaddaford/gists{/gist_id}","starred_url":"https://api.github.com/users/ajmaddaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajmaddaford/subscriptions","organizations_url":"https://api.github.com/users/ajmaddaford/orgs","repos_url":"https://api.github.com/users/ajmaddaford/repos","events_url":"https://api.github.com/users/ajmaddaford/events{/privacy}","received_events_url":"https://api.github.com/users/ajmaddaford/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/521/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/statuses/62f29612e26f38ac27040f0414e05f8d13a10fd7","head":{"label":"ONSdigital:fix-checkbox-no-answer-summary","ref":"fix-checkbox-no-answer-summary","sha":"62f29612e26f38ac27040f0414e05f8d13a10fd7","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":49205589,"name":"eq-survey-runner","full_name":"ONSdigital/eq-survey-runner","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-survey-runner","description":"eQ Survey Runner","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner","forks_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/deployments","created_at":"2016-01-07T13:15:26Z","updated_at":"2016-10-24T10:17:57Z","pushed_at":"2016-10-25T11:02:56Z","git_url":"git://github.com/ONSdigital/eq-survey-runner.git","ssh_url":"git@github.com:ONSdigital/eq-survey-runner.git","clone_url":"https://github.com/ONSdigital/eq-survey-runner.git","svn_url":"https://github.com/ONSdigital/eq-survey-runner","homepage":null,"size":7621,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":3,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"b9b82d14406a662b6c8bede15bc3ee72e18347c4","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":49205589,"name":"eq-survey-runner","full_name":"ONSdigital/eq-survey-runner","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-survey-runner","description":"eQ Survey Runner","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner","forks_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/deployments","created_at":"2016-01-07T13:15:26Z","updated_at":"2016-10-24T10:17:57Z","pushed_at":"2016-10-25T11:02:56Z","git_url":"git://github.com/ONSdigital/eq-survey-runner.git","ssh_url":"git@github.com:ONSdigital/eq-survey-runner.git","clone_url":"https://github.com/ONSdigital/eq-survey-runner.git","svn_url":"https://github.com/ONSdigital/eq-survey-runner","homepage":null,"size":7621,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521"},"html":{"href":"https://github.com/ONSdigital/eq-survey-runner/pull/521"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/521"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-survey-runner/statuses/62f29612e26f38ac27040f0414e05f8d13a10fd7"}}}}
{"actor":{"display_login":"benjefferies"}}