{"comment":{"url":"https://api.github.com/repos/Teradata/presto/comments/15372242","html_url":"https://github.com/Teradata/presto/commit/b275dfd4adbc02920f91dbaf2c1f496e946a2c04#commitcomment-15372242","id":15372242,"user":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars.githubusercontent.com/u/8957547?v=3","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"position":45,"line":107,"path":"presto-spi/src/main/java/com/facebook/presto/spi/type/TypeSignature.java","commit_id":"b275dfd4adbc02920f91dbaf2c1f496e946a2c04","created_at":"2016-01-11T15:14:11Z","updated_at":"2016-01-11T15:14:11Z","body":"I'm squashing this commit with `add explicit literalParameters`, there this method is required.\r\n\r\nWhat do you mean by \"type variables\"? Like `X` would be a type variable in `array(X)`? Then no. `templateLiteralParameters` is to recognize that in `varchar(x)` \"x\" is a TypeLiteralCalculation (check method `parseTypeSignatureParameter`). For me `typeVariableNames` implies this first one, so I suggest renaming this variable to `literalCalculationVariables`. Is it ok for you?"}}