{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/11698","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/11698/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/11698/comments","events_url":"https://api.github.com/repos/servo/servo/issues/11698/events","html_url":"https://github.com/servo/servo/pull/11698","id":159575962,"number":11698,"title":"Excise SubpageId and use only PipelineIds","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-06-10T07:33:03Z","updated_at":"2016-06-10T23:33:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11698","html_url":"https://github.com/servo/servo/pull/11698","diff_url":"https://github.com/servo/servo/pull/11698.diff","patch_url":"https://github.com/servo/servo/pull/11698.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nSubpageId was originally introduced in 2013 to help iframes keep track of\r\ntheir associated (children) pipelines. However, since each pipeline\r\nalready has a PipelineId, and those are unique, those are sufficient\r\nto keep track of children.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #11694  (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [X] These changes do not require tests because refactoring\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11698)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/225319677","html_url":"https://github.com/servo/servo/pull/11698#issuecomment-225319677","issue_url":"https://api.github.com/repos/servo/servo/issues/11698","id":225319677,"user":{"login":"ConnorGBrewster","id":9086315,"avatar_url":"https://avatars.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorGBrewster","html_url":"https://github.com/ConnorGBrewster","followers_url":"https://api.github.com/users/ConnorGBrewster/followers","following_url":"https://api.github.com/users/ConnorGBrewster/following{/other_user}","gists_url":"https://api.github.com/users/ConnorGBrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorGBrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorGBrewster/subscriptions","organizations_url":"https://api.github.com/users/ConnorGBrewster/orgs","repos_url":"https://api.github.com/users/ConnorGBrewster/repos","events_url":"https://api.github.com/users/ConnorGBrewster/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorGBrewster/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T23:33:56Z","updated_at":"2016-06-10T23:33:56Z","body":"Would it be possible to get rid of the `(PipelineId, PipelineId)`s?"}}
{"actor":{"display_login":"ConnorGBrewster"}}