{"action":"closed","number":643,"pull_request":{"url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643","id":64044831,"html_url":"https://github.com/ResearchKit/ResearchKit/pull/643","diff_url":"https://github.com/ResearchKit/ResearchKit/pull/643.diff","patch_url":"https://github.com/ResearchKit/ResearchKit/pull/643.patch","issue_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/643","number":643,"state":"closed","locked":false,"title":"[ORKAnswerFormat] Implement picker-based 'ORKHeightAnswerFormat'","user":{"login":"rsanchezsaez","id":444313,"avatar_url":"https://avatars.githubusercontent.com/u/444313?v=3","gravatar_id":"","url":"https://api.github.com/users/rsanchezsaez","html_url":"https://github.com/rsanchezsaez","followers_url":"https://api.github.com/users/rsanchezsaez/followers","following_url":"https://api.github.com/users/rsanchezsaez/following{/other_user}","gists_url":"https://api.github.com/users/rsanchezsaez/gists{/gist_id}","starred_url":"https://api.github.com/users/rsanchezsaez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsanchezsaez/subscriptions","organizations_url":"https://api.github.com/users/rsanchezsaez/orgs","repos_url":"https://api.github.com/users/rsanchezsaez/repos","events_url":"https://api.github.com/users/rsanchezsaez/events{/privacy}","received_events_url":"https://api.github.com/users/rsanchezsaez/received_events","type":"User","site_admin":false},"body":"This PR implements the picker-based 'ORKHeightAnswerFormat' [Issue #484](https://github.com/ResearchKit/ResearchKit/issues/484).\r\n\r\nDetails:\r\n- Supports the metric and ~~imperial~~USC measuring systems\r\n- Supports standalone question steps and on form steps\r\n- Serialization unit tests have been implemented\r\n\r\nNotes:\r\n- For input it uses the newly added 'ORKHeighPicker' class\r\n- Height limits and default value are hardcoded into the picker, taking the same values as the *Health app*: [`0 ft, 0 in` - `9 ft, 11 in`] range, default: `5 ft, 4 in`; [`0 cm` - `299 cm`] range, default: `162 cm`\r\n- Results are output as an `ORKNumericResult` object, with the unit canonically set to ~~`in` or~~ `cm` ~~depending on the chosen measuring system (on the imperial system, feet and inches always get converted to total inches in the output result)~~\r\n- Visually, the picker and the chosen answer in form steps display the `cm` and decomposed `ft in` values, with their units localized if applicable (unlike the canonical result units which are never localized)\r\n\r\n---\r\n![simulator screen shot 24 mar 2016 14 58 08](https://cloud.githubusercontent.com/assets/444313/14020958/5765226c-f1d1-11e5-86f0-dacaa20e5c26.png)\r\n---\r\n![simulator screen shot 24 mar 2016 15 02 51](https://cloud.githubusercontent.com/assets/444313/14021003/8413e302-f1d1-11e5-8d7e-a11739456630.png)\r\n---\r\n![simulator screen shot 24 mar 2016 15 01 11](https://cloud.githubusercontent.com/assets/444313/14020957/5729910c-f1d1-11e5-8cd9-67307617b649.png)\r\n","created_at":"2016-03-24T14:51:35Z","updated_at":"2016-07-08T17:41:15Z","closed_at":"2016-07-08T17:41:15Z","merged_at":"2016-07-08T17:41:15Z","merge_commit_sha":"e11440b036bd46a8e988013fc6fc8c856a9f2416","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643/commits","review_comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643/comments","review_comment_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/643/comments","statuses_url":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/7fe3e227adee211180ae3c064e86a454c549cc68","head":{"label":"rsanchezsaez:rsanchezsaez-ORKHeightAnswerFormat","ref":"rsanchezsaez-ORKHeightAnswerFormat","sha":"7fe3e227adee211180ae3c064e86a454c549cc68","user":{"login":"rsanchezsaez","id":444313,"avatar_url":"https://avatars.githubusercontent.com/u/444313?v=3","gravatar_id":"","url":"https://api.github.com/users/rsanchezsaez","html_url":"https://github.com/rsanchezsaez","followers_url":"https://api.github.com/users/rsanchezsaez/followers","following_url":"https://api.github.com/users/rsanchezsaez/following{/other_user}","gists_url":"https://api.github.com/users/rsanchezsaez/gists{/gist_id}","starred_url":"https://api.github.com/users/rsanchezsaez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsanchezsaez/subscriptions","organizations_url":"https://api.github.com/users/rsanchezsaez/orgs","repos_url":"https://api.github.com/users/rsanchezsaez/repos","events_url":"https://api.github.com/users/rsanchezsaez/events{/privacy}","received_events_url":"https://api.github.com/users/rsanchezsaez/received_events","type":"User","site_admin":false},"repo":{"id":33944592,"name":"ResearchKit","full_name":"rsanchezsaez/ResearchKit","owner":{"login":"rsanchezsaez","id":444313,"avatar_url":"https://avatars.githubusercontent.com/u/444313?v=3","gravatar_id":"","url":"https://api.github.com/users/rsanchezsaez","html_url":"https://github.com/rsanchezsaez","followers_url":"https://api.github.com/users/rsanchezsaez/followers","following_url":"https://api.github.com/users/rsanchezsaez/following{/other_user}","gists_url":"https://api.github.com/users/rsanchezsaez/gists{/gist_id}","starred_url":"https://api.github.com/users/rsanchezsaez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsanchezsaez/subscriptions","organizations_url":"https://api.github.com/users/rsanchezsaez/orgs","repos_url":"https://api.github.com/users/rsanchezsaez/repos","events_url":"https://api.github.com/users/rsanchezsaez/events{/privacy}","received_events_url":"https://api.github.com/users/rsanchezsaez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsanchezsaez/ResearchKit","description":"ResearchKit is an open source software framework that makes it easy to create apps for medical research or for other research projects.","fork":true,"url":"https://api.github.com/repos/rsanchezsaez/ResearchKit","forks_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/forks","keys_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/teams","hooks_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/hooks","issue_events_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/issues/events{/number}","events_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/events","assignees_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/assignees{/user}","branches_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/branches{/branch}","tags_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/tags","blobs_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/statuses/{sha}","languages_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/languages","stargazers_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/stargazers","contributors_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/contributors","subscribers_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/subscribers","subscription_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/subscription","commits_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/contents/{+path}","compare_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/merges","archive_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/downloads","issues_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/issues{/number}","pulls_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/pulls{/number}","milestones_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/milestones{/number}","notifications_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/labels{/name}","releases_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/releases{/id}","deployments_url":"https://api.github.com/repos/rsanchezsaez/ResearchKit/deployments","created_at":"2015-04-14T16:50:40Z","updated_at":"2016-02-04T18:37:47Z","pushed_at":"2016-07-08T13:07:25Z","git_url":"git://github.com/rsanchezsaez/ResearchKit.git","ssh_url":"git@github.com:rsanchezsaez/ResearchKit.git","clone_url":"https://github.com/rsanchezsaez/ResearchKit.git","svn_url":"https://github.com/rsanchezsaez/ResearchKit","homepage":"","size":24026,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ResearchKit:master","ref":"master","sha":"b1b25f9ac42e6b4b8efc76a9f860658de141e814","user":{"login":"ResearchKit","id":11183179,"avatar_url":"https://avatars.githubusercontent.com/u/11183179?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchKit","html_url":"https://github.com/ResearchKit","followers_url":"https://api.github.com/users/ResearchKit/followers","following_url":"https://api.github.com/users/ResearchKit/following{/other_user}","gists_url":"https://api.github.com/users/ResearchKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchKit/subscriptions","organizations_url":"https://api.github.com/users/ResearchKit/orgs","repos_url":"https://api.github.com/users/ResearchKit/repos","events_url":"https://api.github.com/users/ResearchKit/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchKit/received_events","type":"Organization","site_admin":false},"repo":{"id":31979038,"name":"ResearchKit","full_name":"ResearchKit/ResearchKit","owner":{"login":"ResearchKit","id":11183179,"avatar_url":"https://avatars.githubusercontent.com/u/11183179?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchKit","html_url":"https://github.com/ResearchKit","followers_url":"https://api.github.com/users/ResearchKit/followers","following_url":"https://api.github.com/users/ResearchKit/following{/other_user}","gists_url":"https://api.github.com/users/ResearchKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchKit/subscriptions","organizations_url":"https://api.github.com/users/ResearchKit/orgs","repos_url":"https://api.github.com/users/ResearchKit/repos","events_url":"https://api.github.com/users/ResearchKit/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchKit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ResearchKit/ResearchKit","description":"ResearchKit is an open source software framework that makes it easy to create apps for medical research or for other research projects.","fork":false,"url":"https://api.github.com/repos/ResearchKit/ResearchKit","forks_url":"https://api.github.com/repos/ResearchKit/ResearchKit/forks","keys_url":"https://api.github.com/repos/ResearchKit/ResearchKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ResearchKit/ResearchKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ResearchKit/ResearchKit/teams","hooks_url":"https://api.github.com/repos/ResearchKit/ResearchKit/hooks","issue_events_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/events{/number}","events_url":"https://api.github.com/repos/ResearchKit/ResearchKit/events","assignees_url":"https://api.github.com/repos/ResearchKit/ResearchKit/assignees{/user}","branches_url":"https://api.github.com/repos/ResearchKit/ResearchKit/branches{/branch}","tags_url":"https://api.github.com/repos/ResearchKit/ResearchKit/tags","blobs_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/{sha}","languages_url":"https://api.github.com/repos/ResearchKit/ResearchKit/languages","stargazers_url":"https://api.github.com/repos/ResearchKit/ResearchKit/stargazers","contributors_url":"https://api.github.com/repos/ResearchKit/ResearchKit/contributors","subscribers_url":"https://api.github.com/repos/ResearchKit/ResearchKit/subscribers","subscription_url":"https://api.github.com/repos/ResearchKit/ResearchKit/subscription","commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ResearchKit/ResearchKit/contents/{+path}","compare_url":"https://api.github.com/repos/ResearchKit/ResearchKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ResearchKit/ResearchKit/merges","archive_url":"https://api.github.com/repos/ResearchKit/ResearchKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ResearchKit/ResearchKit/downloads","issues_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues{/number}","pulls_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls{/number}","milestones_url":"https://api.github.com/repos/ResearchKit/ResearchKit/milestones{/number}","notifications_url":"https://api.github.com/repos/ResearchKit/ResearchKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ResearchKit/ResearchKit/labels{/name}","releases_url":"https://api.github.com/repos/ResearchKit/ResearchKit/releases{/id}","deployments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/deployments","created_at":"2015-03-10T20:05:32Z","updated_at":"2016-07-08T09:41:13Z","pushed_at":"2016-07-08T17:41:15Z","git_url":"git://github.com/ResearchKit/ResearchKit.git","ssh_url":"git@github.com:ResearchKit/ResearchKit.git","clone_url":"https://github.com/ResearchKit/ResearchKit.git","svn_url":"https://github.com/ResearchKit/ResearchKit","homepage":"","size":28770,"stargazers_count":4650,"watchers_count":4650,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":804,"mirror_url":null,"open_issues_count":107,"forks":804,"open_issues":107,"watchers":4650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643"},"html":{"href":"https://github.com/ResearchKit/ResearchKit/pull/643"},"issue":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/643"},"comments":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/7fe3e227adee211180ae3c064e86a454c549cc68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"YuanZhu-apple","id":11466704,"avatar_url":"https://avatars.githubusercontent.com/u/11466704?v=3","gravatar_id":"","url":"https://api.github.com/users/YuanZhu-apple","html_url":"https://github.com/YuanZhu-apple","followers_url":"https://api.github.com/users/YuanZhu-apple/followers","following_url":"https://api.github.com/users/YuanZhu-apple/following{/other_user}","gists_url":"https://api.github.com/users/YuanZhu-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/YuanZhu-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuanZhu-apple/subscriptions","organizations_url":"https://api.github.com/users/YuanZhu-apple/orgs","repos_url":"https://api.github.com/users/YuanZhu-apple/repos","events_url":"https://api.github.com/users/YuanZhu-apple/events{/privacy}","received_events_url":"https://api.github.com/users/YuanZhu-apple/received_events","type":"User","site_admin":false},"comments":10,"review_comments":19,"commits":13,"additions":678,"deletions":71,"changed_files":24}}
{"actor":{"display_login":"YuanZhu-apple"}}