{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/79417657","id":79417657,"diff_hunk":"@@ -29,11 +29,13 @@\n     </li>\n }\n \n-<div class=\"main-menu-container\" id=\"main-menu\">\n+<label for=\"main-menu-toggle\" class=\"main-menu-container__overlay\" aria-hidden=\"true\"></label>","path":"common/app/views/fragments/nav/newHeaderMenu.scala.html","position":29,"original_position":25,"commit_id":"ae0fd06d60b7070dbd449b4b2f172df820dcb777","original_commit_id":"a79bd0e23f0d27d2687ca081c3c76d112b65230e","user":{"login":"gtrufitt","id":638051,"avatar_url":"https://avatars.githubusercontent.com/u/638051?v=3","gravatar_id":"","url":"https://api.github.com/users/gtrufitt","html_url":"https://github.com/gtrufitt","followers_url":"https://api.github.com/users/gtrufitt/followers","following_url":"https://api.github.com/users/gtrufitt/following{/other_user}","gists_url":"https://api.github.com/users/gtrufitt/gists{/gist_id}","starred_url":"https://api.github.com/users/gtrufitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtrufitt/subscriptions","organizations_url":"https://api.github.com/users/gtrufitt/orgs","repos_url":"https://api.github.com/users/gtrufitt/repos","events_url":"https://api.github.com/users/gtrufitt/events{/privacy}","received_events_url":"https://api.github.com/users/gtrufitt/received_events","type":"User","site_admin":false},"body":"k remembered the form element is the tabbabable element so if you're avoiding tabbing to the checkbox this is cool innit.","created_at":"2016-09-19T15:28:03Z","updated_at":"2016-09-19T15:28:03Z","html_url":"https://github.com/guardian/frontend/pull/14356#discussion_r79417657","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/14356","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/79417657"},"html":{"href":"https://github.com/guardian/frontend/pull/14356#discussion_r79417657"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14356"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14356","id":85592975,"html_url":"https://github.com/guardian/frontend/pull/14356","diff_url":"https://github.com/guardian/frontend/pull/14356.diff","patch_url":"https://github.com/guardian/frontend/pull/14356.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14356","number":14356,"state":"open","locked":false,"title":"CSS-only header navigation","user":{"login":"SiAdcock","id":5931528,"avatar_url":"https://avatars.githubusercontent.com/u/5931528?v=3","gravatar_id":"","url":"https://api.github.com/users/SiAdcock","html_url":"https://github.com/SiAdcock","followers_url":"https://api.github.com/users/SiAdcock/followers","following_url":"https://api.github.com/users/SiAdcock/following{/other_user}","gists_url":"https://api.github.com/users/SiAdcock/gists{/gist_id}","starred_url":"https://api.github.com/users/SiAdcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiAdcock/subscriptions","organizations_url":"https://api.github.com/users/SiAdcock/orgs","repos_url":"https://api.github.com/users/SiAdcock/repos","events_url":"https://api.github.com/users/SiAdcock/events{/privacy}","received_events_url":"https://api.github.com/users/SiAdcock/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\n\r\n- implemented a CSS-only version of the new header navigation. This is available as soon as the HTML and CSS has loaded\r\n- stripped most of the JavaScript functionality of the header; JS now provides only accessibility and user experience enhancements. Also removed most of its third party dependency libraries, with the exception of `fastdom` and `qwery`\r\n- moved the JavaScript from enhanced into standard\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nCurrently, the new header navigation does not respond to user interaction until all enhanced JavaScript has been loaded. There is an unacceptable delay between user interaction and perceived response from the header UI. Implementing a CSS-only version of the navigation ensures there will be no such delay.\r\n\r\nThe CSS-only version of the navigation is not accessible, and the user experience is sub-optimal. Therefore we will still need to maintain minimal JavaScript that addresses these issues.\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNope\r\n\r\n## Request for comment\r\n\r\n@NataliaLKB @gtrufitt @rich-nguyen @TBonnin @zeftilldeath @regiskuckaertz \r\n","created_at":"2016-09-16T15:26:42Z","updated_at":"2016-09-19T15:28:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea3a9d951296bd4b7f59071ca3395887ac11292d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/14356/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/14356/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14356/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/ae0fd06d60b7070dbd449b4b2f172df820dcb777","head":{"label":"guardian:new-navigation-css-only-spike","ref":"new-navigation-css-only-spike","sha":"ae0fd06d60b7070dbd449b4b2f172df820dcb777","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-09-19T06:03:29Z","pushed_at":"2016-09-19T15:26:46Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":528350,"stargazers_count":3300,"watchers_count":3300,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":45,"forks":348,"open_issues":45,"watchers":3300,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"7814cde38d8d8eb51982027f0851dfacfd8d8137","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-09-19T06:03:29Z","pushed_at":"2016-09-19T15:26:46Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":528350,"stargazers_count":3300,"watchers_count":3300,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":45,"forks":348,"open_issues":45,"watchers":3300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14356"},"html":{"href":"https://github.com/guardian/frontend/pull/14356"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/14356"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/14356/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14356/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14356/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/ae0fd06d60b7070dbd449b4b2f172df820dcb777"}}}}
{"actor":{"display_login":"gtrufitt"}}