{"action":"closed","number":369,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/369","id":90441425,"html_url":"https://github.com/eclipse/omr/pull/369","diff_url":"https://github.com/eclipse/omr/pull/369.diff","patch_url":"https://github.com/eclipse/omr/pull/369.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/369","number":369,"state":"closed","locked":false,"title":"Change `name` in `DefineFunction()` taking `char*` to `const char*`","user":{"login":"ShuyuLi-ca","id":22401274,"avatar_url":"https://avatars.githubusercontent.com/u/22401274?v=3","gravatar_id":"","url":"https://api.github.com/users/ShuyuLi-ca","html_url":"https://github.com/ShuyuLi-ca","followers_url":"https://api.github.com/users/ShuyuLi-ca/followers","following_url":"https://api.github.com/users/ShuyuLi-ca/following{/other_user}","gists_url":"https://api.github.com/users/ShuyuLi-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/ShuyuLi-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShuyuLi-ca/subscriptions","organizations_url":"https://api.github.com/users/ShuyuLi-ca/orgs","repos_url":"https://api.github.com/users/ShuyuLi-ca/repos","events_url":"https://api.github.com/users/ShuyuLi-ca/events{/privacy}","received_events_url":"https://api.github.com/users/ShuyuLi-ca/received_events","type":"User","site_admin":false},"body":"In order to eliminate the warning: ISO C++11 does not allow conversion\r\nfrom string literal to `char *` [-Wwritable-strings] when passing string\r\nparameter in the first field `name` in `DefineFunction()`, change the\r\ntype of `name` taking `char*` to `const char *`.\r\n\r\nSigned-off-by: Shuyu Li <shuyuli@ca.ibm.com>","created_at":"2016-10-21T20:48:21Z","updated_at":"2016-10-24T19:43:40Z","closed_at":"2016-10-24T19:43:40Z","merged_at":null,"merge_commit_sha":"e44157d4b3f0d78f484c98c2948fbe4767188fad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/369/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/369/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/369/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/b99bbd01fa5a4fb56ddca8eaf9dcc65a68f95809","head":{"label":"ShuyuLi-ca:Shuyu","ref":"Shuyu","sha":"b99bbd01fa5a4fb56ddca8eaf9dcc65a68f95809","user":{"login":"ShuyuLi-ca","id":22401274,"avatar_url":"https://avatars.githubusercontent.com/u/22401274?v=3","gravatar_id":"","url":"https://api.github.com/users/ShuyuLi-ca","html_url":"https://github.com/ShuyuLi-ca","followers_url":"https://api.github.com/users/ShuyuLi-ca/followers","following_url":"https://api.github.com/users/ShuyuLi-ca/following{/other_user}","gists_url":"https://api.github.com/users/ShuyuLi-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/ShuyuLi-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShuyuLi-ca/subscriptions","organizations_url":"https://api.github.com/users/ShuyuLi-ca/orgs","repos_url":"https://api.github.com/users/ShuyuLi-ca/repos","events_url":"https://api.github.com/users/ShuyuLi-ca/events{/privacy}","received_events_url":"https://api.github.com/users/ShuyuLi-ca/received_events","type":"User","site_admin":false},"repo":{"id":69265557,"name":"omr","full_name":"ShuyuLi-ca/omr","owner":{"login":"ShuyuLi-ca","id":22401274,"avatar_url":"https://avatars.githubusercontent.com/u/22401274?v=3","gravatar_id":"","url":"https://api.github.com/users/ShuyuLi-ca","html_url":"https://github.com/ShuyuLi-ca","followers_url":"https://api.github.com/users/ShuyuLi-ca/followers","following_url":"https://api.github.com/users/ShuyuLi-ca/following{/other_user}","gists_url":"https://api.github.com/users/ShuyuLi-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/ShuyuLi-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShuyuLi-ca/subscriptions","organizations_url":"https://api.github.com/users/ShuyuLi-ca/orgs","repos_url":"https://api.github.com/users/ShuyuLi-ca/repos","events_url":"https://api.github.com/users/ShuyuLi-ca/events{/privacy}","received_events_url":"https://api.github.com/users/ShuyuLi-ca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShuyuLi-ca/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/ShuyuLi-ca/omr","forks_url":"https://api.github.com/repos/ShuyuLi-ca/omr/forks","keys_url":"https://api.github.com/repos/ShuyuLi-ca/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShuyuLi-ca/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShuyuLi-ca/omr/teams","hooks_url":"https://api.github.com/repos/ShuyuLi-ca/omr/hooks","issue_events_url":"https://api.github.com/repos/ShuyuLi-ca/omr/issues/events{/number}","events_url":"https://api.github.com/repos/ShuyuLi-ca/omr/events","assignees_url":"https://api.github.com/repos/ShuyuLi-ca/omr/assignees{/user}","branches_url":"https://api.github.com/repos/ShuyuLi-ca/omr/branches{/branch}","tags_url":"https://api.github.com/repos/ShuyuLi-ca/omr/tags","blobs_url":"https://api.github.com/repos/ShuyuLi-ca/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShuyuLi-ca/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShuyuLi-ca/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShuyuLi-ca/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShuyuLi-ca/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/ShuyuLi-ca/omr/languages","stargazers_url":"https://api.github.com/repos/ShuyuLi-ca/omr/stargazers","contributors_url":"https://api.github.com/repos/ShuyuLi-ca/omr/contributors","subscribers_url":"https://api.github.com/repos/ShuyuLi-ca/omr/subscribers","subscription_url":"https://api.github.com/repos/ShuyuLi-ca/omr/subscription","commits_url":"https://api.github.com/repos/ShuyuLi-ca/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShuyuLi-ca/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShuyuLi-ca/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShuyuLi-ca/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShuyuLi-ca/omr/contents/{+path}","compare_url":"https://api.github.com/repos/ShuyuLi-ca/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShuyuLi-ca/omr/merges","archive_url":"https://api.github.com/repos/ShuyuLi-ca/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShuyuLi-ca/omr/downloads","issues_url":"https://api.github.com/repos/ShuyuLi-ca/omr/issues{/number}","pulls_url":"https://api.github.com/repos/ShuyuLi-ca/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/ShuyuLi-ca/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/ShuyuLi-ca/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShuyuLi-ca/omr/labels{/name}","releases_url":"https://api.github.com/repos/ShuyuLi-ca/omr/releases{/id}","deployments_url":"https://api.github.com/repos/ShuyuLi-ca/omr/deployments","created_at":"2016-09-26T15:42:46Z","updated_at":"2016-09-26T15:42:53Z","pushed_at":"2016-10-24T19:42:53Z","git_url":"git://github.com/ShuyuLi-ca/omr.git","ssh_url":"git@github.com:ShuyuLi-ca/omr.git","clone_url":"https://github.com/ShuyuLi-ca/omr.git","svn_url":"https://github.com/ShuyuLi-ca/omr","homepage":"","size":9418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"9fe8bc4c8b0b855155c4d609ac1063276d4a1a4e","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2016-10-24T19:16:47Z","pushed_at":"2016-10-24T19:42:53Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"","size":9668,"stargazers_count":243,"watchers_count":243,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":64,"forks":83,"open_issues":64,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/369"},"html":{"href":"https://github.com/eclipse/omr/pull/369"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/369"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/b99bbd01fa5a4fb56ddca8eaf9dcc65a68f95809"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"ShuyuLi-ca"}}