{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91922702","pull_request_review_id":12430736,"id":91922702,"diff_hunk":"@@ -0,0 +1,53 @@\n+apiVersion: v1\n+kind: Pod\n+metadata:\n+  name: etcd-server-events\n+  namespace: kube-system\n+spec:\n+  dnsPolicy: ClusterFirst\n+  hostNetwork: true\n+  nodeName: {{instance_prefix}}-master\n+  restartPolicy: Always","path":"test/kubemark/resources/manifests/etcd-events.yaml","position":10,"original_position":10,"commit_id":"9bd868b7559b93ab5ecd1000090b7149b3bcd1ff","original_commit_id":"9bd868b7559b93ab5ecd1000090b7149b3bcd1ff","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"Isn't this a default?","created_at":"2016-12-12T10:44:23Z","updated_at":"2016-12-12T10:44:23Z","html_url":"https://github.com/kubernetes/kubernetes/pull/38227#discussion_r91922702","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91922702"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38227#discussion_r91922702"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227","id":96829903,"html_url":"https://github.com/kubernetes/kubernetes/pull/38227","diff_url":"https://github.com/kubernetes/kubernetes/pull/38227.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38227.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38227","number":38227,"state":"open","locked":false,"title":"On kubemark master, kubelet now runs as a supervisord process and all master components as pods","user":{"login":"shyamjvs","id":4333971,"avatar_url":"https://avatars.githubusercontent.com/u/4333971?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"body":"This PR fixes issue #37485\r\nOn kubemark, previously we had a custom setup that runs master components as top-level processes under supervisord, which is lighter than running kubelet and docker.\r\nThis PR makes kubelet run as a process under supervisord and the master components (apiserver, controller-manager, scheduler, etcd) as pods, making testing on kubemark mimic real clusters better.\r\nAlso, start-kubemark-master.sh now closely resembles cluster/gce/gci/configure-helper.sh, allowing easy integration in future.\r\n\r\ncc @kubernetes/sig-scalability @wojtek-t @gmarek \r\n","created_at":"2016-12-06T23:37:24Z","updated_at":"2016-12-12T10:49:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3471c4264b18705a52168024616cb0a0e9af6511","assignee":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":null,"creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":217,"closed_issues":102,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2016-12-12T10:24:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38227/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9bd868b7559b93ab5ecd1000090b7149b3bcd1ff","head":{"label":"shyamjvs:kubemark-master-migrate","ref":"kubemark-master-migrate","sha":"9bd868b7559b93ab5ecd1000090b7149b3bcd1ff","user":{"login":"shyamjvs","id":4333971,"avatar_url":"https://avatars.githubusercontent.com/u/4333971?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"repo":{"id":74686020,"name":"kubernetes","full_name":"shyamjvs/kubernetes","owner":{"login":"shyamjvs","id":4333971,"avatar_url":"https://avatars.githubusercontent.com/u/4333971?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shyamjvs/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/shyamjvs/kubernetes","forks_url":"https://api.github.com/repos/shyamjvs/kubernetes/forks","keys_url":"https://api.github.com/repos/shyamjvs/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shyamjvs/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shyamjvs/kubernetes/teams","hooks_url":"https://api.github.com/repos/shyamjvs/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/shyamjvs/kubernetes/events","assignees_url":"https://api.github.com/repos/shyamjvs/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/shyamjvs/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/shyamjvs/kubernetes/tags","blobs_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shyamjvs/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/shyamjvs/kubernetes/languages","stargazers_url":"https://api.github.com/repos/shyamjvs/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/shyamjvs/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/shyamjvs/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/shyamjvs/kubernetes/subscription","commits_url":"https://api.github.com/repos/shyamjvs/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/shyamjvs/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/shyamjvs/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/shyamjvs/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shyamjvs/kubernetes/merges","archive_url":"https://api.github.com/repos/shyamjvs/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shyamjvs/kubernetes/downloads","issues_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/shyamjvs/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/shyamjvs/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/shyamjvs/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shyamjvs/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/shyamjvs/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/shyamjvs/kubernetes/deployments","created_at":"2016-11-24T15:40:48Z","updated_at":"2016-11-24T15:41:32Z","pushed_at":"2016-12-09T15:10:01Z","git_url":"git://github.com/shyamjvs/kubernetes.git","ssh_url":"git@github.com:shyamjvs/kubernetes.git","clone_url":"https://github.com/shyamjvs/kubernetes.git","svn_url":"https://github.com/shyamjvs/kubernetes","homepage":"http://kubernetes.io","size":370187,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"72b52d4334d1d2fe7ed072bab465c36525f308e7","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-12T09:50:31Z","pushed_at":"2016-12-12T10:45:23Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":665983,"stargazers_count":19084,"watchers_count":19084,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6358,"mirror_url":null,"open_issues_count":5375,"forks":6358,"open_issues":5375,"watchers":19084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38227"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38227"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38227/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38227/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9bd868b7559b93ab5ecd1000090b7149b3bcd1ff"}}}}
{"actor":{"display_login":"wojtek-t"}}