{"action":"created","comment":{"url":"https://api.github.com/repos/libuv/libuv/pulls/comments/84000991","pull_request_review_id":4806553,"id":84000991,"diff_hunk":"@@ -106,11 +106,24 @@ API\n     .. note::\n         Though UV_DISCONNECT can be set, it is unsupported on AIX and as such will not be set\n         on the `events` field in the callback.\n+        \n+    .. note::\n+        If one of the events UV_READABLE or UV_WRITABLE are set, the callback will be called over-and-over again, as long as the given fd/socket remains readable or writable accordingly. Particullary in each of the following scenerios:\n+        \n+        * The callback has been called because the socket became readable/writable and the callback did not conduct a read/write on this socket at all.\n+        * The callback commited a read on the socket, and have not read all the available data (when UV_READABLE is set).","path":"docs/src/poll.rst","position":9,"original_position":9,"commit_id":"70b1ad232dfccbaa1ce4f6aff10c96596659403a","original_commit_id":"70b1ad232dfccbaa1ce4f6aff10c96596659403a","user":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=3","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"body":"shouldn't it be \"and has not read all\"?","created_at":"2016-10-19T05:52:27Z","updated_at":"2016-10-19T05:52:27Z","html_url":"https://github.com/libuv/libuv/pull/1100#discussion_r84000991","pull_request_url":"https://api.github.com/repos/libuv/libuv/pulls/1100","_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments/84000991"},"html":{"href":"https://github.com/libuv/libuv/pull/1100#discussion_r84000991"},"pull_request":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1100"}}},"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/1100","id":89911784,"html_url":"https://github.com/libuv/libuv/pull/1100","diff_url":"https://github.com/libuv/libuv/pull/1100.diff","patch_url":"https://github.com/libuv/libuv/pull/1100.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1100","number":1100,"state":"open","locked":false,"title":"doc: poll: add notes (repeated cb & cancel pending cb)","user":{"login":"eladn","id":9944637,"avatar_url":"https://avatars.githubusercontent.com/u/9944637?v=3","gravatar_id":"","url":"https://api.github.com/users/eladn","html_url":"https://github.com/eladn","followers_url":"https://api.github.com/users/eladn/followers","following_url":"https://api.github.com/users/eladn/following{/other_user}","gists_url":"https://api.github.com/users/eladn/gists{/gist_id}","starred_url":"https://api.github.com/users/eladn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladn/subscriptions","organizations_url":"https://api.github.com/users/eladn/orgs","repos_url":"https://api.github.com/users/eladn/repos","events_url":"https://api.github.com/users/eladn/events{/privacy}","received_events_url":"https://api.github.com/users/eladn/received_events","type":"User","site_admin":false},"body":"Added notes to documentation of `uv_poll_t`:\r\n- The callback will be called over-and-over again as long as the socket\r\nremains readable/writable.\r\n- uv_pool_stop() cancels pending callbacks of already happened events.\r\nhttps://github.com/libuv/libuv/issues/1078","created_at":"2016-10-18T22:37:38Z","updated_at":"2016-10-19T06:02:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924fffdc10bb8d4f3022a539780667e14b5f8978","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1100/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/70b1ad232dfccbaa1ce4f6aff10c96596659403a","head":{"label":"eladn:poll-doc-note-repeated-callbacks","ref":"poll-doc-note-repeated-callbacks","sha":"70b1ad232dfccbaa1ce4f6aff10c96596659403a","user":{"login":"eladn","id":9944637,"avatar_url":"https://avatars.githubusercontent.com/u/9944637?v=3","gravatar_id":"","url":"https://api.github.com/users/eladn","html_url":"https://github.com/eladn","followers_url":"https://api.github.com/users/eladn/followers","following_url":"https://api.github.com/users/eladn/following{/other_user}","gists_url":"https://api.github.com/users/eladn/gists{/gist_id}","starred_url":"https://api.github.com/users/eladn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladn/subscriptions","organizations_url":"https://api.github.com/users/eladn/orgs","repos_url":"https://api.github.com/users/eladn/repos","events_url":"https://api.github.com/users/eladn/events{/privacy}","received_events_url":"https://api.github.com/users/eladn/received_events","type":"User","site_admin":false},"repo":{"id":71295995,"name":"libuv","full_name":"eladn/libuv","owner":{"login":"eladn","id":9944637,"avatar_url":"https://avatars.githubusercontent.com/u/9944637?v=3","gravatar_id":"","url":"https://api.github.com/users/eladn","html_url":"https://github.com/eladn","followers_url":"https://api.github.com/users/eladn/followers","following_url":"https://api.github.com/users/eladn/following{/other_user}","gists_url":"https://api.github.com/users/eladn/gists{/gist_id}","starred_url":"https://api.github.com/users/eladn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladn/subscriptions","organizations_url":"https://api.github.com/users/eladn/orgs","repos_url":"https://api.github.com/users/eladn/repos","events_url":"https://api.github.com/users/eladn/events{/privacy}","received_events_url":"https://api.github.com/users/eladn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eladn/libuv","description":"Cross-platform asynchronous I/O","fork":true,"url":"https://api.github.com/repos/eladn/libuv","forks_url":"https://api.github.com/repos/eladn/libuv/forks","keys_url":"https://api.github.com/repos/eladn/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eladn/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eladn/libuv/teams","hooks_url":"https://api.github.com/repos/eladn/libuv/hooks","issue_events_url":"https://api.github.com/repos/eladn/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/eladn/libuv/events","assignees_url":"https://api.github.com/repos/eladn/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/eladn/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/eladn/libuv/tags","blobs_url":"https://api.github.com/repos/eladn/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eladn/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eladn/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/eladn/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eladn/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/eladn/libuv/languages","stargazers_url":"https://api.github.com/repos/eladn/libuv/stargazers","contributors_url":"https://api.github.com/repos/eladn/libuv/contributors","subscribers_url":"https://api.github.com/repos/eladn/libuv/subscribers","subscription_url":"https://api.github.com/repos/eladn/libuv/subscription","commits_url":"https://api.github.com/repos/eladn/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/eladn/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/eladn/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/eladn/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/eladn/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/eladn/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eladn/libuv/merges","archive_url":"https://api.github.com/repos/eladn/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eladn/libuv/downloads","issues_url":"https://api.github.com/repos/eladn/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/eladn/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/eladn/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/eladn/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eladn/libuv/labels{/name}","releases_url":"https://api.github.com/repos/eladn/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/eladn/libuv/deployments","created_at":"2016-10-18T22:15:29Z","updated_at":"2016-10-18T22:15:32Z","pushed_at":"2016-10-18T22:27:57Z","git_url":"git://github.com/eladn/libuv.git","ssh_url":"git@github.com:eladn/libuv.git","clone_url":"https://github.com/eladn/libuv.git","svn_url":"https://github.com/eladn/libuv","homepage":"http://libuv.org/","size":11206,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"libuv:v1.x","ref":"v1.x","sha":"a35308306fc9614407194fd294fdc130c98b53a5","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asynchronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/libuv/libuv/deployments","created_at":"2013-11-30T00:29:56Z","updated_at":"2016-10-19T05:21:01Z","pushed_at":"2016-10-18T22:37:38Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":18196,"stargazers_count":4946,"watchers_count":4946,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":841,"mirror_url":null,"open_issues_count":107,"forks":841,"open_issues":107,"watchers":4946,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1100"},"html":{"href":"https://github.com/libuv/libuv/pull/1100"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/1100"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/70b1ad232dfccbaa1ce4f6aff10c96596659403a"}}}}
{"actor":{"display_login":"txdv"}}