{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/73973084","id":73973084,"diff_hunk":"@@ -522,6 +526,7 @@ internal class DataContractCriticalHelper\n             private static object s_clrTypeStringsLock = new object();\n \n             private Type _underlyingType;\n+            Type _originalUnderlyingType;","path":"src/System.Private.DataContractSerialization/src/System/Runtime/Serialization/DataContract.cs","position":17,"original_position":17,"commit_id":"859cf0c6088ceb2b2cf3aaf8a88f42c12a7cf1a7","original_commit_id":"859cf0c6088ceb2b2cf3aaf8a88f42c12a7cf1a7","user":{"login":"mconnew","id":8648390,"avatar_url":"https://avatars.githubusercontent.com/u/8648390?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnew","html_url":"https://github.com/mconnew","followers_url":"https://api.github.com/users/mconnew/followers","following_url":"https://api.github.com/users/mconnew/following{/other_user}","gists_url":"https://api.github.com/users/mconnew/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnew/subscriptions","organizations_url":"https://api.github.com/users/mconnew/orgs","repos_url":"https://api.github.com/users/mconnew/repos","events_url":"https://api.github.com/users/mconnew/events{/privacy}","received_events_url":"https://api.github.com/users/mconnew/received_events","type":"User","site_admin":false},"body":"add explicit `private` to field","created_at":"2016-08-08T23:11:29Z","updated_at":"2016-08-08T23:11:29Z","html_url":"https://github.com/dotnet/corefx/pull/10598#discussion_r73973084","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/10598","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/73973084"},"html":{"href":"https://github.com/dotnet/corefx/pull/10598#discussion_r73973084"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10598"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/10598","id":80163626,"html_url":"https://github.com/dotnet/corefx/pull/10598","diff_url":"https://github.com/dotnet/corefx/pull/10598.diff","patch_url":"https://github.com/dotnet/corefx/pull/10598.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/10598","number":10598,"state":"open","locked":false,"title":"Fix for Issue#10155 & #10217","user":{"login":"huanwu","id":1438378,"avatar_url":"https://avatars.githubusercontent.com/u/1438378?v=3","gravatar_id":"","url":"https://api.github.com/users/huanwu","html_url":"https://github.com/huanwu","followers_url":"https://api.github.com/users/huanwu/followers","following_url":"https://api.github.com/users/huanwu/following{/other_user}","gists_url":"https://api.github.com/users/huanwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huanwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huanwu/subscriptions","organizations_url":"https://api.github.com/users/huanwu/orgs","repos_url":"https://api.github.com/users/huanwu/repos","events_url":"https://api.github.com/users/huanwu/events{/privacy}","received_events_url":"https://api.github.com/users/huanwu/received_events","type":"User","site_admin":false},"body":"Fix two issues.\r\n\r\nFix #10155.  When serialize a object with unknown type, if the serializer contains a DataContractResolver, it will end up with SerializationException. However, no exception thrown from Desktop Version. This is because, in core version, it always verify knowtype if there's resolver. Change the code to match the desktop version. \r\n\r\nFix #10217. When serialize a object with DateTimeOffset property, the OriginalUnderlyType of DataContract is always DateTimeOffsetAgent type, which should be DateTimeOffset based on Desktop version. This is because it is missing GetDataContractOriginalType method in DataContractCriticalHelper.\r\n\r\n\r\n@shmao @mconnew @zhenlan ","created_at":"2016-08-04T22:58:05Z","updated_at":"2016-08-08T23:11:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3114064d8dd254a92262ec9b30a152a4ef7700f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/10598/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/10598/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/10598/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/859cf0c6088ceb2b2cf3aaf8a88f42c12a7cf1a7","head":{"label":"huanwu:OriginalTypeAndKnowType","ref":"OriginalTypeAndKnowType","sha":"859cf0c6088ceb2b2cf3aaf8a88f42c12a7cf1a7","user":{"login":"huanwu","id":1438378,"avatar_url":"https://avatars.githubusercontent.com/u/1438378?v=3","gravatar_id":"","url":"https://api.github.com/users/huanwu","html_url":"https://github.com/huanwu","followers_url":"https://api.github.com/users/huanwu/followers","following_url":"https://api.github.com/users/huanwu/following{/other_user}","gists_url":"https://api.github.com/users/huanwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huanwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huanwu/subscriptions","organizations_url":"https://api.github.com/users/huanwu/orgs","repos_url":"https://api.github.com/users/huanwu/repos","events_url":"https://api.github.com/users/huanwu/events{/privacy}","received_events_url":"https://api.github.com/users/huanwu/received_events","type":"User","site_admin":false},"repo":{"id":61407397,"name":"corefx","full_name":"huanwu/corefx","owner":{"login":"huanwu","id":1438378,"avatar_url":"https://avatars.githubusercontent.com/u/1438378?v=3","gravatar_id":"","url":"https://api.github.com/users/huanwu","html_url":"https://github.com/huanwu","followers_url":"https://api.github.com/users/huanwu/followers","following_url":"https://api.github.com/users/huanwu/following{/other_user}","gists_url":"https://api.github.com/users/huanwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huanwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huanwu/subscriptions","organizations_url":"https://api.github.com/users/huanwu/orgs","repos_url":"https://api.github.com/users/huanwu/repos","events_url":"https://api.github.com/users/huanwu/events{/privacy}","received_events_url":"https://api.github.com/users/huanwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huanwu/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/huanwu/corefx","forks_url":"https://api.github.com/repos/huanwu/corefx/forks","keys_url":"https://api.github.com/repos/huanwu/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huanwu/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huanwu/corefx/teams","hooks_url":"https://api.github.com/repos/huanwu/corefx/hooks","issue_events_url":"https://api.github.com/repos/huanwu/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/huanwu/corefx/events","assignees_url":"https://api.github.com/repos/huanwu/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/huanwu/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/huanwu/corefx/tags","blobs_url":"https://api.github.com/repos/huanwu/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huanwu/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huanwu/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/huanwu/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huanwu/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/huanwu/corefx/languages","stargazers_url":"https://api.github.com/repos/huanwu/corefx/stargazers","contributors_url":"https://api.github.com/repos/huanwu/corefx/contributors","subscribers_url":"https://api.github.com/repos/huanwu/corefx/subscribers","subscription_url":"https://api.github.com/repos/huanwu/corefx/subscription","commits_url":"https://api.github.com/repos/huanwu/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/huanwu/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/huanwu/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/huanwu/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/huanwu/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/huanwu/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huanwu/corefx/merges","archive_url":"https://api.github.com/repos/huanwu/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huanwu/corefx/downloads","issues_url":"https://api.github.com/repos/huanwu/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/huanwu/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/huanwu/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/huanwu/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huanwu/corefx/labels{/name}","releases_url":"https://api.github.com/repos/huanwu/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/huanwu/corefx/deployments","created_at":"2016-06-17T23:14:16Z","updated_at":"2016-06-17T23:14:40Z","pushed_at":"2016-08-04T22:30:26Z","git_url":"git://github.com/huanwu/corefx.git","ssh_url":"git@github.com:huanwu/corefx.git","clone_url":"https://github.com/huanwu/corefx.git","svn_url":"https://github.com/huanwu/corefx","homepage":"https://dotnet.github.io/","size":78989,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f3b182c0b58353b0bcfb6557630ed5c08836012e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-08-08T22:24:17Z","pushed_at":"2016-08-08T23:04:37Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":125635,"stargazers_count":10336,"watchers_count":10336,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2526,"mirror_url":null,"open_issues_count":1271,"forks":2526,"open_issues":1271,"watchers":10336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10598"},"html":{"href":"https://github.com/dotnet/corefx/pull/10598"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10598"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10598/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10598/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10598/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/859cf0c6088ceb2b2cf3aaf8a88f42c12a7cf1a7"}}}}
{"actor":{"display_login":"mconnew"}}