{"action":"created","comment":{"url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/comments/64875806","id":64875806,"diff_hunk":"@@ -179,4 +184,52 @@ public function it_creates_empty_assets_folder()\n         $this->assertTrue($this->finder->isFile($this->testThemePath . '/assets/js/.gitignore'));\n         $this->assertTrue($this->finder->isFile($this->testThemePath . '/assets/images/.gitignore'));\n     }\n+\n+    /**\n+     * @group elixir\n+     * @test\n+     */\n+    public function it_does_not_create_elixir_files_when_option_is_no()","path":"Tests/ThemeScaffoldTest.php","position":21,"original_position":21,"commit_id":"bcfff7bc662988ed047fd62b617986e7098b257c","original_commit_id":"bcfff7bc662988ed047fd62b617986e7098b257c","user":{"login":"Nitpick-CI","id":12626182,"avatar_url":"https://avatars.githubusercontent.com/u/12626182?v=3","gravatar_id":"","url":"https://api.github.com/users/Nitpick-CI","html_url":"https://github.com/Nitpick-CI","followers_url":"https://api.github.com/users/Nitpick-CI/followers","following_url":"https://api.github.com/users/Nitpick-CI/following{/other_user}","gists_url":"https://api.github.com/users/Nitpick-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/Nitpick-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nitpick-CI/subscriptions","organizations_url":"https://api.github.com/users/Nitpick-CI/orgs","repos_url":"https://api.github.com/users/Nitpick-CI/repos","events_url":"https://api.github.com/users/Nitpick-CI/events{/privacy}","received_events_url":"https://api.github.com/users/Nitpick-CI/received_events","type":"User","site_admin":false},"body":"Method name `ThemeScaffoldTest::it_does_not_create_elixir_files_when_option_is_no` is not in camel caps format","created_at":"2016-05-27T08:54:20Z","updated_at":"2016-05-27T08:54:20Z","html_url":"https://github.com/AsgardCms/Workshop/pull/27#discussion_r64875806","pull_request_url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/comments/64875806"},"html":{"href":"https://github.com/AsgardCms/Workshop/pull/27#discussion_r64875806"},"pull_request":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27","id":71680442,"html_url":"https://github.com/AsgardCms/Workshop/pull/27","diff_url":"https://github.com/AsgardCms/Workshop/pull/27.diff","patch_url":"https://github.com/AsgardCms/Workshop/pull/27.patch","issue_url":"https://api.github.com/repos/AsgardCms/Workshop/issues/27","number":27,"state":"open","locked":false,"title":"Added Elixir option to ThemeScaffold","user":{"login":"originalwebgurl","id":2898748,"avatar_url":"https://avatars.githubusercontent.com/u/2898748?v=3","gravatar_id":"","url":"https://api.github.com/users/originalwebgurl","html_url":"https://github.com/originalwebgurl","followers_url":"https://api.github.com/users/originalwebgurl/followers","following_url":"https://api.github.com/users/originalwebgurl/following{/other_user}","gists_url":"https://api.github.com/users/originalwebgurl/gists{/gist_id}","starred_url":"https://api.github.com/users/originalwebgurl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/originalwebgurl/subscriptions","organizations_url":"https://api.github.com/users/originalwebgurl/orgs","repos_url":"https://api.github.com/users/originalwebgurl/repos","events_url":"https://api.github.com/users/originalwebgurl/events{/privacy}","received_events_url":"https://api.github.com/users/originalwebgurl/received_events","type":"User","site_admin":false},"body":"Not sure if this is something you'd want for this module. I was planning to put it in a separate one but thought I'd check in first to see if you'd prefer to have it as part of the existing ThemeScaffold. \r\n\r\nAdded the option to include elixir as part of the theme scaffolding. During the setup you can choose to include elixir and specify the version if you like.\r\n\r\nIf you choose to include Elixir as part of the theme scaffolding it will be configured to look for source files in THEME_NAME/resources and generate your assets within your THEME_NAME/assets directory.\r\n\r\nIt also includes the 'stylistPublish' Elixir extension. An updated version of the snippet documented here: https://asgardcms.com/docs/themes/usage#elixir\r\n\r\nNew unit tests were added to make sure it's backwards compatible. No elixir files are created when you choose 'no' during setup. Tests were added to validate the elixir files get created as well when you choose 'yes' during setup.\r\n\r\nTo manually test:\r\n```\r\nphp artisan asgard:theme:scaffold\r\n// 1. 'vendor/themename' [Enter]\r\n// 2. 'frontend' [Enter]\r\n// 3. 'Yes' [Enter]\r\n// 4. '*' [Enter]\r\n// 5. '*' [Enter]\r\ncd Themes/themename\r\nnpm install\r\n// add a css or less file to be mixed in\r\ngulp\r\n// see the generated file in Themes/themename/assets\r\n// see the published assets in public/themes/themename\r\n```\r\n\r\nThe .php_cs file seems to be out-dated so I ran this (tried to match it up as best as I could)\r\n```\r\nphp-cs-fixer fix . --rules=@PSR1,@PSR2,concat_with_spaces,ordered_imports,no_extra_consecutive_blank_lines,no_useless_return,no_unused_imports,no_whitespace_in_blank_lines --verbose --dry-run\r\n```\r\nNot sure if you're still following the PSR2 standards since most of the files failed the unix line endings test, so I left them as-is.","created_at":"2016-05-27T08:54:10Z","updated_at":"2016-05-27T08:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07b21a73d052b704c9ceb8f4fe706f387ee7c7b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27/commits","review_comments_url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27/comments","review_comment_url":"https://api.github.com/repos/AsgardCms/Workshop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AsgardCms/Workshop/issues/27/comments","statuses_url":"https://api.github.com/repos/AsgardCms/Workshop/statuses/bcfff7bc662988ed047fd62b617986e7098b257c","head":{"label":"originalwebgurl:feature/theme-scaffold-with-elixir","ref":"feature/theme-scaffold-with-elixir","sha":"bcfff7bc662988ed047fd62b617986e7098b257c","user":{"login":"originalwebgurl","id":2898748,"avatar_url":"https://avatars.githubusercontent.com/u/2898748?v=3","gravatar_id":"","url":"https://api.github.com/users/originalwebgurl","html_url":"https://github.com/originalwebgurl","followers_url":"https://api.github.com/users/originalwebgurl/followers","following_url":"https://api.github.com/users/originalwebgurl/following{/other_user}","gists_url":"https://api.github.com/users/originalwebgurl/gists{/gist_id}","starred_url":"https://api.github.com/users/originalwebgurl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/originalwebgurl/subscriptions","organizations_url":"https://api.github.com/users/originalwebgurl/orgs","repos_url":"https://api.github.com/users/originalwebgurl/repos","events_url":"https://api.github.com/users/originalwebgurl/events{/privacy}","received_events_url":"https://api.github.com/users/originalwebgurl/received_events","type":"User","site_admin":false},"repo":{"id":59787230,"name":"Workshop","full_name":"originalwebgurl/Workshop","owner":{"login":"originalwebgurl","id":2898748,"avatar_url":"https://avatars.githubusercontent.com/u/2898748?v=3","gravatar_id":"","url":"https://api.github.com/users/originalwebgurl","html_url":"https://github.com/originalwebgurl","followers_url":"https://api.github.com/users/originalwebgurl/followers","following_url":"https://api.github.com/users/originalwebgurl/following{/other_user}","gists_url":"https://api.github.com/users/originalwebgurl/gists{/gist_id}","starred_url":"https://api.github.com/users/originalwebgurl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/originalwebgurl/subscriptions","organizations_url":"https://api.github.com/users/originalwebgurl/orgs","repos_url":"https://api.github.com/users/originalwebgurl/repos","events_url":"https://api.github.com/users/originalwebgurl/events{/privacy}","received_events_url":"https://api.github.com/users/originalwebgurl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/originalwebgurl/Workshop","description":"Workshop module is used to enable/disable modules. And run multiple commands on those modules.","fork":true,"url":"https://api.github.com/repos/originalwebgurl/Workshop","forks_url":"https://api.github.com/repos/originalwebgurl/Workshop/forks","keys_url":"https://api.github.com/repos/originalwebgurl/Workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/originalwebgurl/Workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/originalwebgurl/Workshop/teams","hooks_url":"https://api.github.com/repos/originalwebgurl/Workshop/hooks","issue_events_url":"https://api.github.com/repos/originalwebgurl/Workshop/issues/events{/number}","events_url":"https://api.github.com/repos/originalwebgurl/Workshop/events","assignees_url":"https://api.github.com/repos/originalwebgurl/Workshop/assignees{/user}","branches_url":"https://api.github.com/repos/originalwebgurl/Workshop/branches{/branch}","tags_url":"https://api.github.com/repos/originalwebgurl/Workshop/tags","blobs_url":"https://api.github.com/repos/originalwebgurl/Workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/originalwebgurl/Workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/originalwebgurl/Workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/originalwebgurl/Workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/originalwebgurl/Workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/originalwebgurl/Workshop/languages","stargazers_url":"https://api.github.com/repos/originalwebgurl/Workshop/stargazers","contributors_url":"https://api.github.com/repos/originalwebgurl/Workshop/contributors","subscribers_url":"https://api.github.com/repos/originalwebgurl/Workshop/subscribers","subscription_url":"https://api.github.com/repos/originalwebgurl/Workshop/subscription","commits_url":"https://api.github.com/repos/originalwebgurl/Workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/originalwebgurl/Workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/originalwebgurl/Workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/originalwebgurl/Workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/originalwebgurl/Workshop/contents/{+path}","compare_url":"https://api.github.com/repos/originalwebgurl/Workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/originalwebgurl/Workshop/merges","archive_url":"https://api.github.com/repos/originalwebgurl/Workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/originalwebgurl/Workshop/downloads","issues_url":"https://api.github.com/repos/originalwebgurl/Workshop/issues{/number}","pulls_url":"https://api.github.com/repos/originalwebgurl/Workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/originalwebgurl/Workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/originalwebgurl/Workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/originalwebgurl/Workshop/labels{/name}","releases_url":"https://api.github.com/repos/originalwebgurl/Workshop/releases{/id}","deployments_url":"https://api.github.com/repos/originalwebgurl/Workshop/deployments","created_at":"2016-05-26T22:29:06Z","updated_at":"2016-05-26T22:29:08Z","pushed_at":"2016-05-27T08:40:39Z","git_url":"git://github.com/originalwebgurl/Workshop.git","ssh_url":"git@github.com:originalwebgurl/Workshop.git","clone_url":"https://github.com/originalwebgurl/Workshop.git","svn_url":"https://github.com/originalwebgurl/Workshop","homepage":"","size":311,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AsgardCms:master","ref":"master","sha":"263e31570a505f9d5ba5ede45d8819782238d2e2","user":{"login":"AsgardCms","id":8859068,"avatar_url":"https://avatars.githubusercontent.com/u/8859068?v=3","gravatar_id":"","url":"https://api.github.com/users/AsgardCms","html_url":"https://github.com/AsgardCms","followers_url":"https://api.github.com/users/AsgardCms/followers","following_url":"https://api.github.com/users/AsgardCms/following{/other_user}","gists_url":"https://api.github.com/users/AsgardCms/gists{/gist_id}","starred_url":"https://api.github.com/users/AsgardCms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsgardCms/subscriptions","organizations_url":"https://api.github.com/users/AsgardCms/orgs","repos_url":"https://api.github.com/users/AsgardCms/repos","events_url":"https://api.github.com/users/AsgardCms/events{/privacy}","received_events_url":"https://api.github.com/users/AsgardCms/received_events","type":"Organization","site_admin":false},"repo":{"id":24512288,"name":"Workshop","full_name":"AsgardCms/Workshop","owner":{"login":"AsgardCms","id":8859068,"avatar_url":"https://avatars.githubusercontent.com/u/8859068?v=3","gravatar_id":"","url":"https://api.github.com/users/AsgardCms","html_url":"https://github.com/AsgardCms","followers_url":"https://api.github.com/users/AsgardCms/followers","following_url":"https://api.github.com/users/AsgardCms/following{/other_user}","gists_url":"https://api.github.com/users/AsgardCms/gists{/gist_id}","starred_url":"https://api.github.com/users/AsgardCms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsgardCms/subscriptions","organizations_url":"https://api.github.com/users/AsgardCms/orgs","repos_url":"https://api.github.com/users/AsgardCms/repos","events_url":"https://api.github.com/users/AsgardCms/events{/privacy}","received_events_url":"https://api.github.com/users/AsgardCms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AsgardCms/Workshop","description":"Workshop module is used to enable/disable modules. And run multiple commands on those modules.","fork":false,"url":"https://api.github.com/repos/AsgardCms/Workshop","forks_url":"https://api.github.com/repos/AsgardCms/Workshop/forks","keys_url":"https://api.github.com/repos/AsgardCms/Workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AsgardCms/Workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AsgardCms/Workshop/teams","hooks_url":"https://api.github.com/repos/AsgardCms/Workshop/hooks","issue_events_url":"https://api.github.com/repos/AsgardCms/Workshop/issues/events{/number}","events_url":"https://api.github.com/repos/AsgardCms/Workshop/events","assignees_url":"https://api.github.com/repos/AsgardCms/Workshop/assignees{/user}","branches_url":"https://api.github.com/repos/AsgardCms/Workshop/branches{/branch}","tags_url":"https://api.github.com/repos/AsgardCms/Workshop/tags","blobs_url":"https://api.github.com/repos/AsgardCms/Workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AsgardCms/Workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AsgardCms/Workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/AsgardCms/Workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AsgardCms/Workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/AsgardCms/Workshop/languages","stargazers_url":"https://api.github.com/repos/AsgardCms/Workshop/stargazers","contributors_url":"https://api.github.com/repos/AsgardCms/Workshop/contributors","subscribers_url":"https://api.github.com/repos/AsgardCms/Workshop/subscribers","subscription_url":"https://api.github.com/repos/AsgardCms/Workshop/subscription","commits_url":"https://api.github.com/repos/AsgardCms/Workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/AsgardCms/Workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/AsgardCms/Workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/AsgardCms/Workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/AsgardCms/Workshop/contents/{+path}","compare_url":"https://api.github.com/repos/AsgardCms/Workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AsgardCms/Workshop/merges","archive_url":"https://api.github.com/repos/AsgardCms/Workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AsgardCms/Workshop/downloads","issues_url":"https://api.github.com/repos/AsgardCms/Workshop/issues{/number}","pulls_url":"https://api.github.com/repos/AsgardCms/Workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/AsgardCms/Workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/AsgardCms/Workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AsgardCms/Workshop/labels{/name}","releases_url":"https://api.github.com/repos/AsgardCms/Workshop/releases{/id}","deployments_url":"https://api.github.com/repos/AsgardCms/Workshop/deployments","created_at":"2014-09-26T19:17:33Z","updated_at":"2016-05-06T15:04:00Z","pushed_at":"2016-05-27T08:54:12Z","git_url":"git://github.com/AsgardCms/Workshop.git","ssh_url":"git@github.com:AsgardCms/Workshop.git","clone_url":"https://github.com/AsgardCms/Workshop.git","svn_url":"https://github.com/AsgardCms/Workshop","homepage":"","size":321,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27"},"html":{"href":"https://github.com/AsgardCms/Workshop/pull/27"},"issue":{"href":"https://api.github.com/repos/AsgardCms/Workshop/issues/27"},"comments":{"href":"https://api.github.com/repos/AsgardCms/Workshop/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AsgardCms/Workshop/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/AsgardCms/Workshop/statuses/bcfff7bc662988ed047fd62b617986e7098b257c"}}}}
{"actor":{"display_login":"Nitpick-CI"}}