{"action":"created","issue":{"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/129","labels_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/129/comments","events_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/129/events","html_url":"https://github.com/BigNoid/script.skinshortcuts/pull/129","id":127771451,"number":129,"title":"End user-focused changes","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-20T19:59:12Z","updated_at":"2016-01-26T07:14:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/129","html_url":"https://github.com/BigNoid/script.skinshortcuts/pull/129","diff_url":"https://github.com/BigNoid/script.skinshortcuts/pull/129.diff","patch_url":"https://github.com/BigNoid/script.skinshortcuts/pull/129.patch"},"body":"These commits are various changes to the script primarily aimed at the end users, unlike most commits which are normally requested by skinners.\r\n\r\n- Context menu extension point (enabled from settings) to add any folder directly to the home menu, including auto-filling the submenu\r\n- Language changes, moving away from referring to 'shortcuts' towards 'menu items', also should clear up some functions (choose shortcut/change action)\r\n- Add option not to hide PVR shortcuts (requested feature)\r\n- Use mtime, not hash of file, to determine if .DATA.xml/property files/overrides/etc have changed - should reduce disk access significantly\r\n- Oft requested feature, the ability for users to specify that their menus aren't shared amongst skins utilising the script, plus ability to import menu from another skin\r\n- Fix for disappearing icons between skins - icons and thumbs are now saved in the skins .properties file\r\n\r\nAlso bumps version and docs to mark unstable.\r\n\r\nContext menu required xbmc.python 2.20.0 (Isengard), but I believe the script is on the Isengard repo...?\r\n\r\nThe non-sharing skins feature requires changes to skin.helper.service's backup functions, which I will PR separately.\r\n\r\nThe language changes will probably only be effective if the script is added onto Transifex.\r\n\r\n@marcelveldt do you have time to give these changes a look through?"},"comment":{"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/comments/174866997","html_url":"https://github.com/BigNoid/script.skinshortcuts/pull/129#issuecomment-174866997","issue_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/129","id":174866997,"user":{"login":"guidosarducci","id":14342969,"avatar_url":"https://avatars.githubusercontent.com/u/14342969?v=3","gravatar_id":"","url":"https://api.github.com/users/guidosarducci","html_url":"https://github.com/guidosarducci","followers_url":"https://api.github.com/users/guidosarducci/followers","following_url":"https://api.github.com/users/guidosarducci/following{/other_user}","gists_url":"https://api.github.com/users/guidosarducci/gists{/gist_id}","starred_url":"https://api.github.com/users/guidosarducci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidosarducci/subscriptions","organizations_url":"https://api.github.com/users/guidosarducci/orgs","repos_url":"https://api.github.com/users/guidosarducci/repos","events_url":"https://api.github.com/users/guidosarducci/events{/privacy}","received_events_url":"https://api.github.com/users/guidosarducci/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T07:14:03Z","updated_at":"2016-01-26T07:14:03Z","body":"@Ignoble61  These are very welcome changes -- thank you!  I had previously been trying out the non-shared menu changes from your UX branch, but suggest making non-shared menus the default addon setting since it is much less frustrating for users.\r\n\r\nFor example, a common case is when a long-time skin user tries to test-drive a new skin, does some simple configuration, but then returns to the old skin to find the original menus messed up.  I also want to mention that in the 4-5 skinshortcut-enabled skins where I've tweaked menus to my liking, the menus ended up different between the skins, again making non-shared menus preferable."}}