{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55","id":70976927,"html_url":"https://github.com/smarthomeNG/smarthome/pull/55","diff_url":"https://github.com/smarthomeNG/smarthome/pull/55.diff","patch_url":"https://github.com/smarthomeNG/smarthome/pull/55.patch","issue_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/55","number":55,"state":"closed","locked":false,"title":"Check plugin arguments before instatiation","user":{"login":"ohinckel","id":717217,"avatar_url":"https://avatars.githubusercontent.com/u/717217?v=3","gravatar_id":"","url":"https://api.github.com/users/ohinckel","html_url":"https://github.com/ohinckel","followers_url":"https://api.github.com/users/ohinckel/followers","following_url":"https://api.github.com/users/ohinckel/following{/other_user}","gists_url":"https://api.github.com/users/ohinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/ohinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohinckel/subscriptions","organizations_url":"https://api.github.com/users/ohinckel/orgs","repos_url":"https://api.github.com/users/ohinckel/repos","events_url":"https://api.github.com/users/ohinckel/events{/privacy}","received_events_url":"https://api.github.com/users/ohinckel/received_events","type":"User","site_admin":false},"body":"This patch will only handle named arguments of plugin which are really supported. All other configuration settings will be just ignored.\r\n\r\nThis will also make the plugin setup more robust by not completely failing in case of a wrong parameter name in the plugin configuration.\r\n\r\nOn the other hand this is using the inspect module to find out which parameters are supported by the plugin. It could be too much overhead for just having a more robust plugin setup.\r\n\r\nBut decide yourself ;-)","created_at":"2016-05-22T13:21:07Z","updated_at":"2016-05-31T17:59:13Z","closed_at":"2016-05-31T17:59:13Z","merged_at":null,"merge_commit_sha":"afd6778647f6ddc91a5acd17fbfde92cf262d38a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55/commits","review_comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55/comments","review_comment_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/55/comments","statuses_url":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/cd66b9b667dc5d07fcbc6004d8afa028d8c7af7d","head":{"label":"ohinckel:dev-plugin-namedargs","ref":"dev-plugin-namedargs","sha":"cd66b9b667dc5d07fcbc6004d8afa028d8c7af7d","user":{"login":"ohinckel","id":717217,"avatar_url":"https://avatars.githubusercontent.com/u/717217?v=3","gravatar_id":"","url":"https://api.github.com/users/ohinckel","html_url":"https://github.com/ohinckel","followers_url":"https://api.github.com/users/ohinckel/followers","following_url":"https://api.github.com/users/ohinckel/following{/other_user}","gists_url":"https://api.github.com/users/ohinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/ohinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohinckel/subscriptions","organizations_url":"https://api.github.com/users/ohinckel/orgs","repos_url":"https://api.github.com/users/ohinckel/repos","events_url":"https://api.github.com/users/ohinckel/events{/privacy}","received_events_url":"https://api.github.com/users/ohinckel/received_events","type":"User","site_admin":false},"repo":{"id":58805414,"name":"smarthome","full_name":"ohinckel/smarthome","owner":{"login":"ohinckel","id":717217,"avatar_url":"https://avatars.githubusercontent.com/u/717217?v=3","gravatar_id":"","url":"https://api.github.com/users/ohinckel","html_url":"https://github.com/ohinckel","followers_url":"https://api.github.com/users/ohinckel/followers","following_url":"https://api.github.com/users/ohinckel/following{/other_user}","gists_url":"https://api.github.com/users/ohinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/ohinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohinckel/subscriptions","organizations_url":"https://api.github.com/users/ohinckel/orgs","repos_url":"https://api.github.com/users/ohinckel/repos","events_url":"https://api.github.com/users/ohinckel/events{/privacy}","received_events_url":"https://api.github.com/users/ohinckel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ohinckel/smarthome","description":"","fork":true,"url":"https://api.github.com/repos/ohinckel/smarthome","forks_url":"https://api.github.com/repos/ohinckel/smarthome/forks","keys_url":"https://api.github.com/repos/ohinckel/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ohinckel/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ohinckel/smarthome/teams","hooks_url":"https://api.github.com/repos/ohinckel/smarthome/hooks","issue_events_url":"https://api.github.com/repos/ohinckel/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/ohinckel/smarthome/events","assignees_url":"https://api.github.com/repos/ohinckel/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/ohinckel/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/ohinckel/smarthome/tags","blobs_url":"https://api.github.com/repos/ohinckel/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ohinckel/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ohinckel/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/ohinckel/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ohinckel/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/ohinckel/smarthome/languages","stargazers_url":"https://api.github.com/repos/ohinckel/smarthome/stargazers","contributors_url":"https://api.github.com/repos/ohinckel/smarthome/contributors","subscribers_url":"https://api.github.com/repos/ohinckel/smarthome/subscribers","subscription_url":"https://api.github.com/repos/ohinckel/smarthome/subscription","commits_url":"https://api.github.com/repos/ohinckel/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/ohinckel/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/ohinckel/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/ohinckel/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/ohinckel/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/ohinckel/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ohinckel/smarthome/merges","archive_url":"https://api.github.com/repos/ohinckel/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ohinckel/smarthome/downloads","issues_url":"https://api.github.com/repos/ohinckel/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/ohinckel/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/ohinckel/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/ohinckel/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ohinckel/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/ohinckel/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/ohinckel/smarthome/deployments","created_at":"2016-05-14T11:54:53Z","updated_at":"2016-05-14T11:55:43Z","pushed_at":"2016-05-22T13:18:14Z","git_url":"git://github.com/ohinckel/smarthome.git","ssh_url":"git@github.com:ohinckel/smarthome.git","clone_url":"https://github.com/ohinckel/smarthome.git","svn_url":"https://github.com/ohinckel/smarthome","homepage":"","size":6639,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smarthomeNG:develop","ref":"develop","sha":"5c143bb0fc307ac0258d37822460a714c24efaa2","user":{"login":"smarthomeNG","id":17847102,"avatar_url":"https://avatars.githubusercontent.com/u/17847102?v=3","gravatar_id":"","url":"https://api.github.com/users/smarthomeNG","html_url":"https://github.com/smarthomeNG","followers_url":"https://api.github.com/users/smarthomeNG/followers","following_url":"https://api.github.com/users/smarthomeNG/following{/other_user}","gists_url":"https://api.github.com/users/smarthomeNG/gists{/gist_id}","starred_url":"https://api.github.com/users/smarthomeNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarthomeNG/subscriptions","organizations_url":"https://api.github.com/users/smarthomeNG/orgs","repos_url":"https://api.github.com/users/smarthomeNG/repos","events_url":"https://api.github.com/users/smarthomeNG/events{/privacy}","received_events_url":"https://api.github.com/users/smarthomeNG/received_events","type":"Organization","site_admin":false},"repo":{"id":53928710,"name":"smarthome","full_name":"smarthomeNG/smarthome","owner":{"login":"smarthomeNG","id":17847102,"avatar_url":"https://avatars.githubusercontent.com/u/17847102?v=3","gravatar_id":"","url":"https://api.github.com/users/smarthomeNG","html_url":"https://github.com/smarthomeNG","followers_url":"https://api.github.com/users/smarthomeNG/followers","following_url":"https://api.github.com/users/smarthomeNG/following{/other_user}","gists_url":"https://api.github.com/users/smarthomeNG/gists{/gist_id}","starred_url":"https://api.github.com/users/smarthomeNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarthomeNG/subscriptions","organizations_url":"https://api.github.com/users/smarthomeNG/orgs","repos_url":"https://api.github.com/users/smarthomeNG/repos","events_url":"https://api.github.com/users/smarthomeNG/events{/privacy}","received_events_url":"https://api.github.com/users/smarthomeNG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smarthomeNG/smarthome","description":"","fork":false,"url":"https://api.github.com/repos/smarthomeNG/smarthome","forks_url":"https://api.github.com/repos/smarthomeNG/smarthome/forks","keys_url":"https://api.github.com/repos/smarthomeNG/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smarthomeNG/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smarthomeNG/smarthome/teams","hooks_url":"https://api.github.com/repos/smarthomeNG/smarthome/hooks","issue_events_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/smarthomeNG/smarthome/events","assignees_url":"https://api.github.com/repos/smarthomeNG/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/smarthomeNG/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/smarthomeNG/smarthome/tags","blobs_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/smarthomeNG/smarthome/languages","stargazers_url":"https://api.github.com/repos/smarthomeNG/smarthome/stargazers","contributors_url":"https://api.github.com/repos/smarthomeNG/smarthome/contributors","subscribers_url":"https://api.github.com/repos/smarthomeNG/smarthome/subscribers","subscription_url":"https://api.github.com/repos/smarthomeNG/smarthome/subscription","commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/smarthomeNG/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/smarthomeNG/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smarthomeNG/smarthome/merges","archive_url":"https://api.github.com/repos/smarthomeNG/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smarthomeNG/smarthome/downloads","issues_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/smarthomeNG/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/smarthomeNG/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smarthomeNG/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/smarthomeNG/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/smarthomeNG/smarthome/deployments","created_at":"2016-03-15T08:49:44Z","updated_at":"2016-05-31T12:01:52Z","pushed_at":"2016-05-31T13:57:29Z","git_url":"git://github.com/smarthomeNG/smarthome.git","ssh_url":"git@github.com:smarthomeNG/smarthome.git","clone_url":"https://github.com/smarthomeNG/smarthome.git","svn_url":"https://github.com/smarthomeNG/smarthome","homepage":"","size":8479,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":15,"forks":16,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55"},"html":{"href":"https://github.com/smarthomeNG/smarthome/pull/55"},"issue":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/issues/55"},"comments":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/cd66b9b667dc5d07fcbc6004d8afa028d8c7af7d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":12,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ohinckel"}}