{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/streams/pulls/comments/83154105","pull_request_review_id":4013070,"id":83154105,"diff_hunk":"@@ -209,11 +193,8 @@ async_test(t => {\n \n     resolveFirstWritePromise();\n \n-    writePromise\n-        .then(t.step_func(() => {\n-          assert_equals(writeCount, numberOfWrites, `should have called sink's write ${numberOfWrites} times`);\n-          t.done();\n-        }))\n-        .catch(t.step_func(() => assert_unreached('writePromise should not be rejected')));\n-  }), 0);\n+    return writePromise\n+        .then(() =>\n+        assert_equals(writeCount, numberOfWrites, `should have called sink's write ${numberOfWrites} times`));","path":"reference-implementation/to-upstream-wpts/writable-streams/write.js","position":null,"original_position":211,"commit_id":"4e9e7ce27650b1551788df85edc2e4bc19b500a6","original_commit_id":"51c96137e385f59a6097e1f74239358a8ec8606f","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-10-13T07:01:22Z","updated_at":"2016-10-13T07:01:22Z","html_url":"https://github.com/whatwg/streams/pull/534#discussion_r83154105","pull_request_url":"https://api.github.com/repos/whatwg/streams/pulls/534","_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments/83154105"},"html":{"href":"https://github.com/whatwg/streams/pull/534#discussion_r83154105"},"pull_request":{"href":"https://api.github.com/repos/whatwg/streams/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/streams/pulls/534","id":88986909,"html_url":"https://github.com/whatwg/streams/pull/534","diff_url":"https://github.com/whatwg/streams/pull/534.diff","patch_url":"https://github.com/whatwg/streams/pull/534.patch","issue_url":"https://api.github.com/repos/whatwg/streams/issues/534","number":534,"state":"open","locked":false,"title":"Eliminate usages of async_test","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"body":"Replace all usages of async_test in the wpt writable-streams tests with\r\npromise_test. promise_test is easier to work with than async_test.\r\n\r\nAlso remove the 'a' from close('a') (it did nothing).","created_at":"2016-10-12T10:01:17Z","updated_at":"2016-10-13T07:01:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d55b0eee678c5e375f003be0a3b6fd5291babcfe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/streams/pulls/534/commits","review_comments_url":"https://api.github.com/repos/whatwg/streams/pulls/534/comments","review_comment_url":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/534/comments","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/4e9e7ce27650b1551788df85edc2e4bc19b500a6","head":{"label":"ricea:wpt_write_async_tests","ref":"wpt_write_async_tests","sha":"4e9e7ce27650b1551788df85edc2e4bc19b500a6","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"repo":{"id":64450373,"name":"streams","full_name":"ricea/streams","owner":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricea/streams","description":"Streams Standard","fork":true,"url":"https://api.github.com/repos/ricea/streams","forks_url":"https://api.github.com/repos/ricea/streams/forks","keys_url":"https://api.github.com/repos/ricea/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricea/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricea/streams/teams","hooks_url":"https://api.github.com/repos/ricea/streams/hooks","issue_events_url":"https://api.github.com/repos/ricea/streams/issues/events{/number}","events_url":"https://api.github.com/repos/ricea/streams/events","assignees_url":"https://api.github.com/repos/ricea/streams/assignees{/user}","branches_url":"https://api.github.com/repos/ricea/streams/branches{/branch}","tags_url":"https://api.github.com/repos/ricea/streams/tags","blobs_url":"https://api.github.com/repos/ricea/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricea/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricea/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricea/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricea/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/ricea/streams/languages","stargazers_url":"https://api.github.com/repos/ricea/streams/stargazers","contributors_url":"https://api.github.com/repos/ricea/streams/contributors","subscribers_url":"https://api.github.com/repos/ricea/streams/subscribers","subscription_url":"https://api.github.com/repos/ricea/streams/subscription","commits_url":"https://api.github.com/repos/ricea/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricea/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricea/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricea/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricea/streams/contents/{+path}","compare_url":"https://api.github.com/repos/ricea/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricea/streams/merges","archive_url":"https://api.github.com/repos/ricea/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricea/streams/downloads","issues_url":"https://api.github.com/repos/ricea/streams/issues{/number}","pulls_url":"https://api.github.com/repos/ricea/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/ricea/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/ricea/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricea/streams/labels{/name}","releases_url":"https://api.github.com/repos/ricea/streams/releases{/id}","deployments_url":"https://api.github.com/repos/ricea/streams/deployments","created_at":"2016-07-29T04:28:21Z","updated_at":"2016-07-29T04:28:21Z","pushed_at":"2016-10-13T07:00:19Z","git_url":"git://github.com/ricea/streams.git","ssh_url":"git@github.com:ricea/streams.git","clone_url":"https://github.com/ricea/streams.git","svn_url":"https://github.com/ricea/streams","homepage":"https://streams.spec.whatwg.org/","size":2002,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"8a671b6cc3670cce3a93567e9324c27d0c6aa435","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":13962843,"name":"streams","full_name":"whatwg/streams","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/streams","description":"Streams Standard","fork":false,"url":"https://api.github.com/repos/whatwg/streams","forks_url":"https://api.github.com/repos/whatwg/streams/forks","keys_url":"https://api.github.com/repos/whatwg/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/streams/teams","hooks_url":"https://api.github.com/repos/whatwg/streams/hooks","issue_events_url":"https://api.github.com/repos/whatwg/streams/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/streams/events","assignees_url":"https://api.github.com/repos/whatwg/streams/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/streams/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/streams/tags","blobs_url":"https://api.github.com/repos/whatwg/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/streams/languages","stargazers_url":"https://api.github.com/repos/whatwg/streams/stargazers","contributors_url":"https://api.github.com/repos/whatwg/streams/contributors","subscribers_url":"https://api.github.com/repos/whatwg/streams/subscribers","subscription_url":"https://api.github.com/repos/whatwg/streams/subscription","commits_url":"https://api.github.com/repos/whatwg/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/streams/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/streams/merges","archive_url":"https://api.github.com/repos/whatwg/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/streams/downloads","issues_url":"https://api.github.com/repos/whatwg/streams/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/streams/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/streams/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/streams/deployments","created_at":"2013-10-29T17:16:58Z","updated_at":"2016-10-09T01:57:59Z","pushed_at":"2016-10-13T07:00:20Z","git_url":"git://github.com/whatwg/streams.git","ssh_url":"git@github.com:whatwg/streams.git","clone_url":"https://github.com/whatwg/streams.git","svn_url":"https://github.com/whatwg/streams","homepage":"https://streams.spec.whatwg.org/","size":2705,"stargazers_count":583,"watchers_count":583,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":53,"forks":54,"open_issues":53,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/534"},"html":{"href":"https://github.com/whatwg/streams/pull/534"},"issue":{"href":"https://api.github.com/repos/whatwg/streams/issues/534"},"comments":{"href":"https://api.github.com/repos/whatwg/streams/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/streams/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/streams/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/streams/statuses/4e9e7ce27650b1551788df85edc2e4bc19b500a6"}}}}
{"actor":{"display_login":"ricea"}}