{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/fiat/pulls/comments/72526593","id":72526593,"diff_hunk":"@@ -4,6 +4,11 @@ server:\n redis:\n   connection: ${services.redis.connection:redis://localhost:6379}\n \n+services:\n+  connection:\n+    retryBackoff:\n+      maxSeconds: 5","path":"fiat-web/config/fiat.yml","position":7,"original_position":7,"commit_id":"b4e481f947c1b65c3a27b74eea683bd37c8bf238","original_commit_id":"b4e481f947c1b65c3a27b74eea683bd37c8bf238","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"Should this live in the normal `okHttpClient` config block vs. introducing a new section?\r\n\r\n```\r\nokHttpClient:\r\n  retryBackOff:\r\n    maxSeconds: 5\r\n```\r\n\r\nConsistency might see this as `okHttpClient.retries.maxElapsedBackoffMs` as we've used milliseconds for other config values.\r\n\r\nOtherwise LGTM.","created_at":"2016-07-27T21:23:15Z","updated_at":"2016-07-27T21:23:15Z","html_url":"https://github.com/spinnaker/fiat/pull/21#discussion_r72526593","pull_request_url":"https://api.github.com/repos/spinnaker/fiat/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/comments/72526593"},"html":{"href":"https://github.com/spinnaker/fiat/pull/21#discussion_r72526593"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/fiat/pulls/21","id":79085035,"html_url":"https://github.com/spinnaker/fiat/pull/21","diff_url":"https://github.com/spinnaker/fiat/pull/21.diff","patch_url":"https://github.com/spinnaker/fiat/pull/21.patch","issue_url":"https://api.github.com/repos/spinnaker/fiat/issues/21","number":21,"state":"open","locked":false,"title":"Adds retrying interceptor for all Retrofit calls. Introduces Provider…","user":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"body":"…Exception as common exception between all providers. \r\n\r\nAlso introduces the notion of a \"partial permission\", where one or both of the dependent components were down at the time the permission was resolved. In this case, whatever is in the repo is not overrwritten. I'll take the next PR to make the server unhealthy if after some time or X failed calls, as the data is now stale.\r\n\r\n@jtk54 @duftler @cfieber @ajordens - PTAL ","created_at":"2016-07-27T19:42:09Z","updated_at":"2016-07-27T21:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6c4c514e0fec652489c3e1f1cb3ff093332a135","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/fiat/pulls/21/commits","review_comments_url":"https://api.github.com/repos/spinnaker/fiat/pulls/21/comments","review_comment_url":"https://api.github.com/repos/spinnaker/fiat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/fiat/issues/21/comments","statuses_url":"https://api.github.com/repos/spinnaker/fiat/statuses/b4e481f947c1b65c3a27b74eea683bd37c8bf238","head":{"label":"ttomsu:google-retry","ref":"google-retry","sha":"b4e481f947c1b65c3a27b74eea683bd37c8bf238","user":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"repo":{"id":62735000,"name":"fiat","full_name":"ttomsu/fiat","owner":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttomsu/fiat","description":"Spinnaker auth service","fork":true,"url":"https://api.github.com/repos/ttomsu/fiat","forks_url":"https://api.github.com/repos/ttomsu/fiat/forks","keys_url":"https://api.github.com/repos/ttomsu/fiat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttomsu/fiat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttomsu/fiat/teams","hooks_url":"https://api.github.com/repos/ttomsu/fiat/hooks","issue_events_url":"https://api.github.com/repos/ttomsu/fiat/issues/events{/number}","events_url":"https://api.github.com/repos/ttomsu/fiat/events","assignees_url":"https://api.github.com/repos/ttomsu/fiat/assignees{/user}","branches_url":"https://api.github.com/repos/ttomsu/fiat/branches{/branch}","tags_url":"https://api.github.com/repos/ttomsu/fiat/tags","blobs_url":"https://api.github.com/repos/ttomsu/fiat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttomsu/fiat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttomsu/fiat/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttomsu/fiat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttomsu/fiat/statuses/{sha}","languages_url":"https://api.github.com/repos/ttomsu/fiat/languages","stargazers_url":"https://api.github.com/repos/ttomsu/fiat/stargazers","contributors_url":"https://api.github.com/repos/ttomsu/fiat/contributors","subscribers_url":"https://api.github.com/repos/ttomsu/fiat/subscribers","subscription_url":"https://api.github.com/repos/ttomsu/fiat/subscription","commits_url":"https://api.github.com/repos/ttomsu/fiat/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttomsu/fiat/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttomsu/fiat/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttomsu/fiat/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttomsu/fiat/contents/{+path}","compare_url":"https://api.github.com/repos/ttomsu/fiat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttomsu/fiat/merges","archive_url":"https://api.github.com/repos/ttomsu/fiat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttomsu/fiat/downloads","issues_url":"https://api.github.com/repos/ttomsu/fiat/issues{/number}","pulls_url":"https://api.github.com/repos/ttomsu/fiat/pulls{/number}","milestones_url":"https://api.github.com/repos/ttomsu/fiat/milestones{/number}","notifications_url":"https://api.github.com/repos/ttomsu/fiat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttomsu/fiat/labels{/name}","releases_url":"https://api.github.com/repos/ttomsu/fiat/releases{/id}","deployments_url":"https://api.github.com/repos/ttomsu/fiat/deployments","created_at":"2016-07-06T16:06:48Z","updated_at":"2016-07-15T13:48:59Z","pushed_at":"2016-07-27T19:35:07Z","git_url":"git://github.com/ttomsu/fiat.git","ssh_url":"git@github.com:ttomsu/fiat.git","clone_url":"https://github.com/ttomsu/fiat.git","svn_url":"https://github.com/ttomsu/fiat","homepage":null,"size":173,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"c0f618e221eb63c76d68e38c00abbafd646d2003","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":61139592,"name":"fiat","full_name":"spinnaker/fiat","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/fiat","description":"Spinnaker auth service","fork":false,"url":"https://api.github.com/repos/spinnaker/fiat","forks_url":"https://api.github.com/repos/spinnaker/fiat/forks","keys_url":"https://api.github.com/repos/spinnaker/fiat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/fiat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/fiat/teams","hooks_url":"https://api.github.com/repos/spinnaker/fiat/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/fiat/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/fiat/events","assignees_url":"https://api.github.com/repos/spinnaker/fiat/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/fiat/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/fiat/tags","blobs_url":"https://api.github.com/repos/spinnaker/fiat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/fiat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/fiat/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/fiat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/fiat/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/fiat/languages","stargazers_url":"https://api.github.com/repos/spinnaker/fiat/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/fiat/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/fiat/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/fiat/subscription","commits_url":"https://api.github.com/repos/spinnaker/fiat/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/fiat/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/fiat/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/fiat/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/fiat/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/fiat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/fiat/merges","archive_url":"https://api.github.com/repos/spinnaker/fiat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/fiat/downloads","issues_url":"https://api.github.com/repos/spinnaker/fiat/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/fiat/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/fiat/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/fiat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/fiat/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/fiat/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/fiat/deployments","created_at":"2016-06-14T16:44:56Z","updated_at":"2016-07-27T05:13:26Z","pushed_at":"2016-07-27T19:42:09Z","git_url":"git://github.com/spinnaker/fiat.git","ssh_url":"git@github.com:spinnaker/fiat.git","clone_url":"https://github.com/spinnaker/fiat.git","svn_url":"https://github.com/spinnaker/fiat","homepage":null,"size":173,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/21"},"html":{"href":"https://github.com/spinnaker/fiat/pull/21"},"issue":{"href":"https://api.github.com/repos/spinnaker/fiat/issues/21"},"comments":{"href":"https://api.github.com/repos/spinnaker/fiat/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/fiat/statuses/b4e481f947c1b65c3a27b74eea683bd37c8bf238"}}}}
{"actor":{"display_login":"ajordens"}}