{"action":"closed","issue":{"url":"https://api.github.com/repos/sstur/react-rte/issues/73","repository_url":"https://api.github.com/repos/sstur/react-rte","labels_url":"https://api.github.com/repos/sstur/react-rte/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/sstur/react-rte/issues/73/comments","events_url":"https://api.github.com/repos/sstur/react-rte/issues/73/events","html_url":"https://github.com/sstur/react-rte/issues/73","id":164177466,"number":73,"title":"Provide ability to edit and click on links","user":{"login":"cobarx","id":4063255,"avatar_url":"https://avatars.githubusercontent.com/u/4063255?v=3","gravatar_id":"","url":"https://api.github.com/users/cobarx","html_url":"https://github.com/cobarx","followers_url":"https://api.github.com/users/cobarx/followers","following_url":"https://api.github.com/users/cobarx/following{/other_user}","gists_url":"https://api.github.com/users/cobarx/gists{/gist_id}","starred_url":"https://api.github.com/users/cobarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobarx/subscriptions","organizations_url":"https://api.github.com/users/cobarx/orgs","repos_url":"https://api.github.com/users/cobarx/repos","events_url":"https://api.github.com/users/cobarx/events{/privacy}","received_events_url":"https://api.github.com/users/cobarx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-06T21:22:54Z","updated_at":"2016-08-21T08:36:34Z","closed_at":"2016-08-21T08:36:34Z","body":"I work with @RainFang and we have been really enjoying using React-RTE as our rich text editor of choice. One of the challenges we've been running into is that we use the editor portion of React-RTE for both editing and viewing text, similar to how Google Docs works. Unlike people who present the HTML output to customers, with only working in editor mode there's no easy way to click on links and open them.\r\n\r\nWhat I'd like to do is create a PR that copies the functionality from Google Docs and make it so that you can edit and click on links inline. The way Google has it setup, the popover shows up whenever the cursor is over the text of the link or when you click on the link, like how it's shown below:\r\n![google docs link](https://cloud.githubusercontent.com/assets/4063255/16634785/233c9038-4384-11e6-8391-3bfb835e80e0.png)\r\nThey also have a mode for modifying the link, like this:\r\n![change link](https://cloud.githubusercontent.com/assets/4063255/16634821/58b5ffce-4384-11e6-8b61-438115720cdd.png)\r\n\r\nBefore I started developing this feature, I wanted to check and see if this is a feature you'd welcome as part of the editor as well as getting a feel for what sort of visual design you'd want. If so, I'd be happy to build it out and submit a PR. \r\n\r\nI've also noticed two other bugs/changes that I'd like to address as part of the same effort if you're ok with this approach:\r\nAfter creating a link, any additional text you type is included in the link, which makes it hard to enter normal text again. I'd like to copy Docs behavior on this where after you create a link, any text you add reverts back to the default style.\r\nThe insert link feature also allows you to insert a link within an existing link, splitting the text into two separate link portions. I'd like to make it so you can only edit an existing link but never add a link in the middle.\r\n\r\nLet me know if you'd be ok with this approach for these 3 and I'll get started. Thanks!"}}
{"actor":{"display_login":"sstur"}}