{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/72815457","id":72815457,"diff_hunk":"@@ -118,17 +123,20 @@ - (NSArray*)defaultParameters\n #if TARGET_OS_IPHONE\n         //iOS:\n         NSString* deviceId = [[[UIDevice currentDevice] identifierForVendor] UUIDString];\n-        NSString* deviceName = [[UIDevice currentDevice] name];\n-        SET_IF_NOT_NIL(s_defaultParameters, @\"device_id\", [[deviceId dataUsingEncoding:NSUTF8StringEncoding] base64EncodedStringWithOptions:0]);\n-        SET_IF_NOT_NIL(s_defaultParameters, @\"device_name\", [[deviceName dataUsingEncoding:NSUTF8StringEncoding] base64EncodedStringWithOptions:0]);\n-        \n-        SET_IF_NOT_NIL(s_defaultParameters, @\"application_name\", [[NSBundle mainBundle] objectForInfoDictionaryKey:@\"CFBundleDisplayName\"]);\n-        SET_IF_NOT_NIL(s_defaultParameters, @\"sdk_id\", @\"iOS\");\n+        NSString* applicationName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@\"CFBundleDisplayName\"];\n+        NSString* sdkId = @\"iOS\";","path":"ADAL/src/telemetry/ADDefaultEvent.m","position":23,"original_position":23,"commit_id":"0e39cc2b4372be491cdbb73a515f343e113ad7ae","original_commit_id":"0e39cc2b4372be491cdbb73a515f343e113ad7ae","user":{"login":"jasoncoolmax","id":8347347,"avatar_url":"https://avatars.githubusercontent.com/u/8347347?v=3","gravatar_id":"","url":"https://api.github.com/users/jasoncoolmax","html_url":"https://github.com/jasoncoolmax","followers_url":"https://api.github.com/users/jasoncoolmax/followers","following_url":"https://api.github.com/users/jasoncoolmax/following{/other_user}","gists_url":"https://api.github.com/users/jasoncoolmax/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncoolmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncoolmax/subscriptions","organizations_url":"https://api.github.com/users/jasoncoolmax/orgs","repos_url":"https://api.github.com/users/jasoncoolmax/repos","events_url":"https://api.github.com/users/jasoncoolmax/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncoolmax/received_events","type":"User","site_admin":false},"body":"Seems device name is removed from the requirement doc. ","created_at":"2016-07-29T15:54:11Z","updated_at":"2016-07-29T15:54:11Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706#discussion_r72815457","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/72815457"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706#discussion_r72815457"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706","id":79314066,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/706","number":706,"state":"open","locked":false,"title":"Apply telemetry interface to existing code","user":{"login":"jasoncoolmax","id":8347347,"avatar_url":"https://avatars.githubusercontent.com/u/8347347?v=3","gravatar_id":"","url":"https://api.github.com/users/jasoncoolmax","html_url":"https://github.com/jasoncoolmax","followers_url":"https://api.github.com/users/jasoncoolmax/followers","following_url":"https://api.github.com/users/jasoncoolmax/following{/other_user}","gists_url":"https://api.github.com/users/jasoncoolmax/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncoolmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncoolmax/subscriptions","organizations_url":"https://api.github.com/users/jasoncoolmax/orgs","repos_url":"https://api.github.com/users/jasoncoolmax/repos","events_url":"https://api.github.com/users/jasoncoolmax/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncoolmax/received_events","type":"User","site_admin":false},"body":"(for #695)\r\n\r\nTelemetry events are generated by applying the telemetry hooks to existing code.\r\n\r\nThe following 5 types of events are generated:\r\n\r\n1) ADAPIEvent (for api calls to reflect the work flow)\r\n2) ADUIEvent (for webview launch)\r\n3) ADHttpEvent (for http connection)\r\n4) ADCacheEvent (for cache access)\r\n5) ADBrokerEvent (for broker invoke)\r\n\r\nBesides, changes has been made to generate device id for Mac OS, which is a hash value of the Mac serial number.","created_at":"2016-07-29T06:48:16Z","updated_at":"2016-07-29T15:54:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a4ea85d744d7cb77210583ad6937de52503e121","assignee":{"login":"RPangrle","id":7004783,"avatar_url":"https://avatars.githubusercontent.com/u/7004783?v=3","gravatar_id":"","url":"https://api.github.com/users/RPangrle","html_url":"https://github.com/RPangrle","followers_url":"https://api.github.com/users/RPangrle/followers","following_url":"https://api.github.com/users/RPangrle/following{/other_user}","gists_url":"https://api.github.com/users/RPangrle/gists{/gist_id}","starred_url":"https://api.github.com/users/RPangrle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPangrle/subscriptions","organizations_url":"https://api.github.com/users/RPangrle/orgs","repos_url":"https://api.github.com/users/RPangrle/repos","events_url":"https://api.github.com/users/RPangrle/events{/privacy}","received_events_url":"https://api.github.com/users/RPangrle/received_events","type":"User","site_admin":false},"assignees":[{"login":"RPangrle","id":7004783,"avatar_url":"https://avatars.githubusercontent.com/u/7004783?v=3","gravatar_id":"","url":"https://api.github.com/users/RPangrle","html_url":"https://github.com/RPangrle","followers_url":"https://api.github.com/users/RPangrle/followers","following_url":"https://api.github.com/users/RPangrle/following{/other_user}","gists_url":"https://api.github.com/users/RPangrle/gists{/gist_id}","starred_url":"https://api.github.com/users/RPangrle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPangrle/subscriptions","organizations_url":"https://api.github.com/users/RPangrle/orgs","repos_url":"https://api.github.com/users/RPangrle/repos","events_url":"https://api.github.com/users/RPangrle/events{/privacy}","received_events_url":"https://api.github.com/users/RPangrle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/706/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/0e39cc2b4372be491cdbb73a515f343e113ad7ae","head":{"label":"AzureAD:jason/695(2)","ref":"jason/695(2)","sha":"0e39cc2b4372be491cdbb73a515f343e113ad7ae","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/deployments","created_at":"2013-11-26T00:46:00Z","updated_at":"2016-07-06T11:15:04Z","pushed_at":"2016-07-29T06:48:16Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":13759,"stargazers_count":85,"watchers_count":85,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":25,"forks":51,"open_issues":25,"watchers":85,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"17e16d21fdf5837d634481ef76039ac4cbf6c1ed","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/deployments","created_at":"2013-11-26T00:46:00Z","updated_at":"2016-07-06T11:15:04Z","pushed_at":"2016-07-29T06:48:16Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":13759,"stargazers_count":85,"watchers_count":85,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":25,"forks":51,"open_issues":25,"watchers":85,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/706"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/706"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/0e39cc2b4372be491cdbb73a515f343e113ad7ae"}}}}
{"actor":{"display_login":"jasoncoolmax"}}