{"action":"opened","number":2594,"pull_request":{"url":"https://api.github.com/repos/harvesthq/chosen/pulls/2594","id":66538048,"html_url":"https://github.com/harvesthq/chosen/pull/2594","diff_url":"https://github.com/harvesthq/chosen/pull/2594.diff","patch_url":"https://github.com/harvesthq/chosen/pull/2594.patch","issue_url":"https://api.github.com/repos/harvesthq/chosen/issues/2594","number":2594,"state":"open","locked":false,"title":"Issue #2075: Fix client-side validation","user":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"body":"<!---\r\nGood pull requests — patches, improvements, new features — are a fantastic help.  They should remain focused in scope and avoid containing unrelated commits.\r\n\r\nPlease review the Pull Requests section of our Contributing Guidelines before submitting your work: https://github.com/harvesthq/chosen/blob/master/contributing.md#pull-requests\r\n-->\r\n\r\n### Summary\r\n\r\nFixes issue #2075 by not setting `display: none` and instead leaves the element focusable for browsers that implement client-side validation.\r\n\r\nPlease double-check that:\r\n\r\n  - [ x] All changes were made in CoffeeScript files, **not** JavaScript files.\r\n  - [ x] You used [Grunt](https://github.com/harvesthq/chosen/blob/master/contributing.md#grunt) to build the JavaScript files and tested them locally.\r\n  - [ ] You've updated both the jQuery *and* Prototype versions. (I don't know for sure, but I think this is only a bug in the jQuery version due to how the element is hidden.)\r\n  - [ x] You haven't manually updated the version number in `package.json`.\r\n  - [ x] If necessary, you've updated [the documentation](https://github.com/harvesthq/chosen/blob/master/public/options.html).\r\n\r\n","created_at":"2016-04-14T19:13:41Z","updated_at":"2016-04-14T19:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harvesthq/chosen/pulls/2594/commits","review_comments_url":"https://api.github.com/repos/harvesthq/chosen/pulls/2594/comments","review_comment_url":"https://api.github.com/repos/harvesthq/chosen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harvesthq/chosen/issues/2594/comments","statuses_url":"https://api.github.com/repos/harvesthq/chosen/statuses/3193e6c0641502d428781903d25ecf7ab0aac25a","head":{"label":"jhedstrom:bug/client-side-validation-2075","ref":"bug/client-side-validation-2075","sha":"3193e6c0641502d428781903d25ecf7ab0aac25a","user":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"repo":{"id":55267516,"name":"chosen","full_name":"jhedstrom/chosen","owner":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhedstrom/chosen","description":"Chosen is a library for making long, unwieldy select boxes more friendly.","fork":true,"url":"https://api.github.com/repos/jhedstrom/chosen","forks_url":"https://api.github.com/repos/jhedstrom/chosen/forks","keys_url":"https://api.github.com/repos/jhedstrom/chosen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhedstrom/chosen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhedstrom/chosen/teams","hooks_url":"https://api.github.com/repos/jhedstrom/chosen/hooks","issue_events_url":"https://api.github.com/repos/jhedstrom/chosen/issues/events{/number}","events_url":"https://api.github.com/repos/jhedstrom/chosen/events","assignees_url":"https://api.github.com/repos/jhedstrom/chosen/assignees{/user}","branches_url":"https://api.github.com/repos/jhedstrom/chosen/branches{/branch}","tags_url":"https://api.github.com/repos/jhedstrom/chosen/tags","blobs_url":"https://api.github.com/repos/jhedstrom/chosen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhedstrom/chosen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhedstrom/chosen/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhedstrom/chosen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhedstrom/chosen/statuses/{sha}","languages_url":"https://api.github.com/repos/jhedstrom/chosen/languages","stargazers_url":"https://api.github.com/repos/jhedstrom/chosen/stargazers","contributors_url":"https://api.github.com/repos/jhedstrom/chosen/contributors","subscribers_url":"https://api.github.com/repos/jhedstrom/chosen/subscribers","subscription_url":"https://api.github.com/repos/jhedstrom/chosen/subscription","commits_url":"https://api.github.com/repos/jhedstrom/chosen/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhedstrom/chosen/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhedstrom/chosen/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhedstrom/chosen/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhedstrom/chosen/contents/{+path}","compare_url":"https://api.github.com/repos/jhedstrom/chosen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhedstrom/chosen/merges","archive_url":"https://api.github.com/repos/jhedstrom/chosen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhedstrom/chosen/downloads","issues_url":"https://api.github.com/repos/jhedstrom/chosen/issues{/number}","pulls_url":"https://api.github.com/repos/jhedstrom/chosen/pulls{/number}","milestones_url":"https://api.github.com/repos/jhedstrom/chosen/milestones{/number}","notifications_url":"https://api.github.com/repos/jhedstrom/chosen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhedstrom/chosen/labels{/name}","releases_url":"https://api.github.com/repos/jhedstrom/chosen/releases{/id}","deployments_url":"https://api.github.com/repos/jhedstrom/chosen/deployments","created_at":"2016-04-01T23:08:50Z","updated_at":"2016-04-01T23:08:52Z","pushed_at":"2016-04-14T19:07:16Z","git_url":"git://github.com/jhedstrom/chosen.git","ssh_url":"git@github.com:jhedstrom/chosen.git","clone_url":"https://github.com/jhedstrom/chosen.git","svn_url":"https://github.com/jhedstrom/chosen","homepage":"http://harvesthq.github.io/chosen/","size":2445,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harvesthq:master","ref":"master","sha":"7b44637a605c315d7ef86f74ecf1514577849d1f","user":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"repo":{"id":1631024,"name":"chosen","full_name":"harvesthq/chosen","owner":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvesthq/chosen","description":"Chosen is a library for making long, unwieldy select boxes more friendly.","fork":false,"url":"https://api.github.com/repos/harvesthq/chosen","forks_url":"https://api.github.com/repos/harvesthq/chosen/forks","keys_url":"https://api.github.com/repos/harvesthq/chosen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvesthq/chosen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvesthq/chosen/teams","hooks_url":"https://api.github.com/repos/harvesthq/chosen/hooks","issue_events_url":"https://api.github.com/repos/harvesthq/chosen/issues/events{/number}","events_url":"https://api.github.com/repos/harvesthq/chosen/events","assignees_url":"https://api.github.com/repos/harvesthq/chosen/assignees{/user}","branches_url":"https://api.github.com/repos/harvesthq/chosen/branches{/branch}","tags_url":"https://api.github.com/repos/harvesthq/chosen/tags","blobs_url":"https://api.github.com/repos/harvesthq/chosen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvesthq/chosen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvesthq/chosen/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvesthq/chosen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvesthq/chosen/statuses/{sha}","languages_url":"https://api.github.com/repos/harvesthq/chosen/languages","stargazers_url":"https://api.github.com/repos/harvesthq/chosen/stargazers","contributors_url":"https://api.github.com/repos/harvesthq/chosen/contributors","subscribers_url":"https://api.github.com/repos/harvesthq/chosen/subscribers","subscription_url":"https://api.github.com/repos/harvesthq/chosen/subscription","commits_url":"https://api.github.com/repos/harvesthq/chosen/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvesthq/chosen/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvesthq/chosen/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvesthq/chosen/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvesthq/chosen/contents/{+path}","compare_url":"https://api.github.com/repos/harvesthq/chosen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvesthq/chosen/merges","archive_url":"https://api.github.com/repos/harvesthq/chosen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvesthq/chosen/downloads","issues_url":"https://api.github.com/repos/harvesthq/chosen/issues{/number}","pulls_url":"https://api.github.com/repos/harvesthq/chosen/pulls{/number}","milestones_url":"https://api.github.com/repos/harvesthq/chosen/milestones{/number}","notifications_url":"https://api.github.com/repos/harvesthq/chosen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvesthq/chosen/labels{/name}","releases_url":"https://api.github.com/repos/harvesthq/chosen/releases{/id}","deployments_url":"https://api.github.com/repos/harvesthq/chosen/deployments","created_at":"2011-04-18T15:07:41Z","updated_at":"2016-04-14T18:13:39Z","pushed_at":"2016-04-12T14:41:32Z","git_url":"git://github.com/harvesthq/chosen.git","ssh_url":"git@github.com:harvesthq/chosen.git","clone_url":"https://github.com/harvesthq/chosen.git","svn_url":"https://github.com/harvesthq/chosen","homepage":"http://harvesthq.github.io/chosen/","size":6772,"stargazers_count":19302,"watchers_count":19302,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3704,"mirror_url":null,"open_issues_count":397,"forks":3704,"open_issues":397,"watchers":19302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2594"},"html":{"href":"https://github.com/harvesthq/chosen/pull/2594"},"issue":{"href":"https://api.github.com/repos/harvesthq/chosen/issues/2594"},"comments":{"href":"https://api.github.com/repos/harvesthq/chosen/issues/2594/comments"},"review_comments":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2594/comments"},"review_comment":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2594/commits"},"statuses":{"href":"https://api.github.com/repos/harvesthq/chosen/statuses/3193e6c0641502d428781903d25ecf7ab0aac25a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}