{"action":"created","comment":{"url":"https://api.github.com/repos/gushphp/gush/pulls/comments/84858092","pull_request_review_id":5607803,"id":84858092,"diff_hunk":"@@ -46,18 +46,13 @@ public function fromString($string)\n             throw new \\RuntimeException('No EDITOR environment variable set.');\n         }\n \n-        if (defined('PHP_WINDOWS_VERSION_MAJOR')) {","path":"src/Helper/EditorHelper.php","position":4,"original_position":4,"commit_id":"51efa2fa154e36f85810439883a8219f6c34df70","original_commit_id":"51efa2fa154e36f85810439883a8219f6c34df70","user":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"body":"I forgot I removed this as `system($editor.' '.$tmpName.' > `tty`');` is horribly broken 💀 ","created_at":"2016-10-25T09:01:48Z","updated_at":"2016-10-25T09:01:48Z","html_url":"https://github.com/gushphp/gush/pull/579#discussion_r84858092","pull_request_url":"https://api.github.com/repos/gushphp/gush/pulls/579","_links":{"self":{"href":"https://api.github.com/repos/gushphp/gush/pulls/comments/84858092"},"html":{"href":"https://github.com/gushphp/gush/pull/579#discussion_r84858092"},"pull_request":{"href":"https://api.github.com/repos/gushphp/gush/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/gushphp/gush/pulls/579","id":79366360,"html_url":"https://github.com/gushphp/gush/pull/579","diff_url":"https://github.com/gushphp/gush/pull/579.diff","patch_url":"https://github.com/gushphp/gush/pull/579.patch","issue_url":"https://api.github.com/repos/gushphp/gush/issues/579","number":579,"state":"open","locked":false,"title":"Refactor ProcessHelper logic","user":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"body":"|Q            |A  |\r\n|---          |---|\r\n|Fixed tickets|   |\r\n|License      |MIT|\r\n\r\nI refactored the ProcessHelper a little to make it cleaner and use existing techniques.\r\n\r\n* Ensure command with dynamic values are provided as an array (no a string), to ensure they are properly escaped.\r\n\r\n* Replace the home-made Console debugging with the Symfony ConsoleHelper version (which provides more information, the command (as it was executed, output, and success/failure)) (see image below).\r\n\r\n* The EditorHelper now always uses the same logic (no more tty required), and shows which command is actually executed when debugging is enabled.\r\n\r\n![schermafbeelding 2016-07-29 om 16 36 45](https://cloud.githubusercontent.com/assets/904790/17251883/bdf191b8-55aa-11e6-9da8-e34579509fec.png)","created_at":"2016-07-29T14:17:13Z","updated_at":"2016-10-25T09:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e1676828ca0d0c5c9d2fc59176fcfc2f4a7ac4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gushphp/gush/pulls/579/commits","review_comments_url":"https://api.github.com/repos/gushphp/gush/pulls/579/comments","review_comment_url":"https://api.github.com/repos/gushphp/gush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gushphp/gush/issues/579/comments","statuses_url":"https://api.github.com/repos/gushphp/gush/statuses/51efa2fa154e36f85810439883a8219f6c34df70","head":{"label":"sstok:refactor-process-helper","ref":"refactor-process-helper","sha":"51efa2fa154e36f85810439883a8219f6c34df70","user":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"repo":{"id":19689159,"name":"gush","full_name":"sstok/gush","owner":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sstok/gush","description":"Open Source & Enterprise FAST project maintainance/contributing","fork":true,"url":"https://api.github.com/repos/sstok/gush","forks_url":"https://api.github.com/repos/sstok/gush/forks","keys_url":"https://api.github.com/repos/sstok/gush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sstok/gush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sstok/gush/teams","hooks_url":"https://api.github.com/repos/sstok/gush/hooks","issue_events_url":"https://api.github.com/repos/sstok/gush/issues/events{/number}","events_url":"https://api.github.com/repos/sstok/gush/events","assignees_url":"https://api.github.com/repos/sstok/gush/assignees{/user}","branches_url":"https://api.github.com/repos/sstok/gush/branches{/branch}","tags_url":"https://api.github.com/repos/sstok/gush/tags","blobs_url":"https://api.github.com/repos/sstok/gush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sstok/gush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sstok/gush/git/refs{/sha}","trees_url":"https://api.github.com/repos/sstok/gush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sstok/gush/statuses/{sha}","languages_url":"https://api.github.com/repos/sstok/gush/languages","stargazers_url":"https://api.github.com/repos/sstok/gush/stargazers","contributors_url":"https://api.github.com/repos/sstok/gush/contributors","subscribers_url":"https://api.github.com/repos/sstok/gush/subscribers","subscription_url":"https://api.github.com/repos/sstok/gush/subscription","commits_url":"https://api.github.com/repos/sstok/gush/commits{/sha}","git_commits_url":"https://api.github.com/repos/sstok/gush/git/commits{/sha}","comments_url":"https://api.github.com/repos/sstok/gush/comments{/number}","issue_comment_url":"https://api.github.com/repos/sstok/gush/issues/comments{/number}","contents_url":"https://api.github.com/repos/sstok/gush/contents/{+path}","compare_url":"https://api.github.com/repos/sstok/gush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sstok/gush/merges","archive_url":"https://api.github.com/repos/sstok/gush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sstok/gush/downloads","issues_url":"https://api.github.com/repos/sstok/gush/issues{/number}","pulls_url":"https://api.github.com/repos/sstok/gush/pulls{/number}","milestones_url":"https://api.github.com/repos/sstok/gush/milestones{/number}","notifications_url":"https://api.github.com/repos/sstok/gush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sstok/gush/labels{/name}","releases_url":"https://api.github.com/repos/sstok/gush/releases{/id}","deployments_url":"https://api.github.com/repos/sstok/gush/deployments","created_at":"2014-05-12T07:09:35Z","updated_at":"2016-07-26T09:27:47Z","pushed_at":"2016-10-22T14:06:06Z","git_url":"git://github.com/sstok/gush.git","ssh_url":"git@github.com:sstok/gush.git","clone_url":"https://github.com/sstok/gush.git","svn_url":"https://github.com/sstok/gush","homepage":"http://gushphp.org","size":4304,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gushphp:master","ref":"master","sha":"3d4aa97af980eafa1384aa5da53d483d2a11cab8","user":{"login":"gushphp","id":6666950,"avatar_url":"https://avatars.githubusercontent.com/u/6666950?v=3","gravatar_id":"","url":"https://api.github.com/users/gushphp","html_url":"https://github.com/gushphp","followers_url":"https://api.github.com/users/gushphp/followers","following_url":"https://api.github.com/users/gushphp/following{/other_user}","gists_url":"https://api.github.com/users/gushphp/gists{/gist_id}","starred_url":"https://api.github.com/users/gushphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gushphp/subscriptions","organizations_url":"https://api.github.com/users/gushphp/orgs","repos_url":"https://api.github.com/users/gushphp/repos","events_url":"https://api.github.com/users/gushphp/events{/privacy}","received_events_url":"https://api.github.com/users/gushphp/received_events","type":"Organization","site_admin":false},"repo":{"id":16789051,"name":"gush","full_name":"gushphp/gush","owner":{"login":"gushphp","id":6666950,"avatar_url":"https://avatars.githubusercontent.com/u/6666950?v=3","gravatar_id":"","url":"https://api.github.com/users/gushphp","html_url":"https://github.com/gushphp","followers_url":"https://api.github.com/users/gushphp/followers","following_url":"https://api.github.com/users/gushphp/following{/other_user}","gists_url":"https://api.github.com/users/gushphp/gists{/gist_id}","starred_url":"https://api.github.com/users/gushphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gushphp/subscriptions","organizations_url":"https://api.github.com/users/gushphp/orgs","repos_url":"https://api.github.com/users/gushphp/repos","events_url":"https://api.github.com/users/gushphp/events{/privacy}","received_events_url":"https://api.github.com/users/gushphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gushphp/gush","description":"Project Maintenance & Contributing Automation","fork":false,"url":"https://api.github.com/repos/gushphp/gush","forks_url":"https://api.github.com/repos/gushphp/gush/forks","keys_url":"https://api.github.com/repos/gushphp/gush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gushphp/gush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gushphp/gush/teams","hooks_url":"https://api.github.com/repos/gushphp/gush/hooks","issue_events_url":"https://api.github.com/repos/gushphp/gush/issues/events{/number}","events_url":"https://api.github.com/repos/gushphp/gush/events","assignees_url":"https://api.github.com/repos/gushphp/gush/assignees{/user}","branches_url":"https://api.github.com/repos/gushphp/gush/branches{/branch}","tags_url":"https://api.github.com/repos/gushphp/gush/tags","blobs_url":"https://api.github.com/repos/gushphp/gush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gushphp/gush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gushphp/gush/git/refs{/sha}","trees_url":"https://api.github.com/repos/gushphp/gush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gushphp/gush/statuses/{sha}","languages_url":"https://api.github.com/repos/gushphp/gush/languages","stargazers_url":"https://api.github.com/repos/gushphp/gush/stargazers","contributors_url":"https://api.github.com/repos/gushphp/gush/contributors","subscribers_url":"https://api.github.com/repos/gushphp/gush/subscribers","subscription_url":"https://api.github.com/repos/gushphp/gush/subscription","commits_url":"https://api.github.com/repos/gushphp/gush/commits{/sha}","git_commits_url":"https://api.github.com/repos/gushphp/gush/git/commits{/sha}","comments_url":"https://api.github.com/repos/gushphp/gush/comments{/number}","issue_comment_url":"https://api.github.com/repos/gushphp/gush/issues/comments{/number}","contents_url":"https://api.github.com/repos/gushphp/gush/contents/{+path}","compare_url":"https://api.github.com/repos/gushphp/gush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gushphp/gush/merges","archive_url":"https://api.github.com/repos/gushphp/gush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gushphp/gush/downloads","issues_url":"https://api.github.com/repos/gushphp/gush/issues{/number}","pulls_url":"https://api.github.com/repos/gushphp/gush/pulls{/number}","milestones_url":"https://api.github.com/repos/gushphp/gush/milestones{/number}","notifications_url":"https://api.github.com/repos/gushphp/gush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gushphp/gush/labels{/name}","releases_url":"https://api.github.com/repos/gushphp/gush/releases{/id}","deployments_url":"https://api.github.com/repos/gushphp/gush/deployments","created_at":"2014-02-13T02:14:36Z","updated_at":"2016-10-22T13:12:23Z","pushed_at":"2016-10-22T13:16:27Z","git_url":"git://github.com/gushphp/gush.git","ssh_url":"git@github.com:gushphp/gush.git","clone_url":"https://github.com/gushphp/gush.git","svn_url":"https://github.com/gushphp/gush","homepage":"","size":4923,"stargazers_count":284,"watchers_count":284,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":22,"forks":43,"open_issues":22,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gushphp/gush/pulls/579"},"html":{"href":"https://github.com/gushphp/gush/pull/579"},"issue":{"href":"https://api.github.com/repos/gushphp/gush/issues/579"},"comments":{"href":"https://api.github.com/repos/gushphp/gush/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/gushphp/gush/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/gushphp/gush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gushphp/gush/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/gushphp/gush/statuses/51efa2fa154e36f85810439883a8219f6c34df70"}}}}
{"actor":{"display_login":"sstok"}}