{"action":"closed","issue":{"url":"https://api.github.com/repos/spotify/HubFramework/issues/51","repository_url":"https://api.github.com/repos/spotify/HubFramework","labels_url":"https://api.github.com/repos/spotify/HubFramework/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/spotify/HubFramework/issues/51/comments","events_url":"https://api.github.com/repos/spotify/HubFramework/issues/51/events","html_url":"https://github.com/spotify/HubFramework/issues/51","id":180651289,"number":51,"title":"Image loader: Replace cache-check with timer","user":{"login":"JohnSundell","id":2466701,"avatar_url":"https://avatars.githubusercontent.com/u/2466701?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnSundell","html_url":"https://github.com/JohnSundell","followers_url":"https://api.github.com/users/JohnSundell/followers","following_url":"https://api.github.com/users/JohnSundell/following{/other_user}","gists_url":"https://api.github.com/users/JohnSundell/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnSundell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnSundell/subscriptions","organizations_url":"https://api.github.com/users/JohnSundell/orgs","repos_url":"https://api.github.com/users/JohnSundell/repos","events_url":"https://api.github.com/users/JohnSundell/events{/privacy}","received_events_url":"https://api.github.com/users/JohnSundell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spotify/HubFramework/labels/enhancement","name":"enhancement","color":"1e3264"},{"url":"https://api.github.com/repos/spotify/HubFramework/labels/ready%20to%20be%20implemented","name":"ready to be implemented","color":"c2e0c6"}],"state":"closed","locked":false,"assignee":{"login":"krris","id":1786612,"avatar_url":"https://avatars.githubusercontent.com/u/1786612?v=3","gravatar_id":"","url":"https://api.github.com/users/krris","html_url":"https://github.com/krris","followers_url":"https://api.github.com/users/krris/followers","following_url":"https://api.github.com/users/krris/following{/other_user}","gists_url":"https://api.github.com/users/krris/gists{/gist_id}","starred_url":"https://api.github.com/users/krris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krris/subscriptions","organizations_url":"https://api.github.com/users/krris/orgs","repos_url":"https://api.github.com/users/krris/repos","events_url":"https://api.github.com/users/krris/events{/privacy}","received_events_url":"https://api.github.com/users/krris/received_events","type":"User","site_admin":false},"assignees":[{"login":"krris","id":1786612,"avatar_url":"https://avatars.githubusercontent.com/u/1786612?v=3","gravatar_id":"","url":"https://api.github.com/users/krris","html_url":"https://github.com/krris","followers_url":"https://api.github.com/users/krris/followers","following_url":"https://api.github.com/users/krris/following{/other_user}","gists_url":"https://api.github.com/users/krris/gists{/gist_id}","starred_url":"https://api.github.com/users/krris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krris/subscriptions","organizations_url":"https://api.github.com/users/krris/orgs","repos_url":"https://api.github.com/users/krris/repos","events_url":"https://api.github.com/users/krris/events{/privacy}","received_events_url":"https://api.github.com/users/krris/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-03T14:14:38Z","updated_at":"2016-10-20T15:27:45Z","closed_at":"2016-10-20T15:27:45Z","body":"Currently, we ask each implementation of `HUBImageLoader` to return whether an image was loaded from cache or not. This parameter is in turn used to decide whether a component should animate a change of image.\r\n\r\nInstead of doing this, let the user of `HUBImageLoader` (currently `HUBViewControllerImplementation`) keep track of how long time the image download took, and then - if the value exceeded a certain threshold (in the Spotify app we use `0.07` seconds, which seems to be a reasonable value). This removes the need for image loaders to perform this work, and guarantees a consistent behavior irregardless of image loader implementation.\r\n\r\nWhen this is done, we can remove the `loadedFromCache` parameter in `HUBImageLoaderDelegate`."}}
{"actor":{"display_login":"krris"}}