{"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/49952315","id":49952315,"diff_hunk":"@@ -464,15 +464,10 @@ else if (dimension.equals(\"time\")) {\n                     if (strategyModel.getObject() == Strategy.NEAREST) {\n                         if (!DimensionDefaultValueSetting.TIME_CURRENT.equalsIgnoreCase(value\n                                 .getValue())) {\n-                            IValidationError err = new ValidationError(\"invalidNearestTimeReferenceValue \" + Collections\n-                                    .singletonMap(\"value\", (Object) value.getValue()));\n-                            value.error(err);\n+                            value.error(new ValidationError(\"invalidNearestTimeReferenceValue\"));\n                         }\n                     } else {\n-                        IValidationError err = new ValidationError(\"invalidTimeReferenceValue\" + Collections.singletonMap(\"value\",\n-                                (Object) value.getValue()));\n-\n-                        value.error(err);\n+                        value.error(new ValidationError(\"invalidTimeReferenceValue\"));","path":"src/web/core/src/main/java/org/geoserver/web/data/resource/DimensionEditor.java","position":14,"original_position":14,"commit_id":"4cc69f7aaa0d47f8f1f469e465674252af91a166","original_commit_id":"4cc69f7aaa0d47f8f1f469e465674252af91a166","user":{"login":"bradh","id":174642,"avatar_url":"https://avatars.githubusercontent.com/u/174642?v=3","gravatar_id":"","url":"https://api.github.com/users/bradh","html_url":"https://github.com/bradh","followers_url":"https://api.github.com/users/bradh/followers","following_url":"https://api.github.com/users/bradh/following{/other_user}","gists_url":"https://api.github.com/users/bradh/gists{/gist_id}","starred_url":"https://api.github.com/users/bradh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradh/subscriptions","organizations_url":"https://api.github.com/users/bradh/orgs","repos_url":"https://api.github.com/users/bradh/repos","events_url":"https://api.github.com/users/bradh/events{/privacy}","received_events_url":"https://api.github.com/users/bradh/received_events","type":"User","site_admin":false},"body":"In this case, the parameter was not used (hence removed).\r\n\r\n```DimensionEditor.referenceValue.invalidTimeReferenceValue = Reference time value must be an ISO 8601 DateTime```","created_at":"2016-01-17T21:01:38Z","updated_at":"2016-01-17T21:01:38Z","html_url":"https://github.com/geoserver/geoserver/pull/1406#discussion_r49952315","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1406","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/49952315"},"html":{"href":"https://github.com/geoserver/geoserver/pull/1406#discussion_r49952315"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/1406","id":56268558,"html_url":"https://github.com/geoserver/geoserver/pull/1406","diff_url":"https://github.com/geoserver/geoserver/pull/1406.diff","patch_url":"https://github.com/geoserver/geoserver/pull/1406.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/1406","number":1406,"state":"open","locked":false,"title":"[Wicket 7] Fix errors in conversion at c1aabb94e843263851e376bdff2d28ba45bba7e6","user":{"login":"bradh","id":174642,"avatar_url":"https://avatars.githubusercontent.com/u/174642?v=3","gravatar_id":"","url":"https://api.github.com/users/bradh","html_url":"https://github.com/bradh","followers_url":"https://api.github.com/users/bradh/followers","following_url":"https://api.github.com/users/bradh/following{/other_user}","gists_url":"https://api.github.com/users/bradh/gists{/gist_id}","starred_url":"https://api.github.com/users/bradh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradh/subscriptions","organizations_url":"https://api.github.com/users/bradh/orgs","repos_url":"https://api.github.com/users/bradh/repos","events_url":"https://api.github.com/users/bradh/events{/privacy}","received_events_url":"https://api.github.com/users/bradh/received_events","type":"User","site_admin":false},"body":"I'd failed to realise those were resource keys.","created_at":"2016-01-17T02:18:02Z","updated_at":"2016-01-17T21:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32de6005b4e3c8245927abc4dba4b363682fdd24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/1406/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/4cc69f7aaa0d47f8f1f469e465674252af91a166","head":{"label":"bradh:wicket7","ref":"wicket7","sha":"4cc69f7aaa0d47f8f1f469e465674252af91a166","user":{"login":"bradh","id":174642,"avatar_url":"https://avatars.githubusercontent.com/u/174642?v=3","gravatar_id":"","url":"https://api.github.com/users/bradh","html_url":"https://github.com/bradh","followers_url":"https://api.github.com/users/bradh/followers","following_url":"https://api.github.com/users/bradh/following{/other_user}","gists_url":"https://api.github.com/users/bradh/gists{/gist_id}","starred_url":"https://api.github.com/users/bradh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradh/subscriptions","organizations_url":"https://api.github.com/users/bradh/orgs","repos_url":"https://api.github.com/users/bradh/repos","events_url":"https://api.github.com/users/bradh/events{/privacy}","received_events_url":"https://api.github.com/users/bradh/received_events","type":"User","site_admin":false},"repo":{"id":15123335,"name":"geoserver","full_name":"bradh/geoserver","owner":{"login":"bradh","id":174642,"avatar_url":"https://avatars.githubusercontent.com/u/174642?v=3","gravatar_id":"","url":"https://api.github.com/users/bradh","html_url":"https://github.com/bradh","followers_url":"https://api.github.com/users/bradh/followers","following_url":"https://api.github.com/users/bradh/following{/other_user}","gists_url":"https://api.github.com/users/bradh/gists{/gist_id}","starred_url":"https://api.github.com/users/bradh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradh/subscriptions","organizations_url":"https://api.github.com/users/bradh/orgs","repos_url":"https://api.github.com/users/bradh/repos","events_url":"https://api.github.com/users/bradh/events{/privacy}","received_events_url":"https://api.github.com/users/bradh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradh/geoserver","description":"Not the GeoServer repository - see: http://geoserver.org","fork":true,"url":"https://api.github.com/repos/bradh/geoserver","forks_url":"https://api.github.com/repos/bradh/geoserver/forks","keys_url":"https://api.github.com/repos/bradh/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradh/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradh/geoserver/teams","hooks_url":"https://api.github.com/repos/bradh/geoserver/hooks","issue_events_url":"https://api.github.com/repos/bradh/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/bradh/geoserver/events","assignees_url":"https://api.github.com/repos/bradh/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/bradh/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/bradh/geoserver/tags","blobs_url":"https://api.github.com/repos/bradh/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradh/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradh/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradh/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradh/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/bradh/geoserver/languages","stargazers_url":"https://api.github.com/repos/bradh/geoserver/stargazers","contributors_url":"https://api.github.com/repos/bradh/geoserver/contributors","subscribers_url":"https://api.github.com/repos/bradh/geoserver/subscribers","subscription_url":"https://api.github.com/repos/bradh/geoserver/subscription","commits_url":"https://api.github.com/repos/bradh/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradh/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradh/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradh/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradh/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/bradh/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradh/geoserver/merges","archive_url":"https://api.github.com/repos/bradh/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradh/geoserver/downloads","issues_url":"https://api.github.com/repos/bradh/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/bradh/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/bradh/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/bradh/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradh/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/bradh/geoserver/releases{/id}","created_at":"2013-12-12T00:44:17Z","updated_at":"2015-03-08T05:12:21Z","pushed_at":"2016-01-17T10:44:45Z","git_url":"git://github.com/bradh/geoserver.git","ssh_url":"git@github.com:bradh/geoserver.git","clone_url":"https://github.com/bradh/geoserver.git","svn_url":"https://github.com/bradh/geoserver","homepage":"","size":130021,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoserver:wicket7","ref":"wicket7","sha":"89190cf2e9dd28b4e499b9654d4c272359095371","user":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"name":"geoserver","full_name":"geoserver/geoserver","owner":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","created_at":"2011-11-10T19:56:06Z","updated_at":"2016-01-15T05:22:37Z","pushed_at":"2016-01-17T17:39:45Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":135023,"stargazers_count":536,"watchers_count":536,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":608,"mirror_url":null,"open_issues_count":19,"forks":608,"open_issues":19,"watchers":536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1406"},"html":{"href":"https://github.com/geoserver/geoserver/pull/1406"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/1406"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/4cc69f7aaa0d47f8f1f469e465674252af91a166"}}}}