{"action":"opened","number":1807,"pull_request":{"url":"https://api.github.com/repos/nylas/N1/pulls/1807","id":63636344,"html_url":"https://github.com/nylas/N1/pull/1807","diff_url":"https://github.com/nylas/N1/pull/1807.diff","patch_url":"https://github.com/nylas/N1/pull/1807.patch","issue_url":"https://api.github.com/repos/nylas/N1/issues/1807","number":1807,"state":"open","locked":false,"title":"[RFC] Multi-spellchecker","user":{"login":"mbilker","id":1266541,"avatar_url":"https://avatars.githubusercontent.com/u/1266541?v=3","gravatar_id":"","url":"https://api.github.com/users/mbilker","html_url":"https://github.com/mbilker","followers_url":"https://api.github.com/users/mbilker/followers","following_url":"https://api.github.com/users/mbilker/following{/other_user}","gists_url":"https://api.github.com/users/mbilker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbilker/subscriptions","organizations_url":"https://api.github.com/users/mbilker/orgs","repos_url":"https://api.github.com/users/mbilker/repos","events_url":"https://api.github.com/users/mbilker/events{/privacy}","received_events_url":"https://api.github.com/users/mbilker/received_events","type":"User","site_admin":false},"body":"This spellchecker implementation takes cues from Slack's spellcheck implementation and scans all available Hunspell directories on startup. Unfortunately, this comes at a startup penalty to all N1 windows (main, composer, and background). I have not tested running the spellchecker from the main process and communicating via Electron `ipc`.\r\n\r\nThis is **NOT** tested on OS X and Windows and I need to write specs for it, but I want feedback on future implementation and how to test the Windows version.","created_at":"2016-03-21T21:35:41Z","updated_at":"2016-03-21T21:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nylas/N1/pulls/1807/commits","review_comments_url":"https://api.github.com/repos/nylas/N1/pulls/1807/comments","review_comment_url":"https://api.github.com/repos/nylas/N1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nylas/N1/issues/1807/comments","statuses_url":"https://api.github.com/repos/nylas/N1/statuses/7366eeb18deb70a9f6580b33d76187d31ac05dcf","head":{"label":"mbilker:spellcheck","ref":"spellcheck","sha":"7366eeb18deb70a9f6580b33d76187d31ac05dcf","user":{"login":"mbilker","id":1266541,"avatar_url":"https://avatars.githubusercontent.com/u/1266541?v=3","gravatar_id":"","url":"https://api.github.com/users/mbilker","html_url":"https://github.com/mbilker","followers_url":"https://api.github.com/users/mbilker/followers","following_url":"https://api.github.com/users/mbilker/following{/other_user}","gists_url":"https://api.github.com/users/mbilker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbilker/subscriptions","organizations_url":"https://api.github.com/users/mbilker/orgs","repos_url":"https://api.github.com/users/mbilker/repos","events_url":"https://api.github.com/users/mbilker/events{/privacy}","received_events_url":"https://api.github.com/users/mbilker/received_events","type":"User","site_admin":false},"repo":{"id":43793219,"name":"N1","full_name":"mbilker/N1","owner":{"login":"mbilker","id":1266541,"avatar_url":"https://avatars.githubusercontent.com/u/1266541?v=3","gravatar_id":"","url":"https://api.github.com/users/mbilker","html_url":"https://github.com/mbilker","followers_url":"https://api.github.com/users/mbilker/followers","following_url":"https://api.github.com/users/mbilker/following{/other_user}","gists_url":"https://api.github.com/users/mbilker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbilker/subscriptions","organizations_url":"https://api.github.com/users/mbilker/orgs","repos_url":"https://api.github.com/users/mbilker/repos","events_url":"https://api.github.com/users/mbilker/events{/privacy}","received_events_url":"https://api.github.com/users/mbilker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbilker/N1","description":"An extensible mail client built on the modern web.","fork":true,"url":"https://api.github.com/repos/mbilker/N1","forks_url":"https://api.github.com/repos/mbilker/N1/forks","keys_url":"https://api.github.com/repos/mbilker/N1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbilker/N1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbilker/N1/teams","hooks_url":"https://api.github.com/repos/mbilker/N1/hooks","issue_events_url":"https://api.github.com/repos/mbilker/N1/issues/events{/number}","events_url":"https://api.github.com/repos/mbilker/N1/events","assignees_url":"https://api.github.com/repos/mbilker/N1/assignees{/user}","branches_url":"https://api.github.com/repos/mbilker/N1/branches{/branch}","tags_url":"https://api.github.com/repos/mbilker/N1/tags","blobs_url":"https://api.github.com/repos/mbilker/N1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbilker/N1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbilker/N1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbilker/N1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbilker/N1/statuses/{sha}","languages_url":"https://api.github.com/repos/mbilker/N1/languages","stargazers_url":"https://api.github.com/repos/mbilker/N1/stargazers","contributors_url":"https://api.github.com/repos/mbilker/N1/contributors","subscribers_url":"https://api.github.com/repos/mbilker/N1/subscribers","subscription_url":"https://api.github.com/repos/mbilker/N1/subscription","commits_url":"https://api.github.com/repos/mbilker/N1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbilker/N1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbilker/N1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbilker/N1/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbilker/N1/contents/{+path}","compare_url":"https://api.github.com/repos/mbilker/N1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbilker/N1/merges","archive_url":"https://api.github.com/repos/mbilker/N1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbilker/N1/downloads","issues_url":"https://api.github.com/repos/mbilker/N1/issues{/number}","pulls_url":"https://api.github.com/repos/mbilker/N1/pulls{/number}","milestones_url":"https://api.github.com/repos/mbilker/N1/milestones{/number}","notifications_url":"https://api.github.com/repos/mbilker/N1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbilker/N1/labels{/name}","releases_url":"https://api.github.com/repos/mbilker/N1/releases{/id}","deployments_url":"https://api.github.com/repos/mbilker/N1/deployments","created_at":"2015-10-07T03:32:30Z","updated_at":"2016-01-12T03:30:15Z","pushed_at":"2016-03-21T06:16:00Z","git_url":"git://github.com/mbilker/N1.git","ssh_url":"git@github.com:mbilker/N1.git","clone_url":"https://github.com/mbilker/N1.git","svn_url":"https://github.com/mbilker/N1","homepage":"https://nylas.com/N1","size":51934,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nylas:master","ref":"master","sha":"687597134d454a3d008e7e621626289a8dd2f058","user":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"repo":{"id":25315643,"name":"N1","full_name":"nylas/N1","owner":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas/N1","description":":love_letter: An extensible desktop mail app built on the modern web.","fork":false,"url":"https://api.github.com/repos/nylas/N1","forks_url":"https://api.github.com/repos/nylas/N1/forks","keys_url":"https://api.github.com/repos/nylas/N1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas/N1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas/N1/teams","hooks_url":"https://api.github.com/repos/nylas/N1/hooks","issue_events_url":"https://api.github.com/repos/nylas/N1/issues/events{/number}","events_url":"https://api.github.com/repos/nylas/N1/events","assignees_url":"https://api.github.com/repos/nylas/N1/assignees{/user}","branches_url":"https://api.github.com/repos/nylas/N1/branches{/branch}","tags_url":"https://api.github.com/repos/nylas/N1/tags","blobs_url":"https://api.github.com/repos/nylas/N1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas/N1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas/N1/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas/N1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas/N1/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas/N1/languages","stargazers_url":"https://api.github.com/repos/nylas/N1/stargazers","contributors_url":"https://api.github.com/repos/nylas/N1/contributors","subscribers_url":"https://api.github.com/repos/nylas/N1/subscribers","subscription_url":"https://api.github.com/repos/nylas/N1/subscription","commits_url":"https://api.github.com/repos/nylas/N1/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas/N1/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas/N1/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas/N1/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas/N1/contents/{+path}","compare_url":"https://api.github.com/repos/nylas/N1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas/N1/merges","archive_url":"https://api.github.com/repos/nylas/N1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas/N1/downloads","issues_url":"https://api.github.com/repos/nylas/N1/issues{/number}","pulls_url":"https://api.github.com/repos/nylas/N1/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas/N1/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas/N1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas/N1/labels{/name}","releases_url":"https://api.github.com/repos/nylas/N1/releases{/id}","deployments_url":"https://api.github.com/repos/nylas/N1/deployments","created_at":"2014-10-16T18:29:12Z","updated_at":"2016-03-21T20:47:15Z","pushed_at":"2016-03-21T19:20:14Z","git_url":"git://github.com/nylas/N1.git","ssh_url":"git@github.com:nylas/N1.git","clone_url":"https://github.com/nylas/N1.git","svn_url":"https://github.com/nylas/N1","homepage":"https://nylas.com/N1","size":55373,"stargazers_count":16362,"watchers_count":16362,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":550,"mirror_url":null,"open_issues_count":570,"forks":550,"open_issues":570,"watchers":16362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nylas/N1/pulls/1807"},"html":{"href":"https://github.com/nylas/N1/pull/1807"},"issue":{"href":"https://api.github.com/repos/nylas/N1/issues/1807"},"comments":{"href":"https://api.github.com/repos/nylas/N1/issues/1807/comments"},"review_comments":{"href":"https://api.github.com/repos/nylas/N1/pulls/1807/comments"},"review_comment":{"href":"https://api.github.com/repos/nylas/N1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nylas/N1/pulls/1807/commits"},"statuses":{"href":"https://api.github.com/repos/nylas/N1/statuses/7366eeb18deb70a9f6580b33d76187d31ac05dcf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":246,"deletions":9,"changed_files":6}}