{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69","id":54022215,"html_url":"https://github.com/PolymerElements/iron-input/pull/69","diff_url":"https://github.com/PolymerElements/iron-input/pull/69.diff","patch_url":"https://github.com/PolymerElements/iron-input/pull/69.patch","issue_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/69","number":69,"state":"closed","locked":false,"title":"Patch dispatchEvent on FF & IE to avoid disabled bugs. Fixes #47","user":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"body":"Fixes #47.\r\n\r\n(this was originally opened in https://github.com/PolymerElements/iron-input/pull/48 a long time ago, but I picked it up here to finally merge it).\r\n\r\nOriginal description\r\nFirefox has a bug where calling dispatchEvent on a non-attached and disabled input throws.\r\n\r\nThis can happen when any notify: true value is set on a disabled input type extension before attached, which can happen via a binding, during configuration of a default value, or by setting a property in ready when it is in the local-DOM of another element (since it won't be attached until after ready).\r\n\r\nAdditionally, in debugging this, we also found out that Firefox will not actually dispatch events from disabled form controls (regardless of attachment), and IE will not actually dispatch events from ANY disabled element.\r\n\r\nAfter considering how we'd fix this bug in Polymer core, we decided we'd rather just fix it locally in iron-input for now, to avoid adding a complex whitelist system in Polymer core to work around the browser quirks. If this becomes more of a problem outside of iron-input we can consider a more general solution.\r\n\r\nProof the test originally failed :)\r\n<img width=\"643\" alt=\"screen shot 2015-12-17 at 11 38 36 am\" src=\"https://cloud.githubusercontent.com/assets/1369170/11880012/8780dec0-a4b3-11e5-8a4c-c67330cb7e6f.png\">\r\n","created_at":"2015-12-17T19:44:32Z","updated_at":"2016-01-07T19:41:44Z","closed_at":"2016-01-07T19:41:43Z","merged_at":"2016-01-07T19:41:43Z","merge_commit_sha":"b98ad156f6c938d9de1561e17d90fca039e26271","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/iron-input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/69/comments","statuses_url":"https://api.github.com/repos/PolymerElements/iron-input/statuses/9ef163ad1390c61011f7472c8839cb454854d29f","head":{"label":"PolymerElements:fix-disabled","ref":"fix-disabled","sha":"9ef163ad1390c61011f7472c8839cb454854d29f","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34349757,"name":"iron-input","full_name":"PolymerElements/iron-input","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-input","description":"An input with data binding","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-input","forks_url":"https://api.github.com/repos/PolymerElements/iron-input/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-input/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-input/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-input/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-input/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-input/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-input/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-input/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-input/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-input/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-input/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-input/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-input/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-input/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-input/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-input/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-input/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-input/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-input/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-input/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-input/releases{/id}","created_at":"2015-04-21T20:11:45Z","updated_at":"2015-12-16T09:19:13Z","pushed_at":"2016-01-07T19:41:44Z","git_url":"git://github.com/PolymerElements/iron-input.git","ssh_url":"git@github.com:PolymerElements/iron-input.git","clone_url":"https://github.com/PolymerElements/iron-input.git","svn_url":"https://github.com/PolymerElements/iron-input","homepage":"https://elements.polymer-project.org/elements/iron-input?view=demo:demo/index.html","size":108,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"55d2b39ead32b8d90da538daa1a6681fd9ae89d9","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34349757,"name":"iron-input","full_name":"PolymerElements/iron-input","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-input","description":"An input with data binding","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-input","forks_url":"https://api.github.com/repos/PolymerElements/iron-input/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-input/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-input/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-input/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-input/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-input/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-input/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-input/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-input/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-input/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-input/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-input/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-input/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-input/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-input/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-input/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-input/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-input/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-input/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-input/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-input/releases{/id}","created_at":"2015-04-21T20:11:45Z","updated_at":"2015-12-16T09:19:13Z","pushed_at":"2016-01-07T19:41:44Z","git_url":"git://github.com/PolymerElements/iron-input.git","ssh_url":"git@github.com:PolymerElements/iron-input.git","clone_url":"https://github.com/PolymerElements/iron-input.git","svn_url":"https://github.com/PolymerElements/iron-input","homepage":"https://elements.polymer-project.org/elements/iron-input?view=demo:demo/index.html","size":108,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69"},"html":{"href":"https://github.com/PolymerElements/iron-input/pull/69"},"issue":{"href":"https://api.github.com/repos/PolymerElements/iron-input/issues/69"},"comments":{"href":"https://api.github.com/repos/PolymerElements/iron-input/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/iron-input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/iron-input/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/iron-input/statuses/9ef163ad1390c61011f7472c8839cb454854d29f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"comments":4,"review_comments":7,"commits":2,"additions":86,"deletions":2,"changed_files":3}}