{"action":"created","comment":{"url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/comments/85280223","pull_request_review_id":6002294,"id":85280223,"diff_hunk":"@@ -185,6 +201,24 @@ def runTest(self):\n         ])\n \n \n+class RandomSeedClassTestNP(RandomlyPluginTester, TestCase):","path":"tests/test_basic.py","position":27,"original_position":27,"commit_id":"7c207f0033fc15542fc2ffab5aadb6c55a3b7b99","original_commit_id":"7c207f0033fc15542fc2ffab5aadb6c55a3b7b99","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"body":"I don't think we need this test case - we have a test case that checks that random seeds in general are fixed during classes, and since it's part of the contract of `nose-randomly` that the various random states are reset at the same time, we shouldn't need to test again that the `numpy`'s specific random state is reset during classes.","created_at":"2016-10-27T07:35:01Z","updated_at":"2016-10-27T07:37:09Z","html_url":"https://github.com/adamchainz/nose-randomly/pull/26#discussion_r85280223","pull_request_url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/comments/85280223"},"html":{"href":"https://github.com/adamchainz/nose-randomly/pull/26#discussion_r85280223"},"pull_request":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26","id":91010072,"html_url":"https://github.com/adamchainz/nose-randomly/pull/26","diff_url":"https://github.com/adamchainz/nose-randomly/pull/26.diff","patch_url":"https://github.com/adamchainz/nose-randomly/pull/26.patch","issue_url":"https://api.github.com/repos/adamchainz/nose-randomly/issues/26","number":26,"state":"open","locked":false,"title":"Add opt numpy state","user":{"login":"marscher","id":170287,"avatar_url":"https://avatars.githubusercontent.com/u/170287?v=3","gravatar_id":"","url":"https://api.github.com/users/marscher","html_url":"https://github.com/marscher","followers_url":"https://api.github.com/users/marscher/followers","following_url":"https://api.github.com/users/marscher/following{/other_user}","gists_url":"https://api.github.com/users/marscher/gists{/gist_id}","starred_url":"https://api.github.com/users/marscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marscher/subscriptions","organizations_url":"https://api.github.com/users/marscher/orgs","repos_url":"https://api.github.com/users/marscher/repos","events_url":"https://api.github.com/users/marscher/events{/privacy}","received_events_url":"https://api.github.com/users/marscher/received_events","type":"User","site_admin":false},"body":"* This is done in the same manner as for factory boy and faker\r\n* It introduces a new random state member, since the numpy state differs from the stdlib random state.\r\n* Added tests\r\n ","created_at":"2016-10-26T13:59:48Z","updated_at":"2016-10-27T07:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a295bb1181728deeeb49a939580bd7ca4623c7f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26/commits","review_comments_url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26/comments","review_comment_url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adamchainz/nose-randomly/issues/26/comments","statuses_url":"https://api.github.com/repos/adamchainz/nose-randomly/statuses/7c207f0033fc15542fc2ffab5aadb6c55a3b7b99","head":{"label":"marscher:add_opt_numpy_state","ref":"add_opt_numpy_state","sha":"7c207f0033fc15542fc2ffab5aadb6c55a3b7b99","user":{"login":"marscher","id":170287,"avatar_url":"https://avatars.githubusercontent.com/u/170287?v=3","gravatar_id":"","url":"https://api.github.com/users/marscher","html_url":"https://github.com/marscher","followers_url":"https://api.github.com/users/marscher/followers","following_url":"https://api.github.com/users/marscher/following{/other_user}","gists_url":"https://api.github.com/users/marscher/gists{/gist_id}","starred_url":"https://api.github.com/users/marscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marscher/subscriptions","organizations_url":"https://api.github.com/users/marscher/orgs","repos_url":"https://api.github.com/users/marscher/repos","events_url":"https://api.github.com/users/marscher/events{/privacy}","received_events_url":"https://api.github.com/users/marscher/received_events","type":"User","site_admin":false},"repo":{"id":71997471,"name":"nose-randomly","full_name":"marscher/nose-randomly","owner":{"login":"marscher","id":170287,"avatar_url":"https://avatars.githubusercontent.com/u/170287?v=3","gravatar_id":"","url":"https://api.github.com/users/marscher","html_url":"https://github.com/marscher","followers_url":"https://api.github.com/users/marscher/followers","following_url":"https://api.github.com/users/marscher/following{/other_user}","gists_url":"https://api.github.com/users/marscher/gists{/gist_id}","starred_url":"https://api.github.com/users/marscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marscher/subscriptions","organizations_url":"https://api.github.com/users/marscher/orgs","repos_url":"https://api.github.com/users/marscher/repos","events_url":"https://api.github.com/users/marscher/events{/privacy}","received_events_url":"https://api.github.com/users/marscher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marscher/nose-randomly","description":":nose: Nose plugin to randomly order tests and control `random.seed`","fork":true,"url":"https://api.github.com/repos/marscher/nose-randomly","forks_url":"https://api.github.com/repos/marscher/nose-randomly/forks","keys_url":"https://api.github.com/repos/marscher/nose-randomly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marscher/nose-randomly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marscher/nose-randomly/teams","hooks_url":"https://api.github.com/repos/marscher/nose-randomly/hooks","issue_events_url":"https://api.github.com/repos/marscher/nose-randomly/issues/events{/number}","events_url":"https://api.github.com/repos/marscher/nose-randomly/events","assignees_url":"https://api.github.com/repos/marscher/nose-randomly/assignees{/user}","branches_url":"https://api.github.com/repos/marscher/nose-randomly/branches{/branch}","tags_url":"https://api.github.com/repos/marscher/nose-randomly/tags","blobs_url":"https://api.github.com/repos/marscher/nose-randomly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marscher/nose-randomly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marscher/nose-randomly/git/refs{/sha}","trees_url":"https://api.github.com/repos/marscher/nose-randomly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marscher/nose-randomly/statuses/{sha}","languages_url":"https://api.github.com/repos/marscher/nose-randomly/languages","stargazers_url":"https://api.github.com/repos/marscher/nose-randomly/stargazers","contributors_url":"https://api.github.com/repos/marscher/nose-randomly/contributors","subscribers_url":"https://api.github.com/repos/marscher/nose-randomly/subscribers","subscription_url":"https://api.github.com/repos/marscher/nose-randomly/subscription","commits_url":"https://api.github.com/repos/marscher/nose-randomly/commits{/sha}","git_commits_url":"https://api.github.com/repos/marscher/nose-randomly/git/commits{/sha}","comments_url":"https://api.github.com/repos/marscher/nose-randomly/comments{/number}","issue_comment_url":"https://api.github.com/repos/marscher/nose-randomly/issues/comments{/number}","contents_url":"https://api.github.com/repos/marscher/nose-randomly/contents/{+path}","compare_url":"https://api.github.com/repos/marscher/nose-randomly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marscher/nose-randomly/merges","archive_url":"https://api.github.com/repos/marscher/nose-randomly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marscher/nose-randomly/downloads","issues_url":"https://api.github.com/repos/marscher/nose-randomly/issues{/number}","pulls_url":"https://api.github.com/repos/marscher/nose-randomly/pulls{/number}","milestones_url":"https://api.github.com/repos/marscher/nose-randomly/milestones{/number}","notifications_url":"https://api.github.com/repos/marscher/nose-randomly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marscher/nose-randomly/labels{/name}","releases_url":"https://api.github.com/repos/marscher/nose-randomly/releases{/id}","deployments_url":"https://api.github.com/repos/marscher/nose-randomly/deployments","created_at":"2016-10-26T11:41:53Z","updated_at":"2016-10-26T11:41:54Z","pushed_at":"2016-10-26T14:48:56Z","git_url":"git://github.com/marscher/nose-randomly.git","ssh_url":"git@github.com:marscher/nose-randomly.git","clone_url":"https://github.com/marscher/nose-randomly.git","svn_url":"https://github.com/marscher/nose-randomly","homepage":"","size":53,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adamchainz:master","ref":"master","sha":"5af8d2c1dbfcaa49dc9134c35b4df99d365ce779","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"repo":{"id":39631752,"name":"nose-randomly","full_name":"adamchainz/nose-randomly","owner":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamchainz/nose-randomly","description":":nose: Nose plugin to randomly order tests and control `random.seed`","fork":false,"url":"https://api.github.com/repos/adamchainz/nose-randomly","forks_url":"https://api.github.com/repos/adamchainz/nose-randomly/forks","keys_url":"https://api.github.com/repos/adamchainz/nose-randomly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamchainz/nose-randomly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamchainz/nose-randomly/teams","hooks_url":"https://api.github.com/repos/adamchainz/nose-randomly/hooks","issue_events_url":"https://api.github.com/repos/adamchainz/nose-randomly/issues/events{/number}","events_url":"https://api.github.com/repos/adamchainz/nose-randomly/events","assignees_url":"https://api.github.com/repos/adamchainz/nose-randomly/assignees{/user}","branches_url":"https://api.github.com/repos/adamchainz/nose-randomly/branches{/branch}","tags_url":"https://api.github.com/repos/adamchainz/nose-randomly/tags","blobs_url":"https://api.github.com/repos/adamchainz/nose-randomly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamchainz/nose-randomly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamchainz/nose-randomly/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamchainz/nose-randomly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamchainz/nose-randomly/statuses/{sha}","languages_url":"https://api.github.com/repos/adamchainz/nose-randomly/languages","stargazers_url":"https://api.github.com/repos/adamchainz/nose-randomly/stargazers","contributors_url":"https://api.github.com/repos/adamchainz/nose-randomly/contributors","subscribers_url":"https://api.github.com/repos/adamchainz/nose-randomly/subscribers","subscription_url":"https://api.github.com/repos/adamchainz/nose-randomly/subscription","commits_url":"https://api.github.com/repos/adamchainz/nose-randomly/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamchainz/nose-randomly/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamchainz/nose-randomly/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamchainz/nose-randomly/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamchainz/nose-randomly/contents/{+path}","compare_url":"https://api.github.com/repos/adamchainz/nose-randomly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamchainz/nose-randomly/merges","archive_url":"https://api.github.com/repos/adamchainz/nose-randomly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamchainz/nose-randomly/downloads","issues_url":"https://api.github.com/repos/adamchainz/nose-randomly/issues{/number}","pulls_url":"https://api.github.com/repos/adamchainz/nose-randomly/pulls{/number}","milestones_url":"https://api.github.com/repos/adamchainz/nose-randomly/milestones{/number}","notifications_url":"https://api.github.com/repos/adamchainz/nose-randomly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamchainz/nose-randomly/labels{/name}","releases_url":"https://api.github.com/repos/adamchainz/nose-randomly/releases{/id}","deployments_url":"https://api.github.com/repos/adamchainz/nose-randomly/deployments","created_at":"2015-07-24T12:27:59Z","updated_at":"2016-08-17T18:22:02Z","pushed_at":"2016-10-26T14:48:57Z","git_url":"git://github.com/adamchainz/nose-randomly.git","ssh_url":"git@github.com:adamchainz/nose-randomly.git","clone_url":"https://github.com/adamchainz/nose-randomly.git","svn_url":"https://github.com/adamchainz/nose-randomly","homepage":"","size":41,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26"},"html":{"href":"https://github.com/adamchainz/nose-randomly/pull/26"},"issue":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/issues/26"},"comments":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/adamchainz/nose-randomly/statuses/7c207f0033fc15542fc2ffab5aadb6c55a3b7b99"}}}}
{"actor":{"display_login":"adamchainz"}}