{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments/79291302","id":79291302,"diff_hunk":"@@ -738,6 +751,15 @@ def _load_stylesheet(self):\n         finally:\n             f.close()\n \n+    def _download_attachments(self, attachments, note_id):\n+        \"\"\"\n+        Downloads the contents of the given list of Attachment entities.\n+\n+        :param list attachments: A list of Attachment entities to download.","path":"python/version_details/version_details.py","position":89,"original_position":89,"commit_id":"b93e3f39f42774b317a09eb3db3860ca50906803","original_commit_id":"b0c312181a3fc9d4d301d0b48719e7842dbc989f","user":{"login":"josh-t","id":2604646,"avatar_url":"https://avatars.githubusercontent.com/u/2604646?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-t","html_url":"https://github.com/josh-t","followers_url":"https://api.github.com/users/josh-t/followers","following_url":"https://api.github.com/users/josh-t/following{/other_user}","gists_url":"https://api.github.com/users/josh-t/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-t/subscriptions","organizations_url":"https://api.github.com/users/josh-t/orgs","repos_url":"https://api.github.com/users/josh-t/repos","events_url":"https://api.github.com/users/josh-t/events{/privacy}","received_events_url":"https://api.github.com/users/josh-t/received_events","type":"User","site_admin":false},"body":"missing param docs for `note_id`","created_at":"2016-09-17T20:22:15Z","updated_at":"2016-09-17T20:27:21Z","html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43#discussion_r79291302","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments/79291302"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43#discussion_r79291302"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43","id":85649879,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43","diff_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43.diff","patch_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/43","number":43,"state":"open","locked":false,"title":"Game #16288: Attachments download refactor.","user":{"login":"thebeeland","id":4913787,"avatar_url":"https://avatars.githubusercontent.com/u/4913787?v=3","gravatar_id":"","url":"https://api.github.com/users/thebeeland","html_url":"https://github.com/thebeeland","followers_url":"https://api.github.com/users/thebeeland/followers","following_url":"https://api.github.com/users/thebeeland/following{/other_user}","gists_url":"https://api.github.com/users/thebeeland/gists{/gist_id}","starred_url":"https://api.github.com/users/thebeeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebeeland/subscriptions","organizations_url":"https://api.github.com/users/thebeeland/orgs","repos_url":"https://api.github.com/users/thebeeland/repos","events_url":"https://api.github.com/users/thebeeland/events{/privacy}","received_events_url":"https://api.github.com/users/thebeeland/received_events","type":"User","site_admin":false},"body":"Rather than relying on the activity stream cache being up to date with the current list of Attachment entities for a Note, we now query for them live and download what we find asynchronously.","created_at":"2016-09-16T22:38:25Z","updated_at":"2016-09-17T20:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e37fd822c0716e432b2f518277f3be59c80f5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/43/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/b93e3f39f42774b317a09eb3db3860ca50906803","head":{"label":"shotgunsoftware:game_16288_markup_attachments","ref":"game_16288_markup_attachments","sha":"b93e3f39f42774b317a09eb3db3860ca50906803","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":19910716,"name":"tk-framework-qtwidgets","full_name":"shotgunsoftware/tk-framework-qtwidgets","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","description":"A collection of Toolkit related QT Widgets","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/deployments","created_at":"2014-05-18T13:12:00Z","updated_at":"2016-03-07T00:35:48Z","pushed_at":"2016-09-17T12:11:56Z","git_url":"git://github.com/shotgunsoftware/tk-framework-qtwidgets.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-qtwidgets.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","homepage":"","size":53758,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"cfe9d2c4ffc517388cbc21c5953afd19635f91df","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":19910716,"name":"tk-framework-qtwidgets","full_name":"shotgunsoftware/tk-framework-qtwidgets","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","description":"A collection of Toolkit related QT Widgets","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/deployments","created_at":"2014-05-18T13:12:00Z","updated_at":"2016-03-07T00:35:48Z","pushed_at":"2016-09-17T12:11:56Z","git_url":"git://github.com/shotgunsoftware/tk-framework-qtwidgets.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-qtwidgets.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","homepage":"","size":53758,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/43"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/43"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/b93e3f39f42774b317a09eb3db3860ca50906803"}}}}
{"actor":{"display_login":"josh-t"}}