{"action":"created","comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/93419420","pull_request_review_id":13945513,"id":93419420,"diff_hunk":"@@ -958,6 +959,170 @@ def plot_explained_variance_ratio(self, n=50, log=True):\n             ax.semilogy()\n         return ax\n \n+    def scree_plot(self, n=50, log=True, cutoff=0.01, signal_num=0,","path":"hyperspy/learn/mva.py","position":14,"original_position":14,"commit_id":"af1c6aa0725a99e4d417e7bc04cc734d837084d3","original_commit_id":"af1c6aa0725a99e4d417e7bc04cc734d837084d3","user":{"login":"tjof2","id":6626247,"avatar_url":"https://avatars.githubusercontent.com/u/6626247?v=3","gravatar_id":"","url":"https://api.github.com/users/tjof2","html_url":"https://github.com/tjof2","followers_url":"https://api.github.com/users/tjof2/followers","following_url":"https://api.github.com/users/tjof2/following{/other_user}","gists_url":"https://api.github.com/users/tjof2/gists{/gist_id}","starred_url":"https://api.github.com/users/tjof2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjof2/subscriptions","organizations_url":"https://api.github.com/users/tjof2/orgs","repos_url":"https://api.github.com/users/tjof2/repos","events_url":"https://api.github.com/users/tjof2/events{/privacy}","received_events_url":"https://api.github.com/users/tjof2/received_events","type":"User","site_admin":false},"body":"@francisco-dlp not really for PCA - the reason I used soft rather than hard-thresholding (i.e. PCA) of the singular values was because it's easier to automate! @bm424 might know more.","created_at":"2016-12-21T11:13:44Z","updated_at":"2016-12-21T11:13:44Z","html_url":"https://github.com/hyperspy/hyperspy/pull/1359#discussion_r93419420","pull_request_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359","_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/93419420"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/1359#discussion_r93419420"},"pull_request":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359"}}},"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359","id":98255380,"html_url":"https://github.com/hyperspy/hyperspy/pull/1359","diff_url":"https://github.com/hyperspy/hyperspy/pull/1359.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/1359.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1359","number":1359,"state":"open","locked":false,"title":"ENH: scree plot improvements","user":{"login":"jat255","id":1278301,"avatar_url":"https://avatars.githubusercontent.com/u/1278301?v=3","gravatar_id":"","url":"https://api.github.com/users/jat255","html_url":"https://github.com/jat255","followers_url":"https://api.github.com/users/jat255/followers","following_url":"https://api.github.com/users/jat255/following{/other_user}","gists_url":"https://api.github.com/users/jat255/gists{/gist_id}","starred_url":"https://api.github.com/users/jat255/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jat255/subscriptions","organizations_url":"https://api.github.com/users/jat255/orgs","repos_url":"https://api.github.com/users/jat255/repos","events_url":"https://api.github.com/users/jat255/events{/privacy}","received_events_url":"https://api.github.com/users/jat255/received_events","type":"User","site_admin":false},"body":"Re-opening of #607. Implemented requested changes, and should be ready for review.\r\n\r\n**Todo**\r\n- [x] Implement dictionary parsing for options\r\n- [x] Highlighting by using different symbols (for gray figures).\r\n- [x] Ability to pass the matplotlib axes (to plot several scree plots in the same axes)\r\n- [x] Ability to pass the matplotlib figure (e.g. to customize the size).\r\n- [x] Add options for horizontal line\r\n- [x] Add options for axes titles\r\n- [x] Documentation and user guide update","created_at":"2016-12-15T23:59:21Z","updated_at":"2016-12-21T11:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b376caae75717aae42e1bbe55fb35841f15550","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1359/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/af1c6aa0725a99e4d417e7bc04cc734d837084d3","head":{"label":"jat255:ENH_scree_plot_improvements","ref":"ENH_scree_plot_improvements","sha":"af1c6aa0725a99e4d417e7bc04cc734d837084d3","user":{"login":"jat255","id":1278301,"avatar_url":"https://avatars.githubusercontent.com/u/1278301?v=3","gravatar_id":"","url":"https://api.github.com/users/jat255","html_url":"https://github.com/jat255","followers_url":"https://api.github.com/users/jat255/followers","following_url":"https://api.github.com/users/jat255/following{/other_user}","gists_url":"https://api.github.com/users/jat255/gists{/gist_id}","starred_url":"https://api.github.com/users/jat255/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jat255/subscriptions","organizations_url":"https://api.github.com/users/jat255/orgs","repos_url":"https://api.github.com/users/jat255/repos","events_url":"https://api.github.com/users/jat255/events{/privacy}","received_events_url":"https://api.github.com/users/jat255/received_events","type":"User","site_admin":false},"repo":{"id":28409375,"name":"hyperspy","full_name":"jat255/hyperspy","owner":{"login":"jat255","id":1278301,"avatar_url":"https://avatars.githubusercontent.com/u/1278301?v=3","gravatar_id":"","url":"https://api.github.com/users/jat255","html_url":"https://github.com/jat255","followers_url":"https://api.github.com/users/jat255/followers","following_url":"https://api.github.com/users/jat255/following{/other_user}","gists_url":"https://api.github.com/users/jat255/gists{/gist_id}","starred_url":"https://api.github.com/users/jat255/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jat255/subscriptions","organizations_url":"https://api.github.com/users/jat255/orgs","repos_url":"https://api.github.com/users/jat255/repos","events_url":"https://api.github.com/users/jat255/events{/privacy}","received_events_url":"https://api.github.com/users/jat255/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jat255/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/jat255/hyperspy","forks_url":"https://api.github.com/repos/jat255/hyperspy/forks","keys_url":"https://api.github.com/repos/jat255/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jat255/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jat255/hyperspy/teams","hooks_url":"https://api.github.com/repos/jat255/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/jat255/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/jat255/hyperspy/events","assignees_url":"https://api.github.com/repos/jat255/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/jat255/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/jat255/hyperspy/tags","blobs_url":"https://api.github.com/repos/jat255/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jat255/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jat255/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jat255/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jat255/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/jat255/hyperspy/languages","stargazers_url":"https://api.github.com/repos/jat255/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/jat255/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/jat255/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/jat255/hyperspy/subscription","commits_url":"https://api.github.com/repos/jat255/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jat255/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jat255/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jat255/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jat255/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/jat255/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jat255/hyperspy/merges","archive_url":"https://api.github.com/repos/jat255/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jat255/hyperspy/downloads","issues_url":"https://api.github.com/repos/jat255/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/jat255/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/jat255/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/jat255/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jat255/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/jat255/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/jat255/hyperspy/deployments","created_at":"2014-12-23T16:59:02Z","updated_at":"2016-02-12T18:06:34Z","pushed_at":"2016-12-20T14:04:31Z","git_url":"git://github.com/jat255/hyperspy.git","ssh_url":"git@github.com:jat255/hyperspy.git","clone_url":"https://github.com/jat255/hyperspy.git","svn_url":"https://github.com/jat255/hyperspy","homepage":"http://www.hyperspy.org","size":88398,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"RELEASE_next_minor"}},"base":{"label":"hyperspy:RELEASE_next_minor","ref":"RELEASE_next_minor","sha":"bbc79eab2ed5dbfa8d48b76932d186d5fc098a5f","user":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2016-12-16T22:50:57Z","pushed_at":"2016-12-20T23:14:22Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":98617,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":175,"forks":51,"open_issues":175,"watchers":80,"default_branch":"RELEASE_next_minor"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/1359"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/1359"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/1359/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1359/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/af1c6aa0725a99e4d417e7bc04cc734d837084d3"}}}}
{"actor":{"display_login":"tjof2"}}