{"action":"created","issue":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/387","repository_url":"https://api.github.com/repos/aodn/imos-toolbox","labels_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/387/labels{/name}","comments_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/387/comments","events_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/387/events","html_url":"https://github.com/aodn/imos-toolbox/issues/387","id":188669704,"number":387,"title":"Application of manual qc to data that returns more that one sample_data structure","user":{"login":"sspagnol","id":2917450,"avatar_url":"https://avatars.githubusercontent.com/u/2917450?v=3","gravatar_id":"","url":"https://api.github.com/users/sspagnol","html_url":"https://github.com/sspagnol","followers_url":"https://api.github.com/users/sspagnol/followers","following_url":"https://api.github.com/users/sspagnol/following{/other_user}","gists_url":"https://api.github.com/users/sspagnol/gists{/gist_id}","starred_url":"https://api.github.com/users/sspagnol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sspagnol/subscriptions","organizations_url":"https://api.github.com/users/sspagnol/orgs","repos_url":"https://api.github.com/users/sspagnol/repos","events_url":"https://api.github.com/users/sspagnol/events{/privacy}","received_events_url":"https://api.github.com/users/sspagnol/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-11T02:21:13Z","updated_at":"2016-11-21T00:54:10Z","closed_at":"2016-11-21T00:54:10Z","body":"Sorry for the long winded issue, can't think of a nice way to describe this.\r\n\r\nIf you import and RDI what has waves you will have two sample_data entries but only one mqc file for the two files e.g. import adcp.000 and adcp.WVS, do some manual qc on wave parameters you end up with only one mqc file (adcp.mqc). But when you reimport data and redo historical QC, imosHistoricalManualSetQC.m will try to look for wave parameters when acting on sample_data structure from 000 file. Actuall error will occur in line 78\r\n\r\n```MATLAB\r\nsample_data.variables{idVar}.flags(dataIdx) = flag;\r\n```\r\ndue to fact that\r\n```MATLAB\r\nidVar   = getVar(sample_data.variables, mqc(i).nameVar);\r\n```\r\nwill return 0 (eg looking for variable WWSH from waves WVS file while working on sample_data struct from 000 currents file).\r\n\r\nAs a quick workaround for my use I just tested if idVar was zero and continued. For longer term solution either that (so can still use already created mqc files) or change the qc file name i.e. if import filename.ext then qc file is filename_ext.mqc or something."},"comment":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/comments/261819898","html_url":"https://github.com/aodn/imos-toolbox/issues/387#issuecomment-261819898","issue_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/387","id":261819898,"user":{"login":"ggalibert","id":3498686,"avatar_url":"https://avatars.githubusercontent.com/u/3498686?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalibert","html_url":"https://github.com/ggalibert","followers_url":"https://api.github.com/users/ggalibert/followers","following_url":"https://api.github.com/users/ggalibert/following{/other_user}","gists_url":"https://api.github.com/users/ggalibert/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalibert/subscriptions","organizations_url":"https://api.github.com/users/ggalibert/orgs","repos_url":"https://api.github.com/users/ggalibert/repos","events_url":"https://api.github.com/users/ggalibert/events{/privacy}","received_events_url":"https://api.github.com/users/ggalibert/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T00:54:09Z","updated_at":"2016-11-21T00:54:09Z","body":"Should be fixed by https://github.com/aodn/imos-toolbox/commit/b06dd10c23def612c87c7bb2e035cc62574a97f6 in https://github.com/aodn/imos-toolbox/releases/tag/v2.5.20 . New file naming convention is fileName.ext.mqc / .pqc ."}}
{"actor":{"display_login":"ggalibert"}}