{"action":"created","issue":{"url":"https://api.github.com/repos/eBay/fabio/issues/117","repository_url":"https://api.github.com/repos/eBay/fabio","labels_url":"https://api.github.com/repos/eBay/fabio/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/eBay/fabio/issues/117/comments","events_url":"https://api.github.com/repos/eBay/fabio/issues/117/events","html_url":"https://github.com/eBay/fabio/pull/117","id":161184363,"number":117,"title":"Allow routes to a service in warning status","user":{"login":"erikvanoosten","id":630600,"avatar_url":"https://avatars.githubusercontent.com/u/630600?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanoosten","html_url":"https://github.com/erikvanoosten","followers_url":"https://api.github.com/users/erikvanoosten/followers","following_url":"https://api.github.com/users/erikvanoosten/following{/other_user}","gists_url":"https://api.github.com/users/erikvanoosten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanoosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanoosten/subscriptions","organizations_url":"https://api.github.com/users/erikvanoosten/orgs","repos_url":"https://api.github.com/users/erikvanoosten/repos","events_url":"https://api.github.com/users/erikvanoosten/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanoosten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-20T12:31:53Z","updated_at":"2016-06-21T08:00:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eBay/fabio/pulls/117","html_url":"https://github.com/eBay/fabio/pull/117","diff_url":"https://github.com/eBay/fabio/pull/117.diff","patch_url":"https://github.com/eBay/fabio/pull/117.patch"},"body":"Currently Fabio only creates routes to services in the passing state. We have a use case for also wanting to use services in warning status. In consul the warning status indicates that the service is still good to go, but requires attention to keep it that way.\r\n\r\nIn this PR the acceptable statuses can be configured in fabio.properties where the default is just \"passing\" for backward compatibility.\r\n\r\nAs a bonus a few minor typos were fixed.\r\n\r\nUnlike my previous attempt ( #116 ) this PR has a single squashed commit."},"comment":{"url":"https://api.github.com/repos/eBay/fabio/issues/comments/227368215","html_url":"https://github.com/eBay/fabio/pull/117#issuecomment-227368215","issue_url":"https://api.github.com/repos/eBay/fabio/issues/117","id":227368215,"user":{"login":"magiconair","id":229005,"avatar_url":"https://avatars.githubusercontent.com/u/229005?v=3","gravatar_id":"","url":"https://api.github.com/users/magiconair","html_url":"https://github.com/magiconair","followers_url":"https://api.github.com/users/magiconair/followers","following_url":"https://api.github.com/users/magiconair/following{/other_user}","gists_url":"https://api.github.com/users/magiconair/gists{/gist_id}","starred_url":"https://api.github.com/users/magiconair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiconair/subscriptions","organizations_url":"https://api.github.com/users/magiconair/orgs","repos_url":"https://api.github.com/users/magiconair/repos","events_url":"https://api.github.com/users/magiconair/events{/privacy}","received_events_url":"https://api.github.com/users/magiconair/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T08:00:30Z","updated_at":"2016-06-21T08:00:30Z","body":"Could you please rename the field in the config struct to `ServiceStatus`? Then it is in line with the config parameter and the rest of the`ServiceXXX` fields in the `Config` struct. Leave the function parameters at `status`. Then we're good. Sorry for bothering again. Should have seen this yesterday.\r\n\r\nBTW, is there a way for me to amend this change like in gerrit so that I don't have to bother you with this?"}}
{"actor":{"display_login":"magiconair"}}