{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/comments/59125309","id":59125309,"diff_hunk":"@@ -88,7 +90,7 @@ export default function connect(mapStateToProps, mapDispatchToProps, mergeProps,\n           this.finalMapStateToProps(state, props) :\n           this.finalMapStateToProps(state)\n \n-        return checkStateShape(stateProps)\n+        return checkStateShape(this.constructor.displayName, stateProps)","path":"src/components/connect.js","position":null,"original_position":34,"commit_id":"e6d0665ce94692f56db69e440a3d7c315dca4d55","original_commit_id":"9d16da2cdb2157daf2da22a8cdd66da03b9a40aa","user":{"login":"chentsulin","id":3382565,"avatar_url":"https://avatars.githubusercontent.com/u/3382565?v=3","gravatar_id":"","url":"https://api.github.com/users/chentsulin","html_url":"https://github.com/chentsulin","followers_url":"https://api.github.com/users/chentsulin/followers","following_url":"https://api.github.com/users/chentsulin/following{/other_user}","gists_url":"https://api.github.com/users/chentsulin/gists{/gist_id}","starred_url":"https://api.github.com/users/chentsulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chentsulin/subscriptions","organizations_url":"https://api.github.com/users/chentsulin/orgs","repos_url":"https://api.github.com/users/chentsulin/repos","events_url":"https://api.github.com/users/chentsulin/events{/privacy}","received_events_url":"https://api.github.com/users/chentsulin/received_events","type":"User","site_admin":false},"body":"Should we use var before `wrapWithConnect`? Or move `checkStateShape` into `wrapWithConnect`? `checkStateShape` can't use `connectDisplayName` directly because they live in the different scope.","created_at":"2016-04-10T01:56:23Z","updated_at":"2016-04-10T01:56:23Z","html_url":"https://github.com/reactjs/react-redux/pull/335#discussion_r59125309","pull_request_url":"https://api.github.com/repos/reactjs/react-redux/pulls/335","_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/comments/59125309"},"html":{"href":"https://github.com/reactjs/react-redux/pull/335#discussion_r59125309"},"pull_request":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/335","id":65427606,"html_url":"https://github.com/reactjs/react-redux/pull/335","diff_url":"https://github.com/reactjs/react-redux/pull/335.diff","patch_url":"https://github.com/reactjs/react-redux/pull/335.patch","issue_url":"https://api.github.com/repos/reactjs/react-redux/issues/335","number":335,"state":"open","locked":false,"title":"Close #309, Improve  invariant validation error message","user":{"login":"chentsulin","id":3382565,"avatar_url":"https://avatars.githubusercontent.com/u/3382565?v=3","gravatar_id":"","url":"https://api.github.com/users/chentsulin","html_url":"https://github.com/chentsulin","followers_url":"https://api.github.com/users/chentsulin/followers","following_url":"https://api.github.com/users/chentsulin/following{/other_user}","gists_url":"https://api.github.com/users/chentsulin/gists{/gist_id}","starred_url":"https://api.github.com/users/chentsulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chentsulin/subscriptions","organizations_url":"https://api.github.com/users/chentsulin/orgs","repos_url":"https://api.github.com/users/chentsulin/repos","events_url":"https://api.github.com/users/chentsulin/events{/privacy}","received_events_url":"https://api.github.com/users/chentsulin/received_events","type":"User","site_admin":false},"body":"This should fix #309","created_at":"2016-04-06T08:28:38Z","updated_at":"2016-04-10T01:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"297cd0bcb7a508601787c5f5c3ca932cac9c820d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/react-redux/pulls/335/commits","review_comments_url":"https://api.github.com/repos/reactjs/react-redux/pulls/335/comments","review_comment_url":"https://api.github.com/repos/reactjs/react-redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/react-redux/issues/335/comments","statuses_url":"https://api.github.com/repos/reactjs/react-redux/statuses/e6d0665ce94692f56db69e440a3d7c315dca4d55","head":{"label":"chentsulin:improve-mapStateToProps-invariant","ref":"improve-mapStateToProps-invariant","sha":"e6d0665ce94692f56db69e440a3d7c315dca4d55","user":{"login":"chentsulin","id":3382565,"avatar_url":"https://avatars.githubusercontent.com/u/3382565?v=3","gravatar_id":"","url":"https://api.github.com/users/chentsulin","html_url":"https://github.com/chentsulin","followers_url":"https://api.github.com/users/chentsulin/followers","following_url":"https://api.github.com/users/chentsulin/following{/other_user}","gists_url":"https://api.github.com/users/chentsulin/gists{/gist_id}","starred_url":"https://api.github.com/users/chentsulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chentsulin/subscriptions","organizations_url":"https://api.github.com/users/chentsulin/orgs","repos_url":"https://api.github.com/users/chentsulin/repos","events_url":"https://api.github.com/users/chentsulin/events{/privacy}","received_events_url":"https://api.github.com/users/chentsulin/received_events","type":"User","site_admin":false},"repo":{"id":53383683,"name":"react-redux","full_name":"chentsulin/react-redux","owner":{"login":"chentsulin","id":3382565,"avatar_url":"https://avatars.githubusercontent.com/u/3382565?v=3","gravatar_id":"","url":"https://api.github.com/users/chentsulin","html_url":"https://github.com/chentsulin","followers_url":"https://api.github.com/users/chentsulin/followers","following_url":"https://api.github.com/users/chentsulin/following{/other_user}","gists_url":"https://api.github.com/users/chentsulin/gists{/gist_id}","starred_url":"https://api.github.com/users/chentsulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chentsulin/subscriptions","organizations_url":"https://api.github.com/users/chentsulin/orgs","repos_url":"https://api.github.com/users/chentsulin/repos","events_url":"https://api.github.com/users/chentsulin/events{/privacy}","received_events_url":"https://api.github.com/users/chentsulin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chentsulin/react-redux","description":"Official React bindings for Redux","fork":true,"url":"https://api.github.com/repos/chentsulin/react-redux","forks_url":"https://api.github.com/repos/chentsulin/react-redux/forks","keys_url":"https://api.github.com/repos/chentsulin/react-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chentsulin/react-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chentsulin/react-redux/teams","hooks_url":"https://api.github.com/repos/chentsulin/react-redux/hooks","issue_events_url":"https://api.github.com/repos/chentsulin/react-redux/issues/events{/number}","events_url":"https://api.github.com/repos/chentsulin/react-redux/events","assignees_url":"https://api.github.com/repos/chentsulin/react-redux/assignees{/user}","branches_url":"https://api.github.com/repos/chentsulin/react-redux/branches{/branch}","tags_url":"https://api.github.com/repos/chentsulin/react-redux/tags","blobs_url":"https://api.github.com/repos/chentsulin/react-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chentsulin/react-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chentsulin/react-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/chentsulin/react-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chentsulin/react-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/chentsulin/react-redux/languages","stargazers_url":"https://api.github.com/repos/chentsulin/react-redux/stargazers","contributors_url":"https://api.github.com/repos/chentsulin/react-redux/contributors","subscribers_url":"https://api.github.com/repos/chentsulin/react-redux/subscribers","subscription_url":"https://api.github.com/repos/chentsulin/react-redux/subscription","commits_url":"https://api.github.com/repos/chentsulin/react-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/chentsulin/react-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/chentsulin/react-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/chentsulin/react-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/chentsulin/react-redux/contents/{+path}","compare_url":"https://api.github.com/repos/chentsulin/react-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chentsulin/react-redux/merges","archive_url":"https://api.github.com/repos/chentsulin/react-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chentsulin/react-redux/downloads","issues_url":"https://api.github.com/repos/chentsulin/react-redux/issues{/number}","pulls_url":"https://api.github.com/repos/chentsulin/react-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/chentsulin/react-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/chentsulin/react-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chentsulin/react-redux/labels{/name}","releases_url":"https://api.github.com/repos/chentsulin/react-redux/releases{/id}","deployments_url":"https://api.github.com/repos/chentsulin/react-redux/deployments","created_at":"2016-03-08T04:55:10Z","updated_at":"2016-03-08T04:55:11Z","pushed_at":"2016-04-10T01:52:56Z","git_url":"git://github.com/chentsulin/react-redux.git","ssh_url":"git@github.com:chentsulin/react-redux.git","clone_url":"https://github.com/chentsulin/react-redux.git","svn_url":"https://github.com/chentsulin/react-redux","homepage":"http://redux.js.org/docs/basics/UsageWithReact.html","size":306,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"e55e93a25562cbf6a69ce21aadbbf8d5e939bd48","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":38934449,"name":"react-redux","full_name":"reactjs/react-redux","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-redux","description":"Official React bindings for Redux","fork":false,"url":"https://api.github.com/repos/reactjs/react-redux","forks_url":"https://api.github.com/repos/reactjs/react-redux/forks","keys_url":"https://api.github.com/repos/reactjs/react-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-redux/teams","hooks_url":"https://api.github.com/repos/reactjs/react-redux/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-redux/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-redux/events","assignees_url":"https://api.github.com/repos/reactjs/react-redux/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-redux/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-redux/tags","blobs_url":"https://api.github.com/repos/reactjs/react-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-redux/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-redux/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-redux/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-redux/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-redux/subscription","commits_url":"https://api.github.com/repos/reactjs/react-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-redux/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-redux/merges","archive_url":"https://api.github.com/repos/reactjs/react-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-redux/downloads","issues_url":"https://api.github.com/repos/reactjs/react-redux/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-redux/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-redux/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-redux/deployments","created_at":"2015-07-11T17:32:01Z","updated_at":"2016-04-09T20:19:49Z","pushed_at":"2016-04-10T01:52:56Z","git_url":"git://github.com/reactjs/react-redux.git","ssh_url":"git@github.com:reactjs/react-redux.git","clone_url":"https://github.com/reactjs/react-redux.git","svn_url":"https://github.com/reactjs/react-redux","homepage":"http://redux.js.org/docs/basics/UsageWithReact.html","size":421,"stargazers_count":2751,"watchers_count":2751,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":18,"forks":349,"open_issues":18,"watchers":2751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/335"},"html":{"href":"https://github.com/reactjs/react-redux/pull/335"},"issue":{"href":"https://api.github.com/repos/reactjs/react-redux/issues/335"},"comments":{"href":"https://api.github.com/repos/reactjs/react-redux/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/react-redux/statuses/e6d0665ce94692f56db69e440a3d7c315dca4d55"}}}}