{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/57504959","id":57504959,"diff_hunk":"@@ -244,6 +244,56 @@ def test_cache_key_memcache_validation(self):\n         self.assertEqual(cache_key, 'staticfiles:821ea71ef36f95b3922a77f7364670e7')\n \n \n+@override_settings(\n+    **dict(\n+        TEST_SETTINGS,\n+        STATICFILES_STORAGE=(\n+            'staticfiles_tests.storage.MultiCachedStaticFilesStorage'\n+        ),\n+        DEBUG=False,  # see note above\n+    )\n+)\n+class TestMultiCachedStorage(BaseCollectionTestCase, BaseStaticFilesTestCase,\n+        SimpleTestCase):\n+\n+    def setUp(self):\n+        storage.staticfiles_storage.hashed_files.clear()  # avoid cache interference\n+        super(TestMultiCachedStorage, self).setUp()\n+\n+    def cached_file_path(self, path):\n+        fullpath = self.render_template(self.static_template_snippet(path))\n+        return fullpath.replace(settings.STATIC_URL, '')\n+\n+    def test_multi_extension_patterns(self):\n+        \"\"\" See #19670 \"\"\"\n+        self.assertEqual(\n+            settings.STATICFILES_STORAGE,\n+            'staticfiles_tests.storage.MultiCachedStaticFilesStorage'\n+        )\n+        self.assertEqual(\n+            storage.staticfiles_storage._wrapped.__class__.__name__,\n+            'MultiCachedStaticFilesStorage'\n+        )\n+\n+        # Confirm CSS files haven't been touched by JS patterns.\n+        relpath = self.cached_file_path(\"cached/import.css\")\n+        self.assertEqual(relpath, \"cached/import.2b1d40b0bbd4.css\")\n+        with storage.staticfiles_storage.open(relpath) as relfile:\n+            self.assertIn(\n+                b\"\"\"import url(\"styles.bb84a0240107.css\")\"\"\",","path":"tests/staticfiles_tests/test_storage.py","position":40,"original_position":40,"commit_id":"680657480ff1bac1437061f5fb87a993bad3fa66","original_commit_id":"680657480ff1bac1437061f5fb87a993bad3fa66","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"Single line seems fine for this assert. Triple quotes -> single quote should ease line length a bit.","created_at":"2016-03-26T00:25:48Z","updated_at":"2016-03-26T00:25:48Z","html_url":"https://github.com/django/django/pull/6215#discussion_r57504959","pull_request_url":"https://api.github.com/repos/django/django/pulls/6215","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/57504959"},"html":{"href":"https://github.com/django/django/pull/6215#discussion_r57504959"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/6215"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/6215","id":60963873,"html_url":"https://github.com/django/django/pull/6215","diff_url":"https://github.com/django/django/pull/6215.diff","patch_url":"https://github.com/django/django/pull/6215.patch","issue_url":"https://api.github.com/repos/django/django/issues/6215","number":6215,"state":"open","locked":false,"title":"Fixed #19670 -- Applied CachedFilesMixin patterns to specific extensions","user":{"login":"claudep","id":143192,"avatar_url":"https://avatars.githubusercontent.com/u/143192?v=3","gravatar_id":"","url":"https://api.github.com/users/claudep","html_url":"https://github.com/claudep","followers_url":"https://api.github.com/users/claudep/followers","following_url":"https://api.github.com/users/claudep/following{/other_user}","gists_url":"https://api.github.com/users/claudep/gists{/gist_id}","starred_url":"https://api.github.com/users/claudep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudep/subscriptions","organizations_url":"https://api.github.com/users/claudep/orgs","repos_url":"https://api.github.com/users/claudep/repos","events_url":"https://api.github.com/users/claudep/events{/privacy}","received_events_url":"https://api.github.com/users/claudep/received_events","type":"User","site_admin":false},"body":"Thanks Simon Meers for the initial patch.","created_at":"2016-02-27T20:33:37Z","updated_at":"2016-03-26T00:25:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17f98a8861099064a43007c1a674878d159ee888","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/6215/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/6215/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/6215/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/680657480ff1bac1437061f5fb87a993bad3fa66","head":{"label":"claudep:19670","ref":"19670","sha":"680657480ff1bac1437061f5fb87a993bad3fa66","user":{"login":"claudep","id":143192,"avatar_url":"https://avatars.githubusercontent.com/u/143192?v=3","gravatar_id":"","url":"https://api.github.com/users/claudep","html_url":"https://github.com/claudep","followers_url":"https://api.github.com/users/claudep/followers","following_url":"https://api.github.com/users/claudep/following{/other_user}","gists_url":"https://api.github.com/users/claudep/gists{/gist_id}","starred_url":"https://api.github.com/users/claudep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudep/subscriptions","organizations_url":"https://api.github.com/users/claudep/orgs","repos_url":"https://api.github.com/users/claudep/repos","events_url":"https://api.github.com/users/claudep/events{/privacy}","received_events_url":"https://api.github.com/users/claudep/received_events","type":"User","site_admin":false},"repo":{"id":4217165,"name":"django","full_name":"claudep/django","owner":{"login":"claudep","id":143192,"avatar_url":"https://avatars.githubusercontent.com/u/143192?v=3","gravatar_id":"","url":"https://api.github.com/users/claudep","html_url":"https://github.com/claudep","followers_url":"https://api.github.com/users/claudep/followers","following_url":"https://api.github.com/users/claudep/following{/other_user}","gists_url":"https://api.github.com/users/claudep/gists{/gist_id}","starred_url":"https://api.github.com/users/claudep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudep/subscriptions","organizations_url":"https://api.github.com/users/claudep/orgs","repos_url":"https://api.github.com/users/claudep/repos","events_url":"https://api.github.com/users/claudep/events{/privacy}","received_events_url":"https://api.github.com/users/claudep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claudep/django","description":"The Web framework for perfectionists with deadlines. Now on GitHub.","fork":true,"url":"https://api.github.com/repos/claudep/django","forks_url":"https://api.github.com/repos/claudep/django/forks","keys_url":"https://api.github.com/repos/claudep/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claudep/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claudep/django/teams","hooks_url":"https://api.github.com/repos/claudep/django/hooks","issue_events_url":"https://api.github.com/repos/claudep/django/issues/events{/number}","events_url":"https://api.github.com/repos/claudep/django/events","assignees_url":"https://api.github.com/repos/claudep/django/assignees{/user}","branches_url":"https://api.github.com/repos/claudep/django/branches{/branch}","tags_url":"https://api.github.com/repos/claudep/django/tags","blobs_url":"https://api.github.com/repos/claudep/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claudep/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claudep/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/claudep/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claudep/django/statuses/{sha}","languages_url":"https://api.github.com/repos/claudep/django/languages","stargazers_url":"https://api.github.com/repos/claudep/django/stargazers","contributors_url":"https://api.github.com/repos/claudep/django/contributors","subscribers_url":"https://api.github.com/repos/claudep/django/subscribers","subscription_url":"https://api.github.com/repos/claudep/django/subscription","commits_url":"https://api.github.com/repos/claudep/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/claudep/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/claudep/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/claudep/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/claudep/django/contents/{+path}","compare_url":"https://api.github.com/repos/claudep/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claudep/django/merges","archive_url":"https://api.github.com/repos/claudep/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claudep/django/downloads","issues_url":"https://api.github.com/repos/claudep/django/issues{/number}","pulls_url":"https://api.github.com/repos/claudep/django/pulls{/number}","milestones_url":"https://api.github.com/repos/claudep/django/milestones{/number}","notifications_url":"https://api.github.com/repos/claudep/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claudep/django/labels{/name}","releases_url":"https://api.github.com/repos/claudep/django/releases{/id}","deployments_url":"https://api.github.com/repos/claudep/django/deployments","created_at":"2012-05-03T18:20:44Z","updated_at":"2015-04-24T14:29:13Z","pushed_at":"2016-03-25T09:33:52Z","git_url":"git://github.com/claudep/django.git","ssh_url":"git@github.com:claudep/django.git","clone_url":"https://github.com/claudep/django.git","svn_url":"https://github.com/claudep/django","homepage":"http://www.djangoproject.com/","size":118673,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"b84f5ab4ec2d1edbe9a7effa9f75a3caa189bace","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-03-26T00:23:35Z","pushed_at":"2016-03-25T23:00:06Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":184573,"stargazers_count":18661,"watchers_count":18661,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7564,"mirror_url":null,"open_issues_count":63,"forks":7564,"open_issues":63,"watchers":18661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/6215"},"html":{"href":"https://github.com/django/django/pull/6215"},"issue":{"href":"https://api.github.com/repos/django/django/issues/6215"},"comments":{"href":"https://api.github.com/repos/django/django/issues/6215/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/6215/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/6215/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/680657480ff1bac1437061f5fb87a993bad3fa66"}}}}