{"action":"closed","number":2132,"pull_request":{"url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132","id":74040736,"html_url":"https://github.com/sharetribe/sharetribe/pull/2132","diff_url":"https://github.com/sharetribe/sharetribe/pull/2132.diff","patch_url":"https://github.com/sharetribe/sharetribe/pull/2132.patch","issue_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/2132","number":2132,"state":"closed","locked":false,"title":"Clp conditional routing","user":{"login":"sktoiva","id":230815,"avatar_url":"https://avatars.githubusercontent.com/u/230815?v=3","gravatar_id":"","url":"https://api.github.com/users/sktoiva","html_url":"https://github.com/sktoiva","followers_url":"https://api.github.com/users/sktoiva/followers","following_url":"https://api.github.com/users/sktoiva/following{/other_user}","gists_url":"https://api.github.com/users/sktoiva/gists{/gist_id}","starred_url":"https://api.github.com/users/sktoiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sktoiva/subscriptions","organizations_url":"https://api.github.com/users/sktoiva/orgs","repos_url":"https://api.github.com/users/sktoiva/repos","events_url":"https://api.github.com/users/sktoiva/events{/privacy}","received_events_url":"https://api.github.com/users/sktoiva/received_events","type":"User","site_admin":false},"body":"Enables conditional routing to landing pages if it's enabled.\r\n\r\nMight still break root redirection for marketplaces that have landing page enabled, but this can be taken to production and `redirect_to root` checked afterwards.\r\n\r\nChanges to functionality:\r\n\r\n  - Route / for marketplaces with CLP to custom landing page\r\n  - Route /s for marketplaces with CLP to homepage#index\r\n  - Route / for marketplaces without CLP to homepage#index\r\n  - Redirect /s for marketplaces without CLP to homepage#index with 307, Temporary\r\n  - Redirect to landing page for private marketplaces with CLP from homepage, if not logged in\r\n  - Check protocol in middleware and perform redirect to https already there\r\n  - Conditionally link to either / or /s from homepage#index views depending on if CLP is enabled\r\n  - Replaces redirect roots with either landing page or search\r\n  - Deprecates root helper\r\n  - Replaces root_paths with search_path\r\n  - Replaces root_urls with search_urls\r\n  - Links to landing page instead of homepage in header icon","created_at":"2016-06-16T08:29:52Z","updated_at":"2016-06-21T13:37:28Z","closed_at":"2016-06-21T13:37:28Z","merged_at":"2016-06-21T13:37:28Z","merge_commit_sha":"88b550935e158bcb6a47d327b36d8789c47b1301","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132/commits","review_comments_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132/comments","review_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/2132/comments","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/34ecc8cdea0c8acb5930ae10b271dfbd81228f5b","head":{"label":"sharetribe:clp-conditional-routing","ref":"clp-conditional-routing","sha":"34ecc8cdea0c8acb5930ae10b271dfbd81228f5b","user":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"repo":{"id":4447023,"name":"sharetribe","full_name":"sharetribe/sharetribe","owner":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sharetribe/sharetribe","description":"Open source marketplace platform","fork":false,"url":"https://api.github.com/repos/sharetribe/sharetribe","forks_url":"https://api.github.com/repos/sharetribe/sharetribe/forks","keys_url":"https://api.github.com/repos/sharetribe/sharetribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharetribe/sharetribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharetribe/sharetribe/teams","hooks_url":"https://api.github.com/repos/sharetribe/sharetribe/hooks","issue_events_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/events{/number}","events_url":"https://api.github.com/repos/sharetribe/sharetribe/events","assignees_url":"https://api.github.com/repos/sharetribe/sharetribe/assignees{/user}","branches_url":"https://api.github.com/repos/sharetribe/sharetribe/branches{/branch}","tags_url":"https://api.github.com/repos/sharetribe/sharetribe/tags","blobs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharetribe/sharetribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharetribe/sharetribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/{sha}","languages_url":"https://api.github.com/repos/sharetribe/sharetribe/languages","stargazers_url":"https://api.github.com/repos/sharetribe/sharetribe/stargazers","contributors_url":"https://api.github.com/repos/sharetribe/sharetribe/contributors","subscribers_url":"https://api.github.com/repos/sharetribe/sharetribe/subscribers","subscription_url":"https://api.github.com/repos/sharetribe/sharetribe/subscription","commits_url":"https://api.github.com/repos/sharetribe/sharetribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharetribe/sharetribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharetribe/sharetribe/contents/{+path}","compare_url":"https://api.github.com/repos/sharetribe/sharetribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharetribe/sharetribe/merges","archive_url":"https://api.github.com/repos/sharetribe/sharetribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharetribe/sharetribe/downloads","issues_url":"https://api.github.com/repos/sharetribe/sharetribe/issues{/number}","pulls_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls{/number}","milestones_url":"https://api.github.com/repos/sharetribe/sharetribe/milestones{/number}","notifications_url":"https://api.github.com/repos/sharetribe/sharetribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharetribe/sharetribe/labels{/name}","releases_url":"https://api.github.com/repos/sharetribe/sharetribe/releases{/id}","deployments_url":"https://api.github.com/repos/sharetribe/sharetribe/deployments","created_at":"2012-05-25T15:34:17Z","updated_at":"2016-06-20T13:54:28Z","pushed_at":"2016-06-21T13:37:28Z","git_url":"git://github.com/sharetribe/sharetribe.git","ssh_url":"git@github.com:sharetribe/sharetribe.git","clone_url":"https://github.com/sharetribe/sharetribe.git","svn_url":"https://github.com/sharetribe/sharetribe","homepage":"https://www.sharetribe.com","size":107506,"stargazers_count":662,"watchers_count":662,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":457,"mirror_url":null,"open_issues_count":16,"forks":457,"open_issues":16,"watchers":662,"default_branch":"master"}},"base":{"label":"sharetribe:master","ref":"master","sha":"2bdb3c1f4037914b94a28b3bab083e86f9ddb46c","user":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"repo":{"id":4447023,"name":"sharetribe","full_name":"sharetribe/sharetribe","owner":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sharetribe/sharetribe","description":"Open source marketplace platform","fork":false,"url":"https://api.github.com/repos/sharetribe/sharetribe","forks_url":"https://api.github.com/repos/sharetribe/sharetribe/forks","keys_url":"https://api.github.com/repos/sharetribe/sharetribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharetribe/sharetribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharetribe/sharetribe/teams","hooks_url":"https://api.github.com/repos/sharetribe/sharetribe/hooks","issue_events_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/events{/number}","events_url":"https://api.github.com/repos/sharetribe/sharetribe/events","assignees_url":"https://api.github.com/repos/sharetribe/sharetribe/assignees{/user}","branches_url":"https://api.github.com/repos/sharetribe/sharetribe/branches{/branch}","tags_url":"https://api.github.com/repos/sharetribe/sharetribe/tags","blobs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharetribe/sharetribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharetribe/sharetribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/{sha}","languages_url":"https://api.github.com/repos/sharetribe/sharetribe/languages","stargazers_url":"https://api.github.com/repos/sharetribe/sharetribe/stargazers","contributors_url":"https://api.github.com/repos/sharetribe/sharetribe/contributors","subscribers_url":"https://api.github.com/repos/sharetribe/sharetribe/subscribers","subscription_url":"https://api.github.com/repos/sharetribe/sharetribe/subscription","commits_url":"https://api.github.com/repos/sharetribe/sharetribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharetribe/sharetribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharetribe/sharetribe/contents/{+path}","compare_url":"https://api.github.com/repos/sharetribe/sharetribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharetribe/sharetribe/merges","archive_url":"https://api.github.com/repos/sharetribe/sharetribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharetribe/sharetribe/downloads","issues_url":"https://api.github.com/repos/sharetribe/sharetribe/issues{/number}","pulls_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls{/number}","milestones_url":"https://api.github.com/repos/sharetribe/sharetribe/milestones{/number}","notifications_url":"https://api.github.com/repos/sharetribe/sharetribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharetribe/sharetribe/labels{/name}","releases_url":"https://api.github.com/repos/sharetribe/sharetribe/releases{/id}","deployments_url":"https://api.github.com/repos/sharetribe/sharetribe/deployments","created_at":"2012-05-25T15:34:17Z","updated_at":"2016-06-20T13:54:28Z","pushed_at":"2016-06-21T13:37:28Z","git_url":"git://github.com/sharetribe/sharetribe.git","ssh_url":"git@github.com:sharetribe/sharetribe.git","clone_url":"https://github.com/sharetribe/sharetribe.git","svn_url":"https://github.com/sharetribe/sharetribe","homepage":"https://www.sharetribe.com","size":107506,"stargazers_count":662,"watchers_count":662,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":457,"mirror_url":null,"open_issues_count":16,"forks":457,"open_issues":16,"watchers":662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132"},"html":{"href":"https://github.com/sharetribe/sharetribe/pull/2132"},"issue":{"href":"https://api.github.com/repos/sharetribe/sharetribe/issues/2132"},"comments":{"href":"https://api.github.com/repos/sharetribe/sharetribe/issues/2132/comments"},"review_comments":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132/comments"},"review_comment":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/2132/commits"},"statuses":{"href":"https://api.github.com/repos/sharetribe/sharetribe/statuses/34ecc8cdea0c8acb5930ae10b271dfbd81228f5b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sktoiva","id":230815,"avatar_url":"https://avatars.githubusercontent.com/u/230815?v=3","gravatar_id":"","url":"https://api.github.com/users/sktoiva","html_url":"https://github.com/sktoiva","followers_url":"https://api.github.com/users/sktoiva/followers","following_url":"https://api.github.com/users/sktoiva/following{/other_user}","gists_url":"https://api.github.com/users/sktoiva/gists{/gist_id}","starred_url":"https://api.github.com/users/sktoiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sktoiva/subscriptions","organizations_url":"https://api.github.com/users/sktoiva/orgs","repos_url":"https://api.github.com/users/sktoiva/repos","events_url":"https://api.github.com/users/sktoiva/events{/privacy}","received_events_url":"https://api.github.com/users/sktoiva/received_events","type":"User","site_admin":false},"comments":0,"review_comments":15,"commits":18,"additions":191,"deletions":89,"changed_files":37}}
{"actor":{"display_login":"sktoiva"}}