{"action":"created","comment":{"url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/comments/67158908","id":67158908,"diff_hunk":"@@ -380,6 +385,16 @@ def _mark_as_lost(self):\n         self.latest_goal_status.status = GoalStatus.LOST\n         self.transition_to(CommState.DONE)\n \n+    ## @brief Is the goal's age beyond the lost-message delta?\n+    ##\n+    ## @param status_timestamp Timestamp from the server status message.\n+    ##\n+    ## @return True if the goal is older than the delta, otherwise False","path":"src/actionlib/action_client.py","position":34,"original_position":34,"commit_id":"4860e9c99bbbbd0a2ecc03a48610759c470064f6","original_commit_id":"4860e9c99bbbbd0a2ecc03a48610759c470064f6","user":{"login":"abencz","id":505545,"avatar_url":"https://avatars.githubusercontent.com/u/505545?v=3","gravatar_id":"","url":"https://api.github.com/users/abencz","html_url":"https://github.com/abencz","followers_url":"https://api.github.com/users/abencz/followers","following_url":"https://api.github.com/users/abencz/following{/other_user}","gists_url":"https://api.github.com/users/abencz/gists{/gist_id}","starred_url":"https://api.github.com/users/abencz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abencz/subscriptions","organizations_url":"https://api.github.com/users/abencz/orgs","repos_url":"https://api.github.com/users/abencz/repos","events_url":"https://api.github.com/users/abencz/events{/privacy}","received_events_url":"https://api.github.com/users/abencz/received_events","type":"User","site_admin":false},"body":"This comment should be a Python docstring. However I would argue that it's completely superfluous, this method's function is simple enough that its name is explanation enough.","created_at":"2016-06-15T13:18:00Z","updated_at":"2016-06-15T13:18:00Z","html_url":"https://github.com/clearpathrobotics/actionlib/pull/1#discussion_r67158908","pull_request_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/comments/67158908"},"html":{"href":"https://github.com/clearpathrobotics/actionlib/pull/1#discussion_r67158908"},"pull_request":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1","id":73843369,"html_url":"https://github.com/clearpathrobotics/actionlib/pull/1","diff_url":"https://github.com/clearpathrobotics/actionlib/pull/1.diff","patch_url":"https://github.com/clearpathrobotics/actionlib/pull/1.patch","issue_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/1","number":1,"state":"open","locked":false,"title":"Mark as LOST goals that are WAITING_FOR_GOAL_ACK and are aged out","user":{"login":"sjfwilson","id":6607865,"avatar_url":"https://avatars.githubusercontent.com/u/6607865?v=3","gravatar_id":"","url":"https://api.github.com/users/sjfwilson","html_url":"https://github.com/sjfwilson","followers_url":"https://api.github.com/users/sjfwilson/followers","following_url":"https://api.github.com/users/sjfwilson/following{/other_user}","gists_url":"https://api.github.com/users/sjfwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/sjfwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjfwilson/subscriptions","organizations_url":"https://api.github.com/users/sjfwilson/orgs","repos_url":"https://api.github.com/users/sjfwilson/repos","events_url":"https://api.github.com/users/sjfwilson/events{/privacy}","received_events_url":"https://api.github.com/users/sjfwilson/received_events","type":"User","site_admin":false},"body":"Added a lost_goal_timestamp_delta parameter to ActionClient.\r\n\r\nThis parameter is used by CommStateMachine for detecting \"old\" or\r\n\"aged out\" goals that are in the WAITING_FOR_GOAL_ACK state. These\r\ngoals will be marked as LOST.\r\n\r\nThis change allows for the ActionClient to handle goals that were\r\nsent to an ActionServer, but never received by the Server. E.g. In\r\nthe event of a network outage.","created_at":"2016-06-15T02:27:02Z","updated_at":"2016-06-15T13:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f6cbf601d9e0c4f038c7ce81ac51865ce87712c","assignee":{"login":"abencz","id":505545,"avatar_url":"https://avatars.githubusercontent.com/u/505545?v=3","gravatar_id":"","url":"https://api.github.com/users/abencz","html_url":"https://github.com/abencz","followers_url":"https://api.github.com/users/abencz/followers","following_url":"https://api.github.com/users/abencz/following{/other_user}","gists_url":"https://api.github.com/users/abencz/gists{/gist_id}","starred_url":"https://api.github.com/users/abencz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abencz/subscriptions","organizations_url":"https://api.github.com/users/abencz/orgs","repos_url":"https://api.github.com/users/abencz/repos","events_url":"https://api.github.com/users/abencz/events{/privacy}","received_events_url":"https://api.github.com/users/abencz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1/commits","review_comments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1/comments","review_comment_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/1/comments","statuses_url":"https://api.github.com/repos/clearpathrobotics/actionlib/statuses/4860e9c99bbbbd0a2ecc03a48610759c470064f6","head":{"label":"clearpathrobotics:lost-goal-recovery","ref":"lost-goal-recovery","sha":"4860e9c99bbbbd0a2ecc03a48610759c470064f6","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":44557042,"name":"actionlib","full_name":"clearpathrobotics/actionlib","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/actionlib","description":"Provides a standardized interface for interfacing with preemptable tasks. Examples of this include moving the base to a target location, performing a laser scan and returning the resulting point cloud, detecting the handle of a door, etc.","fork":true,"url":"https://api.github.com/repos/clearpathrobotics/actionlib","forks_url":"https://api.github.com/repos/clearpathrobotics/actionlib/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/actionlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/actionlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/actionlib/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/actionlib/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/actionlib/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/actionlib/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/actionlib/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/actionlib/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/actionlib/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/actionlib/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/actionlib/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/actionlib/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/actionlib/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/actionlib/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/actionlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/actionlib/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/actionlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/actionlib/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/actionlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/actionlib/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/actionlib/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/actionlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/actionlib/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/actionlib/releases{/id}","deployments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/deployments","created_at":"2015-10-19T19:03:04Z","updated_at":"2015-10-19T19:03:06Z","pushed_at":"2016-06-15T13:01:40Z","git_url":"git://github.com/clearpathrobotics/actionlib.git","ssh_url":"git@github.com:clearpathrobotics/actionlib.git","clone_url":"https://github.com/clearpathrobotics/actionlib.git","svn_url":"https://github.com/clearpathrobotics/actionlib","homepage":"http://www.ros.org/wiki/actionlib","size":1257,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"action-fixup"}},"base":{"label":"clearpathrobotics:indigo-devel","ref":"indigo-devel","sha":"da39083c513066e0d3d05346f3b1be9f9f90268d","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":44557042,"name":"actionlib","full_name":"clearpathrobotics/actionlib","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/actionlib","description":"Provides a standardized interface for interfacing with preemptable tasks. Examples of this include moving the base to a target location, performing a laser scan and returning the resulting point cloud, detecting the handle of a door, etc.","fork":true,"url":"https://api.github.com/repos/clearpathrobotics/actionlib","forks_url":"https://api.github.com/repos/clearpathrobotics/actionlib/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/actionlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/actionlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/actionlib/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/actionlib/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/actionlib/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/actionlib/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/actionlib/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/actionlib/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/actionlib/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/actionlib/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/actionlib/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/actionlib/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/actionlib/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/actionlib/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/actionlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/actionlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/actionlib/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/actionlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/actionlib/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/actionlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/actionlib/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/actionlib/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/actionlib/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/actionlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/actionlib/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/actionlib/releases{/id}","deployments_url":"https://api.github.com/repos/clearpathrobotics/actionlib/deployments","created_at":"2015-10-19T19:03:04Z","updated_at":"2015-10-19T19:03:06Z","pushed_at":"2016-06-15T13:01:40Z","git_url":"git://github.com/clearpathrobotics/actionlib.git","ssh_url":"git@github.com:clearpathrobotics/actionlib.git","clone_url":"https://github.com/clearpathrobotics/actionlib.git","svn_url":"https://github.com/clearpathrobotics/actionlib","homepage":"http://www.ros.org/wiki/actionlib","size":1257,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"action-fixup"}},"_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1"},"html":{"href":"https://github.com/clearpathrobotics/actionlib/pull/1"},"issue":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/1"},"comments":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/clearpathrobotics/actionlib/statuses/4860e9c99bbbbd0a2ecc03a48610759c470064f6"}}}}
{"actor":{"display_login":"abencz"}}