{"action":"opened","number":1420,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/1420","id":75372238,"html_url":"https://github.com/serverless/serverless/pull/1420","diff_url":"https://github.com/serverless/serverless/pull/1420.diff","patch_url":"https://github.com/serverless/serverless/pull/1420.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/1420","number":1420,"state":"open","locked":false,"title":"Bug: function remove does not work for functions without an endpoint","user":{"login":"stevecaldwell77","id":479049,"avatar_url":"https://avatars.githubusercontent.com/u/479049?v=3","gravatar_id":"","url":"https://api.github.com/users/stevecaldwell77","html_url":"https://github.com/stevecaldwell77","followers_url":"https://api.github.com/users/stevecaldwell77/followers","following_url":"https://api.github.com/users/stevecaldwell77/following{/other_user}","gists_url":"https://api.github.com/users/stevecaldwell77/gists{/gist_id}","starred_url":"https://api.github.com/users/stevecaldwell77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevecaldwell77/subscriptions","organizations_url":"https://api.github.com/users/stevecaldwell77/orgs","repos_url":"https://api.github.com/users/stevecaldwell77/repos","events_url":"https://api.github.com/users/stevecaldwell77/events{/privacy}","received_events_url":"https://api.github.com/users/stevecaldwell77/received_events","type":"User","site_admin":false},"body":"Running:\r\n\r\n`\r\nsls function remove -a\r\n`\r\n\r\nwas not doing anything for me, my function was still existing.  In researching it, I found a bug in lib/actions/FunctionRemove.js that aborted function removal if the function did not have any associated endpoints.\r\n\r\nThis PR fixes that bug and makes sure functions without endpoints get removed properly.","created_at":"2016-06-27T20:13:03Z","updated_at":"2016-06-27T20:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45385a0b937511d0ef9427068160bc731b6168f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/1420/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/1420/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/1420/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/4f97afd9ed9242cadcd456df143ce8a288b51968","head":{"label":"stevecaldwell77:function-remove-bug","ref":"function-remove-bug","sha":"4f97afd9ed9242cadcd456df143ce8a288b51968","user":{"login":"stevecaldwell77","id":479049,"avatar_url":"https://avatars.githubusercontent.com/u/479049?v=3","gravatar_id":"","url":"https://api.github.com/users/stevecaldwell77","html_url":"https://github.com/stevecaldwell77","followers_url":"https://api.github.com/users/stevecaldwell77/followers","following_url":"https://api.github.com/users/stevecaldwell77/following{/other_user}","gists_url":"https://api.github.com/users/stevecaldwell77/gists{/gist_id}","starred_url":"https://api.github.com/users/stevecaldwell77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevecaldwell77/subscriptions","organizations_url":"https://api.github.com/users/stevecaldwell77/orgs","repos_url":"https://api.github.com/users/stevecaldwell77/repos","events_url":"https://api.github.com/users/stevecaldwell77/events{/privacy}","received_events_url":"https://api.github.com/users/stevecaldwell77/received_events","type":"User","site_admin":false},"repo":{"id":55010795,"name":"serverless","full_name":"stevecaldwell77/serverless","owner":{"login":"stevecaldwell77","id":479049,"avatar_url":"https://avatars.githubusercontent.com/u/479049?v=3","gravatar_id":"","url":"https://api.github.com/users/stevecaldwell77","html_url":"https://github.com/stevecaldwell77","followers_url":"https://api.github.com/users/stevecaldwell77/followers","following_url":"https://api.github.com/users/stevecaldwell77/following{/other_user}","gists_url":"https://api.github.com/users/stevecaldwell77/gists{/gist_id}","starred_url":"https://api.github.com/users/stevecaldwell77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevecaldwell77/subscriptions","organizations_url":"https://api.github.com/users/stevecaldwell77/orgs","repos_url":"https://api.github.com/users/stevecaldwell77/repos","events_url":"https://api.github.com/users/stevecaldwell77/events{/privacy}","received_events_url":"https://api.github.com/users/stevecaldwell77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevecaldwell77/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures via AWS Lambda and API Gateway (formerly known as JAWS) – ","fork":true,"url":"https://api.github.com/repos/stevecaldwell77/serverless","forks_url":"https://api.github.com/repos/stevecaldwell77/serverless/forks","keys_url":"https://api.github.com/repos/stevecaldwell77/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevecaldwell77/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevecaldwell77/serverless/teams","hooks_url":"https://api.github.com/repos/stevecaldwell77/serverless/hooks","issue_events_url":"https://api.github.com/repos/stevecaldwell77/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/stevecaldwell77/serverless/events","assignees_url":"https://api.github.com/repos/stevecaldwell77/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/stevecaldwell77/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/stevecaldwell77/serverless/tags","blobs_url":"https://api.github.com/repos/stevecaldwell77/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevecaldwell77/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevecaldwell77/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevecaldwell77/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevecaldwell77/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/stevecaldwell77/serverless/languages","stargazers_url":"https://api.github.com/repos/stevecaldwell77/serverless/stargazers","contributors_url":"https://api.github.com/repos/stevecaldwell77/serverless/contributors","subscribers_url":"https://api.github.com/repos/stevecaldwell77/serverless/subscribers","subscription_url":"https://api.github.com/repos/stevecaldwell77/serverless/subscription","commits_url":"https://api.github.com/repos/stevecaldwell77/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevecaldwell77/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevecaldwell77/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevecaldwell77/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevecaldwell77/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/stevecaldwell77/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevecaldwell77/serverless/merges","archive_url":"https://api.github.com/repos/stevecaldwell77/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevecaldwell77/serverless/downloads","issues_url":"https://api.github.com/repos/stevecaldwell77/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/stevecaldwell77/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/stevecaldwell77/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/stevecaldwell77/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevecaldwell77/serverless/labels{/name}","releases_url":"https://api.github.com/repos/stevecaldwell77/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/stevecaldwell77/serverless/deployments","created_at":"2016-03-29T21:10:54Z","updated_at":"2016-03-29T21:10:55Z","pushed_at":"2016-06-27T20:11:35Z","git_url":"git://github.com/stevecaldwell77/serverless.git","ssh_url":"git@github.com:stevecaldwell77/serverless.git","clone_url":"https://github.com/stevecaldwell77/serverless.git","svn_url":"https://github.com/stevecaldwell77/serverless","homepage":"http://www.serverless.com","size":28508,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"b5573893e55cf0e7136a08c358cf8759daca47e6","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2016-06-27T19:44:56Z","pushed_at":"2016-06-27T20:13:03Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":70610,"stargazers_count":9047,"watchers_count":9047,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":560,"mirror_url":null,"open_issues_count":217,"forks":560,"open_issues":217,"watchers":9047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/1420"},"html":{"href":"https://github.com/serverless/serverless/pull/1420"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/1420"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/1420/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/1420/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/1420/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/4f97afd9ed9242cadcd456df143ce8a288b51968"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"stevecaldwell77"}}