{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1526","repository_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1526/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1526/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1526/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1526","id":180785107,"number":1526,"title":"Reimplemented esp_init_data_default.","user":{"login":"jmattsson","id":869607,"avatar_url":"https://avatars.githubusercontent.com/u/869607?v=3","gravatar_id":"","url":"https://api.github.com/users/jmattsson","html_url":"https://github.com/jmattsson","followers_url":"https://api.github.com/users/jmattsson/followers","following_url":"https://api.github.com/users/jmattsson/following{/other_user}","gists_url":"https://api.github.com/users/jmattsson/gists{/gist_id}","starred_url":"https://api.github.com/users/jmattsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmattsson/subscriptions","organizations_url":"https://api.github.com/users/jmattsson/orgs","repos_url":"https://api.github.com/users/jmattsson/repos","events_url":"https://api.github.com/users/jmattsson/events{/privacy}","received_events_url":"https://api.github.com/users/jmattsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-04T01:14:15Z","updated_at":"2016-10-04T13:17:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1526","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1526","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1526.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1526.patch"},"body":"Fixes #1500.\r\n\r\n- [x] This PR is for the `dev` branch rather than for `master`.\r\n- [x] This PR is compliant with the [other contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) as well (if not, please describe why).\r\n- [x] I have thoroughly tested my contribution.\r\n- [ ] The code changes are reflected in the documentation at `docs/en/*`.\r\n\r\n\\<Description of and rational behind this PR\\>\r\nReimplemented esp_init_data_default to work around the pesky \"rf_cal[0] !=0x05\" hang when booting on a chip which doesn't have esp_init_data written to it.\r\n\r\nIt is no longer possible to do the writing of the esp_init_data_default\r\nfrom within nodemcu_init(), as the SDK now hangs long before it gets\r\nthere.  As such, I've had to reimplement this in our user_start_trampoline\r\nand get it all done before the SDK has a chance to look for the init data.\r\nIt's unfortunate that we have to spend IRAM on this, but I see no better\r\nalternative at this point.\r\n\r\nWith this patch, NodeMCU should finally be back to \"it just works\" when flashed onto a fresh(ly erased) ESP, and the previously documented approach should be correct once more.\r\n\r\nI'd really appreciate it if a few more people could try this PR before considering merging - while it's working fine for me, I'm always a bit hesitant messing with the early boot stuff."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/251384803","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1526#issuecomment-251384803","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1526","id":251384803,"user":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T13:17:14Z","updated_at":"2016-10-04T13:17:14Z","body":"I'm currently on the road and can't test but did one of you verify if the \"old firmware\" (0.9.x, 1.4, etc.) -> 1.5.4.1 upgrade runs smoothly? IIRC there were some fundamental init data changes between 1.5.1 and 1.5.4.1."}}
{"actor":{"display_login":"marcelstoer"}}