{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/70350439","id":70350439,"diff_hunk":"@@ -1180,14 +1141,13 @@ fn struct_field_family_to_visibility(family: Family) -> ty::Visibility {\n     }\n }\n \n-pub fn get_struct_field_names(intr: &IdentInterner, cdata: Cmd, id: DefIndex)\n-    -> Vec<ast::Name> {\n+pub fn get_struct_field_names(cdata: Cmd, id: DefIndex) -> Vec<ast::Name> {\n     let item = cdata.lookup_item(id);\n     let mut index = 0;\n     reader::tagged_docs(item, tag_item_field).map(|an_item| {\n-        item_name(intr, an_item)\n+        item_name(an_item)\n     }).chain(reader::tagged_docs(item, tag_item_unnamed_field).map(|_| {\n-        let name = intr.intern(&index.to_string());\n+        let name = token::with_ident_interner(|interner| interner.intern(index.to_string()));","path":"src/librustc_metadata/decoder.rs","position":311,"original_position":311,"commit_id":"060b5c5ef273a6b74ccbd10c1d4a1debfa27d9de","original_commit_id":"060b5c5ef273a6b74ccbd10c1d4a1debfa27d9de","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Is calling `with_ident_interner` even necessary here?","created_at":"2016-07-11T22:40:36Z","updated_at":"2016-07-11T22:40:36Z","html_url":"https://github.com/rust-lang/rust/pull/34772#discussion_r70350439","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/34772","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/70350439"},"html":{"href":"https://github.com/rust-lang/rust/pull/34772#discussion_r70350439"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34772"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/34772","id":77034270,"html_url":"https://github.com/rust-lang/rust/pull/34772","diff_url":"https://github.com/rust-lang/rust/pull/34772.diff","patch_url":"https://github.com/rust-lang/rust/pull/34772.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/34772","number":34772,"state":"open","locked":false,"title":"Start cleaning up the string interner","user":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"body":"r? @eddyb ","created_at":"2016-07-11T22:31:23Z","updated_at":"2016-07-11T22:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4e784eb46bbea92082156fb33eeb66937e18ba5","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/34772/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/34772/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/34772/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/060b5c5ef273a6b74ccbd10c1d4a1debfa27d9de","head":{"label":"jseyfried:cleanup_interner","ref":"cleanup_interner","sha":"060b5c5ef273a6b74ccbd10c1d4a1debfa27d9de","user":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"repo":{"id":45209988,"name":"rust","full_name":"jseyfried/rust","owner":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jseyfried/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/jseyfried/rust","forks_url":"https://api.github.com/repos/jseyfried/rust/forks","keys_url":"https://api.github.com/repos/jseyfried/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jseyfried/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jseyfried/rust/teams","hooks_url":"https://api.github.com/repos/jseyfried/rust/hooks","issue_events_url":"https://api.github.com/repos/jseyfried/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jseyfried/rust/events","assignees_url":"https://api.github.com/repos/jseyfried/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jseyfried/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jseyfried/rust/tags","blobs_url":"https://api.github.com/repos/jseyfried/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jseyfried/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jseyfried/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jseyfried/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jseyfried/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jseyfried/rust/languages","stargazers_url":"https://api.github.com/repos/jseyfried/rust/stargazers","contributors_url":"https://api.github.com/repos/jseyfried/rust/contributors","subscribers_url":"https://api.github.com/repos/jseyfried/rust/subscribers","subscription_url":"https://api.github.com/repos/jseyfried/rust/subscription","commits_url":"https://api.github.com/repos/jseyfried/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jseyfried/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jseyfried/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jseyfried/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jseyfried/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jseyfried/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jseyfried/rust/merges","archive_url":"https://api.github.com/repos/jseyfried/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jseyfried/rust/downloads","issues_url":"https://api.github.com/repos/jseyfried/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jseyfried/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jseyfried/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jseyfried/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jseyfried/rust/labels{/name}","releases_url":"https://api.github.com/repos/jseyfried/rust/releases{/id}","deployments_url":"https://api.github.com/repos/jseyfried/rust/deployments","created_at":"2015-10-29T20:55:18Z","updated_at":"2016-03-27T03:28:50Z","pushed_at":"2016-07-11T22:25:19Z","git_url":"git://github.com/jseyfried/rust.git","ssh_url":"git@github.com:jseyfried/rust.git","clone_url":"https://github.com/jseyfried/rust.git","svn_url":"https://github.com/jseyfried/rust","homepage":"http://www.rust-lang.org","size":296735,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3ab8054ac182fc170099135304a0c1c6760da57a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-07-11T17:52:08Z","pushed_at":"2016-07-11T22:31:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":516397,"stargazers_count":17425,"watchers_count":17425,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3327,"mirror_url":null,"open_issues_count":2587,"forks":3327,"open_issues":2587,"watchers":17425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34772"},"html":{"href":"https://github.com/rust-lang/rust/pull/34772"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34772"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34772/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34772/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34772/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/060b5c5ef273a6b74ccbd10c1d4a1debfa27d9de"}}}}
{"actor":{"display_login":"eddyb"}}