{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/63777405","id":63777405,"diff_hunk":"@@ -804,6 +808,52 @@ public void testHardcodedCatalog() throws Exception {\n                 \"- type: vanilla\");\n     }\n \n+    @Test\n+    public void testItemWithBrooklynParameters() throws Exception {\n+        String id = \"inline_version.app\";\n+        String version = TEST_VERSION;\n+        addCatalogItems(\n+                \"brooklyn.catalog:\",\n+                \"  id: \" + id,\n+                \"  version: \" + TEST_VERSION,\n+                \"  item:\",\n+                \"    brooklyn.parameters:\",\n+                \"    - name: test.myconf\",\n+                \"      type:  string\",\n+                \"      default: myval\",\n+                \"    services:\",\n+                \"    - type: \" + BasicApplication.class.getName(),\n+                \"      brooklyn.config:\",\n+                \"        myconf2: $brooklyn:config(\\\"test.myconf\\\")\",\n+                \"        myconf2.from.root: $brooklyn:root().config(\\\"test.myconf\\\")\",\n+                \"      brooklyn.children:\",\n+                \"      - type: \"+BasicEntity.class.getName(),\n+                \"        brooklyn.config:\",\n+                \"          myconf3: $brooklyn:config(\\\"test.myconf\\\")\",\n+                \"          myconf3.from.root: $brooklyn:root().config(\\\"test.myconf\\\")\");\n+\n+        RegisteredType catalogItem = mgmt().getTypeRegistry().get(id, version);\n+        assertEquals(catalogItem.getVersion(), version);\n+        \n+        String yaml = \"name: simple-app-yaml\\n\" +\n+                \"location: localhost\\n\" +\n+                \"services: \\n\" +\n+                \"  - type: \"+id+\":\"+version;\n+        Entity app = createAndStartApplication(yaml);\n+        Entity child = Iterables.getOnlyElement(app.getChildren());\n+        ConfigKey<?> configKey = app.getEntityType().getConfigKey(\"test.myconf\");\n+        assertNotNull(configKey);\n+        assertEquals(app.config().get(configKey), \"myval\");\n+        assertEquals(app.config().get(ConfigKeys.newStringConfigKey(\"myconf2.from.root\")), \"myval\");\n+        assertEquals(child.config().get(ConfigKeys.newStringConfigKey(\"myconf3.from.root\")), \"myval\");\n+        assertEquals(app.config().get(ConfigKeys.newStringConfigKey(\"myconf2\")), \"myval\");","path":"camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlEntityTest.java","position":65,"original_position":65,"commit_id":"4c5d099d16d5b5dffa2c44bb26f8ab5c181daf32","original_commit_id":"4c5d099d16d5b5dffa2c44bb26f8ab5c181daf32","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"The assertion for `myconf3` is commented out, because it fails. When we address BROOKLYN-267, then we can uncomment that.","created_at":"2016-05-18T20:37:48Z","updated_at":"2016-05-18T20:37:48Z","html_url":"https://github.com/apache/brooklyn-server/pull/139#discussion_r63777405","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/63777405"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/139#discussion_r63777405"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/139","id":70200370,"html_url":"https://github.com/apache/brooklyn-server/pull/139","diff_url":"https://github.com/apache/brooklyn-server/pull/139.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/139.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/139","number":139,"state":"open","locked":false,"title":"BROOKLYN-267: test for brooklyn.parameters inheritance","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-16T14:00:01Z","updated_at":"2016-05-18T20:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcafadabd1ec644dac8ae89ac41d12af749c76b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/139/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/139/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/139/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/4c5d099d16d5b5dffa2c44bb26f8ab5c181daf32","head":{"label":"aledsage:brooklyn-267/test","ref":"brooklyn-267/test","sha":"4c5d099d16d5b5dffa2c44bb26f8ab5c181daf32","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"repo":{"id":50909018,"name":"brooklyn-server","full_name":"aledsage/brooklyn-server","owner":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledsage/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/aledsage/brooklyn-server","forks_url":"https://api.github.com/repos/aledsage/brooklyn-server/forks","keys_url":"https://api.github.com/repos/aledsage/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledsage/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledsage/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/aledsage/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/aledsage/brooklyn-server/events","assignees_url":"https://api.github.com/repos/aledsage/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/aledsage/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledsage/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aledsage/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/aledsage/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/aledsage/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledsage/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledsage/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/aledsage/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledsage/brooklyn-server/merges","archive_url":"https://api.github.com/repos/aledsage/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledsage/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/aledsage/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aledsage/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aledsage/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledsage/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/aledsage/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/aledsage/brooklyn-server/deployments","created_at":"2016-02-02T09:23:44Z","updated_at":"2016-02-02T09:23:52Z","pushed_at":"2016-05-17T16:27:15Z","git_url":"git://github.com/aledsage/brooklyn-server.git","ssh_url":"git@github.com:aledsage/brooklyn-server.git","clone_url":"https://github.com/aledsage/brooklyn-server.git","svn_url":"https://github.com/aledsage/brooklyn-server","homepage":null,"size":29515,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f4a6bb868d76b586ccce39c0a99e5b94c16c141f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-04-20T09:40:31Z","pushed_at":"2016-05-18T14:55:10Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":29582,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":14,"forks":31,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/139"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/139"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/139"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/4c5d099d16d5b5dffa2c44bb26f8ab5c181daf32"}}}}