{"action":"opened","number":54,"pull_request":{"url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54","id":99183689,"html_url":"https://github.com/apollostack/subscriptions-transport-ws/pull/54","diff_url":"https://github.com/apollostack/subscriptions-transport-ws/pull/54.diff","patch_url":"https://github.com/apollostack/subscriptions-transport-ws/pull/54.patch","issue_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/54","number":54,"state":"open","locked":false,"title":"Don't throw in the server on certain unsub messages","user":{"login":"glasser","id":16724,"avatar_url":"https://avatars.githubusercontent.com/u/16724?v=3","gravatar_id":"","url":"https://api.github.com/users/glasser","html_url":"https://github.com/glasser","followers_url":"https://api.github.com/users/glasser/followers","following_url":"https://api.github.com/users/glasser/following{/other_user}","gists_url":"https://api.github.com/users/glasser/gists{/gist_id}","starred_url":"https://api.github.com/users/glasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glasser/subscriptions","organizations_url":"https://api.github.com/users/glasser/orgs","repos_url":"https://api.github.com/users/glasser/repos","events_url":"https://api.github.com/users/glasser/events{/privacy}","received_events_url":"https://api.github.com/users/glasser/received_events","type":"User","site_admin":false},"body":"To use an object as a map with arbitrary keys, you should either use\r\n`Object.create(null)` or the `Map` class.  Otherwise you can run into trouble\r\nwhere keys like `toString` and `constructor` are in your app too.  If the server\r\nreceived such a message, an exception would get thrown within\r\nSubscriptionManager.unsubscribe.\r\n\r\nNoticed while reviewing @Urigo 's PR","created_at":"2016-12-22T23:07:22Z","updated_at":"2016-12-22T23:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54/commits","review_comments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54/comments","review_comment_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/54/comments","statuses_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/statuses/86dcc9bef941bd21db6e4c8ddce5b933407fe370","head":{"label":"apollostack:glasser/safer-unsub","ref":"glasser/safer-unsub","sha":"86dcc9bef941bd21db6e4c8ddce5b933407fe370","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":63733328,"name":"subscriptions-transport-ws","full_name":"apollostack/subscriptions-transport-ws","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/subscriptions-transport-ws","description":":arrows_clockwise: A WebSocket client + server for GraphQL subscriptions","fork":false,"url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws","forks_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/forks","keys_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/teams","hooks_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/hooks","issue_events_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/events","assignees_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/tags","blobs_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/languages","stargazers_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/stargazers","contributors_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/contributors","subscribers_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/subscribers","subscription_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/subscription","commits_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/merges","archive_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/downloads","issues_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/deployments","created_at":"2016-07-19T22:58:49Z","updated_at":"2016-12-22T22:56:31Z","pushed_at":"2016-12-22T23:06:57Z","git_url":"git://github.com/apollostack/subscriptions-transport-ws.git","ssh_url":"git@github.com:apollostack/subscriptions-transport-ws.git","clone_url":"https://github.com/apollostack/subscriptions-transport-ws.git","svn_url":"https://github.com/apollostack/subscriptions-transport-ws","homepage":"https://www.npmjs.com/package/subscriptions-transport-ws","size":107,"stargazers_count":87,"watchers_count":87,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":87,"default_branch":"master"}},"base":{"label":"apollostack:master","ref":"master","sha":"a77c21f7e2a3446c74850bddb1f94d9ccb742230","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":63733328,"name":"subscriptions-transport-ws","full_name":"apollostack/subscriptions-transport-ws","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/subscriptions-transport-ws","description":":arrows_clockwise: A WebSocket client + server for GraphQL subscriptions","fork":false,"url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws","forks_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/forks","keys_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/teams","hooks_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/hooks","issue_events_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/events","assignees_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/tags","blobs_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/languages","stargazers_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/stargazers","contributors_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/contributors","subscribers_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/subscribers","subscription_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/subscription","commits_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/merges","archive_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/downloads","issues_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/deployments","created_at":"2016-07-19T22:58:49Z","updated_at":"2016-12-22T22:56:31Z","pushed_at":"2016-12-22T23:06:57Z","git_url":"git://github.com/apollostack/subscriptions-transport-ws.git","ssh_url":"git@github.com:apollostack/subscriptions-transport-ws.git","clone_url":"https://github.com/apollostack/subscriptions-transport-ws.git","svn_url":"https://github.com/apollostack/subscriptions-transport-ws","homepage":"https://www.npmjs.com/package/subscriptions-transport-ws","size":107,"stargazers_count":87,"watchers_count":87,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54"},"html":{"href":"https://github.com/apollostack/subscriptions-transport-ws/pull/54"},"issue":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/54"},"comments":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/subscriptions-transport-ws/statuses/86dcc9bef941bd21db6e4c8ddce5b933407fe370"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"glasser"}}