{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/6816","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/6816/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6816/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/6816/events","html_url":"https://github.com/nodejs/node/pull/6816","id":155310787,"number":6816,"title":"tty: set the handle to blocking mode","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/process","name":"process","color":"00aaff"},{"url":"https://api.github.com/repos/nodejs/node/labels/tty","name":"tty","color":"8ad857"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":56,"created_at":"2016-05-17T17:00:53Z","updated_at":"2016-07-16T07:07:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6816","html_url":"https://github.com/nodejs/node/pull/6816","diff_url":"https://github.com/nodejs/node/pull/6816.diff","patch_url":"https://github.com/nodejs/node/pull/6816.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements and walk\r\nthrough the checklist. You can 'tick' a box by using the letter \"x\": [x].\r\n\r\nRun the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on\r\nWindows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. If possible, include a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [X] tests and code linting passes\r\n- [ ] a test and/or benchmark is included\r\n- [ ] documentation is changed or added\r\n- [X] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\ntty, process\r\n\r\n##### Description of change\r\n<!-- provide a description of the change below this comment -->\r\n\r\nSee discussion at:\r\n- https://github.com/nodejs/node/pull/177#issuecomment-119351671\r\n- https://github.com/nodejs/node/issues/6456#issuecomment-219620603\r\n- https://github.com/nodejs/node/pull/6773\r\n\r\ncc @nodejs/ctc @isaacs @ksc @saghul etc\r\n\r\nNote: we still have more investigation to do but this is looking like it is probably the correct thing to do."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/233115753","html_url":"https://github.com/nodejs/node/pull/6816#issuecomment-233115753","issue_url":"https://api.github.com/repos/nodejs/node/issues/6816","id":233115753,"user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"created_at":"2016-07-16T07:07:17Z","updated_at":"2016-07-16T07:07:17Z","body":"@kzc A note to remember: when stdio was made blocking on macOS that was meant to restore the behavior aas in v4.x On other Unix systems it never blocked. We are changing that now. Is it a good or a bad thing? I no longer know."}}
{"actor":{"display_login":"saghul"}}