{"action":"created","issue":{"url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/72","repository_url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js","labels_url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/72/comments","events_url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/72/events","html_url":"https://github.com/spring-guides/tut-spring-security-and-angular-js/pull/72","id":134934367,"number":72,"title":"Navigate to home page when authenticated user clicks login","user":{"login":"duongvu89","id":9512917,"avatar_url":"https://avatars.githubusercontent.com/u/9512917?v=3","gravatar_id":"","url":"https://api.github.com/users/duongvu89","html_url":"https://github.com/duongvu89","followers_url":"https://api.github.com/users/duongvu89/followers","following_url":"https://api.github.com/users/duongvu89/following{/other_user}","gists_url":"https://api.github.com/users/duongvu89/gists{/gist_id}","starred_url":"https://api.github.com/users/duongvu89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duongvu89/subscriptions","organizations_url":"https://api.github.com/users/duongvu89/orgs","repos_url":"https://api.github.com/users/duongvu89/repos","events_url":"https://api.github.com/users/duongvu89/events{/privacy}","received_events_url":"https://api.github.com/users/duongvu89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-19T18:07:59Z","updated_at":"2016-02-19T18:44:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/pulls/72","html_url":"https://github.com/spring-guides/tut-spring-security-and-angular-js/pull/72","diff_url":"https://github.com/spring-guides/tut-spring-security-and-angular-js/pull/72.diff","patch_url":"https://github.com/spring-guides/tut-spring-security-and-angular-js/pull/72.patch"},"body":"May I add a minor fix for enter() function(added code is in bold):\r\nenter = function() {\r\n\t\t\t\tif ($location.path() != auth.loginPath) {\r\n\t\t\t\t\tauth.path = $location.path();\r\n\t\t\t\t\tif (!auth.authenticated) {\r\n\t\t\t\t\t\t$location.path(auth.loginPath);\r\n\t\t\t\t\t_**} else {\r\n\t\t\t\t\tif (auth.authenticated) {\r\n\t\t\t\t\t\t$location.path(auth.homePath);\r\n\t\t\t\t\t}\r\n\t\t\t\t}**_\r\n\t\t\t}\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/comments/186356577","html_url":"https://github.com/spring-guides/tut-spring-security-and-angular-js/pull/72#issuecomment-186356577","issue_url":"https://api.github.com/repos/spring-guides/tut-spring-security-and-angular-js/issues/72","id":186356577,"user":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T18:44:47Z","updated_at":"2016-02-19T18:44:47Z","body":"Thanks for the suggestion. I'm not sure why the change is necessary, though, and it might break something (the \"return to current path\" after login feature provided by spring security). Can you elaborate a bit?\r\n\r\nThe conflicts are your responsibility as the author of the pull request. It's probably best to start again if it's a really small change. In any case rebase your local branch to master in this repo before you update the pr."}}