{"action":"opened","number":9420,"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9420","id":84116893,"html_url":"https://github.com/cakephp/cakephp/pull/9420","diff_url":"https://github.com/cakephp/cakephp/pull/9420.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9420.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9420","number":9420,"state":"open","locked":false,"title":"3.x - Strip aliases from update query conditions where possible.","user":{"login":"ndm2","id":5031606,"avatar_url":"https://avatars.githubusercontent.com/u/5031606?v=3","gravatar_id":"","url":"https://api.github.com/users/ndm2","html_url":"https://github.com/ndm2","followers_url":"https://api.github.com/users/ndm2/followers","following_url":"https://api.github.com/users/ndm2/following{/other_user}","gists_url":"https://api.github.com/users/ndm2/gists{/gist_id}","starred_url":"https://api.github.com/users/ndm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndm2/subscriptions","organizations_url":"https://api.github.com/users/ndm2/orgs","repos_url":"https://api.github.com/users/ndm2/repos","events_url":"https://api.github.com/users/ndm2/events{/privacy}","received_events_url":"https://api.github.com/users/ndm2/received_events","type":"User","site_admin":false},"body":"Unlike for delete queries, possible aliases in the conditions of update queries are not being removed, which will fail for some database dialects. Given that update queries currently do not support joins, just like delete queries, removing the aliases here in the same way should be good enough for now I think.\r\n\r\nThe fact that expressions are being left untouched is something that maybe should go in the docs somewhere, it's something that affects all dependent, non-cascading associated deletes as well, which developers should generally be aware of.\r\n\r\nrefs #9404","created_at":"2016-09-06T12:55:57Z","updated_at":"2016-09-06T12:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9420/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9420/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9420/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/7ea595f3485c220d5e9a25f9614876b012a7e5e6","head":{"label":"ndm2:fix-strip-update-condition-aliases","ref":"fix-strip-update-condition-aliases","sha":"7ea595f3485c220d5e9a25f9614876b012a7e5e6","user":{"login":"ndm2","id":5031606,"avatar_url":"https://avatars.githubusercontent.com/u/5031606?v=3","gravatar_id":"","url":"https://api.github.com/users/ndm2","html_url":"https://github.com/ndm2","followers_url":"https://api.github.com/users/ndm2/followers","following_url":"https://api.github.com/users/ndm2/following{/other_user}","gists_url":"https://api.github.com/users/ndm2/gists{/gist_id}","starred_url":"https://api.github.com/users/ndm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndm2/subscriptions","organizations_url":"https://api.github.com/users/ndm2/orgs","repos_url":"https://api.github.com/users/ndm2/repos","events_url":"https://api.github.com/users/ndm2/events{/privacy}","received_events_url":"https://api.github.com/users/ndm2/received_events","type":"User","site_admin":false},"repo":{"id":17031477,"name":"cakephp","full_name":"ndm2/cakephp","owner":{"login":"ndm2","id":5031606,"avatar_url":"https://avatars.githubusercontent.com/u/5031606?v=3","gravatar_id":"","url":"https://api.github.com/users/ndm2","html_url":"https://github.com/ndm2","followers_url":"https://api.github.com/users/ndm2/followers","following_url":"https://api.github.com/users/ndm2/following{/other_user}","gists_url":"https://api.github.com/users/ndm2/gists{/gist_id}","starred_url":"https://api.github.com/users/ndm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndm2/subscriptions","organizations_url":"https://api.github.com/users/ndm2/orgs","repos_url":"https://api.github.com/users/ndm2/repos","events_url":"https://api.github.com/users/ndm2/events{/privacy}","received_events_url":"https://api.github.com/users/ndm2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndm2/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/ndm2/cakephp","forks_url":"https://api.github.com/repos/ndm2/cakephp/forks","keys_url":"https://api.github.com/repos/ndm2/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndm2/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndm2/cakephp/teams","hooks_url":"https://api.github.com/repos/ndm2/cakephp/hooks","issue_events_url":"https://api.github.com/repos/ndm2/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/ndm2/cakephp/events","assignees_url":"https://api.github.com/repos/ndm2/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/ndm2/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/ndm2/cakephp/tags","blobs_url":"https://api.github.com/repos/ndm2/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndm2/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndm2/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndm2/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndm2/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/ndm2/cakephp/languages","stargazers_url":"https://api.github.com/repos/ndm2/cakephp/stargazers","contributors_url":"https://api.github.com/repos/ndm2/cakephp/contributors","subscribers_url":"https://api.github.com/repos/ndm2/cakephp/subscribers","subscription_url":"https://api.github.com/repos/ndm2/cakephp/subscription","commits_url":"https://api.github.com/repos/ndm2/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndm2/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndm2/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndm2/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndm2/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/ndm2/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndm2/cakephp/merges","archive_url":"https://api.github.com/repos/ndm2/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndm2/cakephp/downloads","issues_url":"https://api.github.com/repos/ndm2/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/ndm2/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/ndm2/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/ndm2/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndm2/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/ndm2/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/ndm2/cakephp/deployments","created_at":"2014-02-20T18:50:36Z","updated_at":"2016-02-13T20:24:28Z","pushed_at":"2016-09-06T12:53:33Z","git_url":"git://github.com/ndm2/cakephp.git","ssh_url":"git@github.com:ndm2/cakephp.git","clone_url":"https://github.com/ndm2/cakephp.git","svn_url":"https://github.com/ndm2/cakephp","homepage":"http://cakephp.org","size":65148,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"d8ff0b7d64a82df96dd5c837533218f93db33b09","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-09-06T06:50:44Z","pushed_at":"2016-09-06T11:21:25Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":130736,"stargazers_count":6692,"watchers_count":6692,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3039,"mirror_url":null,"open_issues_count":206,"forks":3039,"open_issues":206,"watchers":6692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9420"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9420"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9420"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9420/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9420/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9420/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/7ea595f3485c220d5e9a25f9614876b012a7e5e6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":62,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"ndm2"}}