{"action":"created","comment":{"url":"https://api.github.com/repos/python/mypy/pulls/comments/69440596","id":69440596,"diff_hunk":"@@ -330,6 +350,9 @@ def copy_ref(self, new: RefExpr, original: RefExpr) -> None:\n         target = original.node\n         if isinstance(target, Var):\n             target = self.visit_var(target)\n+        elif isinstance(target, FuncDef):\n+            if target in self.func_map:","path":"mypy/treetransform.py","position":64,"original_position":64,"commit_id":"bdd518141d15f665c6321d17b6fa205e90cc6e10","original_commit_id":"bdd518141d15f665c6321d17b6fa205e90cc6e10","user":{"login":"JukkaL","id":1107911,"avatar_url":"https://avatars.githubusercontent.com/u/1107911?v=3","gravatar_id":"","url":"https://api.github.com/users/JukkaL","html_url":"https://github.com/JukkaL","followers_url":"https://api.github.com/users/JukkaL/followers","following_url":"https://api.github.com/users/JukkaL/following{/other_user}","gists_url":"https://api.github.com/users/JukkaL/gists{/gist_id}","starred_url":"https://api.github.com/users/JukkaL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JukkaL/subscriptions","organizations_url":"https://api.github.com/users/JukkaL/orgs","repos_url":"https://api.github.com/users/JukkaL/repos","events_url":"https://api.github.com/users/JukkaL/events{/privacy}","received_events_url":"https://api.github.com/users/JukkaL/received_events","type":"User","site_admin":false},"body":"Could use `self.func_map.get(target, target)` here for a minor simplification.","created_at":"2016-07-04T10:48:04Z","updated_at":"2016-07-04T10:48:04Z","html_url":"https://github.com/python/mypy/pull/1791#discussion_r69440596","pull_request_url":"https://api.github.com/repos/python/mypy/pulls/1791","_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/comments/69440596"},"html":{"href":"https://github.com/python/mypy/pull/1791#discussion_r69440596"},"pull_request":{"href":"https://api.github.com/repos/python/mypy/pulls/1791"}}},"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/1791","id":76046340,"html_url":"https://github.com/python/mypy/pull/1791","diff_url":"https://github.com/python/mypy/pull/1791.diff","patch_url":"https://github.com/python/mypy/pull/1791.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/1791","number":1791,"state":"open","locked":false,"title":"Rewrite references to inner functions in treetransform","user":{"login":"rwbarton","id":22628,"avatar_url":"https://avatars.githubusercontent.com/u/22628?v=3","gravatar_id":"","url":"https://api.github.com/users/rwbarton","html_url":"https://github.com/rwbarton","followers_url":"https://api.github.com/users/rwbarton/followers","following_url":"https://api.github.com/users/rwbarton/following{/other_user}","gists_url":"https://api.github.com/users/rwbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/rwbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwbarton/subscriptions","organizations_url":"https://api.github.com/users/rwbarton/orgs","repos_url":"https://api.github.com/users/rwbarton/repos","events_url":"https://api.github.com/users/rwbarton/events{/privacy}","received_events_url":"https://api.github.com/users/rwbarton/received_events","type":"User","site_admin":false},"body":"Fixes #1323.","created_at":"2016-07-01T23:00:20Z","updated_at":"2016-07-04T10:48:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d6d6ecff1678aa7a66b309631b8af99fa136919","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/1791/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/1791/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/1791/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/bdd518141d15f665c6321d17b6fa205e90cc6e10","head":{"label":"rwbarton:rwbarton-expand-inner","ref":"rwbarton-expand-inner","sha":"bdd518141d15f665c6321d17b6fa205e90cc6e10","user":{"login":"rwbarton","id":22628,"avatar_url":"https://avatars.githubusercontent.com/u/22628?v=3","gravatar_id":"","url":"https://api.github.com/users/rwbarton","html_url":"https://github.com/rwbarton","followers_url":"https://api.github.com/users/rwbarton/followers","following_url":"https://api.github.com/users/rwbarton/following{/other_user}","gists_url":"https://api.github.com/users/rwbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/rwbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwbarton/subscriptions","organizations_url":"https://api.github.com/users/rwbarton/orgs","repos_url":"https://api.github.com/users/rwbarton/repos","events_url":"https://api.github.com/users/rwbarton/events{/privacy}","received_events_url":"https://api.github.com/users/rwbarton/received_events","type":"User","site_admin":false},"repo":{"id":55577784,"name":"mypy","full_name":"rwbarton/mypy","owner":{"login":"rwbarton","id":22628,"avatar_url":"https://avatars.githubusercontent.com/u/22628?v=3","gravatar_id":"","url":"https://api.github.com/users/rwbarton","html_url":"https://github.com/rwbarton","followers_url":"https://api.github.com/users/rwbarton/followers","following_url":"https://api.github.com/users/rwbarton/following{/other_user}","gists_url":"https://api.github.com/users/rwbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/rwbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwbarton/subscriptions","organizations_url":"https://api.github.com/users/rwbarton/orgs","repos_url":"https://api.github.com/users/rwbarton/repos","events_url":"https://api.github.com/users/rwbarton/events{/privacy}","received_events_url":"https://api.github.com/users/rwbarton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwbarton/mypy","description":"Optional static typing for Python","fork":true,"url":"https://api.github.com/repos/rwbarton/mypy","forks_url":"https://api.github.com/repos/rwbarton/mypy/forks","keys_url":"https://api.github.com/repos/rwbarton/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwbarton/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwbarton/mypy/teams","hooks_url":"https://api.github.com/repos/rwbarton/mypy/hooks","issue_events_url":"https://api.github.com/repos/rwbarton/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/rwbarton/mypy/events","assignees_url":"https://api.github.com/repos/rwbarton/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/rwbarton/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/rwbarton/mypy/tags","blobs_url":"https://api.github.com/repos/rwbarton/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwbarton/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwbarton/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwbarton/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwbarton/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/rwbarton/mypy/languages","stargazers_url":"https://api.github.com/repos/rwbarton/mypy/stargazers","contributors_url":"https://api.github.com/repos/rwbarton/mypy/contributors","subscribers_url":"https://api.github.com/repos/rwbarton/mypy/subscribers","subscription_url":"https://api.github.com/repos/rwbarton/mypy/subscription","commits_url":"https://api.github.com/repos/rwbarton/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwbarton/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwbarton/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwbarton/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwbarton/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/rwbarton/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwbarton/mypy/merges","archive_url":"https://api.github.com/repos/rwbarton/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwbarton/mypy/downloads","issues_url":"https://api.github.com/repos/rwbarton/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/rwbarton/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/rwbarton/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/rwbarton/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwbarton/mypy/labels{/name}","releases_url":"https://api.github.com/repos/rwbarton/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/rwbarton/mypy/deployments","created_at":"2016-04-06T05:18:54Z","updated_at":"2016-04-06T05:18:56Z","pushed_at":"2016-07-01T23:00:11Z","git_url":"git://github.com/rwbarton/mypy.git","ssh_url":"git@github.com:rwbarton/mypy.git","clone_url":"https://github.com/rwbarton/mypy.git","svn_url":"https://github.com/rwbarton/mypy","homepage":"http://www.mypy-lang.org/","size":13916,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"daa0b672a119ee98cc8127039a254dfdbec83c4f","user":{"login":"python","id":1525981,"avatar_url":"https://avatars.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"name":"mypy","full_name":"python/mypy","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2016-07-04T05:31:48Z","pushed_at":"2016-07-04T04:05:50Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":16015,"stargazers_count":1552,"watchers_count":1552,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":424,"forks":186,"open_issues":424,"watchers":1552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/1791"},"html":{"href":"https://github.com/python/mypy/pull/1791"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/1791"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/1791/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/1791/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/1791/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/bdd518141d15f665c6321d17b6fa205e90cc6e10"}}}}
{"actor":{"display_login":"JukkaL"}}