{"action":"created","issue":{"url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/4","repository_url":"https://api.github.com/repos/xwp/wp-customize-concurrency","labels_url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/4/comments","events_url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/4/events","html_url":"https://github.com/xwp/wp-customize-concurrency/pull/4","id":167967361,"number":4,"title":"WIP feature/reboot","user":{"login":"lgedeon","id":370981,"avatar_url":"https://avatars.githubusercontent.com/u/370981?v=3","gravatar_id":"","url":"https://api.github.com/users/lgedeon","html_url":"https://github.com/lgedeon","followers_url":"https://api.github.com/users/lgedeon/followers","following_url":"https://api.github.com/users/lgedeon/following{/other_user}","gists_url":"https://api.github.com/users/lgedeon/gists{/gist_id}","starred_url":"https://api.github.com/users/lgedeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgedeon/subscriptions","organizations_url":"https://api.github.com/users/lgedeon/orgs","repos_url":"https://api.github.com/users/lgedeon/repos","events_url":"https://api.github.com/users/lgedeon/events{/privacy}","received_events_url":"https://api.github.com/users/lgedeon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"valendesigns","id":62798,"avatar_url":"https://avatars.githubusercontent.com/u/62798?v=3","gravatar_id":"","url":"https://api.github.com/users/valendesigns","html_url":"https://github.com/valendesigns","followers_url":"https://api.github.com/users/valendesigns/followers","following_url":"https://api.github.com/users/valendesigns/following{/other_user}","gists_url":"https://api.github.com/users/valendesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/valendesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valendesigns/subscriptions","organizations_url":"https://api.github.com/users/valendesigns/orgs","repos_url":"https://api.github.com/users/valendesigns/repos","events_url":"https://api.github.com/users/valendesigns/events{/privacy}","received_events_url":"https://api.github.com/users/valendesigns/received_events","type":"User","site_admin":false},"assignees":[{"login":"valendesigns","id":62798,"avatar_url":"https://avatars.githubusercontent.com/u/62798?v=3","gravatar_id":"","url":"https://api.github.com/users/valendesigns","html_url":"https://github.com/valendesigns","followers_url":"https://api.github.com/users/valendesigns/followers","following_url":"https://api.github.com/users/valendesigns/following{/other_user}","gists_url":"https://api.github.com/users/valendesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/valendesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valendesigns/subscriptions","organizations_url":"https://api.github.com/users/valendesigns/orgs","repos_url":"https://api.github.com/users/valendesigns/repos","events_url":"https://api.github.com/users/valendesigns/events{/privacy}","received_events_url":"https://api.github.com/users/valendesigns/received_events","type":"User","site_admin":false},{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},{"login":"lgedeon","id":370981,"avatar_url":"https://avatars.githubusercontent.com/u/370981?v=3","gravatar_id":"","url":"https://api.github.com/users/lgedeon","html_url":"https://github.com/lgedeon","followers_url":"https://api.github.com/users/lgedeon/followers","following_url":"https://api.github.com/users/lgedeon/following{/other_user}","gists_url":"https://api.github.com/users/lgedeon/gists{/gist_id}","starred_url":"https://api.github.com/users/lgedeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgedeon/subscriptions","organizations_url":"https://api.github.com/users/lgedeon/orgs","repos_url":"https://api.github.com/users/lgedeon/repos","events_url":"https://api.github.com/users/lgedeon/events{/privacy}","received_events_url":"https://api.github.com/users/lgedeon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2016-07-27T22:02:01Z","updated_at":"2016-08-29T19:38:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xwp/wp-customize-concurrency/pulls/4","html_url":"https://github.com/xwp/wp-customize-concurrency/pull/4","diff_url":"https://github.com/xwp/wp-customize-concurrency/pull/4.diff","patch_url":"https://github.com/xwp/wp-customize-concurrency/pull/4.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/comments/243231326","html_url":"https://github.com/xwp/wp-customize-concurrency/pull/4#issuecomment-243231326","issue_url":"https://api.github.com/repos/xwp/wp-customize-concurrency/issues/4","id":243231326,"user":{"login":"lgedeon","id":370981,"avatar_url":"https://avatars.githubusercontent.com/u/370981?v=3","gravatar_id":"","url":"https://api.github.com/users/lgedeon","html_url":"https://github.com/lgedeon","followers_url":"https://api.github.com/users/lgedeon/followers","following_url":"https://api.github.com/users/lgedeon/following{/other_user}","gists_url":"https://api.github.com/users/lgedeon/gists{/gist_id}","starred_url":"https://api.github.com/users/lgedeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgedeon/subscriptions","organizations_url":"https://api.github.com/users/lgedeon/orgs","repos_url":"https://api.github.com/users/lgedeon/repos","events_url":"https://api.github.com/users/lgedeon/events{/privacy}","received_events_url":"https://api.github.com/users/lgedeon/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T19:38:00Z","updated_at":"2016-08-29T19:38:00Z","body":"@westonruter This detects conflicts when:\r\n\r\n- a) Save/Update is clicked while editing the same snapshot after they have saved.\r\n- b) Publish is clicked when someone else has published changes.\r\n- c) Changes are made but not yet published as long as you are not editing a snapshot.\r\n\r\nIt does not detect conflicts when:\r\n\r\n- d) Changes are made to a snapshot (until saved)\r\n\r\nI am not sure that scenario c) was part of the original plan, but it is there and I think it is kind of handy. However, should I then make d) work?\r\n\r\nThen... if we do that, does it make sense to send partial changes to our concurrency conflict storage and let other editors know an unsaved change has been made to a field? Currently you don't know they have made a change until they have saved or published, which could be an hour later with settings now available to change (not smart to wait that long but when has that ever stopped anyone :) ).\r\n\r\nThis notification could be a full conflict error message like we have been sending or since the edit is not yet \"committed\", we could just add a warning (yellow not red) that someone else is also editing that field.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"lgedeon"}}