{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/63316958","id":63316958,"diff_hunk":"@@ -12,20 +12,19 @@ Now we can safely require one of those modules.\n Unfortunately we can't do all of this using the curl API, so we use a\n combination of ajax/eval/curl instead.\n \n-Bundles we need to run: commercial + (enhanced-vendor + enhanced)*\n-* Only if we detect we should run enhance\n+Bundles we need to run: commercial + enhanced\n+\n+Only if we detect we should run enhance.\n  */\n \n define([\n     'Promise',","path":"static/src/javascripts/boot.js","position":12,"original_position":12,"commit_id":"fe6e24c21d090c8043d44af8ccbf3828e8a8b989","original_commit_id":"fe6e24c21d090c8043d44af8ccbf3828e8a8b989","user":{"login":"sndrs","id":867233,"avatar_url":"https://avatars.githubusercontent.com/u/867233?v=3","gravatar_id":"","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false},"body":"do these methods all really need to be wrapped in promises? there's not much going on now, feel a bit like overkill?","created_at":"2016-05-16T07:14:04Z","updated_at":"2016-05-16T07:14:04Z","html_url":"https://github.com/guardian/frontend/pull/12910#discussion_r63316958","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/12910","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/63316958"},"html":{"href":"https://github.com/guardian/frontend/pull/12910#discussion_r63316958"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12910"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/12910","id":70026615,"html_url":"https://github.com/guardian/frontend/pull/12910","diff_url":"https://github.com/guardian/frontend/pull/12910.diff","patch_url":"https://github.com/guardian/frontend/pull/12910.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/12910","number":12910,"state":"open","locked":false,"title":"Fix for dev js booting","user":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?v=3","gravatar_id":"","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"body":"There are some intermittent issues with the dev js loading. This was caused by using the prefetch system in dev, which was supposed to align prod and dev behaviour. The best fix is to remove the prefetch system, because it was pre-emptively downloading some bootstraps in the order of a few milliseconds (9ms when I measured). To balance out any performance risk, the \"optimised\" `enhanced-vendor` js has been removed, which was a separate 2KB download.\r\n\r\nI kept the user timing marking to the standard app, it's still useful.\r\n\r\n@jamesgorrie ","created_at":"2016-05-13T16:55:02Z","updated_at":"2016-05-16T07:14:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"526ac8d53b62a8961a62069d0b7a210c175c7472","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/12910/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/12910/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/12910/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/fe6e24c21d090c8043d44af8ccbf3828e8a8b989","head":{"label":"guardian:simplify-boot","ref":"simplify-boot","sha":"fe6e24c21d090c8043d44af8ccbf3828e8a8b989","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-15T20:46:54Z","pushed_at":"2016-05-13T17:42:01Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":472823,"stargazers_count":3199,"watchers_count":3199,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":43,"forks":334,"open_issues":43,"watchers":3199,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"e93f94a0190d3a15ba9f61814beaf878d2a817a8","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-15T20:46:54Z","pushed_at":"2016-05-13T17:42:01Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":472823,"stargazers_count":3199,"watchers_count":3199,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":43,"forks":334,"open_issues":43,"watchers":3199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12910"},"html":{"href":"https://github.com/guardian/frontend/pull/12910"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/12910"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/12910/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12910/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12910/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/fe6e24c21d090c8043d44af8ccbf3828e8a8b989"}}}}