{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60634739","id":60634739,"diff_hunk":"@@ -35,112 +35,3 @@ QUnit.test('class renders before didInsertElement', function() {\n   equal(view.element.firstChild.className, 'blue', 'attribute is output');\n   equal(matchingElement.length, 1, 'element is in the DOM when didInsertElement');\n });\n-\n-QUnit.test('class property can contain multiple classes', function() {\n-  view = EmberView.create({\n-    context: { classes: 'large blue' },\n-    template: compile('<div class={{classes}}></div>')\n-  });\n-  appendView(view);\n-\n-  equalInnerHTML(view.element, '<div class=\"large blue\"></div>',\n-                 'attribute is output');\n-  ok(view.$('.large')[0], 'first class found');\n-  ok(view.$('.blue')[0], 'second class found');\n-});\n-\n-QUnit.test('class property is removed when updated with a null value', function() {\n-  view = EmberView.create({\n-    context: { class: 'large' },\n-    template: compile('<div class={{class}}></div>')\n-  });\n-  appendView(view);\n-\n-  equal(view.element.firstChild.className, 'large', 'attribute is output');\n-\n-  run(view, view.set, 'context.class', null);\n-\n-  equal(view.element.firstChild.className, '', 'attribute is removed');\n-});\n-\n-QUnit.test('class attribute concats bound values', function() {","path":"packages/ember-htmlbars/tests/attr_nodes/class_test.js","position":66,"original_position":32,"commit_id":"e12cc37914563cd001e9a5931d6a4623fd2cc670","original_commit_id":"021ece60a1f724d4d2dfc6c2810c086044fdf1ae","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"✔️ ","created_at":"2016-04-21T18:46:24Z","updated_at":"2016-04-21T18:46:24Z","html_url":"https://github.com/emberjs/ember.js/pull/13372#discussion_r60634739","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13372","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60634739"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13372#discussion_r60634739"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13372"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13372","id":67034072,"html_url":"https://github.com/emberjs/ember.js/pull/13372","diff_url":"https://github.com/emberjs/ember.js/pull/13372.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13372.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13372","number":13372,"state":"open","locked":false,"title":"[Glimmer 2] Differentiate between bound `class` and `classNames`","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"This fixes a behavior where a bound `class` can mutate, where as bound `classNames` are const'd post creation. Also migrating some of the attr_node tests that were testing `class` behavior.","created_at":"2016-04-19T15:00:14Z","updated_at":"2016-04-21T18:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e4158acd1925c3f462508e5eacb079a3d450902","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13372/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13372/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13372/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/e12cc37914563cd001e9a5931d6a4623fd2cc670","head":{"label":"chadhietala:failing-sexpr-if","ref":"failing-sexpr-if","sha":"e12cc37914563cd001e9a5931d6a4623fd2cc670","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"repo":{"id":22746792,"name":"ember.js","full_name":"chadhietala/ember.js","owner":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadhietala/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/chadhietala/ember.js","forks_url":"https://api.github.com/repos/chadhietala/ember.js/forks","keys_url":"https://api.github.com/repos/chadhietala/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadhietala/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadhietala/ember.js/teams","hooks_url":"https://api.github.com/repos/chadhietala/ember.js/hooks","issue_events_url":"https://api.github.com/repos/chadhietala/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/chadhietala/ember.js/events","assignees_url":"https://api.github.com/repos/chadhietala/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/chadhietala/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/chadhietala/ember.js/tags","blobs_url":"https://api.github.com/repos/chadhietala/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadhietala/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadhietala/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadhietala/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadhietala/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chadhietala/ember.js/languages","stargazers_url":"https://api.github.com/repos/chadhietala/ember.js/stargazers","contributors_url":"https://api.github.com/repos/chadhietala/ember.js/contributors","subscribers_url":"https://api.github.com/repos/chadhietala/ember.js/subscribers","subscription_url":"https://api.github.com/repos/chadhietala/ember.js/subscription","commits_url":"https://api.github.com/repos/chadhietala/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadhietala/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadhietala/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadhietala/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadhietala/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/chadhietala/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadhietala/ember.js/merges","archive_url":"https://api.github.com/repos/chadhietala/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadhietala/ember.js/downloads","issues_url":"https://api.github.com/repos/chadhietala/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/chadhietala/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chadhietala/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chadhietala/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadhietala/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/chadhietala/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/chadhietala/ember.js/deployments","created_at":"2014-08-08T05:15:30Z","updated_at":"2014-12-11T18:19:26Z","pushed_at":"2016-04-21T18:23:29Z","git_url":"git://github.com/chadhietala/ember.js.git","ssh_url":"git@github.com:chadhietala/ember.js.git","clone_url":"https://github.com/chadhietala/ember.js.git","svn_url":"https://github.com/chadhietala/ember.js","homepage":"http://www.emberjs.com","size":31329,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"6739196db628b26b403d66c4271715ec14747dfe","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-04-21T18:08:19Z","pushed_at":"2016-04-21T18:23:30Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":67192,"stargazers_count":16104,"watchers_count":16104,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3462,"mirror_url":null,"open_issues_count":295,"forks":3462,"open_issues":295,"watchers":16104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13372"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13372"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13372"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13372/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13372/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13372/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/e12cc37914563cd001e9a5931d6a4623fd2cc670"}}}}