{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/comments/87980394","pull_request_review_id":8567888,"id":87980394,"diff_hunk":"@@ -116,7 +110,7 @@ public void resumeReadAhead() {\n \n     @Override\n     public void onSuccess(LogRecordWithDLSN record) {\n-        setLastSeenDLSN(record.getDlsn());\n+        this.lastSeenDLSN = record.getDlsn();","path":"distributedlog-core/src/main/java/com/twitter/distributedlog/BKSyncLogReaderDLSN.java","position":27,"original_position":27,"commit_id":"ece97cf10eb1f71e57abb53f88e31960f4a84804","original_commit_id":"3ff9e8a77320ef3ba284d171d9c7693d90089f0d","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars.githubusercontent.com/u/1217863?v=3","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"LGTM. @leighst what do you think?","created_at":"2016-11-15T09:48:09Z","updated_at":"2016-11-15T09:48:18Z","html_url":"https://github.com/apache/incubator-distributedlog/pull/42#discussion_r87980394","pull_request_url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/comments/87980394"},"html":{"href":"https://github.com/apache/incubator-distributedlog/pull/42#discussion_r87980394"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42","id":90410394,"html_url":"https://github.com/apache/incubator-distributedlog/pull/42","diff_url":"https://github.com/apache/incubator-distributedlog/pull/42.diff","patch_url":"https://github.com/apache/incubator-distributedlog/pull/42.patch","issue_url":"https://api.github.com/repos/apache/incubator-distributedlog/issues/42","number":42,"state":"open","locked":false,"title":"Fix deadlock on BKSyncLogReaderDLSN","user":{"login":"khurrumnasimm","id":21236134,"avatar_url":"https://avatars.githubusercontent.com/u/21236134?v=3","gravatar_id":"","url":"https://api.github.com/users/khurrumnasimm","html_url":"https://github.com/khurrumnasimm","followers_url":"https://api.github.com/users/khurrumnasimm/followers","following_url":"https://api.github.com/users/khurrumnasimm/following{/other_user}","gists_url":"https://api.github.com/users/khurrumnasimm/gists{/gist_id}","starred_url":"https://api.github.com/users/khurrumnasimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khurrumnasimm/subscriptions","organizations_url":"https://api.github.com/users/khurrumnasimm/orgs","repos_url":"https://api.github.com/users/khurrumnasimm/repos","events_url":"https://api.github.com/users/khurrumnasimm/events{/privacy}","received_events_url":"https://api.github.com/users/khurrumnasimm/received_events","type":"User","site_admin":false},"body":"Change the lastSeenDLSN to volatile to remove the synchronization block to avoid deadlock with sharedLock\n","created_at":"2016-10-21T16:04:19Z","updated_at":"2016-11-15T09:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c951ad56bf8f72a2fd8d4c58df67ecdb5c9e31e5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-distributedlog/issues/42/comments","statuses_url":"https://api.github.com/repos/apache/incubator-distributedlog/statuses/ece97cf10eb1f71e57abb53f88e31960f4a84804","head":{"label":"khurrumnasimm:kn/fix_deadlock","ref":"kn/fix_deadlock","sha":"ece97cf10eb1f71e57abb53f88e31960f4a84804","user":{"login":"khurrumnasimm","id":21236134,"avatar_url":"https://avatars.githubusercontent.com/u/21236134?v=3","gravatar_id":"","url":"https://api.github.com/users/khurrumnasimm","html_url":"https://github.com/khurrumnasimm","followers_url":"https://api.github.com/users/khurrumnasimm/followers","following_url":"https://api.github.com/users/khurrumnasimm/following{/other_user}","gists_url":"https://api.github.com/users/khurrumnasimm/gists{/gist_id}","starred_url":"https://api.github.com/users/khurrumnasimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khurrumnasimm/subscriptions","organizations_url":"https://api.github.com/users/khurrumnasimm/orgs","repos_url":"https://api.github.com/users/khurrumnasimm/repos","events_url":"https://api.github.com/users/khurrumnasimm/events{/privacy}","received_events_url":"https://api.github.com/users/khurrumnasimm/received_events","type":"User","site_admin":false},"repo":{"id":66534667,"name":"incubator-distributedlog","full_name":"khurrumnasimm/incubator-distributedlog","owner":{"login":"khurrumnasimm","id":21236134,"avatar_url":"https://avatars.githubusercontent.com/u/21236134?v=3","gravatar_id":"","url":"https://api.github.com/users/khurrumnasimm","html_url":"https://github.com/khurrumnasimm","followers_url":"https://api.github.com/users/khurrumnasimm/followers","following_url":"https://api.github.com/users/khurrumnasimm/following{/other_user}","gists_url":"https://api.github.com/users/khurrumnasimm/gists{/gist_id}","starred_url":"https://api.github.com/users/khurrumnasimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khurrumnasimm/subscriptions","organizations_url":"https://api.github.com/users/khurrumnasimm/orgs","repos_url":"https://api.github.com/users/khurrumnasimm/repos","events_url":"https://api.github.com/users/khurrumnasimm/events{/privacy}","received_events_url":"https://api.github.com/users/khurrumnasimm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khurrumnasimm/incubator-distributedlog","description":"Mirror of Apache DistributedLog (Incubating)","fork":true,"url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog","forks_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/forks","keys_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/teams","hooks_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/hooks","issue_events_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/issues/events{/number}","events_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/events","assignees_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/assignees{/user}","branches_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/branches{/branch}","tags_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/tags","blobs_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/statuses/{sha}","languages_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/languages","stargazers_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/stargazers","contributors_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/contributors","subscribers_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/subscribers","subscription_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/subscription","commits_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/issues/comments{/number}","contents_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/contents/{+path}","compare_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/merges","archive_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/downloads","issues_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/issues{/number}","pulls_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/pulls{/number}","milestones_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/milestones{/number}","notifications_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/labels{/name}","releases_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/releases{/id}","deployments_url":"https://api.github.com/repos/khurrumnasimm/incubator-distributedlog/deployments","created_at":"2016-08-25T07:17:02Z","updated_at":"2016-08-25T07:17:04Z","pushed_at":"2016-11-12T10:31:12Z","git_url":"git://github.com/khurrumnasimm/incubator-distributedlog.git","ssh_url":"git@github.com:khurrumnasimm/incubator-distributedlog.git","clone_url":"https://github.com/khurrumnasimm/incubator-distributedlog.git","svn_url":"https://github.com/khurrumnasimm/incubator-distributedlog","homepage":null,"size":7124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"878ae87be5b40b9f9d9a27297be14ed83a2c2f34","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":63931184,"name":"incubator-distributedlog","full_name":"apache/incubator-distributedlog","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-distributedlog","description":"Mirror of Apache DistributedLog (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-distributedlog","forks_url":"https://api.github.com/repos/apache/incubator-distributedlog/forks","keys_url":"https://api.github.com/repos/apache/incubator-distributedlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-distributedlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-distributedlog/teams","hooks_url":"https://api.github.com/repos/apache/incubator-distributedlog/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-distributedlog/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-distributedlog/events","assignees_url":"https://api.github.com/repos/apache/incubator-distributedlog/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-distributedlog/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-distributedlog/tags","blobs_url":"https://api.github.com/repos/apache/incubator-distributedlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-distributedlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-distributedlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-distributedlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-distributedlog/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-distributedlog/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-distributedlog/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-distributedlog/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-distributedlog/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-distributedlog/subscription","commits_url":"https://api.github.com/repos/apache/incubator-distributedlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-distributedlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-distributedlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-distributedlog/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-distributedlog/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-distributedlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-distributedlog/merges","archive_url":"https://api.github.com/repos/apache/incubator-distributedlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-distributedlog/downloads","issues_url":"https://api.github.com/repos/apache/incubator-distributedlog/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-distributedlog/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-distributedlog/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-distributedlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-distributedlog/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-distributedlog/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-distributedlog/deployments","created_at":"2016-07-22T07:00:06Z","updated_at":"2016-11-08T14:56:05Z","pushed_at":"2016-11-14T16:31:19Z","git_url":"git://github.com/apache/incubator-distributedlog.git","ssh_url":"git@github.com:apache/incubator-distributedlog.git","clone_url":"https://github.com/apache/incubator-distributedlog.git","svn_url":"https://github.com/apache/incubator-distributedlog","homepage":null,"size":7507,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":"git://git.apache.org/incubator-distributedlog.git","open_issues_count":9,"forks":19,"open_issues":9,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42"},"html":{"href":"https://github.com/apache/incubator-distributedlog/pull/42"},"issue":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/issues/42"},"comments":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-distributedlog/statuses/ece97cf10eb1f71e57abb53f88e31960f4a84804"}}}}
{"actor":{"display_login":"sijie"}}