{"action":"opened","number":211,"pull_request":{"url":"https://api.github.com/repos/recharts/recharts/pulls/211","id":84065459,"html_url":"https://github.com/recharts/recharts/pull/211","diff_url":"https://github.com/recharts/recharts/pull/211.diff","patch_url":"https://github.com/recharts/recharts/pull/211.patch","issue_url":"https://api.github.com/repos/recharts/recharts/issues/211","number":211,"state":"open","locked":false,"title":"Stopped domain calculation reverting to 0 for missing data points","user":{"login":"AlexGilleran","id":900555,"avatar_url":"https://avatars.githubusercontent.com/u/900555?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGilleran","html_url":"https://github.com/AlexGilleran","followers_url":"https://api.github.com/users/AlexGilleran/followers","following_url":"https://api.github.com/users/AlexGilleran/following{/other_user}","gists_url":"https://api.github.com/users/AlexGilleran/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGilleran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGilleran/subscriptions","organizations_url":"https://api.github.com/users/AlexGilleran/orgs","repos_url":"https://api.github.com/users/AlexGilleran/repos","events_url":"https://api.github.com/users/AlexGilleran/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGilleran/received_events","type":"User","site_admin":false},"body":"Thanks for creating this library!\r\n\r\nI've just started using it and I've had trouble charting two datasets against each other that don't have exactly overlapping data points (e.g. 1/1/2010 has a value for one line, 1/2/2010 has a value for the other line etc) - fortunately I can use `connectNulls` to make the lines make sense, but the axis always starts from 0 even if I override it.\r\n\r\nThis is because domain calculation makes use of `Math.max|min` and javascript thinks that `null` is `0`. This PR simply excludes null data from domain calculation, reverting to `0` only if there's no other data to go off whatsoever.","created_at":"2016-09-06T06:13:28Z","updated_at":"2016-09-06T06:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/recharts/recharts/pulls/211/commits","review_comments_url":"https://api.github.com/repos/recharts/recharts/pulls/211/comments","review_comment_url":"https://api.github.com/repos/recharts/recharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/recharts/recharts/issues/211/comments","statuses_url":"https://api.github.com/repos/recharts/recharts/statuses/951882d7e8e486da563efbf59c6c68970bacb216","head":{"label":"AlexGilleran:fixed-domains","ref":"fixed-domains","sha":"951882d7e8e486da563efbf59c6c68970bacb216","user":{"login":"AlexGilleran","id":900555,"avatar_url":"https://avatars.githubusercontent.com/u/900555?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGilleran","html_url":"https://github.com/AlexGilleran","followers_url":"https://api.github.com/users/AlexGilleran/followers","following_url":"https://api.github.com/users/AlexGilleran/following{/other_user}","gists_url":"https://api.github.com/users/AlexGilleran/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGilleran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGilleran/subscriptions","organizations_url":"https://api.github.com/users/AlexGilleran/orgs","repos_url":"https://api.github.com/users/AlexGilleran/repos","events_url":"https://api.github.com/users/AlexGilleran/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGilleran/received_events","type":"User","site_admin":false},"repo":{"id":67468160,"name":"recharts","full_name":"AlexGilleran/recharts","owner":{"login":"AlexGilleran","id":900555,"avatar_url":"https://avatars.githubusercontent.com/u/900555?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGilleran","html_url":"https://github.com/AlexGilleran","followers_url":"https://api.github.com/users/AlexGilleran/followers","following_url":"https://api.github.com/users/AlexGilleran/following{/other_user}","gists_url":"https://api.github.com/users/AlexGilleran/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGilleran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGilleran/subscriptions","organizations_url":"https://api.github.com/users/AlexGilleran/orgs","repos_url":"https://api.github.com/users/AlexGilleran/repos","events_url":"https://api.github.com/users/AlexGilleran/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGilleran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexGilleran/recharts","description":"Redefined chart library built with React and D3","fork":true,"url":"https://api.github.com/repos/AlexGilleran/recharts","forks_url":"https://api.github.com/repos/AlexGilleran/recharts/forks","keys_url":"https://api.github.com/repos/AlexGilleran/recharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexGilleran/recharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexGilleran/recharts/teams","hooks_url":"https://api.github.com/repos/AlexGilleran/recharts/hooks","issue_events_url":"https://api.github.com/repos/AlexGilleran/recharts/issues/events{/number}","events_url":"https://api.github.com/repos/AlexGilleran/recharts/events","assignees_url":"https://api.github.com/repos/AlexGilleran/recharts/assignees{/user}","branches_url":"https://api.github.com/repos/AlexGilleran/recharts/branches{/branch}","tags_url":"https://api.github.com/repos/AlexGilleran/recharts/tags","blobs_url":"https://api.github.com/repos/AlexGilleran/recharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexGilleran/recharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexGilleran/recharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexGilleran/recharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexGilleran/recharts/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexGilleran/recharts/languages","stargazers_url":"https://api.github.com/repos/AlexGilleran/recharts/stargazers","contributors_url":"https://api.github.com/repos/AlexGilleran/recharts/contributors","subscribers_url":"https://api.github.com/repos/AlexGilleran/recharts/subscribers","subscription_url":"https://api.github.com/repos/AlexGilleran/recharts/subscription","commits_url":"https://api.github.com/repos/AlexGilleran/recharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexGilleran/recharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexGilleran/recharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexGilleran/recharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexGilleran/recharts/contents/{+path}","compare_url":"https://api.github.com/repos/AlexGilleran/recharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexGilleran/recharts/merges","archive_url":"https://api.github.com/repos/AlexGilleran/recharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexGilleran/recharts/downloads","issues_url":"https://api.github.com/repos/AlexGilleran/recharts/issues{/number}","pulls_url":"https://api.github.com/repos/AlexGilleran/recharts/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexGilleran/recharts/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexGilleran/recharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexGilleran/recharts/labels{/name}","releases_url":"https://api.github.com/repos/AlexGilleran/recharts/releases{/id}","deployments_url":"https://api.github.com/repos/AlexGilleran/recharts/deployments","created_at":"2016-09-06T02:57:44Z","updated_at":"2016-09-06T02:57:45Z","pushed_at":"2016-09-06T06:03:34Z","git_url":"git://github.com/AlexGilleran/recharts.git","ssh_url":"git@github.com:AlexGilleran/recharts.git","clone_url":"https://github.com/AlexGilleran/recharts.git","svn_url":"https://github.com/AlexGilleran/recharts","homepage":"http://recharts.org","size":2141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"recharts:master","ref":"master","sha":"5dd38b351edaa2b6e6a5b28ccdca60e8de1a346b","user":{"login":"recharts","id":13690587,"avatar_url":"https://avatars.githubusercontent.com/u/13690587?v=3","gravatar_id":"","url":"https://api.github.com/users/recharts","html_url":"https://github.com/recharts","followers_url":"https://api.github.com/users/recharts/followers","following_url":"https://api.github.com/users/recharts/following{/other_user}","gists_url":"https://api.github.com/users/recharts/gists{/gist_id}","starred_url":"https://api.github.com/users/recharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recharts/subscriptions","organizations_url":"https://api.github.com/users/recharts/orgs","repos_url":"https://api.github.com/users/recharts/repos","events_url":"https://api.github.com/users/recharts/events{/privacy}","received_events_url":"https://api.github.com/users/recharts/received_events","type":"Organization","site_admin":false},"repo":{"id":40345658,"name":"recharts","full_name":"recharts/recharts","owner":{"login":"recharts","id":13690587,"avatar_url":"https://avatars.githubusercontent.com/u/13690587?v=3","gravatar_id":"","url":"https://api.github.com/users/recharts","html_url":"https://github.com/recharts","followers_url":"https://api.github.com/users/recharts/followers","following_url":"https://api.github.com/users/recharts/following{/other_user}","gists_url":"https://api.github.com/users/recharts/gists{/gist_id}","starred_url":"https://api.github.com/users/recharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recharts/subscriptions","organizations_url":"https://api.github.com/users/recharts/orgs","repos_url":"https://api.github.com/users/recharts/repos","events_url":"https://api.github.com/users/recharts/events{/privacy}","received_events_url":"https://api.github.com/users/recharts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/recharts/recharts","description":"Redefined chart library built with React and D3","fork":false,"url":"https://api.github.com/repos/recharts/recharts","forks_url":"https://api.github.com/repos/recharts/recharts/forks","keys_url":"https://api.github.com/repos/recharts/recharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recharts/recharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recharts/recharts/teams","hooks_url":"https://api.github.com/repos/recharts/recharts/hooks","issue_events_url":"https://api.github.com/repos/recharts/recharts/issues/events{/number}","events_url":"https://api.github.com/repos/recharts/recharts/events","assignees_url":"https://api.github.com/repos/recharts/recharts/assignees{/user}","branches_url":"https://api.github.com/repos/recharts/recharts/branches{/branch}","tags_url":"https://api.github.com/repos/recharts/recharts/tags","blobs_url":"https://api.github.com/repos/recharts/recharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recharts/recharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recharts/recharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/recharts/recharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recharts/recharts/statuses/{sha}","languages_url":"https://api.github.com/repos/recharts/recharts/languages","stargazers_url":"https://api.github.com/repos/recharts/recharts/stargazers","contributors_url":"https://api.github.com/repos/recharts/recharts/contributors","subscribers_url":"https://api.github.com/repos/recharts/recharts/subscribers","subscription_url":"https://api.github.com/repos/recharts/recharts/subscription","commits_url":"https://api.github.com/repos/recharts/recharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/recharts/recharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/recharts/recharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/recharts/recharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/recharts/recharts/contents/{+path}","compare_url":"https://api.github.com/repos/recharts/recharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recharts/recharts/merges","archive_url":"https://api.github.com/repos/recharts/recharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recharts/recharts/downloads","issues_url":"https://api.github.com/repos/recharts/recharts/issues{/number}","pulls_url":"https://api.github.com/repos/recharts/recharts/pulls{/number}","milestones_url":"https://api.github.com/repos/recharts/recharts/milestones{/number}","notifications_url":"https://api.github.com/repos/recharts/recharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recharts/recharts/labels{/name}","releases_url":"https://api.github.com/repos/recharts/recharts/releases{/id}","deployments_url":"https://api.github.com/repos/recharts/recharts/deployments","created_at":"2015-08-07T06:50:27Z","updated_at":"2016-09-06T06:09:19Z","pushed_at":"2016-09-02T20:00:45Z","git_url":"git://github.com/recharts/recharts.git","ssh_url":"git@github.com:recharts/recharts.git","clone_url":"https://github.com/recharts/recharts.git","svn_url":"https://github.com/recharts/recharts","homepage":"http://recharts.org","size":2214,"stargazers_count":3266,"watchers_count":3266,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":19,"forks":139,"open_issues":19,"watchers":3266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/recharts/recharts/pulls/211"},"html":{"href":"https://github.com/recharts/recharts/pull/211"},"issue":{"href":"https://api.github.com/repos/recharts/recharts/issues/211"},"comments":{"href":"https://api.github.com/repos/recharts/recharts/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/recharts/recharts/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/recharts/recharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/recharts/recharts/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/recharts/recharts/statuses/951882d7e8e486da563efbf59c6c68970bacb216"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":92,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"AlexGilleran"}}