{"action":"created","issue":{"url":"https://api.github.com/repos/jnicklas/capybara/issues/1744","repository_url":"https://api.github.com/repos/jnicklas/capybara","labels_url":"https://api.github.com/repos/jnicklas/capybara/issues/1744/labels{/name}","comments_url":"https://api.github.com/repos/jnicklas/capybara/issues/1744/comments","events_url":"https://api.github.com/repos/jnicklas/capybara/issues/1744/events","html_url":"https://github.com/jnicklas/capybara/pull/1744","id":172588343,"number":1744,"title":"clarify Firefox note on readme","user":{"login":"titusfortner","id":777185,"avatar_url":"https://avatars.githubusercontent.com/u/777185?v=3","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-23T00:50:09Z","updated_at":"2016-09-01T02:52:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jnicklas/capybara/pulls/1744","html_url":"https://github.com/jnicklas/capybara/pull/1744","diff_url":"https://github.com/jnicklas/capybara/pull/1744.diff","patch_url":"https://github.com/jnicklas/capybara/pull/1744.patch"},"body":"The current statement in the README is technically incorrect.\r\n\r\nThis is the code that should work to use Selenium 3.0 with the legacy Firefox driver.\r\n```ruby\r\nCapybara.register_driver :legacy_firefox do |app|\r\n  Capybara::Selenium::Driver.new(\r\n    app,\r\n    browser: :firefox,\r\n    desired_capabilities: Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false)\r\n  )\r\nend\r\n```\r\n\r\nIf this PR is too wordy, maybe the information and above code could be put somewhere else and referenced by link in the README."},"comment":{"url":"https://api.github.com/repos/jnicklas/capybara/issues/comments/243961837","html_url":"https://github.com/jnicklas/capybara/pull/1744#issuecomment-243961837","issue_url":"https://api.github.com/repos/jnicklas/capybara/issues/1744","id":243961837,"user":{"login":"titusfortner","id":777185,"avatar_url":"https://avatars.githubusercontent.com/u/777185?v=3","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T02:52:49Z","updated_at":"2016-09-01T02:52:49Z","body":"Yeah, I'm not super happy with that, either. I was hoping that once we deprecated the legacy Firefox & Safari drivers we wouldn't need to do any build process at all for the Ruby code, but I guess it makes sense that where JWP drivers use the atoms, w3c should not.\r\n\r\nI have a local Jenkins I use to run Watir specs on Selenium master. I shallow clone Selenium and run: \r\n\r\n`./go //rb:gem:build`\r\n\r\nThen set in the gemfile:\r\n\r\n`gem 'selenium-webdriver', :path => '../selenium/build/rb'`\r\n"}}
{"actor":{"display_login":"titusfortner"}}