{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/51109696","id":51109696,"diff_hunk":"@@ -87,16 +87,14 @@ void TextureCache::TCacheEntry::CopyRectangleFromTexture(\n \tif (srcrect.GetWidth() == dstrect.GetWidth()\n \t\t&& srcrect.GetHeight() == dstrect.GetHeight())\n \t{\n-\t\tconst D3D11_BOX *psrcbox = nullptr;\n \t\tD3D11_BOX srcbox;\n-\t\tif (srcrect.left != 0 || srcrect.top != 0)\n-\t\t{\n-\t\t\tsrcbox.left = srcrect.left;\n-\t\t\tsrcbox.top = srcrect.top;\n-\t\t\tsrcbox.right = srcrect.right;\n-\t\t\tsrcbox.bottom = srcrect.bottom;\n-\t\t\tpsrcbox = &srcbox;\n-\t\t}\n+\t\tsrcbox.left = srcrect.left;\n+\t\tsrcbox.top = srcrect.top;\n+\t\tsrcbox.right = srcrect.right;\n+\t\tsrcbox.bottom = srcrect.bottom;\n+\t\tsrcbox.front = 0;\n+\t\tsrcbox.back = 1;","path":"Source/Core/VideoBackends/D3D/TextureCache.cpp","position":19,"original_position":19,"commit_id":"ba299ed429ade593320350fb5aea2f0cd7641395","original_commit_id":"ba299ed429ade593320350fb5aea2f0cd7641395","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"body":"Is it possible for this code path to deal with EFB textures? In that case we should probably copy all layers.","created_at":"2016-01-28T11:18:19Z","updated_at":"2016-01-28T11:18:19Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3355#discussion_r51109696","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/51109696"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3355#discussion_r51109696"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355","id":54118478,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3355","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3355.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3355.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355","number":3355,"state":"open","locked":false,"title":"Partial texture updates: Check the dimensions of the efb copy","user":{"login":"mimimi085181","id":9304938,"avatar_url":"https://avatars.githubusercontent.com/u/9304938?v=3","gravatar_id":"","url":"https://api.github.com/users/mimimi085181","html_url":"https://github.com/mimimi085181","followers_url":"https://api.github.com/users/mimimi085181/followers","following_url":"https://api.github.com/users/mimimi085181/following{/other_user}","gists_url":"https://api.github.com/users/mimimi085181/gists{/gist_id}","starred_url":"https://api.github.com/users/mimimi085181/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimimi085181/subscriptions","organizations_url":"https://api.github.com/users/mimimi085181/orgs","repos_url":"https://api.github.com/users/mimimi085181/repos","events_url":"https://api.github.com/users/mimimi085181/events{/privacy}","received_events_url":"https://api.github.com/users/mimimi085181/received_events","type":"User","site_admin":false},"body":"and the target texture, not just the binary size.\r\n\r\nA few other fixes around partial texture updates found their way into this pr as well:\r\n- A bug in D3D's version of TextureCache::TCacheEntry::CopyRectangleFromTexture which would cause some issue when trying to use only a part of a source texture\r\n- Forcing the scaling factor for both, the efb copy and the normal texture to be the current scaling factor. Before it was rescaling the normal texture with the scaling factor of the efb copy, but it might have calculated it wrong for small efb copies.\r\n- Keeping track of the pointer for textures_by_hash\r\n\r\n\r\nThis should get Donkey Kong Country Returns characters to be as broken as they should be. They will be fixed in a later pr.\r\n\r\n\r\n\r\nExpected result is:\r\nefbtex: characters are always flickering or invisible, no matter what scaling or IR setting\r\nefb2ram: characters are always working properly at 1xIR, no matter what scaling or IR setting\r\n\r\nThis is related to:\r\nhttps://bugs.dolphin-emu.org/issues/9120\r\n\r\nPS: Donkey Kong is supposed to be invisible with efb2tex, because the efb copy is 1 pixel/texel wider and heigher than the texture the game tries to use from the same offset. So the correct behavior is to not use that efb copy, because currently the efb copy is supposed to fit completely into the texture that is updated. But the partial texture updates code did only check the binary size for updates, so Dolphin refused to use the efb copy directly, but did a partial texture update. But why it was randomly working and not working with different IR settings, i don't know.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3355)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-12-18T16:01:20Z","updated_at":"2016-01-28T11:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57397c4276ec0f2eacd0997a14099ab45f8de59b","assignee":null,"milestone":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones/1","html_url":"https://github.com/dolphin-emu/dolphin/milestones/Dolphin%20Release%205.0","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones/1/labels","id":1154505,"number":1,"title":"Dolphin Release 5.0","description":"","creator":{"login":"Parlane","id":86614,"avatar_url":"https://avatars.githubusercontent.com/u/86614?v=3","gravatar_id":"","url":"https://api.github.com/users/Parlane","html_url":"https://github.com/Parlane","followers_url":"https://api.github.com/users/Parlane/followers","following_url":"https://api.github.com/users/Parlane/following{/other_user}","gists_url":"https://api.github.com/users/Parlane/gists{/gist_id}","starred_url":"https://api.github.com/users/Parlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parlane/subscriptions","organizations_url":"https://api.github.com/users/Parlane/orgs","repos_url":"https://api.github.com/users/Parlane/repos","events_url":"https://api.github.com/users/Parlane/events{/privacy}","received_events_url":"https://api.github.com/users/Parlane/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":32,"state":"open","created_at":"2015-06-08T11:13:39Z","updated_at":"2016-01-27T15:34:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ba299ed429ade593320350fb5aea2f0cd7641395","head":{"label":"mimimi085181:partial-texture-updates-check-dimensions","ref":"partial-texture-updates-check-dimensions","sha":"ba299ed429ade593320350fb5aea2f0cd7641395","user":{"login":"mimimi085181","id":9304938,"avatar_url":"https://avatars.githubusercontent.com/u/9304938?v=3","gravatar_id":"","url":"https://api.github.com/users/mimimi085181","html_url":"https://github.com/mimimi085181","followers_url":"https://api.github.com/users/mimimi085181/followers","following_url":"https://api.github.com/users/mimimi085181/following{/other_user}","gists_url":"https://api.github.com/users/mimimi085181/gists{/gist_id}","starred_url":"https://api.github.com/users/mimimi085181/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimimi085181/subscriptions","organizations_url":"https://api.github.com/users/mimimi085181/orgs","repos_url":"https://api.github.com/users/mimimi085181/repos","events_url":"https://api.github.com/users/mimimi085181/events{/privacy}","received_events_url":"https://api.github.com/users/mimimi085181/received_events","type":"User","site_admin":false},"repo":{"id":30147616,"name":"dolphin","full_name":"mimimi085181/dolphin","owner":{"login":"mimimi085181","id":9304938,"avatar_url":"https://avatars.githubusercontent.com/u/9304938?v=3","gravatar_id":"","url":"https://api.github.com/users/mimimi085181","html_url":"https://github.com/mimimi085181","followers_url":"https://api.github.com/users/mimimi085181/followers","following_url":"https://api.github.com/users/mimimi085181/following{/other_user}","gists_url":"https://api.github.com/users/mimimi085181/gists{/gist_id}","starred_url":"https://api.github.com/users/mimimi085181/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimimi085181/subscriptions","organizations_url":"https://api.github.com/users/mimimi085181/orgs","repos_url":"https://api.github.com/users/mimimi085181/repos","events_url":"https://api.github.com/users/mimimi085181/events{/privacy}","received_events_url":"https://api.github.com/users/mimimi085181/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mimimi085181/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/mimimi085181/dolphin","forks_url":"https://api.github.com/repos/mimimi085181/dolphin/forks","keys_url":"https://api.github.com/repos/mimimi085181/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mimimi085181/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mimimi085181/dolphin/teams","hooks_url":"https://api.github.com/repos/mimimi085181/dolphin/hooks","issue_events_url":"https://api.github.com/repos/mimimi085181/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/mimimi085181/dolphin/events","assignees_url":"https://api.github.com/repos/mimimi085181/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/mimimi085181/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/mimimi085181/dolphin/tags","blobs_url":"https://api.github.com/repos/mimimi085181/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mimimi085181/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mimimi085181/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mimimi085181/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mimimi085181/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/mimimi085181/dolphin/languages","stargazers_url":"https://api.github.com/repos/mimimi085181/dolphin/stargazers","contributors_url":"https://api.github.com/repos/mimimi085181/dolphin/contributors","subscribers_url":"https://api.github.com/repos/mimimi085181/dolphin/subscribers","subscription_url":"https://api.github.com/repos/mimimi085181/dolphin/subscription","commits_url":"https://api.github.com/repos/mimimi085181/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mimimi085181/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mimimi085181/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mimimi085181/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mimimi085181/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/mimimi085181/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mimimi085181/dolphin/merges","archive_url":"https://api.github.com/repos/mimimi085181/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mimimi085181/dolphin/downloads","issues_url":"https://api.github.com/repos/mimimi085181/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/mimimi085181/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/mimimi085181/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/mimimi085181/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mimimi085181/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/mimimi085181/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/mimimi085181/dolphin/deployments","created_at":"2015-02-01T13:58:13Z","updated_at":"2015-06-10T11:27:53Z","pushed_at":"2016-01-21T19:28:36Z","git_url":"git://github.com/mimimi085181/dolphin.git","ssh_url":"git@github.com:mimimi085181/dolphin.git","clone_url":"https://github.com/mimimi085181/dolphin.git","svn_url":"https://github.com/mimimi085181/dolphin","homepage":"https://dolphin-emu.org/","size":235674,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7c3e4b34f3407b95ac1746fe6f4567c744478c60","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-01-28T02:41:05Z","pushed_at":"2016-01-28T07:43:57Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":253746,"stargazers_count":1982,"watchers_count":1982,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"open_issues_count":95,"forks":601,"open_issues":95,"watchers":1982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3355"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ba299ed429ade593320350fb5aea2f0cd7641395"}}}}