{"action":"created","issue":{"url":"https://api.github.com/repos/losalamos/Draco/issues/139","repository_url":"https://api.github.com/repos/losalamos/Draco","labels_url":"https://api.github.com/repos/losalamos/Draco/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/losalamos/Draco/issues/139/comments","events_url":"https://api.github.com/repos/losalamos/Draco/issues/139/events","html_url":"https://github.com/losalamos/Draco/pull/139","id":195930139,"number":139,"title":"Add an Abstract_Class_Contexual_Parser that parallels Abstract_Class_…","user":{"login":"kgbudge","id":20447234,"avatar_url":"https://avatars.githubusercontent.com/u/20447234?v=3","gravatar_id":"","url":"https://api.github.com/users/kgbudge","html_url":"https://github.com/kgbudge","followers_url":"https://api.github.com/users/kgbudge/followers","following_url":"https://api.github.com/users/kgbudge/following{/other_user}","gists_url":"https://api.github.com/users/kgbudge/gists{/gist_id}","starred_url":"https://api.github.com/users/kgbudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgbudge/subscriptions","organizations_url":"https://api.github.com/users/kgbudge/orgs","repos_url":"https://api.github.com/users/kgbudge/repos","events_url":"https://api.github.com/users/kgbudge/events{/privacy}","received_events_url":"https://api.github.com/users/kgbudge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kgbudge","id":20447234,"avatar_url":"https://avatars.githubusercontent.com/u/20447234?v=3","gravatar_id":"","url":"https://api.github.com/users/kgbudge","html_url":"https://github.com/kgbudge","followers_url":"https://api.github.com/users/kgbudge/followers","following_url":"https://api.github.com/users/kgbudge/following{/other_user}","gists_url":"https://api.github.com/users/kgbudge/gists{/gist_id}","starred_url":"https://api.github.com/users/kgbudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgbudge/subscriptions","organizations_url":"https://api.github.com/users/kgbudge/orgs","repos_url":"https://api.github.com/users/kgbudge/repos","events_url":"https://api.github.com/users/kgbudge/events{/privacy}","received_events_url":"https://api.github.com/users/kgbudge/received_events","type":"User","site_admin":false},"assignees":[{"login":"kgbudge","id":20447234,"avatar_url":"https://avatars.githubusercontent.com/u/20447234?v=3","gravatar_id":"","url":"https://api.github.com/users/kgbudge","html_url":"https://github.com/kgbudge","followers_url":"https://api.github.com/users/kgbudge/followers","following_url":"https://api.github.com/users/kgbudge/following{/other_user}","gists_url":"https://api.github.com/users/kgbudge/gists{/gist_id}","starred_url":"https://api.github.com/users/kgbudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgbudge/subscriptions","organizations_url":"https://api.github.com/users/kgbudge/orgs","repos_url":"https://api.github.com/users/kgbudge/repos","events_url":"https://api.github.com/users/kgbudge/events{/privacy}","received_events_url":"https://api.github.com/users/kgbudge/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-15T22:13:27Z","updated_at":"2016-12-16T00:55:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/losalamos/Draco/pulls/139","html_url":"https://github.com/losalamos/Draco/pull/139","diff_url":"https://github.com/losalamos/Draco/pull/139.diff","patch_url":"https://github.com/losalamos/Draco/pull/139.patch"},"body":"* The class Abstract_Class_Contextual_Parser is nearly identical to Abstract_Class_Parser; the only significant difference is that the Parse_Function typedef is to a function taking an additional context argument. Its use is documented in the test file test/tstAbstract_Class_Contextual_Parser.cc\r\n* I noticed while writing this class that there was an uncovered destructor in Abstract_Class_Parser_Base. On further reflection, I realized that this class is much more machinery than is needed to perform its function, so I stripped it down to its core and moved this into Abstract_Class_Parser.i.hh.\r\n\r\n* [Pre-Merge Code Review](https://github.com/losalamos/Draco/wiki/Style-Guide)\r\n  * [x] Travis CI checks pass\r\n  * [x] Code coverage does not decrease\r\n  * [x] [Valgrind test passes](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Toss2 checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Trinitite checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] Code reviewed/approved, sufficient DbC checks, testing, documentation\r\n  * [ ] Test on Win32 and Sequoia. This PR touches routines that we had a lot of trouble compiling on non-Linux machines.\r\n"},"comment":{"url":"https://api.github.com/repos/losalamos/Draco/issues/comments/267489091","html_url":"https://github.com/losalamos/Draco/pull/139#issuecomment-267489091","issue_url":"https://api.github.com/repos/losalamos/Draco/issues/139","id":267489091,"user":{"login":"KineticTheory","id":17579601,"avatar_url":"https://avatars.githubusercontent.com/u/17579601?v=3","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T00:55:15Z","updated_at":"2016-12-16T00:55:15Z","body":"I added a couple of additional checks for this PR since it touches code that I have struggled to compile in the past.  I want to be sure we don't loose our ability to compile on the IBM BGQ and Win32 platforms. I'll take care of this testing."}}
{"actor":{"display_login":"KineticTheory"}}