{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/70838887","id":70838887,"diff_hunk":"@@ -37,5 +37,231 @@ def take\n     def poll(millis)\n       @queue.poll(millis, TimeUnit::MILLISECONDS)\n     end\n+\n+    def write_client\n+      WriteClient.new(self)\n+    end\n+\n+    def read_client\n+      ReadClient.new(self)\n+    end\n+\n+    class ReadClient\n+      # We generally only want one thread at a time able to access pop/take/poll operations\n+      # from this queue. We also depend on this to be able to block consumers while we snapshot\n+      # in-flight buffers\n+\n+      def initialize(queue)\n+        @queue = queue\n+        @mutex = Mutex.new\n+        @inflight_batches = {}\n+        @batch_size = 125\n+        @wait_for = 5\n+      end\n+\n+      def set_batch_details(batch_size, wait_for)","path":"logstash-core/lib/logstash/util/wrapped_synchronous_queue.rb","position":26,"original_position":26,"commit_id":"6b19b03be8e1a04678273201db49903e5dc87cc0","original_commit_id":"1a0615121ba9f13772f3349836b4f3f68b8a56e9","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"I anticipated that, in the near future we may change either of these parameters during a run.\r\nDoing this in a setter would not interrupt the thread locking - it would just allow the next batch to be sourced differently.","created_at":"2016-07-14T16:37:40Z","updated_at":"2016-07-14T16:37:40Z","html_url":"https://github.com/elastic/logstash/pull/5560#discussion_r70838887","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5560","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/70838887"},"html":{"href":"https://github.com/elastic/logstash/pull/5560#discussion_r70838887"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5560","id":75493186,"html_url":"https://github.com/elastic/logstash/pull/5560","diff_url":"https://github.com/elastic/logstash/pull/5560.diff","patch_url":"https://github.com/elastic/logstash/pull/5560.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5560","number":5560,"state":"open","locked":false,"title":"Add queue client support (and batch object) to pipeline","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"Following discussion, this is WrappedSynchronousQueue Client support classes proposal.","created_at":"2016-06-28T15:01:32Z","updated_at":"2016-07-14T16:37:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"320cddae4a8b9934fc54c0d56691efa3786fd352","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5560/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5560/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5560/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/6b19b03be8e1a04678273201db49903e5dc87cc0","head":{"label":"guyboertje:fix/5525","ref":"fix/5525","sha":"6b19b03be8e1a04678273201db49903e5dc87cc0","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"repo":{"id":44548170,"name":"logstash","full_name":"guyboertje/logstash","owner":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guyboertje/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/guyboertje/logstash","forks_url":"https://api.github.com/repos/guyboertje/logstash/forks","keys_url":"https://api.github.com/repos/guyboertje/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyboertje/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyboertje/logstash/teams","hooks_url":"https://api.github.com/repos/guyboertje/logstash/hooks","issue_events_url":"https://api.github.com/repos/guyboertje/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/guyboertje/logstash/events","assignees_url":"https://api.github.com/repos/guyboertje/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/guyboertje/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/guyboertje/logstash/tags","blobs_url":"https://api.github.com/repos/guyboertje/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyboertje/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyboertje/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyboertje/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyboertje/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/guyboertje/logstash/languages","stargazers_url":"https://api.github.com/repos/guyboertje/logstash/stargazers","contributors_url":"https://api.github.com/repos/guyboertje/logstash/contributors","subscribers_url":"https://api.github.com/repos/guyboertje/logstash/subscribers","subscription_url":"https://api.github.com/repos/guyboertje/logstash/subscription","commits_url":"https://api.github.com/repos/guyboertje/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyboertje/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyboertje/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyboertje/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyboertje/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/guyboertje/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyboertje/logstash/merges","archive_url":"https://api.github.com/repos/guyboertje/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyboertje/logstash/downloads","issues_url":"https://api.github.com/repos/guyboertje/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/guyboertje/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/guyboertje/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/guyboertje/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyboertje/logstash/labels{/name}","releases_url":"https://api.github.com/repos/guyboertje/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/guyboertje/logstash/deployments","created_at":"2015-10-19T16:26:52Z","updated_at":"2016-01-12T15:34:23Z","pushed_at":"2016-07-14T09:43:44Z","git_url":"git://github.com/guyboertje/logstash.git","ssh_url":"git@github.com:guyboertje/logstash.git","clone_url":"https://github.com/guyboertje/logstash.git","svn_url":"https://github.com/guyboertje/logstash","homepage":"https://www.elastic.co/products/logstash","size":76203,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"87e13ced5b29b7e04e88ec5e68b5be25885e45dc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-07-14T14:39:55Z","pushed_at":"2016-07-14T15:55:55Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":89110,"stargazers_count":6153,"watchers_count":6153,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1831,"mirror_url":null,"open_issues_count":788,"forks":1831,"open_issues":788,"watchers":6153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560"},"html":{"href":"https://github.com/elastic/logstash/pull/5560"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5560"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5560/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/6b19b03be8e1a04678273201db49903e5dc87cc0"}}}}
{"actor":{"display_login":"guyboertje"}}