{"action":"created","issue":{"url":"https://api.github.com/repos/Lickability/PinpointKit/issues/188","repository_url":"https://api.github.com/repos/Lickability/PinpointKit","labels_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/188/comments","events_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/188/events","html_url":"https://github.com/Lickability/PinpointKit/pull/188","id":190340617,"number":188,"title":"Bar Button Item Customization","user":{"login":"mliberatore","id":7883805,"avatar_url":"https://avatars.githubusercontent.com/u/7883805?v=3","gravatar_id":"","url":"https://api.github.com/users/mliberatore","html_url":"https://github.com/mliberatore","followers_url":"https://api.github.com/users/mliberatore/followers","following_url":"https://api.github.com/users/mliberatore/following{/other_user}","gists_url":"https://api.github.com/users/mliberatore/gists{/gist_id}","starred_url":"https://api.github.com/users/mliberatore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mliberatore/subscriptions","organizations_url":"https://api.github.com/users/mliberatore/orgs","repos_url":"https://api.github.com/users/mliberatore/repos","events_url":"https://api.github.com/users/mliberatore/events{/privacy}","received_events_url":"https://api.github.com/users/mliberatore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-18T15:05:20Z","updated_at":"2016-11-18T17:15:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/188","html_url":"https://github.com/Lickability/PinpointKit/pull/188","diff_url":"https://github.com/Lickability/PinpointKit/pull/188.diff","patch_url":"https://github.com/Lickability/PinpointKit/pull/188.patch"},"body":"## What it Does\r\n\r\n- Adds the ability to customize bar buttons on `EditImageViewController`\r\n- Introduces a new `Appearance` property, `editorDoneButtonFont`, since the `editorTextAnnotationDoneButtonFont` was being used for more than just the text annotation dismiss button.\r\n- Renames `editorTextAnnotationDoneButtonFont` to `editorTextAnnotationDismissButtonFont` for better disambiguation.\r\n\r\n## How to Test\r\n\r\n1. Run `git revert -n 0db8fa2`, which uses a custom implementation of `EditImageViewControllerBarButtonItemProviding`.\r\n1. View the test code in `ViewController.swift`, which makes the right bar button item log to the console, and the left bar button item dismiss.\r\n1. Make some modifications like setting `allowsHidingBarButtonItemsWhileEditingTextAnnotations` to `true` in this test implementation, and verify the results."},"comment":{"url":"https://api.github.com/repos/Lickability/PinpointKit/issues/comments/261587449","html_url":"https://github.com/Lickability/PinpointKit/pull/188#issuecomment-261587449","issue_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/188","id":261587449,"user":{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T17:15:33Z","updated_at":"2016-11-18T17:15:33Z","body":"@mliberatore Oh yeah, the bold thing. I guess we could modify the API to have a `done` and non-done style font, but I’m not sure that’s better. Do you think we should change it in some way or leave it as is with every font being individually settable? cc @bcapps "}}
{"actor":{"display_login":"mattbischoff"}}