{"action":"opened","number":589,"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/589","id":57928146,"html_url":"https://github.com/d-ronin/dRonin/pull/589","diff_url":"https://github.com/d-ronin/dRonin/pull/589.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/589.patch","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/589","number":589,"state":"open","locked":false,"title":"Flight: Make external mag handling consistent across targets","user":{"login":"jihlein","id":3869782,"avatar_url":"https://avatars.githubusercontent.com/u/3869782?v=3","gravatar_id":"","url":"https://api.github.com/users/jihlein","html_url":"https://github.com/jihlein","followers_url":"https://api.github.com/users/jihlein/followers","following_url":"https://api.github.com/users/jihlein/following{/other_user}","gists_url":"https://api.github.com/users/jihlein/gists{/gist_id}","starred_url":"https://api.github.com/users/jihlein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihlein/subscriptions","organizations_url":"https://api.github.com/users/jihlein/orgs","repos_url":"https://api.github.com/users/jihlein/repos","events_url":"https://api.github.com/users/jihlein/events{/privacy}","received_events_url":"https://api.github.com/users/jihlein/received_events","type":"User","site_admin":false},"body":"The external mag handling is not consistent across targets  This PR will change the external mag handling to be as follows:\r\n\r\n1)I2C initialization will no longer generate a panic code upon failure.  Successful initialization will be indicated by the I2C WCA box being displayed in green.  Either an init failure or a checkclear failure will turn the I2C WCA box red.  Both internal and external I2C ports will adhere to this.  One deficiency is that if an I2C bus fails initialization, it will be hard to tell whether the internal or external bus is at fault.  A mitigation here is to disable any active external I2C buses and see if the error condition clears,\r\n\r\n2)A failure of the external mag to initialize will no longer generate a panic code upon initialization or test failure, it will turn the sensor WCA box red.\r\n\r\n3)An option to disable the use of mag inputs completely will be added.\r\n\r\nThis initial set of commits moves Sparky to this paradigm.  Other targets to follow.","created_at":"2016-02-02T01:31:11Z","updated_at":"2016-02-02T01:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/589/commits","review_comments_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/589/comments","review_comment_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/589/comments","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/56eb09f7df13471a12c25b5ae0df6783d4c64a0b","head":{"label":"jihlein:extMag","ref":"extMag","sha":"56eb09f7df13471a12c25b5ae0df6783d4c64a0b","user":{"login":"jihlein","id":3869782,"avatar_url":"https://avatars.githubusercontent.com/u/3869782?v=3","gravatar_id":"","url":"https://api.github.com/users/jihlein","html_url":"https://github.com/jihlein","followers_url":"https://api.github.com/users/jihlein/followers","following_url":"https://api.github.com/users/jihlein/following{/other_user}","gists_url":"https://api.github.com/users/jihlein/gists{/gist_id}","starred_url":"https://api.github.com/users/jihlein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihlein/subscriptions","organizations_url":"https://api.github.com/users/jihlein/orgs","repos_url":"https://api.github.com/users/jihlein/repos","events_url":"https://api.github.com/users/jihlein/events{/privacy}","received_events_url":"https://api.github.com/users/jihlein/received_events","type":"User","site_admin":false},"repo":{"id":43623620,"name":"dronin","full_name":"jihlein/dronin","owner":{"login":"jihlein","id":3869782,"avatar_url":"https://avatars.githubusercontent.com/u/3869782?v=3","gravatar_id":"","url":"https://api.github.com/users/jihlein","html_url":"https://github.com/jihlein","followers_url":"https://api.github.com/users/jihlein/followers","following_url":"https://api.github.com/users/jihlein/following{/other_user}","gists_url":"https://api.github.com/users/jihlein/gists{/gist_id}","starred_url":"https://api.github.com/users/jihlein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihlein/subscriptions","organizations_url":"https://api.github.com/users/jihlein/orgs","repos_url":"https://api.github.com/users/jihlein/repos","events_url":"https://api.github.com/users/jihlein/events{/privacy}","received_events_url":"https://api.github.com/users/jihlein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jihlein/dronin","description":"The dRonin' flight controller software.","fork":true,"url":"https://api.github.com/repos/jihlein/dronin","forks_url":"https://api.github.com/repos/jihlein/dronin/forks","keys_url":"https://api.github.com/repos/jihlein/dronin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihlein/dronin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihlein/dronin/teams","hooks_url":"https://api.github.com/repos/jihlein/dronin/hooks","issue_events_url":"https://api.github.com/repos/jihlein/dronin/issues/events{/number}","events_url":"https://api.github.com/repos/jihlein/dronin/events","assignees_url":"https://api.github.com/repos/jihlein/dronin/assignees{/user}","branches_url":"https://api.github.com/repos/jihlein/dronin/branches{/branch}","tags_url":"https://api.github.com/repos/jihlein/dronin/tags","blobs_url":"https://api.github.com/repos/jihlein/dronin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihlein/dronin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihlein/dronin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihlein/dronin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihlein/dronin/statuses/{sha}","languages_url":"https://api.github.com/repos/jihlein/dronin/languages","stargazers_url":"https://api.github.com/repos/jihlein/dronin/stargazers","contributors_url":"https://api.github.com/repos/jihlein/dronin/contributors","subscribers_url":"https://api.github.com/repos/jihlein/dronin/subscribers","subscription_url":"https://api.github.com/repos/jihlein/dronin/subscription","commits_url":"https://api.github.com/repos/jihlein/dronin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihlein/dronin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihlein/dronin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihlein/dronin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihlein/dronin/contents/{+path}","compare_url":"https://api.github.com/repos/jihlein/dronin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihlein/dronin/merges","archive_url":"https://api.github.com/repos/jihlein/dronin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihlein/dronin/downloads","issues_url":"https://api.github.com/repos/jihlein/dronin/issues{/number}","pulls_url":"https://api.github.com/repos/jihlein/dronin/pulls{/number}","milestones_url":"https://api.github.com/repos/jihlein/dronin/milestones{/number}","notifications_url":"https://api.github.com/repos/jihlein/dronin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihlein/dronin/labels{/name}","releases_url":"https://api.github.com/repos/jihlein/dronin/releases{/id}","deployments_url":"https://api.github.com/repos/jihlein/dronin/deployments","created_at":"2015-10-04T03:24:50Z","updated_at":"2016-01-21T03:19:45Z","pushed_at":"2016-02-02T01:21:04Z","git_url":"git://github.com/jihlein/dronin.git","ssh_url":"git@github.com:jihlein/dronin.git","clone_url":"https://github.com/jihlein/dronin.git","svn_url":"https://github.com/jihlein/dronin","homepage":null,"size":222173,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"d-ronin:next","ref":"next","sha":"f9ad72bb24ba0575db7354e33f1e854028715d18","user":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"repo":{"id":43620723,"name":"dRonin","full_name":"d-ronin/dRonin","owner":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-ronin/dRonin","description":"The dRonin flight controller software.","fork":false,"url":"https://api.github.com/repos/d-ronin/dRonin","forks_url":"https://api.github.com/repos/d-ronin/dRonin/forks","keys_url":"https://api.github.com/repos/d-ronin/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-ronin/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-ronin/dRonin/teams","hooks_url":"https://api.github.com/repos/d-ronin/dRonin/hooks","issue_events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/d-ronin/dRonin/events","assignees_url":"https://api.github.com/repos/d-ronin/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/d-ronin/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/d-ronin/dRonin/tags","blobs_url":"https://api.github.com/repos/d-ronin/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-ronin/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-ronin/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-ronin/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/d-ronin/dRonin/languages","stargazers_url":"https://api.github.com/repos/d-ronin/dRonin/stargazers","contributors_url":"https://api.github.com/repos/d-ronin/dRonin/contributors","subscribers_url":"https://api.github.com/repos/d-ronin/dRonin/subscribers","subscription_url":"https://api.github.com/repos/d-ronin/dRonin/subscription","commits_url":"https://api.github.com/repos/d-ronin/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-ronin/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-ronin/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/d-ronin/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-ronin/dRonin/merges","archive_url":"https://api.github.com/repos/d-ronin/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-ronin/dRonin/downloads","issues_url":"https://api.github.com/repos/d-ronin/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/d-ronin/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/d-ronin/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/d-ronin/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-ronin/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/d-ronin/dRonin/releases{/id}","deployments_url":"https://api.github.com/repos/d-ronin/dRonin/deployments","created_at":"2015-10-04T01:13:04Z","updated_at":"2016-01-28T22:54:21Z","pushed_at":"2016-02-02T01:07:18Z","git_url":"git://github.com/d-ronin/dRonin.git","ssh_url":"git@github.com:d-ronin/dRonin.git","clone_url":"https://github.com/d-ronin/dRonin.git","svn_url":"https://github.com/d-ronin/dRonin","homepage":"http://dronin.org","size":219374,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":178,"forks":32,"open_issues":178,"watchers":42,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/589"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/589"},"issue":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/589"},"comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/d-ronin/dRonin/statuses/56eb09f7df13471a12c25b5ae0df6783d4c64a0b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":78,"deletions":57,"changed_files":8}}