{"action":"closed","number":416,"pull_request":{"url":"https://api.github.com/repos/pupil-labs/pupil/pulls/416","id":75725789,"html_url":"https://github.com/pupil-labs/pupil/pull/416","diff_url":"https://github.com/pupil-labs/pupil/pull/416.diff","patch_url":"https://github.com/pupil-labs/pupil/pull/416.patch","issue_url":"https://api.github.com/repos/pupil-labs/pupil/issues/416","number":416,"state":"closed","locked":false,"title":"Problem: Pupil Sync is too complex","user":{"login":"papr","id":168390,"avatar_url":"https://avatars.githubusercontent.com/u/168390?v=3","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false},"body":"Solution: Split discovery and time sync features into different plugins.\r\n\r\n- [x] Discovery implementation\r\n- [ ] Discovery UI\r\n- [ ] Time Sync implementation\r\n- [ ] Time Sync UI\r\n\r\n**`discovery.py` documentation:**\r\n- Creates `Pyre` node with following headers:\r\n    - \"pub_address\"\r\n    - \"sub_address\"\r\n    - \"app_type\"\r\n- Joins \"pupil-discovery\" group by default.\r\n- Shouts all notifications with the key \"discovery.shout\"\r\n    - Notifications will be serialized with msgpack\r\n- Whispers all notifications with the key \"discovery.whisper\"\r\n    - Notifications will be serialized with msgpack\r\n- Publishes all discovered notifications to the IPC backbone\r\n    - Drops notifications which cannot be unpacked with msgpack\r\n        or do not have \"subject\" key\r\n    - Adds \"discovery.peer\" key with dictionary containing information:\r\n        - \"uuid\": peer uuid\r\n        - \"name\": peer name\r\n        - \"arrival_timestamp\": time of arrival\r\n        - \"type\": \"SHOUT\" or \"WHISPER\"\r\n        - [\"group\": source group] if \"type\" equals \"SHOUT\"","created_at":"2016-06-29T21:35:02Z","updated_at":"2016-07-04T09:06:11Z","closed_at":"2016-07-04T09:06:11Z","merged_at":null,"merge_commit_sha":"68119eed0275f12cbf82aed76ce376ebd479ad28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/416/commits","review_comments_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/416/comments","review_comment_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pupil-labs/pupil/issues/416/comments","statuses_url":"https://api.github.com/repos/pupil-labs/pupil/statuses/44b9a65d191227e9f970fb9581f4ed132d1cfdbf","head":{"label":"papr:discovery","ref":"discovery","sha":"44b9a65d191227e9f970fb9581f4ed132d1cfdbf","user":{"login":"papr","id":168390,"avatar_url":"https://avatars.githubusercontent.com/u/168390?v=3","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false},"repo":{"id":49060521,"name":"pupil","full_name":"papr/pupil","owner":{"login":"papr","id":168390,"avatar_url":"https://avatars.githubusercontent.com/u/168390?v=3","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/papr/pupil","description":"Open source eye tracking ","fork":true,"url":"https://api.github.com/repos/papr/pupil","forks_url":"https://api.github.com/repos/papr/pupil/forks","keys_url":"https://api.github.com/repos/papr/pupil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papr/pupil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papr/pupil/teams","hooks_url":"https://api.github.com/repos/papr/pupil/hooks","issue_events_url":"https://api.github.com/repos/papr/pupil/issues/events{/number}","events_url":"https://api.github.com/repos/papr/pupil/events","assignees_url":"https://api.github.com/repos/papr/pupil/assignees{/user}","branches_url":"https://api.github.com/repos/papr/pupil/branches{/branch}","tags_url":"https://api.github.com/repos/papr/pupil/tags","blobs_url":"https://api.github.com/repos/papr/pupil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papr/pupil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papr/pupil/git/refs{/sha}","trees_url":"https://api.github.com/repos/papr/pupil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papr/pupil/statuses/{sha}","languages_url":"https://api.github.com/repos/papr/pupil/languages","stargazers_url":"https://api.github.com/repos/papr/pupil/stargazers","contributors_url":"https://api.github.com/repos/papr/pupil/contributors","subscribers_url":"https://api.github.com/repos/papr/pupil/subscribers","subscription_url":"https://api.github.com/repos/papr/pupil/subscription","commits_url":"https://api.github.com/repos/papr/pupil/commits{/sha}","git_commits_url":"https://api.github.com/repos/papr/pupil/git/commits{/sha}","comments_url":"https://api.github.com/repos/papr/pupil/comments{/number}","issue_comment_url":"https://api.github.com/repos/papr/pupil/issues/comments{/number}","contents_url":"https://api.github.com/repos/papr/pupil/contents/{+path}","compare_url":"https://api.github.com/repos/papr/pupil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papr/pupil/merges","archive_url":"https://api.github.com/repos/papr/pupil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papr/pupil/downloads","issues_url":"https://api.github.com/repos/papr/pupil/issues{/number}","pulls_url":"https://api.github.com/repos/papr/pupil/pulls{/number}","milestones_url":"https://api.github.com/repos/papr/pupil/milestones{/number}","notifications_url":"https://api.github.com/repos/papr/pupil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papr/pupil/labels{/name}","releases_url":"https://api.github.com/repos/papr/pupil/releases{/id}","deployments_url":"https://api.github.com/repos/papr/pupil/deployments","created_at":"2016-01-05T10:59:29Z","updated_at":"2016-02-04T18:05:15Z","pushed_at":"2016-07-04T09:06:11Z","git_url":"git://github.com/papr/pupil.git","ssh_url":"git@github.com:papr/pupil.git","clone_url":"https://github.com/papr/pupil.git","svn_url":"https://github.com/papr/pupil","homepage":"https://pupil-labs.com","size":9030,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pupil-labs:master","ref":"master","sha":"b2e1149320a7cfca8b0466d6762848a8a59b5d61","user":{"login":"pupil-labs","id":5248635,"avatar_url":"https://avatars.githubusercontent.com/u/5248635?v=3","gravatar_id":"","url":"https://api.github.com/users/pupil-labs","html_url":"https://github.com/pupil-labs","followers_url":"https://api.github.com/users/pupil-labs/followers","following_url":"https://api.github.com/users/pupil-labs/following{/other_user}","gists_url":"https://api.github.com/users/pupil-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/pupil-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pupil-labs/subscriptions","organizations_url":"https://api.github.com/users/pupil-labs/orgs","repos_url":"https://api.github.com/users/pupil-labs/repos","events_url":"https://api.github.com/users/pupil-labs/events{/privacy}","received_events_url":"https://api.github.com/users/pupil-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":12173486,"name":"pupil","full_name":"pupil-labs/pupil","owner":{"login":"pupil-labs","id":5248635,"avatar_url":"https://avatars.githubusercontent.com/u/5248635?v=3","gravatar_id":"","url":"https://api.github.com/users/pupil-labs","html_url":"https://github.com/pupil-labs","followers_url":"https://api.github.com/users/pupil-labs/followers","following_url":"https://api.github.com/users/pupil-labs/following{/other_user}","gists_url":"https://api.github.com/users/pupil-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/pupil-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pupil-labs/subscriptions","organizations_url":"https://api.github.com/users/pupil-labs/orgs","repos_url":"https://api.github.com/users/pupil-labs/repos","events_url":"https://api.github.com/users/pupil-labs/events{/privacy}","received_events_url":"https://api.github.com/users/pupil-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pupil-labs/pupil","description":"Open source eye tracking ","fork":false,"url":"https://api.github.com/repos/pupil-labs/pupil","forks_url":"https://api.github.com/repos/pupil-labs/pupil/forks","keys_url":"https://api.github.com/repos/pupil-labs/pupil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pupil-labs/pupil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pupil-labs/pupil/teams","hooks_url":"https://api.github.com/repos/pupil-labs/pupil/hooks","issue_events_url":"https://api.github.com/repos/pupil-labs/pupil/issues/events{/number}","events_url":"https://api.github.com/repos/pupil-labs/pupil/events","assignees_url":"https://api.github.com/repos/pupil-labs/pupil/assignees{/user}","branches_url":"https://api.github.com/repos/pupil-labs/pupil/branches{/branch}","tags_url":"https://api.github.com/repos/pupil-labs/pupil/tags","blobs_url":"https://api.github.com/repos/pupil-labs/pupil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pupil-labs/pupil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pupil-labs/pupil/git/refs{/sha}","trees_url":"https://api.github.com/repos/pupil-labs/pupil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pupil-labs/pupil/statuses/{sha}","languages_url":"https://api.github.com/repos/pupil-labs/pupil/languages","stargazers_url":"https://api.github.com/repos/pupil-labs/pupil/stargazers","contributors_url":"https://api.github.com/repos/pupil-labs/pupil/contributors","subscribers_url":"https://api.github.com/repos/pupil-labs/pupil/subscribers","subscription_url":"https://api.github.com/repos/pupil-labs/pupil/subscription","commits_url":"https://api.github.com/repos/pupil-labs/pupil/commits{/sha}","git_commits_url":"https://api.github.com/repos/pupil-labs/pupil/git/commits{/sha}","comments_url":"https://api.github.com/repos/pupil-labs/pupil/comments{/number}","issue_comment_url":"https://api.github.com/repos/pupil-labs/pupil/issues/comments{/number}","contents_url":"https://api.github.com/repos/pupil-labs/pupil/contents/{+path}","compare_url":"https://api.github.com/repos/pupil-labs/pupil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pupil-labs/pupil/merges","archive_url":"https://api.github.com/repos/pupil-labs/pupil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pupil-labs/pupil/downloads","issues_url":"https://api.github.com/repos/pupil-labs/pupil/issues{/number}","pulls_url":"https://api.github.com/repos/pupil-labs/pupil/pulls{/number}","milestones_url":"https://api.github.com/repos/pupil-labs/pupil/milestones{/number}","notifications_url":"https://api.github.com/repos/pupil-labs/pupil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pupil-labs/pupil/labels{/name}","releases_url":"https://api.github.com/repos/pupil-labs/pupil/releases{/id}","deployments_url":"https://api.github.com/repos/pupil-labs/pupil/deployments","created_at":"2013-08-17T04:40:25Z","updated_at":"2016-07-04T08:29:13Z","pushed_at":"2016-07-04T08:46:14Z","git_url":"git://github.com/pupil-labs/pupil.git","ssh_url":"git@github.com:pupil-labs/pupil.git","clone_url":"https://github.com/pupil-labs/pupil.git","svn_url":"https://github.com/pupil-labs/pupil","homepage":"https://pupil-labs.com","size":11608,"stargazers_count":187,"watchers_count":187,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":63,"forks":170,"open_issues":63,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/416"},"html":{"href":"https://github.com/pupil-labs/pupil/pull/416"},"issue":{"href":"https://api.github.com/repos/pupil-labs/pupil/issues/416"},"comments":{"href":"https://api.github.com/repos/pupil-labs/pupil/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/pupil-labs/pupil/statuses/44b9a65d191227e9f970fb9581f4ed132d1cfdbf"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":352,"deletions":111,"changed_files":10}}
{"actor":{"display_login":"papr"}}