{"action":"closed","number":208,"pull_request":{"url":"https://api.github.com/repos/tildeio/glimmer/pulls/208","id":76085788,"html_url":"https://github.com/tildeio/glimmer/pull/208","diff_url":"https://github.com/tildeio/glimmer/pull/208.diff","patch_url":"https://github.com/tildeio/glimmer/pull/208.patch","issue_url":"https://api.github.com/repos/tildeio/glimmer/issues/208","number":208,"state":"closed","locked":false,"title":"remove out of date comments","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"body":"These comments are our of date so I've removed them. I've also removed the function params and return statement docs as they are also out of date, this code is internal and the functions are self explanatory.\r\n\r\nI reordered the three compile functions from higher to lower level:\r\n\r\n 1. `compile`\r\n 2. `compileLayout`\r\n 3. `compileRealSpec`\r\n\r\nI also removed the `export function template` which doesn't seem to be used anywhere and inlined the `JSON.parse`","created_at":"2016-07-03T10:26:38Z","updated_at":"2016-07-07T21:07:08Z","closed_at":"2016-07-07T21:07:08Z","merged_at":"2016-07-07T21:07:08Z","merge_commit_sha":"8212ffd77f9395386f39f3b17328b0eeb69899d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tildeio/glimmer/pulls/208/commits","review_comments_url":"https://api.github.com/repos/tildeio/glimmer/pulls/208/comments","review_comment_url":"https://api.github.com/repos/tildeio/glimmer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tildeio/glimmer/issues/208/comments","statuses_url":"https://api.github.com/repos/tildeio/glimmer/statuses/12ca3c7aab8f4b71bed5a36b6813948e43825e94","head":{"label":"GavinJoyce:gj/remove-invalid-comments","ref":"gj/remove-invalid-comments","sha":"12ca3c7aab8f4b71bed5a36b6813948e43825e94","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"repo":{"id":49984504,"name":"glimmer","full_name":"GavinJoyce/glimmer","owner":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GavinJoyce/glimmer","description":"","fork":true,"url":"https://api.github.com/repos/GavinJoyce/glimmer","forks_url":"https://api.github.com/repos/GavinJoyce/glimmer/forks","keys_url":"https://api.github.com/repos/GavinJoyce/glimmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GavinJoyce/glimmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GavinJoyce/glimmer/teams","hooks_url":"https://api.github.com/repos/GavinJoyce/glimmer/hooks","issue_events_url":"https://api.github.com/repos/GavinJoyce/glimmer/issues/events{/number}","events_url":"https://api.github.com/repos/GavinJoyce/glimmer/events","assignees_url":"https://api.github.com/repos/GavinJoyce/glimmer/assignees{/user}","branches_url":"https://api.github.com/repos/GavinJoyce/glimmer/branches{/branch}","tags_url":"https://api.github.com/repos/GavinJoyce/glimmer/tags","blobs_url":"https://api.github.com/repos/GavinJoyce/glimmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GavinJoyce/glimmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GavinJoyce/glimmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GavinJoyce/glimmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GavinJoyce/glimmer/statuses/{sha}","languages_url":"https://api.github.com/repos/GavinJoyce/glimmer/languages","stargazers_url":"https://api.github.com/repos/GavinJoyce/glimmer/stargazers","contributors_url":"https://api.github.com/repos/GavinJoyce/glimmer/contributors","subscribers_url":"https://api.github.com/repos/GavinJoyce/glimmer/subscribers","subscription_url":"https://api.github.com/repos/GavinJoyce/glimmer/subscription","commits_url":"https://api.github.com/repos/GavinJoyce/glimmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GavinJoyce/glimmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GavinJoyce/glimmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GavinJoyce/glimmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GavinJoyce/glimmer/contents/{+path}","compare_url":"https://api.github.com/repos/GavinJoyce/glimmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GavinJoyce/glimmer/merges","archive_url":"https://api.github.com/repos/GavinJoyce/glimmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GavinJoyce/glimmer/downloads","issues_url":"https://api.github.com/repos/GavinJoyce/glimmer/issues{/number}","pulls_url":"https://api.github.com/repos/GavinJoyce/glimmer/pulls{/number}","milestones_url":"https://api.github.com/repos/GavinJoyce/glimmer/milestones{/number}","notifications_url":"https://api.github.com/repos/GavinJoyce/glimmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GavinJoyce/glimmer/labels{/name}","releases_url":"https://api.github.com/repos/GavinJoyce/glimmer/releases{/id}","deployments_url":"https://api.github.com/repos/GavinJoyce/glimmer/deployments","created_at":"2016-01-19T21:30:42Z","updated_at":"2016-02-07T23:04:33Z","pushed_at":"2016-07-07T19:50:50Z","git_url":"git://github.com/GavinJoyce/glimmer.git","ssh_url":"git@github.com:GavinJoyce/glimmer.git","clone_url":"https://github.com/GavinJoyce/glimmer.git","svn_url":"https://github.com/GavinJoyce/glimmer","homepage":null,"size":3335,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tildeio:master","ref":"master","sha":"e9f3158d6510372def52d03d2ff18620b05f4d2b","user":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"repo":{"id":42467001,"name":"glimmer","full_name":"tildeio/glimmer","owner":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tildeio/glimmer","description":"","fork":false,"url":"https://api.github.com/repos/tildeio/glimmer","forks_url":"https://api.github.com/repos/tildeio/glimmer/forks","keys_url":"https://api.github.com/repos/tildeio/glimmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tildeio/glimmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tildeio/glimmer/teams","hooks_url":"https://api.github.com/repos/tildeio/glimmer/hooks","issue_events_url":"https://api.github.com/repos/tildeio/glimmer/issues/events{/number}","events_url":"https://api.github.com/repos/tildeio/glimmer/events","assignees_url":"https://api.github.com/repos/tildeio/glimmer/assignees{/user}","branches_url":"https://api.github.com/repos/tildeio/glimmer/branches{/branch}","tags_url":"https://api.github.com/repos/tildeio/glimmer/tags","blobs_url":"https://api.github.com/repos/tildeio/glimmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tildeio/glimmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tildeio/glimmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tildeio/glimmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tildeio/glimmer/statuses/{sha}","languages_url":"https://api.github.com/repos/tildeio/glimmer/languages","stargazers_url":"https://api.github.com/repos/tildeio/glimmer/stargazers","contributors_url":"https://api.github.com/repos/tildeio/glimmer/contributors","subscribers_url":"https://api.github.com/repos/tildeio/glimmer/subscribers","subscription_url":"https://api.github.com/repos/tildeio/glimmer/subscription","commits_url":"https://api.github.com/repos/tildeio/glimmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tildeio/glimmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tildeio/glimmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tildeio/glimmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tildeio/glimmer/contents/{+path}","compare_url":"https://api.github.com/repos/tildeio/glimmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tildeio/glimmer/merges","archive_url":"https://api.github.com/repos/tildeio/glimmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tildeio/glimmer/downloads","issues_url":"https://api.github.com/repos/tildeio/glimmer/issues{/number}","pulls_url":"https://api.github.com/repos/tildeio/glimmer/pulls{/number}","milestones_url":"https://api.github.com/repos/tildeio/glimmer/milestones{/number}","notifications_url":"https://api.github.com/repos/tildeio/glimmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tildeio/glimmer/labels{/name}","releases_url":"https://api.github.com/repos/tildeio/glimmer/releases{/id}","deployments_url":"https://api.github.com/repos/tildeio/glimmer/deployments","created_at":"2015-09-14T17:59:26Z","updated_at":"2016-07-07T19:35:07Z","pushed_at":"2016-07-07T21:07:08Z","git_url":"git://github.com/tildeio/glimmer.git","ssh_url":"git@github.com:tildeio/glimmer.git","clone_url":"https://github.com/tildeio/glimmer.git","svn_url":"https://github.com/tildeio/glimmer","homepage":null,"size":3541,"stargazers_count":220,"watchers_count":220,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":30,"forks":35,"open_issues":30,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/208"},"html":{"href":"https://github.com/tildeio/glimmer/pull/208"},"issue":{"href":"https://api.github.com/repos/tildeio/glimmer/issues/208"},"comments":{"href":"https://api.github.com/repos/tildeio/glimmer/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/tildeio/glimmer/statuses/12ca3c7aab8f4b71bed5a36b6813948e43825e94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":4,"deletions":40,"changed_files":1}}
{"actor":{"display_login":"chancancode"}}