{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/8366","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/8366/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8366/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/8366/events","html_url":"https://github.com/openshift/origin/pull/8366","id":146166553,"number":8366,"title":"Add basic validation for route TLS configuration - checks that input is \"syntactically\" valid.","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":27,"created_at":"2016-04-06T02:19:34Z","updated_at":"2016-04-21T15:49:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8366","html_url":"https://github.com/openshift/origin/pull/8366","diff_url":"https://github.com/openshift/origin/pull/8366.diff","patch_url":"https://github.com/openshift/origin/pull/8366.patch"},"body":"Partial Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1312292  \r\n\r\n@smarterclayton PTAL Thx\r\n\r\nThe other PR https://github.com/openshift/origin/pull/8353 would be needed in addition to this for a complete fix but this one provides a partial fix to check input is valid PEM format.\r\n\r\n```  \r\n# make release  || echo \"run make, copy binary and build new docker image\"  \r\noadm router --latest-images  --replicas=0  \r\noc env dc/router EXTENDED_VALIDATION=true  \r\noc scale  dc/router --replicas=1  \r\n```  \r\n*Updated*  with testing instructions/usage."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/212981946","html_url":"https://github.com/openshift/origin/pull/8366#issuecomment-212981946","issue_url":"https://api.github.com/repos/openshift/origin/issues/8366","id":212981946,"user":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars.githubusercontent.com/u/10033853?v=3","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T15:49:36Z","updated_at":"2016-04-21T15:49:36Z","body":"For Online Beta they are disabling custom hostnames, so that means that we don't need to allow custom certs.  We need to work out how ops can disable certs (perhaps by deploying a custom router).\r\n\r\nWe also need to get this patch landed for GA."}}