{"action":"closed","number":8488,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/8488","id":64685569,"html_url":"https://github.com/mrdoob/three.js/pull/8488","diff_url":"https://github.com/mrdoob/three.js/pull/8488.diff","patch_url":"https://github.com/mrdoob/three.js/pull/8488.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8488","number":8488,"state":"closed","locked":false,"title":"webgl_terrain_dynamic: bugfixing and simplification","user":{"login":"Mugen87","id":12612165,"avatar_url":"https://avatars.githubusercontent.com/u/12612165?v=3","gravatar_id":"","url":"https://api.github.com/users/Mugen87","html_url":"https://github.com/Mugen87","followers_url":"https://api.github.com/users/Mugen87/followers","following_url":"https://api.github.com/users/Mugen87/following{/other_user}","gists_url":"https://api.github.com/users/Mugen87/gists{/gist_id}","starred_url":"https://api.github.com/users/Mugen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mugen87/subscriptions","organizations_url":"https://api.github.com/users/Mugen87/orgs","repos_url":"https://api.github.com/users/Mugen87/repos","events_url":"https://api.github.com/users/Mugen87/events{/privacy}","received_events_url":"https://api.github.com/users/Mugen87/received_events","type":"User","site_admin":false},"body":"This PR fixes two runtime errors in `examples/js/ShaderTerrain.js` and simplifies the example `examples/webgl_terrain_dynamic.html`(see #8405).\r\n\r\nUnfortunately i had no time so far to refactor the lighting shader code in `examples/js/ShaderTerrain.js `. I've planned to use the shader chunk `lights_template.glsl` to replace some of the old code. Is it okay to implement this in a separate PR?","created_at":"2016-03-30T19:46:59Z","updated_at":"2016-03-30T20:04:43Z","closed_at":"2016-03-30T20:04:42Z","merged_at":"2016-03-30T20:04:42Z","merge_commit_sha":"12312b12fbfa652a2776fabdadf0633324f88672","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8488/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8488/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8488/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/76ab8e8e82a41b096aeee7c063bf3eb8055cd2a5","head":{"label":"Mugen87:dev","ref":"dev","sha":"76ab8e8e82a41b096aeee7c063bf3eb8055cd2a5","user":{"login":"Mugen87","id":12612165,"avatar_url":"https://avatars.githubusercontent.com/u/12612165?v=3","gravatar_id":"","url":"https://api.github.com/users/Mugen87","html_url":"https://github.com/Mugen87","followers_url":"https://api.github.com/users/Mugen87/followers","following_url":"https://api.github.com/users/Mugen87/following{/other_user}","gists_url":"https://api.github.com/users/Mugen87/gists{/gist_id}","starred_url":"https://api.github.com/users/Mugen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mugen87/subscriptions","organizations_url":"https://api.github.com/users/Mugen87/orgs","repos_url":"https://api.github.com/users/Mugen87/repos","events_url":"https://api.github.com/users/Mugen87/events{/privacy}","received_events_url":"https://api.github.com/users/Mugen87/received_events","type":"User","site_admin":false},"repo":{"id":44012154,"name":"three.js","full_name":"Mugen87/three.js","owner":{"login":"Mugen87","id":12612165,"avatar_url":"https://avatars.githubusercontent.com/u/12612165?v=3","gravatar_id":"","url":"https://api.github.com/users/Mugen87","html_url":"https://github.com/Mugen87","followers_url":"https://api.github.com/users/Mugen87/followers","following_url":"https://api.github.com/users/Mugen87/following{/other_user}","gists_url":"https://api.github.com/users/Mugen87/gists{/gist_id}","starred_url":"https://api.github.com/users/Mugen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mugen87/subscriptions","organizations_url":"https://api.github.com/users/Mugen87/orgs","repos_url":"https://api.github.com/users/Mugen87/repos","events_url":"https://api.github.com/users/Mugen87/events{/privacy}","received_events_url":"https://api.github.com/users/Mugen87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mugen87/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/Mugen87/three.js","forks_url":"https://api.github.com/repos/Mugen87/three.js/forks","keys_url":"https://api.github.com/repos/Mugen87/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mugen87/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mugen87/three.js/teams","hooks_url":"https://api.github.com/repos/Mugen87/three.js/hooks","issue_events_url":"https://api.github.com/repos/Mugen87/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/Mugen87/three.js/events","assignees_url":"https://api.github.com/repos/Mugen87/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/Mugen87/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/Mugen87/three.js/tags","blobs_url":"https://api.github.com/repos/Mugen87/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mugen87/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mugen87/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mugen87/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mugen87/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Mugen87/three.js/languages","stargazers_url":"https://api.github.com/repos/Mugen87/three.js/stargazers","contributors_url":"https://api.github.com/repos/Mugen87/three.js/contributors","subscribers_url":"https://api.github.com/repos/Mugen87/three.js/subscribers","subscription_url":"https://api.github.com/repos/Mugen87/three.js/subscription","commits_url":"https://api.github.com/repos/Mugen87/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mugen87/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mugen87/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mugen87/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mugen87/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/Mugen87/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mugen87/three.js/merges","archive_url":"https://api.github.com/repos/Mugen87/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mugen87/three.js/downloads","issues_url":"https://api.github.com/repos/Mugen87/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/Mugen87/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Mugen87/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Mugen87/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mugen87/three.js/labels{/name}","releases_url":"https://api.github.com/repos/Mugen87/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/Mugen87/three.js/deployments","created_at":"2015-10-10T13:41:49Z","updated_at":"2016-02-10T19:36:47Z","pushed_at":"2016-03-30T19:31:55Z","git_url":"git://github.com/Mugen87/three.js.git","ssh_url":"git@github.com:Mugen87/three.js.git","clone_url":"https://github.com/Mugen87/three.js.git","svn_url":"https://github.com/Mugen87/three.js","homepage":"http://threejs.org/","size":372657,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"7e4ad58a3f0a146d9f26e7c7ca9ffea990d0ac48","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-03-30T17:38:18Z","pushed_at":"2016-03-30T20:04:42Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":571410,"stargazers_count":24053,"watchers_count":24053,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":7779,"mirror_url":null,"open_issues_count":611,"forks":7779,"open_issues":611,"watchers":24053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8488"},"html":{"href":"https://github.com/mrdoob/three.js/pull/8488"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8488"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8488/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8488/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8488/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/76ab8e8e82a41b096aeee7c063bf3eb8055cd2a5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":44,"deletions":221,"changed_files":2}}