{"action":"created","comment":{"url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/comments/70604697","id":70604697,"diff_hunk":"@@ -18,7 +18,14 @@\n     };\n \n     KeyEvent.prototype.toNative = function() {\n-        var event = document.createEventObject ? document.createEventObject() : document.createEvent('Events');\n+        var event;\n+\n+        // Events created with createEventObject() in IE 10 don't work with setting properties like `which`, etc.\n+        if (/*@cc_on!@*/false && document.documentMode === 10) {","path":"tests/libs/key-event.js","position":8,"original_position":8,"commit_id":"28af327f6c3d6258a309a0411790e79dd99d8d26","original_commit_id":"28af327f6c3d6258a309a0411790e79dd99d8d26","user":{"login":"lepolt","id":669410,"avatar_url":"https://avatars.githubusercontent.com/u/669410?v=3","gravatar_id":"","url":"https://api.github.com/users/lepolt","html_url":"https://github.com/lepolt","followers_url":"https://api.github.com/users/lepolt/followers","following_url":"https://api.github.com/users/lepolt/following{/other_user}","gists_url":"https://api.github.com/users/lepolt/gists{/gist_id}","starred_url":"https://api.github.com/users/lepolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepolt/subscriptions","organizations_url":"https://api.github.com/users/lepolt/orgs","repos_url":"https://api.github.com/users/lepolt/repos","events_url":"https://api.github.com/users/lepolt/events{/privacy}","received_events_url":"https://api.github.com/users/lepolt/received_events","type":"User","site_admin":false},"body":"It executes in IE\r\nhttps://stackoverflow.com/questions/24473882/what-does-this-comment-cc-on-0-do-inside-an-if-statement-in-javascript/24473897#24473897","created_at":"2016-07-13T10:58:37Z","updated_at":"2016-07-13T10:58:37Z","html_url":"https://github.com/ccampbell/mousetrap/pull/339#discussion_r70604697","pull_request_url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/comments/70604697"},"html":{"href":"https://github.com/ccampbell/mousetrap/pull/339#discussion_r70604697"},"pull_request":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339","id":66922232,"html_url":"https://github.com/ccampbell/mousetrap/pull/339","diff_url":"https://github.com/ccampbell/mousetrap/pull/339.diff","patch_url":"https://github.com/ccampbell/mousetrap/pull/339.patch","issue_url":"https://api.github.com/repos/ccampbell/mousetrap/issues/339","number":339,"state":"open","locked":false,"title":"Fix issue with key events not firing in IE10","user":{"login":"lepolt","id":669410,"avatar_url":"https://avatars.githubusercontent.com/u/669410?v=3","gravatar_id":"","url":"https://api.github.com/users/lepolt","html_url":"https://github.com/lepolt","followers_url":"https://api.github.com/users/lepolt/followers","following_url":"https://api.github.com/users/lepolt/following{/other_user}","gists_url":"https://api.github.com/users/lepolt/gists{/gist_id}","starred_url":"https://api.github.com/users/lepolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepolt/subscriptions","organizations_url":"https://api.github.com/users/lepolt/orgs","repos_url":"https://api.github.com/users/lepolt/repos","events_url":"https://api.github.com/users/lepolt/events{/privacy}","received_events_url":"https://api.github.com/users/lepolt/received_events","type":"User","site_admin":false},"body":"Fixes #279. The events created appear to be read only, so setting properties like `which` and `keyCode`, etc. didn't have any effect on the events that were dispatched. ","created_at":"2016-04-18T21:07:48Z","updated_at":"2016-07-13T10:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48842acd016a6f7c61f00cd5db7745f4c0a1de25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339/commits","review_comments_url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339/comments","review_comment_url":"https://api.github.com/repos/ccampbell/mousetrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccampbell/mousetrap/issues/339/comments","statuses_url":"https://api.github.com/repos/ccampbell/mousetrap/statuses/28af327f6c3d6258a309a0411790e79dd99d8d26","head":{"label":"Batterii:ie10-key-event-fix","ref":"ie10-key-event-fix","sha":"28af327f6c3d6258a309a0411790e79dd99d8d26","user":{"login":"Batterii","id":1659601,"avatar_url":"https://avatars.githubusercontent.com/u/1659601?v=3","gravatar_id":"","url":"https://api.github.com/users/Batterii","html_url":"https://github.com/Batterii","followers_url":"https://api.github.com/users/Batterii/followers","following_url":"https://api.github.com/users/Batterii/following{/other_user}","gists_url":"https://api.github.com/users/Batterii/gists{/gist_id}","starred_url":"https://api.github.com/users/Batterii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Batterii/subscriptions","organizations_url":"https://api.github.com/users/Batterii/orgs","repos_url":"https://api.github.com/users/Batterii/repos","events_url":"https://api.github.com/users/Batterii/events{/privacy}","received_events_url":"https://api.github.com/users/Batterii/received_events","type":"Organization","site_admin":false},"repo":{"id":56541825,"name":"mousetrap","full_name":"Batterii/mousetrap","owner":{"login":"Batterii","id":1659601,"avatar_url":"https://avatars.githubusercontent.com/u/1659601?v=3","gravatar_id":"","url":"https://api.github.com/users/Batterii","html_url":"https://github.com/Batterii","followers_url":"https://api.github.com/users/Batterii/followers","following_url":"https://api.github.com/users/Batterii/following{/other_user}","gists_url":"https://api.github.com/users/Batterii/gists{/gist_id}","starred_url":"https://api.github.com/users/Batterii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Batterii/subscriptions","organizations_url":"https://api.github.com/users/Batterii/orgs","repos_url":"https://api.github.com/users/Batterii/repos","events_url":"https://api.github.com/users/Batterii/events{/privacy}","received_events_url":"https://api.github.com/users/Batterii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Batterii/mousetrap","description":"Simple library for handling keyboard shortcuts in Javascript","fork":true,"url":"https://api.github.com/repos/Batterii/mousetrap","forks_url":"https://api.github.com/repos/Batterii/mousetrap/forks","keys_url":"https://api.github.com/repos/Batterii/mousetrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Batterii/mousetrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Batterii/mousetrap/teams","hooks_url":"https://api.github.com/repos/Batterii/mousetrap/hooks","issue_events_url":"https://api.github.com/repos/Batterii/mousetrap/issues/events{/number}","events_url":"https://api.github.com/repos/Batterii/mousetrap/events","assignees_url":"https://api.github.com/repos/Batterii/mousetrap/assignees{/user}","branches_url":"https://api.github.com/repos/Batterii/mousetrap/branches{/branch}","tags_url":"https://api.github.com/repos/Batterii/mousetrap/tags","blobs_url":"https://api.github.com/repos/Batterii/mousetrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Batterii/mousetrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Batterii/mousetrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Batterii/mousetrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Batterii/mousetrap/statuses/{sha}","languages_url":"https://api.github.com/repos/Batterii/mousetrap/languages","stargazers_url":"https://api.github.com/repos/Batterii/mousetrap/stargazers","contributors_url":"https://api.github.com/repos/Batterii/mousetrap/contributors","subscribers_url":"https://api.github.com/repos/Batterii/mousetrap/subscribers","subscription_url":"https://api.github.com/repos/Batterii/mousetrap/subscription","commits_url":"https://api.github.com/repos/Batterii/mousetrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Batterii/mousetrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Batterii/mousetrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Batterii/mousetrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Batterii/mousetrap/contents/{+path}","compare_url":"https://api.github.com/repos/Batterii/mousetrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Batterii/mousetrap/merges","archive_url":"https://api.github.com/repos/Batterii/mousetrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Batterii/mousetrap/downloads","issues_url":"https://api.github.com/repos/Batterii/mousetrap/issues{/number}","pulls_url":"https://api.github.com/repos/Batterii/mousetrap/pulls{/number}","milestones_url":"https://api.github.com/repos/Batterii/mousetrap/milestones{/number}","notifications_url":"https://api.github.com/repos/Batterii/mousetrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Batterii/mousetrap/labels{/name}","releases_url":"https://api.github.com/repos/Batterii/mousetrap/releases{/id}","deployments_url":"https://api.github.com/repos/Batterii/mousetrap/deployments","created_at":"2016-04-18T21:01:22Z","updated_at":"2016-04-18T21:01:23Z","pushed_at":"2016-04-18T21:05:24Z","git_url":"git://github.com/Batterii/mousetrap.git","ssh_url":"git@github.com:Batterii/mousetrap.git","clone_url":"https://github.com/Batterii/mousetrap.git","svn_url":"https://github.com/Batterii/mousetrap","homepage":"https://craig.is/killing/mice","size":351,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ccampbell:master","ref":"master","sha":"ab4327c82b1b2e38b1d8ac5576f32a49e4441ea3","user":{"login":"ccampbell","id":259316,"avatar_url":"https://avatars.githubusercontent.com/u/259316?v=3","gravatar_id":"","url":"https://api.github.com/users/ccampbell","html_url":"https://github.com/ccampbell","followers_url":"https://api.github.com/users/ccampbell/followers","following_url":"https://api.github.com/users/ccampbell/following{/other_user}","gists_url":"https://api.github.com/users/ccampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/ccampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccampbell/subscriptions","organizations_url":"https://api.github.com/users/ccampbell/orgs","repos_url":"https://api.github.com/users/ccampbell/repos","events_url":"https://api.github.com/users/ccampbell/events{/privacy}","received_events_url":"https://api.github.com/users/ccampbell/received_events","type":"User","site_admin":false},"repo":{"id":4897046,"name":"mousetrap","full_name":"ccampbell/mousetrap","owner":{"login":"ccampbell","id":259316,"avatar_url":"https://avatars.githubusercontent.com/u/259316?v=3","gravatar_id":"","url":"https://api.github.com/users/ccampbell","html_url":"https://github.com/ccampbell","followers_url":"https://api.github.com/users/ccampbell/followers","following_url":"https://api.github.com/users/ccampbell/following{/other_user}","gists_url":"https://api.github.com/users/ccampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/ccampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccampbell/subscriptions","organizations_url":"https://api.github.com/users/ccampbell/orgs","repos_url":"https://api.github.com/users/ccampbell/repos","events_url":"https://api.github.com/users/ccampbell/events{/privacy}","received_events_url":"https://api.github.com/users/ccampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccampbell/mousetrap","description":"Simple library for handling keyboard shortcuts in Javascript","fork":false,"url":"https://api.github.com/repos/ccampbell/mousetrap","forks_url":"https://api.github.com/repos/ccampbell/mousetrap/forks","keys_url":"https://api.github.com/repos/ccampbell/mousetrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccampbell/mousetrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccampbell/mousetrap/teams","hooks_url":"https://api.github.com/repos/ccampbell/mousetrap/hooks","issue_events_url":"https://api.github.com/repos/ccampbell/mousetrap/issues/events{/number}","events_url":"https://api.github.com/repos/ccampbell/mousetrap/events","assignees_url":"https://api.github.com/repos/ccampbell/mousetrap/assignees{/user}","branches_url":"https://api.github.com/repos/ccampbell/mousetrap/branches{/branch}","tags_url":"https://api.github.com/repos/ccampbell/mousetrap/tags","blobs_url":"https://api.github.com/repos/ccampbell/mousetrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccampbell/mousetrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccampbell/mousetrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccampbell/mousetrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccampbell/mousetrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ccampbell/mousetrap/languages","stargazers_url":"https://api.github.com/repos/ccampbell/mousetrap/stargazers","contributors_url":"https://api.github.com/repos/ccampbell/mousetrap/contributors","subscribers_url":"https://api.github.com/repos/ccampbell/mousetrap/subscribers","subscription_url":"https://api.github.com/repos/ccampbell/mousetrap/subscription","commits_url":"https://api.github.com/repos/ccampbell/mousetrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccampbell/mousetrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccampbell/mousetrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccampbell/mousetrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccampbell/mousetrap/contents/{+path}","compare_url":"https://api.github.com/repos/ccampbell/mousetrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccampbell/mousetrap/merges","archive_url":"https://api.github.com/repos/ccampbell/mousetrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccampbell/mousetrap/downloads","issues_url":"https://api.github.com/repos/ccampbell/mousetrap/issues{/number}","pulls_url":"https://api.github.com/repos/ccampbell/mousetrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ccampbell/mousetrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ccampbell/mousetrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccampbell/mousetrap/labels{/name}","releases_url":"https://api.github.com/repos/ccampbell/mousetrap/releases{/id}","deployments_url":"https://api.github.com/repos/ccampbell/mousetrap/deployments","created_at":"2012-07-05T03:13:55Z","updated_at":"2016-07-13T10:19:05Z","pushed_at":"2016-07-13T10:06:45Z","git_url":"git://github.com/ccampbell/mousetrap.git","ssh_url":"git@github.com:ccampbell/mousetrap.git","clone_url":"https://github.com/ccampbell/mousetrap.git","svn_url":"https://github.com/ccampbell/mousetrap","homepage":"https://craig.is/killing/mice","size":943,"stargazers_count":7051,"watchers_count":7051,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":635,"mirror_url":null,"open_issues_count":146,"forks":635,"open_issues":146,"watchers":7051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339"},"html":{"href":"https://github.com/ccampbell/mousetrap/pull/339"},"issue":{"href":"https://api.github.com/repos/ccampbell/mousetrap/issues/339"},"comments":{"href":"https://api.github.com/repos/ccampbell/mousetrap/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccampbell/mousetrap/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/ccampbell/mousetrap/statuses/28af327f6c3d6258a309a0411790e79dd99d8d26"}}}}
{"actor":{"display_login":"lepolt"}}