{"action":"created","issue":{"url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/716","repository_url":"https://api.github.com/repos/Vauxoo/addons-vauxoo","labels_url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/716/labels{/name}","comments_url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/716/comments","events_url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/716/events","html_url":"https://github.com/Vauxoo/addons-vauxoo/issues/716","id":131375360,"number":716,"title":"[8.0] product_do_merge: Code lines need to be review.","user":{"login":"zaoral","id":7593953,"avatar_url":"https://avatars.githubusercontent.com/u/7593953?v=3","gravatar_id":"","url":"https://api.github.com/users/zaoral","html_url":"https://github.com/zaoral","followers_url":"https://api.github.com/users/zaoral/followers","following_url":"https://api.github.com/users/zaoral/following{/other_user}","gists_url":"https://api.github.com/users/zaoral/gists{/gist_id}","starred_url":"https://api.github.com/users/zaoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaoral/subscriptions","organizations_url":"https://api.github.com/users/zaoral/orgs","repos_url":"https://api.github.com/users/zaoral/repos","events_url":"https://api.github.com/users/zaoral/events{/privacy}","received_events_url":"https://api.github.com/users/zaoral/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-04T15:05:38Z","updated_at":"2016-02-04T15:41:54Z","closed_at":null,"body":"Review product_do_merge module.\r\nHad some lines that need to be reviewed.\r\n\r\n```python\r\n    def merge_cb(self, cr, uid, ids, context=None):\r\n        ...\r\n        this = self.browse(cr, uid, ids[0], context=context)\r\n        p_ids = this.product_ids and this.product_ids\r\n        p_ids and p_ids.append(this.product_to)\r\n        ...\r\n```\r\noriginal file [here](https://github.com/Vauxoo/addons-vauxoo/blob/8.0/product_do_merge/wizard/base_product_merge.py#L530-L531)\r\n\r\nFirst. what impact has this line `p_ids = this.product_ids and this.product_ids`? If has not we can removed?\r\n\r\nSecond, this line generate and error because p_ids is a recorset not a list `p_ids and p_ids.append(this.product_to)`. We could replace it for a `new_set = set1 | set2` that is the convention for union of two sets.\r\n\r\n@dsabrinarg @moylop260  I look that you work in this module.\r\nPlease can contribute with the evaluation of this lines so I will be able to do the fix.\r\n\r\nIf, this module is not used or deprecated, then we could delete it.\r\nBest Regards.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/comments/179906115","html_url":"https://github.com/Vauxoo/addons-vauxoo/issues/716#issuecomment-179906115","issue_url":"https://api.github.com/repos/Vauxoo/addons-vauxoo/issues/716","id":179906115,"user":{"login":"zaoral","id":7593953,"avatar_url":"https://avatars.githubusercontent.com/u/7593953?v=3","gravatar_id":"","url":"https://api.github.com/users/zaoral","html_url":"https://github.com/zaoral","followers_url":"https://api.github.com/users/zaoral/followers","following_url":"https://api.github.com/users/zaoral/following{/other_user}","gists_url":"https://api.github.com/users/zaoral/gists{/gist_id}","starred_url":"https://api.github.com/users/zaoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaoral/subscriptions","organizations_url":"https://api.github.com/users/zaoral/orgs","repos_url":"https://api.github.com/users/zaoral/repos","events_url":"https://api.github.com/users/zaoral/events{/privacy}","received_events_url":"https://api.github.com/users/zaoral/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T15:41:54Z","updated_at":"2016-02-04T15:41:54Z","body":"If this issue is fixed we solve #714 \r\n"}}