{"action":"created","issue":{"url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/69","repository_url":"https://api.github.com/repos/hathitrust/ht_sip_validator","labels_url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/69/comments","events_url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/69/events","html_url":"https://github.com/hathitrust/ht_sip_validator/issues/69","id":185731277,"number":69,"title":"Refactor Messages fields","user":{"login":"aelkiss","id":3856018,"avatar_url":"https://avatars.githubusercontent.com/u/3856018?v=3","gravatar_id":"","url":"https://api.github.com/users/aelkiss","html_url":"https://github.com/aelkiss","followers_url":"https://api.github.com/users/aelkiss/followers","following_url":"https://api.github.com/users/aelkiss/following{/other_user}","gists_url":"https://api.github.com/users/aelkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/aelkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelkiss/subscriptions","organizations_url":"https://api.github.com/users/aelkiss/orgs","repos_url":"https://api.github.com/users/aelkiss/repos","events_url":"https://api.github.com/users/aelkiss/events{/privacy}","received_events_url":"https://api.github.com/users/aelkiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-27T17:24:55Z","updated_at":"2016-10-27T19:20:28Z","closed_at":null,"body":"- Create a controlled vocabulary for what we currently call 'validation'\r\n- Figure out something better to call the field we currently call `validation` - maybe `validation_type`?\r\n- That should map to an expected set of fields in `extra`\r\n- Call `field` target instead (since it could be a directory rather than a field)\r\n- Log the class of the whatever created the messages."},"comment":{"url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/comments/256742769","html_url":"https://github.com/hathitrust/ht_sip_validator/issues/69#issuecomment-256742769","issue_url":"https://api.github.com/repos/hathitrust/ht_sip_validator/issues/69","id":256742769,"user":{"login":"malakai97","id":3486429,"avatar_url":"https://avatars.githubusercontent.com/u/3486429?v=3","gravatar_id":"","url":"https://api.github.com/users/malakai97","html_url":"https://github.com/malakai97","followers_url":"https://api.github.com/users/malakai97/followers","following_url":"https://api.github.com/users/malakai97/following{/other_user}","gists_url":"https://api.github.com/users/malakai97/gists{/gist_id}","starred_url":"https://api.github.com/users/malakai97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malakai97/subscriptions","organizations_url":"https://api.github.com/users/malakai97/orgs","repos_url":"https://api.github.com/users/malakai97/repos","events_url":"https://api.github.com/users/malakai97/events{/privacy}","received_events_url":"https://api.github.com/users/malakai97/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T19:20:28Z","updated_at":"2016-10-27T19:20:28Z","body":"\r\n### Re: Controlled vocabulary\r\nThese are the types of things we're doing now:\r\n\r\n- existence of files/folders\r\n- existence of fields\r\n- pairwise presence of fields\r\n- presence of extra files/folders\r\n- presence of extra fields\r\n- checksum mismatch\r\n- format of field values\r\n- format of files?\r\n\r\nThis list isn't too bad but I feel like the edges of each of these are fuzzy enough that proper categorization might be a daunting task.  \r\n\r\n### Name for the `validation` field\r\n`validation_type` is fine by me.\r\n\r\n### Message class\r\nAdding storing what created the messages, the new name for `:validation`, and `filename -> target`, we get:\r\n```\r\nMessage.new(\r\n  validator: self.class.to_s,\r\n  validation_type: :field_valid,\r\n  level: Message::ERROR,\r\n  human_message: \"some_message\",\r\n  extras: {\r\n    filename: \"meta.yml\",\r\n    field: \"pagedata\",\r\n    actual: key\r\n  }\r\n)\r\n```"}}
{"actor":{"display_login":"malakai97"}}