{"action":"closed","number":9954,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/9954","id":85618231,"html_url":"https://github.com/facebook/react-native/pull/9954","diff_url":"https://github.com/facebook/react-native/pull/9954.diff","patch_url":"https://github.com/facebook/react-native/pull/9954.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/9954","number":9954,"state":"closed","locked":false,"title":"Simplify react-native overrides when building from source","user":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"body":"You may want to double-check that this works perfectly (I am trying to move away from RN-from-source, since my changes were upstreamed), but it seems to build without errors for me. And this has the advantage of working seamlessly with \"rnpm\", which isn't smart enough to add these excludes when linking modules.","created_at":"2016-09-16T18:26:06Z","updated_at":"2016-10-25T11:44:10Z","closed_at":"2016-10-25T11:44:10Z","merged_at":null,"merge_commit_sha":"571dc16e3db04097940214e6a5a2927cfe219ce4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/9954/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/9954/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/9954/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/8224190a78e216cf2a26d2d14c01db99a788eb55","head":{"label":"mikelambert:patch-1","ref":"patch-1","sha":"8224190a78e216cf2a26d2d14c01db99a788eb55","user":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"repo":{"id":58318059,"name":"react-native","full_name":"mikelambert/react-native","owner":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikelambert/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/mikelambert/react-native","forks_url":"https://api.github.com/repos/mikelambert/react-native/forks","keys_url":"https://api.github.com/repos/mikelambert/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikelambert/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikelambert/react-native/teams","hooks_url":"https://api.github.com/repos/mikelambert/react-native/hooks","issue_events_url":"https://api.github.com/repos/mikelambert/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/mikelambert/react-native/events","assignees_url":"https://api.github.com/repos/mikelambert/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/mikelambert/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/mikelambert/react-native/tags","blobs_url":"https://api.github.com/repos/mikelambert/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikelambert/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikelambert/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikelambert/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikelambert/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mikelambert/react-native/languages","stargazers_url":"https://api.github.com/repos/mikelambert/react-native/stargazers","contributors_url":"https://api.github.com/repos/mikelambert/react-native/contributors","subscribers_url":"https://api.github.com/repos/mikelambert/react-native/subscribers","subscription_url":"https://api.github.com/repos/mikelambert/react-native/subscription","commits_url":"https://api.github.com/repos/mikelambert/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikelambert/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikelambert/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikelambert/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikelambert/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/mikelambert/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikelambert/react-native/merges","archive_url":"https://api.github.com/repos/mikelambert/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikelambert/react-native/downloads","issues_url":"https://api.github.com/repos/mikelambert/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/mikelambert/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mikelambert/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mikelambert/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikelambert/react-native/labels{/name}","releases_url":"https://api.github.com/repos/mikelambert/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/mikelambert/react-native/deployments","created_at":"2016-05-08T15:17:44Z","updated_at":"2016-05-08T15:17:50Z","pushed_at":"2016-10-25T09:26:48Z","git_url":"git://github.com/mikelambert/react-native.git","ssh_url":"git@github.com:mikelambert/react-native.git","clone_url":"https://github.com/mikelambert/react-native.git","svn_url":"https://github.com/mikelambert/react-native","homepage":"http://facebook.github.io/react-native/","size":73855,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f930270b005953bb7083190eef60d050e4de7607","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-10-25T10:44:12Z","pushed_at":"2016-10-25T11:43:36Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":149009,"stargazers_count":39411,"watchers_count":39411,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8831,"mirror_url":null,"open_issues_count":1253,"forks":8831,"open_issues":1253,"watchers":39411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9954"},"html":{"href":"https://github.com/facebook/react-native/pull/9954"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/9954"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/9954/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9954/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9954/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/8224190a78e216cf2a26d2d14c01db99a788eb55"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"facebook-github-bot"}}