{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/11138","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11138/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11138/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11138/events","html_url":"https://github.com/joomla/joomla-cms/pull/11138","id":165680627,"number":11138,"title":"New DateTime picker (replaces calendar)","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":38,"created_at":"2016-07-14T23:23:24Z","updated_at":"2016-08-07T23:01:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11138","html_url":"https://github.com/joomla/joomla-cms/pull/11138","diff_url":"https://github.com/joomla/joomla-cms/pull/11138.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11138.patch"},"body":"#### UX UI improvements\r\n\r\n#### Summary of Changes\r\n\r\n- Bootstrapified\r\n- Remove old code for IE<8\r\n- New simplified popup code\r\n- The internals of the date calculations are unchanged\r\n- Base on #707 improved support for non Gregorian calendars\r\n- New time picker code based on select elements (24 or 12h based)\r\n- options to display or not: week numbers, today button, year month in one row, days from previous next month (as disabled)\r\n- Everything is controllable through the calendar field definition (documentation will be done later on)\r\n\r\nIt still lacks some features:\r\n\r\n- [x]  JHtml calendar needs to call the form field calendar\r\n \r\n\r\n- [x] CSS for the templates that are not based on bootstrap (for isis and protostar there will be a layout that will not utilise that css file)\r\n\r\n- [x] Translate AM and PM strings\r\n\r\n- [ ] Anything that I missed or overlooked\r\n\r\n#### Preview\r\n![screen shot 2016-07-15 at 01 54 13](https://cloud.githubusercontent.com/assets/3889375/16858420/578c67ee-4a2f-11e6-9224-2b0db517294a.png)\r\n\r\nWith time picker\r\n![screen shot 2016-07-17 at 00 43 45](https://cloud.githubusercontent.com/assets/3889375/16897377/dc174284-4bb7-11e6-970e-1631fdaaa160.png)\r\n\r\n\r\n\r\nBasic view\r\n![screen shot 2016-07-15 at 02 11 02](https://cloud.githubusercontent.com/assets/3889375/16858799/41cc42b4-4a32-11e6-9fb9-8b29569dba47.png)\r\n\r\n#### Testing Instructions\r\nThis is **NOT** show time ready. The reasons I made the PR are:\r\n- Code review form Ruchiranga Wickramasinghe (GSOC js testing)\r\n- Get feedback on functionality, features, etc\r\n- Check if B/C is broken\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/238114173","html_url":"https://github.com/joomla/joomla-cms/pull/11138#issuecomment-238114173","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11138","id":238114173,"user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T23:01:55Z","updated_at":"2016-08-07T23:01:55Z","body":"> Is there a reason why the date field has to be readonly?\r\n\r\nMaybe I was too strict here, there should be a way to allow user input from keyboard. To explain the problem: \r\n- the old way: user filled the form and pressed save. For non-gregorian calendars there was an event that was fired on submit and checked the calendar fields (parse-print) and then continue to submit.\r\n\r\n- the new way: user filled the form and pressed save. All calendar fields exchange their input value to a data-value where the format is given (mysql), so no real calculation done at that point and the form continues to submit.\r\n\r\nA solution could be adding an event listener on blur, means that the user clicked in the input and then clicked somewhere else, that will fire the parse-print sequence.\r\n\r\nSo why not: in short: prevent errors before you reach the submit stage (that might be after onValid, I don;t remember, have to check)\r\n\r\nAbout the selects: these are working great for touch devices and are ok for desktops, also the implementation was way easier 😛"}}
{"actor":{"display_login":"dgt41"}}