{"action":"created","issue":{"url":"https://api.github.com/repos/cerati/mictest/issues/46","repository_url":"https://api.github.com/repos/cerati/mictest","labels_url":"https://api.github.com/repos/cerati/mictest/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/cerati/mictest/issues/46/comments","events_url":"https://api.github.com/repos/cerati/mictest/issues/46/events","html_url":"https://github.com/cerati/mictest/pull/46","id":154443308,"number":46,"title":"Change mom coord","user":{"login":"cerati","id":4818458,"avatar_url":"https://avatars.githubusercontent.com/u/4818458?v=3","gravatar_id":"","url":"https://api.github.com/users/cerati","html_url":"https://github.com/cerati","followers_url":"https://api.github.com/users/cerati/followers","following_url":"https://api.github.com/users/cerati/following{/other_user}","gists_url":"https://api.github.com/users/cerati/gists{/gist_id}","starred_url":"https://api.github.com/users/cerati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerati/subscriptions","organizations_url":"https://api.github.com/users/cerati/orgs","repos_url":"https://api.github.com/users/cerati/repos","events_url":"https://api.github.com/users/cerati/events{/privacy}","received_events_url":"https://api.github.com/users/cerati/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-12T09:58:52Z","updated_at":"2016-05-13T14:19:45Z","closed_at":"2016-05-13T10:34:36Z","pull_request":{"url":"https://api.github.com/repos/cerati/mictest/pulls/46","html_url":"https://github.com/cerati/mictest/pull/46","diff_url":"https://github.com/cerati/mictest/pull/46.diff","patch_url":"https://github.com/cerati/mictest/pull/46.patch"},"body":"This PR switches the default momentum coordinates in the Track object from global cartesian to quasi-polar (1/pT,phi,theta). In this way we do not need to convert back and forth from the two coordinate systems in the KalmanUtils.\r\nThe old behaviour can still be recovered disabling #define POLCOORD in Config.h.\r\n\r\nWhat still needs to be ported to the new coordinates are the SMatrix version of Propagation and of KalmanUtils. Also, the cuda version is not changed for the moment.\r\n\r\nAlso, a few deprecated functions are removed in this PR.\r\n\r\nThe timing performance is improved and goes back to the version before PR39, see plots at:\r\nhttp://uaf-6.t2.ucsd.edu/~cerati/mictest/2016-05-11-PR46/\r\n"},"comment":{"url":"https://api.github.com/repos/cerati/mictest/issues/comments/219056592","html_url":"https://github.com/cerati/mictest/pull/46#issuecomment-219056592","issue_url":"https://api.github.com/repos/cerati/mictest/issues/46","id":219056592,"user":{"login":"srlantz","id":8005834,"avatar_url":"https://avatars.githubusercontent.com/u/8005834?v=3","gravatar_id":"","url":"https://api.github.com/users/srlantz","html_url":"https://github.com/srlantz","followers_url":"https://api.github.com/users/srlantz/followers","following_url":"https://api.github.com/users/srlantz/following{/other_user}","gists_url":"https://api.github.com/users/srlantz/gists{/gist_id}","starred_url":"https://api.github.com/users/srlantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srlantz/subscriptions","organizations_url":"https://api.github.com/users/srlantz/orgs","repos_url":"https://api.github.com/users/srlantz/repos","events_url":"https://api.github.com/users/srlantz/events{/privacy}","received_events_url":"https://api.github.com/users/srlantz/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T14:19:45Z","updated_at":"2016-05-13T14:19:45Z","body":"Agreed, today's meeting will be full enough. But I disagree with the \"bikeshedding\" characterization. To me, names are important, and they should correctly reflect the concepts behind them.\r\n\r\nSteve\r\n\r\n\r\nFrom: Dan Riley [mailto:notifications@github.com]\r\nSent: Friday, May 13, 2016 10:09 AM\r\nTo: cerati/mictest\r\nCc: Steve Lantz; Comment\r\nSubject: Re: [cerati/mictest] Change mom coord (#46)\r\n\r\nCCS (cartesian-curvature-spherical) is fine by me, and I agree about\r\nnot using meeting time for this, too close to bikeshedding.\r\n\r\n-dan\r\n\r\n> On May 13, 2016, at 04:00, cerati <notifications@github.com> wrote:\r\n>\r\n> I do not think we should devote part of the meeting to the naming\r\n> convention, our 1h slot is too short already.\r\n> Just to say that \"helix parameters\" is a too generic definition that\r\n> applies to any parametrization (cartesian, \"polar\", curvilinear, perigee,\r\n> etc.).\r\n>\r\n> Our parametrization has two components:\r\n> - a global cartesian position\r\n> - a spherical momentum, modified so that the magnitude of the 3D radius\r\n> vector is replaced with 1./pT, where 1./pT is the magnitude of the 2D\r\n> radius vector and is proportional to the curvature (the fact that pT is 2D\r\n> while R is 3D is why I initially suggested polar rather than spherical)\r\n>\r\n> Any name capturing these features is fine with me.\r\n>\r\n> On Fri, May 13, 2016 at 12:23 AM, srlantz <notifications@github.com> wrote:\r\n>\r\n> > We can talk about it tomorrow if people want. My point is simply that the\r\n> > goal of these \"coordinates\" is to describe a geometrical object, namely a\r\n> > helix. We are saying that the current best estimate of the track is a\r\n> > z-oriented helix with pitch angle theta and lateral \"curvature\" 1/pT, and\r\n> > that point x,y,z is a position at azimuth phi (+/- pi/2) on this helix.\r\n> > (OK, to make 1/pT into a real curvature, the charge and B should be\r\n> > included to make it 1/gyroradius; not sure if I have omitted a relativistic\r\n> > gamma in some of the definitions.) The new coordinates just make it a bit\r\n> > clearer that we have been talking about such a geometrical object all\r\n> > along. So call them \"helix/helical parameters\"?\r\n> >\r\n> > —\r\n> > You are receiving this because you were mentioned.\r\n> > Reply to this email directly or view it on GitHub\r\n> > <https://github.com/cerati/mictest/pull/46#issuecomment-218903131>\r\n> >\r\n> —\r\n> You are receiving this because you were mentioned.\r\n> Reply to this email directly or view it on GitHub\r\n>\r\n\r\n\r\n\r\n—\r\nYou are receiving this because you commented.\r\nReply to this email directly or view it on GitHub<https://github.com/cerati/mictest/pull/46#issuecomment-219053491>\r\n"}}