{"action":"closed","number":774,"pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/774","id":55170896,"html_url":"https://github.com/apache/thrift/pull/774","diff_url":"https://github.com/apache/thrift/pull/774.diff","patch_url":"https://github.com/apache/thrift/pull/774.patch","issue_url":"https://api.github.com/repos/apache/thrift/issues/774","number":774,"state":"closed","locked":false,"title":"THRIFT-3523 : XML Generator","user":{"login":"bgould","id":766878,"avatar_url":"https://avatars.githubusercontent.com/u/766878?v=3","gravatar_id":"","url":"https://api.github.com/users/bgould","html_url":"https://github.com/bgould","followers_url":"https://api.github.com/users/bgould/followers","following_url":"https://api.github.com/users/bgould/following{/other_user}","gists_url":"https://api.github.com/users/bgould/gists{/gist_id}","starred_url":"https://api.github.com/users/bgould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgould/subscriptions","organizations_url":"https://api.github.com/users/bgould/orgs","repos_url":"https://api.github.com/users/bgould/repos","events_url":"https://api.github.com/users/bgould/events{/privacy}","received_events_url":"https://api.github.com/users/bgould/received_events","type":"User","site_admin":false},"body":"I've put together an XML model for Thrift IDL that is very similar in concept and structure to the model created by the JSON generator of the Thrift compiler.  The code is based on the JSON generator, and inherits the 'merge' option from that module for including the model of all includes in a single file if desired.\r\n\r\nThis generator is useful if you wish to extend the Thrift compiler with some XML based templating engine such as XSLT.  For example I have prototyped transforms that can create valid XML schema and WSDL files from Thrift IDL, as well as transform SOAP requests and responses to and from Thrift messages.  Those transforms are not included because they may be outside the scope of Thrift, but I can provide them if interested.  Regardless, I feel the XML model is generally useful and might be a good addition to the Thrift compiler.\r\n\r\nAlso included is an XML schema for the model file format and tests that generate XML from existing IDL in the Thrift test suite to validate against that schema.  These tests are Ant based and so only run when --with-java is enabled in ./configure","created_at":"2016-01-06T02:40:29Z","updated_at":"2016-01-10T10:54:44Z","closed_at":"2016-01-10T10:54:44Z","merged_at":null,"merge_commit_sha":"1da4ebc818d0065d6d6db95cf0ef8ad3335d04b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/thrift/pulls/774/commits","review_comments_url":"https://api.github.com/repos/apache/thrift/pulls/774/comments","review_comment_url":"https://api.github.com/repos/apache/thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/thrift/issues/774/comments","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/e09407675ea70a5bc4d5d25bfa2174e1518acf0c","head":{"label":"bgould:xml-generator","ref":"xml-generator","sha":"e09407675ea70a5bc4d5d25bfa2174e1518acf0c","user":{"login":"bgould","id":766878,"avatar_url":"https://avatars.githubusercontent.com/u/766878?v=3","gravatar_id":"","url":"https://api.github.com/users/bgould","html_url":"https://github.com/bgould","followers_url":"https://api.github.com/users/bgould/followers","following_url":"https://api.github.com/users/bgould/following{/other_user}","gists_url":"https://api.github.com/users/bgould/gists{/gist_id}","starred_url":"https://api.github.com/users/bgould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgould/subscriptions","organizations_url":"https://api.github.com/users/bgould/orgs","repos_url":"https://api.github.com/users/bgould/repos","events_url":"https://api.github.com/users/bgould/events{/privacy}","received_events_url":"https://api.github.com/users/bgould/received_events","type":"User","site_admin":false},"repo":{"id":18363198,"name":"thrift","full_name":"bgould/thrift","owner":{"login":"bgould","id":766878,"avatar_url":"https://avatars.githubusercontent.com/u/766878?v=3","gravatar_id":"","url":"https://api.github.com/users/bgould","html_url":"https://github.com/bgould","followers_url":"https://api.github.com/users/bgould/followers","following_url":"https://api.github.com/users/bgould/following{/other_user}","gists_url":"https://api.github.com/users/bgould/gists{/gist_id}","starred_url":"https://api.github.com/users/bgould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgould/subscriptions","organizations_url":"https://api.github.com/users/bgould/orgs","repos_url":"https://api.github.com/users/bgould/repos","events_url":"https://api.github.com/users/bgould/events{/privacy}","received_events_url":"https://api.github.com/users/bgould/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgould/thrift","description":"Mirror of Apache Thrift","fork":true,"url":"https://api.github.com/repos/bgould/thrift","forks_url":"https://api.github.com/repos/bgould/thrift/forks","keys_url":"https://api.github.com/repos/bgould/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgould/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgould/thrift/teams","hooks_url":"https://api.github.com/repos/bgould/thrift/hooks","issue_events_url":"https://api.github.com/repos/bgould/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/bgould/thrift/events","assignees_url":"https://api.github.com/repos/bgould/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/bgould/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/bgould/thrift/tags","blobs_url":"https://api.github.com/repos/bgould/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgould/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgould/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgould/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgould/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/bgould/thrift/languages","stargazers_url":"https://api.github.com/repos/bgould/thrift/stargazers","contributors_url":"https://api.github.com/repos/bgould/thrift/contributors","subscribers_url":"https://api.github.com/repos/bgould/thrift/subscribers","subscription_url":"https://api.github.com/repos/bgould/thrift/subscription","commits_url":"https://api.github.com/repos/bgould/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgould/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgould/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgould/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgould/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/bgould/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgould/thrift/merges","archive_url":"https://api.github.com/repos/bgould/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgould/thrift/downloads","issues_url":"https://api.github.com/repos/bgould/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/bgould/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/bgould/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/bgould/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgould/thrift/labels{/name}","releases_url":"https://api.github.com/repos/bgould/thrift/releases{/id}","created_at":"2014-04-02T10:48:04Z","updated_at":"2015-01-21T04:09:32Z","pushed_at":"2016-01-08T17:50:23Z","git_url":"git://github.com/bgould/thrift.git","ssh_url":"git@github.com:bgould/thrift.git","clone_url":"https://github.com/bgould/thrift.git","svn_url":"https://github.com/bgould/thrift","homepage":"","size":15093,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f6521c64f4622960fe3aec634d1a07cb06d0cab1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":310611,"name":"thrift","full_name":"apache/thrift","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/thrift","description":"Mirror of Apache Thrift","fork":false,"url":"https://api.github.com/repos/apache/thrift","forks_url":"https://api.github.com/repos/apache/thrift/forks","keys_url":"https://api.github.com/repos/apache/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/thrift/teams","hooks_url":"https://api.github.com/repos/apache/thrift/hooks","issue_events_url":"https://api.github.com/repos/apache/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/apache/thrift/events","assignees_url":"https://api.github.com/repos/apache/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/apache/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/apache/thrift/tags","blobs_url":"https://api.github.com/repos/apache/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/thrift/languages","stargazers_url":"https://api.github.com/repos/apache/thrift/stargazers","contributors_url":"https://api.github.com/repos/apache/thrift/contributors","subscribers_url":"https://api.github.com/repos/apache/thrift/subscribers","subscription_url":"https://api.github.com/repos/apache/thrift/subscription","commits_url":"https://api.github.com/repos/apache/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/apache/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/thrift/merges","archive_url":"https://api.github.com/repos/apache/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/thrift/downloads","issues_url":"https://api.github.com/repos/apache/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/apache/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/thrift/labels{/name}","releases_url":"https://api.github.com/repos/apache/thrift/releases{/id}","created_at":"2009-09-18T08:00:17Z","updated_at":"2016-01-10T05:39:17Z","pushed_at":"2016-01-10T10:54:35Z","git_url":"git://github.com/apache/thrift.git","ssh_url":"git@github.com:apache/thrift.git","clone_url":"https://github.com/apache/thrift.git","svn_url":"https://github.com/apache/thrift","homepage":"","size":20864,"stargazers_count":2286,"watchers_count":2286,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1378,"mirror_url":"git://git.apache.org/thrift.git","open_issues_count":72,"forks":1378,"open_issues":72,"watchers":2286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/thrift/pulls/774"},"html":{"href":"https://github.com/apache/thrift/pull/774"},"issue":{"href":"https://api.github.com/repos/apache/thrift/issues/774"},"comments":{"href":"https://api.github.com/repos/apache/thrift/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/thrift/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/thrift/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/apache/thrift/statuses/e09407675ea70a5bc4d5d25bfa2174e1518acf0c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":2,"commits":1,"additions":1097,"deletions":1,"changed_files":8}}