{"push_id":1201262504,"size":50,"distinct_size":50,"ref":"refs/heads/master","head":"12351f2b35f0fecf6d7d30a5776f81e8a5e38404","before":"081d9fc8702c4ab1df0932d5f50f4d1acf6177a4","commits":[{"sha":"4da397adde88c161b1c6b583b1a1ce432a8b4dca","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"CachingBuildEngineTest: enable disabled test\n\nSummary:\nIt appears this test was accidentely left disabled due to a missing\n`Test` annotation.  Add this annotation and fix a minor case of bit\nrot.\n\nTest Plan: ran it\n\nReviewed By: michath\n\nfbshipit-source-id: 49e0d6d","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/4da397adde88c161b1c6b583b1a1ce432a8b4dca"},{"sha":"66062af50b4294c1eeb43310c2a2ba20d07ef1a6","author":{"name":"Rui Barbosa Martins","email":"e0b976060a5bff07520a2ebeca31a68033eab2bd@fb.com"},"message":"Getting rid of the stray '~/java*.log' file\n\nSummary: Getting rid of the stray 'java*.log' file with zero bytes that is created when the buck process starts.\n\nTest Plan:\nbuck test\nci\n\nReviewed By: michath\n\nfbshipit-source-id: 6442801","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/66062af50b4294c1eeb43310c2a2ba20d07ef1a6"},{"sha":"70a8f93c0eac784d5513190b279b945386369864","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Rename .buckconfig to .buckconfig.local to exercise the intended behavior in an integration test.\n\nSummary:\nAs noted in the comment in `.buckconfig.local`, the behavior that was designed to be tested\nwas being overwritten by `ProjectWorkspace`. This fixes it.\n\nTest Plan:\n1. CI\n2. Stepped through `CachedTestIntegrationTest` in the debugger and verified that the correct values in `BuckConfig` were set and a `DirCacheEntry` was created with the correct value for `cacheDir`.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 5405dac","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/70a8f93c0eac784d5513190b279b945386369864"},{"sha":"675d9185ac6f9e7112f2ed8835adc5b07ca4fa27","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Force AbstractNetworkCache to write its temp files under buck-out/ rather than tmp/.\n\nSummary:\nThis was causing issues for [Eden](https://github.com/facebookexperimental/eden) because\nwrites are fairly expensive as compared to reads. Currently, we mitigate this issue by bind-mounting\nthe `buck-out` directory in EdenFS, so we are less concerned about the I/O that happens there.\n\nIt turns out that `AbstractNetworkCache` was using the `tmp` directory in the project root as its own\nscratch directory, so this fixes it to use `buck-out/tmp` instead. Eden notwithstanding, letting Buck do\nwrites outside of `buck-out` is not kosher. I suspect this went unnoticed because in practice:\n\n1. This only happens if you are using `http` or `thrift_over_http` as a cache mode.\n2. `AbstractNetworkCache` attempts to clean up the file in `tmp` after the artifact is uploaded.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: b3d4aab","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/675d9185ac6f9e7112f2ed8835adc5b07ca4fa27"},{"sha":"ce64178eb5f9d8ffd81a8e4a4424f75618797c95","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Improve error message for BuckBuildLog.assertNotTargetBuiltLocally\n\nTest Plan: Viewed error message.  Was pleased.\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: c2c1a61","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/ce64178eb5f9d8ffd81a8e4a4424f75618797c95"},{"sha":"c30b76af1eaac2a9321006ae26650d4dfc499101","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Use \"android-strip\" as a flavor name instead of \"strip\"\n\nSummary:\ngoing to start sharing this rules between apps.  Use a more specific\nflavor to avoid colliding with any non-Android rules.\n\nTest Plan: CI\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: d8308f9","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/c30b76af1eaac2a9321006ae26650d4dfc499101"},{"sha":"02dd72ceb2cdb98fdf584021c01b8a8cdb00dc6b","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Make AndroidNativeLibsPackageableGraphEnhancer.generateStripRules static\n\nSummary:\nI'm updating this method to make it share rules between apps.  Making it\nstatic is an optional step to reduce the risk of details of the app\nleaking into the generated rules (by making all data passed in\nexplicitly).  LMK if you think this is a bad idea or waste of space.\n\nTest Plan: CI.\n\nReviewed By: andrewjcg, asp2insp\n\nfbshipit-source-id: 3d4dd97","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/02dd72ceb2cdb98fdf584021c01b8a8cdb00dc6b"},{"sha":"d3945368a0c7f491a0cc59dfed7d87faa5c36506","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Share (most) strip rules between Android apps\n\nSummary:\nPreviously, rules for stripping libs for inclusion in Android apps used\nthe app target as the base for the strip target.  This prevented them\nfrom being shared between apps (even slight variations like exo/noexo),\nso someone building an app that wasn't pre-cached (the exact same\ntarget) would get a cache miss on the strip rule and have to download\nthe cache artifact for the unstripped lib, which can be very large.\n\nNow, use the library target as the base of the target to allow sharing.\n\nFor libs that are not BuildTargetSourcePaths, keep the old behavior to\nbe safe.  I've only seen this affect the C++ runtime, whose unstripped\nlib is part of the NDK.\n\nTest Plan: Added integration test.\n\nReviewed By: andrewjcg, asp2insp\n\nfbshipit-source-id: 098e4da","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/d3945368a0c7f491a0cc59dfed7d87faa5c36506"},{"sha":"ca2a67cc89b978f3a8a2596e1468be6b1174e348","author":{"name":"Joel McCall","email":"fb9ad6027e7bc8b3e4bf32d4b47243e5267c7ef4@fb.com"},"message":"allow non-hardcoded names in DexStore\n\nSummary:\nthis allows the names of the dex files in the store to be non-standard (either secondary* or classes*) so that the dexes\nin additional dex stores for modules can be named according to their module\n\nTest Plan: unit tests, builds and inspection of verious dex store options in fb4a builds\n\nReviewed By: dreiss\n\nfbshipit-source-id: fd61502","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/ca2a67cc89b978f3a8a2596e1468be6b1174e348"},{"sha":"e9d927d1db14185c1773f359e2891719199abf00","author":{"name":"Joel McCall","email":"fb9ad6027e7bc8b3e4bf32d4b47243e5267c7ef4@fb.com"},"message":"store name support in dex class canaries\n\nSummary: allow for store specific naming in canary classes used to validate proper loading of dex files\n\nTest Plan: build and inspection of dexes, validate canaries are loaded\n\nReviewed By: dreiss\n\nfbshipit-source-id: 576338a","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/e9d927d1db14185c1773f359e2891719199abf00"},{"sha":"8ba44608c8829cfadf18efadd41b064cbc768536","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Update docs for building Eden JAR to reflect a recent change in Eden.\n\nSummary:\nThe recent change in Eden is:\nhttps://github.com/facebookexperimental/eden/commit/10a9b86fc79f045b0a2eebed86209cc9496580dd\n\nTest Plan: Verified that I could build the new target.\n\nReviewed By: simpkins\n\nfbshipit-source-id: c701834","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/8ba44608c8829cfadf18efadd41b064cbc768536"},{"sha":"bd288e72ab271aaaa95fa48542559d97061d9dd1","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"Support configuring most buck-out dirs\n\nSummary:\nThis adds a buck config setting to allow changing the buck-out directory\nused for most of the buck-out subdirs used during the build.\n\nTest Plan: added integration tests\n\nReviewed By: k21\n\nfbshipit-source-id: 141281d","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/bd288e72ab271aaaa95fa48542559d97061d9dd1"},{"sha":"e61d5e03ca5fa8e588ddefc8619aae7afb38faa6","author":{"name":"Martino Luca","email":"bc39cf26caffb8d5b7f43458ab0463d2c1c72bbf@fb.com"},"message":"Do not cache `infer-deps.txt`, always create it as part of post-build\n\nSummary: Do not cache `infer-deps.txt` but always create it as part of post-build\n\nTest Plan: Integration tests, unit tests\n\nReviewed By: mzlee\n\nfbshipit-source-id: de70eee","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/e61d5e03ca5fa8e588ddefc8619aae7afb38faa6"},{"sha":"0fd564bf62e1e16ab9f790de5e5f20be1781db21","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Extend SC API that returns optional\n\nSummary:\nIntroduction of the following API calls:\n* revisionIdOrAbsent(): like revisionId() but it returns Optional.absent() if not found or an error was caused instead of throwing.\n* commonAncestorOrAbsent(): like revisionId() but it returns Optional.absent() if not found or an error was caused instead of throwing.\n\n* trackedBookmarksOffRevisionId(tip, rev, bookmarks): You give it a tip revision id, another revision id and a list of bookmarks. It will find the common ancestor between the tip and other revision and compare that revision with the bookmarks. The reason behind the tip revision id is to have more precise data.\n\nTest Plan:\n* CI\n* added new tests that check all the new API\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 4889ae4","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/0fd564bf62e1e16ab9f790de5e5f20be1781db21"},{"sha":"5b54b213fb8ddba9c7ec00c4828122702811fe25","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Alter buck rage SC collector\n\nSummary: Altering the logic of VcsInfoCollector to use the new extended source control API that we have.\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 431c42f","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/5b54b213fb8ddba9c7ec00c4828122702811fe25"},{"sha":"b3fc3abb68b8bf121f82ce2621afee15b0ab1d1a","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Introduce base bookmarks for Scuba Buck Builds\n\nSummary:\nWith this diff we will be able to track if a build came from stable or master with a deterministic way.\nThe tracked bookmarks are the stable of each repo and remote/master.\n\nTest Plan:\n* added a unit test.\n* tweaked another one.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 2e614cd","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/b3fc3abb68b8bf121f82ce2621afee15b0ab1d1a"},{"sha":"6a396e2aa5ea84fb1a82a49f7658d82a09a37664","author":{"name":"Martin Kosiba","email":"6bd994d075fcd7642f04677ba9960527dece6461@fb.com"},"message":"Distributed build TargetGraph serialization\n\nSummary:\nThis adds the ability for the distributed build command to serialize and deserialize the TargetGraph.\nThe deserialization is a bit broken because it ends up using the rootCell for the freshly instantiated\nTargetNode's deps. I plan to address this in a later change.\n\nTest Plan: CI, added new test\n\nReviewed By: Coneko\n\nfbshipit-source-id: ff2762c","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/6a396e2aa5ea84fb1a82a49f7658d82a09a37664"},{"sha":"4ed1d141af5d4be6c248748f4fd4c9ac2c160a29","author":{"name":"Keeley D. Erhardt","email":"b55878025e1039f0e1d9159da25aa1b37643b9a3@fb.com"},"message":"Remove unused eden autodep\n\nSummary:\nRan buck autodeps and eden was unused\n\nRemove use of org.apache.commons package\n\nTest Plan: Change came from run of buck autodeps\n\nReviewed By: Coneko\n\nfbshipit-source-id: bc6cea0","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/4ed1d141af5d4be6c248748f4fd4c9ac2c160a29"},{"sha":"1f18a234ca84540030364a0fa1b3653dcde68b10","author":{"name":"Joel McCall","email":"fb9ad6027e7bc8b3e4bf32d4b47243e5267c7ef4@fb.com"},"message":"Make sure RAW dex stores are marked root relative in the metadata file\n\nSummary: RAW dexes are stores as classes*.dex in the root of the apk, we need to make sure the metadata for their store is marked as root relative.\n\nTest Plan: build automation_groups_art_xxhdpi_armv7_release and ensure it is marked .root_relative\n\nfbshipit-source-id: dd4b846","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/1f18a234ca84540030364a0fa1b3653dcde68b10"},{"sha":"d05eaac39bf2334f8baadc8d14c2cfc4b2cb5e8d","author":{"name":"Mark Wang","email":"ef7450a1f0ef1dd83819119188f9feef0990e9ee@fb.com"},"message":"Ignore non apple_test tests in Xcode project generation\n\nSummary:\nSometimes we need non `apple_tests` in apple targets.\n\nDue to Xcode's limitations, we can't include them in generated projects, but `buck test` should still be able to run them, e.g. in CI environments.\n\nInstead of erroring out in this situation, print a warning during project generation.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 83f2dca","distinct":true,"url":"https://api.github.com/repos/rlugojr/buck/commits/d05eaac39bf2334f8baadc8d14c2cfc4b2cb5e8d"}]}
{"actor":{"display_login":"rlugojr"}}