{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/90727073","pull_request_review_id":11247921,"id":90727073,"diff_hunk":"@@ -63,3 +75,16 @@ func SetupLogging() {\n func NewTableWriter(buffer io.Writer) *tabwriter.Writer {\n \treturn tabwriter.NewWriter(buffer, outputMinWidth, outputTabWidth, outputPadding, outputPadChar, 0)\n }\n+\n+func setFlagsFromEnv(flags *pflag.FlagSet) error {","path":"cmd/rook/rook/rook.go","position":44,"original_position":44,"commit_id":"974138a2beea3729bc0595eb3c3f00c7dc7c4e5f","original_commit_id":"1ff56ebdb90a1de8cb8806ef6442b20040a27c3d","user":{"login":"thephred","id":110422,"avatar_url":"https://avatars.githubusercontent.com/u/110422?v=3","gravatar_id":"","url":"https://api.github.com/users/thephred","html_url":"https://github.com/thephred","followers_url":"https://api.github.com/users/thephred/followers","following_url":"https://api.github.com/users/thephred/following{/other_user}","gists_url":"https://api.github.com/users/thephred/gists{/gist_id}","starred_url":"https://api.github.com/users/thephred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephred/subscriptions","organizations_url":"https://api.github.com/users/thephred/orgs","repos_url":"https://api.github.com/users/thephred/repos","events_url":"https://api.github.com/users/thephred/events{/privacy}","received_events_url":"https://api.github.com/users/thephred/received_events","type":"User","site_admin":false},"body":"Would have to parameterize the prefix but that seems reasonable (i.e. this uses ROOK_... and the other use ROOKD_...)","created_at":"2016-12-02T21:56:25Z","updated_at":"2016-12-02T21:56:25Z","html_url":"https://github.com/rook/rook/pull/242#discussion_r90727073","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/90727073"},"html":{"href":"https://github.com/rook/rook/pull/242#discussion_r90727073"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/242","id":96359017,"html_url":"https://github.com/rook/rook/pull/242","diff_url":"https://github.com/rook/rook/pull/242.diff","patch_url":"https://github.com/rook/rook/pull/242.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/242","number":242,"state":"open","locked":false,"title":"Added a kubernetes demo","user":{"login":"thephred","id":110422,"avatar_url":"https://avatars.githubusercontent.com/u/110422?v=3","gravatar_id":"","url":"https://api.github.com/users/thephred","html_url":"https://github.com/thephred","followers_url":"https://api.github.com/users/thephred/followers","following_url":"https://api.github.com/users/thephred/following{/other_user}","gists_url":"https://api.github.com/users/thephred/gists{/gist_id}","starred_url":"https://api.github.com/users/thephred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephred/subscriptions","organizations_url":"https://api.github.com/users/thephred/orgs","repos_url":"https://api.github.com/users/thephred/repos","events_url":"https://api.github.com/users/thephred/events{/privacy}","received_events_url":"https://api.github.com/users/thephred/received_events","type":"User","site_admin":false},"body":"This serves as a simple example of running rook in a kubernetes environment and shows how to consume a block device as a data dir for mysql.\r\n\r\nPlease see the following for changes need to coreos-kubernetes to run the demo: https://github.com/rook/coreos-kubernetes/commit/651dece8c62fef45d76889bd64247bd6eb51546a\r\n\r\nAlso added the ability to set global flags with environment variables in the rook cli.","created_at":"2016-12-02T21:50:20Z","updated_at":"2016-12-02T21:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47212e8899a02e6e6b69c7032ec6363e186709ed","assignee":{"login":"travisn","id":1048514,"avatar_url":"https://avatars.githubusercontent.com/u/1048514?v=3","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"assignees":[{"login":"travisn","id":1048514,"avatar_url":"https://avatars.githubusercontent.com/u/1048514?v=3","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},{"login":"jbw976","id":4313439,"avatar_url":"https://avatars.githubusercontent.com/u/4313439?v=3","gravatar_id":"","url":"https://api.github.com/users/jbw976","html_url":"https://github.com/jbw976","followers_url":"https://api.github.com/users/jbw976/followers","following_url":"https://api.github.com/users/jbw976/following{/other_user}","gists_url":"https://api.github.com/users/jbw976/gists{/gist_id}","starred_url":"https://api.github.com/users/jbw976/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbw976/subscriptions","organizations_url":"https://api.github.com/users/jbw976/orgs","repos_url":"https://api.github.com/users/jbw976/repos","events_url":"https://api.github.com/users/jbw976/events{/privacy}","received_events_url":"https://api.github.com/users/jbw976/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/242/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/242/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/242/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/974138a2beea3729bc0595eb3c3f00c7dc7c4e5f","head":{"label":"thephred:kubernetes","ref":"kubernetes","sha":"974138a2beea3729bc0595eb3c3f00c7dc7c4e5f","user":{"login":"thephred","id":110422,"avatar_url":"https://avatars.githubusercontent.com/u/110422?v=3","gravatar_id":"","url":"https://api.github.com/users/thephred","html_url":"https://github.com/thephred","followers_url":"https://api.github.com/users/thephred/followers","following_url":"https://api.github.com/users/thephred/following{/other_user}","gists_url":"https://api.github.com/users/thephred/gists{/gist_id}","starred_url":"https://api.github.com/users/thephred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephred/subscriptions","organizations_url":"https://api.github.com/users/thephred/orgs","repos_url":"https://api.github.com/users/thephred/repos","events_url":"https://api.github.com/users/thephred/events{/privacy}","received_events_url":"https://api.github.com/users/thephred/received_events","type":"User","site_admin":false},"repo":{"id":73988481,"name":"rook","full_name":"thephred/rook","owner":{"login":"thephred","id":110422,"avatar_url":"https://avatars.githubusercontent.com/u/110422?v=3","gravatar_id":"","url":"https://api.github.com/users/thephred","html_url":"https://github.com/thephred","followers_url":"https://api.github.com/users/thephred/followers","following_url":"https://api.github.com/users/thephred/following{/other_user}","gists_url":"https://api.github.com/users/thephred/gists{/gist_id}","starred_url":"https://api.github.com/users/thephred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephred/subscriptions","organizations_url":"https://api.github.com/users/thephred/orgs","repos_url":"https://api.github.com/users/thephred/repos","events_url":"https://api.github.com/users/thephred/events{/privacy}","received_events_url":"https://api.github.com/users/thephred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thephred/rook","description":"Open, Cloud Native, and Universal Distributed Storage","fork":true,"url":"https://api.github.com/repos/thephred/rook","forks_url":"https://api.github.com/repos/thephred/rook/forks","keys_url":"https://api.github.com/repos/thephred/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thephred/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thephred/rook/teams","hooks_url":"https://api.github.com/repos/thephred/rook/hooks","issue_events_url":"https://api.github.com/repos/thephred/rook/issues/events{/number}","events_url":"https://api.github.com/repos/thephred/rook/events","assignees_url":"https://api.github.com/repos/thephred/rook/assignees{/user}","branches_url":"https://api.github.com/repos/thephred/rook/branches{/branch}","tags_url":"https://api.github.com/repos/thephred/rook/tags","blobs_url":"https://api.github.com/repos/thephred/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thephred/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thephred/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/thephred/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thephred/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/thephred/rook/languages","stargazers_url":"https://api.github.com/repos/thephred/rook/stargazers","contributors_url":"https://api.github.com/repos/thephred/rook/contributors","subscribers_url":"https://api.github.com/repos/thephred/rook/subscribers","subscription_url":"https://api.github.com/repos/thephred/rook/subscription","commits_url":"https://api.github.com/repos/thephred/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/thephred/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/thephred/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/thephred/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/thephred/rook/contents/{+path}","compare_url":"https://api.github.com/repos/thephred/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thephred/rook/merges","archive_url":"https://api.github.com/repos/thephred/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thephred/rook/downloads","issues_url":"https://api.github.com/repos/thephred/rook/issues{/number}","pulls_url":"https://api.github.com/repos/thephred/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/thephred/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/thephred/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thephred/rook/labels{/name}","releases_url":"https://api.github.com/repos/thephred/rook/releases{/id}","deployments_url":"https://api.github.com/repos/thephred/rook/deployments","created_at":"2016-11-17T03:56:01Z","updated_at":"2016-11-17T03:56:02Z","pushed_at":"2016-12-02T21:47:57Z","git_url":"git://github.com/thephred/rook.git","ssh_url":"git@github.com:thephred/rook.git","clone_url":"https://github.com/thephred/rook.git","svn_url":"https://github.com/thephred/rook","homepage":"https://rook.io","size":890,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"332658211c6ec8747e52872f15554fa852edb94f","user":{"login":"rook","id":22860722,"avatar_url":"https://avatars.githubusercontent.com/u/22860722?v=3","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"avatar_url":"https://avatars.githubusercontent.com/u/22860722?v=3","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"Open, Cloud Native, and Universal Distributed Storage","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2016-12-02T21:46:22Z","pushed_at":"2016-12-02T21:55:00Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":6036,"stargazers_count":726,"watchers_count":726,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":57,"forks":26,"open_issues":57,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/242"},"html":{"href":"https://github.com/rook/rook/pull/242"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/242"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/974138a2beea3729bc0595eb3c3f00c7dc7c4e5f"}}}}
{"actor":{"display_login":"thephred"}}