{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56526335","id":56526335,"diff_hunk":"@@ -4,20 +4,11 @@\n \n   <ItemGroup>\n     <ProjectReference Include=\"..\\ref\\System.Security.Cryptography.OpenSsl.csproj\">\n-      <SupportedFramework>netstandardapp1.5</SupportedFramework>\n-    </ProjectReference>\n-    <ProjectReference Include=\"..\\src\\System.Security.Cryptography.OpenSsl.csproj\" >\n-      <OSGroup>Linux</OSGroup>\n+      <SupportedFramework>netstandardapp1.5;net461;netcore50</SupportedFramework>","path":"src/System.Security.Cryptography.OpenSsl/pkg/System.Security.Cryptography.OpenSsl.pkgproj","position":8,"original_position":8,"commit_id":"55ff90b72aefe34a861b31531adde6928599f69d","original_commit_id":"55ff90b72aefe34a861b31531adde6928599f69d","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"What does it mean to say that the OpenSsl library is supported on net461?","created_at":"2016-03-17T15:45:45Z","updated_at":"2016-03-17T15:45:45Z","html_url":"https://github.com/dotnet/corefx/pull/6988#discussion_r56526335","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6988","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56526335"},"html":{"href":"https://github.com/dotnet/corefx/pull/6988#discussion_r56526335"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6988"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6988","id":63192239,"html_url":"https://github.com/dotnet/corefx/pull/6988","diff_url":"https://github.com/dotnet/corefx/pull/6988.diff","patch_url":"https://github.com/dotnet/corefx/pull/6988.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6988","number":6988,"state":"open","locked":false,"title":"Add dummy impl for platform specific API","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"body":"This adds dummy implementations for platform specific API.  The\r\nimplementation assemblies throw PlatformNotSupported for all methods.\r\n\r\nThis will satisfy NuGet's guardrails check and also let folks compile\r\nagainst these assemblies and load them at runtime without JIT failures.\r\n\r\nWe will not be placing these packages in any of the shared-framework\r\nlayouts, nor should any of these ever be depended on by CoreFx\r\nlibraries.  But we will provide them to enable folks to write platform\r\nlightup code without having to worry about using reflection or guarding\r\ncalls in separate methods disabling JIT inlining.\r\n\r\nThese assemblies are marked with AssemblyMetadata(\"NotSupported\",\r\n\"True\"), so that future dev-time tooling can detect them and warn/error\r\nin the case of accidental dependence on platform specific API.\r\n\r\nOne notable difference is\r\nSystem.Runtime.InteropSerivices.WindowsRuntime: this assembly was\r\npreviously part of portable profiles and implementation exists in\r\nmscorlib.  For this we will forward to mscorlib on all platforms and it\r\nis up to mscorlib to determine implementation (throw vs noop).\r\nFixes dotnet#6684\r\n\r\nOther platform specific contracts that have been excluded:\r\nSystem.IO.IsolatedStorage: currently only supported for netcore50 so no\r\nneed to address this problem for x-plat.\r\nSystem.Runtime.WindowsRuntime & System.Runtime.WindowsRuntime.UI.Xaml:\r\nboth are WinRT specific and not exposed in any PCL profiles that we\r\nexpect folks to use with x-plat NET core.","created_at":"2016-03-17T09:15:27Z","updated_at":"2016-03-17T15:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"339dd7deb39ca33a89022a992c57cec467361a1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6988/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6988/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6988/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/55ff90b72aefe34a861b31531adde6928599f69d","head":{"label":"ericstj:AddTurds","ref":"AddTurds","sha":"55ff90b72aefe34a861b31531adde6928599f69d","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"repo":{"id":27736722,"name":"corefx","full_name":"ericstj/corefx","owner":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericstj/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/ericstj/corefx","forks_url":"https://api.github.com/repos/ericstj/corefx/forks","keys_url":"https://api.github.com/repos/ericstj/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericstj/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericstj/corefx/teams","hooks_url":"https://api.github.com/repos/ericstj/corefx/hooks","issue_events_url":"https://api.github.com/repos/ericstj/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ericstj/corefx/events","assignees_url":"https://api.github.com/repos/ericstj/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ericstj/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ericstj/corefx/tags","blobs_url":"https://api.github.com/repos/ericstj/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericstj/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericstj/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericstj/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericstj/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ericstj/corefx/languages","stargazers_url":"https://api.github.com/repos/ericstj/corefx/stargazers","contributors_url":"https://api.github.com/repos/ericstj/corefx/contributors","subscribers_url":"https://api.github.com/repos/ericstj/corefx/subscribers","subscription_url":"https://api.github.com/repos/ericstj/corefx/subscription","commits_url":"https://api.github.com/repos/ericstj/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericstj/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericstj/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericstj/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericstj/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ericstj/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericstj/corefx/merges","archive_url":"https://api.github.com/repos/ericstj/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericstj/corefx/downloads","issues_url":"https://api.github.com/repos/ericstj/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ericstj/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ericstj/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ericstj/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericstj/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ericstj/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ericstj/corefx/deployments","created_at":"2014-12-08T21:44:45Z","updated_at":"2016-01-11T20:03:34Z","pushed_at":"2016-03-17T09:13:55Z","git_url":"git://github.com/ericstj/corefx.git","ssh_url":"git@github.com:ericstj/corefx.git","clone_url":"https://github.com/ericstj/corefx.git","svn_url":"https://github.com/ericstj/corefx","homepage":"","size":59012,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9ba80de480a2a9f69d7fa5625864295802f8bd29","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-03-17T13:21:30Z","pushed_at":"2016-03-17T15:05:33Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":80275,"stargazers_count":9331,"watchers_count":9331,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2193,"mirror_url":null,"open_issues_count":942,"forks":2193,"open_issues":942,"watchers":9331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6988"},"html":{"href":"https://github.com/dotnet/corefx/pull/6988"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6988"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6988/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6988/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6988/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/55ff90b72aefe34a861b31531adde6928599f69d"}}}}