{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12582","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12582/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12582/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12582/events","html_url":"https://github.com/servo/servo/pull/12582","id":167318807,"number":12582,"title":"Make the service worker send custom response","user":{"login":"creativcoder","id":5155745,"avatar_url":"https://avatars.githubusercontent.com/u/5155745?v=3","gravatar_id":"","url":"https://api.github.com/users/creativcoder","html_url":"https://github.com/creativcoder","followers_url":"https://api.github.com/users/creativcoder/followers","following_url":"https://api.github.com/users/creativcoder/following{/other_user}","gists_url":"https://api.github.com/users/creativcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/creativcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativcoder/subscriptions","organizations_url":"https://api.github.com/users/creativcoder/orgs","repos_url":"https://api.github.com/users/creativcoder/repos","events_url":"https://api.github.com/users/creativcoder/events{/privacy}","received_events_url":"https://api.github.com/users/creativcoder/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-07-25T09:05:39Z","updated_at":"2016-07-26T13:27:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12582","html_url":"https://github.com/servo/servo/pull/12582","diff_url":"https://github.com/servo/servo/pull/12582.diff","patch_url":"https://github.com/servo/servo/pull/12582.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] These changes do not require tests because \"refactor\".\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12582)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/235266817","html_url":"https://github.com/servo/servo/pull/12582#issuecomment-235266817","issue_url":"https://api.github.com/repos/servo/servo/issues/12582","id":235266817,"user":{"login":"creativcoder","id":5155745,"avatar_url":"https://avatars.githubusercontent.com/u/5155745?v=3","gravatar_id":"","url":"https://api.github.com/users/creativcoder","html_url":"https://github.com/creativcoder","followers_url":"https://api.github.com/users/creativcoder/followers","following_url":"https://api.github.com/users/creativcoder/following{/other_user}","gists_url":"https://api.github.com/users/creativcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/creativcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativcoder/subscriptions","organizations_url":"https://api.github.com/users/creativcoder/orgs","repos_url":"https://api.github.com/users/creativcoder/repos","events_url":"https://api.github.com/users/creativcoder/events{/privacy}","received_events_url":"https://api.github.com/users/creativcoder/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T13:27:43Z","updated_at":"2016-07-26T13:27:43Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[components/script/dom/abstractworker.rs, line 21 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/12582#-KNXHVxfdqPuS3OhHd3N:-KNbMQ-SJeXE9E4IClrl:727549967) ([raw file](https://github.com/servo/servo/blob/00db4bbb6cd8c10416810ad528f7ead819744a97/components/script/dom/abstractworker.rs#L21)):*\n<details><summary><i>Previously, jdm (Josh Matthews) wrote…</i></summary>\n> Could create a separate ServiceWorkerScriptMsg that includes this and a WorkerScriptMsg variant? I'm not sure about all the places where we store senders and receivers, but it would be nice to avoid introducing another message that's only used by one worker type.\n</details>\nokay, so I've added the `ServiceWorkerScriptMsg` enum as a seperate msg type in `serviceworkerglobalscope.rs` itself. Does that look ok to you ?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/12582)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"creativcoder"}}