{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4997","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4997/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4997/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4997/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/4997","id":182232545,"number":4997,"title":"Adapt Jerk / Speed code from Prusa MK2","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs:%20Testing","name":"Needs: Testing","color":"eb6420"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Bugfix","name":"PR: Bugfix","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-11T10:47:51Z","updated_at":"2016-10-20T07:49:07Z","closed_at":"2016-10-12T11:38:50Z","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/4997","html_url":"https://github.com/MarlinFirmware/Marlin/pull/4997","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/4997.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/4997.patch"},"body":"This PR adapts the  of the speed limiting code from the Prusa i3 MK2 branch of Marlin. It purports to correct an issue where the Z axis could end up with its speed not properly limited.\r\n\r\nSummary:\r\n- Use a single byte with flag bits instead of two `bool` flags\r\n- Add `previous_safe_speed` for testing whether the move is halting\r\n- Optimize / condense max acceleration limit code (See also #4365)\r\n- Perform initial jerk speed limit as per MK2 branch\r\n- Perform junction speed limit as per MK2 branch\r\n- Use `const` where it makes sense\r\n\r\nReferences: #4936, #4930, #4365\r\n\r\n![image](https://cloud.githubusercontent.com/assets/698003/19308927/bd3fb68c-9047-11e6-8fd2-790c5bef731f.png)\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/255033713","html_url":"https://github.com/MarlinFirmware/Marlin/pull/4997#issuecomment-255033713","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4997","id":255033713,"user":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T07:49:06Z","updated_at":"2016-10-20T07:49:06Z","body":"Wouldn't it be possible to limit G92 in a way that it cannot set positions outside of the actual bed positions?\r\n\r\nThe only time where you would want to set a coordinate outside of the build volume would be if you're trying to \"figure out\" your printers limits I imagine. \r\n\r\nI would envision if you call a G92 with X, Y or Z values outside  +AXIS_LENGTH>=value>=-AXIS_LENGTH it should simply not execute the command at all.\r\n\r\nOf course that wouldn't solve issues where someone actually needs exorbitant values (I'd love to see a printer with a 3.2 meter long build axis :D)"}}
{"actor":{"display_login":"FHeilmann"}}