{"action":"created","comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/85872951","pull_request_review_id":6561544,"id":85872951,"diff_hunk":"@@ -315,6 +316,10 @@\n         };\n         return item.tier.toLowerCase() === (tierMap[predicate] || predicate);\n       },\n+      sublime: function(predicate, item) {\n+        return item.isEngram() &&\n+          item.name.indexOf('Sublime') === 0;","path":"app/scripts/shell/dimSearchFilter.directive.js","position":14,"original_position":14,"commit_id":"3ad4e094ac87e9aea63b604a5d4000d50fd58f35","original_commit_id":"3ad4e094ac87e9aea63b604a5d4000d50fd58f35","user":{"login":"bhollis","id":313208,"avatar_url":"https://avatars.githubusercontent.com/u/313208?v=3","gravatar_id":"","url":"https://api.github.com/users/bhollis","html_url":"https://github.com/bhollis","followers_url":"https://api.github.com/users/bhollis/followers","following_url":"https://api.github.com/users/bhollis/following{/other_user}","gists_url":"https://api.github.com/users/bhollis/gists{/gist_id}","starred_url":"https://api.github.com/users/bhollis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhollis/subscriptions","organizations_url":"https://api.github.com/users/bhollis/orgs","repos_url":"https://api.github.com/users/bhollis/repos","events_url":"https://api.github.com/users/bhollis/events{/privacy}","received_events_url":"https://api.github.com/users/bhollis/received_events","type":"User","site_admin":false},"body":"Unfortunately, we can't use the name of things for this type of filter, because it won't work in all languages. Instead, we try to look at things like the categories of the item, which are language independent.","created_at":"2016-11-01T04:12:13Z","updated_at":"2016-11-01T04:12:16Z","html_url":"https://github.com/DestinyItemManager/DIM/pull/1116#discussion_r85872951","pull_request_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116","_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/85872951"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/1116#discussion_r85872951"},"pull_request":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116"}}},"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116","id":91681978,"html_url":"https://github.com/DestinyItemManager/DIM/pull/1116","diff_url":"https://github.com/DestinyItemManager/DIM/pull/1116.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/1116.patch","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/1116","number":1116,"state":"open","locked":false,"title":"Adds is:sublime filter","user":{"login":"ajacobson","id":617552,"avatar_url":"https://avatars.githubusercontent.com/u/617552?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacobson","html_url":"https://github.com/ajacobson","followers_url":"https://api.github.com/users/ajacobson/followers","following_url":"https://api.github.com/users/ajacobson/following{/other_user}","gists_url":"https://api.github.com/users/ajacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacobson/subscriptions","organizations_url":"https://api.github.com/users/ajacobson/orgs","repos_url":"https://api.github.com/users/ajacobson/repos","events_url":"https://api.github.com/users/ajacobson/events{/privacy}","received_events_url":"https://api.github.com/users/ajacobson/received_events","type":"User","site_admin":false},"body":"When decrypting \"sublime\" engrams a user may need to be mindful of the character being used to efficiently complete the PS exclusive armor sets.  I found myself often wanting a way to exclude these engrams from a search filter when bulk decrypting engrams after a farming session so I could handle their decryption with more attention at a later time.\r\n\r\nWith this change, this is now possible using a filter like: \"is:legendary is:engram not:sublime\".","created_at":"2016-10-31T20:15:51Z","updated_at":"2016-11-01T04:12:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c458f9e2a45a61ecccc9f87ed3c267985890b11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/1116/comments","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/3ad4e094ac87e9aea63b604a5d4000d50fd58f35","head":{"label":"ajacobson:sublime-filter","ref":"sublime-filter","sha":"3ad4e094ac87e9aea63b604a5d4000d50fd58f35","user":{"login":"ajacobson","id":617552,"avatar_url":"https://avatars.githubusercontent.com/u/617552?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacobson","html_url":"https://github.com/ajacobson","followers_url":"https://api.github.com/users/ajacobson/followers","following_url":"https://api.github.com/users/ajacobson/following{/other_user}","gists_url":"https://api.github.com/users/ajacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacobson/subscriptions","organizations_url":"https://api.github.com/users/ajacobson/orgs","repos_url":"https://api.github.com/users/ajacobson/repos","events_url":"https://api.github.com/users/ajacobson/events{/privacy}","received_events_url":"https://api.github.com/users/ajacobson/received_events","type":"User","site_admin":false},"repo":{"id":72472795,"name":"DIM","full_name":"ajacobson/DIM","owner":{"login":"ajacobson","id":617552,"avatar_url":"https://avatars.githubusercontent.com/u/617552?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacobson","html_url":"https://github.com/ajacobson","followers_url":"https://api.github.com/users/ajacobson/followers","following_url":"https://api.github.com/users/ajacobson/following{/other_user}","gists_url":"https://api.github.com/users/ajacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacobson/subscriptions","organizations_url":"https://api.github.com/users/ajacobson/orgs","repos_url":"https://api.github.com/users/ajacobson/repos","events_url":"https://api.github.com/users/ajacobson/events{/privacy}","received_events_url":"https://api.github.com/users/ajacobson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajacobson/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/ajacobson/DIM","forks_url":"https://api.github.com/repos/ajacobson/DIM/forks","keys_url":"https://api.github.com/repos/ajacobson/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajacobson/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajacobson/DIM/teams","hooks_url":"https://api.github.com/repos/ajacobson/DIM/hooks","issue_events_url":"https://api.github.com/repos/ajacobson/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/ajacobson/DIM/events","assignees_url":"https://api.github.com/repos/ajacobson/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/ajacobson/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/ajacobson/DIM/tags","blobs_url":"https://api.github.com/repos/ajacobson/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajacobson/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajacobson/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajacobson/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajacobson/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/ajacobson/DIM/languages","stargazers_url":"https://api.github.com/repos/ajacobson/DIM/stargazers","contributors_url":"https://api.github.com/repos/ajacobson/DIM/contributors","subscribers_url":"https://api.github.com/repos/ajacobson/DIM/subscribers","subscription_url":"https://api.github.com/repos/ajacobson/DIM/subscription","commits_url":"https://api.github.com/repos/ajacobson/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajacobson/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajacobson/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajacobson/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajacobson/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/ajacobson/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajacobson/DIM/merges","archive_url":"https://api.github.com/repos/ajacobson/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajacobson/DIM/downloads","issues_url":"https://api.github.com/repos/ajacobson/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/ajacobson/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/ajacobson/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/ajacobson/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajacobson/DIM/labels{/name}","releases_url":"https://api.github.com/repos/ajacobson/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/ajacobson/DIM/deployments","created_at":"2016-10-31T19:56:23Z","updated_at":"2016-10-31T19:56:24Z","pushed_at":"2016-10-31T20:05:36Z","git_url":"git://github.com/ajacobson/DIM.git","ssh_url":"git@github.com:ajacobson/DIM.git","clone_url":"https://github.com/ajacobson/DIM.git","svn_url":"https://github.com/ajacobson/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":243534,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DestinyItemManager:dev","ref":"dev","sha":"c4d6ebaab82be6f00ec182997788f9b39db73a43","user":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"repo":{"id":31681575,"name":"DIM","full_name":"DestinyItemManager/DIM","owner":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DestinyItemManager/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/DestinyItemManager/DIM","forks_url":"https://api.github.com/repos/DestinyItemManager/DIM/forks","keys_url":"https://api.github.com/repos/DestinyItemManager/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DestinyItemManager/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DestinyItemManager/DIM/teams","hooks_url":"https://api.github.com/repos/DestinyItemManager/DIM/hooks","issue_events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/events","assignees_url":"https://api.github.com/repos/DestinyItemManager/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/DestinyItemManager/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/tags","blobs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/DestinyItemManager/DIM/languages","stargazers_url":"https://api.github.com/repos/DestinyItemManager/DIM/stargazers","contributors_url":"https://api.github.com/repos/DestinyItemManager/DIM/contributors","subscribers_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscribers","subscription_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscription","commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/DestinyItemManager/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/DestinyItemManager/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DestinyItemManager/DIM/merges","archive_url":"https://api.github.com/repos/DestinyItemManager/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DestinyItemManager/DIM/downloads","issues_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/DestinyItemManager/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/DestinyItemManager/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/labels{/name}","releases_url":"https://api.github.com/repos/DestinyItemManager/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/DestinyItemManager/DIM/deployments","created_at":"2015-03-04T21:46:50Z","updated_at":"2016-11-01T01:34:27Z","pushed_at":"2016-11-01T00:44:26Z","git_url":"git://github.com/DestinyItemManager/DIM.git","ssh_url":"git@github.com:DestinyItemManager/DIM.git","clone_url":"https://github.com/DestinyItemManager/DIM.git","svn_url":"https://github.com/DestinyItemManager/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":253958,"stargazers_count":391,"watchers_count":391,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":108,"forks":180,"open_issues":108,"watchers":391,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/1116"},"issue":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/1116"},"comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/3ad4e094ac87e9aea63b604a5d4000d50fd58f35"}}}}
{"actor":{"display_login":"bhollis"}}