{"action":"created","issue":{"url":"https://api.github.com/repos/plank/laravel-mediable/issues/20","repository_url":"https://api.github.com/repos/plank/laravel-mediable","labels_url":"https://api.github.com/repos/plank/laravel-mediable/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/plank/laravel-mediable/issues/20/comments","events_url":"https://api.github.com/repos/plank/laravel-mediable/issues/20/events","html_url":"https://github.com/plank/laravel-mediable/pull/20","id":175576516,"number":20,"title":"Use file content hash has filename if none is set.","user":{"login":"geidelguerra","id":5066997,"avatar_url":"https://avatars.githubusercontent.com/u/5066997?v=3","gravatar_id":"","url":"https://api.github.com/users/geidelguerra","html_url":"https://github.com/geidelguerra","followers_url":"https://api.github.com/users/geidelguerra/followers","following_url":"https://api.github.com/users/geidelguerra/following{/other_user}","gists_url":"https://api.github.com/users/geidelguerra/gists{/gist_id}","starred_url":"https://api.github.com/users/geidelguerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geidelguerra/subscriptions","organizations_url":"https://api.github.com/users/geidelguerra/orgs","repos_url":"https://api.github.com/users/geidelguerra/repos","events_url":"https://api.github.com/users/geidelguerra/events{/privacy}","received_events_url":"https://api.github.com/users/geidelguerra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-07T18:42:51Z","updated_at":"2016-09-13T22:05:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/plank/laravel-mediable/pulls/20","html_url":"https://github.com/plank/laravel-mediable/pull/20","diff_url":"https://github.com/plank/laravel-mediable/pull/20.diff","patch_url":"https://github.com/plank/laravel-mediable/pull/20.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/plank/laravel-mediable/issues/comments/246840763","html_url":"https://github.com/plank/laravel-mediable/pull/20#issuecomment-246840763","issue_url":"https://api.github.com/repos/plank/laravel-mediable/issues/20","id":246840763,"user":{"login":"frasmage","id":916652,"avatar_url":"https://avatars.githubusercontent.com/u/916652?v=3","gravatar_id":"","url":"https://api.github.com/users/frasmage","html_url":"https://github.com/frasmage","followers_url":"https://api.github.com/users/frasmage/followers","following_url":"https://api.github.com/users/frasmage/following{/other_user}","gists_url":"https://api.github.com/users/frasmage/gists{/gist_id}","starred_url":"https://api.github.com/users/frasmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasmage/subscriptions","organizations_url":"https://api.github.com/users/frasmage/orgs","repos_url":"https://api.github.com/users/frasmage/repos","events_url":"https://api.github.com/users/frasmage/events{/privacy}","received_events_url":"https://api.github.com/users/frasmage/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T22:05:58Z","updated_at":"2016-09-13T22:05:58Z","body":"Hi Geidel,\r\n\r\nGreat! That is very similar to the approach I was thinking. I have a couple of nitpicks and suggestions to make before we merge this.\r\n\r\n- $snake_case for properties please. can we make the  name $hash_filename or similar? Imho, boolean vars shouldn't start with a verb.\r\n- needs a useDefaultFilename() method which clears $filename and $hash_filename properties.\r\n- setFilename() should set $hash_filename to false, e.g. if it is called after.\r\n- useHashForFilename() should clear $filename.\r\n- that line wth the double ternary expression is getting too bloated, needs to be extracted to its own method.\r\n- need to update the documentation accordingly.\r\n\r\nFeel free to take a stab at any of those, I'll handle anything that is left over this weekend when I get home.\r\n"}}
{"actor":{"display_login":"frasmage"}}