{"action":"created","comment":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/61888602","id":61888602,"diff_hunk":"@@ -0,0 +1,4 @@\n+{","path":"public/js/configs/development.json","position":1,"original_position":1,"commit_id":"2906d2c547259d4f20716b6a025d4948c10226c6","original_commit_id":"2906d2c547259d4f20716b6a025d4948c10226c6","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"body":"I feel like the configs still belong at the top-level. We could make a top-level `configs` directory. We'll probably end up wanting to put some other stuff in there, like the `port` that the server runs on.","created_at":"2016-05-03T14:20:10Z","updated_at":"2016-05-03T14:20:10Z","html_url":"https://github.com/jlongster/debugger.html/pull/128#discussion_r61888602","pull_request_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/61888602"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/128#discussion_r61888602"},"pull_request":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/128","id":68601954,"html_url":"https://github.com/jlongster/debugger.html/pull/128","diff_url":"https://github.com/jlongster/debugger.html/pull/128.diff","patch_url":"https://github.com/jlongster/debugger.html/pull/128.patch","issue_url":"https://api.github.com/repos/jlongster/debugger.html/issues/128","number":128,"state":"open","locked":false,"title":"Update Configuration","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"Currently we use an environment file for configuration.\r\nThis is fine, but there are a couple shortcomings\r\n\r\n1) the environment file is read directly\r\n\r\n2) the environment file is for your own local changes, which is not the\r\nsame as shared development features\r\n\r\n3) it would not be obvious how to add production flags. This PR adds a\r\ndevelopment.json file, but it would be easy to add a production.php file\r\nand read from it when in production.\r\n\r\n4) lastly, there aren't any nice helpers. This PR adds an isEnabled\r\nfeature, but ultimately it would be nice to improve it to support path\r\nnotation and maybe other functionality as well.","created_at":"2016-05-02T18:46:45Z","updated_at":"2016-05-03T14:20:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5997f3d3567c5306268a5fd36efe5691c695e06c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/128/commits","review_comments_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/128/comments","review_comment_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/issues/128/comments","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/2906d2c547259d4f20716b6a025d4948c10226c6","head":{"label":"jasonLaster:configs2","ref":"configs2","sha":"2906d2c547259d4f20716b6a025d4948c10226c6","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"repo":{"id":55007537,"name":"debugger.html","full_name":"jasonLaster/debugger.html","owner":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonLaster/debugger.html","description":"Experimental something something.","fork":true,"url":"https://api.github.com/repos/jasonLaster/debugger.html","forks_url":"https://api.github.com/repos/jasonLaster/debugger.html/forks","keys_url":"https://api.github.com/repos/jasonLaster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonLaster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonLaster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jasonLaster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jasonLaster/debugger.html/events","assignees_url":"https://api.github.com/repos/jasonLaster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jasonLaster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonLaster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonLaster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jasonLaster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jasonLaster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonLaster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonLaster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jasonLaster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonLaster/debugger.html/merges","archive_url":"https://api.github.com/repos/jasonLaster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonLaster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jasonLaster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonLaster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonLaster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonLaster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jasonLaster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jasonLaster/debugger.html/deployments","created_at":"2016-03-29T20:14:57Z","updated_at":"2016-04-06T21:38:42Z","pushed_at":"2016-05-03T13:14:27Z","git_url":"git://github.com/jasonLaster/debugger.html.git","ssh_url":"git@github.com:jasonLaster/debugger.html.git","clone_url":"https://github.com/jasonLaster/debugger.html.git","svn_url":"https://github.com/jasonLaster/debugger.html","homepage":null,"size":281,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jlongster:master","ref":"master","sha":"5fd77d2d17c9d36676f300a450ba0b3b5033aa0a","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"jlongster/debugger.html","owner":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongster/debugger.html","description":"An experimental debugger interface.","fork":false,"url":"https://api.github.com/repos/jlongster/debugger.html","forks_url":"https://api.github.com/repos/jlongster/debugger.html/forks","keys_url":"https://api.github.com/repos/jlongster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jlongster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jlongster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jlongster/debugger.html/events","assignees_url":"https://api.github.com/repos/jlongster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jlongster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jlongster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jlongster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jlongster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jlongster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jlongster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jlongster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jlongster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jlongster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongster/debugger.html/merges","archive_url":"https://api.github.com/repos/jlongster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jlongster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jlongster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jlongster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jlongster/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2016-04-30T22:31:47Z","pushed_at":"2016-05-03T13:14:24Z","git_url":"git://github.com/jlongster/debugger.html.git","ssh_url":"git@github.com:jlongster/debugger.html.git","clone_url":"https://github.com/jlongster/debugger.html.git","svn_url":"https://github.com/jlongster/debugger.html","homepage":"","size":326,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":25,"forks":12,"open_issues":25,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/128"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/128"},"issue":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/128"},"comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/jlongster/debugger.html/statuses/2906d2c547259d4f20716b6a025d4948c10226c6"}}}}