{"action":"created","issue":{"url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1430","repository_url":"https://api.github.com/repos/plone/Products.CMFPlone","labels_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1430/labels{/name}","comments_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1430/comments","events_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1430/events","html_url":"https://github.com/plone/Products.CMFPlone/issues/1430","id":137620069,"number":1430,"title":"Fix html validation","user":{"login":"mauritsvanrees","id":210587,"avatar_url":"https://avatars.githubusercontent.com/u/210587?v=3","gravatar_id":"","url":"https://api.github.com/users/mauritsvanrees","html_url":"https://github.com/mauritsvanrees","followers_url":"https://api.github.com/users/mauritsvanrees/followers","following_url":"https://api.github.com/users/mauritsvanrees/following{/other_user}","gists_url":"https://api.github.com/users/mauritsvanrees/gists{/gist_id}","starred_url":"https://api.github.com/users/mauritsvanrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauritsvanrees/subscriptions","organizations_url":"https://api.github.com/users/mauritsvanrees/orgs","repos_url":"https://api.github.com/users/mauritsvanrees/repos","events_url":"https://api.github.com/users/mauritsvanrees/events{/privacy}","received_events_url":"https://api.github.com/users/mauritsvanrees/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/plone/Products.CMFPlone/labels/04%20type:%20enhancement","name":"04 type: enhancement","color":"00fa00"},{"url":"https://api.github.com/repos/plone/Products.CMFPlone/labels/23%20status:%20testing","name":"23 status: testing","color":"fafa00"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-01T16:24:04Z","updated_at":"2016-03-01T19:33:56Z","closed_at":null,"body":"When validation the homepage of a fresh Plone 5 site, there are several errors and warnings. Let's fix them. This is from the validator at https://validator.w3.org:\r\n\r\n- Error: Bad value menu for attribute role on element section.\r\n- Warning: Element main does not need a role attribute.\r\n- Warning: Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.\r\n- Warning: The banner role is unnecessary for element header.\r\n- Warning: The contentinfo role is unnecessary for element footer.\r\n\r\nSome are there multiple times. There can be others, for example when you change the portal_actions footer to show a portlet title (which is ugly by the way, but that is why it is switched off by default).\r\n\r\nI have fixed these and will create pull requests and link them here.  There will still be failures on other pages, but this is a nice start.\r\n\r\nThe most controversial may be the warning 'section lacks heading'. We have various `section` elements with a `header` element in it, but that is not the same as a heading. Headings are `h1`, `h2`, etcetera. And in a lot of these cases it does not make sense to add a heading. My solution in most cases was to simply change the `section` into a `div`. Seems like that is fine for our current css. There were no glaring javascript errors due to this change either. Let's see what Jenkins has to say about that in a while.\r\n\r\nAnyway, since it is only a warning, we could ignore it: adding a heading in a section is only a recommendation, not a requirement.\r\n\r\nI have added https://github.com/plone/buildout.coredev/blob/5.0/plips/maurits-fix-html-validation.cfg with checkouts and source branches so you can try it out. I'll create the individual pull requests now and feed them to Jenkins in one go.\r\n\r\nPull requests:\r\n\r\nhttps://github.com/plone/plone.app.contenttypes/pull/329\r\nhttps://github.com/plone/plone.app.layout/pull/81\r\nhttps://github.com/plone/plone.app.portlets/pull/64\r\nhttps://github.com/plone/plone.app.theming/pull/98\r\nhttps://github.com/plone/plonetheme.barceloneta/pull/90\r\nhttps://github.com/plone/Products.CMFPlone/pull/1431\r\n\r\nFor easy copy-pasting in Jenkins:\r\n```\r\nhttps://github.com/plone/plone.app.contenttypes/pull/329\r\nhttps://github.com/plone/plone.app.layout/pull/81\r\nhttps://github.com/plone/plone.app.portlets/pull/64\r\nhttps://github.com/plone/plone.app.theming/pull/98\r\nhttps://github.com/plone/plonetheme.barceloneta/pull/90\r\nhttps://github.com/plone/Products.CMFPlone/pull/1431\r\n```"},"comment":{"url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/comments/190866424","html_url":"https://github.com/plone/Products.CMFPlone/issues/1430#issuecomment-190866424","issue_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1430","id":190866424,"user":{"login":"mauritsvanrees","id":210587,"avatar_url":"https://avatars.githubusercontent.com/u/210587?v=3","gravatar_id":"","url":"https://api.github.com/users/mauritsvanrees","html_url":"https://github.com/mauritsvanrees","followers_url":"https://api.github.com/users/mauritsvanrees/followers","following_url":"https://api.github.com/users/mauritsvanrees/following{/other_user}","gists_url":"https://api.github.com/users/mauritsvanrees/gists{/gist_id}","starred_url":"https://api.github.com/users/mauritsvanrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauritsvanrees/subscriptions","organizations_url":"https://api.github.com/users/mauritsvanrees/orgs","repos_url":"https://api.github.com/users/mauritsvanrees/repos","events_url":"https://api.github.com/users/mauritsvanrees/events{/privacy}","received_events_url":"https://api.github.com/users/mauritsvanrees/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T19:33:56Z","updated_at":"2016-03-01T19:33:56Z","body":"You are smelling another flake8 plugin. :-)"}}