{"action":"created","comment":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/51201130","id":51201130,"diff_hunk":"@@ -310,92 +310,74 @@ AppInstaller = class AppInstaller {\n     };\n \n     let protocol;\n-    if (url.protocol === 'http:') {\n-      protocol = Http;\n-    } else if (url.protocol === 'https:') {\n+    if (url.protocol === 'http:' || url.protocol === 'https:') {\n+      protocol = Request.defaults({\n+        maxRedirects: 1,","path":"shell/server/installer.js","position":9,"original_position":9,"commit_id":"435363f0362d1cee82d24462e27859a1ecd42430","original_commit_id":"435363f0362d1cee82d24462e27859a1ecd42430","user":{"login":"paulproteus","id":25457,"avatar_url":"https://avatars.githubusercontent.com/u/25457?v=3","gravatar_id":"","url":"https://api.github.com/users/paulproteus","html_url":"https://github.com/paulproteus","followers_url":"https://api.github.com/users/paulproteus/followers","following_url":"https://api.github.com/users/paulproteus/following{/other_user}","gists_url":"https://api.github.com/users/paulproteus/gists{/gist_id}","starred_url":"https://api.github.com/users/paulproteus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulproteus/subscriptions","organizations_url":"https://api.github.com/users/paulproteus/orgs","repos_url":"https://api.github.com/users/paulproteus/repos","events_url":"https://api.github.com/users/paulproteus/events{/privacy}","received_events_url":"https://api.github.com/users/paulproteus/received_events","type":"User","site_admin":false},"body":"How about 5? : D\r\n\r\nI just want to pick a constant, any constant.","created_at":"2016-01-28T22:50:26Z","updated_at":"2016-01-28T22:50:26Z","html_url":"https://github.com/sandstorm-io/sandstorm/pull/1438#discussion_r51201130","pull_request_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438","_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/51201130"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/1438#discussion_r51201130"},"pull_request":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438","id":57551890,"html_url":"https://github.com/sandstorm-io/sandstorm/pull/1438","diff_url":"https://github.com/sandstorm-io/sandstorm/pull/1438.diff","patch_url":"https://github.com/sandstorm-io/sandstorm/pull/1438.patch","issue_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/1438","number":1438,"state":"open","locked":false,"title":"Add support for using a HTTP proxy for outbound connections (just for app install for now)","user":{"login":"paulproteus","id":25457,"avatar_url":"https://avatars.githubusercontent.com/u/25457?v=3","gravatar_id":"","url":"https://api.github.com/users/paulproteus","html_url":"https://github.com/paulproteus","followers_url":"https://api.github.com/users/paulproteus/followers","following_url":"https://api.github.com/users/paulproteus/following{/other_user}","gists_url":"https://api.github.com/users/paulproteus/gists{/gist_id}","starred_url":"https://api.github.com/users/paulproteus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulproteus/subscriptions","organizations_url":"https://api.github.com/users/paulproteus/orgs","repos_url":"https://api.github.com/users/paulproteus/repos","events_url":"https://api.github.com/users/paulproteus/events{/privacy}","received_events_url":"https://api.github.com/users/paulproteus/received_events","type":"User","site_admin":false},"body":"This adjusts `installer.js` to use the `request` API, rather than the node\r\nHTTP/HTTPS API. It also adjusts `run-bundle.c++` to pass this variable through,\r\nand adjusts the docs to explain how to use this feature.\r\n\r\nRefs #693\r\n\r\nDoes not fully close #693 yet because a few other places need a similar update.","created_at":"2016-01-28T19:24:03Z","updated_at":"2016-01-28T22:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a42dacab6f8a446ee3d6a0ef893a1883d0ffee65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/1438/comments","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/435363f0362d1cee82d24462e27859a1ecd42430","head":{"label":"sandstorm-io:support-app-install-via-proxy","ref":"support-app-install-via-proxy","sha":"435363f0362d1cee82d24462e27859a1ecd42430","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":15728293,"name":"sandstorm","full_name":"sandstorm-io/sandstorm","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/sandstorm","description":"Personal Cloud Sandbox","fork":false,"url":"https://api.github.com/repos/sandstorm-io/sandstorm","forks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/forks","keys_url":"https://api.github.com/repos/sandstorm-io/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/sandstorm/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/events","assignees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/sandstorm/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/sandstorm/merges","archive_url":"https://api.github.com/repos/sandstorm-io/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/sandstorm/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/deployments","created_at":"2014-01-08T07:10:33Z","updated_at":"2016-01-28T15:45:51Z","pushed_at":"2016-01-28T19:24:03Z","git_url":"git://github.com/sandstorm-io/sandstorm.git","ssh_url":"git@github.com:sandstorm-io/sandstorm.git","clone_url":"https://github.com/sandstorm-io/sandstorm.git","svn_url":"https://github.com/sandstorm-io/sandstorm","homepage":"https://sandstorm.io","size":33995,"stargazers_count":3305,"watchers_count":3305,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":324,"forks":275,"open_issues":324,"watchers":3305,"default_branch":"master"}},"base":{"label":"sandstorm-io:master","ref":"master","sha":"d80315ae6aabc3ba23655cb7926fd88061cbf0a2","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":15728293,"name":"sandstorm","full_name":"sandstorm-io/sandstorm","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/sandstorm","description":"Personal Cloud Sandbox","fork":false,"url":"https://api.github.com/repos/sandstorm-io/sandstorm","forks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/forks","keys_url":"https://api.github.com/repos/sandstorm-io/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/sandstorm/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/events","assignees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/sandstorm/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/sandstorm/merges","archive_url":"https://api.github.com/repos/sandstorm-io/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/sandstorm/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/deployments","created_at":"2014-01-08T07:10:33Z","updated_at":"2016-01-28T15:45:51Z","pushed_at":"2016-01-28T19:24:03Z","git_url":"git://github.com/sandstorm-io/sandstorm.git","ssh_url":"git@github.com:sandstorm-io/sandstorm.git","clone_url":"https://github.com/sandstorm-io/sandstorm.git","svn_url":"https://github.com/sandstorm-io/sandstorm","homepage":"https://sandstorm.io","size":33995,"stargazers_count":3305,"watchers_count":3305,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":324,"forks":275,"open_issues":324,"watchers":3305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/1438"},"issue":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/1438"},"comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/435363f0362d1cee82d24462e27859a1ecd42430"}}}}