{"action":"created","comment":{"url":"https://api.github.com/repos/CESNET/perun/pulls/comments/73441495","id":73441495,"diff_hunk":"@@ -2060,4 +2179,108 @@ private void closeExtSourcesAfterSynchronization(ExtSource membersSource, ExtSou\n \t\t\t}\n \t\t}\n \t}\n+\t\n+\t@Override\n+\tpublic void processRelationMembers(PerunSession sess, Group resultGroup, List<Member> changedMembers, int sourceGroupId, boolean addition) throws GroupOperationsException {\n+\n+\t\tList<Member> newMembers;\n+\n+\t\ttry {\n+\t\t\tif (addition) {\n+\t\t\t\tnewMembers = addIndirectMembers(sess, resultGroup, changedMembers, sourceGroupId);\n+\t\t\t} else {\n+\t\t\t\tnewMembers = removeIndirectMembers(sess, resultGroup, changedMembers, sourceGroupId);\n+\t\t\t}\n+\n+\t\t\tif (newMembers.isEmpty()) {\n+\t\t\t\treturn;\n+\t\t\t}\n+\n+\t\t\tList<Integer> relations = groupsManagerImpl.getGroupRelations(sess, resultGroup.getId());\n+\t\t\tfor (Integer groupId : relations) {\n+\t\t\t\tprocessRelationMembers(sess, groupsManagerImpl.getGroupById(sess, groupId), newMembers, resultGroup.getId(), addition);\n+\t\t\t}\n+\t\t} catch (WrongReferenceAttributeValueException | WrongAttributeValueException | AlreadyMemberException |\n+\t\t\t\tInternalErrorException | NotGroupMemberException | GroupNotExistsException ex) {\n+\t\t\tthrow new GroupOperationsException(ex);\n+\t\t}\n+\t}\n+\n+\t@Override\n+\tpublic Group createGroupUnion(PerunSession sess, Group resultGroup, Group operandGroup, boolean parentFlag) throws GroupOperationsException, InternalErrorException {\n+\t\t\n+\t\t//check if any of the groups is members group\n+\t\tif(resultGroup.getName().equals(VosManager.MEMBERS_GROUP) || operandGroup.getName().equals(VosManager.MEMBERS_GROUP)) {\n+\t\t\tthrow new InternalErrorException(\"Union cannot be created on members group.\");","path":"perun-core/src/main/java/cz/metacentrum/perun/core/blImpl/GroupsManagerBlImpl.java","position":479,"original_position":479,"commit_id":"95f79c30c856f5d24ec9e2580f7971a6c232a2b8","original_commit_id":"95f79c30c856f5d24ec9e2580f7971a6c232a2b8","user":{"login":"licehammer","id":3735955,"avatar_url":"https://avatars.githubusercontent.com/u/3735955?v=3","gravatar_id":"","url":"https://api.github.com/users/licehammer","html_url":"https://github.com/licehammer","followers_url":"https://api.github.com/users/licehammer/followers","following_url":"https://api.github.com/users/licehammer/following{/other_user}","gists_url":"https://api.github.com/users/licehammer/gists{/gist_id}","starred_url":"https://api.github.com/users/licehammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licehammer/subscriptions","organizations_url":"https://api.github.com/users/licehammer/orgs","repos_url":"https://api.github.com/users/licehammer/repos","events_url":"https://api.github.com/users/licehammer/events{/privacy}","received_events_url":"https://api.github.com/users/licehammer/received_events","type":"User","site_admin":false},"body":"Unless there is another check which prevent user to call this method with MEMBERS_GROUP in parameter, another exception should be used.","created_at":"2016-08-03T23:44:26Z","updated_at":"2016-08-03T23:44:26Z","html_url":"https://github.com/CESNET/perun/pull/1107#discussion_r73441495","pull_request_url":"https://api.github.com/repos/CESNET/perun/pulls/1107","_links":{"self":{"href":"https://api.github.com/repos/CESNET/perun/pulls/comments/73441495"},"html":{"href":"https://github.com/CESNET/perun/pull/1107#discussion_r73441495"},"pull_request":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1107"}}},"pull_request":{"url":"https://api.github.com/repos/CESNET/perun/pulls/1107","id":61266366,"html_url":"https://github.com/CESNET/perun/pull/1107","diff_url":"https://github.com/CESNET/perun/pull/1107.diff","patch_url":"https://github.com/CESNET/perun/pull/1107.patch","issue_url":"https://api.github.com/repos/CESNET/perun/issues/1107","number":1107,"state":"open","locked":false,"title":"GroupArithmetic#2630","user":{"login":"Natrezim","id":7032372,"avatar_url":"https://avatars.githubusercontent.com/u/7032372?v=3","gravatar_id":"","url":"https://api.github.com/users/Natrezim","html_url":"https://github.com/Natrezim","followers_url":"https://api.github.com/users/Natrezim/followers","following_url":"https://api.github.com/users/Natrezim/following{/other_user}","gists_url":"https://api.github.com/users/Natrezim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natrezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natrezim/subscriptions","organizations_url":"https://api.github.com/users/Natrezim/orgs","repos_url":"https://api.github.com/users/Natrezim/repos","events_url":"https://api.github.com/users/Natrezim/events{/privacy}","received_events_url":"https://api.github.com/users/Natrezim/received_events","type":"User","site_admin":false},"body":"- member object now has sourceGroupId parameter. It defines from which\r\n  group is member propagated.\r\n- group union operation implemented\r\n- tests implemented","created_at":"2016-03-01T16:15:29Z","updated_at":"2016-08-03T23:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a816bed2ca0f760f7a32bc5c566b7d4d003ed06b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CESNET/perun/pulls/1107/commits","review_comments_url":"https://api.github.com/repos/CESNET/perun/pulls/1107/comments","review_comment_url":"https://api.github.com/repos/CESNET/perun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CESNET/perun/issues/1107/comments","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/95f79c30c856f5d24ec9e2580f7971a6c232a2b8","head":{"label":"Natrezim:groupUnionPush","ref":"groupUnionPush","sha":"95f79c30c856f5d24ec9e2580f7971a6c232a2b8","user":{"login":"Natrezim","id":7032372,"avatar_url":"https://avatars.githubusercontent.com/u/7032372?v=3","gravatar_id":"","url":"https://api.github.com/users/Natrezim","html_url":"https://github.com/Natrezim","followers_url":"https://api.github.com/users/Natrezim/followers","following_url":"https://api.github.com/users/Natrezim/following{/other_user}","gists_url":"https://api.github.com/users/Natrezim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natrezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natrezim/subscriptions","organizations_url":"https://api.github.com/users/Natrezim/orgs","repos_url":"https://api.github.com/users/Natrezim/repos","events_url":"https://api.github.com/users/Natrezim/events{/privacy}","received_events_url":"https://api.github.com/users/Natrezim/received_events","type":"User","site_admin":false},"repo":{"id":20745324,"name":"perun","full_name":"Natrezim/perun","owner":{"login":"Natrezim","id":7032372,"avatar_url":"https://avatars.githubusercontent.com/u/7032372?v=3","gravatar_id":"","url":"https://api.github.com/users/Natrezim","html_url":"https://github.com/Natrezim","followers_url":"https://api.github.com/users/Natrezim/followers","following_url":"https://api.github.com/users/Natrezim/following{/other_user}","gists_url":"https://api.github.com/users/Natrezim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natrezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natrezim/subscriptions","organizations_url":"https://api.github.com/users/Natrezim/orgs","repos_url":"https://api.github.com/users/Natrezim/repos","events_url":"https://api.github.com/users/Natrezim/events{/privacy}","received_events_url":"https://api.github.com/users/Natrezim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Natrezim/perun","description":"Users, Groups, Services and Resources Management System","fork":true,"url":"https://api.github.com/repos/Natrezim/perun","forks_url":"https://api.github.com/repos/Natrezim/perun/forks","keys_url":"https://api.github.com/repos/Natrezim/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Natrezim/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Natrezim/perun/teams","hooks_url":"https://api.github.com/repos/Natrezim/perun/hooks","issue_events_url":"https://api.github.com/repos/Natrezim/perun/issues/events{/number}","events_url":"https://api.github.com/repos/Natrezim/perun/events","assignees_url":"https://api.github.com/repos/Natrezim/perun/assignees{/user}","branches_url":"https://api.github.com/repos/Natrezim/perun/branches{/branch}","tags_url":"https://api.github.com/repos/Natrezim/perun/tags","blobs_url":"https://api.github.com/repos/Natrezim/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Natrezim/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Natrezim/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/Natrezim/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Natrezim/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/Natrezim/perun/languages","stargazers_url":"https://api.github.com/repos/Natrezim/perun/stargazers","contributors_url":"https://api.github.com/repos/Natrezim/perun/contributors","subscribers_url":"https://api.github.com/repos/Natrezim/perun/subscribers","subscription_url":"https://api.github.com/repos/Natrezim/perun/subscription","commits_url":"https://api.github.com/repos/Natrezim/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/Natrezim/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/Natrezim/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/Natrezim/perun/issues/comments{/number}","contents_url":"https://api.github.com/repos/Natrezim/perun/contents/{+path}","compare_url":"https://api.github.com/repos/Natrezim/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Natrezim/perun/merges","archive_url":"https://api.github.com/repos/Natrezim/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Natrezim/perun/downloads","issues_url":"https://api.github.com/repos/Natrezim/perun/issues{/number}","pulls_url":"https://api.github.com/repos/Natrezim/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/Natrezim/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/Natrezim/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Natrezim/perun/labels{/name}","releases_url":"https://api.github.com/repos/Natrezim/perun/releases{/id}","deployments_url":"https://api.github.com/repos/Natrezim/perun/deployments","created_at":"2014-06-11T21:42:34Z","updated_at":"2016-03-01T14:58:07Z","pushed_at":"2016-05-22T21:26:14Z","git_url":"git://github.com/Natrezim/perun.git","ssh_url":"git@github.com:Natrezim/perun.git","clone_url":"https://github.com/Natrezim/perun.git","svn_url":"https://github.com/Natrezim/perun","homepage":null,"size":26545,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CESNET:master","ref":"master","sha":"9bd99ff46b18897deecc4dc469452594f4df043b","user":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars.githubusercontent.com/u/1116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"repo":{"id":4085998,"name":"perun","full_name":"CESNET/perun","owner":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars.githubusercontent.com/u/1116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESNET/perun","description":"Identity and Access Management System","fork":false,"url":"https://api.github.com/repos/CESNET/perun","forks_url":"https://api.github.com/repos/CESNET/perun/forks","keys_url":"https://api.github.com/repos/CESNET/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESNET/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESNET/perun/teams","hooks_url":"https://api.github.com/repos/CESNET/perun/hooks","issue_events_url":"https://api.github.com/repos/CESNET/perun/issues/events{/number}","events_url":"https://api.github.com/repos/CESNET/perun/events","assignees_url":"https://api.github.com/repos/CESNET/perun/assignees{/user}","branches_url":"https://api.github.com/repos/CESNET/perun/branches{/branch}","tags_url":"https://api.github.com/repos/CESNET/perun/tags","blobs_url":"https://api.github.com/repos/CESNET/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESNET/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESNET/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESNET/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/CESNET/perun/languages","stargazers_url":"https://api.github.com/repos/CESNET/perun/stargazers","contributors_url":"https://api.github.com/repos/CESNET/perun/contributors","subscribers_url":"https://api.github.com/repos/CESNET/perun/subscribers","subscription_url":"https://api.github.com/repos/CESNET/perun/subscription","commits_url":"https://api.github.com/repos/CESNET/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESNET/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESNET/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESNET/perun/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESNET/perun/contents/{+path}","compare_url":"https://api.github.com/repos/CESNET/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESNET/perun/merges","archive_url":"https://api.github.com/repos/CESNET/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESNET/perun/downloads","issues_url":"https://api.github.com/repos/CESNET/perun/issues{/number}","pulls_url":"https://api.github.com/repos/CESNET/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/CESNET/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/CESNET/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESNET/perun/labels{/name}","releases_url":"https://api.github.com/repos/CESNET/perun/releases{/id}","deployments_url":"https://api.github.com/repos/CESNET/perun/deployments","created_at":"2012-04-20T11:55:38Z","updated_at":"2016-06-03T16:50:33Z","pushed_at":"2016-08-03T12:29:18Z","git_url":"git://github.com/CESNET/perun.git","ssh_url":"git@github.com:CESNET/perun.git","clone_url":"https://github.com/CESNET/perun.git","svn_url":"https://github.com/CESNET/perun","homepage":"http://perun.cesnet.cz","size":28997,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1107"},"html":{"href":"https://github.com/CESNET/perun/pull/1107"},"issue":{"href":"https://api.github.com/repos/CESNET/perun/issues/1107"},"comments":{"href":"https://api.github.com/repos/CESNET/perun/issues/1107/comments"},"review_comments":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1107/comments"},"review_comment":{"href":"https://api.github.com/repos/CESNET/perun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1107/commits"},"statuses":{"href":"https://api.github.com/repos/CESNET/perun/statuses/95f79c30c856f5d24ec9e2580f7971a6c232a2b8"}}}}
{"actor":{"display_login":"licehammer"}}