{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8152","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8152/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8152/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8152/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8152","id":158735057,"number":8152,"title":"Remove CWalletDB* parameter from CWallet::AddToWallet","user":{"login":"pstratem","id":620611,"avatar_url":"https://avatars.githubusercontent.com/u/620611?v=3","gravatar_id":"","url":"https://api.github.com/users/pstratem","html_url":"https://github.com/pstratem","followers_url":"https://api.github.com/users/pstratem/followers","following_url":"https://api.github.com/users/pstratem/following{/other_user}","gists_url":"https://api.github.com/users/pstratem/gists{/gist_id}","starred_url":"https://api.github.com/users/pstratem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstratem/subscriptions","organizations_url":"https://api.github.com/users/pstratem/orgs","repos_url":"https://api.github.com/users/pstratem/repos","events_url":"https://api.github.com/users/pstratem/events{/privacy}","received_events_url":"https://api.github.com/users/pstratem/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-06T17:48:25Z","updated_at":"2016-06-07T07:00:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8152","html_url":"https://github.com/bitcoin/bitcoin/pull/8152","diff_url":"https://github.com/bitcoin/bitcoin/pull/8152.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8152.patch"},"body":"This is the last method to pass a CWalletDB"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/224196799","html_url":"https://github.com/bitcoin/bitcoin/pull/8152#issuecomment-224196799","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8152","id":224196799,"user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T07:00:47Z","updated_at":"2016-06-07T07:00:47Z","body":"I think the persistent CWalletDb object here is just there to prevent a flush to disk in between every added transaction, for performance reasons. Based on earlier pull requests by @pstratem around this, I think he intends to re-introduce a single CWalletDb* inside CWallet rather than reopening one all the time, after cleaning things up. Perhaps that will need to be done in the same PR, though?"}}
{"actor":{"display_login":"sipa"}}