{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/67002968","id":67002968,"diff_hunk":"@@ -72,4 +72,79 @@ public void testGetPropertyByString() {\n     }\n     assertTrue(\"test was a dud, and did nothing\", found);\n   }\n+\n+  @Test\n+  public void testGetSinglePort() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"9997\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(1, ports.length);\n+    assertEquals(9997, ports[0]);\n+  }\n+\n+  @Test\n+  public void testGetAnyPort() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"0\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(1, ports.length);\n+    assertEquals(0, ports[0]);\n+  }\n+\n+  @Test\n+  public void testGetInvalidPort() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"1020\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(1, ports.length);\n+    assertEquals(Integer.parseInt(Property.TSERV_CLIENTPORT.getDefaultValue()), ports[0]);\n+  }\n+\n+  @Test\n+  public void testGetPortRange() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"9997-9999\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(3, ports.length);\n+    assertEquals(9997, ports[0]);\n+    assertEquals(9998, ports[1]);\n+    assertEquals(9999, ports[2]);\n+  }\n+\n+  @Test\n+  public void testGetPortRangeInvalidLow() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"1020-1026\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(3, ports.length);\n+    assertEquals(1024, ports[0]);\n+    assertEquals(1025, ports[1]);\n+    assertEquals(1026, ports[2]);\n+  }\n+\n+  @Test\n+  public void testGetPortRangeInvalidHigh() {\n+    AccumuloConfiguration c = AccumuloConfiguration.getDefaultConfiguration();\n+    ConfigurationCopy cc = new ConfigurationCopy(c);\n+    cc.set(Property.TSERV_CLIENTPORT, \"65533-65538\");\n+    int[] ports = cc.getPort(Property.TSERV_CLIENTPORT);\n+    assertEquals(3, ports.length);\n+    assertEquals(65533, ports[0]);\n+    assertEquals(65534, ports[1]);\n+    assertEquals(65535, ports[2]);\n+  }\n+\n+  @Test(expected = IllegalArgumentException.class)","path":"core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java","position":71,"original_position":71,"commit_id":"5c16cba961fcd03e67452a7911c856335c88094d","original_commit_id":"5c16cba961fcd03e67452a7911c856335c88094d","user":{"login":"dlmarion","id":567911,"avatar_url":"https://avatars.githubusercontent.com/u/567911?v=3","gravatar_id":"","url":"https://api.github.com/users/dlmarion","html_url":"https://github.com/dlmarion","followers_url":"https://api.github.com/users/dlmarion/followers","following_url":"https://api.github.com/users/dlmarion/following{/other_user}","gists_url":"https://api.github.com/users/dlmarion/gists{/gist_id}","starred_url":"https://api.github.com/users/dlmarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlmarion/subscriptions","organizations_url":"https://api.github.com/users/dlmarion/orgs","repos_url":"https://api.github.com/users/dlmarion/repos","events_url":"https://api.github.com/users/dlmarion/events{/privacy}","received_events_url":"https://api.github.com/users/dlmarion/received_events","type":"User","site_admin":false},"body":"Because the range syntax is M-N, not [M,N].","created_at":"2016-06-14T16:12:51Z","updated_at":"2016-06-14T16:12:51Z","html_url":"https://github.com/apache/accumulo/pull/111#discussion_r67002968","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/67002968"},"html":{"href":"https://github.com/apache/accumulo/pull/111#discussion_r67002968"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/111","id":73103067,"html_url":"https://github.com/apache/accumulo/pull/111","diff_url":"https://github.com/apache/accumulo/pull/111.diff","patch_url":"https://github.com/apache/accumulo/pull/111.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/111","number":111,"state":"closed","locked":false,"title":"ACCUMULO-4331: first draft","user":{"login":"dlmarion","id":567911,"avatar_url":"https://avatars.githubusercontent.com/u/567911?v=3","gravatar_id":"","url":"https://api.github.com/users/dlmarion","html_url":"https://github.com/dlmarion","followers_url":"https://api.github.com/users/dlmarion/followers","following_url":"https://api.github.com/users/dlmarion/following{/other_user}","gists_url":"https://api.github.com/users/dlmarion/gists{/gist_id}","starred_url":"https://api.github.com/users/dlmarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlmarion/subscriptions","organizations_url":"https://api.github.com/users/dlmarion/orgs","repos_url":"https://api.github.com/users/dlmarion/repos","events_url":"https://api.github.com/users/dlmarion/events{/privacy}","received_events_url":"https://api.github.com/users/dlmarion/received_events","type":"User","site_admin":false},"body":"First draft. Did not implement the range syntax that was proposed in later comments, but would be easy to swap out. There are some ports where it seemed not to make sense to support a range, log4j monitor port being one as its also set as a system property.","created_at":"2016-06-08T19:10:11Z","updated_at":"2016-06-14T16:12:51Z","closed_at":"2016-06-14T14:30:46Z","merged_at":null,"merge_commit_sha":"63b9340e92a74e19dfe9c6be6fea3603f89c243d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/111/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/111/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/111/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/5c16cba961fcd03e67452a7911c856335c88094d","head":{"label":"dlmarion:ACCUMULO-4331","ref":"ACCUMULO-4331","sha":"5c16cba961fcd03e67452a7911c856335c88094d","user":{"login":"dlmarion","id":567911,"avatar_url":"https://avatars.githubusercontent.com/u/567911?v=3","gravatar_id":"","url":"https://api.github.com/users/dlmarion","html_url":"https://github.com/dlmarion","followers_url":"https://api.github.com/users/dlmarion/followers","following_url":"https://api.github.com/users/dlmarion/following{/other_user}","gists_url":"https://api.github.com/users/dlmarion/gists{/gist_id}","starred_url":"https://api.github.com/users/dlmarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlmarion/subscriptions","organizations_url":"https://api.github.com/users/dlmarion/orgs","repos_url":"https://api.github.com/users/dlmarion/repos","events_url":"https://api.github.com/users/dlmarion/events{/privacy}","received_events_url":"https://api.github.com/users/dlmarion/received_events","type":"User","site_admin":false},"repo":{"id":45923929,"name":"accumulo","full_name":"dlmarion/accumulo","owner":{"login":"dlmarion","id":567911,"avatar_url":"https://avatars.githubusercontent.com/u/567911?v=3","gravatar_id":"","url":"https://api.github.com/users/dlmarion","html_url":"https://github.com/dlmarion","followers_url":"https://api.github.com/users/dlmarion/followers","following_url":"https://api.github.com/users/dlmarion/following{/other_user}","gists_url":"https://api.github.com/users/dlmarion/gists{/gist_id}","starred_url":"https://api.github.com/users/dlmarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlmarion/subscriptions","organizations_url":"https://api.github.com/users/dlmarion/orgs","repos_url":"https://api.github.com/users/dlmarion/repos","events_url":"https://api.github.com/users/dlmarion/events{/privacy}","received_events_url":"https://api.github.com/users/dlmarion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlmarion/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/dlmarion/accumulo","forks_url":"https://api.github.com/repos/dlmarion/accumulo/forks","keys_url":"https://api.github.com/repos/dlmarion/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlmarion/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlmarion/accumulo/teams","hooks_url":"https://api.github.com/repos/dlmarion/accumulo/hooks","issue_events_url":"https://api.github.com/repos/dlmarion/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/dlmarion/accumulo/events","assignees_url":"https://api.github.com/repos/dlmarion/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/dlmarion/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/dlmarion/accumulo/tags","blobs_url":"https://api.github.com/repos/dlmarion/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlmarion/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlmarion/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlmarion/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlmarion/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/dlmarion/accumulo/languages","stargazers_url":"https://api.github.com/repos/dlmarion/accumulo/stargazers","contributors_url":"https://api.github.com/repos/dlmarion/accumulo/contributors","subscribers_url":"https://api.github.com/repos/dlmarion/accumulo/subscribers","subscription_url":"https://api.github.com/repos/dlmarion/accumulo/subscription","commits_url":"https://api.github.com/repos/dlmarion/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlmarion/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlmarion/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlmarion/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlmarion/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/dlmarion/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlmarion/accumulo/merges","archive_url":"https://api.github.com/repos/dlmarion/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlmarion/accumulo/downloads","issues_url":"https://api.github.com/repos/dlmarion/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/dlmarion/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/dlmarion/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/dlmarion/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlmarion/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/dlmarion/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/dlmarion/accumulo/deployments","created_at":"2015-11-10T16:16:16Z","updated_at":"2016-03-25T15:09:12Z","pushed_at":"2016-06-14T13:45:56Z","git_url":"git://github.com/dlmarion/accumulo.git","ssh_url":"git@github.com:dlmarion/accumulo.git","clone_url":"https://github.com/dlmarion/accumulo.git","svn_url":"https://github.com/dlmarion/accumulo","homepage":"","size":50893,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:1.8","ref":"1.8","sha":"24289e2c4c32850185b8649a5022b495c3205a83","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Mirror of Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2016-06-09T15:59:31Z","pushed_at":"2016-06-14T15:05:22Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"","size":66204,"stargazers_count":229,"watchers_count":229,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":124,"mirror_url":"git://git.apache.org/accumulo.git","open_issues_count":3,"forks":124,"open_issues":3,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/111"},"html":{"href":"https://github.com/apache/accumulo/pull/111"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/111"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/5c16cba961fcd03e67452a7911c856335c88094d"}}}}
{"actor":{"display_login":"dlmarion"}}