{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments/65312734","id":65312734,"diff_hunk":"@@ -88,12 +97,12 @@ Creates a default instance of TradingCalendar according to current parameters (c\n sub build_trading_calendar {\n     my $self = shift;\n \n-    return Quant::Framework::TradingCalendar->new({\n-            symbol => $self->underlying_config->exchange_name,\n-            chronicle_reader => $self->chronicle_reader,\n-            (($self->underlying_config->locale) ? (locale => $self->underlying_config->locale) :()),\n-            for_date => $self->for_date\n-        });\n+    return Quant::Framework::TradingCalendar->new(\n+            $self->underlying_config->exchange_name,\n+            $self->chronicle_reader,\n+            ($self->underlying_config->locale) ? $self->underlying_config->locale : undef,","path":"lib/Quant/Framework/Utils/Builder.pm","position":29,"original_position":29,"commit_id":"dd6d1444986bc57b559c0804870514a34c7b958c","original_commit_id":"dd6d1444986bc57b559c0804870514a34c7b958c","user":{"login":"yngshan","id":7992011,"avatar_url":"https://avatars.githubusercontent.com/u/7992011?v=3","gravatar_id":"","url":"https://api.github.com/users/yngshan","html_url":"https://github.com/yngshan","followers_url":"https://api.github.com/users/yngshan/followers","following_url":"https://api.github.com/users/yngshan/following{/other_user}","gists_url":"https://api.github.com/users/yngshan/gists{/gist_id}","starred_url":"https://api.github.com/users/yngshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yngshan/subscriptions","organizations_url":"https://api.github.com/users/yngshan/orgs","repos_url":"https://api.github.com/users/yngshan/repos","events_url":"https://api.github.com/users/yngshan/events{/privacy}","received_events_url":"https://api.github.com/users/yngshan/received_events","type":"User","site_admin":false},"body":"why you no need to pass in symbol , for_date, chronicle_reader anymore here ? Dont they are expect parameter?","created_at":"2016-06-01T07:20:55Z","updated_at":"2016-06-01T07:20:55Z","html_url":"https://github.com/binary-com/perl-Quant-Framework/pull/19#discussion_r65312734","pull_request_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments/65312734"},"html":{"href":"https://github.com/binary-com/perl-Quant-Framework/pull/19#discussion_r65312734"},"pull_request":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19","id":69620332,"html_url":"https://github.com/binary-com/perl-Quant-Framework/pull/19","diff_url":"https://github.com/binary-com/perl-Quant-Framework/pull/19.diff","patch_url":"https://github.com/binary-com/perl-Quant-Framework/pull/19.patch","issue_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/19","number":19,"state":"open","locked":false,"title":"modules initially moved from internal code","user":{"login":"mm-binary","id":9294049,"avatar_url":"https://avatars.githubusercontent.com/u/9294049?v=3","gravatar_id":"","url":"https://api.github.com/users/mm-binary","html_url":"https://github.com/mm-binary","followers_url":"https://api.github.com/users/mm-binary/followers","following_url":"https://api.github.com/users/mm-binary/following{/other_user}","gists_url":"https://api.github.com/users/mm-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/mm-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mm-binary/subscriptions","organizations_url":"https://api.github.com/users/mm-binary/orgs","repos_url":"https://api.github.com/users/mm-binary/repos","events_url":"https://api.github.com/users/mm-binary/events{/privacy}","received_events_url":"https://api.github.com/users/mm-binary/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-11T06:21:24Z","updated_at":"2016-06-01T07:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6114208e99be1277b10efe8ca809d175ffc123a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19/commits","review_comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19/comments","review_comment_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/19/comments","statuses_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/dd6d1444986bc57b559c0804870514a34c7b958c","head":{"label":"mm-binary:mm/vol_surface","ref":"mm/vol_surface","sha":"dd6d1444986bc57b559c0804870514a34c7b958c","user":{"login":"mm-binary","id":9294049,"avatar_url":"https://avatars.githubusercontent.com/u/9294049?v=3","gravatar_id":"","url":"https://api.github.com/users/mm-binary","html_url":"https://github.com/mm-binary","followers_url":"https://api.github.com/users/mm-binary/followers","following_url":"https://api.github.com/users/mm-binary/following{/other_user}","gists_url":"https://api.github.com/users/mm-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/mm-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mm-binary/subscriptions","organizations_url":"https://api.github.com/users/mm-binary/orgs","repos_url":"https://api.github.com/users/mm-binary/repos","events_url":"https://api.github.com/users/mm-binary/events{/privacy}","received_events_url":"https://api.github.com/users/mm-binary/received_events","type":"User","site_admin":false},"repo":{"id":50819638,"name":"perl-Quant-Framework","full_name":"mm-binary/perl-Quant-Framework","owner":{"login":"mm-binary","id":9294049,"avatar_url":"https://avatars.githubusercontent.com/u/9294049?v=3","gravatar_id":"","url":"https://api.github.com/users/mm-binary","html_url":"https://github.com/mm-binary","followers_url":"https://api.github.com/users/mm-binary/followers","following_url":"https://api.github.com/users/mm-binary/following{/other_user}","gists_url":"https://api.github.com/users/mm-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/mm-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mm-binary/subscriptions","organizations_url":"https://api.github.com/users/mm-binary/orgs","repos_url":"https://api.github.com/users/mm-binary/repos","events_url":"https://api.github.com/users/mm-binary/events{/privacy}","received_events_url":"https://api.github.com/users/mm-binary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mm-binary/perl-Quant-Framework","description":"A framework of objects upon which to build Financial Quantitative Analysis code","fork":true,"url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework","forks_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/forks","keys_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/teams","hooks_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/hooks","issue_events_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/events","assignees_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/tags","blobs_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/languages","stargazers_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/stargazers","contributors_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/contributors","subscribers_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/subscribers","subscription_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/subscription","commits_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/merges","archive_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/downloads","issues_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/labels{/name}","releases_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/mm-binary/perl-Quant-Framework/deployments","created_at":"2016-02-01T06:36:04Z","updated_at":"2016-02-26T08:47:59Z","pushed_at":"2016-06-01T05:21:21Z","git_url":"git://github.com/mm-binary/perl-Quant-Framework.git","ssh_url":"git@github.com:mm-binary/perl-Quant-Framework.git","clone_url":"https://github.com/mm-binary/perl-Quant-Framework.git","svn_url":"https://github.com/mm-binary/perl-Quant-Framework","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binary-com:master","ref":"master","sha":"bc9253029936fa2b5a7c85ac18b6eaca3aa82fde","user":{"login":"binary-com","id":7437559,"avatar_url":"https://avatars.githubusercontent.com/u/7437559?v=3","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":50404733,"name":"perl-Quant-Framework","full_name":"binary-com/perl-Quant-Framework","owner":{"login":"binary-com","id":7437559,"avatar_url":"https://avatars.githubusercontent.com/u/7437559?v=3","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binary-com/perl-Quant-Framework","description":"A framework of objects upon which to build Financial Quantitative Analysis code","fork":false,"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework","forks_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/forks","keys_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/teams","hooks_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/hooks","issue_events_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/events","assignees_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/tags","blobs_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/languages","stargazers_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/stargazers","contributors_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/contributors","subscribers_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/subscribers","subscription_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/subscription","commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/merges","archive_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/downloads","issues_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/deployments","created_at":"2016-01-26T05:05:38Z","updated_at":"2016-03-24T01:59:42Z","pushed_at":"2016-06-01T05:21:22Z","git_url":"git://github.com/binary-com/perl-Quant-Framework.git","ssh_url":"git@github.com:binary-com/perl-Quant-Framework.git","clone_url":"https://github.com/binary-com/perl-Quant-Framework.git","svn_url":"https://github.com/binary-com/perl-Quant-Framework","homepage":null,"size":374,"stargazers_count":2,"watchers_count":2,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19"},"html":{"href":"https://github.com/binary-com/perl-Quant-Framework/pull/19"},"issue":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/19"},"comments":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/dd6d1444986bc57b559c0804870514a34c7b958c"}}}}
{"actor":{"display_login":"yngshan"}}