{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15710","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15710/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15710/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15710/events","html_url":"https://github.com/cms-sw/cmssw/pull/15710","id":174820783,"number":15710,"title":"Vertex Reconstruction with Timing 810","user":{"login":"lgray","id":1068089,"avatar_url":"https://avatars.githubusercontent.com/u/1068089?v=3","gravatar_id":"","url":"https://api.github.com/users/lgray","html_url":"https://github.com/lgray","followers_url":"https://api.github.com/users/lgray/followers","following_url":"https://api.github.com/users/lgray/following{/other_user}","gists_url":"https://api.github.com/users/lgray/gists{/gist_id}","starred_url":"https://api.github.com/users/lgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgray/subscriptions","organizations_url":"https://api.github.com/users/lgray/orgs","repos_url":"https://api.github.com/users/lgray/repos","events_url":"https://api.github.com/users/lgray/events{/privacy}","received_events_url":"https://api.github.com/users/lgray/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-approved","name":"core-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":1485,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-20T22:37:20Z","due_on":null,"closed_at":null},"comments":118,"created_at":"2016-09-02T18:27:17Z","updated_at":"2016-09-21T02:18:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15710","html_url":"https://github.com/cms-sw/cmssw/pull/15710","diff_url":"https://github.com/cms-sw/cmssw/pull/15710.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15710.patch"},"body":"This is a forward port of:\r\n- #12290 & #12962\r\n\r\nIt implements in reco::Vertex and the vertex finding/fitting machinery the ability to cluster in time in addition to space.\r\n\r\nThe track times are extracted from the matched sim-track of the reconstructed track and saved as ValueMaps.\r\n\r\nIn order to seemlessly switch between timing and no timing I have implemented the underlying GlobalError and Positions as four vectors instead of three vectors. Extending an interface to deal with the new dimension, and using the old interface for the original 3D algorithms. \r\n\r\nThe physics performance of the 3D algorithms (i.e. present LHC vertex reco) should be (and from local tests is) unaffected by this change. There may be minor performance drawbacks due to the way the backwards compatibility is kept. Alternative recommendations are welcome.\r\n\r\nThe timing is integrated directly into the phase 2 tracking reconstruction era. The overhead is fairly small.\r\n\r\n@bendavid @kpedro88"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/248492413","html_url":"https://github.com/cms-sw/cmssw/pull/15710#issuecomment-248492413","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15710","id":248492413,"user":{"login":"monttj","id":4115236,"avatar_url":"https://avatars.githubusercontent.com/u/4115236?v=3","gravatar_id":"","url":"https://api.github.com/users/monttj","html_url":"https://github.com/monttj","followers_url":"https://api.github.com/users/monttj/followers","following_url":"https://api.github.com/users/monttj/following{/other_user}","gists_url":"https://api.github.com/users/monttj/gists{/gist_id}","starred_url":"https://api.github.com/users/monttj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monttj/subscriptions","organizations_url":"https://api.github.com/users/monttj/orgs","repos_url":"https://api.github.com/users/monttj/repos","events_url":"https://api.github.com/users/monttj/events{/privacy}","received_events_url":"https://api.github.com/users/monttj/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T02:18:50Z","updated_at":"2016-09-21T02:18:50Z","body":"+1\r\nThere seems no issues from analysis side with this PR. \r\nIt is about adding vector<float> type in the PAT candidate dictionary. "}}
{"actor":{"display_login":"monttj"}}