{"action":"opened","number":19274,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19274","id":76071618,"html_url":"https://github.com/symfony/symfony/pull/19274","diff_url":"https://github.com/symfony/symfony/pull/19274.diff","patch_url":"https://github.com/symfony/symfony/pull/19274.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19274","number":19274,"state":"open","locked":false,"title":"Mark getRouteCollection() as internal","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/pull/19270#issuecomment-230111301\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThe `getRouteCollection()` method should not be used in runtime as it'll rebuild the routing cache. It should be marked as internal and removed from the interface in 4.0.\r\n\r\nI'm not sure how to mark it as being removed from the interface, end up deprecating it (but `Router::getRouteCollection()` isn't deprecated and shouldn't).","created_at":"2016-07-02T18:23:31Z","updated_at":"2016-07-02T18:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dd5f68821a5f953068435c0ee00504e8a8dde41","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19274/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19274/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19274/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/a5796a72b5929a63cfaa6abcb7e783ac5d953661","head":{"label":"WouterJ:deprecate-getRouteCollection","ref":"deprecate-getRouteCollection","sha":"a5796a72b5929a63cfaa6abcb7e783ac5d953661","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"WouterJ/symfony","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony","forks_url":"https://api.github.com/repos/WouterJ/symfony/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/WouterJ/symfony/deployments","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2016-07-02T18:19:02Z","git_url":"git://github.com/WouterJ/symfony.git","ssh_url":"git@github.com:WouterJ/symfony.git","clone_url":"https://github.com/WouterJ/symfony.git","svn_url":"https://github.com/WouterJ/symfony","homepage":"symfony.com","size":69389,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"d9f1a72fff2cd13e230c7df59d9ff4dc34a69605","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-07-02T17:44:26Z","pushed_at":"2016-07-02T18:07:49Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":135074,"stargazers_count":12586,"watchers_count":12586,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4918,"mirror_url":null,"open_issues_count":658,"forks":4918,"open_issues":658,"watchers":12586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19274"},"html":{"href":"https://github.com/symfony/symfony/pull/19274"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19274"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19274/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19274/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19274/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/a5796a72b5929a63cfaa6abcb7e783ac5d953661"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"WouterJ"}}