{"action":"created","issue":{"url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/548","repository_url":"https://api.github.com/repos/fsouza/go-dockerclient","labels_url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/548/labels{/name}","comments_url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/548/comments","events_url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/548/events","html_url":"https://github.com/fsouza/go-dockerclient/issues/548","id":165469331,"number":548,"title":"omitempty should remain for Cmd and Entrypoint","user":{"login":"xh4n3","id":4469022,"avatar_url":"https://avatars.githubusercontent.com/u/4469022?v=3","gravatar_id":"","url":"https://api.github.com/users/xh4n3","html_url":"https://github.com/xh4n3","followers_url":"https://api.github.com/users/xh4n3/followers","following_url":"https://api.github.com/users/xh4n3/following{/other_user}","gists_url":"https://api.github.com/users/xh4n3/gists{/gist_id}","starred_url":"https://api.github.com/users/xh4n3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh4n3/subscriptions","organizations_url":"https://api.github.com/users/xh4n3/orgs","repos_url":"https://api.github.com/users/xh4n3/repos","events_url":"https://api.github.com/users/xh4n3/events{/privacy}","received_events_url":"https://api.github.com/users/xh4n3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-14T03:39:03Z","updated_at":"2016-08-17T09:14:22Z","closed_at":null,"body":"Hi @fsouza @ybogdanov,\r\n\r\nSorry to pull this old issue out.\r\n[omitempty for Cmd and Entrypoint](https://github.com/fsouza/go-dockerclient/issues/314)\r\n\r\nPersonally I think the solution is wrong. If anyone wants to rewrite a base image setting, that's a issue of base image, we probably should leave that option blank.\r\nIn addition, if removing omitempty is correct, we should also remove omitempty for other fields in the Config struct, e.g. Env, DNS.\r\n\r\nSo I suggest you @ybogdanov could considering to change your base image's setting instead of leaving these two fields Cmd and Entrypoint to be treated specially.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/comments/240357706","html_url":"https://github.com/fsouza/go-dockerclient/issues/548#issuecomment-240357706","issue_url":"https://api.github.com/repos/fsouza/go-dockerclient/issues/548","id":240357706,"user":{"login":"ybogdanov","id":292569,"avatar_url":"https://avatars.githubusercontent.com/u/292569?v=3","gravatar_id":"","url":"https://api.github.com/users/ybogdanov","html_url":"https://github.com/ybogdanov","followers_url":"https://api.github.com/users/ybogdanov/followers","following_url":"https://api.github.com/users/ybogdanov/following{/other_user}","gists_url":"https://api.github.com/users/ybogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ybogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybogdanov/subscriptions","organizations_url":"https://api.github.com/users/ybogdanov/orgs","repos_url":"https://api.github.com/users/ybogdanov/repos","events_url":"https://api.github.com/users/ybogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/ybogdanov/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T09:14:22Z","updated_at":"2016-08-17T09:14:22Z","body":"@xh4n3 Hm. Let me think of your case, I'll come back later."}}
{"actor":{"display_login":"ybogdanov"}}