{"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments/75157264","id":75157264,"diff_hunk":"@@ -1251,9 +1416,9 @@ int process_device_udp_packet (uint8_t *data, int data_len)\n \n             // if transparent DNS is enabled, any packet arriving at out netif\n             // address to port 53 is considered a DNS packet\n-            is_dns = (options.udpgw_transparent_dns &&\n-                      ipv4_header.destination_address == netif_ipaddr.ipv4 &&\n-                      udp_header.dest_port == hton16(53));\n+            is_dns = (options.transparent_dns &&\n+                      // ipv4_header.destination_address == netif_ipaddr.ipv4 &&","path":"src/badvpn/tun2socks/tun2socks.c","position":null,"original_position":423,"commit_id":"35b12a25e2680764a71f2bf259238f696ab6e282","original_commit_id":"86dd5ed9f88a9ad8ca6196553ac9ca5a8dcd431a","user":{"login":"albertolalama","id":2132122,"avatar_url":"https://avatars.githubusercontent.com/u/2132122?v=3","gravatar_id":"","url":"https://api.github.com/users/albertolalama","html_url":"https://github.com/albertolalama","followers_url":"https://api.github.com/users/albertolalama/followers","following_url":"https://api.github.com/users/albertolalama/following{/other_user}","gists_url":"https://api.github.com/users/albertolalama/gists{/gist_id}","starred_url":"https://api.github.com/users/albertolalama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertolalama/subscriptions","organizations_url":"https://api.github.com/users/albertolalama/orgs","repos_url":"https://api.github.com/users/albertolalama/repos","events_url":"https://api.github.com/users/albertolalama/events{/privacy}","received_events_url":"https://api.github.com/users/albertolalama/received_events","type":"User","site_admin":false},"body":"I had commented out this line to check if we were receiving non-DNS UDP packets.\r\nIt should be uncommented.","created_at":"2016-08-17T16:28:43Z","updated_at":"2016-08-17T16:28:43Z","html_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3#discussion_r75157264","pull_request_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments/75157264"},"html":{"href":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3#discussion_r75157264"},"pull_request":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3","id":79408369,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3","diff_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3.diff","patch_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3.patch","issue_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/3","number":3,"state":"open","locked":false,"title":"Plugin implementation","user":{"login":"albertolalama","id":2132122,"avatar_url":"https://avatars.githubusercontent.com/u/2132122?v=3","gravatar_id":"","url":"https://api.github.com/users/albertolalama","html_url":"https://github.com/albertolalama","followers_url":"https://api.github.com/users/albertolalama/followers","following_url":"https://api.github.com/users/albertolalama/following{/other_user}","gists_url":"https://api.github.com/users/albertolalama/gists{/gist_id}","starred_url":"https://api.github.com/users/albertolalama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertolalama/subscriptions","organizations_url":"https://api.github.com/users/albertolalama/orgs","repos_url":"https://api.github.com/users/albertolalama/repos","events_url":"https://api.github.com/users/albertolalama/events{/privacy}","received_events_url":"https://api.github.com/users/albertolalama/received_events","type":"User","site_admin":false},"body":"* All of the plugin's functionality is included in these changes.\r\n* The main commits contain modifications to tun2socks [(commit)](https://github.com/uProxy/cordova-plugin-tun2socks/commit/39929e5f4751662286a0020a9d7f30975b542fa6) and Psiphon [(commit)] (https://github.com/uProxy/cordova-plugin-tun2socks/commit/f1b880f002ea162cfcfcd60f94c1688a508c624a).\r\n* Once the code is reviewed, the plugin's import path should be updated  in uProxy's Gruntfile.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/cordova-plugin-tun2socks/3)\n<!-- Reviewable:end -->\n","created_at":"2016-07-29T19:07:21Z","updated_at":"2016-08-17T16:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bba07d9d572dc5d190b6725ee215258738879cde","assignee":{"login":"bemasc","id":191945,"avatar_url":"https://avatars.githubusercontent.com/u/191945?v=3","gravatar_id":"","url":"https://api.github.com/users/bemasc","html_url":"https://github.com/bemasc","followers_url":"https://api.github.com/users/bemasc/followers","following_url":"https://api.github.com/users/bemasc/following{/other_user}","gists_url":"https://api.github.com/users/bemasc/gists{/gist_id}","starred_url":"https://api.github.com/users/bemasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemasc/subscriptions","organizations_url":"https://api.github.com/users/bemasc/orgs","repos_url":"https://api.github.com/users/bemasc/repos","events_url":"https://api.github.com/users/bemasc/events{/privacy}","received_events_url":"https://api.github.com/users/bemasc/received_events","type":"User","site_admin":false},"assignees":[{"login":"bemasc","id":191945,"avatar_url":"https://avatars.githubusercontent.com/u/191945?v=3","gravatar_id":"","url":"https://api.github.com/users/bemasc","html_url":"https://github.com/bemasc","followers_url":"https://api.github.com/users/bemasc/followers","following_url":"https://api.github.com/users/bemasc/following{/other_user}","gists_url":"https://api.github.com/users/bemasc/gists{/gist_id}","starred_url":"https://api.github.com/users/bemasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemasc/subscriptions","organizations_url":"https://api.github.com/users/bemasc/orgs","repos_url":"https://api.github.com/users/bemasc/repos","events_url":"https://api.github.com/users/bemasc/events{/privacy}","received_events_url":"https://api.github.com/users/bemasc/received_events","type":"User","site_admin":false},{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3/commits","review_comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3/comments","review_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/3/comments","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/35b12a25e2680764a71f2bf259238f696ab6e282","head":{"label":"uProxy:alalama-changes","ref":"alalama-changes","sha":"35b12a25e2680764a71f2bf259238f696ab6e282","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":61642646,"name":"cordova-plugin-tun2socks","full_name":"uProxy/cordova-plugin-tun2socks","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks","description":"","fork":false,"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks","forks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/forks","keys_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/teams","hooks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/hooks","issue_events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/events","assignees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/tags","blobs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/languages","stargazers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/stargazers","contributors_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contributors","subscribers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscribers","subscription_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscription","commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/merges","archive_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/downloads","issues_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/deployments","created_at":"2016-06-21T14:53:44Z","updated_at":"2016-08-01T03:20:52Z","pushed_at":"2016-08-17T16:28:38Z","git_url":"git://github.com/uProxy/cordova-plugin-tun2socks.git","ssh_url":"git@github.com:uProxy/cordova-plugin-tun2socks.git","clone_url":"https://github.com/uProxy/cordova-plugin-tun2socks.git","svn_url":"https://github.com/uProxy/cordova-plugin-tun2socks","homepage":null,"size":1903,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"773b88e02ef29fc270ffb246c50b67b72a2ece81","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":61642646,"name":"cordova-plugin-tun2socks","full_name":"uProxy/cordova-plugin-tun2socks","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks","description":"","fork":false,"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks","forks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/forks","keys_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/teams","hooks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/hooks","issue_events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/events","assignees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/tags","blobs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/languages","stargazers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/stargazers","contributors_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contributors","subscribers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscribers","subscription_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscription","commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/merges","archive_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/downloads","issues_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/deployments","created_at":"2016-06-21T14:53:44Z","updated_at":"2016-08-01T03:20:52Z","pushed_at":"2016-08-17T16:28:38Z","git_url":"git://github.com/uProxy/cordova-plugin-tun2socks.git","ssh_url":"git@github.com:uProxy/cordova-plugin-tun2socks.git","clone_url":"https://github.com/uProxy/cordova-plugin-tun2socks.git","svn_url":"https://github.com/uProxy/cordova-plugin-tun2socks","homepage":null,"size":1903,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3"},"html":{"href":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/3"},"issue":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/3"},"comments":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/35b12a25e2680764a71f2bf259238f696ab6e282"}}}}
{"actor":{"display_login":"albertolalama"}}