{"action":"closed","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1350","repository_url":"https://api.github.com/repos/facebook/AsyncDisplayKit","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1350/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1350/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1350/events","html_url":"https://github.com/facebook/AsyncDisplayKit/issues/1350","id":139677639,"number":1350,"title":"[ASTextNode] Truncation token not visible when maximumNumberOfLines = 0","user":{"login":"tomizimobile","id":7967500,"avatar_url":"https://avatars.githubusercontent.com/u/7967500?v=3","gravatar_id":"","url":"https://api.github.com/users/tomizimobile","html_url":"https://github.com/tomizimobile","followers_url":"https://api.github.com/users/tomizimobile/followers","following_url":"https://api.github.com/users/tomizimobile/following{/other_user}","gists_url":"https://api.github.com/users/tomizimobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tomizimobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomizimobile/subscriptions","organizations_url":"https://api.github.com/users/tomizimobile/orgs","repos_url":"https://api.github.com/users/tomizimobile/repos","events_url":"https://api.github.com/users/tomizimobile/events{/privacy}","received_events_url":"https://api.github.com/users/tomizimobile/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-09T19:31:56Z","updated_at":"2016-06-17T12:38:29Z","closed_at":"2016-06-17T12:38:29Z","body":"I have an ASViewController that includes an ASTextNode (among other views) that initially has `maximumNumberOfLines` set to 4. When the truncation token is pressed, the `maximumNumberOfLines` is set to 0, and allows the whole text to be visible. The layoutSpec for the viewController node ensures that nothing gets pushed off the screen, so if the text is very long, it may still need truncation again (and if the truncation token is tapped again, I bring them to a different view). In this case, the truncation token doesn't appear - however, the area where it should appear _does_ respond to touches and shows highlights, so it seems that part of it works as expected. I believe the truncation token doesn't show because at the time `-_truncate()` is called in ASTextKitTailTruncater, the textContainer size is +Inf, so the visibleCharacterRange is the whole range. I am not familiar enough with this to come up with a good fix, but I'm betting that truncating after the size is constrained would fix this."}}
{"actor":{"display_login":"tomizimobile"}}