{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/comments/81518494","pull_request_review_id":2492258,"id":81518494,"diff_hunk":"@@ -67,6 +67,16 @@ build-requirements:\n \t$(TEMPDIR)/bin/pip install -Ue \".[monitoring,postgresql]\"\n \t$(TEMPDIR)/bin/pip freeze > requirements.txt\n \n+update-kinto-admin:\n+\trm -fr kinto_admin/static/*\n+\trm -fr tmp\n+\tgit clone https://github.com/Kinto/kinto-admin.git tmp\n+\tcd tmp; git checkout $$(git tag | tail -n 1); npm install\n+\tcd tmp; KINTO_ADMIN_PUBLIC_PATH=/v1/admin/ npm run dist\n+\tcp -fr tmp/dist/* kinto_admin/static/","path":"Makefile","position":10,"original_position":10,"commit_id":"2f9f004043da538f1d3f01ae1292b654748515ba","original_commit_id":"2f9f004043da538f1d3f01ae1292b654748515ba","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=3","gravatar_id":"","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":"Same here, I think the path is wrong.","created_at":"2016-10-03T09:40:48Z","updated_at":"2016-10-03T09:43:13Z","html_url":"https://github.com/Kinto/kinto/pull/843#discussion_r81518494","pull_request_url":"https://api.github.com/repos/Kinto/kinto/pulls/843","_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments/81518494"},"html":{"href":"https://github.com/Kinto/kinto/pull/843#discussion_r81518494"},"pull_request":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/843"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/843","id":87638399,"html_url":"https://github.com/Kinto/kinto/pull/843","diff_url":"https://github.com/Kinto/kinto/pull/843.diff","patch_url":"https://github.com/Kinto/kinto/pull/843.patch","issue_url":"https://api.github.com/repos/Kinto/kinto/issues/843","number":843,"state":"open","locked":false,"title":"Move kinto-admin plugin as built in plugin in Kinto","user":{"login":"VarnaSuresh","id":8169932,"avatar_url":"https://avatars.githubusercontent.com/u/8169932?v=3","gravatar_id":"","url":"https://api.github.com/users/VarnaSuresh","html_url":"https://github.com/VarnaSuresh","followers_url":"https://api.github.com/users/VarnaSuresh/followers","following_url":"https://api.github.com/users/VarnaSuresh/following{/other_user}","gists_url":"https://api.github.com/users/VarnaSuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/VarnaSuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VarnaSuresh/subscriptions","organizations_url":"https://api.github.com/users/VarnaSuresh/orgs","repos_url":"https://api.github.com/users/VarnaSuresh/repos","events_url":"https://api.github.com/users/VarnaSuresh/events{/privacy}","received_events_url":"https://api.github.com/users/VarnaSuresh/received_events","type":"User","site_admin":false},"body":"Fixes #831\r\n\r\n- [ ] Add documentation.\r\n- [ ] Add tests.\r\n- [ ] Add a changelog entry.\r\n- [ ] Add your name in the contributors file.\r\n- [ ] If you changed the HTTP API, update the [API_VERSION](https://github.com/Kinto/kinto/blob/master/kinto/__init__.py#L15) constant and add an API changelog entry [in the docs](https://github.com/Kinto/kinto/blob/master/docs/api/index.rst)\r\n\r\nr? @\r\n","created_at":"2016-10-02T16:26:29Z","updated_at":"2016-10-03T09:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"079c0f43d9342dd8929589054265a398c52d302a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kinto/kinto/pulls/843/commits","review_comments_url":"https://api.github.com/repos/Kinto/kinto/pulls/843/comments","review_comment_url":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/kinto/issues/843/comments","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/2f9f004043da538f1d3f01ae1292b654748515ba","head":{"label":"VarnaSuresh:master","ref":"master","sha":"2f9f004043da538f1d3f01ae1292b654748515ba","user":{"login":"VarnaSuresh","id":8169932,"avatar_url":"https://avatars.githubusercontent.com/u/8169932?v=3","gravatar_id":"","url":"https://api.github.com/users/VarnaSuresh","html_url":"https://github.com/VarnaSuresh","followers_url":"https://api.github.com/users/VarnaSuresh/followers","following_url":"https://api.github.com/users/VarnaSuresh/following{/other_user}","gists_url":"https://api.github.com/users/VarnaSuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/VarnaSuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VarnaSuresh/subscriptions","organizations_url":"https://api.github.com/users/VarnaSuresh/orgs","repos_url":"https://api.github.com/users/VarnaSuresh/repos","events_url":"https://api.github.com/users/VarnaSuresh/events{/privacy}","received_events_url":"https://api.github.com/users/VarnaSuresh/received_events","type":"User","site_admin":false},"repo":{"id":68713537,"name":"kinto","full_name":"VarnaSuresh/kinto","owner":{"login":"VarnaSuresh","id":8169932,"avatar_url":"https://avatars.githubusercontent.com/u/8169932?v=3","gravatar_id":"","url":"https://api.github.com/users/VarnaSuresh","html_url":"https://github.com/VarnaSuresh","followers_url":"https://api.github.com/users/VarnaSuresh/followers","following_url":"https://api.github.com/users/VarnaSuresh/following{/other_user}","gists_url":"https://api.github.com/users/VarnaSuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/VarnaSuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VarnaSuresh/subscriptions","organizations_url":"https://api.github.com/users/VarnaSuresh/orgs","repos_url":"https://api.github.com/users/VarnaSuresh/repos","events_url":"https://api.github.com/users/VarnaSuresh/events{/privacy}","received_events_url":"https://api.github.com/users/VarnaSuresh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VarnaSuresh/kinto","description":"A minimalist JSON storage service with synchronisation and sharing abilities.","fork":true,"url":"https://api.github.com/repos/VarnaSuresh/kinto","forks_url":"https://api.github.com/repos/VarnaSuresh/kinto/forks","keys_url":"https://api.github.com/repos/VarnaSuresh/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VarnaSuresh/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VarnaSuresh/kinto/teams","hooks_url":"https://api.github.com/repos/VarnaSuresh/kinto/hooks","issue_events_url":"https://api.github.com/repos/VarnaSuresh/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/VarnaSuresh/kinto/events","assignees_url":"https://api.github.com/repos/VarnaSuresh/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/VarnaSuresh/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/VarnaSuresh/kinto/tags","blobs_url":"https://api.github.com/repos/VarnaSuresh/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VarnaSuresh/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VarnaSuresh/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/VarnaSuresh/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VarnaSuresh/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/VarnaSuresh/kinto/languages","stargazers_url":"https://api.github.com/repos/VarnaSuresh/kinto/stargazers","contributors_url":"https://api.github.com/repos/VarnaSuresh/kinto/contributors","subscribers_url":"https://api.github.com/repos/VarnaSuresh/kinto/subscribers","subscription_url":"https://api.github.com/repos/VarnaSuresh/kinto/subscription","commits_url":"https://api.github.com/repos/VarnaSuresh/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/VarnaSuresh/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/VarnaSuresh/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/VarnaSuresh/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/VarnaSuresh/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/VarnaSuresh/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VarnaSuresh/kinto/merges","archive_url":"https://api.github.com/repos/VarnaSuresh/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VarnaSuresh/kinto/downloads","issues_url":"https://api.github.com/repos/VarnaSuresh/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/VarnaSuresh/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/VarnaSuresh/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/VarnaSuresh/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VarnaSuresh/kinto/labels{/name}","releases_url":"https://api.github.com/repos/VarnaSuresh/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/VarnaSuresh/kinto/deployments","created_at":"2016-09-20T13:15:51Z","updated_at":"2016-09-20T13:15:52Z","pushed_at":"2016-10-02T16:21:02Z","git_url":"git://github.com/VarnaSuresh/kinto.git","ssh_url":"git@github.com:VarnaSuresh/kinto.git","clone_url":"https://github.com/VarnaSuresh/kinto.git","svn_url":"https://github.com/VarnaSuresh/kinto","homepage":"https://kinto.readthedocs.io","size":7778,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"3cf0d7d0a20a61848472b2c12a53e699b38a5cae","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":31315021,"name":"kinto","full_name":"Kinto/kinto","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto","description":"A minimalist JSON storage service with synchronisation and sharing abilities.","fork":false,"url":"https://api.github.com/repos/Kinto/kinto","forks_url":"https://api.github.com/repos/Kinto/kinto/forks","keys_url":"https://api.github.com/repos/Kinto/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto/events","assignees_url":"https://api.github.com/repos/Kinto/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto/merges","archive_url":"https://api.github.com/repos/Kinto/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto/deployments","created_at":"2015-02-25T13:34:23Z","updated_at":"2016-09-30T23:31:43Z","pushed_at":"2016-10-02T16:26:29Z","git_url":"git://github.com/Kinto/kinto.git","ssh_url":"git@github.com:Kinto/kinto.git","clone_url":"https://github.com/Kinto/kinto.git","svn_url":"https://github.com/Kinto/kinto","homepage":"https://kinto.readthedocs.io","size":12834,"stargazers_count":2879,"watchers_count":2879,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":69,"forks":171,"open_issues":69,"watchers":2879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/843"},"html":{"href":"https://github.com/Kinto/kinto/pull/843"},"issue":{"href":"https://api.github.com/repos/Kinto/kinto/issues/843"},"comments":{"href":"https://api.github.com/repos/Kinto/kinto/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/kinto/statuses/2f9f004043da538f1d3f01ae1292b654748515ba"}}}}
{"actor":{"display_login":"Natim"}}