{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1453","repository_url":"https://api.github.com/repos/rockstor/rockstor-core","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1453/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1453/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1453/events","html_url":"https://github.com/rockstor/rockstor-core/pull/1453","id":180045854,"number":1453,"title":"Broken samba config - correctly build smb.conf","user":{"login":"MFlyer","id":17988902,"avatar_url":"https://avatars.githubusercontent.com/u/17988902?v=3","gravatar_id":"","url":"https://api.github.com/users/MFlyer","html_url":"https://github.com/MFlyer","followers_url":"https://api.github.com/users/MFlyer/followers","following_url":"https://api.github.com/users/MFlyer/following{/other_user}","gists_url":"https://api.github.com/users/MFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/MFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFlyer/subscriptions","organizations_url":"https://api.github.com/users/MFlyer/orgs","repos_url":"https://api.github.com/users/MFlyer/repos","events_url":"https://api.github.com/users/MFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/MFlyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-29T13:14:29Z","updated_at":"2016-10-02T21:13:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1453","html_url":"https://github.com/rockstor/rockstor-core/pull/1453","diff_url":"https://github.com/rockstor/rockstor-core/pull/1453.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1453.patch"},"body":"Opening PR to have a single space for code comments\r\nReference to #1404 #1407 \r\nTo @schakrava : not ready to merge, will tell when ready :)\r\n\r\nRoadmap:\r\n- [x] Let our Rockstor smb builder know how to loop inside current smb file like on smb shares, better define AD section, default global section and a global custom section (only one to iterate on with custom configs) (1e5e6fd)\r\n- [x] Ensure skipping AD username and password fields in smb config file :exclamation: (1e5e6fd)\r\n- [x] Nicely handle having custom global configs with AD ON too (currently not possible because of a check over workgroup name - not possible with AD ON, so not able to save custom config on smb [global] (1e5e6fd)\r\n- [x] Samba config page - Avoid having workgroup both in workgroup field and custom params field (42dc6f2)\r\n- [x] If AD ON disable workgroup field on samba config page (not really required, workgroup value by server side checks, just for a better UX) (7daefb5 to 9919b42)\r\n- [x] Code cleaning and indent 4 spaces (42dc6f2)\r\n\r\nTesting branch:\r\n- [x] Random turn off/on samba and AD\r\n- [x] AD ON add custom samba params\r\n- [x] AD ON change workgroup, expected to have AD workgroup\r\n- [x] AD OFF change/set workgroup on samba conf page and have it\r\n- [x] AD OFF add custom samba params\r\n- [x] Add / remove new samba shares\r\n- [x] Samba config page workgroup field switches enable/disabled on AD current status"},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/250996460","html_url":"https://github.com/rockstor/rockstor-core/pull/1453#issuecomment-250996460","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1453","id":250996460,"user":{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"created_at":"2016-10-02T21:13:24Z","updated_at":"2016-10-02T21:13:24Z","body":"Nicely done, as always @MFlyer . Thank you!\r\n\r\nI am not able to test all of AD right now, but things look good as far as my testing goes. Can you also describe your testing effort?"}}
{"actor":{"display_login":"schakrava"}}