{"action":"created","issue":{"url":"https://api.github.com/repos/square/leakcanary/issues/235","labels_url":"https://api.github.com/repos/square/leakcanary/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/square/leakcanary/issues/235/comments","events_url":"https://api.github.com/repos/square/leakcanary/issues/235/events","html_url":"https://github.com/square/leakcanary/pull/235","id":99184218,"number":235,"title":"Store heap dumps in package specific directories","user":{"login":"lennykano","id":6470279,"avatar_url":"https://avatars.githubusercontent.com/u/6470279?v=3","gravatar_id":"","url":"https://api.github.com/users/lennykano","html_url":"https://github.com/lennykano","followers_url":"https://api.github.com/users/lennykano/followers","following_url":"https://api.github.com/users/lennykano/following{/other_user}","gists_url":"https://api.github.com/users/lennykano/gists{/gist_id}","starred_url":"https://api.github.com/users/lennykano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennykano/subscriptions","organizations_url":"https://api.github.com/users/lennykano/orgs","repos_url":"https://api.github.com/users/lennykano/repos","events_url":"https://api.github.com/users/lennykano/events{/privacy}","received_events_url":"https://api.github.com/users/lennykano/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-05T11:34:30Z","updated_at":"2016-01-05T07:53:06Z","closed_at":"2016-01-05T07:53:06Z","pull_request":{"url":"https://api.github.com/repos/square/leakcanary/pulls/235","html_url":"https://github.com/square/leakcanary/pull/235","diff_url":"https://github.com/square/leakcanary/pull/235.diff","patch_url":"https://github.com/square/leakcanary/pull/235.patch"},"body":"Fixes #154\r\n\r\nI am aware that #158 is another way of doing this. Personally, I don't think storing leaks on the external storage is a security risk, as developers should be smart enough to not ship a release with leak canary activated, and on many devices external storage will have more capacity available.\r\n\r\nAlso, #158 adds an extra burden of forcing the support library dependency, which I feel is best to avoid if possible. But the leak reports certainly need to be separated by package, I have 13 apps running leak canary and it makes it very difficult to track exactly where the leaks are coming from specifically when it occurs in a library class."},"comment":{"url":"https://api.github.com/repos/square/leakcanary/issues/comments/168927832","html_url":"https://github.com/square/leakcanary/pull/235#issuecomment-168927832","issue_url":"https://api.github.com/repos/square/leakcanary/issues/235","id":168927832,"user":{"login":"pyricau","id":557033,"avatar_url":"https://avatars.githubusercontent.com/u/557033?v=3","gravatar_id":"","url":"https://api.github.com/users/pyricau","html_url":"https://github.com/pyricau","followers_url":"https://api.github.com/users/pyricau/followers","following_url":"https://api.github.com/users/pyricau/following{/other_user}","gists_url":"https://api.github.com/users/pyricau/gists{/gist_id}","starred_url":"https://api.github.com/users/pyricau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyricau/subscriptions","organizations_url":"https://api.github.com/users/pyricau/orgs","repos_url":"https://api.github.com/users/pyricau/repos","events_url":"https://api.github.com/users/pyricau/events{/privacy}","received_events_url":"https://api.github.com/users/pyricau/received_events","type":"User","site_admin":false},"created_at":"2016-01-05T07:53:06Z","updated_at":"2016-01-05T07:53:06Z","body":"I'll open a new PR that does everything listed in #239. Really sorry for the delay"}}