{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7516","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7516/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7516/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7516/events","html_url":"https://github.com/matplotlib/matplotlib/pull/7516","id":191781336,"number":7516,"title":"[MRG] Deprecate \"hold\" kwarg and machinery.","user":{"login":"efiring","id":85125,"avatar_url":"https://avatars.githubusercontent.com/u/85125?v=3","gravatar_id":"","url":"https://api.github.com/users/efiring","html_url":"https://github.com/efiring","followers_url":"https://api.github.com/users/efiring/followers","following_url":"https://api.github.com/users/efiring/following{/other_user}","gists_url":"https://api.github.com/users/efiring/gists{/gist_id}","starred_url":"https://api.github.com/users/efiring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efiring/subscriptions","organizations_url":"https://api.github.com/users/efiring/orgs","repos_url":"https://api.github.com/users/efiring/repos","events_url":"https://api.github.com/users/efiring/events{/privacy}","received_events_url":"https://api.github.com/users/efiring/received_events","type":"User","site_admin":false},"labels":[{"id":120674472,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/API%20Changes","name":"API Changes","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.0%20(style%20change%20major%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14/labels","id":662004,"number":14,"title":"2.0 (style change major release)","description":"Style changes only","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":659,"state":"open","created_at":"2014-05-17T14:28:22Z","updated_at":"2016-11-26T19:05:40Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-26T02:00:42Z","updated_at":"2016-11-27T02:45:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7516","html_url":"https://github.com/matplotlib/matplotlib/pull/7516","diff_url":"https://github.com/matplotlib/matplotlib/pull/7516.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/7516.patch"},"body":"This follows #7515 and addresses #3070."},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/263098904","html_url":"https://github.com/matplotlib/matplotlib/pull/7516#issuecomment-263098904","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7516","id":263098904,"user":{"login":"efiring","id":85125,"avatar_url":"https://avatars.githubusercontent.com/u/85125?v=3","gravatar_id":"","url":"https://api.github.com/users/efiring","html_url":"https://github.com/efiring","followers_url":"https://api.github.com/users/efiring/followers","following_url":"https://api.github.com/users/efiring/following{/other_user}","gists_url":"https://api.github.com/users/efiring/gists{/gist_id}","starred_url":"https://api.github.com/users/efiring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efiring/subscriptions","organizations_url":"https://api.github.com/users/efiring/orgs","repos_url":"https://api.github.com/users/efiring/repos","events_url":"https://api.github.com/users/efiring/events{/privacy}","received_events_url":"https://api.github.com/users/efiring/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T02:45:47Z","updated_at":"2016-11-27T02:45:47Z","body":"I think this is in reasonable shape now.  The messages specifying 3.0 as the removal point are subject to debate; but if the decision is to phrase them differently, that change could be a separate tiny PR.\r\n\r\nTo make the deprecation strategy explicit:\r\n\r\n- This is stage one: if anyone tries to set a \"hold\" value, it will trigger a warning; otherwise, there should be no change in the behavior.\r\n- The next stage could be to change all the warnings to exceptions, enabling the removal of part, but not all, of the \"hold\" system.  I view this as an optional stage, not an essential one. I would prefer to skip it.\r\n- The final stage is gleefully deleting every last vestige of the \"hold\" machinery.\r\n\r\nBasemap needs to be treated in sync with mpl, but it can be done in a simpler fashion.  I will submit a PR for that now. "}}
{"actor":{"display_login":"efiring"}}