{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10866","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10866/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10866/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10866/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10866","id":190557262,"number":10866,"title":"cli/sql: report the txn status in prompt","user":{"login":"yznming","id":17263211,"avatar_url":"https://avatars.githubusercontent.com/u/17263211?v=3","gravatar_id":"","url":"https://api.github.com/users/yznming","html_url":"https://github.com/yznming","followers_url":"https://api.github.com/users/yznming/followers","following_url":"https://api.github.com/users/yznming/following{/other_user}","gists_url":"https://api.github.com/users/yznming/gists{/gist_id}","starred_url":"https://api.github.com/users/yznming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yznming/subscriptions","organizations_url":"https://api.github.com/users/yznming/orgs","repos_url":"https://api.github.com/users/yznming/repos","events_url":"https://api.github.com/users/yznming/events{/privacy}","received_events_url":"https://api.github.com/users/yznming/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-11-20T13:08:37Z","updated_at":"2016-11-22T00:19:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10866","html_url":"https://github.com/cockroachdb/cockroach/pull/10866","diff_url":"https://github.com/cockroachdb/cockroach/pull/10866.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10866.patch"},"body":"Report the transaction status in prompt.\r\n\r\nFixes #10290. \r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10866)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/262109782","html_url":"https://github.com/cockroachdb/cockroach/pull/10866#issuecomment-262109782","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10866","id":262109782,"user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T00:19:44Z","updated_at":"2016-11-22T00:19:44Z","body":"@yznming: see my comments and Andrei's. \n\nAgain thank you for working on this. It is a bit more complicated than I initially envisioned but you are on a good path.\n\n---\n\nReview status: 0 of 11 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[pkg/cli/sql.go, line 365 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10866#-KX2c_S4ZxeBP-V4VZQV:-KX8O8EDkujRJNUT1qYT:b-qejzwc) ([raw file](https://github.com/cockroachdb/cockroach/blob/5c49b6f981fff8cc20e9cd9f78a1aa8f5eccfaed/pkg/cli/sql.go#L365)):*\n<details><summary><i>Previously, yznming (Yan Long) wrote…</i></summary>\n> done. I think the prompts should be refreshed in `doProcessingFirstLine`.  bacause an empty prompt would not get into `doStartLine`.\n</details>\nThat's ok, you can update the state machine accordingly.\n\n---\n\n*[pkg/cli/sql.go, line 406 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10866#-KX2coBQfIyILf3t9Kj-:-KX8OEF4pXUBFvSV6xTp:b-279hql) ([raw file](https://github.com/cockroachdb/cockroach/blob/5c49b6f981fff8cc20e9cd9f78a1aa8f5eccfaed/pkg/cli/sql.go#L406)):*\n<details><summary><i>Previously, yznming (Yan Long) wrote…</i></summary>\n> the `RestartWait` state should be shown as `TXN>`, right?\n</details>\nI think it is useful to separate the states visually. \nIn the RestartWait state the user cannot send the same statements, and that is important to communicate.\n\nAlso I am fond of same-width identifiers for all the states, so that the prompt `>` is always on the same column on the screen.\n\nCan you try to find names and alignments that work well?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10866#-:-KX8Obju56ox9_BOHJHN:bgsoom4)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"knz"}}