{"push_id":1133891500,"size":534,"distinct_size":500,"ref":"refs/heads/master","head":"5c00a5f9f425a295e3b80e7e71acbcff1ff15120","before":"3ddd9c43821bf617621f87d8d1519229e7d3b789","commits":[{"sha":"db3ad091c544ae67f8f32fe36245fcb1210f6111","author":{"name":"Matt Ellis","email":"d7a9f5a11a3bde32d16b3a23c24225c3538df6bd@microsoft.com"},"message":"Change how we detect the default locale\n\nPreviously, we would just ask ICU what it thought the default locale\nwas, since that seemed like a reasonable thing to do. However, in cases\nwhere LANG, LC_MESSAGES and LC_ALL where unset and setlocale(3) returned\n\"C\", ICU would use \"en-US-POSIX\" as a default locale.\n\nThe above case is actually what happens by default when you are running\nin docker and en-US-POSIX has very odd collation rules (ASCII characters\nwhich differ only by case are still treated as seperate letters) which\ntrip folks up.\n\nSo in this case, we'll use Invariant. If setlocale(3) returns a non\nC/POSIX locale or any of LANG, LC_MESSAGES, or LC_ALL are set to non\nempty values, we'll continue to let ICU figure out what to do.","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/db3ad091c544ae67f8f32fe36245fcb1210f6111"},{"sha":"8c3f1869cd0063c6c5e88b56db6eef1e7da8e134","author":{"name":"Sung-Jae Lee","email":"28a7b2b1478d6d88fc312d02a3427aa64b60076f@mail.com"},"message":"Fix 'runtest.sh' script\n\nThis change fixes a bug in the 'runtest.sh' that read test cases from\nfile given by '--testDirFile=<path>' option.\nRemove LF characters while reading each line to make array properly.\nAlso changes similar codes in other place to same simple one.","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/8c3f1869cd0063c6c5e88b56db6eef1e7da8e134"},{"sha":"024178d9cc8fdd8dc30d28f90039c0a36ff4eaea","author":{"name":"MyungJoo Ham","email":"7045964e83ea37556f128548102c1f8facb1fa7c@samsung.com"},"message":"Fix incorrect usage of preprocessor define\n\nIn native world, it's DEBUG, not DBG.\n\nFix #4712\n\nSigned-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/024178d9cc8fdd8dc30d28f90039c0a36ff4eaea"},{"sha":"a8ef4f0923102d83928d22c9176266f8d2dd8b0e","author":{"name":"Sung-Jae Lee","email":"28a7b2b1478d6d88fc312d02a3427aa64b60076f@mail.com"},"message":"Using alternate way for 'readarray' to support bash in Mac OS X\n\nbash in Mac OS X doesn't support `readarray` built-in command\nGNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/a8ef4f0923102d83928d22c9176266f8d2dd8b0e"},{"sha":"cdca9a6355f6d7aa6a01e58e0198ffcac60acf79","author":{"name":"Sung-Jae Lee","email":"28a7b2b1478d6d88fc312d02a3427aa64b60076f@mail.com"},"message":"Fix '--mscorlibDir=' option default value processing\n\nDefault value not assigned before copying overlay 'bin/*' objects to test root.","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/cdca9a6355f6d7aa6a01e58e0198ffcac60acf79"},{"sha":"cf2317ac50ce545cf5cc7ccf4be44b0d80c088df","author":{"name":"Kamil Rytarowski","email":"8d8c823f03a1df5c93596264d9785e2984069240@gmx.com"},"message":"NetBSD: Fix build with LLVM-3.9","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/cf2317ac50ce545cf5cc7ccf4be44b0d80c088df"},{"sha":"52e149e3bac644087463f418a0516f02a6be0060","author":{"name":"Koundinya Veluri","email":"d1af74ef98e3a3985b6aeb5b676718451376531d@microsoft.com"},"message":"Fix recently introduced timing issue when growing the card table\n\nObserved issue:\n- When software write watch is enabled, the runtime is suspended in grow_brick_card_tables() to copy the dirty state of pages into the new table\n- The global card table pointer was updated before the attempt to suspend the runtime\n- That thread gets blocked there, while the background GC thread successfully suspends the runtime, and calls copy_brick_card_table()\n- Since the lowest and highest addresses of the GC heap were not updated, copy_brick_card_table() reads invalid memory\n\nFixes:\n- Moved the change to g_card_table to after the point of suspend for software write watch. At the point of this suspend, the global state will be that prior to resize.\n- Though much less frequent, this issue can also occur with the implicit suspend that occurs as part of StompWriteBarrierResize(), when the write barrier type needs to be changed. Moved the other StompWriteBarrierResize() down such that it is done after all global state is updated. At the point of this suspend, the global state will be that following resize.\n- I don't think we can have a failure path (failing to commit the mark array) after updating global state such as g_card_table. Soon after that, there may be changes to the new table on paths that don't go through the write barrier, and upon failure to commit the mark array, those updates would be lost. Passed the new card table to functions that need them, and moved changes to global table pointers to after all of the failure points.\n\nFixes #4750","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/52e149e3bac644087463f418a0516f02a6be0060"},{"sha":"c377b53dca090869ea10d95fe7098e70ac3c0847","author":{"name":"John Chen (CLR)","email":"c0324c926938473cb77abd4c0beb662bbb71abed@microsoft.com"},"message":"Remove an assert in AssemblySpec::EmitToken\n\nAssemblySpec::EmitToken has a PRECONDITION that prohibits emitting AssemblyRef\ntokens to WinMD files, except inside CrossGen. However, there are scenarios,\nsuch as XML serialization, that need to emit such tokens. Thus this PRECONDITION\nis removed.","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/c377b53dca090869ea10d95fe7098e70ac3c0847"},{"sha":"9290b53960f368ab9b6356ad029cb3cab69a12c6","author":{"name":"Sung-Jae Lee","email":"28a7b2b1478d6d88fc312d02a3427aa64b60076f@mail.com"},"message":"Following the review comments","distinct":true,"url":"https://api.github.com/repos/hughbe/coreclr/commits/9290b53960f368ab9b6356ad029cb3cab69a12c6"},{"sha":"75a96376d9b6760b63eefbc245572e9274eeb347","author":{"name":"sivarv","email":"73fae3b6c24de473684fcc85cbed17d3fb546409@microsoft.com"},"message":"Avoid SIMD type return values from requiring to go through\nmemory for returning.","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/75a96376d9b6760b63eefbc245572e9274eeb347"},{"sha":"9b54e5ebee7838b3eb9c7cacbd9f66ac78dfb968","author":{"name":"Sejong Oh","email":"e4dec363717cd5bf7d2392a3b7cd0d680c57a337@microsoft.com"},"message":"Return RetBuf address via RAX for Windows 64\n\nThe AMD64 native calling convention requires return buffer address to be\nreturned by callee in RAX. This changeset makes JIT follow this rule.\nEspecially, in case that a managed method returns a struct value to its\nnative caller, the caller reads a pointer to the return value from RAX.\n\nAsm diffs show expected differences such as 'mov rax, reg' at the end of\nfunctions and some different register assignments.","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/9b54e5ebee7838b3eb9c7cacbd9f66ac78dfb968"},{"sha":"9614277d4fb85970871678601c9ffe0c4cbc6a97","author":{"name":"Andy Ayers","email":"eb540dbfe23ecab6edc4372665b4d5d4e13a72b7@microsoft.com"},"message":"Fix inline dump format issue\n\nLost some implict casts to float when I updated SIZE_SCALE to an enum\nconstant, so now make the casts explicit.\n\nJust impacts dump output.\n\nAlso, add a newline to LegacyPolicy dump to keep messages distinct.","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/9614277d4fb85970871678601c9ffe0c4cbc6a97"},{"sha":"f6796220664d3bfa4ea42d2ab86cf5a6e2edeae9","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Mark EDX as trashed by the no-gc helper calls\n\nFixes #4666","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/f6796220664d3bfa4ea42d2ab86cf5a6e2edeae9"},{"sha":"0feeb4ff48a6f0beb614ee2e3d3604e85dfbca27","author":{"name":"Andy Ayers","email":"eb540dbfe23ecab6edc4372665b4d5d4e13a72b7@microsoft.com"},"message":"Inliner: add JitInlineLimit check to LegacyPolicy under debug\n\nAdds the ability to limit the number of inlines done by the LegacyPolicy.\nUseful in trying to binary search for inlines that cause correctness\nissues.\n\nThis limit impacts inlining in all methods, so effective isolation may\nalso require use of JitNoInlineRange to hone in on the root method that\nis the source of problems.","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/0feeb4ff48a6f0beb614ee2e3d3604e85dfbca27"},{"sha":"2ae90a015933dc85192b73c2bf8361cf59cef035","author":{"name":"Jeremy Kuhne","email":"21c746d567876386edcceea0628369652afcb30c@microsoft.com"},"message":"This change ports the support files from NetFxDev1. It doesn't change behavior yet. Adding a feature for the app context switch for path compat as we don't intend to use it in core.\n\n[tfs-changeset: 1602284]","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/2ae90a015933dc85192b73c2bf8361cf59cef035"},{"sha":"16ca4a20ddd03479e101cea0d74705f1a2791ae5","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Fix GC ref frame offset range assert\n\nIn emitSetFrameRangeGCRs(), on x86, there is the following assert:\n  assert(offsHi <  0);\nThis is saying that the highest offset of a stack frame gc reference\nis negative w.r.t. the frame pointer. This is not quite true: the\nhighest offset is exclusive of the range (the lowest offset is inclusive).\nI found a test case where the 'this' pointer, a gc ref, was located\nimmediately below the frame pointer, in range [ebp-4,ebp), so offsHi==0.\n\nThe reason we don't hit this more is because this assert is only in\nthe JitDump code (under #ifdef DEBUG and 'if (verbose)'). (This\nalso seems wrong.)\n\nI changed the assert to (offsHi <= 0).","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/16ca4a20ddd03479e101cea0d74705f1a2791ae5"},{"sha":"4eb10dbf742604906019931ac4b1540b451f7322","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Fix COMPlus_JitFunctionTrace=1 to work better with NYI","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/4eb10dbf742604906019931ac4b1540b451f7322"},{"sha":"0c29217d7f0de620248c30d2db92ce29af6858ef","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Disable tests which fail in a RyuJIT/x86 Checked build test run","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/0c29217d7f0de620248c30d2db92ce29af6858ef"},{"sha":"cc284fb9c0ac4c2efbf1395efdbe8d8e0978dc92","author":{"name":"Matt Ellis","email":"d7a9f5a11a3bde32d16b3a23c24225c3538df6bd@microsoft.com"},"message":"Fix conditional in Unix build definition","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/cc284fb9c0ac4c2efbf1395efdbe8d8e0978dc92"},{"sha":"bf61fa87d857381dfeeca258d1d366d62faf39be","author":{"name":"Matt Ellis","email":"d7a9f5a11a3bde32d16b3a23c24225c3538df6bd@microsoft.com"},"message":"Merge pull request #4821 from ellismg/fix-unix-builds\n\nFix conditional in Unix build definition","distinct":false,"url":"https://api.github.com/repos/hughbe/coreclr/commits/bf61fa87d857381dfeeca258d1d366d62faf39be"}]}
{"actor":{"display_login":"hughbe"}}