{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/668","repository_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/668/comments","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/668/events","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/668","id":197119404,"number":668,"title":"JENKINS-39762 - Update application header","user":{"login":"sophistifunk","id":142591,"avatar_url":"https://avatars.githubusercontent.com/u/142591?v=3","gravatar_id":"","url":"https://api.github.com/users/sophistifunk","html_url":"https://github.com/sophistifunk","followers_url":"https://api.github.com/users/sophistifunk/followers","following_url":"https://api.github.com/users/sophistifunk/following{/other_user}","gists_url":"https://api.github.com/users/sophistifunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sophistifunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophistifunk/subscriptions","organizations_url":"https://api.github.com/users/sophistifunk/orgs","repos_url":"https://api.github.com/users/sophistifunk/repos","events_url":"https://api.github.com/users/sophistifunk/events{/privacy}","received_events_url":"https://api.github.com/users/sophistifunk/received_events","type":"User","site_admin":false},"labels":[{"id":315599433,"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":334266887,"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/needs-review","name":"needs-review","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-22T08:25:18Z","updated_at":"2016-12-22T10:03:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/668","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/668","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/668.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/668.patch"},"body":" * Pull in updated JDL, and add new components to replace existing headers.\r\n * Add Blue Ocean logo component to use for betas.\r\n * Add storybook entries to demonstrate usage.\r\n\r\nThe existing stuff hasn't been replaced, as Thor's doing stuff with the headers, but mostly I ran out of steam and 2016. It's new components, which should be demonstrated amply in Storybooks.\r\n\r\nSquashed commit of the following:\r\n\r\n    josh/JENKINS-39762-new-headers * lint\r\n    josh/JENKINS-39762-new-headers * ResultPageHeader working nicely, no build details shown in storybooks\r\n    josh/JENKINS-39762-new-headers * Progess on ResultPageHeader, still losing result somewhere :(\r\n    josh/JENKINS-39762-new-headers * Improvments to ContentPageHeader, show weather icon in story\r\n    josh/JENKINS-39762-new-headers * Fix JDL version\r\n    josh/JENKINS-39762-new-headers * Clean up the rest of the storybook remnants from web\r\n    josh/JENKINS-39762-new-headers * Move components and stories to -dashboard\r\n    josh/JENKINS-39762-new-headers * ehsuydjmntws5rty67hauw5r6yjthna\r\n    josh/JENKINS-39762-new-headers * tweak storybook to get by with a npm run bundle rather than full mvn build which is way slower and requirequires lint\r\n    josh/JENKINS-39762-new-headers * Add logo as a component, rejigger storybooks to also reference module-local styles\r\n    josh/JENKINS-39762-new-headers * Add storybooks to -web\r\n    josh/JENKINS-39762-new-headers * Pull in JDL beta, switch out PageTabs for PageTabsOld for transition\r\n\r\n# Description\r\n\r\nSee [JENKINS-39762](https://issues.jenkins-ci.org/browse/JENKINS-39762).\r\nSee [JENKINS-39763](https://issues.jenkins-ci.org/browse/JENKINS-39763).\r\n\r\n# Submitter checklist\r\n- [X] Link to JIRA ticket in description, if appropriate.\r\n- [X] Change is code complete and matches issue description\r\n- [X] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [X] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [ ] Ran Acceptance Test Harness against PR changes.\r\n\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [ ] Reviewed the code\r\n- [ ] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@reviewbybees \r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments/268764704","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/668#issuecomment-268764704","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/668","id":268764704,"user":{"login":"michaelneale","id":14976,"avatar_url":"https://avatars.githubusercontent.com/u/14976?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelneale","html_url":"https://github.com/michaelneale","followers_url":"https://api.github.com/users/michaelneale/followers","following_url":"https://api.github.com/users/michaelneale/following{/other_user}","gists_url":"https://api.github.com/users/michaelneale/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelneale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelneale/subscriptions","organizations_url":"https://api.github.com/users/michaelneale/orgs","repos_url":"https://api.github.com/users/michaelneale/repos","events_url":"https://api.github.com/users/michaelneale/events{/privacy}","received_events_url":"https://api.github.com/users/michaelneale/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T10:03:41Z","updated_at":"2016-12-22T10:03:41Z","body":"very nice - @scherler @i386 want to take a look at storybooks? "}}
{"actor":{"display_login":"michaelneale"}}