{"action":"opened","number":68,"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/68","id":74085801,"html_url":"https://github.com/openshift/origin-web-console/pull/68","diff_url":"https://github.com/openshift/origin-web-console/pull/68.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/68.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/68","number":68,"state":"open","locked":false,"title":"[WIP] Clean up service-group directive","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"The `service-group` directive currently takes 16 (!) attributes, almost all of them unchanged from the parent controller. Thoughts on this change? I think I've convinced @benjaminapetersen :)\r\n\r\nIf we agree this makes sense, I can make the same change to the `overview-service` directive.\r\n\r\n@jwforres \r\n\r\n[ ] Update `overview-service` directive\r\n[ ] Update `service-group` directive name to make it clear it's only for the overview\r\n","created_at":"2016-06-16T14:00:58Z","updated_at":"2016-06-16T14:00:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/68/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/68/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/68/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/994928b1bb89efa768de73a53340a715a7159190","head":{"label":"spadgett:service-group-inherited-group","ref":"service-group-inherited-group","sha":"994928b1bb89efa768de73a53340a715a7159190","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":58545409,"name":"origin-web-console","full_name":"spadgett/origin-web-console","owner":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/spadgett/origin-web-console","forks_url":"https://api.github.com/repos/spadgett/origin-web-console/forks","keys_url":"https://api.github.com/repos/spadgett/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/origin-web-console/teams","hooks_url":"https://api.github.com/repos/spadgett/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/spadgett/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/origin-web-console/events","assignees_url":"https://api.github.com/repos/spadgett/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/origin-web-console/tags","blobs_url":"https://api.github.com/repos/spadgett/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/spadgett/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/spadgett/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/spadgett/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/spadgett/origin-web-console/subscription","commits_url":"https://api.github.com/repos/spadgett/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/origin-web-console/merges","archive_url":"https://api.github.com/repos/spadgett/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/origin-web-console/downloads","issues_url":"https://api.github.com/repos/spadgett/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/spadgett/origin-web-console/deployments","created_at":"2016-05-11T13:03:37Z","updated_at":"2016-05-11T13:03:40Z","pushed_at":"2016-06-16T13:52:22Z","git_url":"git://github.com/spadgett/origin-web-console.git","ssh_url":"git@github.com:spadgett/origin-web-console.git","clone_url":"https://github.com/spadgett/origin-web-console.git","svn_url":"https://github.com/spadgett/origin-web-console","homepage":null,"size":7027,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7840198e809bd64e5e5fc52b4954bc7d1fdbee97","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-06-15T13:02:12Z","pushed_at":"2016-06-16T12:47:14Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":6644,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":23,"forks":21,"open_issues":23,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/68"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/68"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/68"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/994928b1bb89efa768de73a53340a715a7159190"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":80,"changed_files":3}}
{"actor":{"display_login":"spadgett"}}