{"action":"created","issue":{"url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/266","repository_url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc","labels_url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/266/comments","events_url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/266/events","html_url":"https://github.com/GordonLesti/Lesti_Fpc/issues/266","id":189486038,"number":266,"title":"Problem caching prices for taxed/non-taxed zones and multiple currencies","user":{"login":"doctea","id":657658,"avatar_url":"https://avatars.githubusercontent.com/u/657658?v=3","gravatar_id":"","url":"https://api.github.com/users/doctea","html_url":"https://github.com/doctea","followers_url":"https://api.github.com/users/doctea/followers","following_url":"https://api.github.com/users/doctea/following{/other_user}","gists_url":"https://api.github.com/users/doctea/gists{/gist_id}","starred_url":"https://api.github.com/users/doctea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctea/subscriptions","organizations_url":"https://api.github.com/users/doctea/orgs","repos_url":"https://api.github.com/users/doctea/repos","events_url":"https://api.github.com/users/doctea/events{/privacy}","received_events_url":"https://api.github.com/users/doctea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-15T19:39:21Z","updated_at":"2016-11-15T22:07:41Z","closed_at":null,"body":"I'm running into problems with multiple currencies - or rather, areas with differing tax rules.  I can't seem to find a way to cache based on the 'tax area' being used.\r\n\r\nFor example, sales to EU countries should have tax applied; sales to elsewhere shouldn't.\r\n\r\nIf a customer 'A' with a Billing Address/Quote country of 'US' visits a page first, then product details are cached without showing \"including VAT\".  This 'not showing tax' version will then be incorrectly shown to EU visitors who follow.\r\nIf a customer 'B' with a Billing Address/Quote country in the EU visits a page first, then product details are cached showing \"including VAT\".  This 'showing tax' version will then be incorrectly shown to non-EU visitors who follow.\r\n\r\nEven jumping through some hoops to add CountryId to the caching parameters doesn't seem to solve the problem.  Caching on CountryId doesn't seem the best idea either, since (in my situ) there are basically only two unique 'tax areas', while there are hundreds of unique Country Codes that map to them, so the cache would be missing unnecessarily.\r\n\r\nIn a bit of a rush right now, will come back to investigate this further if there are no suggestions so far!"},"comment":{"url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/comments/260785516","html_url":"https://github.com/GordonLesti/Lesti_Fpc/issues/266#issuecomment-260785516","issue_url":"https://api.github.com/repos/GordonLesti/Lesti_Fpc/issues/266","id":260785516,"user":{"login":"doctea","id":657658,"avatar_url":"https://avatars.githubusercontent.com/u/657658?v=3","gravatar_id":"","url":"https://api.github.com/users/doctea","html_url":"https://github.com/doctea","followers_url":"https://api.github.com/users/doctea/followers","following_url":"https://api.github.com/users/doctea/following{/other_user}","gists_url":"https://api.github.com/users/doctea/gists{/gist_id}","starred_url":"https://api.github.com/users/doctea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctea/subscriptions","organizations_url":"https://api.github.com/users/doctea/orgs","repos_url":"https://api.github.com/users/doctea/repos","events_url":"https://api.github.com/users/doctea/events{/privacy}","received_events_url":"https://api.github.com/users/doctea/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T22:07:41Z","updated_at":"2016-11-15T22:07:41Z","body":"Hi @GordonLesti, thanks for responding - btw before I go any further I just wanted to say a big THANK YOU for all your hard work on this and dealing with issues!  You are a good man :)\r\n\r\nYes, in this instance both A and B are in different customer groups.  I *think* that I tested it and that it behaved differently when FPC was enabled/disabled, but I'll have to wait until I get back to work tomorrow to double-check that, sorry.  I'll also experiment with having the users in the same and differing customer groups, and see what that turns up.\r\n\r\nIs there anything in particular you think I should check over or that might be the cause here?"}}
{"actor":{"display_login":"doctea"}}