{"action":"created","issue":{"url":"https://api.github.com/repos/lcm-proj/lcm/issues/84","repository_url":"https://api.github.com/repos/lcm-proj/lcm","labels_url":"https://api.github.com/repos/lcm-proj/lcm/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/lcm-proj/lcm/issues/84/comments","events_url":"https://api.github.com/repos/lcm-proj/lcm/issues/84/events","html_url":"https://github.com/lcm-proj/lcm/pull/84","id":165120916,"number":84,"title":"Avoid use of BASH_SOURCE in wrapper scripts","user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars.githubusercontent.com/u/6474409?v=3","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ashuang","id":1559426,"avatar_url":"https://avatars.githubusercontent.com/u/1559426?v=3","gravatar_id":"","url":"https://api.github.com/users/ashuang","html_url":"https://github.com/ashuang","followers_url":"https://api.github.com/users/ashuang/followers","following_url":"https://api.github.com/users/ashuang/following{/other_user}","gists_url":"https://api.github.com/users/ashuang/gists{/gist_id}","starred_url":"https://api.github.com/users/ashuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashuang/subscriptions","organizations_url":"https://api.github.com/users/ashuang/orgs","repos_url":"https://api.github.com/users/ashuang/repos","events_url":"https://api.github.com/users/ashuang/events{/privacy}","received_events_url":"https://api.github.com/users/ashuang/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashuang","id":1559426,"avatar_url":"https://avatars.githubusercontent.com/u/1559426?v=3","gravatar_id":"","url":"https://api.github.com/users/ashuang","html_url":"https://github.com/ashuang","followers_url":"https://api.github.com/users/ashuang/followers","following_url":"https://api.github.com/users/ashuang/following{/other_user}","gists_url":"https://api.github.com/users/ashuang/gists{/gist_id}","starred_url":"https://api.github.com/users/ashuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashuang/subscriptions","organizations_url":"https://api.github.com/users/ashuang/orgs","repos_url":"https://api.github.com/users/ashuang/repos","events_url":"https://api.github.com/users/ashuang/events{/privacy}","received_events_url":"https://api.github.com/users/ashuang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-07-12T16:29:49Z","updated_at":"2016-07-13T18:01:06Z","closed_at":"2016-07-13T17:54:38Z","pull_request":{"url":"https://api.github.com/repos/lcm-proj/lcm/pulls/84","html_url":"https://github.com/lcm-proj/lcm/pull/84","diff_url":"https://github.com/lcm-proj/lcm/pull/84.diff","patch_url":"https://github.com/lcm-proj/lcm/pull/84.patch"},"body":"The wrapper scripts use `!#/bin/sh`, not `#!/bin/bash`, and we'd prefer to avoid the latter in case of systems that don't have it, if possible. Accordingly, replace use of `${BASH_SOURCE[0]}` with plain old `$0`. These should be the same except if the script is sourced via another script, and it seems safe enough to assume that doesn't happen for these."},"comment":{"url":"https://api.github.com/repos/lcm-proj/lcm/issues/comments/232437053","html_url":"https://github.com/lcm-proj/lcm/pull/84#issuecomment-232437053","issue_url":"https://api.github.com/repos/lcm-proj/lcm/issues/84","id":232437053,"user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars.githubusercontent.com/u/6474409?v=3","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T18:01:06Z","updated_at":"2016-07-13T18:01:06Z","body":"> I suppose we can address perl compatibility issues if they arise so no need to preemptively worry about it here I think.\r\n\r\nI think that's reasonable. Thanks :smile:."}}
{"actor":{"display_login":"mwoehlke-kitware"}}