{"action":"created","comment":{"url":"https://api.github.com/repos/cayleygraph/cayley/pulls/comments/70179568","id":70179568,"diff_hunk":"@@ -274,7 +274,7 @@ func (qs *QuadStore) ApplyDeltas(deltas []graph.Delta, ignoreOpts graph.IgnoreOp\n \t\t\t\tif err == graph.ErrQuadNotExist && ignoreOpts.IgnoreMissing {\n \t\t\t\t\tcontinue\n \t\t\t\t}\n-\t\t\t\treturn err\n+\t\t\t\treturn &graph.DeltaError{Delta: d, Err: err}","path":"graph/bolt/quadstore.go","position":14,"original_position":14,"commit_id":"6e91ba644293ed9f1e3fff8b625adb2f85a173c7","original_commit_id":"c89e42ae1788919deb11deb87e253966b03b7ea6","user":{"login":"dennwc","id":676724,"avatar_url":"https://avatars.githubusercontent.com/u/676724?v=3","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false},"body":"Does this means that ApplyDeltas should return DeltaError in most cases? There are multiple brunches in this function that doesn't follow this behavior.","created_at":"2016-07-10T10:35:05Z","updated_at":"2016-07-10T10:35:05Z","html_url":"https://github.com/cayleygraph/cayley/pull/443#discussion_r70179568","pull_request_url":"https://api.github.com/repos/cayleygraph/cayley/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/comments/70179568"},"html":{"href":"https://github.com/cayleygraph/cayley/pull/443#discussion_r70179568"},"pull_request":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/cayleygraph/cayley/pulls/443","id":76863267,"html_url":"https://github.com/cayleygraph/cayley/pull/443","diff_url":"https://github.com/cayleygraph/cayley/pull/443.diff","patch_url":"https://github.com/cayleygraph/cayley/pull/443.patch","issue_url":"https://api.github.com/repos/cayleygraph/cayley/issues/443","number":443,"state":"open","locked":false,"title":"graph: provide more meaningful errors for bad actions","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=3","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"body":"This leads the way to a richer error handling that may allow the reduction of logging within packages.","created_at":"2016-07-10T03:26:08Z","updated_at":"2016-07-10T10:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1555d654ee4475245d96370e5130aa05ef628edd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cayleygraph/cayley/pulls/443/commits","review_comments_url":"https://api.github.com/repos/cayleygraph/cayley/pulls/443/comments","review_comment_url":"https://api.github.com/repos/cayleygraph/cayley/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cayleygraph/cayley/issues/443/comments","statuses_url":"https://api.github.com/repos/cayleygraph/cayley/statuses/6e91ba644293ed9f1e3fff8b625adb2f85a173c7","head":{"label":"kortschak:dups","ref":"dups","sha":"6e91ba644293ed9f1e3fff8b625adb2f85a173c7","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=3","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"repo":{"id":21220299,"name":"cayley","full_name":"kortschak/cayley","owner":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=3","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kortschak/cayley","description":"An open-source graph database","fork":true,"url":"https://api.github.com/repos/kortschak/cayley","forks_url":"https://api.github.com/repos/kortschak/cayley/forks","keys_url":"https://api.github.com/repos/kortschak/cayley/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kortschak/cayley/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kortschak/cayley/teams","hooks_url":"https://api.github.com/repos/kortschak/cayley/hooks","issue_events_url":"https://api.github.com/repos/kortschak/cayley/issues/events{/number}","events_url":"https://api.github.com/repos/kortschak/cayley/events","assignees_url":"https://api.github.com/repos/kortschak/cayley/assignees{/user}","branches_url":"https://api.github.com/repos/kortschak/cayley/branches{/branch}","tags_url":"https://api.github.com/repos/kortschak/cayley/tags","blobs_url":"https://api.github.com/repos/kortschak/cayley/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kortschak/cayley/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kortschak/cayley/git/refs{/sha}","trees_url":"https://api.github.com/repos/kortschak/cayley/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kortschak/cayley/statuses/{sha}","languages_url":"https://api.github.com/repos/kortschak/cayley/languages","stargazers_url":"https://api.github.com/repos/kortschak/cayley/stargazers","contributors_url":"https://api.github.com/repos/kortschak/cayley/contributors","subscribers_url":"https://api.github.com/repos/kortschak/cayley/subscribers","subscription_url":"https://api.github.com/repos/kortschak/cayley/subscription","commits_url":"https://api.github.com/repos/kortschak/cayley/commits{/sha}","git_commits_url":"https://api.github.com/repos/kortschak/cayley/git/commits{/sha}","comments_url":"https://api.github.com/repos/kortschak/cayley/comments{/number}","issue_comment_url":"https://api.github.com/repos/kortschak/cayley/issues/comments{/number}","contents_url":"https://api.github.com/repos/kortschak/cayley/contents/{+path}","compare_url":"https://api.github.com/repos/kortschak/cayley/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kortschak/cayley/merges","archive_url":"https://api.github.com/repos/kortschak/cayley/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kortschak/cayley/downloads","issues_url":"https://api.github.com/repos/kortschak/cayley/issues{/number}","pulls_url":"https://api.github.com/repos/kortschak/cayley/pulls{/number}","milestones_url":"https://api.github.com/repos/kortschak/cayley/milestones{/number}","notifications_url":"https://api.github.com/repos/kortschak/cayley/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kortschak/cayley/labels{/name}","releases_url":"https://api.github.com/repos/kortschak/cayley/releases{/id}","deployments_url":"https://api.github.com/repos/kortschak/cayley/deployments","created_at":"2014-06-25T22:10:28Z","updated_at":"2016-06-27T23:00:10Z","pushed_at":"2016-07-10T10:15:28Z","git_url":"git://github.com/kortschak/cayley.git","ssh_url":"git@github.com:kortschak/cayley.git","clone_url":"https://github.com/kortschak/cayley.git","svn_url":"https://github.com/kortschak/cayley","homepage":"","size":16921,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cayleygraph:master","ref":"master","sha":"4b350beb71f1a869547f4467d48a94eea6de2378","user":{"login":"cayleygraph","id":20098289,"avatar_url":"https://avatars.githubusercontent.com/u/20098289?v=3","gravatar_id":"","url":"https://api.github.com/users/cayleygraph","html_url":"https://github.com/cayleygraph","followers_url":"https://api.github.com/users/cayleygraph/followers","following_url":"https://api.github.com/users/cayleygraph/following{/other_user}","gists_url":"https://api.github.com/users/cayleygraph/gists{/gist_id}","starred_url":"https://api.github.com/users/cayleygraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cayleygraph/subscriptions","organizations_url":"https://api.github.com/users/cayleygraph/orgs","repos_url":"https://api.github.com/users/cayleygraph/repos","events_url":"https://api.github.com/users/cayleygraph/events{/privacy}","received_events_url":"https://api.github.com/users/cayleygraph/received_events","type":"Organization","site_admin":false},"repo":{"id":20537104,"name":"cayley","full_name":"cayleygraph/cayley","owner":{"login":"cayleygraph","id":20098289,"avatar_url":"https://avatars.githubusercontent.com/u/20098289?v=3","gravatar_id":"","url":"https://api.github.com/users/cayleygraph","html_url":"https://github.com/cayleygraph","followers_url":"https://api.github.com/users/cayleygraph/followers","following_url":"https://api.github.com/users/cayleygraph/following{/other_user}","gists_url":"https://api.github.com/users/cayleygraph/gists{/gist_id}","starred_url":"https://api.github.com/users/cayleygraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cayleygraph/subscriptions","organizations_url":"https://api.github.com/users/cayleygraph/orgs","repos_url":"https://api.github.com/users/cayleygraph/repos","events_url":"https://api.github.com/users/cayleygraph/events{/privacy}","received_events_url":"https://api.github.com/users/cayleygraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cayleygraph/cayley","description":"An open-source graph database","fork":false,"url":"https://api.github.com/repos/cayleygraph/cayley","forks_url":"https://api.github.com/repos/cayleygraph/cayley/forks","keys_url":"https://api.github.com/repos/cayleygraph/cayley/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cayleygraph/cayley/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cayleygraph/cayley/teams","hooks_url":"https://api.github.com/repos/cayleygraph/cayley/hooks","issue_events_url":"https://api.github.com/repos/cayleygraph/cayley/issues/events{/number}","events_url":"https://api.github.com/repos/cayleygraph/cayley/events","assignees_url":"https://api.github.com/repos/cayleygraph/cayley/assignees{/user}","branches_url":"https://api.github.com/repos/cayleygraph/cayley/branches{/branch}","tags_url":"https://api.github.com/repos/cayleygraph/cayley/tags","blobs_url":"https://api.github.com/repos/cayleygraph/cayley/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cayleygraph/cayley/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cayleygraph/cayley/git/refs{/sha}","trees_url":"https://api.github.com/repos/cayleygraph/cayley/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cayleygraph/cayley/statuses/{sha}","languages_url":"https://api.github.com/repos/cayleygraph/cayley/languages","stargazers_url":"https://api.github.com/repos/cayleygraph/cayley/stargazers","contributors_url":"https://api.github.com/repos/cayleygraph/cayley/contributors","subscribers_url":"https://api.github.com/repos/cayleygraph/cayley/subscribers","subscription_url":"https://api.github.com/repos/cayleygraph/cayley/subscription","commits_url":"https://api.github.com/repos/cayleygraph/cayley/commits{/sha}","git_commits_url":"https://api.github.com/repos/cayleygraph/cayley/git/commits{/sha}","comments_url":"https://api.github.com/repos/cayleygraph/cayley/comments{/number}","issue_comment_url":"https://api.github.com/repos/cayleygraph/cayley/issues/comments{/number}","contents_url":"https://api.github.com/repos/cayleygraph/cayley/contents/{+path}","compare_url":"https://api.github.com/repos/cayleygraph/cayley/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cayleygraph/cayley/merges","archive_url":"https://api.github.com/repos/cayleygraph/cayley/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cayleygraph/cayley/downloads","issues_url":"https://api.github.com/repos/cayleygraph/cayley/issues{/number}","pulls_url":"https://api.github.com/repos/cayleygraph/cayley/pulls{/number}","milestones_url":"https://api.github.com/repos/cayleygraph/cayley/milestones{/number}","notifications_url":"https://api.github.com/repos/cayleygraph/cayley/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cayleygraph/cayley/labels{/name}","releases_url":"https://api.github.com/repos/cayleygraph/cayley/releases{/id}","deployments_url":"https://api.github.com/repos/cayleygraph/cayley/deployments","created_at":"2014-06-05T18:49:41Z","updated_at":"2016-07-09T21:04:01Z","pushed_at":"2016-07-10T10:15:29Z","git_url":"git://github.com/cayleygraph/cayley.git","ssh_url":"git@github.com:cayleygraph/cayley.git","clone_url":"https://github.com/cayleygraph/cayley.git","svn_url":"https://github.com/cayleygraph/cayley","homepage":"","size":23917,"stargazers_count":8410,"watchers_count":8410,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":685,"mirror_url":null,"open_issues_count":71,"forks":685,"open_issues":71,"watchers":8410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/443"},"html":{"href":"https://github.com/cayleygraph/cayley/pull/443"},"issue":{"href":"https://api.github.com/repos/cayleygraph/cayley/issues/443"},"comments":{"href":"https://api.github.com/repos/cayleygraph/cayley/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cayleygraph/cayley/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/cayleygraph/cayley/statuses/6e91ba644293ed9f1e3fff8b625adb2f85a173c7"}}}}
{"actor":{"display_login":"dennwc"}}