{"action":"created","comment":{"url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/comments/66162395","id":66162395,"diff_hunk":"@@ -17,6 +21,69 @@ export class TSNpmLintTask extends GulpTask<ITSNPMLintTaskConfig> {\n   };\n \n   public executeTask(gulp: gulp.Gulp): void {\n-    tsdLinter.fixTypings();\n+    const taskScope: TSNpmLintTask = this;\n+\n+    const filePattern: string = path.join(taskScope.buildConfig.libFolder, '**', '*.d.ts');\n+\n+    /**\n+     * Matches:\n+     *  /// <reference path=\"../../typings.d.ts\" />\n+     *  /// <reference path='../../typings.d.ts' />\n+     *  ///<reference path='../../typings.d.ts' />\n+     *  ///<reference path='../../typings.d.ts'/>\n+     */\n+    const referencePathRegex: RegExp = /^\\/\\/\\/[ ]?<reference path=['\"](.*)['\"][ ]?\\/>/gm;\n+    return gulp.src(filePattern)\n+      .pipe(cached(\n+        /* tslint:disable:no-function-expression */\n+        through2.obj(function(file: gulpUtil.File, encoding: string,\n+          callback: (encoding?: string, file?: gulpUtil.File) => void): void {\n+          /* tslint:enable:no-function-expression */\n+\n+          try {\n+            const rawContents: string = file.contents.toString(encoding);\n+            const relativePathToCurrentFile: string = path.relative(taskScope.buildConfig.rootPath, file.path);\n+            taskScope.logVerbose(relativePathToCurrentFile);\n+\n+            /* tslint:disable:no-string-literal */\n+            file[taskScope.name] = {\n+              failureCount: 0\n+            };\n+            /* tslint:enable:no-string-literal */","path":"src/TSNpmLintTask.ts","position":null,"original_position":45,"commit_id":"d7bad1b4258dc7a807f6627332d9387afda5baaf","original_commit_id":"8fd5d7bcb0ff8411d6d77b14e03c436e3d9d9559","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"I had it as a string literal but decided to use the taskname instead. Removing linter override.","created_at":"2016-06-07T22:11:57Z","updated_at":"2016-06-07T22:11:57Z","html_url":"https://github.com/dzearing/gulp-core-build-typescript/pull/17#discussion_r66162395","pull_request_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/comments/66162395"},"html":{"href":"https://github.com/dzearing/gulp-core-build-typescript/pull/17#discussion_r66162395"},"pull_request":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17","id":72789332,"html_url":"https://github.com/dzearing/gulp-core-build-typescript/pull/17","diff_url":"https://github.com/dzearing/gulp-core-build-typescript/pull/17.diff","patch_url":"https://github.com/dzearing/gulp-core-build-typescript/pull/17.patch","issue_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/17","number":17,"state":"open","locked":false,"title":"Rewrites the ts-npm-lint task such that we no longer use the external…","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"* Since we were only using a small bit of ts-npm-lint, I first factored that code out & removed the dependency.\r\n* Secondly, remodeled this code as a gulp.src/gulp.dest instead of glob/fs\r\n* Thirdly, I updated the RegEx to be more lenient\r\n* Fourthly, I added a cache so only files which have changed will get relinted","created_at":"2016-06-06T22:33:43Z","updated_at":"2016-06-07T22:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"babefe54ae877a1d862a495896b77db322efdc34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17/commits","review_comments_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17/comments","review_comment_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/17/comments","statuses_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/statuses/d7bad1b4258dc7a807f6627332d9387afda5baaf","head":{"label":"nickpape-msft:master","ref":"master","sha":"d7bad1b4258dc7a807f6627332d9387afda5baaf","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"repo":{"id":60564805,"name":"gulp-core-build-typescript","full_name":"nickpape-msft/gulp-core-build-typescript","owner":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickpape-msft/gulp-core-build-typescript","description":"","fork":true,"url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript","forks_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/forks","keys_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/teams","hooks_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/hooks","issue_events_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/events","assignees_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/tags","blobs_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/languages","stargazers_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/stargazers","contributors_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/contributors","subscribers_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/subscribers","subscription_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/subscription","commits_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/merges","archive_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/downloads","issues_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/labels{/name}","releases_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/nickpape-msft/gulp-core-build-typescript/deployments","created_at":"2016-06-06T22:23:00Z","updated_at":"2016-06-06T22:23:01Z","pushed_at":"2016-06-07T18:35:12Z","git_url":"git://github.com/nickpape-msft/gulp-core-build-typescript.git","ssh_url":"git@github.com:nickpape-msft/gulp-core-build-typescript.git","clone_url":"https://github.com/nickpape-msft/gulp-core-build-typescript.git","svn_url":"https://github.com/nickpape-msft/gulp-core-build-typescript","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dzearing:master","ref":"master","sha":"1343cc97ae3c409e209f663d09bc8da18f767b4a","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"repo":{"id":53446459,"name":"gulp-core-build-typescript","full_name":"dzearing/gulp-core-build-typescript","owner":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzearing/gulp-core-build-typescript","description":"","fork":false,"url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript","forks_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/forks","keys_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/teams","hooks_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/hooks","issue_events_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/events","assignees_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/tags","blobs_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/languages","stargazers_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/stargazers","contributors_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/contributors","subscribers_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/subscribers","subscription_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/subscription","commits_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/merges","archive_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/downloads","issues_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/labels{/name}","releases_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/deployments","created_at":"2016-03-08T21:28:30Z","updated_at":"2016-03-08T22:16:52Z","pushed_at":"2016-06-07T18:35:12Z","git_url":"git://github.com/dzearing/gulp-core-build-typescript.git","ssh_url":"git@github.com:dzearing/gulp-core-build-typescript.git","clone_url":"https://github.com/dzearing/gulp-core-build-typescript.git","svn_url":"https://github.com/dzearing/gulp-core-build-typescript","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17"},"html":{"href":"https://github.com/dzearing/gulp-core-build-typescript/pull/17"},"issue":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/17"},"comments":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/dzearing/gulp-core-build-typescript/statuses/d7bad1b4258dc7a807f6627332d9387afda5baaf"}}}}
{"actor":{"display_login":"nickpape-msft"}}