{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/haskell/pulls/comments/88703756","pull_request_review_id":9271290,"id":88703756,"diff_hunk":"@@ -33,25 +33,31 @@ import qualified TensorFlow.Nodes as TF\n import qualified TensorFlow.Ops as TF\n import qualified TensorFlow.Session as TF\n import qualified TensorFlow.Tensor as TF\n+import qualified TensorFlow.Types as TF\n \n -- | Test that one can easily determine number of elements in the tensor.\n+testSize :: Test\n testSize = testCase \"testSize\" $ do\n-    x <- eval $ TF.size (TF.constant [2, 3] [0..5 :: Float])\n+    x <- eval $ TF.size (TF.constant (TF.Shape [2, 3]) [0..5 :: Float])","path":"tensorflow-ops/tests/OpsTest.hs","position":29,"original_position":29,"commit_id":"15060298ed5fd62c0245ad91a469af4d89179498","original_commit_id":"15060298ed5fd62c0245ad91a469af4d89179498","user":{"login":"judah","id":49143,"avatar_url":"https://avatars.githubusercontent.com/u/49143?v=3","gravatar_id":"","url":"https://api.github.com/users/judah","html_url":"https://github.com/judah","followers_url":"https://api.github.com/users/judah/followers","following_url":"https://api.github.com/users/judah/following{/other_user}","gists_url":"https://api.github.com/users/judah/gists{/gist_id}","starred_url":"https://api.github.com/users/judah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judah/subscriptions","organizations_url":"https://api.github.com/users/judah/orgs","repos_url":"https://api.github.com/users/judah/repos","events_url":"https://api.github.com/users/judah/events{/privacy}","received_events_url":"https://api.github.com/users/judah/received_events","type":"User","site_admin":false},"body":"I'm curious of the reason to remove the use of OverloadedLists here; maybe we can improve something in our libraries to prevent warnings?","created_at":"2016-11-18T17:46:29Z","updated_at":"2016-11-18T17:48:16Z","html_url":"https://github.com/tensorflow/haskell/pull/35#discussion_r88703756","pull_request_url":"https://api.github.com/repos/tensorflow/haskell/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/comments/88703756"},"html":{"href":"https://github.com/tensorflow/haskell/pull/35#discussion_r88703756"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/haskell/pulls/35","id":94257421,"html_url":"https://github.com/tensorflow/haskell/pull/35","diff_url":"https://github.com/tensorflow/haskell/pull/35.diff","patch_url":"https://github.com/tensorflow/haskell/pull/35.patch","issue_url":"https://api.github.com/repos/tensorflow/haskell/issues/35","number":35,"state":"open","locked":false,"title":"Make code --pedantic","user":{"login":"blackgnezdo","id":8768818,"avatar_url":"https://avatars.githubusercontent.com/u/8768818?v=3","gravatar_id":"","url":"https://api.github.com/users/blackgnezdo","html_url":"https://github.com/blackgnezdo","followers_url":"https://api.github.com/users/blackgnezdo/followers","following_url":"https://api.github.com/users/blackgnezdo/following{/other_user}","gists_url":"https://api.github.com/users/blackgnezdo/gists{/gist_id}","starred_url":"https://api.github.com/users/blackgnezdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackgnezdo/subscriptions","organizations_url":"https://api.github.com/users/blackgnezdo/orgs","repos_url":"https://api.github.com/users/blackgnezdo/repos","events_url":"https://api.github.com/users/blackgnezdo/events{/privacy}","received_events_url":"https://api.github.com/users/blackgnezdo/received_events","type":"User","site_admin":false},"body":"\r\nEnforce pedantic build mode in CI.\r\nOur imports drifted really far from where they should be.","created_at":"2016-11-17T21:45:28Z","updated_at":"2016-11-18T17:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"121a46453bb3630a7d67b79b5a9ae9cb7493e022","assignee":{"login":"judah","id":49143,"avatar_url":"https://avatars.githubusercontent.com/u/49143?v=3","gravatar_id":"","url":"https://api.github.com/users/judah","html_url":"https://github.com/judah","followers_url":"https://api.github.com/users/judah/followers","following_url":"https://api.github.com/users/judah/following{/other_user}","gists_url":"https://api.github.com/users/judah/gists{/gist_id}","starred_url":"https://api.github.com/users/judah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judah/subscriptions","organizations_url":"https://api.github.com/users/judah/orgs","repos_url":"https://api.github.com/users/judah/repos","events_url":"https://api.github.com/users/judah/events{/privacy}","received_events_url":"https://api.github.com/users/judah/received_events","type":"User","site_admin":false},"assignees":[{"login":"judah","id":49143,"avatar_url":"https://avatars.githubusercontent.com/u/49143?v=3","gravatar_id":"","url":"https://api.github.com/users/judah","html_url":"https://github.com/judah","followers_url":"https://api.github.com/users/judah/followers","following_url":"https://api.github.com/users/judah/following{/other_user}","gists_url":"https://api.github.com/users/judah/gists{/gist_id}","starred_url":"https://api.github.com/users/judah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judah/subscriptions","organizations_url":"https://api.github.com/users/judah/orgs","repos_url":"https://api.github.com/users/judah/repos","events_url":"https://api.github.com/users/judah/events{/privacy}","received_events_url":"https://api.github.com/users/judah/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/haskell/pulls/35/commits","review_comments_url":"https://api.github.com/repos/tensorflow/haskell/pulls/35/comments","review_comment_url":"https://api.github.com/repos/tensorflow/haskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/haskell/issues/35/comments","statuses_url":"https://api.github.com/repos/tensorflow/haskell/statuses/15060298ed5fd62c0245ad91a469af4d89179498","head":{"label":"tensorflow:pedantic","ref":"pedantic","sha":"15060298ed5fd62c0245ad91a469af4d89179498","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":71028374,"name":"haskell","full_name":"tensorflow/haskell","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/haskell","description":"Haskell bindings for TensorFlow","fork":false,"url":"https://api.github.com/repos/tensorflow/haskell","forks_url":"https://api.github.com/repos/tensorflow/haskell/forks","keys_url":"https://api.github.com/repos/tensorflow/haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/haskell/teams","hooks_url":"https://api.github.com/repos/tensorflow/haskell/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/haskell/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/haskell/events","assignees_url":"https://api.github.com/repos/tensorflow/haskell/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/haskell/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/haskell/tags","blobs_url":"https://api.github.com/repos/tensorflow/haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/haskell/languages","stargazers_url":"https://api.github.com/repos/tensorflow/haskell/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/haskell/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/haskell/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/haskell/subscription","commits_url":"https://api.github.com/repos/tensorflow/haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/haskell/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/haskell/merges","archive_url":"https://api.github.com/repos/tensorflow/haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/haskell/downloads","issues_url":"https://api.github.com/repos/tensorflow/haskell/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/haskell/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/haskell/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/haskell/deployments","created_at":"2016-10-16T03:40:47Z","updated_at":"2016-11-17T15:15:13Z","pushed_at":"2016-11-18T17:07:04Z","git_url":"git://github.com/tensorflow/haskell.git","ssh_url":"git@github.com:tensorflow/haskell.git","clone_url":"https://github.com/tensorflow/haskell.git","svn_url":"https://github.com/tensorflow/haskell","homepage":"https://tensorflow.github.io/haskell/haddock/","size":1258,"stargazers_count":278,"watchers_count":278,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":278,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"69fdbf677ff5c56ee99576310ee65ccf0efdf2b2","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":71028374,"name":"haskell","full_name":"tensorflow/haskell","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/haskell","description":"Haskell bindings for TensorFlow","fork":false,"url":"https://api.github.com/repos/tensorflow/haskell","forks_url":"https://api.github.com/repos/tensorflow/haskell/forks","keys_url":"https://api.github.com/repos/tensorflow/haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/haskell/teams","hooks_url":"https://api.github.com/repos/tensorflow/haskell/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/haskell/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/haskell/events","assignees_url":"https://api.github.com/repos/tensorflow/haskell/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/haskell/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/haskell/tags","blobs_url":"https://api.github.com/repos/tensorflow/haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/haskell/languages","stargazers_url":"https://api.github.com/repos/tensorflow/haskell/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/haskell/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/haskell/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/haskell/subscription","commits_url":"https://api.github.com/repos/tensorflow/haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/haskell/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/haskell/merges","archive_url":"https://api.github.com/repos/tensorflow/haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/haskell/downloads","issues_url":"https://api.github.com/repos/tensorflow/haskell/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/haskell/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/haskell/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/haskell/deployments","created_at":"2016-10-16T03:40:47Z","updated_at":"2016-11-17T15:15:13Z","pushed_at":"2016-11-18T17:07:04Z","git_url":"git://github.com/tensorflow/haskell.git","ssh_url":"git@github.com:tensorflow/haskell.git","clone_url":"https://github.com/tensorflow/haskell.git","svn_url":"https://github.com/tensorflow/haskell","homepage":"https://tensorflow.github.io/haskell/haddock/","size":1258,"stargazers_count":278,"watchers_count":278,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/35"},"html":{"href":"https://github.com/tensorflow/haskell/pull/35"},"issue":{"href":"https://api.github.com/repos/tensorflow/haskell/issues/35"},"comments":{"href":"https://api.github.com/repos/tensorflow/haskell/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/haskell/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/haskell/statuses/15060298ed5fd62c0245ad91a469af4d89179498"}}}}
{"actor":{"display_login":"judah"}}