{"action":"created","comment":{"url":"https://api.github.com/repos/kapost/circuitry/pulls/comments/51452495","id":51452495,"diff_hunk":"@@ -0,0 +1,59 @@\n+require 'circuitry/provisioning/queue_creator'\n+require 'circuitry/provisioning/topic_creator'\n+require 'circuitry/provisioning/subscription_creator'\n+\n+module Circuitry\n+  module Provisioning\n+    class << self\n+      def provision_from_config(config, logger: Logger.new(STDOUT))","path":"lib/circuitry/provisioning.rb","position":8,"original_position":8,"commit_id":"00979848341182b13f01eebae5233647741a5617","original_commit_id":"00979848341182b13f01eebae5233647741a5617","user":{"login":"mhuggins","id":169093,"avatar_url":"https://avatars.githubusercontent.com/u/169093?v=3","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"body":"I'd consider just calling this method `provision`.  There is no reason to add the `_from_config` suffix since you're not differentiating from other privisioning methods.","created_at":"2016-02-01T17:48:07Z","updated_at":"2016-02-01T17:48:07Z","html_url":"https://github.com/kapost/circuitry/pull/36#discussion_r51452495","pull_request_url":"https://api.github.com/repos/kapost/circuitry/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/comments/51452495"},"html":{"href":"https://github.com/kapost/circuitry/pull/36#discussion_r51452495"},"pull_request":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/kapost/circuitry/pulls/36","id":57779440,"html_url":"https://github.com/kapost/circuitry/pull/36","diff_url":"https://github.com/kapost/circuitry/pull/36.diff","patch_url":"https://github.com/kapost/circuitry/pull/36.patch","issue_url":"https://api.github.com/repos/kapost/circuitry/issues/36","number":36,"state":"open","locked":false,"title":"Allow subscriber_topic_names configuration","user":{"login":"brandonc","id":174332,"avatar_url":"https://avatars.githubusercontent.com/u/174332?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonc","html_url":"https://github.com/brandonc","followers_url":"https://api.github.com/users/brandonc/followers","following_url":"https://api.github.com/users/brandonc/following{/other_user}","gists_url":"https://api.github.com/users/brandonc/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonc/subscriptions","organizations_url":"https://api.github.com/users/brandonc/orgs","repos_url":"https://api.github.com/users/brandonc/repos","events_url":"https://api.github.com/users/brandonc/events{/privacy}","received_events_url":"https://api.github.com/users/brandonc/received_events","type":"User","site_admin":false},"body":"It doesn't make sense to subscribe publisher_topic_names to the\nsubscriber queue. Therefore, I:\n\n- Added subscriber_topic_names configuration and changed the\nprovisioner to create both subscriber_topic_names and\npublisher_topic_names, but only subscribe subscriber_topic_names to the\nsubscriber queue\n- Refactored the Provisioner class into a Provisioning module with a\nclass method #provision_from_config","created_at":"2016-01-31T20:39:53Z","updated_at":"2016-02-01T17:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff626c24a6bbb9e57d06030268b41ec356f8d81a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kapost/circuitry/pulls/36/commits","review_comments_url":"https://api.github.com/repos/kapost/circuitry/pulls/36/comments","review_comment_url":"https://api.github.com/repos/kapost/circuitry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kapost/circuitry/issues/36/comments","statuses_url":"https://api.github.com/repos/kapost/circuitry/statuses/00979848341182b13f01eebae5233647741a5617","head":{"label":"kapost:feature/subscriber_topics_config","ref":"feature/subscriber_topics_config","sha":"00979848341182b13f01eebae5233647741a5617","user":{"login":"kapost","id":2104524,"avatar_url":"https://avatars.githubusercontent.com/u/2104524?v=3","gravatar_id":"","url":"https://api.github.com/users/kapost","html_url":"https://github.com/kapost","followers_url":"https://api.github.com/users/kapost/followers","following_url":"https://api.github.com/users/kapost/following{/other_user}","gists_url":"https://api.github.com/users/kapost/gists{/gist_id}","starred_url":"https://api.github.com/users/kapost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapost/subscriptions","organizations_url":"https://api.github.com/users/kapost/orgs","repos_url":"https://api.github.com/users/kapost/repos","events_url":"https://api.github.com/users/kapost/events{/privacy}","received_events_url":"https://api.github.com/users/kapost/received_events","type":"Organization","site_admin":false},"repo":{"id":36836081,"name":"circuitry","full_name":"kapost/circuitry","owner":{"login":"kapost","id":2104524,"avatar_url":"https://avatars.githubusercontent.com/u/2104524?v=3","gravatar_id":"","url":"https://api.github.com/users/kapost","html_url":"https://github.com/kapost","followers_url":"https://api.github.com/users/kapost/followers","following_url":"https://api.github.com/users/kapost/following{/other_user}","gists_url":"https://api.github.com/users/kapost/gists{/gist_id}","starred_url":"https://api.github.com/users/kapost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapost/subscriptions","organizations_url":"https://api.github.com/users/kapost/orgs","repos_url":"https://api.github.com/users/kapost/repos","events_url":"https://api.github.com/users/kapost/events{/privacy}","received_events_url":"https://api.github.com/users/kapost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kapost/circuitry","description":"Decouple ruby applications using SNS fanout with SQS processing.","fork":false,"url":"https://api.github.com/repos/kapost/circuitry","forks_url":"https://api.github.com/repos/kapost/circuitry/forks","keys_url":"https://api.github.com/repos/kapost/circuitry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapost/circuitry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapost/circuitry/teams","hooks_url":"https://api.github.com/repos/kapost/circuitry/hooks","issue_events_url":"https://api.github.com/repos/kapost/circuitry/issues/events{/number}","events_url":"https://api.github.com/repos/kapost/circuitry/events","assignees_url":"https://api.github.com/repos/kapost/circuitry/assignees{/user}","branches_url":"https://api.github.com/repos/kapost/circuitry/branches{/branch}","tags_url":"https://api.github.com/repos/kapost/circuitry/tags","blobs_url":"https://api.github.com/repos/kapost/circuitry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapost/circuitry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapost/circuitry/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapost/circuitry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapost/circuitry/statuses/{sha}","languages_url":"https://api.github.com/repos/kapost/circuitry/languages","stargazers_url":"https://api.github.com/repos/kapost/circuitry/stargazers","contributors_url":"https://api.github.com/repos/kapost/circuitry/contributors","subscribers_url":"https://api.github.com/repos/kapost/circuitry/subscribers","subscription_url":"https://api.github.com/repos/kapost/circuitry/subscription","commits_url":"https://api.github.com/repos/kapost/circuitry/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapost/circuitry/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapost/circuitry/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapost/circuitry/issues/comments{/number}","contents_url":"https://api.github.com/repos/kapost/circuitry/contents/{+path}","compare_url":"https://api.github.com/repos/kapost/circuitry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapost/circuitry/merges","archive_url":"https://api.github.com/repos/kapost/circuitry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapost/circuitry/downloads","issues_url":"https://api.github.com/repos/kapost/circuitry/issues{/number}","pulls_url":"https://api.github.com/repos/kapost/circuitry/pulls{/number}","milestones_url":"https://api.github.com/repos/kapost/circuitry/milestones{/number}","notifications_url":"https://api.github.com/repos/kapost/circuitry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapost/circuitry/labels{/name}","releases_url":"https://api.github.com/repos/kapost/circuitry/releases{/id}","deployments_url":"https://api.github.com/repos/kapost/circuitry/deployments","created_at":"2015-06-03T23:20:41Z","updated_at":"2016-01-27T23:51:14Z","pushed_at":"2016-01-31T20:39:54Z","git_url":"git://github.com/kapost/circuitry.git","ssh_url":"git@github.com:kapost/circuitry.git","clone_url":"https://github.com/kapost/circuitry.git","svn_url":"https://github.com/kapost/circuitry","homepage":"","size":156,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":41,"default_branch":"master"}},"base":{"label":"kapost:master","ref":"master","sha":"ec252d14b6ab11e3e5db5c5fc32e7d2bd9ada5c2","user":{"login":"kapost","id":2104524,"avatar_url":"https://avatars.githubusercontent.com/u/2104524?v=3","gravatar_id":"","url":"https://api.github.com/users/kapost","html_url":"https://github.com/kapost","followers_url":"https://api.github.com/users/kapost/followers","following_url":"https://api.github.com/users/kapost/following{/other_user}","gists_url":"https://api.github.com/users/kapost/gists{/gist_id}","starred_url":"https://api.github.com/users/kapost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapost/subscriptions","organizations_url":"https://api.github.com/users/kapost/orgs","repos_url":"https://api.github.com/users/kapost/repos","events_url":"https://api.github.com/users/kapost/events{/privacy}","received_events_url":"https://api.github.com/users/kapost/received_events","type":"Organization","site_admin":false},"repo":{"id":36836081,"name":"circuitry","full_name":"kapost/circuitry","owner":{"login":"kapost","id":2104524,"avatar_url":"https://avatars.githubusercontent.com/u/2104524?v=3","gravatar_id":"","url":"https://api.github.com/users/kapost","html_url":"https://github.com/kapost","followers_url":"https://api.github.com/users/kapost/followers","following_url":"https://api.github.com/users/kapost/following{/other_user}","gists_url":"https://api.github.com/users/kapost/gists{/gist_id}","starred_url":"https://api.github.com/users/kapost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapost/subscriptions","organizations_url":"https://api.github.com/users/kapost/orgs","repos_url":"https://api.github.com/users/kapost/repos","events_url":"https://api.github.com/users/kapost/events{/privacy}","received_events_url":"https://api.github.com/users/kapost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kapost/circuitry","description":"Decouple ruby applications using SNS fanout with SQS processing.","fork":false,"url":"https://api.github.com/repos/kapost/circuitry","forks_url":"https://api.github.com/repos/kapost/circuitry/forks","keys_url":"https://api.github.com/repos/kapost/circuitry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapost/circuitry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapost/circuitry/teams","hooks_url":"https://api.github.com/repos/kapost/circuitry/hooks","issue_events_url":"https://api.github.com/repos/kapost/circuitry/issues/events{/number}","events_url":"https://api.github.com/repos/kapost/circuitry/events","assignees_url":"https://api.github.com/repos/kapost/circuitry/assignees{/user}","branches_url":"https://api.github.com/repos/kapost/circuitry/branches{/branch}","tags_url":"https://api.github.com/repos/kapost/circuitry/tags","blobs_url":"https://api.github.com/repos/kapost/circuitry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapost/circuitry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapost/circuitry/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapost/circuitry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapost/circuitry/statuses/{sha}","languages_url":"https://api.github.com/repos/kapost/circuitry/languages","stargazers_url":"https://api.github.com/repos/kapost/circuitry/stargazers","contributors_url":"https://api.github.com/repos/kapost/circuitry/contributors","subscribers_url":"https://api.github.com/repos/kapost/circuitry/subscribers","subscription_url":"https://api.github.com/repos/kapost/circuitry/subscription","commits_url":"https://api.github.com/repos/kapost/circuitry/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapost/circuitry/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapost/circuitry/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapost/circuitry/issues/comments{/number}","contents_url":"https://api.github.com/repos/kapost/circuitry/contents/{+path}","compare_url":"https://api.github.com/repos/kapost/circuitry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapost/circuitry/merges","archive_url":"https://api.github.com/repos/kapost/circuitry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapost/circuitry/downloads","issues_url":"https://api.github.com/repos/kapost/circuitry/issues{/number}","pulls_url":"https://api.github.com/repos/kapost/circuitry/pulls{/number}","milestones_url":"https://api.github.com/repos/kapost/circuitry/milestones{/number}","notifications_url":"https://api.github.com/repos/kapost/circuitry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapost/circuitry/labels{/name}","releases_url":"https://api.github.com/repos/kapost/circuitry/releases{/id}","deployments_url":"https://api.github.com/repos/kapost/circuitry/deployments","created_at":"2015-06-03T23:20:41Z","updated_at":"2016-01-27T23:51:14Z","pushed_at":"2016-01-31T20:39:54Z","git_url":"git://github.com/kapost/circuitry.git","ssh_url":"git@github.com:kapost/circuitry.git","clone_url":"https://github.com/kapost/circuitry.git","svn_url":"https://github.com/kapost/circuitry","homepage":"","size":156,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/36"},"html":{"href":"https://github.com/kapost/circuitry/pull/36"},"issue":{"href":"https://api.github.com/repos/kapost/circuitry/issues/36"},"comments":{"href":"https://api.github.com/repos/kapost/circuitry/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kapost/circuitry/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/kapost/circuitry/statuses/00979848341182b13f01eebae5233647741a5617"}}}}