{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/37584","repository_url":"https://api.github.com/repos/brianchandotcom/liferay-portal","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/37584/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/37584/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/37584/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/37584","id":140838489,"number":37584,"title":"Lps 64246","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-15T00:54:18Z","updated_at":"2016-03-15T14:46:17Z","closed_at":"2016-03-15T14:46:17Z","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/37584","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/37584","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/37584.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/37584.patch"},"body":"CC @csierra this is caused by liferay@1372a7e\r\n\r\nCC @michaelhashimoto\r\n\r\n@brianchandotcom https://github.com/brianchandotcom/liferay-portal/commit/11e54051d0fdab22358685bdecd5aab22541d7c4 is a temp work around.\r\n\r\nregistry-impl needs the portal-kernel dependency to get over this infinite loop thread safety issue.\r\n\r\nLater, either we have @Ithildir working out a proper auto replace build script logic, or @csierra rewrite those tests to do our arquillian way in a real tomcat, or we break down kernel into many many modules.\r\n\r\nIt is up to you @brianchandotcom to take which route."},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/196850917","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/37584#issuecomment-196850917","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/37584","id":196850917,"user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T14:46:17Z","updated_at":"2016-03-15T14:46:17Z","body":"ok, let's not embedded the code, it is not 1 or 2 classes we are talking about here. We will end up including 10~20 classes. Our perm/ meta space has grown rapidly due to all sorts of bnd includes. \r\n\r\nIdeally those kernel code we use here can be pulled out as a module which only has jdk dependency, then registry can safely use it, but it is too late for that, and I don't have the bandwidth for it.\r\n\r\nLet's find a middle ground. I am going to rewrite that ServiceTracker tracking logic a bit, still reference based, but directly using jdk code. It is techinically duplicating whay kernel is doing, but in the most simplified way, at least this should only have minimal perm/meta space impact.\r\n\r\nI will start on it once I get in office."}}