{"action":"created","issue":{"url":"https://api.github.com/repos/danger/danger/issues/591","repository_url":"https://api.github.com/repos/danger/danger","labels_url":"https://api.github.com/repos/danger/danger/issues/591/labels{/name}","comments_url":"https://api.github.com/repos/danger/danger/issues/591/comments","events_url":"https://api.github.com/repos/danger/danger/issues/591/events","html_url":"https://github.com/danger/danger/pull/591","id":179784077,"number":591,"title":"Improves `danger local` merged Pull Request finding logic","user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-28T14:11:14Z","updated_at":"2016-09-29T05:27:45Z","closed_at":"2016-09-28T18:19:22Z","pull_request":{"url":"https://api.github.com/repos/danger/danger/pulls/591","html_url":"https://github.com/danger/danger/pull/591","diff_url":"https://github.com/danger/danger/pull/591.diff","patch_url":"https://github.com/danger/danger/pull/591.patch"},"body":"This Pull Request improves `danger local` finding merged Pull Request logic.\r\n\r\nI was trying to use `danger local` against my repo and found this bug 😢 \r\n\r\n--\r\n\r\n<details>\r\n<summary>Implementation Details</summary>\r\n- Feed in PR ID correctly to `MergedPullRequestFinder`:\r\n\r\n  Given `LOCAL_GIT_PR_ID=\"2\"`\r\n\r\n  Before\r\n\r\n  `env[\"LOCAL_GIT_PR_ID\"] || \"\" # => \"\"`\r\n\r\n  After\r\n\r\n  `env.fetch(\"LOCAL_GIT_PR_ID\") { \"\" } # => \"2\"`\r\n\r\n- Handle case that both merged and squash-and-merged (same as rebase merge) PR both presents\r\n\r\n  * `Something (#2)`\r\n  * `Merge pull request #2`\r\n\r\n    Pick the most recent one in these two.\r\n\r\n- Improves the RegExp for finding merged pull request and\r\nsquash-and-merged pull request.\r\n\r\n  * Merged PR:\r\n\r\n    - Before: `\"Merge pull request #2\"`\r\n    - After: `\"Merge pull request #2 from\"`\r\n\r\n  * Squash-and-merged PR:\r\n\r\n    - Before: `\"#2\"`\r\n    - After: `\"(#2)\"`\r\n\r\n- When PR ID not specified, use`/#\\d+/` to search a recent PR.\r\n</details>"},"comment":{"url":"https://api.github.com/repos/danger/danger/issues/comments/250373582","html_url":"https://github.com/danger/danger/pull/591#issuecomment-250373582","issue_url":"https://api.github.com/repos/danger/danger/issues/591","id":250373582,"user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T05:27:45Z","updated_at":"2016-09-29T05:27:45Z","body":"> I was actual wondering if you were interested in trying to tackle the refactor from danger local to danger local and danger pr? e.g starting #518 from scratch?\r\n\r\nyes, I'm interested, will look into #518, thank you 👍 ."}}
{"actor":{"display_login":"JuanitoFatas"}}