{"action":"created","comment":{"url":"https://api.github.com/repos/samilliken/openDCIM/pulls/comments/82425304","pull_request_review_id":3336373,"id":82425304,"diff_hunk":"@@ -11,16 +11,6 @@\n   $content = \"\";\n   $person = new People();\n \n-  if ( isset($_GET['logout'])) {","path":"login_ldap.php","position":4,"original_position":4,"commit_id":"9aaeb273776ba5c06ab5409d73691629c06d6f2d","original_commit_id":"9aaeb273776ba5c06ab5409d73691629c06d6f2d","user":{"login":"syndgr","id":20760738,"avatar_url":"https://avatars.githubusercontent.com/u/20760738?v=3","gravatar_id":"","url":"https://api.github.com/users/syndgr","html_url":"https://github.com/syndgr","followers_url":"https://api.github.com/users/syndgr/followers","following_url":"https://api.github.com/users/syndgr/following{/other_user}","gists_url":"https://api.github.com/users/syndgr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndgr/subscriptions","organizations_url":"https://api.github.com/users/syndgr/orgs","repos_url":"https://api.github.com/users/syndgr/repos","events_url":"https://api.github.com/users/syndgr/events{/privacy}","received_events_url":"https://api.github.com/users/syndgr/received_events","type":"User","site_admin":false},"body":"Moved logout code to new file, logout.php, so we're not duplicating this code and having to remember to maintain it in two different places.","created_at":"2016-10-07T16:40:49Z","updated_at":"2016-10-07T16:40:49Z","html_url":"https://github.com/samilliken/openDCIM/pull/824#discussion_r82425304","pull_request_url":"https://api.github.com/repos/samilliken/openDCIM/pulls/824","_links":{"self":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/comments/82425304"},"html":{"href":"https://github.com/samilliken/openDCIM/pull/824#discussion_r82425304"},"pull_request":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/824"}}},"pull_request":{"url":"https://api.github.com/repos/samilliken/openDCIM/pulls/824","id":88461145,"html_url":"https://github.com/samilliken/openDCIM/pull/824","diff_url":"https://github.com/samilliken/openDCIM/pull/824.diff","patch_url":"https://github.com/samilliken/openDCIM/pull/824.patch","issue_url":"https://api.github.com/repos/samilliken/openDCIM/issues/824","number":824,"state":"open","locked":false,"title":"AD authentication","user":{"login":"syndgr","id":20760738,"avatar_url":"https://avatars.githubusercontent.com/u/20760738?v=3","gravatar_id":"","url":"https://api.github.com/users/syndgr","html_url":"https://github.com/syndgr","followers_url":"https://api.github.com/users/syndgr/followers","following_url":"https://api.github.com/users/syndgr/following{/other_user}","gists_url":"https://api.github.com/users/syndgr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndgr/subscriptions","organizations_url":"https://api.github.com/users/syndgr/orgs","repos_url":"https://api.github.com/users/syndgr/repos","events_url":"https://api.github.com/users/syndgr/events{/privacy}","received_events_url":"https://api.github.com/users/syndgr/received_events","type":"User","site_admin":false},"body":"These changes introduce AD authentication to openDCIM. Even though Active Directory is LDAP based, there are certain differences and scenarios where LDAP authentication is not appropriate. Most noted is when a user has multiple AD domains and users can authenticate from different domains.\r\n\r\nAlso included are some bug fixes. For example install.php was missing the Bulk Operations group DN field, some session values were set in ldap_bootstrap.php but the code hadn't made it to install.php.\r\n\r\nI've tested the changes against our multiple domain AD environment (we're using this code in production). Also regression tested against a test OpenLDAP instance to make sure I've not broken anything. And tested with Apache authentication. I have no means of testing OAuth.\r\n\r\nI've also written some documentation here: https://github.com/syndgr/openDCIM/wiki/Active-Directory-authentication\r\n\r\nYou can crib this for the openDCIM wiki.","created_at":"2016-10-07T15:40:22Z","updated_at":"2016-10-07T16:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8abac9e786aabfffabc417acedf3d3379ff4c598","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samilliken/openDCIM/pulls/824/commits","review_comments_url":"https://api.github.com/repos/samilliken/openDCIM/pulls/824/comments","review_comment_url":"https://api.github.com/repos/samilliken/openDCIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samilliken/openDCIM/issues/824/comments","statuses_url":"https://api.github.com/repos/samilliken/openDCIM/statuses/9aaeb273776ba5c06ab5409d73691629c06d6f2d","head":{"label":"syndgr:master","ref":"master","sha":"9aaeb273776ba5c06ab5409d73691629c06d6f2d","user":{"login":"syndgr","id":20760738,"avatar_url":"https://avatars.githubusercontent.com/u/20760738?v=3","gravatar_id":"","url":"https://api.github.com/users/syndgr","html_url":"https://github.com/syndgr","followers_url":"https://api.github.com/users/syndgr/followers","following_url":"https://api.github.com/users/syndgr/following{/other_user}","gists_url":"https://api.github.com/users/syndgr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndgr/subscriptions","organizations_url":"https://api.github.com/users/syndgr/orgs","repos_url":"https://api.github.com/users/syndgr/repos","events_url":"https://api.github.com/users/syndgr/events{/privacy}","received_events_url":"https://api.github.com/users/syndgr/received_events","type":"User","site_admin":false},"repo":{"id":69272974,"name":"openDCIM","full_name":"syndgr/openDCIM","owner":{"login":"syndgr","id":20760738,"avatar_url":"https://avatars.githubusercontent.com/u/20760738?v=3","gravatar_id":"","url":"https://api.github.com/users/syndgr","html_url":"https://github.com/syndgr","followers_url":"https://api.github.com/users/syndgr/followers","following_url":"https://api.github.com/users/syndgr/following{/other_user}","gists_url":"https://api.github.com/users/syndgr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndgr/subscriptions","organizations_url":"https://api.github.com/users/syndgr/orgs","repos_url":"https://api.github.com/users/syndgr/repos","events_url":"https://api.github.com/users/syndgr/events{/privacy}","received_events_url":"https://api.github.com/users/syndgr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syndgr/openDCIM","description":"An open source (GPL v3) Data Center Inventory Management (DCIM) application.","fork":true,"url":"https://api.github.com/repos/syndgr/openDCIM","forks_url":"https://api.github.com/repos/syndgr/openDCIM/forks","keys_url":"https://api.github.com/repos/syndgr/openDCIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syndgr/openDCIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syndgr/openDCIM/teams","hooks_url":"https://api.github.com/repos/syndgr/openDCIM/hooks","issue_events_url":"https://api.github.com/repos/syndgr/openDCIM/issues/events{/number}","events_url":"https://api.github.com/repos/syndgr/openDCIM/events","assignees_url":"https://api.github.com/repos/syndgr/openDCIM/assignees{/user}","branches_url":"https://api.github.com/repos/syndgr/openDCIM/branches{/branch}","tags_url":"https://api.github.com/repos/syndgr/openDCIM/tags","blobs_url":"https://api.github.com/repos/syndgr/openDCIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syndgr/openDCIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syndgr/openDCIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/syndgr/openDCIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syndgr/openDCIM/statuses/{sha}","languages_url":"https://api.github.com/repos/syndgr/openDCIM/languages","stargazers_url":"https://api.github.com/repos/syndgr/openDCIM/stargazers","contributors_url":"https://api.github.com/repos/syndgr/openDCIM/contributors","subscribers_url":"https://api.github.com/repos/syndgr/openDCIM/subscribers","subscription_url":"https://api.github.com/repos/syndgr/openDCIM/subscription","commits_url":"https://api.github.com/repos/syndgr/openDCIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/syndgr/openDCIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/syndgr/openDCIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/syndgr/openDCIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/syndgr/openDCIM/contents/{+path}","compare_url":"https://api.github.com/repos/syndgr/openDCIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syndgr/openDCIM/merges","archive_url":"https://api.github.com/repos/syndgr/openDCIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syndgr/openDCIM/downloads","issues_url":"https://api.github.com/repos/syndgr/openDCIM/issues{/number}","pulls_url":"https://api.github.com/repos/syndgr/openDCIM/pulls{/number}","milestones_url":"https://api.github.com/repos/syndgr/openDCIM/milestones{/number}","notifications_url":"https://api.github.com/repos/syndgr/openDCIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syndgr/openDCIM/labels{/name}","releases_url":"https://api.github.com/repos/syndgr/openDCIM/releases{/id}","deployments_url":"https://api.github.com/repos/syndgr/openDCIM/deployments","created_at":"2016-09-26T17:10:00Z","updated_at":"2016-09-27T15:21:34Z","pushed_at":"2016-10-07T15:29:46Z","git_url":"git://github.com/syndgr/openDCIM.git","ssh_url":"git@github.com:syndgr/openDCIM.git","clone_url":"https://github.com/syndgr/openDCIM.git","svn_url":"https://github.com/syndgr/openDCIM","homepage":"http://opendcim.org","size":32181,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samilliken:master","ref":"master","sha":"f39b6fa103f0e3764f4978c81486773b6c9d62ea","user":{"login":"samilliken","id":1653883,"avatar_url":"https://avatars.githubusercontent.com/u/1653883?v=3","gravatar_id":"","url":"https://api.github.com/users/samilliken","html_url":"https://github.com/samilliken","followers_url":"https://api.github.com/users/samilliken/followers","following_url":"https://api.github.com/users/samilliken/following{/other_user}","gists_url":"https://api.github.com/users/samilliken/gists{/gist_id}","starred_url":"https://api.github.com/users/samilliken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samilliken/subscriptions","organizations_url":"https://api.github.com/users/samilliken/orgs","repos_url":"https://api.github.com/users/samilliken/repos","events_url":"https://api.github.com/users/samilliken/events{/privacy}","received_events_url":"https://api.github.com/users/samilliken/received_events","type":"User","site_admin":false},"repo":{"id":4059172,"name":"openDCIM","full_name":"samilliken/openDCIM","owner":{"login":"samilliken","id":1653883,"avatar_url":"https://avatars.githubusercontent.com/u/1653883?v=3","gravatar_id":"","url":"https://api.github.com/users/samilliken","html_url":"https://github.com/samilliken","followers_url":"https://api.github.com/users/samilliken/followers","following_url":"https://api.github.com/users/samilliken/following{/other_user}","gists_url":"https://api.github.com/users/samilliken/gists{/gist_id}","starred_url":"https://api.github.com/users/samilliken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samilliken/subscriptions","organizations_url":"https://api.github.com/users/samilliken/orgs","repos_url":"https://api.github.com/users/samilliken/repos","events_url":"https://api.github.com/users/samilliken/events{/privacy}","received_events_url":"https://api.github.com/users/samilliken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samilliken/openDCIM","description":"An open source (GPL v3) Data Center Inventory Management (DCIM) application.","fork":false,"url":"https://api.github.com/repos/samilliken/openDCIM","forks_url":"https://api.github.com/repos/samilliken/openDCIM/forks","keys_url":"https://api.github.com/repos/samilliken/openDCIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samilliken/openDCIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samilliken/openDCIM/teams","hooks_url":"https://api.github.com/repos/samilliken/openDCIM/hooks","issue_events_url":"https://api.github.com/repos/samilliken/openDCIM/issues/events{/number}","events_url":"https://api.github.com/repos/samilliken/openDCIM/events","assignees_url":"https://api.github.com/repos/samilliken/openDCIM/assignees{/user}","branches_url":"https://api.github.com/repos/samilliken/openDCIM/branches{/branch}","tags_url":"https://api.github.com/repos/samilliken/openDCIM/tags","blobs_url":"https://api.github.com/repos/samilliken/openDCIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samilliken/openDCIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samilliken/openDCIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/samilliken/openDCIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samilliken/openDCIM/statuses/{sha}","languages_url":"https://api.github.com/repos/samilliken/openDCIM/languages","stargazers_url":"https://api.github.com/repos/samilliken/openDCIM/stargazers","contributors_url":"https://api.github.com/repos/samilliken/openDCIM/contributors","subscribers_url":"https://api.github.com/repos/samilliken/openDCIM/subscribers","subscription_url":"https://api.github.com/repos/samilliken/openDCIM/subscription","commits_url":"https://api.github.com/repos/samilliken/openDCIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/samilliken/openDCIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/samilliken/openDCIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/samilliken/openDCIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/samilliken/openDCIM/contents/{+path}","compare_url":"https://api.github.com/repos/samilliken/openDCIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samilliken/openDCIM/merges","archive_url":"https://api.github.com/repos/samilliken/openDCIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samilliken/openDCIM/downloads","issues_url":"https://api.github.com/repos/samilliken/openDCIM/issues{/number}","pulls_url":"https://api.github.com/repos/samilliken/openDCIM/pulls{/number}","milestones_url":"https://api.github.com/repos/samilliken/openDCIM/milestones{/number}","notifications_url":"https://api.github.com/repos/samilliken/openDCIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samilliken/openDCIM/labels{/name}","releases_url":"https://api.github.com/repos/samilliken/openDCIM/releases{/id}","deployments_url":"https://api.github.com/repos/samilliken/openDCIM/deployments","created_at":"2012-04-18T01:46:19Z","updated_at":"2016-10-03T21:33:07Z","pushed_at":"2016-10-07T15:40:23Z","git_url":"git://github.com/samilliken/openDCIM.git","ssh_url":"git@github.com:samilliken/openDCIM.git","clone_url":"https://github.com/samilliken/openDCIM.git","svn_url":"https://github.com/samilliken/openDCIM","homepage":"http://opendcim.org","size":43390,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":38,"forks":80,"open_issues":38,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/824"},"html":{"href":"https://github.com/samilliken/openDCIM/pull/824"},"issue":{"href":"https://api.github.com/repos/samilliken/openDCIM/issues/824"},"comments":{"href":"https://api.github.com/repos/samilliken/openDCIM/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samilliken/openDCIM/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/samilliken/openDCIM/statuses/9aaeb273776ba5c06ab5409d73691629c06d6f2d"}}}}
{"actor":{"display_login":"syndgr"}}