{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/loop/pulls/comments/65264750","id":65264750,"diff_hunk":"@@ -298,6 +298,17 @@ describe(\"loop.DataDriver\", () => {\n     });\n   });\n \n+  describe(\"#requestRoomData\", () => {\n+    it(\"should request everything but chat\", () => {\n+      driver.requestRoomData();\n+\n+      let queries = requests[0].url.split(\"?\")[1].split(\"&\").sort();\n+      expect(queries).contain(\"orderBy=%22%24key%22\");\n+      expect(queries).contain(\"startAt=%22chat~%22\");\n+      expect(queries).contain(`limitToLast=${driver.MAX_LIMIT}`);","path":"shared/test/dataDriver_test.js","position":11,"original_position":11,"commit_id":"ffdac1a9fe156a01cdce45e926bc6633b61b613e","original_commit_id":"ffdac1a9fe156a01cdce45e926bc6633b61b613e","user":{"login":"dmose","id":425657,"avatar_url":"https://avatars.githubusercontent.com/u/425657?v=3","gravatar_id":"","url":"https://api.github.com/users/dmose","html_url":"https://github.com/dmose","followers_url":"https://api.github.com/users/dmose/followers","following_url":"https://api.github.com/users/dmose/following{/other_user}","gists_url":"https://api.github.com/users/dmose/gists{/gist_id}","starred_url":"https://api.github.com/users/dmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmose/subscriptions","organizations_url":"https://api.github.com/users/dmose/orgs","repos_url":"https://api.github.com/users/dmose/repos","events_url":"https://api.github.com/users/dmose/events{/privacy}","received_events_url":"https://api.github.com/users/dmose/received_events","type":"User","site_admin":false},"body":"This wants a few helpers, probably on dataDriver itself, to make this more readable.  That said, feel free to just add an XXX here so that someone considers doing it in the future.","created_at":"2016-05-31T21:18:37Z","updated_at":"2016-05-31T21:18:37Z","html_url":"https://github.com/mozilla/loop/pull/466#discussion_r65264750","pull_request_url":"https://api.github.com/repos/mozilla/loop/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments/65264750"},"html":{"href":"https://github.com/mozilla/loop/pull/466#discussion_r65264750"},"pull_request":{"href":"https://api.github.com/repos/mozilla/loop/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/loop/pulls/466","id":71663012,"html_url":"https://github.com/mozilla/loop/pull/466","diff_url":"https://github.com/mozilla/loop/pull/466.diff","patch_url":"https://github.com/mozilla/loop/pull/466.patch","issue_url":"https://api.github.com/repos/mozilla/loop/issues/466","number":466,"state":"open","locked":false,"title":"Bug 1274181 - Request existing room data after firebase connects","user":{"login":"Mardak","id":438537,"avatar_url":"https://avatars.githubusercontent.com/u/438537?v=3","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"body":"This required fixing loop_mocha_utils to correctly implement Promises as SyncThenable.","created_at":"2016-05-27T05:43:07Z","updated_at":"2016-05-31T21:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60275c77de15ba91f87cd81f544cd6cab152bceb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/loop/pulls/466/commits","review_comments_url":"https://api.github.com/repos/mozilla/loop/pulls/466/comments","review_comment_url":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/loop/issues/466/comments","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/ffdac1a9fe156a01cdce45e926bc6633b61b613e","head":{"label":"Mardak:bug-1274181-request-existing","ref":"bug-1274181-request-existing","sha":"ffdac1a9fe156a01cdce45e926bc6633b61b613e","user":{"login":"Mardak","id":438537,"avatar_url":"https://avatars.githubusercontent.com/u/438537?v=3","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"repo":{"id":47700795,"name":"loop","full_name":"Mardak/loop","owner":{"login":"Mardak","id":438537,"avatar_url":"https://avatars.githubusercontent.com/u/438537?v=3","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mardak/loop","description":"","fork":true,"url":"https://api.github.com/repos/Mardak/loop","forks_url":"https://api.github.com/repos/Mardak/loop/forks","keys_url":"https://api.github.com/repos/Mardak/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mardak/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mardak/loop/teams","hooks_url":"https://api.github.com/repos/Mardak/loop/hooks","issue_events_url":"https://api.github.com/repos/Mardak/loop/issues/events{/number}","events_url":"https://api.github.com/repos/Mardak/loop/events","assignees_url":"https://api.github.com/repos/Mardak/loop/assignees{/user}","branches_url":"https://api.github.com/repos/Mardak/loop/branches{/branch}","tags_url":"https://api.github.com/repos/Mardak/loop/tags","blobs_url":"https://api.github.com/repos/Mardak/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mardak/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mardak/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mardak/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mardak/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/Mardak/loop/languages","stargazers_url":"https://api.github.com/repos/Mardak/loop/stargazers","contributors_url":"https://api.github.com/repos/Mardak/loop/contributors","subscribers_url":"https://api.github.com/repos/Mardak/loop/subscribers","subscription_url":"https://api.github.com/repos/Mardak/loop/subscription","commits_url":"https://api.github.com/repos/Mardak/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mardak/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mardak/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mardak/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mardak/loop/contents/{+path}","compare_url":"https://api.github.com/repos/Mardak/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mardak/loop/merges","archive_url":"https://api.github.com/repos/Mardak/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mardak/loop/downloads","issues_url":"https://api.github.com/repos/Mardak/loop/issues{/number}","pulls_url":"https://api.github.com/repos/Mardak/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/Mardak/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/Mardak/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mardak/loop/labels{/name}","releases_url":"https://api.github.com/repos/Mardak/loop/releases{/id}","deployments_url":"https://api.github.com/repos/Mardak/loop/deployments","created_at":"2015-12-09T15:41:43Z","updated_at":"2016-01-13T16:05:59Z","pushed_at":"2016-05-27T14:38:36Z","git_url":"git://github.com/Mardak/loop.git","ssh_url":"git@github.com:Mardak/loop.git","clone_url":"https://github.com/Mardak/loop.git","svn_url":"https://github.com/Mardak/loop","homepage":null,"size":16326,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:akita","ref":"akita","sha":"169425aa587cb7574dd7bd65c3e3ccf91a67a888","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":45496273,"name":"loop","full_name":"mozilla/loop","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/loop","description":"This is the development repository for Firefox Hello","fork":false,"url":"https://api.github.com/repos/mozilla/loop","forks_url":"https://api.github.com/repos/mozilla/loop/forks","keys_url":"https://api.github.com/repos/mozilla/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/loop/teams","hooks_url":"https://api.github.com/repos/mozilla/loop/hooks","issue_events_url":"https://api.github.com/repos/mozilla/loop/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/loop/events","assignees_url":"https://api.github.com/repos/mozilla/loop/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/loop/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/loop/tags","blobs_url":"https://api.github.com/repos/mozilla/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/loop/languages","stargazers_url":"https://api.github.com/repos/mozilla/loop/stargazers","contributors_url":"https://api.github.com/repos/mozilla/loop/contributors","subscribers_url":"https://api.github.com/repos/mozilla/loop/subscribers","subscription_url":"https://api.github.com/repos/mozilla/loop/subscription","commits_url":"https://api.github.com/repos/mozilla/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/loop/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/loop/merges","archive_url":"https://api.github.com/repos/mozilla/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/loop/downloads","issues_url":"https://api.github.com/repos/mozilla/loop/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/loop/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/loop/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/loop/deployments","created_at":"2015-11-03T21:18:47Z","updated_at":"2016-05-28T19:03:15Z","pushed_at":"2016-05-31T21:03:51Z","git_url":"git://github.com/mozilla/loop.git","ssh_url":"git@github.com:mozilla/loop.git","clone_url":"https://github.com/mozilla/loop.git","svn_url":"https://github.com/mozilla/loop","homepage":"https://wiki.mozilla.org/Loop","size":17014,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":17,"forks":29,"open_issues":17,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/466"},"html":{"href":"https://github.com/mozilla/loop/pull/466"},"issue":{"href":"https://api.github.com/repos/mozilla/loop/issues/466"},"comments":{"href":"https://api.github.com/repos/mozilla/loop/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/loop/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/loop/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/loop/statuses/ffdac1a9fe156a01cdce45e926bc6633b61b613e"}}}}
{"actor":{"display_login":"dmose"}}