{"action":"created","issue":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/1060","repository_url":"https://api.github.com/repos/Manishearth/rust-clippy","labels_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/1060/labels{/name}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/1060/comments","events_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/1060/events","html_url":"https://github.com/Manishearth/rust-clippy/pull/1060","id":163044373,"number":1060,"title":"Improve suggestions","user":{"login":"mcarton","id":3751788,"avatar_url":"https://avatars.githubusercontent.com/u/3751788?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarton","html_url":"https://github.com/mcarton","followers_url":"https://api.github.com/users/mcarton/followers","following_url":"https://api.github.com/users/mcarton/following{/other_user}","gists_url":"https://api.github.com/users/mcarton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarton/subscriptions","organizations_url":"https://api.github.com/users/mcarton/orgs","repos_url":"https://api.github.com/users/mcarton/repos","events_url":"https://api.github.com/users/mcarton/events{/privacy}","received_events_url":"https://api.github.com/users/mcarton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-29T22:46:17Z","updated_at":"2016-07-06T13:22:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/1060","html_url":"https://github.com/Manishearth/rust-clippy/pull/1060","diff_url":"https://github.com/Manishearth/rust-clippy/pull/1060.diff","patch_url":"https://github.com/Manishearth/rust-clippy/pull/1060.patch"},"body":"Fix #1052.\r\nThis is a work in progress. I probably have forgotten most suggestions. I'll review them all tomorrow."},"comment":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/comments/230769243","html_url":"https://github.com/Manishearth/rust-clippy/pull/1060#issuecomment-230769243","issue_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/1060","id":230769243,"user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T13:22:09Z","updated_at":"2016-07-06T13:22:09Z","body":"I'm through. The `Sugg` struct is awesome. A lot of code became more readable. Especially where the ad-hoc parenthesis adders were factored out.\r\n\r\nSome parts are a little confusing, like `sugg.as_ty(&format!(\"{} as {}\", x, y))`. I get that the \"type\" is just a string, so we can dump anything there, and that there's not much advantage over `sugg.as_ty(x.to_string()).as_ty(y.to_string())`, but it feels weird. But it's not a blocker imo.\r\n\r\nExcept for the needless bool refactoring, I could not find any bugs that were introduced from the refactoring."}}
{"actor":{"display_login":"oli-obk"}}