{"action":"created","issue":{"url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/288","repository_url":"https://api.github.com/repos/ocombe/ocLazyLoad","labels_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/288/comments","events_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/288/events","html_url":"https://github.com/ocombe/ocLazyLoad/issues/288","id":137299007,"number":288,"title":"ocLazyLoad + Angular 1.5 + Angular 2 + ngUpgrade = sad day","user":{"login":"amcdnl","id":227909,"avatar_url":"https://avatars.githubusercontent.com/u/227909?v=3","gravatar_id":"","url":"https://api.github.com/users/amcdnl","html_url":"https://github.com/amcdnl","followers_url":"https://api.github.com/users/amcdnl/followers","following_url":"https://api.github.com/users/amcdnl/following{/other_user}","gists_url":"https://api.github.com/users/amcdnl/gists{/gist_id}","starred_url":"https://api.github.com/users/amcdnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcdnl/subscriptions","organizations_url":"https://api.github.com/users/amcdnl/orgs","repos_url":"https://api.github.com/users/amcdnl/repos","events_url":"https://api.github.com/users/amcdnl/events{/privacy}","received_events_url":"https://api.github.com/users/amcdnl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-02-29T16:19:02Z","updated_at":"2016-03-09T14:43:00Z","closed_at":"2016-03-09T14:41:57Z","body":"With the following stack:\r\n- ocLazyLoad\r\n- Angular 1.5\r\n- Angular 2\r\n- ngUpgrade\r\n\r\nwhen I drop in ngUpgrade it dies with the following:\r\n\r\n```\r\nangular.js:70 Uncaught Error: [$injector:modulerr] Failed to instantiate module NG2_UPGRADE_0_ due to:\r\nError: [$injector:modulerr] Failed to instantiate module swimlane due to:\r\nError: [$injector:modulerr] Failed to instantiate module core due to:\r\nError: [$injector:modulerr] Failed to instantiate module oc.lazyLoad due to:\r\nNo module found during bootstrap, unable to init ocLazyLoad\r\nhttp://errors.angularjs.org/1.5.0/$injector/modulerr?p0=oc.lazyLoad&p1=No%20module%20found%20during%20bootstrap%2C%20unable%20to%20init%20ocLazyLoad\r\n    at http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:70:12\r\n    at http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:4528:15\r\n    at forEach (http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:323:20)\r\n    at loadModules (http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:4489:5)\r\n    at http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:4506:40\r\n    at forEach (http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:323:20)\r\n    at loadModules (http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:4489:5)\r\n    at http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:4506:40\r\n    at forEach (http://10.211.55.5:9000/jspm_packages/npm/angular@1.5.0/angular.js:323:20)\r\n```\r\n\r\nfrom my convo with @ocombe:\r\n\r\n> yeah, there's a bug with the fact that I override angular.module and ng upgrade does the same. no idea, but it should be possible to make it work, I don't see why not the unit test angular mock package override angular.module as well and I made it work. https://github.com/ocombe/ocLazyLoad/blob/master/src/ocLazyLoad.core.js#L728-L732 I think that \"return ngModuleFct(name, requires, configFn);\" (L731) is probably different with ng upgrade or maybe angular.bootstrap is different."},"comment":{"url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/comments/194324551","html_url":"https://github.com/ocombe/ocLazyLoad/issues/288#issuecomment-194324551","issue_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/288","id":194324551,"user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars.githubusercontent.com/u/265378?v=3","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T14:43:00Z","updated_at":"2016-03-09T14:43:00Z","body":":+1: thanks for the hard work you two"}}