{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14482","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14482/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14482/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14482/events","html_url":"https://github.com/cms-sw/cmssw/pull/14482","id":154552251,"number":14482,"title":"add QIE11 support in hcal digitization","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":587,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-05-12T18:40:53Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-12T18:38:50Z","updated_at":"2016-05-12T18:41:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14482","html_url":"https://github.com/cms-sw/cmssw/pull/14482","diff_url":"https://github.com/cms-sw/cmssw/pull/14482.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14482.patch"},"body":"This PR duplicates all QIE10 functionality for QIE11 (to be used with HE in 2017, and later with HB). Most of the changes are just a straight extension of the changes already made for QIE10. A few other notable changes:\r\n\r\n1) Removed `run2_HF_2016` sub-era: `HcalDigitizer` now automatically assigns a cell to a digi collection based on `QIEType` in the database, no other need for this sub-era.\r\n\r\n2) Cleanup: Removed some unused code in HcalDigitizer and reduced code duplication in a few classes.\r\n\r\n3) Added `run2_HE_2017` sub-era for necessary customizations for the SiPM simulation.\r\n\r\n4) Rearranged HcalCustoms slightly, following the idea that these customization functions will continue to be used for (temporary) development work with hardcode conditions. Now available: \r\na) `customise_Hcal2016` (turns on `testHFQIE10` option)\r\nb) `customise_Hcal2017` (turns on QIE10s throughout HF, uses QIE8/HPD for HE, but allows for extra depths if 2017dev geometry is used)\r\nc) `customise_Hcal2017Full` (as previous, but with QIE11/SiPM conditions for HE; to use this, also enable `run2_HE_2017` sub-era)\r\n\r\n5) Made some changes to the `HitFilter` classes so they are more uniform and more efficient:\r\na) Take a vector of subdet ids to handle HBHE case\r\nb) Use `std::binary_search()` instead of `std::find()` when checking a list of DetIds\r\n\r\nA few validations:\r\n\r\ni) Premixing:\r\n![fc_standard_vs_premix_qie11.png](http://www.kjplanet.com/pr/fc_standard_vs_premix_qie11.png)\r\n\r\nii) QIE11 digis with 2017dev geometry:\r\n![qie11_ieta.png](http://www.kjplanet.com/pr/qie11_ieta.png)\r\n![qie11_depth.png](http://www.kjplanet.com/pr/qie11_depth.png)\r\n\r\nScript for testing with 2017dev geometry:\r\n```\r\n#!/bin/bash\r\n\r\n cmsDriver.py SinglePiE50HCAL_pythia8_cfi  --conditions auto:phase1_2017_design -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent FEVTDEBUG -s GEN,SIM --datatier GEN-SIM --beamspot Realistic50ns13TeVCollision --fileout file:step1.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017Full > step1_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n \r\n\r\n cmsDriver.py step2  --conditions auto:phase1_2017_design -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent FEVTDEBUGHLT --filein file:step1.root  --fileout file:step2.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017Full > step2_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n \r\n\r\n cmsDriver.py step3  --runUnscheduled  --conditions auto:phase1_2017_design -s RAW2DIGI,L1Reco,RECO,EI,PAT --datatier GEN-SIM-RECO,MINIAODSIM -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent RECOSIM,MINIAODSIM --filein file:step2.root  --fileout file:step3.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017Full > step3_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n```"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/218848260","html_url":"https://github.com/cms-sw/cmssw/pull/14482#issuecomment-218848260","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14482","id":218848260,"user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T18:41:20Z","updated_at":"2016-05-12T18:41:20Z","body":"@cmsbuild please test"}}