{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/76745384","id":76745384,"diff_hunk":"@@ -28,6 +28,32 @@ all: $(RUNC_LINK)\n static: $(RUNC_LINK)\n \tCGO_ENABLED=1 go build -i -tags \"$(BUILDTAGS) cgo static_build\" -ldflags \"-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION}\" -o runc .\n \n+release: $(RUNC_LINK)\n+\t@flag_list=(seccomp selinux apparmor static); \\","path":"Makefile","position":5,"original_position":5,"commit_id":"66204cb825318f415836a65b24ea92a654090dd1","original_commit_id":"66204cb825318f415836a65b24ea92a654090dd1","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"body":"This looks quite nice IMO. But maybe we should move this to an actual `.sh` script in `script/...` and call it from the Makefile (so we can avoid the `; \\`, `$$` and other ugliness)?","created_at":"2016-08-30T07:53:12Z","updated_at":"2016-08-30T07:53:12Z","html_url":"https://github.com/opencontainers/runc/pull/914#discussion_r76745384","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/914","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/76745384"},"html":{"href":"https://github.com/opencontainers/runc/pull/914#discussion_r76745384"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/914"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/914","id":73713720,"html_url":"https://github.com/opencontainers/runc/pull/914","diff_url":"https://github.com/opencontainers/runc/pull/914.diff","patch_url":"https://github.com/opencontainers/runc/pull/914.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/914","number":914,"state":"open","locked":false,"title":"Introduce make release","user":{"login":"zhaoleidd","id":11662186,"avatar_url":"https://avatars.githubusercontent.com/u/11662186?v=3","gravatar_id":"","url":"https://api.github.com/users/zhaoleidd","html_url":"https://github.com/zhaoleidd","followers_url":"https://api.github.com/users/zhaoleidd/followers","following_url":"https://api.github.com/users/zhaoleidd/following{/other_user}","gists_url":"https://api.github.com/users/zhaoleidd/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoleidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoleidd/subscriptions","organizations_url":"https://api.github.com/users/zhaoleidd/orgs","repos_url":"https://api.github.com/users/zhaoleidd/repos","events_url":"https://api.github.com/users/zhaoleidd/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoleidd/received_events","type":"User","site_admin":false},"body":"So we can make all types of release binary with combination\r\nof following flags:\r\n seccomp\r\n selinux\r\n apparmor\r\n static\r\n\r\nAll binary files are put in release/ dir, like:\r\n [root@zlosvm1 runc]# ls -l release\r\n total 53488\r\n -rwxr-xr-x. 1 root root 9517965 Jun 14 18:11 runc\r\n -rwxr-xr-x. 1 root root 9673533 Jun 14 18:10 runc.seccomp\r\n -rwxr-xr-x. 1 root root 9705839 Jun 14 18:09 runc.seccomp.selinux\r\n -rwxr-xr-x. 1 root root 9546175 Jun 14 18:10 runc.selinux\r\n -rwxr-xr-x. 1 root root 8169190 Jun 14 18:10 runc.selinux.static\r\n -rwxr-xr-x. 1 root root 8150060 Jun 14 18:11 runc.static\r\n ...\r\n\r\nCloses #899\r\n\r\nSigned-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>","created_at":"2016-06-14T10:15:27Z","updated_at":"2016-08-30T07:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37db65c3c4ccffdbb7ae1874747a7b4c3b5b6d67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/914/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/914/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/914/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/66204cb825318f415836a65b24ea92a654090dd1","head":{"label":"zhaoleidd:add_make_release","ref":"add_make_release","sha":"66204cb825318f415836a65b24ea92a654090dd1","user":{"login":"zhaoleidd","id":11662186,"avatar_url":"https://avatars.githubusercontent.com/u/11662186?v=3","gravatar_id":"","url":"https://api.github.com/users/zhaoleidd","html_url":"https://github.com/zhaoleidd","followers_url":"https://api.github.com/users/zhaoleidd/followers","following_url":"https://api.github.com/users/zhaoleidd/following{/other_user}","gists_url":"https://api.github.com/users/zhaoleidd/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoleidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoleidd/subscriptions","organizations_url":"https://api.github.com/users/zhaoleidd/orgs","repos_url":"https://api.github.com/users/zhaoleidd/repos","events_url":"https://api.github.com/users/zhaoleidd/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoleidd/received_events","type":"User","site_admin":false},"repo":{"id":59264278,"name":"runc","full_name":"zhaoleidd/runc","owner":{"login":"zhaoleidd","id":11662186,"avatar_url":"https://avatars.githubusercontent.com/u/11662186?v=3","gravatar_id":"","url":"https://api.github.com/users/zhaoleidd","html_url":"https://github.com/zhaoleidd","followers_url":"https://api.github.com/users/zhaoleidd/followers","following_url":"https://api.github.com/users/zhaoleidd/following{/other_user}","gists_url":"https://api.github.com/users/zhaoleidd/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoleidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoleidd/subscriptions","organizations_url":"https://api.github.com/users/zhaoleidd/orgs","repos_url":"https://api.github.com/users/zhaoleidd/repos","events_url":"https://api.github.com/users/zhaoleidd/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoleidd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhaoleidd/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/zhaoleidd/runc","forks_url":"https://api.github.com/repos/zhaoleidd/runc/forks","keys_url":"https://api.github.com/repos/zhaoleidd/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhaoleidd/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhaoleidd/runc/teams","hooks_url":"https://api.github.com/repos/zhaoleidd/runc/hooks","issue_events_url":"https://api.github.com/repos/zhaoleidd/runc/issues/events{/number}","events_url":"https://api.github.com/repos/zhaoleidd/runc/events","assignees_url":"https://api.github.com/repos/zhaoleidd/runc/assignees{/user}","branches_url":"https://api.github.com/repos/zhaoleidd/runc/branches{/branch}","tags_url":"https://api.github.com/repos/zhaoleidd/runc/tags","blobs_url":"https://api.github.com/repos/zhaoleidd/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhaoleidd/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhaoleidd/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhaoleidd/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhaoleidd/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/zhaoleidd/runc/languages","stargazers_url":"https://api.github.com/repos/zhaoleidd/runc/stargazers","contributors_url":"https://api.github.com/repos/zhaoleidd/runc/contributors","subscribers_url":"https://api.github.com/repos/zhaoleidd/runc/subscribers","subscription_url":"https://api.github.com/repos/zhaoleidd/runc/subscription","commits_url":"https://api.github.com/repos/zhaoleidd/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhaoleidd/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhaoleidd/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhaoleidd/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhaoleidd/runc/contents/{+path}","compare_url":"https://api.github.com/repos/zhaoleidd/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhaoleidd/runc/merges","archive_url":"https://api.github.com/repos/zhaoleidd/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhaoleidd/runc/downloads","issues_url":"https://api.github.com/repos/zhaoleidd/runc/issues{/number}","pulls_url":"https://api.github.com/repos/zhaoleidd/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/zhaoleidd/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/zhaoleidd/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhaoleidd/runc/labels{/name}","releases_url":"https://api.github.com/repos/zhaoleidd/runc/releases{/id}","deployments_url":"https://api.github.com/repos/zhaoleidd/runc/deployments","created_at":"2016-05-20T04:13:49Z","updated_at":"2016-05-20T04:13:50Z","pushed_at":"2016-08-30T07:46:50Z","git_url":"git://github.com/zhaoleidd/runc.git","ssh_url":"git@github.com:zhaoleidd/runc.git","clone_url":"https://github.com/zhaoleidd/runc.git","svn_url":"https://github.com/zhaoleidd/runc","homepage":"https://www.opencontainers.org/","size":3421,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"189a2ab2f7acc59043e457cea25b58f631443f08","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-08-30T06:39:45Z","pushed_at":"2016-08-30T07:46:50Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":5952,"stargazers_count":3062,"watchers_count":3062,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":433,"mirror_url":null,"open_issues_count":81,"forks":433,"open_issues":81,"watchers":3062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/914"},"html":{"href":"https://github.com/opencontainers/runc/pull/914"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/914"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/914/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/914/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/914/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/66204cb825318f415836a65b24ea92a654090dd1"}}}}
{"actor":{"display_login":"cyphar"}}