{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/comments/72196884","id":72196884,"diff_hunk":"@@ -71,6 +84,13 @@ public FormValidation doCheckDiskPoolId(@QueryParameter String value) {\n             return validateRequired(value);\n         }\n \n+        public FormValidation doCheckWorkspaceTemplate(@QueryParameter String value) {","path":"src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java","position":45,"original_position":45,"commit_id":"c0c19739e117b70128d9340727038701a2ba873b","original_commit_id":"c0c19739e117b70128d9340727038701a2ba873b","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"Good practice: Restrict Stapler methods. Otherwise they become a part of the public UI","created_at":"2016-07-26T06:55:05Z","updated_at":"2016-07-26T06:55:05Z","html_url":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24#discussion_r72196884","pull_request_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/comments/72196884"},"html":{"href":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24#discussion_r72196884"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24","id":77850490,"html_url":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24","diff_url":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24.diff","patch_url":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24.patch","issue_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/24","number":24,"state":"open","locked":false,"title":"[JENKINS-35975] Allow configurable relative path","user":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"body":"Related to issue [[JENKINS-35975]](https://issues.jenkins-ci.org/browse/JENKINS-35975)\r\n\r\nSummary of this pull request:\r\n - [x] Define workspace based on a template configured for each Disk Pool entry (Jenkins global config)\r\n - [x] Custom workspace for the `exwsAllocate` step, by using an extra parameter: `path`\r\n - [x] Write tests \r\n - [x] Write documentation\r\n\r\nCC @oleg-nenashev @martinda\r\n","created_at":"2016-07-18T17:59:59Z","updated_at":"2016-07-26T06:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8038825a53ae215c27b66da62a5e90f45e86f32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/24/comments","statuses_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/statuses/c0c19739e117b70128d9340727038701a2ba873b","head":{"label":"alexsomai:custom-template","ref":"custom-template","sha":"c0c19739e117b70128d9340727038701a2ba873b","user":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"repo":{"id":59319962,"name":"external-workspace-manager-plugin","full_name":"alexsomai/external-workspace-manager-plugin","owner":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexsomai/external-workspace-manager-plugin","description":"","fork":true,"url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin","forks_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/forks","keys_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/teams","hooks_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/hooks","issue_events_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/events","assignees_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/tags","blobs_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/languages","stargazers_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/stargazers","contributors_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/contributors","subscribers_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/subscribers","subscription_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/subscription","commits_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/merges","archive_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/downloads","issues_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/labels{/name}","releases_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/alexsomai/external-workspace-manager-plugin/deployments","created_at":"2016-05-20T19:11:36Z","updated_at":"2016-06-07T17:30:42Z","pushed_at":"2016-07-26T06:27:46Z","git_url":"git://github.com/alexsomai/external-workspace-manager-plugin.git","ssh_url":"git@github.com:alexsomai/external-workspace-manager-plugin.git","clone_url":"https://github.com/alexsomai/external-workspace-manager-plugin.git","svn_url":"https://github.com/alexsomai/external-workspace-manager-plugin","homepage":"","size":798,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"29f2aecdf66da91641499eb60576bf46250d456e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":58932444,"name":"external-workspace-manager-plugin","full_name":"jenkinsci/external-workspace-manager-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/external-workspace-manager-plugin","description":"Jenkins plugin that facilitates workspace share and reuse across multiple jobs","fork":false,"url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin","forks_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/deployments","created_at":"2016-05-16T12:57:04Z","updated_at":"2016-07-23T07:43:41Z","pushed_at":"2016-07-26T06:27:46Z","git_url":"git://github.com/jenkinsci/external-workspace-manager-plugin.git","ssh_url":"git@github.com:jenkinsci/external-workspace-manager-plugin.git","clone_url":"https://github.com/jenkinsci/external-workspace-manager-plugin.git","svn_url":"https://github.com/jenkinsci/external-workspace-manager-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/External+Workspace+Manager+Plugin","size":851,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24"},"html":{"href":"https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24"},"issue":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/24"},"comments":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/external-workspace-manager-plugin/statuses/c0c19739e117b70128d9340727038701a2ba873b"}}}}
{"actor":{"display_login":"oleg-nenashev"}}