{"action":"created","issue":{"url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/161","repository_url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin","labels_url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/161/comments","events_url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/161/events","html_url":"https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/161","id":136819962,"number":161,"title":"Add support for more than one custom properties file","user":{"login":"automatictester","id":9162833,"avatar_url":"https://avatars.githubusercontent.com/u/9162833?v=3","gravatar_id":"","url":"https://api.github.com/users/automatictester","html_url":"https://github.com/automatictester","followers_url":"https://api.github.com/users/automatictester/followers","following_url":"https://api.github.com/users/automatictester/following{/other_user}","gists_url":"https://api.github.com/users/automatictester/gists{/gist_id}","starred_url":"https://api.github.com/users/automatictester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/automatictester/subscriptions","organizations_url":"https://api.github.com/users/automatictester/orgs","repos_url":"https://api.github.com/users/automatictester/repos","events_url":"https://api.github.com/users/automatictester/events{/privacy}","received_events_url":"https://api.github.com/users/automatictester/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-26T21:33:06Z","updated_at":"2016-02-26T23:25:14Z","closed_at":"2016-02-26T23:24:27Z","pull_request":{"url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/pulls/161","html_url":"https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/161","diff_url":"https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/161.diff","patch_url":"https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/161.patch"},"body":"JMeter allows more than one additional property file [(-q, --addprop)](http://jmeter.apache.org/usermanual/get-started.html#options). The way jmeter-maven-plugin is designed [at the moment](https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/search?utf8=%E2%9C%93&q=customPropertiesFile), allows support for only one additional properties file. This PR will sync behaviour of jmeter-maven-plugin with JMeter itself.\r\n\r\nPlease note:\r\n1) This is a breaking change, as now plugin will be looking for this:\r\n\r\n                            <customPropertiesFiles>\r\n                                <customerPropertiesFile>someFile</customerPropertiesFile>\r\n                                <customerPropertiesFile>someOtherFile</customerPropertiesFile>\r\n                            </customPropertiesFiles>\r\n\r\nRather than that:\r\n\r\n                            <customPropertiesFile>someFile</customPropertiesFile>\r\nI considered keeping the old functionality alongside the new one, but this would make the code a bit messy. Also, as the next version is 2.0.0, according to semantic versioning there is nothing wrong with introducing breaking changes.\r\n\r\n2) I was unable to use JAR generated with `mvn plugin:descriptor install` from master (prior to my changes). By use I mean `mvn test` in the project where I use jmeter-maven-plugin:\r\n\r\n    [ERROR] Failed to execute goal com.lazerycode.jmeter:jmeter-maven-plugin:2.0.0-SNAPSHOT:jmeter\r\n    (jmeter-tests) on project jmeter-maven-project: Unable to parse configuration of mojo\r\n    com.lazerycode.jmeter:jmeter-maven-plugin:2.0.0-SNAPSHOT:jmeter for parameter pluginArtifacts:\r\n    Cannot find 'pluginArtifacts' in class com.lazerycode.jmeter.JMeterMojo -> [Help 1]\r\n\r\nTo test my changes, I did [git revert 9781595e8efe978ad2c30a824e6bc84ccdcae592](https://github.com/automatictester/jmeter-maven-plugin/commit/9781595e8efe978ad2c30a824e6bc84ccdcae592)."},"comment":{"url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/comments/189524236","html_url":"https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/161#issuecomment-189524236","issue_url":"https://api.github.com/repos/jmeter-maven-plugin/jmeter-maven-plugin/issues/161","id":189524236,"user":{"login":"Ardesco","id":1205116,"avatar_url":"https://avatars.githubusercontent.com/u/1205116?v=3","gravatar_id":"","url":"https://api.github.com/users/Ardesco","html_url":"https://github.com/Ardesco","followers_url":"https://api.github.com/users/Ardesco/followers","following_url":"https://api.github.com/users/Ardesco/following{/other_user}","gists_url":"https://api.github.com/users/Ardesco/gists{/gist_id}","starred_url":"https://api.github.com/users/Ardesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ardesco/subscriptions","organizations_url":"https://api.github.com/users/Ardesco/orgs","repos_url":"https://api.github.com/users/Ardesco/repos","events_url":"https://api.github.com/users/Ardesco/events{/privacy}","received_events_url":"https://api.github.com/users/Ardesco/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T23:25:14Z","updated_at":"2016-02-26T23:25:14Z","body":"Merged in, thanks for the PR."}}