{"action":"created","comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/64817452","id":64817452,"diff_hunk":"@@ -519,8 +519,10 @@ Style/HashSyntax:\n     - ruby19\n     - ruby19_no_mixed_keys\n     - hash_rockets\n-# Force hashes that have a symbol value to use hash rockets\n+  # Force hashes that have a symbol value to use hash rockets\n   UseHashRocketsWithSymbolValues: false\n+  # Do not suggest { a?: 1 } over { :a? => 1 } in ruby19 style\n+  AllowHashRocketsWithSymbolValuesEndingInNonAlnum: true","path":"config/default.yml","position":8,"original_position":8,"commit_id":"9a963d8d72c0021cd41ec36240501feb20963e50","original_commit_id":"9a963d8d72c0021cd41ec36240501feb20963e50","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"body":"haha, yeah definitely, I struggled with it! What about \r\n1. `AllowNonAlnumEndingSymbolHashRockets`\r\n2. `AllowHashRocketsForPunctuationEndingSymbols`\r\n3. `EndingPunctuationAllowedForHashRockets`\r\n\r\ncontrasting with the current\r\n- `AllowHashRocketsWithSymbolValuesEndingInNonAlnum`\r\n\r\nOk, I'll rebase and make it false by default","created_at":"2016-05-26T20:44:50Z","updated_at":"2016-05-26T20:44:51Z","html_url":"https://github.com/bbatsov/rubocop/pull/3149#discussion_r64817452","pull_request_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/64817452"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3149#discussion_r64817452"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149"}}},"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149","id":70753035,"html_url":"https://github.com/bbatsov/rubocop/pull/3149","diff_url":"https://github.com/bbatsov/rubocop/pull/3149.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/3149.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149","number":3149,"state":"open","locked":false,"title":"Ignore symbols ending with ?/! in `Style/HashSyntax`","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"body":"Perhaps a slightly personal taste, but I think \r\n```\r\n{ :development? => true }\r\n```\r\n reads better/is clearer than \r\n```\r\n{ development?: true }\r\n```\r\nand therefore Rubocop shouldn't suggest changing the former to the latter. (Similarly for symbols ending in `!` e.g. `{ :raise_on_invalid! => true }`.\r\n\r\nAs an example, the original line I wrote that triggered this was:\r\n```\r\nexpect(Rails).to receive(:env).and_return(double(:production? => true)) \r\n```\r\n\r\nI'd be interested to know what others think of this one.\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it)\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] All tests are passing.\r\n* [x] The new code doesn't generate RuboCop offenses.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n\r\n[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html\r\n\r\n","created_at":"2016-05-19T19:42:11Z","updated_at":"2016-05-26T20:44:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88dbec41ea3b1141ed7ddead66e88b81b48ef345","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/9a963d8d72c0021cd41ec36240501feb20963e50","head":{"label":"owst:ignore_symbols_ending_with_exclamation_or_question_marks_for_hash_syntax","ref":"ignore_symbols_ending_with_exclamation_or_question_marks_for_hash_syntax","sha":"9a963d8d72c0021cd41ec36240501feb20963e50","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"repo":{"id":50128601,"name":"rubocop","full_name":"owst/rubocop","owner":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owst/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/owst/rubocop","forks_url":"https://api.github.com/repos/owst/rubocop/forks","keys_url":"https://api.github.com/repos/owst/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owst/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owst/rubocop/teams","hooks_url":"https://api.github.com/repos/owst/rubocop/hooks","issue_events_url":"https://api.github.com/repos/owst/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/owst/rubocop/events","assignees_url":"https://api.github.com/repos/owst/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/owst/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/owst/rubocop/tags","blobs_url":"https://api.github.com/repos/owst/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owst/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owst/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/owst/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owst/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/owst/rubocop/languages","stargazers_url":"https://api.github.com/repos/owst/rubocop/stargazers","contributors_url":"https://api.github.com/repos/owst/rubocop/contributors","subscribers_url":"https://api.github.com/repos/owst/rubocop/subscribers","subscription_url":"https://api.github.com/repos/owst/rubocop/subscription","commits_url":"https://api.github.com/repos/owst/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/owst/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/owst/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/owst/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/owst/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/owst/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owst/rubocop/merges","archive_url":"https://api.github.com/repos/owst/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owst/rubocop/downloads","issues_url":"https://api.github.com/repos/owst/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/owst/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/owst/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/owst/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owst/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/owst/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/owst/rubocop/deployments","created_at":"2016-01-21T18:41:29Z","updated_at":"2016-01-21T18:41:32Z","pushed_at":"2016-05-26T13:07:26Z","git_url":"git://github.com/owst/rubocop.git","ssh_url":"git@github.com:owst/rubocop.git","clone_url":"https://github.com/owst/rubocop.git","svn_url":"https://github.com/owst/rubocop","homepage":"","size":11941,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"584326962d721d630c15219c0f99f040d6c27b57","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2016-05-26T19:51:31Z","pushed_at":"2016-05-26T19:31:32Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":15532,"stargazers_count":6326,"watchers_count":6326,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":858,"mirror_url":null,"open_issues_count":136,"forks":858,"open_issues":136,"watchers":6326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3149"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3149"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3149/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/9a963d8d72c0021cd41ec36240501feb20963e50"}}}}
{"actor":{"display_login":"owst"}}