{"push_id":1396458212,"size":75,"distinct_size":75,"ref":"refs/heads/master","head":"ca7cbdee858e84c4a74a2d9c7be151f5cfdcfbfe","before":"6ed49341f315434ee0c2016c356aa1c3f29209c1","commits":[{"sha":"6a83ac3af62308e4c286ca169f4834b6d2c3fadd","author":{"name":"Neo","email":"e41e298d3166fc9d48c58ea64f21109ab91d948c@live.com"},"message":"update Modal.js to fix #10662\n\nSummary:\nfurther discussion: should there be a `onClose` or `onClosed` to pair with `onShow`? which would make a workaround for #10471 much easier\nCloses https://github.com/facebook/react-native/pull/10669\n\nDifferential Revision: D4133832\n\nPulled By: hramos\n\nfbshipit-source-id: 644a5bb6b9da697c81fc96ae4da196ba5b4050cb","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/6a83ac3af62308e4c286ca169f4834b6d2c3fadd"},{"sha":"f29e3bc27798b52c18c0a834667c31a432d43c4a","author":{"name":"David Aurelio","email":"ff048047600c1f3e891446665b5269773d037402@fb.com"},"message":"Fix website generation after React upgrade\n\nSummary:\ncare to merge, dear bestander?\nCloses https://github.com/facebook/react-native/pull/10750\n\nDifferential Revision: D4131594\n\nPulled By: lacker\n\nfbshipit-source-id: 39c2a31c774405529cc57ee1d0e10a9bef89f5f5","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/f29e3bc27798b52c18c0a834667c31a432d43c4a"},{"sha":"e173f14b525c41bd33b5256cc70e2e883d3d07e1","author":{"name":"Janic Duplessis","email":"f86e95ed6b436aea8f9b2714b1e8fe379ef2d649@gmail.com"},"message":"Use native animations if the animated value is native in NavigationCardStackPanResponder\n\nSummary:\nSince native and non-native animations do not work together check if the animated value is native and set useNativeDriver accordingly. So untill we move to always using the native driver this is needed. This and another fix in NativeAnimations module will allow using native animations to transitions with gestures.\n\n**Test plan**\nTested in an app that uses native driven animations with a back gesture. This also needs #10643 and #10642 for everything to work properly.\nCloses https://github.com/facebook/react-native/pull/10641\n\nDifferential Revision: D4135972\n\nPulled By: ericvicenti\n\nfbshipit-source-id: 8e65574ebb296da044f4d03bf1eedee4a37ebdac","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/e173f14b525c41bd33b5256cc70e2e883d3d07e1"},{"sha":"97d90a1d718958c5d7ce840dad5cfa2df7ab9df9","author":{"name":"kentaromiura","email":"87993b64e72871948e6985bd1c9367db8b2bc5ef@gmail.com"},"message":"Add `React` name mapping to the preset\n\nSummary:\nFixes breakage on https://circleci.com/gh/facebook/react-native/12763 after the upgrade of React\n\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nJest preset has been upgraded so that requiring `React` capitalized can be possible\n\n**Test plan (required)**\n\nCouldn't reproduce it locally, we need to see if Circle passes.\nCloses https://github.com/facebook/react-native/pull/10749\n\nDifferential Revision: D4132150\n\nPulled By: bestander\n\nfbshipit-source-id: e41fb95b6677113fc6a3bf8bbce9247f59aa81dd","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/97d90a1d718958c5d7ce840dad5cfa2df7ab9df9"},{"sha":"ac1927653463e766e270c87bb46833af67ee1fdc","author":{"name":"Janic Duplessis","email":"f86e95ed6b436aea8f9b2714b1e8fe379ef2d649@gmail.com"},"message":"Fix NavigationCardStackPanResponder to work with native animations\n\nSummary:\n`NavigationCardStackPanResponder` uses `__getValue` and the `stopAnimation` callback value which both doesn't work with native driven animation. The workaround here is to add a value listener so the JS value of the AnimatedValue gets updated too so `__getValue` has a relatively up to date value. This value should be good unless JS lags behind native a lot but that should not happen during a navigation gesture. Also added a comment that explains the hack.\n\n**Test plan**\nTested in an app that uses native driven animations with a back gesture. This also needs #10643 and #10641 for everything to work properly.\nCloses https://github.com/facebook/react-native/pull/10642\n\nDifferential Revision: D4135496\n\nPulled By: ericvicenti\n\nfbshipit-source-id: 395aff78b16a37ad9407207a05504fdd6311f733","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/ac1927653463e766e270c87bb46833af67ee1fdc"},{"sha":"1ceb2f7519862c5e37a6b0e80aa4fec95cd28e52","author":{"name":"Héctor Ramos","email":"4c668669ecbe6bbe31db28cbf68f243002f1c12d@gmail.com"},"message":"Swap locations for Prev/Next links.\n\nSummary:\nThis reverts a change in #10660 that swapped the locations of the prev/next links across the entire site. It made sense in the blog, but not so much in the docs.\nCloses https://github.com/facebook/react-native/pull/10753\n\nDifferential Revision: D4133501\n\nPulled By: lacker\n\nfbshipit-source-id: 92ee35b1bd5575401e548f8290db3fb7cf0f56a1","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/1ceb2f7519862c5e37a6b0e80aa4fec95cd28e52"},{"sha":"1605276801aa8766df6a30b9088277f162eb7d80","author":{"name":"Martin Konicek","email":"f9c5ef9b5325ce81d68a8d733940290a1a837e54@fb.com"},"message":"Remove open source deprecation warning from MapView\n\nSummary: The warning is only relevant to open source RN but shown to employees too.\n\nReviewed By: fkgozali\n\nDifferential Revision: D4137216\n\nfbshipit-source-id: 21d5c3051c7964231eeb3f555681a83eacb4c972","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/1605276801aa8766df6a30b9088277f162eb7d80"},{"sha":"a609d1c2b78fb2493935b065afa52413313ea199","author":{"name":"Ben Griffith","email":"e66af12bfef1c5ab21c4c0cf3a93c52ab1b87f69@gmail.com"},"message":"Add currentHeight constant to status bar docs\n\nSummary:\nThis PR is to fix #10561 by adding `currentHeight` to a list of constants for the `StatusBar` component. It also makes it clear that this constant is Android only by also adding a further note to the example use.\n\nCloses #10561\n\n![screen shot 2016-11-01 at 12 37 06](https://cloud.githubusercontent.com/assets/2854338/19889978/f453d43a-a02f-11e6-859e-5a9ebeba9d44.png)\nCloses https://github.com/facebook/react-native/pull/10675\n\nDifferential Revision: D4137353\n\nfbshipit-source-id: 717494fe78f8eb55c55447d6567ec8bcd0be86d3","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/a609d1c2b78fb2493935b065afa52413313ea199"},{"sha":"237ab33ff4981105609f0733e265695683578f3f","author":{"name":"Andres Suarez","email":"b0ef26ce5e4a521b6c8a5ffbe6367423bd3ae155@fb.com"},"message":"Upgrade to lodash@^4.16.6\n\nSummary:\nThis diff updates `lodash` so that it's optimally deduped, resulting in:\n\n* reducing the packager's load time by ~300-400ms.\n* reduces the size of `node_modules` from ~225MB to ~148MB.\n* reduces the time to do a clean `yarn install` from 35s to 18s.\n\nLots of dependencies (including every `babel-*`) use `lodash@4`, by having `lodash@3` as a root dependency, each package had to have it's own copy of `lodash@4`. Now, there's only one.\n\nThe uses of `lodash` in RN are restricted to the CLI/packager, and the uses are pretty basic. The breaking APIs don't really seem to affect us https://github.com/lodash/lodash/wiki/Changelog#v400.\n\nReviewed By: bestander\n\nDifferential Revision: D4124836\n\nfbshipit-source-id: 0849c385fcafe10b463e684fea47be6775982386","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/237ab33ff4981105609f0733e265695683578f3f"},{"sha":"6c04b3597d2d025c739333b332c07990538a0ba8","author":{"name":"Chuck Dishmon","email":"2592ecaac0fb00e904124e2b8a55119c57050a8b@users.noreply.github.com"},"message":"Update HandlingTextInput.md\n\nSummary:\nThanks for submitting a pull request! Please provide enough information so that others can review your pull request:\n\n> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**\n\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nPrefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\n\n**Test plan (required)**\n\nDemonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.\n\nMake sure tests pass on both Travis and Circle CI.\n\n**Code formatting**\n\nLook around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).\n\nFor more info, see\nCloses https://github.com/facebook/react-native/pull/10763\n\nDifferential Revision: D4139069\n\nPulled By: JoelMarcey\n\nfbshipit-source-id: ecc36f4e0ff4a44c95d63a256e0cdf67a4d386b3","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/6c04b3597d2d025c739333b332c07990538a0ba8"},{"sha":"fb7fe2d4e8783232c73fc48b29ad63400a8b3420","author":{"name":"Kevin Gozali","email":"519c383035abcdbf43f06653caada42a5db422d9@fb.com"},"message":"modernize AppContainer and add rootTag in the child context\n\nSummary:\nThis does 2 things:\n- modernize the component to use ES6 + flow\n- assign `rootTag` to the child context\n\nEach view in RN has its own `reactTag`. The reactTag for a root view is called `rootTag`. When there are multiple react root views active within the app (e.g. in a hybrid environment), rootTag is the only reliable \"label\" to differentiate them. This is especially useful when we want to limit an event/activity on a particular root view, instead of affecting all active root views. This allows components to do:\n\n```\nclass Foo extends React.Component {\n  static contextTypes = {\n    rootTag: React.PropTypes.number,\n  };\n\n  componentDidMount() {\n    // Get the root tag of this component, which is static for all components under the same root view\n    console.log(this.context.rootTag);\n  }\n}\n```\n\nIn a pure JS RN app environment, there will always be exactly 1 root view, so `rootTag` may usually be ignored.\n\nReviewed By: yungsters\n\nDifferential Revision: D4130376\n\nfbshipit-source-id: 559b67615f487bad754b5832ad4a02bcef05be2a","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/fb7fe2d4e8783232c73fc48b29ad63400a8b3420"},{"sha":"72369ee4d2203a888605e3382aeae1be7fff1c62","author":{"name":"Héctor Ramos","email":"4c668669ecbe6bbe31db28cbf68f243002f1c12d@gmail.com"},"message":"Consolidate Running on Device (Android|iOS) Guides into one\n\nSummary:\nThe RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.\nCloses https://github.com/facebook/react-native/pull/10726\n\nDifferential Revision: D4139089\n\nPulled By: JoelMarcey\n\nfbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/72369ee4d2203a888605e3382aeae1be7fff1c62"},{"sha":"d2bdc24ecd49751b18517b09ab25d16cd66e2d0c","author":{"name":"Andres Suarez","email":"b0ef26ce5e4a521b6c8a5ffbe6367423bd3ae155@fb.com"},"message":"Move graphql from deps to devDeps\n\nReviewed By: cpojer\n\nDifferential Revision: D4139626\n\nfbshipit-source-id: 52e5c19cf3b472c0b62a0ae18fb7bb21f0d88841","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/d2bdc24ecd49751b18517b09ab25d16cd66e2d0c"},{"sha":"ba8bbcbe2f319406d0d606162d78d9533b1349bf","author":{"name":"Andres Suarez","email":"b0ef26ce5e4a521b6c8a5ffbe6367423bd3ae155@fb.com"},"message":"Remove prepack bundle functionality\n\nReviewed By: davidaurelio\n\nDifferential Revision: D4138495\n\nfbshipit-source-id: 52793fc1a8ef8b2fc461156607c360f34c4cb362","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/ba8bbcbe2f319406d0d606162d78d9533b1349bf"},{"sha":"96a581f6c2fe7a473779e88cf6e171ee4b75c639","author":{"name":"Andy Street","email":"6e0a5d741ac959bfc549c8536c97ed54924c3d29@fb.com"},"message":"Assert that node can have measure function <==> node is a leaf node\n\nSummary: Instead of silently ignorning non-leaf nodes with measure functions, we should assert that we don't create those kinds of trees.\n\nReviewed By: emilsjolander\n\nDifferential Revision: D4130770\n\nfbshipit-source-id: a3ef10a2e63bbc12b5aa07977e4b84c8d59e3ffe","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/96a581f6c2fe7a473779e88cf6e171ee4b75c639"},{"sha":"a320b0ab19c9c1e3d8bf60d31bfdc68599f62bab","author":{"name":"Andy Street","email":"6e0a5d741ac959bfc549c8536c97ed54924c3d29@fb.com"},"message":"Lazy create children list when first child is added\n\nSummary: We don't need to allocate a list for every node since leaf nodes don't have children.\n\nReviewed By: emilsjolander\n\nDifferential Revision: D4130818\n\nfbshipit-source-id: 80d3e98fce9d2daa0676fd1cbed0e81edcf7adb3","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/a320b0ab19c9c1e3d8bf60d31bfdc68599f62bab"},{"sha":"0089cd763002849cba7b057c9cea2e59f050636c","author":{"name":"Andy Street","email":"6e0a5d741ac959bfc549c8536c97ed54924c3d29@fb.com"},"message":"Make CSSNode#measure final, cache more correct methodid\n\nSummary:\nIn the JNI portion of CSSLayout, there's a subtle bug where we were caching the jmethodid of the 'measure' of the first object that had measure called on it. However, if that class had overriden measure, then the jmethodid would be specific to that subclass's implementation and would not work for other classes. Conversely, if a regular CSSNode had been called first, then the super method would be called on the subclass instead of the proper overriden method.\n\nSince there's not really a reason to overriden measure anyway (since you can just provide a different measure function), it's safest to just mark it final and explicitly cache the appropriate methodid\n\nReviewed By: emilsjolander\n\nDifferential Revision: D4132428\n\nfbshipit-source-id: 6fb51597d80f1c03681e6611153b52b73b392245","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/0089cd763002849cba7b057c9cea2e59f050636c"},{"sha":"a4bb4d25f5ed1414e40de92df7d7c20e148804e6","author":{"name":"Geordie","email":"96a5744bb30fc6fe4f38dca50248d47bd12d527f@gmail.com"},"message":"Only retain the previousViews that need to be validated\n\nSummary:\nFixes #4740, where views would unnecessarily be retained after performing `navigator.pop()` - this was particularly problematic for big lists and memory-intensive custom views.\n\nThis fix causes no functional change: `_previousViews` are only used in the loop starting at line 564 to ensure that the JavaScript and Native navigation stacks are equivalent at all times. As we do in this fix, that loop limits itself to only the views expected to be on the React navigation stack. So overall this change makes the code logically 'more correct'.\n\nTested by checking that `_previousViews.count` is always equivalent to `previousReactCount` in the loop (which means we could remove the complex `MIN(... MIN(previousReactCount, _previousViews.count)` in the loop too, but I wanted to keep the diff as small as possible for now).\nCloses https://github.com/facebook/react-native/pull/10789\n\nDifferential Revision: D4140502\n\nPulled By: ericvicenti\n\nfbshipit-source-id: 4491ad3c16642914c3081295cf95c4cf36be9f94","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/a4bb4d25f5ed1414e40de92df7d7c20e148804e6"},{"sha":"be4afdde37ab6ff6ebe573821745887fd3edfb05","author":{"name":"Antoine Rousseau","email":"2774d14550c0a47bad9bc992ee5d14c3f60603ae@rousseau.im"},"message":"Android WebSocket: include cookies in request\n\nSummary:\nThis PR updates #6851 from srikanthkh, fixing coding conventions and javadoc, and adding a test plan.\n\nAdded testing functions into the WebSocketExample page of the UIExplorer, including a tiny http server to set a cookie on demand. Instructions included in the UIExplorer app.\nCloses https://github.com/facebook/react-native/pull/9114\n\nDifferential Revision: D4140534\n\nPulled By: lacker\n\nfbshipit-source-id: e020ad0c6d1d3ea09c0c3564c1795b4e1bc4517d","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/be4afdde37ab6ff6ebe573821745887fd3edfb05"},{"sha":"7839a9fd60d9ae728502de3ef4498089e0aad350","author":{"name":"安秋亮","email":"b129362d10eac4e20a11279d7aed1530c28bc24a@alibaba-inc.com"},"message":"Add inline definition for Microsoft Visual Studio\n\nSummary:\nThe inline keyword is available only in C++. The __inline and __forceinline keywords are available in both C and C++. For compatibility with previous versions, _inline is a synonym for __inline.\n\nhttps://msdn.microsoft.com/en-us/library/z8y1yy88(v=vs.120).aspx\nCloses https://github.com/facebook/css-layout/pull/239\n\nReviewed By: astreet\n\nDifferential Revision: D4138941\n\nPulled By: emilsjolander\n\nfbshipit-source-id: cb59dc91ef285e5378036c4912217fd4ec8d9f79","distinct":true,"url":"https://api.github.com/repos/rseemann/react-native/commits/7839a9fd60d9ae728502de3ef4498089e0aad350"}]}
{"actor":{"display_login":"rseemann"}}