{"action":"created","issue":{"url":"https://api.github.com/repos/inveniosoftware/domapping/issues/9","repository_url":"https://api.github.com/repos/inveniosoftware/domapping","labels_url":"https://api.github.com/repos/inveniosoftware/domapping/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/inveniosoftware/domapping/issues/9/comments","events_url":"https://api.github.com/repos/inveniosoftware/domapping/issues/9/events","html_url":"https://github.com/inveniosoftware/domapping/issues/9","id":134806176,"number":9,"title":"Incorrect property name ('settings' instead of 'mappings')","user":{"login":"switowski","id":4835412,"avatar_url":"https://avatars.githubusercontent.com/u/4835412?v=3","gravatar_id":"","url":"https://api.github.com/users/switowski","html_url":"https://github.com/switowski","followers_url":"https://api.github.com/users/switowski/followers","following_url":"https://api.github.com/users/switowski/following{/other_user}","gists_url":"https://api.github.com/users/switowski/gists{/gist_id}","starred_url":"https://api.github.com/users/switowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/switowski/subscriptions","organizations_url":"https://api.github.com/users/switowski/orgs","repos_url":"https://api.github.com/users/switowski/repos","events_url":"https://api.github.com/users/switowski/events{/privacy}","received_events_url":"https://api.github.com/users/switowski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JavierDelgadoFernandez","id":6481083,"avatar_url":"https://avatars.githubusercontent.com/u/6481083?v=3","gravatar_id":"","url":"https://api.github.com/users/JavierDelgadoFernandez","html_url":"https://github.com/JavierDelgadoFernandez","followers_url":"https://api.github.com/users/JavierDelgadoFernandez/followers","following_url":"https://api.github.com/users/JavierDelgadoFernandez/following{/other_user}","gists_url":"https://api.github.com/users/JavierDelgadoFernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierDelgadoFernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierDelgadoFernandez/subscriptions","organizations_url":"https://api.github.com/users/JavierDelgadoFernandez/orgs","repos_url":"https://api.github.com/users/JavierDelgadoFernandez/repos","events_url":"https://api.github.com/users/JavierDelgadoFernandez/events{/privacy}","received_events_url":"https://api.github.com/users/JavierDelgadoFernandez/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inveniosoftware/domapping/milestones/2","html_url":"https://github.com/inveniosoftware/domapping/milestones/Sprint-Record-Data-Model","labels_url":"https://api.github.com/repos/inveniosoftware/domapping/milestones/2/labels","id":1577327,"number":2,"title":"Sprint-Record-Data-Model","description":null,"creator":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2016-02-11T10:48:24Z","updated_at":"2016-02-19T08:40:54Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-02-19T08:40:54Z","updated_at":"2016-02-19T08:51:55Z","closed_at":null,"body":"As reported by @JavierDelgadoFernandez, domapping is putting ElasticSearch mappings under `settings` key in the generated file, while they should go inside `mappings` key."},"comment":{"url":"https://api.github.com/repos/inveniosoftware/domapping/issues/comments/186120707","html_url":"https://github.com/inveniosoftware/domapping/issues/9#issuecomment-186120707","issue_url":"https://api.github.com/repos/inveniosoftware/domapping/issues/9","id":186120707,"user":{"login":"nharraud","id":5708796,"avatar_url":"https://avatars.githubusercontent.com/u/5708796?v=3","gravatar_id":"","url":"https://api.github.com/users/nharraud","html_url":"https://github.com/nharraud","followers_url":"https://api.github.com/users/nharraud/followers","following_url":"https://api.github.com/users/nharraud/following{/other_user}","gists_url":"https://api.github.com/users/nharraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nharraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nharraud/subscriptions","organizations_url":"https://api.github.com/users/nharraud/orgs","repos_url":"https://api.github.com/users/nharraud/repos","events_url":"https://api.github.com/users/nharraud/events{/privacy}","received_events_url":"https://api.github.com/users/nharraud/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T08:51:55Z","updated_at":"2016-02-19T08:51:55Z","body":"Is there an explicit \"settings\" key generated? Normally DoMapping generates the content of the type mapping corresponding to the given JSON Schema. The idea is that it can also be used manually like this:\r\n```json\r\nPUT myindex/_mapping/mydoctype \r\n{\r\n  \"properties\": {\r\n    \"name\": {\r\n      \"type\": \"string\"\r\n    }\r\n  }\r\n}\r\n```\r\n\r\nIf DoMapping was adding enclosing \"mappings\" or \"settings\" it could not be used like that anymore.\r\nThe recommended solution is to use a jinja template including all the type mappings into one global index \"mappings\" file. This is more extensible as you might want to add later other doctypes to the mappings."}}