{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/comments/51364989","id":51364989,"diff_hunk":"@@ -1,13 +1,10 @@\n BEGIN:VCALENDAR\n-ATTACH;FMTTYPE=text/plain;ENCODING=BASE64;VALUE=BINARY:TG9yZW","path":"test/parser/base64.ics","position":2,"original_position":2,"commit_id":"4ea864b1d153fd941ffcd2396e710a0f1f5e9770","original_commit_id":"4ea864b1d153fd941ffcd2396e710a0f1f5e9770","user":{"login":"kewisch","id":607198,"avatar_url":"https://avatars.githubusercontent.com/u/607198?v=3","gravatar_id":"","url":"https://api.github.com/users/kewisch","html_url":"https://github.com/kewisch","followers_url":"https://api.github.com/users/kewisch/followers","following_url":"https://api.github.com/users/kewisch/following{/other_user}","gists_url":"https://api.github.com/users/kewisch/gists{/gist_id}","starred_url":"https://api.github.com/users/kewisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kewisch/subscriptions","organizations_url":"https://api.github.com/users/kewisch/orgs","repos_url":"https://api.github.com/users/kewisch/repos","events_url":"https://api.github.com/users/kewisch/events{/privacy}","received_events_url":"https://api.github.com/users/kewisch/received_events","type":"User","site_admin":false},"body":"Instead of changing the attachment value type to uri, I'd appreciate if you could keep it and then just add the parameter. Also, maybe you can clear out the real world data of that ics sample, both the real representation and the base64 encoded one, e.g.\r\n\r\n```\r\nATTACH;FMTTYPE=text/plain;ENCODING=BASE64;VALUE=BINARY;X-BASE\r\n 64-PARAM=UGFyYW1ldGVyCg==:WW91IHJlYWxseSBzcGVudCB0aGUgdGltZS\r\n B0byBiYXNlNjQgZGVjb2RlIHRoaXM/Cg==\r\n```","created_at":"2016-01-31T18:35:31Z","updated_at":"2016-01-31T18:35:31Z","html_url":"https://github.com/mozilla-comm/ical.js/pull/202#discussion_r51364989","pull_request_url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/comments/51364989"},"html":{"href":"https://github.com/mozilla-comm/ical.js/pull/202#discussion_r51364989"},"pull_request":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202","id":57753132,"html_url":"https://github.com/mozilla-comm/ical.js/pull/202","diff_url":"https://github.com/mozilla-comm/ical.js/pull/202.diff","patch_url":"https://github.com/mozilla-comm/ical.js/pull/202.patch","issue_url":"https://api.github.com/repos/mozilla-comm/ical.js/issues/202","number":202,"state":"open","locked":false,"title":"Fix #201, Property parameters are misparsed when containing a second = sign","user":{"login":"zoehneto","id":8282547,"avatar_url":"https://avatars.githubusercontent.com/u/8282547?v=3","gravatar_id":"","url":"https://api.github.com/users/zoehneto","html_url":"https://github.com/zoehneto","followers_url":"https://api.github.com/users/zoehneto/followers","following_url":"https://api.github.com/users/zoehneto/following{/other_user}","gists_url":"https://api.github.com/users/zoehneto/gists{/gist_id}","starred_url":"https://api.github.com/users/zoehneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoehneto/subscriptions","organizations_url":"https://api.github.com/users/zoehneto/orgs","repos_url":"https://api.github.com/users/zoehneto/repos","events_url":"https://api.github.com/users/zoehneto/events{/privacy}","received_events_url":"https://api.github.com/users/zoehneto/received_events","type":"User","site_admin":false},"body":"Fixes #201. Also modifies the base64 test to prevent this bug in the future. ","created_at":"2016-01-30T22:41:47Z","updated_at":"2016-01-31T18:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab5b44740c979e508d79b6e61ac2492c6094b308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202/commits","review_comments_url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202/comments","review_comment_url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-comm/ical.js/issues/202/comments","statuses_url":"https://api.github.com/repos/mozilla-comm/ical.js/statuses/4ea864b1d153fd941ffcd2396e710a0f1f5e9770","head":{"label":"zoehneto:base64-property-parameter","ref":"base64-property-parameter","sha":"4ea864b1d153fd941ffcd2396e710a0f1f5e9770","user":{"login":"zoehneto","id":8282547,"avatar_url":"https://avatars.githubusercontent.com/u/8282547?v=3","gravatar_id":"","url":"https://api.github.com/users/zoehneto","html_url":"https://github.com/zoehneto","followers_url":"https://api.github.com/users/zoehneto/followers","following_url":"https://api.github.com/users/zoehneto/following{/other_user}","gists_url":"https://api.github.com/users/zoehneto/gists{/gist_id}","starred_url":"https://api.github.com/users/zoehneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoehneto/subscriptions","organizations_url":"https://api.github.com/users/zoehneto/orgs","repos_url":"https://api.github.com/users/zoehneto/repos","events_url":"https://api.github.com/users/zoehneto/events{/privacy}","received_events_url":"https://api.github.com/users/zoehneto/received_events","type":"User","site_admin":false},"repo":{"id":50747736,"name":"ical.js","full_name":"zoehneto/ical.js","owner":{"login":"zoehneto","id":8282547,"avatar_url":"https://avatars.githubusercontent.com/u/8282547?v=3","gravatar_id":"","url":"https://api.github.com/users/zoehneto","html_url":"https://github.com/zoehneto","followers_url":"https://api.github.com/users/zoehneto/followers","following_url":"https://api.github.com/users/zoehneto/following{/other_user}","gists_url":"https://api.github.com/users/zoehneto/gists{/gist_id}","starred_url":"https://api.github.com/users/zoehneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoehneto/subscriptions","organizations_url":"https://api.github.com/users/zoehneto/orgs","repos_url":"https://api.github.com/users/zoehneto/repos","events_url":"https://api.github.com/users/zoehneto/events{/privacy}","received_events_url":"https://api.github.com/users/zoehneto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zoehneto/ical.js","description":"Javascript parser for ics (rfc5545) and vcard (rfc6350) data","fork":true,"url":"https://api.github.com/repos/zoehneto/ical.js","forks_url":"https://api.github.com/repos/zoehneto/ical.js/forks","keys_url":"https://api.github.com/repos/zoehneto/ical.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoehneto/ical.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoehneto/ical.js/teams","hooks_url":"https://api.github.com/repos/zoehneto/ical.js/hooks","issue_events_url":"https://api.github.com/repos/zoehneto/ical.js/issues/events{/number}","events_url":"https://api.github.com/repos/zoehneto/ical.js/events","assignees_url":"https://api.github.com/repos/zoehneto/ical.js/assignees{/user}","branches_url":"https://api.github.com/repos/zoehneto/ical.js/branches{/branch}","tags_url":"https://api.github.com/repos/zoehneto/ical.js/tags","blobs_url":"https://api.github.com/repos/zoehneto/ical.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoehneto/ical.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoehneto/ical.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoehneto/ical.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoehneto/ical.js/statuses/{sha}","languages_url":"https://api.github.com/repos/zoehneto/ical.js/languages","stargazers_url":"https://api.github.com/repos/zoehneto/ical.js/stargazers","contributors_url":"https://api.github.com/repos/zoehneto/ical.js/contributors","subscribers_url":"https://api.github.com/repos/zoehneto/ical.js/subscribers","subscription_url":"https://api.github.com/repos/zoehneto/ical.js/subscription","commits_url":"https://api.github.com/repos/zoehneto/ical.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoehneto/ical.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoehneto/ical.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoehneto/ical.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoehneto/ical.js/contents/{+path}","compare_url":"https://api.github.com/repos/zoehneto/ical.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoehneto/ical.js/merges","archive_url":"https://api.github.com/repos/zoehneto/ical.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoehneto/ical.js/downloads","issues_url":"https://api.github.com/repos/zoehneto/ical.js/issues{/number}","pulls_url":"https://api.github.com/repos/zoehneto/ical.js/pulls{/number}","milestones_url":"https://api.github.com/repos/zoehneto/ical.js/milestones{/number}","notifications_url":"https://api.github.com/repos/zoehneto/ical.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoehneto/ical.js/labels{/name}","releases_url":"https://api.github.com/repos/zoehneto/ical.js/releases{/id}","deployments_url":"https://api.github.com/repos/zoehneto/ical.js/deployments","created_at":"2016-01-30T22:21:41Z","updated_at":"2016-01-30T22:21:42Z","pushed_at":"2016-01-30T22:36:41Z","git_url":"git://github.com/zoehneto/ical.js.git","ssh_url":"git@github.com:zoehneto/ical.js.git","clone_url":"https://github.com/zoehneto/ical.js.git","svn_url":"https://github.com/zoehneto/ical.js","homepage":"http://mozilla-comm.github.com/ical.js/","size":3960,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-comm:master","ref":"master","sha":"bf71a667edb09cbb57393221b49d51daeb7f0bb6","user":{"login":"mozilla-comm","id":3663132,"avatar_url":"https://avatars.githubusercontent.com/u/3663132?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-comm","html_url":"https://github.com/mozilla-comm","followers_url":"https://api.github.com/users/mozilla-comm/followers","following_url":"https://api.github.com/users/mozilla-comm/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-comm/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-comm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-comm/subscriptions","organizations_url":"https://api.github.com/users/mozilla-comm/orgs","repos_url":"https://api.github.com/users/mozilla-comm/repos","events_url":"https://api.github.com/users/mozilla-comm/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-comm/received_events","type":"Organization","site_admin":false},"repo":{"id":5025286,"name":"ical.js","full_name":"mozilla-comm/ical.js","owner":{"login":"mozilla-comm","id":3663132,"avatar_url":"https://avatars.githubusercontent.com/u/3663132?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-comm","html_url":"https://github.com/mozilla-comm","followers_url":"https://api.github.com/users/mozilla-comm/followers","following_url":"https://api.github.com/users/mozilla-comm/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-comm/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-comm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-comm/subscriptions","organizations_url":"https://api.github.com/users/mozilla-comm/orgs","repos_url":"https://api.github.com/users/mozilla-comm/repos","events_url":"https://api.github.com/users/mozilla-comm/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-comm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-comm/ical.js","description":"Javascript parser for ics (rfc5545) and vcard (rfc6350) data","fork":false,"url":"https://api.github.com/repos/mozilla-comm/ical.js","forks_url":"https://api.github.com/repos/mozilla-comm/ical.js/forks","keys_url":"https://api.github.com/repos/mozilla-comm/ical.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-comm/ical.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-comm/ical.js/teams","hooks_url":"https://api.github.com/repos/mozilla-comm/ical.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla-comm/ical.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-comm/ical.js/events","assignees_url":"https://api.github.com/repos/mozilla-comm/ical.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-comm/ical.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-comm/ical.js/tags","blobs_url":"https://api.github.com/repos/mozilla-comm/ical.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-comm/ical.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-comm/ical.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-comm/ical.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-comm/ical.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-comm/ical.js/languages","stargazers_url":"https://api.github.com/repos/mozilla-comm/ical.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla-comm/ical.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla-comm/ical.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla-comm/ical.js/subscription","commits_url":"https://api.github.com/repos/mozilla-comm/ical.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-comm/ical.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-comm/ical.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-comm/ical.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-comm/ical.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-comm/ical.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-comm/ical.js/merges","archive_url":"https://api.github.com/repos/mozilla-comm/ical.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-comm/ical.js/downloads","issues_url":"https://api.github.com/repos/mozilla-comm/ical.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-comm/ical.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-comm/ical.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-comm/ical.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-comm/ical.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-comm/ical.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-comm/ical.js/deployments","created_at":"2012-07-13T21:30:56Z","updated_at":"2016-01-31T02:48:39Z","pushed_at":"2016-01-31T18:26:47Z","git_url":"git://github.com/mozilla-comm/ical.js.git","ssh_url":"git@github.com:mozilla-comm/ical.js.git","clone_url":"https://github.com/mozilla-comm/ical.js.git","svn_url":"https://github.com/mozilla-comm/ical.js","homepage":"http://mozilla-comm.github.com/ical.js/","size":4264,"stargazers_count":150,"watchers_count":150,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":31,"forks":44,"open_issues":31,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202"},"html":{"href":"https://github.com/mozilla-comm/ical.js/pull/202"},"issue":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/issues/202"},"comments":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-comm/ical.js/statuses/4ea864b1d153fd941ffcd2396e710a0f1f5e9770"}}}}