{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/client/pulls/comments/79359602","id":79359602,"diff_hunk":"@@ -68,7 +68,9 @@ function Streamer($rootScope, annotationMapper, annotationUI, features, groups,\n     case 'delete':\n       annotations.forEach(function (ann) {\n         delete pendingUpdates[ann.id];","path":"h/static/scripts/streamer.js","position":3,"original_position":3,"commit_id":"16ab87b8e8f0985853306ee08919f6920bd7a2eb","original_commit_id":"16ab87b8e8f0985853306ee08919f6920bd7a2eb","user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"body":"Shouldn't the check on the line below apply to this action, too?","created_at":"2016-09-19T10:00:41Z","updated_at":"2016-09-19T10:00:41Z","html_url":"https://github.com/hypothesis/client/pull/114#discussion_r79359602","pull_request_url":"https://api.github.com/repos/hypothesis/client/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/client/pulls/comments/79359602"},"html":{"href":"https://github.com/hypothesis/client/pull/114#discussion_r79359602"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/client/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/hypothesis/client/pulls/114","id":85581208,"html_url":"https://github.com/hypothesis/client/pull/114","diff_url":"https://github.com/hypothesis/client/pull/114.diff","patch_url":"https://github.com/hypothesis/client/pull/114.patch","issue_url":"https://api.github.com/repos/hypothesis/client/issues/114","number":114,"state":"open","locked":false,"title":"Count deletions as pending updates","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"body":"_**This depends on #112**_\r\n\r\nWhen calculating the count of pending updates that is used to determine\r\nwhether to show the 'Apply Updates' icon or not, count deletions.\r\n \r\nIn addition to changing the count calculation itself, this also requires\r\nthat pending deletions are discarded for annotations that are not\r\ncurrently loaded. Such notifications may be received because the\r\ndeletion may have happened in an un-focused group. Unlike create/update\r\nnotifications, no group information is included in the notification\r\nitself so we look up the ID in the local store.\r\n","created_at":"2016-09-16T14:17:40Z","updated_at":"2016-09-19T10:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2478129c225bc3b5490cec332567759eb3d2fc45","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/client/pulls/114/commits","review_comments_url":"https://api.github.com/repos/hypothesis/client/pulls/114/comments","review_comment_url":"https://api.github.com/repos/hypothesis/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hypothesis/client/issues/114/comments","statuses_url":"https://api.github.com/repos/hypothesis/client/statuses/16ab87b8e8f0985853306ee08919f6920bd7a2eb","head":{"label":"hypothesis:count-deletions-as-pending-updates","ref":"count-deletions-as-pending-updates","sha":"16ab87b8e8f0985853306ee08919f6920bd7a2eb","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":62234930,"name":"client","full_name":"hypothesis/client","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/client","description":"The Hypothesis web-based annotation client.","fork":false,"url":"https://api.github.com/repos/hypothesis/client","forks_url":"https://api.github.com/repos/hypothesis/client/forks","keys_url":"https://api.github.com/repos/hypothesis/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/client/teams","hooks_url":"https://api.github.com/repos/hypothesis/client/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/client/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/client/events","assignees_url":"https://api.github.com/repos/hypothesis/client/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/client/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/client/tags","blobs_url":"https://api.github.com/repos/hypothesis/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/client/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/client/languages","stargazers_url":"https://api.github.com/repos/hypothesis/client/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/client/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/client/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/client/subscription","commits_url":"https://api.github.com/repos/hypothesis/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/client/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/client/merges","archive_url":"https://api.github.com/repos/hypothesis/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/client/downloads","issues_url":"https://api.github.com/repos/hypothesis/client/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/client/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/client/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/client/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/client/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/client/deployments","created_at":"2016-06-29T15:02:29Z","updated_at":"2016-09-12T15:49:01Z","pushed_at":"2016-09-19T09:49:21Z","git_url":"git://github.com/hypothesis/client.git","ssh_url":"git@github.com:hypothesis/client.git","clone_url":"https://github.com/hypothesis/client.git","svn_url":"https://github.com/hypothesis/client","homepage":null,"size":13760,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":24,"forks":8,"open_issues":24,"watchers":16,"default_branch":"master"}},"base":{"label":"hypothesis:master","ref":"master","sha":"0be2369a52f5b704ea6d50799e2ab947207fe5ea","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":62234930,"name":"client","full_name":"hypothesis/client","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/client","description":"The Hypothesis web-based annotation client.","fork":false,"url":"https://api.github.com/repos/hypothesis/client","forks_url":"https://api.github.com/repos/hypothesis/client/forks","keys_url":"https://api.github.com/repos/hypothesis/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/client/teams","hooks_url":"https://api.github.com/repos/hypothesis/client/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/client/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/client/events","assignees_url":"https://api.github.com/repos/hypothesis/client/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/client/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/client/tags","blobs_url":"https://api.github.com/repos/hypothesis/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/client/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/client/languages","stargazers_url":"https://api.github.com/repos/hypothesis/client/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/client/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/client/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/client/subscription","commits_url":"https://api.github.com/repos/hypothesis/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/client/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/client/merges","archive_url":"https://api.github.com/repos/hypothesis/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/client/downloads","issues_url":"https://api.github.com/repos/hypothesis/client/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/client/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/client/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/client/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/client/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/client/deployments","created_at":"2016-06-29T15:02:29Z","updated_at":"2016-09-12T15:49:01Z","pushed_at":"2016-09-19T09:49:21Z","git_url":"git://github.com/hypothesis/client.git","ssh_url":"git@github.com:hypothesis/client.git","clone_url":"https://github.com/hypothesis/client.git","svn_url":"https://github.com/hypothesis/client","homepage":null,"size":13760,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":24,"forks":8,"open_issues":24,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/client/pulls/114"},"html":{"href":"https://github.com/hypothesis/client/pull/114"},"issue":{"href":"https://api.github.com/repos/hypothesis/client/issues/114"},"comments":{"href":"https://api.github.com/repos/hypothesis/client/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/client/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/client/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/client/statuses/16ab87b8e8f0985853306ee08919f6920bd7a2eb"}}}}
{"actor":{"display_login":"nickstenning"}}