{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/512","repository_url":"https://api.github.com/repos/kubernetes/minikube","labels_url":"https://api.github.com/repos/kubernetes/minikube/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/512/comments","events_url":"https://api.github.com/repos/kubernetes/minikube/issues/512/events","html_url":"https://github.com/kubernetes/minikube/issues/512","id":172764427,"number":512,"title":"Make localkube flag passing more robust","user":{"login":"dlorenc","id":1714486,"avatar_url":"https://avatars.githubusercontent.com/u/1714486?v=3","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/minikube/labels/kind/feature","name":"kind/feature","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"dlorenc","id":1714486,"avatar_url":"https://avatars.githubusercontent.com/u/1714486?v=3","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlorenc","id":1714486,"avatar_url":"https://avatars.githubusercontent.com/u/1714486?v=3","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-23T17:54:52Z","updated_at":"2016-10-26T21:59:38Z","closed_at":"2016-10-26T21:59:38Z","body":"Right now minikube passes a set of flags to localkube via ssh at startup time. This works, but is problematic as we try to let minikube support multiple versions of localkube, and change the flags localkube takes over time. See #511 for one example of adding a flag.\r\n\r\nHere are some ideas:\r\n\r\n## Add a localkube command (or just parse the help text) to output what flags it takes.\r\nThen minikube could first call that command, compare the list of valid flags with the list of flags the user wants to pass, and warn/error appropriately.\r\n\r\n## Move flag passing to a config file\r\nThen locallkube could only use the flags it knows about, and log a warning about ignored flags. This would be harder to get the warning back to the user automatically, but would avoid errors in the case of extra flags.\r\n\r\nAny other ideas? Depending on what we do here, we might need to go back and re-release the last several localkube builds.\r\n\r\ncc @aaron-prindle @r2d4 "},"comment":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/comments/256489862","html_url":"https://github.com/kubernetes/minikube/issues/512#issuecomment-256489862","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/512","id":256489862,"user":{"login":"aaron-prindle","id":1951658,"avatar_url":"https://avatars.githubusercontent.com/u/1951658?v=3","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T21:59:38Z","updated_at":"2016-10-26T21:59:38Z","body":"I believe this was fixed with #529. Closing."}}
{"actor":{"display_login":"aaron-prindle"}}