{"action":"closed","issue":{"url":"https://api.github.com/repos/KristianOellegaard/django-health-check/issues/47","repository_url":"https://api.github.com/repos/KristianOellegaard/django-health-check","labels_url":"https://api.github.com/repos/KristianOellegaard/django-health-check/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/KristianOellegaard/django-health-check/issues/47/comments","events_url":"https://api.github.com/repos/KristianOellegaard/django-health-check/issues/47/events","html_url":"https://github.com/KristianOellegaard/django-health-check/issues/47","id":170714693,"number":47,"title":"Storage base check_status returns errors instead of raising them","user":{"login":"mspeedy","id":20404683,"avatar_url":"https://avatars.githubusercontent.com/u/20404683?v=3","gravatar_id":"","url":"https://api.github.com/users/mspeedy","html_url":"https://github.com/mspeedy","followers_url":"https://api.github.com/users/mspeedy/followers","following_url":"https://api.github.com/users/mspeedy/following{/other_user}","gists_url":"https://api.github.com/users/mspeedy/gists{/gist_id}","starred_url":"https://api.github.com/users/mspeedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspeedy/subscriptions","organizations_url":"https://api.github.com/users/mspeedy/orgs","repos_url":"https://api.github.com/users/mspeedy/repos","events_url":"https://api.github.com/users/mspeedy/events{/privacy}","received_events_url":"https://api.github.com/users/mspeedy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-11T18:34:09Z","updated_at":"2016-08-14T08:47:17Z","closed_at":"2016-08-14T08:47:17Z","body":"In health_check_storage.base.check_status in two of the if statements, the code returns an error instead of raising it. Therefore if the file contents are not equal to what is read, or if it is improperly deleted, the status of the plugin will be set to ServiceUnavailable(msg), rather than its numbered error code. The error is then raised when pretty_status attempts to to translate the ServiceUnavailable error into one of the three default messages.\r\n\r\nReplace 'return' with 'raise' and the problem should be fixed."}}
{"actor":{"display_login":"codingjoe"}}