{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13613","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13613/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13613/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13613/events","html_url":"https://github.com/edx/edx-platform/pull/13613","id":180289542,"number":13613,"title":"Aj/tnl 5644 exposed icon","user":{"login":"staubina","id":2854941,"avatar_url":"https://avatars.githubusercontent.com/u/2854941?v=3","gravatar_id":"","url":"https://api.github.com/users/staubina","html_url":"https://github.com/staubina","followers_url":"https://api.github.com/users/staubina/followers","following_url":"https://api.github.com/users/staubina/following{/other_user}","gists_url":"https://api.github.com/users/staubina/gists{/gist_id}","starred_url":"https://api.github.com/users/staubina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staubina/subscriptions","organizations_url":"https://api.github.com/users/staubina/orgs","repos_url":"https://api.github.com/users/staubina/repos","events_url":"https://api.github.com/users/staubina/events{/privacy}","received_events_url":"https://api.github.com/users/staubina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-09-30T12:15:07Z","updated_at":"2016-10-11T14:01:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13613","html_url":"https://github.com/edx/edx-platform/pull/13613","diff_url":"https://github.com/edx/edx-platform/pull/13613.diff","patch_url":"https://github.com/edx/edx-platform/pull/13613.patch"},"body":"## [TNL-5644](https://openedx.atlassian.net/browse/TNL-5644)\r\n\r\n### Description\r\n\r\nUpdated the Status icons to use the span component so that the Screen reader would function as expected. \r\n\r\nAlso, moved the status components for the problems to a template.\r\n\r\n### Sandbox\r\n\r\nSandbox:\r\nhttps://staubina-icon.sandbox.edx.org\r\n\r\n- [x] Build a sandbox for your branch and add a link here\r\n\r\n### Testing\r\n- [ ] i18n\r\n- [ ] RTL\r\n- [ ] safecommit violation code review process\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @cahrens \r\n- [ ] Code review: @alisan617\r\n- [ ] UX review: @chris-mike \r\n- [x] Accessibility review: @cptvitamin \r\n- [ ] Product review: @sstack22 \r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/252925467","html_url":"https://github.com/edx/edx-platform/pull/13613#issuecomment-252925467","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13613","id":252925467,"user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?v=3","gravatar_id":"","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T14:01:38Z","updated_at":"2016-10-11T14:01:38Z","body":"@cptvitamin Did you realize that this work also includes the following items (which you originally reported in TNL-5671)?\r\n\r\n1. Remove - aria-describedby on <span class=\"status incorrect/correct/unanswered\"\r\n2. Add - aria-describedby to all inputs/selects that references the <span class=\"status incorrect/correct/unanswered\" <-- will need a unique ID. For radio buttons and checkbox problems, the aria-describedby should be on the fieldset. Basically, in conjunction with #1 this reverts the \"aria-describedby\" relationship.\r\n3. Change - Status text \"This answer is incorrect/correct TO \"correct/incorrect (too verbose) It's OK for it to be verbose in the <span class=\"notification-message\r\n\r\nIf you didn't review those, please take a quick look to make sure that everything is as you desired. Thank you!"}}
{"actor":{"display_login":"cahrens"}}