{"action":"created","comment":{"url":"https://api.github.com/repos/fplll/fplll/pulls/comments/93758258","pull_request_review_id":14292914,"id":93758258,"diff_hunk":"@@ -298,116 +303,234 @@ template <class FT> int test_auto_prune(size_t n)\n             PRUNER_METRIC_PROBABILITY_OF_SHORTEST, true);\n   status |= !(pruning.expectation <= 1.0);\n   cerr << \"Probability \" << pruning.expectation << endl;\n+  cost = 0.;\n+  for (size_t i = 0; i < 2 * n; ++i)\n+  {\n+    cerr << pruning.detailed_cost[i] << \"\\t\";\n+    cost += pruning.detailed_cost[i];\n+  }\n+  cerr << endl << \"Total Cost \" << cost << endl;\n+\n   status |= !(pruning.expectation > 0.0);\n   status |= !(pruning.radius_factor >= 1.0);\n   status |= !(pruning.coefficients[0] == 1.0);\n \n+  if (status)\n+    exit(1);","path":"tests/test_pruner.cpp","position":88,"original_position":88,"commit_id":"200748eb6439e3ec0cff511a0f7960ab35df8ef4","original_commit_id":"200748eb6439e3ec0cff511a0f7960ab35df8ef4","user":{"login":"lducas","id":6318560,"avatar_url":"https://avatars.githubusercontent.com/u/6318560?v=3","gravatar_id":"","url":"https://api.github.com/users/lducas","html_url":"https://github.com/lducas","followers_url":"https://api.github.com/users/lducas/followers","following_url":"https://api.github.com/users/lducas/following{/other_user}","gists_url":"https://api.github.com/users/lducas/gists{/gist_id}","starred_url":"https://api.github.com/users/lducas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lducas/subscriptions","organizations_url":"https://api.github.com/users/lducas/orgs","repos_url":"https://api.github.com/users/lducas/repos","events_url":"https://api.github.com/users/lducas/events{/privacy}","received_events_url":"https://api.github.com/users/lducas/received_events","type":"User","site_admin":false},"body":"While, I want to know what exactly fails when it does... Can remove if bad practice.","created_at":"2016-12-23T12:00:32Z","updated_at":"2016-12-23T12:00:32Z","html_url":"https://github.com/fplll/fplll/pull/233#discussion_r93758258","pull_request_url":"https://api.github.com/repos/fplll/fplll/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/fplll/fplll/pulls/comments/93758258"},"html":{"href":"https://github.com/fplll/fplll/pull/233#discussion_r93758258"},"pull_request":{"href":"https://api.github.com/repos/fplll/fplll/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/fplll/fplll/pulls/233","id":99194815,"html_url":"https://github.com/fplll/fplll/pull/233","diff_url":"https://github.com/fplll/fplll/pull/233.diff","patch_url":"https://github.com/fplll/fplll/pull/233.patch","issue_url":"https://api.github.com/repos/fplll/fplll/issues/233","number":233,"state":"open","locked":false,"title":"Pruner","user":{"login":"lducas","id":6318560,"avatar_url":"https://avatars.githubusercontent.com/u/6318560?v=3","gravatar_id":"","url":"https://api.github.com/users/lducas","html_url":"https://github.com/lducas","followers_url":"https://api.github.com/users/lducas/followers","following_url":"https://api.github.com/users/lducas/following{/other_user}","gists_url":"https://api.github.com/users/lducas/gists{/gist_id}","starred_url":"https://api.github.com/users/lducas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lducas/subscriptions","organizations_url":"https://api.github.com/users/lducas/orgs","repos_url":"https://api.github.com/users/lducas/repos","events_url":"https://api.github.com/users/lducas/events{/privacy}","received_events_url":"https://api.github.com/users/lducas/received_events","type":"User","site_admin":false},"body":"The gradient descent was going rogue due to inappropriate lower bounds on b[i]. Also, the descent now starts from greedy if reset=true (this way, it is also at least as good as greedy... sometime it wasn't !)","created_at":"2016-12-23T01:47:59Z","updated_at":"2016-12-23T12:00:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7631eac09d886ba7bb58459d5615e1191195fe8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fplll/fplll/pulls/233/commits","review_comments_url":"https://api.github.com/repos/fplll/fplll/pulls/233/comments","review_comment_url":"https://api.github.com/repos/fplll/fplll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fplll/fplll/issues/233/comments","statuses_url":"https://api.github.com/repos/fplll/fplll/statuses/200748eb6439e3ec0cff511a0f7960ab35df8ef4","head":{"label":"fplll:pruner","ref":"pruner","sha":"200748eb6439e3ec0cff511a0f7960ab35df8ef4","user":{"login":"fplll","id":20039728,"avatar_url":"https://avatars.githubusercontent.com/u/20039728?v=3","gravatar_id":"","url":"https://api.github.com/users/fplll","html_url":"https://github.com/fplll","followers_url":"https://api.github.com/users/fplll/followers","following_url":"https://api.github.com/users/fplll/following{/other_user}","gists_url":"https://api.github.com/users/fplll/gists{/gist_id}","starred_url":"https://api.github.com/users/fplll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fplll/subscriptions","organizations_url":"https://api.github.com/users/fplll/orgs","repos_url":"https://api.github.com/users/fplll/repos","events_url":"https://api.github.com/users/fplll/events{/privacy}","received_events_url":"https://api.github.com/users/fplll/received_events","type":"Organization","site_admin":false},"repo":{"id":24889750,"name":"fplll","full_name":"fplll/fplll","owner":{"login":"fplll","id":20039728,"avatar_url":"https://avatars.githubusercontent.com/u/20039728?v=3","gravatar_id":"","url":"https://api.github.com/users/fplll","html_url":"https://github.com/fplll","followers_url":"https://api.github.com/users/fplll/followers","following_url":"https://api.github.com/users/fplll/following{/other_user}","gists_url":"https://api.github.com/users/fplll/gists{/gist_id}","starred_url":"https://api.github.com/users/fplll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fplll/subscriptions","organizations_url":"https://api.github.com/users/fplll/orgs","repos_url":"https://api.github.com/users/fplll/repos","events_url":"https://api.github.com/users/fplll/events{/privacy}","received_events_url":"https://api.github.com/users/fplll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fplll/fplll","description":"Lattice algorithms using floating-point arithmetic","fork":false,"url":"https://api.github.com/repos/fplll/fplll","forks_url":"https://api.github.com/repos/fplll/fplll/forks","keys_url":"https://api.github.com/repos/fplll/fplll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fplll/fplll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fplll/fplll/teams","hooks_url":"https://api.github.com/repos/fplll/fplll/hooks","issue_events_url":"https://api.github.com/repos/fplll/fplll/issues/events{/number}","events_url":"https://api.github.com/repos/fplll/fplll/events","assignees_url":"https://api.github.com/repos/fplll/fplll/assignees{/user}","branches_url":"https://api.github.com/repos/fplll/fplll/branches{/branch}","tags_url":"https://api.github.com/repos/fplll/fplll/tags","blobs_url":"https://api.github.com/repos/fplll/fplll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fplll/fplll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fplll/fplll/git/refs{/sha}","trees_url":"https://api.github.com/repos/fplll/fplll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fplll/fplll/statuses/{sha}","languages_url":"https://api.github.com/repos/fplll/fplll/languages","stargazers_url":"https://api.github.com/repos/fplll/fplll/stargazers","contributors_url":"https://api.github.com/repos/fplll/fplll/contributors","subscribers_url":"https://api.github.com/repos/fplll/fplll/subscribers","subscription_url":"https://api.github.com/repos/fplll/fplll/subscription","commits_url":"https://api.github.com/repos/fplll/fplll/commits{/sha}","git_commits_url":"https://api.github.com/repos/fplll/fplll/git/commits{/sha}","comments_url":"https://api.github.com/repos/fplll/fplll/comments{/number}","issue_comment_url":"https://api.github.com/repos/fplll/fplll/issues/comments{/number}","contents_url":"https://api.github.com/repos/fplll/fplll/contents/{+path}","compare_url":"https://api.github.com/repos/fplll/fplll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fplll/fplll/merges","archive_url":"https://api.github.com/repos/fplll/fplll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fplll/fplll/downloads","issues_url":"https://api.github.com/repos/fplll/fplll/issues{/number}","pulls_url":"https://api.github.com/repos/fplll/fplll/pulls{/number}","milestones_url":"https://api.github.com/repos/fplll/fplll/milestones{/number}","notifications_url":"https://api.github.com/repos/fplll/fplll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fplll/fplll/labels{/name}","releases_url":"https://api.github.com/repos/fplll/fplll/releases{/id}","deployments_url":"https://api.github.com/repos/fplll/fplll/deployments","created_at":"2014-10-07T12:44:16Z","updated_at":"2016-12-16T19:09:59Z","pushed_at":"2016-12-23T09:01:30Z","git_url":"git://github.com/fplll/fplll.git","ssh_url":"git@github.com:fplll/fplll.git","clone_url":"https://github.com/fplll/fplll.git","svn_url":"https://github.com/fplll/fplll","homepage":"","size":5622,"stargazers_count":55,"watchers_count":55,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":8,"forks":34,"open_issues":8,"watchers":55,"default_branch":"master"}},"base":{"label":"fplll:master","ref":"master","sha":"b75fe83b6dea11647174e44242fdfe0f577ea7fe","user":{"login":"fplll","id":20039728,"avatar_url":"https://avatars.githubusercontent.com/u/20039728?v=3","gravatar_id":"","url":"https://api.github.com/users/fplll","html_url":"https://github.com/fplll","followers_url":"https://api.github.com/users/fplll/followers","following_url":"https://api.github.com/users/fplll/following{/other_user}","gists_url":"https://api.github.com/users/fplll/gists{/gist_id}","starred_url":"https://api.github.com/users/fplll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fplll/subscriptions","organizations_url":"https://api.github.com/users/fplll/orgs","repos_url":"https://api.github.com/users/fplll/repos","events_url":"https://api.github.com/users/fplll/events{/privacy}","received_events_url":"https://api.github.com/users/fplll/received_events","type":"Organization","site_admin":false},"repo":{"id":24889750,"name":"fplll","full_name":"fplll/fplll","owner":{"login":"fplll","id":20039728,"avatar_url":"https://avatars.githubusercontent.com/u/20039728?v=3","gravatar_id":"","url":"https://api.github.com/users/fplll","html_url":"https://github.com/fplll","followers_url":"https://api.github.com/users/fplll/followers","following_url":"https://api.github.com/users/fplll/following{/other_user}","gists_url":"https://api.github.com/users/fplll/gists{/gist_id}","starred_url":"https://api.github.com/users/fplll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fplll/subscriptions","organizations_url":"https://api.github.com/users/fplll/orgs","repos_url":"https://api.github.com/users/fplll/repos","events_url":"https://api.github.com/users/fplll/events{/privacy}","received_events_url":"https://api.github.com/users/fplll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fplll/fplll","description":"Lattice algorithms using floating-point arithmetic","fork":false,"url":"https://api.github.com/repos/fplll/fplll","forks_url":"https://api.github.com/repos/fplll/fplll/forks","keys_url":"https://api.github.com/repos/fplll/fplll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fplll/fplll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fplll/fplll/teams","hooks_url":"https://api.github.com/repos/fplll/fplll/hooks","issue_events_url":"https://api.github.com/repos/fplll/fplll/issues/events{/number}","events_url":"https://api.github.com/repos/fplll/fplll/events","assignees_url":"https://api.github.com/repos/fplll/fplll/assignees{/user}","branches_url":"https://api.github.com/repos/fplll/fplll/branches{/branch}","tags_url":"https://api.github.com/repos/fplll/fplll/tags","blobs_url":"https://api.github.com/repos/fplll/fplll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fplll/fplll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fplll/fplll/git/refs{/sha}","trees_url":"https://api.github.com/repos/fplll/fplll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fplll/fplll/statuses/{sha}","languages_url":"https://api.github.com/repos/fplll/fplll/languages","stargazers_url":"https://api.github.com/repos/fplll/fplll/stargazers","contributors_url":"https://api.github.com/repos/fplll/fplll/contributors","subscribers_url":"https://api.github.com/repos/fplll/fplll/subscribers","subscription_url":"https://api.github.com/repos/fplll/fplll/subscription","commits_url":"https://api.github.com/repos/fplll/fplll/commits{/sha}","git_commits_url":"https://api.github.com/repos/fplll/fplll/git/commits{/sha}","comments_url":"https://api.github.com/repos/fplll/fplll/comments{/number}","issue_comment_url":"https://api.github.com/repos/fplll/fplll/issues/comments{/number}","contents_url":"https://api.github.com/repos/fplll/fplll/contents/{+path}","compare_url":"https://api.github.com/repos/fplll/fplll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fplll/fplll/merges","archive_url":"https://api.github.com/repos/fplll/fplll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fplll/fplll/downloads","issues_url":"https://api.github.com/repos/fplll/fplll/issues{/number}","pulls_url":"https://api.github.com/repos/fplll/fplll/pulls{/number}","milestones_url":"https://api.github.com/repos/fplll/fplll/milestones{/number}","notifications_url":"https://api.github.com/repos/fplll/fplll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fplll/fplll/labels{/name}","releases_url":"https://api.github.com/repos/fplll/fplll/releases{/id}","deployments_url":"https://api.github.com/repos/fplll/fplll/deployments","created_at":"2014-10-07T12:44:16Z","updated_at":"2016-12-16T19:09:59Z","pushed_at":"2016-12-23T09:01:30Z","git_url":"git://github.com/fplll/fplll.git","ssh_url":"git@github.com:fplll/fplll.git","clone_url":"https://github.com/fplll/fplll.git","svn_url":"https://github.com/fplll/fplll","homepage":"","size":5622,"stargazers_count":55,"watchers_count":55,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":8,"forks":34,"open_issues":8,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fplll/fplll/pulls/233"},"html":{"href":"https://github.com/fplll/fplll/pull/233"},"issue":{"href":"https://api.github.com/repos/fplll/fplll/issues/233"},"comments":{"href":"https://api.github.com/repos/fplll/fplll/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/fplll/fplll/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/fplll/fplll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fplll/fplll/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/fplll/fplll/statuses/200748eb6439e3ec0cff511a0f7960ab35df8ef4"}}}}
{"actor":{"display_login":"lducas"}}