{"push_id":1020294459,"size":35,"distinct_size":35,"ref":"refs/heads/master","head":"90ce409e3581b455ab8ac6532684ef3e9475772a","before":"f3485bc125afbb0930674e9f5a4f02cdd9989aea","commits":[{"sha":"62fef18d69be7d8c5338fe5a471966dc1e6d68f7","author":{"email":"6f6e68d1df92f30cb4b3ce35260ddf94a402f33d@dasilva.io","name":"Shane da Silva"},"message":"Fix documentation for creating containers with data volumes\n\nThe documentation for Docker 1.10.2 (API version 1.22) mentions under\nthe \"Create a container\"[1] section that `HostConfig.Binds` can be given\na \"container path\" which will automatically \"create a new volume for the\ncontainer.\"\n\nI interpreted this to mean it that the following two commands should\nhave the same net result:\n\n    # Create container with data volume via REST API\n    curl --unix-socket /var/run/docker.sock -XPOST \\\n         http://localhost/containers/create \\\n         -H\"Content-Type: application/json\" \\\n         -d'{\n           \"Image\": \"<image-id>\",\n           ...\n           \"HostConfig\": {\n             \"Binds\": [\n               \"/some/data/volume\"\n             ]\n           }\n         }'\n\n    # Create container with data volume via CLI\n    docker create -v /some/data/volume <image-id> <command>\n\nHowever, this turned out not the be the case, as the former would create\na mount with no source and no corresponding volume:\n\n    ...\n    \"Mounts\": [\n      {\n        \"Source\": \"\",\n        \"Destination\": \"/some/data/volume\",\n        \"Driver\": \"local\",\n        \"Mode\": \"\",\n        \"RW\": true,\n        \"Propagation\": \"rprivate\"\n      }\n    ],\n    ...\n    \"Config\": {\n      ...\n      \"Volumes\": null,\n      ...\n    }\n\n...whereas the latter would create a volume and mount it:\n\n    ...\n    \"Mounts\": [\n      {\n        \"Name\": \"9b38af46d6...\"\n        \"Source\": \"/var/lib/docker/volumes/9b38af46d6.../_data\",\n        \"Destination\": \"/some/data/volume\",\n        \"Driver\": \"local\",\n        \"Mode\": \"\",\n        \"RW\": true,\n        \"Propagation\": \"\"\n      }\n    ],\n    ...\n    \"Config\": {\n      ...\n      \"Volumes\": {\n        \"/some/data/volume\": {}\n      },\n      ...\n    }\n\nHowever, if you instead specify the data volume via the `Volumes` key,\nthen it works as expected, e.g.\n\n    curl --unix-socket /var/run/docker.sock -XPOST \\\n         http://localhost/containers/create \\\n         -H\"Content-Type: application/json\" \\\n         -d'{\n           \"Image\": \"...\",\n           ...\n           \"Volumes\": {\"/some/data/volume\": {}}\n          }'\n\n...will create a data volume and mount it.\n\nThus the documentation is either incorrect, or this is a bug and the\nability to create a data volume via `HostConfig.Binds` does not\nwork as advertised for API version 1.22 (and likely others).\n\nI concluded that the documentation was incorrect. Since I've only\nverified this behavior for Docker 1.10.2, I updated the docs for\nAPI versions 1.22 and 1.23, but this may apply to other versions as\nwell.\n\n[1] https://docs.docker.com/engine/reference/api/docker_remote_api_v1.22/#create-a-container\n\nSigned-off-by: Shane da Silva <shane@dasilva.io>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/62fef18d69be7d8c5338fe5a471966dc1e6d68f7"},{"sha":"5730259f324a59a6dddf63a950ab8eb9cde3ca0c","author":{"email":"e1c79a582b6629e6b39e9679f4bb964d25db4aa8@mcgstyle.net","name":"Derek McGowan"},"message":"Vendor updates to distribution\n\nPull in changes for refresh token in the registry client\n\nSigned-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/5730259f324a59a6dddf63a950ab8eb9cde3ca0c"},{"sha":"e896d1d7c4459c4b357efdd780e9fb9dd9bc90e0","author":{"email":"e1c79a582b6629e6b39e9679f4bb964d25db4aa8@mcgstyle.net","name":"Derek McGowan"},"message":"Add support for identity token with token handler\n\nUse token handler options for initialization.\nUpdate auth endpoint to set identity token in response.\nUpdate credential store to match distribution interface changes.\n\nSigned-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/e896d1d7c4459c4b357efdd780e9fb9dd9bc90e0"},{"sha":"a6d0c66b4c923cddeaea09f5b41ad353ea7a9b5f","author":{"email":"8ecfc6017a87905413dcd7d63696a2a4c351b604@docker.com","name":"Aaron Lehmann"},"message":"Change Docker client to support OAuth-based flow for login\n\nThis mechanism exchanges basic auth credentials for an identity token.\nThe identity token is used going forward to request scoped-down tokens\nto use for registry operations.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/a6d0c66b4c923cddeaea09f5b41ad353ea7a9b5f"},{"sha":"ba0aa5311aa27fe77166f03d8bcc0174e2985913","author":{"email":"8ecfc6017a87905413dcd7d63696a2a4c351b604@docker.com","name":"Aaron Lehmann"},"message":"Add support for identity tokens in client credentials store\n\nUpdate unit test and documentation to handle the new case where Username\nis set to <token> to indicate an identity token is involved.\n\nChange the \"Password\" field in communications with the credential helper\nto \"Secret\" to make clear it has a more generic purpose.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/ba0aa5311aa27fe77166f03d8bcc0174e2985913"},{"sha":"76cd0f681184afc44302b954a0775b0cfd748c4f","author":{"email":"e1c79a582b6629e6b39e9679f4bb964d25db4aa8@mcgstyle.net","name":"Derek McGowan"},"message":"Update docs to mention identity token usage for /auth\n\nSigned-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/76cd0f681184afc44302b954a0775b0cfd748c4f"},{"sha":"7bb815e2960c97c5cc0624566ac51581bdd884ab","author":{"email":"4efb7da3e38416208b41d8021a942884d8a9435c@docker.com","name":"Alexander Morozov"},"message":"daemon: fix hanging attaches on initial start failures\n\nAttach can hang forever if there is no data to send. This PR adds notification\nof Attach goroutine about container stop.\n\nSigned-off-by: Alexander Morozov <lk4d4@docker.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/7bb815e2960c97c5cc0624566ac51581bdd884ab"},{"sha":"68bda672dc0fb53c5247047104e09c7f8346e24e","author":{"email":"af64ee19f04db9509cb02b0e470e11e5402ef9b3@docker.com","name":"Justin Cormack"},"message":"Update statically linked libseccomp to 2.3.0\n\nFixes #20550\n\nThis update to libseccomp supports the new versions of socket\nsystem calls that can be called directly rather than via the\nsocketcall syscall in kernel versions 4.3 or later with new glibc.\n\nNote this library version now supports s390x and ppc64le, so\nseccomp can be potentially be enabled for these architectures now.\n\nSigned-off-by: Justin Cormack <justin.cormack@docker.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/68bda672dc0fb53c5247047104e09c7f8346e24e"},{"sha":"16e4c4e481aca8d5a99d5a4760b5d27bf5bbb9fd","author":{"email":"c2470c48b2d3312d61f94f18d3a1cd113d1915ad@gmail.com","name":"Tonis Tiigi"},"message":"Fix docker run for 64 byte hex ID\n\nFixes #20972\n\nAlso makes sure there is no check to registry if\nno image is found for the prefixed IDs.\n\nSigned-off-by: Tonis Tiigi <tonistiigi@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/16e4c4e481aca8d5a99d5a4760b5d27bf5bbb9fd"},{"sha":"e2076453071f9fc82478557919d327c958eec712","author":{"email":"dbac1f450dc8326caa7ba104b384a0eca642250c@linux.vnet.ibm.com","name":"Phil Estes"},"message":"Fix gcc compile test with proper flag ordering\n\nThis test for libdevmapper was always silently failing because the\nlinker never got the `-ldevmapper` information. Putting the flag last\ncorrects the test.\n\nDocker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/e2076453071f9fc82478557919d327c958eec712"},{"sha":"2a0291489247b79058f0f94a2af7c5b3f89b78af","author":{"email":"da8482a61c3a314f69bc15b69175fd62d9234b97@linux.vnet.ibm.com","name":"Christopher Jones"},"message":"Fix error-checking when looking at empty log\n\nFixes a bug when the log output is empty.\n\nThe length of a slice containing an empty string is 1, not 0, so\nthe test fails to catch when the log is empty. Instead, take a look at\nout, which is just a string.\n\nSigned-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/2a0291489247b79058f0f94a2af7c5b3f89b78af"},{"sha":"db700a678d1da4275553ff7201e2597c7a8016ee","author":{"email":"da8482a61c3a314f69bc15b69175fd62d9234b97@linux.vnet.ibm.com","name":"Christopher Jones"},"message":"Add notary binary requirement for tests\n\nThis PR adds the \"notary\" binary requirement for tests.\n\nPreviously, NotaryHosting was checking for the \"notary-server\"\nbinary under the name notaryBinary. This renames that reference to\nnotaryServerBinary, so that notaryBinary can rightly refer\nto the actual \"notary\" binary.\n\nCurrently only one test actually uses the notary binary, so it's been\nupdated accordingly.\n\nSigned-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/db700a678d1da4275553ff7201e2597c7a8016ee"},{"sha":"94336cb5dd7bce9f34901a86000a124a6d6c68ef","author":{"email":"64b2b6d12bfe4baae7dad3d018f8cbf6b0e7a044@gone.nl","name":"Sebastiaan van Stijn"},"message":"Add redirects for old Docker Cloud tutorial\n\nThis page has been deleted from the Docker Cloud tutorials,\nso adding redirects for the old locations.\n\nSigned-off-by: Sebastiaan van Stijn <github@gone.nl>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/94336cb5dd7bce9f34901a86000a124a6d6c68ef"},{"sha":"497d545093bce4f01455bf8d2e1658435dbb040b","author":{"email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com","name":"Antonio Murdaca"},"message":"distribution: errors: do not retry if no credentials provided\n\nFix and add test for case c) in #21054\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/497d545093bce4f01455bf8d2e1658435dbb040b"},{"sha":"8ff884548f9dfcc67a1a3bc186957c964fb62fe4","author":{"email":"50ae662f5fcde39b7d1ed786133b7c61a25411dd@microsoft.com","name":"John Howard"},"message":"Fix TestLogsContainers performance\n\nSigned-off-by: John Howard <jhoward@microsoft.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/8ff884548f9dfcc67a1a3bc186957c964fb62fe4"},{"sha":"2ef00ba89fc04b0a7571aa050d8a11c06f758d9b","author":{"email":"d22477479bbf55ba62bd822f4112c80f292c7805@docker.com","name":"Madhu Venugopal"},"message":"Include all endpoints in network inspect object\n\nPrior to this change, the \"docker network inspect\" contains only the\nendpoints that have active local container. This excludes all the remote\nand stale endpoints. By including all the endpoints, it makes debugging\nmuch simpler and also allows the user to cleanup any stale endpoints\nusing \"docker network disconnect -f {network} {endpoint-name}\".\n\nSigned-off-by: Madhu Venugopal <madhu@docker.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/2ef00ba89fc04b0a7571aa050d8a11c06f758d9b"},{"sha":"f6bd62a8d735d4748dc4e5e4235e04284a7f5af6","author":{"email":"03a9957f0460ce3379f6e452396aa35e108b5af5@cn.ibm.com","name":"Kai Qiang Wu(Kennan)"},"message":"Fix the typo url and info\n\nSome info is not consistent between context and word.\n\nSigned-off-by: Kai Qiang Wu(Kennan) <wkqwu@cn.ibm.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/f6bd62a8d735d4748dc4e5e4235e04284a7f5af6"},{"sha":"d4a4cb99e3a447d7711140ff377a3ece0e6bc1a2","author":{"email":"9ac444d2b5df3db1f31aa1c6462ac8e9e2bde241@huawei.com","name":"Lei Jitang"},"message":"Merge pull request #21177 from HackToday/fixtypo\n\nFix the typo url and info","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/d4a4cb99e3a447d7711140ff377a3ece0e6bc1a2"},{"sha":"901c67a8eeabc64e53539b5f3d5aac9c9196a037","author":{"email":"87e1f221a672a14a323e57bb65eaea19d3ed3804@sbr.pm","name":"Vincent Demeester"},"message":"Merge pull request #21160 from mavenugo/staleep\n\nInclude all endpoints in network inspect object","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/901c67a8eeabc64e53539b5f3d5aac9c9196a037"},{"sha":"6d23c3c57a733436d902b7883f2f0b00846df9e2","author":{"email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com","name":"Antonio Murdaca"},"message":"integration-cli: add tests for case a) and d) in #21054\n\n- add test for pull from private registry with no credentials\n- add test for push to docker hub with no credentials\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>\nSigned-off-by: Antonio Murdaca <amurdaca@localhost.localdomain>\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/vdemeester/docker/commits/6d23c3c57a733436d902b7883f2f0b00846df9e2"}]}