{"action":"created","issue":{"url":"https://api.github.com/repos/pytest-dev/pytest/issues/2046","repository_url":"https://api.github.com/repos/pytest-dev/pytest","labels_url":"https://api.github.com/repos/pytest-dev/pytest/issues/2046/labels{/name}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/2046/comments","events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/2046/events","html_url":"https://github.com/pytest-dev/pytest/pull/2046","id":188033642,"number":2046,"title":"Clean up unittest TestCase objects after tests are complete (#1649).","user":{"login":"d-b-w","id":3013277,"avatar_url":"https://avatars.githubusercontent.com/u/3013277?v=3","gravatar_id":"","url":"https://api.github.com/users/d-b-w","html_url":"https://github.com/d-b-w","followers_url":"https://api.github.com/users/d-b-w/followers","following_url":"https://api.github.com/users/d-b-w/following{/other_user}","gists_url":"https://api.github.com/users/d-b-w/gists{/gist_id}","starred_url":"https://api.github.com/users/d-b-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-b-w/subscriptions","organizations_url":"https://api.github.com/users/d-b-w/orgs","repos_url":"https://api.github.com/users/d-b-w/repos","events_url":"https://api.github.com/users/d-b-w/events{/privacy}","received_events_url":"https://api.github.com/users/d-b-w/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-08T16:10:13Z","updated_at":"2016-11-08T17:23:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/2046","html_url":"https://github.com/pytest-dev/pytest/pull/2046","diff_url":"https://github.com/pytest-dev/pytest/pull/2046.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/2046.patch"},"body":"Fix [#1649](https://github.com/pytest-dev/pytest/issues/1649)\r\n\r\nUsers of unittest style TestCases will create expensive objects\r\nin setUp. We should clean up TestCase instances that are lying\r\naround so that they don't fill up memory.\r\n\r\nHere's a quick checklist that should be present in PRs:\r\n\r\n- [x] Target: for bug or doc fixes, target `master`; for new features, target `features`; (master)\r\n- [x] Make sure to include one or more tests for your change; (`test_teardown_issue1649()`, fails before and passes after)\r\n- [x] Add yourself to `AUTHORS`; (as Daniel Wandschneider)\r\n- [x] Add a new entry to `CHANGELOG.rst` (Added first line of this description)"},"comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments/259200988","html_url":"https://github.com/pytest-dev/pytest/pull/2046#issuecomment-259200988","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/2046","id":259200988,"user":{"login":"nicoddemus","id":1085180,"avatar_url":"https://avatars.githubusercontent.com/u/1085180?v=3","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T17:23:28Z","updated_at":"2016-11-08T17:23:28Z","body":"> I didn't think people would do add attributes to the test instances for pytest style test cases because they could just use fixtures. I'll put together a second PR for non-unittest cases.\r\n\r\nO sorry I didn't your reply before I posted mine. I will merge this as it is then if you prefer a separate PR. \r\n\r\nThanks again!"}}
{"actor":{"display_login":"nicoddemus"}}