{"action":"created","comment":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/51044385","id":51044385,"diff_hunk":"@@ -955,7 +955,7 @@ def registerReadback(self):\n         @inlineCallbacks\n         def func():\n             # build registry packet\n-            regs = self.regRun(self.RUN_MODE_REGISTER_READBACK, 0) # 0 reps?\n+            regs = self.regRun(self.RUN_MODE_REGISTER_READBACK, {}, 0)","path":"fpgalib/adc.py","position":5,"original_position":5,"commit_id":"ea9a2ca23bf04609f961bd7252d540690aacd7da","original_commit_id":"ea9a2ca23bf04609f961bd7252d540690aacd7da","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"I think it'd be a good idea to add param names throughout the module. Note that the param names for build1 and build7 are different.","created_at":"2016-01-27T20:25:12Z","updated_at":"2016-01-27T20:25:12Z","html_url":"https://github.com/martinisgroup/servers/pull/310#discussion_r51044385","pull_request_url":"https://api.github.com/repos/martinisgroup/servers/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/51044385"},"html":{"href":"https://github.com/martinisgroup/servers/pull/310#discussion_r51044385"},"pull_request":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/310","id":57314282,"html_url":"https://github.com/martinisgroup/servers/pull/310","diff_url":"https://github.com/martinisgroup/servers/pull/310.diff","patch_url":"https://github.com/martinisgroup/servers/pull/310.patch","issue_url":"https://api.github.com/repos/martinisgroup/servers/issues/310","number":310,"state":"open","locked":false,"title":"Fix bug #309","user":{"login":"patzinak","id":13015184,"avatar_url":"https://avatars.githubusercontent.com/u/13015184?v=3","gravatar_id":"","url":"https://api.github.com/users/patzinak","html_url":"https://github.com/patzinak","followers_url":"https://api.github.com/users/patzinak/followers","following_url":"https://api.github.com/users/patzinak/following{/other_user}","gists_url":"https://api.github.com/users/patzinak/gists{/gist_id}","starred_url":"https://api.github.com/users/patzinak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patzinak/subscriptions","organizations_url":"https://api.github.com/users/patzinak/orgs","repos_url":"https://api.github.com/users/patzinak/repos","events_url":"https://api.github.com/users/patzinak/events{/privacy}","received_events_url":"https://api.github.com/users/patzinak/received_events","type":"User","site_admin":false},"body":"See bug  #309 separated from issue #301.","created_at":"2016-01-27T05:03:35Z","updated_at":"2016-01-27T20:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd94f893e1bc6db52cc4241207c47b98720943e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/martinisgroup/servers/pulls/310/commits","review_comments_url":"https://api.github.com/repos/martinisgroup/servers/pulls/310/comments","review_comment_url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinisgroup/servers/issues/310/comments","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/ea9a2ca23bf04609f961bd7252d540690aacd7da","head":{"label":"McDermott-Group:bug-fix-309-adc-build-7-register-readback","ref":"bug-fix-309-adc-build-7-register-readback","sha":"ea9a2ca23bf04609f961bd7252d540690aacd7da","user":{"login":"McDermott-Group","id":13005504,"avatar_url":"https://avatars.githubusercontent.com/u/13005504?v=3","gravatar_id":"","url":"https://api.github.com/users/McDermott-Group","html_url":"https://github.com/McDermott-Group","followers_url":"https://api.github.com/users/McDermott-Group/followers","following_url":"https://api.github.com/users/McDermott-Group/following{/other_user}","gists_url":"https://api.github.com/users/McDermott-Group/gists{/gist_id}","starred_url":"https://api.github.com/users/McDermott-Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McDermott-Group/subscriptions","organizations_url":"https://api.github.com/users/McDermott-Group/orgs","repos_url":"https://api.github.com/users/McDermott-Group/repos","events_url":"https://api.github.com/users/McDermott-Group/events{/privacy}","received_events_url":"https://api.github.com/users/McDermott-Group/received_events","type":"Organization","site_admin":false},"repo":{"id":50482455,"name":"martinis-group-servers","full_name":"McDermott-Group/martinis-group-servers","owner":{"login":"McDermott-Group","id":13005504,"avatar_url":"https://avatars.githubusercontent.com/u/13005504?v=3","gravatar_id":"","url":"https://api.github.com/users/McDermott-Group","html_url":"https://github.com/McDermott-Group","followers_url":"https://api.github.com/users/McDermott-Group/followers","following_url":"https://api.github.com/users/McDermott-Group/following{/other_user}","gists_url":"https://api.github.com/users/McDermott-Group/gists{/gist_id}","starred_url":"https://api.github.com/users/McDermott-Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McDermott-Group/subscriptions","organizations_url":"https://api.github.com/users/McDermott-Group/orgs","repos_url":"https://api.github.com/users/McDermott-Group/repos","events_url":"https://api.github.com/users/McDermott-Group/events{/privacy}","received_events_url":"https://api.github.com/users/McDermott-Group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/McDermott-Group/martinis-group-servers","description":"LabRAD servers","fork":true,"url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers","forks_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/forks","keys_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/teams","hooks_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/hooks","issue_events_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/issues/events{/number}","events_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/events","assignees_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/assignees{/user}","branches_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/branches{/branch}","tags_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/tags","blobs_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/statuses/{sha}","languages_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/languages","stargazers_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/stargazers","contributors_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/contributors","subscribers_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/subscribers","subscription_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/subscription","commits_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/contents/{+path}","compare_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/merges","archive_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/downloads","issues_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/issues{/number}","pulls_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/pulls{/number}","milestones_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/milestones{/number}","notifications_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/labels{/name}","releases_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/releases{/id}","deployments_url":"https://api.github.com/repos/McDermott-Group/martinis-group-servers/deployments","created_at":"2016-01-27T04:51:48Z","updated_at":"2016-01-27T04:52:02Z","pushed_at":"2016-01-27T04:55:11Z","git_url":"git://github.com/McDermott-Group/martinis-group-servers.git","ssh_url":"git@github.com:McDermott-Group/martinis-group-servers.git","clone_url":"https://github.com/McDermott-Group/martinis-group-servers.git","svn_url":"https://github.com/McDermott-Group/martinis-group-servers","homepage":"","size":51407,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"martinisgroup:master","ref":"master","sha":"a836b35879b3f114e4f177a93a150a1801579030","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"LabRAD servers","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","deployments_url":"https://api.github.com/repos/martinisgroup/servers/deployments","created_at":"2014-06-25T00:07:25Z","updated_at":"2015-11-22T16:31:13Z","pushed_at":"2016-01-27T05:03:35Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":"","size":52867,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":95,"forks":6,"open_issues":95,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/310"},"html":{"href":"https://github.com/martinisgroup/servers/pull/310"},"issue":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/310"},"comments":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/martinisgroup/servers/statuses/ea9a2ca23bf04609f961bd7252d540690aacd7da"}}}}