{"action":"created","issue":{"url":"https://api.github.com/repos/silverwind/droppy/issues/260","repository_url":"https://api.github.com/repos/silverwind/droppy","labels_url":"https://api.github.com/repos/silverwind/droppy/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/silverwind/droppy/issues/260/comments","events_url":"https://api.github.com/repos/silverwind/droppy/issues/260/events","html_url":"https://github.com/silverwind/droppy/issues/260","id":158889700,"number":260,"title":"Exception and endless response if you are request a non-valid download url","user":{"login":"Augustus78","id":19796940,"avatar_url":"https://avatars.githubusercontent.com/u/19796940?v=3","gravatar_id":"","url":"https://api.github.com/users/Augustus78","html_url":"https://github.com/Augustus78","followers_url":"https://api.github.com/users/Augustus78/followers","following_url":"https://api.github.com/users/Augustus78/following{/other_user}","gists_url":"https://api.github.com/users/Augustus78/gists{/gist_id}","starred_url":"https://api.github.com/users/Augustus78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Augustus78/subscriptions","organizations_url":"https://api.github.com/users/Augustus78/orgs","repos_url":"https://api.github.com/users/Augustus78/repos","events_url":"https://api.github.com/users/Augustus78/events{/privacy}","received_events_url":"https://api.github.com/users/Augustus78/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-07T10:27:54Z","updated_at":"2016-06-08T20:04:07Z","closed_at":"2016-06-07T16:14:10Z","body":"If you open in your browser a download url that don’t existing droppy create this exception:\r\n2016-06-07 12:24:20 [ERROR] =============== Uncaught exception! ===============\r\n2016-06-07 12:24:20 [ERROR] TypeError: Cannot read property 'location' of undefined\r\n    at handleFileRequest (/usr/lib/node_modules/droppy/server/server.js:718:39)\r\n    at handleGET (/usr/lib/node_modules/droppy/server/server.js:534:5)\r\n    at Server.onRequest (/usr/lib/node_modules/droppy/server/server.js:115:7)\r\n    at emitTwo (events.js:87:13)\r\n    at Server.emit (events.js:172:7)\r\n    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:533:12)\r\n    at HTTPParser.parserOnHeadersComplete (_http_common.js:103:23)\r\nOne way this is maybe good to complicate a brute force attack to find download urls, but for me it looks dirty and not wanted. Also I don’t know the side effect because I am not a Node developer.\r\n\r\nWith download url I mean urls like: ?$/fru7ksdvpdd (invalid/not existend) or simple ?$/\r\n\r\ndroppy 4.2.5\r\nnode 4.4.5\r\n"},"comment":{"url":"https://api.github.com/repos/silverwind/droppy/issues/comments/224710728","html_url":"https://github.com/silverwind/droppy/issues/260#issuecomment-224710728","issue_url":"https://api.github.com/repos/silverwind/droppy/issues/260","id":224710728,"user":{"login":"Augustus78","id":19796940,"avatar_url":"https://avatars.githubusercontent.com/u/19796940?v=3","gravatar_id":"","url":"https://api.github.com/users/Augustus78","html_url":"https://github.com/Augustus78","followers_url":"https://api.github.com/users/Augustus78/followers","following_url":"https://api.github.com/users/Augustus78/following{/other_user}","gists_url":"https://api.github.com/users/Augustus78/gists{/gist_id}","starred_url":"https://api.github.com/users/Augustus78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Augustus78/subscriptions","organizations_url":"https://api.github.com/users/Augustus78/orgs","repos_url":"https://api.github.com/users/Augustus78/repos","events_url":"https://api.github.com/users/Augustus78/events{/privacy}","received_events_url":"https://api.github.com/users/Augustus78/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T20:04:07Z","updated_at":"2016-06-08T20:04:07Z","body":"Thank you. Great and fast support. It works now without problem. "}}
{"actor":{"display_login":"Augustus78"}}