{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/78052155","id":78052155,"diff_hunk":"@@ -18,6 +18,16 @@ os::cmd::expect_failure 'oc new-app unknownhubimage -o yaml'\n os::cmd::expect_failure_and_text 'oc new-app docker.io/node~https://github.com/openshift/nodejs-ex' 'the image match \\\"docker.io/node\\\" for source repository \\\"https://github.com/openshift/nodejs-ex\\\" does not appear to be a source-to-image builder.'\n os::cmd::expect_failure_and_text 'oc new-app https://github.com/openshift/rails-ex' 'the image match \\\"ruby\\\" for source repository \\\"https://github.com/openshift/rails-ex\\\" does not appear to be a source-to-image builder.'\n os::cmd::expect_success 'oc new-app https://github.com/openshift/rails-ex --strategy=source --dry-run'\n+# When env file doesn't exist\n+export TEMP_DIR=$(mktemp -d temp.XXXXXXXXX)\n+export TEMP_FILE=$TEMP_DIR/envfile\n+os::cmd::expect_failure_and_text 'oc new-app openshift/postgresql-92-centos7 --env-file='\"$TEMP_FILE\"' --dry-run' 'Error reading environment variable from file'\n+# When env file contains invalid entries\n+printf 'one=first\\ntwosecond\\nthree=third\\n' >> $TEMP_FILE\n+os::cmd::expect_failure_and_text 'oc new-app openshift/postgresql-92-centos7 --env-file='\"$TEMP_FILE\"' --dry-run' 'environment variables must be of the form key=value'","path":"test/cmd/newapp.sh","position":10,"original_position":10,"commit_id":"aaba79430e69c08eba2ccf7974e6307b06113c68","original_commit_id":"aaba79430e69c08eba2ccf7974e6307b06113c68","user":{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars.githubusercontent.com/u/11657829?v=3","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"body":"I have positive test-cases in newapp_test.go ","created_at":"2016-09-08T17:30:28Z","updated_at":"2016-09-08T17:30:28Z","html_url":"https://github.com/openshift/origin/pull/10766#discussion_r78052155","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/10766","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/78052155"},"html":{"href":"https://github.com/openshift/origin/pull/10766#discussion_r78052155"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/10766"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10766","id":83649507,"html_url":"https://github.com/openshift/origin/pull/10766","diff_url":"https://github.com/openshift/origin/pull/10766.diff","patch_url":"https://github.com/openshift/origin/pull/10766.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10766","number":10766,"state":"open","locked":false,"title":"PR for  using a env file in oc cmdline","user":{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars.githubusercontent.com/u/11657829?v=3","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"body":"@bparees, As discussed this is PR for  #7585. Please provide some feedback on the set of changes made.","created_at":"2016-09-01T15:02:13Z","updated_at":"2016-09-08T17:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"018e9d0d878a2e1cc48447e5b5e97bb9bfbbae9a","assignee":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10766/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10766/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10766/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/aaba79430e69c08eba2ccf7974e6307b06113c68","head":{"label":"ravisantoshgudimetla:master","ref":"master","sha":"aaba79430e69c08eba2ccf7974e6307b06113c68","user":{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars.githubusercontent.com/u/11657829?v=3","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"repo":{"id":66579135,"name":"origin","full_name":"ravisantoshgudimetla/origin","owner":{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars.githubusercontent.com/u/11657829?v=3","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravisantoshgudimetla/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/ravisantoshgudimetla/origin","forks_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/forks","keys_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/teams","hooks_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/hooks","issue_events_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/issues/events{/number}","events_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/events","assignees_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/assignees{/user}","branches_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/branches{/branch}","tags_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/tags","blobs_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/languages","stargazers_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/stargazers","contributors_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/contributors","subscribers_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/subscribers","subscription_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/subscription","commits_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/contents/{+path}","compare_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/merges","archive_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/downloads","issues_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/issues{/number}","pulls_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/labels{/name}","releases_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/releases{/id}","deployments_url":"https://api.github.com/repos/ravisantoshgudimetla/origin/deployments","created_at":"2016-08-25T17:30:23Z","updated_at":"2016-08-25T17:30:32Z","pushed_at":"2016-09-08T02:51:00Z","git_url":"git://github.com/ravisantoshgudimetla/origin.git","ssh_url":"git@github.com:ravisantoshgudimetla/origin.git","clone_url":"https://github.com/ravisantoshgudimetla/origin.git","svn_url":"https://github.com/ravisantoshgudimetla/origin","homepage":"http://www.openshift.org","size":330596,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e7c15020d2efa85f54396b8aca247429f32df5fc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-09-08T07:49:32Z","pushed_at":"2016-09-08T16:49:42Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":587479,"stargazers_count":1678,"watchers_count":1678,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1078,"mirror_url":null,"open_issues_count":1138,"forks":1078,"open_issues":1138,"watchers":1678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10766"},"html":{"href":"https://github.com/openshift/origin/pull/10766"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10766"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10766/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10766/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10766/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/aaba79430e69c08eba2ccf7974e6307b06113c68"}}}}
{"actor":{"display_login":"ravisantoshgudimetla"}}