{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments/59794386","id":59794386,"diff_hunk":"@@ -210,16 +227,26 @@ func (plugin *ovsPlugin) SetUpPod(namespace string, name string, id kubeletTypes\n \t\treturn err\n \t}\n \n-\tout, err := utilexec.New().Command(plugin.getExecutable(), setUpCmd, string(id), vnidstr, ingressStr, egressStr, fmt.Sprintf(\"%t\", macvlan)).CombinedOutput()\n+\tout, err := exec.Command(plugin.getExecutable(), setUpCmd, string(id), vnidstr, ingressStr, egressStr, fmt.Sprintf(\"%t\", macvlan)).CombinedOutput()\n \tglog.V(5).Infof(\"SetUpPod network plugin output: %s, %v\", string(out), err)\n-\treturn err\n+\n+\tif isScriptError(err) {\n+\t\treturn fmt.Errorf(\"Error running network setup script: %s\", getScriptError(out))","path":"plugins/osdn/ovs/plugin.go","position":51,"original_position":51,"commit_id":"1cb07c75c57fe6311192434947e486617be206ed","original_commit_id":"1cb07c75c57fe6311192434947e486617be206ed","user":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars.githubusercontent.com/u/1258630?v=3","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"body":"Can you also include pod name and namespace in the error msg? I think that will be useful.","created_at":"2016-04-14T21:23:23Z","updated_at":"2016-04-14T21:23:23Z","html_url":"https://github.com/openshift/openshift-sdn/pull/295#discussion_r59794386","pull_request_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments/59794386"},"html":{"href":"https://github.com/openshift/openshift-sdn/pull/295#discussion_r59794386"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295","id":66504363,"html_url":"https://github.com/openshift/openshift-sdn/pull/295","diff_url":"https://github.com/openshift/openshift-sdn/pull/295.diff","patch_url":"https://github.com/openshift/openshift-sdn/pull/295.patch","issue_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/295","number":295,"state":"open","locked":false,"title":"Return better errors from SetUpPod/TearDownPod","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"Fixes #290 \r\n@openshift/networking PTAL","created_at":"2016-04-14T15:28:07Z","updated_at":"2016-04-14T21:23:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e5b5482602fa37c98a2596866366e7db6b51318","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/295/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-sdn/statuses/1cb07c75c57fe6311192434947e486617be206ed","head":{"label":"danwinship:better-setuppod-errors","ref":"better-setuppod-errors","sha":"1cb07c75c57fe6311192434947e486617be206ed","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"repo":{"id":47194172,"name":"openshift-sdn","full_name":"danwinship/openshift-sdn","owner":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danwinship/openshift-sdn","description":"","fork":true,"url":"https://api.github.com/repos/danwinship/openshift-sdn","forks_url":"https://api.github.com/repos/danwinship/openshift-sdn/forks","keys_url":"https://api.github.com/repos/danwinship/openshift-sdn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danwinship/openshift-sdn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danwinship/openshift-sdn/teams","hooks_url":"https://api.github.com/repos/danwinship/openshift-sdn/hooks","issue_events_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues/events{/number}","events_url":"https://api.github.com/repos/danwinship/openshift-sdn/events","assignees_url":"https://api.github.com/repos/danwinship/openshift-sdn/assignees{/user}","branches_url":"https://api.github.com/repos/danwinship/openshift-sdn/branches{/branch}","tags_url":"https://api.github.com/repos/danwinship/openshift-sdn/tags","blobs_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/refs{/sha}","trees_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danwinship/openshift-sdn/statuses/{sha}","languages_url":"https://api.github.com/repos/danwinship/openshift-sdn/languages","stargazers_url":"https://api.github.com/repos/danwinship/openshift-sdn/stargazers","contributors_url":"https://api.github.com/repos/danwinship/openshift-sdn/contributors","subscribers_url":"https://api.github.com/repos/danwinship/openshift-sdn/subscribers","subscription_url":"https://api.github.com/repos/danwinship/openshift-sdn/subscription","commits_url":"https://api.github.com/repos/danwinship/openshift-sdn/commits{/sha}","git_commits_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/commits{/sha}","comments_url":"https://api.github.com/repos/danwinship/openshift-sdn/comments{/number}","issue_comment_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues/comments{/number}","contents_url":"https://api.github.com/repos/danwinship/openshift-sdn/contents/{+path}","compare_url":"https://api.github.com/repos/danwinship/openshift-sdn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danwinship/openshift-sdn/merges","archive_url":"https://api.github.com/repos/danwinship/openshift-sdn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danwinship/openshift-sdn/downloads","issues_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues{/number}","pulls_url":"https://api.github.com/repos/danwinship/openshift-sdn/pulls{/number}","milestones_url":"https://api.github.com/repos/danwinship/openshift-sdn/milestones{/number}","notifications_url":"https://api.github.com/repos/danwinship/openshift-sdn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danwinship/openshift-sdn/labels{/name}","releases_url":"https://api.github.com/repos/danwinship/openshift-sdn/releases{/id}","deployments_url":"https://api.github.com/repos/danwinship/openshift-sdn/deployments","created_at":"2015-12-01T14:21:16Z","updated_at":"2015-12-01T14:21:17Z","pushed_at":"2016-04-14T15:27:40Z","git_url":"git://github.com/danwinship/openshift-sdn.git","ssh_url":"git@github.com:danwinship/openshift-sdn.git","clone_url":"https://github.com/danwinship/openshift-sdn.git","svn_url":"https://github.com/danwinship/openshift-sdn","homepage":null,"size":706,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5106c5ab4c3b981c55176ce88684a1ab1d031e92","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":29500061,"name":"openshift-sdn","full_name":"openshift/openshift-sdn","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-sdn","description":"","fork":false,"url":"https://api.github.com/repos/openshift/openshift-sdn","forks_url":"https://api.github.com/repos/openshift/openshift-sdn/forks","keys_url":"https://api.github.com/repos/openshift/openshift-sdn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-sdn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-sdn/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-sdn/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-sdn/events","assignees_url":"https://api.github.com/repos/openshift/openshift-sdn/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-sdn/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-sdn/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-sdn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-sdn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-sdn/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-sdn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-sdn/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-sdn/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-sdn/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-sdn/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-sdn/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-sdn/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-sdn/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-sdn/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-sdn/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-sdn/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-sdn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-sdn/merges","archive_url":"https://api.github.com/repos/openshift/openshift-sdn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-sdn/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-sdn/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-sdn/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-sdn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-sdn/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-sdn/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-sdn/deployments","created_at":"2015-01-19T22:32:20Z","updated_at":"2016-04-11T03:37:59Z","pushed_at":"2016-04-14T18:46:29Z","git_url":"git://github.com/openshift/openshift-sdn.git","ssh_url":"git@github.com:openshift/openshift-sdn.git","clone_url":"https://github.com/openshift/openshift-sdn.git","svn_url":"https://github.com/openshift/openshift-sdn","homepage":null,"size":1010,"stargazers_count":39,"watchers_count":39,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":19,"forks":35,"open_issues":19,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295"},"html":{"href":"https://github.com/openshift/openshift-sdn/pull/295"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-sdn/issues/295"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-sdn/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-sdn/statuses/1cb07c75c57fe6311192434947e486617be206ed"}}}}