{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/luigi/issues/1799","repository_url":"https://api.github.com/repos/spotify/luigi","labels_url":"https://api.github.com/repos/spotify/luigi/issues/1799/labels{/name}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/1799/comments","events_url":"https://api.github.com/repos/spotify/luigi/issues/1799/events","html_url":"https://github.com/spotify/luigi/pull/1799","id":168720816,"number":1799,"title":"Added NumericalParameter Parameter class that does automatic error ch…","user":{"login":"brcopeland","id":13629943,"avatar_url":"https://avatars.githubusercontent.com/u/13629943?v=3","gravatar_id":"","url":"https://api.github.com/users/brcopeland","html_url":"https://github.com/brcopeland","followers_url":"https://api.github.com/users/brcopeland/followers","following_url":"https://api.github.com/users/brcopeland/following{/other_user}","gists_url":"https://api.github.com/users/brcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/brcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brcopeland/subscriptions","organizations_url":"https://api.github.com/users/brcopeland/orgs","repos_url":"https://api.github.com/users/brcopeland/repos","events_url":"https://api.github.com/users/brcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/brcopeland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-08-01T19:19:47Z","updated_at":"2016-08-04T19:03:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/1799","html_url":"https://github.com/spotify/luigi/pull/1799","diff_url":"https://github.com/spotify/luigi/pull/1799.diff","patch_url":"https://github.com/spotify/luigi/pull/1799.patch"},"body":"<!--- This template is optional. Please use it as a starting point to help guide PRs -->\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nAdded a new Parameter class, NumericalParameter, that validates that the specified input parameter, an int or float, is in the specified range.  The comparison functions, i.e. <= or < may be overridden, and the min and max values are adjustable.\r\n\r\n## Motivation and Context\r\nThis Parameter type is helpful to reduce repetitive code, such as repeatedly checking that various input numeric parameters are in the permissible ranges.  I argue it is also cleaner to specify the constraints on the parameter when it is defined in a Task class.\r\n\r\n## Have you tested this? If so, how?\r\nI've been using this class for several weeks successfully."},"comment":{"url":"https://api.github.com/repos/spotify/luigi/issues/comments/237651213","html_url":"https://github.com/spotify/luigi/pull/1799#issuecomment-237651213","issue_url":"https://api.github.com/repos/spotify/luigi/issues/1799","id":237651213,"user":{"login":"brcopeland","id":13629943,"avatar_url":"https://avatars.githubusercontent.com/u/13629943?v=3","gravatar_id":"","url":"https://api.github.com/users/brcopeland","html_url":"https://github.com/brcopeland","followers_url":"https://api.github.com/users/brcopeland/followers","following_url":"https://api.github.com/users/brcopeland/following{/other_user}","gists_url":"https://api.github.com/users/brcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/brcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brcopeland/subscriptions","organizations_url":"https://api.github.com/users/brcopeland/orgs","repos_url":"https://api.github.com/users/brcopeland/repos","events_url":"https://api.github.com/users/brcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/brcopeland/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T19:03:02Z","updated_at":"2016-08-04T19:03:02Z","body":"I added hashability and serialize/parse tests that work properly.  I haven't personally used a `luigi.cfg` before, but I assume it would be like any other parameter, e.g. `MyNumericalParameter=5`.  Any reason to think otherwise?"}}
{"actor":{"display_login":"brcopeland"}}