{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/85264700","pull_request_review_id":5989818,"id":85264700,"diff_hunk":"@@ -99,9 +99,13 @@\n   post '/api/academics/canvas/mailing_lists/:canvas_course_id/delete' => 'canvas_mailing_lists#destroy', :defaults => { :format => 'json' }\n \n   # OEC endpoints\n-  get '/api/oec_tasks' => 'oec_tasks#index', :defaults => { :format => 'json' }\n-  post '/api/oec_tasks/:task_name' => 'oec_tasks#run', :defaults => { :format => 'json' }\n-  get '/api/oec_tasks/status/:task_id' => 'oec_tasks#task_status',  :defaults => { :format => 'json' }\n+  get '/api/oec/google/request_authorization'=> 'oec_google_auth#refresh_tokens', :defaults => { :format => 'json' }\n+  get '/api/oec/google/handle_callback' => 'oec_google_auth#handle_callback', :defaults => { :format => 'json' }\n+  get '/api/oec/google/current_scope' => 'oec_google_auth#current_scope', :defaults => { :format => 'json' }\n+  get '/api/google/remove_authorization' => 'oec_google_auth#remove_authorization', :via => :post","path":"config/routes.rb","position":10,"original_position":10,"commit_id":"6ab097604c8cf777cfc74fffa6f4ce93e32f7221","original_commit_id":"6ab097604c8cf777cfc74fffa6f4ce93e32f7221","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"body":"@johncrossman 1) should this be `/api/oec/google/remove_authorization`? 2) should it start with `post`?","created_at":"2016-10-27T04:35:40Z","updated_at":"2016-10-27T04:43:39Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6071#discussion_r85264700","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/85264700"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6071#discussion_r85264700"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071","id":91113481,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6071","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6071.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6071.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6071","number":6071,"state":"open","locked":false,"title":"CLC-6478, GoogleAuthController variant to manage OEC-specific Google tokens","user":{"login":"johncrossman","id":7606442,"avatar_url":"https://avatars.githubusercontent.com/u/7606442?v=3","gravatar_id":"","url":"https://api.github.com/users/johncrossman","html_url":"https://github.com/johncrossman","followers_url":"https://api.github.com/users/johncrossman/followers","following_url":"https://api.github.com/users/johncrossman/following{/other_user}","gists_url":"https://api.github.com/users/johncrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/johncrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johncrossman/subscriptions","organizations_url":"https://api.github.com/users/johncrossman/orgs","repos_url":"https://api.github.com/users/johncrossman/repos","events_url":"https://api.github.com/users/johncrossman/events{/privacy}","received_events_url":"https://api.github.com/users/johncrossman/received_events","type":"User","site_admin":false},"body":"https://jira.ets.berkeley.edu/jira/browse/CLC-6478\r\n\r\nThis is the first half of the CLC-6478 story. The logic of `GoogleAuthController` was moved to a the reusable model `GoogleApps::Oauth2TokensGrant`. Next, a dedicated OEC controller was added, with stricter access rules, that allows the same kind of token management.\r\n\r\nA lot more test coverage.\r\n\r\nThe next step will be removal OEC's client_id and client_secret from YAML.","created_at":"2016-10-27T00:24:16Z","updated_at":"2016-10-27T04:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74456e71f07a66f1855c0363457655ff0ca13864","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6071/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/6ab097604c8cf777cfc74fffa6f4ce93e32f7221","head":{"label":"johncrossman:CLC-6478_oec-google-controller","ref":"CLC-6478_oec-google-controller","sha":"6ab097604c8cf777cfc74fffa6f4ce93e32f7221","user":{"login":"johncrossman","id":7606442,"avatar_url":"https://avatars.githubusercontent.com/u/7606442?v=3","gravatar_id":"","url":"https://api.github.com/users/johncrossman","html_url":"https://github.com/johncrossman","followers_url":"https://api.github.com/users/johncrossman/followers","following_url":"https://api.github.com/users/johncrossman/following{/other_user}","gists_url":"https://api.github.com/users/johncrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/johncrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johncrossman/subscriptions","organizations_url":"https://api.github.com/users/johncrossman/orgs","repos_url":"https://api.github.com/users/johncrossman/repos","events_url":"https://api.github.com/users/johncrossman/events{/privacy}","received_events_url":"https://api.github.com/users/johncrossman/received_events","type":"User","site_admin":false},"repo":{"id":23628046,"name":"calcentral","full_name":"johncrossman/calcentral","owner":{"login":"johncrossman","id":7606442,"avatar_url":"https://avatars.githubusercontent.com/u/7606442?v=3","gravatar_id":"","url":"https://api.github.com/users/johncrossman","html_url":"https://github.com/johncrossman","followers_url":"https://api.github.com/users/johncrossman/followers","following_url":"https://api.github.com/users/johncrossman/following{/other_user}","gists_url":"https://api.github.com/users/johncrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/johncrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johncrossman/subscriptions","organizations_url":"https://api.github.com/users/johncrossman/orgs","repos_url":"https://api.github.com/users/johncrossman/repos","events_url":"https://api.github.com/users/johncrossman/events{/privacy}","received_events_url":"https://api.github.com/users/johncrossman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johncrossman/calcentral","description":null,"fork":true,"url":"https://api.github.com/repos/johncrossman/calcentral","forks_url":"https://api.github.com/repos/johncrossman/calcentral/forks","keys_url":"https://api.github.com/repos/johncrossman/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johncrossman/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johncrossman/calcentral/teams","hooks_url":"https://api.github.com/repos/johncrossman/calcentral/hooks","issue_events_url":"https://api.github.com/repos/johncrossman/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/johncrossman/calcentral/events","assignees_url":"https://api.github.com/repos/johncrossman/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/johncrossman/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/johncrossman/calcentral/tags","blobs_url":"https://api.github.com/repos/johncrossman/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johncrossman/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johncrossman/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/johncrossman/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johncrossman/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/johncrossman/calcentral/languages","stargazers_url":"https://api.github.com/repos/johncrossman/calcentral/stargazers","contributors_url":"https://api.github.com/repos/johncrossman/calcentral/contributors","subscribers_url":"https://api.github.com/repos/johncrossman/calcentral/subscribers","subscription_url":"https://api.github.com/repos/johncrossman/calcentral/subscription","commits_url":"https://api.github.com/repos/johncrossman/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/johncrossman/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/johncrossman/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/johncrossman/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/johncrossman/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/johncrossman/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johncrossman/calcentral/merges","archive_url":"https://api.github.com/repos/johncrossman/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johncrossman/calcentral/downloads","issues_url":"https://api.github.com/repos/johncrossman/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/johncrossman/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/johncrossman/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/johncrossman/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johncrossman/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/johncrossman/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/johncrossman/calcentral/deployments","created_at":"2014-09-03T16:25:09Z","updated_at":"2015-05-07T16:57:25Z","pushed_at":"2016-10-27T03:25:13Z","git_url":"git://github.com/johncrossman/calcentral.git","ssh_url":"git@github.com:johncrossman/calcentral.git","clone_url":"https://github.com/johncrossman/calcentral.git","svn_url":"https://github.com/johncrossman/calcentral","homepage":"https://calcentral.berkeley.edu","size":26738,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"canvasfix"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"1d51626ce035015c01f61b9cd03ea6d1d156cb93","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":null,"fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2016-10-26T13:03:06Z","pushed_at":"2016-10-27T04:26:43Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":30862,"stargazers_count":67,"watchers_count":67,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":5,"forks":65,"open_issues":5,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6071"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6071"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6071/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6071/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/6ab097604c8cf777cfc74fffa6f4ce93e32f7221"}}}}
{"actor":{"display_login":"paulkerschen"}}