{"action":"created","issue":{"url":"https://api.github.com/repos/pymedusa/SickRage/issues/740","repository_url":"https://api.github.com/repos/pymedusa/SickRage","labels_url":"https://api.github.com/repos/pymedusa/SickRage/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/pymedusa/SickRage/issues/740/comments","events_url":"https://api.github.com/repos/pymedusa/SickRage/issues/740/events","html_url":"https://github.com/pymedusa/SickRage/pull/740","id":164205760,"number":740,"title":"Fix proper search for NZB","user":{"login":"fernandog","id":2620870,"avatar_url":"https://avatars.githubusercontent.com/u/2620870?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandog","html_url":"https://github.com/fernandog","followers_url":"https://api.github.com/users/fernandog/followers","following_url":"https://api.github.com/users/fernandog/following{/other_user}","gists_url":"https://api.github.com/users/fernandog/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandog/subscriptions","organizations_url":"https://api.github.com/users/fernandog/orgs","repos_url":"https://api.github.com/users/fernandog/repos","events_url":"https://api.github.com/users/fernandog/events{/privacy}","received_events_url":"https://api.github.com/users/fernandog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pymedusa/SickRage/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/pymedusa/SickRage/labels/concluded","name":"concluded","color":"207de5"},{"url":"https://api.github.com/repos/pymedusa/SickRage/labels/Needs%20review","name":"Needs review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-07T00:41:16Z","updated_at":"2016-07-07T16:44:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pymedusa/SickRage/pulls/740","html_url":"https://github.com/pymedusa/SickRage/pull/740","diff_url":"https://github.com/pymedusa/SickRage/pull/740.diff","patch_url":"https://github.com/pymedusa/SickRage/pull/740.patch"},"body":"Without this, FINDPROPER with NZB providers were not doing \"Search mode: episode\" with search string with show+episode that needed to be searched for propers\r\n\r\nRelated to issue: https://github.com/pymedusa/SickRage/pull/740\r\nWe dont have \"GET URL\" because it isn't doing any kind of query in NZB providers\r\n\r\nTODO:\r\n- [x] NZB search is using `tvdbid` when it should use `q` parameter to search for \"The Musketeers S03E09 PROPER|REPACK|REAL\" - the propers strings\r\n- [x] Maybe replace the `find_proper` in GenericProvider with the one that exists in torrentprovider and remove `find_propers` from torrent and nzb provider files\r\n\r\nAbout PROPER search detection in newsnab.py:\r\n```\r\n>>> 'PROPER|REPACK|REAL' in 'The Real Housewives S02E03'\r\nFalse\r\n>>> 'PROPER|REPACK|REAL' in 'The Real Housewives S02E03 PROPER|REPACK|REAL'\r\nTrue\r\n```\r\n\r\n## Before:\r\n\r\nnzb:\r\n```\r\n2016-07-06 20:19:04 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Found new proper result: Quantico.S01E17.PROPER.HDTV.x264-BATV\r\n2016-07-06 20:19:04 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Found new proper result: Quantico.S01E17.PROPER.HDTV.x264-BATV-Obfuscated\r\n2016-07-06 20:19:04 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Found new proper result: Quantico.S01E17.PROPER.720p.HDTV.x264-BATV\r\n2016-07-06 20:19:04 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Found new proper result: Quantico.S01E17.PROPER.720p.HDTV.x264-BATV-Obfuscated\r\n2016-07-06 20:19:04 INFO     FINDPROPERS :: [NZBGeek] :: [42fd472] Searching for any new PROPER releases from NZBGeek\r\n```\r\n\r\ntorrent:\r\n```\r\n2016-07-06 20:18:47 DEBUG    FINDPROPERS :: [ThePirateBay] :: [42fd472] Search string: The Musketeers S03E06 PROPER|REPACK|REAL\r\n2016-07-06 20:18:47 DEBUG    FINDPROPERS :: [ThePirateBay] :: [42fd472] Search mode: Episode\r\n2016-07-06 20:18:47 INFO     FINDPROPERS :: [ThePirateBay] :: [42fd472] Searching for any new PROPER releases from ThePirateBay\r\n```\r\n\r\n## After:\r\n\r\n```\r\n2016-07-06 21:26:49 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Found result: The.Musketeers.S03E09.1080p.WEB-DL.AAC2.0.H.264-ViSUM-Obfuscated with -1 seeders and -1 leechers\r\n2016-07-06 21:26:49 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] GET URL: https://api.nzbgeek.info/api?apikey=**********&tvdbid=269159&season=3&maxage=300&cat=5030%2C5040&limit=100&t=tvsearch&offset=0&ep=9 [Status: 200]\r\n2016-07-06 21:26:42 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Search string: The Musketeers S03E09 PROPER|REPACK|REAL\r\n2016-07-06 21:26:42 DEBUG    FINDPROPERS :: [NZBGeek] :: [42fd472] Search mode: Episode\r\n```"},"comment":{"url":"https://api.github.com/repos/pymedusa/SickRage/issues/comments/231137334","html_url":"https://github.com/pymedusa/SickRage/pull/740#issuecomment-231137334","issue_url":"https://api.github.com/repos/pymedusa/SickRage/issues/740","id":231137334,"user":{"login":"p0psicles","id":1331394,"avatar_url":"https://avatars.githubusercontent.com/u/1331394?v=3","gravatar_id":"","url":"https://api.github.com/users/p0psicles","html_url":"https://github.com/p0psicles","followers_url":"https://api.github.com/users/p0psicles/followers","following_url":"https://api.github.com/users/p0psicles/following{/other_user}","gists_url":"https://api.github.com/users/p0psicles/gists{/gist_id}","starred_url":"https://api.github.com/users/p0psicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0psicles/subscriptions","organizations_url":"https://api.github.com/users/p0psicles/orgs","repos_url":"https://api.github.com/users/p0psicles/repos","events_url":"https://api.github.com/users/p0psicles/events{/privacy}","received_events_url":"https://api.github.com/users/p0psicles/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T16:44:51Z","updated_at":"2016-07-07T16:44:51Z","body":"Okay, interesting. I'm going to free up some time for this. I was also looking into how the proper searching is working. Even started on created a small flowchart. Will look further into these PR's. But please refrain from putting anymore commits in them. Or at least for this one. Then I have the time to properly test them."}}
{"actor":{"display_login":"p0psicles"}}