{"action":"created","issue":{"url":"https://api.github.com/repos/docker/libcompose/issues/163","repository_url":"https://api.github.com/repos/docker/libcompose","labels_url":"https://api.github.com/repos/docker/libcompose/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/docker/libcompose/issues/163/comments","events_url":"https://api.github.com/repos/docker/libcompose/issues/163/events","html_url":"https://github.com/docker/libcompose/pull/163","id":137232999,"number":163,"title":"Supporting logger factories for image build and pulls","user":{"login":"bfosberry","id":1553039,"avatar_url":"https://avatars.githubusercontent.com/u/1553039?v=3","gravatar_id":"","url":"https://api.github.com/users/bfosberry","html_url":"https://github.com/bfosberry","followers_url":"https://api.github.com/users/bfosberry/followers","following_url":"https://api.github.com/users/bfosberry/following{/other_user}","gists_url":"https://api.github.com/users/bfosberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bfosberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfosberry/subscriptions","organizations_url":"https://api.github.com/users/bfosberry/orgs","repos_url":"https://api.github.com/users/bfosberry/repos","events_url":"https://api.github.com/users/bfosberry/events{/privacy}","received_events_url":"https://api.github.com/users/bfosberry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/libcompose/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/libcompose/milestones/4","html_url":"https://github.com/docker/libcompose/milestones/0.3.0%20Admiring%20Murdock","labels_url":"https://api.github.com/repos/docker/libcompose/milestones/4/labels","id":1667694,"number":4,"title":"0.3.0 Admiring Murdock","description":"https://github.com/docker/libcompose/wiki/0.3.0-Milestone-Project-Page","creator":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":69,"state":"open","created_at":"2016-03-27T18:38:57Z","updated_at":"2016-06-27T21:35:19Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2016-02-29T11:53:32Z","updated_at":"2016-06-28T06:02:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/libcompose/pulls/163","html_url":"https://github.com/docker/libcompose/pull/163","diff_url":"https://github.com/docker/libcompose/pull/163.diff","patch_url":"https://github.com/docker/libcompose/pull/163.patch"},"body":"This change updates how the container and builder write logs from docker, to use a provided LoggerFactory. This currently uses the following assumptions\r\n\r\n1) Container loggers are requested using the format $PROJECTNAME_$SERVICENAME_$INSTANCENUM, eg myproject_app_1 as per the compose container name format.\r\n2) Image build loggers are requested using the service name\r\n3) Image pull loggers are requested using the image name\r\n\r\nThe problem with this is that it's highly likely someone would use the same image and service name, e.g. the redis service uses the image redis. \r\n\r\nPossible solutions:\r\n\r\n* Using different logger factories for the different types of loggers\r\n* Extending the logger factory interface to request different types of loggers\r\n\r\nthoughts?"},"comment":{"url":"https://api.github.com/repos/docker/libcompose/issues/comments/228956413","html_url":"https://github.com/docker/libcompose/pull/163#issuecomment-228956413","issue_url":"https://api.github.com/repos/docker/libcompose/issues/163","id":228956413,"user":{"login":"bfosberry","id":1553039,"avatar_url":"https://avatars.githubusercontent.com/u/1553039?v=3","gravatar_id":"","url":"https://api.github.com/users/bfosberry","html_url":"https://github.com/bfosberry","followers_url":"https://api.github.com/users/bfosberry/followers","following_url":"https://api.github.com/users/bfosberry/following{/other_user}","gists_url":"https://api.github.com/users/bfosberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bfosberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfosberry/subscriptions","organizations_url":"https://api.github.com/users/bfosberry/orgs","repos_url":"https://api.github.com/users/bfosberry/repos","events_url":"https://api.github.com/users/bfosberry/events{/privacy}","received_events_url":"https://api.github.com/users/bfosberry/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T06:02:48Z","updated_at":"2016-06-28T06:02:48Z","body":"I think it looks good now!"}}
{"actor":{"display_login":"bfosberry"}}