{"action":"opened","number":33,"pull_request":{"url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33","id":74701517,"html_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/33","diff_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/33.diff","patch_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/33.patch","issue_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/33","number":33,"state":"open","locked":false,"title":"Remove `require('crypto')` in sjcl for Cordova --browerify","user":{"login":"yyfearth","id":604140,"avatar_url":"https://avatars.githubusercontent.com/u/604140?v=3","gravatar_id":"","url":"https://api.github.com/users/yyfearth","html_url":"https://github.com/yyfearth","followers_url":"https://api.github.com/users/yyfearth/followers","following_url":"https://api.github.com/users/yyfearth/following{/other_user}","gists_url":"https://api.github.com/users/yyfearth/gists{/gist_id}","starred_url":"https://api.github.com/users/yyfearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyfearth/subscriptions","organizations_url":"https://api.github.com/users/yyfearth/orgs","repos_url":"https://api.github.com/users/yyfearth/repos","events_url":"https://api.github.com/users/yyfearth/events{/privacy}","received_events_url":"https://api.github.com/users/yyfearth/received_events","type":"User","site_admin":false},"body":"cordova --browserify will pack all js files of plugins into the cordova.js file.\r\nBut during browerify, since the sjcl_ss.js has `require('crypto')`, which result in a huge node-crypto polyfill will be added into the cordova.js bundle.\r\nSince we already decided to remove this file sooner or later, I think it is fine to just modify it a little, to make it works better for the --browserify flag","created_at":"2016-06-21T23:16:00Z","updated_at":"2016-06-21T23:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8e6f1377464d657a0c6a3f1ccfb6927faf0c8fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/33/comments","statuses_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/0faf721219c416114b2abef7186968998c778d2a","head":{"label":"yyfearth:master","ref":"master","sha":"0faf721219c416114b2abef7186968998c778d2a","user":{"login":"yyfearth","id":604140,"avatar_url":"https://avatars.githubusercontent.com/u/604140?v=3","gravatar_id":"","url":"https://api.github.com/users/yyfearth","html_url":"https://github.com/yyfearth","followers_url":"https://api.github.com/users/yyfearth/followers","following_url":"https://api.github.com/users/yyfearth/following{/other_user}","gists_url":"https://api.github.com/users/yyfearth/gists{/gist_id}","starred_url":"https://api.github.com/users/yyfearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyfearth/subscriptions","organizations_url":"https://api.github.com/users/yyfearth/orgs","repos_url":"https://api.github.com/users/yyfearth/repos","events_url":"https://api.github.com/users/yyfearth/events{/privacy}","received_events_url":"https://api.github.com/users/yyfearth/received_events","type":"User","site_admin":false},"repo":{"id":58235990,"name":"cordova-plugin-secure-storage","full_name":"yyfearth/cordova-plugin-secure-storage","owner":{"login":"yyfearth","id":604140,"avatar_url":"https://avatars.githubusercontent.com/u/604140?v=3","gravatar_id":"","url":"https://api.github.com/users/yyfearth","html_url":"https://github.com/yyfearth","followers_url":"https://api.github.com/users/yyfearth/followers","following_url":"https://api.github.com/users/yyfearth/following{/other_user}","gists_url":"https://api.github.com/users/yyfearth/gists{/gist_id}","starred_url":"https://api.github.com/users/yyfearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyfearth/subscriptions","organizations_url":"https://api.github.com/users/yyfearth/orgs","repos_url":"https://api.github.com/users/yyfearth/repos","events_url":"https://api.github.com/users/yyfearth/events{/privacy}","received_events_url":"https://api.github.com/users/yyfearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyfearth/cordova-plugin-secure-storage","description":"SecureStorage plugin for iOS & Android","fork":true,"url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage","forks_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/forks","keys_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/teams","hooks_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/hooks","issue_events_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/issues/events{/number}","events_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/events","assignees_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/assignees{/user}","branches_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/branches{/branch}","tags_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/tags","blobs_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/languages","stargazers_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/stargazers","contributors_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/contributors","subscribers_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/subscribers","subscription_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/subscription","commits_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/contents/{+path}","compare_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/merges","archive_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/downloads","issues_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/issues{/number}","pulls_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/labels{/name}","releases_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/releases{/id}","deployments_url":"https://api.github.com/repos/yyfearth/cordova-plugin-secure-storage/deployments","created_at":"2016-05-06T21:31:16Z","updated_at":"2016-05-06T21:31:31Z","pushed_at":"2016-06-21T01:00:01Z","git_url":"git://github.com/yyfearth/cordova-plugin-secure-storage.git","ssh_url":"git@github.com:yyfearth/cordova-plugin-secure-storage.git","clone_url":"https://github.com/yyfearth/cordova-plugin-secure-storage.git","svn_url":"https://github.com/yyfearth/cordova-plugin-secure-storage","homepage":"","size":85,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Crypho:master","ref":"master","sha":"829c2fbaf1e326b9d3167a7bb9c3864e1b1c0503","user":{"login":"Crypho","id":2860957,"avatar_url":"https://avatars.githubusercontent.com/u/2860957?v=3","gravatar_id":"","url":"https://api.github.com/users/Crypho","html_url":"https://github.com/Crypho","followers_url":"https://api.github.com/users/Crypho/followers","following_url":"https://api.github.com/users/Crypho/following{/other_user}","gists_url":"https://api.github.com/users/Crypho/gists{/gist_id}","starred_url":"https://api.github.com/users/Crypho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crypho/subscriptions","organizations_url":"https://api.github.com/users/Crypho/orgs","repos_url":"https://api.github.com/users/Crypho/repos","events_url":"https://api.github.com/users/Crypho/events{/privacy}","received_events_url":"https://api.github.com/users/Crypho/received_events","type":"Organization","site_admin":false},"repo":{"id":32869407,"name":"cordova-plugin-secure-storage","full_name":"Crypho/cordova-plugin-secure-storage","owner":{"login":"Crypho","id":2860957,"avatar_url":"https://avatars.githubusercontent.com/u/2860957?v=3","gravatar_id":"","url":"https://api.github.com/users/Crypho","html_url":"https://github.com/Crypho","followers_url":"https://api.github.com/users/Crypho/followers","following_url":"https://api.github.com/users/Crypho/following{/other_user}","gists_url":"https://api.github.com/users/Crypho/gists{/gist_id}","starred_url":"https://api.github.com/users/Crypho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crypho/subscriptions","organizations_url":"https://api.github.com/users/Crypho/orgs","repos_url":"https://api.github.com/users/Crypho/repos","events_url":"https://api.github.com/users/Crypho/events{/privacy}","received_events_url":"https://api.github.com/users/Crypho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Crypho/cordova-plugin-secure-storage","description":"Secure storage plugin for iOS & Android","fork":false,"url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage","forks_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/forks","keys_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/teams","hooks_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/hooks","issue_events_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/events{/number}","events_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/events","assignees_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/assignees{/user}","branches_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/branches{/branch}","tags_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/tags","blobs_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/languages","stargazers_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/stargazers","contributors_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/contributors","subscribers_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/subscribers","subscription_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/subscription","commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/contents/{+path}","compare_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/merges","archive_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/downloads","issues_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues{/number}","pulls_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/labels{/name}","releases_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/releases{/id}","deployments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/deployments","created_at":"2015-03-25T14:24:08Z","updated_at":"2016-06-21T20:06:14Z","pushed_at":"2016-06-16T08:01:44Z","git_url":"git://github.com/Crypho/cordova-plugin-secure-storage.git","ssh_url":"git@github.com:Crypho/cordova-plugin-secure-storage.git","clone_url":"https://github.com/Crypho/cordova-plugin-secure-storage.git","svn_url":"https://github.com/Crypho/cordova-plugin-secure-storage","homepage":"","size":115,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":2,"forks":32,"open_issues":2,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33"},"html":{"href":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/33"},"issue":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/33"},"comments":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/0faf721219c416114b2abef7186968998c778d2a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"yyfearth"}}