{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/gax-java/issues/113","repository_url":"https://api.github.com/repos/googleapis/gax-java","labels_url":"https://api.github.com/repos/googleapis/gax-java/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/gax-java/issues/113/comments","events_url":"https://api.github.com/repos/googleapis/gax-java/issues/113/events","html_url":"https://github.com/googleapis/gax-java/pull/113","id":179650387,"number":113,"title":"Add streaming support","user":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"assignees":[{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-09-28T00:22:31Z","updated_at":"2016-09-30T20:42:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-java/pulls/113","html_url":"https://github.com/googleapis/gax-java/pull/113","diff_url":"https://github.com/googleapis/gax-java/pull/113.diff","patch_url":"https://github.com/googleapis/gax-java/pull/113.patch"},"body":"cc/ @jmuk \r\n\r\n1. The following new streaming classes are added:\r\n  - StreamingApiCallable\r\n    - Public access\r\n    - Callable object which supports client/server/bidi streaming calls with the given channel\r\n  - StreamingCallable\r\n    - Package private (used by StreamingApiCallable)\r\n    - Bridge between gax to actual grpc streaming calls.\r\n  - StreamingCallSettings\r\n    - Public access\r\n    - Creates the StreamingAPICallable object for the method based on the MethodDescriptor object from the generated gRPC code \r\n\r\n2. The original non-streaming API callable/settings classes are renamed with “Unary” prefix to be distinguished from the new streaming classes:\r\n\r\n  - ApiCallable -> UnaryApiCallable\r\n  - ApiCallSettings -> UnaryApiCallSettings\r\n  - ApiCallSettingsTyped -> UnaryApiCallSettingsTyped\r\n\r\n3. Refactored CallContext class to only contain CallOptions and Channel. The benefits of this refactoring are:\r\n\r\n  - Remove the type parameter from CallContext to make the code cleaner.\r\n  - Share CallContext for both streaming and non-streaming API calls. \r\n\r\n4. Removed ChannelBindingCallable. Handles channel binding within UnaryApiCallable instead.\r\n"},"comment":{"url":"https://api.github.com/repos/googleapis/gax-java/issues/comments/250847451","html_url":"https://github.com/googleapis/gax-java/pull/113#issuecomment-250847451","issue_url":"https://api.github.com/repos/googleapis/gax-java/issues/113","id":250847451,"user":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T20:42:55Z","updated_at":"2016-09-30T20:42:55Z","body":"Version bump PR merged: https://github.com/googleapis/gax-java/pull/114"}}
{"actor":{"display_login":"shinfan"}}