{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1","repository_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs","labels_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/events","html_url":"https://github.com/rust-lang-nursery/fmt-rfcs/issues/1","id":152897365,"number":1,"title":"Line and indent width","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/labels/P-high","name":"P-high","color":"d93f0b"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":38,"created_at":"2016-05-03T23:28:27Z","updated_at":"2016-09-16T05:05:39Z","closed_at":null,"body":"Decide on the options and defaults for the maximum width of lines and indents.\r\n\r\nRustfmt currently has the following options:\r\n\r\n```\r\n    max_width: usize, 100, \"Maximum width of each line\";\r\n    ideal_width: usize, 80, \"Ideal width of each line\";\r\n    tab_spaces: usize, 4, \"Number of spaces per tab\";\r\n    hard_tabs: bool, false, \"Use tab characters for indentation, spaces for alignment\";\r\n```\r\n\r\nThe [style guide](https://github.com/rust-lang/rust/blob/master/src/doc/style/style/whitespace.md) specifies a maximum line width of 99 chars and 4 spaces (no tabs) for indentation. `make tidy` enforces 100 char width for the Rust repo.\r\n\r\nMostly these defaults seem reasonable. Points to discuss:\r\n\r\n* 99 or 100 char width,\r\n* 'ideal width' concept,\r\n* which options should remain,\r\n* names of options.\r\n\r\nNotes:\r\n\r\n* ideal width is not really used by rustfmt any more, in retrospect it was a bad idea. The only place it is used (I think) is for comments. I do think wrapping comments at 80 chars is nice, since reading prose is easier in narrower columns and the solid text of large comment blocks looks bad. It might be nice to keep the comment width at 80 and either remove the option to change it, or rename the option.\r\n* the 99 chars thing is to cope with diffs in 100 chars or newlines in terminals."},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/comments/247519099","html_url":"https://github.com/rust-lang-nursery/fmt-rfcs/issues/1#issuecomment-247519099","issue_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1","id":247519099,"user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T05:05:39Z","updated_at":"2016-09-16T05:05:39Z","body":"@nathansizemore Knowing that a new scope has been entered is important, of course, but 2 spaces is visual and mental break enough. A larger break has only downsides for me.\r\n\r\nSince I've recently realized that 2 spaces is still wide enough for Rust code to be clear to me, I'd love to take advantage of that and have narrower code."}}
{"actor":{"display_login":"solson"}}