{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/comments/57227335","id":57227335,"diff_hunk":"@@ -1087,7 +1095,7 @@ class IndexConsumer : public ASTConsumer,\n             text[i] != '\\t' && text[i] != '\\n')\n           text[i] = '?';\n       }\n-      recordValue(\"text\", text, true);\n+      macromap.insert(make_pair(nameStart, text));","path":"dxr/plugins/clang/dxr-index.cpp","position":33,"original_position":33,"commit_id":"b673e30b1d01a8a756e6a2fb69a36b6fa7b095cb","original_commit_id":"b673e30b1d01a8a756e6a2fb69a36b6fa7b095cb","user":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"body":"It seems like this will keep the full text of any macro body in memory forever. I'm not sure how that's going to go on something as big as Firefox, which can barely be compiled in a 7GB VM as is. What do you think?","created_at":"2016-03-23T20:05:35Z","updated_at":"2016-03-23T20:05:35Z","html_url":"https://github.com/mozilla/dxr/pull/518#discussion_r57227335","pull_request_url":"https://api.github.com/repos/mozilla/dxr/pulls/518","_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments/57227335"},"html":{"href":"https://github.com/mozilla/dxr/pull/518#discussion_r57227335"},"pull_request":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/518","id":61423881,"html_url":"https://github.com/mozilla/dxr/pull/518","diff_url":"https://github.com/mozilla/dxr/pull/518.diff","patch_url":"https://github.com/mozilla/dxr/pull/518.patch","issue_url":"https://api.github.com/repos/mozilla/dxr/issues/518","number":518,"state":"open","locked":false,"title":"Place clang macro definition tooltip on macro refs instead of macro def.","user":{"login":"kleintom","id":632915,"avatar_url":"https://avatars.githubusercontent.com/u/632915?v=3","gravatar_id":"","url":"https://api.github.com/users/kleintom","html_url":"https://github.com/kleintom","followers_url":"https://api.github.com/users/kleintom/followers","following_url":"https://api.github.com/users/kleintom/following{/other_user}","gists_url":"https://api.github.com/users/kleintom/gists{/gist_id}","starred_url":"https://api.github.com/users/kleintom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleintom/subscriptions","organizations_url":"https://api.github.com/users/kleintom/orgs","repos_url":"https://api.github.com/users/kleintom/repos","events_url":"https://api.github.com/users/kleintom/events{/privacy}","received_events_url":"https://api.github.com/users/kleintom/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-02T16:12:01Z","updated_at":"2016-03-23T20:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"450a386b4bfd95f57c8c921d1713d5bec8c5d355","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/dxr/pulls/518/commits","review_comments_url":"https://api.github.com/repos/mozilla/dxr/pulls/518/comments","review_comment_url":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/dxr/issues/518/comments","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/b673e30b1d01a8a756e6a2fb69a36b6fa7b095cb","head":{"label":"kleintom:macro_tooltip","ref":"macro_tooltip","sha":"b673e30b1d01a8a756e6a2fb69a36b6fa7b095cb","user":{"login":"kleintom","id":632915,"avatar_url":"https://avatars.githubusercontent.com/u/632915?v=3","gravatar_id":"","url":"https://api.github.com/users/kleintom","html_url":"https://github.com/kleintom","followers_url":"https://api.github.com/users/kleintom/followers","following_url":"https://api.github.com/users/kleintom/following{/other_user}","gists_url":"https://api.github.com/users/kleintom/gists{/gist_id}","starred_url":"https://api.github.com/users/kleintom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleintom/subscriptions","organizations_url":"https://api.github.com/users/kleintom/orgs","repos_url":"https://api.github.com/users/kleintom/repos","events_url":"https://api.github.com/users/kleintom/events{/privacy}","received_events_url":"https://api.github.com/users/kleintom/received_events","type":"User","site_admin":false},"repo":{"id":45321782,"name":"dxr","full_name":"kleintom/dxr","owner":{"login":"kleintom","id":632915,"avatar_url":"https://avatars.githubusercontent.com/u/632915?v=3","gravatar_id":"","url":"https://api.github.com/users/kleintom","html_url":"https://github.com/kleintom","followers_url":"https://api.github.com/users/kleintom/followers","following_url":"https://api.github.com/users/kleintom/following{/other_user}","gists_url":"https://api.github.com/users/kleintom/gists{/gist_id}","starred_url":"https://api.github.com/users/kleintom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleintom/subscriptions","organizations_url":"https://api.github.com/users/kleintom/orgs","repos_url":"https://api.github.com/users/kleintom/repos","events_url":"https://api.github.com/users/kleintom/events{/privacy}","received_events_url":"https://api.github.com/users/kleintom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kleintom/dxr","description":"An intelligent source code browser","fork":true,"url":"https://api.github.com/repos/kleintom/dxr","forks_url":"https://api.github.com/repos/kleintom/dxr/forks","keys_url":"https://api.github.com/repos/kleintom/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kleintom/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kleintom/dxr/teams","hooks_url":"https://api.github.com/repos/kleintom/dxr/hooks","issue_events_url":"https://api.github.com/repos/kleintom/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/kleintom/dxr/events","assignees_url":"https://api.github.com/repos/kleintom/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/kleintom/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/kleintom/dxr/tags","blobs_url":"https://api.github.com/repos/kleintom/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kleintom/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kleintom/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kleintom/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kleintom/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/kleintom/dxr/languages","stargazers_url":"https://api.github.com/repos/kleintom/dxr/stargazers","contributors_url":"https://api.github.com/repos/kleintom/dxr/contributors","subscribers_url":"https://api.github.com/repos/kleintom/dxr/subscribers","subscription_url":"https://api.github.com/repos/kleintom/dxr/subscription","commits_url":"https://api.github.com/repos/kleintom/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kleintom/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kleintom/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kleintom/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/kleintom/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/kleintom/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kleintom/dxr/merges","archive_url":"https://api.github.com/repos/kleintom/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kleintom/dxr/downloads","issues_url":"https://api.github.com/repos/kleintom/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/kleintom/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/kleintom/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/kleintom/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kleintom/dxr/labels{/name}","releases_url":"https://api.github.com/repos/kleintom/dxr/releases{/id}","deployments_url":"https://api.github.com/repos/kleintom/dxr/deployments","created_at":"2015-10-31T23:27:41Z","updated_at":"2016-03-02T15:59:52Z","pushed_at":"2016-03-23T17:49:25Z","git_url":"git://github.com/kleintom/dxr.git","ssh_url":"git@github.com:kleintom/dxr.git","clone_url":"https://github.com/kleintom/dxr.git","svn_url":"https://github.com/kleintom/dxr","homepage":"https://dxr.readthedocs.org/","size":10867,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"02e06d7c817868ec381966113467e5aa1695dad3","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1795049,"name":"dxr","full_name":"mozilla/dxr","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/dxr","description":"Powerful search for large codebases","fork":false,"url":"https://api.github.com/repos/mozilla/dxr","forks_url":"https://api.github.com/repos/mozilla/dxr/forks","keys_url":"https://api.github.com/repos/mozilla/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/dxr/teams","hooks_url":"https://api.github.com/repos/mozilla/dxr/hooks","issue_events_url":"https://api.github.com/repos/mozilla/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/dxr/events","assignees_url":"https://api.github.com/repos/mozilla/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/dxr/tags","blobs_url":"https://api.github.com/repos/mozilla/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/dxr/languages","stargazers_url":"https://api.github.com/repos/mozilla/dxr/stargazers","contributors_url":"https://api.github.com/repos/mozilla/dxr/contributors","subscribers_url":"https://api.github.com/repos/mozilla/dxr/subscribers","subscription_url":"https://api.github.com/repos/mozilla/dxr/subscription","commits_url":"https://api.github.com/repos/mozilla/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/dxr/merges","archive_url":"https://api.github.com/repos/mozilla/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/dxr/downloads","issues_url":"https://api.github.com/repos/mozilla/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/dxr/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/dxr/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/dxr/deployments","created_at":"2011-05-24T18:52:38Z","updated_at":"2016-03-19T10:33:00Z","pushed_at":"2016-03-23T17:49:26Z","git_url":"git://github.com/mozilla/dxr.git","ssh_url":"git@github.com:mozilla/dxr.git","clone_url":"https://github.com/mozilla/dxr.git","svn_url":"https://github.com/mozilla/dxr","homepage":"https://dxr.readthedocs.org/","size":12911,"stargazers_count":393,"watchers_count":393,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":37,"forks":146,"open_issues":37,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/518"},"html":{"href":"https://github.com/mozilla/dxr/pull/518"},"issue":{"href":"https://api.github.com/repos/mozilla/dxr/issues/518"},"comments":{"href":"https://api.github.com/repos/mozilla/dxr/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/dxr/statuses/b673e30b1d01a8a756e6a2fb69a36b6fa7b095cb"}}}}