{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/comments/88982230","pull_request_review_id":9536648,"id":88982230,"diff_hunk":"@@ -230,8 +230,8 @@\n                 <groupId>org.apache.maven.plugins</groupId>\n                 <artifactId>maven-compiler-plugin</artifactId>\n                 <configuration>\n-                    <source>1.6</source>\n-                    <target>1.6</target>\n+                    <source>1.7</source>\n+                    <target>1.7</target>","path":"pom.xml","position":7,"original_position":7,"commit_id":"dfe6ba177ca4060ada160fc2582b44164988d80f","original_commit_id":"dfe6ba177ca4060ada160fc2582b44164988d80f","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"I would go even further:\r\n1) Update parent POM to 2.x latest\r\n2) Update Core requirement to 1.609.x or above\r\n3) Get rid of this section, you will get Java 7 by default","created_at":"2016-11-21T20:35:42Z","updated_at":"2016-11-21T20:35:42Z","html_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57#discussion_r88982230","pull_request_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/comments/88982230"},"html":{"href":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57#discussion_r88982230"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57","id":84132558,"html_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57","diff_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57.diff","patch_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57.patch","issue_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/57","number":57,"state":"open","locked":false,"title":"Use fixed pool size, parse all single line matchers in one thread","user":{"login":"Jimilian","id":4785672,"avatar_url":"https://avatars.githubusercontent.com/u/4785672?v=3","gravatar_id":"","url":"https://api.github.com/users/Jimilian","html_url":"https://github.com/Jimilian","followers_url":"https://api.github.com/users/Jimilian/followers","following_url":"https://api.github.com/users/Jimilian/following{/other_user}","gists_url":"https://api.github.com/users/Jimilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimilian/subscriptions","organizations_url":"https://api.github.com/users/Jimilian/orgs","repos_url":"https://api.github.com/users/Jimilian/repos","events_url":"https://api.github.com/users/Jimilian/events{/privacy}","received_events_url":"https://api.github.com/users/Jimilian/received_events","type":"User","site_admin":false},"body":"So, this is ambitious PR:\n- Set language level to Java 7\n- Thread pool is constant now - doesn't depend on number of failed job\n- All single line patterns are parsed in one thread - reduces CPU load and memory pressure A LOT\n\nI understand that right now this PR is far away from final state. But it already works as expected.\nMy questions are:\n- Can I keep Java 7?\n- Can I delete\\rework scan(Run build, PrintStream buildLog)?\n- Can I rework chain Cause->Indication->Pattern? I don't like current solution `setter`+`getter`, but I didn't want to make significant changes without asking it here.\n","created_at":"2016-09-06T14:27:59Z","updated_at":"2016-11-21T20:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ca8a5c88cc72a092cef2e963964b80bcb9612eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/57/comments","statuses_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/statuses/dfe6ba177ca4060ada160fc2582b44164988d80f","head":{"label":"Jimilian:set_max_number_of_threads","ref":"set_max_number_of_threads","sha":"dfe6ba177ca4060ada160fc2582b44164988d80f","user":{"login":"Jimilian","id":4785672,"avatar_url":"https://avatars.githubusercontent.com/u/4785672?v=3","gravatar_id":"","url":"https://api.github.com/users/Jimilian","html_url":"https://github.com/Jimilian","followers_url":"https://api.github.com/users/Jimilian/followers","following_url":"https://api.github.com/users/Jimilian/following{/other_user}","gists_url":"https://api.github.com/users/Jimilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimilian/subscriptions","organizations_url":"https://api.github.com/users/Jimilian/orgs","repos_url":"https://api.github.com/users/Jimilian/repos","events_url":"https://api.github.com/users/Jimilian/events{/privacy}","received_events_url":"https://api.github.com/users/Jimilian/received_events","type":"User","site_admin":false},"repo":{"id":55073442,"name":"build-failure-analyzer-plugin","full_name":"Jimilian/build-failure-analyzer-plugin","owner":{"login":"Jimilian","id":4785672,"avatar_url":"https://avatars.githubusercontent.com/u/4785672?v=3","gravatar_id":"","url":"https://api.github.com/users/Jimilian","html_url":"https://github.com/Jimilian","followers_url":"https://api.github.com/users/Jimilian/followers","following_url":"https://api.github.com/users/Jimilian/following{/other_user}","gists_url":"https://api.github.com/users/Jimilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimilian/subscriptions","organizations_url":"https://api.github.com/users/Jimilian/orgs","repos_url":"https://api.github.com/users/Jimilian/repos","events_url":"https://api.github.com/users/Jimilian/events{/privacy}","received_events_url":"https://api.github.com/users/Jimilian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jimilian/build-failure-analyzer-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin","forks_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/forks","keys_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/teams","hooks_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/hooks","issue_events_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/events","assignees_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/tags","blobs_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/languages","stargazers_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/stargazers","contributors_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/contributors","subscribers_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/subscribers","subscription_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/subscription","commits_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/merges","archive_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/downloads","issues_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/labels{/name}","releases_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/Jimilian/build-failure-analyzer-plugin/deployments","created_at":"2016-03-30T15:13:07Z","updated_at":"2016-03-30T15:13:08Z","pushed_at":"2016-09-20T15:16:43Z","git_url":"git://github.com/Jimilian/build-failure-analyzer-plugin.git","ssh_url":"git@github.com:Jimilian/build-failure-analyzer-plugin.git","clone_url":"https://github.com/Jimilian/build-failure-analyzer-plugin.git","svn_url":"https://github.com/Jimilian/build-failure-analyzer-plugin","homepage":"","size":961,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"10f1536db3c9c94a8471dd9db1d63e974a1c53fc","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":6812369,"name":"build-failure-analyzer-plugin","full_name":"jenkinsci/build-failure-analyzer-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin","forks_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/deployments","created_at":"2012-11-22T11:51:57Z","updated_at":"2016-11-02T13:19:01Z","pushed_at":"2016-10-21T09:39:42Z","git_url":"git://github.com/jenkinsci/build-failure-analyzer-plugin.git","ssh_url":"git@github.com:jenkinsci/build-failure-analyzer-plugin.git","clone_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin.git","svn_url":"https://github.com/jenkinsci/build-failure-analyzer-plugin","homepage":"","size":1149,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":1,"forks":70,"open_issues":1,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57"},"html":{"href":"https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57"},"issue":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/57"},"comments":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/build-failure-analyzer-plugin/statuses/dfe6ba177ca4060ada160fc2582b44164988d80f"}}}}
{"actor":{"display_login":"oleg-nenashev"}}