{"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75","id":26039376,"html_url":"https://github.com/Vagabond/gen_smtp/pull/75","diff_url":"https://github.com/Vagabond/gen_smtp/pull/75.diff","patch_url":"https://github.com/Vagabond/gen_smtp/pull/75.patch","issue_url":"https://api.github.com/repos/Vagabond/gen_smtp/issues/75","number":75,"state":"closed","locked":false,"title":"Set the default encoding to \"none\" if iconv cannot be found","user":{"login":"gotthardp","id":939979,"avatar_url":"https://avatars.githubusercontent.com/u/939979?v=3","gravatar_id":"","url":"https://api.github.com/users/gotthardp","html_url":"https://github.com/gotthardp","followers_url":"https://api.github.com/users/gotthardp/followers","following_url":"https://api.github.com/users/gotthardp/following{/other_user}","gists_url":"https://api.github.com/users/gotthardp/gists{/gist_id}","starred_url":"https://api.github.com/users/gotthardp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotthardp/subscriptions","organizations_url":"https://api.github.com/users/gotthardp/orgs","repos_url":"https://api.github.com/users/gotthardp/repos","events_url":"https://api.github.com/users/gotthardp/events{/privacy}","received_events_url":"https://api.github.com/users/gotthardp/received_events","type":"User","site_admin":false},"body":"The comment in [mimemail.erl:59](https://github.com/vagabond/gen_smtp/blob/master/src/mimemail.erl#L59) suggests the \"default encoding is utf-8 if we can find the iconv module\", however the default encoding is always \"utf-8\" even if the iconv is not available.\r\n\r\nI suggest to make the dependency on iconv optional by setting the default encoding to \"none\" if iconv cannot be found.","created_at":"2014-12-14T21:26:07Z","updated_at":"2016-05-16T18:26:20Z","closed_at":"2016-05-16T18:26:20Z","merged_at":null,"merge_commit_sha":"eb3997642e3330bfeb8ac8f8515d1f83ae5e0559","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75/commits","review_comments_url":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75/comments","review_comment_url":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vagabond/gen_smtp/issues/75/comments","statuses_url":"https://api.github.com/repos/Vagabond/gen_smtp/statuses/06ebca76fd1c48eca06f72a9c19e43eda89435b8","head":{"label":"gotthardp:optional_eiconv","ref":"optional_eiconv","sha":"06ebca76fd1c48eca06f72a9c19e43eda89435b8","user":{"login":"gotthardp","id":939979,"avatar_url":"https://avatars.githubusercontent.com/u/939979?v=3","gravatar_id":"","url":"https://api.github.com/users/gotthardp","html_url":"https://github.com/gotthardp","followers_url":"https://api.github.com/users/gotthardp/followers","following_url":"https://api.github.com/users/gotthardp/following{/other_user}","gists_url":"https://api.github.com/users/gotthardp/gists{/gist_id}","starred_url":"https://api.github.com/users/gotthardp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotthardp/subscriptions","organizations_url":"https://api.github.com/users/gotthardp/orgs","repos_url":"https://api.github.com/users/gotthardp/repos","events_url":"https://api.github.com/users/gotthardp/events{/privacy}","received_events_url":"https://api.github.com/users/gotthardp/received_events","type":"User","site_admin":false},"repo":{"id":27000788,"name":"gen_smtp","full_name":"gotthardp/gen_smtp","owner":{"login":"gotthardp","id":939979,"avatar_url":"https://avatars.githubusercontent.com/u/939979?v=3","gravatar_id":"","url":"https://api.github.com/users/gotthardp","html_url":"https://github.com/gotthardp","followers_url":"https://api.github.com/users/gotthardp/followers","following_url":"https://api.github.com/users/gotthardp/following{/other_user}","gists_url":"https://api.github.com/users/gotthardp/gists{/gist_id}","starred_url":"https://api.github.com/users/gotthardp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotthardp/subscriptions","organizations_url":"https://api.github.com/users/gotthardp/orgs","repos_url":"https://api.github.com/users/gotthardp/repos","events_url":"https://api.github.com/users/gotthardp/events{/privacy}","received_events_url":"https://api.github.com/users/gotthardp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gotthardp/gen_smtp","description":"A generic Erlang SMTP server and client that can be extended via callback modules","fork":true,"url":"https://api.github.com/repos/gotthardp/gen_smtp","forks_url":"https://api.github.com/repos/gotthardp/gen_smtp/forks","keys_url":"https://api.github.com/repos/gotthardp/gen_smtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gotthardp/gen_smtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gotthardp/gen_smtp/teams","hooks_url":"https://api.github.com/repos/gotthardp/gen_smtp/hooks","issue_events_url":"https://api.github.com/repos/gotthardp/gen_smtp/issues/events{/number}","events_url":"https://api.github.com/repos/gotthardp/gen_smtp/events","assignees_url":"https://api.github.com/repos/gotthardp/gen_smtp/assignees{/user}","branches_url":"https://api.github.com/repos/gotthardp/gen_smtp/branches{/branch}","tags_url":"https://api.github.com/repos/gotthardp/gen_smtp/tags","blobs_url":"https://api.github.com/repos/gotthardp/gen_smtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gotthardp/gen_smtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gotthardp/gen_smtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/gotthardp/gen_smtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gotthardp/gen_smtp/statuses/{sha}","languages_url":"https://api.github.com/repos/gotthardp/gen_smtp/languages","stargazers_url":"https://api.github.com/repos/gotthardp/gen_smtp/stargazers","contributors_url":"https://api.github.com/repos/gotthardp/gen_smtp/contributors","subscribers_url":"https://api.github.com/repos/gotthardp/gen_smtp/subscribers","subscription_url":"https://api.github.com/repos/gotthardp/gen_smtp/subscription","commits_url":"https://api.github.com/repos/gotthardp/gen_smtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/gotthardp/gen_smtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/gotthardp/gen_smtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/gotthardp/gen_smtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/gotthardp/gen_smtp/contents/{+path}","compare_url":"https://api.github.com/repos/gotthardp/gen_smtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gotthardp/gen_smtp/merges","archive_url":"https://api.github.com/repos/gotthardp/gen_smtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gotthardp/gen_smtp/downloads","issues_url":"https://api.github.com/repos/gotthardp/gen_smtp/issues{/number}","pulls_url":"https://api.github.com/repos/gotthardp/gen_smtp/pulls{/number}","milestones_url":"https://api.github.com/repos/gotthardp/gen_smtp/milestones{/number}","notifications_url":"https://api.github.com/repos/gotthardp/gen_smtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gotthardp/gen_smtp/labels{/name}","releases_url":"https://api.github.com/repos/gotthardp/gen_smtp/releases{/id}","deployments_url":"https://api.github.com/repos/gotthardp/gen_smtp/deployments","created_at":"2014-11-22T14:11:11Z","updated_at":"2015-02-26T12:26:09Z","pushed_at":"2015-12-06T19:22:45Z","git_url":"git://github.com/gotthardp/gen_smtp.git","ssh_url":"git@github.com:gotthardp/gen_smtp.git","clone_url":"https://github.com/gotthardp/gen_smtp.git","svn_url":"https://github.com/gotthardp/gen_smtp","homepage":"","size":1365,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vagabond:master","ref":"master","sha":"8f7ba01172e679e8b4262334cefc3451b4c36777","user":{"login":"Vagabond","id":86412,"avatar_url":"https://avatars.githubusercontent.com/u/86412?v=3","gravatar_id":"","url":"https://api.github.com/users/Vagabond","html_url":"https://github.com/Vagabond","followers_url":"https://api.github.com/users/Vagabond/followers","following_url":"https://api.github.com/users/Vagabond/following{/other_user}","gists_url":"https://api.github.com/users/Vagabond/gists{/gist_id}","starred_url":"https://api.github.com/users/Vagabond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vagabond/subscriptions","organizations_url":"https://api.github.com/users/Vagabond/orgs","repos_url":"https://api.github.com/users/Vagabond/repos","events_url":"https://api.github.com/users/Vagabond/events{/privacy}","received_events_url":"https://api.github.com/users/Vagabond/received_events","type":"User","site_admin":false},"repo":{"id":207238,"name":"gen_smtp","full_name":"Vagabond/gen_smtp","owner":{"login":"Vagabond","id":86412,"avatar_url":"https://avatars.githubusercontent.com/u/86412?v=3","gravatar_id":"","url":"https://api.github.com/users/Vagabond","html_url":"https://github.com/Vagabond","followers_url":"https://api.github.com/users/Vagabond/followers","following_url":"https://api.github.com/users/Vagabond/following{/other_user}","gists_url":"https://api.github.com/users/Vagabond/gists{/gist_id}","starred_url":"https://api.github.com/users/Vagabond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vagabond/subscriptions","organizations_url":"https://api.github.com/users/Vagabond/orgs","repos_url":"https://api.github.com/users/Vagabond/repos","events_url":"https://api.github.com/users/Vagabond/events{/privacy}","received_events_url":"https://api.github.com/users/Vagabond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vagabond/gen_smtp","description":"A generic Erlang SMTP server and client that can be extended via callback modules","fork":false,"url":"https://api.github.com/repos/Vagabond/gen_smtp","forks_url":"https://api.github.com/repos/Vagabond/gen_smtp/forks","keys_url":"https://api.github.com/repos/Vagabond/gen_smtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vagabond/gen_smtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vagabond/gen_smtp/teams","hooks_url":"https://api.github.com/repos/Vagabond/gen_smtp/hooks","issue_events_url":"https://api.github.com/repos/Vagabond/gen_smtp/issues/events{/number}","events_url":"https://api.github.com/repos/Vagabond/gen_smtp/events","assignees_url":"https://api.github.com/repos/Vagabond/gen_smtp/assignees{/user}","branches_url":"https://api.github.com/repos/Vagabond/gen_smtp/branches{/branch}","tags_url":"https://api.github.com/repos/Vagabond/gen_smtp/tags","blobs_url":"https://api.github.com/repos/Vagabond/gen_smtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vagabond/gen_smtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vagabond/gen_smtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vagabond/gen_smtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vagabond/gen_smtp/statuses/{sha}","languages_url":"https://api.github.com/repos/Vagabond/gen_smtp/languages","stargazers_url":"https://api.github.com/repos/Vagabond/gen_smtp/stargazers","contributors_url":"https://api.github.com/repos/Vagabond/gen_smtp/contributors","subscribers_url":"https://api.github.com/repos/Vagabond/gen_smtp/subscribers","subscription_url":"https://api.github.com/repos/Vagabond/gen_smtp/subscription","commits_url":"https://api.github.com/repos/Vagabond/gen_smtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vagabond/gen_smtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vagabond/gen_smtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vagabond/gen_smtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vagabond/gen_smtp/contents/{+path}","compare_url":"https://api.github.com/repos/Vagabond/gen_smtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vagabond/gen_smtp/merges","archive_url":"https://api.github.com/repos/Vagabond/gen_smtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vagabond/gen_smtp/downloads","issues_url":"https://api.github.com/repos/Vagabond/gen_smtp/issues{/number}","pulls_url":"https://api.github.com/repos/Vagabond/gen_smtp/pulls{/number}","milestones_url":"https://api.github.com/repos/Vagabond/gen_smtp/milestones{/number}","notifications_url":"https://api.github.com/repos/Vagabond/gen_smtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vagabond/gen_smtp/labels{/name}","releases_url":"https://api.github.com/repos/Vagabond/gen_smtp/releases{/id}","deployments_url":"https://api.github.com/repos/Vagabond/gen_smtp/deployments","created_at":"2009-05-21T23:18:49Z","updated_at":"2016-05-16T15:17:34Z","pushed_at":"2016-05-16T18:19:58Z","git_url":"git://github.com/Vagabond/gen_smtp.git","ssh_url":"git@github.com:Vagabond/gen_smtp.git","clone_url":"https://github.com/Vagabond/gen_smtp.git","svn_url":"https://github.com/Vagabond/gen_smtp","homepage":"","size":2241,"stargazers_count":354,"watchers_count":354,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":38,"forks":143,"open_issues":38,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75"},"html":{"href":"https://github.com/Vagabond/gen_smtp/pull/75"},"issue":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/issues/75"},"comments":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/Vagabond/gen_smtp/statuses/06ebca76fd1c48eca06f72a9c19e43eda89435b8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}