{"action":"created","issue":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076","repository_url":"https://api.github.com/repos/qooxdoo/qooxdoo","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076/labels{/name}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076/comments","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076/events","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9076","id":163473623,"number":9076,"title":"String \"startsWith()\" and \"endsWith()\" polyfills ...ECMAScript 2015 (6th Edition, ECMA-262)","user":{"login":"schnepe2","id":18400313,"avatar_url":"https://avatars.githubusercontent.com/u/18400313?v=3","gravatar_id":"","url":"https://api.github.com/users/schnepe2","html_url":"https://github.com/schnepe2","followers_url":"https://api.github.com/users/schnepe2/followers","following_url":"https://api.github.com/users/schnepe2/following{/other_user}","gists_url":"https://api.github.com/users/schnepe2/gists{/gist_id}","starred_url":"https://api.github.com/users/schnepe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnepe2/subscriptions","organizations_url":"https://api.github.com/users/schnepe2/orgs","repos_url":"https://api.github.com/users/schnepe2/repos","events_url":"https://api.github.com/users/schnepe2/events{/privacy}","received_events_url":"https://api.github.com/users/schnepe2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-01T21:03:12Z","updated_at":"2016-07-05T10:01:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9076","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9076.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9076.patch"},"body":"Hi there,\r\n\r\nhere's my PR for the polyfills for the String prototype methods `startsWith` and `endsWith`.\r\n\r\nI always found it irritating that there are still some clients (IE) missing this and I had to use\r\n`qx.lang.String.startsWith(str, \"foo\")` instead of the easy to read `str.startsWith(\"foo\")` :smile: \r\n\r\nIncluding tests & environment checks\r\n\r\nReferences:\r\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith\r\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith"},"comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments/230437654","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9076#issuecomment-230437654","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076","id":230437654,"user":{"login":"schnepe2","id":18400313,"avatar_url":"https://avatars.githubusercontent.com/u/18400313?v=3","gravatar_id":"","url":"https://api.github.com/users/schnepe2","html_url":"https://github.com/schnepe2","followers_url":"https://api.github.com/users/schnepe2/followers","following_url":"https://api.github.com/users/schnepe2/following{/other_user}","gists_url":"https://api.github.com/users/schnepe2/gists{/gist_id}","starred_url":"https://api.github.com/users/schnepe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnepe2/subscriptions","organizations_url":"https://api.github.com/users/schnepe2/orgs","repos_url":"https://api.github.com/users/schnepe2/repos","events_url":"https://api.github.com/users/schnepe2/events{/privacy}","received_events_url":"https://api.github.com/users/schnepe2/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T10:01:29Z","updated_at":"2016-07-05T10:01:29Z","body":"I'll be happy to add the deprecation hint to my PR.\r\nSince **when** should it be deprecated? Version 5.0.2?\r\nIn that case, here are my proposals (including deprecation warning information):\r\n```\r\n    /**\r\n     * Check whether the string starts with the given substring\r\n     *\r\n     * @deprecated {5.0.2} Please use String instance startsWith method instead\r\n     *\r\n     * @param fullstr {String} the string to search in\r\n     * @param substr {String} the substring to look for\r\n     * @return {Boolean} whether the string starts with the given substring\r\n     */\r\n    startsWith : function(fullstr, substr) {\r\n      return fullstr.startsWith(substr);\r\n    },\r\n\r\n\r\n    /**\r\n     * Check whether the string ends with the given substring\r\n     *\r\n     * @deprecated {5.0.2} Please use String instance endsWith method instead\r\n     *\r\n     * @param fullstr {String} the string to search in\r\n     * @param substr {String} the substring to look for\r\n     * @return {Boolean} whether the string ends with the given substring\r\n     */\r\n    endsWith : function(fullstr, substr) {\r\n      return fullstr.endsWith(substr)\r\n    },\r\n```\r\n"}}
{"actor":{"display_login":"schnepe2"}}