{"action":"created","issue":{"url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/232","repository_url":"https://api.github.com/repos/FlixelCommunity/flixel","labels_url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/232/comments","events_url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/232/events","html_url":"https://github.com/FlixelCommunity/flixel/issues/232","id":158446831,"number":232,"title":"[GPU build] calcFrame() wrong order","user":{"login":"PRIZZA","id":3136062,"avatar_url":"https://avatars.githubusercontent.com/u/3136062?v=3","gravatar_id":"","url":"https://api.github.com/users/PRIZZA","html_url":"https://github.com/PRIZZA","followers_url":"https://api.github.com/users/PRIZZA/followers","following_url":"https://api.github.com/users/PRIZZA/following{/other_user}","gists_url":"https://api.github.com/users/PRIZZA/gists{/gist_id}","starred_url":"https://api.github.com/users/PRIZZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRIZZA/subscriptions","organizations_url":"https://api.github.com/users/PRIZZA/orgs","repos_url":"https://api.github.com/users/PRIZZA/repos","events_url":"https://api.github.com/users/PRIZZA/events{/privacy}","received_events_url":"https://api.github.com/users/PRIZZA/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-03T20:20:26Z","updated_at":"2016-06-08T13:01:06Z","closed_at":null,"body":"In `calcFrame()`, the `isBlitting()` check sets the flashRect dimensions to zero in the incorrect order:\r\n```\r\nif (FlxG.render.isBlitting())\r\n\t\t\t{\r\n\t\t\t\tcalcFramePixels();\r\n\t\t\t\t_flashRect.x = _flashRect.y = 0;\r\n\t\t\t}\r\n```\r\n\r\nIn the blitting render this causes some alpha effects to not work correctly depending on a few factors. This can be resolved by moving the flashRect assignment to within the calcFramePixels() function.\r\n\r\n```\r\nprotected function calcFramePixels():void\r\n\t\t{\r\n\t\t\tframePixels.copyPixels(_pixels, _flashRect, _flashPointZero);\r\n\t\t\t_flashRect.x = _flashRect.y = 0;//Reset rectangle before setting colorTransform\r\n\t\t\t\r\n\t\t\tif (_colorTransform != null)\r\n\t\t\t{\r\n\t\t\t\tframePixels.colorTransform(_flashRect, _colorTransform);\r\n\t\t\t}\r\n\t\t}\r\n```"},"comment":{"url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/comments/224581321","html_url":"https://github.com/FlixelCommunity/flixel/issues/232#issuecomment-224581321","issue_url":"https://api.github.com/repos/FlixelCommunity/flixel/issues/232","id":224581321,"user":{"login":"Dovyski","id":512405,"avatar_url":"https://avatars.githubusercontent.com/u/512405?v=3","gravatar_id":"","url":"https://api.github.com/users/Dovyski","html_url":"https://github.com/Dovyski","followers_url":"https://api.github.com/users/Dovyski/followers","following_url":"https://api.github.com/users/Dovyski/following{/other_user}","gists_url":"https://api.github.com/users/Dovyski/gists{/gist_id}","starred_url":"https://api.github.com/users/Dovyski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dovyski/subscriptions","organizations_url":"https://api.github.com/users/Dovyski/orgs","repos_url":"https://api.github.com/users/Dovyski/repos","events_url":"https://api.github.com/users/Dovyski/events{/privacy}","received_events_url":"https://api.github.com/users/Dovyski/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T13:01:06Z","updated_at":"2016-06-08T13:01:06Z","body":"Have you tried to run this same fix with the GPU render as well? I remember I had some problems making `_flashRect` to work properly with both blitting and GPU render."}}
{"actor":{"display_login":"Dovyski"}}