{"action":"created","issue":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/1023","repository_url":"https://api.github.com/repos/NyxStudios/TShock","labels_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1023/labels{/name}","comments_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1023/comments","events_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1023/events","html_url":"https://github.com/NyxStudios/TShock/issues/1023","id":95532659,"number":1023,"title":"Browsing occupies slots","user":{"login":"Gaegamel","id":2140965,"avatar_url":"https://avatars.githubusercontent.com/u/2140965?v=3","gravatar_id":"","url":"https://api.github.com/users/Gaegamel","html_url":"https://github.com/Gaegamel","followers_url":"https://api.github.com/users/Gaegamel/followers","following_url":"https://api.github.com/users/Gaegamel/following{/other_user}","gists_url":"https://api.github.com/users/Gaegamel/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaegamel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaegamel/subscriptions","organizations_url":"https://api.github.com/users/Gaegamel/orgs","repos_url":"https://api.github.com/users/Gaegamel/repos","events_url":"https://api.github.com/users/Gaegamel/events{/privacy}","received_events_url":"https://api.github.com/users/Gaegamel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NyxStudios/TShock/labels/Confirmed%20Issue","name":"Confirmed Issue","color":"bfe5bf"},{"url":"https://api.github.com/repos/NyxStudios/TShock/labels/Security%20Problem","name":"Security Problem","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2015-07-16T21:20:29Z","updated_at":"2016-10-10T23:42:59Z","closed_at":null,"body":"Hi,\r\nI'm sorry to disturb you. I looked through the issues. Nothing seemed really fitting. The closest was https://github.com/NyxStudios/TShock/issues/947 (because the actual reason might still be unknown. My bad, if it is known already).\r\n\r\nTerrariaAPI Version: 1.19.0.0 (Protocol v1.3.0.5 (153))\r\nSendQ edition\r\nTShock 4.3.5.0 (Yoraiz0r R0cks)\r\n(executed with Mono: \"mono --server --gc=sgen -O=all TerrariaServer.exe\" )\r\n\r\nThe bug: Connecting to the server via the web browser repeatedly leads to the ip occupying slots and not freeing them, leading to an overall lockdown.\r\n\r\nHow to reproduce the issue:\r\n1. Start a serverinstance. For example selecting 4 slots and on port 7777 (a default world wouldn't be bad, either).\r\n2. Start your webbrowser and enter the ip+port of your terraria-Server. i.e. 1.2.3.4:7777.\r\n3. Repeat that several times by refreshing the tab/window. Now, pay attention to your server-window. Messages such as:\r\n\r\n> x.x.x.x:60869 is connecting to slot 0...\r\n> x.x.x.x:60870 is connecting to slot 1...\r\n\r\nshould appear (like expected for \"normal\" behaviour).\r\nAfter reaching max slots, `Netplay: No more clients can connect!` will appear (ok under normal circumstances).\r\n\r\nIf you need further information, I would be glad to help.\r\n\r\nWith kind regards,\r\nGaegamel"},"comment":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/comments/252774720","html_url":"https://github.com/NyxStudios/TShock/issues/1023#issuecomment-252774720","issue_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1023","id":252774720,"user":{"login":"tylerjwatson","id":5001408,"avatar_url":"https://avatars.githubusercontent.com/u/5001408?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerjwatson","html_url":"https://github.com/tylerjwatson","followers_url":"https://api.github.com/users/tylerjwatson/followers","following_url":"https://api.github.com/users/tylerjwatson/following{/other_user}","gists_url":"https://api.github.com/users/tylerjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjwatson/subscriptions","organizations_url":"https://api.github.com/users/tylerjwatson/orgs","repos_url":"https://api.github.com/users/tylerjwatson/repos","events_url":"https://api.github.com/users/tylerjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjwatson/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T23:42:59Z","updated_at":"2016-10-10T23:42:59Z","body":"Unfortunately this is a regression with how Re-logic has written their socket handling, meaning that any Open TCP socket is regarded as a player, even when it has not even attempted a player handshake, thus taking a slot.\n\nIt's broken at the very concept. There may be a path around it if we are able to reimplement terraria's network stack and patch it in as an OTAPI modification, however likely that is.\n\nSent from my iPhone\n\nOn 11 Oct. 2016, at 9:27 am, Lucas Nicodemus <notifications@github.com<mailto:notifications@github.com>> wrote:\n\n\n@tylerjwatson<https://github.com/tylerjwatson> is this issue still relevant with the move to OTAPI + Orion?\n\n-\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub<https://github.com/NyxStudios/TShock/issues/1023#issuecomment-252772504>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AExQwBOdY-MKAT_hxvl-LpAeK55dcUfpks5qysm-gaJpZM4FaPOZ>.\n"}}
{"actor":{"display_login":"tylerjwatson"}}