{"action":"created","comment":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/comments/59844703","id":59844703,"diff_hunk":"@@ -809,13 +809,19 @@ extension Request {\n     public func rx_progress() -> Observable<RxProgress> {\n         return Observable.create { observer in\n             self.progress() { bytesWritten, totalBytesWritten, totalBytesExpectedToWrite in\n+                \n                 observer.onNext(RxProgress(bytesWritten: bytesWritten, totalBytesWritten: totalBytesWritten, totalBytesExpectedToWrite: totalBytesExpectedToWrite))\n+                \n+                if totalBytesWritten == totalBytesExpectedToWrite {","path":"RxAlamofire/Source/RxAlamofire.swift","position":7,"original_position":7,"commit_id":"490624982aea2dfc6af6a08994cd31c28c473a61","original_commit_id":"490624982aea2dfc6af6a08994cd31c28c473a61","user":{"login":"bontoJR","id":159493,"avatar_url":"https://avatars.githubusercontent.com/u/159493?v=3","gravatar_id":"","url":"https://api.github.com/users/bontoJR","html_url":"https://github.com/bontoJR","followers_url":"https://api.github.com/users/bontoJR/followers","following_url":"https://api.github.com/users/bontoJR/following{/other_user}","gists_url":"https://api.github.com/users/bontoJR/gists{/gist_id}","starred_url":"https://api.github.com/users/bontoJR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bontoJR/subscriptions","organizations_url":"https://api.github.com/users/bontoJR/orgs","repos_url":"https://api.github.com/users/bontoJR/repos","events_url":"https://api.github.com/users/bontoJR/events{/privacy}","received_events_url":"https://api.github.com/users/bontoJR/received_events","type":"User","site_admin":false},"body":"I would change this and check if `totalBytesWritten is >= totalBytesExpectedToWrite`, it might happen, it's an edge case, but we have to be safe on this matter.","created_at":"2016-04-15T08:49:58Z","updated_at":"2016-04-15T08:49:58Z","html_url":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22#discussion_r59844703","pull_request_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/comments/59844703"},"html":{"href":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22#discussion_r59844703"},"pull_request":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22","id":66289921,"html_url":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22","diff_url":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22.diff","patch_url":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22.patch","issue_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/22","number":22,"state":"open","locked":false,"title":"Fix *rx_progress()* to send *onCompleted()* when *totalBytesWritten* is equal to *totalBytesExpectedToWrite*","user":{"login":"idikic","id":2021137,"avatar_url":"https://avatars.githubusercontent.com/u/2021137?v=3","gravatar_id":"","url":"https://api.github.com/users/idikic","html_url":"https://github.com/idikic","followers_url":"https://api.github.com/users/idikic/followers","following_url":"https://api.github.com/users/idikic/following{/other_user}","gists_url":"https://api.github.com/users/idikic/gists{/gist_id}","starred_url":"https://api.github.com/users/idikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idikic/subscriptions","organizations_url":"https://api.github.com/users/idikic/orgs","repos_url":"https://api.github.com/users/idikic/repos","events_url":"https://api.github.com/users/idikic/events{/privacy}","received_events_url":"https://api.github.com/users/idikic/received_events","type":"User","site_admin":false},"body":"Hello @bontoJR ,\r\n\r\nI have made some changes to rx_progress() to allow signal completion when totalBytesWritten is equal to totalBytesExpectedToWrite, let me know what do you think.\r\n\r\nHave a nice day\r\n\r\nIvan","created_at":"2016-04-13T09:23:45Z","updated_at":"2016-04-15T08:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fc84dfb20afff8b2bade212af1276e7e2278445","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22/commits","review_comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22/comments","review_comment_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/22/comments","statuses_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/statuses/490624982aea2dfc6af6a08994cd31c28c473a61","head":{"label":"idikic:master","ref":"master","sha":"490624982aea2dfc6af6a08994cd31c28c473a61","user":{"login":"idikic","id":2021137,"avatar_url":"https://avatars.githubusercontent.com/u/2021137?v=3","gravatar_id":"","url":"https://api.github.com/users/idikic","html_url":"https://github.com/idikic","followers_url":"https://api.github.com/users/idikic/followers","following_url":"https://api.github.com/users/idikic/following{/other_user}","gists_url":"https://api.github.com/users/idikic/gists{/gist_id}","starred_url":"https://api.github.com/users/idikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idikic/subscriptions","organizations_url":"https://api.github.com/users/idikic/orgs","repos_url":"https://api.github.com/users/idikic/repos","events_url":"https://api.github.com/users/idikic/events{/privacy}","received_events_url":"https://api.github.com/users/idikic/received_events","type":"User","site_admin":false},"repo":{"id":56135845,"name":"RxAlamofire","full_name":"idikic/RxAlamofire","owner":{"login":"idikic","id":2021137,"avatar_url":"https://avatars.githubusercontent.com/u/2021137?v=3","gravatar_id":"","url":"https://api.github.com/users/idikic","html_url":"https://github.com/idikic","followers_url":"https://api.github.com/users/idikic/followers","following_url":"https://api.github.com/users/idikic/following{/other_user}","gists_url":"https://api.github.com/users/idikic/gists{/gist_id}","starred_url":"https://api.github.com/users/idikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idikic/subscriptions","organizations_url":"https://api.github.com/users/idikic/orgs","repos_url":"https://api.github.com/users/idikic/repos","events_url":"https://api.github.com/users/idikic/events{/privacy}","received_events_url":"https://api.github.com/users/idikic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/idikic/RxAlamofire","description":"RxSwift wrapper around the elegant HTTP networking in Swift Alamofire","fork":true,"url":"https://api.github.com/repos/idikic/RxAlamofire","forks_url":"https://api.github.com/repos/idikic/RxAlamofire/forks","keys_url":"https://api.github.com/repos/idikic/RxAlamofire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idikic/RxAlamofire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idikic/RxAlamofire/teams","hooks_url":"https://api.github.com/repos/idikic/RxAlamofire/hooks","issue_events_url":"https://api.github.com/repos/idikic/RxAlamofire/issues/events{/number}","events_url":"https://api.github.com/repos/idikic/RxAlamofire/events","assignees_url":"https://api.github.com/repos/idikic/RxAlamofire/assignees{/user}","branches_url":"https://api.github.com/repos/idikic/RxAlamofire/branches{/branch}","tags_url":"https://api.github.com/repos/idikic/RxAlamofire/tags","blobs_url":"https://api.github.com/repos/idikic/RxAlamofire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idikic/RxAlamofire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idikic/RxAlamofire/git/refs{/sha}","trees_url":"https://api.github.com/repos/idikic/RxAlamofire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idikic/RxAlamofire/statuses/{sha}","languages_url":"https://api.github.com/repos/idikic/RxAlamofire/languages","stargazers_url":"https://api.github.com/repos/idikic/RxAlamofire/stargazers","contributors_url":"https://api.github.com/repos/idikic/RxAlamofire/contributors","subscribers_url":"https://api.github.com/repos/idikic/RxAlamofire/subscribers","subscription_url":"https://api.github.com/repos/idikic/RxAlamofire/subscription","commits_url":"https://api.github.com/repos/idikic/RxAlamofire/commits{/sha}","git_commits_url":"https://api.github.com/repos/idikic/RxAlamofire/git/commits{/sha}","comments_url":"https://api.github.com/repos/idikic/RxAlamofire/comments{/number}","issue_comment_url":"https://api.github.com/repos/idikic/RxAlamofire/issues/comments{/number}","contents_url":"https://api.github.com/repos/idikic/RxAlamofire/contents/{+path}","compare_url":"https://api.github.com/repos/idikic/RxAlamofire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idikic/RxAlamofire/merges","archive_url":"https://api.github.com/repos/idikic/RxAlamofire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idikic/RxAlamofire/downloads","issues_url":"https://api.github.com/repos/idikic/RxAlamofire/issues{/number}","pulls_url":"https://api.github.com/repos/idikic/RxAlamofire/pulls{/number}","milestones_url":"https://api.github.com/repos/idikic/RxAlamofire/milestones{/number}","notifications_url":"https://api.github.com/repos/idikic/RxAlamofire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idikic/RxAlamofire/labels{/name}","releases_url":"https://api.github.com/repos/idikic/RxAlamofire/releases{/id}","deployments_url":"https://api.github.com/repos/idikic/RxAlamofire/deployments","created_at":"2016-04-13T08:47:52Z","updated_at":"2016-04-13T08:47:53Z","pushed_at":"2016-04-13T08:57:46Z","git_url":"git://github.com/idikic/RxAlamofire.git","ssh_url":"git@github.com:idikic/RxAlamofire.git","clone_url":"https://github.com/idikic/RxAlamofire.git","svn_url":"https://github.com/idikic/RxAlamofire","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RxSwiftCommunity:master","ref":"master","sha":"6abf5678d43d04065946b393282ef6bd37dc8298","user":{"login":"RxSwiftCommunity","id":15903991,"avatar_url":"https://avatars.githubusercontent.com/u/15903991?v=3","gravatar_id":"","url":"https://api.github.com/users/RxSwiftCommunity","html_url":"https://github.com/RxSwiftCommunity","followers_url":"https://api.github.com/users/RxSwiftCommunity/followers","following_url":"https://api.github.com/users/RxSwiftCommunity/following{/other_user}","gists_url":"https://api.github.com/users/RxSwiftCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/RxSwiftCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxSwiftCommunity/subscriptions","organizations_url":"https://api.github.com/users/RxSwiftCommunity/orgs","repos_url":"https://api.github.com/users/RxSwiftCommunity/repos","events_url":"https://api.github.com/users/RxSwiftCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/RxSwiftCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":41247272,"name":"RxAlamofire","full_name":"RxSwiftCommunity/RxAlamofire","owner":{"login":"RxSwiftCommunity","id":15903991,"avatar_url":"https://avatars.githubusercontent.com/u/15903991?v=3","gravatar_id":"","url":"https://api.github.com/users/RxSwiftCommunity","html_url":"https://github.com/RxSwiftCommunity","followers_url":"https://api.github.com/users/RxSwiftCommunity/followers","following_url":"https://api.github.com/users/RxSwiftCommunity/following{/other_user}","gists_url":"https://api.github.com/users/RxSwiftCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/RxSwiftCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxSwiftCommunity/subscriptions","organizations_url":"https://api.github.com/users/RxSwiftCommunity/orgs","repos_url":"https://api.github.com/users/RxSwiftCommunity/repos","events_url":"https://api.github.com/users/RxSwiftCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/RxSwiftCommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RxSwiftCommunity/RxAlamofire","description":"RxSwift wrapper around the elegant HTTP networking in Swift Alamofire","fork":false,"url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire","forks_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/forks","keys_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/teams","hooks_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/hooks","issue_events_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/events{/number}","events_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/events","assignees_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/assignees{/user}","branches_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/branches{/branch}","tags_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/tags","blobs_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/git/refs{/sha}","trees_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/statuses/{sha}","languages_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/languages","stargazers_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/stargazers","contributors_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/contributors","subscribers_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/subscribers","subscription_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/subscription","commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/commits{/sha}","git_commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/git/commits{/sha}","comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/comments{/number}","issue_comment_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/comments{/number}","contents_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/contents/{+path}","compare_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/merges","archive_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/downloads","issues_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues{/number}","pulls_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls{/number}","milestones_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/milestones{/number}","notifications_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/labels{/name}","releases_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/releases{/id}","deployments_url":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/deployments","created_at":"2015-08-23T11:37:23Z","updated_at":"2016-04-15T07:20:40Z","pushed_at":"2016-04-14T06:32:50Z","git_url":"git://github.com/RxSwiftCommunity/RxAlamofire.git","ssh_url":"git@github.com:RxSwiftCommunity/RxAlamofire.git","clone_url":"https://github.com/RxSwiftCommunity/RxAlamofire.git","svn_url":"https://github.com/RxSwiftCommunity/RxAlamofire","homepage":null,"size":88,"stargazers_count":198,"watchers_count":198,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22"},"html":{"href":"https://github.com/RxSwiftCommunity/RxAlamofire/pull/22"},"issue":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/22"},"comments":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxAlamofire/statuses/490624982aea2dfc6af6a08994cd31c28c473a61"}}}}