{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/33","repository_url":"https://api.github.com/repos/bazelbuild/rules_appengine","labels_url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/33/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/33/events","html_url":"https://github.com/bazelbuild/rules_appengine/issues/33","id":195393504,"number":33,"title":"appengine_war doesn't work with a java_library","user":{"login":"regisd","id":838356,"avatar_url":"https://avatars.githubusercontent.com/u/838356?v=3","gravatar_id":"","url":"https://api.github.com/users/regisd","html_url":"https://github.com/regisd","followers_url":"https://api.github.com/users/regisd/followers","following_url":"https://api.github.com/users/regisd/following{/other_user}","gists_url":"https://api.github.com/users/regisd/gists{/gist_id}","starred_url":"https://api.github.com/users/regisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisd/subscriptions","organizations_url":"https://api.github.com/users/regisd/orgs","repos_url":"https://api.github.com/users/regisd/repos","events_url":"https://api.github.com/users/regisd/events{/privacy}","received_events_url":"https://api.github.com/users/regisd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-13T22:58:05Z","updated_at":"2016-12-13T23:10:48Z","closed_at":null,"body":"The doc reads:\r\n\r\n> appengine_war(name, jars, data, data_path)\r\n\r\nand\r\n\r\n> jars\tList of labels, required\r\n> List of JAR files that will be uncompressed as the code for the Web Application.\r\n> **If it is a `java_library` or a `java_import`, the JAR from the runtime classpath will be added in the `lib` directory of the Web Application.**\r\n\r\nIn my experience, this doesn't work.\r\n\r\nIn fact, even examples is using\r\n\r\n    jars = [\"//examples/src:src_deploy.jar\"],\r\n\r\nThis would also work:\r\n\r\n    jars = [\"//examples/src:srr.jar\"],\r\n\r\nBut this doesn't:\r\n\r\n    jars = [\"//examples/src:src\"],\r\n\r\nIf I understand correctly, it should (and the syntax would be nicer and follow the convention of listing targets, not build artifacts).\r\n"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/comments/266891904","html_url":"https://github.com/bazelbuild/rules_appengine/issues/33#issuecomment-266891904","issue_url":"https://api.github.com/repos/bazelbuild/rules_appengine/issues/33","id":266891904,"user":{"login":"regisd","id":838356,"avatar_url":"https://avatars.githubusercontent.com/u/838356?v=3","gravatar_id":"","url":"https://api.github.com/users/regisd","html_url":"https://github.com/regisd","followers_url":"https://api.github.com/users/regisd/followers","following_url":"https://api.github.com/users/regisd/following{/other_user}","gists_url":"https://api.github.com/users/regisd/gists{/gist_id}","starred_url":"https://api.github.com/users/regisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisd/subscriptions","organizations_url":"https://api.github.com/users/regisd/orgs","repos_url":"https://api.github.com/users/regisd/repos","events_url":"https://api.github.com/users/regisd/events{/privacy}","received_events_url":"https://api.github.com/users/regisd/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T23:10:48Z","updated_at":"2016-12-13T23:10:48Z","body":"I don't experience the same behaviour. The provided `examples` uses a `java_binary` and this is also failing when referencing the target rather than the jar.\r\n\r\nI mean, the compilation works doesn't succeeds, but the war doesn't contain the jar, hence the server will hit a `NoClassDefFoundError` at runtime.\r\n"}}
{"actor":{"display_login":"regisd"}}