{"action":"created","issue":{"url":"https://api.github.com/repos/seomoz/dragnet/issues/34","repository_url":"https://api.github.com/repos/seomoz/dragnet","labels_url":"https://api.github.com/repos/seomoz/dragnet/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/seomoz/dragnet/issues/34/comments","events_url":"https://api.github.com/repos/seomoz/dragnet/issues/34/events","html_url":"https://github.com/seomoz/dragnet/pull/34","id":195653496,"number":34,"title":"Stylistic cleanup and (start of) Py2/3 compatibility","user":{"login":"bdewilde","id":2514535,"avatar_url":"https://avatars.githubusercontent.com/u/2514535?v=3","gravatar_id":"","url":"https://api.github.com/users/bdewilde","html_url":"https://github.com/bdewilde","followers_url":"https://api.github.com/users/bdewilde/followers","following_url":"https://api.github.com/users/bdewilde/following{/other_user}","gists_url":"https://api.github.com/users/bdewilde/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewilde/subscriptions","organizations_url":"https://api.github.com/users/bdewilde/orgs","repos_url":"https://api.github.com/users/bdewilde/repos","events_url":"https://api.github.com/users/bdewilde/events{/privacy}","received_events_url":"https://api.github.com/users/bdewilde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-14T21:41:13Z","updated_at":"2016-12-19T01:52:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/seomoz/dragnet/pulls/34","html_url":"https://github.com/seomoz/dragnet/pull/34","diff_url":"https://github.com/seomoz/dragnet/pull/34.diff","patch_url":"https://github.com/seomoz/dragnet/pull/34.patch"},"body":"- Many minor changes in whitespace, indentation, imports, etc. to clean up the code à la pep8. No code behavior should change.\r\n- Added a `compat.py` module with standardized Py2/3 compatible built-ins, and replaced the Py2-only equivalents in all modules:`xrange` => `compat.range_`, `unicode` => `compat.unicode_`, etc.\r\n- Replaced all `print` statements with `print()` functions via `from __future__ import print_function`\r\n- Replaced sets of string literals in `blocks.pyx` with explicit bytes, compatible with Py3 in addition to Py2\r\n\r\nUnfortunately, _something_ has changed in the code's behavior, and 1 test out of 39 now fails. Specifically, the `kohlschuetter_css_model` model's extracted content fails to match the actual content in `test_models()`, even after 5 tries. I don't understand why this is.\r\n\r\nOne other note: `scipy.weave` is Py2 only, so its use in `arias.py` is incompatible with Py3. It looks like the recommendation is to use Cython directly, but I didn't want to muck around with that just yet."},"comment":{"url":"https://api.github.com/repos/seomoz/dragnet/issues/comments/267865123","html_url":"https://github.com/seomoz/dragnet/pull/34#issuecomment-267865123","issue_url":"https://api.github.com/repos/seomoz/dragnet/issues/34","id":267865123,"user":{"login":"bdewilde","id":2514535,"avatar_url":"https://avatars.githubusercontent.com/u/2514535?v=3","gravatar_id":"","url":"https://api.github.com/users/bdewilde","html_url":"https://github.com/bdewilde","followers_url":"https://api.github.com/users/bdewilde/followers","following_url":"https://api.github.com/users/bdewilde/following{/other_user}","gists_url":"https://api.github.com/users/bdewilde/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewilde/subscriptions","organizations_url":"https://api.github.com/users/bdewilde/orgs","repos_url":"https://api.github.com/users/bdewilde/repos","events_url":"https://api.github.com/users/bdewilde/events{/privacy}","received_events_url":"https://api.github.com/users/bdewilde/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T01:52:16Z","updated_at":"2016-12-19T01:52:16Z","body":"Hey @matt-peters , so, all tests run successfully in my branch after the 2nd of 3 commits, but `test_models` test fails after the changes introduced in the 3rd commit, as discussed. I've reverted one change at a time and re-run the failing test case, but nothing changes the outcome. Also, just looking at the changes, I can't see anything that would change the code's behavior at all. I'm at a total loss."}}
{"actor":{"display_login":"bdewilde"}}