{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67","id":66738862,"html_url":"https://github.com/karlorg/drunken-octo-avenger/pull/67","diff_url":"https://github.com/karlorg/drunken-octo-avenger/pull/67.diff","patch_url":"https://github.com/karlorg/drunken-octo-avenger/pull/67.patch","issue_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/67","number":67,"state":"closed","locked":false,"title":"Show information about finished games","user":{"login":"allanderek","id":791177,"avatar_url":"https://avatars.githubusercontent.com/u/791177?v=3","gravatar_id":"","url":"https://api.github.com/users/allanderek","html_url":"https://github.com/allanderek","followers_url":"https://api.github.com/users/allanderek/followers","following_url":"https://api.github.com/users/allanderek/following{/other_user}","gists_url":"https://api.github.com/users/allanderek/gists{/gist_id}","starred_url":"https://api.github.com/users/allanderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanderek/subscriptions","organizations_url":"https://api.github.com/users/allanderek/orgs","repos_url":"https://api.github.com/users/allanderek/repos","events_url":"https://api.github.com/users/allanderek/events{/privacy}","received_events_url":"https://api.github.com/users/allanderek/received_events","type":"User","site_admin":false},"body":"This includes a database migration! It is also the first database migration that actually does something interesting with the new column, so it might be quite good to look back to as an example, the next time we need to do something like this.\r\n\r\nEssentially this PR, changes the 'finished' boolean column, into a column which represents how the game ended (b/w win by resignation, b/w win on points, draw, not finished).\r\n\r\nA couple of points, I well accept that the testing here is less than comprehensive. There is a bit of testing, but in particular I'd like to more thoroughly unit test go.py with respect to computing the score.\r\n\r\nWith that in mind, this means that in go.py, we do duplicate some of the work done in go_rules.coffee, I'm afraid I just think that is inevitable and arguably not such a bad thing since you can test the two implementations against each other.\r\n\r\nIf we really do not like that there are two options:\r\n    1. Have the python code called the compiled coffeescript code\r\n    2. Ditch some of the coffee script code and compile/interpret the Python code as Javascript. This is actually more of an option than I thought. I have translated an HTML5/Phaser tutorial (cloning flappy bird) into Python which is then compiled using Transcrypt, or can be interpreted using Brython. Let me know if you want more details on either of these.\r\n\r\nBut in general for now, I'm assuming it's not a majorly bad thing.\r\n\r\n","created_at":"2016-04-16T14:04:42Z","updated_at":"2016-04-28T11:39:36Z","closed_at":"2016-04-28T11:39:36Z","merged_at":"2016-04-28T11:39:36Z","merge_commit_sha":"ebdedec9da79e2249022e53d8930452bec501cc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67/commits","review_comments_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67/comments","review_comment_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/67/comments","statuses_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/statuses/ebdedec9da79e2249022e53d8930452bec501cc3","head":{"label":"allanderek:master","ref":"master","sha":"ebdedec9da79e2249022e53d8930452bec501cc3","user":{"login":"allanderek","id":791177,"avatar_url":"https://avatars.githubusercontent.com/u/791177?v=3","gravatar_id":"","url":"https://api.github.com/users/allanderek","html_url":"https://github.com/allanderek","followers_url":"https://api.github.com/users/allanderek/followers","following_url":"https://api.github.com/users/allanderek/following{/other_user}","gists_url":"https://api.github.com/users/allanderek/gists{/gist_id}","starred_url":"https://api.github.com/users/allanderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanderek/subscriptions","organizations_url":"https://api.github.com/users/allanderek/orgs","repos_url":"https://api.github.com/users/allanderek/repos","events_url":"https://api.github.com/users/allanderek/events{/privacy}","received_events_url":"https://api.github.com/users/allanderek/received_events","type":"User","site_admin":false},"repo":{"id":30547416,"name":"drunken-octo-avenger","full_name":"allanderek/drunken-octo-avenger","owner":{"login":"allanderek","id":791177,"avatar_url":"https://avatars.githubusercontent.com/u/791177?v=3","gravatar_id":"","url":"https://api.github.com/users/allanderek","html_url":"https://github.com/allanderek","followers_url":"https://api.github.com/users/allanderek/followers","following_url":"https://api.github.com/users/allanderek/following{/other_user}","gists_url":"https://api.github.com/users/allanderek/gists{/gist_id}","starred_url":"https://api.github.com/users/allanderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanderek/subscriptions","organizations_url":"https://api.github.com/users/allanderek/orgs","repos_url":"https://api.github.com/users/allanderek/repos","events_url":"https://api.github.com/users/allanderek/events{/privacy}","received_events_url":"https://api.github.com/users/allanderek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allanderek/drunken-octo-avenger","description":"Python/Flask version of Go website prototype, for comparison","fork":true,"url":"https://api.github.com/repos/allanderek/drunken-octo-avenger","forks_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/forks","keys_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/teams","hooks_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/hooks","issue_events_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/issues/events{/number}","events_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/events","assignees_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/assignees{/user}","branches_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/branches{/branch}","tags_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/tags","blobs_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/git/refs{/sha}","trees_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/statuses/{sha}","languages_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/languages","stargazers_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/stargazers","contributors_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/contributors","subscribers_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/subscribers","subscription_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/subscription","commits_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/commits{/sha}","git_commits_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/git/commits{/sha}","comments_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/comments{/number}","issue_comment_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/issues/comments{/number}","contents_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/contents/{+path}","compare_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/merges","archive_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/downloads","issues_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/issues{/number}","pulls_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/pulls{/number}","milestones_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/milestones{/number}","notifications_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/labels{/name}","releases_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/releases{/id}","deployments_url":"https://api.github.com/repos/allanderek/drunken-octo-avenger/deployments","created_at":"2015-02-09T17:07:43Z","updated_at":"2016-04-16T13:55:30Z","pushed_at":"2016-04-26T18:44:10Z","git_url":"git://github.com/allanderek/drunken-octo-avenger.git","ssh_url":"git@github.com:allanderek/drunken-octo-avenger.git","clone_url":"https://github.com/allanderek/drunken-octo-avenger.git","svn_url":"https://github.com/allanderek/drunken-octo-avenger","homepage":null,"size":1416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"karlorg:master","ref":"master","sha":"41676af206937fae03bccfba7b808d2033736250","user":{"login":"karlorg","id":3965887,"avatar_url":"https://avatars.githubusercontent.com/u/3965887?v=3","gravatar_id":"","url":"https://api.github.com/users/karlorg","html_url":"https://github.com/karlorg","followers_url":"https://api.github.com/users/karlorg/followers","following_url":"https://api.github.com/users/karlorg/following{/other_user}","gists_url":"https://api.github.com/users/karlorg/gists{/gist_id}","starred_url":"https://api.github.com/users/karlorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlorg/subscriptions","organizations_url":"https://api.github.com/users/karlorg/orgs","repos_url":"https://api.github.com/users/karlorg/repos","events_url":"https://api.github.com/users/karlorg/events{/privacy}","received_events_url":"https://api.github.com/users/karlorg/received_events","type":"User","site_admin":false},"repo":{"id":27976925,"name":"drunken-octo-avenger","full_name":"karlorg/drunken-octo-avenger","owner":{"login":"karlorg","id":3965887,"avatar_url":"https://avatars.githubusercontent.com/u/3965887?v=3","gravatar_id":"","url":"https://api.github.com/users/karlorg","html_url":"https://github.com/karlorg","followers_url":"https://api.github.com/users/karlorg/followers","following_url":"https://api.github.com/users/karlorg/following{/other_user}","gists_url":"https://api.github.com/users/karlorg/gists{/gist_id}","starred_url":"https://api.github.com/users/karlorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlorg/subscriptions","organizations_url":"https://api.github.com/users/karlorg/orgs","repos_url":"https://api.github.com/users/karlorg/repos","events_url":"https://api.github.com/users/karlorg/events{/privacy}","received_events_url":"https://api.github.com/users/karlorg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karlorg/drunken-octo-avenger","description":"Python/Flask version of Go website prototype, for comparison","fork":false,"url":"https://api.github.com/repos/karlorg/drunken-octo-avenger","forks_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/forks","keys_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/teams","hooks_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/hooks","issue_events_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/events{/number}","events_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/events","assignees_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/assignees{/user}","branches_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/branches{/branch}","tags_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/tags","blobs_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/git/refs{/sha}","trees_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/statuses/{sha}","languages_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/languages","stargazers_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/stargazers","contributors_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/contributors","subscribers_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/subscribers","subscription_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/subscription","commits_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/commits{/sha}","git_commits_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/git/commits{/sha}","comments_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/comments{/number}","issue_comment_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/comments{/number}","contents_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/contents/{+path}","compare_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/merges","archive_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/downloads","issues_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues{/number}","pulls_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls{/number}","milestones_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/milestones{/number}","notifications_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/labels{/name}","releases_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/releases{/id}","deployments_url":"https://api.github.com/repos/karlorg/drunken-octo-avenger/deployments","created_at":"2014-12-13T23:17:48Z","updated_at":"2016-03-25T17:05:11Z","pushed_at":"2016-04-28T11:39:36Z","git_url":"git://github.com/karlorg/drunken-octo-avenger.git","ssh_url":"git@github.com:karlorg/drunken-octo-avenger.git","clone_url":"https://github.com/karlorg/drunken-octo-avenger.git","svn_url":"https://github.com/karlorg/drunken-octo-avenger","homepage":null,"size":1440,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67"},"html":{"href":"https://github.com/karlorg/drunken-octo-avenger/pull/67"},"issue":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/67"},"comments":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/karlorg/drunken-octo-avenger/statuses/ebdedec9da79e2249022e53d8930452bec501cc3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"karlorg","id":3965887,"avatar_url":"https://avatars.githubusercontent.com/u/3965887?v=3","gravatar_id":"","url":"https://api.github.com/users/karlorg","html_url":"https://github.com/karlorg","followers_url":"https://api.github.com/users/karlorg/followers","following_url":"https://api.github.com/users/karlorg/following{/other_user}","gists_url":"https://api.github.com/users/karlorg/gists{/gist_id}","starred_url":"https://api.github.com/users/karlorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlorg/subscriptions","organizations_url":"https://api.github.com/users/karlorg/orgs","repos_url":"https://api.github.com/users/karlorg/repos","events_url":"https://api.github.com/users/karlorg/events{/privacy}","received_events_url":"https://api.github.com/users/karlorg/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":13,"additions":467,"deletions":78,"changed_files":12}}