{"action":"closed","issue":{"url":"https://api.github.com/repos/sgroschupf/zkclient/issues/62","repository_url":"https://api.github.com/repos/sgroschupf/zkclient","labels_url":"https://api.github.com/repos/sgroschupf/zkclient/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/sgroschupf/zkclient/issues/62/comments","events_url":"https://api.github.com/repos/sgroschupf/zkclient/issues/62/events","html_url":"https://github.com/sgroschupf/zkclient/issues/62","id":191538477,"number":62,"title":"SLF4J misuse","user":{"login":"jasonf20","id":1601106,"avatar_url":"https://avatars.githubusercontent.com/u/1601106?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonf20","html_url":"https://github.com/jasonf20","followers_url":"https://api.github.com/users/jasonf20/followers","following_url":"https://api.github.com/users/jasonf20/following{/other_user}","gists_url":"https://api.github.com/users/jasonf20/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonf20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonf20/subscriptions","organizations_url":"https://api.github.com/users/jasonf20/orgs","repos_url":"https://api.github.com/users/jasonf20/repos","events_url":"https://api.github.com/users/jasonf20/events{/privacy}","received_events_url":"https://api.github.com/users/jasonf20/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-24T14:50:38Z","updated_at":"2016-11-24T16:03:33Z","closed_at":"2016-11-24T16:03:33Z","body":"It seems that the slf4j library is being misused. The purpose of this library is to allow all users of the your library to have their own logging back-end. However, in the current form you:\r\n1) Have `org.slf4j:slf4j-log4j12:1.6.1` as a compile dependency\r\n2) Seem to be using `log4j` directly in the code instead of the facade classes provided by `slf4j`. This prevents one from simply excluding your `org.slf4j:slf4j-log4j12:1.6.1` to avoid using it since then your code will throw a runtime `ClassNotFound` error.\r\n\r\nThe following explanation can be seen on slf4j's documentation: \r\n> Embedded components such as libraries or frameworks should not declare a dependency on any SLF4J binding but only depend on slf4j-api. When a library declares a compile-time dependency on a SLF4J binding, it imposes that binding on the end-user, thus negating SLF4J's purpose. \r\n(http://www.slf4j.org/codes.html#multiple_bindings)\r\n"}}
{"actor":{"display_login":"jzillmann"}}