{"action":"created","issue":{"url":"https://api.github.com/repos/novoda/download-manager/issues/185","repository_url":"https://api.github.com/repos/novoda/download-manager","labels_url":"https://api.github.com/repos/novoda/download-manager/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/novoda/download-manager/issues/185/comments","events_url":"https://api.github.com/repos/novoda/download-manager/issues/185/events","html_url":"https://github.com/novoda/download-manager/pull/185","id":146336129,"number":185,"title":"Propagate error upwards instead of swallowing","user":{"login":"ataulm","id":2678555,"avatar_url":"https://avatars.githubusercontent.com/u/2678555?v=3","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-06T14:41:27Z","updated_at":"2016-04-06T14:51:19Z","closed_at":"2016-04-06T14:50:00Z","pull_request":{"url":"https://api.github.com/repos/novoda/download-manager/pulls/185","html_url":"https://github.com/novoda/download-manager/pull/185","diff_url":"https://github.com/novoda/download-manager/pull/185.diff","patch_url":"https://github.com/novoda/download-manager/pull/185.patch"},"body":"Fixes the bug where downloads were considered successful even though they weren't\r\n\r\nThe comment says we should have thrown it but looks like it was mistakenly put inside the condition.\r\n\r\nCan reproduce this by turning airplane mode on in the middle of a download, and turning it back off so the download resumes. The download will \"complete\" successfully, but it's not downloaded anymore."},"comment":{"url":"https://api.github.com/repos/novoda/download-manager/issues/comments/206413178","html_url":"https://github.com/novoda/download-manager/pull/185#issuecomment-206413178","issue_url":"https://api.github.com/repos/novoda/download-manager/issues/185","id":206413178,"user":{"login":"amlcurran","id":666285,"avatar_url":"https://avatars.githubusercontent.com/u/666285?v=3","gravatar_id":"","url":"https://api.github.com/users/amlcurran","html_url":"https://github.com/amlcurran","followers_url":"https://api.github.com/users/amlcurran/followers","following_url":"https://api.github.com/users/amlcurran/following{/other_user}","gists_url":"https://api.github.com/users/amlcurran/gists{/gist_id}","starred_url":"https://api.github.com/users/amlcurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amlcurran/subscriptions","organizations_url":"https://api.github.com/users/amlcurran/orgs","repos_url":"https://api.github.com/users/amlcurran/repos","events_url":"https://api.github.com/users/amlcurran/events{/privacy}","received_events_url":"https://api.github.com/users/amlcurran/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T14:51:19Z","updated_at":"2016-04-06T14:51:19Z","body":"Any way of testing this? :)"}}