{"action":"created","comment":{"url":"https://api.github.com/repos/philogb/philogl/pulls/comments/49387184","id":49387184,"diff_hunk":"@@ -258,55 +217,49 @@ export default class Program {\n \n   // Alternate constructor\n   // Create a program from vertex and fragment shader node ids\n-  static async fromShaderIds(...args) {\n-    const opt = Program._getOptions({}, ...args);\n-    const vertexShader = document.getElementById(opt.vs).innerHTML;\n-    const fragmentShader = document.getElementById(opt.fs).innerHTML;\n-    return new Program(opt.app, vertexShader, fragmentShader);\n+  static fromHTMLTemplates(app, vs, fs) {","path":"src/program.js","position":67,"original_position":67,"commit_id":"3f5d6aba6a201b9795dc251b0d2efb5f05b9538b","original_commit_id":"3f5d6aba6a201b9795dc251b0d2efb5f05b9538b","user":{"login":"ibgreen","id":7025232,"avatar_url":"https://avatars.githubusercontent.com/u/7025232?v=3","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"body":"I'm starting to think that with ES6 template strings (that support multi line strings), this explicit support for getting strings from HTML templates seems increasingly old school. If an app really wants to do it, it is just one line of code, they can implement it themselves.\r\n\r\nI think we should remove this \"constructor\" and update all examples by moving the shader text from HTML file to template strings in the javascript.\r\n\r\n  const fragmentShader = `\r\n     ...\r\n  `;\r\n","created_at":"2016-01-11T22:13:08Z","updated_at":"2016-01-11T22:13:08Z","html_url":"https://github.com/philogb/philogl/pull/34#discussion_r49387184","pull_request_url":"https://api.github.com/repos/philogb/philogl/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/philogb/philogl/pulls/comments/49387184"},"html":{"href":"https://github.com/philogb/philogl/pull/34#discussion_r49387184"},"pull_request":{"href":"https://api.github.com/repos/philogb/philogl/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/philogb/philogl/pulls/34","id":55552799,"html_url":"https://github.com/philogb/philogl/pull/34","diff_url":"https://github.com/philogb/philogl/pull/34.diff","patch_url":"https://github.com/philogb/philogl/pull/34.patch","issue_url":"https://api.github.com/repos/philogb/philogl/issues/34","number":34,"state":"open","locked":false,"title":"Es6 refactor refactor","user":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"body":"Here you go @ibgreen, a first attempt at removing `core.js`. :tada: All the lessons are working.\r\n\r\nThe organization of the code flow of the lessons changed as I worked through them and I took a couple of liberties with styling; I'm happy to adopt whatever you guys prefer, just let me know. :)\r\n\r\n@philogb Unless you prefer otherwise, I'll start pinging you on these so you can keep abreast of what I'm up to. :)","created_at":"2016-01-09T22:42:46Z","updated_at":"2016-01-11T22:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1b8aab472e48c43a851662a82e4b9b3c8861cbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/philogb/philogl/pulls/34/commits","review_comments_url":"https://api.github.com/repos/philogb/philogl/pulls/34/comments","review_comment_url":"https://api.github.com/repos/philogb/philogl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/philogb/philogl/issues/34/comments","statuses_url":"https://api.github.com/repos/philogb/philogl/statuses/3f5d6aba6a201b9795dc251b0d2efb5f05b9538b","head":{"label":"wwwtyro:es6-refactor-refactor","ref":"es6-refactor-refactor","sha":"3f5d6aba6a201b9795dc251b0d2efb5f05b9538b","user":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"repo":{"id":46380159,"name":"philogl","full_name":"wwwtyro/philogl","owner":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wwwtyro/philogl","description":"A WebGL Framework for Data Visualization, Creative Coding and Game Development","fork":true,"url":"https://api.github.com/repos/wwwtyro/philogl","forks_url":"https://api.github.com/repos/wwwtyro/philogl/forks","keys_url":"https://api.github.com/repos/wwwtyro/philogl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwwtyro/philogl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwwtyro/philogl/teams","hooks_url":"https://api.github.com/repos/wwwtyro/philogl/hooks","issue_events_url":"https://api.github.com/repos/wwwtyro/philogl/issues/events{/number}","events_url":"https://api.github.com/repos/wwwtyro/philogl/events","assignees_url":"https://api.github.com/repos/wwwtyro/philogl/assignees{/user}","branches_url":"https://api.github.com/repos/wwwtyro/philogl/branches{/branch}","tags_url":"https://api.github.com/repos/wwwtyro/philogl/tags","blobs_url":"https://api.github.com/repos/wwwtyro/philogl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwwtyro/philogl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwwtyro/philogl/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwwtyro/philogl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwwtyro/philogl/statuses/{sha}","languages_url":"https://api.github.com/repos/wwwtyro/philogl/languages","stargazers_url":"https://api.github.com/repos/wwwtyro/philogl/stargazers","contributors_url":"https://api.github.com/repos/wwwtyro/philogl/contributors","subscribers_url":"https://api.github.com/repos/wwwtyro/philogl/subscribers","subscription_url":"https://api.github.com/repos/wwwtyro/philogl/subscription","commits_url":"https://api.github.com/repos/wwwtyro/philogl/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwwtyro/philogl/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwwtyro/philogl/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwwtyro/philogl/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwwtyro/philogl/contents/{+path}","compare_url":"https://api.github.com/repos/wwwtyro/philogl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwwtyro/philogl/merges","archive_url":"https://api.github.com/repos/wwwtyro/philogl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwwtyro/philogl/downloads","issues_url":"https://api.github.com/repos/wwwtyro/philogl/issues{/number}","pulls_url":"https://api.github.com/repos/wwwtyro/philogl/pulls{/number}","milestones_url":"https://api.github.com/repos/wwwtyro/philogl/milestones{/number}","notifications_url":"https://api.github.com/repos/wwwtyro/philogl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwwtyro/philogl/labels{/name}","releases_url":"https://api.github.com/repos/wwwtyro/philogl/releases{/id}","created_at":"2015-11-17T22:42:51Z","updated_at":"2015-11-17T22:42:57Z","pushed_at":"2016-01-09T22:29:08Z","git_url":"git://github.com/wwwtyro/philogl.git","ssh_url":"git@github.com:wwwtyro/philogl.git","clone_url":"https://github.com/wwwtyro/philogl.git","svn_url":"https://github.com/wwwtyro/philogl","homepage":"http://senchalabs.github.com/philogl/","size":125341,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"philogb:es6-refactor","ref":"es6-refactor","sha":"ec757cfbd24b0df3d50431239bf7dcd428ac271e","user":{"login":"philogb","id":71751,"avatar_url":"https://avatars.githubusercontent.com/u/71751?v=3","gravatar_id":"","url":"https://api.github.com/users/philogb","html_url":"https://github.com/philogb","followers_url":"https://api.github.com/users/philogb/followers","following_url":"https://api.github.com/users/philogb/following{/other_user}","gists_url":"https://api.github.com/users/philogb/gists{/gist_id}","starred_url":"https://api.github.com/users/philogb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philogb/subscriptions","organizations_url":"https://api.github.com/users/philogb/orgs","repos_url":"https://api.github.com/users/philogb/repos","events_url":"https://api.github.com/users/philogb/events{/privacy}","received_events_url":"https://api.github.com/users/philogb/received_events","type":"User","site_admin":false},"repo":{"id":1435852,"name":"philogl","full_name":"philogb/philogl","owner":{"login":"philogb","id":71751,"avatar_url":"https://avatars.githubusercontent.com/u/71751?v=3","gravatar_id":"","url":"https://api.github.com/users/philogb","html_url":"https://github.com/philogb","followers_url":"https://api.github.com/users/philogb/followers","following_url":"https://api.github.com/users/philogb/following{/other_user}","gists_url":"https://api.github.com/users/philogb/gists{/gist_id}","starred_url":"https://api.github.com/users/philogb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philogb/subscriptions","organizations_url":"https://api.github.com/users/philogb/orgs","repos_url":"https://api.github.com/users/philogb/repos","events_url":"https://api.github.com/users/philogb/events{/privacy}","received_events_url":"https://api.github.com/users/philogb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philogb/philogl","description":"A WebGL Framework for Data Visualization, Creative Coding and Game Development","fork":true,"url":"https://api.github.com/repos/philogb/philogl","forks_url":"https://api.github.com/repos/philogb/philogl/forks","keys_url":"https://api.github.com/repos/philogb/philogl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philogb/philogl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philogb/philogl/teams","hooks_url":"https://api.github.com/repos/philogb/philogl/hooks","issue_events_url":"https://api.github.com/repos/philogb/philogl/issues/events{/number}","events_url":"https://api.github.com/repos/philogb/philogl/events","assignees_url":"https://api.github.com/repos/philogb/philogl/assignees{/user}","branches_url":"https://api.github.com/repos/philogb/philogl/branches{/branch}","tags_url":"https://api.github.com/repos/philogb/philogl/tags","blobs_url":"https://api.github.com/repos/philogb/philogl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philogb/philogl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philogb/philogl/git/refs{/sha}","trees_url":"https://api.github.com/repos/philogb/philogl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philogb/philogl/statuses/{sha}","languages_url":"https://api.github.com/repos/philogb/philogl/languages","stargazers_url":"https://api.github.com/repos/philogb/philogl/stargazers","contributors_url":"https://api.github.com/repos/philogb/philogl/contributors","subscribers_url":"https://api.github.com/repos/philogb/philogl/subscribers","subscription_url":"https://api.github.com/repos/philogb/philogl/subscription","commits_url":"https://api.github.com/repos/philogb/philogl/commits{/sha}","git_commits_url":"https://api.github.com/repos/philogb/philogl/git/commits{/sha}","comments_url":"https://api.github.com/repos/philogb/philogl/comments{/number}","issue_comment_url":"https://api.github.com/repos/philogb/philogl/issues/comments{/number}","contents_url":"https://api.github.com/repos/philogb/philogl/contents/{+path}","compare_url":"https://api.github.com/repos/philogb/philogl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philogb/philogl/merges","archive_url":"https://api.github.com/repos/philogb/philogl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philogb/philogl/downloads","issues_url":"https://api.github.com/repos/philogb/philogl/issues{/number}","pulls_url":"https://api.github.com/repos/philogb/philogl/pulls{/number}","milestones_url":"https://api.github.com/repos/philogb/philogl/milestones{/number}","notifications_url":"https://api.github.com/repos/philogb/philogl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philogb/philogl/labels{/name}","releases_url":"https://api.github.com/repos/philogb/philogl/releases{/id}","created_at":"2011-03-03T17:12:05Z","updated_at":"2016-01-11T18:21:47Z","pushed_at":"2016-01-09T22:42:46Z","git_url":"git://github.com/philogb/philogl.git","ssh_url":"git@github.com:philogb/philogl.git","clone_url":"https://github.com/philogb/philogl.git","svn_url":"https://github.com/philogb/philogl","homepage":"http://senchalabs.github.com/philogl/","size":125348,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philogb/philogl/pulls/34"},"html":{"href":"https://github.com/philogb/philogl/pull/34"},"issue":{"href":"https://api.github.com/repos/philogb/philogl/issues/34"},"comments":{"href":"https://api.github.com/repos/philogb/philogl/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/philogb/philogl/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/philogb/philogl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/philogb/philogl/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/philogb/philogl/statuses/3f5d6aba6a201b9795dc251b0d2efb5f05b9538b"}}}}