{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/5422","labels_url":"https://api.github.com/repos/facebook/react-native/issues/5422/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5422/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/5422/events","html_url":"https://github.com/facebook/react-native/pull/5422","id":127587843,"number":5422,"title":"Make the packager work with babel strict mode transform","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"davidaurelio","id":158859,"avatar_url":"https://avatars.githubusercontent.com/u/158859?v=3","gravatar_id":"","url":"https://api.github.com/users/davidaurelio","html_url":"https://github.com/davidaurelio","followers_url":"https://api.github.com/users/davidaurelio/followers","following_url":"https://api.github.com/users/davidaurelio/following{/other_user}","gists_url":"https://api.github.com/users/davidaurelio/gists{/gist_id}","starred_url":"https://api.github.com/users/davidaurelio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidaurelio/subscriptions","organizations_url":"https://api.github.com/users/davidaurelio/orgs","repos_url":"https://api.github.com/users/davidaurelio/repos","events_url":"https://api.github.com/users/davidaurelio/events{/privacy}","received_events_url":"https://api.github.com/users/davidaurelio/received_events","type":"User","site_admin":false},"milestone":null,"comments":23,"created_at":"2016-01-20T02:05:30Z","updated_at":"2016-01-21T14:16:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5422","html_url":"https://github.com/facebook/react-native/pull/5422","diff_url":"https://github.com/facebook/react-native/pull/5422.diff","patch_url":"https://github.com/facebook/react-native/pull/5422.patch"},"body":"At the moment we have to disable strict mode for the transform-es2015-modules-commonjs because strict mode leaks to the global scope and breaks the bridge. It was due to the way the polyfills were bundled in the package. To fix it, I wrapped the polyfill modules in an IIFE. Then when strict mode was enabled some polyfills were broken due to strict mode errors so that was fixed too. Also removed the IIFE from the polyfills that included one.\r\n\r\nThis diff doesn't enable the strict mode transform since some internal facebook modules depend on it not being enabled. When #5214 lands we could make the default babel config shipped with OSS react-native use strict mode modules and facebook could just modify the babel config to disable it if needed.\r\n\r\nThis will allow removing `\"strict\": false` from https://github.com/facebook/react-native/blob/master/packager/react-packager/.babelrc#L16\r\n\r\nFixes #5316"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/173581205","html_url":"https://github.com/facebook/react-native/pull/5422#issuecomment-173581205","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5422","id":173581205,"user":{"login":"davidaurelio","id":158859,"avatar_url":"https://avatars.githubusercontent.com/u/158859?v=3","gravatar_id":"","url":"https://api.github.com/users/davidaurelio","html_url":"https://github.com/davidaurelio","followers_url":"https://api.github.com/users/davidaurelio/followers","following_url":"https://api.github.com/users/davidaurelio/following{/other_user}","gists_url":"https://api.github.com/users/davidaurelio/gists{/gist_id}","starred_url":"https://api.github.com/users/davidaurelio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidaurelio/subscriptions","organizations_url":"https://api.github.com/users/davidaurelio/orgs","repos_url":"https://api.github.com/users/davidaurelio/repos","events_url":"https://api.github.com/users/davidaurelio/events{/privacy}","received_events_url":"https://api.github.com/users/davidaurelio/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T14:16:02Z","updated_at":"2016-01-21T14:16:02Z","body":"@facebook-github-bot shipit"}}