{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/55987480","id":55987480,"diff_hunk":"@@ -36,24 +36,7 @@ public function testProcess()\n         $this->assertSame('my-command', (string) $container->getAlias($alias));\n \n         $this->assertTrue($container->hasParameter('console.command.ids'));\n-        $this->assertSame(array('my-command'), $container->getParameter('console.command.ids'));\n-    }\n-\n-    /**\n-     * @expectedException \\InvalidArgumentException\n-     * @expectedExceptionMessage The service \"my-command\" tagged \"console.command\" must be public.\n-     */\n-    public function testProcessThrowAnExceptionIfTheServiceIsNotPublic()\n-    {\n-        $container = new ContainerBuilder();\n-        $container->addCompilerPass(new AddConsoleCommandPass());\n-\n-        $definition = new Definition('Symfony\\Bundle\\FrameworkBundle\\Tests\\DependencyInjection\\Compiler\\MyCommand');\n-        $definition->addTag('console.command');\n-        $definition->setPublic(false);","path":"src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php","position":18,"original_position":18,"commit_id":"ce324d6f3572c48a78c3feb2d334327fea2b59c0","original_commit_id":"ce324d6f3572c48a78c3feb2d334327fea2b59c0","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"Maybe I'm missing something but, shouldn't you keep the `$definition->setPublic(false);` line to test that private commands don't trigger an error? ","created_at":"2016-03-14T11:35:22Z","updated_at":"2016-03-14T11:35:22Z","html_url":"https://github.com/symfony/symfony/pull/18101#discussion_r55987480","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18101","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/55987480"},"html":{"href":"https://github.com/symfony/symfony/pull/18101#discussion_r55987480"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18101"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18101","id":62408158,"html_url":"https://github.com/symfony/symfony/pull/18101","diff_url":"https://github.com/symfony/symfony/pull/18101.diff","patch_url":"https://github.com/symfony/symfony/pull/18101.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18101","number":18101,"state":"open","locked":false,"title":"[Console] Allow to register commands privately","user":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nI'm not sure if this should be considered as a bug or a feature.\r\n\r\nIt allows to declare command services as private (the command alias is used). I don't see a good reason to force the user to declare his services as public as the limitation is more internal than in his own code.","created_at":"2016-03-10T15:40:12Z","updated_at":"2016-03-14T11:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"491e1ad9e9e8ae670b3aca3102c034d6049cabed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18101/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18101/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18101/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ce324d6f3572c48a78c3feb2d334327fea2b59c0","head":{"label":"Ener-Getick:COMMAND","ref":"COMMAND","sha":"ce324d6f3572c48a78c3feb2d334327fea2b59c0","user":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"repo":{"id":47275948,"name":"symfony","full_name":"Ener-Getick/symfony","owner":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ener-Getick/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Ener-Getick/symfony","forks_url":"https://api.github.com/repos/Ener-Getick/symfony/forks","keys_url":"https://api.github.com/repos/Ener-Getick/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ener-Getick/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ener-Getick/symfony/teams","hooks_url":"https://api.github.com/repos/Ener-Getick/symfony/hooks","issue_events_url":"https://api.github.com/repos/Ener-Getick/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Ener-Getick/symfony/events","assignees_url":"https://api.github.com/repos/Ener-Getick/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Ener-Getick/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Ener-Getick/symfony/tags","blobs_url":"https://api.github.com/repos/Ener-Getick/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ener-Getick/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ener-Getick/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ener-Getick/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ener-Getick/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Ener-Getick/symfony/languages","stargazers_url":"https://api.github.com/repos/Ener-Getick/symfony/stargazers","contributors_url":"https://api.github.com/repos/Ener-Getick/symfony/contributors","subscribers_url":"https://api.github.com/repos/Ener-Getick/symfony/subscribers","subscription_url":"https://api.github.com/repos/Ener-Getick/symfony/subscription","commits_url":"https://api.github.com/repos/Ener-Getick/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ener-Getick/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ener-Getick/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ener-Getick/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ener-Getick/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Ener-Getick/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ener-Getick/symfony/merges","archive_url":"https://api.github.com/repos/Ener-Getick/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ener-Getick/symfony/downloads","issues_url":"https://api.github.com/repos/Ener-Getick/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Ener-Getick/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Ener-Getick/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Ener-Getick/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ener-Getick/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Ener-Getick/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Ener-Getick/symfony/deployments","created_at":"2015-12-02T17:11:04Z","updated_at":"2015-12-16T13:33:01Z","pushed_at":"2016-03-12T14:09:16Z","git_url":"git://github.com/Ener-Getick/symfony.git","ssh_url":"git@github.com:Ener-Getick/symfony.git","clone_url":"https://github.com/Ener-Getick/symfony.git","svn_url":"https://github.com/Ener-Getick/symfony","homepage":"symfony.com","size":68958,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"bb2727a6804d1c8a0e0cadc7ad9791d2d096c443","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-03-14T07:50:28Z","pushed_at":"2016-03-14T07:00:14Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":103640,"stargazers_count":11924,"watchers_count":11924,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4691,"mirror_url":null,"open_issues_count":703,"forks":4691,"open_issues":703,"watchers":11924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18101"},"html":{"href":"https://github.com/symfony/symfony/pull/18101"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18101"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18101/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18101/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18101/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ce324d6f3572c48a78c3feb2d334327fea2b59c0"}}}}