{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/56300919","id":56300919,"diff_hunk":"@@ -72,7 +72,7 @@\n                                     <td>\n                                         <ul>\n                                         {% for option in variant.options %}\n-                                            <li><strong>{{ option.name }}</strong>: {{ option.value }}</li>\n+                                            <li><strong>{{ option.presentation }}</strong>: {{ option.value }}</li>","path":"src/Sylius/Bundle/WebBundle/Resources/views/Backend/Inventory/macros.html.twig","position":5,"original_position":5,"commit_id":"ff0bf2289d224b8064913c11de74f122cb0cbcd7","original_commit_id":"e7bb21158116eb4e18dffa5c47da137d9de97eeb","user":{"login":"nakashu","id":1550659,"avatar_url":"https://avatars.githubusercontent.com/u/1550659?v=3","gravatar_id":"","url":"https://api.github.com/users/nakashu","html_url":"https://github.com/nakashu","followers_url":"https://api.github.com/users/nakashu/followers","following_url":"https://api.github.com/users/nakashu/following{/other_user}","gists_url":"https://api.github.com/users/nakashu/gists{/gist_id}","starred_url":"https://api.github.com/users/nakashu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakashu/subscriptions","organizations_url":"https://api.github.com/users/nakashu/orgs","repos_url":"https://api.github.com/users/nakashu/repos","events_url":"https://api.github.com/users/nakashu/events{/privacy}","received_events_url":"https://api.github.com/users/nakashu/received_events","type":"User","site_admin":false},"body":"rename is simple. but the object level changes are more important. will update it later todat.","created_at":"2016-03-16T09:10:18Z","updated_at":"2016-03-16T09:10:18Z","html_url":"https://github.com/Sylius/Sylius/pull/4514#discussion_r56300919","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4514","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/56300919"},"html":{"href":"https://github.com/Sylius/Sylius/pull/4514#discussion_r56300919"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4514"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/4514","id":62984532,"html_url":"https://github.com/Sylius/Sylius/pull/4514","diff_url":"https://github.com/Sylius/Sylius/pull/4514.diff","patch_url":"https://github.com/Sylius/Sylius/pull/4514.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/4514","number":4514,"state":"open","locked":false,"title":"[OptionValue][Core] - various fixes after option value model changes","user":{"login":"nakashu","id":1550659,"avatar_url":"https://avatars.githubusercontent.com/u/1550659?v=3","gravatar_id":"","url":"https://api.github.com/users/nakashu","html_url":"https://github.com/nakashu","followers_url":"https://api.github.com/users/nakashu/followers","following_url":"https://api.github.com/users/nakashu/following{/other_user}","gists_url":"https://api.github.com/users/nakashu/gists{/gist_id}","starred_url":"https://api.github.com/users/nakashu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakashu/subscriptions","organizations_url":"https://api.github.com/users/nakashu/orgs","repos_url":"https://api.github.com/users/nakashu/repos","events_url":"https://api.github.com/users/nakashu/events{/privacy}","received_events_url":"https://api.github.com/users/nakashu/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | no\r\n| Deprecations?   | no\r\n| Related tickets | fixes #4449\r\n| License         | MIT\r\n\r\nFixed:\r\n* in inventory, where the script will throw an exception,\r\n* cyrilc translations referenced in #4449 \r\n* translation and validation strings and keys\r\n\r\nMaybe for consistency all mentions of `presentation` should be changed to `name` in OptionValue and probably in productVariant. As it is proxied to the name anyway.\r\n\r\n```php\r\n    // OptionValue.php\r\n    /**\r\n     * {@inheritdoc}\r\n     */\r\n    public function getPresentation()\r\n    {\r\n        if (null === $this->option) {\r\n            throw new \\BadMethodCallException('The option have not been created yet so you cannot access proxy methods.');\r\n        }\r\n\r\n        return $this->option->getName();\r\n    }\r\n```\r\n\r\n","created_at":"2016-03-15T22:03:03Z","updated_at":"2016-03-16T09:10:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8badb13e9eaa6682b9898c19131e55b332f5f048","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4514/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4514/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/4514/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/ff0bf2289d224b8064913c11de74f122cb0cbcd7","head":{"label":"nakashu:fix/option-value-fields-changes","ref":"fix/option-value-fields-changes","sha":"ff0bf2289d224b8064913c11de74f122cb0cbcd7","user":{"login":"nakashu","id":1550659,"avatar_url":"https://avatars.githubusercontent.com/u/1550659?v=3","gravatar_id":"","url":"https://api.github.com/users/nakashu","html_url":"https://github.com/nakashu","followers_url":"https://api.github.com/users/nakashu/followers","following_url":"https://api.github.com/users/nakashu/following{/other_user}","gists_url":"https://api.github.com/users/nakashu/gists{/gist_id}","starred_url":"https://api.github.com/users/nakashu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakashu/subscriptions","organizations_url":"https://api.github.com/users/nakashu/orgs","repos_url":"https://api.github.com/users/nakashu/repos","events_url":"https://api.github.com/users/nakashu/events{/privacy}","received_events_url":"https://api.github.com/users/nakashu/received_events","type":"User","site_admin":false},"repo":{"id":42724236,"name":"Sylius","full_name":"nakashu/Sylius","owner":{"login":"nakashu","id":1550659,"avatar_url":"https://avatars.githubusercontent.com/u/1550659?v=3","gravatar_id":"","url":"https://api.github.com/users/nakashu","html_url":"https://github.com/nakashu","followers_url":"https://api.github.com/users/nakashu/followers","following_url":"https://api.github.com/users/nakashu/following{/other_user}","gists_url":"https://api.github.com/users/nakashu/gists{/gist_id}","starred_url":"https://api.github.com/users/nakashu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakashu/subscriptions","organizations_url":"https://api.github.com/users/nakashu/orgs","repos_url":"https://api.github.com/users/nakashu/repos","events_url":"https://api.github.com/users/nakashu/events{/privacy}","received_events_url":"https://api.github.com/users/nakashu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nakashu/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/nakashu/Sylius","forks_url":"https://api.github.com/repos/nakashu/Sylius/forks","keys_url":"https://api.github.com/repos/nakashu/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nakashu/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nakashu/Sylius/teams","hooks_url":"https://api.github.com/repos/nakashu/Sylius/hooks","issue_events_url":"https://api.github.com/repos/nakashu/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/nakashu/Sylius/events","assignees_url":"https://api.github.com/repos/nakashu/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/nakashu/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/nakashu/Sylius/tags","blobs_url":"https://api.github.com/repos/nakashu/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nakashu/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nakashu/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/nakashu/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nakashu/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/nakashu/Sylius/languages","stargazers_url":"https://api.github.com/repos/nakashu/Sylius/stargazers","contributors_url":"https://api.github.com/repos/nakashu/Sylius/contributors","subscribers_url":"https://api.github.com/repos/nakashu/Sylius/subscribers","subscription_url":"https://api.github.com/repos/nakashu/Sylius/subscription","commits_url":"https://api.github.com/repos/nakashu/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/nakashu/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/nakashu/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/nakashu/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/nakashu/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/nakashu/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nakashu/Sylius/merges","archive_url":"https://api.github.com/repos/nakashu/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nakashu/Sylius/downloads","issues_url":"https://api.github.com/repos/nakashu/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/nakashu/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/nakashu/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/nakashu/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nakashu/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/nakashu/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/nakashu/Sylius/deployments","created_at":"2015-09-18T13:35:58Z","updated_at":"2016-02-11T22:25:23Z","pushed_at":"2016-03-16T08:40:31Z","git_url":"git://github.com/nakashu/Sylius.git","ssh_url":"git@github.com:nakashu/Sylius.git","clone_url":"https://github.com/nakashu/Sylius.git","svn_url":"https://github.com/nakashu/Sylius","homepage":"Sylius.org","size":26555,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"9b61490426dea47e118695c6a866431a42425a7c","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-03-16T08:31:49Z","pushed_at":"2016-03-16T08:51:33Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":58204,"stargazers_count":2212,"watchers_count":2212,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":805,"mirror_url":null,"open_issues_count":587,"forks":805,"open_issues":587,"watchers":2212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4514"},"html":{"href":"https://github.com/Sylius/Sylius/pull/4514"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4514"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4514/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4514/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4514/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/ff0bf2289d224b8064913c11de74f122cb0cbcd7"}}}}