{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/93161354","pull_request_review_id":13683006,"id":93161354,"diff_hunk":"@@ -298,6 +301,10 @@ func (daemon *Daemon) createNetwork(create types.NetworkCreateRequest, id string\n \t\treturn nil, err\n \t}\n \n+\tdaemon.pluginRefCount(driver, driverapi.NetworkPluginEndpointType, plugingetter.ACQUIRE)","path":"daemon/network.go","position":16,"original_position":16,"commit_id":"c746a736049cf2ee5a372b07e94382fed57641cb","original_commit_id":"c746a736049cf2ee5a372b07e94382fed57641cb","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"body":"Outside the scope of this PR: all caps declarations are unusual in Go and clash with the typical style. I opened #29564 to change this. This PR can be merged first and then I'll rebase afterwards.","created_at":"2016-12-20T02:24:09Z","updated_at":"2016-12-20T02:24:09Z","html_url":"https://github.com/docker/docker/pull/29556#discussion_r93161354","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/29556","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/93161354"},"html":{"href":"https://github.com/docker/docker/pull/29556#discussion_r93161354"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/29556"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/29556","id":98656852,"html_url":"https://github.com/docker/docker/pull/29556","diff_url":"https://github.com/docker/docker/pull/29556.diff","patch_url":"https://github.com/docker/docker/pull/29556.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/29556","number":29556,"state":"open","locked":false,"title":"Fixing a couple of network plugin life-cycle mgmt issues","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"\r\nFixes https://github.com/docker/docker/issues/29447 : Reference count is managed for network plugins using ACQUIRE and RELEASE mechanism in createNetwork and deleteNetwork.\r\n\r\nFixes https://github.com/docker/docker/issues/29471 : libnetwork remote driver init is modified to lookup active plugins and registered with drvRegistry\r\n\r\nFixes https://github.com/docker/docker/issues/29473 : Since plugin rm is not fully propagated to drvRegistry, we allowed overriding the drvRegistry map to cleanup stale plugin socket\r\n\r\nAlso includes a fix from @anusha-ragunathan to honor Reference count during `docker plugin disable`. (This is applicable for all plugins). ","created_at":"2016-12-19T23:05:00Z","updated_at":"2016-12-20T02:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"680cfc0d008fc00e4d5e80fff863f4ba5b6af6b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/29556/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/29556/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/29556/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/c746a736049cf2ee5a372b07e94382fed57641cb","head":{"label":"mavenugo:refcount","ref":"refcount","sha":"c746a736049cf2ee5a372b07e94382fed57641cb","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"repo":{"id":25433630,"name":"docker","full_name":"mavenugo/docker","owner":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavenugo/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mavenugo/docker","forks_url":"https://api.github.com/repos/mavenugo/docker/forks","keys_url":"https://api.github.com/repos/mavenugo/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavenugo/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavenugo/docker/teams","hooks_url":"https://api.github.com/repos/mavenugo/docker/hooks","issue_events_url":"https://api.github.com/repos/mavenugo/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mavenugo/docker/events","assignees_url":"https://api.github.com/repos/mavenugo/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mavenugo/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mavenugo/docker/tags","blobs_url":"https://api.github.com/repos/mavenugo/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavenugo/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavenugo/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavenugo/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavenugo/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mavenugo/docker/languages","stargazers_url":"https://api.github.com/repos/mavenugo/docker/stargazers","contributors_url":"https://api.github.com/repos/mavenugo/docker/contributors","subscribers_url":"https://api.github.com/repos/mavenugo/docker/subscribers","subscription_url":"https://api.github.com/repos/mavenugo/docker/subscription","commits_url":"https://api.github.com/repos/mavenugo/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavenugo/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavenugo/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavenugo/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavenugo/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mavenugo/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavenugo/docker/merges","archive_url":"https://api.github.com/repos/mavenugo/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavenugo/docker/downloads","issues_url":"https://api.github.com/repos/mavenugo/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mavenugo/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mavenugo/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mavenugo/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavenugo/docker/labels{/name}","releases_url":"https://api.github.com/repos/mavenugo/docker/releases{/id}","deployments_url":"https://api.github.com/repos/mavenugo/docker/deployments","created_at":"2014-10-19T17:04:36Z","updated_at":"2015-04-24T13:45:12Z","pushed_at":"2016-12-20T00:50:46Z","git_url":"git://github.com/mavenugo/docker.git","ssh_url":"git@github.com:mavenugo/docker.git","clone_url":"https://github.com/mavenugo/docker.git","svn_url":"https://github.com/mavenugo/docker","homepage":"http://www.docker.com","size":117763,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"288e55c09b252e02b5201e7d2f2bf45a323d8105","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-12-20T00:42:45Z","pushed_at":"2016-12-20T02:23:10Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":118816,"stargazers_count":37955,"watchers_count":37955,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11323,"mirror_url":null,"open_issues_count":2041,"forks":11323,"open_issues":2041,"watchers":37955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/29556"},"html":{"href":"https://github.com/docker/docker/pull/29556"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/29556"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/29556/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/29556/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/29556/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/c746a736049cf2ee5a372b07e94382fed57641cb"}}}}
{"actor":{"display_login":"aaronlehmann"}}