{"action":"created","comment":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/76968732","id":76968732,"diff_hunk":"@@ -147,18 +164,21 @@ public void Should_return_configuration_when_configuring_any_call()\n             result.Should().BeSameAs(expectedConfiguration);\r\n         }\r\n \r\n-        [Fact]\r\n-        public void Should_add_call_rule_to_fake_manager_when_configuring_any_call()\r\n+        [SuppressMessage(\"Microsoft.Design\", \"CA1062:Validate arguments of public methods\", MessageId = \"0\", Justification = \"It's not really a public method\")]\r\n+        [Theory]\r\n+        [MemberData(nameof(CallSpecificationActions))]\r\n+        public void CallTo_should_not_add_rule_to_manager(Action<FakeConfigurationManagerTests, IFoo> action)\r\n         {\r\n             // Arrange\r\n-            var fake = A.Fake<IFoo>();\r\n-            var manager = Fake.GetFakeManager(fake);\r\n+            var foo = A.Fake<IFoo>();\r\n+            var manager = Fake.GetFakeManager(foo);\r\n+            var initialRules = manager.Rules.ToList();\r\n \r\n             // Act\r\n-            this.configurationManager.CallTo(fake);\r\n+            action(this, foo);\r","path":"tests/FakeItEasy.Tests/Configuration/FakeConfigurationManagerTests.cs","position":51,"original_position":51,"commit_id":"e9a86a09f1857907030cd2e776a0c61d4322e219","original_commit_id":"e9a86a09f1857907030cd2e776a0c61d4322e219","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"body":"I found all the `@this`es up near line 35 distracting. How do you feel about just passing `configurationManager` in here instead of `this`? I think it better reveals which object's being manipulated.","created_at":"2016-08-31T11:12:59Z","updated_at":"2016-08-31T11:12:59Z","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/840#discussion_r76968732","pull_request_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840","_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/76968732"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/840#discussion_r76968732"},"pull_request":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840"}}},"pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840","id":82993067,"html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/840","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/840.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/840.patch","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/840","number":840,"state":"open","locked":false,"title":"Make A.CallTo side-effect free","user":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars.githubusercontent.com/u/1864281?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"body":"Fixes #556 \r\n\r\n~~This is my first stab at it, still a work in progress.~~\r\n~~The implementation is not yet complete, there are a few other cases that I need to look into.~~\r\n~~The current tests pass, but I need to add new ones to validate the new behavior.~~","created_at":"2016-08-27T17:07:17Z","updated_at":"2016-08-31T11:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b159901e86ffdb3cd218245c38680de5d7a9a94f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840/commits","review_comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840/comments","review_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/840/comments","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/e9a86a09f1857907030cd2e776a0c61d4322e219","head":{"label":"thomaslevesque:remove-callto-side-effect","ref":"remove-callto-side-effect","sha":"e9a86a09f1857907030cd2e776a0c61d4322e219","user":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars.githubusercontent.com/u/1864281?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"repo":{"id":31570944,"name":"FakeItEasy","full_name":"thomaslevesque/FakeItEasy","owner":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars.githubusercontent.com/u/1864281?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaslevesque/FakeItEasy","description":"The easy mocking library for .NET","fork":true,"url":"https://api.github.com/repos/thomaslevesque/FakeItEasy","forks_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/forks","keys_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/events","assignees_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/merges","archive_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/deployments","created_at":"2015-03-03T00:22:47Z","updated_at":"2016-01-13T20:13:45Z","pushed_at":"2016-08-30T20:54:01Z","git_url":"git://github.com/thomaslevesque/FakeItEasy.git","ssh_url":"git@github.com:thomaslevesque/FakeItEasy.git","clone_url":"https://github.com/thomaslevesque/FakeItEasy.git","svn_url":"https://github.com/thomaslevesque/FakeItEasy","homepage":"fakeiteasy.github.io","size":20475,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FakeItEasy:master","ref":"master","sha":"ba2335188c17109eae9758651014fbf3c694f9a6","user":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=3","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"repo":{"id":1920133,"name":"FakeItEasy","full_name":"FakeItEasy/FakeItEasy","owner":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=3","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FakeItEasy/FakeItEasy","description":"The easy mocking library for .NET","fork":false,"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","forks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/forks","keys_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/events","assignees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/merges","archive_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/deployments","created_at":"2011-06-19T17:56:01Z","updated_at":"2016-08-29T10:34:13Z","pushed_at":"2016-08-30T20:54:02Z","git_url":"git://github.com/FakeItEasy/FakeItEasy.git","ssh_url":"git@github.com:FakeItEasy/FakeItEasy.git","clone_url":"https://github.com/FakeItEasy/FakeItEasy.git","svn_url":"https://github.com/FakeItEasy/FakeItEasy","homepage":"fakeiteasy.github.io","size":22785,"stargazers_count":576,"watchers_count":576,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":46,"forks":117,"open_issues":46,"watchers":576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/840"},"issue":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/840"},"comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/e9a86a09f1857907030cd2e776a0c61d4322e219"}}}}
{"actor":{"display_login":"blairconrad"}}