{"action":"created","issue":{"url":"https://api.github.com/repos/concourse/git-resource/issues/53","repository_url":"https://api.github.com/repos/concourse/git-resource","labels_url":"https://api.github.com/repos/concourse/git-resource/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/concourse/git-resource/issues/53/comments","events_url":"https://api.github.com/repos/concourse/git-resource/issues/53/events","html_url":"https://github.com/concourse/git-resource/pull/53","id":153027588,"number":53,"title":"check returns commits in topological order","user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/concourse/git-resource/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/concourse/git-resource/labels/unscheduled","name":"unscheduled","color":"e4eff7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-05-04T14:35:25Z","updated_at":"2016-07-12T08:53:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concourse/git-resource/pulls/53","html_url":"https://github.com/concourse/git-resource/pull/53","diff_url":"https://github.com/concourse/git-resource/pull/53.diff","patch_url":"https://github.com/concourse/git-resource/pull/53.patch"},"body":"When check returns all the commits from a given ref, currently it returns them ~~without a specific order~~ in the default chronological order, although the first commit is the given ref and the last HEAD.\r\n\r\nBut this might be confusing for the end user when looking at the git history of the repos and the version list stored in concourse, which was reported by the check command.\r\n\r\nAn alternate approach is to show the commits in topological order, as explained by --topo-order in git-log [1]:\r\n\r\n> Show no parents before all of its children are shown, and avoid\r\n> showing commits on multiple lines of history intermixed.\r\n> for example, in a commit history like this:\r\n> ```\r\n>    ---1----2----4----7\r\n>    \\       \\\r\n>     3----5----6----8---\r\n> ```\r\n>\r\n> where the numbers denote the order of commit timestamps, git rev-list and friends with --date-order show the commits in the timestamp order: 8 7 6 5 4 3 2 1.\r\n> With --topo-order, they would show 8 6 5 3 7 4 2 1 (or 8 7 4 2 6 5 3 1); some older commits are shown before newer ones in order to avoid showing the commits from two parallel development track mixed together.\r\n\r\n\r\n[1] https://git-scm.com/docs/git-log"},"comment":{"url":"https://api.github.com/repos/concourse/git-resource/issues/comments/231978140","html_url":"https://github.com/concourse/git-resource/pull/53#issuecomment-231978140","issue_url":"https://api.github.com/repos/concourse/git-resource/issues/53","id":231978140,"user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T08:53:31Z","updated_at":"2016-07-12T08:53:31Z","body":"Fine for me.\r\n\r\nTo be sincere I was hoping to solve some situations where git resource returns the git commits in a different order than what I expect. But I am not able to reproduce it in a consistent way and I don't know if this fixes it. \r\n\r\nI will close this for the time being."}}
{"actor":{"display_login":"keymon"}}