{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2","id":71419113,"html_url":"https://github.com/salsify/salsify_rubocop/pull/2","diff_url":"https://github.com/salsify/salsify_rubocop/pull/2.diff","patch_url":"https://github.com/salsify/salsify_rubocop/pull/2.patch","issue_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/2","number":2,"state":"closed","locked":false,"title":"Configuration updates","user":{"login":"tjwp","id":1476506,"avatar_url":"https://avatars.githubusercontent.com/u/1476506?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwp","html_url":"https://github.com/tjwp","followers_url":"https://api.github.com/users/tjwp/followers","following_url":"https://api.github.com/users/tjwp/following{/other_user}","gists_url":"https://api.github.com/users/tjwp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwp/subscriptions","organizations_url":"https://api.github.com/users/tjwp/orgs","repos_url":"https://api.github.com/users/tjwp/repos","events_url":"https://api.github.com/users/tjwp/events{/privacy}","received_events_url":"https://api.github.com/users/tjwp/received_events","type":"User","site_admin":false},"body":"For background, this gem contains specific version dependencies for rubocop and rubocop-rspec\r\nand shared configuration that we're using for newer applications and gems.\r\n\r\nThe configuration changes here represent overrides that have been used in multiple repos recently:\r\n\r\n* Style/ModuleFunction: This prefers `module_function` over `extend self`. We don't want that.\r\n\r\n* Style/RaiseArgs: The 'compact' style selected here prefers:\r\n```ruby\r\n# good\r\nraise SomeError.new('foo')\r\n\r\n# bad\r\nraise SomeError, 'foo'\r\n```\r\n\r\n* Performance/RedundantMerge: This cop recommends against the use of `merge!`. It's configurable based on the number of keys passed to `merge!`. It prefers:\r\n\r\n```ruby\r\n# according to the cop\r\n# bad\r\nhash.merge!(one: 1, two: 2)\r\n\r\n# good\r\nhash[:one] = 1\r\nhash[:two] = 2\r\n```\r\n\r\nThe configuration here only allows it to complain when `merge!` has a single key, i.e.:\r\n```ruby\r\nhash.merge!(one: 1)\r\n# can be replaced by\r\nhash[:one] = 1\r\n```\r\n\r\nPrime: @fgarces ","created_at":"2016-05-25T16:07:42Z","updated_at":"2016-05-31T17:32:33Z","closed_at":"2016-05-31T17:32:33Z","merged_at":"2016-05-31T17:32:33Z","merge_commit_sha":"b848a282174d4e0f4dbfc8490dce062c90b6a098","assignee":{"login":"fgarces","id":7518506,"avatar_url":"https://avatars.githubusercontent.com/u/7518506?v=3","gravatar_id":"","url":"https://api.github.com/users/fgarces","html_url":"https://github.com/fgarces","followers_url":"https://api.github.com/users/fgarces/followers","following_url":"https://api.github.com/users/fgarces/following{/other_user}","gists_url":"https://api.github.com/users/fgarces/gists{/gist_id}","starred_url":"https://api.github.com/users/fgarces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgarces/subscriptions","organizations_url":"https://api.github.com/users/fgarces/orgs","repos_url":"https://api.github.com/users/fgarces/repos","events_url":"https://api.github.com/users/fgarces/events{/privacy}","received_events_url":"https://api.github.com/users/fgarces/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2/commits","review_comments_url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2/comments","review_comment_url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/2/comments","statuses_url":"https://api.github.com/repos/salsify/salsify_rubocop/statuses/d2093aef7b8a569d290cd3e43a6032368c6d23e7","head":{"label":"salsify:cop-updates","ref":"cop-updates","sha":"d2093aef7b8a569d290cd3e43a6032368c6d23e7","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":59226827,"name":"salsify_rubocop","full_name":"salsify/salsify_rubocop","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/salsify_rubocop","description":"Salsify shared RuboCop configuration","fork":false,"url":"https://api.github.com/repos/salsify/salsify_rubocop","forks_url":"https://api.github.com/repos/salsify/salsify_rubocop/forks","keys_url":"https://api.github.com/repos/salsify/salsify_rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/salsify_rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/salsify_rubocop/teams","hooks_url":"https://api.github.com/repos/salsify/salsify_rubocop/hooks","issue_events_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/salsify_rubocop/events","assignees_url":"https://api.github.com/repos/salsify/salsify_rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/salsify_rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/salsify_rubocop/tags","blobs_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/salsify_rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/salsify_rubocop/languages","stargazers_url":"https://api.github.com/repos/salsify/salsify_rubocop/stargazers","contributors_url":"https://api.github.com/repos/salsify/salsify_rubocop/contributors","subscribers_url":"https://api.github.com/repos/salsify/salsify_rubocop/subscribers","subscription_url":"https://api.github.com/repos/salsify/salsify_rubocop/subscription","commits_url":"https://api.github.com/repos/salsify/salsify_rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/salsify_rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/salsify_rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/salsify_rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/salsify_rubocop/merges","archive_url":"https://api.github.com/repos/salsify/salsify_rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/salsify_rubocop/downloads","issues_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/salsify_rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/salsify_rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/salsify_rubocop/labels{/name}","releases_url":"https://api.github.com/repos/salsify/salsify_rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/salsify/salsify_rubocop/deployments","created_at":"2016-05-19T17:13:13Z","updated_at":"2016-05-19T17:15:10Z","pushed_at":"2016-05-31T17:32:34Z","git_url":"git://github.com/salsify/salsify_rubocop.git","ssh_url":"git@github.com:salsify/salsify_rubocop.git","clone_url":"https://github.com/salsify/salsify_rubocop.git","svn_url":"https://github.com/salsify/salsify_rubocop","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salsify:master","ref":"master","sha":"2b1477ef3c2842ff74d55248802262e586392f56","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":59226827,"name":"salsify_rubocop","full_name":"salsify/salsify_rubocop","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/salsify_rubocop","description":"Salsify shared RuboCop configuration","fork":false,"url":"https://api.github.com/repos/salsify/salsify_rubocop","forks_url":"https://api.github.com/repos/salsify/salsify_rubocop/forks","keys_url":"https://api.github.com/repos/salsify/salsify_rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/salsify_rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/salsify_rubocop/teams","hooks_url":"https://api.github.com/repos/salsify/salsify_rubocop/hooks","issue_events_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/salsify_rubocop/events","assignees_url":"https://api.github.com/repos/salsify/salsify_rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/salsify_rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/salsify_rubocop/tags","blobs_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/salsify_rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/salsify_rubocop/languages","stargazers_url":"https://api.github.com/repos/salsify/salsify_rubocop/stargazers","contributors_url":"https://api.github.com/repos/salsify/salsify_rubocop/contributors","subscribers_url":"https://api.github.com/repos/salsify/salsify_rubocop/subscribers","subscription_url":"https://api.github.com/repos/salsify/salsify_rubocop/subscription","commits_url":"https://api.github.com/repos/salsify/salsify_rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/salsify_rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/salsify_rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/salsify_rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/salsify_rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/salsify_rubocop/merges","archive_url":"https://api.github.com/repos/salsify/salsify_rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/salsify_rubocop/downloads","issues_url":"https://api.github.com/repos/salsify/salsify_rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/salsify_rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/salsify_rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/salsify_rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/salsify_rubocop/labels{/name}","releases_url":"https://api.github.com/repos/salsify/salsify_rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/salsify/salsify_rubocop/deployments","created_at":"2016-05-19T17:13:13Z","updated_at":"2016-05-19T17:15:10Z","pushed_at":"2016-05-31T17:32:34Z","git_url":"git://github.com/salsify/salsify_rubocop.git","ssh_url":"git@github.com:salsify/salsify_rubocop.git","clone_url":"https://github.com/salsify/salsify_rubocop.git","svn_url":"https://github.com/salsify/salsify_rubocop","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2"},"html":{"href":"https://github.com/salsify/salsify_rubocop/pull/2"},"issue":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/issues/2"},"comments":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/salsify/salsify_rubocop/statuses/d2093aef7b8a569d290cd3e43a6032368c6d23e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tjwp","id":1476506,"avatar_url":"https://avatars.githubusercontent.com/u/1476506?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwp","html_url":"https://github.com/tjwp","followers_url":"https://api.github.com/users/tjwp/followers","following_url":"https://api.github.com/users/tjwp/following{/other_user}","gists_url":"https://api.github.com/users/tjwp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwp/subscriptions","organizations_url":"https://api.github.com/users/tjwp/orgs","repos_url":"https://api.github.com/users/tjwp/repos","events_url":"https://api.github.com/users/tjwp/events{/privacy}","received_events_url":"https://api.github.com/users/tjwp/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":22,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"tjwp"}}