{"action":"created","issue":{"url":"https://api.github.com/repos/curl/curl/issues/730","repository_url":"https://api.github.com/repos/curl/curl","labels_url":"https://api.github.com/repos/curl/curl/issues/730/labels{/name}","comments_url":"https://api.github.com/repos/curl/curl/issues/730/comments","events_url":"https://api.github.com/repos/curl/curl/issues/730/events","html_url":"https://github.com/curl/curl/pull/730","id":143539596,"number":730,"title":"Fix GEN_PDB option for release builds using MakefileBuild.vc to match Visual Studio project files","user":{"login":"mcconkeyp","id":6552518,"avatar_url":"https://avatars.githubusercontent.com/u/6552518?v=3","gravatar_id":"","url":"https://api.github.com/users/mcconkeyp","html_url":"https://github.com/mcconkeyp","followers_url":"https://api.github.com/users/mcconkeyp/followers","following_url":"https://api.github.com/users/mcconkeyp/following{/other_user}","gists_url":"https://api.github.com/users/mcconkeyp/gists{/gist_id}","starred_url":"https://api.github.com/users/mcconkeyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcconkeyp/subscriptions","organizations_url":"https://api.github.com/users/mcconkeyp/orgs","repos_url":"https://api.github.com/users/mcconkeyp/repos","events_url":"https://api.github.com/users/mcconkeyp/events{/privacy}","received_events_url":"https://api.github.com/users/mcconkeyp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/curl/curl/labels/build","name":"build","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-03-25T16:48:30Z","updated_at":"2016-08-27T08:58:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/curl/curl/pulls/730","html_url":"https://github.com/curl/curl/pull/730","diff_url":"https://github.com/curl/curl/pull/730.diff","patch_url":"https://github.com/curl/curl/pull/730.patch"},"body":"Symbol database (PDB) files are not being added to the release DLL target because the /DEBUG switch is not added to the linker command line for release DLL builds.\r\n\r\nA PBD file is being generated for the import library, but this does not provide symbols for the DLL.\r\n\r\nI have modified LFLAGS_PDB so that the /DEBUG switch is used by the linker for all builds that require a PDB file. The /incremental:no switch is implied by /DEBUG so /incremental:no is removed.\r\n\r\nAs the linker uses the target DLL name to create a filename for the PDB file, the PBD file for the import library is overwritten by the linker. I have added '_imp' to the name that will be used for the import library PDB file. Both files are now copied to the distribution lib folder.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/curl/curl/issues/comments/242905759","html_url":"https://github.com/curl/curl/pull/730#issuecomment-242905759","issue_url":"https://api.github.com/repos/curl/curl/issues/730","id":242905759,"user":{"login":"captain-caveman2k","id":1523871,"avatar_url":"https://avatars.githubusercontent.com/u/1523871?v=3","gravatar_id":"","url":"https://api.github.com/users/captain-caveman2k","html_url":"https://github.com/captain-caveman2k","followers_url":"https://api.github.com/users/captain-caveman2k/followers","following_url":"https://api.github.com/users/captain-caveman2k/following{/other_user}","gists_url":"https://api.github.com/users/captain-caveman2k/gists{/gist_id}","starred_url":"https://api.github.com/users/captain-caveman2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captain-caveman2k/subscriptions","organizations_url":"https://api.github.com/users/captain-caveman2k/orgs","repos_url":"https://api.github.com/users/captain-caveman2k/repos","events_url":"https://api.github.com/users/captain-caveman2k/events{/privacy}","received_events_url":"https://api.github.com/users/captain-caveman2k/received_events","type":"User","site_admin":false},"created_at":"2016-08-27T08:58:58Z","updated_at":"2016-08-27T08:58:58Z","body":"@mcconkeyp Just a couple of follow up queries:\r\n\r\n* IS GEN_PDB defaulted to true (if it isn't set) for debug builds? If it isn't then I think it should be to maintain current/default behaviour for debug builds\r\n* Rather than copy the .pdb files to \\lib and then move them to \\bin if the build is DLL, assuming I have understood the current code correctly, it would be slightly more efficient to copy them to \\lib if not a DLL build and copy them to \\bin if a DLL build\r\n\r\n@bagder Once my points are addressed then its a +1 from me ;-)"}}
{"actor":{"display_login":"captain-caveman2k"}}