{"push_id":953511499,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"3cf591c60077e23e00d25a710c79ea6156a103c1","before":"155dbb44c2bd08a0d1c39b7de8fc601a6a4cf375","commits":[{"sha":"24ed35215a9ea745295fa78519d7dbf458b5b472","author":{"email":"5fe4d20cf6ab8a2cf4e5e71d4c2d58346e96df0d@intel.com","name":"Raphael Kubo da Costa"},"message":"Move the variable setting logic from gyp_xwalk to build/common.gypi.\n\nSetting variables in gyp_xwalk was a historical mistake and likely came\nfrom failures to understand GYP's bizantine scoping and evaluation\nrules. Additionally, gyp_xwalk will not be used once we move to GN, so\nthis logic needs to be moved anyway.\n\nThe following variables were being set in gyp_xwalk to the values they\nalready have as default in src/build/common.gypi and have thus just been\nremoved from gyp_xwalk and not added to src/xwalk/build/common.gypi:\n * notifications\n * use_aura\n * use_openmax_dl_fft\n\nQuick explanation about GYP's weird scoping and variable evaluation\nrules: one cannot set a variable in a scope and use it in a conditional\nblock in the same scope level, or set it in a conditional block and use\nit in another check in the same block and scope level. In other words,\nboth conditionals below will evaluate to false:\n  'variables': {\n    'foo%': 1,\n    'conditionals': [\n      [\"foo == 1\", {\n        'bar%': 42,\n      }],\n      [\"bar == 42\", {\n        'baz%': 34,\n      }],\n    ],\n  }\nFor it to work, we need to define some variable-within-variable blocks\nso that the variables and their values are properly seen by the\nconditional blocks. To complicate things further, since this .gypi file\nis automatically merged into all other .gyp and .gypi files we need to\nput any variables we set in a conditions block into another variables\nscope to avoid the situation where another .gypi file checks for the\nvariable's value in the same scope we're setting it in a conditional.\n\nA lot of comments were added to the file to make this whole mess clear\nto future readers.\n\nAlso related to the above, we are now including src/build/common.gypi\nbefore src/xwalk/build/common.gypi, so that the values we set in the\nlatter do not get overridden by the former.\n\nTesting done: run gyp_xwalk without this patch, build a target like\n\"xwalk\", apply the patch, run gyp_xwalk again. Building the target again\nshould do nothing (on Android it's easier to pass -Denable_webcl=0,\notherwise -DENABLE_WEBCL=1 will be passed in another position in the\ncommand line and needlessly make everything be rebuilt).\n\nBUG=XWALK-3674","distinct":true,"url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits/24ed35215a9ea745295fa78519d7dbf458b5b472"},{"sha":"3cf591c60077e23e00d25a710c79ea6156a103c1","author":{"email":"5fe4d20cf6ab8a2cf4e5e71d4c2d58346e96df0d@intel.com","name":"Raphael Kubo da Costa"},"message":"Merge pull request #3512 from rakuco/move-variable-definitions-out-of-gyp_xwalk\n\nMove the variable setting logic from gyp_xwalk to build/common.gypi.","distinct":true,"url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits/3cf591c60077e23e00d25a710c79ea6156a103c1"}]}