{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/704","repository_url":"https://api.github.com/repos/sul-dlss/sul-embed","labels_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/704/comments","events_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/704/events","html_url":"https://github.com/sul-dlss/sul-embed/pull/704","id":176141175,"number":704,"title":"Force the use of Flash when the browser is IE or Edge on Windows 10.","user":{"login":"tingulfsen","id":3740294,"avatar_url":"https://avatars.githubusercontent.com/u/3740294?v=3","gravatar_id":"","url":"https://api.github.com/users/tingulfsen","html_url":"https://github.com/tingulfsen","followers_url":"https://api.github.com/users/tingulfsen/followers","following_url":"https://api.github.com/users/tingulfsen/following{/other_user}","gists_url":"https://api.github.com/users/tingulfsen/gists{/gist_id}","starred_url":"https://api.github.com/users/tingulfsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tingulfsen/subscriptions","organizations_url":"https://api.github.com/users/tingulfsen/orgs","repos_url":"https://api.github.com/users/tingulfsen/repos","events_url":"https://api.github.com/users/tingulfsen/events{/privacy}","received_events_url":"https://api.github.com/users/tingulfsen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sul-dlss/sul-embed/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-10T00:16:07Z","updated_at":"2016-09-12T16:45:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/pulls/704","html_url":"https://github.com/sul-dlss/sul-embed/pull/704","diff_url":"https://github.com/sul-dlss/sul-embed/pull/704.diff","patch_url":"https://github.com/sul-dlss/sul-embed/pull/704.patch"},"body":"Fixes #701 \r\n\r\nThis PR pulls in the Client.js browser fingerprinting library, a small JavaScript library that I think does a fairly decent job at figuring out what browser is being used. It mainly uses the user agent string for what we're doing here, I believe, but is probably more robust than rolling our own UA parsing.\r\n\r\nThis PR updates the media viewer JS code to force the use of Flash on Windows 10 with the Microsoft browsers (Edge and IE). This is due to a known issue with the VideoJS HLS plugin:\r\n\r\nhttps://github.com/videojs/videojs-contrib-hls#known-issues\r\n\r\nhttps://github.com/videojs/videojs-contrib-hls/issues/833\r\n\r\nHopefully this problem will be resolved either by the VideoJS HLS plugin authors or by Microsoft in the not too distant future. Until then, the only recommended solution is to force Flash. Note that due to the nature of the bug, feature detection won't help us solve this one - hence browser detection/fingerprinting."},"comment":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/comments/246410217","html_url":"https://github.com/sul-dlss/sul-embed/pull/704#issuecomment-246410217","issue_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/704","id":246410217,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T16:45:07Z","updated_at":"2016-09-12T16:45:07Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7848068/badge)](https://coveralls.io/builds/7848068)\n\nCoverage remained the same at 98.796% when pulling **430ae550c028762879d95a9e14872576b90b7733 on 701-force-microsoft-flash** into **ef81ca0282ea4161adeee555faa195a5848227d4 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}