{"action":"created","issue":{"url":"https://api.github.com/repos/github/linguist/issues/3251","repository_url":"https://api.github.com/repos/github/linguist","labels_url":"https://api.github.com/repos/github/linguist/issues/3251/labels{/name}","comments_url":"https://api.github.com/repos/github/linguist/issues/3251/comments","events_url":"https://api.github.com/repos/github/linguist/issues/3251/events","html_url":"https://github.com/github/linguist/pull/3251","id":179325089,"number":3251,"title":"Strengthen license detection","user":{"login":"pchaigno","id":1764210,"avatar_url":"https://avatars.githubusercontent.com/u/1764210?v=3","gravatar_id":"","url":"https://api.github.com/users/pchaigno","html_url":"https://github.com/pchaigno","followers_url":"https://api.github.com/users/pchaigno/followers","following_url":"https://api.github.com/users/pchaigno/following{/other_user}","gists_url":"https://api.github.com/users/pchaigno/gists{/gist_id}","starred_url":"https://api.github.com/users/pchaigno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchaigno/subscriptions","organizations_url":"https://api.github.com/users/pchaigno/orgs","repos_url":"https://api.github.com/users/pchaigno/repos","events_url":"https://api.github.com/users/pchaigno/events{/privacy}","received_events_url":"https://api.github.com/users/pchaigno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-26T20:10:35Z","updated_at":"2016-09-26T20:43:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/github/linguist/pulls/3251","html_url":"https://github.com/github/linguist/pull/3251","diff_url":"https://github.com/github/linguist/pull/3251.diff","patch_url":"https://github.com/github/linguist/pull/3251.patch"},"body":"This pull request implements several changes to strengthen our mechanism to detect/recognize licenses. I broke it down into three commits:\r\n\r\n0. Enable the recognition of licenses in READMEs using Licensee with `detect_readme: true`.\r\n0. Use hashes to uniquely identify unrecognized licenses. This way we will be notified for any change in a license text.\r\n0. Remove our own license classification code and rely solely on Licensee's. Our classification code sometimes recognizes the wrong license (e.g., [atom/language-csharp](https://github.com/atom/language-csharp/blob/db4468545a8a1a5e76518e0ae2f6697dc21bf686/LICENSE.md) is detected as GPL), which is something we clearly do not want to happen.\r\n\r\n/cc @arfon @aroben @benbalter"},"comment":{"url":"https://api.github.com/repos/github/linguist/issues/comments/249691729","html_url":"https://github.com/github/linguist/pull/3251#issuecomment-249691729","issue_url":"https://api.github.com/repos/github/linguist/issues/3251","id":249691729,"user":{"login":"benbalter","id":282759,"avatar_url":"https://avatars.githubusercontent.com/u/282759?v=3","gravatar_id":"","url":"https://api.github.com/users/benbalter","html_url":"https://github.com/benbalter","followers_url":"https://api.github.com/users/benbalter/followers","following_url":"https://api.github.com/users/benbalter/following{/other_user}","gists_url":"https://api.github.com/users/benbalter/gists{/gist_id}","starred_url":"https://api.github.com/users/benbalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbalter/subscriptions","organizations_url":"https://api.github.com/users/benbalter/orgs","repos_url":"https://api.github.com/users/benbalter/repos","events_url":"https://api.github.com/users/benbalter/events{/privacy}","received_events_url":"https://api.github.com/users/benbalter/received_events","type":"User","site_admin":true},"created_at":"2016-09-26T20:43:57Z","updated_at":"2016-09-26T20:43:57Z","body":"> Use hashes to uniquely identify unrecognized licenses. \r\n\r\nOne point of clarification, that shouldn't affect this PR, the hash is based off the normalized licensed body, which is the license body with whitespace *and the copyright notice* removed (in most cases), meaning it is possible for two projects to return the same hash. Put another way, the hash is deterministic of the normalized license text, not the project itself, so two projects may share a hash (but that doesn't seem to be a problem here)."}}
{"actor":{"display_login":"benbalter"}}