{"action":"created","comment":{"url":"https://api.github.com/repos/ultrabug/py3status/pulls/comments/83417150","pull_request_review_id":4263372,"id":83417150,"diff_hunk":"@@ -11,14 +11,11 @@\n     format: you MUST use placeholders here to display data, see below.\n         (default '')\n     graphite_url: URL to your graphite server. (default '')\n-    http_proxy: You can configure individual requests for the scheme HTTP,\n-        see http://docs.python-requests.org/en/master/user/advanced/#proxies\n-        (default: None)\n-    https_proxy: You can configure individual requests for the scheme HTTPS,\n-        see http://docs.python-requests.org/en/master/user/advanced/#proxies\n-        (default: None)\n     http_timeout: HTTP query timeout to graphite.\n         (default 10)\n+    proxy: You can configure the proxy with HTTP or HTTPS.\n+        See: http://docs.python-requests.org/en/master/user/advanced/#proxies","path":"py3status/modules/graphite.py","position":null,"original_position":13,"commit_id":"5e229b2a86dcf4a0806ea27fcfb4f57caea4b4c3","original_commit_id":"5e229b2a86dcf4a0806ea27fcfb4f57caea4b4c3","user":{"login":"tobes","id":56311,"avatar_url":"https://avatars.githubusercontent.com/u/56311?v=3","gravatar_id":"","url":"https://api.github.com/users/tobes","html_url":"https://github.com/tobes","followers_url":"https://api.github.com/users/tobes/followers","following_url":"https://api.github.com/users/tobes/following{/other_user}","gists_url":"https://api.github.com/users/tobes/gists{/gist_id}","starred_url":"https://api.github.com/users/tobes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobes/subscriptions","organizations_url":"https://api.github.com/users/tobes/orgs","repos_url":"https://api.github.com/users/tobes/repos","events_url":"https://api.github.com/users/tobes/events{/privacy}","received_events_url":"https://api.github.com/users/tobes/received_events","type":"User","site_admin":false},"body":"I'd remove this link.\r\n\r\n1) It is specific to requests and the module should be neutral about the lib it happens to use.\r\n\r\n2) The requests documentation is not very helpful.  I had to read the code to work out what the http/https was all about.\r\n\r\n3) a simple example would be better for users to understand how to use","created_at":"2016-10-14T13:05:17Z","updated_at":"2016-10-14T13:05:17Z","html_url":"https://github.com/ultrabug/py3status/pull/510#discussion_r83417150","pull_request_url":"https://api.github.com/repos/ultrabug/py3status/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/comments/83417150"},"html":{"href":"https://github.com/ultrabug/py3status/pull/510#discussion_r83417150"},"pull_request":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/ultrabug/py3status/pulls/510","id":89356957,"html_url":"https://github.com/ultrabug/py3status/pull/510","diff_url":"https://github.com/ultrabug/py3status/pull/510.diff","patch_url":"https://github.com/ultrabug/py3status/pull/510.patch","issue_url":"https://api.github.com/repos/ultrabug/py3status/issues/510","number":510,"state":"open","locked":false,"title":"modules/graphite: Allow to set the http and https proxies","user":{"login":"btall","id":6665717,"avatar_url":"https://avatars.githubusercontent.com/u/6665717?v=3","gravatar_id":"","url":"https://api.github.com/users/btall","html_url":"https://github.com/btall","followers_url":"https://api.github.com/users/btall/followers","following_url":"https://api.github.com/users/btall/following{/other_user}","gists_url":"https://api.github.com/users/btall/gists{/gist_id}","starred_url":"https://api.github.com/users/btall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btall/subscriptions","organizations_url":"https://api.github.com/users/btall/orgs","repos_url":"https://api.github.com/users/btall/repos","events_url":"https://api.github.com/users/btall/events{/privacy}","received_events_url":"https://api.github.com/users/btall/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-14T10:02:56Z","updated_at":"2016-10-14T13:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90add2a71c8b6cc25e9ae29783f02d98e200d7f2","assignee":{"login":"ultrabug","id":474389,"avatar_url":"https://avatars.githubusercontent.com/u/474389?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrabug","html_url":"https://github.com/ultrabug","followers_url":"https://api.github.com/users/ultrabug/followers","following_url":"https://api.github.com/users/ultrabug/following{/other_user}","gists_url":"https://api.github.com/users/ultrabug/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrabug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrabug/subscriptions","organizations_url":"https://api.github.com/users/ultrabug/orgs","repos_url":"https://api.github.com/users/ultrabug/repos","events_url":"https://api.github.com/users/ultrabug/events{/privacy}","received_events_url":"https://api.github.com/users/ultrabug/received_events","type":"User","site_admin":false},"assignees":[{"login":"ultrabug","id":474389,"avatar_url":"https://avatars.githubusercontent.com/u/474389?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrabug","html_url":"https://github.com/ultrabug","followers_url":"https://api.github.com/users/ultrabug/followers","following_url":"https://api.github.com/users/ultrabug/following{/other_user}","gists_url":"https://api.github.com/users/ultrabug/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrabug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrabug/subscriptions","organizations_url":"https://api.github.com/users/ultrabug/orgs","repos_url":"https://api.github.com/users/ultrabug/repos","events_url":"https://api.github.com/users/ultrabug/events{/privacy}","received_events_url":"https://api.github.com/users/ultrabug/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ultrabug/py3status/milestones/2","html_url":"https://github.com/ultrabug/py3status/milestones/3.3","labels_url":"https://api.github.com/repos/ultrabug/py3status/milestones/2/labels","id":1944725,"number":2,"title":"3.3","description":"This release will be focused on the overall module normalization.","creator":{"login":"ultrabug","id":474389,"avatar_url":"https://avatars.githubusercontent.com/u/474389?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrabug","html_url":"https://github.com/ultrabug","followers_url":"https://api.github.com/users/ultrabug/followers","following_url":"https://api.github.com/users/ultrabug/following{/other_user}","gists_url":"https://api.github.com/users/ultrabug/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrabug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrabug/subscriptions","organizations_url":"https://api.github.com/users/ultrabug/orgs","repos_url":"https://api.github.com/users/ultrabug/repos","events_url":"https://api.github.com/users/ultrabug/events{/privacy}","received_events_url":"https://api.github.com/users/ultrabug/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":15,"state":"open","created_at":"2016-08-16T10:30:36Z","updated_at":"2016-10-14T12:31:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ultrabug/py3status/pulls/510/commits","review_comments_url":"https://api.github.com/repos/ultrabug/py3status/pulls/510/comments","review_comment_url":"https://api.github.com/repos/ultrabug/py3status/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ultrabug/py3status/issues/510/comments","statuses_url":"https://api.github.com/repos/ultrabug/py3status/statuses/5e229b2a86dcf4a0806ea27fcfb4f57caea4b4c3","head":{"label":"btall:feature/graphite-module-proxies","ref":"feature/graphite-module-proxies","sha":"5e229b2a86dcf4a0806ea27fcfb4f57caea4b4c3","user":{"login":"btall","id":6665717,"avatar_url":"https://avatars.githubusercontent.com/u/6665717?v=3","gravatar_id":"","url":"https://api.github.com/users/btall","html_url":"https://github.com/btall","followers_url":"https://api.github.com/users/btall/followers","following_url":"https://api.github.com/users/btall/following{/other_user}","gists_url":"https://api.github.com/users/btall/gists{/gist_id}","starred_url":"https://api.github.com/users/btall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btall/subscriptions","organizations_url":"https://api.github.com/users/btall/orgs","repos_url":"https://api.github.com/users/btall/repos","events_url":"https://api.github.com/users/btall/events{/privacy}","received_events_url":"https://api.github.com/users/btall/received_events","type":"User","site_admin":false},"repo":{"id":44270445,"name":"py3status","full_name":"btall/py3status","owner":{"login":"btall","id":6665717,"avatar_url":"https://avatars.githubusercontent.com/u/6665717?v=3","gravatar_id":"","url":"https://api.github.com/users/btall","html_url":"https://github.com/btall","followers_url":"https://api.github.com/users/btall/followers","following_url":"https://api.github.com/users/btall/following{/other_user}","gists_url":"https://api.github.com/users/btall/gists{/gist_id}","starred_url":"https://api.github.com/users/btall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btall/subscriptions","organizations_url":"https://api.github.com/users/btall/orgs","repos_url":"https://api.github.com/users/btall/repos","events_url":"https://api.github.com/users/btall/events{/privacy}","received_events_url":"https://api.github.com/users/btall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btall/py3status","description":"py3status is an extensible i3status wrapper written in python","fork":true,"url":"https://api.github.com/repos/btall/py3status","forks_url":"https://api.github.com/repos/btall/py3status/forks","keys_url":"https://api.github.com/repos/btall/py3status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btall/py3status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btall/py3status/teams","hooks_url":"https://api.github.com/repos/btall/py3status/hooks","issue_events_url":"https://api.github.com/repos/btall/py3status/issues/events{/number}","events_url":"https://api.github.com/repos/btall/py3status/events","assignees_url":"https://api.github.com/repos/btall/py3status/assignees{/user}","branches_url":"https://api.github.com/repos/btall/py3status/branches{/branch}","tags_url":"https://api.github.com/repos/btall/py3status/tags","blobs_url":"https://api.github.com/repos/btall/py3status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btall/py3status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btall/py3status/git/refs{/sha}","trees_url":"https://api.github.com/repos/btall/py3status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btall/py3status/statuses/{sha}","languages_url":"https://api.github.com/repos/btall/py3status/languages","stargazers_url":"https://api.github.com/repos/btall/py3status/stargazers","contributors_url":"https://api.github.com/repos/btall/py3status/contributors","subscribers_url":"https://api.github.com/repos/btall/py3status/subscribers","subscription_url":"https://api.github.com/repos/btall/py3status/subscription","commits_url":"https://api.github.com/repos/btall/py3status/commits{/sha}","git_commits_url":"https://api.github.com/repos/btall/py3status/git/commits{/sha}","comments_url":"https://api.github.com/repos/btall/py3status/comments{/number}","issue_comment_url":"https://api.github.com/repos/btall/py3status/issues/comments{/number}","contents_url":"https://api.github.com/repos/btall/py3status/contents/{+path}","compare_url":"https://api.github.com/repos/btall/py3status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btall/py3status/merges","archive_url":"https://api.github.com/repos/btall/py3status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btall/py3status/downloads","issues_url":"https://api.github.com/repos/btall/py3status/issues{/number}","pulls_url":"https://api.github.com/repos/btall/py3status/pulls{/number}","milestones_url":"https://api.github.com/repos/btall/py3status/milestones{/number}","notifications_url":"https://api.github.com/repos/btall/py3status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btall/py3status/labels{/name}","releases_url":"https://api.github.com/repos/btall/py3status/releases{/id}","deployments_url":"https://api.github.com/repos/btall/py3status/deployments","created_at":"2015-10-14T19:13:02Z","updated_at":"2016-01-20T21:55:31Z","pushed_at":"2016-10-14T12:57:35Z","git_url":"git://github.com/btall/py3status.git","ssh_url":"git@github.com:btall/py3status.git","clone_url":"https://github.com/btall/py3status.git","svn_url":"https://github.com/btall/py3status","homepage":"","size":1878,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ultrabug:master","ref":"master","sha":"19daa6d5adf66d98fe56a390f1956deb6dc8cead","user":{"login":"ultrabug","id":474389,"avatar_url":"https://avatars.githubusercontent.com/u/474389?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrabug","html_url":"https://github.com/ultrabug","followers_url":"https://api.github.com/users/ultrabug/followers","following_url":"https://api.github.com/users/ultrabug/following{/other_user}","gists_url":"https://api.github.com/users/ultrabug/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrabug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrabug/subscriptions","organizations_url":"https://api.github.com/users/ultrabug/orgs","repos_url":"https://api.github.com/users/ultrabug/repos","events_url":"https://api.github.com/users/ultrabug/events{/privacy}","received_events_url":"https://api.github.com/users/ultrabug/received_events","type":"User","site_admin":false},"repo":{"id":8292338,"name":"py3status","full_name":"ultrabug/py3status","owner":{"login":"ultrabug","id":474389,"avatar_url":"https://avatars.githubusercontent.com/u/474389?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrabug","html_url":"https://github.com/ultrabug","followers_url":"https://api.github.com/users/ultrabug/followers","following_url":"https://api.github.com/users/ultrabug/following{/other_user}","gists_url":"https://api.github.com/users/ultrabug/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrabug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrabug/subscriptions","organizations_url":"https://api.github.com/users/ultrabug/orgs","repos_url":"https://api.github.com/users/ultrabug/repos","events_url":"https://api.github.com/users/ultrabug/events{/privacy}","received_events_url":"https://api.github.com/users/ultrabug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ultrabug/py3status","description":"py3status is an extensible i3status wrapper written in python","fork":false,"url":"https://api.github.com/repos/ultrabug/py3status","forks_url":"https://api.github.com/repos/ultrabug/py3status/forks","keys_url":"https://api.github.com/repos/ultrabug/py3status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ultrabug/py3status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ultrabug/py3status/teams","hooks_url":"https://api.github.com/repos/ultrabug/py3status/hooks","issue_events_url":"https://api.github.com/repos/ultrabug/py3status/issues/events{/number}","events_url":"https://api.github.com/repos/ultrabug/py3status/events","assignees_url":"https://api.github.com/repos/ultrabug/py3status/assignees{/user}","branches_url":"https://api.github.com/repos/ultrabug/py3status/branches{/branch}","tags_url":"https://api.github.com/repos/ultrabug/py3status/tags","blobs_url":"https://api.github.com/repos/ultrabug/py3status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ultrabug/py3status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ultrabug/py3status/git/refs{/sha}","trees_url":"https://api.github.com/repos/ultrabug/py3status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ultrabug/py3status/statuses/{sha}","languages_url":"https://api.github.com/repos/ultrabug/py3status/languages","stargazers_url":"https://api.github.com/repos/ultrabug/py3status/stargazers","contributors_url":"https://api.github.com/repos/ultrabug/py3status/contributors","subscribers_url":"https://api.github.com/repos/ultrabug/py3status/subscribers","subscription_url":"https://api.github.com/repos/ultrabug/py3status/subscription","commits_url":"https://api.github.com/repos/ultrabug/py3status/commits{/sha}","git_commits_url":"https://api.github.com/repos/ultrabug/py3status/git/commits{/sha}","comments_url":"https://api.github.com/repos/ultrabug/py3status/comments{/number}","issue_comment_url":"https://api.github.com/repos/ultrabug/py3status/issues/comments{/number}","contents_url":"https://api.github.com/repos/ultrabug/py3status/contents/{+path}","compare_url":"https://api.github.com/repos/ultrabug/py3status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ultrabug/py3status/merges","archive_url":"https://api.github.com/repos/ultrabug/py3status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ultrabug/py3status/downloads","issues_url":"https://api.github.com/repos/ultrabug/py3status/issues{/number}","pulls_url":"https://api.github.com/repos/ultrabug/py3status/pulls{/number}","milestones_url":"https://api.github.com/repos/ultrabug/py3status/milestones{/number}","notifications_url":"https://api.github.com/repos/ultrabug/py3status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ultrabug/py3status/labels{/name}","releases_url":"https://api.github.com/repos/ultrabug/py3status/releases{/id}","deployments_url":"https://api.github.com/repos/ultrabug/py3status/deployments","created_at":"2013-02-19T14:59:13Z","updated_at":"2016-10-14T12:36:36Z","pushed_at":"2016-10-14T12:57:35Z","git_url":"git://github.com/ultrabug/py3status.git","ssh_url":"git@github.com:ultrabug/py3status.git","clone_url":"https://github.com/ultrabug/py3status.git","svn_url":"https://github.com/ultrabug/py3status","homepage":"","size":2421,"stargazers_count":310,"watchers_count":310,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":34,"forks":120,"open_issues":34,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/510"},"html":{"href":"https://github.com/ultrabug/py3status/pull/510"},"issue":{"href":"https://api.github.com/repos/ultrabug/py3status/issues/510"},"comments":{"href":"https://api.github.com/repos/ultrabug/py3status/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ultrabug/py3status/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/ultrabug/py3status/statuses/5e229b2a86dcf4a0806ea27fcfb4f57caea4b4c3"}}}}
{"actor":{"display_login":"tobes"}}