{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/303","repository_url":"https://api.github.com/repos/PowerShell/xSharePoint","labels_url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/303/comments","events_url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/303/events","html_url":"https://github.com/PowerShell/xSharePoint/pull/303","id":157821161,"number":303,"title":"Fixed bug with schedule type not being tested as a string","user":{"login":"BrianFarnhill","id":1332611,"avatar_url":"https://avatars.githubusercontent.com/u/1332611?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianFarnhill","html_url":"https://github.com/BrianFarnhill","followers_url":"https://api.github.com/users/BrianFarnhill/followers","following_url":"https://api.github.com/users/BrianFarnhill/following{/other_user}","gists_url":"https://api.github.com/users/BrianFarnhill/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianFarnhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianFarnhill/subscriptions","organizations_url":"https://api.github.com/users/BrianFarnhill/orgs","repos_url":"https://api.github.com/users/BrianFarnhill/repos","events_url":"https://api.github.com/users/BrianFarnhill/events{/privacy}","received_events_url":"https://api.github.com/users/BrianFarnhill/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/xSharePoint/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-01T04:27:48Z","updated_at":"2016-06-01T09:17:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xSharePoint/pulls/303","html_url":"https://github.com/PowerShell/xSharePoint/pull/303","diff_url":"https://github.com/PowerShell/xSharePoint/pull/303.diff","patch_url":"https://github.com/PowerShell/xSharePoint/pull/303.patch"},"body":"Quick one to fix a bug I found in SPTimerJobState - looks like the object coming back from schedule is a custom object, not a string (it's ToString() method hides that though so it looks like a string until you interrogate it). A quick ToString() on it in the get method stops the tests from throwing a false result when it is actually set correctly.\r\n\r\n@ykuijs You wanna code review this one seeing as that module was yours to begin with? Thanks dude\r\n\r\n- [X] Change details added to Unreleased section of readme.md?\r\n- [X] Added/updated documentation and descriptions in .schema.mof files where appropriate?\r\n- [X] Examples updated for both the single server and small farm templates in the examples folder?\r\n- [X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?\r\n- [X] [Unit and Integration tests](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md) created/updated where possible?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xsharepoint/303)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/comments/222938060","html_url":"https://github.com/PowerShell/xSharePoint/pull/303#issuecomment-222938060","issue_url":"https://api.github.com/repos/PowerShell/xSharePoint/issues/303","id":222938060,"user":{"login":"ykuijs","id":15103891,"avatar_url":"https://avatars.githubusercontent.com/u/15103891?v=3","gravatar_id":"","url":"https://api.github.com/users/ykuijs","html_url":"https://github.com/ykuijs","followers_url":"https://api.github.com/users/ykuijs/followers","following_url":"https://api.github.com/users/ykuijs/following{/other_user}","gists_url":"https://api.github.com/users/ykuijs/gists{/gist_id}","starred_url":"https://api.github.com/users/ykuijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykuijs/subscriptions","organizations_url":"https://api.github.com/users/ykuijs/orgs","repos_url":"https://api.github.com/users/ykuijs/repos","events_url":"https://api.github.com/users/ykuijs/events{/privacy}","received_events_url":"https://api.github.com/users/ykuijs/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T09:17:54Z","updated_at":"2016-06-01T09:17:54Z","body":"\n\n\n\n\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/xsharepoint/303)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ykuijs"}}