{"action":"created","issue":{"url":"https://api.github.com/repos/grempe/sirp/issues/4","repository_url":"https://api.github.com/repos/grempe/sirp","labels_url":"https://api.github.com/repos/grempe/sirp/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/grempe/sirp/issues/4/comments","events_url":"https://api.github.com/repos/grempe/sirp/issues/4/events","html_url":"https://github.com/grempe/sirp/pull/4","id":194116217,"number":4,"title":"New API PoC","user":{"login":"Ptico","id":69933,"avatar_url":"https://avatars.githubusercontent.com/u/69933?v=3","gravatar_id":"","url":"https://api.github.com/users/Ptico","html_url":"https://github.com/Ptico","followers_url":"https://api.github.com/users/Ptico/followers","following_url":"https://api.github.com/users/Ptico/following{/other_user}","gists_url":"https://api.github.com/users/Ptico/gists{/gist_id}","starred_url":"https://api.github.com/users/Ptico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ptico/subscriptions","organizations_url":"https://api.github.com/users/Ptico/orgs","repos_url":"https://api.github.com/users/Ptico/repos","events_url":"https://api.github.com/users/Ptico/events{/privacy}","received_events_url":"https://api.github.com/users/Ptico/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-07T17:38:32Z","updated_at":"2016-12-08T19:09:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grempe/sirp/pulls/4","html_url":"https://github.com/grempe/sirp/pull/4","diff_url":"https://github.com/grempe/sirp/pull/4.diff","patch_url":"https://github.com/grempe/sirp/pull/4.patch"},"body":"This is very early prototype (contain bugs and untested code) of proposed API changes. Just for discussion. \r\n\r\nFor now it looks like this:\r\n\r\n```ruby\r\nuser = { username: 'xxx', verifier: 'xxx', salt: 'xxx' }\r\naa = 'xxx'\r\nstart = SIRP::Server::Start.new(user, aa)\r\n\r\nchallenge = start.challenge\r\nproof = start.proof\r\n\r\nfinish = SIRP::Server::Finish.new(proof, mm)\r\nfinish.success?\r\nfinish.match #=> H(A, M, K)\r\n```"},"comment":{"url":"https://api.github.com/repos/grempe/sirp/issues/comments/265826462","html_url":"https://github.com/grempe/sirp/pull/4#issuecomment-265826462","issue_url":"https://api.github.com/repos/grempe/sirp/issues/4","id":265826462,"user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T19:09:44Z","updated_at":"2016-12-08T19:09:44Z","body":"Hi @Ptico \r\n\r\nThanks for taking this challenge on. Your ideas are good.\r\n\r\nBefore we get into the API changes there are a couple of things that probably need to be addressed.\r\n\r\nYour work is based off of my experimental fork with the intention to make the library even more secure.  In the interim there has been a new release on the master branch and this work-in-progress branch is out of date.  I think it needs to be rebased off of master and get it back in sync again.\r\n\r\nMy biggest concern is that the new branch represents breaking changes with the Javascript SRP client that this ruby code works with. This is a library that I don't own and I imagine that the owner would be reluctant to take on the necessary changes since they would be breaking changes.  This means I would likely need to fork and maintain that tool as well, which is possible, but I am a bit reluctant to take on.\r\n\r\nI can take on the rebase, but that means your significant work will be out of date.\r\n\r\nWhat are your thoughts on the best approach to tackle these issues?\r\n\r\nCheers."}}
{"actor":{"display_login":"grempe"}}