{"action":"created","comment":{"url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/comments/90041224","pull_request_review_id":10565131,"id":90041224,"diff_hunk":"@@ -142,6 +145,21 @@ module.exports = (bluebird, error, logger, requestOptions, requestPromise, respo\n                     // Pass the reason response to the error handler.\n                     responseHandler.handleErrorResponse(reason);\n                 });\n+            }, (rejectArr) => {\n+                var errorMessage;\n+\n+                errorMessage = [];\n+                rejectArr.forEach((err) => {\n+                    if (!errorMessage.includes(err.message)) {\n+                        errorMessage.push(`${err.code}\\n`);\n+                    }\n+\n+                    if (err instanceof Error) {\n+                        errorMessage.push(`${err.message}\\n`);\n+                    }\n+                });\n+\n+                return errorMessage.join();","path":"lib/artifact-search.js","position":45,"original_position":45,"commit_id":"6762306f25f463154a22c44b1274c6ec77bb8a81","original_commit_id":"fcf16e43df4ea116a20a3019e71906373b0be31b","user":{"login":"kyle-long","id":1569367,"avatar_url":"https://avatars.githubusercontent.com/u/1569367?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-long","html_url":"https://github.com/kyle-long","followers_url":"https://api.github.com/users/kyle-long/followers","following_url":"https://api.github.com/users/kyle-long/following{/other_user}","gists_url":"https://api.github.com/users/kyle-long/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-long/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-long/subscriptions","organizations_url":"https://api.github.com/users/kyle-long/orgs","repos_url":"https://api.github.com/users/kyle-long/repos","events_url":"https://api.github.com/users/kyle-long/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-long/received_events","type":"User","site_admin":false},"body":"This doesn't keep the error rejected. This will actually resolve the promise. Also it is not an error. Also no errors should be duplicate. I see that they will be, but that doesn't help the user that much. Instead the error should contain the query that errored. Also We shouldn't need to check if its an instance of Error. It should always be a `ShelfError` but even if it was not we should be consistent with the values returned.\r\n\r\nAfter that is done you should just be able to do map.\r\n\r\n```\r\nmessageList = rejectionList.map((err) => {\r\n    return err.message;\r\n});\r\nmessage = messageList.join(\"\\n\");\r\n```","created_at":"2016-11-29T16:07:09Z","updated_at":"2016-11-29T16:32:01Z","html_url":"https://github.com/not-nexus/shelf-lib-js/pull/9#discussion_r90041224","pull_request_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/comments/90041224"},"html":{"href":"https://github.com/not-nexus/shelf-lib-js/pull/9#discussion_r90041224"},"pull_request":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9","id":95705347,"html_url":"https://github.com/not-nexus/shelf-lib-js/pull/9","diff_url":"https://github.com/not-nexus/shelf-lib-js/pull/9.diff","patch_url":"https://github.com/not-nexus/shelf-lib-js/pull/9.patch","issue_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/9","number":9,"state":"open","locked":false,"title":"Various changes requested by Kyle","user":{"login":"lnagle93","id":13711016,"avatar_url":"https://avatars.githubusercontent.com/u/13711016?v=3","gravatar_id":"","url":"https://api.github.com/users/lnagle93","html_url":"https://github.com/lnagle93","followers_url":"https://api.github.com/users/lnagle93/followers","following_url":"https://api.github.com/users/lnagle93/following{/other_user}","gists_url":"https://api.github.com/users/lnagle93/gists{/gist_id}","starred_url":"https://api.github.com/users/lnagle93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnagle93/subscriptions","organizations_url":"https://api.github.com/users/lnagle93/orgs","repos_url":"https://api.github.com/users/lnagle93/repos","events_url":"https://api.github.com/users/lnagle93/events{/privacy}","received_events_url":"https://api.github.com/users/lnagle93/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-29T14:44:52Z","updated_at":"2016-11-29T16:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b54ac1b001be3e64eccb775d6f7273da43a767ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9/commits","review_comments_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9/comments","review_comment_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/9/comments","statuses_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/statuses/6762306f25f463154a22c44b1274c6ec77bb8a81","head":{"label":"lnagle93:kyle-updates","ref":"kyle-updates","sha":"6762306f25f463154a22c44b1274c6ec77bb8a81","user":{"login":"lnagle93","id":13711016,"avatar_url":"https://avatars.githubusercontent.com/u/13711016?v=3","gravatar_id":"","url":"https://api.github.com/users/lnagle93","html_url":"https://github.com/lnagle93","followers_url":"https://api.github.com/users/lnagle93/followers","following_url":"https://api.github.com/users/lnagle93/following{/other_user}","gists_url":"https://api.github.com/users/lnagle93/gists{/gist_id}","starred_url":"https://api.github.com/users/lnagle93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnagle93/subscriptions","organizations_url":"https://api.github.com/users/lnagle93/orgs","repos_url":"https://api.github.com/users/lnagle93/repos","events_url":"https://api.github.com/users/lnagle93/events{/privacy}","received_events_url":"https://api.github.com/users/lnagle93/received_events","type":"User","site_admin":false},"repo":{"id":72005108,"name":"shelf-lib-js","full_name":"lnagle93/shelf-lib-js","owner":{"login":"lnagle93","id":13711016,"avatar_url":"https://avatars.githubusercontent.com/u/13711016?v=3","gravatar_id":"","url":"https://api.github.com/users/lnagle93","html_url":"https://github.com/lnagle93","followers_url":"https://api.github.com/users/lnagle93/followers","following_url":"https://api.github.com/users/lnagle93/following{/other_user}","gists_url":"https://api.github.com/users/lnagle93/gists{/gist_id}","starred_url":"https://api.github.com/users/lnagle93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnagle93/subscriptions","organizations_url":"https://api.github.com/users/lnagle93/orgs","repos_url":"https://api.github.com/users/lnagle93/repos","events_url":"https://api.github.com/users/lnagle93/events{/privacy}","received_events_url":"https://api.github.com/users/lnagle93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lnagle93/shelf-lib-js","description":null,"fork":true,"url":"https://api.github.com/repos/lnagle93/shelf-lib-js","forks_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/forks","keys_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/teams","hooks_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/hooks","issue_events_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/issues/events{/number}","events_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/events","assignees_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/assignees{/user}","branches_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/branches{/branch}","tags_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/tags","blobs_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/statuses/{sha}","languages_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/languages","stargazers_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/stargazers","contributors_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/contributors","subscribers_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/subscribers","subscription_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/subscription","commits_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/contents/{+path}","compare_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/merges","archive_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/downloads","issues_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/issues{/number}","pulls_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/pulls{/number}","milestones_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/milestones{/number}","notifications_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/labels{/name}","releases_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/releases{/id}","deployments_url":"https://api.github.com/repos/lnagle93/shelf-lib-js/deployments","created_at":"2016-10-26T13:20:19Z","updated_at":"2016-10-13T13:20:09Z","pushed_at":"2016-11-29T16:01:30Z","git_url":"git://github.com/lnagle93/shelf-lib-js.git","ssh_url":"git@github.com:lnagle93/shelf-lib-js.git","clone_url":"https://github.com/lnagle93/shelf-lib-js.git","svn_url":"https://github.com/lnagle93/shelf-lib-js","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"not-nexus:master","ref":"master","sha":"284d627022396c14e4dfe56d9e28fbc37ccc66fe","user":{"login":"not-nexus","id":23244957,"avatar_url":"https://avatars.githubusercontent.com/u/23244957?v=3","gravatar_id":"","url":"https://api.github.com/users/not-nexus","html_url":"https://github.com/not-nexus","followers_url":"https://api.github.com/users/not-nexus/followers","following_url":"https://api.github.com/users/not-nexus/following{/other_user}","gists_url":"https://api.github.com/users/not-nexus/gists{/gist_id}","starred_url":"https://api.github.com/users/not-nexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-nexus/subscriptions","organizations_url":"https://api.github.com/users/not-nexus/orgs","repos_url":"https://api.github.com/users/not-nexus/repos","events_url":"https://api.github.com/users/not-nexus/events{/privacy}","received_events_url":"https://api.github.com/users/not-nexus/received_events","type":"Organization","site_admin":false},"repo":{"id":70175423,"name":"shelf-lib-js","full_name":"not-nexus/shelf-lib-js","owner":{"login":"not-nexus","id":23244957,"avatar_url":"https://avatars.githubusercontent.com/u/23244957?v=3","gravatar_id":"","url":"https://api.github.com/users/not-nexus","html_url":"https://github.com/not-nexus","followers_url":"https://api.github.com/users/not-nexus/followers","following_url":"https://api.github.com/users/not-nexus/following{/other_user}","gists_url":"https://api.github.com/users/not-nexus/gists{/gist_id}","starred_url":"https://api.github.com/users/not-nexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-nexus/subscriptions","organizations_url":"https://api.github.com/users/not-nexus/orgs","repos_url":"https://api.github.com/users/not-nexus/repos","events_url":"https://api.github.com/users/not-nexus/events{/privacy}","received_events_url":"https://api.github.com/users/not-nexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/not-nexus/shelf-lib-js","description":null,"fork":false,"url":"https://api.github.com/repos/not-nexus/shelf-lib-js","forks_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/forks","keys_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/teams","hooks_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/hooks","issue_events_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/events{/number}","events_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/events","assignees_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/assignees{/user}","branches_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/branches{/branch}","tags_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/tags","blobs_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/statuses/{sha}","languages_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/languages","stargazers_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/stargazers","contributors_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/contributors","subscribers_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/subscribers","subscription_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/subscription","commits_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/contents/{+path}","compare_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/merges","archive_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/downloads","issues_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues{/number}","pulls_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls{/number}","milestones_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/milestones{/number}","notifications_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/labels{/name}","releases_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/releases{/id}","deployments_url":"https://api.github.com/repos/not-nexus/shelf-lib-js/deployments","created_at":"2016-10-06T17:13:01Z","updated_at":"2016-11-10T17:37:03Z","pushed_at":"2016-11-29T16:01:31Z","git_url":"git://github.com/not-nexus/shelf-lib-js.git","ssh_url":"git@github.com:not-nexus/shelf-lib-js.git","clone_url":"https://github.com/not-nexus/shelf-lib-js.git","svn_url":"https://github.com/not-nexus/shelf-lib-js","homepage":null,"size":37,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9"},"html":{"href":"https://github.com/not-nexus/shelf-lib-js/pull/9"},"issue":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/9"},"comments":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/not-nexus/shelf-lib-js/statuses/6762306f25f463154a22c44b1274c6ec77bb8a81"}}}}
{"actor":{"display_login":"kyle-long"}}