{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/49357503","id":49357503,"diff_hunk":"@@ -0,0 +1,701 @@\n+/*\n+ * Copyright (c) 2014, STMicroelectronics International N.V.\n+ * Copyright (c) 2015, Linaro Limited\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * 1. Redistributions of source code must retain the above copyright notice,\n+ * this list of conditions and the following disclaimer.\n+ *\n+ * 2. Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation\n+ * and/or other materials provided with the distribution.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include <compiler.h>\n+#include <keep.h>\n+#include <types_ext.h>\n+#include <stdlib.h>\n+#include <kernel/tee_rpc.h>\n+#include <kernel/tee_rpc_types.h>\n+#include <kernel/tee_ta_manager.h>\n+#include <kernel/thread.h>\n+#include <kernel/user_ta.h>\n+#include <mm/core_memprot.h>\n+#include <mm/core_mmu.h>\n+#include <mm/tee_mm.h>\n+#include <mm/tee_mmu.h>\n+#include <tee/tee_cryp_provider.h>\n+#include <tee/tee_cryp_utl.h>\n+#include <tee/tee_obj.h>\n+#include <tee/tee_svc_cryp.h>\n+#include <tee/tee_svc.h>\n+#include <tee/tee_svc_storage.h>\n+#include <signed_hdr.h>\n+#include <ta_pub_key.h>\n+#include <trace.h>\n+#include <utee_defines.h>\n+#include <util.h>\n+\n+#include \"elf_load.h\"\n+\n+#define TEE_TA_STACK_ALIGNMENT   8\n+\n+static TEE_Result load_header(const struct shdr *signed_ta,\n+\t\tstruct shdr **sec_shdr)\n+{\n+\tsize_t s;\n+\n+\tif (!tee_vbuf_is_non_sec(signed_ta, sizeof(*signed_ta)))","path":"core/arch/arm/kernel/user_ta.c","position":63,"original_position":63,"commit_id":"61fea16f2fcf47de9f1460279367b1277378af7d","original_commit_id":"61fea16f2fcf47de9f1460279367b1277378af7d","user":{"login":"jbech-linaro","id":6168937,"avatar_url":"https://avatars.githubusercontent.com/u/6168937?v=3","gravatar_id":"","url":"https://api.github.com/users/jbech-linaro","html_url":"https://github.com/jbech-linaro","followers_url":"https://api.github.com/users/jbech-linaro/followers","following_url":"https://api.github.com/users/jbech-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jbech-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jbech-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbech-linaro/subscriptions","organizations_url":"https://api.github.com/users/jbech-linaro/orgs","repos_url":"https://api.github.com/users/jbech-linaro/repos","events_url":"https://api.github.com/users/jbech-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jbech-linaro/received_events","type":"User","site_admin":false},"body":"Probably personal taste, but I usually find it easier to read if you don't negate an already negated item (i.e, I would have used tee_vbuf_is_sec(...) instead).","created_at":"2016-01-11T18:25:38Z","updated_at":"2016-01-11T18:25:38Z","html_url":"https://github.com/OP-TEE/optee_os/pull/592#discussion_r49357503","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/49357503"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/592#discussion_r49357503"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592","id":53816622,"html_url":"https://github.com/OP-TEE/optee_os/pull/592","diff_url":"https://github.com/OP-TEE/optee_os/pull/592.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/592.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/592","number":592,"state":"open","locked":false,"title":"Refactor tee_ta_manager{,_unpg}.{c,h}","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-16T09:26:15Z","updated_at":"2016-01-11T18:25:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bc202465a6aefb2b857668b9f2e9ffce083fedf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/592/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/61fea16f2fcf47de9f1460279367b1277378af7d","head":{"label":"jenswi-linaro:refactor_ta_man","ref":"refactor_ta_man","sha":"61fea16f2fcf47de9f1460279367b1277378af7d","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"repo":{"id":20770355,"name":"optee_os","full_name":"jenswi-linaro/optee_os","owner":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenswi-linaro/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/jenswi-linaro/optee_os","forks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/forks","keys_url":"https://api.github.com/repos/jenswi-linaro/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenswi-linaro/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenswi-linaro/optee_os/teams","hooks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/hooks","issue_events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/events","assignees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/jenswi-linaro/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/tags","blobs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenswi-linaro/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/jenswi-linaro/optee_os/languages","stargazers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/stargazers","contributors_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contributors","subscribers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscribers","subscription_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscription","commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenswi-linaro/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/jenswi-linaro/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenswi-linaro/optee_os/merges","archive_url":"https://api.github.com/repos/jenswi-linaro/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenswi-linaro/optee_os/downloads","issues_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/jenswi-linaro/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/jenswi-linaro/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/jenswi-linaro/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenswi-linaro/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/jenswi-linaro/optee_os/releases{/id}","created_at":"2014-06-12T14:26:39Z","updated_at":"2015-05-07T19:34:05Z","pushed_at":"2016-01-07T20:20:12Z","git_url":"git://github.com/jenswi-linaro/optee_os.git","ssh_url":"git@github.com:jenswi-linaro/optee_os.git","clone_url":"https://github.com/jenswi-linaro/optee_os.git","svn_url":"https://github.com/jenswi-linaro/optee_os","homepage":null,"size":4229,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"3e27ab4b88b00e2a4135196f60c80c7b0ce68881","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2016-01-11T11:36:48Z","pushed_at":"2016-01-11T14:57:53Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":8171,"stargazers_count":83,"watchers_count":83,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":20,"forks":89,"open_issues":20,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/592"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/592"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/61fea16f2fcf47de9f1460279367b1277378af7d"}}}}