{"action":"created","issue":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/685","repository_url":"https://api.github.com/repos/freeorion/freeorion","labels_url":"https://api.github.com/repos/freeorion/freeorion/issues/685/labels{/name}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/685/comments","events_url":"https://api.github.com/repos/freeorion/freeorion/issues/685/events","html_url":"https://github.com/freeorion/freeorion/pull/685","id":157536861,"number":685,"title":"Remove several vacuous try..catch from UniverseWrapper","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-30T17:28:37Z","updated_at":"2016-06-01T19:07:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/685","html_url":"https://github.com/freeorion/freeorion/pull/685","diff_url":"https://github.com/freeorion/freeorion/pull/685.diff","patch_url":"https://github.com/freeorion/freeorion/pull/685.patch"},"body":"Removing these empty catch statements made fixing PR #684 possible."},"comment":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/comments/223093665","html_url":"https://github.com/freeorion/freeorion/pull/685#issuecomment-223093665","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/685","id":223093665,"user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T19:07:08Z","updated_at":"2016-06-01T19:07:08Z","body":"It was necessary to find where the error was for #684.  Because the Trith could not see their own homeworld they used -1 as a system id, which did reach all the way to the boost::graph functions which threw when trying to convert the system_id to a graph index.  However, these catch all clauses prevent the AI from generating any error.\r\n\r\nRemoving these catch clauses did not crash the AI, but the AI did produce a line number error.  I could not have found the error with these in place because nothing reported the error.\r\n\r\nI'll repeat that this falling through to python did not crash the game.  It even reported the correct exception.\r\n\r\nI also have a commit with more expansive debug message when get_capital() fails to find a homeworld, but I didn't bother submitting those.  Do you want that?"}}
{"actor":{"display_login":"LGM-Doyle"}}