{"action":"created","comment":{"url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments/70245068","id":70245068,"diff_hunk":"@@ -414,42 +418,58 @@ ss_droplink(struct sock *sk)\n \tsock_put(sk);\t/* paired with ss_do_close() */\n }\n \n-/*\n- * Schedule a socket closing action on the CPU that is processing\n- * the connection. The closing action is executed asynchronously\n- * in the context of the socket that is being closed.\n+/**\n+ * The function should be called with @sync = true whenever possible to\n+ * improve performance. If @sync = false, then return value must be checked\n+ * and the call must be repeated in case of bad return value.\n+ * @sync = true doesn't mean that the socket will be closed immediately,\n+ * but rather it guarantees that the socket will be closed and the caller can\n+ * not care about return value.\n  */\n int\n-ss_close(struct sock *sk)\n+__ss_close(struct sock *sk, bool sync, bool need_drop)\n {\n-\tSsWork sw = {\n-\t\t.sk\t= sk,\n-\t\t.action\t= SS_CLOSE,\n-\t};\n \n \tif (unlikely(!sk))\n \t\treturn SS_OK;\n+\tsk_incoming_cpu_update(sk);","path":"tempesta_fw/sock.c","position":38,"original_position":38,"commit_id":"fc59a7927edac4eb52a6f783c6511aa20305b8f9","original_commit_id":"fc59a7927edac4eb52a6f783c6511aa20305b8f9","user":{"login":"krizhanovsky","id":884694,"avatar_url":"https://avatars.githubusercontent.com/u/884694?v=3","gravatar_id":"","url":"https://api.github.com/users/krizhanovsky","html_url":"https://github.com/krizhanovsky","followers_url":"https://api.github.com/users/krizhanovsky/followers","following_url":"https://api.github.com/users/krizhanovsky/following{/other_user}","gists_url":"https://api.github.com/users/krizhanovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/krizhanovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizhanovsky/subscriptions","organizations_url":"https://api.github.com/users/krizhanovsky/orgs","repos_url":"https://api.github.com/users/krizhanovsky/repos","events_url":"https://api.github.com/users/krizhanovsky/events{/privacy}","received_events_url":"https://api.github.com/users/krizhanovsky/received_events","type":"User","site_admin":false},"body":"No, it must be done before calling `smp_processor_id() != sk->sk_incoming_cp`","created_at":"2016-07-11T12:04:38Z","updated_at":"2016-07-11T12:04:38Z","html_url":"https://github.com/tempesta-tech/tempesta/pull/581#discussion_r70245068","pull_request_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments/70245068"},"html":{"href":"https://github.com/tempesta-tech/tempesta/pull/581#discussion_r70245068"},"pull_request":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581","id":76882985,"html_url":"https://github.com/tempesta-tech/tempesta/pull/581","diff_url":"https://github.com/tempesta-tech/tempesta/pull/581.diff","patch_url":"https://github.com/tempesta-tech/tempesta/pull/581.patch","issue_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/581","number":581,"state":"open","locked":false,"title":"#576: fix infinite loop on work queue push()","user":{"login":"krizhanovsky","id":884694,"avatar_url":"https://avatars.githubusercontent.com/u/884694?v=3","gravatar_id":"","url":"https://api.github.com/users/krizhanovsky","html_url":"https://github.com/krizhanovsky","followers_url":"https://api.github.com/users/krizhanovsky/followers","following_url":"https://api.github.com/users/krizhanovsky/following{/other_user}","gists_url":"https://api.github.com/users/krizhanovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/krizhanovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizhanovsky/subscriptions","organizations_url":"https://api.github.com/users/krizhanovsky/orgs","repos_url":"https://api.github.com/users/krizhanovsky/repos","events_url":"https://api.github.com/users/krizhanovsky/events{/privacy}","received_events_url":"https://api.github.com/users/krizhanovsky/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/tempesta-tech/tempesta/issues/576#issuecomment-230177421: do not try to push() socket close work synchronously if current context is the work queue consumer","created_at":"2016-07-10T20:40:21Z","updated_at":"2016-07-11T12:04:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"096874e08f198866d87d80f183b236f01eeb9575","assignee":{"login":"milabs","id":624823,"avatar_url":"https://avatars.githubusercontent.com/u/624823?v=3","gravatar_id":"","url":"https://api.github.com/users/milabs","html_url":"https://github.com/milabs","followers_url":"https://api.github.com/users/milabs/followers","following_url":"https://api.github.com/users/milabs/following{/other_user}","gists_url":"https://api.github.com/users/milabs/gists{/gist_id}","starred_url":"https://api.github.com/users/milabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milabs/subscriptions","organizations_url":"https://api.github.com/users/milabs/orgs","repos_url":"https://api.github.com/users/milabs/repos","events_url":"https://api.github.com/users/milabs/events{/privacy}","received_events_url":"https://api.github.com/users/milabs/received_events","type":"User","site_admin":false},"assignees":[{"login":"milabs","id":624823,"avatar_url":"https://avatars.githubusercontent.com/u/624823?v=3","gravatar_id":"","url":"https://api.github.com/users/milabs","html_url":"https://github.com/milabs","followers_url":"https://api.github.com/users/milabs/followers","following_url":"https://api.github.com/users/milabs/following{/other_user}","gists_url":"https://api.github.com/users/milabs/gists{/gist_id}","starred_url":"https://api.github.com/users/milabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milabs/subscriptions","organizations_url":"https://api.github.com/users/milabs/orgs","repos_url":"https://api.github.com/users/milabs/repos","events_url":"https://api.github.com/users/milabs/events{/privacy}","received_events_url":"https://api.github.com/users/milabs/received_events","type":"User","site_admin":false},{"login":"keshonok","id":6352580,"avatar_url":"https://avatars.githubusercontent.com/u/6352580?v=3","gravatar_id":"","url":"https://api.github.com/users/keshonok","html_url":"https://github.com/keshonok","followers_url":"https://api.github.com/users/keshonok/followers","following_url":"https://api.github.com/users/keshonok/following{/other_user}","gists_url":"https://api.github.com/users/keshonok/gists{/gist_id}","starred_url":"https://api.github.com/users/keshonok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keshonok/subscriptions","organizations_url":"https://api.github.com/users/keshonok/orgs","repos_url":"https://api.github.com/users/keshonok/repos","events_url":"https://api.github.com/users/keshonok/events{/privacy}","received_events_url":"https://api.github.com/users/keshonok/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581/commits","review_comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581/comments","review_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/581/comments","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/fc59a7927edac4eb52a6f783c6511aa20305b8f9","head":{"label":"tempesta-tech:ak-576","ref":"ak-576","sha":"fc59a7927edac4eb52a6f783c6511aa20305b8f9","user":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":23121600,"name":"tempesta","full_name":"tempesta-tech/tempesta","owner":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/tempesta","description":"High performance HTTP accelerator and firewall for WAF and DDoS prevention","fork":false,"url":"https://api.github.com/repos/tempesta-tech/tempesta","forks_url":"https://api.github.com/repos/tempesta-tech/tempesta/forks","keys_url":"https://api.github.com/repos/tempesta-tech/tempesta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/tempesta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/tempesta/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/tempesta/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/tempesta/events","assignees_url":"https://api.github.com/repos/tempesta-tech/tempesta/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/tempesta/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/tempesta/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/tempesta/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/tempesta/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/tempesta/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/tempesta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/tempesta/merges","archive_url":"https://api.github.com/repos/tempesta-tech/tempesta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/tempesta/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/tempesta/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/tempesta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/tempesta/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/tempesta/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/tempesta/deployments","created_at":"2014-08-19T18:44:05Z","updated_at":"2016-07-04T09:32:23Z","pushed_at":"2016-07-11T10:04:27Z","git_url":"git://github.com/tempesta-tech/tempesta.git","ssh_url":"git@github.com:tempesta-tech/tempesta.git","clone_url":"https://github.com/tempesta-tech/tempesta.git","svn_url":"https://github.com/tempesta-tech/tempesta","homepage":"","size":6429,"stargazers_count":109,"watchers_count":109,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":93,"forks":25,"open_issues":93,"watchers":109,"default_branch":"master"}},"base":{"label":"tempesta-tech:master","ref":"master","sha":"c55131334cdb7ff13e3867ec1a25d23a4316fbc8","user":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":23121600,"name":"tempesta","full_name":"tempesta-tech/tempesta","owner":{"login":"tempesta-tech","id":10939672,"avatar_url":"https://avatars.githubusercontent.com/u/10939672?v=3","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/tempesta","description":"High performance HTTP accelerator and firewall for WAF and DDoS prevention","fork":false,"url":"https://api.github.com/repos/tempesta-tech/tempesta","forks_url":"https://api.github.com/repos/tempesta-tech/tempesta/forks","keys_url":"https://api.github.com/repos/tempesta-tech/tempesta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/tempesta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/tempesta/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/tempesta/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/tempesta/events","assignees_url":"https://api.github.com/repos/tempesta-tech/tempesta/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/tempesta/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/tempesta/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/tempesta/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/tempesta/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/tempesta/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/tempesta/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/tempesta/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/tempesta/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/tempesta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/tempesta/merges","archive_url":"https://api.github.com/repos/tempesta-tech/tempesta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/tempesta/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/tempesta/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/tempesta/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/tempesta/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/tempesta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/tempesta/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/tempesta/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/tempesta/deployments","created_at":"2014-08-19T18:44:05Z","updated_at":"2016-07-04T09:32:23Z","pushed_at":"2016-07-11T10:04:27Z","git_url":"git://github.com/tempesta-tech/tempesta.git","ssh_url":"git@github.com:tempesta-tech/tempesta.git","clone_url":"https://github.com/tempesta-tech/tempesta.git","svn_url":"https://github.com/tempesta-tech/tempesta","homepage":"","size":6429,"stargazers_count":109,"watchers_count":109,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":93,"forks":25,"open_issues":93,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581"},"html":{"href":"https://github.com/tempesta-tech/tempesta/pull/581"},"issue":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/issues/581"},"comments":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/tempesta-tech/tempesta/statuses/fc59a7927edac4eb52a6f783c6511aa20305b8f9"}}}}
{"actor":{"display_login":"krizhanovsky"}}