{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/56147316","id":56147316,"diff_hunk":"@@ -198,11 +202,19 @@ func (c *mockConnection) SetDeadline(t time.Time) error {\n \n // Write implements the net.Conn interface.\n func (c *mockConnection) Write(data []byte) (int, error) {\n+\tc.Lock()\n+\tdefer c.Unlock()\n \tc.AddCall(\"Write\", data)\n \tc.data = data\n \treturn len(data), nil\n }\n \n+func (c *mockConnection) readData() []byte {\n+\tc.Lock()\n+\tdefer c.Unlock()\n+\treturn c.data","path":"worker/metrics/collect/handler_test.go","position":50,"original_position":50,"commit_id":"d95303b1178dbaf88b0180aad285130506b22442","original_commit_id":"d95303b1178dbaf88b0180aad285130506b22442","user":{"login":"davecheney","id":7171,"avatar_url":"https://avatars.githubusercontent.com/u/7171?v=3","gravatar_id":"","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"body":"sorry, this isn't right, you need to return a _copy_ of the data, not just the slice header.","created_at":"2016-03-15T11:15:49Z","updated_at":"2016-03-15T11:15:49Z","html_url":"https://github.com/juju/juju/pull/4733#discussion_r56147316","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/4733","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/56147316"},"html":{"href":"https://github.com/juju/juju/pull/4733#discussion_r56147316"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/4733"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/4733","id":62879328,"html_url":"https://github.com/juju/juju/pull/4733","diff_url":"https://github.com/juju/juju/pull/4733.diff","patch_url":"https://github.com/juju/juju/pull/4733.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/4733","number":4733,"state":"open","locked":false,"title":"Sync on writes/reads on mockConnection.","user":{"login":"tasdomas","id":119220,"avatar_url":"https://avatars.githubusercontent.com/u/119220?v=3","gravatar_id":"","url":"https://api.github.com/users/tasdomas","html_url":"https://github.com/tasdomas","followers_url":"https://api.github.com/users/tasdomas/followers","following_url":"https://api.github.com/users/tasdomas/following{/other_user}","gists_url":"https://api.github.com/users/tasdomas/gists{/gist_id}","starred_url":"https://api.github.com/users/tasdomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasdomas/subscriptions","organizations_url":"https://api.github.com/users/tasdomas/orgs","repos_url":"https://api.github.com/users/tasdomas/repos","events_url":"https://api.github.com/users/tasdomas/events{/privacy}","received_events_url":"https://api.github.com/users/tasdomas/received_events","type":"User","site_admin":false},"body":"This fixes a potential race condition in tests.\n\n(Review request: http://reviews.vapour.ws/r/4170/)","created_at":"2016-03-15T09:55:31Z","updated_at":"2016-03-15T11:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b88631b3edb14adaf4462c5276be2b63e9bc36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/4733/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/4733/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/4733/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/d95303b1178dbaf88b0180aad285130506b22442","head":{"label":"tasdomas:d006-sync-on-mock-conn","ref":"d006-sync-on-mock-conn","sha":"d95303b1178dbaf88b0180aad285130506b22442","user":{"login":"tasdomas","id":119220,"avatar_url":"https://avatars.githubusercontent.com/u/119220?v=3","gravatar_id":"","url":"https://api.github.com/users/tasdomas","html_url":"https://github.com/tasdomas","followers_url":"https://api.github.com/users/tasdomas/followers","following_url":"https://api.github.com/users/tasdomas/following{/other_user}","gists_url":"https://api.github.com/users/tasdomas/gists{/gist_id}","starred_url":"https://api.github.com/users/tasdomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasdomas/subscriptions","organizations_url":"https://api.github.com/users/tasdomas/orgs","repos_url":"https://api.github.com/users/tasdomas/repos","events_url":"https://api.github.com/users/tasdomas/events{/privacy}","received_events_url":"https://api.github.com/users/tasdomas/received_events","type":"User","site_admin":false},"repo":{"id":20556185,"name":"juju","full_name":"tasdomas/juju","owner":{"login":"tasdomas","id":119220,"avatar_url":"https://avatars.githubusercontent.com/u/119220?v=3","gravatar_id":"","url":"https://api.github.com/users/tasdomas","html_url":"https://github.com/tasdomas","followers_url":"https://api.github.com/users/tasdomas/followers","following_url":"https://api.github.com/users/tasdomas/following{/other_user}","gists_url":"https://api.github.com/users/tasdomas/gists{/gist_id}","starred_url":"https://api.github.com/users/tasdomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasdomas/subscriptions","organizations_url":"https://api.github.com/users/tasdomas/orgs","repos_url":"https://api.github.com/users/tasdomas/repos","events_url":"https://api.github.com/users/tasdomas/events{/privacy}","received_events_url":"https://api.github.com/users/tasdomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tasdomas/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/tasdomas/juju","forks_url":"https://api.github.com/repos/tasdomas/juju/forks","keys_url":"https://api.github.com/repos/tasdomas/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tasdomas/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tasdomas/juju/teams","hooks_url":"https://api.github.com/repos/tasdomas/juju/hooks","issue_events_url":"https://api.github.com/repos/tasdomas/juju/issues/events{/number}","events_url":"https://api.github.com/repos/tasdomas/juju/events","assignees_url":"https://api.github.com/repos/tasdomas/juju/assignees{/user}","branches_url":"https://api.github.com/repos/tasdomas/juju/branches{/branch}","tags_url":"https://api.github.com/repos/tasdomas/juju/tags","blobs_url":"https://api.github.com/repos/tasdomas/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tasdomas/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tasdomas/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/tasdomas/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tasdomas/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/tasdomas/juju/languages","stargazers_url":"https://api.github.com/repos/tasdomas/juju/stargazers","contributors_url":"https://api.github.com/repos/tasdomas/juju/contributors","subscribers_url":"https://api.github.com/repos/tasdomas/juju/subscribers","subscription_url":"https://api.github.com/repos/tasdomas/juju/subscription","commits_url":"https://api.github.com/repos/tasdomas/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/tasdomas/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/tasdomas/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/tasdomas/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/tasdomas/juju/contents/{+path}","compare_url":"https://api.github.com/repos/tasdomas/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tasdomas/juju/merges","archive_url":"https://api.github.com/repos/tasdomas/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tasdomas/juju/downloads","issues_url":"https://api.github.com/repos/tasdomas/juju/issues{/number}","pulls_url":"https://api.github.com/repos/tasdomas/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/tasdomas/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/tasdomas/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tasdomas/juju/labels{/name}","releases_url":"https://api.github.com/repos/tasdomas/juju/releases{/id}","deployments_url":"https://api.github.com/repos/tasdomas/juju/deployments","created_at":"2014-06-06T08:13:21Z","updated_at":"2015-05-07T10:02:42Z","pushed_at":"2016-03-15T09:54:54Z","git_url":"git://github.com/tasdomas/juju.git","ssh_url":"git@github.com:tasdomas/juju.git","clone_url":"https://github.com/tasdomas/juju.git","svn_url":"https://github.com/tasdomas/juju","homepage":"juju.ubuntu.com","size":70594,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"da10d2be57e63ad2be4c427cf1182144ee16d1de","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-03-14T14:08:27Z","pushed_at":"2016-03-15T10:13:46Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":93921,"stargazers_count":396,"watchers_count":396,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":70,"forks":127,"open_issues":70,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/4733"},"html":{"href":"https://github.com/juju/juju/pull/4733"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/4733"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/4733/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/4733/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/4733/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/d95303b1178dbaf88b0180aad285130506b22442"}}}}