{"action":"created","issue":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/1865","repository_url":"https://api.github.com/repos/clojure-emacs/cider","labels_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1865/labels{/name}","comments_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1865/comments","events_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1865/events","html_url":"https://github.com/clojure-emacs/cider/pull/1865","id":182654740,"number":1865,"title":"[Fix #943] Make cider-repl-result-prefix work for multiline strings","user":{"login":"bkruczyk","id":845609,"avatar_url":"https://avatars.githubusercontent.com/u/845609?v=3","gravatar_id":"","url":"https://api.github.com/users/bkruczyk","html_url":"https://github.com/bkruczyk","followers_url":"https://api.github.com/users/bkruczyk/followers","following_url":"https://api.github.com/users/bkruczyk/following{/other_user}","gists_url":"https://api.github.com/users/bkruczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/bkruczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkruczyk/subscriptions","organizations_url":"https://api.github.com/users/bkruczyk/orgs","repos_url":"https://api.github.com/users/bkruczyk/repos","events_url":"https://api.github.com/users/bkruczyk/events{/privacy}","received_events_url":"https://api.github.com/users/bkruczyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-12T22:58:05Z","updated_at":"2016-10-13T08:18:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider/pulls/1865","html_url":"https://github.com/clojure-emacs/cider/pull/1865","diff_url":"https://github.com/clojure-emacs/cider/pull/1865.diff","patch_url":"https://github.com/clojure-emacs/cider/pull/1865.patch"},"body":"This commit fixes issue where only first line of multilne string\r\nreturned by repl was prefixed.\r\n\r\nAs it changes repl output string, font locking prefix and repl output\r\nseparately would not work and was removed.\r\n\r\n--\r\nThis means that `cider-repl-result-prefix` won't be font locked as comment and rest of output will by font loced with `cider-font-lock-as-clojure`. This looks nice if prefix is someting like `;; => ` and not so bad with other values :)\r\n\r\nIf old behaviour is something necessary it can be done with some more work, let me know if this is good enough."},"comment":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/comments/253446135","html_url":"https://github.com/clojure-emacs/cider/pull/1865#issuecomment-253446135","issue_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1865","id":253446135,"user":{"login":"bkruczyk","id":845609,"avatar_url":"https://avatars.githubusercontent.com/u/845609?v=3","gravatar_id":"","url":"https://api.github.com/users/bkruczyk","html_url":"https://github.com/bkruczyk","followers_url":"https://api.github.com/users/bkruczyk/followers","following_url":"https://api.github.com/users/bkruczyk/following{/other_user}","gists_url":"https://api.github.com/users/bkruczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/bkruczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkruczyk/subscriptions","organizations_url":"https://api.github.com/users/bkruczyk/orgs","repos_url":"https://api.github.com/users/bkruczyk/repos","events_url":"https://api.github.com/users/bkruczyk/events{/privacy}","received_events_url":"https://api.github.com/users/bkruczyk/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T08:18:31Z","updated_at":"2016-10-13T08:18:31Z","body":"@Malabarba Well I don't know if that was the original issue here, but for me above patch works as expected. \r\n\r\nI've noticed that aside from pretty-printing multiline strings are not prefixed, e.g. for prefix `;; ` evaluating\r\n`user> \"foo\\n\\bar\\nbaz\"` would return\r\n```\r\n;; foo\r\nbar\r\nbaz\r\n```\r\n\r\nand not \r\n\r\n```\r\n;; foo\r\n;; bar\r\n;; baz\r\n```\r\n\r\nMaybe it's accidental but patch works with pretty printing as the pretty-printed result is passed as `string` in function `cider-repl-emit-result`.\r\n\r\nIf you have any sugestions how to improve the solution or give me a hint what the root issue may be I'll be glad to work on this."}}
{"actor":{"display_login":"bkruczyk"}}