{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/88317197","pull_request_review_id":8851090,"id":88317197,"diff_hunk":"@@ -0,0 +1,252 @@\n+{\r\n+    \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\r\n+    \"contentVersion\": \"1.0.0.0\",\r\n+    \"parameters\": {\r\n+        \"admin_username\": {\r\n+            \"defaultValue\": null,\r\n+            \"type\": \"string\",\r\n+            \"metadata\": {\r\n+                \"description\": \"The admin username\"\r\n+            }\r\n+        },\r\n+        \"admin_password\": {\r\n+            \"defaultValue\": null,\r\n+            \"type\": \"securestring\",\r\n+            \"metadata\": {\r\n+                \"description\": \"The admin password\"\r\n+            }\r\n+        },\r\n+        \"dns_label_prefix\": {\r\n+            \"type\": \"string\",\r\n+            \"metadata\": {\r\n+                \"description\": \"Unique DNS Name for the Public IP used to access the Virtual Machine.\"\r\n+            }\r\n+        },\r\n+        \"virtual_machine_size\": {\r\n+            \"defaultValue\": \"Standard_D2\",\r\n+            \"type\": \"string\",\r\n+            \"metadata\": {\r\n+                \"description\": \"The virtual machine size\"\r\n+            }\r\n+        },\r\n+        \"_artifactsLocation\": {\r\n+            \"type\": \"string\",\r\n+            \"metadata\": {\r\n+                \"description\": \"The base URI where artifacts required by this template are located. When the template is deployed using the accompanying scripts, a private location in the subscription will be used and this value will be automatically generated.\"\r\n+            },\r\n+            \"defaultValue\": \"https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/bigchaindb-on-ubuntu/\"\r\n+        },\r\n+        \"_artifactsLocationSasToken\": {\r\n+            \"type\": \"securestring\",\r\n+            \"metadata\": {\r\n+                \"description\": \"The sasToken required to access _artifactsLocation.  When the template is deployed using the accompanying scripts, a sasToken will be automatically generated.\"\r\n+            },\r\n+            \"defaultValue\": \"\"\r\n+        }\r\n+    },\r\n+    \"variables\": {\r\n+        \"location\": \"[resourceGroup().location]\",\r\n+        \"storageAccount\": \"[concat(uniquestring(resourceGroup().id), 'storage')]\",\r\n+        \"vmName\": \"bigchaindb\",\r\n+        \"nicName\": \"BDBNic\",\r\n+        \"publicIpName\": \"BDBPublicIp\",\r\n+        \"vnetName\": \"BDBVNet\",\r\n+        \"nsgName\": \"BDBNSG\",\r\n+        \"OSDiskName\": \"bigchaindb_os_disk\",\r\n+        \"fileUris\": \"[concat(parameters('_artifactsLocation'), '/scripts/init.sh', parameters('_artifactsLocationSasToken'))]\",\r\n+        \"vnetID\": \"[resourceId('Microsoft.Network/virtualNetworks', variables('vnetName'))]\",\r\n+        \"subnetRef\": \"[concat(variables('vnetID'), '/subnets/', 'default')]\"\r","path":"bigchaindb-on-ubuntu/azuredeploy.json","position":58,"original_position":58,"commit_id":"246fd3bd877887833e0163219125892d798e4498","original_commit_id":"246fd3bd877887833e0163219125892d798e4498","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars.githubusercontent.com/u/10090014?v=3","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"Simplify this - remove the vnetID variable and use: \r\n\r\nresourceId('Microsoft.Network/virtualNetworks/subnets', variables('vnetName'), 'default')","created_at":"2016-11-16T19:50:51Z","updated_at":"2016-11-16T19:53:29Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2760#discussion_r88317197","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/88317197"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2760#discussion_r88317197"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760","id":93608046,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2760","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/2760.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/2760.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2760","number":2760,"state":"open","locked":false,"title":"Resolve all comments on PR #2543 (prior to now)","user":{"login":"ttmc","id":1210951,"avatar_url":"https://avatars.githubusercontent.com/u/1210951?v=3","gravatar_id":"","url":"https://api.github.com/users/ttmc","html_url":"https://github.com/ttmc","followers_url":"https://api.github.com/users/ttmc/followers","following_url":"https://api.github.com/users/ttmc/following{/other_user}","gists_url":"https://api.github.com/users/ttmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ttmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttmc/subscriptions","organizations_url":"https://api.github.com/users/ttmc/orgs","repos_url":"https://api.github.com/users/ttmc/repos","events_url":"https://api.github.com/users/ttmc/events{/privacy}","received_events_url":"https://api.github.com/users/ttmc/received_events","type":"User","site_admin":false},"body":"This pull request replaces pull request #2543 \r\n\r\n@tomconte said he addressed the comments that @bmoore-msft made on that pull request (#2543).\r\n\r\nProvenance: @tomconte made [a pull request](https://github.com/ttmc/azure-quickstart-templates/pull/1) on [my fork of this repo](https://github.com/ttmc/azure-quickstart-templates), I merged that pull request, and the result is what was used to generate this pull request.","created_at":"2016-11-14T17:15:25Z","updated_at":"2016-11-16T19:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c9d53082f5334b8ee9ff5ce3e324d4bd812e7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2760/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/246fd3bd877887833e0163219125892d798e4498","head":{"label":"ttmc:master","ref":"master","sha":"246fd3bd877887833e0163219125892d798e4498","user":{"login":"ttmc","id":1210951,"avatar_url":"https://avatars.githubusercontent.com/u/1210951?v=3","gravatar_id":"","url":"https://api.github.com/users/ttmc","html_url":"https://github.com/ttmc","followers_url":"https://api.github.com/users/ttmc/followers","following_url":"https://api.github.com/users/ttmc/following{/other_user}","gists_url":"https://api.github.com/users/ttmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ttmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttmc/subscriptions","organizations_url":"https://api.github.com/users/ttmc/orgs","repos_url":"https://api.github.com/users/ttmc/repos","events_url":"https://api.github.com/users/ttmc/events{/privacy}","received_events_url":"https://api.github.com/users/ttmc/received_events","type":"User","site_admin":false},"repo":{"id":67712642,"name":"azure-quickstart-templates","full_name":"ttmc/azure-quickstart-templates","owner":{"login":"ttmc","id":1210951,"avatar_url":"https://avatars.githubusercontent.com/u/1210951?v=3","gravatar_id":"","url":"https://api.github.com/users/ttmc","html_url":"https://github.com/ttmc","followers_url":"https://api.github.com/users/ttmc/followers","following_url":"https://api.github.com/users/ttmc/following{/other_user}","gists_url":"https://api.github.com/users/ttmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ttmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttmc/subscriptions","organizations_url":"https://api.github.com/users/ttmc/orgs","repos_url":"https://api.github.com/users/ttmc/repos","events_url":"https://api.github.com/users/ttmc/events{/privacy}","received_events_url":"https://api.github.com/users/ttmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttmc/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/ttmc/azure-quickstart-templates","forks_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/ttmc/azure-quickstart-templates/deployments","created_at":"2016-09-08T14:53:47Z","updated_at":"2016-09-08T14:53:52Z","pushed_at":"2016-11-15T13:39:13Z","git_url":"git://github.com/ttmc/azure-quickstart-templates.git","ssh_url":"git@github.com:ttmc/azure-quickstart-templates.git","clone_url":"https://github.com/ttmc/azure-quickstart-templates.git","svn_url":"https://github.com/ttmc/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":86952,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"bc2deba4b3e1b9edda937639d87c599f7bc388fb","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2016-11-16T16:26:09Z","pushed_at":"2016-11-16T18:13:21Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":185839,"stargazers_count":1588,"watchers_count":1588,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2252,"mirror_url":null,"open_issues_count":233,"forks":2252,"open_issues":233,"watchers":1588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2760"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2760"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2760/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2760/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/246fd3bd877887833e0163219125892d798e4498"}}}}
{"actor":{"display_login":"bmoore-msft"}}