{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/56550660","id":56550660,"diff_hunk":"@@ -70,6 +70,25 @@ class Html5 extends Tech {\n       }\n     }\n \n+    let trackTypes = ['audio', 'video'];\n+\n+    // ProxyNativeTextTracks\n+    for (let i = 0; i < trackTypes.length; i++) {","path":"src/js/tech/html5.js","position":7,"original_position":7,"commit_id":"aeecbf89430caea8054fbc3100cc1ee9d0c6b073","original_commit_id":"aeecbf89430caea8054fbc3100cc1ee9d0c6b073","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"can you change it to `trackTypes.forEach()` instead?","created_at":"2016-03-17T18:04:52Z","updated_at":"2016-03-17T18:04:52Z","html_url":"https://github.com/videojs/video.js/pull/3173#discussion_r56550660","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/3173","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/56550660"},"html":{"href":"https://github.com/videojs/video.js/pull/3173#discussion_r56550660"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3173"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3173","id":62572097,"html_url":"https://github.com/videojs/video.js/pull/3173","diff_url":"https://github.com/videojs/video.js/pull/3173.diff","patch_url":"https://github.com/videojs/video.js/pull/3173.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3173","number":3173,"state":"open","locked":false,"title":"Integrate video & audio tracks with video.js","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"body":"## Description\r\nImplement `VideoTrack`,  `AudioTrack`, `VideoTrackList`, and `AudioTrackList` using common functionality from `TextTrack` and `TextTrackList`. Which is now shared in a base classes called `Track` and `TrackList`\r\n\r\n## Specific Changes proposed\r\n* Implement Audio/Video Track & Track List\r\n* Move Common functionality into Track and TrackList classes so it can be shared\r\n* Add unit tests for individual everything\r\n* Add unit tests for full integration pieces\r\n\r\n## Requirements Checklist\r\n- [x] Feature implemented / Bug fixed\r\n- [ ] Reviewed by Two Core Contributors\r\n","created_at":"2016-03-11T17:02:39Z","updated_at":"2016-03-17T18:04:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f82483f421851e75c054fc47fc204df8af10223","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3173/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3173/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3173/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/aeecbf89430caea8054fbc3100cc1ee9d0c6b073","head":{"label":"BrandonOCasey:integrate-video-audio-track","ref":"integrate-video-audio-track","sha":"aeecbf89430caea8054fbc3100cc1ee9d0c6b073","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"repo":{"id":48056229,"name":"video.js","full_name":"BrandonOCasey/video.js","owner":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrandonOCasey/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/BrandonOCasey/video.js","forks_url":"https://api.github.com/repos/BrandonOCasey/video.js/forks","keys_url":"https://api.github.com/repos/BrandonOCasey/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrandonOCasey/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrandonOCasey/video.js/teams","hooks_url":"https://api.github.com/repos/BrandonOCasey/video.js/hooks","issue_events_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/BrandonOCasey/video.js/events","assignees_url":"https://api.github.com/repos/BrandonOCasey/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/BrandonOCasey/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/BrandonOCasey/video.js/tags","blobs_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrandonOCasey/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BrandonOCasey/video.js/languages","stargazers_url":"https://api.github.com/repos/BrandonOCasey/video.js/stargazers","contributors_url":"https://api.github.com/repos/BrandonOCasey/video.js/contributors","subscribers_url":"https://api.github.com/repos/BrandonOCasey/video.js/subscribers","subscription_url":"https://api.github.com/repos/BrandonOCasey/video.js/subscription","commits_url":"https://api.github.com/repos/BrandonOCasey/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrandonOCasey/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrandonOCasey/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/BrandonOCasey/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrandonOCasey/video.js/merges","archive_url":"https://api.github.com/repos/BrandonOCasey/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrandonOCasey/video.js/downloads","issues_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/BrandonOCasey/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BrandonOCasey/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BrandonOCasey/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrandonOCasey/video.js/labels{/name}","releases_url":"https://api.github.com/repos/BrandonOCasey/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/BrandonOCasey/video.js/deployments","created_at":"2015-12-15T16:43:06Z","updated_at":"2016-02-12T14:53:16Z","pushed_at":"2016-03-16T20:28:05Z","git_url":"git://github.com/BrandonOCasey/video.js.git","ssh_url":"git@github.com:BrandonOCasey/video.js.git","clone_url":"https://github.com/BrandonOCasey/video.js.git","svn_url":"https://github.com/BrandonOCasey/video.js","homepage":"www.videojs.com","size":74340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"0b26d83e9981560f641f70feb270d6ddcc49ec41","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-03-17T15:55:55Z","pushed_at":"2016-03-17T16:34:32Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":90820,"stargazers_count":11878,"watchers_count":11878,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3459,"mirror_url":null,"open_issues_count":280,"forks":3459,"open_issues":280,"watchers":11878,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3173"},"html":{"href":"https://github.com/videojs/video.js/pull/3173"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3173"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3173/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3173/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3173/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/aeecbf89430caea8054fbc3100cc1ee9d0c6b073"}}}}