{"action":"created","comment":{"url":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments/71816536","id":71816536,"diff_hunk":"@@ -0,0 +1,146 @@\n+include(CMakeParseArguments)\n+\n+set(global_prefix \"${PROJECT_NAME}_\")\n+set(component_prefix \"${PROJECT_NAME}_component_\")\n+\n+define_property(GLOBAL PROPERTY \"${global_prefix}INCLUDE_DIRS\"\n+  BRIEF_DOCS \"Global include directories used by all components.\"\n+  FULL_DOCS \"Global include directories used by all components.\"\n+)\n+define_property(GLOBAL PROPERTY \"${global_prefix}COMPONENTS\"\n+  BRIEF_DOCS \"List all known Aikido components.\"\n+  FULL_DOCS \"List all known Aikido components.\"\n+)\n+\n+#==============================================================================\n+function(add_component component)","path":"cmake/Components.cmake","position":16,"original_position":16,"commit_id":"ab7c9e6baadab863ee852e91500f73272d55f6d5","original_commit_id":"c4c227406be768184ed57cf448fb04bb29deba47","user":{"login":"psigen","id":2805291,"avatar_url":"https://avatars.githubusercontent.com/u/2805291?v=3","gravatar_id":"","url":"https://api.github.com/users/psigen","html_url":"https://github.com/psigen","followers_url":"https://api.github.com/users/psigen/followers","following_url":"https://api.github.com/users/psigen/following{/other_user}","gists_url":"https://api.github.com/users/psigen/gists{/gist_id}","starred_url":"https://api.github.com/users/psigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psigen/subscriptions","organizations_url":"https://api.github.com/users/psigen/orgs","repos_url":"https://api.github.com/users/psigen/repos","events_url":"https://api.github.com/users/psigen/events{/privacy}","received_events_url":"https://api.github.com/users/psigen/received_events","type":"User","site_admin":false},"body":"Well, I don't think we should necessarily assume that we are making components for something named `PROJECT_NAME`.\r\n\r\nI think one reasonable way to do this would be to actually add another property to these functions like:\r\n```cmake\r\nfunction(add_component package_name component)\r\n    [...]\r\nendfunction()\r\n\r\nmacro(setup_component_helpers package_name)\r\n    function(add_${package_name}_component)\r\n        add_component(PACKAGE aikido ${ARGV}})\r\n    endfunction()\r\n    [...]\r\nendmacro()\r\n```\r\nand then in _aikido_'s top-level cmake do something like:\r\n```cmake\r\ninclude(Components.cmake)\r\nsetup_component_helpers(aikido)\r\n\r\nadd_aikido_component(...)\r\n```\r\n(based on http://stackoverflow.com/a/31947751)","created_at":"2016-07-22T01:46:18Z","updated_at":"2016-07-22T01:46:18Z","html_url":"https://github.com/personalrobotics/aikido/pull/107#discussion_r71816536","pull_request_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments/71816536"},"html":{"href":"https://github.com/personalrobotics/aikido/pull/107#discussion_r71816536"},"pull_request":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/personalrobotics/aikido/pulls/107","id":76031556,"html_url":"https://github.com/personalrobotics/aikido/pull/107","diff_url":"https://github.com/personalrobotics/aikido/pull/107.diff","patch_url":"https://github.com/personalrobotics/aikido/pull/107.patch","issue_url":"https://api.github.com/repos/personalrobotics/aikido/issues/107","number":107,"state":"open","locked":false,"title":"Merged aikido_perception and aikido_rviz into aikido","user":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/personalrobotics/aikido/107)\n<!-- Reviewable:end -->\n","created_at":"2016-07-01T20:17:20Z","updated_at":"2016-07-22T01:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c22acbc18e59e45b22e4a7229e83221148f10c2a","assignee":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},{"login":"psigen","id":2805291,"avatar_url":"https://avatars.githubusercontent.com/u/2805291?v=3","gravatar_id":"","url":"https://api.github.com/users/psigen","html_url":"https://github.com/psigen","followers_url":"https://api.github.com/users/psigen/followers","following_url":"https://api.github.com/users/psigen/following{/other_user}","gists_url":"https://api.github.com/users/psigen/gists{/gist_id}","starred_url":"https://api.github.com/users/psigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psigen/subscriptions","organizations_url":"https://api.github.com/users/psigen/orgs","repos_url":"https://api.github.com/users/psigen/repos","events_url":"https://api.github.com/users/psigen/events{/privacy}","received_events_url":"https://api.github.com/users/psigen/received_events","type":"User","site_admin":false},{"login":"jeking04","id":3662021,"avatar_url":"https://avatars.githubusercontent.com/u/3662021?v=3","gravatar_id":"","url":"https://api.github.com/users/jeking04","html_url":"https://github.com/jeking04","followers_url":"https://api.github.com/users/jeking04/followers","following_url":"https://api.github.com/users/jeking04/following{/other_user}","gists_url":"https://api.github.com/users/jeking04/gists{/gist_id}","starred_url":"https://api.github.com/users/jeking04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeking04/subscriptions","organizations_url":"https://api.github.com/users/jeking04/orgs","repos_url":"https://api.github.com/users/jeking04/repos","events_url":"https://api.github.com/users/jeking04/events{/privacy}","received_events_url":"https://api.github.com/users/jeking04/received_events","type":"User","site_admin":false},{"login":"ClintLiddick","id":6076080,"avatar_url":"https://avatars.githubusercontent.com/u/6076080?v=3","gravatar_id":"","url":"https://api.github.com/users/ClintLiddick","html_url":"https://github.com/ClintLiddick","followers_url":"https://api.github.com/users/ClintLiddick/followers","following_url":"https://api.github.com/users/ClintLiddick/following{/other_user}","gists_url":"https://api.github.com/users/ClintLiddick/gists{/gist_id}","starred_url":"https://api.github.com/users/ClintLiddick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClintLiddick/subscriptions","organizations_url":"https://api.github.com/users/ClintLiddick/orgs","repos_url":"https://api.github.com/users/ClintLiddick/repos","events_url":"https://api.github.com/users/ClintLiddick/events{/privacy}","received_events_url":"https://api.github.com/users/ClintLiddick/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/107/commits","review_comments_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/107/comments","review_comment_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments{/number}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/issues/107/comments","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/ab7c9e6baadab863ee852e91500f73272d55f6d5","head":{"label":"personalrobotics:refactor/Components","ref":"refactor/Components","sha":"ab7c9e6baadab863ee852e91500f73272d55f6d5","user":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars.githubusercontent.com/u/4705918?v=3","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":34424077,"name":"aikido","full_name":"personalrobotics/aikido","owner":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars.githubusercontent.com/u/4705918?v=3","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/personalrobotics/aikido","description":"AI for KIDO","fork":false,"url":"https://api.github.com/repos/personalrobotics/aikido","forks_url":"https://api.github.com/repos/personalrobotics/aikido/forks","keys_url":"https://api.github.com/repos/personalrobotics/aikido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/personalrobotics/aikido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/personalrobotics/aikido/teams","hooks_url":"https://api.github.com/repos/personalrobotics/aikido/hooks","issue_events_url":"https://api.github.com/repos/personalrobotics/aikido/issues/events{/number}","events_url":"https://api.github.com/repos/personalrobotics/aikido/events","assignees_url":"https://api.github.com/repos/personalrobotics/aikido/assignees{/user}","branches_url":"https://api.github.com/repos/personalrobotics/aikido/branches{/branch}","tags_url":"https://api.github.com/repos/personalrobotics/aikido/tags","blobs_url":"https://api.github.com/repos/personalrobotics/aikido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/personalrobotics/aikido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/personalrobotics/aikido/git/refs{/sha}","trees_url":"https://api.github.com/repos/personalrobotics/aikido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/{sha}","languages_url":"https://api.github.com/repos/personalrobotics/aikido/languages","stargazers_url":"https://api.github.com/repos/personalrobotics/aikido/stargazers","contributors_url":"https://api.github.com/repos/personalrobotics/aikido/contributors","subscribers_url":"https://api.github.com/repos/personalrobotics/aikido/subscribers","subscription_url":"https://api.github.com/repos/personalrobotics/aikido/subscription","commits_url":"https://api.github.com/repos/personalrobotics/aikido/commits{/sha}","git_commits_url":"https://api.github.com/repos/personalrobotics/aikido/git/commits{/sha}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/comments{/number}","issue_comment_url":"https://api.github.com/repos/personalrobotics/aikido/issues/comments{/number}","contents_url":"https://api.github.com/repos/personalrobotics/aikido/contents/{+path}","compare_url":"https://api.github.com/repos/personalrobotics/aikido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/personalrobotics/aikido/merges","archive_url":"https://api.github.com/repos/personalrobotics/aikido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/personalrobotics/aikido/downloads","issues_url":"https://api.github.com/repos/personalrobotics/aikido/issues{/number}","pulls_url":"https://api.github.com/repos/personalrobotics/aikido/pulls{/number}","milestones_url":"https://api.github.com/repos/personalrobotics/aikido/milestones{/number}","notifications_url":"https://api.github.com/repos/personalrobotics/aikido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/personalrobotics/aikido/labels{/name}","releases_url":"https://api.github.com/repos/personalrobotics/aikido/releases{/id}","deployments_url":"https://api.github.com/repos/personalrobotics/aikido/deployments","created_at":"2015-04-23T00:33:33Z","updated_at":"2016-07-04T18:18:06Z","pushed_at":"2016-07-22T01:04:09Z","git_url":"git://github.com/personalrobotics/aikido.git","ssh_url":"git@github.com:personalrobotics/aikido.git","clone_url":"https://github.com/personalrobotics/aikido.git","svn_url":"https://github.com/personalrobotics/aikido","homepage":"","size":4849,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":51,"forks":0,"open_issues":51,"watchers":3,"default_branch":"master"}},"base":{"label":"personalrobotics:master","ref":"master","sha":"407a63412ced386e99497320ed94da99771473ac","user":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars.githubusercontent.com/u/4705918?v=3","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":34424077,"name":"aikido","full_name":"personalrobotics/aikido","owner":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars.githubusercontent.com/u/4705918?v=3","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/personalrobotics/aikido","description":"AI for KIDO","fork":false,"url":"https://api.github.com/repos/personalrobotics/aikido","forks_url":"https://api.github.com/repos/personalrobotics/aikido/forks","keys_url":"https://api.github.com/repos/personalrobotics/aikido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/personalrobotics/aikido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/personalrobotics/aikido/teams","hooks_url":"https://api.github.com/repos/personalrobotics/aikido/hooks","issue_events_url":"https://api.github.com/repos/personalrobotics/aikido/issues/events{/number}","events_url":"https://api.github.com/repos/personalrobotics/aikido/events","assignees_url":"https://api.github.com/repos/personalrobotics/aikido/assignees{/user}","branches_url":"https://api.github.com/repos/personalrobotics/aikido/branches{/branch}","tags_url":"https://api.github.com/repos/personalrobotics/aikido/tags","blobs_url":"https://api.github.com/repos/personalrobotics/aikido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/personalrobotics/aikido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/personalrobotics/aikido/git/refs{/sha}","trees_url":"https://api.github.com/repos/personalrobotics/aikido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/{sha}","languages_url":"https://api.github.com/repos/personalrobotics/aikido/languages","stargazers_url":"https://api.github.com/repos/personalrobotics/aikido/stargazers","contributors_url":"https://api.github.com/repos/personalrobotics/aikido/contributors","subscribers_url":"https://api.github.com/repos/personalrobotics/aikido/subscribers","subscription_url":"https://api.github.com/repos/personalrobotics/aikido/subscription","commits_url":"https://api.github.com/repos/personalrobotics/aikido/commits{/sha}","git_commits_url":"https://api.github.com/repos/personalrobotics/aikido/git/commits{/sha}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/comments{/number}","issue_comment_url":"https://api.github.com/repos/personalrobotics/aikido/issues/comments{/number}","contents_url":"https://api.github.com/repos/personalrobotics/aikido/contents/{+path}","compare_url":"https://api.github.com/repos/personalrobotics/aikido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/personalrobotics/aikido/merges","archive_url":"https://api.github.com/repos/personalrobotics/aikido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/personalrobotics/aikido/downloads","issues_url":"https://api.github.com/repos/personalrobotics/aikido/issues{/number}","pulls_url":"https://api.github.com/repos/personalrobotics/aikido/pulls{/number}","milestones_url":"https://api.github.com/repos/personalrobotics/aikido/milestones{/number}","notifications_url":"https://api.github.com/repos/personalrobotics/aikido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/personalrobotics/aikido/labels{/name}","releases_url":"https://api.github.com/repos/personalrobotics/aikido/releases{/id}","deployments_url":"https://api.github.com/repos/personalrobotics/aikido/deployments","created_at":"2015-04-23T00:33:33Z","updated_at":"2016-07-04T18:18:06Z","pushed_at":"2016-07-22T01:04:09Z","git_url":"git://github.com/personalrobotics/aikido.git","ssh_url":"git@github.com:personalrobotics/aikido.git","clone_url":"https://github.com/personalrobotics/aikido.git","svn_url":"https://github.com/personalrobotics/aikido","homepage":"","size":4849,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":51,"forks":0,"open_issues":51,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/107"},"html":{"href":"https://github.com/personalrobotics/aikido/pull/107"},"issue":{"href":"https://api.github.com/repos/personalrobotics/aikido/issues/107"},"comments":{"href":"https://api.github.com/repos/personalrobotics/aikido/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/personalrobotics/aikido/statuses/ab7c9e6baadab863ee852e91500f73272d55f6d5"}}}}
{"actor":{"display_login":"psigen"}}