{"action":"created","issue":{"url":"https://api.github.com/repos/boothj5/profanity/issues/747","repository_url":"https://api.github.com/repos/boothj5/profanity","labels_url":"https://api.github.com/repos/boothj5/profanity/issues/747/labels{/name}","comments_url":"https://api.github.com/repos/boothj5/profanity/issues/747/comments","events_url":"https://api.github.com/repos/boothj5/profanity/issues/747/events","html_url":"https://github.com/boothj5/profanity/issues/747","id":136023754,"number":747,"title":"Missing Declaration in src/plugins/api.c","user":{"login":"femnad","id":1352288,"avatar_url":"https://avatars.githubusercontent.com/u/1352288?v=3","gravatar_id":"","url":"https://api.github.com/users/femnad","html_url":"https://github.com/femnad","followers_url":"https://api.github.com/users/femnad/followers","following_url":"https://api.github.com/users/femnad/following{/other_user}","gists_url":"https://api.github.com/users/femnad/gists{/gist_id}","starred_url":"https://api.github.com/users/femnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femnad/subscriptions","organizations_url":"https://api.github.com/users/femnad/orgs","repos_url":"https://api.github.com/users/femnad/repos","events_url":"https://api.github.com/users/femnad/events{/privacy}","received_events_url":"https://api.github.com/users/femnad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-24T10:51:54Z","updated_at":"2016-02-24T13:25:16Z","closed_at":null,"body":"Hello,\r\n\r\nCurrent HEAD (9d31ce4) fails during compilation because of a missing include in `src/plugins/api.c`:\r\n```\r\nsrc/plugins/api.c: In function ‘api_register_command’:\r\nsrc/plugins/api.c:119:9: error: implicit declaration of function ‘strdup’ [-Werror=implicit-function-declaration]\r\n         help->synopsis[i] = strdup(synopsis[i]);\r\n         ^\r\nsrc/plugins/api.c:119:29: error: incompatible implicit declaration of built-in function ‘strdup’ [-Werror]\r\n         help->synopsis[i] = strdup(synopsis[i]);\r\n                             ^\r\nsrc/plugins/api.c:123:18: error: incompatible implicit declaration of built-in function ‘strdup’ [-Werror]\r\n     help->desc = strdup(description);\r\n```\r\n\r\nI think `string.h` should be included in `src/plugins/api.c`."},"comment":{"url":"https://api.github.com/repos/boothj5/profanity/issues/comments/188253382","html_url":"https://github.com/boothj5/profanity/issues/747#issuecomment-188253382","issue_url":"https://api.github.com/repos/boothj5/profanity/issues/747","id":188253382,"user":{"login":"femnad","id":1352288,"avatar_url":"https://avatars.githubusercontent.com/u/1352288?v=3","gravatar_id":"","url":"https://api.github.com/users/femnad","html_url":"https://github.com/femnad","followers_url":"https://api.github.com/users/femnad/followers","following_url":"https://api.github.com/users/femnad/following{/other_user}","gists_url":"https://api.github.com/users/femnad/gists{/gist_id}","starred_url":"https://api.github.com/users/femnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femnad/subscriptions","organizations_url":"https://api.github.com/users/femnad/orgs","repos_url":"https://api.github.com/users/femnad/repos","events_url":"https://api.github.com/users/femnad/events{/privacy}","received_events_url":"https://api.github.com/users/femnad/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T13:25:15Z","updated_at":"2016-02-24T13:25:15Z","body":"Yes, after inspecting the `configure.ac` file I realize that the `-Werror` flag is active only when the `PACKAGE_STATUS` is defined as `development`, which is the case for a git clone, but not the tarball release. So, this is observable only when compiling from a git clone and making the compilation run successfully is easy enough via modifying `src/plugins/api.c` or the autoconf script."}}