{"action":"created","comment":{"url":"https://api.github.com/repos/wincinderith/topicons/pulls/comments/82097186","pull_request_review_id":3028343,"id":82097186,"diff_hunk":"@@ -24,15 +24,18 @@ build:\n \tmkdir -vp build\n \tcp -vr schemas convenience.js extension.js metadata.json prefs.js build\n \tglib-compile-schemas build/schemas\n+\n clean:\n \trm -vrf build\n \n install: build\n-\tln -sfn ${PWD}/build $(EXT_DIR)/$(EXT_NAME)\n+\tcp -vr ${PWD}/build $(EXT_DIR)/$(EXT_NAME)\n+\n uninstall:\n-\trm -v $(EXT_DIR)/$(EXT_NAME)\n+\trm -vrf $(EXT_DIR)/$(EXT_NAME)\n \n fetch-updates:\n \tgit reset --hard HEAD\n \tgit pull --rebase --prune\n+\n update: clean fetch-updates build","path":"Makefile","position":20,"original_position":20,"commit_id":"95446423039e5a556bfaa83133a971b3e82fd148","original_commit_id":"95446423039e5a556bfaa83133a971b3e82fd148","user":{"login":"wincinderith","id":13294419,"avatar_url":"https://avatars.githubusercontent.com/u/13294419?v=3","gravatar_id":"","url":"https://api.github.com/users/wincinderith","html_url":"https://github.com/wincinderith","followers_url":"https://api.github.com/users/wincinderith/followers","following_url":"https://api.github.com/users/wincinderith/following{/other_user}","gists_url":"https://api.github.com/users/wincinderith/gists{/gist_id}","starred_url":"https://api.github.com/users/wincinderith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincinderith/subscriptions","organizations_url":"https://api.github.com/users/wincinderith/orgs","repos_url":"https://api.github.com/users/wincinderith/repos","events_url":"https://api.github.com/users/wincinderith/events{/privacy}","received_events_url":"https://api.github.com/users/wincinderith/received_events","type":"User","site_admin":false},"body":"@ffflorian I'll handle this with a push directly to `master`. Thanks for your contribution!","created_at":"2016-10-06T00:13:13Z","updated_at":"2016-10-06T00:13:13Z","html_url":"https://github.com/wincinderith/topicons/pull/12#discussion_r82097186","pull_request_url":"https://api.github.com/repos/wincinderith/topicons/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/comments/82097186"},"html":{"href":"https://github.com/wincinderith/topicons/pull/12#discussion_r82097186"},"pull_request":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/wincinderith/topicons/pulls/12","id":87952960,"html_url":"https://github.com/wincinderith/topicons/pull/12","diff_url":"https://github.com/wincinderith/topicons/pull/12.diff","patch_url":"https://github.com/wincinderith/topicons/pull/12.patch","issue_url":"https://api.github.com/repos/wincinderith/topicons/issues/12","number":12,"state":"open","locked":false,"title":"Move built files instead of linking","user":{"login":"ffflorian","id":5497598,"avatar_url":"https://avatars.githubusercontent.com/u/5497598?v=3","gravatar_id":"","url":"https://api.github.com/users/ffflorian","html_url":"https://github.com/ffflorian","followers_url":"https://api.github.com/users/ffflorian/followers","following_url":"https://api.github.com/users/ffflorian/following{/other_user}","gists_url":"https://api.github.com/users/ffflorian/gists{/gist_id}","starred_url":"https://api.github.com/users/ffflorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffflorian/subscriptions","organizations_url":"https://api.github.com/users/ffflorian/orgs","repos_url":"https://api.github.com/users/ffflorian/repos","events_url":"https://api.github.com/users/ffflorian/events{/privacy}","received_events_url":"https://api.github.com/users/ffflorian/received_events","type":"User","site_admin":false},"body":"The link breaks (thus the plugin doesn't work anymore) when the user moves or deletes the repository folder - I don't consider linking very stable in this case.\r\n\r\nI suggest to move the `build` folder into the user's local extension folder, so they don't have to keep the repository on their computer.","created_at":"2016-10-04T18:57:02Z","updated_at":"2016-10-06T00:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d8f973e55f147f0ccf0ddf00a2cf3e91fb54ef5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wincinderith/topicons/pulls/12/commits","review_comments_url":"https://api.github.com/repos/wincinderith/topicons/pulls/12/comments","review_comment_url":"https://api.github.com/repos/wincinderith/topicons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wincinderith/topicons/issues/12/comments","statuses_url":"https://api.github.com/repos/wincinderith/topicons/statuses/95446423039e5a556bfaa83133a971b3e82fd148","head":{"label":"ffflorian:patch-1","ref":"patch-1","sha":"95446423039e5a556bfaa83133a971b3e82fd148","user":{"login":"ffflorian","id":5497598,"avatar_url":"https://avatars.githubusercontent.com/u/5497598?v=3","gravatar_id":"","url":"https://api.github.com/users/ffflorian","html_url":"https://github.com/ffflorian","followers_url":"https://api.github.com/users/ffflorian/followers","following_url":"https://api.github.com/users/ffflorian/following{/other_user}","gists_url":"https://api.github.com/users/ffflorian/gists{/gist_id}","starred_url":"https://api.github.com/users/ffflorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffflorian/subscriptions","organizations_url":"https://api.github.com/users/ffflorian/orgs","repos_url":"https://api.github.com/users/ffflorian/repos","events_url":"https://api.github.com/users/ffflorian/events{/privacy}","received_events_url":"https://api.github.com/users/ffflorian/received_events","type":"User","site_admin":false},"repo":{"id":69995765,"name":"topicons","full_name":"ffflorian/topicons","owner":{"login":"ffflorian","id":5497598,"avatar_url":"https://avatars.githubusercontent.com/u/5497598?v=3","gravatar_id":"","url":"https://api.github.com/users/ffflorian","html_url":"https://github.com/ffflorian","followers_url":"https://api.github.com/users/ffflorian/followers","following_url":"https://api.github.com/users/ffflorian/following{/other_user}","gists_url":"https://api.github.com/users/ffflorian/gists{/gist_id}","starred_url":"https://api.github.com/users/ffflorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffflorian/subscriptions","organizations_url":"https://api.github.com/users/ffflorian/orgs","repos_url":"https://api.github.com/users/ffflorian/repos","events_url":"https://api.github.com/users/ffflorian/events{/privacy}","received_events_url":"https://api.github.com/users/ffflorian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ffflorian/topicons","description":"A GNOME shell extension to show legacy tray icons in the top bar.","fork":true,"url":"https://api.github.com/repos/ffflorian/topicons","forks_url":"https://api.github.com/repos/ffflorian/topicons/forks","keys_url":"https://api.github.com/repos/ffflorian/topicons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ffflorian/topicons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ffflorian/topicons/teams","hooks_url":"https://api.github.com/repos/ffflorian/topicons/hooks","issue_events_url":"https://api.github.com/repos/ffflorian/topicons/issues/events{/number}","events_url":"https://api.github.com/repos/ffflorian/topicons/events","assignees_url":"https://api.github.com/repos/ffflorian/topicons/assignees{/user}","branches_url":"https://api.github.com/repos/ffflorian/topicons/branches{/branch}","tags_url":"https://api.github.com/repos/ffflorian/topicons/tags","blobs_url":"https://api.github.com/repos/ffflorian/topicons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ffflorian/topicons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ffflorian/topicons/git/refs{/sha}","trees_url":"https://api.github.com/repos/ffflorian/topicons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ffflorian/topicons/statuses/{sha}","languages_url":"https://api.github.com/repos/ffflorian/topicons/languages","stargazers_url":"https://api.github.com/repos/ffflorian/topicons/stargazers","contributors_url":"https://api.github.com/repos/ffflorian/topicons/contributors","subscribers_url":"https://api.github.com/repos/ffflorian/topicons/subscribers","subscription_url":"https://api.github.com/repos/ffflorian/topicons/subscription","commits_url":"https://api.github.com/repos/ffflorian/topicons/commits{/sha}","git_commits_url":"https://api.github.com/repos/ffflorian/topicons/git/commits{/sha}","comments_url":"https://api.github.com/repos/ffflorian/topicons/comments{/number}","issue_comment_url":"https://api.github.com/repos/ffflorian/topicons/issues/comments{/number}","contents_url":"https://api.github.com/repos/ffflorian/topicons/contents/{+path}","compare_url":"https://api.github.com/repos/ffflorian/topicons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ffflorian/topicons/merges","archive_url":"https://api.github.com/repos/ffflorian/topicons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ffflorian/topicons/downloads","issues_url":"https://api.github.com/repos/ffflorian/topicons/issues{/number}","pulls_url":"https://api.github.com/repos/ffflorian/topicons/pulls{/number}","milestones_url":"https://api.github.com/repos/ffflorian/topicons/milestones{/number}","notifications_url":"https://api.github.com/repos/ffflorian/topicons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ffflorian/topicons/labels{/name}","releases_url":"https://api.github.com/repos/ffflorian/topicons/releases{/id}","deployments_url":"https://api.github.com/repos/ffflorian/topicons/deployments","created_at":"2016-10-04T18:49:24Z","updated_at":"2016-10-04T18:49:25Z","pushed_at":"2016-10-05T10:25:28Z","git_url":"git://github.com/ffflorian/topicons.git","ssh_url":"git@github.com:ffflorian/topicons.git","clone_url":"https://github.com/ffflorian/topicons.git","svn_url":"https://github.com/ffflorian/topicons","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wincinderith:master","ref":"master","sha":"8b7baa92bdb1a6b2c5e6dfe65a1aa467eb182041","user":{"login":"wincinderith","id":13294419,"avatar_url":"https://avatars.githubusercontent.com/u/13294419?v=3","gravatar_id":"","url":"https://api.github.com/users/wincinderith","html_url":"https://github.com/wincinderith","followers_url":"https://api.github.com/users/wincinderith/followers","following_url":"https://api.github.com/users/wincinderith/following{/other_user}","gists_url":"https://api.github.com/users/wincinderith/gists{/gist_id}","starred_url":"https://api.github.com/users/wincinderith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincinderith/subscriptions","organizations_url":"https://api.github.com/users/wincinderith/orgs","repos_url":"https://api.github.com/users/wincinderith/repos","events_url":"https://api.github.com/users/wincinderith/events{/privacy}","received_events_url":"https://api.github.com/users/wincinderith/received_events","type":"User","site_admin":false},"repo":{"id":44841524,"name":"topicons","full_name":"wincinderith/topicons","owner":{"login":"wincinderith","id":13294419,"avatar_url":"https://avatars.githubusercontent.com/u/13294419?v=3","gravatar_id":"","url":"https://api.github.com/users/wincinderith","html_url":"https://github.com/wincinderith","followers_url":"https://api.github.com/users/wincinderith/followers","following_url":"https://api.github.com/users/wincinderith/following{/other_user}","gists_url":"https://api.github.com/users/wincinderith/gists{/gist_id}","starred_url":"https://api.github.com/users/wincinderith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincinderith/subscriptions","organizations_url":"https://api.github.com/users/wincinderith/orgs","repos_url":"https://api.github.com/users/wincinderith/repos","events_url":"https://api.github.com/users/wincinderith/events{/privacy}","received_events_url":"https://api.github.com/users/wincinderith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wincinderith/topicons","description":"A GNOME shell extension to show legacy tray icons in the top bar.","fork":false,"url":"https://api.github.com/repos/wincinderith/topicons","forks_url":"https://api.github.com/repos/wincinderith/topicons/forks","keys_url":"https://api.github.com/repos/wincinderith/topicons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wincinderith/topicons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wincinderith/topicons/teams","hooks_url":"https://api.github.com/repos/wincinderith/topicons/hooks","issue_events_url":"https://api.github.com/repos/wincinderith/topicons/issues/events{/number}","events_url":"https://api.github.com/repos/wincinderith/topicons/events","assignees_url":"https://api.github.com/repos/wincinderith/topicons/assignees{/user}","branches_url":"https://api.github.com/repos/wincinderith/topicons/branches{/branch}","tags_url":"https://api.github.com/repos/wincinderith/topicons/tags","blobs_url":"https://api.github.com/repos/wincinderith/topicons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wincinderith/topicons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wincinderith/topicons/git/refs{/sha}","trees_url":"https://api.github.com/repos/wincinderith/topicons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wincinderith/topicons/statuses/{sha}","languages_url":"https://api.github.com/repos/wincinderith/topicons/languages","stargazers_url":"https://api.github.com/repos/wincinderith/topicons/stargazers","contributors_url":"https://api.github.com/repos/wincinderith/topicons/contributors","subscribers_url":"https://api.github.com/repos/wincinderith/topicons/subscribers","subscription_url":"https://api.github.com/repos/wincinderith/topicons/subscription","commits_url":"https://api.github.com/repos/wincinderith/topicons/commits{/sha}","git_commits_url":"https://api.github.com/repos/wincinderith/topicons/git/commits{/sha}","comments_url":"https://api.github.com/repos/wincinderith/topicons/comments{/number}","issue_comment_url":"https://api.github.com/repos/wincinderith/topicons/issues/comments{/number}","contents_url":"https://api.github.com/repos/wincinderith/topicons/contents/{+path}","compare_url":"https://api.github.com/repos/wincinderith/topicons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wincinderith/topicons/merges","archive_url":"https://api.github.com/repos/wincinderith/topicons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wincinderith/topicons/downloads","issues_url":"https://api.github.com/repos/wincinderith/topicons/issues{/number}","pulls_url":"https://api.github.com/repos/wincinderith/topicons/pulls{/number}","milestones_url":"https://api.github.com/repos/wincinderith/topicons/milestones{/number}","notifications_url":"https://api.github.com/repos/wincinderith/topicons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wincinderith/topicons/labels{/name}","releases_url":"https://api.github.com/repos/wincinderith/topicons/releases{/id}","deployments_url":"https://api.github.com/repos/wincinderith/topicons/deployments","created_at":"2015-10-23T22:19:39Z","updated_at":"2016-10-04T16:22:21Z","pushed_at":"2016-10-05T10:25:28Z","git_url":"git://github.com/wincinderith/topicons.git","ssh_url":"git@github.com:wincinderith/topicons.git","clone_url":"https://github.com/wincinderith/topicons.git","svn_url":"https://github.com/wincinderith/topicons","homepage":null,"size":44,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/12"},"html":{"href":"https://github.com/wincinderith/topicons/pull/12"},"issue":{"href":"https://api.github.com/repos/wincinderith/topicons/issues/12"},"comments":{"href":"https://api.github.com/repos/wincinderith/topicons/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wincinderith/topicons/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/wincinderith/topicons/statuses/95446423039e5a556bfaa83133a971b3e82fd148"}}}}
{"actor":{"display_login":"wincinderith"}}