{"action":"closed","number":208,"pull_request":{"url":"https://api.github.com/repos/airbnb/synapse/pulls/208","id":82532037,"html_url":"https://github.com/airbnb/synapse/pull/208","diff_url":"https://github.com/airbnb/synapse/pull/208.diff","patch_url":"https://github.com/airbnb/synapse/pull/208.patch","issue_url":"https://api.github.com/repos/airbnb/synapse/issues/208","number":208,"state":"closed","locked":false,"title":"comment line was breaking config comparison","user":{"login":"davent","id":1391336,"avatar_url":"https://avatars.githubusercontent.com/u/1391336?v=3","gravatar_id":"","url":"https://api.github.com/users/davent","html_url":"https://github.com/davent","followers_url":"https://api.github.com/users/davent/followers","following_url":"https://api.github.com/users/davent/following{/other_user}","gists_url":"https://api.github.com/users/davent/gists{/gist_id}","starred_url":"https://api.github.com/users/davent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davent/subscriptions","organizations_url":"https://api.github.com/users/davent/orgs","repos_url":"https://api.github.com/users/davent/repos","events_url":"https://api.github.com/users/davent/events{/privacy}","received_events_url":"https://api.github.com/users/davent/received_events","type":"User","site_admin":false},"body":"Due to the auto-generated comment line included on the first line of the HAProxy, a restart of HAProxy will occur even when the configuration itself is identical.\r\n\r\nHere is an example diff when no configuration has actually changed:\r\n```\r\n1c1\r\n< # auto-generated by synapse at 2016-08-24 10:20:55 +0000\r\n---\r\n> # auto-generated by synapse at 2016-08-24 10:22:47 +0000\r\n```\r\nAs the logic to decide whether or not the config is different is just a simple string comparison (within the write_config function) it will never return true.","created_at":"2016-08-24T12:22:54Z","updated_at":"2016-10-07T14:34:49Z","closed_at":"2016-10-07T14:34:49Z","merged_at":null,"merge_commit_sha":"d8961f921618c864b4c5e029caabd7b50b196d38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/synapse/pulls/208/commits","review_comments_url":"https://api.github.com/repos/airbnb/synapse/pulls/208/comments","review_comment_url":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/synapse/issues/208/comments","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/952c8a12a48da794884b962798d78b6541d2361d","head":{"label":"davent:identical_config_fix","ref":"identical_config_fix","sha":"952c8a12a48da794884b962798d78b6541d2361d","user":{"login":"davent","id":1391336,"avatar_url":"https://avatars.githubusercontent.com/u/1391336?v=3","gravatar_id":"","url":"https://api.github.com/users/davent","html_url":"https://github.com/davent","followers_url":"https://api.github.com/users/davent/followers","following_url":"https://api.github.com/users/davent/following{/other_user}","gists_url":"https://api.github.com/users/davent/gists{/gist_id}","starred_url":"https://api.github.com/users/davent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davent/subscriptions","organizations_url":"https://api.github.com/users/davent/orgs","repos_url":"https://api.github.com/users/davent/repos","events_url":"https://api.github.com/users/davent/events{/privacy}","received_events_url":"https://api.github.com/users/davent/received_events","type":"User","site_admin":false},"repo":{"id":66459823,"name":"synapse","full_name":"davent/synapse","owner":{"login":"davent","id":1391336,"avatar_url":"https://avatars.githubusercontent.com/u/1391336?v=3","gravatar_id":"","url":"https://api.github.com/users/davent","html_url":"https://github.com/davent","followers_url":"https://api.github.com/users/davent/followers","following_url":"https://api.github.com/users/davent/following{/other_user}","gists_url":"https://api.github.com/users/davent/gists{/gist_id}","starred_url":"https://api.github.com/users/davent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davent/subscriptions","organizations_url":"https://api.github.com/users/davent/orgs","repos_url":"https://api.github.com/users/davent/repos","events_url":"https://api.github.com/users/davent/events{/privacy}","received_events_url":"https://api.github.com/users/davent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davent/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":true,"url":"https://api.github.com/repos/davent/synapse","forks_url":"https://api.github.com/repos/davent/synapse/forks","keys_url":"https://api.github.com/repos/davent/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davent/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davent/synapse/teams","hooks_url":"https://api.github.com/repos/davent/synapse/hooks","issue_events_url":"https://api.github.com/repos/davent/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/davent/synapse/events","assignees_url":"https://api.github.com/repos/davent/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/davent/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/davent/synapse/tags","blobs_url":"https://api.github.com/repos/davent/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davent/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davent/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/davent/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davent/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/davent/synapse/languages","stargazers_url":"https://api.github.com/repos/davent/synapse/stargazers","contributors_url":"https://api.github.com/repos/davent/synapse/contributors","subscribers_url":"https://api.github.com/repos/davent/synapse/subscribers","subscription_url":"https://api.github.com/repos/davent/synapse/subscription","commits_url":"https://api.github.com/repos/davent/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/davent/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/davent/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/davent/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/davent/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/davent/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davent/synapse/merges","archive_url":"https://api.github.com/repos/davent/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davent/synapse/downloads","issues_url":"https://api.github.com/repos/davent/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/davent/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/davent/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/davent/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davent/synapse/labels{/name}","releases_url":"https://api.github.com/repos/davent/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/davent/synapse/deployments","created_at":"2016-08-24T11:51:51Z","updated_at":"2016-08-24T11:51:52Z","pushed_at":"2016-08-24T14:31:39Z","git_url":"git://github.com/davent/synapse.git","ssh_url":"git@github.com:davent/synapse.git","clone_url":"https://github.com/davent/synapse.git","svn_url":"https://github.com/davent/synapse","homepage":"","size":557,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"dd892c9aabfb4b790dbd94ff7010bbd3be210b41","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6607851,"name":"synapse","full_name":"airbnb/synapse","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":false,"url":"https://api.github.com/repos/airbnb/synapse","forks_url":"https://api.github.com/repos/airbnb/synapse/forks","keys_url":"https://api.github.com/repos/airbnb/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/synapse/teams","hooks_url":"https://api.github.com/repos/airbnb/synapse/hooks","issue_events_url":"https://api.github.com/repos/airbnb/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/synapse/events","assignees_url":"https://api.github.com/repos/airbnb/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/synapse/tags","blobs_url":"https://api.github.com/repos/airbnb/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/synapse/languages","stargazers_url":"https://api.github.com/repos/airbnb/synapse/stargazers","contributors_url":"https://api.github.com/repos/airbnb/synapse/contributors","subscribers_url":"https://api.github.com/repos/airbnb/synapse/subscribers","subscription_url":"https://api.github.com/repos/airbnb/synapse/subscription","commits_url":"https://api.github.com/repos/airbnb/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/synapse/merges","archive_url":"https://api.github.com/repos/airbnb/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/synapse/downloads","issues_url":"https://api.github.com/repos/airbnb/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/synapse/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/synapse/deployments","created_at":"2012-11-09T03:03:06Z","updated_at":"2016-10-07T07:37:30Z","pushed_at":"2016-09-10T03:07:47Z","git_url":"git://github.com/airbnb/synapse.git","ssh_url":"git@github.com:airbnb/synapse.git","clone_url":"https://github.com/airbnb/synapse.git","svn_url":"https://github.com/airbnb/synapse","homepage":"","size":918,"stargazers_count":1469,"watchers_count":1469,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":46,"forks":194,"open_issues":46,"watchers":1469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/208"},"html":{"href":"https://github.com/airbnb/synapse/pull/208"},"issue":{"href":"https://api.github.com/repos/airbnb/synapse/issues/208"},"comments":{"href":"https://api.github.com/repos/airbnb/synapse/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/synapse/statuses/952c8a12a48da794884b962798d78b6541d2361d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":3,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jolynch"}}