{"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/84557147","pull_request_review_id":5331666,"id":84557147,"diff_hunk":"@@ -657,6 +660,27 @@ func (self *manager) getRequestedContainers(containerName string, options v2.Req\n \treturn containersMap, nil\n }\n \n+func (self *manager) GetDirFsInfo(dir string) (v2.FsInfo, error) {\n+\tdirDevice, err := self.fsInfo.GetDirFsDevice(dir)\n+\tif err != nil {\n+\t\treturn v2.FsInfo{}, fmt.Errorf(\"error trying to get filesystem Device for dir %v: err: %v\", dir, err)\n+\t}\n+\tdirMountpoint, err := self.fsInfo.GetMountpointForDevice(dirDevice.Device)\n+\tif err != nil {\n+\t\treturn v2.FsInfo{}, fmt.Errorf(\"error trying to get MountPoint for Root Device: %v, err: %v\", dirDevice, err)\n+\t}\n+\tinfos, err := self.GetFsInfo(\"\")","path":"manager/manager.go","position":23,"original_position":23,"commit_id":"3fec19a10eb506c9543132be8d97d98aa7c59cf0","original_commit_id":"3a33ceba831d5db84f97b01d2911788384be682c","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"body":"Spoke offline, decided to stick with this.","created_at":"2016-10-21T22:47:27Z","updated_at":"2016-10-21T22:47:27Z","html_url":"https://github.com/google/cadvisor/pull/1507#discussion_r84557147","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/1507","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/84557147"},"html":{"href":"https://github.com/google/cadvisor/pull/1507#discussion_r84557147"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1507"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/1507","id":90093805,"html_url":"https://github.com/google/cadvisor/pull/1507","diff_url":"https://github.com/google/cadvisor/pull/1507.diff","patch_url":"https://github.com/google/cadvisor/pull/1507.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1507","number":1507,"state":"open","locked":false,"title":"added GetDirFsInfo, which returns filesystem information for the specified directory","user":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"body":"This will allow us to, for example, monitor the filesystem that includes /var/lib/kubelet, by calling GetDirFsInfo(\"/var/lib/kubelet\").","created_at":"2016-10-19T21:26:09Z","updated_at":"2016-10-21T22:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d25d8bb16fe875ef17a50d8408ed8ee5177f0701","assignee":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"assignees":[{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/1507/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/1507/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1507/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/3fec19a10eb506c9543132be8d97d98aa7c59cf0","head":{"label":"dashpole:dir_fs_info","ref":"dir_fs_info","sha":"3fec19a10eb506c9543132be8d97d98aa7c59cf0","user":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"repo":{"id":69054147,"name":"cadvisor","full_name":"dashpole/cadvisor","owner":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dashpole/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/dashpole/cadvisor","forks_url":"https://api.github.com/repos/dashpole/cadvisor/forks","keys_url":"https://api.github.com/repos/dashpole/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpole/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpole/cadvisor/teams","hooks_url":"https://api.github.com/repos/dashpole/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/dashpole/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/dashpole/cadvisor/events","assignees_url":"https://api.github.com/repos/dashpole/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/dashpole/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/dashpole/cadvisor/tags","blobs_url":"https://api.github.com/repos/dashpole/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpole/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpole/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpole/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpole/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpole/cadvisor/languages","stargazers_url":"https://api.github.com/repos/dashpole/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/dashpole/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/dashpole/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/dashpole/cadvisor/subscription","commits_url":"https://api.github.com/repos/dashpole/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpole/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpole/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpole/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpole/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/dashpole/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpole/cadvisor/merges","archive_url":"https://api.github.com/repos/dashpole/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpole/cadvisor/downloads","issues_url":"https://api.github.com/repos/dashpole/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/dashpole/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpole/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpole/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpole/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/dashpole/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/dashpole/cadvisor/deployments","created_at":"2016-09-23T19:19:32Z","updated_at":"2016-09-23T19:19:35Z","pushed_at":"2016-10-21T22:41:33Z","git_url":"git://github.com/dashpole/cadvisor.git","ssh_url":"git@github.com:dashpole/cadvisor.git","clone_url":"https://github.com/dashpole/cadvisor.git","svn_url":"https://github.com/dashpole/cadvisor","homepage":"","size":23370,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"1f00ce6905c331afcf4797eb940899e588eef385","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/google/cadvisor/deployments","created_at":"2014-06-09T16:36:33Z","updated_at":"2016-10-21T20:46:36Z","pushed_at":"2016-10-21T22:41:34Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":32278,"stargazers_count":4702,"watchers_count":4702,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":674,"mirror_url":null,"open_issues_count":232,"forks":674,"open_issues":232,"watchers":4702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1507"},"html":{"href":"https://github.com/google/cadvisor/pull/1507"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/1507"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/1507/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1507/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1507/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/3fec19a10eb506c9543132be8d97d98aa7c59cf0"}}}}
{"actor":{"display_login":"timstclair"}}