{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/rapid7/rex/pulls/6","id":98378100,"html_url":"https://github.com/rapid7/rex/pull/6","diff_url":"https://github.com/rapid7/rex/pull/6.diff","patch_url":"https://github.com/rapid7/rex/pull/6.patch","issue_url":"https://api.github.com/repos/rapid7/rex/issues/6","number":6,"state":"closed","locked":false,"title":"Update client.rb","user":{"login":"arch4ngel","id":11574161,"avatar_url":"https://avatars.githubusercontent.com/u/11574161?v=3","gravatar_id":"","url":"https://api.github.com/users/arch4ngel","html_url":"https://github.com/arch4ngel","followers_url":"https://api.github.com/users/arch4ngel/followers","following_url":"https://api.github.com/users/arch4ngel/following{/other_user}","gists_url":"https://api.github.com/users/arch4ngel/gists{/gist_id}","starred_url":"https://api.github.com/users/arch4ngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arch4ngel/subscriptions","organizations_url":"https://api.github.com/users/arch4ngel/orgs","repos_url":"https://api.github.com/users/arch4ngel/repos","events_url":"https://api.github.com/users/arch4ngel/events{/privacy}","received_events_url":"https://api.github.com/users/arch4ngel/received_events","type":"User","site_admin":false},"body":"Line 126 references the instance variable self.smb.read_timeout. SMB is an instance of simpleclient (Lines 118 || 120) and does not have an instance variable by that name. Client, which is an instance variable of a simpleclient object, does. I updated this line to access the client instance variable. Testing this appears to work as intended.","created_at":"2016-12-16T18:04:35Z","updated_at":"2016-12-16T18:35:04Z","closed_at":"2016-12-16T18:35:04Z","merged_at":null,"merge_commit_sha":"13a6d25fe7f7a66de6968f4c423b72d2ad585292","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/rex/pulls/6/commits","review_comments_url":"https://api.github.com/repos/rapid7/rex/pulls/6/comments","review_comment_url":"https://api.github.com/repos/rapid7/rex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/rex/issues/6/comments","statuses_url":"https://api.github.com/repos/rapid7/rex/statuses/d417a8796bc8c6fdc15d7b6b22c5f912dd4e9b58","head":{"label":"arch4ngel:master","ref":"master","sha":"d417a8796bc8c6fdc15d7b6b22c5f912dd4e9b58","user":{"login":"arch4ngel","id":11574161,"avatar_url":"https://avatars.githubusercontent.com/u/11574161?v=3","gravatar_id":"","url":"https://api.github.com/users/arch4ngel","html_url":"https://github.com/arch4ngel","followers_url":"https://api.github.com/users/arch4ngel/followers","following_url":"https://api.github.com/users/arch4ngel/following{/other_user}","gists_url":"https://api.github.com/users/arch4ngel/gists{/gist_id}","starred_url":"https://api.github.com/users/arch4ngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arch4ngel/subscriptions","organizations_url":"https://api.github.com/users/arch4ngel/orgs","repos_url":"https://api.github.com/users/arch4ngel/repos","events_url":"https://api.github.com/users/arch4ngel/events{/privacy}","received_events_url":"https://api.github.com/users/arch4ngel/received_events","type":"User","site_admin":false},"repo":{"id":76674095,"name":"rex","full_name":"arch4ngel/rex","owner":{"login":"arch4ngel","id":11574161,"avatar_url":"https://avatars.githubusercontent.com/u/11574161?v=3","gravatar_id":"","url":"https://api.github.com/users/arch4ngel","html_url":"https://github.com/arch4ngel","followers_url":"https://api.github.com/users/arch4ngel/followers","following_url":"https://api.github.com/users/arch4ngel/following{/other_user}","gists_url":"https://api.github.com/users/arch4ngel/gists{/gist_id}","starred_url":"https://api.github.com/users/arch4ngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arch4ngel/subscriptions","organizations_url":"https://api.github.com/users/arch4ngel/orgs","repos_url":"https://api.github.com/users/arch4ngel/repos","events_url":"https://api.github.com/users/arch4ngel/events{/privacy}","received_events_url":"https://api.github.com/users/arch4ngel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arch4ngel/rex","description":"Rex provides a variety of classes useful for security testing and exploit development.","fork":true,"url":"https://api.github.com/repos/arch4ngel/rex","forks_url":"https://api.github.com/repos/arch4ngel/rex/forks","keys_url":"https://api.github.com/repos/arch4ngel/rex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arch4ngel/rex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arch4ngel/rex/teams","hooks_url":"https://api.github.com/repos/arch4ngel/rex/hooks","issue_events_url":"https://api.github.com/repos/arch4ngel/rex/issues/events{/number}","events_url":"https://api.github.com/repos/arch4ngel/rex/events","assignees_url":"https://api.github.com/repos/arch4ngel/rex/assignees{/user}","branches_url":"https://api.github.com/repos/arch4ngel/rex/branches{/branch}","tags_url":"https://api.github.com/repos/arch4ngel/rex/tags","blobs_url":"https://api.github.com/repos/arch4ngel/rex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arch4ngel/rex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arch4ngel/rex/git/refs{/sha}","trees_url":"https://api.github.com/repos/arch4ngel/rex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arch4ngel/rex/statuses/{sha}","languages_url":"https://api.github.com/repos/arch4ngel/rex/languages","stargazers_url":"https://api.github.com/repos/arch4ngel/rex/stargazers","contributors_url":"https://api.github.com/repos/arch4ngel/rex/contributors","subscribers_url":"https://api.github.com/repos/arch4ngel/rex/subscribers","subscription_url":"https://api.github.com/repos/arch4ngel/rex/subscription","commits_url":"https://api.github.com/repos/arch4ngel/rex/commits{/sha}","git_commits_url":"https://api.github.com/repos/arch4ngel/rex/git/commits{/sha}","comments_url":"https://api.github.com/repos/arch4ngel/rex/comments{/number}","issue_comment_url":"https://api.github.com/repos/arch4ngel/rex/issues/comments{/number}","contents_url":"https://api.github.com/repos/arch4ngel/rex/contents/{+path}","compare_url":"https://api.github.com/repos/arch4ngel/rex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arch4ngel/rex/merges","archive_url":"https://api.github.com/repos/arch4ngel/rex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arch4ngel/rex/downloads","issues_url":"https://api.github.com/repos/arch4ngel/rex/issues{/number}","pulls_url":"https://api.github.com/repos/arch4ngel/rex/pulls{/number}","milestones_url":"https://api.github.com/repos/arch4ngel/rex/milestones{/number}","notifications_url":"https://api.github.com/repos/arch4ngel/rex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arch4ngel/rex/labels{/name}","releases_url":"https://api.github.com/repos/arch4ngel/rex/releases{/id}","deployments_url":"https://api.github.com/repos/arch4ngel/rex/deployments","created_at":"2016-12-16T17:53:13Z","updated_at":"2016-12-16T17:53:17Z","pushed_at":"2016-12-16T18:02:03Z","git_url":"git://github.com/arch4ngel/rex.git","ssh_url":"git@github.com:arch4ngel/rex.git","clone_url":"https://github.com/arch4ngel/rex.git","svn_url":"https://github.com/arch4ngel/rex","homepage":null,"size":264182,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"1542aeeab5e1267ad041e73ca404aad20f52deef","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":23768727,"name":"rex","full_name":"rapid7/rex","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/rex","description":"Rex provides a variety of classes useful for security testing and exploit development.","fork":false,"url":"https://api.github.com/repos/rapid7/rex","forks_url":"https://api.github.com/repos/rapid7/rex/forks","keys_url":"https://api.github.com/repos/rapid7/rex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/rex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/rex/teams","hooks_url":"https://api.github.com/repos/rapid7/rex/hooks","issue_events_url":"https://api.github.com/repos/rapid7/rex/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/rex/events","assignees_url":"https://api.github.com/repos/rapid7/rex/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/rex/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/rex/tags","blobs_url":"https://api.github.com/repos/rapid7/rex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/rex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/rex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/rex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/rex/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/rex/languages","stargazers_url":"https://api.github.com/repos/rapid7/rex/stargazers","contributors_url":"https://api.github.com/repos/rapid7/rex/contributors","subscribers_url":"https://api.github.com/repos/rapid7/rex/subscribers","subscription_url":"https://api.github.com/repos/rapid7/rex/subscription","commits_url":"https://api.github.com/repos/rapid7/rex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/rex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/rex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/rex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/rex/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/rex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/rex/merges","archive_url":"https://api.github.com/repos/rapid7/rex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/rex/downloads","issues_url":"https://api.github.com/repos/rapid7/rex/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/rex/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/rex/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/rex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/rex/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/rex/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/rex/deployments","created_at":"2014-09-07T19:25:11Z","updated_at":"2016-12-15T02:26:40Z","pushed_at":"2016-12-16T18:04:35Z","git_url":"git://github.com/rapid7/rex.git","ssh_url":"git@github.com:rapid7/rex.git","clone_url":"https://github.com/rapid7/rex.git","svn_url":"https://github.com/rapid7/rex","homepage":null,"size":264182,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/rex/pulls/6"},"html":{"href":"https://github.com/rapid7/rex/pull/6"},"issue":{"href":"https://api.github.com/repos/rapid7/rex/issues/6"},"comments":{"href":"https://api.github.com/repos/rapid7/rex/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/rex/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/rex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/rex/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/rex/statuses/d417a8796bc8c6fdc15d7b6b22c5f912dd4e9b58"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hdm"}}