{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments/92557912","pull_request_review_id":13074830,"id":92557912,"diff_hunk":"@@ -19,7 +19,7 @@ public class ConfigureScenariosForMsmqTransport : IConfigureSupportedScenariosFo\n \n public class ConfigureEndpointMsmqTransport : IConfigureEndpointTestExecution\n {\n-    public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings)\n+    public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings, PublisherMetadata publisherMetadata)","path":"src/NServiceBus.Callbacks.AcceptanceTests/ConfigureEndpointMsmqTransport.cs","position":5,"original_position":5,"commit_id":"d163eff914e71f2f6c7d613440f9c87d4da7f984","original_commit_id":"d163eff914e71f2f6c7d613440f9c87d4da7f984","user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars.githubusercontent.com/u/3524870?v=3","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"body":"shouldn't we also apply the metadata to the publisher api when using MSMQ (even though it doesn't seem to be used in these tests?)","created_at":"2016-12-15T07:45:15Z","updated_at":"2016-12-15T07:47:09Z","html_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/49#discussion_r92557912","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments/92557912"},"html":{"href":"https://github.com/Particular/NServiceBus.Callbacks/pull/49#discussion_r92557912"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49","id":96530801,"html_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/49","diff_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/49.diff","patch_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/49.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/49","number":49,"state":"open","locked":false,"title":"Update to core 6.1","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"relates to https://github.com/Particular/NServiceBus/pull/4377","created_at":"2016-12-05T13:43:33Z","updated_at":"2016-12-15T07:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1f11c5e25283f8e4694897e8101421dfb303669","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/49/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/d163eff914e71f2f6c7d613440f9c87d4da7f984","head":{"label":"Particular:callbacks-update61","ref":"callbacks-update61","sha":"d163eff914e71f2f6c7d613440f9c87d4da7f984","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":39256075,"name":"NServiceBus.Callbacks","full_name":"Particular/NServiceBus.Callbacks","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Callbacks","description":null,"fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/deployments","created_at":"2015-07-17T13:43:45Z","updated_at":"2016-10-10T21:03:12Z","pushed_at":"2016-12-14T22:10:46Z","git_url":"git://github.com/Particular/NServiceBus.Callbacks.git","ssh_url":"git@github.com:Particular/NServiceBus.Callbacks.git","clone_url":"https://github.com/Particular/NServiceBus.Callbacks.git","svn_url":"https://github.com/Particular/NServiceBus.Callbacks","homepage":"https://docs.particular.net/nservicebus/messaging/callbacks","size":191,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":2,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"7d69f94979e7dc82c8527d7cbc0a0d95a863a7e0","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":39256075,"name":"NServiceBus.Callbacks","full_name":"Particular/NServiceBus.Callbacks","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Callbacks","description":null,"fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/deployments","created_at":"2015-07-17T13:43:45Z","updated_at":"2016-10-10T21:03:12Z","pushed_at":"2016-12-14T22:10:46Z","git_url":"git://github.com/Particular/NServiceBus.Callbacks.git","ssh_url":"git@github.com:Particular/NServiceBus.Callbacks.git","clone_url":"https://github.com/Particular/NServiceBus.Callbacks.git","svn_url":"https://github.com/Particular/NServiceBus.Callbacks","homepage":"https://docs.particular.net/nservicebus/messaging/callbacks","size":191,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49"},"html":{"href":"https://github.com/Particular/NServiceBus.Callbacks/pull/49"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/49"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/d163eff914e71f2f6c7d613440f9c87d4da7f984"}}}}
{"actor":{"display_login":"timbussmann"}}