{"action":"opened","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31186","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31186/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31186/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31186/events","html_url":"https://github.com/kubernetes/kubernetes/issues/31186","id":172576284,"number":31186,"title":"Address open issues from \"Azure data disk volume\" PR","user":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/storage","name":"area/storage","color":"006b75"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/cluster","name":"team/cluster","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"assignees":[{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-08-22T23:09:55Z","updated_at":"2016-08-22T23:09:55Z","closed_at":null,"body":"This issue is to track and follow-up on the unaddressed comments/open issues on PR #29836 \"support Azure data disk volume\":\r\n* Remove `KeyMutex` since volumemanager/attach detach controller handle concurrency\r\n  * https://github.com/kubernetes/kubernetes/pull/29836#discussion-diff-74159683\r\n* Add comments to public methods.\r\n  * https://github.com/kubernetes/kubernetes/pull/29836/files#r75774475\r\n* Document (in comments) the violation of contract where lun is being returned instead of device path.\r\n* Ensure that Warningf, Errorf, and Infof (with varying verbosity) is used correctly.\r\n  * e.g. https://github.com/kubernetes/kubernetes/pull/29836/files#r74161572, https://github.com/kubernetes/kubernetes/pull/29836/files#r75775075, https://github.com/kubernetes/kubernetes/pull/29836/files#r75775317\r\n* Don't swallow unmount errors\r\n  * https://github.com/kubernetes/kubernetes/pull/29836/files#r75775683\r\n"}}
{"actor":{"display_login":"saad-ali"}}