{"action":"created","comment":{"url":"https://api.github.com/repos/smealum/ctrulib/pulls/comments/93650194","pull_request_review_id":14182588,"id":93650194,"diff_hunk":"@@ -930,11 +988,19 @@ Result svcKernelSetState(u32 type, ...);\n void svcBreak(UserBreakType breakReason);\n \n /**\n+ * @brief Breaks execution.\n+ * @param breakReason Debug reason for breaking.\n+ * @param debugParameter1 First debugging parameter\n+ * @param debugParameter2 Second debugging parameter\n+ */\n+void svcDebugBreak(UserBreakType breakReason, u32 debugParameter1, u32 debugParameter2);\n+\n+/**\n  * @brief Outputs a debug string.\n  * @param str String to output.\n- * @param length Length of the string to output.\n+ * @param length Length of the string to output (needs to be positive).\n  */\n-Result svcOutputDebugString(const char* str, int length);\n+Result svcOutputDebugString(const char* str, s32 length);","path":"libctru/include/3ds/svc.h","position":385,"original_position":350,"commit_id":"e38d2bc4d94cc770facd3d400e90946b5c8362d3","original_commit_id":"4d9970d8f2e64191c043c94cb068fb42f96b6795","user":{"login":"mtheall","id":896483,"avatar_url":"https://avatars.githubusercontent.com/u/896483?v=3","gravatar_id":"","url":"https://api.github.com/users/mtheall","html_url":"https://github.com/mtheall","followers_url":"https://api.github.com/users/mtheall/followers","following_url":"https://api.github.com/users/mtheall/following{/other_user}","gists_url":"https://api.github.com/users/mtheall/gists{/gist_id}","starred_url":"https://api.github.com/users/mtheall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtheall/subscriptions","organizations_url":"https://api.github.com/users/mtheall/orgs","repos_url":"https://api.github.com/users/mtheall/repos","events_url":"https://api.github.com/users/mtheall/events{/privacy}","received_events_url":"https://api.github.com/users/mtheall/received_events","type":"User","site_admin":false},"body":"Signed integers don't have a \"sign bit\" per se. It just happens to be that the high bit of a negative number is always set, but that's just a side-effect of twos-complement form. If they truly had a sign bit, you would gain -0 but lose -2147483648.\r\n\r\nIn any case, the kernel treats this parameter as signed. I would therefore leave the size parameter as s32.","created_at":"2016-12-22T16:10:17Z","updated_at":"2016-12-22T16:10:17Z","html_url":"https://github.com/smealum/ctrulib/pull/325#discussion_r93650194","pull_request_url":"https://api.github.com/repos/smealum/ctrulib/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/comments/93650194"},"html":{"href":"https://github.com/smealum/ctrulib/pull/325#discussion_r93650194"},"pull_request":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/smealum/ctrulib/pulls/325","id":99007921,"html_url":"https://github.com/smealum/ctrulib/pull/325","diff_url":"https://github.com/smealum/ctrulib/pull/325.diff","patch_url":"https://github.com/smealum/ctrulib/pull/325.patch","issue_url":"https://api.github.com/repos/smealum/ctrulib/issues/325","number":325,"state":"open","locked":false,"title":"Finish implementing the debug SVCs, fix bugs, other changes","user":{"login":"TuxSH","id":1922548,"avatar_url":"https://avatars.githubusercontent.com/u/1922548?v=3","gravatar_id":"","url":"https://api.github.com/users/TuxSH","html_url":"https://github.com/TuxSH","followers_url":"https://api.github.com/users/TuxSH/followers","following_url":"https://api.github.com/users/TuxSH/following{/other_user}","gists_url":"https://api.github.com/users/TuxSH/gists{/gist_id}","starred_url":"https://api.github.com/users/TuxSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuxSH/subscriptions","organizations_url":"https://api.github.com/users/TuxSH/orgs","repos_url":"https://api.github.com/users/TuxSH/repos","events_url":"https://api.github.com/users/TuxSH/events{/privacy}","received_events_url":"https://api.github.com/users/TuxSH/received_events","type":"User","site_admin":false},"body":"This completes the definition of `DebugEventInfo` and defines the remaining types for the debug SVCs, implement the remaining SVCs, etc.\r\n\r\nTwo debug SVCs were also renamed.","created_at":"2016-12-21T21:29:06Z","updated_at":"2016-12-22T16:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"589b495ad1de8232f1648619fd0df9b45dfdd430","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smealum/ctrulib/pulls/325/commits","review_comments_url":"https://api.github.com/repos/smealum/ctrulib/pulls/325/comments","review_comment_url":"https://api.github.com/repos/smealum/ctrulib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smealum/ctrulib/issues/325/comments","statuses_url":"https://api.github.com/repos/smealum/ctrulib/statuses/e38d2bc4d94cc770facd3d400e90946b5c8362d3","head":{"label":"TuxSH:master","ref":"master","sha":"e38d2bc4d94cc770facd3d400e90946b5c8362d3","user":{"login":"TuxSH","id":1922548,"avatar_url":"https://avatars.githubusercontent.com/u/1922548?v=3","gravatar_id":"","url":"https://api.github.com/users/TuxSH","html_url":"https://github.com/TuxSH","followers_url":"https://api.github.com/users/TuxSH/followers","following_url":"https://api.github.com/users/TuxSH/following{/other_user}","gists_url":"https://api.github.com/users/TuxSH/gists{/gist_id}","starred_url":"https://api.github.com/users/TuxSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuxSH/subscriptions","organizations_url":"https://api.github.com/users/TuxSH/orgs","repos_url":"https://api.github.com/users/TuxSH/repos","events_url":"https://api.github.com/users/TuxSH/events{/privacy}","received_events_url":"https://api.github.com/users/TuxSH/received_events","type":"User","site_admin":false},"repo":{"id":48952817,"name":"ctrulib","full_name":"TuxSH/ctrulib","owner":{"login":"TuxSH","id":1922548,"avatar_url":"https://avatars.githubusercontent.com/u/1922548?v=3","gravatar_id":"","url":"https://api.github.com/users/TuxSH","html_url":"https://github.com/TuxSH","followers_url":"https://api.github.com/users/TuxSH/followers","following_url":"https://api.github.com/users/TuxSH/following{/other_user}","gists_url":"https://api.github.com/users/TuxSH/gists{/gist_id}","starred_url":"https://api.github.com/users/TuxSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuxSH/subscriptions","organizations_url":"https://api.github.com/users/TuxSH/orgs","repos_url":"https://api.github.com/users/TuxSH/repos","events_url":"https://api.github.com/users/TuxSH/events{/privacy}","received_events_url":"https://api.github.com/users/TuxSH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TuxSH/ctrulib","description":"C library for writing user mode arm11 code for the 3DS (CTR)","fork":true,"url":"https://api.github.com/repos/TuxSH/ctrulib","forks_url":"https://api.github.com/repos/TuxSH/ctrulib/forks","keys_url":"https://api.github.com/repos/TuxSH/ctrulib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TuxSH/ctrulib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TuxSH/ctrulib/teams","hooks_url":"https://api.github.com/repos/TuxSH/ctrulib/hooks","issue_events_url":"https://api.github.com/repos/TuxSH/ctrulib/issues/events{/number}","events_url":"https://api.github.com/repos/TuxSH/ctrulib/events","assignees_url":"https://api.github.com/repos/TuxSH/ctrulib/assignees{/user}","branches_url":"https://api.github.com/repos/TuxSH/ctrulib/branches{/branch}","tags_url":"https://api.github.com/repos/TuxSH/ctrulib/tags","blobs_url":"https://api.github.com/repos/TuxSH/ctrulib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TuxSH/ctrulib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TuxSH/ctrulib/git/refs{/sha}","trees_url":"https://api.github.com/repos/TuxSH/ctrulib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TuxSH/ctrulib/statuses/{sha}","languages_url":"https://api.github.com/repos/TuxSH/ctrulib/languages","stargazers_url":"https://api.github.com/repos/TuxSH/ctrulib/stargazers","contributors_url":"https://api.github.com/repos/TuxSH/ctrulib/contributors","subscribers_url":"https://api.github.com/repos/TuxSH/ctrulib/subscribers","subscription_url":"https://api.github.com/repos/TuxSH/ctrulib/subscription","commits_url":"https://api.github.com/repos/TuxSH/ctrulib/commits{/sha}","git_commits_url":"https://api.github.com/repos/TuxSH/ctrulib/git/commits{/sha}","comments_url":"https://api.github.com/repos/TuxSH/ctrulib/comments{/number}","issue_comment_url":"https://api.github.com/repos/TuxSH/ctrulib/issues/comments{/number}","contents_url":"https://api.github.com/repos/TuxSH/ctrulib/contents/{+path}","compare_url":"https://api.github.com/repos/TuxSH/ctrulib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TuxSH/ctrulib/merges","archive_url":"https://api.github.com/repos/TuxSH/ctrulib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TuxSH/ctrulib/downloads","issues_url":"https://api.github.com/repos/TuxSH/ctrulib/issues{/number}","pulls_url":"https://api.github.com/repos/TuxSH/ctrulib/pulls{/number}","milestones_url":"https://api.github.com/repos/TuxSH/ctrulib/milestones{/number}","notifications_url":"https://api.github.com/repos/TuxSH/ctrulib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TuxSH/ctrulib/labels{/name}","releases_url":"https://api.github.com/repos/TuxSH/ctrulib/releases{/id}","deployments_url":"https://api.github.com/repos/TuxSH/ctrulib/deployments","created_at":"2016-01-03T16:35:43Z","updated_at":"2016-12-20T22:18:04Z","pushed_at":"2016-12-22T00:08:43Z","git_url":"git://github.com/TuxSH/ctrulib.git","ssh_url":"git@github.com:TuxSH/ctrulib.git","clone_url":"https://github.com/TuxSH/ctrulib.git","svn_url":"https://github.com/TuxSH/ctrulib","homepage":"","size":6726,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"smealum:master","ref":"master","sha":"e8c3a9139e37ddc0d4f2f624becd28db335a9c44","user":{"login":"smealum","id":6338016,"avatar_url":"https://avatars.githubusercontent.com/u/6338016?v=3","gravatar_id":"","url":"https://api.github.com/users/smealum","html_url":"https://github.com/smealum","followers_url":"https://api.github.com/users/smealum/followers","following_url":"https://api.github.com/users/smealum/following{/other_user}","gists_url":"https://api.github.com/users/smealum/gists{/gist_id}","starred_url":"https://api.github.com/users/smealum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smealum/subscriptions","organizations_url":"https://api.github.com/users/smealum/orgs","repos_url":"https://api.github.com/users/smealum/repos","events_url":"https://api.github.com/users/smealum/events{/privacy}","received_events_url":"https://api.github.com/users/smealum/received_events","type":"User","site_admin":false},"repo":{"id":16035058,"name":"ctrulib","full_name":"smealum/ctrulib","owner":{"login":"smealum","id":6338016,"avatar_url":"https://avatars.githubusercontent.com/u/6338016?v=3","gravatar_id":"","url":"https://api.github.com/users/smealum","html_url":"https://github.com/smealum","followers_url":"https://api.github.com/users/smealum/followers","following_url":"https://api.github.com/users/smealum/following{/other_user}","gists_url":"https://api.github.com/users/smealum/gists{/gist_id}","starred_url":"https://api.github.com/users/smealum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smealum/subscriptions","organizations_url":"https://api.github.com/users/smealum/orgs","repos_url":"https://api.github.com/users/smealum/repos","events_url":"https://api.github.com/users/smealum/events{/privacy}","received_events_url":"https://api.github.com/users/smealum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smealum/ctrulib","description":"C library for writing user mode arm11 code for the 3DS (CTR)","fork":false,"url":"https://api.github.com/repos/smealum/ctrulib","forks_url":"https://api.github.com/repos/smealum/ctrulib/forks","keys_url":"https://api.github.com/repos/smealum/ctrulib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smealum/ctrulib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smealum/ctrulib/teams","hooks_url":"https://api.github.com/repos/smealum/ctrulib/hooks","issue_events_url":"https://api.github.com/repos/smealum/ctrulib/issues/events{/number}","events_url":"https://api.github.com/repos/smealum/ctrulib/events","assignees_url":"https://api.github.com/repos/smealum/ctrulib/assignees{/user}","branches_url":"https://api.github.com/repos/smealum/ctrulib/branches{/branch}","tags_url":"https://api.github.com/repos/smealum/ctrulib/tags","blobs_url":"https://api.github.com/repos/smealum/ctrulib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smealum/ctrulib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smealum/ctrulib/git/refs{/sha}","trees_url":"https://api.github.com/repos/smealum/ctrulib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smealum/ctrulib/statuses/{sha}","languages_url":"https://api.github.com/repos/smealum/ctrulib/languages","stargazers_url":"https://api.github.com/repos/smealum/ctrulib/stargazers","contributors_url":"https://api.github.com/repos/smealum/ctrulib/contributors","subscribers_url":"https://api.github.com/repos/smealum/ctrulib/subscribers","subscription_url":"https://api.github.com/repos/smealum/ctrulib/subscription","commits_url":"https://api.github.com/repos/smealum/ctrulib/commits{/sha}","git_commits_url":"https://api.github.com/repos/smealum/ctrulib/git/commits{/sha}","comments_url":"https://api.github.com/repos/smealum/ctrulib/comments{/number}","issue_comment_url":"https://api.github.com/repos/smealum/ctrulib/issues/comments{/number}","contents_url":"https://api.github.com/repos/smealum/ctrulib/contents/{+path}","compare_url":"https://api.github.com/repos/smealum/ctrulib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smealum/ctrulib/merges","archive_url":"https://api.github.com/repos/smealum/ctrulib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smealum/ctrulib/downloads","issues_url":"https://api.github.com/repos/smealum/ctrulib/issues{/number}","pulls_url":"https://api.github.com/repos/smealum/ctrulib/pulls{/number}","milestones_url":"https://api.github.com/repos/smealum/ctrulib/milestones{/number}","notifications_url":"https://api.github.com/repos/smealum/ctrulib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smealum/ctrulib/labels{/name}","releases_url":"https://api.github.com/repos/smealum/ctrulib/releases{/id}","deployments_url":"https://api.github.com/repos/smealum/ctrulib/deployments","created_at":"2014-01-18T22:11:32Z","updated_at":"2016-12-14T21:43:55Z","pushed_at":"2016-12-22T07:18:36Z","git_url":"git://github.com/smealum/ctrulib.git","ssh_url":"git@github.com:smealum/ctrulib.git","clone_url":"https://github.com/smealum/ctrulib.git","svn_url":"https://github.com/smealum/ctrulib","homepage":"","size":7127,"stargazers_count":339,"watchers_count":339,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":119,"mirror_url":null,"open_issues_count":12,"forks":119,"open_issues":12,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/325"},"html":{"href":"https://github.com/smealum/ctrulib/pull/325"},"issue":{"href":"https://api.github.com/repos/smealum/ctrulib/issues/325"},"comments":{"href":"https://api.github.com/repos/smealum/ctrulib/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smealum/ctrulib/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/smealum/ctrulib/statuses/e38d2bc4d94cc770facd3d400e90946b5c8362d3"}}}}
{"actor":{"display_login":"mtheall"}}