{"action":"created","issue":{"url":"https://api.github.com/repos/deitch/jstree-grid/issues/179","repository_url":"https://api.github.com/repos/deitch/jstree-grid","labels_url":"https://api.github.com/repos/deitch/jstree-grid/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/deitch/jstree-grid/issues/179/comments","events_url":"https://api.github.com/repos/deitch/jstree-grid/issues/179/events","html_url":"https://github.com/deitch/jstree-grid/issues/179","id":181348135,"number":179,"title":"Indicate Search matches entire row","user":{"login":"QueroBartK","id":20296285,"avatar_url":"https://avatars.githubusercontent.com/u/20296285?v=3","gravatar_id":"","url":"https://api.github.com/users/QueroBartK","html_url":"https://github.com/QueroBartK","followers_url":"https://api.github.com/users/QueroBartK/followers","following_url":"https://api.github.com/users/QueroBartK/following{/other_user}","gists_url":"https://api.github.com/users/QueroBartK/gists{/gist_id}","starred_url":"https://api.github.com/users/QueroBartK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QueroBartK/subscriptions","organizations_url":"https://api.github.com/users/QueroBartK/orgs","repos_url":"https://api.github.com/users/QueroBartK/repos","events_url":"https://api.github.com/users/QueroBartK/events{/privacy}","received_events_url":"https://api.github.com/users/QueroBartK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-06T08:01:30Z","updated_at":"2016-10-07T13:14:13Z","closed_at":null,"body":"currently when searching the matches will be shown in bold red in the jstree but not in the other columns.\r\nI'm not sure if this behaviour is intended or not.\r\n\r\nIn case it is not you could add the 'jstree-search' class to the columns on the same row as the search result.\r\n\r\nThis can be done by adding the code : \r\n```\r\ndata.nodes.filter('.jstree-node').each(function(i,node) {\r\n\tvar nodeId = node.id;\r\n\tif(nodeId){\r\n\t\tfindDataCell(grid, nodeId).addClass(\"jstree-search\");\r\n\t}\r\n});\r\n```\r\nbefore https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L409 (so before getting in the if statement)\r\n\r\n(PS: the above code is basically the same as what you do on https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L414 but without adding the parent nodes of the matched nodes)\r\n\r\nSince the data.nodes to start with only has the matched nodes it will only select the correct rows\r\n\r\nIn order to unmark the matches we'll need to change the following line https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L427 to\r\n`this.gridWrapper.find('div.jstree-grid-cell').removeClass(\"jstree-search\").show();`\r\nso that not only it shows all cells again it also removes all nodes with the jstree-search class\r\n"},"comment":{"url":"https://api.github.com/repos/deitch/jstree-grid/issues/comments/252248680","html_url":"https://github.com/deitch/jstree-grid/issues/179#issuecomment-252248680","issue_url":"https://api.github.com/repos/deitch/jstree-grid/issues/179","id":252248680,"user":{"login":"deitch","id":282526,"avatar_url":"https://avatars.githubusercontent.com/u/282526?v=3","gravatar_id":"","url":"https://api.github.com/users/deitch","html_url":"https://github.com/deitch","followers_url":"https://api.github.com/users/deitch/followers","following_url":"https://api.github.com/users/deitch/following{/other_user}","gists_url":"https://api.github.com/users/deitch/gists{/gist_id}","starred_url":"https://api.github.com/users/deitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deitch/subscriptions","organizations_url":"https://api.github.com/users/deitch/orgs","repos_url":"https://api.github.com/users/deitch/repos","events_url":"https://api.github.com/users/deitch/events{/privacy}","received_events_url":"https://api.github.com/users/deitch/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T13:14:13Z","updated_at":"2016-10-07T13:14:13Z","body":"Well, as you know only too well, the way we do it is use the `search_callback` to indicate if a given row should match or not. Unfortunately, jstree doesn't give us an option to say, \"yes, this row matches, but do not highlight it.\" We could play around with the CSS to get there, but it is asking for trouble.\r\n\r\nGiven that, yeah, it probably is better to highlight the whole row. Let's do that."}}
{"actor":{"display_login":"deitch"}}