{"action":"closed","number":132,"pull_request":{"url":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132","id":71274725,"html_url":"https://github.com/Kunstmaan/skylab/pull/132","diff_url":"https://github.com/Kunstmaan/skylab/pull/132.diff","patch_url":"https://github.com/Kunstmaan/skylab/pull/132.patch","issue_url":"https://api.github.com/repos/Kunstmaan/skylab/issues/132","number":132,"state":"closed","locked":false,"title":"set owner and permissions in alphabetical order","user":{"login":"janfrederik","id":18148910,"avatar_url":"https://avatars.githubusercontent.com/u/18148910?v=3","gravatar_id":"","url":"https://api.github.com/users/janfrederik","html_url":"https://github.com/janfrederik","followers_url":"https://api.github.com/users/janfrederik/followers","following_url":"https://api.github.com/users/janfrederik/following{/other_user}","gists_url":"https://api.github.com/users/janfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/janfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janfrederik/subscriptions","organizations_url":"https://api.github.com/users/janfrederik/orgs","repos_url":"https://api.github.com/users/janfrederik/repos","events_url":"https://api.github.com/users/janfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/janfrederik/received_events","type":"User","site_admin":false},"body":"When running `skylab permissions my_project`, it looks like the folders defined in `permissions.xml` are iterated in random order to set the permissions.\r\n\r\nMy experience:\r\n\r\n- For the same user, I set permissions for folders \"/\", and \"/site\". These folders are defined in this order the permissions.xml.\r\n\r\n```xml\r\n  <var name=\"/site\">\r\n    <item value=\"-R -m u:@config.wwwuser@:r-X\"/>\r\n   <item value=\"-R -m d:u:@config.wwwuser@:r-X\"/>\r\n    (...)\r\n  </var>\r\n  <var name=\"/site/wp-content\">\r\n    <item value=\"-R -m u:@config.wwwuser@:rwX\"/>\r\n    <item value=\"-R -m d:u:@config.wwwuser@:rwX\"/>\r\n    (...)\r\n  </var>\r\n```\r\n\r\n- I run `skylab permissions my_project`\r\n\r\nResult of `getfacl` on my_project/site/wp-content:\r\n```\r\nuser:www-data:r-x\r\ndefault:user:www-data:r-x\r\n(...)\r\n```\r\n\r\nThis behavior is not consistent for all projects. That's why I suppose the folders are just picked in a random order for applying the permissions. In this case: first permissions are set for \"/site\", which are later on replaced by the -R permissions on \"/\".\r\nIn my opinion, `skylab permissions` should honor the order in which the folders are defined in the xml. Or better: alphabetical order of the folders. This defines a clear rule that allow for overriding ACL's in subfolders.\r\n\r\nThis patch does just that.","created_at":"2016-05-24T19:02:24Z","updated_at":"2016-05-24T19:21:58Z","closed_at":"2016-05-24T19:21:58Z","merged_at":"2016-05-24T19:21:58Z","merge_commit_sha":"6e7eb71ee043a9306a7d3c7c98f0c8e91ed2ae71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132/commits","review_comments_url":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132/comments","review_comment_url":"https://api.github.com/repos/Kunstmaan/skylab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kunstmaan/skylab/issues/132/comments","statuses_url":"https://api.github.com/repos/Kunstmaan/skylab/statuses/ce1b745d9cad25ad65f377e3435d55d1c37a1eef","head":{"label":"janfrederik:perm-order","ref":"perm-order","sha":"ce1b745d9cad25ad65f377e3435d55d1c37a1eef","user":{"login":"janfrederik","id":18148910,"avatar_url":"https://avatars.githubusercontent.com/u/18148910?v=3","gravatar_id":"","url":"https://api.github.com/users/janfrederik","html_url":"https://github.com/janfrederik","followers_url":"https://api.github.com/users/janfrederik/followers","following_url":"https://api.github.com/users/janfrederik/following{/other_user}","gists_url":"https://api.github.com/users/janfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/janfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janfrederik/subscriptions","organizations_url":"https://api.github.com/users/janfrederik/orgs","repos_url":"https://api.github.com/users/janfrederik/repos","events_url":"https://api.github.com/users/janfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/janfrederik/received_events","type":"User","site_admin":false},"repo":{"id":54995917,"name":"skylab","full_name":"janfrederik/skylab","owner":{"login":"janfrederik","id":18148910,"avatar_url":"https://avatars.githubusercontent.com/u/18148910?v=3","gravatar_id":"","url":"https://api.github.com/users/janfrederik","html_url":"https://github.com/janfrederik","followers_url":"https://api.github.com/users/janfrederik/followers","following_url":"https://api.github.com/users/janfrederik/following{/other_user}","gists_url":"https://api.github.com/users/janfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/janfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janfrederik/subscriptions","organizations_url":"https://api.github.com/users/janfrederik/orgs","repos_url":"https://api.github.com/users/janfrederik/repos","events_url":"https://api.github.com/users/janfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/janfrederik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janfrederik/skylab","description":"Skylab is a 100% backwards compatible PHP port of the Python based hosting scripts used at Kunstmaan. By using the Cilex, Symfony Components and lot's of good code samples from the Composer project we hope to create an application where everyone in our organisation can work with, and if issues or new needed features should arise, be able to work on.","fork":true,"url":"https://api.github.com/repos/janfrederik/skylab","forks_url":"https://api.github.com/repos/janfrederik/skylab/forks","keys_url":"https://api.github.com/repos/janfrederik/skylab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janfrederik/skylab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janfrederik/skylab/teams","hooks_url":"https://api.github.com/repos/janfrederik/skylab/hooks","issue_events_url":"https://api.github.com/repos/janfrederik/skylab/issues/events{/number}","events_url":"https://api.github.com/repos/janfrederik/skylab/events","assignees_url":"https://api.github.com/repos/janfrederik/skylab/assignees{/user}","branches_url":"https://api.github.com/repos/janfrederik/skylab/branches{/branch}","tags_url":"https://api.github.com/repos/janfrederik/skylab/tags","blobs_url":"https://api.github.com/repos/janfrederik/skylab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janfrederik/skylab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janfrederik/skylab/git/refs{/sha}","trees_url":"https://api.github.com/repos/janfrederik/skylab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janfrederik/skylab/statuses/{sha}","languages_url":"https://api.github.com/repos/janfrederik/skylab/languages","stargazers_url":"https://api.github.com/repos/janfrederik/skylab/stargazers","contributors_url":"https://api.github.com/repos/janfrederik/skylab/contributors","subscribers_url":"https://api.github.com/repos/janfrederik/skylab/subscribers","subscription_url":"https://api.github.com/repos/janfrederik/skylab/subscription","commits_url":"https://api.github.com/repos/janfrederik/skylab/commits{/sha}","git_commits_url":"https://api.github.com/repos/janfrederik/skylab/git/commits{/sha}","comments_url":"https://api.github.com/repos/janfrederik/skylab/comments{/number}","issue_comment_url":"https://api.github.com/repos/janfrederik/skylab/issues/comments{/number}","contents_url":"https://api.github.com/repos/janfrederik/skylab/contents/{+path}","compare_url":"https://api.github.com/repos/janfrederik/skylab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janfrederik/skylab/merges","archive_url":"https://api.github.com/repos/janfrederik/skylab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janfrederik/skylab/downloads","issues_url":"https://api.github.com/repos/janfrederik/skylab/issues{/number}","pulls_url":"https://api.github.com/repos/janfrederik/skylab/pulls{/number}","milestones_url":"https://api.github.com/repos/janfrederik/skylab/milestones{/number}","notifications_url":"https://api.github.com/repos/janfrederik/skylab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janfrederik/skylab/labels{/name}","releases_url":"https://api.github.com/repos/janfrederik/skylab/releases{/id}","deployments_url":"https://api.github.com/repos/janfrederik/skylab/deployments","created_at":"2016-03-29T17:26:06Z","updated_at":"2016-03-29T17:26:07Z","pushed_at":"2016-05-24T18:59:23Z","git_url":"git://github.com/janfrederik/skylab.git","ssh_url":"git@github.com:janfrederik/skylab.git","clone_url":"https://github.com/janfrederik/skylab.git","svn_url":"https://github.com/janfrederik/skylab","homepage":"https://github.com/Kunstmaan/skylab","size":678,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kunstmaan:master","ref":"master","sha":"6f8efc648ee1fb9e2dccbb66f6d2da33602f5ee8","user":{"login":"Kunstmaan","id":441259,"avatar_url":"https://avatars.githubusercontent.com/u/441259?v=3","gravatar_id":"","url":"https://api.github.com/users/Kunstmaan","html_url":"https://github.com/Kunstmaan","followers_url":"https://api.github.com/users/Kunstmaan/followers","following_url":"https://api.github.com/users/Kunstmaan/following{/other_user}","gists_url":"https://api.github.com/users/Kunstmaan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kunstmaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kunstmaan/subscriptions","organizations_url":"https://api.github.com/users/Kunstmaan/orgs","repos_url":"https://api.github.com/users/Kunstmaan/repos","events_url":"https://api.github.com/users/Kunstmaan/events{/privacy}","received_events_url":"https://api.github.com/users/Kunstmaan/received_events","type":"Organization","site_admin":false},"repo":{"id":15199961,"name":"skylab","full_name":"Kunstmaan/skylab","owner":{"login":"Kunstmaan","id":441259,"avatar_url":"https://avatars.githubusercontent.com/u/441259?v=3","gravatar_id":"","url":"https://api.github.com/users/Kunstmaan","html_url":"https://github.com/Kunstmaan","followers_url":"https://api.github.com/users/Kunstmaan/followers","following_url":"https://api.github.com/users/Kunstmaan/following{/other_user}","gists_url":"https://api.github.com/users/Kunstmaan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kunstmaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kunstmaan/subscriptions","organizations_url":"https://api.github.com/users/Kunstmaan/orgs","repos_url":"https://api.github.com/users/Kunstmaan/repos","events_url":"https://api.github.com/users/Kunstmaan/events{/privacy}","received_events_url":"https://api.github.com/users/Kunstmaan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kunstmaan/skylab","description":"Skylab is a 100% backwards compatible PHP port of the Python based hosting scripts used at Kunstmaan. By using the Cilex, Symfony Components and lot's of good code samples from the Composer project we hope to create an application where everyone in our organisation can work with, and if issues or new needed features should arise, be able to work on.","fork":false,"url":"https://api.github.com/repos/Kunstmaan/skylab","forks_url":"https://api.github.com/repos/Kunstmaan/skylab/forks","keys_url":"https://api.github.com/repos/Kunstmaan/skylab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kunstmaan/skylab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kunstmaan/skylab/teams","hooks_url":"https://api.github.com/repos/Kunstmaan/skylab/hooks","issue_events_url":"https://api.github.com/repos/Kunstmaan/skylab/issues/events{/number}","events_url":"https://api.github.com/repos/Kunstmaan/skylab/events","assignees_url":"https://api.github.com/repos/Kunstmaan/skylab/assignees{/user}","branches_url":"https://api.github.com/repos/Kunstmaan/skylab/branches{/branch}","tags_url":"https://api.github.com/repos/Kunstmaan/skylab/tags","blobs_url":"https://api.github.com/repos/Kunstmaan/skylab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kunstmaan/skylab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kunstmaan/skylab/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kunstmaan/skylab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kunstmaan/skylab/statuses/{sha}","languages_url":"https://api.github.com/repos/Kunstmaan/skylab/languages","stargazers_url":"https://api.github.com/repos/Kunstmaan/skylab/stargazers","contributors_url":"https://api.github.com/repos/Kunstmaan/skylab/contributors","subscribers_url":"https://api.github.com/repos/Kunstmaan/skylab/subscribers","subscription_url":"https://api.github.com/repos/Kunstmaan/skylab/subscription","commits_url":"https://api.github.com/repos/Kunstmaan/skylab/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kunstmaan/skylab/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kunstmaan/skylab/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kunstmaan/skylab/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kunstmaan/skylab/contents/{+path}","compare_url":"https://api.github.com/repos/Kunstmaan/skylab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kunstmaan/skylab/merges","archive_url":"https://api.github.com/repos/Kunstmaan/skylab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kunstmaan/skylab/downloads","issues_url":"https://api.github.com/repos/Kunstmaan/skylab/issues{/number}","pulls_url":"https://api.github.com/repos/Kunstmaan/skylab/pulls{/number}","milestones_url":"https://api.github.com/repos/Kunstmaan/skylab/milestones{/number}","notifications_url":"https://api.github.com/repos/Kunstmaan/skylab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kunstmaan/skylab/labels{/name}","releases_url":"https://api.github.com/repos/Kunstmaan/skylab/releases{/id}","deployments_url":"https://api.github.com/repos/Kunstmaan/skylab/deployments","created_at":"2013-12-15T08:05:43Z","updated_at":"2016-05-15T19:37:28Z","pushed_at":"2016-05-24T19:21:58Z","git_url":"git://github.com/Kunstmaan/skylab.git","ssh_url":"git@github.com:Kunstmaan/skylab.git","clone_url":"https://github.com/Kunstmaan/skylab.git","svn_url":"https://github.com/Kunstmaan/skylab","homepage":"https://github.com/Kunstmaan/skylab","size":707,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":7,"forks":14,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132"},"html":{"href":"https://github.com/Kunstmaan/skylab/pull/132"},"issue":{"href":"https://api.github.com/repos/Kunstmaan/skylab/issues/132"},"comments":{"href":"https://api.github.com/repos/Kunstmaan/skylab/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/Kunstmaan/skylab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kunstmaan/skylab/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/Kunstmaan/skylab/statuses/ce1b745d9cad25ad65f377e3435d55d1c37a1eef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"roderik","id":16780,"avatar_url":"https://avatars.githubusercontent.com/u/16780?v=3","gravatar_id":"","url":"https://api.github.com/users/roderik","html_url":"https://github.com/roderik","followers_url":"https://api.github.com/users/roderik/followers","following_url":"https://api.github.com/users/roderik/following{/other_user}","gists_url":"https://api.github.com/users/roderik/gists{/gist_id}","starred_url":"https://api.github.com/users/roderik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roderik/subscriptions","organizations_url":"https://api.github.com/users/roderik/orgs","repos_url":"https://api.github.com/users/roderik/repos","events_url":"https://api.github.com/users/roderik/events{/privacy}","received_events_url":"https://api.github.com/users/roderik/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"roderik"}}