{"action":"created","comment":{"url":"https://api.github.com/repos/redfin/react-server/pulls/comments/52498796","id":52498796,"diff_hunk":"@@ -0,0 +1,35 @@\n+# generator-react-server [![NPM version][npm-image]][npm-url] [![Build Status][travis-image]][travis-url] [![Dependency Status][daviddm-image]][daviddm-url] [![Coverage percentage][coveralls-image]][coveralls-url]\n+> A yeoman generator for creating react-server projects\n+\n+## Installation\n+\n+First, install [Yeoman](http://yeoman.io) and generator-corvair using [npm](https://www.npmjs.com/) (we assume you have pre-installed [node.js](https://nodejs.org/)).\n+\n+```bash\n+npm install -g yo\n+npm install -g generator-corvair\n+```\n+\n+Then generate your new project:\n+\n+```bash\n+yo corvair\n+```\n+\n+## Getting To Know Yeoman\n+\n+Yeoman has a heart of gold. He&#39;s a person with feelings and opinions, but he&#39;s very easy to work with. If you think he&#39;s too opinionated, he can be easily convinced. Feel free to [learn more about him](http://yeoman.io/).\n+\n+## License\n+\n+MIT © [Redfin]()","path":"packages/generator-corvair/README.md","position":25,"original_position":25,"commit_id":"93273abf2fc552db526a1bca38cf7738eed9ed17","original_commit_id":"0a6d45ca665a9ce124e5a96d6aaf6b568ef4a973","user":{"login":"doug-wade","id":3477707,"avatar_url":"https://avatars.githubusercontent.com/u/3477707?v=3","gravatar_id":"","url":"https://api.github.com/users/doug-wade","html_url":"https://github.com/doug-wade","followers_url":"https://api.github.com/users/doug-wade/followers","following_url":"https://api.github.com/users/doug-wade/following{/other_user}","gists_url":"https://api.github.com/users/doug-wade/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-wade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-wade/subscriptions","organizations_url":"https://api.github.com/users/doug-wade/orgs","repos_url":"https://api.github.com/users/doug-wade/repos","events_url":"https://api.github.com/users/doug-wade/events{/privacy}","received_events_url":"https://api.github.com/users/doug-wade/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-02-10T18:12:15Z","updated_at":"2016-02-10T18:12:15Z","html_url":"https://github.com/redfin/react-server/pull/2#discussion_r52498796","pull_request_url":"https://api.github.com/repos/redfin/react-server/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/redfin/react-server/pulls/comments/52498796"},"html":{"href":"https://github.com/redfin/react-server/pull/2#discussion_r52498796"},"pull_request":{"href":"https://api.github.com/repos/redfin/react-server/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/redfin/react-server/pulls/2","id":58863781,"html_url":"https://github.com/redfin/react-server/pull/2","diff_url":"https://github.com/redfin/react-server/pull/2.diff","patch_url":"https://github.com/redfin/react-server/pull/2.patch","issue_url":"https://api.github.com/repos/redfin/react-server/issues/2","number":2,"state":"open","locked":false,"title":"Add Yeoman generator and example; fix bugs from npm link, npm start","user":{"login":"doug-wade","id":3477707,"avatar_url":"https://avatars.githubusercontent.com/u/3477707?v=3","gravatar_id":"","url":"https://api.github.com/users/doug-wade","html_url":"https://github.com/doug-wade","followers_url":"https://api.github.com/users/doug-wade/followers","following_url":"https://api.github.com/users/doug-wade/following{/other_user}","gists_url":"https://api.github.com/users/doug-wade/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-wade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-wade/subscriptions","organizations_url":"https://api.github.com/users/doug-wade/orgs","repos_url":"https://api.github.com/users/doug-wade/repos","events_url":"https://api.github.com/users/doug-wade/events{/privacy}","received_events_url":"https://api.github.com/users/doug-wade/received_events","type":"User","site_admin":false},"body":"This adds a yeoman generator to help new devs quickly scaffold a react-server instance.  Yeoman generators have to start with `generator-`, and `generator-react-server` is already taken -- we could do generator-reactserver or generator-rs, but I thought generator-corvair might be more memorable.\r\n\r\nThis also resolves a couple of issues I encountered along the way.\r\n\r\n    dougwade packages/example-corvair ‹add-yeoman-generator*› » npm start\r\n\r\n    > example-corvair@0.0.1 start /Users/doug.wade/react-server/packages/example-corvair\r\n    > node server.js\r\n\r\n    Start server...\r\n    Listening on port 3000\r\n    Started!\r\n    (node) OutgoingMessage.flush is deprecated. Use flushHeaders instead.\r\n    Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead.\r\n    2016-02-10T08:43:07.681Z - error: [react-server.core.renderMiddleware] Error rendering element 0 message=TRITON_CONFIGS environment variable required to start server., stack=Error: TRITON_CONFIGS environment variable required to start server.\r\n        at module.exports (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/config.js:17:11)\r\n        at getNonInternalConfigs (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/renderMiddleware.js:904:19)\r\n        at bootstrapClient (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/renderMiddleware.js:809:13)\r\n        at writeElements (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/renderMiddleware.js:773:4)\r\n        at doElement (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/renderMiddleware.js:601:3)\r\n        at /Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/target/server/renderMiddleware.js:609:11\r\n        at /Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/node_modules/continuation-local-storage/context.js:74:17\r\n        at _fulfilled (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/node_modules/q/q.js:834:54)\r\n        at self.promiseDispatch.done (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/node_modules/q/q.js:863:30)\r\n        at Promise.promise.promiseDispatch (/Users/doug.wade/react-server/packages/example-corvair/node_modules/react-server/node_modules/q/q.js:796:13)\r\n\r\nis less than ideal, since we don't call it Triton anymore.\r\n\r\nand then also\r\n\r\n    [00:46:45] 'test' errored after 66 ms\r\n    [00:46:45] Error in plugin 'gulp-jasmine'\r\n    Message:\r\n        Cannot find module 'superagent'\r\n    Details:\r\n        code: MODULE_NOT_FOUND\r\n\r\n    npm WARN react-server@0.0.4 requires a peer of react@0.14.2 but none was installed.\r\n    npm WARN react-server@0.0.4 requires a peer of react-dom@0.14.2 but none was installed.\r\n    npm WARN react-server@0.0.4 requires a peer of superagent@1.2.0 but none was installed.\r\n    npm WARN react-server@0.0.4 license should be a valid SPDX license expression\r\n    npm ERR! Darwin 15.0.0\r\n    npm ERR! argv \"/usr/local/bin/iojs\" \"/usr/local/bin/npm\" \"link\"\r\n    npm ERR! node v5.6.0\r\n    npm ERR! npm  v3.6.0\r\n    npm ERR! code ELIFECYCLE\r\n    npm ERR! react-server@0.0.4 prepublish: `gulp build && gulp test`\r\n    npm ERR! Exit status 1\r\n    npm ERR!\r\n    npm ERR! Failed at the react-server@0.0.4 prepublish script 'gulp build && gulp test'.\r\n    npm ERR! Make sure you have the latest version of node.js and npm installed.\r\n    npm ERR! If you do, this is most likely a problem with the react-server package,\r\n    npm ERR! not with npm itself.\r\n    npm ERR! Tell the author that this fails on your system:\r\n    npm ERR!     gulp build && gulp test\r\n    npm ERR! You can get information on how to open an issue for this project with:\r\n    npm ERR!     npm bugs react-server\r\n    npm ERR! Or if that isn't available, you can get their info via:\r\n    npm ERR!     npm owner ls react-server\r\n    npm ERR! There is likely additional logging output above.\r\n\r\n    npm ERR! Please include the following file with any support request:\r\n    npm ERR!     /Users/doug.wade/react-server/packages/react-server/npm-debug.log\r\n\r\nhappened on `npm link`, so I added all the peer dependencies as dev dependencies to make it easier to develop locally.","created_at":"2016-02-10T09:13:48Z","updated_at":"2016-02-10T18:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redfin/react-server/pulls/2/commits","review_comments_url":"https://api.github.com/repos/redfin/react-server/pulls/2/comments","review_comment_url":"https://api.github.com/repos/redfin/react-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redfin/react-server/issues/2/comments","statuses_url":"https://api.github.com/repos/redfin/react-server/statuses/93273abf2fc552db526a1bca38cf7738eed9ed17","head":{"label":"doug-wade:add-yeoman-generator","ref":"add-yeoman-generator","sha":"93273abf2fc552db526a1bca38cf7738eed9ed17","user":{"login":"doug-wade","id":3477707,"avatar_url":"https://avatars.githubusercontent.com/u/3477707?v=3","gravatar_id":"","url":"https://api.github.com/users/doug-wade","html_url":"https://github.com/doug-wade","followers_url":"https://api.github.com/users/doug-wade/followers","following_url":"https://api.github.com/users/doug-wade/following{/other_user}","gists_url":"https://api.github.com/users/doug-wade/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-wade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-wade/subscriptions","organizations_url":"https://api.github.com/users/doug-wade/orgs","repos_url":"https://api.github.com/users/doug-wade/repos","events_url":"https://api.github.com/users/doug-wade/events{/privacy}","received_events_url":"https://api.github.com/users/doug-wade/received_events","type":"User","site_admin":false},"repo":{"id":51405573,"name":"react-server","full_name":"doug-wade/react-server","owner":{"login":"doug-wade","id":3477707,"avatar_url":"https://avatars.githubusercontent.com/u/3477707?v=3","gravatar_id":"","url":"https://api.github.com/users/doug-wade","html_url":"https://github.com/doug-wade","followers_url":"https://api.github.com/users/doug-wade/followers","following_url":"https://api.github.com/users/doug-wade/following{/other_user}","gists_url":"https://api.github.com/users/doug-wade/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-wade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-wade/subscriptions","organizations_url":"https://api.github.com/users/doug-wade/orgs","repos_url":"https://api.github.com/users/doug-wade/repos","events_url":"https://api.github.com/users/doug-wade/events{/privacy}","received_events_url":"https://api.github.com/users/doug-wade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doug-wade/react-server","description":"React server monorepo","fork":true,"url":"https://api.github.com/repos/doug-wade/react-server","forks_url":"https://api.github.com/repos/doug-wade/react-server/forks","keys_url":"https://api.github.com/repos/doug-wade/react-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doug-wade/react-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doug-wade/react-server/teams","hooks_url":"https://api.github.com/repos/doug-wade/react-server/hooks","issue_events_url":"https://api.github.com/repos/doug-wade/react-server/issues/events{/number}","events_url":"https://api.github.com/repos/doug-wade/react-server/events","assignees_url":"https://api.github.com/repos/doug-wade/react-server/assignees{/user}","branches_url":"https://api.github.com/repos/doug-wade/react-server/branches{/branch}","tags_url":"https://api.github.com/repos/doug-wade/react-server/tags","blobs_url":"https://api.github.com/repos/doug-wade/react-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doug-wade/react-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doug-wade/react-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/doug-wade/react-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doug-wade/react-server/statuses/{sha}","languages_url":"https://api.github.com/repos/doug-wade/react-server/languages","stargazers_url":"https://api.github.com/repos/doug-wade/react-server/stargazers","contributors_url":"https://api.github.com/repos/doug-wade/react-server/contributors","subscribers_url":"https://api.github.com/repos/doug-wade/react-server/subscribers","subscription_url":"https://api.github.com/repos/doug-wade/react-server/subscription","commits_url":"https://api.github.com/repos/doug-wade/react-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/doug-wade/react-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/doug-wade/react-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/doug-wade/react-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/doug-wade/react-server/contents/{+path}","compare_url":"https://api.github.com/repos/doug-wade/react-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doug-wade/react-server/merges","archive_url":"https://api.github.com/repos/doug-wade/react-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doug-wade/react-server/downloads","issues_url":"https://api.github.com/repos/doug-wade/react-server/issues{/number}","pulls_url":"https://api.github.com/repos/doug-wade/react-server/pulls{/number}","milestones_url":"https://api.github.com/repos/doug-wade/react-server/milestones{/number}","notifications_url":"https://api.github.com/repos/doug-wade/react-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doug-wade/react-server/labels{/name}","releases_url":"https://api.github.com/repos/doug-wade/react-server/releases{/id}","deployments_url":"https://api.github.com/repos/doug-wade/react-server/deployments","created_at":"2016-02-09T22:35:35Z","updated_at":"2016-02-09T22:35:36Z","pushed_at":"2016-02-10T18:11:51Z","git_url":"git://github.com/doug-wade/react-server.git","ssh_url":"git@github.com:doug-wade/react-server.git","clone_url":"https://github.com/doug-wade/react-server.git","svn_url":"https://github.com/doug-wade/react-server","homepage":"","size":744,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redfin:master","ref":"master","sha":"b7994dd03262969f584d9122befb7879099581fb","user":{"login":"redfin","id":6288468,"avatar_url":"https://avatars.githubusercontent.com/u/6288468?v=3","gravatar_id":"","url":"https://api.github.com/users/redfin","html_url":"https://github.com/redfin","followers_url":"https://api.github.com/users/redfin/followers","following_url":"https://api.github.com/users/redfin/following{/other_user}","gists_url":"https://api.github.com/users/redfin/gists{/gist_id}","starred_url":"https://api.github.com/users/redfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redfin/subscriptions","organizations_url":"https://api.github.com/users/redfin/orgs","repos_url":"https://api.github.com/users/redfin/repos","events_url":"https://api.github.com/users/redfin/events{/privacy}","received_events_url":"https://api.github.com/users/redfin/received_events","type":"Organization","site_admin":false},"repo":{"id":51392574,"name":"react-server","full_name":"redfin/react-server","owner":{"login":"redfin","id":6288468,"avatar_url":"https://avatars.githubusercontent.com/u/6288468?v=3","gravatar_id":"","url":"https://api.github.com/users/redfin","html_url":"https://github.com/redfin","followers_url":"https://api.github.com/users/redfin/followers","following_url":"https://api.github.com/users/redfin/following{/other_user}","gists_url":"https://api.github.com/users/redfin/gists{/gist_id}","starred_url":"https://api.github.com/users/redfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redfin/subscriptions","organizations_url":"https://api.github.com/users/redfin/orgs","repos_url":"https://api.github.com/users/redfin/repos","events_url":"https://api.github.com/users/redfin/events{/privacy}","received_events_url":"https://api.github.com/users/redfin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redfin/react-server","description":"React server monorepo","fork":false,"url":"https://api.github.com/repos/redfin/react-server","forks_url":"https://api.github.com/repos/redfin/react-server/forks","keys_url":"https://api.github.com/repos/redfin/react-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redfin/react-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redfin/react-server/teams","hooks_url":"https://api.github.com/repos/redfin/react-server/hooks","issue_events_url":"https://api.github.com/repos/redfin/react-server/issues/events{/number}","events_url":"https://api.github.com/repos/redfin/react-server/events","assignees_url":"https://api.github.com/repos/redfin/react-server/assignees{/user}","branches_url":"https://api.github.com/repos/redfin/react-server/branches{/branch}","tags_url":"https://api.github.com/repos/redfin/react-server/tags","blobs_url":"https://api.github.com/repos/redfin/react-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redfin/react-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redfin/react-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/redfin/react-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redfin/react-server/statuses/{sha}","languages_url":"https://api.github.com/repos/redfin/react-server/languages","stargazers_url":"https://api.github.com/repos/redfin/react-server/stargazers","contributors_url":"https://api.github.com/repos/redfin/react-server/contributors","subscribers_url":"https://api.github.com/repos/redfin/react-server/subscribers","subscription_url":"https://api.github.com/repos/redfin/react-server/subscription","commits_url":"https://api.github.com/repos/redfin/react-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/redfin/react-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/redfin/react-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/redfin/react-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/redfin/react-server/contents/{+path}","compare_url":"https://api.github.com/repos/redfin/react-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redfin/react-server/merges","archive_url":"https://api.github.com/repos/redfin/react-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redfin/react-server/downloads","issues_url":"https://api.github.com/repos/redfin/react-server/issues{/number}","pulls_url":"https://api.github.com/repos/redfin/react-server/pulls{/number}","milestones_url":"https://api.github.com/repos/redfin/react-server/milestones{/number}","notifications_url":"https://api.github.com/repos/redfin/react-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redfin/react-server/labels{/name}","releases_url":"https://api.github.com/repos/redfin/react-server/releases{/id}","deployments_url":"https://api.github.com/repos/redfin/react-server/deployments","created_at":"2016-02-09T19:20:35Z","updated_at":"2016-02-10T17:02:45Z","pushed_at":"2016-02-10T18:11:51Z","git_url":"git://github.com/redfin/react-server.git","ssh_url":"git@github.com:redfin/react-server.git","clone_url":"https://github.com/redfin/react-server.git","svn_url":"https://github.com/redfin/react-server","homepage":"","size":723,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redfin/react-server/pulls/2"},"html":{"href":"https://github.com/redfin/react-server/pull/2"},"issue":{"href":"https://api.github.com/repos/redfin/react-server/issues/2"},"comments":{"href":"https://api.github.com/repos/redfin/react-server/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/redfin/react-server/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/redfin/react-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redfin/react-server/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/redfin/react-server/statuses/93273abf2fc552db526a1bca38cf7738eed9ed17"}}}}