{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/yarp/pulls/comments/77305902","id":77305902,"diff_hunk":"@@ -7,34 +7,12 @@\n #include <yarp/os/Log.h>\n #include <yarp/math/Math.h>\n #include <yarp/math/SVD.h>\n-#include <gsl/gsl_math.h>\n-#include <gsl/gsl_matrix.h>\n-#include <gsl/gsl_matrix_double.h>\n-\n-#include <gsl/gsl_vector.h>\n-#include <gsl/gsl_vector_double.h>\n-#include <gsl/gsl_blas.h>\n \n-#include <gsl/gsl_linalg.h>\n-\n-#include <gsl/gsl_version.h>\n-#include <gsl/gsl_eigen.h>\n+#include <cmath>\n+#include <gsl/gsl_math.h>","path":"src/libYARP_math/src/math.cpp","position":17,"original_position":17,"commit_id":"9c0c7615941df40d3bb999b93af7eed465205950","original_commit_id":"9c0c7615941df40d3bb999b93af7eed465205950","user":{"login":"traversaro","id":1857049,"avatar_url":"https://avatars.githubusercontent.com/u/1857049?v=3","gravatar_id":"","url":"https://api.github.com/users/traversaro","html_url":"https://github.com/traversaro","followers_url":"https://api.github.com/users/traversaro/followers","following_url":"https://api.github.com/users/traversaro/following{/other_user}","gists_url":"https://api.github.com/users/traversaro/gists{/gist_id}","starred_url":"https://api.github.com/users/traversaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traversaro/subscriptions","organizations_url":"https://api.github.com/users/traversaro/orgs","repos_url":"https://api.github.com/users/traversaro/repos","events_url":"https://api.github.com/users/traversaro/events{/privacy}","received_events_url":"https://api.github.com/users/traversaro/received_events","type":"User","site_admin":false},"body":"@lornat75 what is the rationale of this include? `math.cpp` is supposed to be GSL independent now, and any M_PI problem on Windows can be solved independently  from GSL, see https://github.com/robotology/QA/issues/81 .\r\n\r\n","created_at":"2016-09-02T07:46:12Z","updated_at":"2016-09-02T07:46:12Z","html_url":"https://github.com/robotology/yarp/pull/896#discussion_r77305902","pull_request_url":"https://api.github.com/repos/robotology/yarp/pulls/896","_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments/77305902"},"html":{"href":"https://github.com/robotology/yarp/pull/896#discussion_r77305902"},"pull_request":{"href":"https://api.github.com/repos/robotology/yarp/pulls/896"}}},"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/896","id":83694889,"html_url":"https://github.com/robotology/yarp/pull/896","diff_url":"https://github.com/robotology/yarp/pull/896.diff","patch_url":"https://github.com/robotology/yarp/pull/896.patch","issue_url":"https://api.github.com/repos/robotology/yarp/issues/896","number":896,"state":"open","locked":false,"title":"Remove GSL dependency","user":{"login":"lornat75","id":1403333,"avatar_url":"https://avatars.githubusercontent.com/u/1403333?v=3","gravatar_id":"","url":"https://api.github.com/users/lornat75","html_url":"https://github.com/lornat75","followers_url":"https://api.github.com/users/lornat75/followers","following_url":"https://api.github.com/users/lornat75/following{/other_user}","gists_url":"https://api.github.com/users/lornat75/gists{/gist_id}","starred_url":"https://api.github.com/users/lornat75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lornat75/subscriptions","organizations_url":"https://api.github.com/users/lornat75/orgs","repos_url":"https://api.github.com/users/lornat75/repos","events_url":"https://api.github.com/users/lornat75/events{/privacy}","received_events_url":"https://api.github.com/users/lornat75/received_events","type":"User","site_admin":false},"body":"Removes GSL dependency from libYARP_math and libYARP_sig. Interoperability with GSL is delegated to libYARP_gsl. libYARP_math can now be compiled with GSL (for legacy reasons) or Eigen.","created_at":"2016-09-01T19:46:48Z","updated_at":"2016-09-02T07:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16394eeb057c5f9f28f650483fbfdea3f2c14efc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/yarp/pulls/896/commits","review_comments_url":"https://api.github.com/repos/robotology/yarp/pulls/896/comments","review_comment_url":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/896/comments","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/9c0c7615941df40d3bb999b93af7eed465205950","head":{"label":"robotology:cleanup-gsl","ref":"cleanup-gsl","sha":"9c0c7615941df40d3bb999b93af7eed465205950","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2016-08-23T19:57:23Z","pushed_at":"2016-09-01T22:47:22Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"git@github.com:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":83464,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":135,"forks":58,"open_issues":135,"watchers":71,"default_branch":"master"}},"base":{"label":"robotology:devel","ref":"devel","sha":"92880bbdb58264b5d943ff3c13092b096260c09f","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2016-08-23T19:57:23Z","pushed_at":"2016-09-01T22:47:22Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"git@github.com:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":83464,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":135,"forks":58,"open_issues":135,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/896"},"html":{"href":"https://github.com/robotology/yarp/pull/896"},"issue":{"href":"https://api.github.com/repos/robotology/yarp/issues/896"},"comments":{"href":"https://api.github.com/repos/robotology/yarp/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/yarp/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/yarp/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/yarp/statuses/9c0c7615941df40d3bb999b93af7eed465205950"}}}}
{"actor":{"display_login":"traversaro"}}