{"action":"created","comment":{"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/comments/59324752","id":59324752,"diff_hunk":"@@ -17,7 +17,7 @@ public class XDocumentAssertionSpecs\n         #region Be / NotBe\n \n         [TestMethod]\n-        public void When_asserting_a_xml_document_is_equal_to_the_same_xml_document_it_should_succeed()\n+        public void When_asserting_a_XDocument_is_equal_to_the_same_XDocument_it_should_succeed()","path":"Tests/FluentAssertions.Shared.Specs/XDocumentAssertionSpecs.cs","position":null,"original_position":5,"commit_id":"425e3fd71c634fb9843a62359126ed0b6427a2d4","original_commit_id":"6e24524c5632603ab5fe508e879b15493ed963f3","user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"body":"I've reverted the renames of those tests and also renamed the other tests I've created to follow the same pattern.\r\n\r\nFor the question about what *equals* means in this case, I haven't looked into it. It's an existing test that I didn't modify.","created_at":"2016-04-12T06:07:59Z","updated_at":"2016-04-12T06:07:59Z","html_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386#discussion_r59324752","pull_request_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386","_links":{"self":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/comments/59324752"},"html":{"href":"https://github.com/dennisdoomen/FluentAssertions/pull/386#discussion_r59324752"},"pull_request":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386"}}},"pull_request":{"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386","id":65106566,"html_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386","diff_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386.diff","patch_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386.patch","issue_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386","number":386,"state":"open","locked":false,"title":"Semantic (Not)BeEquivalent for XDocument/XElement","user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"body":"Also fixed a bug where the location for xml comparisons was incorrect after a selfclosed <xml /> element had been compared.\r\n\r\nThe tests for `XDocument/XElement.Should().BeEquivalent()` are not very covering. They basically just checks that semantical equivalency is used. The tests for `XmlNode` are much more extensive, as those are what I used to test the `XmlReaderValidator` implementation. How do you want the tests? I can think of three options.\r\n\r\n1. Kept as it is\r\n2. Also do full tests/specs for `XDocument/XElement` (will be a lot of copied tests)\r\n3. Move the detailed tests to a separate class that tests `XmlReaderValidator` directly\r\n","created_at":"2016-04-04T07:48:22Z","updated_at":"2016-04-12T06:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"622e1ebacf0c4bd58d1272cd46045a360714f736","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386/commits","review_comments_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386/comments","review_comment_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386/comments","statuses_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/statuses/425e3fd71c634fb9843a62359126ed0b6427a2d4","head":{"label":"AndersAbel:XDocument_ShouldBeEquivalent","ref":"XDocument_ShouldBeEquivalent","sha":"425e3fd71c634fb9843a62359126ed0b6427a2d4","user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"repo":{"id":51614991,"name":"FluentAssertions","full_name":"AndersAbel/FluentAssertions","owner":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndersAbel/FluentAssertions","description":"Fluent Assertions is a set of .NET extension methods that allow you to more naturally specify the expected outcome of a TDD or BDD-style test. We currently use it in all our internal and client projects, and it is used in many open-source projects. It runs on .NET 4.0, 4.5, 4.6, CoreClr, .NET Native, Windows 8.1, Silverlight 5, Windows Phone 8.0 and UWP. It supports the unit test frameworks NUnit, XUnit, MBUnit, Gallio, NSpec and MSpec.","fork":true,"url":"https://api.github.com/repos/AndersAbel/FluentAssertions","forks_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/forks","keys_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/teams","hooks_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/hooks","issue_events_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/issues/events{/number}","events_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/events","assignees_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/assignees{/user}","branches_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/branches{/branch}","tags_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/tags","blobs_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/statuses/{sha}","languages_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/languages","stargazers_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/stargazers","contributors_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/contributors","subscribers_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/subscribers","subscription_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/subscription","commits_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/contents/{+path}","compare_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/merges","archive_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/downloads","issues_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/issues{/number}","pulls_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/pulls{/number}","milestones_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/milestones{/number}","notifications_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/labels{/name}","releases_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/releases{/id}","deployments_url":"https://api.github.com/repos/AndersAbel/FluentAssertions/deployments","created_at":"2016-02-12T20:39:57Z","updated_at":"2016-02-12T20:39:59Z","pushed_at":"2016-04-12T06:07:29Z","git_url":"git://github.com/AndersAbel/FluentAssertions.git","ssh_url":"git@github.com:AndersAbel/FluentAssertions.git","clone_url":"https://github.com/AndersAbel/FluentAssertions.git","svn_url":"https://github.com/AndersAbel/FluentAssertions","homepage":"http://www.fluentassertions.com","size":13705,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dennisdoomen:master","ref":"master","sha":"d16c8c03c13317264e0c4e11f13735111639c73a","user":{"login":"dennisdoomen","id":572734,"avatar_url":"https://avatars.githubusercontent.com/u/572734?v=3","gravatar_id":"","url":"https://api.github.com/users/dennisdoomen","html_url":"https://github.com/dennisdoomen","followers_url":"https://api.github.com/users/dennisdoomen/followers","following_url":"https://api.github.com/users/dennisdoomen/following{/other_user}","gists_url":"https://api.github.com/users/dennisdoomen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisdoomen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisdoomen/subscriptions","organizations_url":"https://api.github.com/users/dennisdoomen/orgs","repos_url":"https://api.github.com/users/dennisdoomen/repos","events_url":"https://api.github.com/users/dennisdoomen/events{/privacy}","received_events_url":"https://api.github.com/users/dennisdoomen/received_events","type":"User","site_admin":false},"repo":{"id":11718424,"name":"FluentAssertions","full_name":"dennisdoomen/FluentAssertions","owner":{"login":"dennisdoomen","id":572734,"avatar_url":"https://avatars.githubusercontent.com/u/572734?v=3","gravatar_id":"","url":"https://api.github.com/users/dennisdoomen","html_url":"https://github.com/dennisdoomen","followers_url":"https://api.github.com/users/dennisdoomen/followers","following_url":"https://api.github.com/users/dennisdoomen/following{/other_user}","gists_url":"https://api.github.com/users/dennisdoomen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisdoomen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisdoomen/subscriptions","organizations_url":"https://api.github.com/users/dennisdoomen/orgs","repos_url":"https://api.github.com/users/dennisdoomen/repos","events_url":"https://api.github.com/users/dennisdoomen/events{/privacy}","received_events_url":"https://api.github.com/users/dennisdoomen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennisdoomen/FluentAssertions","description":"Fluent Assertions is a set of .NET extension methods that allow you to more naturally specify the expected outcome of a TDD or BDD-style test. We currently use it in all our internal and client projects, and it is used in many open-source projects. It runs on .NET 4.0, 4.5, 4.6, CoreClr, .NET Native, Windows 8.1, Silverlight 5, Windows Phone 8.0 and UWP. It supports the unit test frameworks NUnit, XUnit, MBUnit, Gallio, NSpec and MSpec.","fork":false,"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions","forks_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/forks","keys_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/teams","hooks_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/hooks","issue_events_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/events{/number}","events_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/events","assignees_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/assignees{/user}","branches_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/branches{/branch}","tags_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/tags","blobs_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/statuses/{sha}","languages_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/languages","stargazers_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/stargazers","contributors_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/contributors","subscribers_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/subscribers","subscription_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/subscription","commits_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/comments{/number}","contents_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/contents/{+path}","compare_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/merges","archive_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/downloads","issues_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues{/number}","pulls_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls{/number}","milestones_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/milestones{/number}","notifications_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/labels{/name}","releases_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/releases{/id}","deployments_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/deployments","created_at":"2013-07-28T10:35:25Z","updated_at":"2016-04-11T20:03:53Z","pushed_at":"2016-04-12T06:07:30Z","git_url":"git://github.com/dennisdoomen/FluentAssertions.git","ssh_url":"git@github.com:dennisdoomen/FluentAssertions.git","clone_url":"https://github.com/dennisdoomen/FluentAssertions.git","svn_url":"https://github.com/dennisdoomen/FluentAssertions","homepage":"http://www.fluentassertions.com","size":14577,"stargazers_count":545,"watchers_count":545,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":124,"mirror_url":null,"open_issues_count":52,"forks":124,"open_issues":52,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386"},"html":{"href":"https://github.com/dennisdoomen/FluentAssertions/pull/386"},"issue":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386"},"comments":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/dennisdoomen/FluentAssertions/statuses/425e3fd71c634fb9843a62359126ed0b6427a2d4"}}}}