{"action":"opened","issue":{"url":"https://api.github.com/repos/luka9x/NmsSeedChanger/issues/2","repository_url":"https://api.github.com/repos/luka9x/NmsSeedChanger","labels_url":"https://api.github.com/repos/luka9x/NmsSeedChanger/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/luka9x/NmsSeedChanger/issues/2/comments","events_url":"https://api.github.com/repos/luka9x/NmsSeedChanger/issues/2/events","html_url":"https://github.com/luka9x/NmsSeedChanger/issues/2","id":173017477,"number":2,"title":"Some suggested changes around file load/save","user":{"login":"matthew-humphrey","id":5487637,"avatar_url":"https://avatars.githubusercontent.com/u/5487637?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-humphrey","html_url":"https://github.com/matthew-humphrey","followers_url":"https://api.github.com/users/matthew-humphrey/followers","following_url":"https://api.github.com/users/matthew-humphrey/following{/other_user}","gists_url":"https://api.github.com/users/matthew-humphrey/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-humphrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-humphrey/subscriptions","organizations_url":"https://api.github.com/users/matthew-humphrey/orgs","repos_url":"https://api.github.com/users/matthew-humphrey/repos","events_url":"https://api.github.com/users/matthew-humphrey/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-humphrey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-24T17:54:57Z","updated_at":"2016-08-24T17:54:57Z","closed_at":null,"body":"The JSON file that you're reading actually does not change when the save game is decrypted. So I found that it's a slightly better workflow to parse/load that file, and then when you want to update it, do a decrypt, save, encrypt. That way the file is never in an unusable/decrypted state and you can run the program concurrently with NMS, just make a change and then tell NMS to reload current save.\r\n\r\nAlso, when running nomanssave, instead of starting a \"cmd.exe\" process, it's better and simpler just to start a process with nomanssave.exe directly. And when you do that, you can also check the process return code with action.ExitCode. A non-zero value there indicates that nomanssave had an error, something which you may choose to tell the user about.\r\n\r\nI just made these changes myself to my local cloned copy. I can certainly share the code if you like, but the changes are very simple."}}
{"actor":{"display_login":"matthew-humphrey"}}