{"action":"created","issue":{"url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/43","repository_url":"https://api.github.com/repos/vsch/laravel-translation-manager","labels_url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/43/comments","events_url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/43/events","html_url":"https://github.com/vsch/laravel-translation-manager/pull/43","id":162405228,"number":43,"title":"New way of inline translations without breaking layouts","user":{"login":"yurtesen","id":1926599,"avatar_url":"https://avatars.githubusercontent.com/u/1926599?v=3","gravatar_id":"","url":"https://api.github.com/users/yurtesen","html_url":"https://github.com/yurtesen","followers_url":"https://api.github.com/users/yurtesen/followers","following_url":"https://api.github.com/users/yurtesen/following{/other_user}","gists_url":"https://api.github.com/users/yurtesen/gists{/gist_id}","starred_url":"https://api.github.com/users/yurtesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurtesen/subscriptions","organizations_url":"https://api.github.com/users/yurtesen/orgs","repos_url":"https://api.github.com/users/yurtesen/repos","events_url":"https://api.github.com/users/yurtesen/events{/privacy}","received_events_url":"https://api.github.com/users/yurtesen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-27T09:06:45Z","updated_at":"2016-09-11T04:22:09Z","closed_at":"2016-09-11T04:17:41Z","pull_request":{"url":"https://api.github.com/repos/vsch/laravel-translation-manager/pulls/43","html_url":"https://github.com/vsch/laravel-translation-manager/pull/43","diff_url":"https://github.com/vsch/laravel-translation-manager/pull/43.diff","patch_url":"https://github.com/vsch/laravel-translation-manager/pull/43.patch"},"body":"Here is the new way of translations as discussed in (with animations)\r\nhttps://github.com/vsch/laravel-translation-manager/issues/38\r\nBecause the old way is cumbersome and needs modifying the way laravel is doing translations...\r\n\r\nIn addition, it allows translating ALL text created by trans()/choice() functions when page is loaded/rendered. Not only those found in the view blade templates. For example if you used trans() inside the controller and passed the resulting text as a variable to blade template, you can still translate that specific key even though it was not used in the template itself!\r\n\r\nBelow are gif animations of how it works as examples:\r\nTooltips for remembering which button does what :)\r\n![tooltips](https://cloud.githubusercontent.com/assets/1926599/16388352/76e6e560-3ca1-11e6-9703-69e92079499c.gif)\r\nA page with two trans() keys only...\r\n![newinline1](https://cloud.githubusercontent.com/assets/1926599/16388359/7d41da1e-3ca1-11e6-84de-b65fb15d76ad.gif)\r\nThe translator page with many keys (compare with how ugly the page looked when old inline translations were enabled).\r\n![newinline2](https://cloud.githubusercontent.com/assets/1926599/16388363/81b84362-3ca1-11e6-9bb1-58fe02bdfff7.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/comments/246161064","html_url":"https://github.com/vsch/laravel-translation-manager/pull/43#issuecomment-246161064","issue_url":"https://api.github.com/repos/vsch/laravel-translation-manager/issues/43","id":246161064,"user":{"login":"vsch","id":10299086,"avatar_url":"https://avatars.githubusercontent.com/u/10299086?v=3","gravatar_id":"","url":"https://api.github.com/users/vsch","html_url":"https://github.com/vsch","followers_url":"https://api.github.com/users/vsch/followers","following_url":"https://api.github.com/users/vsch/following{/other_user}","gists_url":"https://api.github.com/users/vsch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsch/subscriptions","organizations_url":"https://api.github.com/users/vsch/orgs","repos_url":"https://api.github.com/users/vsch/repos","events_url":"https://api.github.com/users/vsch/events{/privacy}","received_events_url":"https://api.github.com/users/vsch/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T04:22:09Z","updated_at":"2016-09-11T04:22:09Z","body":"The delay was having to update LTM and my dev site which is my site for the [Markdown Navigator](http://vladsch.com/product/markdown-navigator) plugin for JetBrains IDEs, to Laravel 5.3.\r\n\r\nEvery time Laravel updates the API it breaks a boat-load of code, real PITA. Laravel 5.3 silently breaks a lot of code due to API changes.\r\n\r\nI will be making a release probably tomorrow, once I have tested the Web UI. \r\n"}}
{"actor":{"display_login":"vsch"}}