{"action":"created","issue":{"url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/151","repository_url":"https://api.github.com/repos/smarthomeNG/smarthome","labels_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/151/comments","events_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/151/events","html_url":"https://github.com/smarthomeNG/smarthome/pull/151","id":189190513,"number":151,"title":"systemair: fix bug with unsigned temperatures","user":{"login":"4d4mu","id":23149334,"avatar_url":"https://avatars.githubusercontent.com/u/23149334?v=3","gravatar_id":"","url":"https://api.github.com/users/4d4mu","html_url":"https://github.com/4d4mu","followers_url":"https://api.github.com/users/4d4mu/followers","following_url":"https://api.github.com/users/4d4mu/following{/other_user}","gists_url":"https://api.github.com/users/4d4mu/gists{/gist_id}","starred_url":"https://api.github.com/users/4d4mu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4d4mu/subscriptions","organizations_url":"https://api.github.com/users/4d4mu/orgs","repos_url":"https://api.github.com/users/4d4mu/repos","events_url":"https://api.github.com/users/4d4mu/events{/privacy}","received_events_url":"https://api.github.com/users/4d4mu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2016-11-14T18:38:28Z","updated_at":"2016-11-17T19:12:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/151","html_url":"https://github.com/smarthomeNG/smarthome/pull/151","diff_url":"https://github.com/smarthomeNG/smarthome/pull/151.diff","patch_url":"https://github.com/smarthomeNG/smarthome/pull/151.patch"},"body":"Hi,\r\nMy vent told me, that last night temperature was over +6500*C!\r\nThere's a bug in systemair plugin - all values are parsed as unsigned. Minimalmodbus has optional argument for signed/unsigned, but only for reading one reg, not group. Since group read is faster, i decided to convert temperatures with ctypes. According to systemair modbus manual, only heater regs contain temperatures and rest of heater regs doesn't exceed value 32767, so I applied fix to all heater regs (for simplicity)."},"comment":{"url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/comments/261339818","html_url":"https://github.com/smarthomeNG/smarthome/pull/151#issuecomment-261339818","issue_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/151","id":261339818,"user":{"login":"4d4mu","id":23149334,"avatar_url":"https://avatars.githubusercontent.com/u/23149334?v=3","gravatar_id":"","url":"https://api.github.com/users/4d4mu","html_url":"https://github.com/4d4mu","followers_url":"https://api.github.com/users/4d4mu/followers","following_url":"https://api.github.com/users/4d4mu/following{/other_user}","gists_url":"https://api.github.com/users/4d4mu/gists{/gist_id}","starred_url":"https://api.github.com/users/4d4mu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4d4mu/subscriptions","organizations_url":"https://api.github.com/users/4d4mu/orgs","repos_url":"https://api.github.com/users/4d4mu/repos","events_url":"https://api.github.com/users/4d4mu/events{/privacy}","received_events_url":"https://api.github.com/users/4d4mu/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T19:12:25Z","updated_at":"2016-11-17T19:12:25Z","body":"`requirements/plugins.systemair.txt \r\nminimalmodbus>=0.7\r\npyserial>=3.0.1\r\n`\r\nis that good?\r\n\r\nOk, fixing logger"}}
{"actor":{"display_login":"4d4mu"}}