{"push_id":1117958573,"size":31,"distinct_size":31,"ref":"refs/heads/webui-filter-assets","head":"531231a749bbe5b95f278c709fe6c44ede6fa9fe","before":"280007d0f5e2e7047b7106e198af469fd5e50e4c","commits":[{"sha":"8016a44b4d2591a50764731f38c94c58e78a69e2","author":{"email":"2b10d63485adf53bd61ddf92e433227c7a1606ba@suse.de","name":"Oliver Kurz"},"message":"Fix use of symlinked needle dirs from outside of basedir\n\nThis fixes a problem introduced with 2b8ac3c859e6db1296fbf7f6ff71d0306d9501e8.\nThe check for the needledir has been moved where an external file path is used\ncoming from a REST request where additional care should be taken to ensure a\nvalid and secure directory. For a \"local\" definition of the needledir the\ncheck was removed changing the behaviour back to the old way supporting\nsymlinked needle dirs, e.g. when /local/needles is symlinked into\n/var/lib/openqa/share/tests/... instead of being a real subdirectory.\n\nAs proper test cases have been missing for the \"new\" feature a proper test for\nneedle reading over URL requests has been created based on the needles created\nby the needle editor test and the disabled (skipped) test in 07-file.t.\n\nFixes gh #667.","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/8016a44b4d2591a50764731f38c94c58e78a69e2"},{"sha":"86ca953dacf0050dbe78fb5f6849e172f5a0cb86","author":{"email":"614f19bfe57f7abe6a3c5d54da8899ac543a35ae@gmail.com","name":"Ondřej Holeček"},"message":"Merge pull request #669 from okurz/fix/needledir_symlinked\n\nFix use of symlinked needle dirs from outside of basedir","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/86ca953dacf0050dbe78fb5f6849e172f5a0cb86"},{"sha":"669d679a5f65badcec3848a1485995cdcfbc8f56","author":{"email":"19b8357e2c85144ed7d7896dcd794db4045538aa@suse.com","name":"Ondrej Holecek"},"message":"Create iso, hdd, repo and other subdirs under factory","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/669d679a5f65badcec3848a1485995cdcfbc8f56"},{"sha":"95a4c0d95fc9075f0f164ac5e87b1b76a0936b1b","author":{"email":"b7203c818b59b922ac08a5cf9edea9b0763c1b16@kde.org","name":"Stephan Kulow"},"message":"Merge pull request #670 from aaannz/create_factory_subdirs\n\nCreate iso, hdd, repo and other subdirs under factory","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/95a4c0d95fc9075f0f164ac5e87b1b76a0936b1b"},{"sha":"2797bcffa5e9681db44e9d1a67eb0759aa7e85f6","author":{"email":"2b10d63485adf53bd61ddf92e433227c7a1606ba@suse.de","name":"Oliver Kurz"},"message":"Allow symlinked test and needle directory structure\n\nAs a followup to 8016a44b4d2591a50764731f38c94c58e78a69e2 this change allows\nto symlink e.g. the needle directory into the tests distribution directory\nwithin the filesystem while still not allowing to inject outside paths over\nURL requests.\n\nIt would be ok to not support this feature but 403/404 responses to needle\nimages are not properly handled in the javascript code which would leave users\nstumbled why the images don't update unless looking at server logs.","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/2797bcffa5e9681db44e9d1a67eb0759aa7e85f6"},{"sha":"e6d71629aba982a6afda91c9b4354010656e4c82","author":{"email":"19b8357e2c85144ed7d7896dcd794db4045538aa@suse.com","name":"Ondrej Holecek"},"message":"Do not allow passing unescaped quotes in admin tables\n\n- escape quotes for values\n- remove quotes for keys\n\npartly fixes gh#666","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/e6d71629aba982a6afda91c9b4354010656e4c82"},{"sha":"705c17d01f5e9f159d12ff921803d733920ff5a4","author":{"email":"614f19bfe57f7abe6a3c5d54da8899ac543a35ae@gmail.com","name":"Ondřej Holeček"},"message":"Merge pull request #671 from okurz/fix/needledir_symlinked\n\nAllow symlinked test and needle directory structure","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/705c17d01f5e9f159d12ff921803d733920ff5a4"},{"sha":"abbc9358be89f2ca858fa533d8b446ea0c3f7cc9","author":{"email":"614f19bfe57f7abe6a3c5d54da8899ac543a35ae@gmail.com","name":"Ondřej Holeček"},"message":"Merge pull request #672 from aaannz/hash_without_eval_2\n\nDo not allow passing unescaped quotes in admin tables","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/abbc9358be89f2ca858fa533d8b446ea0c3f7cc9"},{"sha":"307e7bcbef76755c3db180030b01067b4f4d34e4","author":{"email":"19b8357e2c85144ed7d7896dcd794db4045538aa@suse.com","name":"Ondrej Holecek"},"message":"HTML escape form data before showing\n\n- fix for second part of #666","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/307e7bcbef76755c3db180030b01067b4f4d34e4"},{"sha":"c50f517436ce6472bafff6e2103e08a15e497b5e","author":{"email":"b7203c818b59b922ac08a5cf9edea9b0763c1b16@kde.org","name":"Stephan Kulow"},"message":"Merge pull request #674 from aaannz/double_quotes_encoding\n\nHTML escape form data before showing","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/c50f517436ce6472bafff6e2103e08a15e497b5e"},{"sha":"24e50ee6ea7219bd1ab1bc2e0ed0086227b2cb35","author":{"email":"2b10d63485adf53bd61ddf92e433227c7a1606ba@suse.de","name":"Oliver Kurz"},"message":"t: Use helper function to wait for ajax\n\nSee d390fdc.","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/24e50ee6ea7219bd1ab1bc2e0ed0086227b2cb35"},{"sha":"66471e39e761003f6189b3b10562bb9e863ca68e","author":{"email":"614f19bfe57f7abe6a3c5d54da8899ac543a35ae@gmail.com","name":"Ondřej Holeček"},"message":"Merge pull request #675 from okurz/enhance/#674\n\nt: Use helper function to wait for ajax","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/66471e39e761003f6189b3b10562bb9e863ca68e"},{"sha":"553c19e1d70b940643fba806d39115728a504622","author":{"email":"95ee9b49749cc205668aab88b923e0766a3d03d7@suse.de","name":"Christopher Hofmann"},"message":"Extend iso post TEST parameter to support a list of tests (poo#10482)","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/553c19e1d70b940643fba806d39115728a504622"},{"sha":"b3562ee84c20d91476742f9b9bb171efc5452b66","author":{"email":"95ee9b49749cc205668aab88b923e0766a3d03d7@suse.de","name":"Christopher Hofmann"},"message":"Test for \"let TEST parameter support a list of tests\"","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/b3562ee84c20d91476742f9b9bb171efc5452b66"},{"sha":"0e444a3cb09997cfa0068be889f78a67dc9ad9c7","author":{"email":"19b8357e2c85144ed7d7896dcd794db4045538aa@suse.com","name":"Ondrej Holecek"},"message":"Enable brackets inside keys in client script\n\n- adding/modifying test_suites by client script requires user to be able\nto put keys in format 'settings[$key]=value'","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/0e444a3cb09997cfa0068be889f78a67dc9ad9c7"},{"sha":"ab245d8b7a472f30d118c24f5c45d69729f98432","author":{"email":"1401ee6f1159d15c206c33830c6f9300a3a2f15b@suse.de","name":"Marius Kittler"},"message":"Add first approach for editable comments\n\n- Comments in group overview are now editable.\n- Only the user who initially created the comment\n  is allowed to edit. To implement the possibility for\n  admins to edit comments, it would be required to\n  add additional fields to the data base.\n- Required CSS and JavaScript is in extra files. Not sure\n  where to put it.\n- Method for complete removal of comments has been implemented, too.\n  However, I'm not sure whether this feature is actually wanted.","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/ab245d8b7a472f30d118c24f5c45d69729f98432"},{"sha":"6884a0ad87016f3171ce113232e0a8e7210e850a","author":{"email":"1401ee6f1159d15c206c33830c6f9300a3a2f15b@suse.de","name":"Marius Kittler"},"message":"Make comments for tests editable, too\n\nAdditional changes: admins can remove comments\n\nstill TODO:\n- fix non-ASCII characters\n- fix indentation of \"$self->flash\"\n- show errors via \"$self->flash\"","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/6884a0ad87016f3171ce113232e0a8e7210e850a"},{"sha":"2419a1b2427a8f096b8be0929b8fc8b177f15a02","author":{"email":"1401ee6f1159d15c206c33830c6f9300a3a2f15b@suse.de","name":"Marius Kittler"},"message":"Fix indentation of flash and wells on test page","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/2419a1b2427a8f096b8be0929b8fc8b177f15a02"},{"sha":"2446f8bee2c543db6531ce3e9bb4fa3df83d56fc","author":{"email":"1401ee6f1159d15c206c33830c6f9300a3a2f15b@suse.de","name":"Marius Kittler"},"message":"Fix minor mistakes in editable comments","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/2446f8bee2c543db6531ce3e9bb4fa3df83d56fc"},{"sha":"41fa328224c8df1b3ea6d94908b7a488bfa508fc","author":{"email":"1401ee6f1159d15c206c33830c6f9300a3a2f15b@suse.de","name":"Marius Kittler"},"message":"Reduce code-dublication in templates\n\nMoved redundand code for comment rows and the \"add comment\" form controls\nto templates/comments/{comment_row,add_comment_form_groups}.html.ep.","distinct":true,"url":"https://api.github.com/repos/AdamWill/openQA/commits/41fa328224c8df1b3ea6d94908b7a488bfa508fc"}]}