{"action":"created","comment":{"url":"https://api.github.com/repos/ocf/utils/pulls/comments/88333176","pull_request_review_id":8910555,"id":88333176,"diff_hunk":"@@ -66,12 +66,12 @@ def main():\n         )\n         for attrs in map(itemgetter('attributes'), c.response):\n             cn = attrs['cn'][0]\n-            type_ = attrs['type'][0]\n+            type_ = attrs['type']\n \n             if type_ not in RECOGNIZED_TYPES:\n                 complain(cn, 'has unknown type ' + type_)\n \n-            if 'macAddress' in attrs:\n+            if attrs.get('macaddress', []):","path":"staff/sys/ldap-lint","position":null,"original_position":11,"commit_id":"b0af403532f029e775c8ac3432cfaf5b73f623fd","original_commit_id":"41e017cc4a84b8d137f4c02571fc7fbcf04a8159","user":{"login":"jvperrin","id":1523594,"avatar_url":"https://avatars.githubusercontent.com/u/1523594?v=3","gravatar_id":"","url":"https://api.github.com/users/jvperrin","html_url":"https://github.com/jvperrin","followers_url":"https://api.github.com/users/jvperrin/followers","following_url":"https://api.github.com/users/jvperrin/following{/other_user}","gists_url":"https://api.github.com/users/jvperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/jvperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvperrin/subscriptions","organizations_url":"https://api.github.com/users/jvperrin/orgs","repos_url":"https://api.github.com/users/jvperrin/repos","events_url":"https://api.github.com/users/jvperrin/events{/privacy}","received_events_url":"https://api.github.com/users/jvperrin/received_events","type":"User","site_admin":false},"body":"`ldap-lint` will have to be updated too, since it uses ocflib and there are breaking changes with the upgrade.","created_at":"2016-11-16T21:20:40Z","updated_at":"2016-11-16T21:20:40Z","html_url":"https://github.com/ocf/utils/pull/23#discussion_r88333176","pull_request_url":"https://api.github.com/repos/ocf/utils/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/ocf/utils/pulls/comments/88333176"},"html":{"href":"https://github.com/ocf/utils/pull/23#discussion_r88333176"},"pull_request":{"href":"https://api.github.com/repos/ocf/utils/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/ocf/utils/pulls/23","id":94046130,"html_url":"https://github.com/ocf/utils/pull/23","diff_url":"https://github.com/ocf/utils/pull/23.diff","patch_url":"https://github.com/ocf/utils/pull/23.patch","issue_url":"https://api.github.com/repos/ocf/utils/issues/23","number":23,"state":"open","locked":false,"title":"Fix compatibility with ldap3 version 2","user":{"login":"matthew-mcallister","id":6722367,"avatar_url":"https://avatars.githubusercontent.com/u/6722367?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-mcallister","html_url":"https://github.com/matthew-mcallister","followers_url":"https://api.github.com/users/matthew-mcallister/followers","following_url":"https://api.github.com/users/matthew-mcallister/following{/other_user}","gists_url":"https://api.github.com/users/matthew-mcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-mcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-mcallister/subscriptions","organizations_url":"https://api.github.com/users/matthew-mcallister/orgs","repos_url":"https://api.github.com/users/matthew-mcallister/repos","events_url":"https://api.github.com/users/matthew-mcallister/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-mcallister/received_events","type":"User","site_admin":false},"body":"See https://github.com/ocf/ocflib/pull/38.","created_at":"2016-11-16T20:44:06Z","updated_at":"2016-11-16T21:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176e5fdcef342e8233800d2e3c3d5d0cec208881","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocf/utils/pulls/23/commits","review_comments_url":"https://api.github.com/repos/ocf/utils/pulls/23/comments","review_comment_url":"https://api.github.com/repos/ocf/utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocf/utils/issues/23/comments","statuses_url":"https://api.github.com/repos/ocf/utils/statuses/b0af403532f029e775c8ac3432cfaf5b73f623fd","head":{"label":"matthew-mcallister:ocflib-ldap3-v2","ref":"ocflib-ldap3-v2","sha":"b0af403532f029e775c8ac3432cfaf5b73f623fd","user":{"login":"matthew-mcallister","id":6722367,"avatar_url":"https://avatars.githubusercontent.com/u/6722367?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-mcallister","html_url":"https://github.com/matthew-mcallister","followers_url":"https://api.github.com/users/matthew-mcallister/followers","following_url":"https://api.github.com/users/matthew-mcallister/following{/other_user}","gists_url":"https://api.github.com/users/matthew-mcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-mcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-mcallister/subscriptions","organizations_url":"https://api.github.com/users/matthew-mcallister/orgs","repos_url":"https://api.github.com/users/matthew-mcallister/repos","events_url":"https://api.github.com/users/matthew-mcallister/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-mcallister/received_events","type":"User","site_admin":false},"repo":{"id":45167899,"name":"utils","full_name":"matthew-mcallister/utils","owner":{"login":"matthew-mcallister","id":6722367,"avatar_url":"https://avatars.githubusercontent.com/u/6722367?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-mcallister","html_url":"https://github.com/matthew-mcallister","followers_url":"https://api.github.com/users/matthew-mcallister/followers","following_url":"https://api.github.com/users/matthew-mcallister/following{/other_user}","gists_url":"https://api.github.com/users/matthew-mcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-mcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-mcallister/subscriptions","organizations_url":"https://api.github.com/users/matthew-mcallister/orgs","repos_url":"https://api.github.com/users/matthew-mcallister/repos","events_url":"https://api.github.com/users/matthew-mcallister/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-mcallister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthew-mcallister/utils","description":"User and staff utilities for the Open Computing Facility","fork":true,"url":"https://api.github.com/repos/matthew-mcallister/utils","forks_url":"https://api.github.com/repos/matthew-mcallister/utils/forks","keys_url":"https://api.github.com/repos/matthew-mcallister/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthew-mcallister/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthew-mcallister/utils/teams","hooks_url":"https://api.github.com/repos/matthew-mcallister/utils/hooks","issue_events_url":"https://api.github.com/repos/matthew-mcallister/utils/issues/events{/number}","events_url":"https://api.github.com/repos/matthew-mcallister/utils/events","assignees_url":"https://api.github.com/repos/matthew-mcallister/utils/assignees{/user}","branches_url":"https://api.github.com/repos/matthew-mcallister/utils/branches{/branch}","tags_url":"https://api.github.com/repos/matthew-mcallister/utils/tags","blobs_url":"https://api.github.com/repos/matthew-mcallister/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthew-mcallister/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthew-mcallister/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthew-mcallister/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthew-mcallister/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/matthew-mcallister/utils/languages","stargazers_url":"https://api.github.com/repos/matthew-mcallister/utils/stargazers","contributors_url":"https://api.github.com/repos/matthew-mcallister/utils/contributors","subscribers_url":"https://api.github.com/repos/matthew-mcallister/utils/subscribers","subscription_url":"https://api.github.com/repos/matthew-mcallister/utils/subscription","commits_url":"https://api.github.com/repos/matthew-mcallister/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthew-mcallister/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthew-mcallister/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthew-mcallister/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthew-mcallister/utils/contents/{+path}","compare_url":"https://api.github.com/repos/matthew-mcallister/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthew-mcallister/utils/merges","archive_url":"https://api.github.com/repos/matthew-mcallister/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthew-mcallister/utils/downloads","issues_url":"https://api.github.com/repos/matthew-mcallister/utils/issues{/number}","pulls_url":"https://api.github.com/repos/matthew-mcallister/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/matthew-mcallister/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/matthew-mcallister/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthew-mcallister/utils/labels{/name}","releases_url":"https://api.github.com/repos/matthew-mcallister/utils/releases{/id}","deployments_url":"https://api.github.com/repos/matthew-mcallister/utils/deployments","created_at":"2015-10-29T07:42:23Z","updated_at":"2016-02-28T10:02:08Z","pushed_at":"2016-11-16T21:15:44Z","git_url":"git://github.com/matthew-mcallister/utils.git","ssh_url":"git@github.com:matthew-mcallister/utils.git","clone_url":"https://github.com/matthew-mcallister/utils.git","svn_url":"https://github.com/matthew-mcallister/utils","homepage":"https://www.ocf.berkeley.edu/","size":223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocf:master","ref":"master","sha":"fa6a40337458f4a63b44bcb4b766a58f3a9b77b8","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":20369692,"name":"utils","full_name":"ocf/utils","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/utils","description":"User and staff utilities for the Open Computing Facility","fork":false,"url":"https://api.github.com/repos/ocf/utils","forks_url":"https://api.github.com/repos/ocf/utils/forks","keys_url":"https://api.github.com/repos/ocf/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/utils/teams","hooks_url":"https://api.github.com/repos/ocf/utils/hooks","issue_events_url":"https://api.github.com/repos/ocf/utils/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/utils/events","assignees_url":"https://api.github.com/repos/ocf/utils/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/utils/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/utils/tags","blobs_url":"https://api.github.com/repos/ocf/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/utils/languages","stargazers_url":"https://api.github.com/repos/ocf/utils/stargazers","contributors_url":"https://api.github.com/repos/ocf/utils/contributors","subscribers_url":"https://api.github.com/repos/ocf/utils/subscribers","subscription_url":"https://api.github.com/repos/ocf/utils/subscription","commits_url":"https://api.github.com/repos/ocf/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/utils/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/utils/merges","archive_url":"https://api.github.com/repos/ocf/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/utils/downloads","issues_url":"https://api.github.com/repos/ocf/utils/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/utils/labels{/name}","releases_url":"https://api.github.com/repos/ocf/utils/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/utils/deployments","created_at":"2014-06-01T02:50:07Z","updated_at":"2016-10-23T04:45:37Z","pushed_at":"2016-11-16T21:15:44Z","git_url":"git://github.com/ocf/utils.git","ssh_url":"git@github.com:ocf/utils.git","clone_url":"https://github.com/ocf/utils.git","svn_url":"https://github.com/ocf/utils","homepage":"https://www.ocf.berkeley.edu/","size":321,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocf/utils/pulls/23"},"html":{"href":"https://github.com/ocf/utils/pull/23"},"issue":{"href":"https://api.github.com/repos/ocf/utils/issues/23"},"comments":{"href":"https://api.github.com/repos/ocf/utils/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/ocf/utils/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/ocf/utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocf/utils/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/ocf/utils/statuses/b0af403532f029e775c8ac3432cfaf5b73f623fd"}}}}
{"actor":{"display_login":"jvperrin"}}