{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/22664","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/22664/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/22664/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/22664/events","html_url":"https://github.com/owncloud/core/pull/22664","id":136556398,"number":22664,"title":"ldap group membership background job should also throw pre_addToGroup…","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/app:user_ldap","name":"app:user_ldap","color":"02d7e1"},{"url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9"},{"url":"https://api.github.com/repos/owncloud/core/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-current","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":1715,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2016-02-26T20:01:48Z","due_on":"2016-03-08T04:00:00Z","closed_at":null},"comments":2,"created_at":"2016-02-26T00:27:45Z","updated_at":"2016-02-26T20:01:48Z","closed_at":"2016-02-26T20:01:48Z","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/22664","html_url":"https://github.com/owncloud/core/pull/22664","diff_url":"https://github.com/owncloud/core/pull/22664.diff","patch_url":"https://github.com/owncloud/core/pull/22664.patch"},"body":"…, because sharing listens to it. Fixes #21986.\r\n\r\nReason for this PR is https://github.com/owncloud/core/pull/21854#issuecomment-174198467, however looking at the code, this hook should have been fired before. Nevertheless, sharing worked. Now I wonder whether this is really needed, but I still guess so.\r\n\r\nAs brief excursion: At some time in the past sharing listened to addToGroup and RemoveFromGroup hooks for updating the shares. Because with LDAP we do not when a member is added or removed from a group, we have a background job that updates the members and throws hooks, if necessary.\r\n\r\n@schiesbn @MorrisJobke @rullzer what do you think?"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/189458101","html_url":"https://github.com/owncloud/core/pull/22664#issuecomment-189458101","issue_url":"https://api.github.com/repos/owncloud/core/issues/22664","id":189458101,"user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T20:01:48Z","updated_at":"2016-02-26T20:01:48Z","body":"```\r\n<Blizzz> BeS: i.e. #22664 is unnecessry?\r\n<Blizzz> less code, better.\r\n<BeS> Blizzz: yes, it is probably not unnecessry. But please double-check\r\n<BeS> 1. share a file test.txt with a group\r\n<BeS> 2. create a file text.txt for a user who is not in the group\r\n<BeS> 3. add the user to the group\r\n<BeS> 4 login as the user and check the the group share is mounted as test.txt (2)\r\n<Blizzz> BeS: I will try this, thx.\r\n```\r\n\r\n→ Tested, works without this PR, thus closing."}}