{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/67551296","id":67551296,"diff_hunk":"@@ -48,19 +48,15 @@ trait NIHService extends HttpService with PerRequestCreator with FireCloudDirect\n                 val lastLinkTime = DateUtils.now\n                 val linkExpireTime = DateUtils.nowPlus30Days\n \n-                // update this user's dbGaP access in rawls, assuming the user exists in the whitelist.\n-                // this call is silent/async - if it fails, we continue on, and the user's access will\n-                // be updated the next time sync_whitelist runs; the user will have to wait for that.\n-                val groupUpdate = perRequest(requestContext, Props(new ProfileClientActor(requestContext)),\n-                  ProfileClient.SyncSelf(userInfo))\n-","path":"src/main/scala/org/broadinstitute/dsde/firecloud/service/NIHService.scala","position":9,"original_position":9,"commit_id":"34d570543d061afebb170c3f6cbb79f765427c3d","original_commit_id":"34d570543d061afebb170c3f6cbb79f765427c3d","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"In the original code, this is one of two PerRequests are fired off. Whichever one finishes first is the one that the client receives.","created_at":"2016-06-17T18:01:36Z","updated_at":"2016-06-17T18:01:36Z","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/225#discussion_r67551296","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/67551296"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/225#discussion_r67551296"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225","id":74280023,"html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/225","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/225.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/225.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/225","number":225,"state":"open","locked":false,"title":"Update nih link callback to be a better per-request citizen","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"Addresses https://broadinstitute.atlassian.net/browse/GAWB-695\r\nThis has a companion PR in UI: https://github.com/broadinstitute/firecloud-ui/pull/456\r\n\r\nThe intention of this PR is to fix the nih link callback so that it does the white-list sync *and then* handles the update in Thurloe for the user's nih profile information. \r\n\r\nTesting:\r\n* See companion PR in UI\r\n* There is a branch not in dev at the moment for handling a mock NIH link endpoint. See #223 for that. This PR needs #223 for the UI piece to work correctly.\r\n* To ensure that the NIH linking response is the one that is actually returned by the ProfileClient, you can add \r\nsome custom content to the returned callback response in ProfileClient, line 102: `case true => Future(RequestComplete(OK))` and see that in the network panel from the UI call.\r\n\r\n=========================\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] **Submitter**: Tell tech lead that the PR exists if s/he wants to look at it\r\n- [ ] **Submitter**: Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [ ] **LR**: Initial review by LR and others.\r\n- [ ] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] **Tech lead**:  sign off\r\n- [ ] **LR**: sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev server still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n","created_at":"2016-06-17T17:48:05Z","updated_at":"2016-06-17T18:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaffa2149026ba4de761f28eec38c4467db0b119","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/225/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/34d570543d061afebb170c3f6cbb79f765427c3d","head":{"label":"broadinstitute:gr-GAWB-695-link-nih","ref":"gr-GAWB-695-link-nih","sha":"34d570543d061afebb170c3f6cbb79f765427c3d","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-03-30T19:04:01Z","pushed_at":"2016-06-17T17:48:05Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":666,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":6,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"575acf8282266df6094d1d3a63472f6e9400460e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-03-30T19:04:01Z","pushed_at":"2016-06-17T17:48:05Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":666,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/225"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/225"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/34d570543d061afebb170c3f6cbb79f765427c3d"}}}}
{"actor":{"display_login":"rushtong"}}