{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/comments/87936414","pull_request_review_id":8526385,"id":87936414,"diff_hunk":"@@ -0,0 +1,63 @@\n+package journal2cri\n+\n+import (\n+\t\"fmt\"\n+\t\"testing\"\n+\t\"time\"\n+\n+\t\"github.com/coreos/go-systemd/sdjournal\"\n+\t\"github.com/stretchr/testify/assert\"\n+)\n+\n+func TestProcessEntry(t *testing.T) {\n+\tnow := time.Unix(0xbad, 0xfacade)\n+\tnow = now.Round(time.Millisecond) // since the nanosecond part of now will break assertions","path":"journal2cri/journal2cri/journal2cri_test.go","position":14,"original_position":14,"commit_id":"31d16359521fe020b5a8007cf4214e0b7600933c","original_commit_id":"73b73b393ef3879098234dd965cfba7dcb262b87","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"why not just round with `time.Microsecond`?","created_at":"2016-11-15T02:13:25Z","updated_at":"2016-11-15T02:13:25Z","html_url":"https://github.com/kubernetes-incubator/rktlet/pull/58#discussion_r87936414","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/comments/87936414"},"html":{"href":"https://github.com/kubernetes-incubator/rktlet/pull/58#discussion_r87936414"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58","id":93490935,"html_url":"https://github.com/kubernetes-incubator/rktlet/pull/58","diff_url":"https://github.com/kubernetes-incubator/rktlet/pull/58.diff","patch_url":"https://github.com/kubernetes-incubator/rktlet/pull/58.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/58","number":58,"state":"open","locked":false,"title":"journal2cri: initial code for logging workaround","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"This commit adds a new program that can be given a pod's journal directory + a output directory and will then make CRI logstuff happen.\r\n\r\nI manually tested that injecting it into a running pod with a bindmount to the `/var/log/....` symlink rkt creates + an additional bindmount for an output directory worked as I expected.\r\n\r\nHow I envision this being used is as a \"helper\" or \"internal\" app that gets added to every pod at the beginning by rktlet code during pod sandbox creation (and then is masked in all api calls from the kubelet, but lives for the full lifecycle of the pod).\r\n\r\nThe TODOs for this are mostly just packaging it as a docker image or ACI for inclusion in the pod, and then actually writing the code to add/start it.\r\nI could also add better testing in the form of test_data with an actual journal file, but this code shouldn't exist for that long anyways so I think the existing unit test coverage is okay.\r\n\r\ncc @lucab @squeed ","created_at":"2016-11-13T22:58:23Z","updated_at":"2016-11-15T02:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b089ac6b7456620b690260c59872b23bf18c4ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/58/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/statuses/31d16359521fe020b5a8007cf4214e0b7600933c","head":{"label":"euank:log-hack","ref":"log-hack","sha":"31d16359521fe020b5a8007cf4214e0b7600933c","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"repo":{"id":65413501,"name":"rktlet","full_name":"euank/rktlet","owner":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euank/rktlet","description":"The rkt implemntation of a Kubernetes Container Runtime","fork":true,"url":"https://api.github.com/repos/euank/rktlet","forks_url":"https://api.github.com/repos/euank/rktlet/forks","keys_url":"https://api.github.com/repos/euank/rktlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euank/rktlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euank/rktlet/teams","hooks_url":"https://api.github.com/repos/euank/rktlet/hooks","issue_events_url":"https://api.github.com/repos/euank/rktlet/issues/events{/number}","events_url":"https://api.github.com/repos/euank/rktlet/events","assignees_url":"https://api.github.com/repos/euank/rktlet/assignees{/user}","branches_url":"https://api.github.com/repos/euank/rktlet/branches{/branch}","tags_url":"https://api.github.com/repos/euank/rktlet/tags","blobs_url":"https://api.github.com/repos/euank/rktlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euank/rktlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euank/rktlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/euank/rktlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euank/rktlet/statuses/{sha}","languages_url":"https://api.github.com/repos/euank/rktlet/languages","stargazers_url":"https://api.github.com/repos/euank/rktlet/stargazers","contributors_url":"https://api.github.com/repos/euank/rktlet/contributors","subscribers_url":"https://api.github.com/repos/euank/rktlet/subscribers","subscription_url":"https://api.github.com/repos/euank/rktlet/subscription","commits_url":"https://api.github.com/repos/euank/rktlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/euank/rktlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/euank/rktlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/euank/rktlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/euank/rktlet/contents/{+path}","compare_url":"https://api.github.com/repos/euank/rktlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euank/rktlet/merges","archive_url":"https://api.github.com/repos/euank/rktlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euank/rktlet/downloads","issues_url":"https://api.github.com/repos/euank/rktlet/issues{/number}","pulls_url":"https://api.github.com/repos/euank/rktlet/pulls{/number}","milestones_url":"https://api.github.com/repos/euank/rktlet/milestones{/number}","notifications_url":"https://api.github.com/repos/euank/rktlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euank/rktlet/labels{/name}","releases_url":"https://api.github.com/repos/euank/rktlet/releases{/id}","deployments_url":"https://api.github.com/repos/euank/rktlet/deployments","created_at":"2016-08-10T20:16:02Z","updated_at":"2016-09-28T22:41:22Z","pushed_at":"2016-11-15T02:12:59Z","git_url":"git://github.com/euank/rktlet.git","ssh_url":"git@github.com:euank/rktlet.git","clone_url":"https://github.com/euank/rktlet.git","svn_url":"https://github.com/euank/rktlet","homepage":null,"size":40089,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"5703088f70604b0c0d870debce400bdacd63cc8c","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":65413483,"name":"rktlet","full_name":"kubernetes-incubator/rktlet","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/rktlet","description":"The rkt implementation of a Kubernetes Container Runtime","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/rktlet","forks_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/rktlet/deployments","created_at":"2016-08-10T20:15:40Z","updated_at":"2016-11-09T17:34:50Z","pushed_at":"2016-11-15T02:12:59Z","git_url":"git://github.com/kubernetes-incubator/rktlet.git","ssh_url":"git@github.com:kubernetes-incubator/rktlet.git","clone_url":"https://github.com/kubernetes-incubator/rktlet.git","svn_url":"https://github.com/kubernetes-incubator/rktlet","homepage":"","size":39729,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58"},"html":{"href":"https://github.com/kubernetes-incubator/rktlet/pull/58"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/58"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/rktlet/statuses/31d16359521fe020b5a8007cf4214e0b7600933c"}}}}
{"actor":{"display_login":"yifan-gu"}}