{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/13286","repository_url":"https://api.github.com/repos/angular/angular.js","labels_url":"https://api.github.com/repos/angular/angular.js/issues/13286/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/13286/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/13286/events","html_url":"https://github.com/angular/angular.js/pull/13286","id":116062181,"number":13286,"title":"perf(ngModel,ngForm): change ng-model/form controllers to use prototype methods","user":{"login":"jbedard","id":89246,"avatar_url":"https://avatars.githubusercontent.com/u/89246?v=3","gravatar_id":"","url":"https://api.github.com/users/jbedard","html_url":"https://github.com/jbedard","followers_url":"https://api.github.com/users/jbedard/followers","following_url":"https://api.github.com/users/jbedard/following{/other_user}","gists_url":"https://api.github.com/users/jbedard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbedard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbedard/subscriptions","organizations_url":"https://api.github.com/users/jbedard/orgs","repos_url":"https://api.github.com/users/jbedard/repos","events_url":"https://api.github.com/users/jbedard/events{/privacy}","received_events_url":"https://api.github.com/users/jbedard/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20forms","name":"component: forms","color":"7B947B"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20breaking%20change","name":"needs: breaking change","color":"e11d21"},{"url":"https://api.github.com/repos/angular/angular.js/labels/type:%20perf","name":"type: perf","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/105","html_url":"https://github.com/angular/angular.js/milestones/1.6.x","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/105/labels","id":1317216,"number":105,"title":"1.6.x","description":null,"creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":41,"state":"open","created_at":"2015-09-21T20:16:38Z","updated_at":"2016-08-26T16:36:23Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-11-10T08:40:30Z","updated_at":"2016-08-28T14:05:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/13286","html_url":"https://github.com/angular/angular.js/pull/13286","diff_url":"https://github.com/angular/angular.js/pull/13286.diff","patch_url":"https://github.com/angular/angular.js/pull/13286.patch"},"body":"This makes the largetable-bp ng-model benchmarks 10-15% faster (down 90-100ms for me). The actual controller instantiation doesn't change too much but the overall numbers seem consistently faster, I assume all due to reducing memory usage / gc. Specifically on creation there is ~40% less memory GCed, on destruction there is about ~25% less.\r\n\r\nLooking at the heap snapshot this is entirely from having less closures (~70k => 30k closures), other counts are all equal or very close.\r\n\r\nLooking at the chrome timeline the number of GC events is about half and the time/gc amounts roughly match the benchpress measurements.\r\n\r\nWorth the breaking change? The diff can probably be reduced or split into 2 commits if there's interest..."},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/242976622","html_url":"https://github.com/angular/angular.js/pull/13286#issuecomment-242976622","issue_url":"https://api.github.com/repos/angular/angular.js/issues/13286","id":242976622,"user":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T14:05:06Z","updated_at":"2016-08-28T14:05:06Z","body":"@jbedard I think we should merge it. You've never responded to https://github.com/angular/angular.js/pull/13286#discussion_r44686627, do you know what @lgalfaso means by this?\r\n\r\n@dcherman How can we log something in the unminfied build and have it removed in the minified buld? Can we use the Closure compiler for this?"}}
{"actor":{"display_login":"Narretz"}}