{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/perwendel/spark/pulls/185","id":19888795,"html_url":"https://github.com/perwendel/spark/pull/185","diff_url":"https://github.com/perwendel/spark/pull/185.diff","patch_url":"https://github.com/perwendel/spark/pull/185.patch","issue_url":"https://api.github.com/repos/perwendel/spark/issues/185","number":185,"state":"closed","locked":false,"title":"Make it possible to use Spark 2 with Java 7 again","user":{"login":"kroepke","id":52014,"avatar_url":"https://avatars.githubusercontent.com/u/52014?v=3","gravatar_id":"","url":"https://api.github.com/users/kroepke","html_url":"https://github.com/kroepke","followers_url":"https://api.github.com/users/kroepke/followers","following_url":"https://api.github.com/users/kroepke/following{/other_user}","gists_url":"https://api.github.com/users/kroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/kroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroepke/subscriptions","organizations_url":"https://api.github.com/users/kroepke/orgs","repos_url":"https://api.github.com/users/kroepke/repos","events_url":"https://api.github.com/users/kroepke/events{/privacy}","received_events_url":"https://api.github.com/users/kroepke/received_events","type":"User","site_admin":false},"body":"My projects cannot go to Java 8 yet, but still I would like to use Spark 2 as I believe Spark 1.1 will no longer see updates.\r\nThe changes necessary to make it compatible are trivial, without affecting the ability to use Lambdas in Java 8 code.\r\nPlease have a look at it, I'd be happy to donate the changes, but I realize that this change affects the setup significantly.\r\n\r\nCommit message below:\r\n\r\nmove tests to a separate module to be able to run it with a different language level within IDEA\r\n - com.sparkjava:tests runs on java 8 to make use of lambdas\r\n - IDEA does not support different language levels for code and tests, so it has to be in separate modules\r\n\r\nchanges to spark-core are trivial, just making some variables final as per Java7 requirements","created_at":"2014-08-17T11:57:24Z","updated_at":"2016-05-08T18:28:48Z","closed_at":"2016-05-08T18:28:48Z","merged_at":null,"merge_commit_sha":"efc86a13f30aaceaf7e6c6f6a07883f0bf7a09e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/perwendel/spark/pulls/185/commits","review_comments_url":"https://api.github.com/repos/perwendel/spark/pulls/185/comments","review_comment_url":"https://api.github.com/repos/perwendel/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/perwendel/spark/issues/185/comments","statuses_url":"https://api.github.com/repos/perwendel/spark/statuses/e4a2e5df7ad7a309f1f9d60b977813c1510a8d09","head":{"label":"kroepke:master","ref":"master","sha":"e4a2e5df7ad7a309f1f9d60b977813c1510a8d09","user":{"login":"kroepke","id":52014,"avatar_url":"https://avatars.githubusercontent.com/u/52014?v=3","gravatar_id":"","url":"https://api.github.com/users/kroepke","html_url":"https://github.com/kroepke","followers_url":"https://api.github.com/users/kroepke/followers","following_url":"https://api.github.com/users/kroepke/following{/other_user}","gists_url":"https://api.github.com/users/kroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/kroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroepke/subscriptions","organizations_url":"https://api.github.com/users/kroepke/orgs","repos_url":"https://api.github.com/users/kroepke/repos","events_url":"https://api.github.com/users/kroepke/events{/privacy}","received_events_url":"https://api.github.com/users/kroepke/received_events","type":"User","site_admin":false},"repo":{"id":23037529,"name":"spark","full_name":"kroepke/spark","owner":{"login":"kroepke","id":52014,"avatar_url":"https://avatars.githubusercontent.com/u/52014?v=3","gravatar_id":"","url":"https://api.github.com/users/kroepke","html_url":"https://github.com/kroepke","followers_url":"https://api.github.com/users/kroepke/followers","following_url":"https://api.github.com/users/kroepke/following{/other_user}","gists_url":"https://api.github.com/users/kroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/kroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroepke/subscriptions","organizations_url":"https://api.github.com/users/kroepke/orgs","repos_url":"https://api.github.com/users/kroepke/repos","events_url":"https://api.github.com/users/kroepke/events{/privacy}","received_events_url":"https://api.github.com/users/kroepke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kroepke/spark","description":"A Sinatra inspired framework for java","fork":true,"url":"https://api.github.com/repos/kroepke/spark","forks_url":"https://api.github.com/repos/kroepke/spark/forks","keys_url":"https://api.github.com/repos/kroepke/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kroepke/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kroepke/spark/teams","hooks_url":"https://api.github.com/repos/kroepke/spark/hooks","issue_events_url":"https://api.github.com/repos/kroepke/spark/issues/events{/number}","events_url":"https://api.github.com/repos/kroepke/spark/events","assignees_url":"https://api.github.com/repos/kroepke/spark/assignees{/user}","branches_url":"https://api.github.com/repos/kroepke/spark/branches{/branch}","tags_url":"https://api.github.com/repos/kroepke/spark/tags","blobs_url":"https://api.github.com/repos/kroepke/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kroepke/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kroepke/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/kroepke/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kroepke/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/kroepke/spark/languages","stargazers_url":"https://api.github.com/repos/kroepke/spark/stargazers","contributors_url":"https://api.github.com/repos/kroepke/spark/contributors","subscribers_url":"https://api.github.com/repos/kroepke/spark/subscribers","subscription_url":"https://api.github.com/repos/kroepke/spark/subscription","commits_url":"https://api.github.com/repos/kroepke/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/kroepke/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/kroepke/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/kroepke/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/kroepke/spark/contents/{+path}","compare_url":"https://api.github.com/repos/kroepke/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kroepke/spark/merges","archive_url":"https://api.github.com/repos/kroepke/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kroepke/spark/downloads","issues_url":"https://api.github.com/repos/kroepke/spark/issues{/number}","pulls_url":"https://api.github.com/repos/kroepke/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/kroepke/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/kroepke/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kroepke/spark/labels{/name}","releases_url":"https://api.github.com/repos/kroepke/spark/releases{/id}","deployments_url":"https://api.github.com/repos/kroepke/spark/deployments","created_at":"2014-08-17T09:43:56Z","updated_at":"2014-11-11T22:13:12Z","pushed_at":"2014-08-17T11:55:22Z","git_url":"git://github.com/kroepke/spark.git","ssh_url":"git@github.com:kroepke/spark.git","clone_url":"https://github.com/kroepke/spark.git","svn_url":"https://github.com/kroepke/spark","homepage":"","size":1477,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"perwendel:master","ref":"master","sha":"1ecd428c8e2e5b0d1b8f221e9bf9e82429bd73bb","user":{"login":"perwendel","id":741279,"avatar_url":"https://avatars.githubusercontent.com/u/741279?v=3","gravatar_id":"","url":"https://api.github.com/users/perwendel","html_url":"https://github.com/perwendel","followers_url":"https://api.github.com/users/perwendel/followers","following_url":"https://api.github.com/users/perwendel/following{/other_user}","gists_url":"https://api.github.com/users/perwendel/gists{/gist_id}","starred_url":"https://api.github.com/users/perwendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perwendel/subscriptions","organizations_url":"https://api.github.com/users/perwendel/orgs","repos_url":"https://api.github.com/users/perwendel/repos","events_url":"https://api.github.com/users/perwendel/events{/privacy}","received_events_url":"https://api.github.com/users/perwendel/received_events","type":"User","site_admin":false},"repo":{"id":1705960,"name":"spark","full_name":"perwendel/spark","owner":{"login":"perwendel","id":741279,"avatar_url":"https://avatars.githubusercontent.com/u/741279?v=3","gravatar_id":"","url":"https://api.github.com/users/perwendel","html_url":"https://github.com/perwendel","followers_url":"https://api.github.com/users/perwendel/followers","following_url":"https://api.github.com/users/perwendel/following{/other_user}","gists_url":"https://api.github.com/users/perwendel/gists{/gist_id}","starred_url":"https://api.github.com/users/perwendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perwendel/subscriptions","organizations_url":"https://api.github.com/users/perwendel/orgs","repos_url":"https://api.github.com/users/perwendel/repos","events_url":"https://api.github.com/users/perwendel/events{/privacy}","received_events_url":"https://api.github.com/users/perwendel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/perwendel/spark","description":"A Sinatra inspired framework for java","fork":false,"url":"https://api.github.com/repos/perwendel/spark","forks_url":"https://api.github.com/repos/perwendel/spark/forks","keys_url":"https://api.github.com/repos/perwendel/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perwendel/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perwendel/spark/teams","hooks_url":"https://api.github.com/repos/perwendel/spark/hooks","issue_events_url":"https://api.github.com/repos/perwendel/spark/issues/events{/number}","events_url":"https://api.github.com/repos/perwendel/spark/events","assignees_url":"https://api.github.com/repos/perwendel/spark/assignees{/user}","branches_url":"https://api.github.com/repos/perwendel/spark/branches{/branch}","tags_url":"https://api.github.com/repos/perwendel/spark/tags","blobs_url":"https://api.github.com/repos/perwendel/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perwendel/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perwendel/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/perwendel/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perwendel/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/perwendel/spark/languages","stargazers_url":"https://api.github.com/repos/perwendel/spark/stargazers","contributors_url":"https://api.github.com/repos/perwendel/spark/contributors","subscribers_url":"https://api.github.com/repos/perwendel/spark/subscribers","subscription_url":"https://api.github.com/repos/perwendel/spark/subscription","commits_url":"https://api.github.com/repos/perwendel/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/perwendel/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/perwendel/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/perwendel/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/perwendel/spark/contents/{+path}","compare_url":"https://api.github.com/repos/perwendel/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perwendel/spark/merges","archive_url":"https://api.github.com/repos/perwendel/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perwendel/spark/downloads","issues_url":"https://api.github.com/repos/perwendel/spark/issues{/number}","pulls_url":"https://api.github.com/repos/perwendel/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/perwendel/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/perwendel/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perwendel/spark/labels{/name}","releases_url":"https://api.github.com/repos/perwendel/spark/releases{/id}","deployments_url":"https://api.github.com/repos/perwendel/spark/deployments","created_at":"2011-05-05T11:52:05Z","updated_at":"2016-05-08T14:28:40Z","pushed_at":"2016-05-08T18:12:55Z","git_url":"git://github.com/perwendel/spark.git","ssh_url":"git@github.com:perwendel/spark.git","clone_url":"https://github.com/perwendel/spark.git","svn_url":"https://github.com/perwendel/spark","homepage":"","size":3699,"stargazers_count":4101,"watchers_count":4101,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":862,"mirror_url":null,"open_issues_count":133,"forks":862,"open_issues":133,"watchers":4101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/perwendel/spark/pulls/185"},"html":{"href":"https://github.com/perwendel/spark/pull/185"},"issue":{"href":"https://api.github.com/repos/perwendel/spark/issues/185"},"comments":{"href":"https://api.github.com/repos/perwendel/spark/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/perwendel/spark/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/perwendel/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/perwendel/spark/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/perwendel/spark/statuses/e4a2e5df7ad7a309f1f9d60b977813c1510a8d09"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":13,"review_comments":0,"commits":2,"additions":289,"deletions":104,"changed_files":97}}